Re: [VOTE] Release Apache DataFusion Comet 0.1.0 RC2
+1 (binding) I verified it on a m3 mac I noted the changelog link in your email [3] gives me a 404. I think the right link may be [1] Thanks, Andrew [1]: https://github.com/apache/datafusion-comet/blob/df980bf67e59f439521b90dd2139c6a8d706c0bc/dev/changelog/0.1.0.md [3]: https://github.com/apache/datafusion-comet/blob/df980bf67e59f439521b90dd2139c6a8d706c0bc/CHANGELOG.md On Sat, Jul 20, 2024 at 6:36 PM Edmondo Porcu wrote: > +1 (non-binding) > > Verified on M2 Mac. > > Ed > > Il giorno sab 20 lug 2024 alle ore 18:22 huaxin gao < > huaxin.ga...@gmail.com> > ha scritto: > > > +1 (non-binding) > > > > Verified on M2 Mac. > > > > Thanks Andy. > > > > On Sat, Jul 20, 2024 at 2:13 PM L. C. Hsieh wrote: > > > > > +1 (binding) > > > > > > Verified on M3 Mac. > > > > > > Thanks Andy. > > > > > > On Sat, Jul 20, 2024 at 1:57 PM Andy Grove > > > > > > wrote: > > > > > > > > Hi, > > > > > > > > I would like to propose a release of Apache DataFusion Comet version > > > 0.1.0. > > > > > > > > This release candidate is based on commit: > > > df980bf67e59f439521b90dd2139c6a8d706c0bc [1] > > > > The proposed release tarball and signatures are hosted at [2]. > > > > The changelog is located at [3]. > > > > > > > > Please download, verify checksums and signatures, run the unit tests, > > > and vote > > > > on the release. The vote will be open for at least 72 hours. > > > > > > > > Only votes from PMC members are binding, but all members of the > > > community are > > > > encouraged to test the release and vote with "(non-binding)". > > > > > > > > The standard verification procedure is documented at > > > > > > https://github.com/apache/datafusion-comet/blob/main/dev/release/verifying-release-candidates.md > > > > > > > > [ ] +1 Release this as Apache DataFusion Comet 0.1.0 > > > > [ ] +0 > > > > [ ] -1 Do not release this as Apache DataFusion Comet 0.1.0 > because... > > > > > > > > Here is my vote: > > > > > > > > +1 > > > > > > > > [1]: > > > > > > https://github.com/apache/datafusion-comet/tree/df980bf67e59f439521b90dd2139c6a8d706c0bc > > > > [2]: > > > > > > https://dist.apache.org/repos/dist/dev/datafusion/apache-datafusion-comet-0.1.0-rc2 > > > > [3]: > > > > > > https://github.com/apache/datafusion-comet/blob/df980bf67e59f439521b90dd2139c6a8d706c0bc/CHANGELOG.md > > > > > > > > > > > > - > > > > To unsubscribe, e-mail: dev-unsubscr...@datafusion.apache.org > > > > For additional commands, e-mail: dev-h...@datafusion.apache.org > > > > > > > > > > - > > > To unsubscribe, e-mail: dev-unsubscr...@datafusion.apache.org > > > For additional commands, e-mail: dev-h...@datafusion.apache.org > > > > > > > > >
Re: [VOTE] Release Apache DataFusion Comet 0.1.0 RC2
+1 (non-binding) I verified it on a M1 Mac. BTW, I believe the verify-release-candidate.sh in main branch doesn’t work yet, have to switch to branch-0.1 to verify that. > On Jul 22, 2024, at 20:15, Andrew Lamb wrote: > > +1 (binding) > > I verified it on a m3 mac > > I noted the changelog link in your email [3] gives me a 404. I think the > right link may be [1] > > Thanks, > Andrew > > > [1]: > https://github.com/apache/datafusion-comet/blob/df980bf67e59f439521b90dd2139c6a8d706c0bc/dev/changelog/0.1.0.md > [3]: > https://github.com/apache/datafusion-comet/blob/df980bf67e59f439521b90dd2139c6a8d706c0bc/CHANGELOG.md > > > > On Sat, Jul 20, 2024 at 6:36 PM Edmondo Porcu > wrote: > >> +1 (non-binding) >> >> Verified on M2 Mac. >> >> Ed >> >> Il giorno sab 20 lug 2024 alle ore 18:22 huaxin gao < >> huaxin.ga...@gmail.com> >> ha scritto: >> >>> +1 (non-binding) >>> >>> Verified on M2 Mac. >>> >>> Thanks Andy. >>> >>> On Sat, Jul 20, 2024 at 2:13 PM L. C. Hsieh wrote: >>> +1 (binding) Verified on M3 Mac. Thanks Andy. On Sat, Jul 20, 2024 at 1:57 PM Andy Grove >> >>> wrote: > > Hi, > > I would like to propose a release of Apache DataFusion Comet version 0.1.0. > > This release candidate is based on commit: df980bf67e59f439521b90dd2139c6a8d706c0bc [1] > The proposed release tarball and signatures are hosted at [2]. > The changelog is located at [3]. > > Please download, verify checksums and signatures, run the unit tests, and vote > on the release. The vote will be open for at least 72 hours. > > Only votes from PMC members are binding, but all members of the community are > encouraged to test the release and vote with "(non-binding)". > > The standard verification procedure is documented at >>> >> https://github.com/apache/datafusion-comet/blob/main/dev/release/verifying-release-candidates.md > > [ ] +1 Release this as Apache DataFusion Comet 0.1.0 > [ ] +0 > [ ] -1 Do not release this as Apache DataFusion Comet 0.1.0 >> because... > > Here is my vote: > > +1 > > [1]: >>> >> https://github.com/apache/datafusion-comet/tree/df980bf67e59f439521b90dd2139c6a8d706c0bc > [2]: >>> >> https://dist.apache.org/repos/dist/dev/datafusion/apache-datafusion-comet-0.1.0-rc2 > [3]: >>> >> https://github.com/apache/datafusion-comet/blob/df980bf67e59f439521b90dd2139c6a8d706c0bc/CHANGELOG.md > > > - > To unsubscribe, e-mail: dev-unsubscr...@datafusion.apache.org > For additional commands, e-mail: dev-h...@datafusion.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@datafusion.apache.org For additional commands, e-mail: dev-h...@datafusion.apache.org >>> >> - To unsubscribe, e-mail: dev-unsubscr...@datafusion.apache.org For additional commands, e-mail: dev-h...@datafusion.apache.org
Re: [VOTE] Release Apache DataFusion Comet 0.1.0 RC2
Thanks for the feedback so far on the release process. I have a PR open to fix the issues reported so far. https://github.com/apache/datafusion-comet/pull/696 On Mon, Jul 22, 2024 at 8:46 AM Xianjin YE wrote: > +1 (non-binding) > > I verified it on a M1 Mac. > > BTW, I believe the verify-release-candidate.sh in main branch doesn’t work > yet, have to switch to branch-0.1 to verify that. > > > On Jul 22, 2024, at 20:15, Andrew Lamb wrote: > > > > +1 (binding) > > > > I verified it on a m3 mac > > > > I noted the changelog link in your email [3] gives me a 404. I think the > > right link may be [1] > > > > Thanks, > > Andrew > > > > > > [1]: > > > https://github.com/apache/datafusion-comet/blob/df980bf67e59f439521b90dd2139c6a8d706c0bc/dev/changelog/0.1.0.md > > [3]: > > > https://github.com/apache/datafusion-comet/blob/df980bf67e59f439521b90dd2139c6a8d706c0bc/CHANGELOG.md > > > > > > > > On Sat, Jul 20, 2024 at 6:36 PM Edmondo Porcu > > wrote: > > > >> +1 (non-binding) > >> > >> Verified on M2 Mac. > >> > >> Ed > >> > >> Il giorno sab 20 lug 2024 alle ore 18:22 huaxin gao < > >> huaxin.ga...@gmail.com> > >> ha scritto: > >> > >>> +1 (non-binding) > >>> > >>> Verified on M2 Mac. > >>> > >>> Thanks Andy. > >>> > >>> On Sat, Jul 20, 2024 at 2:13 PM L. C. Hsieh wrote: > >>> > +1 (binding) > > Verified on M3 Mac. > > Thanks Andy. > > On Sat, Jul 20, 2024 at 1:57 PM Andy Grove > >> > wrote: > > > > Hi, > > > > I would like to propose a release of Apache DataFusion Comet version > 0.1.0. > > > > This release candidate is based on commit: > df980bf67e59f439521b90dd2139c6a8d706c0bc [1] > > The proposed release tarball and signatures are hosted at [2]. > > The changelog is located at [3]. > > > > Please download, verify checksums and signatures, run the unit tests, > and vote > > on the release. The vote will be open for at least 72 hours. > > > > Only votes from PMC members are binding, but all members of the > community are > > encouraged to test the release and vote with "(non-binding)". > > > > The standard verification procedure is documented at > > >>> > >> > https://github.com/apache/datafusion-comet/blob/main/dev/release/verifying-release-candidates.md > > > > [ ] +1 Release this as Apache DataFusion Comet 0.1.0 > > [ ] +0 > > [ ] -1 Do not release this as Apache DataFusion Comet 0.1.0 > >> because... > > > > Here is my vote: > > > > +1 > > > > [1]: > > >>> > >> > https://github.com/apache/datafusion-comet/tree/df980bf67e59f439521b90dd2139c6a8d706c0bc > > [2]: > > >>> > >> > https://dist.apache.org/repos/dist/dev/datafusion/apache-datafusion-comet-0.1.0-rc2 > > [3]: > > >>> > >> > https://github.com/apache/datafusion-comet/blob/df980bf67e59f439521b90dd2139c6a8d706c0bc/CHANGELOG.md > > > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@datafusion.apache.org > > For additional commands, e-mail: dev-h...@datafusion.apache.org > > > > - > To unsubscribe, e-mail: dev-unsubscr...@datafusion.apache.org > For additional commands, e-mail: dev-h...@datafusion.apache.org > > > >>> > >> > > > - > To unsubscribe, e-mail: dev-unsubscr...@datafusion.apache.org > For additional commands, e-mail: dev-h...@datafusion.apache.org > >
Re: [VOTE] Release Apache DataFusion Comet 0.1.0 RC2
I just noticed that this release candidate depends on the DataFusion 40.0.0 revision in GitHub rather than depending on the released version in crates.io. This means we won't be able to publish the datafusion-comet-spark-expr crate to crates.io. I don't think that is too important for this first release, so I propose that we continue with the vote and fix this for the next release. On Mon, Jul 22, 2024 at 9:00 AM Andy Grove wrote: > Thanks for the feedback so far on the release process. I have a PR open to > fix the issues reported so far. > > https://github.com/apache/datafusion-comet/pull/696 > > On Mon, Jul 22, 2024 at 8:46 AM Xianjin YE wrote: > >> +1 (non-binding) >> >> I verified it on a M1 Mac. >> >> BTW, I believe the verify-release-candidate.sh in main branch doesn’t >> work yet, have to switch to branch-0.1 to verify that. >> >> > On Jul 22, 2024, at 20:15, Andrew Lamb wrote: >> > >> > +1 (binding) >> > >> > I verified it on a m3 mac >> > >> > I noted the changelog link in your email [3] gives me a 404. I think the >> > right link may be [1] >> > >> > Thanks, >> > Andrew >> > >> > >> > [1]: >> > >> https://github.com/apache/datafusion-comet/blob/df980bf67e59f439521b90dd2139c6a8d706c0bc/dev/changelog/0.1.0.md >> > [3]: >> > >> https://github.com/apache/datafusion-comet/blob/df980bf67e59f439521b90dd2139c6a8d706c0bc/CHANGELOG.md >> > >> > >> > >> > On Sat, Jul 20, 2024 at 6:36 PM Edmondo Porcu >> > wrote: >> > >> >> +1 (non-binding) >> >> >> >> Verified on M2 Mac. >> >> >> >> Ed >> >> >> >> Il giorno sab 20 lug 2024 alle ore 18:22 huaxin gao < >> >> huaxin.ga...@gmail.com> >> >> ha scritto: >> >> >> >>> +1 (non-binding) >> >>> >> >>> Verified on M2 Mac. >> >>> >> >>> Thanks Andy. >> >>> >> >>> On Sat, Jul 20, 2024 at 2:13 PM L. C. Hsieh wrote: >> >>> >> +1 (binding) >> >> Verified on M3 Mac. >> >> Thanks Andy. >> >> On Sat, Jul 20, 2024 at 1:57 PM Andy Grove >> >> > >> wrote: >> > >> > Hi, >> > >> > I would like to propose a release of Apache DataFusion Comet version >> 0.1.0. >> > >> > This release candidate is based on commit: >> df980bf67e59f439521b90dd2139c6a8d706c0bc [1] >> > The proposed release tarball and signatures are hosted at [2]. >> > The changelog is located at [3]. >> > >> > Please download, verify checksums and signatures, run the unit >> tests, >> and vote >> > on the release. The vote will be open for at least 72 hours. >> > >> > Only votes from PMC members are binding, but all members of the >> community are >> > encouraged to test the release and vote with "(non-binding)". >> > >> > The standard verification procedure is documented at >> >> >>> >> >> >> https://github.com/apache/datafusion-comet/blob/main/dev/release/verifying-release-candidates.md >> > >> > [ ] +1 Release this as Apache DataFusion Comet 0.1.0 >> > [ ] +0 >> > [ ] -1 Do not release this as Apache DataFusion Comet 0.1.0 >> >> because... >> > >> > Here is my vote: >> > >> > +1 >> > >> > [1]: >> >> >>> >> >> >> https://github.com/apache/datafusion-comet/tree/df980bf67e59f439521b90dd2139c6a8d706c0bc >> > [2]: >> >> >>> >> >> >> https://dist.apache.org/repos/dist/dev/datafusion/apache-datafusion-comet-0.1.0-rc2 >> > [3]: >> >> >>> >> >> >> https://github.com/apache/datafusion-comet/blob/df980bf67e59f439521b90dd2139c6a8d706c0bc/CHANGELOG.md >> > >> > >> > >> - >> > To unsubscribe, e-mail: dev-unsubscr...@datafusion.apache.org >> > For additional commands, e-mail: dev-h...@datafusion.apache.org >> > >> >> - >> To unsubscribe, e-mail: dev-unsubscr...@datafusion.apache.org >> For additional commands, e-mail: dev-h...@datafusion.apache.org >> >> >> >>> >> >> >> >> >> - >> To unsubscribe, e-mail: dev-unsubscr...@datafusion.apache.org >> For additional commands, e-mail: dev-h...@datafusion.apache.org >> >>
Re: [VOTE] Release Apache DataFusion Comet 0.1.0 RC2
Src tarball verified successfully. However, building the artifacts from src gives an error because the makefile does not have "-Dmaven.gitcommitid.skip=true" specified. $ make release ( or just make) ... [ERROR] Failed to execute goal io.github.git-commit-id:git-commit-id-maven-plugin:4.9.9:revision (get-the-git-infos) on project comet-common-spark3.4_2.12: .git directory is not found! Please specify a valid [dotGitDirectory] in your pom.xml -> [Help 1] On Sat, Jul 20, 2024 at 1:56 PM Andy Grove wrote: > Hi, > > I would like to propose a release of Apache DataFusion Comet version 0.1.0. > > This release candidate is based on commit: > df980bf67e59f439521b90dd2139c6a8d706c0bc [1] > The proposed release tarball and signatures are hosted at [2]. > The changelog is located at [3]. > > Please download, verify checksums and signatures, run the unit tests, and > vote > on the release. The vote will be open for at least 72 hours. > > Only votes from PMC members are binding, but all members of the community > are > encouraged to test the release and vote with "(non-binding)". > > The standard verification procedure is documented at > https://github.com/apache/datafusion-comet/blob/main/dev/release/verifying-release-candidates.md > > [ ] +1 Release this as Apache DataFusion Comet 0.1.0 > [ ] +0 > [ ] -1 Do not release this as Apache DataFusion Comet 0.1.0 because... > > Here is my vote: > > +1 > > [1]: > https://github.com/apache/datafusion-comet/tree/df980bf67e59f439521b90dd2139c6a8d706c0bc > [2]: > https://dist.apache.org/repos/dist/dev/datafusion/apache-datafusion-comet-0.1.0-rc2 > [3]: > https://github.com/apache/datafusion-comet/blob/df980bf67e59f439521b90dd2139c6a8d706c0bc/CHANGELOG.md > > > - > To unsubscribe, e-mail: dev-unsubscr...@datafusion.apache.org > For additional commands, e-mail: dev-h...@datafusion.apache.org > >
Re: [VOTE] Release Apache DataFusion Comet 0.1.0 RC2
Thanks, Parth. You should be able to run "make release-nogit". I will add this information to the release verification instructions and the getting started guide. On Mon, Jul 22, 2024 at 11:25 AM Parth Chandra wrote: > Src tarball verified successfully. > > However, building the artifacts from src gives an error because the > makefile does not have "-Dmaven.gitcommitid.skip=true" specified. > $ make release ( or just make) > ... > [ERROR] Failed to execute goal > io.github.git-commit-id:git-commit-id-maven-plugin:4.9.9:revision > (get-the-git-infos) on project comet-common-spark3.4_2.12: .git directory > is not found! Please specify a valid [dotGitDirectory] in your pom.xml -> > [Help 1] > > > On Sat, Jul 20, 2024 at 1:56 PM Andy Grove > wrote: > > > Hi, > > > > I would like to propose a release of Apache DataFusion Comet version > 0.1.0. > > > > This release candidate is based on commit: > > df980bf67e59f439521b90dd2139c6a8d706c0bc [1] > > The proposed release tarball and signatures are hosted at [2]. > > The changelog is located at [3]. > > > > Please download, verify checksums and signatures, run the unit tests, and > > vote > > on the release. The vote will be open for at least 72 hours. > > > > Only votes from PMC members are binding, but all members of the community > > are > > encouraged to test the release and vote with "(non-binding)". > > > > The standard verification procedure is documented at > > > https://github.com/apache/datafusion-comet/blob/main/dev/release/verifying-release-candidates.md > > > > [ ] +1 Release this as Apache DataFusion Comet 0.1.0 > > [ ] +0 > > [ ] -1 Do not release this as Apache DataFusion Comet 0.1.0 because... > > > > Here is my vote: > > > > +1 > > > > [1]: > > > https://github.com/apache/datafusion-comet/tree/df980bf67e59f439521b90dd2139c6a8d706c0bc > > [2]: > > > https://dist.apache.org/repos/dist/dev/datafusion/apache-datafusion-comet-0.1.0-rc2 > > [3]: > > > https://github.com/apache/datafusion-comet/blob/df980bf67e59f439521b90dd2139c6a8d706c0bc/CHANGELOG.md > > > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@datafusion.apache.org > > For additional commands, e-mail: dev-h...@datafusion.apache.org > > > > >
Re: [VOTE] Release Apache DataFusion Comet 0.1.0 RC2
+1 (non-binding) (resolved my previous comment). There is a `release-nogit` target for make. On Mon, Jul 22, 2024 at 10:21 AM Parth Chandra wrote: > Src tarball verified successfully. > > However, building the artifacts from src gives an error because the > makefile does not have "-Dmaven.gitcommitid.skip=true" specified. > $ make release ( or just make) > ... > [ERROR] Failed to execute goal > io.github.git-commit-id:git-commit-id-maven-plugin:4.9.9:revision > (get-the-git-infos) on project comet-common-spark3.4_2.12: .git directory > is not found! Please specify a valid [dotGitDirectory] in your pom.xml -> > [Help 1] > > > On Sat, Jul 20, 2024 at 1:56 PM Andy Grove > wrote: > >> Hi, >> >> I would like to propose a release of Apache DataFusion Comet version >> 0.1.0. >> >> This release candidate is based on commit: >> df980bf67e59f439521b90dd2139c6a8d706c0bc [1] >> The proposed release tarball and signatures are hosted at [2]. >> The changelog is located at [3]. >> >> Please download, verify checksums and signatures, run the unit tests, and >> vote >> on the release. The vote will be open for at least 72 hours. >> >> Only votes from PMC members are binding, but all members of the community >> are >> encouraged to test the release and vote with "(non-binding)". >> >> The standard verification procedure is documented at >> https://github.com/apache/datafusion-comet/blob/main/dev/release/verifying-release-candidates.md >> >> [ ] +1 Release this as Apache DataFusion Comet 0.1.0 >> [ ] +0 >> [ ] -1 Do not release this as Apache DataFusion Comet 0.1.0 because... >> >> Here is my vote: >> >> +1 >> >> [1]: >> https://github.com/apache/datafusion-comet/tree/df980bf67e59f439521b90dd2139c6a8d706c0bc >> [2]: >> https://dist.apache.org/repos/dist/dev/datafusion/apache-datafusion-comet-0.1.0-rc2 >> [3]: >> https://github.com/apache/datafusion-comet/blob/df980bf67e59f439521b90dd2139c6a8d706c0bc/CHANGELOG.md >> >> >> - >> To unsubscribe, e-mail: dev-unsubscr...@datafusion.apache.org >> For additional commands, e-mail: dev-h...@datafusion.apache.org >> >>
Re: [VOTE] Release Apache DataFusion Comet 0.1.0 RC2
+1 (non-binding) Verified on m2 macbook pro. On Sat, Jul 20, 2024 at 4:57 PM Andy Grove wrote: > Hi, > > I would like to propose a release of Apache DataFusion Comet version 0.1.0. > > This release candidate is based on commit: > df980bf67e59f439521b90dd2139c6a8d706c0bc [1] > The proposed release tarball and signatures are hosted at [2]. > The changelog is located at [3]. > > Please download, verify checksums and signatures, run the unit tests, and > vote > on the release. The vote will be open for at least 72 hours. > > Only votes from PMC members are binding, but all members of the community > are > encouraged to test the release and vote with "(non-binding)". > > The standard verification procedure is documented at > https://github.com/apache/datafusion-comet/blob/main/dev/release/verifying-release-candidates.md > > [ ] +1 Release this as Apache DataFusion Comet 0.1.0 > [ ] +0 > [ ] -1 Do not release this as Apache DataFusion Comet 0.1.0 because... > > Here is my vote: > > +1 > > [1]: > https://github.com/apache/datafusion-comet/tree/df980bf67e59f439521b90dd2139c6a8d706c0bc > [2]: > https://dist.apache.org/repos/dist/dev/datafusion/apache-datafusion-comet-0.1.0-rc2 > [3]: > https://github.com/apache/datafusion-comet/blob/df980bf67e59f439521b90dd2139c6a8d706c0bc/CHANGELOG.md > > > - > To unsubscribe, e-mail: dev-unsubscr...@datafusion.apache.org > For additional commands, e-mail: dev-h...@datafusion.apache.org > >
[DISCUSS] TableProvider::Scan to take trait object rather than `SessionState`
We are contemplating changing the `TableProvider::Scan` method (to take a trait object, rather than `SessionState`). Please review and provide comments if you are interested[1] [1]: https://github.com/apache/datafusion/pull/11516
