Re: [PR] Bump ossf/scorecard-action from 2.3.3 to 2.4.0 [cxf]
reta merged PR #1981: URL: https://github.com/apache/cxf/pull/1981 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump github/codeql-action from 3.25.13 to 3.25.15 [cxf]
reta merged PR #1982: URL: https://github.com/apache/cxf/pull/1982 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CXF-9042] Fixed non-idempotent unit tests [cxf]
reta commented on code in PR #1978:
URL: https://github.com/apache/cxf/pull/1978#discussion_r1695586110
##
rt/management/src/test/java/org/apache/cxf/management/InstrumentationManagerTest.java:
##
@@ -105,6 +105,11 @@ public void testWorkQueueInstrumentation() throws
Exception {
}
}
+// Unregister MBeans at the end of the test
Review Comment:
We probably want to wrap this up in `try-finally` block, so if assertion
fails, the resources (mbeans) are still unregistered
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [CXF-9042] Fixed non-idempotent unit tests [cxf]
reta commented on code in PR #1978:
URL: https://github.com/apache/cxf/pull/1978#discussion_r1695631017
##
services/sts/sts-core/src/test/java/org/apache/cxf/sts/operation/ValidateJWTTransformationTest.java:
##
@@ -206,7 +206,9 @@ public void testJWTToSAMLTransformationRealm() throws
Exception {
TokenProviderResponse providerResponse = createJWT();
Element wrapper =
createTokenWrapper((String)providerResponse.getToken());
Document doc = wrapper.getOwnerDocument();
-wrapper = (Element)doc.appendChild(wrapper);
+if (doc.getDocumentElement() == null) {
Review Comment:
@kaiyaok2 this change is a bit suspicious, why the document element will be
null here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] Bump org.asynchttpclient:async-http-client from 2.12.3 to 3.0.0 [cxf]
dependabot[bot] opened a new pull request, #1985: URL: https://github.com/apache/cxf/pull/1985 Bumps [org.asynchttpclient:async-http-client](https://github.com/AsyncHttpClient/async-http-client) from 2.12.3 to 3.0.0. Release notes Sourced from https://github.com/AsyncHttpClient/async-http-client/releases";>org.asynchttpclient:async-http-client's releases. AHC v3.0.0 Release What's Changed Bump org.apache.tomcat.embed:tomcat-embed-core from 10.1.13 to 10.1.16 in /client by https://github.com/dependabot";>@dependabot in https://redirect.github.com/AsyncHttpClient/async-http-client/pull/1919";>AsyncHttpClient/async-http-client#1919 netty 4.1.107 by https://github.com/sullis";>@sullis in https://redirect.github.com/AsyncHttpClient/async-http-client/pull/1929";>AsyncHttpClient/async-http-client#1929 junit 5.10.2 by https://github.com/sullis";>@sullis in https://redirect.github.com/AsyncHttpClient/async-http-client/pull/1930";>AsyncHttpClient/async-http-client#1930 setup-java v4 by https://github.com/sullis";>@sullis in https://redirect.github.com/AsyncHttpClient/async-http-client/pull/1931";>AsyncHttpClient/async-http-client#1931 update maven wrapper by https://github.com/sullis";>@sullis in https://redirect.github.com/AsyncHttpClient/async-http-client/pull/1936";>AsyncHttpClient/async-http-client#1936 fix Netty dependencies by https://github.com/sullis";>@sullis in https://redirect.github.com/AsyncHttpClient/async-http-client/pull/1935";>AsyncHttpClient/async-http-client#1935 maven surefire 3.2.5 by https://github.com/sullis";>@sullis in https://redirect.github.com/AsyncHttpClient/async-http-client/pull/1934";>AsyncHttpClient/async-http-client#1934 slf4j 2.0.12 by https://github.com/sullis";>@sullis in https://redirect.github.com/AsyncHttpClient/async-http-client/pull/1933";>AsyncHttpClient/async-http-client#1933 use Netty leak detector extension by https://github.com/sullis";>@sullis in https://redirect.github.com/AsyncHttpClient/async-http-client/pull/1932";>AsyncHttpClient/async-http-client#1932 unit test for io_uring by https://github.com/sullis";>@sullis in https://redirect.github.com/AsyncHttpClient/async-http-client/pull/1937";>AsyncHttpClient/async-http-client#1937 support brotli by https://github.com/sullis";>@sullis in https://redirect.github.com/AsyncHttpClient/async-http-client/pull/1938";>AsyncHttpClient/async-http-client#1938 maven-gpg-plugin 3.1.0 by https://github.com/sullis";>@sullis in https://redirect.github.com/AsyncHttpClient/async-http-client/pull/1939";>AsyncHttpClient/async-http-client#1939 maven-compiler-plugin 3.12.1 by https://github.com/sullis";>@sullis in https://redirect.github.com/AsyncHttpClient/async-http-client/pull/1940";>AsyncHttpClient/async-http-client#1940 errorprone 2.25.0 by https://github.com/sullis";>@sullis in https://redirect.github.com/AsyncHttpClient/async-http-client/pull/1942";>AsyncHttpClient/async-http-client#1942 maven-javadoc-plugin 3.6.3 by https://github.com/sullis";>@sullis in https://redirect.github.com/AsyncHttpClient/async-http-client/pull/1941";>AsyncHttpClient/async-http-client#1941 Bump org.apache.tomcat.embed:tomcat-embed-core from 10.1.16 to 10.1.19 in /client by https://github.com/dependabot";>@dependabot in https://redirect.github.com/AsyncHttpClient/async-http-client/pull/1944";>AsyncHttpClient/async-http-client#1944 maven-compiler-plugin 3.13.0 by https://github.com/sullis";>@sullis in https://redirect.github.com/AsyncHttpClient/async-http-client/pull/1945";>AsyncHttpClient/async-http-client#1945 netty 4.1.108 by https://github.com/sullis";>@sullis in https://redirect.github.com/AsyncHttpClient/async-http-client/pull/1946";>AsyncHttpClient/async-http-client#1946 netty leak detector 0.0.4 by https://github.com/sullis";>@sullis in https://redirect.github.com/AsyncHttpClient/async-http-client/pull/1948";>AsyncHttpClient/async-http-client#1948 netty leak detector 0.0.5 by https://github.com/sullis";>@sullis in https://redirect.github.com/AsyncHttpClient/async-http-client/pull/1949";>AsyncHttpClient/async-http-client#1949 Extend Response to support returning ByteBufs by https://github.com/dgolombek";>@dgolombek in https://redirect.github.com/AsyncHttpClient/async-http-client/pull/1954";>AsyncHttpClient/async-http-client#1954 Extend Request to support ByteBuf inputs by https://github.com/dgolombek";>@dgolombek in https://redirect.github.com/AsyncHttpClient/async-http-client/pull/1952";>AsyncHttpClient/async-http-client#1952 upgrade netty to 4.1.109.Final by https://github.com/sullis";>@sullis in https://redirect.github.com/AsyncHttpClient/async-http-client/pull/1955";>AsyncHttpClient/async-http-client#1955 upgrade to slf4j 2.0.13 by https://github.com/sullis";>@sullis in https://redirect.github.com/AsyncHttpClient/async-http-client/pull/1956";>AsyncHttpClient/async-http-client#1956 Add missing property copies by https
