reta commented on code in PR #1978:
URL: https://github.com/apache/cxf/pull/1978#discussion_r1695586110


##########
rt/management/src/test/java/org/apache/cxf/management/InstrumentationManagerTest.java:
##########
@@ -105,6 +105,11 @@ public void testWorkQueueInstrumentation() throws 
Exception {
             }
         }
 
+        // Unregister MBeans at the end of the test

Review Comment:
   We probably want to wrap this up in `try-finally` block, so if assertion 
fails, the resources (mbeans) are still unregistered



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to