[GitHub] [cxf] kwin opened a new pull request, #964: CXF-8725: Optionally don't set

[GitBox]

kwin opened a new pull request, #964:
URL: https://github.com/apache/cxf/pull/964

   "org.apache.cxf.transport.service_not_available" for 404 responses


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cxf] reta opened a new pull request, #965: Update Jetty to 9.4.47.v20220610

[GitBox]

reta opened a new pull request, #965:
URL: https://github.com/apache/cxf/pull/965

   Update Jetty to 9.4.47.v20220610


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cxf] reta merged pull request #965: Update Jetty to 9.4.47.v20220610

[GitBox]

reta merged PR #965:
URL: https://github.com/apache/cxf/pull/965


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cxf] reta commented on a diff in pull request #964: CXF-8725: Optionally don't set

[GitBox]

reta commented on code in PR #964:
URL: https://github.com/apache/cxf/pull/964#discussion_r903172496


##
rt/transports/http/src/main/java/org/apache/cxf/transport/http/HTTPConduit.java:
##
@@ -1600,7 +1605,7 @@ protected int doProcessResponseCode() throws IOException {
 }
 if (exchange != null) {
 exchange.put(Message.RESPONSE_CODE, rc);
-if (rc == 404 || rc == 503 || rc == 429) {
+if ((rc == 404 && 
MessageUtils.getContextualBoolean(outMessage, 
SERVICE_NOT_AVAILABLE_ON_HTTP_404, true)) || rc == 503 || rc == 429) {

Review Comment:
   Thanks @kwin , I am wondering if we could use list of status codes as 
contextual property instead (`404`, `503`, `429` being the default)? 



##
rt/transports/http/src/main/java/org/apache/cxf/transport/http/HTTPConduit.java:
##
@@ -1600,7 +1605,7 @@ protected int doProcessResponseCode() throws IOException {
 }
 if (exchange != null) {
 exchange.put(Message.RESPONSE_CODE, rc);
-if (rc == 404 || rc == 503 || rc == 429) {
+if ((rc == 404 && 
MessageUtils.getContextualBoolean(outMessage, 
SERVICE_NOT_AVAILABLE_ON_HTTP_404, true)) || rc == 503 || rc == 429) {

Review Comment:
   Thanks @kwin , I am wondering if we could use list of status codes as 
contextual property instead (`404`, `503`, `429` being the default)? What do 
you think?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [DISCUSS] CXF 3.5.x and beyond

[Jim Ma]

Thanks Andriy too for driving this and moving forward !

On Tue, Jun 21, 2022 at 9:49 AM Andriy Redko  wrote:

> Hey guys,
>
> The Jakarta branch [1] just went into master, HUGE THANKS everyone for
> tremendous effort! Please
> note, it is still work in progress, the things to be done are tracked
> under [2], feel free to
> add more items or pick the existing ones. The master builds still have
> some tests failing, but those
> should be fixed shortly. With that, 3.6.x-fixes becomes the "mirror" of
> the master but for javax.*
> packages. Cherrypicking / backporting changes from master might be a bit
> more complicated (jakarta.* -> javax.*)
> but manageable.
>
> One more thing, the pull requests against master and 3.6.x / 3.5.x are
> build using JDK-17 now (was JDK-11
> before), this is due to the fact that master needs JDK-17, as it's Spring
> 6 / Spring Boot 3 JDK baseline.
> I have difficulties configuring Jenkins Maven builds + Github Pull Request
> builder per branch. It may be
> possible with pipeline, I will experiment with that. Please share any
> concerns, comments or feedback, it
> is highly appreciated.
>
> Thank you!
>
> [1] https://github.com/apache/cxf/pull/912
> [2] https://issues.apache.org/jira/browse/CXF-8371
>
> Best Regards,
> Andriy Redko
>
> COh> +1 from me.
>
> COh> Colm.
>
> COh> On Thu, May 26, 2022 at 2:40 AM Jim Ma  wrote:
> >>
> >> Hi Andriy,
> >> A good plan. I agree with all these changes and support versions.
> >>
> >> Thanks,
> >> Jim
> >>
> >> On Mon, May 23, 2022 at 12:45 AM Andriy Redko  wrote:
> >>
> >> > Hey folks,
> >> >
> >> > While the work on 4.x / Jakarta is slowly but steadily moving
> forward, it
> >> > is
> >> > time to think about next 3.x release line. As we discussed in this
> thread,
> >> > it
> >> > seems we agreed on 3.6.x to be next javax.* based release, with
> JDK-11 as
> >> > the
> >> > baseline. We have new Spring Boot 2.7.0 just released [1], along with
> tons
> >> > of other
> >> > related projects. I would like to propose to:
> >> >  - branch off 3.6.x-fixes (from master) and work on upgrades (+ some
> new
> >> > features)
> >> >  - as per @Jim suggestion, merge (very soon) Jakarta branch [2] into
> master
> >> >
> >> > From the support perspective, it means we would need to maintain
> 3.4.x for
> >> > some
> >> > time, plus 3.5.x, 3.6.x and 4.0.0 (when released at some point). What
> do
> >> > you
> >> > think guys? Thank you!
> >> >
> >> > [1] https://spring.io/blog/2022/05/19/spring-boot-2-7-0-available-now
> >> > [2] https://github.com/apache/cxf/pull/912
> >> >
> >> > Best Regards,
> >> > Andriy Redko
> >> >
> >> >
> >> > JM> Hi Andriy,
> >> > JM> I took some time to look at the CXF java11 support and spring
> >> > decoupling
> >> > JM> last week.
> >> > JM> Here are some thoughts and initial work:
> >> > JM> 1) Use cross compile to support java11 . We can simply change
> >> > JM>  in pom.xml to 11.
> >> > JM> This will allow the maven compiler plugin to build cxf with
> java11.
> >> > JM> 2) We can look at creating some separate modules for Spring
> relevant
> >> > JM> code/configuration in the future. Ideally a small
> >> > JM>  number of modules would be better and it will make it easy for
> users
> >> > to
> >> > JM> import spring relevant dependencies.
> >> > JM>  Here is my initial work :
> >> > https://github.com/jimma/cxf/commits/spring
> >> > JM> . This only touches
> >> > several
> >> > JM> cxf modules, I am not
> >> > JM> sure if this approach will get other blockers and issues.
> >> >
> >> > JM> Thanks,
> >> > JM> Jim
> >> >
> >> >
> >> >
> >> > JM> On Sun, Jan 30, 2022 at 12:55 AM Andriy Redko 
> >> > wrote:
> >> >
> >> > >> Hey Jim,
> >> >
> >> > >> AFAIR this particular topic has popped up several times, a few
> issues
> >> > >> exist [1] and
> >> > >> @Christian even did the POC several years ago [2] in attempt to
> remove
> >> > >> some of the
> >> > >> hard Spring dependencies (I don't know the outcomes to be fair but
> I
> >> > >> suspect it turned
> >> > >> out to be much more difficult than anticipated).
> >> >
> >> > >> The suggestion I have in mind is to keep JDK-17 baseline **for
> now** and
> >> > >> continue working
> >> > >> on addressing the blockers (there too many at this point). Once we
> get
> >> > to
> >> > >> the state when
> >> > >> the Jakarta branch is at least buildable / deployable, we could
> reassess
> >> > >> the Spring
> >> > >> coupling. I am just afraid doing everything at once would introduce
> >> > >> instability in
> >> > >> codebase and slow down everyone on either of these efforts. Not
> sure if
> >> > >> you agree but
> >> > >> in any case I am definitely +1 for reducing the scope of
> dependencies on
> >> > >> Spring, even
> >> > >> in 3.4.x / 3.5.x release lines.
> >> >
> >> > >> Thank you.
> >> >
> >> > >> [1] https://issues.apache.org/jira/browse/CXF-5477
> >> > >> [2] https://github.com/apache/cxf/tree/poc-remove-spring-bp
> >> >
> 

[GitHub] [cxf] kwin commented on a diff in pull request #964: CXF-8725: Optionally don't set

[GitBox]

kwin commented on code in PR #964:
URL: https://github.com/apache/cxf/pull/964#discussion_r903278294


##
rt/transports/http/src/main/java/org/apache/cxf/transport/http/HTTPConduit.java:
##
@@ -1600,7 +1605,7 @@ protected int doProcessResponseCode() throws IOException {
 }
 if (exchange != null) {
 exchange.put(Message.RESPONSE_CODE, rc);
-if (rc == 404 || rc == 503 || rc == 429) {
+if ((rc == 404 && 
MessageUtils.getContextualBoolean(outMessage, 
SERVICE_NOT_AVAILABLE_ON_HTTP_404, true)) || rc == 503 || rc == 429) {

Review Comment:
   Makes sense, I am gonna change the PR



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cxf] kwin commented on a diff in pull request #964: CXF-8725: Optionally don't set

[GitBox]

kwin commented on code in PR #964:
URL: https://github.com/apache/cxf/pull/964#discussion_r903340260


##
rt/transports/http/src/main/java/org/apache/cxf/transport/http/HTTPConduit.java:
##
@@ -1600,7 +1605,7 @@ protected int doProcessResponseCode() throws IOException {
 }
 if (exchange != null) {
 exchange.put(Message.RESPONSE_CODE, rc);
-if (rc == 404 || rc == 503 || rc == 429) {
+if ((rc == 404 && 
MessageUtils.getContextualBoolean(outMessage, 
SERVICE_NOT_AVAILABLE_ON_HTTP_404, true)) || rc == 503 || rc == 429) {

Review Comment:
   Done in 
https://github.com/apache/cxf/pull/964/commits/191bea69cff1ff282d6565d0ba1e4b49daa6d95b



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org