reta commented on code in PR #964:
URL: https://github.com/apache/cxf/pull/964#discussion_r903172496
##########
rt/transports/http/src/main/java/org/apache/cxf/transport/http/HTTPConduit.java:
##########
@@ -1600,7 +1605,7 @@ protected int doProcessResponseCode() throws IOException {
}
if (exchange != null) {
exchange.put(Message.RESPONSE_CODE, rc);
- if (rc == 404 || rc == 503 || rc == 429) {
+ if ((rc == 404 &&
MessageUtils.getContextualBoolean(outMessage,
SERVICE_NOT_AVAILABLE_ON_HTTP_404, true)) || rc == 503 || rc == 429) {
Review Comment:
Thanks @kwin , I am wondering if we could use list of status codes as
contextual property instead (`404`, `503`, `429` being the default)?
##########
rt/transports/http/src/main/java/org/apache/cxf/transport/http/HTTPConduit.java:
##########
@@ -1600,7 +1605,7 @@ protected int doProcessResponseCode() throws IOException {
}
if (exchange != null) {
exchange.put(Message.RESPONSE_CODE, rc);
- if (rc == 404 || rc == 503 || rc == 429) {
+ if ((rc == 404 &&
MessageUtils.getContextualBoolean(outMessage,
SERVICE_NOT_AVAILABLE_ON_HTTP_404, true)) || rc == 503 || rc == 429) {
Review Comment:
Thanks @kwin , I am wondering if we could use list of status codes as
contextual property instead (`404`, `503`, `429` being the default)? What do
you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
