[GitHub] [cxf] rotty3000 commented on pull request #946: CXF-8700: Eliminate the `java.compiler` dependency from cxf-core
rotty3000 commented on PR #946: URL: https://github.com/apache/cxf/pull/946#issuecomment-1123765114 @reta done! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cxf] reta commented on pull request #946: CXF-8700: Eliminate the `java.compiler` dependency from cxf-core
reta commented on PR #946: URL: https://github.com/apache/cxf/pull/946#issuecomment-1123854355 > @reta done! Could see a few things: system.properties: ``` org.ops4j.pax.url.mvn.localRepository=/home/jenkins/workspace/CXF/CXF-JDK11-PR/.repository ``` /home/jenkins/workspace/CXF/CXF-JDK11-PR/.repository has `cxf-tools-compiler` published but the bundle is not installed: ``` karaf@root()> la | grep -i compiler karaf@root()> ``` Looking why PAX does not seem to pick the artifacts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cxf] reta commented on pull request #912: CXF-8371: Support Jakarta EE 9.1+
reta commented on PR #912: URL: https://github.com/apache/cxf/pull/912#issuecomment-1123932696 > > > @reta I meant when can we merge the CXF-8371 to master . And we probably need plan some Alpha or Milestone release in the jakarta 4.x CXF and make CI work , then we don 't need to maintain the CXF-8371 branch anymore. > > > > > > @jimma I don't have any objections, ideally it would be great to megre when at least major issues (listed in description) are addressed but it could take a while. But realistically, once JMS (migration to Artemis) is ready, nothing is pending for this branch and we could get it to master. @coheigea @ffang what do you think guys? > > CI is actually running on every commit [1] > > [1] https://ci-builds.apache.org/job/CXF/job/pipeline/job/CXF-8371 > > @reta Good to know this is already works. Is it better to add the "-fae" flag to see all the test failures ? Done, https://ci-builds.apache.org/job/CXF/job/pipeline/job/CXF-8371/38/consoleFull > I wrongly saw this CI result : https://ci-builds.apache.org/job/CXF/job/CXF-JDK11-PR/109/, it's still using JDK11 to run. It's good to fix this too. WDYT ? This is the right place since this is a PR build (but we also build `origin` branch pipelines). The thing is, this is our main Jenkins check for `master` - basically where we have all pull requests coming. For `javax.*` we will stay on JDK-11 baseline (as we discussed [1]) so it is probably makes sense to keep it that way. But ... for Jakarta branch (4.0.0) we would need it to use JDK-17 and to be fair, I have not succeeded yet to configure separate pull request builders for different branches. I mean, I could create Jenkins jobs for different branch specs but only one of the jobs triggers. Will be looking into that shortly. [1] https://www.mail-archive.com/dev@cxf.apache.org/msg17023.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cxf] reta commented on a diff in pull request #946: CXF-8700: Eliminate the `java.compiler` dependency from cxf-core
reta commented on code in PR #946:
URL: https://github.com/apache/cxf/pull/946#discussion_r870500275
##
services/sts/systests/sts-itests/src/test/java/org/apache/cxf/systest/sts/itests/BasicSTSIntegrationTest.java:
##
@@ -62,7 +63,7 @@ public Option[] getConfig() {
when(!localRepository.isEmpty())
.useOptions(systemProperty("org.ops4j.pax.url.mvn.localRepository").value(localRepository)),
//DO NOT COMMIT WITH THIS LINE ENABLED!!!
-//KarafDistributionOption.keepRuntimeFolder(),
+KarafDistributionOption.keepRuntimeFolder(),
Review Comment:
@rotty3000 I could confirm that despite being in configuration, the
`org.ops4j.pax.url.mvn.localRepository` is not consulted when bundles are
installed (as `mvn:`), may I ask you please to add the following setting (with
addition to `org.ops4j.pax.url.mvn.localRepository`):
```
when(!localRepository.isEmpty())
.useOptions(systemProperty("org.ops4j.pax.url.mvn.defaultLocalRepoAsRemote").value("true")),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cxf] rotty3000 commented on a diff in pull request #946: CXF-8700: Eliminate the `java.compiler` dependency from cxf-core
rotty3000 commented on code in PR #946:
URL: https://github.com/apache/cxf/pull/946#discussion_r870506358
##
services/sts/systests/sts-itests/src/test/java/org/apache/cxf/systest/sts/itests/BasicSTSIntegrationTest.java:
##
@@ -62,7 +63,7 @@ public Option[] getConfig() {
when(!localRepository.isEmpty())
.useOptions(systemProperty("org.ops4j.pax.url.mvn.localRepository").value(localRepository)),
//DO NOT COMMIT WITH THIS LINE ENABLED!!!
-//KarafDistributionOption.keepRuntimeFolder(),
+KarafDistributionOption.keepRuntimeFolder(),
Review Comment:
done! :) I have left `KarafDistributionOption.keepRuntimeFolder(),` also
temporarily until we've resolved the issue :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cxf] reta commented on a diff in pull request #946: CXF-8700: Eliminate the `java.compiler` dependency from cxf-core
reta commented on code in PR #946:
URL: https://github.com/apache/cxf/pull/946#discussion_r870585002
##
services/sts/systests/sts-itests/src/test/java/org/apache/cxf/systest/sts/itests/BasicSTSIntegrationTest.java:
##
@@ -62,7 +63,7 @@ public Option[] getConfig() {
when(!localRepository.isEmpty())
.useOptions(systemProperty("org.ops4j.pax.url.mvn.localRepository").value(localRepository)),
//DO NOT COMMIT WITH THIS LINE ENABLED!!!
-//KarafDistributionOption.keepRuntimeFolder(),
+KarafDistributionOption.keepRuntimeFolder(),
Review Comment:
:( no luck so far
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cxf] reta commented on a diff in pull request #946: CXF-8700: Eliminate the `java.compiler` dependency from cxf-core
reta commented on code in PR #946:
URL: https://github.com/apache/cxf/pull/946#discussion_r870590870
##
services/sts/systests/sts-itests/src/test/java/org/apache/cxf/systest/sts/itests/BasicSTSIntegrationTest.java:
##
@@ -62,7 +63,7 @@ public Option[] getConfig() {
when(!localRepository.isEmpty())
.useOptions(systemProperty("org.ops4j.pax.url.mvn.localRepository").value(localRepository)),
//DO NOT COMMIT WITH THIS LINE ENABLED!!!
-//KarafDistributionOption.keepRuntimeFolder(),
+KarafDistributionOption.keepRuntimeFolder(),
Review Comment:
@rotty3000 may I ask you please for the permission to push to your branch?
(a few experiments, don't want to drag you into that, thank you).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cxf] rotty3000 commented on a diff in pull request #946: CXF-8700: Eliminate the `java.compiler` dependency from cxf-core
rotty3000 commented on code in PR #946:
URL: https://github.com/apache/cxf/pull/946#discussion_r870649461
##
services/sts/systests/sts-itests/src/test/java/org/apache/cxf/systest/sts/itests/BasicSTSIntegrationTest.java:
##
@@ -62,7 +63,7 @@ public Option[] getConfig() {
when(!localRepository.isEmpty())
.useOptions(systemProperty("org.ops4j.pax.url.mvn.localRepository").value(localRepository)),
//DO NOT COMMIT WITH THIS LINE ENABLED!!!
-//KarafDistributionOption.keepRuntimeFolder(),
+KarafDistributionOption.keepRuntimeFolder(),
Review Comment:
@reta you should have it :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cxf] reta commented on a diff in pull request #946: CXF-8700: Eliminate the `java.compiler` dependency from cxf-core
reta commented on code in PR #946:
URL: https://github.com/apache/cxf/pull/946#discussion_r870650350
##
services/sts/systests/sts-itests/src/test/java/org/apache/cxf/systest/sts/itests/BasicSTSIntegrationTest.java:
##
@@ -62,7 +63,7 @@ public Option[] getConfig() {
when(!localRepository.isEmpty())
.useOptions(systemProperty("org.ops4j.pax.url.mvn.localRepository").value(localRepository)),
//DO NOT COMMIT WITH THIS LINE ENABLED!!!
-//KarafDistributionOption.keepRuntimeFolder(),
+KarafDistributionOption.keepRuntimeFolder(),
Review Comment:
👍 TY!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Jakarta build hangs on test
Hey Jim, After this commit [2] the Jakarta builds are started to hang [2] (and eventually fail). I have not checked the reason but I could confirm that reverting these changes locally fixes the test, it does not hang anymore (with changes it hangs). Could you please check what is going on there? I could also look with you if help needed. Thank you! [1] https://ci-builds.apache.org/job/CXF/job/pipeline/job/CXF-8371/37/ [2] https://github.com/apache/cxf/commit/34af83850872e62b58464e386bbca3b1e4bb06a6 Best Regards, Andriy Redko
Re: Jakarta build hangs on test
Hi Andriy, I'll have a look today and get back to you later. Thanks, Jim On Thu, May 12, 2022 at 8:26 AM Andriy Redko wrote: > Hey Jim, > > After this commit [2] the Jakarta builds are started to hang [2] (and > eventually fail). I have > not checked the reason but I could confirm that reverting these changes > locally fixes the test, it > does not hang anymore (with changes it hangs). Could you please check what > is going on there? I > could also look with you if help needed. Thank you! > > [1] https://ci-builds.apache.org/job/CXF/job/pipeline/job/CXF-8371/37/ > [2] > https://github.com/apache/cxf/commit/34af83850872e62b58464e386bbca3b1e4bb06a6 > > Best Regards, > Andriy Redko > >
