[GitHub] [cxf] reta commented on a diff in pull request #946: CXF-8700: Eliminate the `java.compiler` dependency from cxf-core

[GitBox]

reta commented on code in PR #946:
URL: https://github.com/apache/cxf/pull/946#discussion_r870500275


##########
services/sts/systests/sts-itests/src/test/java/org/apache/cxf/systest/sts/itests/BasicSTSIntegrationTest.java:
##########
@@ -62,7 +63,7 @@ public Option[] getConfig() {
             when(!localRepository.isEmpty())
                 
.useOptions(systemProperty("org.ops4j.pax.url.mvn.localRepository").value(localRepository)),
             //DO NOT COMMIT WITH THIS LINE ENABLED!!!
-            //KarafDistributionOption.keepRuntimeFolder(),
+            KarafDistributionOption.keepRuntimeFolder(),

Review Comment:
   @rotty3000 I could confirm that despite being in configuration, the 
`org.ops4j.pax.url.mvn.localRepository` is not consulted when bundles are 
installed (as `mvn:`), may I ask you please to add the following setting (with 
addition to `org.ops4j.pax.url.mvn.localRepository`):
   ```
               when(!localRepository.isEmpty())
                   
.useOptions(systemProperty("org.ops4j.pax.url.mvn.defaultLocalRepoAsRemote").value("true")),
   
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org