[GitHub] cordova-plugin-contacts pull request: CB-11033 Appium tests: Incre...

[alsorokin]

GitHub user alsorokin opened a pull request:

https://github.com/apache/cordova-plugin-contacts/pull/118

CB-11033 Appium tests: Increased the timeout for updating the contact

https://issues.apache.org/jira/browse/CB-11033

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-plugin-contacts CB-11033

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-contacts/pull/118.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #118


commit 0d33af8e4e197fc9204566b165cb5983ab442db8
Author: Alexander Sorokin 
Date:   2016-04-07T09:17:55Z

CB-11033 Appium tests: Increased the timeout for updating the contact




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[ANNOUNCE] Cordova-windows@4.3.2 released

[Vladimir Kotikov (Akvelon)]

Cordova-windows@4.3.2 is on NPM now: 
https://www.npmjs.com/package/cordova-windows
Check out blog post at 
http://cordova.apache.org/announcements/2016/04/05/cordova-windows-4.3.2.html 
and retweet https://twitter.com/apachecordova?ref_src=twsrc%5Etfw

-
Best regards, Vladimir

[GitHub] cordova-plugin-contacts pull request: CB-11033 Appium tests: Incre...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-contacts/pull/118


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file pull request: CB-10960 Uncaught # i...

[daserge]

GitHub user daserge opened a pull request:

https://github.com/apache/cordova-plugin-file/pull/177

CB-10960 Uncaught # in write() when readyState != WRITING ?

[Jira issue](https://issues.apache.org/jira/browse/CB-10960)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-plugin-file CB-10960

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-file/pull/177.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #177


commit 420bf552d42ec5d958881dea6d5dc64805a06282
Author: daserge 
Date:   2016-04-07T09:06:14Z

CB-10960 Uncaught # in write() when readyState != WRITING ?




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file pull request: FileProxy.js makeNativeURL() wil...

[mariol3]

Github user mariol3 commented on the pull request:


https://github.com/apache/cordova-plugin-file/pull/112#issuecomment-206808003
  
+1 for this fix


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [Android] Library Project/AAR alternatives to current plugin situation

[julio cesar sanchez]

I think it's a good idea as right now you can't install plugins on the
cordova embedded webview use case, not even with plugman.

Did you publish it on jcenter or mavencentral? or can you publish on github
the plugin as library project (I mean the plugin  with the changes you
made, but without the cordova sample project)

2016-04-07 2:51 GMT+02:00 Joe Bowser :

> On Wed, Apr 6, 2016 at 4:08 PM, Carlos Santana 
> wrote:
>
> > Does this aligns in a similar way as how phonegap is recommending for iOS
> > on using Cocoapods [1] to embed the Cordova WebView into an existing iOS
> > App?
> >
>
> Yes, except that I don't think it will be nearly as complex as the iOS
> approach is.
>
>
> >
> > Looking only from a Native Android developer eyes this will be the
> approach
> > I would like if I have a pure native android app and for some reason I
> want
> > to add a Cordova webview to a portion of my App.
> >
> > [1]: http://docs.phonegap.com/develop/1-embed-webview/ios/#pods
> >
> >
> > On Wed, Apr 6, 2016 at 5:52 PM Joe Bowser  wrote:
> >
> > > Hey
> > >
> > > I recently looked at how native Android developers could use the
> current
> > > Cordova code with their projects, and I've noticed that there's some
> > major
> > > problems with our current approach of just copying the Java classes
> into
> > a
> > > project, such as resources getting merged together, and other related
> > > issues, so I created a project that instead uses the InAppBrowser
> source
> > as
> > > an Android Library instead of just code thrown over the wall.
> > >
> > > The main advantage of this approach is that we can now build the
> library
> > as
> > > an AAR and distribute the plugins and the platform using jcenter and
> > > mavenCentral and allow more Android developers to be able to use
> Cordova
> > in
> > > their apps and make their apps more hybrid.
> > >
> > > Anyway, the example code is here.
> > >
> > > https://github.com/infil00p/Library-Dev-Project
> > >
> > > I used a Cordova application to demonstrate this, but I could have
> easily
> > > used a vanilla Android project.  Hopefully this also allows for certain
> > > plugins like the InAppBrowser to be a lot more managable and will also
> > > allow us to add more unit tests to our projects.
> > >
> > > Any thoughts on this approach versus our current one?
> > >
> >
>

[GitHub] cordova-plugin-whitelist pull request: Update README.md

[vladimirnani]

GitHub user vladimirnani opened a pull request:

https://github.com/apache/cordova-plugin-whitelist/pull/19

Update README.md

Install docs updated

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/vladimirnani/cordova-plugin-whitelist patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-whitelist/pull/19.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #19


commit b3583ee49b6de9a088240d52d5bd58ed56ca14ce
Author: Vladimir Nani 
Date:   2016-04-07T13:44:45Z

Update README.md

Install docs updated




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-statusbar pull request: Handle extended status bar ...

[goshakkk]

GitHub user goshakkk opened a pull request:

https://github.com/apache/cordova-plugin-statusbar/pull/55

Handle extended status bar on iOS



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/hellyeahllc/cordova-plugin-statusbar 
tall-ios-bar-incall-rec

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-statusbar/pull/55.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #55


commit faa662efe1264e414a873039b7951a7d12c141a7
Author: Gosha Arinich 
Date:   2016-04-07T13:44:32Z

Handle extended status bar on iOS




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-statusbar pull request: Handle extended status bar ...

[goshakkk]

Github user goshakkk commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-statusbar/pull/55#discussion_r58876986
  
--- Diff: src/ios/CDVStatusBar.m ---
@@ -457,6 +457,14 @@ -(void)resizeWebView
 frame.origin.y = statusBarFrame.size.height;
 frame.size.height -= statusBarFrame.size.height;
 self.webView.frame = frame;
+} else {
+// even if overlay is used, we want to handle 
in-call/recording/hotspot larger status bar
+CGRect statusBarFrame = [UIApplication 
sharedApplication].statusBarFrame;
+statusBarFrame = [self invertFrameIfNeeded:statusBarFrame];
+CGRect frame = self.webView.frame;
+frame.origin.y = statusBarFrame.size.height - 20;
+frame.size.height -= statusBarFrame.size.height - 20;
--- End diff --

Might be slightly hacky, but is there a better way?..


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-11034: Camera.getPicture -H...

[elsewhat]

GitHub user elsewhat opened a pull request:

https://github.com/apache/cordova-plugin-camera/pull/201

CB-11034: Camera.getPicture -Handle of OutOfMemoryError gracefull

Catch OutOfMemoryError for memory intensive operations and handle them
gracefully.

Tested on a Samsung SII which throws OutOfMemoryException when taking a 
photo and fetching it as a DATA_URL.Not able to test when selecting from gallery


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/elsewhat/cordova-plugin-camera 
CB-11034cordova-plugin-camera

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-camera/pull/201.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #201


commit eb3ecfff3e07b0e4dd0f6d9b723518d52962f36c
Author: Dagfinn Parnas 
Date:   2016-04-07T14:16:55Z

CB-11034: Camera.getPicture -Handle of OutOfMemoryError gracefull

Catch OutOfMemoryError for memory intensive operations and handle them
gracefully




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-statusbar pull request: Handle extended status bar ...

[jcesarmobile]

Github user jcesarmobile commented on the pull request:


https://github.com/apache/cordova-plugin-statusbar/pull/55#issuecomment-206930561
  
With that code, if statusbar is hidden(height = 0), you'll set webview y to 
-20.

What is the problem you are trying to fix? right now the in-call statusbar 
problems are handled in most cases. There are a few issues still open, check 
them on http://issues.cordova.io/
If the problem isn't any of the open ones, please, file a new one.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-statusbar pull request: Handle extended status bar ...

[goshakkk]

Github user goshakkk commented on the pull request:


https://github.com/apache/cordova-plugin-statusbar/pull/55#issuecomment-206932594
  
The problem is with just overlay set to true, when the status bar extends, 
it partially slides onto the web view.

Reducing the web view's frame by the height of the addition allows to 
address that. The extended status bar will now partially hide only 20px of web 
view, not 40px. These 20px it hides contain a custom bg for the status bar 
anyway, so it's ok to hide that, and the 20px offset ensures that no actual 
content will overlap with the addition.

https://cloud.githubusercontent.com/assets/315596/14354486/23f8bdd8-fce6-11e5-8f24-3959de2742db.png";>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-statusbar pull request: Handle extended status bar ...

[goshakkk]

Github user goshakkk commented on the pull request:


https://github.com/apache/cordova-plugin-statusbar/pull/55#issuecomment-206934148
  
https://issues.apache.org/jira/browse/CB-10796


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-statusbar pull request: Handle extended status bar ...

[jcesarmobile]

Github user jcesarmobile commented on the pull request:


https://github.com/apache/cordova-plugin-statusbar/pull/55#issuecomment-206936756
  
If the statusbar is the in-call statusbar, then 40-20 = 20. Your code is ok 
for this case.
If the statusbar is the regular statusbar, then 20-20 = 0. Ok too because 
overlay webview is true.
but if overlay = true and the statusbar is hidden, then 0-20 = -20.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-statusbar pull request: Handle extended status bar ...

[goshakkk]

Github user goshakkk commented on the pull request:


https://github.com/apache/cordova-plugin-statusbar/pull/55#issuecomment-206938010
  
So, we should add a check if it's hidden and then the PR is good?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

cordova-plugin-remote-inject release

[Brad Reynolds]

If there's an official way to release a plugin let me know but I just
pushed a plugin we developed to github.  It allows for a cordova app to
inject cordova into a remote site.  This allows us to have a cordova app
with native integration and a mobile app for older devices and platforms we
don't support in app form.

https://github.com/TruckMovers/cordova-plugin-remote-injection

-bradr

Re: [Android] Library Project/AAR alternatives to current plugin situation

[Joe Bowser]

I didn't publish it anywhere yet because I can't officially publish things
as Cordova without things being voted on.  I could probably call this all
PhoneGap and publish it, but I really want to make sure that I have the is
dotted and the ts crossed before doing that, since I don't want the Apache
powers-that-be to come back down and shit on my head because I dared do
something for our users.

On Thu, Apr 7, 2016 at 5:31 AM, julio cesar sanchez 
wrote:

> I think it's a good idea as right now you can't install plugins on the
> cordova embedded webview use case, not even with plugman.
>
> Did you publish it on jcenter or mavencentral? or can you publish on github
> the plugin as library project (I mean the plugin  with the changes you
> made, but without the cordova sample project)
>
> 2016-04-07 2:51 GMT+02:00 Joe Bowser :
>
> > On Wed, Apr 6, 2016 at 4:08 PM, Carlos Santana 
> > wrote:
> >
> > > Does this aligns in a similar way as how phonegap is recommending for
> iOS
> > > on using Cocoapods [1] to embed the Cordova WebView into an existing
> iOS
> > > App?
> > >
> >
> > Yes, except that I don't think it will be nearly as complex as the iOS
> > approach is.
> >
> >
> > >
> > > Looking only from a Native Android developer eyes this will be the
> > approach
> > > I would like if I have a pure native android app and for some reason I
> > want
> > > to add a Cordova webview to a portion of my App.
> > >
> > > [1]: http://docs.phonegap.com/develop/1-embed-webview/ios/#pods
> > >
> > >
> > > On Wed, Apr 6, 2016 at 5:52 PM Joe Bowser  wrote:
> > >
> > > > Hey
> > > >
> > > > I recently looked at how native Android developers could use the
> > current
> > > > Cordova code with their projects, and I've noticed that there's some
> > > major
> > > > problems with our current approach of just copying the Java classes
> > into
> > > a
> > > > project, such as resources getting merged together, and other related
> > > > issues, so I created a project that instead uses the InAppBrowser
> > source
> > > as
> > > > an Android Library instead of just code thrown over the wall.
> > > >
> > > > The main advantage of this approach is that we can now build the
> > library
> > > as
> > > > an AAR and distribute the plugins and the platform using jcenter and
> > > > mavenCentral and allow more Android developers to be able to use
> > Cordova
> > > in
> > > > their apps and make their apps more hybrid.
> > > >
> > > > Anyway, the example code is here.
> > > >
> > > > https://github.com/infil00p/Library-Dev-Project
> > > >
> > > > I used a Cordova application to demonstrate this, but I could have
> > easily
> > > > used a vanilla Android project.  Hopefully this also allows for
> certain
> > > > plugins like the InAppBrowser to be a lot more managable and will
> also
> > > > allow us to add more unit tests to our projects.
> > > >
> > > > Any thoughts on this approach versus our current one?
> > > >
> > >
> >
>

Re: [Android] Library Project/AAR alternatives to current plugin situation

[Joe Bowser]

BTW: You can use this to install plugins in an Android Studio project.
It's a proof-of-concept, but it's a good stop-gap until we get our plugin
story figured out.

https://github.com/infil00p/cordova-android-studio

On Thu, Apr 7, 2016 at 5:31 AM, julio cesar sanchez 
wrote:

> I think it's a good idea as right now you can't install plugins on the
> cordova embedded webview use case, not even with plugman.
>
> Did you publish it on jcenter or mavencentral? or can you publish on github
> the plugin as library project (I mean the plugin  with the changes you
> made, but without the cordova sample project)
>
> 2016-04-07 2:51 GMT+02:00 Joe Bowser :
>
> > On Wed, Apr 6, 2016 at 4:08 PM, Carlos Santana 
> > wrote:
> >
> > > Does this aligns in a similar way as how phonegap is recommending for
> iOS
> > > on using Cocoapods [1] to embed the Cordova WebView into an existing
> iOS
> > > App?
> > >
> >
> > Yes, except that I don't think it will be nearly as complex as the iOS
> > approach is.
> >
> >
> > >
> > > Looking only from a Native Android developer eyes this will be the
> > approach
> > > I would like if I have a pure native android app and for some reason I
> > want
> > > to add a Cordova webview to a portion of my App.
> > >
> > > [1]: http://docs.phonegap.com/develop/1-embed-webview/ios/#pods
> > >
> > >
> > > On Wed, Apr 6, 2016 at 5:52 PM Joe Bowser  wrote:
> > >
> > > > Hey
> > > >
> > > > I recently looked at how native Android developers could use the
> > current
> > > > Cordova code with their projects, and I've noticed that there's some
> > > major
> > > > problems with our current approach of just copying the Java classes
> > into
> > > a
> > > > project, such as resources getting merged together, and other related
> > > > issues, so I created a project that instead uses the InAppBrowser
> > source
> > > as
> > > > an Android Library instead of just code thrown over the wall.
> > > >
> > > > The main advantage of this approach is that we can now build the
> > library
> > > as
> > > > an AAR and distribute the plugins and the platform using jcenter and
> > > > mavenCentral and allow more Android developers to be able to use
> > Cordova
> > > in
> > > > their apps and make their apps more hybrid.
> > > >
> > > > Anyway, the example code is here.
> > > >
> > > > https://github.com/infil00p/Library-Dev-Project
> > > >
> > > > I used a Cordova application to demonstrate this, but I could have
> > easily
> > > > used a vanilla Android project.  Hopefully this also allows for
> certain
> > > > plugins like the InAppBrowser to be a lot more managable and will
> also
> > > > allow us to add more unit tests to our projects.
> > > >
> > > > Any thoughts on this approach versus our current one?
> > > >
> > >
> >
>

Re: cordova-plugin-remote-inject release

[Shazron]

Hi,
Check out the official plugins, they have a package.json which is the npm
package format for publishing to their registry. Most plugins would publish
to that so users can just install a plugin by name.

On Thursday, April 7, 2016, Brad Reynolds  wrote:

> If there's an official way to release a plugin let me know but I just
> pushed a plugin we developed to github.  It allows for a cordova app to
> inject cordova into a remote site.  This allows us to have a cordova app
> with native integration and a mobile app for older devices and platforms we
> don't support in app form.
>
> https://github.com/TruckMovers/cordova-plugin-remote-injection
>
> -bradr
>

[GitHub] cordova-plugin-camera pull request: Appium tests stability improve...

[alsorokin]

GitHub user alsorokin opened a pull request:

https://github.com/apache/cordova-plugin-camera/pull/202

Appium tests stability improvements



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-plugin-camera ui-tests

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-camera/pull/202.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #202


commit c27c1299fdc95ec75081073c7d28b733a36fe8f0
Author: Alexander Sorokin 
Date:   2016-04-07T16:16:49Z

Appium tests stability improvements




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: cordova-plugin-remote-inject release

[Brad Reynolds]

Will do.  Thanks for the pointer.

On Thu, Apr 7, 2016 at 11:13 AM, Shazron  wrote:

> Hi,
> Check out the official plugins, they have a package.json which is the npm
> package format for publishing to their registry. Most plugins would publish
> to that so users can just install a plugin by name.
>
> On Thursday, April 7, 2016, Brad Reynolds  wrote:
>
> > If there's an official way to release a plugin let me know but I just
> > pushed a plugin we developed to github.  It allows for a cordova app to
> > inject cordova into a remote site.  This allows us to have a cordova app
> > with native integration and a mobile app for older devices and platforms
> we
> > don't support in app form.
> >
> > https://github.com/TruckMovers/cordova-plugin-remote-injection
> >
> > -bradr
> >
>

RE: [VOTE] 4.1.1 iOS Release - Take 2

[Alexander Sorokin (Akvelon)]

I vote +1:

* Verified archives via `coho verify-archive`
* Verified tags manually
* Verified that blank app creates correctly with platform
* Verified that blank app can be successfully ran and built
* Verified that platform can be updated from previous version
* Verified compatibility with core plugins (ran mobilespec for released and 
edge versions)
* Checked for whitespace issues
* Checked for Unicode issues
* Verified version
* Verified line breaks

-Original Message-
From: Jesse [mailto:purplecabb...@gmail.com] 
Sent: Thursday, April 7, 2016 9:34 AM
To: dev@cordova.apache.org
Subject: Re: [VOTE] 4.1.1 iOS Release - Take 2

+1

- Ran coho audit-license-headers
- Ran coho check-license
- Ran coho verify archive
- Ran iOS native tests > Good signature from "Edna Morales"
- Created and ran hello world iOS app with CLI



@purplecabbage
https://na01.safelinks.protection.outlook.com/?url=risingj.com&data=01%7c01%7cv-alsoro%40microsoft.com%7c43edcedae49b4e6bbe3908d35eaeac46%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=zLJPSjVixkTXxCb0vsEXrFDyCp9rEpkwftmXmFhqanY%3d

On Tue, Apr 5, 2016 at 10:51 AM, Edna Y Morales  wrote:

>
>
> Please review and vote on this 4.1.1 iOS Release by replying to this 
> email (and keep discussion on the DISCUSS thread)
>
> Release issue: 
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissue
> s.apache.org%2fjira%2fbrowse%2fCB-11006&data=01%7c01%7cv-alsoro%40micr
> osoft.com%7c43edcedae49b4e6bbe3908d35eaeac46%7c72f988bf86f141af91ab2d7
> cd011db47%7c1&sdata=LqBRu%2bX5RJDv3kscYEDYbtLxpcYxeGELZJtYobeaiME%3d
>
> The archive has been published to dist/dev:
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fdist.
> apache.org%2frepos%2fdist%2fdev%2fcordova%2fCB-11006%2f&data=01%7c01%7
> cv-alsoro%40microsoft.com%7c43edcedae49b4e6bbe3908d35eaeac46%7c72f988b
> f86f141af91ab2d7cd011db47%7c1&sdata=IganzibFulOMsjHAJolq8UM6K5toA8g0N0
> aBSPG88hY%3d
>
> The package was published from its corresponding git tag:
> cordova-ios: 4.1.1 (c5c33bad30)
>
> Note that you can test it out via:
>
> cordova platform add https://github.com/apache/cordova-ios#4.1.1
>
> Upon a successful vote I will upload the archive to dist/, publish it 
> to npm, and post the blog post.
>
> Voting guidelines:
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting
> .md
>
> Voting will go on for a minimum of 48 hours.
>
> I vote +1:
> * Ran coho audit-license-headers over the relevant repos
> * Ran coho check-license to ensure all dependencies and 
> subdependencies have Apache-compatible licenses
> * Ensured continuous build was green when repo was tagged
> * Ran mobile-spec (iOS)
> * Created and ran hello world iOS app with CLI
> * Created and ran hello world iOS app non-CLI
> * Tested ./bin/create script
> * Tested project upgrade from 4.1.0 to 4.1.1 with CLI
> * Tested project upgrade from 4.1.0 to 4.1.1 non-CLI
> * Ran cordova-lib tests
> * Ran iOS native tests
> * Ran coho verify-archive
>
> Thanks,
> Edna Morales
>

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [Android] Library Project/AAR alternatives to current plugin situation

[Joe Bowser]

BTW: The library project is in the Android directory of this plugin.  I
want to be able to have our plugins use Library Projects and AARs so that
we can get much improved test coverage.

https://github.com/infil00p/cordova-plugin-inappbrowser/tree/aar_poc

On Thu, Apr 7, 2016 at 8:52 AM, Joe Bowser  wrote:

> BTW: You can use this to install plugins in an Android Studio project.
> It's a proof-of-concept, but it's a good stop-gap until we get our plugin
> story figured out.
>
> https://github.com/infil00p/cordova-android-studio
>
> On Thu, Apr 7, 2016 at 5:31 AM, julio cesar sanchez <
> jcesarmob...@gmail.com> wrote:
>
>> I think it's a good idea as right now you can't install plugins on the
>> cordova embedded webview use case, not even with plugman.
>>
>> Did you publish it on jcenter or mavencentral? or can you publish on
>> github
>> the plugin as library project (I mean the plugin  with the changes you
>> made, but without the cordova sample project)
>>
>> 2016-04-07 2:51 GMT+02:00 Joe Bowser :
>>
>> > On Wed, Apr 6, 2016 at 4:08 PM, Carlos Santana 
>> > wrote:
>> >
>> > > Does this aligns in a similar way as how phonegap is recommending for
>> iOS
>> > > on using Cocoapods [1] to embed the Cordova WebView into an existing
>> iOS
>> > > App?
>> > >
>> >
>> > Yes, except that I don't think it will be nearly as complex as the iOS
>> > approach is.
>> >
>> >
>> > >
>> > > Looking only from a Native Android developer eyes this will be the
>> > approach
>> > > I would like if I have a pure native android app and for some reason I
>> > want
>> > > to add a Cordova webview to a portion of my App.
>> > >
>> > > [1]: http://docs.phonegap.com/develop/1-embed-webview/ios/#pods
>> > >
>> > >
>> > > On Wed, Apr 6, 2016 at 5:52 PM Joe Bowser  wrote:
>> > >
>> > > > Hey
>> > > >
>> > > > I recently looked at how native Android developers could use the
>> > current
>> > > > Cordova code with their projects, and I've noticed that there's some
>> > > major
>> > > > problems with our current approach of just copying the Java classes
>> > into
>> > > a
>> > > > project, such as resources getting merged together, and other
>> related
>> > > > issues, so I created a project that instead uses the InAppBrowser
>> > source
>> > > as
>> > > > an Android Library instead of just code thrown over the wall.
>> > > >
>> > > > The main advantage of this approach is that we can now build the
>> > library
>> > > as
>> > > > an AAR and distribute the plugins and the platform using jcenter and
>> > > > mavenCentral and allow more Android developers to be able to use
>> > Cordova
>> > > in
>> > > > their apps and make their apps more hybrid.
>> > > >
>> > > > Anyway, the example code is here.
>> > > >
>> > > > https://github.com/infil00p/Library-Dev-Project
>> > > >
>> > > > I used a Cordova application to demonstrate this, but I could have
>> > easily
>> > > > used a vanilla Android project.  Hopefully this also allows for
>> certain
>> > > > plugins like the InAppBrowser to be a lot more managable and will
>> also
>> > > > allow us to add more unit tests to our projects.
>> > > >
>> > > > Any thoughts on this approach versus our current one?
>> > > >
>> > >
>> >
>>
>
>

[GitHub] cordova-plugin-file pull request: CB-10960 Uncaught # i...

[nikhilkh]

Github user nikhilkh commented on the pull request:


https://github.com/apache/cordova-plugin-file/pull/177#issuecomment-207000261
  
@rakatyal  @jasongin Can you please review?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file pull request: CB-10960 Uncaught # i...

[daserge]

Github user daserge commented on the pull request:


https://github.com/apache/cordova-plugin-file/pull/177#issuecomment-207004588
  
Please find the issue details in the 
[Jira](https://issues.apache.org/jira/browse/CB-10960).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] cordova-ios release

[Shazron]

Update: looks like it looks like an ios-deploy thing
https://github.com/phonegap/ios-deploy/pull/218#issuecomment-206895124

On Tue, Apr 5, 2016 at 4:47 PM, Nikhil Khandelwal
 wrote:
> I noticed there is an issue with ios-deploy/cordova-ios & Xcode 7.3. This 
> seems fairly high priority: CB-10962.
>
> If the fix/workaround happens to be in cordova-ios - we might have to do 
> another release or add it to this release.
>
> -Nikhil
>
> -Original Message-
> From: Shazron [mailto:shaz...@gmail.com]
> Sent: Tuesday, April 5, 2016 12:17 PM
> To: dev@cordova.apache.org
> Subject: Re: [DISCUSS] cordova-ios release
>
> When I do a "cordova run --device" and I don't have ios-deploy installed, I 
> don't get the warning anymore to install it, just a "Error: spawn ios-deploy 
> ENOENT". Not sure when this behaviour changed. Don't think it should stall 
> the release though.
>
> On Tue, Apr 5, 2016 at 9:33 AM, Edna Y Morales  wrote:
>
>> Thanks, Mefire!
>>
>> So there is an issue with the archive that I published on dist/dev. I
>> don't see the issue when I install from git so it must be something in
>> the packaging that I'll need to investigate. I'll close the vote as
>> Failed, republish and restart the vote.
>>
>> Thanks,
>> *Edna Morales*
>>
>> [image: Inactive hide details for "Mefire O." ---04/04/2016 02:02:29
>> PM---LGTM! Thanks,]"Mefire O." ---04/04/2016 02:02:29 PM---LGTM!
>> Thanks,
>>
>> From: "Mefire O." 
>> To: "dev@cordova.apache.org" 
>> Date: 04/04/2016 02:02 PM
>> Subject: RE: [DISCUSS] cordova-ios release
>> --
>>
>>
>>
>> LGTM!
>>
>> Thanks,
>> Mefire
>>
>> From: Edna Y Morales [mailto:eymor...@us.ibm.com
>> ]
>> Sent: Monday, April 4, 2016 10:47 AM
>> To: dev@cordova.apache.org
>> Subject: Re: [DISCUSS] cordova-ios release
>>
>>
>> Can someone review the blog post?
>> https://github.com/apache/cordova-docs/pull/571
>>
>> Thanks,
>> Edna Morales
>>
>> [Inactive hide details for Shazron ---03/30/2016 08:28:03 PM---Thanks
>> Edna
>> - appreciated :) On Wed, Mar 30, 2016 at 8:15 AM, Edn]Shazron
>> ---03/30/2016
>> 08:28:03 PM---Thanks Edna - appreciated :) On Wed, Mar 30, 2016 at
>> 8:15 AM, Edna Y Morales
>> mailto:eymor...@us.ibm.com
>> >> w
>>
>> From: Shazron mailto:shaz...@gmail.com
>> >>
>> To: "dev@cordova.apache.org> >" > mailto:dev@cordova.apache.org >>
>> Date: 03/30/2016 08:28 PM
>> Subject: Re: [DISCUSS] cordova-ios release
>>
>> 
>>
>>
>>
>> Thanks Edna - appreciated :)
>>
>> On Wed, Mar 30, 2016 at 8:15 AM, Edna Y Morales > mailto:eymor...@us.ibm.com >> wrote:
>>
>> > Hi,
>> >
>> > I'd like to drive the release for cordova-ios 4.1.1. Does anyone
>> > have any oppositions or any reason to wait?
>> >
>> > Thanks,
>> > *Edna Morales*
>> >
>> > [image: Inactive hide details for Edna Y Morales---03/24/2016
>> > 09:41:54 AM---bump to this discussion since cordova-common has been
>> > relea]Edna Y
>> > Morales---03/24/2016 09:41:54 AM---bump to this discussion since
>> > cordova-common has been released Thanks,
>> >
>> > From: Edna Y Morales/Durham/IBM@IBMUS
>> > To: dev@cordova.apache.org> >
>> > Date: 03/24/2016 09:41 AM
>> > Subject: Re: [DISCUSS] cordova-ios release
>> > --
>> >
>> >
>> >
>> > bump to this discussion since cordova-common has been released
>> >
>> > Thanks,
>> > *Edna Morales*
>> >
>> > Shazron ---03/18/2016 10:34:07 PM---Another issue, the bundled
>> > ios-sim should be updated:
>> > *https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fis
>> > sues.apache.org%2fjira%2fbrowse%2fCB-10912*&data=01%7c01%7cnikhilkh%
>> > 40microsoft.com%7c4a29ffd994df47e66dcf08d35d86fc89%7c72f988bf86f141a
>> > f91ab2d7cd011db47%7c1&sdata=hWsxSWxXwjFcl%2ftP3XY04Emzg%2bnEgt6xN8MW
>> > 9ghN0uU%3d
>> > > > sues.apache.org%2fjira%2fbrowse%2fCB-10912&data=01%7c01%7cnikhilkh%4
>> > 0microsoft.com%7c4a29ffd994df47e66dcf08d35d86fc89%7c72f988bf86f141af
>> > 91ab2d7cd011db47%7c1&sdata=gIwwkud1HusezoWEVChconGHAfe96DyiSPnYW6xRm
>> > No%3d<
>> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissue
>> s.apache.org%2fjira%2fbrowse%2fCB-10912&data=01%7c01%7commenjik%40micr
>> osoft.com%7c245cd1554777444c794c08d35cb10aae%7c72f988bf86f141af91ab2d7
>> cd011db47%7c1&sdata=b2DfQhpWhLbsxXZEoWdT9hEPte9ex2zshJndNU8k0F4%3d
>> >>
>> >
>> > From: Shazron mailto:shaz...@gmail.com
>> >>
>> > To: "dev@cordova.apache.org> >" > mailto:dev@cordova.apache.org >>
>> > Date: 03/18/2016 10:34 PM
>> > Subject: Re: [DISCUSS] cordova-ios release
>> > --
>> >
>> >
>> >
>> > Another issue, the bundled ios-sim should be updated:
>> > *https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fis
>> > sues.apache.org%2fjira%2fbrowse%2fCB-10912*&data=01%7c01%7cnikhilkh%
>> > 40microsoft.com%7c4a29ffd994df47e66dcf08d35d86

Re: New Docs Look

[Shazron]

Nice! Thank you!

On Wed, Apr 6, 2016 at 6:32 PM, Dmitry Blotsky  wrote:
> Check it out! http://cordova.apache.org/docs/

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-8383 Handle pause event when keep...

[GitRubb]

GitHub user GitRubb opened a pull request:

https://github.com/apache/cordova-android/pull/288

CB-8383 Handle pause event when keeprunning=false

I added this pull request to hopefully get some attention to this bug 
https://issues.apache.org/jira/browse/CB-8383. When keeprunning = false in 
config.xml, any pause event processing is halted until the app returns. Not 
only is the pause event missed on app backgrounding, but on return it processes 
the pause and resume events.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/GitRubb/cordova-android master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-android/pull/288.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #288


commit 101ac992a1bac00863177bba42735389dbef3206
Author: GitRubb 
Date:   2016-04-07T18:09:30Z

CB-8383 Handle pause event when keeprunning=false 

I added this pull request to hopefully get some attention to this bug 
https://issues.apache.org/jira/browse/CB-8383. When keeprunning = false in 
config.xml, any pause event processing is halted until the app returns. Not 
only is the pause event missed on app backgrounding, but on return it processes 
the pause and resume events.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file pull request: CB-10960 Uncaught # i...

[jasongin]

Github user jasongin commented on a diff in the pull request:

https://github.com/apache/cordova-plugin-file/pull/177#discussion_r58919879
  
--- Diff: www/FileWriter.js ---
@@ -107,8 +108,29 @@ FileWriter.prototype.write = function(data) {
 var fileReader = new FileReader();
 fileReader.onload = function() {
 // Call this method again, with the arraybuffer as argument
-FileWriter.prototype.write.call(that, this.result);
+FileWriter.prototype.write.call(that, this.result, true /* 
isPendingBlobReadResult */);
 };
+fileReader.onerror = function (evt) {
+// DONE state
+that.readyState = FileWriter.DONE;
--- End diff --

Do you need to check if this FileWriter is already in the DONE (cancelled) 
state, as in the other callbacks below?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file pull request: CB-10960 Uncaught # i...

[jasongin]

Github user jasongin commented on a diff in the pull request:

https://github.com/apache/cordova-plugin-file/pull/177#discussion_r58922573
  
--- Diff: www/FileWriter.js ---
@@ -107,8 +108,29 @@ FileWriter.prototype.write = function(data) {
 var fileReader = new FileReader();
 fileReader.onload = function() {
 // Call this method again, with the arraybuffer as argument
-FileWriter.prototype.write.call(that, this.result);
+FileWriter.prototype.write.call(that, this.result, true /* 
isPendingBlobReadResult */);
 };
+fileReader.onerror = function (evt) {
+// DONE state
+that.readyState = FileWriter.DONE;
+
+// Save error
+that.error = evt.target.error;
--- End diff --

I think **evt.target** here is the same as **this** in the callback, and 
they both refer to the FileReader instance, right? It's a bit confusing that 
you use **evt.target** here, but **this** is used in the **onload** callback. 
(I can't actually find documentation that says **this** in a FileReader 
callback is set to the FileReader, though it seems like a reasonable 
assumption.)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: Appium tests stability improve...

[riknoll]

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/202#issuecomment-207042099
  
I'm not sure if this is a limitation of the way appium injects functions, 
but since the promise-related callbacks seem to be the same for iOS and 
Android, can they be moved to a common location?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file pull request: CB-10960 Uncaught # i...

[jasongin]

Github user jasongin commented on the pull request:


https://github.com/apache/cordova-plugin-file/pull/177#issuecomment-207042297
  
LGTM aside from the minor issues I commented on.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: Appium tests stability improve...

[riknoll]

Github user riknoll commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-camera/pull/202#discussion_r58923139
  
--- Diff: appium-tests/android/android.spec.js ---
@@ -450,143 +306,110 @@ describe('Camera tests Android.', function () {
 throw 'Couldn\'t find "Choose video" element.';
 });
 })
-.then(win, fail)
+.fail(saveScreenshotAndFail)
 .deviceKeyEvent(4)
-.sleep(2000)
-.deviceKeyEvent(4)
-.sleep(2000)
 .elementById('action_bar_title')
 .then(function () {
 // success means we're still in native app
 return driver
 .deviceKeyEvent(4)
--- End diff --

It would be nice to have constants clarifying these `deviceKeyEvent` 
numbers. I'm guessing that this corresponds to pressing the back button?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file pull request: CB-10960 Uncaught # i...

[rakatyal]

Github user rakatyal commented on a diff in the pull request:

https://github.com/apache/cordova-plugin-file/pull/177#discussion_r58923252
  
--- Diff: www/FileWriter.js ---
@@ -107,8 +108,29 @@ FileWriter.prototype.write = function(data) {
 var fileReader = new FileReader();
 fileReader.onload = function() {
 // Call this method again, with the arraybuffer as argument
-FileWriter.prototype.write.call(that, this.result);
+FileWriter.prototype.write.call(that, this.result, true /* 
isPendingBlobReadResult */);
 };
+fileReader.onerror = function (evt) {
+// DONE state
+that.readyState = FileWriter.DONE;
+
+// Save error
+that.error = evt.target.error;
--- End diff --

+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file pull request: CB-10960 Uncaught # i...

[rakatyal]

Github user rakatyal commented on the pull request:


https://github.com/apache/cordova-plugin-file/pull/177#issuecomment-207044636
  
LGTM as well aside from Jason's feedback.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Roadmap for next few weeks - Microsoft - April Edition

[Parashuram N]

Hey folks,

Last month, we sent out a list of things that the team at Microsoft was working 
on, for the Apache Cordova project. You can find that list here - 
http://apache.markmail.org/thread/lqvfduev3ib2ob62

We made a lot of progress, and I wanted to keep up the cadence, telling people 
what we plan to work on. I am hoping that with this list available, folks can 
tell us if there are interesting things we should look at, or even better – 
join us on working on all the fun stuff.

From last week

Last week, most of our focus was on making documentation better. We made some 
good progress on that, and now have an improved look for the documentation. We 
also started adding much more detailed examples to our plugins so that anyone 
getting started with plugins could simply copy the examples and see them in 
action.
We worked on the splash screen and camera bugs, and have closed a large number. 
Many folks told us that plugins bugs are a cause of concern, and we would like 
to cause a dent in that bug debt.


In the near Future
===
Cordova’s power it its community and I think that we would like to encourage 
more people in making Cordova better. We are looking at building a system to 
run tests when someone submits a PR – a method that most open source projects 
follow to easily respond to pull request. We would like to continue fixing bugs 
on Camera plugins.
We would also like to switch gears a little bit an focus on the phonegap 
barcode scanner plugin, and the phonegap push plugin. Typically, we are looking 
to add features like background support for Windows in the push plugin, android 
M support in Barcode scanner, etc. While these plugins are not core Cordova 
plugins, these are super popular and people have even asked that they be core 
plugins !
We would also like to work on things like Plugin compatibility when folks 
update their platforms, etc.


P.S: Please do let us know if these emails from us are useful and if we should 
continue sending them. Would also love to hear what you fine folks are working 
on, in the near future :)

[GitHub] cordova-plugin-file pull request: adding sample section to readme

[jasongin]

Github user jasongin commented on a diff in the pull request:

https://github.com/apache/cordova-plugin-file/pull/176#discussion_r58928048
  
--- Diff: README.md ---
@@ -671,89 +718,111 @@ window.requestFileSystem(window.TEMPORARY, 5 * 1024 
* 1024, function (fs) {
 }, onErrorLoadFs);
 ```
 
-For completeness, here is the xhr request to get a Blob image. There is 
nothing Cordova-specific in this code, except that you forward the 
DirectoryEntry reference that you already obtained as an argument to the 
saveFile function. You will save the image as a DOM string URL and display it 
later after reading the file (to validate the operation).
+For completeness, here is the xhr request to get a Blob image. There is 
nothing Cordova-specific in this code, except that you forward the 
DirectoryEntry reference that you already obtained as an argument to the 
saveFile function. You will save the blob image and display it later after 
reading the file (to validate the operation).
 
-```
+```js
 function getSampleFile(dirEntry) {
 
 var xhr = new XMLHttpRequest();
 xhr.open('GET', 
'http://cordova.apache.org/static/img/cordova_bot.png', true);
 xhr.responseType = 'blob';
 
-xhr.onload = function (e) {
+xhr.onload = function() {
 if (this.status == 200) {
 
 var blob = new Blob([this.response], { type: 'image/png' });
-var img = new Image();
-// Note: Use window.URL.revokeObjectURL when finished with 
image.
-img.src = window.URL.createObjectURL(blob);
-
-saveFile(dirEntry, img.src, "downloadedImage.png");
+saveFile(dirEntry, blob, "downloadedImage.png");
 }
 };
 xhr.send();
 }
 ```
 >*Note* For Cordova 5 security, the preceding code requires that you add 
the domain name, http://cordova.apache.org, to the Content-Security-Policy 
 element in index.html.
 
-After getting the file, copy the contents to a new file. The current 
DirectoryEntry object is already associated the app cache.
+After getting the file, copy the contents to a new file. The current 
DirectoryEntry object is already associated with the app cache.
 
-```
-function saveFile(dirEntry, srcImage, fileName) {
+```js
+function saveFile(dirEntry, fileData, fileName) {
 
 dirEntry.getFile(fileName, { create: true, exclusive: false }, 
function (fileEntry) {
 
-writeFile(fileEntry, srcImage);
+writeFile(fileEntry, fileData);
 
 }, onErrorCreateFile);
 }
 ```
 
-In writeFile, you pass in the DOM string URL as the dataObj and you will 
save that in the new file.
+In writeFile, you pass in the Blob object as the dataObj and you will save 
that in the new file.
+
+```js
+function writeFile(fileEntry, dataObj, isAppend) {
 
-```
-function writeFile(fileEntry, dataObj) {
 // Create a FileWriter object for our FileEntry (log.txt).
 fileEntry.createWriter(function (fileWriter) {
 
-fileWriter.onwriteend = function (e) {
+fileWriter.onwriteend = function() {
 console.log("Successful file write...");
-readFile(fileEntry);
+if (dataObj.type == "image/png") {
+readBinaryFile(fileEntry);
+}
+else {
+readFile(fileEntry);
+}
 };
 
-fileWriter.onerror = function (e) {
+fileWriter.onerror = function() {
--- End diff --

Oops, this e parameter is actually used below.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file pull request: adding sample section to readme

[jasongin]

Github user jasongin commented on a diff in the pull request:

https://github.com/apache/cordova-plugin-file/pull/176#discussion_r58928337
  
--- Diff: README.md ---
@@ -671,89 +718,111 @@ window.requestFileSystem(window.TEMPORARY, 5 * 1024 
* 1024, function (fs) {
 }, onErrorLoadFs);
 ```
 
-For completeness, here is the xhr request to get a Blob image. There is 
nothing Cordova-specific in this code, except that you forward the 
DirectoryEntry reference that you already obtained as an argument to the 
saveFile function. You will save the image as a DOM string URL and display it 
later after reading the file (to validate the operation).
+For completeness, here is the xhr request to get a Blob image. There is 
nothing Cordova-specific in this code, except that you forward the 
DirectoryEntry reference that you already obtained as an argument to the 
saveFile function. You will save the blob image and display it later after 
reading the file (to validate the operation).
 
-```
+```js
 function getSampleFile(dirEntry) {
 
 var xhr = new XMLHttpRequest();
 xhr.open('GET', 
'http://cordova.apache.org/static/img/cordova_bot.png', true);
 xhr.responseType = 'blob';
 
-xhr.onload = function (e) {
+xhr.onload = function() {
 if (this.status == 200) {
 
 var blob = new Blob([this.response], { type: 'image/png' });
-var img = new Image();
-// Note: Use window.URL.revokeObjectURL when finished with 
image.
-img.src = window.URL.createObjectURL(blob);
-
-saveFile(dirEntry, img.src, "downloadedImage.png");
+saveFile(dirEntry, blob, "downloadedImage.png");
 }
 };
 xhr.send();
 }
 ```
 >*Note* For Cordova 5 security, the preceding code requires that you add 
the domain name, http://cordova.apache.org, to the Content-Security-Policy 
 element in index.html.
 
-After getting the file, copy the contents to a new file. The current 
DirectoryEntry object is already associated the app cache.
+After getting the file, copy the contents to a new file. The current 
DirectoryEntry object is already associated with the app cache.
 
-```
-function saveFile(dirEntry, srcImage, fileName) {
+```js
+function saveFile(dirEntry, fileData, fileName) {
 
 dirEntry.getFile(fileName, { create: true, exclusive: false }, 
function (fileEntry) {
 
-writeFile(fileEntry, srcImage);
+writeFile(fileEntry, fileData);
 
 }, onErrorCreateFile);
 }
 ```
 
-In writeFile, you pass in the DOM string URL as the dataObj and you will 
save that in the new file.
+In writeFile, you pass in the Blob object as the dataObj and you will save 
that in the new file.
+
+```js
+function writeFile(fileEntry, dataObj, isAppend) {
 
-```
-function writeFile(fileEntry, dataObj) {
 // Create a FileWriter object for our FileEntry (log.txt).
 fileEntry.createWriter(function (fileWriter) {
 
-fileWriter.onwriteend = function (e) {
+fileWriter.onwriteend = function() {
 console.log("Successful file write...");
-readFile(fileEntry);
+if (dataObj.type == "image/png") {
+readBinaryFile(fileEntry);
+}
+else {
+readFile(fileEntry);
+}
 };
 
-fileWriter.onerror = function (e) {
+fileWriter.onerror = function() {
 console.log("Failed file write: " + e.toString());
 };
 
-// If data object is not passed in,
-// create a new Blob instead.
-if (!dataObj) {
-dataObj = new Blob(['some file data'], { type: 'text/plain' });
-}
-
 fileWriter.write(dataObj);
 });
 }
 ```
 
-After writing to the file, read it and display it. These operations re-use 
the code that we showed you already in previous tasks, so theres nothing new 
there (see the previous sections). After reading the data, you can display the 
image using code like this.
+After writing to the file, read it and display it. You saved the image as 
binary data, so you can read it using FileReader.readAsArrayBuffer.
+
+```js
+function readBinaryFile(fileEntry) {
+
+fileEntry.file(function (file) {
+var reader = new FileReader();
+
+reader.onloadend = function() {
 
+console.log("Successful file write: " + this.result);
+displayFileData(fileEntry.fullPath + ": " + this.result);
+
+var blob = new Blob([new Uint8Array(this.result)], { type: 
"image/png" });
+displayImage(blob);
+};

[GitHub] cordova-plugin-file pull request: adding sample section to readme

[jasongin]

Github user jasongin commented on a diff in the pull request:

https://github.com/apache/cordova-plugin-file/pull/176#discussion_r58927585
  
--- Diff: README.md ---
@@ -36,9 +36,9 @@ Although most of the plugin code was written when an 
earlier spec was current:
 It also implements the FileWriter spec :
 
[http://dev.w3.org/2009/dap/file-system/file-writer.html](http://dev.w3.org/2009/dap/file-system/file-writer.html)
 
->*Note* For browser targets, some of the file system APIs are deprecated, 
but many of the APIs are supported in Cordova for the non-browser platforms 
listed in the _Supported Platforms_ list (see below).
+>*Note* For Cordova clients that run in native WebViews (for example, iOS 
and Android) or as native apps (Windows), many of the W3C APIs FileSystem are 
supported. This is true for the platforms listed in the _Supported Platforms_ 
list except the Browser platform. On the Browser platform, many of these APIs 
are deprecated.
--- End diff --

"W3C APIs FileSystem" => "W3C FileSystem APIs"

Avoid the term "native apps" to refer to Cordova apps on Windows. Even 
though Windows has built-in support for HTML/JS apps, most developers would not 
consider Cordova apps to be "native". (also on line 562)

How about something like this:
While the W3C FileSystem spec is deprecated for web browsers, the 
FileSystem APIs are supported in Cordova applications with this plugin for the 
platforms listed in the _Supported Platforms_ list, with the exception of the 
Browser platform.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file pull request: adding sample section to readme

[jasongin]

Github user jasongin commented on a diff in the pull request:

https://github.com/apache/cordova-plugin-file/pull/176#discussion_r58928914
  
--- Diff: README.md ---
@@ -36,7 +36,9 @@ Although most of the plugin code was written when an 
earlier spec was current:
 It also implements the FileWriter spec :
 
[http://dev.w3.org/2009/dap/file-system/file-writer.html](http://dev.w3.org/2009/dap/file-system/file-writer.html)
 
-For usage, please refer to HTML5 Rocks' excellent [FileSystem 
article.](http://www.html5rocks.com/en/tutorials/file/filesystem/)
+>*Note* For Cordova clients that run in native WebViews (for example, iOS 
and Android) or as native apps (Windows), many of the W3C APIs FileSystem are 
supported. This is true for the platforms listed in the _Supported Platforms_ 
list except the Browser platform. On the Browser platform, many of these APIs 
are deprecated.
--- End diff --

"W3C APIs FileSystem" => "W3C FileSystem APIs"

Avoid the term "native apps" to refer to Cordova apps on Windows. Even 
though Windows has built-in support for HTML/JS apps, most developers would not 
consider Cordova apps to be "native". (also on line 562)

How about something like this:
 While the W3C FileSystem spec is deprecated for web browsers, the 
FileSystem APIs are supported in Cordova applications with this plugin for the 
platforms listed in the Supported Platforms list, with the exception of the 
Browser platform.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file pull request: adding sample section to readme

[jasongin]

Github user jasongin commented on a diff in the pull request:

https://github.com/apache/cordova-plugin-file/pull/176#discussion_r58929077
  
--- Diff: README.md ---
@@ -538,3 +540,298 @@ Android also supports a special filesystem named 
"documents", which represents a
 * `root`: The entire device filesystem
 
 By default, the library and documents directories can be synced to iCloud. 
You can also request two additional filesystems, `library-nosync` and 
`documents-nosync`, which represent a special non-synced directory within the 
`/Library` or `/Documents` filesystem.
+
+## Sample: Create Files and Directories, Write, Read, and Append files 
+
+The File plugin allows you to do things like store files in a temporary or 
persistent storage location for your app (sandboxed storage) and to store files 
in other platform-dependent locations. The code snippets in this section 
demonstrate different tasks including:
+* Accessing the file system
+* Using cross-platform Cordova file URLs to store your files (see _Where 
to Store Files_ for more info)
+* Creating files and directories
+* Writing to files
+* Reading files
+* Appending files
+
+## Create a persistent file
+
+Before you use the File plugin APIs, you can get access to the file system 
using `requestFileSystem`. When you do this, you can request either persistent 
or temporary storage. Persistent storage will not be removed unless permission 
is granted by the user.
+
+When you get file system access using `requestFileSystem`, access is 
granted for the sandboxed file system only (the sandbox limits access to the 
app itself), not for general access to any file system location on the device. 
(To access file system locations outside the sandboxed storage, use other 
methods such as window.requestLocalFileSystemURL, which support 
platform-specific locations. For one example of this, see _Append a File_.)
+
+Here is a request for persistent storage.
+
+>*Note* When targeting WebView clients (instead of a browser) or native 
apps (Windows), you dont need to use `requestQuota` before using persistent 
storage.
+
+```js
+window.requestFileSystem(LocalFileSystem.PERSISTENT, 0, function (fs) {
+
+console.log('file system open: ' + fs.name);
+fs.root.getFile("newPersistentFile.txt", { create: true, exclusive: 
false }, function (fileEntry) {
+
+console.log("fileEntry is file?" + fileEntry.isFile.toString());
+// fileEntry.name == 'someFile.txt'
+// fileEntry.fullPath == '/someFile.txt'
+writeFile(fileEntry, null);
+
+}, onErrorCreateFile);
+
+}, onErrorLoadFs);
+```
+
+The success callback receives FileSystem object (fs). Use `fs.root` to 
return a DirectoryEntry object, which you can use to create or get a file (by 
calling `getFile`). In this example, `fs.root` is a DirectoryEntry object that 
represents the persistent storage in the sandboxed file system.
+
+The success callback for `getFile` receives a FileEntry object. You can 
use this to perform file write and file read operations.
+
+## Create a temporary file
+
+Here is an example of a request for temporary storage. Temporary storage 
may be deleted by the operating system if the device runs low on memory.
+
+```js
+window.requestFileSystem(window.TEMPORARY, 5 * 1024 * 1024, function (fs) {
+
+console.log('file system open: ' + fs.name);
+createFile(fs.root, "newTempFile.txt", false);
+
+}, onErrorLoadFs);
+```
+When you are using temporary storage, you can create or get the file by 
calling `getFile`. As in the persistent storage example, this will give you a 
FileEntry object that you can use for read or write operations.
+
+```js
+function createFile(dirEntry, fileName, isAppend) {
+// Creates a new file or returns the file if it already exists.
+dirEntry.getFile(fileName, {create: true, exclusive: false}, 
function(fileEntry) {
+
+writeFile(fileEntry, null, isAppend);
+
+}, onErrorCreateFile);
+
+}
+```
+
+## Write to a file
+
+Once you have a FileEntry object, you can write to the file by calling 
`createWriter`, which returns a FileWriter object in the success callback. Call 
the `write` method of FileWriter to write to the file.
+
+```js
+function writeFile(fileEntry, dataObj) {
+// Create a FileWriter object for our FileEntry (log.txt).
+fileEntry.createWriter(function (fileWriter) {
+
+fileWriter.onwriteend = function (e) {
+console.log("Successful file read...");
+readFile(fileEntry);
+};
+
+fileWriter.onerror = function (e) {
+console.log("Failed file read: " + e.toString());
+};
+

[GitHub] cordova-windows pull request: CB-11024: Add preference to set the ...

[rakatyal]

GitHub user rakatyal opened a pull request:

https://github.com/apache/cordova-windows/pull/165

CB-11024: Add preference to set the min UAP target version in the JSP…

…roj File

The current preferences allow the user to set the target and min versions 
in the appxmanifest files. The  target min version currently is set to be the 
minimum SDK installed on the user machine. This change allows the user to 
change it using this new preference else defaults it to '10.0.10240.0' 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-windows raghav/minversion

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-windows/pull/165.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #165


commit 303293d025985b75aa46fa9fe1e8b30fba22e562
Author: Raghav Katyal 
Date:   2016-04-07T19:14:30Z

CB-11024: Add preference to set the min UAP target version in the JSProj 
File




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: CB-11024: Add preference to set the ...

[jasongin]

Github user jasongin commented on the pull request:

https://github.com/apache/cordova-windows/pull/165#issuecomment-207058473
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request: Added Android cookie sha...

[JPustkuchen]

Github user JPustkuchen commented on the pull request:


https://github.com/apache/cordova-plugin-inappbrowser/pull/122#issuecomment-207060533
  
+1 for this merge. A really useful feature! :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request: inAppBrowser custom appl...

[JPustkuchen]

Github user JPustkuchen commented on the pull request:


https://github.com/apache/cordova-plugin-inappbrowser/pull/99#issuecomment-207061483
  
I can confirm that this is really an important feature request. For example 
we want to use skype:// and whatsapp:// links within the webview. The problem 
is, that loadstart acts async and so even a workaround in the event to prevent 
loading the protocol as page is not possible.

A possible and safe solution (from my point of view) could be a new 
"beforeloadstart" event which allows to return false and take the url parameter 
for custom handling. The url should not be prefixed by http:// like currently 
in loadstart. So we can introduce our own custom logic in JS without hacking 
the plugin.

What do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

RE: [VOTE] 4.1.1 iOS Release - Take 2

[Edna Y Morales]

The vote has now closed. The results are:

Positive Binding Votes: 3

Edna Morales
Jesse MacFadyen
Alexander Sorokin


The vote has passed.

Thanks,
Edna Morales



From:   "Alexander Sorokin (Akvelon)" 
To: "dev@cordova.apache.org" 
Date:   04/07/2016 12:28 PM
Subject:RE: [VOTE] 4.1.1 iOS Release - Take 2



I vote +1:

* Verified archives via `coho verify-archive`
* Verified tags manually
* Verified that blank app creates correctly with platform
* Verified that blank app can be successfully ran and built
* Verified that platform can be updated from previous version
* Verified compatibility with core plugins (ran mobilespec for released and
edge versions)
* Checked for whitespace issues
* Checked for Unicode issues
* Verified version
* Verified line breaks

-Original Message-
From: Jesse [mailto:purplecabb...@gmail.com]
Sent: Thursday, April 7, 2016 9:34 AM
To: dev@cordova.apache.org
Subject: Re: [VOTE] 4.1.1 iOS Release - Take 2

+1

- Ran coho audit-license-headers
- Ran coho check-license
- Ran coho verify archive
- Ran iOS native tests > Good signature from "Edna Morales"
- Created and ran hello world iOS app with CLI



@purplecabbage
https://na01.safelinks.protection.outlook.com/?url=risingj.com&data=01%7c01%7cv-alsoro%40microsoft.com%7c43edcedae49b4e6bbe3908d35eaeac46%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=zLJPSjVixkTXxCb0vsEXrFDyCp9rEpkwftmXmFhqanY%3d


On Tue, Apr 5, 2016 at 10:51 AM, Edna Y Morales 
wrote:

>
>
> Please review and vote on this 4.1.1 iOS Release by replying to this
> email (and keep discussion on the DISCUSS thread)
>
> Release issue:
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissue
> s.apache.org%2fjira%2fbrowse%2fCB-11006&data=01%7c01%7cv-alsoro%40micr
> osoft.com%7c43edcedae49b4e6bbe3908d35eaeac46%7c72f988bf86f141af91ab2d7
> cd011db47%7c1&sdata=LqBRu%2bX5RJDv3kscYEDYbtLxpcYxeGELZJtYobeaiME%3d
>
> The archive has been published to dist/dev:
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fdist.
> apache.org%2frepos%2fdist%2fdev%2fcordova%2fCB-11006%2f&data=01%7c01%7
> cv-alsoro%40microsoft.com%7c43edcedae49b4e6bbe3908d35eaeac46%7c72f988b
> f86f141af91ab2d7cd011db47%7c1&sdata=IganzibFulOMsjHAJolq8UM6K5toA8g0N0
> aBSPG88hY%3d
>
> The package was published from its corresponding git tag:
> cordova-ios: 4.1.1 (c5c33bad30)
>
> Note that you can test it out via:
>
> cordova platform add https://github.com/apache/cordova-ios#4.1.1
>
> Upon a successful vote I will upload the archive to dist/, publish it
> to npm, and post the blog post.
>
> Voting guidelines:
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting
> .md
>
> Voting will go on for a minimum of 48 hours.
>
> I vote +1:
> * Ran coho audit-license-headers over the relevant repos
> * Ran coho check-license to ensure all dependencies and
> subdependencies have Apache-compatible licenses
> * Ensured continuous build was green when repo was tagged
> * Ran mobile-spec (iOS)
> * Created and ran hello world iOS app with CLI
> * Created and ran hello world iOS app non-CLI
> * Tested ./bin/create script
> * Tested project upgrade from 4.1.0 to 4.1.1 with CLI
> * Tested project upgrade from 4.1.0 to 4.1.1 non-CLI
> * Ran cordova-lib tests
> * Ran iOS native tests
> * Ran coho verify-archive
>
> Thanks,
> Edna Morales
>

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file pull request: adding sample section to readme

[jasongin]

Github user jasongin commented on the pull request:


https://github.com/apache/cordova-plugin-file/pull/176#issuecomment-207076949
  
Looks good, thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-11006 add ios@4.1.1 release blog pos...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/571


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10770 Remove cache-min when adding pl...

[nikhilkh]

GitHub user nikhilkh opened a pull request:

https://github.com/apache/cordova-lib/pull/422

CB-10770 Remove cache-min when adding platforms



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-lib cache-min

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/422.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #422


commit dc84fb9cb7faa0a89539de7aaae2e25deb806c99
Author: Nikhil Khandelwal 
Date:   2016-04-07T21:23:52Z

CB-10770 Remove cache-min when adding platforms




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-11020, CB-11040 Documenting event fi...

[rakatyal]

Github user rakatyal commented on the pull request:

https://github.com/apache/cordova-docs/pull/573#issuecomment-207100260
  
@jasongin, @riknoll : Please review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-11020, CB-11040 Documenting event fi...

[rakatyal]

GitHub user rakatyal opened a pull request:

https://github.com/apache/cordova-docs/pull/573

CB-11020, CB-11040 Documenting event firing details in VS and the uap…

…-target-min-version preference

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-docs raghav/pref_doc

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/573.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #573


commit caf94e5f983374cba565d919e5d2a75937faa720
Author: Raghav Katyal 
Date:   2016-04-07T21:41:17Z

CB-11020, CB-11040 Documenting event firing details in VS and the 
uap-target-min-version preference




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-10964 build.js script under "plat...

[nikhilkh]

Github user nikhilkh commented on the pull request:

https://github.com/apache/cordova-android/pull/286#issuecomment-207108814
  
This needs to be handled for other platforms too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: New Docs Look

[Jesse]

Yeah, looks great on an iPhone 6!


@purplecabbage
risingj.com

On Thu, Apr 7, 2016 at 10:52 AM, Shazron  wrote:

> Nice! Thank you!
>
> On Wed, Apr 6, 2016 at 6:32 PM, Dmitry Blotsky 
> wrote:
> > Check it out! http://cordova.apache.org/docs/
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>

Re: New Docs Look

[Victor Sosa]

Nicely done!!

On Thu, Apr 7, 2016 at 5:20 PM Jesse  wrote:

> Yeah, looks great on an iPhone 6!
>
>
> @purplecabbage
> risingj.com
>
> On Thu, Apr 7, 2016 at 10:52 AM, Shazron  wrote:
>
> > Nice! Thank you!
> >
> > On Wed, Apr 6, 2016 at 6:32 PM, Dmitry Blotsky 
> > wrote:
> > > Check it out! http://cordova.apache.org/docs/
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
> >
>

[GitHub] cordova-plugin-media pull request: Streaming & Background threadin...

[purplecabbage]

Github user purplecabbage commented on the pull request:


https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-207117910
  
We are further and further off topic, but 
Why are you using `sudo` to install plugins @Taewa ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file pull request: adding sample section to readme

[RobPosener]

Github user RobPosener commented on the pull request:


https://github.com/apache/cordova-plugin-file/pull/176#issuecomment-207120687
  
I am able to get all of the File System APIs that I require to work 
correctly.  I can create directories and sub-directories.  I can create files 
and read files.
So I am confused by the "many of these APIs are depreciated" statement.  I 
think you should expand on this statement... Does it mean that the APIs work, 
but will be withdrawn?  Does it mean that they don't work? Which ones does 
"many" refer to?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file pull request: updated support for the OS X pla...

[purplecabbage]

Github user purplecabbage commented on the pull request:

https://github.com/apache/cordova-plugin-file/pull/42#issuecomment-207121298
  
This pr is hopelessly out of date. If it is still relevant, please rebase 
it, otherwise I will be closing it shortly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request: CB-10957 Remove build-*.xcconfig files f...

[omefire]

GitHub user omefire opened a pull request:

https://github.com/apache/cordova-ios/pull/214

CB-10957 Remove build-*.xcconfig files from build output



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/omefire/cordova-ios CB-10957

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-ios/pull/214.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #214


commit af8a442faa8c2907272c6d78a6dafcd014571e6c
Author: Omar Mefire 
Date:   2016-04-07T22:35:18Z

CB-10957 Remove build-*.xcconfig files from build output




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file pull request: adding sample section to readme

[jasongin]

Github user jasongin commented on the pull request:


https://github.com/apache/cordova-plugin-file/pull/176#issuecomment-207123605
  
Rob, what platform are you looking at?

The W3C FileSystems spec for web browsers is deprecated; what that 
effectively means is no other browsers will implement the spec. Chrome was the 
only browser to ever implement that spec, and I believe it still works in 
current builds of Chrome 

However, the Cordova file plugin implements that spec as a polyfill for 
Cordova platforms other than the "Browser" platform (because the Browser 
platform isn't able to call native plugin APIs). So it makes the deprecation of 
the spec mostly irrelevant for Cordova app developers.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request: CB-10957 Remove build-*.xcconfig files f...

[shazron]

Github user shazron commented on the pull request:

https://github.com/apache/cordova-ios/pull/214#issuecomment-207134051
  
This PR removes crucial functionality, namely the inheritance of build 
settings from the .xcconfig files:
![screen shot 2016-04-07 at 4 13 33 
pm](https://cloud.githubusercontent.com/assets/36107/14369665/d110f518-fcdb-11e5-892a-6dcb3c142aa6.png)

It should only remove the .xcconfig files from here in Build Phases for the 
Target:
![screen shot 2016-04-07 at 4 14 25 
pm](https://cloud.githubusercontent.com/assets/36107/14369661/c71a0e1e-fcdb-11e5-81ac-7154cb3bfc10.png)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request: CB-10957 Remove build-*.xcconfig files f...

[omefire]

Github user omefire commented on the pull request:

https://github.com/apache/cordova-ios/pull/214#issuecomment-207134914
  
Thanks @shazron, will recheck it and make appropriate changes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file pull request: updated support for the OS X pla...

[tripodsan]

Github user tripodsan commented on the pull request:

https://github.com/apache/cordova-plugin-file/pull/42#issuecomment-207138136
  
please close. we got osx support in the meantime added.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-11020, CB-11040 Documenting event fi...

[jasongin]

Github user jasongin commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/573#discussion_r58962639
  
--- Diff: www/docs/en/dev/config_ref/index.md ---
@@ -348,6 +349,7 @@ platform. See [Customize icons topic](images.html) for 
more information.



+   
--- End diff --

Maybe 10.0.10586.0 would be a better example?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-11020, CB-11040 Documenting event fi...

[jasongin]

Github user jasongin commented on the pull request:

https://github.com/apache/cordova-docs/pull/573#issuecomment-207138716
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request: CB-11041: cordova-plugin-con...

[sarangan12]

GitHub user sarangan12 opened a pull request:

https://github.com/apache/cordova-plugin-contacts/pull/119

CB-11041: cordova-plugin-contacts readme must be updated to include 
instructions on removing phone number from a contact

Refer 
[Link](https://issues.apache.org/jira/browse/CB-10976?focusedCommentId=15231307&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15231307)
 for details.

@riknoll @nikhilkh @rakatyal Can you review and merge this PR?

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sarangan12/cordova-plugin-contacts CB-11041

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-contacts/pull/119.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #119


commit 69c206f4290876b43dff7f5c73bb62474ddb5f11
Author: Sarangan Rajamanickam 
Date:   2016-04-07T23:48:21Z

CB-11041: cordova-plugin-contacts readme must be updated to include 
instructions on removing phone number from a contact




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request: CB-11041: cordova-plugin-con...

[riknoll]

Github user riknoll commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/119#discussion_r58963814
  
--- Diff: README.md ---
@@ -354,6 +354,35 @@ for details.
 // remove the contact from the device
 contact.remove(onSuccess,onError);
 
+### Removing phone number(s) from a saved contact
+
+var myContact = navigator.contacts.create({"displayName": "Test 
User"});
+var phoneNumbers = [];
+
+phoneNumbers[0] = new ContactField('work', '768-555-1234', false);
+phoneNumbers[1] = new ContactField('mobile', '999-555-5432', true); // 
preferred number
+phoneNumbers[2] = new ContactField('home', '203-555-7890', false);
+
+myContact.phoneNumbers = phoneNumbers;
+myContact.save(function (contact_obj) {
+var contactObjToModify = contact_obj.clone();
+contact_obj.remove(function(){
+// Note: Do NOT use delete operator. It will break in android.
+// delete contactObjToModify.phoneNumbers[1];
--- End diff --

I would say that if it is know to be broken in Android, just don't include 
the lines here. Leave the note but get rid of the commend out examples.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request: CB-11041: cordova-plugin-con...

[riknoll]

Github user riknoll commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/119#discussion_r58963991
  
--- Diff: README.md ---
@@ -354,6 +354,35 @@ for details.
 // remove the contact from the device
 contact.remove(onSuccess,onError);
 
+### Removing phone number(s) from a saved contact
+
+var myContact = navigator.contacts.create({"displayName": "Test 
User"});
+var phoneNumbers = [];
+
+phoneNumbers[0] = new ContactField('work', '768-555-1234', false);
+phoneNumbers[1] = new ContactField('mobile', '999-555-5432', true); // 
preferred number
+phoneNumbers[2] = new ContactField('home', '203-555-7890', false);
+
+myContact.phoneNumbers = phoneNumbers;
+myContact.save(function (contact_obj) {
--- End diff --

I would say it might be nicer to search for a contact and update it rather 
than creating a new one that immediately gets updated. A more realistic scenario


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request: CB-11041: cordova-plugin-con...

[sarangan12]

Github user sarangan12 commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/119#discussion_r58964196
  
--- Diff: README.md ---
@@ -354,6 +354,35 @@ for details.
 // remove the contact from the device
 contact.remove(onSuccess,onError);
 
+### Removing phone number(s) from a saved contact
+
+var myContact = navigator.contacts.create({"displayName": "Test 
User"});
+var phoneNumbers = [];
+
+phoneNumbers[0] = new ContactField('work', '768-555-1234', false);
+phoneNumbers[1] = new ContactField('mobile', '999-555-5432', true); // 
preferred number
+phoneNumbers[2] = new ContactField('home', '203-555-7890', false);
+
+myContact.phoneNumbers = phoneNumbers;
+myContact.save(function (contact_obj) {
+var contactObjToModify = contact_obj.clone();
+contact_obj.remove(function(){
+// Note: Do NOT use delete operator. It will break in android.
+// delete contactObjToModify.phoneNumbers[1];
--- End diff --

Done


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request: CB-11041: cordova-plugin-con...

[sarangan12]

Github user sarangan12 commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/119#discussion_r58964379
  
--- Diff: README.md ---
@@ -354,6 +354,35 @@ for details.
 // remove the contact from the device
 contact.remove(onSuccess,onError);
 
+### Removing phone number(s) from a saved contact
+
+var myContact = navigator.contacts.create({"displayName": "Test 
User"});
+var phoneNumbers = [];
+
+phoneNumbers[0] = new ContactField('work', '768-555-1234', false);
+phoneNumbers[1] = new ContactField('mobile', '999-555-5432', true); // 
preferred number
+phoneNumbers[2] = new ContactField('home', '203-555-7890', false);
+
+myContact.phoneNumbers = phoneNumbers;
+myContact.save(function (contact_obj) {
--- End diff --

The purpose is to provide a sample snippet. Adding code for find will just 
make it bigger (I already feel it is bigger and could be small) So, I am 
leaving it as such...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: Streaming & Background threadin...

[ghenry22]

Github user ghenry22 commented on the pull request:


https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-207159395
  
@purplecabbage comments on this PR could not possibly go further off topic 
:)  Seems to have become defacto media plugin support for a while there.

I had some odd permission issue on my mac initially and used sudo to 
install as well.  No matter what I did always had that problem, probably 
because I installed something early on with Sudo and then all the permissions 
became a mess.

Was resolved when I did a refresh of the OS on my mac and a clean install 
of all the tools without using sudo for anything.

Doesn't seem to hurt anything either way though and all build tools etc 
work.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: Fixing issues on Android 6.0

[ghenry22]

Github user ghenry22 commented on the pull request:


https://github.com/apache/cordova-plugin-media/pull/77#issuecomment-207159923
  
@purplecabbage there are 2 single line changes on this PR, one of which is 
already incorporated into master from another commit.  If the second one liner 
from here could be committed to trunk then this PR could be closed and media 
plugin would work normally on Marshmallow.

Seems like a very quick and easily resolution.  I have been using a fork of 
the plugin with change incorporated for around a month now (since I realised 
Marshmallow was broken!) with no issues.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer pull request: Fix cordova-plugin-file...

[robario]

GitHub user robario opened a pull request:

https://github.com/apache/cordova-plugin-file-transfer/pull/138

Fix cordova-plugin-file dependency

In plugin.xml

>  

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/robario/cordova-plugin-file-transfer patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-file-transfer/pull/138.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #138


commit 6a92f0503bc7bc7eb0912ebdf587db328c67113e
Author: robario 
Date:   2016-04-08T01:25:50Z

Fix cordova-plugin-file dependency

In plugin.xml

>  




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [GitHub] cordova-plugin-file pull request: adding sample section to readme

[Robert Posener]

1. Browser platform... the one under discussion.
2. I understood everything you say in your response paragraphs 2 and 3.
3. My points still remain... your statement "many of these APIs..." is
confusing.
4. Your words in paragraphs 2 and 3 of your response should be included as
clarification.
5. Replace "I believe it" with "Chrome Version 49.0.2623.112 m still works,
but there is no guarantee that this will continue."

Regards

Rob

Regards
*Rob Posener*
0419 012 627

On 8 April 2016 at 08:44, jasongin  wrote:

> Github user jasongin commented on the pull request:
>
>
> https://github.com/apache/cordova-plugin-file/pull/176#issuecomment-207123605
>
> Rob, what platform are you looking at?
>
> The W3C FileSystems spec for web browsers is deprecated; what that
> effectively means is no other browsers will implement the spec. Chrome was
> the only browser to ever implement that spec, and I believe it still works
> in current builds of Chrome
>
> However, the Cordova file plugin implements that spec as a polyfill
> for Cordova platforms other than the "Browser" platform (because the
> Browser platform isn't able to call native plugin APIs). So it makes the
> deprecation of the spec mostly irrelevant for Cordova app developers.
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>

[ANNOUNCE] cordova-ios 4.1.1 released

[Edna Y Morales]

cordova-ios@4.1.1 is on NPM now: https://www.npmjs.com/package/cordova-ios
Check out blog post at
https://cordova.apache.org/announcements/2016/04/04/ios-4.1.1.html and
retweet https://twitter.com/apachecordova/status/718229585758986241


Thanks,
Edna Morales

[GitHub] cordova-plugin-file pull request: updated support for the OS X pla...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-file/pull/42


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file pull request: CB-10960 Uncaught # i...

[daserge]

Github user daserge commented on a diff in the pull request:

https://github.com/apache/cordova-plugin-file/pull/177#discussion_r58983822
  
--- Diff: www/FileWriter.js ---
@@ -107,8 +108,29 @@ FileWriter.prototype.write = function(data) {
 var fileReader = new FileReader();
 fileReader.onload = function() {
 // Call this method again, with the arraybuffer as argument
-FileWriter.prototype.write.call(that, this.result);
+FileWriter.prototype.write.call(that, this.result, true /* 
isPendingBlobReadResult */);
 };
+fileReader.onerror = function (evt) {
+// DONE state
+that.readyState = FileWriter.DONE;
--- End diff --

I don't think so as the `DONE` state is being set in 
`FileReader.readSuccessCallback`, `FileReader.readFailureCallback` and 
`FileReader.abort` only.
`abort` should not be called outside (and we don't call it) taking into 
account that fileReader is an internal variable, `readSuccessCallback` calls 
`onload` and `readFailureCallback` calls `onerror` so we are covering all the 
cases.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file pull request: CB-10960 Uncaught # i...

[daserge]

Github user daserge commented on the pull request:


https://github.com/apache/cordova-plugin-file/pull/177#issuecomment-207234305
  
Thank you for the review!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file pull request: CB-10960 Uncaught # i...

[daserge]

Github user daserge commented on a diff in the pull request:

https://github.com/apache/cordova-plugin-file/pull/177#discussion_r58983833
  
--- Diff: www/FileWriter.js ---
@@ -107,8 +108,29 @@ FileWriter.prototype.write = function(data) {
 var fileReader = new FileReader();
 fileReader.onload = function() {
 // Call this method again, with the arraybuffer as argument
-FileWriter.prototype.write.call(that, this.result);
+FileWriter.prototype.write.call(that, this.result, true /* 
isPendingBlobReadResult */);
 };
+fileReader.onerror = function (evt) {
+// DONE state
+that.readyState = FileWriter.DONE;
+
+// Save error
+that.error = evt.target.error;
--- End diff --

Thanks, I will update it!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org