Github user riknoll commented on a diff in the pull request:

    
https://github.com/apache/cordova-plugin-camera/pull/202#discussion_r58923139
  
    --- Diff: appium-tests/android/android.spec.js ---
    @@ -450,143 +306,110 @@ describe('Camera tests Android.', function () {
                                 throw 'Couldn\'t find "Choose video" element.';
                             });
                     })
    -                .then(win, fail)
    +                .fail(saveScreenshotAndFail)
                     .deviceKeyEvent(4)
    -                .sleep(2000)
    -                .deviceKeyEvent(4)
    -                .sleep(2000)
                     .elementById('action_bar_title')
                     .then(function () {
                         // success means we're still in native app
                         return driver
                             .deviceKeyEvent(4)
    --- End diff --
    
    It would be nice to have constants clarifying these `deviceKeyEvent` 
numbers. I'm guessing that this corresponds to pressing the back button?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Reply via email to