Re: Release Commons Jelly 1.0.1 Based on RC2

2017-08-30 Thread Rob Tompkins 

> On Aug 30, 2017, at 1:22 AM, Bruno P. Kinoshita 
>  wrote:
> 
> Hi Rob,
> Thanks for RM'ing Commons Jelly 1.0.1. Here's my initial tests results:
> 
> Downloaded JDK from Oracle archives, version 5.0u22.
> 
> Then downloaded Apache Ant following what was in the Dockerfile.
> 
> curl 
> http://archive.apache.org/dist/ant/binaries/apache-ant-1.6.0-bin.tar.gz -o 
> /tmp/apache-ant-1.6.0-bin.tar.gz
> 
> And installed it to /opt.
> 
> Downloaded JUnit into Apache Ant's libraries folder.
> 
> curl 
> https://search.maven.org/remotecontent?filepath=junit/junit/3.8.1/junit-3.8.1.jar
>  -o /opt/apache-ant-1.6.0/lib/junit-3.8.1.jar
> 
> And downloaded other dependencies as in the Dockerfile/build.xml.
> 
> curl 
> https://search.maven.org/remotecontent?filepath=javax/servlet/servlet-api/2.3/servlet-api-2.3.jar
>  -o /${HOME}/.maven/repository/servletapi/jars/servletapi-2.3.jar
> curl 
> https://search.maven.org/remotecontent?filepath=commons-cli/commons-cli/1.0/commons-cli-1.0.jar
>  -o /${HOME}/.maven/repository/commons-cli/jars/commons-cli-1.0.jar
> curl 
> https://search.maven.org/remotecontent?filepath=commons-lang/commons-lang/2.0/commons-lang-2.0.jar
>  -o /${HOME}/.maven/repository/commons-lang/jars/commons-lang-2.0.jar
> curl 
> https://search.maven.org/remotecontent?filepath=commons-discovery/commons-discovery/20030211.213356/commons-discovery-20030211.213356.jar
>  -o 
> /${HOME}/.maven/repository/commons-discovery/jars/commons-discovery-20030211.213356.jar
> curl 
> https://search.maven.org/remotecontent?filepath=forehead/forehead/1.0-beta-5/forehead-1.0-beta-5.jar
>  -o /${HOME}/.maven/repository/forehead/jars/forehead-1.0-beta-5.jar
> curl 
> https://search.maven.org/remotecontent?filepath=javax/servlet/jstl/1.0.6/jstl-1.0.6.jar
>  -o /${HOME}/.maven/repository/jstl/jars/jstl-1.0.6.jar
> curl 
> https://search.maven.org/remotecontent?filepath=junit/junit/3.8.1/junit-3.8.1.jar
>  -o /${HOME}/.maven/repository/junit/jars/junit-3.8.1.jar
> curl 
> https://search.maven.org/remotecontent?filepath=commons-jexl/commons-jexl/1.0/commons-jexl-1.0.jar
>  -o /${HOME}/.maven/repository/commons-jexl/jars/commons-jexl-1.0.jar
> curl 
> https://search.maven.org/remotecontent?filepath=xml-apis/xml-apis/1.0.b2/xml-apis-1.0.b2.jar
>  -o /${HOME}/.maven/repository/xml-apis/jars/xml-apis-1.0.b2.jar
> curl 
> https://search.maven.org/remotecontent?filepath=commons-beanutils/commons-beanutils/1.6/commons-beanutils-1.6.jar
>  -o 
> /${HOME}/.maven/repository/commons-beanutils/jars/commons-beanutils-1.6.jar
> curl 
> https://search.maven.org/remotecontent?filepath=commons-collections/commons-collections/2.1/commons-collections-2.1.jar
>  -o 
> /${HOME}/.maven/repository/commons-collections/jars/commons-collections-2.1.jar
> curl 
> https://search.maven.org/remotecontent?filepath=commons-logging/commons-logging/1.0.3/commons-logging-1.0.3.jar
>  -o /${HOME}/.maven/repository/commons-logging/jars/commons-logging-1.0.3.jar
> curl 
> https://search.maven.org/remotecontent?filepath=dom4j/dom4j/1.5.2/dom4j-1.5.2.jar
>  -o /${HOME}/.maven/repository/dom4j/jars/dom4j-1.5.2.jar
> curl 
> https://search.maven.org/remotecontent?filepath=jaxen/jaxen/1.1-beta-4/jaxen-1.1-beta-4.jar
>  -o /${HOME}/.maven/repository/jaxen/jars/jaxen-1.1-beta-4.jar
> curl 
> https://search.maven.org/remotecontent?filepath=xerces/xercesImpl/2.2.1/xercesImpl-2.2.1.jar
>  -o /${HOME}/.maven/repository/xerces/jars/xerces-2.2.1.jar
> 
> Then started the build with Apache Ant.
> 
> /opt/apache-ant-1.6.0/bin/ant
> 
> Build succeeds, jar is created successfully.
> 
> ```
> test:
> 
> jar:
>   [jar] Building jar: 
> /home/kinow/Development/java/workspace/commons-jelly-1.0.1-RC2/target/commons-jelly-1.0.1.jar
> 
> BUILD SUCCESSFUL
> Total time: 21 seconds
> 
> ```
> 
> Then had a look at the SVN changes with `svn diff -r1805850 | less`, 
> everything looks OK too.
> 
> Manually iterated through each JUnit XML report, everything looking OK. The 
> TestDoctypeDefinitionXXE succeeded, with some errors in the stderr output, 
> but I assume the error messages are normal and the assertions were correctly 
> executed.
> 
> Checked signatures (KEYS file already imported):
> wget -r -nH -nd -np -R index.html*  -erobots=off  
> https://repository.apache.org/content/repositories/orgapachecommons-1260/commons-jelly/commons-jelly/1.0.1/
> for jar in *.jar ; do gpg --verify "${jar}".asc; done
> 
> All good.
> 
> Minor issues, not sure if any of these are blockers?
> 
> 1)
> RELEASE-NOTES.txt mentions The Jakarta Commons Jelly team, but I think it 
> could be The Apache Commons Jelly team. The URL is also set to 
> jakarta.apache, but there's some server redirect in place already.
> 2)
> 
>> Details of changes since 1.0 are in the release notes:> 
>> https://dist.apache.org/repos/dist/dev/commons/jelly/RELEASE-NOTES.txt
> 404 for this URL. Maybe it was overwritten when generating the dist files? I 
> can still check the RELEASE-NOTES in the tag, so I th

Re: [All][Math] New component: "Commons Geometry"?

2017-08-30 Thread Emmanuel Bourg 
Le 21/08/2017 à 21:41, Gary Gregory a écrit :
> What about this for a compromise: create Commons Math 5 as a multi-module
> project and bring in as submodules only the newly minted components and
> whatever gets spun out of Math 3/4.

+1 for multiple modules instead of multiple components.

Emmanuel Bourg

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [BCEL] Breaking changes in 6.1 needed by Tomcat (?)

2017-08-30 Thread Gary Gregory 
We recently dealt with this kind of compatibility issue in Log4j 2 and we
decided to subclass the interface in question. I suggest we do the same
here. Not pretty but it is type safe and bullet-proof.

Gary

On Tue, Aug 29, 2017 at 5:17 AM, sebb  wrote:

> On 28 August 2017 at 20:07, Gary Gregory  wrote:
> > The question is whether this breaks binary compatibility. If it does,
> this
> > needs fixing. Unless there are other important changes that warrant a
> major
> > version, I would go the sub-interface route; ugly, but workable within
> the
> > same major release.
>
> According to [1], it seems it does not.
>
> However it will break source compatibility if a 3rd party implements
> the interface.
>
> Also I seem to remember there were some concerns about the downstream
> effect for 3rd party visitor implementations.
>
> IIRC it was that BCEL will expect to be able to invoke the new
> methods; this will fail.
> There may be ways around this by catching the exception.
>
> The dev list should have the details.
>
> [1] https://docs.oracle.com/javase/specs/jls/se8/html/jls-13.html
>
> > Gary
> >
> > On Mon, Aug 28, 2017 at 12:58 PM, Benedikt Ritter 
> > wrote:
> >
> >> Hi,
> >>
> >> Rev. 1782852 [1] has introduced two breaking changes by adding the
> methods:
> >>
> >> public void visitAnnotation(org.apache.bcel.classfile.Annotations)
> >> public void visitAnnotationDefault(org.apache.bcel.classfile.
> >> AnnotationDefault)
> >>
> >> to the interface org.apache.bcel.classfile.Visitor. The commit comment
> >> indicates that these changes are needed by the Tomcat project. How do we
> >> want to deal with this for the upcoming 6.1 release? I see several
> options:
> >>
> >> - accept these changes and make it explicit in release notes
> >> - add a new interface which extends from the Visitor interface and add
> the
> >> new methods to that interface
> >> - major version bump (probably not the best idea…)
> >>
> >> Thoughts?
> >> Benedikt
> >>
> >> [1] http://svn.apache.org/viewvc?view=revision&revision=1782852 <
> >> http://svn.apache.org/viewvc?view=revision&revision=1782852>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>

Re: [VOTE] Release Apache Commons CSV 1.5 based on RC1

2017-08-30 Thread Gary Gregory 
Nit: the CONTRIBUTING.md is not in the src zip. We should also add a
BUILDING.md.

Gary

On Tue, Aug 29, 2017 at 10:09 PM, Bruno P. Kinoshita <
brunodepau...@yahoo.com.br.invalid> wrote:

> Hi Oliver,
>
> Thank you for taking your time to review this RC!
>
> Interesting, never paid much attention to what was included in the dist
> files. You are correct, and looks like it is defined in each component's
> assembly XML file (https://github.com/apache/commons-csv/blob/master/src/
> assembly/bin.xml).
> I also think it's not a blocker as I assume previous releases of [csv]
> also did not include the other files. But happy to update the assembly XML
> files to match what others (e.g. [text] and [lang]) include.
>
> Cheers
> Bruno
>
>
> 
> From: Oliver Heger 
> To: Commons Developers List 
> Sent: Wednesday, 30 August 2017, 4:05:08 AM NZST
> Subject: Re: [VOTE] Release Apache Commons CSV 1.5 based on RC1
>
> Build works fine with Java 1.7 and 1.8 on Windows 10. Artifacts and site
> look good.
>
> Minor nit: The binary distribution only contains the jar and a
> sources-jar. Other components ship with some more artifacts like Javadoc
> and test jars. But this is not blocking.
>
> +1
>
> Oliver
>
> Am 27.08.2017 um 12:10 schrieb Bruno P. Kinoshita:
> > Hello all,
> >
> > This is a [VOTE] for releasing Apache Commons CSV 1.5 (from RC1).
> >
> > Tag name:
> >   csv-1.5-RC1 (signature can be checked from git using 'git tag -v')
> > Tag URL:
> >   https://git-wip-us.apache.org/repos/asf?p=commons-csv.git;a=commit;h=
> f76a1357057cd3caaf9b0904d9cc57ce384658a3
> > Commit ID the tag points at:
> >   f76a1357057cd3caaf9b0904d9cc57ce384658a3
> >
> > Site:
> >   http://people.apache.org/~kinow/commons-csv-1.5-RC1/
> > Distribution files (committed at revision 21311):
> >   https://dist.apache.org/repos/dist/dev/commons/csv/
> >
> > Distribution files hashes (SHA1):
> >   commons-csv-1.5-bin.tar.gz
> >   (SHA1: 4c2a4cde27c556f808cd354807579a208fcf)
> >   commons-csv-1.5-bin.zip
> >   (SHA1: fea9c15a06e1f660b2bba30a5fba44a76492c02e)
> >   commons-csv-1.5-src.tar.gz
> >   (SHA1: e2c83f040fdfdb868184c019624d20b79113e004)
> >   commons-csv-1.5-src.zip
> >   (SHA1: 22f009e0e7be51c3c61fa667c02ac1822276c7b8)
> >
> > These are the Maven artifacts and their hashes:
> >   commons-csv-1.5-javadoc.jar
> >   (SHA1: 8008b611f677b9ba06988e8102887fa4caed93b5)
> >   commons-csv-1.5-sources.jar
> >   (SHA1: b76c277916ffef14d63279b896b6a82252ddeb79)
> >   commons-csv-1.5-test-sources.jar
> >   (SHA1: f7771a23ac6ec7d5183c65146135e51f6bf2c8fb)
> >   commons-csv-1.5-tests.jar
> >   (SHA1: 1209d9e86a83ac06d139ea02c4331a1426051ee7)
> >   commons-csv-1.5.jar
> >   (SHA1: e10f140af5b82167640f254fa9d88e35ad74329c)
> >   commons-csv-1.5.pom
> >   (SHA1: cffa8d9814f6d711a3cb57865e65927b1f54dcb0)
> >
> > KEYS file to check signatures:
> >   http://www.apache.org/dist/commons/KEYS
> >
> > Maven artifacts:
> >   https://repository.apache.org/content/repositories/
> orgapachecommons-1257
> > Please select one of the following options[1]:
> >
> >   [ ] +1 Release it.
> >   [ ] +0 Go ahead; I don't care.
> >   [ ] -0 There are a few minor glitches: ...
> >   [ ] -1 No, do not release it because ...
> >
> > This vote will be open at least 72 hours, i.e. until
> 2017-08-30T10:00:00Z (this is UTC time).
> > 
> >
> > Cheers,
> >
> > -Bruno
> >
> > [1] http://apache.org/foundation/voting.html
> > ps: I submitted this vote e-mail before at 06:00:00 UTC, but looks like
> the e-mail did not go through, so waited some hours before sending it again
>
> >
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>

Re: Release Commons Jelly 1.0.1 Based on RC2

2017-08-30 Thread Gary Gregory 
The src zip contains a "_MAXOSX" folder. Surely we do not need that.

Gary

On Tue, Aug 29, 2017 at 8:18 AM, Rob Tompkins  wrote:

> Hello,
>
> Commons Jelly 1.0.1 R2 is available for review here:
>   https://dist.apache.org/repos/dist/dev/commons/jelly (svn revision
> 21342)
>
> Note, if anyone needs to get an environment for building and testing the
> release candidate, I have created a docker container such that if you are
> currently in the project directory you can run "docker run -it -v
> $(pwd):/root/commons-jelly-1.X chtompki/commons-jelly-build-env bash”
> then “cd /root/commons-jelly-1.X” to get to a runnable place for the
> project. The container comes with JDK 1.5.0_22-b03 and Ant 1.6.0 on the
> path. If there are any questions about how to use this let me know.
>
> The tag is here:
>   https://svn.apache.org/repos/asf/commons/proper/jelly/tags/
> commons-jelly-1.0.1-RC2
>
> Commit the tag points at:
>   1806595
>
> Maven Artifacts:
>   https://repository.apache.org/content/repositories/orgapachecommons-1260
>
> These are the Maven artifacts and their hashes:
>
> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-javadoc.jar
>  orgapachecommons-1260/commons-jelly/commons-jelly/1.0.1/
> commons-jelly-1.0.1-javadoc.jar>
> (SHA1: 3f4cfaccff8c8448f216c60c428dbd2eff7b2313)
> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-sources.jar.asc
>  orgapachecommons-1260/commons-jelly/commons-jelly/1.0.1/
> commons-jelly-1.0.1-sources.jar.asc>
> (SHA1: 2cb35149c8fa3b26af9684abeeb0d7e7655e18f9)
> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1.pom.asc
>  orgapachecommons-1260/commons-jelly/commons-jelly/1.0.1/
> commons-jelly-1.0.1.pom.asc>
> (SHA1: 572e91a206c52ac5c51834e0186a53c9de8246b3)
> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1.pom
>  orgapachecommons-1260/commons-jelly/commons-jelly/1.0.1/
> commons-jelly-1.0.1.pom>
> (SHA1: 65333d0abdce02b3ae3a54c513c19b7aa04749ba)
> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1.jar.asc
>  orgapachecommons-1260/commons-jelly/commons-jelly/1.0.1/
> commons-jelly-1.0.1.jar.asc>
> (SHA1: f0154dc77befe4f89141a3806e43967869a29ef5)
> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-javadoc.jar.asc
>  orgapachecommons-1260/commons-jelly/commons-jelly/1.0.1/
> commons-jelly-1.0.1-javadoc.jar.asc>
> (SHA1: ec4465d236ba78415eb6a7aea44b197d5f643934)
> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-sources.jar
>  orgapachecommons-1260/commons-jelly/commons-jelly/1.0.1/
> commons-jelly-1.0.1-sources.jar>
> (SHA1: 939a76c00db4ea2463fe57e708299a5a989087e2)
> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1.jar
>  orgapachecommons-1260/commons-jelly/commons-jelly/1.0.1/
> commons-jelly-1.0.1.jar>
> (SHA1: da868784b796b2c20e5e645ed2739f38c5b74454)
> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-tests.jar.asc
>  orgapachecommons-1260/commons-jelly/commons-jelly/1.0.1/
> commons-jelly-1.0.1-tests.jar.asc>
> (SHA1: f0117a1f2b32164e1edcd54188ffe232e0304d7f)
> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-
> test-sources.jar.asc
>  orgapachecommons-1260/commons-jelly/commons-jelly/1.0.1/
> commons-jelly-1.0.1-test-sources.jar.asc>
> (SHA1: ae1175942a746bf3e40176a3089edb2f2fd89e43)
> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-test-sources.jar
>  orgapachecommons-1260/commons-jelly/commons-jelly/1.0.1/
> commons-jelly-1.0.1-test-sources.jar>
> (SHA1: b6459e04b66bce00d7b230eef3fa5fefc160ccc1)
> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-tests.jar
>  orgapachecommons-1260/commons-jelly/commons-jelly/1.0.1/
> commons-jelly-1.0.1-tests.jar>
> (SHA1: e7f7c80dbb05472fcd211a5c726b554ecab02770)
>
> I have tested this with JDK 1.5.0_22-b03 using Ant 1.6.0.
>
> Details of changes since 1.0 are in the release notes:
> https://dist.apache.org/repos/dist/dev/commons/jelly/RELEASE-NOTES.txt
>
> Site:
>   I have no site as this was generated with ant. My plan was to simply
> make minimal
>   changes to the existant site for the purpose of documenting the
> patch.
>
> KEYS:
>   https://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote.
> This vote will close no sooner that 72 hours from now,
> i.e. sometime after 14:20 (UTC) 1-September 2017
>
>   [ ] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really sho

[CANCEL] Release Commons Jelly 1.0.1 Based on RC2

2017-08-30 Thread Rob Tompkins 

> On Aug 30, 2017, at 10:51 AM, Gary Gregory  wrote:
> 
> The src zip contains a "_MAXOSX" folder. Surely we do not need that.

Agreed. Cancelling. I will roll an RC3 in the coming days.

My vote is a -1.
> 
> Gary
> 
> On Tue, Aug 29, 2017 at 8:18 AM, Rob Tompkins  wrote:
> 
>> Hello,
>> 
>> Commons Jelly 1.0.1 R2 is available for review here:
>>  https://dist.apache.org/repos/dist/dev/commons/jelly (svn revision
>> 21342)
>> 
>> Note, if anyone needs to get an environment for building and testing the
>> release candidate, I have created a docker container such that if you are
>> currently in the project directory you can run "docker run -it -v
>> $(pwd):/root/commons-jelly-1.X chtompki/commons-jelly-build-env bash”
>> then “cd /root/commons-jelly-1.X” to get to a runnable place for the
>> project. The container comes with JDK 1.5.0_22-b03 and Ant 1.6.0 on the
>> path. If there are any questions about how to use this let me know.
>> 
>> The tag is here:
>>  https://svn.apache.org/repos/asf/commons/proper/jelly/tags/
>> commons-jelly-1.0.1-RC2
>> 
>> Commit the tag points at:
>>  1806595
>> 
>> Maven Artifacts:
>>  https://repository.apache.org/content/repositories/orgapachecommons-1260
>> 
>> These are the Maven artifacts and their hashes:
>> 
>> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-javadoc.jar
>> > orgapachecommons-1260/commons-jelly/commons-jelly/1.0.1/
>> commons-jelly-1.0.1-javadoc.jar>
>> (SHA1: 3f4cfaccff8c8448f216c60c428dbd2eff7b2313)
>> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-sources.jar.asc
>> > orgapachecommons-1260/commons-jelly/commons-jelly/1.0.1/
>> commons-jelly-1.0.1-sources.jar.asc>
>> (SHA1: 2cb35149c8fa3b26af9684abeeb0d7e7655e18f9)
>> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1.pom.asc
>> > orgapachecommons-1260/commons-jelly/commons-jelly/1.0.1/
>> commons-jelly-1.0.1.pom.asc>
>> (SHA1: 572e91a206c52ac5c51834e0186a53c9de8246b3)
>> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1.pom
>> > orgapachecommons-1260/commons-jelly/commons-jelly/1.0.1/
>> commons-jelly-1.0.1.pom>
>> (SHA1: 65333d0abdce02b3ae3a54c513c19b7aa04749ba)
>> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1.jar.asc
>> > orgapachecommons-1260/commons-jelly/commons-jelly/1.0.1/
>> commons-jelly-1.0.1.jar.asc>
>> (SHA1: f0154dc77befe4f89141a3806e43967869a29ef5)
>> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-javadoc.jar.asc
>> > orgapachecommons-1260/commons-jelly/commons-jelly/1.0.1/
>> commons-jelly-1.0.1-javadoc.jar.asc>
>> (SHA1: ec4465d236ba78415eb6a7aea44b197d5f643934)
>> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-sources.jar
>> > orgapachecommons-1260/commons-jelly/commons-jelly/1.0.1/
>> commons-jelly-1.0.1-sources.jar>
>> (SHA1: 939a76c00db4ea2463fe57e708299a5a989087e2)
>> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1.jar
>> > orgapachecommons-1260/commons-jelly/commons-jelly/1.0.1/
>> commons-jelly-1.0.1.jar>
>> (SHA1: da868784b796b2c20e5e645ed2739f38c5b74454)
>> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-tests.jar.asc
>> > orgapachecommons-1260/commons-jelly/commons-jelly/1.0.1/
>> commons-jelly-1.0.1-tests.jar.asc>
>> (SHA1: f0117a1f2b32164e1edcd54188ffe232e0304d7f)
>> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-
>> test-sources.jar.asc
>> > orgapachecommons-1260/commons-jelly/commons-jelly/1.0.1/
>> commons-jelly-1.0.1-test-sources.jar.asc>
>> (SHA1: ae1175942a746bf3e40176a3089edb2f2fd89e43)
>> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-test-sources.jar
>> > orgapachecommons-1260/commons-jelly/commons-jelly/1.0.1/
>> commons-jelly-1.0.1-test-sources.jar>
>> (SHA1: b6459e04b66bce00d7b230eef3fa5fefc160ccc1)
>> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-tests.jar
>> > orgapachecommons-1260/commons-jelly/commons-jelly/1.0.1/
>> commons-jelly-1.0.1-tests.jar>
>> (SHA1: e7f7c80dbb05472fcd211a5c726b554ecab02770)
>> 
>> I have tested this with JDK 1.5.0_22-b03 using Ant 1.6.0.
>> 
>> Details of changes since 1.0 are in the release notes:
>>https://dist.apache.org/repos/dist/dev/commons/jelly/RELEASE-NOTES.txt
>> 
>> Site:
>>  I have no site as this was generated with ant. My plan was to simply
>> make minimal
>>  changes to the existant site for the purpose of documenting the
>> patch.
>> 
>> KEYS:
>>  https://www.apache.org/dist/commons/

Re: [CANCEL] Release Commons Jelly 1.0.1 Based on RC2

2017-08-30 Thread Gary Gregory 
Hi Rob,

Since we are re-rolling, may I ask that the release notes be updated since
they currently state "This is the first stable release of Jelly", which it
is now the second.

Also, should we add a BUILDING.md and a CONTRIBUTING.md?

Since there are some old tools at play, better building docs would be most
helpful, at the very least for us reviewers. I plan on following your
Docker instructions for example.


Thank you!
Gary


On Wed, Aug 30, 2017 at 8:54 AM, Rob Tompkins  wrote:

>
> > On Aug 30, 2017, at 10:51 AM, Gary Gregory 
> wrote:
> >
> > The src zip contains a "_MAXOSX" folder. Surely we do not need that.
>
> Agreed. Cancelling. I will roll an RC3 in the coming days.
>
> My vote is a -1.
> >
> > Gary
> >
> > On Tue, Aug 29, 2017 at 8:18 AM, Rob Tompkins 
> wrote:
> >
> >> Hello,
> >>
> >> Commons Jelly 1.0.1 R2 is available for review here:
> >>  https://dist.apache.org/repos/dist/dev/commons/jelly (svn revision
> >> 21342)
> >>
> >> Note, if anyone needs to get an environment for building and testing the
> >> release candidate, I have created a docker container such that if you
> are
> >> currently in the project directory you can run "docker run -it -v
> >> $(pwd):/root/commons-jelly-1.X chtompki/commons-jelly-build-env bash”
> >> then “cd /root/commons-jelly-1.X” to get to a runnable place for the
> >> project. The container comes with JDK 1.5.0_22-b03 and Ant 1.6.0 on the
> >> path. If there are any questions about how to use this let me know.
> >>
> >> The tag is here:
> >>  https://svn.apache.org/repos/asf/commons/proper/jelly/tags/
> >> commons-jelly-1.0.1-RC2
> >>
> >> Commit the tag points at:
> >>  1806595
> >>
> >> Maven Artifacts:
> >>  https://repository.apache.org/content/repositories/
> orgapachecommons-1260
> >>
> >> These are the Maven artifacts and their hashes:
> >>
> >> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-javadoc.jar
> >>  >> orgapachecommons-1260/commons-jelly/commons-jelly/1.0.1/
> >> commons-jelly-1.0.1-javadoc.jar>
> >> (SHA1: 3f4cfaccff8c8448f216c60c428dbd2eff7b2313)
> >> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-sources.jar.asc
> >>  >> orgapachecommons-1260/commons-jelly/commons-jelly/1.0.1/
> >> commons-jelly-1.0.1-sources.jar.asc>
> >> (SHA1: 2cb35149c8fa3b26af9684abeeb0d7e7655e18f9)
> >> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1.pom.asc
> >>  >> orgapachecommons-1260/commons-jelly/commons-jelly/1.0.1/
> >> commons-jelly-1.0.1.pom.asc>
> >> (SHA1: 572e91a206c52ac5c51834e0186a53c9de8246b3)
> >> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1.pom
> >>  >> orgapachecommons-1260/commons-jelly/commons-jelly/1.0.1/
> >> commons-jelly-1.0.1.pom>
> >> (SHA1: 65333d0abdce02b3ae3a54c513c19b7aa04749ba)
> >> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1.jar.asc
> >>  >> orgapachecommons-1260/commons-jelly/commons-jelly/1.0.1/
> >> commons-jelly-1.0.1.jar.asc>
> >> (SHA1: f0154dc77befe4f89141a3806e43967869a29ef5)
> >> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-javadoc.jar.asc
> >>  >> orgapachecommons-1260/commons-jelly/commons-jelly/1.0.1/
> >> commons-jelly-1.0.1-javadoc.jar.asc>
> >> (SHA1: ec4465d236ba78415eb6a7aea44b197d5f643934)
> >> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-sources.jar
> >>  >> orgapachecommons-1260/commons-jelly/commons-jelly/1.0.1/
> >> commons-jelly-1.0.1-sources.jar>
> >> (SHA1: 939a76c00db4ea2463fe57e708299a5a989087e2)
> >> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1.jar
> >>  >> orgapachecommons-1260/commons-jelly/commons-jelly/1.0.1/
> >> commons-jelly-1.0.1.jar>
> >> (SHA1: da868784b796b2c20e5e645ed2739f38c5b74454)
> >> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-tests.jar.asc
> >>  >> orgapachecommons-1260/commons-jelly/commons-jelly/1.0.1/
> >> commons-jelly-1.0.1-tests.jar.asc>
> >> (SHA1: f0117a1f2b32164e1edcd54188ffe232e0304d7f)
> >> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-
> >> test-sources.jar.asc
> >>  >> orgapachecommons-1260/commons-jelly/commons-jelly/1.0.1/
> >> commons-jelly-1.0.1-test-sources.jar.asc>
> >> (SHA1: ae1175942a746bf3e40176a3089edb2f2fd89e43)
> >> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-test-sources.jar
> >>  >> orgapachecommons-1260/commons-jelly/commons-jelly/1.0.1/
> >> commons-jelly-1.0.1-test-sources.jar>
> >> (SHA1: b6459e04b66bce00d7b230eef3fa5fefc160ccc1)
> >> /commons-jelly/commons-jelly/1.0.1/

Re: [CANCEL] Release Commons Jelly 1.0.1 Based on RC2

2017-08-30 Thread Rob Tompkins 


> On Aug 30, 2017, at 11:20 AM, Gary Gregory  wrote:
> 
> Hi Rob,
> 
> Since we are re-rolling, may I ask that the release notes be updated since
> they currently state "This is the first stable release of Jelly", which it
> is now the second.
> 
> Also, should we add a BUILDING.md and a CONTRIBUTING.md?
> 
> Since there are some old tools at play, better building docs would be most
> helpful, at the very least for us reviewers. I plan on following your
> Docker instructions for example.

Makes sense to me. I'll get those in both the 1.X branch and get the applicable 
stuff into trunk as well. And thanks all for the extra sets of eyes here. 

Cheers,
-Rob

> 
> 
> Thank you!
> Gary
> 
> 
>> On Wed, Aug 30, 2017 at 8:54 AM, Rob Tompkins  wrote:
>> 
>> 
>>> On Aug 30, 2017, at 10:51 AM, Gary Gregory 
>> wrote:
>>> 
>>> The src zip contains a "_MAXOSX" folder. Surely we do not need that.
>> 
>> Agreed. Cancelling. I will roll an RC3 in the coming days.
>> 
>> My vote is a -1.
>>> 
>>> Gary
>>> 
>>> On Tue, Aug 29, 2017 at 8:18 AM, Rob Tompkins 
>> wrote:
>>> 
 Hello,
 
 Commons Jelly 1.0.1 R2 is available for review here:
 https://dist.apache.org/repos/dist/dev/commons/jelly (svn revision
 21342)
 
 Note, if anyone needs to get an environment for building and testing the
 release candidate, I have created a docker container such that if you
>> are
 currently in the project directory you can run "docker run -it -v
 $(pwd):/root/commons-jelly-1.X chtompki/commons-jelly-build-env bash”
 then “cd /root/commons-jelly-1.X” to get to a runnable place for the
 project. The container comes with JDK 1.5.0_22-b03 and Ant 1.6.0 on the
 path. If there are any questions about how to use this let me know.
 
 The tag is here:
 https://svn.apache.org/repos/asf/commons/proper/jelly/tags/
 commons-jelly-1.0.1-RC2
 
 Commit the tag points at:
 1806595
 
 Maven Artifacts:
 https://repository.apache.org/content/repositories/
>> orgapachecommons-1260
 
 These are the Maven artifacts and their hashes:
 
 /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-javadoc.jar
 
 (SHA1: 3f4cfaccff8c8448f216c60c428dbd2eff7b2313)
 /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-sources.jar.asc
 
 (SHA1: 2cb35149c8fa3b26af9684abeeb0d7e7655e18f9)
 /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1.pom.asc
 
 (SHA1: 572e91a206c52ac5c51834e0186a53c9de8246b3)
 /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1.pom
 
 (SHA1: 65333d0abdce02b3ae3a54c513c19b7aa04749ba)
 /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1.jar.asc
 
 (SHA1: f0154dc77befe4f89141a3806e43967869a29ef5)
 /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-javadoc.jar.asc
 
 (SHA1: ec4465d236ba78415eb6a7aea44b197d5f643934)
 /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-sources.jar
 
 (SHA1: 939a76c00db4ea2463fe57e708299a5a989087e2)
 /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1.jar
 
 (SHA1: da868784b796b2c20e5e645ed2739f38c5b74454)
 /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-tests.jar.asc
 
 (SHA1: f0117a1f2b32164e1edcd54188ffe232e0304d7f)
 /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-
 test-sources.jar.asc
 
 (SHA1: ae1175942a746bf3e40176a3089edb2f2fd89e43)
 /commons-jelly/commons-jelly/1.0.1/commo

Re: [BCEL] Breaking changes in 6.1 needed by Tomcat (?)

2017-08-30 Thread Benedikt Ritter 
Hi,

looking through the JavaDoc comments in the Visitor interface, it looks like we 
added additional methods in the 6.0 release. 6.0 was a major release but 
without package and maven coords change. Seems like we accepted this kind of 
changes for 6.0. I’m not sure what point I’m trying to make here… But the whole 
versioning/api evolution thingy looks pretty messy in BCEL.

Cheers,
Benedikt

> Am 30.08.2017 um 16:37 schrieb Gary Gregory :
> 
> We recently dealt with this kind of compatibility issue in Log4j 2 and we
> decided to subclass the interface in question. I suggest we do the same
> here. Not pretty but it is type safe and bullet-proof.
> 
> Gary
> 
> On Tue, Aug 29, 2017 at 5:17 AM, sebb  wrote:
> 
>> On 28 August 2017 at 20:07, Gary Gregory  wrote:
>>> The question is whether this breaks binary compatibility. If it does,
>> this
>>> needs fixing. Unless there are other important changes that warrant a
>> major
>>> version, I would go the sub-interface route; ugly, but workable within
>> the
>>> same major release.
>> 
>> According to [1], it seems it does not.
>> 
>> However it will break source compatibility if a 3rd party implements
>> the interface.
>> 
>> Also I seem to remember there were some concerns about the downstream
>> effect for 3rd party visitor implementations.
>> 
>> IIRC it was that BCEL will expect to be able to invoke the new
>> methods; this will fail.
>> There may be ways around this by catching the exception.
>> 
>> The dev list should have the details.
>> 
>> [1] https://docs.oracle.com/javase/specs/jls/se8/html/jls-13.html
>> 
>>> Gary
>>> 
>>> On Mon, Aug 28, 2017 at 12:58 PM, Benedikt Ritter 
>>> wrote:
>>> 
 Hi,
 
 Rev. 1782852 [1] has introduced two breaking changes by adding the
>> methods:
 
 public void visitAnnotation(org.apache.bcel.classfile.Annotations)
 public void visitAnnotationDefault(org.apache.bcel.classfile.
 AnnotationDefault)
 
 to the interface org.apache.bcel.classfile.Visitor. The commit comment
 indicates that these changes are needed by the Tomcat project. How do we
 want to deal with this for the upcoming 6.1 release? I see several
>> options:
 
 - accept these changes and make it explicit in release notes
 - add a new interface which extends from the Visitor interface and add
>> the
 new methods to that interface
 - major version bump (probably not the best idea…)
 
 Thoughts?
 Benedikt
 
 [1] http://svn.apache.org/viewvc?view=revision&revision=1782852 <
 http://svn.apache.org/viewvc?view=revision&revision=1782852>
>> 
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>> For additional commands, e-mail: dev-h...@commons.apache.org
>> 
>> 


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [BCEL] Releasing 6.1

2017-08-30 Thread Benedikt Ritter 
Hello,

I’ve committed the patches. BCEL-286 [1] can not be applied to trunk because it 
updates a file that does not exist.

Cheers,
Benedikt

[1] https://issues.apache.org/jira/browse/BCEL-286 


> Am 29.08.2017 um 00:39 schrieb Mark Roberts :
> 
> Found another issue that needs to be corrected.  I have updated the patch 
> file for https://issues.apache.org/jira/browse/BCEL-276.
> 
> Thank you
> Mark
> 
> -Original Message-
> From: Benedikt Ritter [mailto:brit...@apache.org] 
> Sent: Monday, August 28, 2017 11:36 AM
> To: Commons Developers List
> Subject: Re: [BCEL] Releasing 6.1
> 
> Hello Mark,
> 
>> Am 28.08.2017 um 16:39 schrieb Mark Roberts :
>> 
>> As I have noted in previous posts, the UW PLSE Daikon toolset is a major 
>> user of BCEL.  I would be happy to help with this release.  Some 
>> items/questions to start with:
>> 
>> - We have submitted three issues and proposed fixes we would really like to 
>> see included in this release https://issues.apache.org/jira/browse/BCEL-283 
>> , https://issues.apache.org/jira/browse/BCEL-286  and 
>> https://issues.apache.org/jira/browse/BCEL-287 .
> 
> Thank you, I will have a look into these.
> 
> Benedikt
> 
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>

[GitHub] commons-bcel pull request #12: BCEL-276 LocalVariableTypeTable is not update...

2017-08-30 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/commons-bcel/pull/12


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-dbutils pull request #2: This is not a real pull request, just give ...

2017-08-30 Thread drinkjava2 
GitHub user drinkjava2 opened a pull request:

https://github.com/apache/commons-dbutils/pull/2

This is not a real pull request, just give some suggestions

Hi there,
This is not a real pull request, because I can't find somewhere to open an 
issue for DbUtils, so just use a pull request as replacement, I just want give 
you some ideas how to improve this DbUtils project, especially on the 
transaction control.

I made a small project called "DbUtils-Pro", it's based on DbUtils but made 
these improvements:
1.Add in-line style SQL support, "in-line" style using ThreadLocal to weave 
SQL parameters into a SQL String, easy to maintenance.
2.Add SQL Template support, DbUtils-Pro allowed customize to any Template 
engine and it also already have a simple template implementation.
3.Improved DbUtils's Exception strategy, wrap SQLException to 
RuntimeException
4.Add a ConnectionManager, make it easier to integrate with Spring or 3rd 
party transaction services.
5.Original functions of DbUtils 100% kept, obviously, because DbPro is 
extended from QueryRunner.

More introduce of DbUtils-Pro can see this file:

https://github.com/drinkjava2/commons-dbutils/blob/master/README_DbUtils-Pro.md



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/drinkjava2/commons-dbutils master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-dbutils/pull/2.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2


commit 18202e42a12896e6dbb5967a69c9421cd95a6ba6
Author: drinkjava2 
Date:   2017-08-30T20:35:40Z

Add DbUtils-Pro




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-dbutils issue #2: This is not a real pull request, just give some su...

2017-08-30 Thread britter 
Github user britter commented on the issue:

https://github.com/apache/commons-dbutils/pull/2
  
The bug tracker is at https://issues.apache.org/jira/browse/DBUTILS. Please 
see our README.md. If you want to propose changes, please make them minimal and 
focused (see our CONTRIBUTING.md). This PR has like 3.500 changes lines, making 
it impossible to review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-dbutils issue #2: This is not a real pull request, just give some su...

2017-08-30 Thread bindul 
Github user bindul commented on the issue:

https://github.com/apache/commons-dbutils/pull/2
  
@drinkjava2 DBUtils uses Apache JIRA for issue tracking at 
https://issues.apache.org/jira/projects/DBUTILS


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [All][Math] New component: "Commons Geometry"?

2017-08-30 Thread Gilles 

On Wed, 30 Aug 2017 15:28:49 +0200, Emmanuel Bourg wrote:

Le 21/08/2017 à 21:41, Gary Gregory a écrit :
What about this for a compromise: create Commons Math 5 as a 
multi-module
project and bring in as submodules only the newly minted components 
and

whatever gets spun out of Math 3/4.


+1 for multiple modules instead of multiple components.

Emmanuel Bourg



-1 to asking others to do one's work.[1]

Gilles

[1] More complete answer _already_ given.
You should reply to that post, with concrete arguments.


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-dbutils issue #2: This is not a real pull request, just give some su...

2017-08-30 Thread drinkjava2 
Github user drinkjava2 commented on the issue:

https://github.com/apache/commons-dbutils/pull/2
  
I have no time to register on Apache only for post a suggestion. It's weird 
you disabled github issue but worked everyday on here.
DbUtils is perfect, but the biggest problem is, may many people have the 
same question : how to use Spring's transaction with it? 
TransactionAwareDataSourceProxy works, but it is weird way because the purpose 
is designed for legacy programs. If want use DataSourceUtils to get and release 
Connection, you'll have to override the AbstractQueryRunner's 
close/prepareConnection methods. Not everyone is expert of DbUtils know this 
trick, why DbUtils improve itself to get better user experience of the 
transaction control?
BTW, there is no review problem because I did not touch any byte of existed 
DbUtils code, just added some new classes and put them in new folders.  But 
still as I said it's not a real pull request, I just want say some suggestion 
of this project, it's not mature for DbUtils-Pro to submit into DbUtils.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [BCEL] Breaking changes in 6.1 needed by Tomcat (?)

2017-08-30 Thread sebb 
On 30 August 2017 at 20:11, Benedikt Ritter  wrote:
> Hi,
>
> looking through the JavaDoc comments in the Visitor interface, it looks like 
> we added additional methods in the 6.0 release. 6.0 was a major release but 
> without package and maven coords change. Seems like we accepted this kind of 
> changes for 6.0. I’m not sure what point I’m trying to make here… But the 
> whole versioning/api evolution thingy looks pretty messy in BCEL.

A major version bump does not require changes to package names/maven coords.
It just means that there have been major changes.

However changing package/maven coords is a major change and so
requires a major version bump.

AFAIK 6.0 was binary compatible with the previous release.
That was certainly the intention.

> Cheers,
> Benedikt
>
>> Am 30.08.2017 um 16:37 schrieb Gary Gregory :
>>
>> We recently dealt with this kind of compatibility issue in Log4j 2 and we
>> decided to subclass the interface in question. I suggest we do the same
>> here. Not pretty but it is type safe and bullet-proof.
>>
>> Gary
>>
>> On Tue, Aug 29, 2017 at 5:17 AM, sebb  wrote:
>>
>>> On 28 August 2017 at 20:07, Gary Gregory  wrote:
 The question is whether this breaks binary compatibility. If it does,
>>> this
 needs fixing. Unless there are other important changes that warrant a
>>> major
 version, I would go the sub-interface route; ugly, but workable within
>>> the
 same major release.
>>>
>>> According to [1], it seems it does not.
>>>
>>> However it will break source compatibility if a 3rd party implements
>>> the interface.
>>>
>>> Also I seem to remember there were some concerns about the downstream
>>> effect for 3rd party visitor implementations.
>>>
>>> IIRC it was that BCEL will expect to be able to invoke the new
>>> methods; this will fail.
>>> There may be ways around this by catching the exception.
>>>
>>> The dev list should have the details.
>>>
>>> [1] https://docs.oracle.com/javase/specs/jls/se8/html/jls-13.html
>>>
 Gary

 On Mon, Aug 28, 2017 at 12:58 PM, Benedikt Ritter 
 wrote:

> Hi,
>
> Rev. 1782852 [1] has introduced two breaking changes by adding the
>>> methods:
>
> public void visitAnnotation(org.apache.bcel.classfile.Annotations)
> public void visitAnnotationDefault(org.apache.bcel.classfile.
> AnnotationDefault)
>
> to the interface org.apache.bcel.classfile.Visitor. The commit comment
> indicates that these changes are needed by the Tomcat project. How do we
> want to deal with this for the upcoming 6.1 release? I see several
>>> options:
>
> - accept these changes and make it explicit in release notes
> - add a new interface which extends from the Visitor interface and add
>>> the
> new methods to that interface
> - major version bump (probably not the best idea…)
>
> Thoughts?
> Benedikt
>
> [1] http://svn.apache.org/viewvc?view=revision&revision=1782852 <
> http://svn.apache.org/viewvc?view=revision&revision=1782852>
>>>
>>> -
>>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>>> For additional commands, e-mail: dev-h...@commons.apache.org
>>>
>>>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org