> On Aug 30, 2017, at 11:20 AM, Gary Gregory <garydgreg...@gmail.com> wrote: > > Hi Rob, > > Since we are re-rolling, may I ask that the release notes be updated since > they currently state "This is the first stable release of Jelly", which it > is now the second. > > Also, should we add a BUILDING.md and a CONTRIBUTING.md? > > Since there are some old tools at play, better building docs would be most > helpful, at the very least for us reviewers. I plan on following your > Docker instructions for example.
Makes sense to me. I'll get those in both the 1.X branch and get the applicable stuff into trunk as well. And thanks all for the extra sets of eyes here. Cheers, -Rob > > > Thank you! > Gary > > >> On Wed, Aug 30, 2017 at 8:54 AM, Rob Tompkins <chtom...@gmail.com> wrote: >> >> >>> On Aug 30, 2017, at 10:51 AM, Gary Gregory <garydgreg...@gmail.com> >> wrote: >>> >>> The src zip contains a "_MAXOSX" folder. Surely we do not need that. >> >> Agreed. Cancelling. I will roll an RC3 in the coming days. >> >> My vote is a -1. >>> >>> Gary >>> >>> On Tue, Aug 29, 2017 at 8:18 AM, Rob Tompkins <chtom...@apache.org> >> wrote: >>> >>>> Hello, >>>> >>>> Commons Jelly 1.0.1 R2 is available for review here: >>>> https://dist.apache.org/repos/dist/dev/commons/jelly (svn revision >>>> 21342) >>>> >>>> Note, if anyone needs to get an environment for building and testing the >>>> release candidate, I have created a docker container such that if you >> are >>>> currently in the project directory you can run "docker run -it -v >>>> $(pwd):/root/commons-jelly-1.X chtompki/commons-jelly-build-env bash” >>>> then “cd /root/commons-jelly-1.X” to get to a runnable place for the >>>> project. The container comes with JDK 1.5.0_22-b03 and Ant 1.6.0 on the >>>> path. If there are any questions about how to use this let me know. >>>> >>>> The tag is here: >>>> https://svn.apache.org/repos/asf/commons/proper/jelly/tags/ >>>> commons-jelly-1.0.1-RC2 >>>> >>>> Commit the tag points at: >>>> 1806595 >>>> >>>> Maven Artifacts: >>>> https://repository.apache.org/content/repositories/ >> orgapachecommons-1260 >>>> >>>> These are the Maven artifacts and their hashes: >>>> >>>> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-javadoc.jar >>>> <https://repository.apache.org/content/repositories/ >>>> orgapachecommons-1260/commons-jelly/commons-jelly/1.0.1/ >>>> commons-jelly-1.0.1-javadoc.jar> >>>> (SHA1: 3f4cfaccff8c8448f216c60c428dbd2eff7b2313) >>>> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-sources.jar.asc >>>> <https://repository.apache.org/content/repositories/ >>>> orgapachecommons-1260/commons-jelly/commons-jelly/1.0.1/ >>>> commons-jelly-1.0.1-sources.jar.asc> >>>> (SHA1: 2cb35149c8fa3b26af9684abeeb0d7e7655e18f9) >>>> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1.pom.asc >>>> <https://repository.apache.org/content/repositories/ >>>> orgapachecommons-1260/commons-jelly/commons-jelly/1.0.1/ >>>> commons-jelly-1.0.1.pom.asc> >>>> (SHA1: 572e91a206c52ac5c51834e0186a53c9de8246b3) >>>> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1.pom >>>> <https://repository.apache.org/content/repositories/ >>>> orgapachecommons-1260/commons-jelly/commons-jelly/1.0.1/ >>>> commons-jelly-1.0.1.pom> >>>> (SHA1: 65333d0abdce02b3ae3a54c513c19b7aa04749ba) >>>> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1.jar.asc >>>> <https://repository.apache.org/content/repositories/ >>>> orgapachecommons-1260/commons-jelly/commons-jelly/1.0.1/ >>>> commons-jelly-1.0.1.jar.asc> >>>> (SHA1: f0154dc77befe4f89141a3806e43967869a29ef5) >>>> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-javadoc.jar.asc >>>> <https://repository.apache.org/content/repositories/ >>>> orgapachecommons-1260/commons-jelly/commons-jelly/1.0.1/ >>>> commons-jelly-1.0.1-javadoc.jar.asc> >>>> (SHA1: ec4465d236ba78415eb6a7aea44b197d5f643934) >>>> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-sources.jar >>>> <https://repository.apache.org/content/repositories/ >>>> orgapachecommons-1260/commons-jelly/commons-jelly/1.0.1/ >>>> commons-jelly-1.0.1-sources.jar> >>>> (SHA1: 939a76c00db4ea2463fe57e708299a5a989087e2) >>>> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1.jar >>>> <https://repository.apache.org/content/repositories/ >>>> orgapachecommons-1260/commons-jelly/commons-jelly/1.0.1/ >>>> commons-jelly-1.0.1.jar> >>>> (SHA1: da868784b796b2c20e5e645ed2739f38c5b74454) >>>> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-tests.jar.asc >>>> <https://repository.apache.org/content/repositories/ >>>> orgapachecommons-1260/commons-jelly/commons-jelly/1.0.1/ >>>> commons-jelly-1.0.1-tests.jar.asc> >>>> (SHA1: f0117a1f2b32164e1edcd54188ffe232e0304d7f) >>>> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1- >>>> test-sources.jar.asc >>>> <https://repository.apache.org/content/repositories/ >>>> orgapachecommons-1260/commons-jelly/commons-jelly/1.0.1/ >>>> commons-jelly-1.0.1-test-sources.jar.asc> >>>> (SHA1: ae1175942a746bf3e40176a3089edb2f2fd89e43) >>>> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-test-sources.jar >>>> <https://repository.apache.org/content/repositories/ >>>> orgapachecommons-1260/commons-jelly/commons-jelly/1.0.1/ >>>> commons-jelly-1.0.1-test-sources.jar> >>>> (SHA1: b6459e04b66bce00d7b230eef3fa5fefc160ccc1) >>>> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-tests.jar >>>> <https://repository.apache.org/content/repositories/ >>>> orgapachecommons-1260/commons-jelly/commons-jelly/1.0.1/ >>>> commons-jelly-1.0.1-tests.jar> >>>> (SHA1: e7f7c80dbb05472fcd211a5c726b554ecab02770) >>>> >>>> I have tested this with JDK 1.5.0_22-b03 using Ant 1.6.0. >>>> >>>> Details of changes since 1.0 are in the release notes: >>>> https://dist.apache.org/repos/dist/dev/commons/jelly/ >> RELEASE-NOTES.txt >>>> >>>> Site: >>>> I have no site as this was generated with ant. My plan was to >> simply >>>> make minimal >>>> changes to the existant site for the purpose of documenting the >>>> patch. >>>> >>>> KEYS: >>>> https://www.apache.org/dist/commons/KEYS >>>> >>>> Please review the release candidate and vote. >>>> This vote will close no sooner that 72 hours from now, >>>> i.e. sometime after 14:20 (UTC) 1-September 2017 >>>> >>>> [ ] +1 Release these artifacts >>>> [ ] +0 OK, but... >>>> [ ] -0 OK, but really should fix... >>>> [ ] -1 I oppose this release because... >>>> >>>> Thanks! >>>> Rob >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>>> For additional commands, e-mail: dev-h...@commons.apache.org >>>> >>>> >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> >> --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
