Re: svn commit: r1447443 - in /commons/proper/codec/trunk/src: changes/ main/java/org/apache/commons/codec/binary/

2013-02-19 Thread Thomas Neidhart
On 02/18/2013 11:08 PM, Gary Gregory wrote:
> How does this affect the B32 code and the common code w B64?

Ok, I now attached a patch to the issue.

It should be transparent for B32 and B64 (as it uses the
encoded/unencodedBlockSize variables).

Performance has improved, but is still not on level with e.g. MigBase.
I did quite a lot of profiling, but still can not say precisely where
the major bottleneck is.

The actual encoding code is quite minimal, and the array copying also
does not have such a large impact.

There are definitely more objects created in CC, and we also have the
overhead of a virtual method call.

Thomas

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



[continuum] BUILD FAILURE: Apache Commons - Commons VFS -

2013-02-19 Thread Continuum@vmbuild
  Local Maven 2 Build Definition (Java 1.6)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Continuum-Build-Host: vmbuild
X-Continuum-Project-Id: 129
X-Continuum-Project-Name: Commons VFS

Online report : 
http://vmbuild.apache.org/continuum/buildResult.action?buildId=26135&projectId=129

Build statistics:
  State: Failed
  Previous State: Failed
  Started at: Tue 19 Feb 2013 11:20:21 +
  Finished at: Tue 19 Feb 2013 11:26:11 +
  Total time: 5m 50s
  Build Trigger: Schedule
  Build Number: 260
  Exit code: 1
  Building machine hostname: vmbuild
  Operating system : Linux(unknown)
  Java Home version : 
  java version "1.6.0_30"
  Java(TM) SE Runtime Environment (build 1.6.0_30-b12)
  Java HotSpot(TM) 64-Bit Server VM (build 20.5-b03, mixed mode)

  Builder version :
  Apache Maven 2.2.1 (r801777; 2009-08-06 19:16:01+)
  Java version: 1.6.0_30
  Java home: /usr/lib/jvm/jdk1.6.0_30/jre
  Default locale: en_AU, platform encoding: UTF-8
  OS name: "linux" version: "2.6.32-41-server" arch: "amd64" Family: 
"unix"


SCM Changes:

Changed: joehni @ Tue 19 Feb 2013 11:18:22 +
Comment: Update Jsch to version 0.1.49 from 0.1.48.
Files changed:
  /commons/proper/vfs/trunk/pom.xml ( 1447676 )
  /commons/proper/vfs/trunk/src/changes/changes.xml ( 1447676 )


Dependencies Changes:

No dependencies changed



Build Definition:

POM filename: pom.xml
Goals: clean deploy   
Arguments: --batch-mode -Pjava-1.6
Build Fresh: false
Always Build: false
Default Build Definition: true
Schedule: COMMONS_SCHEDULE
Profile Name: Maven 2.2.1
Description: Local Maven 2 Build Definition (Java 1.6)


Test Summary:

Tests: 1769
Failures: 2
Errors: 2
Success Rate: 99
Total time: 58.762


Test Failures:


WebdavProviderTestCase
testFileCreate :
  junit.framework.AssertionFailedError
  junit.framework.AssertionFailedError
at junit.framework.Assert.fail(Assert.java:55)
at junit.framework.Assert.assertTrue(Assert.java:22)
at junit.framework.Assert.assertTrue(Assert.java:31)
at junit.framework.TestCase.assertTrue(TestCase.java:201)
at 
org.apache.commons.vfs2.test.ProviderWriteTests.testFileCreate(ProviderWriteTests.java:130)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at 
org.apache.commons.vfs2.test.AbstractProviderTestCase.runTest(AbstractProviderTestCase.java:218)
at junit.framework.TestCase.runBare(TestCase.java:141)
at junit.framework.TestResult$1.protect(TestResult.java:122)
at junit.framework.TestResult.runProtected(TestResult.java:142)
at junit.framework.TestResult.run(TestResult.java:125)
at junit.framework.TestCase.run(TestCase.java:129)
at junit.framework.TestSuite.runTest(TestSuite.java:255)
at junit.framework.TestSuite.run(TestSuite.java:250)
at junit.extensions.TestDecorator.basicRun(TestDecorator.java:23)
at junit.extensions.TestSetup$1.protect(TestSetup.java:23)
at junit.framework.TestResult.runProtected(TestResult.java:142)
at junit.extensions.TestSetup.run(TestSetup.java:27)
at 
org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:84)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:252)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:141)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:112)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at 
org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithA

Re: svn commit: r1447443 - in /commons/proper/codec/trunk/src: changes/ main/java/org/apache/commons/codec/binary/

2013-02-19 Thread Thomas Neidhart
On 02/18/2013 11:18 PM, Julius Davies wrote:
> On Mon, Feb 18, 2013 at 2:08 PM, Gary Gregory  wrote:
>> How does this affect the B32 code and the common code w B64?
>>
>> Gary
>>
> 
> I tried to make sure the patch perturbed as little of the existing
> code as possible.   There are no changes to the B32 or shared logic.
> 
> Here's the colored diff of the only pre-existing file it touched
> (Base64.java).   The rest of the patch is new files:
> 
> http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/binary/Base64.java?r1=1435550&r2=1447443&diff_format=h
> 
> Some of the static encode/decode methods in Base64 changed.   I also
> re-introduced two instance methods.

ah, just as a side note when doing such micro-benchmarks:

you should always use the result in some way (e.g. use it in a
calculation), otherwise the JVM may optimize it away.

I changed the code to something like this:

long d = 0;
start = System.currentTimeMillis();
for (int i = 0; i < FACTOR * REPS; i++) {
encoded = IHarderBase64.encodeBytesToBytes(data);
d += encoded[i % encoded.length];
}
printEncodeStat(start, data, d);

Thomas

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



[continuum] BUILD FAILURE: Apache Commons - Commons VFS -

2013-02-19 Thread Continuum@vmbuild
  Local Maven 2 Build Definition (Java 1.6)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Continuum-Build-Host: vmbuild
X-Continuum-Project-Id: 129
X-Continuum-Project-Name: Commons VFS

Online report : 
http://vmbuild.apache.org/continuum/buildResult.action?buildId=26136&projectId=129

Build statistics:
  State: Failed
  Previous State: Failed
  Started at: Tue 19 Feb 2013 12:20:19 +
  Finished at: Tue 19 Feb 2013 12:25:42 +
  Total time: 5m 22s
  Build Trigger: Schedule
  Build Number: 260
  Exit code: 1
  Building machine hostname: vmbuild
  Operating system : Linux(unknown)
  Java Home version : 
  java version "1.6.0_30"
  Java(TM) SE Runtime Environment (build 1.6.0_30-b12)
  Java HotSpot(TM) 64-Bit Server VM (build 20.5-b03, mixed mode)

  Builder version :
  Apache Maven 2.2.1 (r801777; 2009-08-06 19:16:01+)
  Java version: 1.6.0_30
  Java home: /usr/lib/jvm/jdk1.6.0_30/jre
  Default locale: en_AU, platform encoding: UTF-8
  OS name: "linux" version: "2.6.32-41-server" arch: "amd64" Family: 
"unix"


SCM Changes:

Changed: joehni @ Tue 19 Feb 2013 11:37:28 +
Comment: Use org.bouncycastel:bcprov-jdk16 instead of 
org.bouncycastle:bcprof-jdk15on since Java 1.6 is required.
Files changed:
  /commons/proper/vfs/trunk/core/pom.xml ( 1447683 )
  /commons/proper/vfs/trunk/pom.xml ( 1447683 )
  /commons/proper/vfs/trunk/src/changes/changes.xml ( 1447683 )


Dependencies Changes:

No dependencies changed



Build Definition:

POM filename: pom.xml
Goals: clean deploy   
Arguments: --batch-mode -Pjava-1.6
Build Fresh: false
Always Build: false
Default Build Definition: true
Schedule: COMMONS_SCHEDULE
Profile Name: Maven 2.2.1
Description: Local Maven 2 Build Definition (Java 1.6)


Test Summary:

Tests: 1769
Failures: 2
Errors: 2
Success Rate: 99
Total time: 56.304


Test Failures:


WebdavProviderTestCase
testFileCreate :
  junit.framework.AssertionFailedError
  junit.framework.AssertionFailedError
at junit.framework.Assert.fail(Assert.java:55)
at junit.framework.Assert.assertTrue(Assert.java:22)
at junit.framework.Assert.assertTrue(Assert.java:31)
at junit.framework.TestCase.assertTrue(TestCase.java:201)
at 
org.apache.commons.vfs2.test.ProviderWriteTests.testFileCreate(ProviderWriteTests.java:130)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at 
org.apache.commons.vfs2.test.AbstractProviderTestCase.runTest(AbstractProviderTestCase.java:218)
at junit.framework.TestCase.runBare(TestCase.java:141)
at junit.framework.TestResult$1.protect(TestResult.java:122)
at junit.framework.TestResult.runProtected(TestResult.java:142)
at junit.framework.TestResult.run(TestResult.java:125)
at junit.framework.TestCase.run(TestCase.java:129)
at junit.framework.TestSuite.runTest(TestSuite.java:255)
at junit.framework.TestSuite.run(TestSuite.java:250)
at junit.extensions.TestDecorator.basicRun(TestDecorator.java:23)
at junit.extensions.TestSetup$1.protect(TestSetup.java:23)
at junit.framework.TestResult.runProtected(TestResult.java:142)
at junit.extensions.TestSetup.run(TestSetup.java:27)
at 
org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:84)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:252)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:141)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:112)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang

Re: svn commit: r1447443 - in /commons/proper/codec/trunk/src: changes/ main/java/org/apache/commons/codec/binary/

2013-02-19 Thread Gary Gregory
@TN: So... what is the performance difference as a %? The size of the input
must matter too...

Gary


On Tue, Feb 19, 2013 at 6:48 AM, Thomas Neidhart
wrote:

> On 02/18/2013 11:18 PM, Julius Davies wrote:
> > On Mon, Feb 18, 2013 at 2:08 PM, Gary Gregory 
> wrote:
> >> How does this affect the B32 code and the common code w B64?
> >>
> >> Gary
> >>
> >
> > I tried to make sure the patch perturbed as little of the existing
> > code as possible.   There are no changes to the B32 or shared logic.
> >
> > Here's the colored diff of the only pre-existing file it touched
> > (Base64.java).   The rest of the patch is new files:
> >
> >
> http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/binary/Base64.java?r1=1435550&r2=1447443&diff_format=h
> >
> > Some of the static encode/decode methods in Base64 changed.   I also
> > re-introduced two instance methods.
>
> ah, just as a side note when doing such micro-benchmarks:
>
> you should always use the result in some way (e.g. use it in a
> calculation), otherwise the JVM may optimize it away.
>
> I changed the code to something like this:
>
> long d = 0;
> start = System.currentTimeMillis();
> for (int i = 0; i < FACTOR * REPS; i++) {
> encoded = IHarderBase64.encodeBytesToBytes(data);
> d += encoded[i % encoded.length];
> }
> printEncodeStat(start, data, d);
>
> Thomas
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>


-- 
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
JUnit in Action, 2nd Ed: http://bit.ly/ECvg0
Spring Batch in Action: http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory


Re: svn commit: r1447443 - in /commons/proper/codec/trunk/src: changes/ main/java/org/apache/commons/codec/binary/

2013-02-19 Thread Thomas Neidhart
On 02/19/2013 03:03 PM, Gary Gregory wrote:
> @TN: So... what is the performance difference as a %? The size of the input
> must matter too...

I updated the issue with the latest performance data.

It is now still slower compared to the other two implementations (on
encode), but almost on par. Further improvements could be made in the
way we increase / ensure the buffer size.

Thomas

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



[VFS] State of FtpsProviderTestCase

2013-02-19 Thread Jörg Schaible
Hi,

can someone enlighten me about the state of the FtpsProviderTestCase? It's 
currently disabled and when I (rename it and) run it with Maven it simply 
hangs. Why is it possible to open two input stream on the same object with 
FTP but not FTPS?

Cheers,
Jörg



-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



Re: svn commit: r1447443 - in /commons/proper/codec/trunk/src: changes/ main/java/org/apache/commons/codec/binary/

2013-02-19 Thread Gary Gregory
On Tue, Feb 19, 2013 at 9:33 AM, Thomas Neidhart
wrote:

> On 02/19/2013 03:03 PM, Gary Gregory wrote:
> > @TN: So... what is the performance difference as a %? The size of the
> input
> > must matter too...
>
> I updated the issue with the latest performance data.
>

Which does not tell me the difference in perf before and after TN's patch,
only after. The #s cannot be compared to J's since you are running on the
same set up.

In any case, if the tests all pass, why not commit TN's patch?

Gary


>
> It is now still slower compared to the other two implementations (on
> encode), but almost on par. Further improvements could be made in the
> way we increase / ensure the buffer size.
>
> Thomas
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>


-- 
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
JUnit in Action, 2nd Ed: http://bit.ly/ECvg0
Spring Batch in Action: http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory


Re: [VFS] State of FtpsProviderTestCase

2013-02-19 Thread Gary Gregory
On Tue, Feb 19, 2013 at 12:57 PM, Gary Gregory wrote:

> On Tue, Feb 19, 2013 at 10:41 AM, Jörg Schaible <
> joerg.schai...@scalaris.com> wrote:
>
>> Hi,
>>
>> can someone enlighten me about the state of the FtpsProviderTestCase? It's
>> currently disabled and when I (rename it and) run it with Maven it simply
>> hangs. Why is it possible to open two input stream on the same object with
>> FTP but not FTPS?
>>
>
> I created and disabled this test a while back. I never got very far
> debugging it aside from seeing it hang in the debugger and asking for help
> on the ML and on the Commons ML for [net]. I though I created a JIRA for
> this but now I cannot find it.
>

@#$% mail filters!

Apache will not let through emails I write with a URL that points to the
email thread from April 2012. So search for an email thread titled
"[NET][VFS] Help with FTPS hanging tests"... Grrr...

Gary


>
> Gary
>
>
>>
>> Cheers,
>> Jörg
>>
>>
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>> For additional commands, e-mail: dev-h...@commons.apache.org
>>
>>
>
>
> --
> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
> JUnit in Action, 2nd Ed: http://bit.ly/ECvg0
> Spring Batch in Action: http://bit.ly/bqpbCK
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>



-- 
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
JUnit in Action, 2nd Ed: http://bit.ly/ECvg0
Spring Batch in Action: http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory


Re: CMS/SvnPubSub for site live ?

2013-02-19 Thread Thomas Neidhart
On 02/12/2013 09:28 PM, Olivier Lamy wrote:
> FYI: rsync from people.a.o has been stopped.
> So updating web sites will need to go live with cms/svnpubsub.

ping.

Any progress?
Looking at the prepared content, I would say we could give it a try and
correct / fix anything that is missing or wrong afterwards.

Thomas

> 
> 2013/1/30 Olivier Lamy :
>> Hi Folks,
>> Ok to go live ?
>>
>> Something missing ? (maybe sandbox parent release ?)
>>
>> What else ?
>>
>> Content is available for review here:
>> http://people.apache.org/~olamy/commons-content/
>>
>>
>> Thanks,
>> --
>> Olivier
>> http://twitter.com/olamy | http://linkedin.com/in/olamy
> 
> 
> 
> --
> Olivier Lamy
> Talend: http://coders.talend.com
> http://twitter.com/olamy | http://linkedin.com/in/olamy
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



Re: CMS/SvnPubSub for site live ?

2013-02-19 Thread Luc Maisonobe



Thomas Neidhart  a écrit :

>On 02/12/2013 09:28 PM, Olivier Lamy wrote:
>> FYI: rsync from people.a.o has been stopped.
>> So updating web sites will need to go live with cms/svnpubsub.
>
>ping.
>
>Any progress?
>Looking at the prepared content, I would say we could give it a try and
>correct / fix anything that is missing or wrong afterwards

+1

Luc

>
>Thomas
>
>> 
>> 2013/1/30 Olivier Lamy :
>>> Hi Folks,
>>> Ok to go live ?
>>>
>>> Something missing ? (maybe sandbox parent release ?)
>>>
>>> What else ?
>>>
>>> Content is available for review here:
>>> http://people.apache.org/~olamy/commons-content/
>>>
>>>
>>> Thanks,
>>> --
>>> Olivier
>>> http://twitter.com/olamy | http://linkedin.com/in/olamy
>> 
>> 
>> 
>> --
>> Olivier Lamy
>> Talend: http://coders.talend.com
>> http://twitter.com/olamy | http://linkedin.com/in/olamy
>> 
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>> For additional commands, e-mail: dev-h...@commons.apache.org
>> 
>
>
>-
>To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>For additional commands, e-mail: dev-h...@commons.apache.org

-- 
Envoyé de mon téléphone Android avec K-9 Mail. Excusez la brièveté.

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



Re: [BeanUtils] Plans for BeanUtils and BeanUtils2

2013-02-19 Thread Benedikt Ritter
2013/2/17 Benedikt Ritter 

> Hi,
>
> I'd like to discuss how the development of [BeanUtils] and [BeanUtils2]
> can be continued.
>
> The last release of BeanUtils (1.8.3) is now nearly 3 years ago and there
> are 92 open issues in JIRA.
> OTOH we've put quiet some effort into [BeanUtils2]. There are some issues
> that have to be addressed* but the API is in a good shape.
> But [BeanUtils2] is also a complete redesign of the API that is binary
> incompatible with [BeanUtils].
>
> Keeping this in mind I propose the following:
> - promote [BeanUtils2] to proper; move it to a 2.0 branch in the beanutils
> svn subtree.**
> - fix all issues that can be fixed without breaking BC in [BeanUtils] to
> push out a last bug fix release for users that don't want to swtich to a
> new API.
> - Make clear that BeanUtils 1.8.4 will be the last release of  the 1.x
> line.
>
> WDYT?
>
> Benedikt
>
> * Some JavaDoc is still missing and we have to take a look at the caching.
> AFAIK WeakHashMap is not the best choice for an in-memory-cache. We'll
> discuss this in a separate thread.
> ** I don't know the exact formal process for this. What has to be done to
> promote a component to proper? Does there have to be a formal vote by the
> PMC?
>
>
More than 72 hours have passed with no reply. Nobody interested in
BeanUtils anymore?


>
> --
> http://people.apache.org/~britter/
> http://www.systemoutprintln.de/
> http://twitter.com/BenediktRitter
> http://github.com/britter
>



-- 
http://people.apache.org/~britter/
http://www.systemoutprintln.de/
http://twitter.com/BenediktRitter
http://github.com/britter