[GitHub] cloudstack issue #1883: CLOUDSTACK-9723: Enable unique mac address across th...
Github user srinivas-gandikota commented on the issue: https://github.com/apache/cloudstack/pull/1883 LGTM Reviewed code -- looks good I see even the BVTs have passed without any failures --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1917: CLOUDSTACK-9756: Configure to ignore the ipas...
Github user srinivas-gandikota commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1917#discussion_r103880552
--- Diff: engine/components-api/src/com/cloud/network/IpAddressManager.java
---
@@ -43,6 +43,9 @@
"If true, when account has dedicated public ip range(s), once the
ips dedicated to the account have been consumed ips will be acquired from the
system pool",
true, ConfigKey.Scope.Account);
+static final ConfigKey RulesContinueOnError = new
ConfigKey("Advanced", Boolean.class,
"network.rule.delete.ignoreerror", "true",
--- End diff --
The default for ignoreerror is set to true, means the errors will be
ignored.
Shouldn't the default be set to false ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1917: CLOUDSTACK-9756: Configure to ignore the ipas...
Github user srinivas-gandikota commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1917#discussion_r103966991
--- Diff: engine/components-api/src/com/cloud/network/IpAddressManager.java
---
@@ -43,6 +43,9 @@
"If true, when account has dedicated public ip range(s), once the
ips dedicated to the account have been consumed ips will be acquired from the
system pool",
true, ConfigKey.Scope.Account);
+static final ConfigKey RulesContinueOnError = new
ConfigKey("Advanced", Boolean.class,
"network.rule.delete.ignoreerror", "true",
--- End diff --
sound appropriate.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
Re: S2S VPN to AWS problems
Nux, You can get one tunnel working, but requires two manual changes in the VR strongswan vpn options. 1. Enforce ikev1 2. add compress=no If all other pieces are in sync, tunnel should be up. Thanks, Srinivas From: Nux! Sent: Thursday, November 30, 2017 11:04 PM To: dev Cc: users Subject: S2S VPN to AWS problems Hello, Has anyone managed to get a s2s VPN up with an AWS VPC? I see AWS require the setup of two tunnels which does not seem possible in ACS. Connecting to either tunnels alone results in the VPN getting disconnected. Any pointers much appreciated! -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro DISCLAIMER == This e-mail may contain privileged and confidential information which is the property of Accelerite, a Persistent Systems business. It is intended only for the use of the individual or entity to which it is addressed. If you are not the intended recipient, you are not authorized to read, retain, copy, print, distribute or use this message. If you have received this communication in error, please notify the sender and delete all copies of this message. Accelerite, a Persistent Systems business does not accept any liability for virus infected mails.
[GitHub] cloudstack pull request: CLOUDSTACK-9130: Make RebootCommand simil...
Github user srinivas-gandikota commented on the pull request: https://github.com/apache/cloudstack/pull/1200#issuecomment-212781868 LGTM based on code review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
