Github user srinivas-gandikota commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1917#discussion_r103880552
--- Diff: engine/components-api/src/com/cloud/network/IpAddressManager.java
---
@@ -43,6 +43,9 @@
"If true, when account has dedicated public ip range(s), once the
ips dedicated to the account have been consumed ips will be acquired from the
system pool",
true, ConfigKey.Scope.Account);
+ static final ConfigKey<Boolean> RulesContinueOnError = new
ConfigKey<Boolean>("Advanced", Boolean.class,
"network.rule.delete.ignoreerror", "true",
--- End diff --
The default for ignoreerror is set to true, means the errors will be
ignored.
Shouldn't the default be set to false ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
