[GitHub] cloudstack pull request: Build and create tomcat, fix several othe...
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/238 Build and create tomcat, fix several other issues with management server Hi guys, This PR has the following goodies: - Tomcat built by maven project (currently set to 8.0.22); - Java 8 support on tomcat :) - Fixed sluggish page reload times for client webapp; - Fixed some issues and merged differences in the tomcat startup scripts in centos 6 and 7 - Fixed issue with cloudstack-setup-management script in centos 7 - Fixed duplication of static files in RPM in management rpm - Synced sudoers config and fixed error running keytool in ubuntu Some advantages of packing tomcat (while not getting rid of it completely ;) ): - Control the tomcat version that is actually run across all users by just setting the version on the tomcat module's pom.xml - Remove dependencies on different packages for tomcat in different distros (a change in the OS provided package will break setup, like what just happened with CentOS 7.0 vs 7.1). - Remove necessity of maintaining different configuration files for distros running different versions of tomcat - Extend out of the box functionality for more distros :) You can merge this pull request into a Git repository by running: $ git pull https://github.com/rsafonseca/cloudstack fixpackaging Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/238.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #238 commit 3173df15ec45bccaba1b6d77daeacc5d52816271 Author: Rafael da Fonseca Date: 2015-05-03T18:59:53Z first commit new packaging commit 2b3f09bd0b1fb31cb07f471e55d59517babcef26 Author: Rafael da Fonseca Date: 2015-05-05T01:38:31Z update commit 4b643c51eb46c85ab2fd4a6a50b898036eaff47b Author: Rafael da Fonseca Date: 2015-05-05T02:17:48Z update commit 45b9d7898ab21f92b25ac60ab02674eaf0b26f70 Author: Rafael da Fonseca Date: 2015-05-06T02:18:48Z all dandy commit d636845749e94b8a1299d5675d9b6ccb7f7a0166 Author: Rafael da Fonseca Date: 2015-05-06T02:47:07Z fixies commit e60614007762c56625e15522f20bc3453c07845c Author: Rafael da Fonseca Date: 2015-05-06T21:59:12Z update commit 1c9c2363dd9e3754441c9968c02fe72e1e9cf4fa Author: root Date: 2015-05-06T23:27:46Z update commit 4c51b0f718d1c73dbd8486827174147cc7ae723e Author: Rafael da Fonseca Date: 2015-05-07T00:39:50Z one more commit e142769ada7529a2e1e5f67af5d52d3b694049fd Author: root Date: 2015-05-07T00:57:12Z another update commit 1d28f5d69b86cbc68df976a6bde9371b18e143e3 Author: Rafael da Fonseca Date: 2015-05-07T17:42:07Z Merge branch 'master' into fixpackaging Conflicts: packaging/centos63/cloud.spec packaging/centos7/cloud.spec merge commit 0f1a7d4bc5582888f2e131d6fa400010c7476a37 Author: Rafael da Fonseca Date: 2015-05-07T18:09:10Z update commit 22cb37011c4a9d7f2c9b31e4cf4a4d6cc6ec35d6 Author: Rafael da Fonseca Date: 2015-05-08T00:05:04Z fixed sluggish page loads --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Build and create tomcat, fix several othe...
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/238#issuecomment-100282638 Yes, it completely removes the need to have tomcat installed in the distro, and at the same time won't conflict if there is any other version of tomcat installed. Besides that, everything seems to be working fine with *Java 8* now.. at least for management server :) I've made some basic testing with Centos6 and 7 and Ubuntu 12.04.05, and all seems fine (didn't update the fedora part yet) If everything goes smoothly and this gets pulled in, i'll make a bigger cleanup afterwards like removing any distro-specific files and config related to tomcat that are scattered troughout /server /client and /packaging). BTW Rohit, i noticed you cleaned up awsapi (i had to merge de spec files, darn) but you forgot to clean up the configs for tomcat, webapps7080 folder, firewall rules for it, etc ;) RF On Fri, May 8, 2015 at 4:59 PM, Rohit Yadav wrote: > Looks good, I see you've remove tomcat requirement as a package > dependency. Is this embedding tomcat so we won't need to install on the > distro? I can help test it next week. > > â > Reply to this email directly or view it on GitHub > <https://github.com/apache/cloudstack/pull/238#issuecomment-100262595>. > --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Build and create tomcat, fix several othe...
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/238#issuecomment-100317657
Yes, I'll take care of that.. i just haven't removed the old tomcat files
of other installers so that this PR wouldn't break building on any OS, as
is.
As soon as i have tested new configs for fedora i'll clean up the rest of
the stuff and do another PR :)
On Fri, May 8, 2015 at 8:07 PM, Rohit Yadav
wrote:
> Thanks @rsafonseca <https://github.com/rsafonseca>, it sounds great.
> While I think I had removed awsapi related tomcat stuff with commit
> 58999da
>
<https://github.com/apache/cloudstack/commit/58999daafe862ebbe953903ce7f928939c9b85f0>
> it's possible I may have missed few spots, or a recent merge on master
> could have brought few things back. Can you also help fix the fedora
> related specs etc, in packaging/{fedora20, fedora21}/ to maintain
> consistency wrt not using distro provided tomcat?
>
> â
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/cloudstack/pull/238#issuecomment-100315706>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Build and create tomcat, fix several othe...
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/238#issuecomment-100966791 Hi @bhaisaab Have you had time to test this? I'm amazed no one else cared to take a look at it, as it's a big change and a big step into supporting java8 and multiple distros :| --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Build and create tomcat, fix several othe...
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/238#issuecomment-101265715 Hi @bhaisaab :) I've also made some basic testing with fedora 2x as you asked and got everything working last night (apart from having the cluster servlet port (tcp 9090) clashing with systemd's cockpit. Just didn't commit the changes because of this last issue, was trying to gather some opinions on changing the port 9090 to some other port.. but no feedback/opinions on that yet... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Build and create tomcat, fix several othe...
Github user rsafonseca commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/238#discussion_r30165996 --- Diff: ui/index.jsp --- @@ -1761,73 +1761,73 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - --- End diff -- lol that article is for IE 4 and 5 :) The thing is, every time you refresh the page, the value of %now% changes, and it's like a whole new file, so the request is always triggered, and the tomcat doesn't fetch it from its own cache either.. because of different header :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Build and create tomcat, fix several othe...
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/238#issuecomment-101399140 Good catch k0kza, I hadn't noticed that StaticResourceServlet class, but i'll do some benchmarking on that vs tomcat 8's connector built in compression features, but it's still a whole lot faster than it was :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Build and create tomcat, fix several othe...
Github user rsafonseca commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/238#discussion_r30173402 --- Diff: ui/index.jsp --- @@ -1761,73 +1761,73 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - --- End diff -- I've tested with no problems in IE11 and chrome.. don't see how changing this would affect specifically IE users :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Build and create tomcat, fix several othe...
Github user rsafonseca commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/238#discussion_r30233372 --- Diff: ui/index.jsp --- @@ -1761,73 +1761,73 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - --- End diff -- There shouldn't be any cache issues using any of the current browsers (by current i mean since a few years back) with default settings. If the browser is specifically configured by the user to don't look for updates, the user should just do a ctrl+f5. In normal scenario, browser will always ask for the files and tomcat will respond with HTTP 304 (not modified) unless it actually is modified.. so it shouldn't affect the UI developers. There are tons of browser settings changes that would break the site completely, disabling static file updates lookup is far from being the worse setting a user can change from the defaults on any browser :) We should not be hitting everyone's performance badly just to support a scenario where a user changes a browser setting that provokes this specific behavior (on any site). Any way.. if it that was ever an issue... it would have not been fixed by placing the timestamp... since the timestamp is not on all .js files (just most of them) in index.jsp :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Build and create tomcat, fix several othe...
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/238#issuecomment-101683092 @bhaisaab rebased and sent. No new fixes since yesterday, but i rolled back the change of port 9090, to not leave anyone unhappy and make things easier on existing users :) Will provide a simple fix for that as soon as i have time, that will apply to all ports used :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Build and create tomcat, fix several othe...
Github user rsafonseca commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/238#discussion_r30316856
--- Diff: packaging/package.sh ---
@@ -48,6 +48,13 @@ function packaging() {
fi
DISTRO=$3
+
+JDK=$(rpm -qa | grep "java-1...0-openjdk-devel")
+for version in $JDK; do [ "${version:7:1}" -ge "7" ] && echo
${version:7:1}; done;
+if [ "$?" -gt "0" ] || [ -z "$JDK" ] ; then
--- End diff --
Yes.. definitely, I didn't test jdk6 silly me... I'll fix that when I can
get my pc back up because I'm currently driving across Europe :-). Just
remove that check from package.sh to test the rest, just punched that in to
remove constraints for java 7 and 8 from the spec files, and still inform
the user if he is missing jdk
On May 13, 2015 11:52 PM, "Erik Weber" wrote:
> In packaging/package.sh
> <https://github.com/apache/cloudstack/pull/238#discussion_r30280222>:
>
> > @@ -48,6 +48,13 @@ function packaging() {
> > fi
> >
> > DISTRO=$3
> > +
> > +JDK=$(rpm -qa | grep "java-1...0-openjdk-devel")
> > +for version in $JDK; do [ "${version:7:1}" -ge "7" ] && echo
${version:7:1}; done;
> > +if [ "$?" -gt "0" ] || [ -z "$JDK" ] ; then
>
> My previous comment is most likely related to this. If the last grep line
> doesn't match -ge 7, it'll fail
>
> â
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/cloudstack/pull/238/files#r30280222>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Build and create tomcat, fix several othe...
Github user rsafonseca commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/238#discussion_r30591946
--- Diff: packaging/package.sh ---
@@ -48,6 +48,13 @@ function packaging() {
fi
DISTRO=$3
+
+JDK=$(rpm -qa | grep "java-1...0-openjdk-devel")
+for version in $JDK; do [ "${version:7:1}" -ge "7" ] && echo
${version:7:1}; done;
+if [ "$?" -gt "0" ] || [ -z "$JDK" ] ; then
--- End diff --
@terbolous it's fixed :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Build and create tomcat, fix several othe...
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/238#issuecomment-103820696 Hello @wilderrodrigues :) I guess the status of this PR is that it was waiting for me to fix the build issues... i was away since last wednesday and just got back yesterday, so i hadn't had time to look into it until last night. The OVM3 failure in jenkins is indeed unrelated to my changes, it seems it's failing for a few PRs whenever it gets built on specific jenkins servers... probably due do different jenkins configs. About the testing, i had only run the existing JUnit tests and did some manual testing on the mentioned platforms (service startup/config issues, tomcat performance/startup and java8 supportability for some things that were failing) and did not test the whole platform.. i still didn't have a look at Marvin, i hope i'll have time to start playing with it over the next week :) @bhaisaab all fixed! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fixuireload
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/277 Fixuireload This PR is for issue https://issues.apache.org/jira/i#browse/CLOUDSTACK-8499 This affects all versions of cloudstack and can be cleanly applied to all supported branches. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rsafonseca/cloudstack fixuireload Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/277.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #277 commit 0f18205b27e5ffcc4ea5a1f28ce29a0edd8001ab Author: Rafael da Fonseca Date: 2015-05-21T08:10:05Z Fixed problem with static files reload: - Tomcat was not caching most static files in index.jsp due to changing timestamp - Page reload performance was very poor - Issue affects all versions since 4.0 commit e3f851cbc6bc88ac3df08e6af8ba04fff5b31d9f Author: Rafael da Fonseca Date: 2015-05-21T08:13:43Z Merge branch 'master' into fixuireload commit 39848ad50c88d5680c8cc0d465b10a2ed40168f8 Author: Rafael da Fonseca Date: 2015-05-21T08:10:05Z Fixed problem with static files reload: - Tomcat was not caching most static files in index.jsp due to changing timestamp - Page reload performance was very poor - Issue affects all versions since 4.0 commit 9ae5371f65a8da05f97d72050f7b8decbb0be8ec Author: Rafael da Fonseca Date: 2015-05-21T08:23:15Z Merge branch 'fixuireload' of https://github.com/rsafonseca/cloudstack into fixuireload --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fixes breadcrumbs problem described in CL...
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/282 Fixes breadcrumbs problem described in CLOUDSTACK-7907 There was an overlap in container placement in the breadcrumbs, leading to the links not being visually correct in some coordinates. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rsafonseca/cloudstack CLOUDSTACK-7907 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/282.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #282 commit e2598ff91db993548192ff46824118c2392932f1 Author: Rafael da Fonseca Date: 2015-05-21T22:54:29Z Fixes breadcrumbs problem described in CLOUDSTACK-7907 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request:
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/commit/1c408dec37a278c97c1b40da0bdbca437d7a564c#commitcomment-11318709 In debian/rules: In debian/rules on line 6: Hi @DaanHoogland This breaks the 4.6.0-SNAPSHOT .deb file builds, can you please revert? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8499: Fixuireload
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/277#issuecomment-104563604 Hi bhaisaab, A UI developer should be able to just press CTRL+F5 and always get the fresh version of files.. no need for something complicated... I just did that a few times yesterday with no issues while testing changes in .css --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Debian packaging fixes
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/291 Debian packaging fixes Fixes problem with having to change the "-SNAPSHOT" string in debian/rules for releases, deb packaging was broken in master due to this in a merge with release version. Fixes some warnings generated by dpkg-buildpackage regarding upstream tarball an source versioning Reduces source tarball from 669MB to 183MB (it was including .git), now build is faster and takes up less space You can merge this pull request into a Git repository by running: $ git pull https://github.com/rsafonseca/cloudstack debfixes Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/291.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #291 commit e1d8ba410e300021add0d904f41fe139d7d5c9a9 Author: Rafael da Fonseca Date: 2015-05-22T16:19:52Z Fixes problem with having to change the "-SNAPSHOT" string in debian/rules for releases, deb packaging was broken in master due to this in a merge with release version. Fixes some warnings generated by dpkg-buildpackage regarding upstream tarball an source versioning Reduces source tarball from 669MB to 183MB (it was including .git), now build is faster and takes up less space --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request:
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/commit/1c408dec37a278c97c1b40da0bdbca437d7a564c#commitcomment-11331207 In debian/rules: In debian/rules on line 6: @DaanHoogland great, master is building on debian again :) I do see this as an issue that gives extra work to maintainers, and would likely happen again in the future.. i propose this: https://github.com/apache/cloudstack/pull/291 I took the chance to include a couple more fixes to deb packaging since i was looking into this :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8502 Improvement/annotations k...
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/280#issuecomment-104771495
@wilderrodrigues the Xenserver tests are failing in master with a ClassCast
Exception :(
*/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/wrapper/citrix/CitrixRequestWrapper.java*
`Reflections baseWrappers = new
Reflections("com.cloud.hypervisor.xenserver.resource.wrapper");
@SuppressWarnings("rawtypes")
Set> baseSet =
baseWrappers.getSubTypesOf(CommandWrapper.class);`
The baseSet ends up becoming the sum of all tests, because the scanner is
recursive, so wrapper.xen56, wrapper.xcp, etc will all get included in the set.
I've tested fixing it by changing the package for the Citrix* classes to a
package that in not parent to the other wrapper's classes and it's working fine.
Do you want to fix this your way, or should I send a PR? :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request:
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/commit/1c408dec37a278c97c1b40da0bdbca437d7a564c#commitcomment-11339020 In packaging/centos63/cloud.spec: In packaging/centos63/cloud.spec on line 273: Hi again @DaanHoogland :) This one breaks packaging for centos6 The _cloudstackmanagementconf and _cloudstackmanagementconfattr lines throw and error in rpmpackaging because their not set in 4.6.0 packaging Please remove t --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fix xenserver tests for travis
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/293 Fix xenserver tests for travis Fix ClassCast exception being thrown due to recursive scan in com.cloud.hypervisor.xenserver.resource.wrapper picking up subpackage modules for running the citrix tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/rsafonseca/cloudstack xentestfix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/293.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #293 commit 79d24ae218889b36674f2c064701638b3f2c5e29 Author: Rafael da Fonseca Date: 2015-05-23T14:14:09Z Fix xenserver tests for travis --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8502 Improvement/annotations k...
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/280#issuecomment-104901705 Hoi @wilderrodrigues :) I've created a pull request for it, have a look https://github.com/apache/cloudstack/pull/293 glad to help :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8339: Allow non-root users to ...
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/288#issuecomment-105056903
Hi @remibergsma
If you're running into the no tty issue, that will likely happen also for
the other commands the management server tries to run.
I'm using this file in /etc/sudoers.d in all environments:
{code}
Cmnd_Alias CLOUDSTACK = /bin/mkdir, /bin/mount, /bin/umount, /bin/cp,
/bin/chmod, /usr/bin/keytool, /bin/keytool
Defaults:cloud !requiretty
cloud ALL=(root) NOPASSWD:CLOUDSTACK
{code}
I believe this is the best way to resolve it for all distros/configs, as
long as we depend on sudo
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Build and create tomcat, fix several othe...
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/238#issuecomment-105057113 looks like a couple more things got broken since last rebase with master... need to refix :| --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8339: Allow non-root users to ...
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/288#issuecomment-105063069 Silly me.. this is running as supplied user, not as cloud. I agree remi, ssh -t is the better option :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8339: Allow non-root users to ...
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/288#issuecomment-105073554 Creating a user for this use would be worse, because it would require some sort of 'standard' credential for ssh access. Or it would require that such account didn't have ssh access and supplied account would need to sudo su account to use It to run the script.. so no advantage. I think that the best way to tackle this would be to use the actual agent for registration. Letting the agent startup without config and listen on tcp port for remote registration (no ssh or sudo) and just process the credentials sent and self configure. I can work on this if you'd like :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Debian packaging fixes
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/291#issuecomment-105253780 @bhaisaab , I wanted to keep hugo's history by manually editing the changelog after doing the testing... unfortunately, editing it manually breaks it.. can you revert just this change? https://github.com/apache/cloudstack/commit/68d18c234955e4aeac758d30bf834fd3f4deec9d --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request:
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/commit/0cdb4b610865fa5493cc79e9c9ef310bdf09ccaf#commitcomment-11359437 Hi @wilderrodrigues The refactoring of the Libvirt broke Libvirt functionality in runtime. Whenever spinning up a new instance in master, deploying VMs with kvm fails with no useful info in the logs. Upon getting some debugging in, it seems that the injected LibvirtUtilitiesHelper is returning null at runtime: LibvirtComputingResource.java: @Inject private LibvirtUtilitiesHelper libvirtUtilitiesHelper; LibvirtCommandWrapper.java ... final LibvirtUtilitiesHelper libvirtUtilitiesHelper = libvirtComputingResource.getLibvirtUtilitiesHelper(); ... conn = libvirtUtilitiesHelper.getConnectionByType(vm.getHvsType()); ... Throws NullPointerException on libvirtUtilitiesHelper Can you have a look? :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request:
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/commit/0cdb4b610865fa5493cc79e9c9ef310bdf09ccaf#commitcomment-11359669 This happens in all my environments (Ubuntu, Fedora21, Centos6, Centos7) All marvin tests run fine in all environments. Upon doing an actual install and going through the setup wizard, issue occurs after initializing host and attempting to deploy systemvms. The only failure that gets logged is in management server logs stating that response is not of type StartAnswer or something like that. It's actually of time UnsupportedAnswer, because it gets created as such due to any exception ocurring in the Wrapper's execution. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request:
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/commit/0cdb4b610865fa5493cc79e9c9ef310bdf09ccaf#commitcomment-11359702
This is where ANY exception gets thrown into an UnsupportedCommandAnswer,
with no information about the actual exception being sent back to the agent:
LibvirtComputingResource.java:
@Override
public Answer executeRequest(final Command cmd) {
final LibvirtRequestWrapper wrapper =
LibvirtRequestWrapper.getInstance();
try {
return wrapper.execute(cmd, this);
} catch (final Exception e) {
return Answer.createUnsupportedCommandAnswer(cmd);
}
}
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request:
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/commit/0cdb4b610865fa5493cc79e9c9ef310bdf09ccaf#commitcomment-11360242 Hi @wilderrodrigues Everything is built on the latest code in my testing, so agent is 4.6.0-SNAPSHOT as well. The issue happens going through the basic startup wizard and deploying system vms (ssvm and console proxy), try to reproduce using that :) I just mentioned that uncool try/catch because it was preventing proper debugging whenever the issue occurs, this was just a heads up to help you debug the issue once you are able to reproduce it, not an indication of the root cause :) I can also give it a try with the version you're referring to (not the lastest) to see if the issue was already present when that package got built, anyway, i can only do it later tonight, as my dayjob is gonna keep me busy the whole day today :) Cheers, RF --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request:
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/commit/0cdb4b610865fa5493cc79e9c9ef310bdf09ccaf#commitcomment-11361925 @wilderrodrigues Yes, i mean creating datacenter manually, since creating it in simulator with marvin shows no errors. Here's what's logged in the management server log: com.cloud.utils.exception.CloudRuntimeException: Unable to get answer that is of class com.cloud.agent.api.StartAnswer at com.cloud.agent.manager.Commands.getAnswer(Commands.java:80) at com.cloud.vm.VirtualMachineManagerImpl.orchestrateStart(VirtualMachineManagerImpl.java:1023) at com.cloud.vm.VirtualMachineManagerImpl.orchestrateStart(VirtualMachineManagerImpl.java:4524) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at com.cloud.vm.VmWorkJobHandlerProxy.handleVmWorkJob(VmWorkJobHandlerProxy.java:107) at com.cloud.vm.VirtualMachineManagerImpl.handleVmWorkJob(VirtualMachineManagerImpl.java:4680) at com.cloud.vm.VmWorkJobDispatcher.runJob(VmWorkJobDispatcher.java:103) at org.apache.cloudstack.framework.jobs.impl.AsyncJobManagerImpl$5.runInContext(AsyncJobManagerImpl.java:537) at org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:49) at org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56) at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103) at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53) at org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:46) at org.apache.cloudstack.framework.jobs.impl.AsyncJobManagerImpl$5.run(AsyncJobManagerImpl.java:494) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471) at java.util.concurrent.FutureTask.run(FutureTask.java:262) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:745) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request:
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/commit/0cdb4b610865fa5493cc79e9c9ef310bdf09ccaf#commitcomment-11361958 It's actually sending an UnsupportedAnswer.class object, that is why it's not StartAnswer.class. Putting some debug in the LibvirtComputingResource.java i get this in the agent log: java.lang.NullPointerException at com.cloud.hypervisor.kvm.resource.wrapper.LibvirtStartCommandWrapper.execute(LibvirtStartCommandWrapper.java:73) at com.cloud.hypervisor.kvm.resource.wrapper.LibvirtStartCommandWrapper.execute(LibvirtStartCommandWrapper.java:46) at com.cloud.hypervisor.kvm.resource.wrapper.LibvirtRequestWrapper.execute(LibvirtRequestWrapper.java:75) at com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.executeRequest(LibvirtComputingResource.java:1263) at com.cloud.agent.Agent.processRequest(Agent.java:503) at com.cloud.agent.Agent$AgentRequestHandler.doTask(Agent.java:809) at com.cloud.utils.nio.Task.run(Task.java:84) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:745) java.lang.NullPointerException at com.cloud.hypervisor.kvm.resource.wrapper.LibvirtStopCommandWrapper.execute(LibvirtStopCommandWrapper.java:64) at com.cloud.hypervisor.kvm.resource.wrapper.LibvirtStopCommandWrapper.execute(LibvirtStopCommandWrapper.java:40) at com.cloud.hypervisor.kvm.resource.wrapper.LibvirtRequestWrapper.execute(LibvirtRequestWrapper.java:75) at com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.executeRequest(LibvirtComputingResource.java:1263) at com.cloud.agent.Agent.processRequest(Agent.java:503) at com.cloud.agent.Agent$AgentRequestHandler.doTask(Agent.java:809) at com.cloud.utils.nio.Task.run(Task.java:84) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:745) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request:
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/commit/0cdb4b610865fa5493cc79e9c9ef310bdf09ccaf#commitcomment-11361983 java.lang.NullPointerException at com.cloud.hypervisor.kvm.resource.wrapper.LibvirtStartCommandWrapper.execute(LibvirtStartCommandWrapper.java:73 This is actually thrown in LibvirtStartCommandWrapper.java:72 , not 73.. the increment was due to some other debugging code i had put in there :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request:
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/commit/0cdb4b610865fa5493cc79e9c9ef310bdf09ccaf#commitcomment-11362046 Just to be clear... NO error is logged in the agent logs when this occurs (with the current code). It just keeps trying to create and delete the new vm's disk and shows no error when it fails to start. The only error is shown in the management server logs. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request:
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/commit/0cdb4b610865fa5493cc79e9c9ef310bdf09ccaf#commitcomment-11362538 Well.. it's actually this line, perhaps i was mistaken about line 72.. just got that from my fuzzy memory :) conn = libvirtUtilitiesHelper.getConnectionByType(vm.getHvsType()); --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request:
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/commit/0cdb4b610865fa5493cc79e9c9ef310bdf09ccaf#commitcomment-11362581 I can't test ATM, but i will do so later when i get home :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Build and create tomcat, fix several othe...
Github user rsafonseca commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/238#discussion_r31043937 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtConsoleProxyLoadCommandWrapper.java --- @@ -49,6 +49,11 @@ public Answer executeProxyLoadScan(final Command cmd, final long proxyVmId, fina final URL url = new URL(sb.toString()); final URLConnection conn = url.openConnection(); +// setting TIMEOUTs to avoid possible waiting until death situations --- End diff -- @wilderrodrigues You may also want to get this into the libvirt refactor work you're doing. This is a copy/paste from: git/rsafonseca/cloudstack/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/wrapper/citrix/CitrixConsoleProxyLoadCommandWrapper.java --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Reinstate working sessions in browser
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/308 Reinstate working sessions in browser I've seen that session persistence stopped working due to https://github.com/apache/cloudstack/commit/19e3c0168e744a76b5e1dc24a5eafa776d342404 From what I could gather from the comments, this was done to fix issue where separate instances of management servers could exist within the same domain. I've fixed the above mentioned issue by prepending the location's hostname, in order to allow both sessions to co-exist without clashing. This also removes the need for this fix https://github.com/apache/cloudstack/commit/6c71d3bae1a3a72a9fa4004decdba4a7174f6913 You can merge this pull request into a Git repository by running: $ git pull https://github.com/rsafonseca/cloudstack fixsessions Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/308.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #308 commit ef4a2f6c592a911dc12c63ef30ed3028ce56e2da Author: Rafael da Fonseca Date: 2015-05-26T21:29:11Z Reinstate working sessions in browser while fixing same domain different instance issue --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Reinstate working sessions in browser
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/308#issuecomment-105672476 @bhaisaab please take a look :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Reinstate working sessions in browser
Github user rsafonseca commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/308#discussion_r31084802
--- Diff: ui/scripts/cloudStack.js ---
@@ -329,7 +325,6 @@
g_regionsecondaryenabled = null;
g_loginCmdText = null;
-$.cookie('JSESSIONID', null);
$.cookie('sessionkey', null);
--- End diff --
Indeed Erik, thanks for pointing that out. I've updated the PR.
On Tue, May 26, 2015 at 11:46 PM, Erik Weber
wrote:
> In ui/scripts/cloudStack.js
> <https://github.com/apache/cloudstack/pull/308#discussion_r31083230>:
>
> > @@ -329,7 +325,6 @@
> > g_regionsecondaryenabled = null;
> > g_loginCmdText = null;
> >
> > -$.cookie('JSESSIONID', null);
> > $.cookie('sessionkey', null);
>
> I'm no UI/Javascript expert, but should these include hostname as well? If
> so, same goes for L351+
>
> â
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/cloudstack/pull/308/files#r31083230>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Reinstate working sessions in browser
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/308#issuecomment-105682213 I searched around for that reference and found nothing useful, perhaps @bhaisaab can shed some light, since it was signed off by him :) If I understood correctly, the issue is easy to reproduce, two instances of management server in the same domain would get messed up with each other's auth due to the cookies. This prevents said issue from occurring, hopefully Rohit will confirm that :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Build and create tomcat, fix several othe...
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/238#issuecomment-10584 Hi @wilderrodrigues I was hoping on reducing the number of changes from this PR to master, so it would be better if you pushed it along with your refactor and i'll just rebase with master, since i don't know when this will get merged :) During your Libvirt refactor pushes, i was having some trouble with that specific test taking too long to run, it was fixed after i set the timeout (after 5 seconds failure, waits no longer to fail and continues), so this speeds things up unless a connection is not actually established, not the other way around :) Replacing that with a static final would be nice, but like i said, this is a copy/paste from the xenserver class of the same name, so that change should be applied there also in order to be consistent. I'd rather not add any more fixes that are unrelated to the tomcat change into this PR :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Reinstate working sessions in browser
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/308#issuecomment-105861689 I see that in the parent commit Jessica tried to fix security on the cookie by setting httponly=true in tomcat's context .xml This would be a sane thing to do, if the sessionkey cookie was actually handled by tomcat, which is not. This cookie only existed on client side, and was created by .js, so it's not possible to set httponly on that. This approach does not add any extra security, since the data is still stored in a .js variable and accessible to scripts, only the location of the data has changed, but this not confer extra security. Basically, all this did was break the functionality and remove 1 of the 2 places where the sessionkey was accessible through javascript. My new proposal is to actually get httponly cookie working, which thwarts most kinds of XSS attacks. This is done by making the server handle the cookie (not the client). The only thing i didn't fix was the same security hole being created by the SAML login (cookie with sessionkey data is created in browser), since i didn't have it setup to test. These changes shouldn't break it though, it will just keep the same insecure behaviour. Have a look at my proposed changes :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8517 Fix the NPE that was bein...
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/318#issuecomment-105931452 Great @wilderrodrigues :) Thank you for fixing that, i'll test it out later. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Build and create tomcat, fix several othe...
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/238#issuecomment-106741425 Hi @remibergsma First of all. thank you for your comment :) I've been very busy these past couple of days, so i haven't gotten around to do what you suggested, but i will take care of that over the weekend (squash commits, clean description of fixes), I will also try to get a couple more stuff in as separate pull requests and clean up a couple more things ;) As for testing this, there is no other way to test this other than manually since marvin doesn't even use tomcat for testing, altough the travis setup scripts download an old version of tomcat into the hard disk the tests do nothing with it :) That should also be cleaned up. Another handy thing that's really missing in the tests is a test to packaging! In the past weeks a few things got into master that completely broke packaging.. although Rohit fixed most of that already, centos6 packaging is still broken. As a side note, master also still doesn't work in Centos 7.1 and Fedora 21.. that's all in here hehe ;) If you guys would like, i can also alter the test scripts to use the same tomcat that will be used in the actual product instead of jetty, which will make for a test scenario closer to reality. This can be done in a way which will easily allow switching between tomcat and jetty in the future :) What do you think of that? BR, Rafael --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Build and create tomcat, fix several othe...
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/238#issuecomment-106752449 Hi @wilderrodrigues Both the issues you hit are legacy behaviour :) I'm guessing that you've deployed it in debian, because the server.xml issue is handled properly by the RPM installers, but not by the debian one. To have it working after install on debian, just run the cloudstack-setup-management script, which i think is the standard way of setting things up, that's why I didn't bother to get the server.xml properly linked on package install in debian yet. I've been thinking about doing something better (at least that's my opinion, please drop a comment on this) which is setup the management server to ALWAYS run with both HTTP and HTTPS right after setup (using generated cert until user provides one) About that mysql-ha lib i guess it's one of the optionally packed libraries? i still haven done any testing on those. I just left this bit as it was. Happy testing :) RF --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Build and create tomcat, fix several othe...
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/238#issuecomment-106758023 Indeed.. it's only setup on centos 6 and not 7, sorry for misleading you there :) cloudstack-setup-management will link the server.xml in any environment anyway. The current version on master drops a server.xml in the folder (for Centos7 only), but it doesn't support SSL. I just restored the behaviour to be the same as in other OSs (you get a non-ssl and ssl version and link is handled by the setup scripts). Configuring SSL by default will remove the need to have a separate server-ssl.xml and server-nonssl.xml and will enable to just drop the server.xml config file in /etc/cloudstack/management . The behaviour should be consistent across distros Thanks for taking the time to test it out :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Reinstate working sessions in browser
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/308#issuecomment-106818248 Hi Rohit, thank you for your view on this :) Here's my comment on it: 1. No use on protecting the sessionkey from MITM attacks, as the username/password are sent in plain text, and so are all the other commands, so anyone can pickup your credentials if they're listening on the wire ;). For MITM protection SSL should be used. I did notice that isSecureSessionCookieEnabled i actually placed the cookie in raw to be exactly the same as the sessioncookie. I did use the cookie class for reading though :). So.. both cookies should be inserted in the same fashion. 2. Will take care of that :) 3. I miss the purpose.. session cleanup? Can you explain a bit more? :) 4. If you don't return it in the loginResponse, regular (non-browser) calls to the API will fail, because i guess all integrations with the API depend on it, that's why i didn't remove it. It can be in the response, as long as javascript doesn't store it for later access. Regarding the non-bulleted stuff: Secure cookie: I don't agree with this one, that will make it just not work at all in HTTP. We aim to fix a browser vulnerability here, not a communication channel one. If someone wants on the wire security, they should just switch to SSL. Not depend on sessionkey as API argument: Will that not break some API implementations? I think supporting both methods is the best for now. About SAML and redirect based auth not working: Are you sure? Did you test? I left it in a way it would likely work... cookie is still read an put into the javascript variable if it was created on redirection. Since the SAML plugin just puts it back in a cookie so i didn't bother destroying it in that scenario, the plugin should be modded for that. Either way.. it *should* work :) Thanks for reviewing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Cleanup awsapi leftovers
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/328 Cleanup awsapi leftovers Just a couple of things that were still in the code :) You can merge this pull request into a Git repository by running: $ git pull https://github.com/rsafonseca/cloudstack clean-awsapi Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/328.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #328 commit 78828188d126213abc8fe26c4b1fa04ed75227b2 Author: Rafael da Fonseca Date: 2015-05-29T17:02:55Z Cleanup awsapi leftovers --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Cleanup awsapi leftovers
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/328#issuecomment-106875402 If if comes back we will just kill it again :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fix agent/management conflict
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/329 Fix agent/management conflict There is an entry for the agent log directory in the management packaging, creating a conflict between the two RPMs. This issue occurs in both 4.4.x and 4.5.x This fixes not being able to install cloudstack-agent and cloudstack-management in the same machine in CentOS. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rsafonseca/cloudstack 45_rpmconflict Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/329.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #329 commit 1138f54c323a5340b426a15f8efeb293bc738c2d Author: Rafael da Fonseca Date: 2015-05-29T17:55:32Z Fix agent/management conflict --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fix agent/management conflict
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/329#issuecomment-106893942 @DaanHoogland too late for 4.4.4? :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fix agent/management conflict
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/329#issuecomment-106897613 nah not blocking a thing on my side.. just thought i'd contribute something more to your release, but it wasn't on time :) one old bug less for 4.4.5 i guess ;) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Change tests random number generator to /...
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/330 Change tests random number generator to /dev/urandom This fixes a big performance issue with random number generation with more recent kernels and java versions in linux, the impact is specially higher on VMs Some tests (that use random number generation) in some environments take randomly 1 - 20 mins to perform tests that should take only seconds to run. This PR is just intended for fixing it on the tests. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rsafonseca/cloudstack fast_tests Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/330.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #330 commit 82847d4405f20920a1ca066765071d485931ff19 Author: Rafael da Fonseca Date: 2015-05-29T18:24:41Z Change tests random number generator to /dev/urandom This fixes a big performance issue with random number generation with more recent kernels and java versions in linux --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fix agent/management conflict
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/329#issuecomment-106904018 perhaps there was a regression? I got the issue in 4.4 and 4.5 master is fine though :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fix agent/management conflict
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/329#issuecomment-106908778 @bhaisaab you are right! .. though it happened on the 4.5 version i built locally... perhaps my copy of the branch was not up to date when i tested :) Closing! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fix agent/management conflict
GitHub user rsafonseca reopened a pull request: https://github.com/apache/cloudstack/pull/329 Fix agent/management conflict There is an entry for the agent log directory in the management packaging, creating a conflict between the two RPMs. This issue occurs in both 4.4.x and 4.5.x This fixes not being able to install cloudstack-agent and cloudstack-management in the same machine in CentOS. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rsafonseca/cloudstack 45_rpmconflict Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/329.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #329 commit 1138f54c323a5340b426a15f8efeb293bc738c2d Author: Rafael da Fonseca Date: 2015-05-29T17:55:32Z Fix agent/management conflict --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fix agent/management conflict
Github user rsafonseca closed the pull request at: https://github.com/apache/cloudstack/pull/329 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fix agent/management conflict
Github user rsafonseca closed the pull request at: https://github.com/apache/cloudstack/pull/329 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fix agent/management conflict
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/329#issuecomment-106908889 . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Change tests random number generator to /...
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/330#issuecomment-106909482 there's a builtin symlink that redirects /dev/urandom to /dev/random. this is the only way to make it work :) This is a known issue with a lot of java apps running in linux --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Use same sudoers config for all distros
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/332 Use same sudoers config for all distros Each distro was using its own sudo config method, now all use the same config file and are setup by the packaging and have the user variable evaluated from config Cleanup python code for sudoers file editing with hardcoded user You can merge this pull request into a Git repository by running: $ git pull https://github.com/rsafonseca/cloudstack sudoconfig Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/332.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #332 commit 7deec642ef9c4c137e0cb1d01efedcada9afb8ab Author: Rafael da Fonseca Date: 2015-05-29T20:10:39Z Use same sudoers config for all distros Cleanup buggy code for sudoers file editing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Reinstate working sessions in browser
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/308#issuecomment-106937060
Hi @bhaisaab
I don't think that is an issue :)
Whatever your login method, the cookie will always be set on the first
successful command and subsequent ones.
On normal login, the js doesn't really store it in a variable, it tries to
read the httponly cookie and fails , and all subsequent API commands have the
param sessionkey="null".. that's why i'm checking if command.equals("null") to
get the cookie :)
If you have tested and have issues, might also be the case that the saml
codes tries to set the cookie, overwriting the existing httponly cookie with a
plain one, thus breaking auth.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Reflections upgrade to 0.9.9
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/333 Reflections upgrade to 0.9.9 Reflection's 0.9.8 dependency javassist doen't properly support java8 and was throwing: Error: java.io.IOException: invalid constant type: 18 Running some unit tests with PowerMockRunner caused this issue, so this fixes it for future tests that use it. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rsafonseca/cloudstack reflections Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/333.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #333 commit ef4a2f6c592a911dc12c63ef30ed3028ce56e2da Author: Rafael da Fonseca Date: 2015-05-26T21:29:11Z Reinstate working sessions in browser while fixing same domain different instance issue commit 775365ae30dd4d93ea2063d6fd06f358bcae293b Author: Rafael da Fonseca Date: 2015-05-26T22:03:04Z Fix all cookie references. Cleanup a couple of extra cookies on logout. commit 7c2502a9c2cd538336c5d87a7613f3b541bd70ec Author: Rafael da Fonseca Date: 2015-05-27T10:37:06Z Set sessionkey on HttpOnly cookie handled by ApiServlet Remove sessionkey data stored in js variable commit 376497aeb9ede7e79eaa65cf632e18b7db013fb4 Author: Rafael da Fonseca Date: 2015-05-29T21:32:35Z Upgrade Reflections to 0.9.9 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Reflections upgrade to 0.9.9
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/333#issuecomment-106941899 ops :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fixes LB certificate tests failure
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/336 Fixes LB certificate tests failure Whenever the path to the project includes a URL encodable character like whitespace, these tests fail to find the local path to the certs. This is because getClass().getResource() returns a URL object and that is used directly to initialize a local file path. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rsafonseca/cloudstack fixcerttest Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/336.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #336 commit fdf3cdf3ac83ec6193de970143f973315b0d7818 Author: Rafael da Fonseca Date: 2015-05-30T18:31:55Z Fixes LB certificate tests failure when the full path has a special character like whitespace or many others. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Update debian packaging
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/339 Update debian packaging This fixes build issue with http://jenkins.buildacloud.org/view/4.4/job/cloudstack-4.4-package-deb/ Reduce source package size (was including .git) Fix a couple of dpkg-buildpackage warnings Remove dependency on changing version on changelog to be able to build package after changing pom.xml Remove nasty hack for snapshot versions on debian/rules You can merge this pull request into a Git repository by running: $ git pull https://github.com/rsafonseca/cloudstack debfixes44 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/339.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #339 commit 3fe1c6d681e740c0f3bf30d36450ae9f3e911e8b Author: Rafael da Fonseca Date: 2015-06-01T11:39:08Z Update debian packaging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Version evaluated with native tools inste...
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/341 Version evaluated with native tools instead of maven I think i saw a build failure yesterday on buildacloud.com due to missing plexus libs invoking the mvn command. Can't seem to pinpoint it now, but this fixes it if it reoccurs, and also makes this specific task much faster. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rsafonseca/cloudstack debfixes Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/341.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #341 commit 55ff2bdf213b8bd38064135c40bf36241a82fa7f Author: Rafael da Fonseca Date: 2015-06-01T13:01:37Z Version evaluated with native tools instead of maven --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Mocking the Connect object used in the Li...
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/342#issuecomment-107454748 LGTM :D Will test it out later! Thanks for this :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Mocking the Connect object used in the Li...
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/342#issuecomment-107663305 [INFO] Apache CloudStack Plugin - Hypervisor KVM . SUCCESS [6.987s] Perfect :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Version evaluated with native tools inste...
Github user rsafonseca commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/341#discussion_r31657434
--- Diff: debian/rules ---
@@ -1,6 +1,6 @@
#!/usr/bin/make -f
# -*- makefile -*-
-VERSION := $(shell mvn
org.apache.maven.plugins:maven-help-plugin:2.1.1:evaluate
-Dexpression=project.version | grep -v "\[")
+VERSION := $(shell awk 'f{print;f=0} /cloudstack/{f=1}'
pom.xml| sed -e 's/<[^>]*>//g' -e 's/^[ \t]*//')
--- End diff --
Hi @bhaisaab
So you think it's not worth the speed improvement? Should i just close this
one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Reinstate working sessions in browser
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/308#issuecomment-108577290 Hi @bhaisaab Any news on testing it? If i misunderstood the problem you stated, can you explain further or help fix as you suggested? I'm sure a lot of people would like to see this through :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Update debian packaging
Github user rsafonseca closed the pull request at: https://github.com/apache/cloudstack/pull/339 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Update debian packaging
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/339#issuecomment-108631632 yeah.. asfbot seems to only monitor master :) closing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Version evaluated with native tools inste...
Github user rsafonseca closed the pull request at: https://github.com/apache/cloudstack/pull/341 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Version evaluated with native tools inste...
Github user rsafonseca commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/341#discussion_r31677186
--- Diff: debian/rules ---
@@ -1,6 +1,6 @@
#!/usr/bin/make -f
# -*- makefile -*-
-VERSION := $(shell mvn
org.apache.maven.plugins:maven-help-plugin:2.1.1:evaluate
-Dexpression=project.version | grep -v "\[")
+VERSION := $(shell awk 'f{print;f=0} /cloudstack/{f=1}'
pom.xml| sed -e 's/<[^>]*>//g' -e 's/^[ \t]*//')
--- End diff --
Well.. i'm actually building packages often because i'm working on it :)
but since it's just a few seconds more, it's not a big deal.. i was more
worried about that failure that i can't seem to find again... so, closing until
i can pinpoint an actual issue with this in the jenkins build env :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fix findbugs high priority warning
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/362 Fix findbugs high priority warning VmwareStorageManagerImpl.java:1023, RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE, Priority: High Redundant nullcheck of datastoreVolumePath, which is known to be non-null in com.cloud.hypervisor.vmware.manager.VmwareStorageManagerImpl.getVolumePathInDatastore(DatastoreMO, String) Assertion is not used in runtime, correct way is throw and handle exception. This just gets rid of the warning on the findbugs reports. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rsafonseca/cloudstack findbugs1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/362.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #362 commit 424b8e0f7a7dc417d09233e8d01d6470db2b4002 Author: Rafael da Fonseca Date: 2015-06-07T09:38:04Z Fix findbugs high priority warning VmwareStorageManagerImpl.java:1023, RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE, Priority: High Redundant nullcheck of datastoreVolumePath, which is known to be non-null in com.cloud.hypervisor.vmware.manager.VmwareStorageManagerImpl.getVolumePathInDatastore(DatastoreMO, String) Assertion is not used in runtime, correct way is throw and handle exception without killing app --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fix 2 findbugs high priority warnings
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/363 Fix 2 findbugs high priority warnings VmwareResource.java:315, MS_SHOULD_BE_FINAL, Priority: High com.cloud.hypervisor.vmware.resource.VmwareResource.s_serviceContext isn't final but should be VmwareResource.java:331, MS_SHOULD_BE_FINAL, Priority: High com.cloud.hypervisor.vmware.resource.VmwareResource.s_powerStatesTable isn't final but should be You can merge this pull request into a Git repository by running: $ git pull https://github.com/rsafonseca/cloudstack findbugs2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/363.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #363 commit 7873080bb822627868a36ba5b50ef6033af2f21b Author: Rafael da Fonseca Date: 2015-06-07T09:44:28Z Fix 2 findbugs high priority warnings VmwareResource.java:315, MS_SHOULD_BE_FINAL, Priority: High com.cloud.hypervisor.vmware.resource.VmwareResource.s_serviceContext isn't final but should be VmwareResource.java:331, MS_SHOULD_BE_FINAL, Priority: High com.cloud.hypervisor.vmware.resource.VmwareResource.s_powerStatesTable isn't final but should be --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fix another findbugs high priority warnin...
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/364 Fix another findbugs high priority warning JuniperSrxResource.java:2617, ES_COMPARING_STRINGS_WITH_EQ, Priority: High Comparison of String objects using == or != in com.cloud.network.resource.JuniperSrxResource.manageApplication(JuniperSrxResource$SecurityPolicyType, JuniperSrxResource$SrxCommand, JuniperSrxResource$Protocol, int, int) This now correctly compares strings You can merge this pull request into a Git repository by running: $ git pull https://github.com/rsafonseca/cloudstack findbugs3 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/364.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #364 commit 5a3e3ff57f87dde0ec5c87fba0ebf3649aafe527 Author: Rafael da Fonseca Date: 2015-06-07T19:18:11Z Fix another findbugs high priority warning JuniperSrxResource.java:2617, ES_COMPARING_STRINGS_WITH_EQ, Priority: High Comparison of String objects using == or != in com.cloud.network.resource.JuniperSrxResource.manageApplication(JuniperSrxResource$SecurityPolicyType, JuniperSrxResource$SrxCommand, JuniperSrxResource$Protocol, int, int) This now correctly compares strings --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fix performance issue reported by findbug...
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/365 Fix performance issue reported by findbugs (unnescessary boxing/unbox⦠â¦ing) VmwareResource.java:693, DM_BOXED_PRIMITIVE_FOR_PARSING, Priority: High VmwareResource.java:4769, DM_BOXED_PRIMITIVE_FOR_PARSING, Priority: High Boxing/unboxing to parse a primitive com.cloud.hypervisor.vmware.resource.VmwareResource.getNetworkStats(String) Now op is faster and takes up less memory You can merge this pull request into a Git repository by running: $ git pull https://github.com/rsafonseca/cloudstack findbugs4 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/365.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #365 commit 82f9c21f2e216fab9919813d5eed1edfab730bf9 Author: Rafael da Fonseca Date: 2015-06-07T19:23:09Z Fix performance issue reported by findbugs (unnescessary boxing/unboxing) VmwareResource.java:693, DM_BOXED_PRIMITIVE_FOR_PARSING, Priority: High VmwareResource.java:4769, DM_BOXED_PRIMITIVE_FOR_PARSING, Priority: High Boxing/unboxing to parse a primitive com.cloud.hypervisor.vmware.resource.VmwareResource.getNetworkStats(String) Now op is faster and takes up less memory --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fix 3 more findbugs performance alerts, c...
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/366 Fix 3 more findbugs performance alerts, creating boxed Long and Integer unnecessarily F5BigIpResource.java:297, DM_BOXED_PRIMITIVE_FOR_PARSING, Priority: High F5BigIpResource.java:703, DM_BOXED_PRIMITIVE_FOR_PARSING, Priority: High F5BigIpResource.java:889, DM_BOXED_PRIMITIVE_FOR_PARSING, Priority: High Boxing/unboxing to parse a primitive com.cloud.network.resource.F5BigIpResource You can merge this pull request into a Git repository by running: $ git pull https://github.com/rsafonseca/cloudstack findbugs5 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/366.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #366 commit 425ac2890e93517ee77f47608e901c5f7a227999 Author: Rafael da Fonseca Date: 2015-06-07T19:33:49Z Fix 3 more findbugs performance alerts, creating Long and Integer unnecessarily F5BigIpResource.java:297, DM_BOXED_PRIMITIVE_FOR_PARSING, Priority: High F5BigIpResource.java:703, DM_BOXED_PRIMITIVE_FOR_PARSING, Priority: High F5BigIpResource.java:889, DM_BOXED_PRIMITIVE_FOR_PARSING, Priority: High Boxing/unboxing to parse a primitive com.cloud.network.resource.F5BigIpResource --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fix another case of unnecessary boxing
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/367 Fix another case of unnecessary boxing JuniperSrxResource.java:1280, DM_BOXED_PRIMITIVE_FOR_PARSING, Priority: High Boxing/unboxing to parse a primitive com.cloud.network.resource.JuniperSrxResource.removeDestinationNatRules(Long, Map, List) You can merge this pull request into a Git repository by running: $ git pull https://github.com/rsafonseca/cloudstack findbugs6 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/367.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #367 commit 4b16c4418a9dadd5bf10cab1d06d52e8e6ae7f8f Author: Rafael da Fonseca Date: 2015-06-07T19:38:01Z Fix another case of unnecessary boxing JuniperSrxResource.java:1280, DM_BOXED_PRIMITIVE_FOR_PARSING, Priority: High Boxing/unboxing to parse a primitive com.cloud.network.resource.JuniperSrxResource.removeDestinationNatRules(Long, Map, List) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fix last ocurrence of unnecessary boxing ...
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/368 Fix last ocurrence of unnecessary boxing detected by findbugs CiscoVnmcResource.java:266, DM_BOXED_PRIMITIVE_FOR_PARSING, Priority: High Boxing/unboxing to parse a primitive com.cloud.network.resource.CiscoVnmcResource.getIpRangeFromCidr(String) You can merge this pull request into a Git repository by running: $ git pull https://github.com/rsafonseca/cloudstack findbugs7 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/368.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #368 commit 104102782df844fc047f22bc94181c3f2acfee84 Author: Rafael da Fonseca Date: 2015-06-07T19:41:23Z Fix last ocurrence of unnecessary boxing detected by findbugs CiscoVnmcResource.java:266, DM_BOXED_PRIMITIVE_FOR_PARSING, Priority: High Boxing/unboxing to parse a primitive com.cloud.network.resource.CiscoVnmcResource.getIpRangeFromCidr(String) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fix malformed closing tag on comments in ...
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/369 Fix malformed closing tag on comments in cisco .xml files You can merge this pull request into a Git repository by running: $ git pull https://github.com/rsafonseca/cloudstack fixxmltypos Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/369.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #369 commit 3a61c4a921ae19a90687b9a72a5fc0684647e2d2 Author: Rafael da Fonseca Date: 2015-06-07T19:52:34Z Fix malformed closing tag on comments in cisco .xml files --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Test jenkins ovm3 failure
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/370 Test jenkins ovm3 failure You can merge this pull request into a Git repository by running: $ git pull https://github.com/rsafonseca/cloudstack ovm3fixtest Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/370.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #370 commit 32e6b5c23f79482c334b56649f5cfdc196d661ba Author: Rafael da Fonseca Date: 2015-06-07T23:18:45Z Test jenkins ovm3 failure --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Reinstate working sessions in browser
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/308#issuecomment-109951692 Session persistence is not working on any scenario atm. The aim of this is to fix that. The security measure is aimed to prevent browser vulnerability, which using SSL doesn't prevent. Why do you say this is not needed any more? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Reinstate working sessions in browser
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/308#issuecomment-109981697 @vadimkim Let me try to break it down: In the past, with the purpose of preventing a browser vulnerability, session persistence was completely broken, so currently, there is no session persistence with either HTTP or HTTPS from ACS 4.3.x to 4.6.x, that is, if you press F5, you will be logged out. This fix reenables persistence, and does so while improving on the security measure that was the objective that led to session persistence being broken. With this patch, both HTTP and HTTPS are working fine with session persistence, and the browser vulnerability (XSS attack) is eliminated. SSL would not protect against a XSS attack, it would only protect from the fact that you are sending your credentials and sessionkey unencrypted from your machine to the server. If you are doing so over a secure network that you trust, using SSL might even be irrelevant, depending on the situation. So, SSL will only protect your credentials/session on the transport layer, other nasty XSS scripts might still gain access to whatever is stored in your browser. Setting the cookie as HttpOnly prevents your own browser from reading it, and thus makes that information safe from XSS. If you're having issues with a reverse proxy in front of it, the issue is probably with the reverse proxy or browser config... here's where i see it might be going wrong on your setup: - Proxy is destroying the cookie; - Proxy is not allowing the cookie in the first place; - Proxy if forcing a new session to be generated; - Browser isn't allowing cookies on the https url (perhaps configured manually to always reject cookies and an exception for the http:// cloudstack url ?) - Proxy might be delivering a cached version of cloudStack.js without the fix; Could you share some more info on your reverse proxy setup? I'll can try to reproduce your issue and give you a hand :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Reinstate working sessions in browser
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/308#issuecomment-110049806 @vadimkim It seems like you're not passing to cookies over to the client on that config :) Try setting: proxy_pass_header Set-Cookie; proxy_pass_header P3P; Since your internal domain may not be the same as the external, you might also need some additional config like: proxy_cookie_domain kickcloud.net $host; sub_filter "kickcloud.net" $host; Or something similar :) I will try to reproduce your setup when i have some time to figure out a config that works for sure, but try these configs in the mean while :) Either way, this seems like an issue with the proxy config itself, and there should be no need to adjust code for that situation ;) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Reinstate working sessions in browser
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/308#issuecomment-110051983 About the redirect rule, i will soon bake a patch that will render that unnecessary, but for now, there should be no problem with just rewriting it in the proxy :) I'll discuss this with the others on wednesday's meetup in SBP --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Embedded Tomcat & Jetty
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/372 Embedded Tomcat & Jetty Well, this spruces things up a bit :) Some of the features/fixes (i may have forgotten a couple as this involved a lot of changes ;) ) - Embedded Tomcat support - Embedded Jetty support - Reduce management .deb package to roughly half the size - Reduce common .rpm package to roughly half the size - Transparent support for more distros like Fedora 21 - Reduced dependencies on the packages, such as mysql-connector-java which are now bundled - Upgraded Jetty version used by Travis from oldie and discontinued morbay 6.x version to current eclipse 9.x version - Tidy up debian packaging under /packaging and include support on package.sh - Cleanup of a lot of duplicate files which made it harder to maintain and caused some fixes to be implemented only for some distros - Consolidates a few configs that were different across distros and shouldn't be - Enables running with any version of openjdk runtime and compiling with any version of openjdk devel as long as they meet the minimum requirements (Java 7+) without conflicting with other packages. The package.sh script packages ASF Tomcat by default, you can package it with Jetty instead by passing -j or --jetty :) There's still a couple more things to consolidate and a couple more places to remove hardcoding of configs like the cloud user, but i'll take care of that on a later PR :) You can merge this pull request into a Git repository by running: $ git pull https://github.com/rsafonseca/cloudstack fixpackaging2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/372.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #372 commit decde6d129ce8c87a82d8aa00a6723b91c322e02 Author: Rafael da Fonseca Date: 2015-05-03T18:59:53Z Tomcat packaging Reduced cloudstack-management_4.6.0-snapshot_all.deb size from 211Mb to 94Mb (CentOS is 92Mb) This deb file was packing two copies of the systemvm (which is alread packed in cloudstack-common), so removed like in CentOS RPM specs Fedora 21 support for management :) Removed Fedora specific branches (symlink fedora2x points to centos7 so, using same installer :) Small cleanup of duplicate files Added embedded jetty Support for choosing tomcat or jetty on package.sh Removed mysql driver distro dependency Replaced old mortbay jetty 6 with eclipse jetty 9 Removed duplicate files Tidy up debian packaging Make things work on debian Cleanup, fixes, distro abstraction, etc Fix simulator for new jetty plugin Fix servlet engines on older mvn version Config jetty version Fix juli logging manager error on tomcat Fix dep problem with mysqlha plugin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Build and create tomcat, fix several othe...
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/238#issuecomment-110082001 This has been stale for a while, here's something to spice it up :) https://github.com/apache/cloudstack/pull/372 If all in agreement will close this one and we'll go for the new one ;) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Build and create tomcat, fix several othe...
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/238#issuecomment-110148582 Hi @bhaisaab :) The new https://github.com/apache/cloudstack/pull/372 was built on top of this one, so all the fixes in this are also in the other one. I do think the other one is the way to go, it includes a few more fixes and cleanup than this one and gives the option to select the servlet engine that gets auto packed into the rpm which i hope will be a popular change. So... closing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Build and create tomcat, fix several othe...
Github user rsafonseca closed the pull request at: https://github.com/apache/cloudstack/pull/238 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Embedded Tomcat & Jetty
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/372#issuecomment-110151397 Hi @terbolous I'm in no way a licensing expert, but don't think there's any incompatibility with the licensing.. but I'll leave that for the experts to say their .2c I guess that mainly it was not shipped because it was just not working when you bundled it in the webapp, it was missing the driver instantiation which it relied on the servlet engine to do.. that is taken care of now :) About the testing, I've tested manually deploying a datacenter with this package in: Ubuntu 12.04.5 Centos 6.6 Centos 7 Fedora 21 Sadly, i've done no testing on upgrades, but i can easily do so in a few days and fix whatever issue may arise... although i don't foresee any issues. I've also tested running marvin locally, and it's working fine :) All distros were tested with both tomcat and jetty, except Fedora 21 which i only tested with tomcat, but should be all the same. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Embedded Tomcat & Jetty
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/372#issuecomment-110161431 How about the FOSS license exception? https://www.mysql.com/about/legal/licensing/foss-exception/ FOSS License List License NameVersion(s)/Copyright Date ... Apache Software License 1.0/1.1/2.0 ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Embedded Tomcat & Jetty
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/372#issuecomment-110255489 Hi @wilderrodrigues , @serverchief Thank you for your feedback :) I understand your point, but since there are a lot of changes and most are interconnected or change the same files, breaking it down would make it take a long time to get things done and i'm used to working fast with a lot of changes, sorry about that ;) . This is still not all the cleaning up i'd like to do in packaging, and packing it all together makes it also a lot faster to test for issues, than to do complete tests for a big bunch of PRs individually, although a complete code review will be a bit taxing of course, either way, reviewing 5x 200 lines of code, should be no faster than to review 1000 line of code once, although testing packaging and functionality once is a lot faster than doing it 5x, don't you agree? I will try to break down a some things in the coming days like i did with the last packaging PR, but ultimately, the work goes a lot faster if i'm not waiting for each individual change to get reviewed and merged before moving on to the next step to improve the same thing. This is a particular case because all the changes revolve around the same things: packaging and distribution. Either way, this allows for people to test once and make sure everything is working.. if any issues are reported i'll be sure to fix them, and not go back in time ;) I will also be sure to review all the changes myself and add anything relevant i may have forgotten about, if any, to the initial comment to make it easier to follow :) Merging the whole PR would speed things up considerably and allow me to continue improving packaging with a new base, but i'm not expecting to see this through overnight of course :) Ultimately it was easier and faster to get everything done in the same branch and fix issues as they arose in my testing. This just gets it all out there at once for the community to comment on and test as a whole. Other than this packaging PR which is something that needed an overhaul in my opinion, I will try to keep my PRs as small as possible as you have suggested. Cheers, Rafael --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Embedded Tomcat & Jetty
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/372#issuecomment-110265493 Hi @terbolous I'm here to help, so i'll try to break it down a bit in the coming days as i mentioned :) Testing this will take some time anyway, and if an issue arises with the mysql connector change, i'll just update the PR, nothing will get stuck because of that ;) Btw, the change with mysql has 2 objectives: 1 - Reduce distro specific dependencies (different distros have different package names an versions) and thus increase distro abstraction. 2 - Make the management webapp self contained (currently, if you take the war file from this PR and put it in your own servlet engine all you need to do is install the RPM and add /etc/cloudstack/management to the context class loader's classpath ) Either way, do you all mean easier to review? I don't see how testing a bunch of PRs would be faster or easier to test a single one :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Reinstate working sessions in browser
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/308#issuecomment-110268630 @vadimkim I need to do some testing with this setup, which i'm afraid i might only have time to do later this week or in the weekend. It generally easier to do this with httpd (using ProxyPassReverseCookieDomain and ProxyPassReverseCookiePath), but i'll figure out a way to make it work on nginx :) The thing is, your internal domain might not be the same as your external domain, and the same goes for the cookie path. You will most likely need to rewrite those bits in the cookie eg. cloudstack.myintra.local <-> kickcloud.net or something like that. I'll get back to you as soon as i can test it and hopefully provide you a working config :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
