[GitHub] cloudstack pull request #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN rang...

[nitin-maharana]

Github user nitin-maharana commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1771#discussion_r102453548
  
--- Diff: server/src/com/cloud/network/NetworkServiceImpl.java ---
@@ -3085,9 +3085,10 @@ public GuestVlan 
dedicateGuestVlanRange(DedicateGuestVlanRangeCmd cmd) {
 // Verify account is valid
 Account vlanOwner = null;
 if (projectId != null) {
-if (accountName != null) {
-throw new InvalidParameterValueException("accountName and 
projectId are mutually exclusive");
-}
+//accountName and projectId are mutually exclusive
--- End diff --

@koushik-das : If we go with the scope field, we have to revert that change 
and have to make required depending on the scope we select. Like shown in the 
below snapshot.

https://cloud.githubusercontent.com/assets/12583725/23212092/1ba1cd22-f92b-11e6-83ba-72dab04dc497.png";>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #:

[nitin-maharana]

Github user nitin-maharana commented on the pull request:


https://github.com/apache/cloudstack/commit/fa85151be962824cc88776a0264e1ac6ef90560c#commitcomment-21082376
  
In server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java:
In server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java on line 295:
Build is failing due to this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN rang...

[nitin-maharana]

Github user nitin-maharana closed the pull request at:

https://github.com/apache/cloudstack/pull/1771


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN rang...

[nitin-maharana]

GitHub user nitin-maharana reopened a pull request:

https://github.com/apache/cloudstack/pull/1771

CLOUDSTACK-9611: Dedicating a Guest VLAN range to Project does not work.

Description:
=

Trying to dedicate a guest VLAN range to an account fails. Either API 
documentation is wrong or code path needs to be corrected. If we pass both 
account and projectId parameters to the dedicateGuestVlanRange (which are not 
mentioned as mutually exclusive in API description) the API layer throws error 
saying both are mutually exclusive.

Steps to Reproduce:
===
Create an account. Create a project in that account.

Go to Admin account and change the view to the above project.

Navigate to Infrastructure -> Zone -> Physical Network -> Guest -> Dedicate 
Guest VLAN range.

Try to dedicate the guest VLAN range from the project view for the account 
associated with the project.

It fails with error saying "accountName and projectId are mutually 
exclusive".


![image](https://cloud.githubusercontent.com/assets/12583725/20559763/15fe55d8-b19c-11e6-9996-62602d269f10.png)


![image](https://cloud.githubusercontent.com/assets/12583725/20559765/1957af36-b19c-11e6-938f-e9c7c9eee987.png)

Expected:
===
The VLAN range should get dedicated to the project account.


![image](https://cloud.githubusercontent.com/assets/12583725/20559787/33ef67b2-b19c-11e6-90fd-41c9c583efd9.png)


![image](https://cloud.githubusercontent.com/assets/12583725/20559789/376cae22-b19c-11e6-9755-ff1e7237fb21.png)

Resolution:

Changed the account field of API to optional.
Even if the account name is passed while adding from a particular project 
view, then it is ignored in API.

Notes:
=
If we do the dedication from default view then it works fine as no 
projectId is associated over there.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nitin-maharana/CloudStack-Nitin nitin3

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1771.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1771


commit f56961392662f4b45e3e4cb989203f918ec19916
Author: Nitin Kumar Maharana 
Date:   2017-02-28T10:57:38Z

CLOUDSTACK-9611: Dedicating a Guest VLAN range to Project does not work.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN range to Pr...

[nitin-maharana]

Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1771
  
@ustcweizhou @koushik-das : I implemented the way @ustcweizhou's suggested. 
It was purely an UI change. But I found an issue while testing.

On API side, the entire logic uses VLAN owner account details, they find it 
from the account given by the user. So, they made account field as mandatory. 
But that contradicts when it is accessed from a project view(This issue). 

The current logic works in a default view because we don't add projectid 
details while accessing the API. But when it is accessed from a particular 
project view, by default the projectid parameter is added with the API call, So 
this issue arises. 

Now, if we go with the change suggested by @ustcweizhou, once we select the 
scope as domain, we don't pass any account details, so the logic can't able to 
find the owner hence gives an error.

According to my suggestion, On API side, we should make the account field 
as optional and on UI front, we should make it mandatory and the account field 
will appear only in case of default view, which will fix the issue. Please give 
your input on this. Accordingly, I will proceed.

Please see the current change(I pushed it here)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN range to Pr...

[nitin-maharana]

Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1771
  
@ustcweizhou : Passing project with domain won't create any issue but not 
passing any account details when we call the API from default view creates an 
issue. Because the internal logic expects account owner of VLAN when dedicated 
from the default view. In the case of project view, it gets the account detail 
from selected project.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN range to Pr...

[nitin-maharana]

Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1771
  
@ustcweizhou : You are correct. We have to remove the domain scope. If we 
support the domain scope, we need more changes on the logic. In that case we 
can create a new ticket for that. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN range to Pr...

[nitin-maharana]

Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1771
  
@ustcweizhou : I have modified the code, can you review it one more time. 
Please see the below snapshot.

https://cloud.githubusercontent.com/assets/12583725/23455743/b4d7be00-fe96-11e6-8a41-398c41f6d019.png";>


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1792: CLOUDSTACK-9623: Deploying virtual machine fails due...

[nitin-maharana]

Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1792
  
@koushik-das : No failure now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1859: CLOUDSTACK-8672 : NCC Integration with CloudStack

[nitin-maharana]

Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1859
  
ping @rajesh-battala @sowmyakrishn 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1792: CLOUDSTACK-9623: Deploying virtual machine fails due...

[nitin-maharana]

Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1792
  
@cloudmonger


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1792: CLOUDSTACK-9623: Deploying virtual machine fails due...

[nitin-maharana]

Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1792
  
@karuturi : Currently running. Will post once completes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1792: CLOUDSTACK-9623: Deploying virtual machine fails due...

[nitin-maharana]

Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1792
  
tag:mergeready


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1859: CLOUDSTACK-8672 : NCC Integration with CloudStack

[nitin-maharana]

Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1859
  
@rajesh-battala : Will update the same in wiki page. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1859: CLOUDSTACK-8672 : NCC Integration with CloudStack

[nitin-maharana]

Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1859
  
Please find the test plan executed from below link(Updated in wiki page).

https://cwiki.apache.org/confluence/display/CLOUDSTACK/NCC+Integration+with+CloudStack+Test+Plan



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN range to Pr...

[nitin-maharana]

Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1771
  
@ustcweizhou : Yes, if domain changes, the project list should change. 
As per my understanding, a project is similar to an account. When we create 
a project, by default it is always created in ROOT domain. But an account can 
be created in a specific domain. I am still not clear what is the need of 
project.

As all the projects are under ROOT domain, if we select any domain other 
than ROOT, the project list would be empty. So I think we needn't use the 
domain list in project scope and instead we should list all projects.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1859: CLOUDSTACK-8672 : NCC Integration with CloudStack

[nitin-maharana]

Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1859
  
@rajesh-battala : Currently running, will post once completes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN range to Pr...

[nitin-maharana]

Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1771
  
@ustcweizhou : The createProject API allows to created a project under a 
domain but no idea if there is any support from UI. Whenever I create a 
project, it always goes to ROOT domain.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN range to Pr...

[nitin-maharana]

Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1771
  
@ustcweizhou : Please verify, I have changed according to your suggestion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN range to Pr...

[nitin-maharana]

Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1771
  
ping @rhtyd @karuturi 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1859: CLOUDSTACK-8672 : NCC Integration with CloudStack

[nitin-maharana]

Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1859
  
Ping @sowmyakrishn @jayapalu 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1859: CLOUDSTACK-8672 : NCC Integration with CloudStack

[nitin-maharana]

Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1859
  
tag:mergeready


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN range to Pr...

[nitin-maharana]

Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1771
  
@ustcweizhou : In case of project view, the projectId is always passed. 
Also we consider it as project scope but we won't have any option to choose 
projects from a list because we are already under a project.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN rang...

[nitin-maharana]

Github user nitin-maharana commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1771#discussion_r104902049
  
--- Diff: ui/scripts/system.js ---
@@ -2090,27 +2090,57 @@
 fields: {
 vlanrange: {
 label: 
'label.vlan.vni.range',
-/*  select: 
function(args) {
-var items = [];
-
if(args.context.physicalNetworks[0].vlan != null && 
args.context.physicalNetworks[0].vlan.length > 0) {
-var vlanranges = 
args.context.physicalNetworks[0].vlan.split(";");
-for(var i = 0; i < 
vlanranges.length ; i++) {
-items.push({id: 
vlanranges[i], description: vlanranges[i]});
-}
-}
-
args.response.success({data: items});
-},*/
 validation: {
 required: true
 }
 },
-account: {
-label: 
'label.account',
-validation: {
-required: true
+scope: {
+label: 
'label.scope',
+docID: 
'helpGuestNetworkZoneScope',
+select: 
function(args) {
+var array1 = 
[];
+
+array1.push({
+id: 
'account-specific',
+
description: 'label.account'
+});
+array1.push({
+id: 
'project-specific',
+
description: 'label.project'
+});
+
+
args.response.success({
+data: 
array1
+});
+
+
args.$select.change(function() {
+var $form 
= $(this).closest('form');
+
+if 
($(this).val() == "account-specific") {
+
$form.find('.form-item[rel=domainId]').css('display', 'inline-block');
+
$form.find('.form-item[rel=account]').css('display', 'inline-block');
+
$form.find('.form-item[rel=projectId]').hide();
+} else if 
($(this).val() == "project-specific") {
+
$form.find('.form-item[rel=domainId]').css('display', 'inline-block');
+
$form.find('.form-item[rel=account]').hide();
+
$form.find('.form-item[rel=projectId]').css('display', 'inline-block');
+  

[GitHub] cloudstack issue #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN range to Pr...

[nitin-maharana]

Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1771
  
tag:mergeready


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1870: CLOUDSTACK-9708: Router deployment failed due to two...

[nitin-maharana]

Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1870
  
@remibergsma : Can you please review it again. Fixed the test failures.

ping @jayapalu @rajesh-battala 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1859: CLOUDSTACK-8672 : NCC Integration with CloudStack

[nitin-maharana]

Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1859
  
It has already two LGTMs and contains all successful test results. This is 
a big change, as time passes there are more chances of conflicts 
appearance(Already resolved once). If anyone wants to review, please do it else 
we should consider merging this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1859: CLOUDSTACK-8672 : NCC Integration with CloudStack

[nitin-maharana]

Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1859
  
@rafaelweingartner : As there are multiple contributors to this feature, If 
I squash it to one commit, then others are going to lose their part of 
contributions. Initially, we thought of making it to one commit, but this is 
the main reason we pushed with multiple commits. Let's wait for others to 
comment on this, after that we will decide. Thanks, @rafaelweingartner for 
pitching in.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #2031: CLOUDSTACK - 8672 : Test PR

[nitin-maharana]

GitHub user nitin-maharana opened a pull request:

https://github.com/apache/cloudstack/pull/2031

CLOUDSTACK - 8672 : Test PR

Currently running with few commit. Please don't review this PR.
According to the result of this PR, I will update in original PR(1859).

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Accelerite/cloudstack CLOUDSTACK-8672-TEST

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/2031.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2031


commit 58aec81013b44a2e83052adc2a9f9c802210e7db
Author: Rajesh Battala 
Date:   2015-07-23T08:44:07Z

CLOUDSTACK-8672 : NCC Integration with CloudStack.

commit 2ce10b7d97b63edfb24465dfd22a525f99ee1b90
Author: Priyank Parihar 
Date:   2015-08-07T11:10:00Z

CLOUDSTACK-8672 : NCC Integration with CloudStack.

commit b0b1914985320f62ca3f8c0838ea8e10dd28
Author: Nitin Kumar Maharana 
Date:   2015-08-07T11:40:13Z

CLOUDSTACK-8672 : NCC Integration with CloudStack.

commit 29e4f70742ce0a9b91cb3111bac282b5a0cd8331
Author: Sowmya Krishnan 
Date:   2017-01-25T11:47:43Z

CLOUDSTACK-8672 : NCC Integration with CloudStack.
Marvin Integration Tests for Shared and Dedicated Workflow.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: New committer: Dag Sonstebo

[Nitin Maharana]

Congratulations, Dag!!

On Tue, Mar 20, 2018 at 7:34 PM, Paul Angus 
wrote:

> Congratulations, well deserved!
>
> paul.an...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue
>
>
>
>
> -Original Message-
> From: Nicolas Vazquez 
> Sent: 20 March 2018 14:02
> To:  
> Subject: Re: New committer: Dag Sonstebo
>
> Good news, congratulations Dag!
>
> 
> From: John Kinsella 
> Sent: Tuesday, March 20, 2018 10:58:22 AM
> To: 
> Subject: New committer: Dag Sonstebo
>
> The Project Management Committee (PMC) for Apache CloudStack has invited
> Dag Sonsteboto become a committer and we are pleased to announce that he
> has accepted.
>
> I'll take a moment here to remind folks that being an ASF committer isn't
> purely about code - Dag has been helping out for quite a while on users@,
> and seems to have a strong interest around ACS and the community. We
> welcome this activity, and encourage others to help out as they can - it
> doesn't necessarily have to be purely code-related.
>
> Being a committer enables easier contribution to the project since there
> is no need to go via the patch submission process. This should enable
> better productivity.
>
> Please join me in welcoming Dag!
>
> John
>
> nicolas.vazq...@shapeblue.com
> www.shapeblue.com
> ,
> @shapeblue
>
>
>
>

Re: Notice that Gabriel Bräscher now works at PCextreme

[Nitin Maharana]

Congratulations, Gabriel!!!

On Tue, Mar 20, 2018 at 10:14 PM, Sateesh Chodapuneedi <
sateesh.chodapune...@accelerite.com> wrote:

> Congrats Gabriel.
>
> Regards,
> Sateesh
>
> -Original Message-
> From: Wido den Hollander 
> Reply-To: "dev@cloudstack.apache.org" 
> Date: Tuesday, 20 March 2018 at 7:21 PM
> To: "dev@cloudstack.apache.org" 
> Cc: "gabrasc...@gmail.com" 
> Subject: Notice that Gabriel Bräscher now works at PCextreme
>
> Hi,
>
> Just wanted to let you know that Gabriel Bräscher started working at
> PCextreme this week.
>
> He'll be committing and developing on CloudStack for PCextreme and the
> community.
>
> Just so everybody knows that we are colleagues now.
>
> Let's make CloudStack even better!
>
> Wido
>
>
> DISCLAIMER
> ==
> This e-mail may contain privileged and confidential information which is
> the property of Accelerite, a Persistent Systems business. It is intended
> only for the use of the individual or entity to which it is addressed. If
> you are not the intended recipient, you are not authorized to read, retain,
> copy, print, distribute or use this message. If you have received this
> communication in error, please notify the sender and delete all copies of
> this message. Accelerite, a Persistent Systems business does not accept any
> liability for virus infected mails.
>

Re: Remove 'md5Hashed' variable from Javascript

[Nitin Maharana]

+1

On Mon, Apr 9, 2018 at 11:01 PM, Rafael Weingärtner <
rafaelweingart...@gmail.com> wrote:

> Hello fellow CloudStackers,
>
> Today I was working on CLOUDSTACK-5235, which is a security issue, and I
> noticed a variable ‘md5Hashed’ in the javascript that does not seem to be
> useful at all. This variable was used to control if we hash or not the
> password of users in the user side (browser). However, we no longer hash
> the password on the user side. All of the password processing is executed
> in the server side according to the priority of hashing mechanism defined
> by the administrator.
>
> I am addressing this cleanup with this PR
> https://github.com/apache/cloudstack/pull/2555.
>
> If you have any objections regarding this variable and its relate code
> removal, please do so. Otherwise, we will proceed to remove it.
>
> --
> Rafael Weingärtner
>

Re: Community opinion regarding Apache events banner in CloudStack's website

[Nitin Maharana]

+1 for the third option. I think It would even look good if we adjust the
vertical alignment of the word "Apache CloudStack" to center.

On Wed, Apr 18, 2018 at 12:12 AM, Rafael Weingärtner <
rafaelweingart...@gmail.com> wrote:

> Third option (suggested by Dag) -
> https://drive.google.com/open?id=16FEu9tD1HZqwxLp2lrnUBmsuRJNLpDqU
>
> On Tue, Apr 17, 2018 at 3:39 PM, Dag Sonstebo 
> wrote:
>
> > Hi Rafael – in my opinion you need it fairly prominent so people notice
> it
> > – so option 1, but maybe put it underneath the CloudMonkey logo on the
> > right hand side?
> >
> > Regards,
> > Dag Sonstebo
> > Cloud Architect
> > ShapeBlue
> >
> > On 17/04/2018, 19:35, "Rafael Weingärtner" 
> > wrote:
> >
> > Ah damm.. I forgot about the file stripping in our mailing list.
> > Sorry guys. Here they go.
> >
> > - first one:
> > https://drive.google.com/open?id=1vSqni_GEj3YJjuGehxe-_dnrNqQP7x8y
> >
> > - second one:
> > https://drive.google.com/open?id=1LEmt9g5ceAUeTuc2a1Cb4uctOwyz5eQ8
> >
> > On Tue, Apr 17, 2018 at 3:31 PM, Dag Sonstebo <
> > dag.sonst...@shapeblue.com>
> > wrote:
> >
> > > The white one is quite nice ☺
> > >
> > > Joking aside – looks like they got stripped from your email Rafael.
> > >
> > > Regards,
> > > Dag Sonstebo
> > > Cloud Architect
> > > ShapeBlue
> > >
> > > From: Rafael Weingärtner 
> > > Reply-To: "dev@cloudstack.apache.org" 
> > > Date: Tuesday, 17 April 2018 at 19:13
> > > To: users , dev <
> > dev@cloudstack.apache.org>
> > > Subject: Community opinion regarding Apache events banner in
> > CloudStack's
> > > website
> > >
> > > Hello folks,
> > > I am trying to work out something to put Apache events banner on
> our
> > > website. So far I came up with two proposals. Which one of them do
> > you guys
> > > prefer?
> > > First one:
> > > [cid:ii_jg3zjco00_162d4ce7db0cd3da]
> > >
> > >
> > > Second:
> > > [cid:ii_jg3zk0e01_162d4cefaef3a1ce]
> > >
> > > --
> > > Rafael Weingärtner
> > >
> > > dag.sonst...@shapeblue.com
> > > www.shapeblue.com
> > > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> > > @shapeblue
> > >
> > >
> > >
> > >
> >
> >
> > --
> > Rafael Weingärtner
> >
> >
> >
> > dag.sonst...@shapeblue.com
> > www.shapeblue.com
> > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> > @shapeblue
> >
> >
> >
> >
>
>
> --
> Rafael Weingärtner
>

Re: [VOTE] Primate as modern UI for CloudStack

[Nitin Maharana]

+1

On Mon, 7 Oct 2019 at 8:39 PM, Sven Vogel  wrote:

> +1 (binding)
>
>
> __
>
> Sven Vogel
> Teamlead Platform
>
> EWERK DIGITAL GmbH
> Brühl 24, D-04109 Leipzig
> 
> P +49 341 42649 - 99
> F +49 341 42649 - 98
> s.vo...@ewerk.com
> www.ewerk.com
>
> Geschäftsführer:
> Dr. Erik Wende, Hendrik Schubert, Frank Richter
> Registergericht: Leipzig HRB 9065
>
> Zertifiziert nach:
> ISO/IEC 27001:2013
> DIN EN ISO 9001:2015
> DIN ISO/IEC 2-1:2011
>
> EWERK-Blog | LinkedIn | Xing | Twitter | Facebook
>
> Auskünfte und Angebote per Mail sind freibleibend und unverbindlich.
>
> Disclaimer Privacy:
> Der Inhalt dieser E-Mail (einschließlich etwaiger beigefügter Dateien) ist
> vertraulich und nur für den Empfänger bestimmt. Sollten Sie nicht der
> bestimmungsgemäße Empfänger sein, ist Ihnen jegliche Offenlegung,
> Vervielfältigung, Weitergabe oder Nutzung des Inhalts untersagt. Bitte
> informieren Sie in diesem Fall unverzüglich den Absender und löschen Sie
> die E-Mail (einschließlich etwaiger beigefügter Dateien) von Ihrem System.
> Vielen Dank.
>
> The contents of this e-mail (including any attachments) are confidential
> and may be legally privileged. If you are not the intended recipient of
> this e-mail, any disclosure, copying, distribution or use of its contents
> is strictly prohibited, and you should please notify the sender immediately
> and then delete it (including any attachments) from your system. Thank you.
> > Am 07.10.2019 um 16:18 schrieb Nicolas Vazquez <
> nicolas.vazq...@shapeblue.com>:
> >
> > +1
> >
> >
> > Regards,
> >
> > Nicolas Vazquez
> >
> > 
> > From: Andrija Panic 
> > Sent: Monday, October 7, 2019 11:16 AM
> > To: users 
> > Cc: dev@cloudstack.apache.org ;
> priv...@cloudstack.apache.org 
> > Subject: Re: [VOTE] Primate as modern UI for CloudStack
> >
> > +1 (binding)
> >
> >
> > nicolas.vazq...@shapeblue.com
> > www.shapeblue.com
> > Amadeus House, Floral Street, London  WC2E 9DPUK
> > @shapeblue
> >
> >
> >
> > On Mon, 7 Oct 2019 at 15:53, Simon Weller 
> wrote:
> >
> >>
> >> +1 (binding)
> >> 
> >> From: Rohit Yadav 
> >> Sent: Monday, October 7, 2019 6:31 AM
> >> To: dev@cloudstack.apache.org ;
> >> us...@cloudstack.apache.org ;
> >> priv...@cloudstack.apache.org 
> >> Subject: [VOTE] Primate as modern UI for CloudStack
> >>
> >> All,
> >>
> >> The feedback and response has been positive on the proposal to use
> Primate
> >> as the modern UI for CloudStack [1] [2]. Thank you all.
> >>
> >> I'm starting this vote (to):
> >>
> >>  *   Accept Primate codebase [3] as a project under Apache CloudStack
> >> project
> >>  *   Create and host a new repository (cloudstack-primate) and follow
> >> Github based development workflow (issues, pull requests etc) as we do
> with
> >> CloudStack
> >>  *   Given this is a new project, to encourage cadence until its feature
> >> completeness the merge criteria is proposed as:
> >> *   Manual testing against each PR and/or with screenshots from the
> >> author or testing contributor, integration with Travis is possible once
> we
> >> get JS/UI tests
> >> *   At least 1 LGTM from any of the active contributors, we'll move
> >> this to 2 LGTMs when the codebase reaches feature parity wrt the
> >> existing/old CloudStack UI
> >> *   Squash and merge PRs
> >>  *   Accept the proposed timeline [1][2] (subject to achievement of
> goals
> >> wrt Primate technical release and GA)
> >> *   the first technical preview targetted with the winter 2019 LTS
> >> release (~Q1 2020) and release to serve a deprecation notice wrt the
> older
> >> UI
> >> *   define a release approach before winter LTS
> >> *   stop taking feature FRs for old/existing UI after winter 2019
> LTS
> >> release, work on upgrade path/documentation from old UI to Primate
> >> *   the first Primate GA targetted wrt summer LTS 2020 (~H2 2019),
> >> but still ship old UI with a final deprecation notice
> >> *   old UI codebase removed from codebase in winter 2020 LTS release
> >>
> >> The vote will be up for the next two weeks to give enough time for PMC
> and
> >> the community to gather consensus and still have room for questions,
> >> feedback and discussions. The results to be shared on/after 21th October
> >> 2019.
> >>
> >> For sanity in tallying the vote, can PMC members please be sure to
> >> indicate "(binding)" with their vote?
> >>
> >> [ ] +1  approve
> >> [ ] +0  no opinion
> >> [ ] -1  disapprove (and reason why)
> >>
> >> [1] Primate Proposal:
> >>
> >>
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Proposal%3A+CloudStack+Primate+UI
> >>
> >> [2] Email thread reference:
> >> https://markmail.org/message/z6fuvw4regig7aqb
> >>
> >> [3] Primate repo current location: https://github.com/shapeblue/primate
> >>
> >>
> >> Regards,
> >>
> >> Rohit Yadav
> >>
> >> Software Architect, ShapeBlu

Prime Minister of India: Commit To Ensuring A Healthy Work-Life Balance For Working Indians #RightToDisconnect

[nitin . maharana]

Hey,

I just signed the petition "Prime Minister of India: Commit To Ensuring A
Healthy Work-Life Balance For Working Indians #RightToDisconnect" and
wanted to see if you could help by adding your name.

Our goal is to reach 150,000 signatures and we need more support. You can
read more and sign the petition here:

http://chng.it/9wdKGQQrNf

Thanks!
Nitin Kumar

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

[nitin-maharana]

Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/1206#issuecomment-164344691
  
@DaanHoogland : Yes, your idea also looks good. Previously, it was 
generating a random value only in case of NULL. But if we pass an empty string, 
it was creating a volume with the empty name. I will modify the condition and 
update the PR. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

[nitin-maharana]

Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/1206#issuecomment-164366344
  
API with non-empty name:


http://10.102.192.122:8080/client/api?command=createVolume&response=json&name=TempVolume&zoneId=18b1cb1a-bb8b-4e3d-aab8-a48475ed3c60&diskOfferingId=dc8a8d64-34a6-481e-99f9-89a49ee94824&size=1&_=1450077422731


![ss_withname_nitin](https://cloud.githubusercontent.com/assets/12583725/11775056/9b18f778-a261-11e5-91d5-05b79e6d31f0.png)


API with empty name:
=

http://10.102.192.122:8080/client/api?command=createVolume&response=json&name=&zoneId=18b1cb1a-bb8b-4e3d-aab8-a48475ed3c60&diskOfferingId=dc8a8d64-34a6-481e-99f9-89a49ee94824&size=1&_=1450077422731


![ss_withoutname_nitin](https://cloud.githubusercontent.com/assets/12583725/11775062/a68f66c8-a261-11e5-9456-4e7eece196fb.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

[nitin-maharana]

Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/1206#issuecomment-164411409
  
@DaanHoogland : In UI, we put the field as required field, so user has to 
give some name to create a volume. It cannot be null or blank. But according 
the change, the API doesn't support the logic of UI. Either we should make the 
field as optional in UI or we should throw an error in API when the name is 
null or empty. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

[nitin-maharana]

Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/1206#issuecomment-164475760
  
@DaanHoogland : You mean the name should be an optional field? If that is 
the case, we should make the field as optional in UI as well as in API.

@rafaelweingartner : The volume name is either collected from the UI or we 
have a method in API called getRandomVolumeName() which sets a random value. I 
think we don't need to extract further.
The above method sets a value.

Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8968: UI icon over VM snapshot...

[nitin-maharana]

Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/1150#issuecomment-164514502
  
Step-1:
=

![pr_1150_ss1_nitin](https://cloud.githubusercontent.com/assets/12583725/11789386/1d14793c-a2bc-11e5-9184-f16b84af91f4.png)

Step-2:
=
Skipped 1st and 2nd steps


![pr_1150_ss2_nitin](https://cloud.githubusercontent.com/assets/12583725/11789434/636162f6-a2bc-11e5-8746-5fd2411803df.png)

Step-3:
=
Last step


![pr_1150_ss3_nitin](https://cloud.githubusercontent.com/assets/12583725/11789449/7404f2ee-a2bc-11e5-8bc7-b196a1bae76d.png)





---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9069: Newly added project is n...

[nitin-maharana]

Github user nitin-maharana closed the pull request at:

https://github.com/apache/cloudstack/pull/1082


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9069: Newly added project is n...

[nitin-maharana]

Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/1082#issuecomment-164723525
  
Hi @remibergsma : Yes, you are correct. This issue is no more in master. I 
think this issue was resolved with a different PR. So closing the PR. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8847: ListServiceOfferings is ...

[nitin-maharana]

Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/823#issuecomment-165074680
  
@agneya2001 : If the new service offering wants in change of deployment 
then it should be fine. But the change affects after reboot only. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

[nitin-maharana]

Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/1206#issuecomment-165076449
  
@rafaelweingartner : Thanks for the suggestion. I will follow the same to 
write test cases for this.
@DaanHoogland : Should we make the Name field as optional in UI as well as 
API?

Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9186: Root admin cannot see VP...

[nitin-maharana]

GitHub user nitin-maharana opened a pull request:

https://github.com/apache/cloudstack/pull/1258

CLOUDSTACK-9186: Root admin cannot see VPC created by Domain admin user

Issue:
=
Root admin cannot see LB rules and Public LB IP addresses created by 
domain-admin in UI therefore root admin cannot manage those.

Reproducible Steps: 
 
1.  Log in as a Domain-Admin account and create a VPC with vpc virtual 
router as public load balancer provider 
2.  click on the newly created VPC -> click on the VPC tier -> click 
internal LB 
3.  Add internal LB, 
4.  Logoff domain-admin and login as root admin 
5.  Navigate the VPC created previously and click internal LB, internal lb 
is not showing up.

Same steps for Public LB IP addresses except select the correct Network 
offering while creating a tier.

Expected Behaviour: 
= 
Root admin should be able to manage VPC created by Domain admin user .

Actual Behaviour:
== 
Root admin cannot see VPC created by Domain admin user and hence not able 
to manage it.

Fix:
===
Added the parameter listAll=true in case of Internal LB as well as Public 
LB IP addresses.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nitin-maharana/CloudStack CloudStack-Nitin3

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1258.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1258


commit fb882aa909f52bfd5e590e967bf4e0d2b5d936e7
Author: Nitin Kumar Maharana 
Date:   2015-12-18T07:53:50Z

CLOUDSTACK-9186: Root admin cannot see VPC created by Domain admin user

Added the parameter listAll=true in case of Internal LB as well as Public 
LB IP addresses.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

[nitin-maharana]

Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/1206#issuecomment-165757054
  
cc @koushik-das @kishankavala 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9186: Root admin cannot see VP...

[nitin-maharana]

Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/1258#issuecomment-166109722
  
cc @remibergsma @kishankavala 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9192: UpdateVpnCustomerGateway...

[nitin-maharana]

GitHub user nitin-maharana opened a pull request:

https://github.com/apache/cloudstack/pull/1264

CLOUDSTACK-9192: UpdateVpnCustomerGateway is failing

Reproducible Steps:

1.Create a customer gateway for a VPC.
2.Edit it using UI(API call is UpdateVpnCustomerGateway).
3.When we try to update the customer vpn gateway with connection state is 
not in "Error", we see the API error but that won't be reflected to the user in 
UI.

Actual Behaviour:
==
The API throws error. But UI doesn't show it to user.

Expected Behaviour:
=
The UI should show the error to user.

Fix:
===
TypeError: json.updatecustomergatewayresponse is undefined
The response name was wrong so corrected it.
It should be json.updatevpncustomergatewayresponse.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nitin-maharana/CloudStack CloudStack-Nitin10

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1264.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1264


commit 3022dd3094d45d6574c4d68d3a0b4e6ffde6ad11
Author: Nitin Kumar Maharana 
Date:   2015-12-21T07:37:33Z

CLOUDSTACK-9192: UpdateVpnCustomerGateway is failing

The response name was wrong so corrected it.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9192: UpdateVpnCustomerGateway...

[nitin-maharana]

Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/1264#issuecomment-166223258
  
cc @JayapalUradi 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9192: UpdateVpnCustomerGateway...

[nitin-maharana]

Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/1264#issuecomment-166258585
  
Hi @ustcweizhou, The error function is not necessary but it is good to 
write this in call. Here the request doesn't fail but throws an error. Thanks 
for the comment, I will update.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

[nitin-maharana]

GitHub user nitin-maharana opened a pull request:

https://github.com/apache/cloudstack/pull/1273

CLOUDSTACK-9132: API createVolume takes empty string for name parameter

Steps to Reproduce:

Create a volume using createVolume API where parameter name is empty.
It creates a volume with empty name.
But the name parameter is mandatory.(Issue)

Expected Behaviour:

It shouldn't create a volume with an empty name. Error should be returned.

Solution:
===
Added a condition to check in case of empty string. If the name is an empty 
string, it generates a random name for the volume. Made the name field optional 
in UI as well as in API.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nitin-maharana/CloudStack CloudStack-Nitin15

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1273.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1273


commit 46c23f1a5b08b36ae9c426491a081edb0b5ba772
Author: Nitin Kumar Maharana 
Date:   2015-12-22T08:01:09Z

CLOUDSTACK-9132: API createVolume takes empty string for name parameter

Added a condition to check in case of empty string.
If the name is an empty string, it generates a random name for the volume.
Made the name field as optional in UI as well as in API.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

[nitin-maharana]

Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/1273#issuecomment-166556707
  
Reference(4.6) : https://github.com/apache/cloudstack/pull/1206


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

[nitin-maharana]

Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/1206#issuecomment-166556945
  
Made a new PR https://github.com/apache/cloudstack/pull/1273 with master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

[nitin-maharana]

Github user nitin-maharana closed the pull request at:

https://github.com/apache/cloudstack/pull/1206


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

[nitin-maharana]

Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/1273#issuecomment-166830953
  
Sure @koushik-das. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

[nitin-maharana]

Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/1273#issuecomment-167484496
  
@rafaelweingartner : Thanks for reviewing the change.

The reason to close the old PR is because it was merging with branch 4.6.
I started this PR a long days back when everything from 4.6 being merged 
with master.
But now I dont know the same is happening or not.

I saw most of the recent PRs are created with merging request to master. 
So, I opened a new PR with master. But I have given a reference to my old PR. 
So that reviewers can see the conversation.

About the code change, if we will make "required=true", there will be a 
mismatch in logic of UI and API. In UI, the field is optional. I will modify 
the comments section. Thanks for suggesting.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9186: Root admin cannot see VP...

[nitin-maharana]

Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/1258#issuecomment-167484956
  
@remibergsma : I didn't check in other API calls. If i come across any, 
then will raise the issue. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9186: Root admin cannot see VP...

[nitin-maharana]

Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/1258#issuecomment-167485441
  
@rafaelweingartner : The recursive parameter is not necessary here, because 
we don't provide the domain id parameter. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

[nitin-maharana]

Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/1273#issuecomment-167721727
  
@rafaelweingartner : I have updated the branch. Can you please review the 
change. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

[nitin-maharana]

Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/1273#issuecomment-167765606
  
@rafaelweingartner : Thats cool. I went through the detail of isBlank, but 
could not catch. Thank you.
I have updated.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

[nitin-maharana]

Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/1273#issuecomment-167773312
  
Thanks a lot @rafaelweingartner , I learned many things. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

[nitin-maharana]

Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/1273#issuecomment-167931759
  
cc @remibergsma @bhaisaab 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8968: UI icon over VM snapshot...

[nitin-maharana]

Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/1150#issuecomment-167931844
  
cc @bhaisaab 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9186: Root admin cannot see VP...

[nitin-maharana]

Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/1258#issuecomment-168115394
  
cc @kishankavala 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8968: UI icon over VM snapshot...

[nitin-maharana]

Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/1150#issuecomment-168115562
  
@remibergsma : Any updates on this? Can you please look at the change if 
you have a setup. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9192: UpdateVpnCustomerGateway...

[nitin-maharana]

Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/1264#issuecomment-168115603
  
cc @kishankavala @bhaisaab @remibergsma 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9192: UpdateVpnCustomerGateway...

[nitin-maharana]

Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/1264#issuecomment-168282637
  
Sure @remibergsma. I will a PR against 4.7. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

[nitin-maharana]

Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/1273#issuecomment-168284288
  
@remibergsma : Shall I make this one against 4.7. I mean, should I make all 
pending PRs against 4.7?
Is it not going to be merged?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9192: UpdateVpnCustomerGateway...

[nitin-maharana]

GitHub user nitin-maharana opened a pull request:

https://github.com/apache/cloudstack/pull/1300

CLOUDSTACK-9192: UpdateVpnCustomerGateway is failing

Reproducible Steps:

1.Create a customer gateway for a VPC.
2.Edit it using UI(API call is UpdateVpnCustomerGateway).
3.When we try to update the customer vpn gateway with connection state is 
not in "Error", we see the API error but that won't be reflected to the user in 
UI.

Actual Behaviour:
==
The API throws error. But UI doesn't show it to user.

Expected Behaviour:

The UI should show the error to user.

Fix:
===
TypeError: json.updatecustomergatewayresponse is undefined
The response name was wrong so corrected it.
It should be json.updatevpncustomergatewayresponse.
Added the error function.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nitin-maharana/CloudStack 
CloudStack-Nitin10_4.7

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1300.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1300


commit c4669fa4f8b320fd5ec2ba6a78bab37498115fa9
Author: Nitin Kumar Maharana 
Date:   2015-12-21T10:34:17Z

CLOUDSTACK-9192: UpdateVpnCustomerGateway is failing

The response name was wrong so corrected it.
Added the error function.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9192: UpdateVpnCustomerGateway...

[nitin-maharana]

Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/1300#issuecomment-168289311
  
Reference #1264 (The PR against master).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9192: UpdateVpnCustomerGateway...

[nitin-maharana]

Github user nitin-maharana closed the pull request at:

https://github.com/apache/cloudstack/pull/1264


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9192: UpdateVpnCustomerGateway...

[nitin-maharana]

Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/1264#issuecomment-168289642
  
Closing this PR as made a new PR #1300 (Against 4.7 which will be merged in 
master later).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9186: Root admin cannot see VP...

[nitin-maharana]

GitHub user nitin-maharana opened a pull request:

https://github.com/apache/cloudstack/pull/1301

CLOUDSTACK-9186: Root admin cannot see VPC created by Domain admin user

Issue:
=
Root admin cannot see LB rules and Public LB IP addresses created by 
domain-admin in UI therefore root admin cannot manage those.

Reproducible Steps:

Log in as a Domain-Admin account and create a VPC with vpc virtual router 
as public load balancer provider
click on the newly created VPC -> click on the VPC tier -> click internal LB
Add internal LB,
Logoff domain-admin and login as root admin
Navigate the VPC created previously and click internal LB, internal lb is 
not showing up.
Same steps for Public LB IP addresses except select the correct Network 
offering while creating a tier.

Expected Behaviour:

Root admin should be able to manage VPC created by Domain admin user .

Actual Behaviour:
==
Root admin cannot see VPC created by Domain admin user and hence not able 
to manage it.

Fix:
===
Added the parameter listAll=true in case of Internal LB as well as Public 
LB IP addresses.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nitin-maharana/CloudStack 
CloudStack-Nitin3_4.7

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1301.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1301


commit 223c5b933848eede4e0b4aaaf2bcd7ff745aea9d
Author: Nitin Kumar Maharana 
Date:   2015-12-18T07:53:50Z

CLOUDSTACK-9186: Root admin cannot see VPC created by Domain admin user

Added the parameter listAll=true in case of Internal LB as well as Public 
LB IP addresses.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9186: Root admin cannot see VP...

[nitin-maharana]

Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/1301#issuecomment-168290875
  
Reference PR #1258 (Against master).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9186: Root admin cannot see VP...

[nitin-maharana]

Github user nitin-maharana closed the pull request at:

https://github.com/apache/cloudstack/pull/1258


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9186: Root admin cannot see VP...

[nitin-maharana]

Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/1258#issuecomment-168290892
  
Closing this PR as made a new PR #1301 (Against 4.7 which will be merged in 
master later).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

[nitin-maharana]

Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/1273#issuecomment-168489232
  
@remibergsma : My new PRs are failing in 4.7. With the same change it was 
successful in master. I think there is some issue with the branch. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

[nitin-maharana]

GitHub user nitin-maharana opened a pull request:

https://github.com/apache/cloudstack/pull/1319

CLOUDSTACK-9132: API createVolume takes empty string for name parameter

Steps to Reproduce:


Create a volume using createVolume API where parameter name is empty.
It creates a volume with empty name.
But the name parameter is mandatory.(Issue)

Expected Behaviour:


It shouldn't create a volume with an empty name. Error should be returned.

Solution:
===

Added a condition to check in case of empty string. If the name is an empty 
string, it generates a random name for the volume. Made the name field optional 
in UI as well as in API.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nitin-maharana/CloudStack 
CloudStack-Nitin15_4.7

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1319.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1319


commit 55f8b32aa00baf0609f54891230269ed97bedb5a
Author: Nitin Kumar Maharana 
Date:   2015-12-29T11:15:41Z

CLOUDSTACK-9132: API createVolume takes empty string for name parameter

Added conditions to check if the name is empty or blank.
If it is empty or blank, then it generates a random name.
Made the name field as optional in UI as well as in API.
Added required unit tests.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

[nitin-maharana]

Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/1319#issuecomment-169927365
  
Reference PR #1273 (Against master) with 3 LGTMs. This PR (against 4.7) 
contains the same code change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

[nitin-maharana]

Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/1273#issuecomment-169927533
  
Closing this PR as made a new PR #1319 (Against 4.7 which will be merged in 
master later).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

[nitin-maharana]

Github user nitin-maharana closed the pull request at:

https://github.com/apache/cloudstack/pull/1273


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8968: UI icon over VM snapshot...

[nitin-maharana]

GitHub user nitin-maharana opened a pull request:

https://github.com/apache/cloudstack/pull/1320

CLOUDSTACK-8968: UI icon over VM snapshot to deploy user instance

Added a new Icon in Instance page to launch the VM from the snapshot.

A new icon over VM snapshot object, which upon invoked will open a deploy 
user instance wizard, where there is no choice to choose zone and ISO or 
template to deploy the user instance from.

1) A new icon to indicate deploy user instance from VM snapshot
2) The new icon is placed as an operation over each VM snapshot object.
3) Clicking this icon will show the wizard to deploy user instance, which 
is same as wizard for normal user instance except that zone selection page and 
ISO/template selection page would not be present in this wizard.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nitin-maharana/CloudStack 
CloudStack-Nitin12_4.7

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1320.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1320


commit 55183fd81804e41f9fa8e335a3282ef42e536af7
Author: Nitin Kumar Maharana 
Date:   2015-12-07T18:14:37Z

CLOUDSTACK-8968: UI icon over VM snapshot to deploy user instance

Added a new Icon in Instance page to launch the VM from the snapshot.
Only supports in case of VMware.

Conflicts:
client/WEB-INF/classes/resources/messages.properties




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8968: UI icon over VM snapshot...

[nitin-maharana]

Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/1150#issuecomment-169931078
  
Closing this PR as made a new PR #1320 (Against 4.7 which will be merged in 
master later).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8968: UI icon over VM snapshot...

[nitin-maharana]

Github user nitin-maharana closed the pull request at:

https://github.com/apache/cloudstack/pull/1150


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8968: UI icon over VM snapshot...

[nitin-maharana]

Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/1320#issuecomment-169931271
  
Reference PR #1150 (Against 4.6). This PR (against 4.7) contains the same 
code change with one conflict which I resolved.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8847: ListServiceOfferings is ...

[nitin-maharana]

GitHub user nitin-maharana opened a pull request:

https://github.com/apache/cloudstack/pull/1321

CLOUDSTACK-8847: ListServiceOfferings is returning incompatible tagged 
offerings when called with VM id

When calling listServiceOfferings with VM id as parameter. It is returning 
incompatible tagged offerings. It should only list all compatible tagged 
offerings. Compatible means the new service offering should contain all the 
tags of the existing service offering(Existing offering SUBSET of new 
offering). If that is the case It should list in the result and can be upgraded 
to that offering.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nitin-maharana/CloudStack 
CloudStack-Nitin5_4.7

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1321.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1321


commit ba0503d000250e233701a71bd8e406e52b6ad110
Author: Nitin Kumar Maharana 
Date:   2015-09-14T16:32:37Z

CLOUDSTACK-8847: ListServiceOfferings is returning incompatible tagged 
offerings when called with VM id

Fixed the subset and superset issue.
Added unit test for the same.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8847: ListServiceOfferings is ...

[nitin-maharana]

Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/1321#issuecomment-169934934
  
Reference PR #823 (Against master). This PR (against 4.7) contains the same 
code change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8847: ListServiceOfferings is ...

[nitin-maharana]

Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/823#issuecomment-169935147
  
Closing this PR as made a new PR #1321 (Against 4.7 which will be merged in 
master later).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8847: ListServiceOfferings is ...

[nitin-maharana]

Github user nitin-maharana closed the pull request at:

https://github.com/apache/cloudstack/pull/823


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

[nitin-maharana]

Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/1319#issuecomment-169935900
  
Hi @remibergsma, I created all my pending PRs against 4.7. Can you please 
review once. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9220 Sort list of domains on D...

[nitin-maharana]

Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/1327#issuecomment-170453979
  
@remibergsma: Checked for all alphabet names, its sorting perfectly. But 
how it is sorting for special character names starting with @, #, etc. Is it 
sorting according to ASCII value or anything else? 

https://cloud.githubusercontent.com/assets/12583725/12228670/c17e9b02-b864-11e5-8c88-315b3826e846.png";>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9221 Allow admin to see user V...

[nitin-maharana]

Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/1325#issuecomment-170477896
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

[nitin-maharana]

Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/1319#issuecomment-170801193
  
@remibergsma : Any updates on this. Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9192: UpdateVpnCustomerGateway...

[nitin-maharana]

Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/1300#issuecomment-170801305
  
@kishankavala @koushik-das : Can you please review this. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

[nitin-maharana]

Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/1319#issuecomment-170825451
  
@mike-tutkowski : Yes, we decided to make random name as a preferred 
solution. You can refer the detail conversation on this PR #1273 . Thanks for 
reviewing. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

[nitin-maharana]

Github user nitin-maharana commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1319#discussion_r49498039
  
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -476,6 +476,25 @@ public VolumeVO doInTransaction(TransactionStatus 
status) {
 });
 }
 
+/**
+ * Retrieves the volume name from CreateVolumeCmd object.
+ *
+ * If the retrieved volume name is null, empty or blank, then A random 
name
+ * will be generated using getRandomVolumeName method.
+ *
+ * @param cmd
+ * @return Either the retrieved name or a random name.
+ */
+public String getVolumeNameFromCommand(CreateVolumeCmd cmd) {
+String userSpecifiedName = cmd.getVolumeName();
+
+if 
(org.apache.commons.lang.StringUtils.isBlank(userSpecifiedName)) {
--- End diff --

@mike-tutkowski : Exactly there is one more StringUtils. If you put this it 
will conflict. I tried in that way but it gives error.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

[nitin-maharana]

Github user nitin-maharana commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1319#discussion_r49551329
  
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -476,6 +476,25 @@ public VolumeVO doInTransaction(TransactionStatus 
status) {
 });
 }
 
+/**
+ * Retrieves the volume name from CreateVolumeCmd object.
+ *
+ * If the retrieved volume name is null, empty or blank, then A random 
name
+ * will be generated using getRandomVolumeName method.
+ *
+ * @param cmd
+ * @return Either the retrieved name or a random name.
+ */
+public String getVolumeNameFromCommand(CreateVolumeCmd cmd) {
+String userSpecifiedName = cmd.getVolumeName();
+
+if 
(org.apache.commons.lang.StringUtils.isBlank(userSpecifiedName)) {
--- End diff --

Yes, you can test the change. But I have tested this on my environment. Its 
working fine. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

[nitin-maharana]

Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/1319#issuecomment-171184133
  
@remibergsma @DaanHoogland : It has got 4 LGTMs. Is it going to be merged? 
Should it be reviewed by some more people? Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9228: Network update with mist...

[nitin-maharana]

GitHub user nitin-maharana opened a pull request:

https://github.com/apache/cloudstack/pull/1333

CLOUDSTACK-9228: Network update with mistmatch in services require forced 
option

Steps to reproduce:
===
1.Bring up CloudStack in advanced zone 
2.Create isolated network with sourcenat, pf, lb, firewall services
3.Deploy a VM in the above network
4.Create another network offering with sourcenat, pf, firewall services
5.Try to update the network with offering created in step4

Result:
==
The new offering:DefaultIsolatedNetworkOfferingForVpcNetworksNoLB will 
remove the following services [Lb]along with all the related configuration 
currently in use. will not proceed with the network update.set forced parameter 
to true for forcing an update."

Workaround:
===
Use api with forced=true

Fix:
===
Added a confirmation dialog box to check whether to make force update or 
not.
The dialog appears only for the Admin. Only admin can make force update.
The new dialog appears after the first CIDR unchanged confirmation dialog.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nitin-maharana/CloudStack 
CloudStack-Nitin16_4.7

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1333.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1333


commit 4b7fef6a68ee2684e3b8c8eb0035f7e36cb1be01
Author: Nitin Kumar Maharana 
Date:   2016-01-01T15:38:20Z

CLOUDSTACK-9228: Network update with mistmatch in services require forced 
option

Added a confirmation dialog box to check whether to make force update or 
not.
The dialog appears only for the Admin. Only admin can make force update.
The new dialog appears after the first CIDR unchanged confirmation dialog.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9229: Autoscale policy creatio...

[nitin-maharana]

GitHub user nitin-maharana opened a pull request:

https://github.com/apache/cloudstack/pull/1334

CLOUDSTACK-9229: Autoscale policy creation failing in VPC due to zone id 
missing in createAutoScaleVmProfile

Autoscale policy creation is failing on VPC while creating 
autoscalevmprofile since zoneid parameter is missing.

Steps to Reproduce:

1. Create VPC Network offering with NS as service provider for LB
2. Create VPC using offering which has NetScaler as LB provider
3. Add a tier using the network offering created in Step1
4. Launch a VM
5. Acquire a public IP
6. Create an auto scale policy with all required parameters on an LB rule

Result:
==
Fails during autoscalevmprofile creation with the following error:

GET  
command=createAutoScaleVmProfile&response=json&serviceofferingid=05ac866f-604c-43e2-a48b-47e83ef7c4f1&templateid=3cdd83c4-ad27-11e5-9eaf-42407779c24b&destroyvmgraceperiod=30&counterparam%5B0%5D.name=snmpcommunity&counterparam%5B0%5D.value=public&counterparam%5B1%5D.name=snmpport&counterparam%5B1%5D.value=161&_=1451458073663
DEBUG [o.a.c.a.BaseCmd] (catalina-exec-10:ctx-58bcf6cf ctx-f5123e30) 
(logid:ae6742c8) Ignoring paremeter fordisplay as the caller is not authorized 
to pass it in
INFO  [c.c.a.ApiServer] (catalina-exec-10:ctx-58bcf6cf ctx-f5123e30) 
(logid:ae6742c8) Unable to execute API command autoscalevmprofile due to 
missing parameter zoneid

Expected Result:
=
Autoscale policy creation should be successful and the "min" number of VMs 
specified in the policy should be deployed.

Following should be the params for autoscalevmprofile creation:

command=createAutoScaleVmProfile&response=json&zoneid=0b43fff3-c069-417b-ac0c-e4dc46b407ea&serviceofferingid=0

5ac866f-604c-43e2-a48b-47e83ef7c4f1&templateid=3cdd83c4-ad27-11e5-9eaf-42407779c24b&destroyvmgraceperiod=30&counterparam%5B0%5D

.name=snmpcommunity&counterparam%5B0%5D.value=public&counterparam%5B1%5D.name=snmpport&counterparam%5B1%5D.value=161

Fix:
===
Added a conditon to check whether the zoneid in networks is undefined,
If that is undefined, it gets the zoneid from ipaddresses argument.
Fixed a localization issue.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nitin-maharana/CloudStack 
CloudStack-Nitin17_4.7

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1334.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1334


commit 8e778151e1cc6064ea46b457be266a8ec3afc7d7
Author: Nitin Kumar Maharana 
Date:   2016-01-07T11:27:54Z

CLOUDSTACK-9229: Autoscale policy creation failing in VPC due to zoneid 
missing in createAutoScaleVmProfile

Added a conditon to check whether the zoneid in networks is undefined,
If that is undefined, it gets the zoneid from ipaddresses argument.
Fixed a localization issue.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---