Re: [PR] Add github actions for verifying different type input params with go sdk [cloudstack-go]
Copilot commented on code in PR #111: URL: https://github.com/apache/cloudstack-go/pull/111#discussion_r2108217940 ## .github/workflows/ci.yml: ## @@ -0,0 +1,126 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +name: Build Check + +on: + push: +branches: ["main"] + pull_request: +branches: ["main"] + +permissions: + contents: read + +env: + CLOUDSTACK_API_URL: http://localhost:8080/client/api + CLOUDSTACK_USER_ID: 2 + +jobs: + build: +runs-on: ubuntu-latest +services: + cloudstack-simulator: +image: apache/cloudstack-simulator:4.20.0.0 +ports: + - 8080:5050 +options: >- + --health-cmd "curl -f http://localhost:5050 || exit 1" + --health-interval 30s + --health-timeout 10s + --health-retries 5 +steps: + - uses: actions/checkout@v4 + + - name: Set up Go +uses: actions/setup-go@v5 +with: + go-version: "1.23" + check-latest: true + + - name: Cache Go modules Review Comment: This Go module caching block is duplicated in multiple workflows. Consider extracting it into a reusable composite action or central step to avoid duplication. ## Makefile: ## @@ -26,6 +28,6 @@ test: go test -v github.com/apache/cloudstack-go/v2/test MOCKGEN := mockgen -mockgen: ## Download conversion-gen locally if necessary. +mockgen: ## Download mockgen locally if necessary. Review Comment: The comment suggests conditional download but the target always installs mockgen. Update to something like 'Install mockgen locally via go install'. ```suggestion mockgen: ## Install mockgen locally via go install. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Add github actions for verifying different type input params with go sdk [cloudstack-go]
vishesh92 opened a new pull request, #111: URL: https://github.com/apache/cloudstack-go/pull/111 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements docs [cloudstack-documentation]
Pearl1594 commented on PR #458: URL: https://github.com/apache/cloudstack-documentation/pull/458#issuecomment-2909355064 @nvazquez Should we add some images for: - Custom template registration - where `for CKS` is highlighted - CNI Configuration Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Update usage types in the docs [cloudstack-documentation]
DaanHoogland commented on PR #504: URL: https://github.com/apache/cloudstack-documentation/pull/504#issuecomment-2909781503 quite frankly I am against this change. there is a list usage types API and it should document the usage types. adding/updating the docs on this in creating a split source of truth. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements docs [cloudstack-documentation]
Pearl1594 commented on code in PR #458: URL: https://github.com/apache/cloudstack-documentation/pull/458#discussion_r2107041193 ## source/plugins/cloudstack-kubernetes-service.rst: ## @@ -15,7 +15,11 @@ CloudStack Kubernetes Service The Kubernetes Service plugin adds Kubernetes integration to CloudStack. The plugin is disabled by default and an admin can enable it using a Global Setting. It enables users to run containerized services using Kubernetes clusters. -With CoreOS having reached EOL, from 4.16 the Kubernetes Service Plugin will use the existing SystemVM Template for deploying kubernetes clusters. For installation of Kubernetes binaries on the cluster nodes, a binaries ISO is used for each Kubernetes version to be made available via CloudStack. This allows faster, offline installation of Kubernetes binaries and docker images along with support for adding multiple versions of Kubernetes for upgrades and running different clusters. +With CoreOS having reached EOL, from 4.16 the Kubernetes Service Plugin will use the existing SystemVM Template by default for deploying kubernetes clusters. For installation of Kubernetes binaries on the cluster nodes, a binaries ISO is used for each Kubernetes version to be made available via CloudStack. This allows faster, offline installation of Kubernetes binaries and docker images along with support for adding multiple versions of Kubernetes for upgrades and running different clusters. + +.. note:: + Since version 4.21.0 users can choose different templates and service offerings for different types of nodes (worker, control, etcd nodes) for deploying Kubernetes clusters. The templates must be previously registered selecting the 'For CKS' option. Review Comment: ```suggestion From version 4.21.0, users can choose different templates and service offerings for different types of nodes (worker, control, etcd nodes) for deploying Kubernetes clusters. The templates must be previously registered selecting the 'For CKS' option. ``` ## source/plugins/cloudstack-kubernetes-service.rst: ## @@ -92,6 +109,10 @@ Once the ISO has been built for a desired Kubernetes version, it can be added by |cks-add-version-form.png| +.. note:: + Since 4.21.0 it is possible to deploy separate dedicated etcd nodes. This requires Review Comment: ```suggestion From 4.21.0, it is possible to deploy separate dedicated etcd nodes. This requires ``` ## source/plugins/cloudstack-kubernetes-service.rst: ## @@ -194,6 +215,17 @@ New Kubernetes clusters can be created using the API or via the UI. User will be |cks-create-cluster-form.png| +Since 4.21.0, the Hypervisor selection is available for Kubernetes Cluster nodes. By default the Hypervisor selection is empty. Review Comment: ```suggestion From 4.21.0, you can select the hypervisor type for Kubernetes cluster nodes. By default, no hypervisor is selected. ``` ## source/plugins/cloudstack-kubernetes-service.rst: ## @@ -194,6 +215,17 @@ New Kubernetes clusters can be created using the API or via the UI. User will be |cks-create-cluster-form.png| +Since 4.21.0, the Hypervisor selection is available for Kubernetes Cluster nodes. By default the Hypervisor selection is empty. + +Since 4.21.0, users will be provided with an optional section displayed when toggling the option: 'Show Advanced Settings'. On this section, users can select templates and service offerings for: +- Worker nodes +- Control nodes +- Etcd nodes (if one or more are selected, no etcd nodes are selected by default) Review Comment: ```suggestion - Etcd nodes (if etcd node count >= 1; By default etcd node count is 0) ``` ## source/plugins/cloudstack-kubernetes-service.rst: ## @@ -405,6 +444,220 @@ To remove an Instance from an ExternalManaged Kubernetes cluster: These operations are only supported for an ExternalManaged Kubernetes Cluster +.. _flexible-kubernetes-clusters: + +Flexible Kubernetes Clusters + + +Since 4.21.0, CloudStack introduces many enhancements to Kubernetes Clusters allowing users to: + +- Select the Hypervisor hype for the Kubernetes Cluster nodes +- Specify different templates and/or service offerings for different types of Kubernetes Clusters nodes +- Use CKS-ready custom and non-ready templates for Kubernetes cluster nodes +- Separate etcd nodes from control nodes of the Kubernetes clusters +- Add and remove a pre-created instance as a worker node to an existing Kubernetes cluster +- Mark Kubernetes cluster nodes for manual-only upgrade +- Dedicate specific hosts/clusters to a specific domain for CKS cluster deployment +- Use diverse CNI plugins (Calico, Cilium, etc) + +Build a custom template to use for Kubernetes clusters nodes + + +CloudStack provides a custom CKS-ready t
Re: [I] Secondary storage list/update/delete API endpoints [cloudstack-go]
DaanHoogland commented on issue #110: URL: https://github.com/apache/cloudstack-go/issues/110#issuecomment-2909689302 the page https://cloudstack.apache.org/api/apidocs-4.20/apis/addSecondaryStorage.html shows that the create (add) API has the parameter `name`. also the update has the parameter (https://cloudstack.apache.org/api/apidocs-4.20/apis/updateImageStore.html). By the looks of `ImageStoreService.go` it should also be available to go clients @catalinpan . There is also a ListImageStores in that file. Can you expand on the issue you are facing? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
