Copilot commented on code in PR #111: URL: https://github.com/apache/cloudstack-go/pull/111#discussion_r2108217940
########## .github/workflows/ci.yml: ########## @@ -0,0 +1,126 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +name: Build Check + +on: + push: + branches: ["main"] + pull_request: + branches: ["main"] + +permissions: + contents: read + +env: + CLOUDSTACK_API_URL: http://localhost:8080/client/api + CLOUDSTACK_USER_ID: 2 + +jobs: + build: + runs-on: ubuntu-latest + services: + cloudstack-simulator: + image: apache/cloudstack-simulator:4.20.0.0 + ports: + - 8080:5050 + options: >- + --health-cmd "curl -f http://localhost:5050 || exit 1" + --health-interval 30s + --health-timeout 10s + --health-retries 5 + steps: + - uses: actions/checkout@v4 + + - name: Set up Go + uses: actions/setup-go@v5 + with: + go-version: "1.23" + check-latest: true + + - name: Cache Go modules Review Comment: This Go module caching block is duplicated in multiple workflows. Consider extracting it into a reusable composite action or central step to avoid duplication. ########## Makefile: ########## @@ -26,6 +28,6 @@ test: go test -v github.com/apache/cloudstack-go/v2/test MOCKGEN := mockgen -mockgen: ## Download conversion-gen locally if necessary. +mockgen: ## Download mockgen locally if necessary. Review Comment: The comment suggests conditional download but the target always installs mockgen. Update to something like 'Install mockgen locally via go install'. ```suggestion mockgen: ## Install mockgen locally via go install. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
