[GitHub] [cloudstack-documentation] rohityadavcloud opened a new pull request, #337: hosts: make it clear what to expect and how to configure balloon feature on KVM
rohityadavcloud opened a new pull request, #337: URL: https://github.com/apache/cloudstack-documentation/pull/337 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] rohityadavcloud commented on pull request #337: hosts: make it clear what to expect and how to configure balloon feature on KVM
rohityadavcloud commented on PR #337: URL: https://github.com/apache/cloudstack-documentation/pull/337#issuecomment-1665166007 @blueorangutan docbuild -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #337: hosts: make it clear what to expect and how to configure balloon feature on KVM
blueorangutan commented on PR #337: URL: https://github.com/apache/cloudstack-documentation/pull/337#issuecomment-1665166983 @rohityadavcloud a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #337: hosts: make it clear what to expect and how to configure balloon feature on KVM
blueorangutan commented on PR #337: URL: https://github.com/apache/cloudstack-documentation/pull/337#issuecomment-1665168115 QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/337. (QA-JID 105) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-go] rohityadavcloud merged pull request #59: Add support for unmanaged kubernetes
rohityadavcloud merged PR #59: URL: https://github.com/apache/cloudstack-go/pull/59 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-go] rohityadavcloud merged pull request #65: Link to most current API docs 4.18
rohityadavcloud merged PR #65: URL: https://github.com/apache/cloudstack-go/pull/65 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-go] rohityadavcloud commented on a diff in pull request #64: Fix spelling
rohityadavcloud commented on code in PR #64:
URL: https://github.com/apache/cloudstack-go/pull/64#discussion_r1284113554
##
generate/listApis.json:
##
@@ -2059,7 +2059,7 @@
"type": "long"
},
{
- "description": "the ID of the availablility zone for the virtual
machine",
Review Comment:
this is a generate file from cloudstack; if we fix in cloudstack's API
docs/descriptions then it would be fixed here. If I merge the change the next
time we generate the list of APIs (json), this will be reverted again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack-documentation] rohityadavcloud merged pull request #337: hosts: make it clear what to expect and how to configure balloon feature on KVM
rohityadavcloud merged PR #337: URL: https://github.com/apache/cloudstack-documentation/pull/337 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
CloudStack India User Group Meet Up
Hi all, Reminder that we will be having a user group meetup on August 18th in Bangalore, India. You can register for the event here: https://www.meetup.com/india-cloudstack-user-group/events/294738405/ Also we have an open CFP which will be active until next Friday, If you would like to join with a talk, please submit it here: https://forms.gle/AqvWiutCSzaBYUii8 I am happy to invite all CloudStack users based in India or close to join the meetup :) Kind regards,
[GitHub] [cloudstack-terraform-provider] fabiomatavelli opened a new pull request, #64: Improves service offering resource
fabiomatavelli opened a new pull request, #64: URL: https://github.com/apache/cloudstack-terraform-provider/pull/64 Hi, Here is some improvement in the `cloudstack_service_offering` resource so we can specify the `cpu_number`, `cpu_speed` and `memory` now. I've added the acceptance test CI which can be run with different versions of Cloudstack. Although it is failing, the specific test for this change is passing: ``` === RUN TestAccCloudStackServiceOffering_basic --- PASS: TestAccCloudStackServiceOffering_basic (0.33s) ``` Also, I made a change in the README to include the updated version of the `cloudstack-simulator`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-terraform-provider] rohityadavcloud commented on a diff in pull request #54: Added contribute document
rohityadavcloud commented on code in PR #54: URL: https://github.com/apache/cloudstack-terraform-provider/pull/54#discussion_r1284607437 ## CONTRIBUTING.md: ## @@ -0,0 +1,139 @@ +Contributing to Apache CloudStack Terraform Provider (ACS) +=== + +Summary +--- +This document covers how to contribute to the ACS project. ACS uses GitHub PRs to manage code contributions. +These instructions assume you have a GitHub.com account, so if you don't have one you will have to create one. Your proposed code changes will be published to your own fork of the ACS project and you will submit a Pull Request for your changes to be added. + +_Lets get started!!!_ + +Bug fixes +- + +It's very important that we can easily track bug fix commits, so their hashes should remain the same in all branches. +Therefore, a pull request (PR) that fixes a bug, should be sent against a release branch. +This can be either the "current release" or the "previous release", depending on which ones are maintained. +Since the goal is a stable main, bug fixes should be "merged forward" to the next branch in order: "previous release" -> "current release" -> main (in other words: old to new) + +Developing new features +--- + +Development should be done in a feature branch, branched off of main. +Send a PR(steps below) to get it into main (2x LGTM applies). +PR will only be merged when main is open, will be held otherwise until main is open again. +No back porting / cherry-picking features to existing branches! + +PendingReleaseNotes file + +When developing a new feature or making a (major) change to a existing feature you are encouraged to append this to the PendingReleaseNotes file so that the Release Manager can +use this file as a source of information when compiling the Release Notes for a new release. + +When adding information to the PendingReleaseNotes file make sure that you write a good and understandable description of the new feature or change which you have developed. + +Updating the PendingReleaseNotes file is preferably a part of the original Pull Request, but that is up to the developers' discretion. + +Fork the code +- + +In your browser, navigate to: [https://github.com/apache/cloudstack-terraform-provider](https://github.com/apache/cloudstack-terraform-provider) + +Fork the repository by clicking on the 'Fork' button on the top right hand side. The fork will happen and you will be taken to your own fork of the repository. Copy the Git repository URL by clicking on the clipboard next to the URL on the right hand side of the page under '**HTTPS** clone URL'. You will paste this URL when doing the following `git clone` command. + +On your computer, follow these steps to setup a local repository for working on ACS: + +``` bash +$ git clone https://github.com/YOUR_ACCOUNT/cloudstack-terraform-provider.git +$ cd cloudstack +$ git remote add upstream https://github.com/apache/cloudstack-terraform-provider.git +$ git checkout main +$ git fetch upstream +$ git rebase upstream/main +``` + + +Making changes +-- + + +It is important that you create a new branch to make changes on and that you do not change the `main` branch (other than to rebase in changes from `upstream/main`). In this example I will assume you will be making your changes to a branch called `feature_x`. This `feature_x` branch will be created on your local repository and will be pushed to your forked repository on GitHub. Once this branch is on your fork you will create a Pull Request for the changes to be added to the ACS project. + +It is best practice to create a new branch each time you want to contribute to the project and only track the changes for that pull request in this branch. + +``` bash +$ git checkout -b feature_x + (make your changes) +$ git status +$ git add . +$ git commit -a -m "descriptive commit message for your changes" +``` + +> The `-b` specifies that you want to create a new branch called `feature_x`. You only specify `-b` the first time you checkout because you are creating a new branch. Once the `feature_x` branch exists, you can later switch to it with only `git checkout feature_x`. + + +Rebase `feature_x` to include updates from `upstream/main` + + +It is important that you maintain an up-to-date `main` branch in your local repository. This is done by rebasing in the code changes from `upstream/main` (the official ACS project repository) into your local repository. You will want to do this before you start working on a feature as well as right before you submit your changes as a pull request. I recommend you do this process periodically while you work to make sure you are working off the most recent project code. + +This process will do the following: + +1. Checkout your local
[GitHub] [cloudstack-terraform-provider] rohityadavcloud merged pull request #54: Added contribute document
rohityadavcloud merged PR #54: URL: https://github.com/apache/cloudstack-terraform-provider/pull/54 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-terraform-provider] rohityadavcloud merged pull request #53: Added correct docker and terraform configuration command
rohityadavcloud merged PR #53: URL: https://github.com/apache/cloudstack-terraform-provider/pull/53 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-terraform-provider] rohityadavcloud commented on pull request #53: Added correct docker and terraform configuration command
rohityadavcloud commented on PR #53: URL: https://github.com/apache/cloudstack-terraform-provider/pull/53#issuecomment-1665862763 If there are any new changes @kiranchavala pl submit as separate PR cc @harikrishna-patnala -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-terraform-provider] rohityadavcloud commented on issue #63: project status
rohityadavcloud commented on issue #63: URL: https://github.com/apache/cloudstack-terraform-provider/issues/63#issuecomment-1665864654 I've created a new milestone to track the next release - https://github.com/apache/cloudstack-terraform-provider/milestone/2 Closing on the remark that the original question has been answered. I'll also look if there a way to automate publishing latest builds as alpha/beta releases for anybody to try the latest/bleeding edge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-terraform-provider] rohityadavcloud commented on a diff in pull request #64: Improves service offering resource
rohityadavcloud commented on code in PR #64:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/64#discussion_r1284617395
##
.github/workflows/testacc.yml:
##
@@ -0,0 +1,63 @@
+name: Acceptance Test
Review Comment:
Could you add license header (see other files)
##
.github/workflows/testacc.yml:
##
@@ -0,0 +1,63 @@
+name: Acceptance Test
+
+on: [push, pull_request]
+
+concurrency:
+ group: ${{ github.workflow }}-${{ github.event.pull_request.number ||
github.ref }}-testacc
+ cancel-in-progress: true
+
+jobs:
+ testacc:
+name: Acceptance Test
+runs-on: ubuntu-22.04
+env:
+ CLOUDSTACK_API_URL: http://localhost:8080/client/api
+steps:
+ - uses: actions/checkout@v3
+ - name: Set up Go
+uses: actions/setup-go@v3
+with:
+ go-version: 1.19.x
+ - name: Wait Cloudstack to be ready
+run: |
+ echo "Starting Cloudstack health check"
+ T=0
+ until [ $T -gt 20 ] || curl -sfL http://localhost:8080 --output
/dev/null
+ do
+echo "Waiting for Cloudstack to be ready..."
+((T+=1))
+sleep 30
+ done
+ - name: Setting up Cloudstack
+run: |
+ docker exec $(docker container ls --format=json -l | jq -r .ID)
python /root/tools/marvin/marvin/deployDataCenter.py -i
/root/setup/dev/advanced.cfg
Review Comment:
fantastic good change @fabiomatavelli !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack-terraform-provider] rohityadavcloud commented on pull request #64: Improves service offering resource
rohityadavcloud commented on PR #64: URL: https://github.com/apache/cloudstack-terraform-provider/pull/64#issuecomment-1665870084 @fabiomatavelli thank you for the PR. I liked how you've introduce a CI github action. There is a conflict with README, could you help resolve it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-terraform-provider] rohityadavcloud closed pull request #57: Adding configuration resource
rohityadavcloud closed pull request #57: Adding configuration resource URL: https://github.com/apache/cloudstack-terraform-provider/pull/57 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-terraform-provider] rohityadavcloud commented on pull request #57: Adding configuration resource
rohityadavcloud commented on PR #57: URL: https://github.com/apache/cloudstack-terraform-provider/pull/57#issuecomment-1665871233 @poddm thanks for the PR, do we need to use the latest go-sdk release (https://github.com/apache/cloudstack-go/releases) ? LGTM havn't tested it though. (closed/reopen PR to rekick Github actions build job) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-go] rohityadavcloud commented on pull request #37: WIP: (#36) - support async client
rohityadavcloud commented on PR #37: URL: https://github.com/apache/cloudstack-go/pull/37#issuecomment-1665872177 ping @tetra12 @davidjumani - any update on this? thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-cloudmonkey] rohityadavcloud opened a new issue, #138: In CLI mode, cmk calls sync and doesn't cache it
rohityadavcloud opened a new issue, #138: URL: https://github.com/apache/cloudstack-cloudmonkey/issues/138 In CLI mode, cmk calls sync command before running the passed arg; this may not be necessary if we can explore the heuristics. Use case; run cmk by passing API url, secret and api keys on the shell or wrapped in a shell script. For every such call, it runs an internal sync before running the command. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-terraform-provider] fabiomatavelli commented on a diff in pull request #64: Improves service offering resource
fabiomatavelli commented on code in PR #64: URL: https://github.com/apache/cloudstack-terraform-provider/pull/64#discussion_r1284630436 ## .github/workflows/testacc.yml: ## @@ -0,0 +1,63 @@ +name: Acceptance Test Review Comment: done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-terraform-provider] fabiomatavelli commented on pull request #64: Improves service offering resource
fabiomatavelli commented on PR #64: URL: https://github.com/apache/cloudstack-terraform-provider/pull/64#issuecomment-1665884527 changes applied @rohityadavcloud -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-go] poddm opened a new issue, #66: CreateZoneResponse empty
poddm opened a new issue, #66:
URL: https://github.com/apache/cloudstack-go/issues/66
CreateZone always returns an empty response. The struct should be nested
with the "zone" key.
```go
// Create zone
r, err := cs.Zone.CreateZone(p)
```
Example response from API
```json
{
"zone": {
"id": "6a36f514-e6ea-4a16-85ff-747b063a156e",
"name": "test",
"dns1": "xx.xx.xx.xx",
"dns2": "xx.xx.xx.xx",
"ip6dns1": "",
"ip6dns2": "",
"internaldns1": "1xx.xx.xx.xx",
"internaldns2": "xx.xx.xx.xx",
"domain": "foo.example.com",
"networktype": "Advanced",
"securitygroupsenabled": false,
"allocationstate": "Disabled",
"zonetoken": "d9609197-6586-3fe3-8c4f-efa15a375e8f",
"dhcpprovider": "VirtualRouter",
"localstorageenabled": false,
"tags": [],
"hasannotations": false
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack-go] poddm commented on issue #66: CreateZoneResponse empty
poddm commented on issue #66:
URL: https://github.com/apache/cloudstack-go/issues/66#issuecomment-1665897322
I believe the CreateZoneResponse should be updated to this. I'm trying to
understand the generator to submit a PR.
```go
type CreateZoneResponse struct {
Zone struct {
Allocationstate string
`json:"allocationstate"`
Capacity []CreateZoneResponseCapacity
`json:"capacity"`
Description string
`json:"description"`
Dhcpprovider string
`json:"dhcpprovider"`
Displaytext string
`json:"displaytext"`
Dns1 string `json:"dns1"`
Dns2 string `json:"dns2"`
Domainstring
`json:"domain"`
Domainid string
`json:"domainid"`
Domainnamestring
`json:"domainname"`
Guestcidraddress string
`json:"guestcidraddress"`
Hasannotationsbool
`json:"hasannotations"`
Icon string `json:"icon"`
Idstring `json:"id"`
Internaldns1 string
`json:"internaldns1"`
Internaldns2 string
`json:"internaldns2"`
Ip6dns1 string
`json:"ip6dns1"`
Ip6dns2 string
`json:"ip6dns2"`
JobID string
`json:"jobid"`
Jobstatus int
`json:"jobstatus"`
Localstorageenabled bool
`json:"localstorageenabled"`
Name string `json:"name"`
Networktype string
`json:"networktype"`
Resourcedetails map[string]string
`json:"resourcedetails"`
Securitygroupsenabled bool
`json:"securitygroupsenabled"`
Tags []Tags `json:"tags"`
Zonetoken string
`json:"zonetoken"`
} `json:"zone"`
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack-go] jbampton opened a new pull request, #67: README: change latest version to 4.18
jbampton opened a new pull request, #67: URL: https://github.com/apache/cloudstack-go/pull/67 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-go] rohityadavcloud merged pull request #67: README: change latest version to 4.18
rohityadavcloud merged PR #67: URL: https://github.com/apache/cloudstack-go/pull/67 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-go] poddm commented on issue #66: CreateZoneResponse empty
poddm commented on issue #66:
URL: https://github.com/apache/cloudstack-go/issues/66#issuecomment-1666004967
@Pearl1594, that resolves the issue. Thanks.
```go
// Generic function to get the first non-count raw value from a response as
json.RawMessage
func getRawValue(b json.RawMessage) (json.RawMessage, error) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack-go] soreana commented on pull request #64: Fix spelling
soreana commented on PR #64: URL: https://github.com/apache/cloudstack-go/pull/64#issuecomment-1666013772 @rohityadavcloud I will take care of this. I'm updating the domainid description, I would add these as well. Checkout the following pr please: https://github.com/apache/cloudstack/issues/7776 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-go] soreana commented on pull request #64: Fix spelling
soreana commented on PR #64: URL: https://github.com/apache/cloudstack-go/pull/64#issuecomment-1666017593 Btw, I don't have a permission to assign PRs in this repository, feel free to assign this PR to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-go] rohityadavcloud merged pull request #68: Adding getRawValue to CreateZone api
rohityadavcloud merged PR #68: URL: https://github.com/apache/cloudstack-go/pull/68 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-go] rohityadavcloud closed issue #66: CreateZoneResponse empty
rohityadavcloud closed issue #66: CreateZoneResponse empty URL: https://github.com/apache/cloudstack-go/issues/66 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-terraform-provider] poddm opened a new pull request, #65: Enhancing zone resource
poddm opened a new pull request, #65: URL: https://github.com/apache/cloudstack-terraform-provider/pull/65 Updating Zone resource - Added all fields - set terraform id as zone id instead of zone name. - added updated Note: this requires the latest cloudstack-go client. https://github.com/apache/cloudstack-go/pull/68 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-terraform-provider] poddm opened a new issue, #66: Terraform plugin SDK update
poddm opened a new issue, #66: URL: https://github.com/apache/cloudstack-terraform-provider/issues/66 Looks like cloudstack is using the "legacy Terraform plugin SDK". To ensure terraform core compatibility we should look at upgrading to SDK v2. Current: `github.com/hashicorp/terraform v0.12.0` - https://github.com/apache/cloudstack-terraform-provider/blob/main/go.mod#L9 [v1-upgrade-guide](https://developer.hashicorp.com/terraform/plugin/sdkv2/guides/v1-upgrade-guide) > As of September 2019, Terraform provider developers importing the Go module github.com/hashicorp/terraform, known as Terraform Core, should switch to github.com/hashicorp/terraform-plugin-sdk, the Terraform Plugin SDK, instead. .. > We will use the term "legacy Terraform plugin SDK" when referring to the version of Terraform Core imported and used by providers. [Upgrading to the latest Terraform SDK](https://developer.hashicorp.com/terraform/plugin/sdkv2/guides/terraform-0.12-compatibility#upgrading-to-the-latest-terraform-sdk) At the time of the Terraform 0.12 release, the Terraform SDK is a set of sub-directories inside the Terraform Core repository. Therefore upgrading to the latest Terraform SDK involves upgrading all of the dependencies on Go packages with the prefix github.com/hashicorp/terraform/ to a version with support for the new provider protocol. NOTE: The SDK is now its own Go module. Existing providers should upgrade to at least v0.12.7 before [switching to the standalone SDK](https://developer.hashicorp.com/terraform/plugin/sdkv2/guides/v1-upgrade-guide). This is to isolate issues between Terraform SDK v0.11 and v0.12, and the standalone SDK. New providers should vendor the standalone SDK from the start. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
