rohityadavcloud commented on code in PR #64:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/64#discussion_r1284617395
##########
.github/workflows/testacc.yml:
##########
@@ -0,0 +1,63 @@
+name: Acceptance Test
Review Comment:
Could you add license header (see other files)
##########
.github/workflows/testacc.yml:
##########
@@ -0,0 +1,63 @@
+name: Acceptance Test
+
+on: [push, pull_request]
+
+concurrency:
+ group: ${{ github.workflow }}-${{ github.event.pull_request.number ||
github.ref }}-testacc
+ cancel-in-progress: true
+
+jobs:
+ testacc:
+ name: Acceptance Test
+ runs-on: ubuntu-22.04
+ env:
+ CLOUDSTACK_API_URL: http://localhost:8080/client/api
+ steps:
+ - uses: actions/checkout@v3
+ - name: Set up Go
+ uses: actions/setup-go@v3
+ with:
+ go-version: 1.19.x
+ - name: Wait Cloudstack to be ready
+ run: |
+ echo "Starting Cloudstack health check"
+ T=0
+ until [ $T -gt 20 ] || curl -sfL http://localhost:8080 --output
/dev/null
+ do
+ echo "Waiting for Cloudstack to be ready..."
+ ((T+=1))
+ sleep 30
+ done
+ - name: Setting up Cloudstack
+ run: |
+ docker exec $(docker container ls --format=json -l | jq -r .ID)
python /root/tools/marvin/marvin/deployDataCenter.py -i
/root/setup/dev/advanced.cfg
Review Comment:
fantastic good change @fabiomatavelli !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
