[GitHub] [cloudstack-primate] rhtyd commented on issue #620: [BUG] Set default CPU speed and CPU core count to zero (if not autopopulated from ASIS offering)
rhtyd commented on issue #620: URL: https://github.com/apache/cloudstack-primate/issues/620#issuecomment-682365618 Fixed in https://github.com/apache/cloudstack-primate/pull/628 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd closed issue #620: [BUG] Set default CPU speed and CPU core count to zero (if not autopopulated from ASIS offering)
rhtyd closed issue #620: URL: https://github.com/apache/cloudstack-primate/issues/620 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd merged pull request #628: deployvm : Setting default min cpunumber and memory to zero
rhtyd merged pull request #628: URL: https://github.com/apache/cloudstack-primate/pull/628 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] DaanHoogland commented on issue #624: [BUG]
DaanHoogland commented on issue #624: URL: https://github.com/apache/cloudstack-primate/issues/624#issuecomment-682369437 @rhtyd, @andrijapanicsb giving a way to just enter a name and create a network does not prohibit a create network button. the two are not mutually exclusive. I consider this a feature missing. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on issue #605: [BUG] Issue with templateFilter=all for a normal USER role
davidjumani commented on issue #605: URL: https://github.com/apache/cloudstack-primate/issues/605#issuecomment-682404079 @andrijapanicsb Fixed in #609 Could you verify the same ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on issue #603: [BUG] Deploy VM job not submited for a long time (?)
rhtyd commented on issue #603: URL: https://github.com/apache/cloudstack-primate/issues/603#issuecomment-682405414 I tried latest master and primate-qa (simulator) and a KVM/trillian env and don't see this. @andrijapanicsb please re-open if you reproduce this again. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd closed issue #603: [BUG] Deploy VM job not submited for a long time (?)
rhtyd closed issue #603: URL: https://github.com/apache/cloudstack-primate/issues/603 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on issue #604: [BUG] EDIT TEMPLATE not on pair with the old UI
rhtyd commented on issue #604: URL: https://github.com/apache/cloudstack-primate/issues/604#issuecomment-682405798 @davidjumani can you check and remove ssh enabled option if not necessary (does it make any difference)? (from both register and edit template forms) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on issue #605: [BUG] Issue with templateFilter=all for a normal USER role
rhtyd commented on issue #605: URL: https://github.com/apache/cloudstack-primate/issues/605#issuecomment-682406307 @davidjumani if we're not sure when #609 will merge, can you send another PR that fixes this blocker for the specific case for VM deployment for users? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on issue #615: [UX] Show multple aysnc jobs horizonatally rather than vertically
rhtyd commented on issue #615: URL: https://github.com/apache/cloudstack-primate/issues/615#issuecomment-682406740 Normally we would expect users to wait until an async job is done; otherwise they need to live with the prompt. Alternatively we can simply decide to get rid of the floating widget, we've notifications already This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #625: Allow migration of detached volumes
rhtyd commented on a change in pull request #625:
URL: https://github.com/apache/cloudstack-primate/pull/625#discussion_r478957423
##
File path: src/config/section/storage.js
##
@@ -168,7 +168,7 @@ export default {
label: 'label.migrate.volume',
args: ['volumeid', 'storageid', 'livemigrate'],
dataView: true,
- show: (record, store) => { return record.state === 'Ready' &&
['Admin'].includes(store.userInfo.roletype) && record.virtualmachineid },
+ show: (record, store) => { return record.state === 'Ready' &&
['Admin'].includes(store.userInfo.roletype) },
Review comment:
@Pearl1594 @davidjumani do we allow migration of attached VMs, for all
hypervisors? What's the logic/check in old UI?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on issue #624: [BUG]
rhtyd commented on issue #624: URL: https://github.com/apache/cloudstack-primate/issues/624#issuecomment-682407920 I've change milestone to 1.1, we need to discuss this on dev/users ML to see what is the general preference. During preview and testing we were advised against what old UI did therefore you see the change in UX. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #631: FIX - Keep form/modal when clicking outside the form
rhtyd commented on a change in pull request #631: URL: https://github.com/apache/cloudstack-primate/pull/631#discussion_r478959264 ## File path: src/views/project/iam/ProjectRoleTab.vue ## @@ -103,7 +108,12 @@ - + - +
[GitHub] [cloudstack-primate] rhtyd commented on pull request #631: FIX - Keep form/modal when clicking outside the form
rhtyd commented on pull request #631: URL: https://github.com/apache/cloudstack-primate/pull/631#issuecomment-682408632 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd merged pull request #631: FIX - Keep form/modal when clicking outside the form
rhtyd merged pull request #631: URL: https://github.com/apache/cloudstack-primate/pull/631 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd closed issue #629: [BUG] Clicking outside the form (i.e. new offering creation) closes the form
rhtyd closed issue #629: URL: https://github.com/apache/cloudstack-primate/issues/629 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #631: FIX - Keep form/modal when clicking outside the form
rhtyd commented on pull request #631: URL: https://github.com/apache/cloudstack-primate/pull/631#issuecomment-682409003 @utchoang tip - when you send a PR that fixes an issue can you use `Fixes #id-of-pr` in the git commit or PR summary that way merging the PR will close the bug. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd edited a comment on issue #630: [BUG] Batch-deleting VMs doesn't show as completed when done
rhtyd edited a comment on issue #630: URL: https://github.com/apache/cloudstack-primate/issues/630#issuecomment-682409624 @davidjumani it may require some framework level fixes - could it be possible to track the list of asyncjobs somehow and then refresh when all have been completed? (instead of blind polling 30s) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on issue #630: [BUG] Batch-deleting VMs doesn't show as completed when done
rhtyd commented on issue #630: URL: https://github.com/apache/cloudstack-primate/issues/630#issuecomment-682409624 @davidjumani it may require some framework level fixes - could it be possible to track the list of asyncjobs somehow and then refresh when all have been completed? (instead of blind poling 30s) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #625: Allow migration of detached volumes
davidjumani commented on a change in pull request #625:
URL: https://github.com/apache/cloudstack-primate/pull/625#discussion_r478967267
##
File path: src/config/section/storage.js
##
@@ -168,7 +168,7 @@ export default {
label: 'label.migrate.volume',
args: ['volumeid', 'storageid', 'livemigrate'],
dataView: true,
- show: (record, store) => { return record.state === 'Ready' &&
['Admin'].includes(store.userInfo.roletype) && record.virtualmachineid },
+ show: (record, store) => { return record.state === 'Ready' &&
['Admin'].includes(store.userInfo.roletype) },
Review comment:
@rhtyd
```
if (jsonObj.type == "ROOT" || jsonObj.type == "DATADISK") {
if (jsonObj.state == "Ready" && isAdmin() && jsonObj.virtualmachineid !=
null) {
allowedActions.push("migrateVolume");
}
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd merged pull request #625: Allow migration of detached volumes
rhtyd merged pull request #625: URL: https://github.com/apache/cloudstack-primate/pull/625 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on issue #622: [BUG] Migrate volume is missing when volume is detached
rhtyd commented on issue #622: URL: https://github.com/apache/cloudstack-primate/issues/622#issuecomment-682414723 Checked against old UI and verified. Fixed in latest master with https://github.com/apache/cloudstack-primate/pull/625 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd closed issue #622: [BUG] Migrate volume is missing when volume is detached
rhtyd closed issue #622: URL: https://github.com/apache/cloudstack-primate/issues/622 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on issue #630: [BUG] Batch-deleting VMs doesn't show as completed when done
davidjumani commented on issue #630: URL: https://github.com/apache/cloudstack-primate/issues/630#issuecomment-682419988 Yes, but I think it's unnecessary. When refreshing the list view every 30 sec, there's always the latest data available to the user This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani edited a comment on issue #630: [BUG] Batch-deleting VMs doesn't show as completed when done
davidjumani edited a comment on issue #630: URL: https://github.com/apache/cloudstack-primate/issues/630#issuecomment-682419988 @rhtyd Yes, but I think it's unnecessary. When refreshing the list view every 30 sec, there's always the latest data available to the user. Perhaps made by some other user / account This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani edited a comment on issue #630: [BUG] Batch-deleting VMs doesn't show as completed when done
davidjumani edited a comment on issue #630: URL: https://github.com/apache/cloudstack-primate/issues/630#issuecomment-682419988 @rhtyd Yes, but I think it's unnecessary. When refreshing the list view every 30 sec, there's always the latest data available to the user This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani edited a comment on issue #630: [BUG] Batch-deleting VMs doesn't show as completed when done
davidjumani edited a comment on issue #630: URL: https://github.com/apache/cloudstack-primate/issues/630#issuecomment-682419988 @rhtyd Yes, but I think it's unnecessary. When refreshing the list view every 30 sec, there's always the latest data available to the user, updated by some other user / account as well This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani opened a new pull request #632: deployvm: Fixing calling templatefilter=all
davidjumani opened a new pull request #632: URL: https://github.com/apache/cloudstack-primate/pull/632 Fixes #605 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #632: deployvm: Fixing calling templatefilter=all
davidjumani commented on pull request #632: URL: https://github.com/apache/cloudstack-primate/pull/632#issuecomment-682425051 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #632: deployvm: Fixing calling templatefilter=all
blueorangutan commented on pull request #632: URL: https://github.com/apache/cloudstack-primate/pull/632#issuecomment-682425504 @davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani opened a new pull request #633: Fixing networks not shown selected
davidjumani opened a new pull request #633: URL: https://github.com/apache/cloudstack-primate/pull/633 Fixes https://github.com/apache/cloudstack-primate/issues/618 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #633: deployvm: Fixing networks not shown selected
davidjumani commented on pull request #633: URL: https://github.com/apache/cloudstack-primate/pull/633#issuecomment-682426383 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #633: deployvm: Fixing networks not shown when selected
blueorangutan commented on pull request #633: URL: https://github.com/apache/cloudstack-primate/pull/633#issuecomment-682426715 @davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #632: deployvm: Fixing calling templatefilter=all
blueorangutan commented on pull request #632: URL: https://github.com/apache/cloudstack-primate/pull/632#issuecomment-682428872 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/632 (JID-3385) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #633: deployvm: Fixing networks not shown when selected
blueorangutan commented on pull request #633: URL: https://github.com/apache/cloudstack-primate/pull/633#issuecomment-682431849 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/633 (JID-3386) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani opened a new pull request #634: Bug fixes
davidjumani opened a new pull request #634: URL: https://github.com/apache/cloudstack-primate/pull/634 Fixes : https://github.com/apache/cloudstack-primate/issues/604 Also : Hide cance button while deploying a vm This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #634: Bug fixes
davidjumani commented on pull request #634: URL: https://github.com/apache/cloudstack-primate/pull/634#issuecomment-682433770 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #634: Bug fixes
blueorangutan commented on pull request #634: URL: https://github.com/apache/cloudstack-primate/pull/634#issuecomment-682434287 @davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on issue #604: [BUG] EDIT TEMPLATE not on pair with the old UI
davidjumani commented on issue #604: URL: https://github.com/apache/cloudstack-primate/issues/604#issuecomment-682434973 @rhtyd It's just a field used to describe the template but does not have any effect in the service layer This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd merged pull request #633: deployvm: Fixing networks not shown when selected
rhtyd merged pull request #633: URL: https://github.com/apache/cloudstack-primate/pull/633 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd closed issue #618: [BUG] A default one network selected, but no networks previously selected
rhtyd closed issue #618: URL: https://github.com/apache/cloudstack-primate/issues/618 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #634: Bug fixes
rhtyd commented on a change in pull request #634:
URL: https://github.com/apache/cloudstack-primate/pull/634#discussion_r479050862
##
File path: src/views/compute/DeployVM.vue
##
@@ -1409,7 +1409,6 @@ export default {
this.$router.back()
}).catch(error => {
this.$notifyError(error)
-}).finally(() => {
Review comment:
Shouldn't we reset in finally? Otherwise it will reset only on error.
Or, is the logic that on VM deployment we'll change view so this is not
necessary?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #634: Bug fixes
rhtyd commented on a change in pull request #634: URL: https://github.com/apache/cloudstack-primate/pull/634#discussion_r479049921 ## File path: src/views/compute/DeployVM.vue ## @@ -505,7 +505,7 @@ - + Review comment: @davidjumani I think disable would make sense instead of hide? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on issue #605: [BUG] Issue with templateFilter=all for a normal USER role
rhtyd commented on issue #605: URL: https://github.com/apache/cloudstack-primate/issues/605#issuecomment-682438252 @andrijapanicsb please reopen if you can again reproduce it with latest master, thnx This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd closed issue #605: [BUG] Issue with templateFilter=all for a normal USER role
rhtyd closed issue #605: URL: https://github.com/apache/cloudstack-primate/issues/605 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd merged pull request #632: deployvm: Fixing calling templatefilter=all
rhtyd merged pull request #632: URL: https://github.com/apache/cloudstack-primate/pull/632 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #634: Bug fixes
davidjumani commented on a change in pull request #634:
URL: https://github.com/apache/cloudstack-primate/pull/634#discussion_r479053645
##
File path: src/views/compute/DeployVM.vue
##
@@ -1409,7 +1409,6 @@ export default {
this.$router.back()
}).catch(error => {
this.$notifyError(error)
-}).finally(() => {
Review comment:
On success, it goes back to the previous page. If we keep it in finally,
the button will show up for a second before the page redirects
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #634: Bug fixes
davidjumani commented on pull request #634: URL: https://github.com/apache/cloudstack-primate/pull/634#issuecomment-682440535 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #634: Bug fixes
blueorangutan commented on pull request #634: URL: https://github.com/apache/cloudstack-primate/pull/634#issuecomment-682441130 @davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #634: Bug fixes
blueorangutan commented on pull request #634: URL: https://github.com/apache/cloudstack-primate/pull/634#issuecomment-682443125 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/634 (JID-3387) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #634: Bug fixes
blueorangutan commented on pull request #634: URL: https://github.com/apache/cloudstack-primate/pull/634#issuecomment-682450253 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/634 (JID-3388) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #609: [WIP] Fixes for vapps
blueorangutan commented on pull request #609: URL: https://github.com/apache/cloudstack-primate/pull/609#issuecomment-682456558 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/609 (JID-3390) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] andrijapanicsb opened a new issue #635: [BUG] UI should show/hide the Expunge option based on the global settting
andrijapanicsb opened a new issue #635:
URL: https://github.com/apache/cloudstack-primate/issues/635
As a regular user role, I've got the option to delete with Expunge, and that
fails on backend (not visible in UI):
2020-08-28 10:51:12,561 DEBUG [c.c.a.ApiServlet]
(qtp129153987-33177:ctx-c4731a7e ctx-37bc0628) (logid:59a0d46c) ===END===
10.1.0.1 -- GET
id=ada553dc-2103-48af-a0a3-605867b8c630&expunge=true&command=destroyVirtualMachine&response=json
2020-08-28 10:51:12,561 INFO [o.a.c.f.j.i.AsyncJobMonitor]
(API-Job-Executor-108:ctx-54a4a8fc job-732) (logid:9f2159a1) Add job-732 into
job monitoring
2020-08-28 10:51:12,563 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl]
(API-Job-Executor-108:ctx-54a4a8fc job-732) (logid:3dc12c67) Executing
AsyncJobVO {id:732, userId: 4, accountId: 4, instanceType: VirtualMachine,
instanceId: 106, cmd: org.apache.cloudstack.api.command.user.vm.DestroyVMCmd,
cmdInfo:
{"response":"json","ctxUserId":"4","expunge":"true","httpmethod":"GET","ctxStartEventId":"1162","id":"ada553dc-2103-48af-a0a3-605867b8c630","ctxDetails":"{\"interface
com.cloud.vm.VirtualMachine\":\"ada553dc-2103-48af-a0a3-605867b8c630\"}","ctxAccountId":"4","uuid":"ada553dc-2103-48af-a0a3-605867b8c630","cmdEventType":"VM.DESTROY"},
cmdVersion: 0, status: IN_PROGRESS, processStatus: 0, resultCode: 0, result:
null, initMsid: 32989442554424, completeMsid: null, lastUpdated: null,
lastPolled: null, created: null, removed: null}
2020-08-28 10:51:12,564 ERROR [c.c.a.ApiAsyncJobDispatcher]
(API-Job-Executor-106:ctx-ed3b1351 job-730) (logid:9b47a1b1) Unexpected
exception while executing org.apache.cloudstack.api.command.user.vm.DestroyVMCmd
com.cloud.exception.PermissionDeniedException: Parameter expunge can be
passed by Admin only. Or when the allow.user.expunge.recover.vm key is set.
at
com.cloud.vm.UserVmManagerImpl.destroyVm(UserVmManagerImpl.java:2875)
at jdk.internal.reflect.GeneratedMethodAccessor821.invoke(Unknown
Source)
at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
i.e. we should show or hide that slider/checkbox based on that particular
global setting value
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack-primate] andrijapanicsb commented on issue #605: [BUG] Issue with templateFilter=all for a normal USER role
andrijapanicsb commented on issue #605: URL: https://github.com/apache/cloudstack-primate/issues/605#issuecomment-682464888 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] andrijapanicsb commented on issue #606: [BUG] "mine" VMs for Admin, shows also other account's VMs
andrijapanicsb commented on issue #606: URL: https://github.com/apache/cloudstack-primate/issues/606#issuecomment-682465621 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] andrijapanicsb commented on issue #618: [BUG] A default one network selected, but no networks previously selected
andrijapanicsb commented on issue #618: URL: https://github.com/apache/cloudstack-primate/issues/618#issuecomment-682468769 This is not good, perhaps broken in some other fix/commit: When the very first template on the Featured list (the one selected by default when you choose a Zone) is a deploy-as-is template, it seems that none of the OVF properties are parsed or something - as the network sections does NOT show 4 NICS to network mappings (part of the OVF template), also offerings are not filtered etc - see the images below So I can't say if this original bug is fixed  and the networking part  while i.e. the network sections should show nic to network mapping like this one:  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] andrijapanicsb edited a comment on issue #618: [BUG] A default one network selected, but no networks previously selected
andrijapanicsb edited a comment on issue #618: URL: https://github.com/apache/cloudstack-primate/issues/618#issuecomment-682468769 This is not good, perhaps broken in some other fix/commit: When the very first template on the Featured list (the one selected by default when you choose a Zone) is a deploy-as-is template, it seems that none of the OVF properties are parsed or something - as the network sections does NOT show 4 NICS to network mappings (part of the OVF template), also offerings are not filtered etc - see the images below So I can't say if this original bug is fixed  (check the missing Configration dropdown) and the networking part  while i.e. the network sections should show nic to network mapping like this one:  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] andrijapanicsb commented on issue #620: [BUG] Set default CPU speed and CPU core count to zero (if not autopopulated from ASIS offering)
andrijapanicsb commented on issue #620: URL: https://github.com/apache/cloudstack-primate/issues/620#issuecomment-682471966 CPU speed is not set to zero, I will reopen once I retest/upgrade packages This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] andrijapanicsb commented on issue #629: [BUG] Clicking outside the form (i.e. new offering creation) closes the form
andrijapanicsb commented on issue #629: URL: https://github.com/apache/cloudstack-primate/issues/629#issuecomment-682472357 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #609: [WIP] Fixes for vapps
blueorangutan commented on pull request #609: URL: https://github.com/apache/cloudstack-primate/pull/609#issuecomment-682478601 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/609 (JID-3391) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] andrijapanicsb commented on pull request #609: [WIP] Fixes for vapps
andrijapanicsb commented on pull request #609: URL: https://github.com/apache/cloudstack-primate/pull/609#issuecomment-682480525 cpuspeed set to by default - LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] andrijapanicsb commented on pull request #609: [WIP] Fixes for vapps
andrijapanicsb commented on pull request #609: URL: https://github.com/apache/cloudstack-primate/pull/609#issuecomment-682480708 New issue - described here: https://github.com/apache/cloudstack-primate/issues/618#issuecomment-682468769 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
