date:20160520

Github user rhtyd commented on the pull request:

https://github.com/apache/cloudstack/pull/1551#issuecomment-220533786
  
@swill the error suggests the template response is missing the key 'status' 
in its json response. It may happen if there has been any change around 
template (response) code; or if the backend is not setting the status, so 
effectively gson does not serialize those keys (as they are not set)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

2016-05-20 Thread anshul1886

Github user anshul1886 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/669#discussion_r6362
  
--- Diff: 
plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java
 ---
@@ -594,6 +597,25 @@ private PlugNicAnswer execute(final PlugNicCommand 
cmd) {
 }
 }
 
+private CopyFileInVmAnswer execute(CopyFileInVmCommand cmd) {
+File keyFile = getSystemVMKeyFile();
+try {
+File file = new File(cmd.getSrc());
+if(file.exists()) {
+if(file.isDirectory()) {
+for (File f : FileUtils.listFiles(new 
File(cmd.getSrc()), TrueFileFilter.INSTANCE, TrueFileFilter.INSTANCE)) {
+SshHelper.scpTo(cmd.getVmIp(), 3922, "root", 
keyFile, null, cmd.getDest(), f.getCanonicalPath(), null);
+}
+} else {
+SshHelper.scpTo(cmd.getVmIp(), 3922, "root", keyFile, 
null, cmd.getDest(), file.getCanonicalPath(), null);
+}
+}
+} catch (Exception e) {
--- End diff --

I don't understand one point what difference it would make to catch 
specific actions and take same action in all case then catching generic 
exception.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

RE: Migrating CloudStack content from download.cloud.com

2016-05-20 Thread Paul Angus

I'm a -1 on adding another step to the installation process.

I agree with Will, it will only be another barrier to platform adoption.

The SSVM going and downloading the built-in template is a good milestone in a 
CloudStack build.

To be honest the mgmt. server should be able to go get the template itself if 
required rather than making it a user installation step.

Kind regards,

Paul Angus

paul.an...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue



-Original Message-
From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] 
Sent: 19 May 2016 23:06
To: dev 
Subject: Re: Migrating CloudStack content from download.cloud.com

sounds good, so if we put both sections together the worry is over. acs is a 
complex system and requires a lot of reading so let''s not put it in a 
different section. would be duplicate code anyhow.

On Thu, May 19, 2016 at 11:56 PM, Chiradeep Vittal 
wrote:

> Well, you have to define "worry" :)
>
> I'm proposing an almost identical step to
>
> http://docs.cloudstack.apache.org/projects/cloudstack-installation/en/
> 4.6/management-server/#prepare-the-system-vm-template
>
> If they can do that, then it is not a stretch to assume they can 
> download the default template in a similar manner. The 
> "cloud-install-default-template" (proposed) script can do the mirror 
> checking etc.
>
>
>
>
> On Thu, May 19, 2016 at 2:44 PM, Will Stevens 
> wrote:
>
> > I definitely agree with this.  I don't think people doing a PoC 
> > should
> have
> > to worry about getting a template installed on first setup.  I think 
> > that is a basic feature if we want platform adoption.  Getting the 
> > first boot process from download to first VM launched should be as 
> > smooth as
> possible.
> >
> > *Will STEVENS*
> > Lead Developer
> >
> > *CloudOps* *| *Cloud Solutions Experts
> > 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6 w cloudops.com *|* 
> > tw @CloudOps_
> >
> > On Thu, May 19, 2016 at 5:37 PM, Daan Hoogland 
> > 
> > wrote:
> >
> > > Chiradeep,
> > >
> > > It makes sense not to have this old default very insecure guest
> template
> > > still be downloaded but it would be nice to have some kind of 
> > > meta-data pointing to the latest version of an acceptable template 
> > > (symlink) for trial installs so PoCcers are swiftly on their way. Would 
> > > you agree?
> > >
> > > On Thu, May 19, 2016 at 8:15 PM, Chiradeep Vittal <
> chirade...@gmail.com>
> > > wrote:
> > >
> > > > Pierre,
> > > > I meant the auto-download of default templates, not systemvm.
> > > > Note that the initial systemvm template has to be 
> > > > hand-downloaded
> > anyway.
> > > > If you are a single hypervisor cloud, then that is all that is
> needed.
> > > >
> > > > On Thu, May 19, 2016 at 11:08 AM, Pierre-Luc Dion <
> pd...@cloudops.com>
> > > > wrote:
> > > >
> > > > > I would be -1 about disabling the autodownload of the systemvm
> > > template,
> > > > > has this should be simplify deployment of a cloudstack system.
> > > > > although, the download URL should be a configurable value, 
> > > > > maybe
> in a
> > > > > property file or thru the API somehow or via a pre-install command.
> > > > >
> > > > > I really like  download.cloudstack.org + mirror. I'm looking 
> > > > > at
> > > getting
> > > > > the
> > > > > DNS entry: builds.cloudstack.org for the new Jenkins and I got 
> > > > > no objections on using the cloudstack.org domain for community
> services
> > > so
> > > > > I'm
> > > > > pretty sure we would be ok to use download.cloudstack.org, 
> > > > > where
> > would
> > > > we
> > > > > setting this up? on the current webserver of our website? 
> > > > > could we
> ?
> > > > >
> > > > >
> > > > > Cheers,
> > > > >
> > > > > PL
> > > > >
> > > > > On Thu, May 19, 2016 at 11:00 AM, Giles Sirett <
> > > > giles.sir...@shapeblue.com
> > > > > >
> > > > > wrote:
> > > > >
> > > > > > Erik
> > > > > > I agree on the existing users - not the end of the world. We
> could
> > > even
> > > > > > release a tiny patch to update the DB records
> > > > > >
> > > > > > The piece that we need to be really careful with is the 
> > > > > > "I've
> just
> > > > > > downloaded cloudstack  thing for the first time" scenario
> > > > > >
> > > > > > But - there seems to be plenty of good ideas flowing on that
> > > > > >
> > > > > >
> > > > > > Kind Regards
> > > > > > Giles
> > > > > >
> > > > > >
> > > > > > giles.sir...@shapeblue.com
> > > > > > www.shapeblue.com
> > > > > > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK 
> > > > > > @shapeblue
> > > > > >
> > > > > >
> > > > > >
> > > > > > -Original Message-
> > > > > > From: Erik Weber [mailto:terbol...@gmail.com]
> > > > > > Sent: 19 May 2016 09:32
> > > > > > To: dev 
> > > > > > Subject: Re: Migrating CloudStack content from
> download.cloud.com
> > > > > >
> > > > > > As a user (with old ACS installations) I'd say that this 
> > > > > > isn't
> all
> > > that
> > > > > > troublesome, this is ea

Re: Regarding: "AmazonEC2stub.java"

OK, those were generated files that are now removed from the project.

send by tablet, no warranties in existence
On 20 May 2016 08:58, "sangeeta lal"  wrote:

> Dear Sir,
>
> I am using version 4.3.0.
>
> Thanks for  your reply!
>
> On Fri, May 20, 2016 at 12:03 PM, Daan Hoogland 
> wrote:
>
>> Sangeeta,
>>
>> What version of the code are you analysing? There used to be a lot of
>> generated ec2 code in the project some versions back. I can not find the
>> java file you are talking about.
>>
>> On Fri, May 20, 2016 at 8:03 AM, sangeeta lal 
>> wrote:
>>
>> > Dear Dev Team,
>> >
>> >
>> > I am Sangeeta, a PhD scholar from India. I am working in the area of
>> > automated software engineering and my aim is to analyse logging
>> statements.
>> >
>> > While analysing the CloudStack project, I found a file:*
>> > AmazonEC2Stub.java*
>> >
>> >
>> >
>> > Can anyone please tell me the reason, why* this file have no logging
>> > statement?*
>> >
>> >
>> >
>> > I  highly appreciate your help!
>> >
>> > Thank You
>> >
>> > --
>> > Regards...
>> > Sangeeta
>> > Assistant Professor
>> > CSE Department @JIIT Noida
>> >
>>
>>
>>
>> --
>> Daan
>>
>
>
>
> --
> Regards...
> Sangeeta
> Assistant Professor
> CSE Department @JIIT Noida
>
>

[GitHub] cloudstack pull request: CLOUDSTACK-9348: NioConnection improvemen...

Github user rhtyd commented on the pull request:

https://github.com/apache/cloudstack/pull/1549#issuecomment-220545220
  
Thanks @swill 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9377: Fix metrics pagesize iss...

Github user rhtyd commented on the pull request:

https://github.com/apache/cloudstack/pull/1540#issuecomment-220545140
  
@swill let's merge this? thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Explicitely load JDBC driver before creat...

2016-05-20 Thread nlivens

GitHub user nlivens opened a pull request:

https://github.com/apache/cloudstack/pull/1553

Explicitely load JDBC driver before creating our MySQL connections

Solution to the mailing thread titled "MySQL : No suitable driver found for 
jdbc:mysql".
It doesn't harm that we explicitely load the MySQL driver, and for those 
which would use a commons-dbcp version < 1.4 this would fix it as well. Since 
JDBC 4.0, the JDBC driver can auto-register itself, but for some weird cases 
(like mine), it's not working. Therefore we need to explicitly load the JDBC 
driver.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nlivens/cloudstack mysql_driver_issue

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1553.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1553


commit 492c7f2612fdc022d78cd1064ca81e47eb201c04
Author: Nick Livens 
Date:   2016-05-20T08:20:48Z

Explicitely load JDBC driver before creating our MySQL connections




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Explicitely load JDBC driver before creat...

2016-05-20 Thread nlivens

Github user nlivens commented on the pull request:

https://github.com/apache/cloudstack/pull/1553#issuecomment-220546975
  
@swill, @rhtyd, @kiwiflyer, triggering you guys because you were part of 
this mailing thread.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Regarding files generated by WSDL

2016-05-20 Thread Rohit Yadav

Sangeeta,

We've remove wsdl auto-generates files (the awsapi package) from CloudStack.

In the past, these files were generated by aws wsdl description [1] to generate 
client code for an EC2 compatible API that would work with CloudStack.

[1] https://en.wikipedia.org/wiki/Web_Services_Description_Language

Regards,
Rohit Yadav


rohit.ya...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue


On May 20 2016, at 10:08 am, sangeeta lal  wrote:

Dear CloudStack Team,

I am Sangeeta, a PhD scholar from India. I am working in the area of
automated software engineering and my aim is to analyse logging statements.

While analysing the CloudStack project,* I found may files having following
statement written in them*:

*/*This file was auto-generated from WSDL*
* * by the Apache Axis2 version: 1.5.6 Built on : Aug 30, 2011 (10:00:16
CEST)*
*/

1. Can anyone please tell me *what this means*?
2. Are the kinds of file have *no user contribution*?

I highly appreciate your help!

Thank You
--
Regards...
Sangeeta
Assistant Professor
CSE Department @JIIT Noida

[GitHub] cloudstack pull request: Explicitely load JDBC driver before creat...

Github user rhtyd commented on the pull request:

https://github.com/apache/cloudstack/pull/1553#issuecomment-220547372
  
LGTM, I am aware about the issue and the changes are therefore needed. 
Thanks @nlivens 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

RE: Migrating CloudStack content from download.cloud.com

send by tablet, no warranties in existence
On 20 May 2016 09:29, "Paul Angus"  wrote:
>
> I'm a -1 on adding another step to the installation process.
>
> I agree with Will, it will only be another barrier to platform adoption.
>
> The SSVM going and downloading the built-in template is a good milestone
in a CloudStack build.
>
> To be honest the mgmt. server should be able to go get the template
itself if required rather than making it a user installation step.
great idea, looking forward to your PR.

>
> Kind regards,
>
> Paul Angus
>
> paul.an...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue
>
>
>
> -Original Message-
> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
> Sent: 19 May 2016 23:06
> To: dev 
> Subject: Re: Migrating CloudStack content from download.cloud.com
>
> sounds good, so if we put both sections together the worry is over. acs
is a complex system and requires a lot of reading so let''s not put it in a
different section. would be duplicate code anyhow.
>
> On Thu, May 19, 2016 at 11:56 PM, Chiradeep Vittal 
> wrote:
>
> > Well, you have to define "worry" :)
> >
> > I'm proposing an almost identical step to
> >
> > http://docs.cloudstack.apache.org/projects/cloudstack-installation/en/
> > 4.6/management-server/#prepare-the-system-vm-template
> >
> > If they can do that, then it is not a stretch to assume they can
> > download the default template in a similar manner. The
> > "cloud-install-default-template" (proposed) script can do the mirror
> > checking etc.
> >
> >
> >
> >
> > On Thu, May 19, 2016 at 2:44 PM, Will Stevens 
> > wrote:
> >
> > > I definitely agree with this.  I don't think people doing a PoC
> > > should
> > have
> > > to worry about getting a template installed on first setup.  I think
> > > that is a basic feature if we want platform adoption.  Getting the
> > > first boot process from download to first VM launched should be as
> > > smooth as
> > possible.
> > >
> > > *Will STEVENS*
> > > Lead Developer
> > >
> > > *CloudOps* *| *Cloud Solutions Experts
> > > 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6 w cloudops.com *|*
> > > tw @CloudOps_
> > >
> > > On Thu, May 19, 2016 at 5:37 PM, Daan Hoogland
> > > 
> > > wrote:
> > >
> > > > Chiradeep,
> > > >
> > > > It makes sense not to have this old default very insecure guest
> > template
> > > > still be downloaded but it would be nice to have some kind of
> > > > meta-data pointing to the latest version of an acceptable template
> > > > (symlink) for trial installs so PoCcers are swiftly on their way.
Would you agree?
> > > >
> > > > On Thu, May 19, 2016 at 8:15 PM, Chiradeep Vittal <
> > chirade...@gmail.com>
> > > > wrote:
> > > >
> > > > > Pierre,
> > > > > I meant the auto-download of default templates, not systemvm.
> > > > > Note that the initial systemvm template has to be
> > > > > hand-downloaded
> > > anyway.
> > > > > If you are a single hypervisor cloud, then that is all that is
> > needed.
> > > > >
> > > > > On Thu, May 19, 2016 at 11:08 AM, Pierre-Luc Dion <
> > pd...@cloudops.com>
> > > > > wrote:
> > > > >
> > > > > > I would be -1 about disabling the autodownload of the systemvm
> > > > template,
> > > > > > has this should be simplify deployment of a cloudstack system.
> > > > > > although, the download URL should be a configurable value,
> > > > > > maybe
> > in a
> > > > > > property file or thru the API somehow or via a pre-install
command.
> > > > > >
> > > > > > I really like  download.cloudstack.org + mirror. I'm looking
> > > > > > at
> > > > getting
> > > > > > the
> > > > > > DNS entry: builds.cloudstack.org for the new Jenkins and I got
> > > > > > no objections on using the cloudstack.org domain for community
> > services
> > > > so
> > > > > > I'm
> > > > > > pretty sure we would be ok to use download.cloudstack.org,
> > > > > > where
> > > would
> > > > > we
> > > > > > setting this up? on the current webserver of our website?
> > > > > > could we
> > ?
> > > > > >
> > > > > >
> > > > > > Cheers,
> > > > > >
> > > > > > PL
> > > > > >
> > > > > > On Thu, May 19, 2016 at 11:00 AM, Giles Sirett <
> > > > > giles.sir...@shapeblue.com
> > > > > > >
> > > > > > wrote:
> > > > > >
> > > > > > > Erik
> > > > > > > I agree on the existing users - not the end of the world. We
> > could
> > > > even
> > > > > > > release a tiny patch to update the DB records
> > > > > > >
> > > > > > > The piece that we need to be really careful with is the
> > > > > > > "I've
> > just
> > > > > > > downloaded cloudstack  thing for the first time" scenario
> > > > > > >
> > > > > > > But - there seems to be plenty of good ideas flowing on that
> > > > > > >
> > > > > > >
> > > > > > > Kind Regards
> > > > > > > Giles
> > > > > > >
> > > > > > >
> > > > > > > giles.sir...@shapeblue.com
> > > > > > > www.shapeblue.com
> > > > > > > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> > > > > > > @shapeblue
> > > > > > >
> > > > > > >
> > > > > >

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/669#discussion_r64009630
  
--- Diff: 
plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java
 ---
@@ -594,6 +597,25 @@ private PlugNicAnswer execute(final PlugNicCommand 
cmd) {
 }
 }
 
+private CopyFileInVmAnswer execute(CopyFileInVmCommand cmd) {
+File keyFile = getSystemVMKeyFile();
+try {
+File file = new File(cmd.getSrc());
+if(file.exists()) {
+if(file.isDirectory()) {
+for (File f : FileUtils.listFiles(new 
File(cmd.getSrc()), TrueFileFilter.INSTANCE, TrueFileFilter.INSTANCE)) {
+SshHelper.scpTo(cmd.getVmIp(), 3922, "root", 
keyFile, null, cmd.getDest(), f.getCanonicalPath(), null);
+}
+} else {
+SshHelper.scpTo(cmd.getVmIp(), 3922, "root", keyFile, 
null, cmd.getDest(), file.getCanonicalPath(), null);
+}
+}
+} catch (Exception e) {
--- End diff --

The message can be more specific and explanatory. The SshHelper  shouldn't 
throw such a generic exception anyway. This is sloppy development and we now 
have a good chance to improve on it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9180: Optimize concurrent VM d...

Github user koushik-das commented on the pull request:

https://github.com/apache/cloudstack/pull/1251#issuecomment-220558485
  
@swill The failures are not related to this PR.
The failure in test_internal_lb.py is due to some cleanup issue. The 
network deletion failed most probably due to some leftover VMs.
The remaining failures seems to be some environment issue due to which 
templates are not downloaded and also some test code issue in base.py. In the 
below snippet, the execution is going to elif and that is resulting in failure 
due to 'in' check on template.status which doesn't seem to be iterable. 
if template.status == 'Download Complete':
break
elif 'Downloaded' in template.status:
time.sleep(interval)
elif 'Installing' not in template.status:
raise Exception(
"Error in downloading template: status - %s" %
template.status)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: API: improve resource limits comprenhensi...

2016-05-20 Thread marcaurele

GitHub user marcaurele opened a pull request:

https://github.com/apache/cloudstack/pull/1554

API: improve resource limits comprenhension

Add resource type name in request and response.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/exoscale/cloudstack feature/resourcelimits

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1554.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1554


commit 95d91148001484884e437038763a8aaf20220d93
Author: Marc-AurÃ¨le Brothier 
Date:   2016-05-20T08:56:04Z

API: improve resource limits comprenhension

Add resource type name in request and response.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Regarding: "AmazonEC2stub.java"

2016-05-20 Thread sangeeta lal

Dear Sir,

Thank You for the information. I highly appreciate you reply.

Thank You

On Fri, May 20, 2016 at 1:02 PM, Daan Hoogland 
wrote:

> OK, those were generated files that are now removed from the project.
>
> send by tablet, no warranties in existence
> On 20 May 2016 08:58, "sangeeta lal"  wrote:
>
>> Dear Sir,
>>
>> I am using version 4.3.0.
>>
>> Thanks for  your reply!
>>
>> On Fri, May 20, 2016 at 12:03 PM, Daan Hoogland 
>> wrote:
>>
>>> Sangeeta,
>>>
>>> What version of the code are you analysing? There used to be a lot of
>>> generated ec2 code in the project some versions back. I can not find the
>>> java file you are talking about.
>>>
>>> On Fri, May 20, 2016 at 8:03 AM, sangeeta lal 
>>> wrote:
>>>
>>> > Dear Dev Team,
>>> >
>>> >
>>> > I am Sangeeta, a PhD scholar from India. I am working in the area of
>>> > automated software engineering and my aim is to analyse logging
>>> statements.
>>> >
>>> > While analysing the CloudStack project, I found a file:*
>>> > AmazonEC2Stub.java*
>>> >
>>> >
>>> >
>>> > Can anyone please tell me the reason, why* this file have no logging
>>> > statement?*
>>> >
>>> >
>>> >
>>> > I  highly appreciate your help!
>>> >
>>> > Thank You
>>> >
>>> > --
>>> > Regards...
>>> > Sangeeta
>>> > Assistant Professor
>>> > CSE Department @JIIT Noida
>>> >
>>>
>>>
>>>
>>> --
>>> Daan
>>>
>>
>>
>>
>> --
>> Regards...
>> Sangeeta
>> Assistant Professor
>> CSE Department @JIIT Noida
>>
>>


-- 
Regards...
Sangeeta
Assistant Professor
CSE Department @JIIT Noida

[GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...

Github user koushik-das commented on the pull request:

https://github.com/apache/cloudstack/pull/1518#issuecomment-220562852
  
@nvazquez Thanks for the fix. As @DaanHoogland mentioned please add license 
header to the newly added file.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

Github user koushik-das commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1511#discussion_r64015658
  
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java 
---
@@ -429,60 +434,42 @@ private void validateChain(List chain, 
Certificate cert) {
 
 }
 
-public PrivateKey parsePrivateKey(String key, String password) throws 
IOException {
-
-PasswordFinder pGet = null;
-
-if (password != null)
-pGet = new KeyPassword(password.toCharArray());
-
-PEMReader privateKey = new PEMReader(new StringReader(key), pGet);
-Object obj = null;
-try {
-obj = privateKey.readObject();
-} finally {
-IOUtils.closeQuietly(privateKey);
-}
-
-try {
-
-if (obj instanceof KeyPair)
-return ((KeyPair)obj).getPrivate();
-
-return (PrivateKey)obj;
-
-} catch (Exception e) {
+public PrivateKey parsePrivateKey(final String key) throws IOException 
{
+try (final PemReader pemReader = new PemReader(new 
StringReader(key));) {
+final PemObject pemObject = pemReader.readPemObject();
+final byte[] content = pemObject.getContent();
+final PKCS8EncodedKeySpec privKeySpec = new 
PKCS8EncodedKeySpec(content);
+final KeyFactory factory = KeyFactory.getInstance("RSA", "BC");
+return factory.generatePrivate(privKeySpec);
+} catch (NoSuchAlgorithmException | NoSuchProviderException e) {
+throw new IOException("No encryption provider available.", e);
+} catch (final InvalidKeySpecException e) {
 throw new IOException("Invalid Key format or invalid 
password.", e);
--- End diff --

@DaanHoogland Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Remodeling of Nuage VSP Plugin + CLOUDSTA...

2016-05-20 Thread KrisSterckx

Github user KrisSterckx commented on the pull request:

https://github.com/apache/cloudstack/pull/1494#issuecomment-220576106
  
Yes, correct, and thanks @DaanHoogland.

Could you initiate for more reviews; or anything i can do?

Thx


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Remodeling of Nuage VSP Plugin + CLOUDSTA...

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1494#issuecomment-220577391
  
@KrisSterckx yes you can; For instance ping @swill, @rhtyd, @koushik-das, 
@remibergsma, @abhinandanprateek, @rafaelweingartner @GabrielBrascher any 
reviews?
@swill I think a retest is in order. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add channel to Instances...

2016-05-20 Thread wido

Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/1545#issuecomment-220579267
  
@swill I have pushed the new version of the commits

@rhtyd @DaanHoogland Thanks for your review and feedback. Should be good 
now I think.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Convert patchviasocket to python (removes...

2016-05-20 Thread wido

Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/1533#issuecomment-220583491
  
Thanks! code-wise this looks good to me now


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: SystemVM cleanups

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1414


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9377: Fix metrics pagesize iss...

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1540


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: dynamic-roles: packaging improvements

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1551


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9366: Capacity of one zone-wid...

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1516


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1403


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9365 : updateVirtualMachine wi...

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1523


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1518#issuecomment-220594320
  


### CI RESULTS

```
Tests Run: 83
  Skipped: 0
   Failed: 0
   Errors: 2
 Duration: 8h 53m 51s
```

**Summary of the problem(s):**
```
ERROR: test suite for 
--
Traceback (most recent call last):
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
209, in run
self.setUp()
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
292, in setUp
self.setupContext(ancestor)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
315, in setupContext
try_run(context, names)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, 
in try_run
return func()
  File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", 
line 293, in setUpClass
cls.template.download(cls.apiclient)
  File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1350, in 
download
elif 'Downloaded' in template.status:
TypeError: argument of type 'NoneType' is not iterable
--
Additional details in: /tmp/MarvinLogs/test_network_WU9CS8/results.txt
```

```
ERROR: test suite for 
--
Traceback (most recent call last):
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
209, in run
self.setUp()
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
292, in setUp
self.setupContext(ancestor)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
315, in setupContext
try_run(context, names)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, 
in try_run
return func()
  File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", 
line 472, in setUpClass
cls.template.download(cls.apiclient)
  File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1350, in 
download
elif 'Downloaded' in template.status:
TypeError: argument of type 'NoneType' is not iterable
--
Additional details in: /tmp/MarvinLogs/test_network_WU9CS8/results.txt
```



**Associated Uploads**

**`/tmp/MarvinLogs/DeployDataCenter__May_19_2016_22_26_12_OT4DJY:`**
* 
[dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1518/tmp/MarvinLogs/DeployDataCenter__May_19_2016_22_26_12_OT4DJY/dc_entries.obj)
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1518/tmp/MarvinLogs/DeployDataCenter__May_19_2016_22_26_12_OT4DJY/failed_plus_exceptions.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1518/tmp/MarvinLogs/DeployDataCenter__May_19_2016_22_26_12_OT4DJY/runinfo.txt)

**`/tmp/MarvinLogs/test_network_WU9CS8:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1518/tmp/MarvinLogs/test_network_WU9CS8/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1518/tmp/MarvinLogs/test_network_WU9CS8/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1518/tmp/MarvinLogs/test_network_WU9CS8/runinfo.txt)

**`/tmp/MarvinLogs/test_vpc_routers_U00WPJ:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1518/tmp/MarvinLogs/test_vpc_routers_U00WPJ/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1518/tmp/MarvinLogs/test_vpc_routers_U00WPJ/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1518/tmp/MarvinLogs/test_vpc_routers_U00WPJ/runinfo.txt)


Uploads will be available until `2016-07-20 02:00:00 +0200 CEST`

*Comment created by [`upr comment`](https://github.com/cloudops/upr).*



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1518#issuecomment-220595138
  
This is a passing CI now.  @koushik-das do you have anything outstanding 
with this PR?

@nvazquez can you close and reopen or do a force push to kick off a Jenkins 
run to see if we can get this green?  Thanks for the work on this to get it 
ready...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1511#issuecomment-220595610
  


### CI RESULTS

```
Tests Run: 85
  Skipped: 0
   Failed: 2
   Errors: 0
 Duration: 4h 21m 39s
```

**Summary of the problem(s):**
```
FAIL: test_02_vpc_privategw_static_routes 
(integration.smoke.test_privategw_acl.TestPrivateGwACL)
--
Traceback (most recent call last):
  File 
"/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 
262, in test_02_vpc_privategw_static_routes
self.performVPCTests(vpc_off)
  File 
"/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 
345, in performVPCTests
self.check_pvt_gw_connectivity(vm1, public_ip_1, [vm2.nic[0].ipaddress, 
vm1.nic[0].ipaddress])
  File 
"/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 
704, in check_pvt_gw_connectivity
"Ping to VM on Network Tier N from VM in Network Tier A should be 
successful at least for 2 out of 3 VMs"
AssertionError: Ping to VM on Network Tier N from VM in Network Tier A 
should be successful at least for 2 out of 3 VMs
--
Additional details in: /tmp/MarvinLogs/test_network_TNYPXD/results.txt
```

```
FAIL: test_03_vpc_privategw_restart_vpc_cleanup 
(integration.smoke.test_privategw_acl.TestPrivateGwACL)
--
Traceback (most recent call last):
  File 
"/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 
274, in test_03_vpc_privategw_restart_vpc_cleanup
self.performVPCTests(vpc_off, restart_with_cleanup = True)
  File 
"/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 
351, in performVPCTests
self.check_pvt_gw_connectivity(vm1, public_ip_1, [vm2.nic[0].ipaddress, 
vm1.nic[0].ipaddress])
  File 
"/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 
704, in check_pvt_gw_connectivity
"Ping to VM on Network Tier N from VM in Network Tier A should be 
successful at least for 2 out of 3 VMs"
AssertionError: Ping to VM on Network Tier N from VM in Network Tier A 
should be successful at least for 2 out of 3 VMs
--
Additional details in: /tmp/MarvinLogs/test_network_TNYPXD/results.txt
```



**Associated Uploads**

**`/tmp/MarvinLogs/DeployDataCenter__May_20_2016_05_58_53_JUS630:`**
* 
[dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1511/tmp/MarvinLogs/DeployDataCenter__May_20_2016_05_58_53_JUS630/dc_entries.obj)
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1511/tmp/MarvinLogs/DeployDataCenter__May_20_2016_05_58_53_JUS630/failed_plus_exceptions.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1511/tmp/MarvinLogs/DeployDataCenter__May_20_2016_05_58_53_JUS630/runinfo.txt)

**`/tmp/MarvinLogs/test_network_TNYPXD:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1511/tmp/MarvinLogs/test_network_TNYPXD/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1511/tmp/MarvinLogs/test_network_TNYPXD/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1511/tmp/MarvinLogs/test_network_TNYPXD/runinfo.txt)

**`/tmp/MarvinLogs/test_vpc_routers_3HBG8V:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1511/tmp/MarvinLogs/test_vpc_routers_3HBG8V/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1511/tmp/MarvinLogs/test_vpc_routers_3HBG8V/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1511/tmp/MarvinLogs/test_vpc_routers_3HBG8V/runinfo.txt)


Uploads will be available until `2016-07-20 02:00:00 +0200 CEST`

*Comment created by [`upr comment`](https://github.com/cloudops/upr).*



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Add Java Default Certificat Authorities i...

2016-05-20 Thread milamberspace

GitHub user milamberspace opened a pull request:

https://github.com/apache/cloudstack/pull/1555

Add Java Default Certificat Authorities into the keystore if using a custom 
cert SSL



Related to CLOUDSTACK-1475

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/milamberspace/cloudstack Improve-CS-1475

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1555.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1555


commit a543b4ac5b2a86828a0106bf3c0b734593b59d4d
Author: Milamber 
Date:   2016-05-20T08:20:12Z

Add Java Default Certificat Authorities into the keystore if using a custom 
cert SSL
Related to CLOUDSTACK-1475




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1511#issuecomment-220595800
  
Im not sure what to think of those failures.  I will run again in  clean 
setup to see if I can get rid of those.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Remodeling of Nuage VSP Plugin + CLOUDSTA...

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1494#issuecomment-220595991
  


### CI RESULTS

```
Tests Run: 85
  Skipped: 0
   Failed: 2
   Errors: 0
 Duration: 4h 12m 50s
```

**Summary of the problem(s):**
```
FAIL: Test redundant router internals
--
Traceback (most recent call last):
  File 
"/data/git/cs2/cloudstack/test/integration/smoke/test_routers_network_ops.py", 
line 290, in test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true
"Attempt to retrieve google.com index page should be successful!"
AssertionError: Attempt to retrieve google.com index page should be 
successful!
--
Additional details in: /tmp/MarvinLogs/test_network_POMB5W/results.txt
```

```
FAIL: test_03_vpc_privategw_restart_vpc_cleanup 
(integration.smoke.test_privategw_acl.TestPrivateGwACL)
--
Traceback (most recent call last):
  File 
"/data/git/cs2/cloudstack/test/integration/smoke/test_privategw_acl.py", line 
274, in test_03_vpc_privategw_restart_vpc_cleanup
self.performVPCTests(vpc_off, restart_with_cleanup = True)
  File 
"/data/git/cs2/cloudstack/test/integration/smoke/test_privategw_acl.py", line 
345, in performVPCTests
self.check_pvt_gw_connectivity(vm1, public_ip_1, [vm2.nic[0].ipaddress, 
vm1.nic[0].ipaddress])
  File 
"/data/git/cs2/cloudstack/test/integration/smoke/test_privategw_acl.py", line 
704, in check_pvt_gw_connectivity
"Ping to VM on Network Tier N from VM in Network Tier A should be 
successful at least for 2 out of 3 VMs"
AssertionError: Ping to VM on Network Tier N from VM in Network Tier A 
should be successful at least for 2 out of 3 VMs
--
Additional details in: /tmp/MarvinLogs/test_network_POMB5W/results.txt
```



**Associated Uploads**

**`/tmp/MarvinLogs/DeployDataCenter__May_20_2016_06_02_00_W35KQN:`**
* 
[dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1494/tmp/MarvinLogs/DeployDataCenter__May_20_2016_06_02_00_W35KQN/dc_entries.obj)
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1494/tmp/MarvinLogs/DeployDataCenter__May_20_2016_06_02_00_W35KQN/failed_plus_exceptions.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1494/tmp/MarvinLogs/DeployDataCenter__May_20_2016_06_02_00_W35KQN/runinfo.txt)

**`/tmp/MarvinLogs/test_network_POMB5W:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1494/tmp/MarvinLogs/test_network_POMB5W/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1494/tmp/MarvinLogs/test_network_POMB5W/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1494/tmp/MarvinLogs/test_network_POMB5W/runinfo.txt)

**`/tmp/MarvinLogs/test_vpc_routers_R6I8VX:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1494/tmp/MarvinLogs/test_vpc_routers_R6I8VX/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1494/tmp/MarvinLogs/test_vpc_routers_R6I8VX/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1494/tmp/MarvinLogs/test_vpc_routers_R6I8VX/runinfo.txt)


Uploads will be available until `2016-07-20 02:00:00 +0200 CEST`

*Comment created by [`upr comment`](https://github.com/cloudops/upr).*



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Remodeling of Nuage VSP Plugin + CLOUDSTA...

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1494#issuecomment-220596270
  
I am getting similar errors in other PRs, so I don't think they are related 
to this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add channel to Instances...

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1545#issuecomment-220599638
  
LGTM, do we retest @swill?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Explicitely load JDBC driver before creat...

2016-05-20 Thread nlivens

Github user nlivens commented on the pull request:

https://github.com/apache/cloudstack/pull/1553#issuecomment-220599141
  
@DaanHoogland, triggering you for review as well, this is only a small code 
change


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Explicitely load JDBC driver before creat...

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1553#discussion_r64040574
  
--- Diff: framework/db/src/com/cloud/utils/db/TransactionLegacy.java ---
@@ -1014,6 +1014,13 @@ public static void initDataSource(Properties 
dbProps) {
 if (dbProps.size() == 0)
 return;
 
+try {
+// Explicitely load JDBC driver because it has been 
removed from the classpath as part of commit 
c22659d76d73f00f41c13776c490e17a50aacd20
+Class.forName("com.mysql.jdbc.Driver");
--- End diff --

two questions:
hardcoded driver name?; now that we can shouldn't we prepare for a MariaDB 
driver to be loaded instead?
if it is not on the classpath how is this going to help, then? 
Class.forName(..) will search the classpath


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...

2016-05-20 Thread nvazquez

Github user nvazquez commented on the pull request:

https://github.com/apache/cloudstack/pull/1518#issuecomment-220608044
  
Thanks @swill @koushik-das! Sorry I was missing a license header, I pushed 
it now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...

2016-05-20 Thread nvazquez

Github user nvazquez commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1518#discussion_r64042208
  
--- Diff: 
engine/storage/src/org/apache/cloudstack/storage/image/NfsImageStoreDriverImpl.java
 ---
@@ -0,0 +1,30 @@
+package org.apache.cloudstack.storage.image;
--- End diff --

Done, thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Refactoring CitrixResourceBase

2016-05-20 Thread Syed Mushtaq

Thanks guys for the Ideas. I will open a JIRA ticket and start working on
it.

-Syed


On Thu, May 19, 2016 at 7:57 PM, Rafael Weingärtner <
rafaelweingart...@gmail.com> wrote:

> Hi Syed,
> That is a great idea; however, it is a very hard task.
> The idea of Tim is great; actually, we already have some sort of hierarchy
> that is used in “CitrixResourceBase.java”.
> I would suggest you first removing the unused code, unused variable, and
> duplicate methods; that would be one PR. You can use a tool called
> UCdetector to find unused code. To find duplicated code you can use PMD.
>
> One very good example of code duplicity are the methods called
>
> “com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.callHostPluginAsync(…)”.
>
> After you have cleaned the class, I suggest you analyzing where each
> remaining method is used and then look for the proper place to put them.
> It might be a good idea on separating between singletons that are
> responsible for well-defined tasks such as managing storage, networking,
> VMs creating and deletion, VMs monitoring and others.
>
> If you need any help, please do not hesitate on asking for our help.
>
>
> On Thu, May 19, 2016 at 4:50 PM, Daan Hoogland 
> wrote:
>
> > Syed,
> >
> > gogogo. actually it has shrunk to 5k lines since 2012 ;)
> >
> > I like your initiative and initial direction. A lot of small steps to
> > improve the blob have been taken and I would sugest to keep going in
> small
> > steps.
> >
> > On Thu, May 19, 2016 at 9:44 PM, Tim Mackey  wrote:
> >
> > > +1
> > >
> > > When I went through this last time, not only was it hard to understand
> > the
> > > flows, but the XenServer version management was a pain. Would suggest
> > > creating a base class which always works (i.e. is independent of
> > XenServer
> > > version) for core functions. Then add in that which exists for a
> specific
> > > version. Should help greatly with testing IMO.
> > >
> > > -tim
> > >
> > > On Thu, May 19, 2016 at 2:37 PM, Syed Mushtaq  >
> > > wrote:
> > >
> > > > Hi All,
> > > >
> > > > I would like to refactor CitrixResourceBase class which is
> responsible
> > > for
> > > > communicating with Xenserver. It has grown too long (>5K lines) and
> has
> > > > absolutely no testing.
> > > >
> > > > In my first pass I want to separate out the functionality buy the
> > > subsystem
> > > > it targets (compute, storage, network etc) and will go on from there.
> > > What
> > > > do you think? Is anyone working on this currently?
> > > >
> > > > Thanks,
> > > > -Syed
> > > >
> > >
> >
> >
> >
> > --
> > Daan
> >
>
>
>
> --
> Rafael Weingärtner
>

[GitHub] cloudstack pull request: Add Java Default Certificat Authorities i...

2016-05-20 Thread footplus

Github user footplus commented on the pull request:

https://github.com/apache/cloudstack/pull/1555#issuecomment-220615734
  
LGTM :) It seems to work correctly on my 4.8.0 setup.

Thanks.

Best regards,
AurÃ©lien


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...

Github user koushik-das commented on the pull request:

https://github.com/apache/cloudstack/pull/1518#issuecomment-220615109
  
@swill nothing outstanding on this


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1518#issuecomment-220619741
  
For some reason Travis is unhappy.  Would you mind trying again.  Sorry for 
the inconvenience...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add channel to Instances...

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1545#issuecomment-220621430
  
@DaanHoogland yes, I will retest now.  Thanks guys...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Remodeling of Nuage VSP Plugin + CLOUDSTA...

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1494#issuecomment-220622074
  
Can I get some code review on this one.  It is looking to be in pretty good 
shape otherwise.  Thanks...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1511#issuecomment-220624878
  
I have seen similar issues in a couple other PRs.  Since this is a PR 
related to connectivity, I do want to try to get a cleaner CI run if I can.  
Also, travis is failing which concerns me a bit...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

RE: [Discuss] CloudStack documentation

2016-05-20 Thread Rajsekhar K

Hi, All,

I agree with Dag Sonstebo that we need to improve the layout and navigation of 
CloudStack documentation. I think that the improvement should begin from the 
home page.

New users may not find the way the information presented on the home page very 
intuitive. A few tweaking on the home page will help us improve the information 
experience of CloudStack users.

Here are my thoughts on improving CloudStack documentation:

•   Our users - mostly experienced administrators- would install CloudStack 
and understand the basic concepts, deployment architecture, and terminologies 
first. After doing this, they would be delighted to see the big picture of the 
tasks that they can do with CloudStack.

  So, a home page for CloudStack documentation that displays the big 
picture of the tasks that the users can do with CloudStack will be appreciated. 
We can display the big picture of the tasks in distinct content blocks on the 
Home page. Each block will have a link to the documentation and a brief 
description of the major task. Users will click the link to the documentation 
to land on the page for that major task. They can, now, see the ToC for the 
major ask. This ToC will delineate the flow of minor (sub) tasks that 
constitute the major task.

•   It is useful if we can incorporate videos and lectures on the Home 
page. Professionally made videos will be very helpful to the users.

•   I think we need to think beyond 'guides' (such as Installation Guide, 
Administration Guide, and so on) when we present the information online. 
CloudStack users would be delighted to see a topic that directly answers the 
question in their mind (such as 'Configuring a XenServer host with CloudStack') 
than logically locating a help topic by navigating to a guide first, then to a 
section in the guide and then locating the information. They would be able to 
access and read the documentation in non-linear manner.

•   Let's ensure that the information on upgrading CloudStack is available 
distinctly on the Home page. This will help avoid directing the users, who want 
to upgrade to the next CloudStack version, to the Installation section. 
Installation section can cater to the users who want to install CloudStack in 
their environment.

•   I think the home page should highlight the link to API reference pages. 
Also, I feel that we must improve CloudStack API reference pages by 
incorporating more useful information to each page.
  Based on the discussions that we had in the community sometime back, I 
have created a specification document and a template for API references at: 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Improving+CloudStack+API+References+-+Specifications

•   We can consolidate all matrixes at one location. Along with 
compatibility matrix, we need to identify information that we can present as 
matrix. The users should be able to access all these information from the 
documentation home page.

•   I would like to mention the effort that we have started on creating a 
reference book for the CloudStack configuration parameters. I hope, this will 
enhance the information experience of CloudStack users by educating them about 
the parameters that they can use for configuring CloudStack. I have published 
some initial information in the following cwiki pages and am awaiting 
thoughts/reviews from the community members:
o   Apache CloudStack Configuration Parameters Reference Guide - Tasks and 
Status - 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Apache+CloudStack+Configuration+Parameters+Reference+Guide+-+Tasks+and+Status
o   Configuration Parameters in Apache CloudStack - Categorization - 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Configuration+Parameters+in+Apache+CloudStack+-+Categorization
o   direct.agent.load.size (sample topic) - 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/direct.agent.load.size

Also, I think it is a good idea to educate the contributors about 
creating/updating the CloudStack documentation using reStructured Text. I am 
facing an issue on this. I want to update some information in the Install 
Guide, but I could not find guidelines on locating the correct files that I 
need to update. Clear instruction on this will be helpful.

I will discuss these points with my colleague Sowmya Krishnan, who will be 
attending the CloudStack conference at Montreal.

Regards,
Rajsekhar K
Senior Product Engineer | Accelerite, Bangalore
Email: rajsekha...@accelerite.com

-Original Message-
From: Ron Wheeler [mailto:rwhee...@artifact-software.com]
Sent: Thursday, May 19, 2016 6:17 PM
To: dev@cloudstack.apache.org
Subject: Re: [Discuss] CloudStack documentation

Identify where most issues are raised in the ML and fix the docs to reduce the 
confusion.
I suspect that Networking is the source of most problems but perhaps other have 
a better sense of this.

Ron

[GitHub] cloudstack pull request: dynamic-roles: packaging improvements

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1551#issuecomment-220626559
  
@rhtyd thank you.  I will review what happened there.  This is something 
that has started showing up intermittently, but only started happening in the 
last few weeks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9180: Optimize concurrent VM d...

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1251#issuecomment-220627549
  
Thanks @koushik-das, I need to track down what changed to cause that 
intermittent problem of the `template.status`.  I need some code review on this 
one.  Thanks...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9348: NioConnection improvemen...

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1549#issuecomment-220627907
  


### CI RESULTS

```
Tests Run: 83
  Skipped: 0
   Failed: 0
   Errors: 2
 Duration: 8h 27m 27s
```

**Summary of the problem(s):**
```
ERROR: test suite for 
--
Traceback (most recent call last):
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
209, in run
self.setUp()
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
292, in setUp
self.setupContext(ancestor)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
315, in setupContext
try_run(context, names)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, 
in try_run
return func()
  File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", 
line 293, in setUpClass
cls.template.download(cls.apiclient)
  File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1350, in 
download
elif 'Downloaded' in template.status:
TypeError: argument of type 'NoneType' is not iterable
--
Additional details in: /tmp/MarvinLogs/test_network_AVQ8UF/results.txt
```

```
ERROR: test suite for 
--
Traceback (most recent call last):
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
209, in run
self.setUp()
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
292, in setUp
self.setupContext(ancestor)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
315, in setupContext
try_run(context, names)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, 
in try_run
return func()
  File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", 
line 472, in setUpClass
cls.template.download(cls.apiclient)
  File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1350, in 
download
elif 'Downloaded' in template.status:
TypeError: argument of type 'NoneType' is not iterable
--
Additional details in: /tmp/MarvinLogs/test_network_AVQ8UF/results.txt
```



**Associated Uploads**

**`/tmp/MarvinLogs/DeployDataCenter__May_20_2016_06_41_21_MDBMOC:`**
* 
[dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1549/tmp/MarvinLogs/DeployDataCenter__May_20_2016_06_41_21_MDBMOC/dc_entries.obj)
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1549/tmp/MarvinLogs/DeployDataCenter__May_20_2016_06_41_21_MDBMOC/failed_plus_exceptions.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1549/tmp/MarvinLogs/DeployDataCenter__May_20_2016_06_41_21_MDBMOC/runinfo.txt)

**`/tmp/MarvinLogs/test_network_AVQ8UF:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1549/tmp/MarvinLogs/test_network_AVQ8UF/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1549/tmp/MarvinLogs/test_network_AVQ8UF/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1549/tmp/MarvinLogs/test_network_AVQ8UF/runinfo.txt)

**`/tmp/MarvinLogs/test_vpc_routers_JFF9WZ:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1549/tmp/MarvinLogs/test_vpc_routers_JFF9WZ/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1549/tmp/MarvinLogs/test_vpc_routers_JFF9WZ/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1549/tmp/MarvinLogs/test_vpc_routers_JFF9WZ/runinfo.txt)


Uploads will be available until `2016-07-20 02:00:00 +0200 CEST`

*Comment created by [`upr comment`](https://github.com/cloudops/upr).*



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9348: NioConnection improvemen...

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1549#issuecomment-220628087
  
Two clean runs in a row.  I think this one is ready to put back in now...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9348: NioConnection improvemen...

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1549#issuecomment-220628402
  
BTW, thank you for your quick response time to work through issues on your 
PRs and get things stabilized.  I really do appreciate it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9180: Optimize concurrent VM d...

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1251#issuecomment-220628656
  


### CI RESULTS

```
Tests Run: 82
  Skipped: 0
   Failed: 0
   Errors: 4
 Duration: 8h 31m 38s
```

**Summary of the problem(s):**
```
ERROR: test suite for 
--
Traceback (most recent call last):
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
228, in run
self.tearDown()
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
351, in tearDown
self.teardownContext(ancestor)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
367, in teardownContext
try_run(context, names)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, 
in try_run
return func()
  File 
"/data/git/cs1/cloudstack/test/integration/smoke/test_internal_lb.py", line 
847, in tearDownClass
raise Exception("Cleanup failed with %s" % e)
Exception: Cleanup failed with Job failed: {jobprocstatus : 0, created : 
u'2016-05-20T11:25:42+0200', jobresult : {errorcode : 530, errortext : u'Failed 
to delete template'}, cmd : 
u'org.apache.cloudstack.api.command.user.template.DeleteTemplateCmd', userid : 
u'e34c6f59-1e44-11e6-9276-5254001daa61', jobstatus : 2, jobid : 
u'88b5638b-7732-4e6d-9ccf-9a3be346b281', jobresultcode : 530, jobinstanceid : 
u'3cd24df8-bd13-4250-8706-a43e9e42c754', jobresulttype : u'object', 
jobinstancetype : u'Template', accountid : 
u'e34c5a5a-1e44-11e6-9276-5254001daa61'}
--
Additional details in: /tmp/MarvinLogs/test_network_GHIWU7/results.txt
```

```
ERROR: test suite for 
--
Traceback (most recent call last):
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
209, in run
self.setUp()
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
292, in setUp
self.setupContext(ancestor)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
315, in setupContext
try_run(context, names)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, 
in try_run
return func()
  File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", 
line 835, in setUpClass
cls.template.download(cls.apiclient)
  File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1350, in 
download
elif 'Downloaded' in template.status:
TypeError: argument of type 'NoneType' is not iterable
--
Additional details in: /tmp/MarvinLogs/test_network_GHIWU7/results.txt
```

```
ERROR: test suite for 
--
Traceback (most recent call last):
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
209, in run
self.setUp()
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
292, in setUp
self.setupContext(ancestor)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
315, in setupContext
try_run(context, names)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, 
in try_run
return func()
  File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", 
line 293, in setUpClass
cls.template.download(cls.apiclient)
  File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1350, in 
download
elif 'Downloaded' in template.status:
TypeError: argument of type 'NoneType' is not iterable
--
Additional details in: /tmp/MarvinLogs/test_network_GHIWU7/results.txt
```

```
ERROR: test suite for 
--
Traceback (most recent call last):
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
209, in run
self.setUp()
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
292, in setUp
self.setupContext(ancestor)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
315, in setupContext
try_run(context, names)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, 
in try_run
return func()
  File "/data/git/cs1/cloudstack/test/integration/smo

[GitHub] cloudstack pull request: CLOUDSTACK-9180: Optimize concurrent VM d...

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1251#issuecomment-220628965
  
Similar issues on this run.  They are not related to this PR.  Still need 
some review on this one...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1514#issuecomment-220629958
  
This one is coming back clean.  If we can get Jenkins and Travis green I 
think this one is ready...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1514#issuecomment-220629640
  


### CI RESULTS

```
Tests Run: 85
  Skipped: 0
   Failed: 0
   Errors: 0
 Duration: 8h 44m 23s
```



**Associated Uploads**

**`/tmp/MarvinLogs/DeployDataCenter__May_20_2016_06_52_13_R81P2X:`**
* 
[dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1514/tmp/MarvinLogs/DeployDataCenter__May_20_2016_06_52_13_R81P2X/dc_entries.obj)
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1514/tmp/MarvinLogs/DeployDataCenter__May_20_2016_06_52_13_R81P2X/failed_plus_exceptions.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1514/tmp/MarvinLogs/DeployDataCenter__May_20_2016_06_52_13_R81P2X/runinfo.txt)

**`/tmp/MarvinLogs/test_network_YQPLQU:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1514/tmp/MarvinLogs/test_network_YQPLQU/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1514/tmp/MarvinLogs/test_network_YQPLQU/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1514/tmp/MarvinLogs/test_network_YQPLQU/runinfo.txt)

**`/tmp/MarvinLogs/test_vpc_routers_WA26EB:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1514/tmp/MarvinLogs/test_vpc_routers_WA26EB/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1514/tmp/MarvinLogs/test_vpc_routers_WA26EB/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1514/tmp/MarvinLogs/test_vpc_routers_WA26EB/runinfo.txt)


Uploads will be available until `2016-07-20 02:00:00 +0200 CEST`

*Comment created by [`upr comment`](https://github.com/cloudops/upr).*



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9289:Automation for feature de...

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1417#issuecomment-220631924
  
Ok, thanks @nitt10prashant.  ð 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9377: Fix metrics pagesize iss...

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1540#issuecomment-220632778
  
Ya, sorry, I had a backlog of commits that were ready while I sorted out 
some merge conflicts doing a forward merge from 4.8 and then testing the 
resulting master to make sure nothing was broken.  I got a bunch of PRs merged 
in this morning.  Thanks for the patience.  :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Convert patchviasocket to python (removes...

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1533#issuecomment-220633650
  
@sverrirab thank you.  Would you mind adding the revert of #1495 into this 
commit in order to clean up unnecessary packages once this PR is accepted?  I 
think we are missing one code review on this one and it is pretty much ready to 
go.  Thanks...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9348: NioConnection improvemen...

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1549


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Variable renaming in classes meant for Agents

Hi guys,
I agree with Daan that if class fields have improper (not descriptive or
not suitable) names we should change them. However, I do not find the
change (on variable names) introduced by PR #816 good. It added an
“_”(underline) before variable names; even though Apache CloudStack has a
lot of that currently, I think that is a pattern we should avoid.

Your ideas to use annotations to avoid relying on variable names are great;
but, let’s not re-create the well here. There is a research [1] that has
been conducted in 2014 that tackled exactly that problem; the proposal
presented in [1] decoupled client and server sides from variable name by
using semantic annotations. The concept, the formalization and the
experiments are all presented in paper [1]. The serialization and
deserialization core of the proposal presented in [1] can be found in [2].

The idea of decoupling our web APIs from variable names is great, but it is
something that will require some effort to be fully and properly
implemented. If you wish to push that forward count on me.

[1] http://ieeexplore.ieee.org/xpls/abs_all.jsp?arnumber=6928953&tag=1
[2] https://github.com/ivansalvadori/gsonld


On Fri, May 20, 2016 at 3:30 AM, Daan Hoogland 
wrote:

> Guys, we should rename fields that have improper names. I do not agreee
> with the statement at all. Your two solutions to the serialisation hazard
> are both acceptable to me. leaving a non compliant or non explanatory name
> in because it slipped through the nets at some points does not seem
> acceptable to me. We must improve are code.
>
> On Fri, May 20, 2016 at 6:53 AM, Tutkowski, Mike <
> mike.tutkow...@netapp.com>
> wrote:
>
> > Thanks for sending out this e-mail, Anshul.
> >
> > This is a bit of a strange situation because we need to make sure people
> > are either aware of the fact that properties in Command classes are
> > serialized (and not change existing variable names) or come up with a
> less
> > fragile way of choosing property names when sending data (perhaps using
> > annotations).
> >
> > At the very least, we should have comments in these classes indicating
> the
> > dangers of changing property names. It might also be beneficial to have
> > unit tests in place that expect certain variable names and assert if they
> > are not as expected.
> >
> > In the meanwhile, I plan to change the variable names back that were
> > changed in PR #816.
> >
> > Additional thoughts on how this should be addressed long term?
> >
> > Thanks!
> > Mike
> > 
> > From: Anshul Gangwar 
> > Sent: Thursday, May 19, 2016 10:47 PM
> > To: dev@cloudstack.apache.org
> > Subject: Variable renaming in classes meant for Agents
> >
> > Hi,
> >
> > We should not allow renaming of variables in classes which ends with
> > Command and TO. As these objects are meant to be consumed by Agents.
> >
> > Agents may not be written in java so relying on these variable names to
> > get the info. One such example is Hyper-V agent.
> >
> > Hyper-V support is currently broken as there are some variables renamed
> in
> > PR https://github.com/apache/cloudstack/pull/816.
> >
> > Regards,
> > Anshul
> >
> >
> >
> >
> >
> >
> > DISCLAIMER
> > ==
> > This e-mail may contain privileged and confidential information which is
> > the property of Accelerite, a Persistent Systems business. It is intended
> > only for the use of the individual or entity to which it is addressed. If
> > you are not the intended recipient, you are not authorized to read,
> retain,
> > copy, print, distribute or use this message. If you have received this
> > communication in error, please notify the sender and delete all copies of
> > this message. Accelerite, a Persistent Systems business does not accept
> any
> > liability for virus infected mails.
> >
>
>
>
> --
> Daan
>



-- 
Rafael Weingärtner

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1511#issuecomment-220637398
  
@swill please see my comment above about the travis failures. BTW why is 
there sometimes two travis runs (pr and push) and sometimes only one?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Variable renaming in classes meant for Agents

It might be a total pipe dream, but if the API was also Swagger compliant,
it would simplify our API documentation and would make API tooling much
easier.  I have not looked into what would be required, but it would
definitely be a nice to have.  :)

*Will STEVENS*
Lead Developer

*CloudOps* *| *Cloud Solutions Experts
420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
w cloudops.com *|* tw @CloudOps_

On Fri, May 20, 2016 at 11:12 AM, Rafael Weingärtner <
rafaelweingart...@gmail.com> wrote:

> Hi guys,
> I agree with Daan that if class fields have improper (not descriptive or
> not suitable) names we should change them. However, I do not find the
> change (on variable names) introduced by PR #816 good. It added an
> “_”(underline) before variable names; even though Apache CloudStack has a
> lot of that currently, I think that is a pattern we should avoid.
>
> Your ideas to use annotations to avoid relying on variable names are great;
> but, let’s not re-create the well here. There is a research [1] that has
> been conducted in 2014 that tackled exactly that problem; the proposal
> presented in [1] decoupled client and server sides from variable name by
> using semantic annotations. The concept, the formalization and the
> experiments are all presented in paper [1]. The serialization and
> deserialization core of the proposal presented in [1] can be found in [2].
>
> The idea of decoupling our web APIs from variable names is great, but it is
> something that will require some effort to be fully and properly
> implemented. If you wish to push that forward count on me.
>
> [1] http://ieeexplore.ieee.org/xpls/abs_all.jsp?arnumber=6928953&tag=1
> [2] https://github.com/ivansalvadori/gsonld
>
>
> On Fri, May 20, 2016 at 3:30 AM, Daan Hoogland 
> wrote:
>
> > Guys, we should rename fields that have improper names. I do not agreee
> > with the statement at all. Your two solutions to the serialisation hazard
> > are both acceptable to me. leaving a non compliant or non explanatory
> name
> > in because it slipped through the nets at some points does not seem
> > acceptable to me. We must improve are code.
> >
> > On Fri, May 20, 2016 at 6:53 AM, Tutkowski, Mike <
> > mike.tutkow...@netapp.com>
> > wrote:
> >
> > > Thanks for sending out this e-mail, Anshul.
> > >
> > > This is a bit of a strange situation because we need to make sure
> people
> > > are either aware of the fact that properties in Command classes are
> > > serialized (and not change existing variable names) or come up with a
> > less
> > > fragile way of choosing property names when sending data (perhaps using
> > > annotations).
> > >
> > > At the very least, we should have comments in these classes indicating
> > the
> > > dangers of changing property names. It might also be beneficial to have
> > > unit tests in place that expect certain variable names and assert if
> they
> > > are not as expected.
> > >
> > > In the meanwhile, I plan to change the variable names back that were
> > > changed in PR #816.
> > >
> > > Additional thoughts on how this should be addressed long term?
> > >
> > > Thanks!
> > > Mike
> > > 
> > > From: Anshul Gangwar 
> > > Sent: Thursday, May 19, 2016 10:47 PM
> > > To: dev@cloudstack.apache.org
> > > Subject: Variable renaming in classes meant for Agents
> > >
> > > Hi,
> > >
> > > We should not allow renaming of variables in classes which ends with
> > > Command and TO. As these objects are meant to be consumed by Agents.
> > >
> > > Agents may not be written in java so relying on these variable names to
> > > get the info. One such example is Hyper-V agent.
> > >
> > > Hyper-V support is currently broken as there are some variables renamed
> > in
> > > PR https://github.com/apache/cloudstack/pull/816.
> > >
> > > Regards,
> > > Anshul
> > >
> > >
> > >
> > >
> > >
> > >
> > > DISCLAIMER
> > > ==
> > > This e-mail may contain privileged and confidential information which
> is
> > > the property of Accelerite, a Persistent Systems business. It is
> intended
> > > only for the use of the individual or entity to which it is addressed.
> If
> > > you are not the intended recipient, you are not authorized to read,
> > retain,
> > > copy, print, distribute or use this message. If you have received this
> > > communication in error, please notify the sender and delete all copies
> of
> > > this message. Accelerite, a Persistent Systems business does not accept
> > any
> > > liability for virus infected mails.
> > >
> >
> >
> >
> > --
> > Daan
> >
>
>
>
> --
> Rafael Weingärtner
>

Re: Variable renaming in classes meant for Agents

Rafael [2] is a members only link (pornographia academia?)

On Fri, May 20, 2016 at 5:12 PM, Rafael Weingärtner <
rafaelweingart...@gmail.com> wrote:

> Hi guys,
> I agree with Daan that if class fields have improper (not descriptive or
> not suitable) names we should change them. However, I do not find the
> change (on variable names) introduced by PR #816 good. It added an
> “_”(underline) before variable names; even though Apache CloudStack has a
> lot of that currently, I think that is a pattern we should avoid.
>
> Your ideas to use annotations to avoid relying on variable names are great;
> but, let’s not re-create the well here. There is a research [1] that has
> been conducted in 2014 that tackled exactly that problem; the proposal
> presented in [1] decoupled client and server sides from variable name by
> using semantic annotations. The concept, the formalization and the
> experiments are all presented in paper [1]. The serialization and
> deserialization core of the proposal presented in [1] can be found in [2].
>
> The idea of decoupling our web APIs from variable names is great, but it is
> something that will require some effort to be fully and properly
> implemented. If you wish to push that forward count on me.
>
> [1] http://ieeexplore.ieee.org/xpls/abs_all.jsp?arnumber=6928953&tag=1
> [2] https://github.com/ivansalvadori/gsonld
>
>
> On Fri, May 20, 2016 at 3:30 AM, Daan Hoogland 
> wrote:
>
> > Guys, we should rename fields that have improper names. I do not agreee
> > with the statement at all. Your two solutions to the serialisation hazard
> > are both acceptable to me. leaving a non compliant or non explanatory
> name
> > in because it slipped through the nets at some points does not seem
> > acceptable to me. We must improve are code.
> >
> > On Fri, May 20, 2016 at 6:53 AM, Tutkowski, Mike <
> > mike.tutkow...@netapp.com>
> > wrote:
> >
> > > Thanks for sending out this e-mail, Anshul.
> > >
> > > This is a bit of a strange situation because we need to make sure
> people
> > > are either aware of the fact that properties in Command classes are
> > > serialized (and not change existing variable names) or come up with a
> > less
> > > fragile way of choosing property names when sending data (perhaps using
> > > annotations).
> > >
> > > At the very least, we should have comments in these classes indicating
> > the
> > > dangers of changing property names. It might also be beneficial to have
> > > unit tests in place that expect certain variable names and assert if
> they
> > > are not as expected.
> > >
> > > In the meanwhile, I plan to change the variable names back that were
> > > changed in PR #816.
> > >
> > > Additional thoughts on how this should be addressed long term?
> > >
> > > Thanks!
> > > Mike
> > > 
> > > From: Anshul Gangwar 
> > > Sent: Thursday, May 19, 2016 10:47 PM
> > > To: dev@cloudstack.apache.org
> > > Subject: Variable renaming in classes meant for Agents
> > >
> > > Hi,
> > >
> > > We should not allow renaming of variables in classes which ends with
> > > Command and TO. As these objects are meant to be consumed by Agents.
> > >
> > > Agents may not be written in java so relying on these variable names to
> > > get the info. One such example is Hyper-V agent.
> > >
> > > Hyper-V support is currently broken as there are some variables renamed
> > in
> > > PR https://github.com/apache/cloudstack/pull/816.
> > >
> > > Regards,
> > > Anshul
> > >
> > >
> > >
> > >
> > >
> > >
> > > DISCLAIMER
> > > ==
> > > This e-mail may contain privileged and confidential information which
> is
> > > the property of Accelerite, a Persistent Systems business. It is
> intended
> > > only for the use of the individual or entity to which it is addressed.
> If
> > > you are not the intended recipient, you are not authorized to read,
> > retain,
> > > copy, print, distribute or use this message. If you have received this
> > > communication in error, please notify the sender and delete all copies
> of
> > > this message. Accelerite, a Persistent Systems business does not accept
> > any
> > > liability for virus infected mails.
> > >
> >
> >
> >
> > --
> > Daan
> >
>
>
>
> --
> Rafael Weingärtner
>



-- 
Daan

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1511#issuecomment-220640589
  
Ok.  Travis has been pretty consistently green for PRs recently, so I have 
not seen this problem elsewhere.  I am not sure why there are sometimes more 
than once Travis job.  @rhtyd may know the answers to these questions as he has 
spent more time with Travis than most of us.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Variable renaming in classes meant for Agents

Hahaha, do not get addicted to it Daan ;)

That is probably due to the environment I am living in right now. I am not
a member per se of the GsonLD project [2]; I have just used it in another
research/work.

So, there is this protocol called OpenID Connect, and one of the things we
did not like much about it was the hard binding between clients and servers
on variable names. We extended it (we used the MIT’s implementation) to use
the serialization and deserialization mechanism presented in [2];
therefore, we stopped relying on variable names and started using their
semantic “meanings”. This work has been accepted to be published at 12th
world congress on services (SERVICES), but we do not know if we will
publish giving the costs :(

Even if the work is not published, you can find the MITREid Connect version
that uses semantics annotation at our Github page [1*]. Projects [1*] and
[2] (GsonLD) do not have a nice and shiny page, but if you find it
interesting and would like to learn more, we can help you guys.


BTW: I have just glanced that the Swagger, and it seems very interesting
too.

[1*]  https://github.com/pedro-martins/OpenID-Connect-Java-Spring-Server


On Fri, May 20, 2016 at 12:36 PM, Daan Hoogland 
wrote:

> Rafael [2] is a members only link (pornographia academia?)
>
> On Fri, May 20, 2016 at 5:12 PM, Rafael Weingärtner <
> rafaelweingart...@gmail.com> wrote:
>
> > Hi guys,
> > I agree with Daan that if class fields have improper (not descriptive or
> > not suitable) names we should change them. However, I do not find the
> > change (on variable names) introduced by PR #816 good. It added an
> > “_”(underline) before variable names; even though Apache CloudStack has a
> > lot of that currently, I think that is a pattern we should avoid.
> >
> > Your ideas to use annotations to avoid relying on variable names are
> great;
> > but, let’s not re-create the well here. There is a research [1] that has
> > been conducted in 2014 that tackled exactly that problem; the proposal
> > presented in [1] decoupled client and server sides from variable name by
> > using semantic annotations. The concept, the formalization and the
> > experiments are all presented in paper [1]. The serialization and
> > deserialization core of the proposal presented in [1] can be found in
> [2].
> >
> > The idea of decoupling our web APIs from variable names is great, but it
> is
> > something that will require some effort to be fully and properly
> > implemented. If you wish to push that forward count on me.
> >
> > [1] http://ieeexplore.ieee.org/xpls/abs_all.jsp?arnumber=6928953&tag=1
> > [2] https://github.com/ivansalvadori/gsonld
> >
> >
> > On Fri, May 20, 2016 at 3:30 AM, Daan Hoogland 
> > wrote:
> >
> > > Guys, we should rename fields that have improper names. I do not agreee
> > > with the statement at all. Your two solutions to the serialisation
> hazard
> > > are both acceptable to me. leaving a non compliant or non explanatory
> > name
> > > in because it slipped through the nets at some points does not seem
> > > acceptable to me. We must improve are code.
> > >
> > > On Fri, May 20, 2016 at 6:53 AM, Tutkowski, Mike <
> > > mike.tutkow...@netapp.com>
> > > wrote:
> > >
> > > > Thanks for sending out this e-mail, Anshul.
> > > >
> > > > This is a bit of a strange situation because we need to make sure
> > people
> > > > are either aware of the fact that properties in Command classes are
> > > > serialized (and not change existing variable names) or come up with a
> > > less
> > > > fragile way of choosing property names when sending data (perhaps
> using
> > > > annotations).
> > > >
> > > > At the very least, we should have comments in these classes
> indicating
> > > the
> > > > dangers of changing property names. It might also be beneficial to
> have
> > > > unit tests in place that expect certain variable names and assert if
> > they
> > > > are not as expected.
> > > >
> > > > In the meanwhile, I plan to change the variable names back that were
> > > > changed in PR #816.
> > > >
> > > > Additional thoughts on how this should be addressed long term?
> > > >
> > > > Thanks!
> > > > Mike
> > > > 
> > > > From: Anshul Gangwar 
> > > > Sent: Thursday, May 19, 2016 10:47 PM
> > > > To: dev@cloudstack.apache.org
> > > > Subject: Variable renaming in classes meant for Agents
> > > >
> > > > Hi,
> > > >
> > > > We should not allow renaming of variables in classes which ends with
> > > > Command and TO. As these objects are meant to be consumed by Agents.
> > > >
> > > > Agents may not be written in java so relying on these variable names
> to
> > > > get the info. One such example is Hyper-V agent.
> > > >
> > > > Hyper-V support is currently broken as there are some variables
> renamed
> > > in
> > > > PR https://github.com/apache/cloudstack/pull/816.
> > > >
> > > > Regards,
> > > > Anshul
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > > DISCLAIMER
> > > > ==
>

[GitHub] cloudstack pull request: Convert patchviasocket to python (removes...

2016-05-20 Thread sverrirab

Github user sverrirab commented on the pull request:

https://github.com/apache/cloudstack/pull/1533#issuecomment-220644228
  
Rebased the PR to latest master and reverted the relevant commit 
(64b72a5c5a410f41bd869cc9d40807d888e05055.).  I think we should be good to go 
@swill ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...

2016-05-20 Thread serg38

Github user serg38 commented on the pull request:

https://github.com/apache/cloudstack/pull/1518#issuecomment-220652018
  
@swill Travis passed. Looks like it is ready to merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Variable renaming in classes meant for Agents

It sounds like most people don't like a preceding "_" for member variables and 
that is fine. Do we have any formal Java coding standards for CloudStack, by 
the way? I'm not aware of any.

The main problem here, though, is that this particular piece of code is super 
fragile, so it would be great to harden it up.

I'm going to open a PR and revert the names in those changed "Command" files 
for 4.9. That will solve the immediate problem.

From: Rafael Weingärtner 
Sent: Friday, May 20, 2016 9:12 AM
To: dev@cloudstack.apache.org
Subject: Re: Variable renaming in classes meant for Agents

Hi guys,
I agree with Daan that if class fields have improper (not descriptive or
not suitable) names we should change them. However, I do not find the
change (on variable names) introduced by PR #816 good. It added an
“_”(underline) before variable names; even though Apache CloudStack has a
lot of that currently, I think that is a pattern we should avoid.

Your ideas to use annotations to avoid relying on variable names are great;
but, let’s not re-create the well here. There is a research [1] that has
been conducted in 2014 that tackled exactly that problem; the proposal
presented in [1] decoupled client and server sides from variable name by
using semantic annotations. The concept, the formalization and the
experiments are all presented in paper [1]. The serialization and
deserialization core of the proposal presented in [1] can be found in [2].

The idea of decoupling our web APIs from variable names is great, but it is
something that will require some effort to be fully and properly
implemented. If you wish to push that forward count on me.

[1] http://ieeexplore.ieee.org/xpls/abs_all.jsp?arnumber=6928953&tag=1
[2] https://github.com/ivansalvadori/gsonld

On Fri, May 20, 2016 at 3:30 AM, Daan Hoogland 
wrote:

> Guys, we should rename fields that have improper names. I do not agreee
> with the statement at all. Your two solutions to the serialisation hazard
> are both acceptable to me. leaving a non compliant or non explanatory name
> in because it slipped through the nets at some points does not seem
> acceptable to me. We must improve are code.
>
> On Fri, May 20, 2016 at 6:53 AM, Tutkowski, Mike <
> mike.tutkow...@netapp.com>
> wrote:
>
> > Thanks for sending out this e-mail, Anshul.
> >
> > This is a bit of a strange situation because we need to make sure people
> > are either aware of the fact that properties in Command classes are
> > serialized (and not change existing variable names) or come up with a
> less
> > fragile way of choosing property names when sending data (perhaps using
> > annotations).
> >
> > At the very least, we should have comments in these classes indicating
> the
> > dangers of changing property names. It might also be beneficial to have
> > unit tests in place that expect certain variable names and assert if they
> > are not as expected.
> >
> > In the meanwhile, I plan to change the variable names back that were
> > changed in PR #816.
> >
> > Additional thoughts on how this should be addressed long term?
> >
> > Thanks!
> > Mike
> > 
> > From: Anshul Gangwar 
> > Sent: Thursday, May 19, 2016 10:47 PM
> > To: dev@cloudstack.apache.org
> > Subject: Variable renaming in classes meant for Agents
> >
> > Hi,
> >
> > We should not allow renaming of variables in classes which ends with
> > Command and TO. As these objects are meant to be consumed by Agents.
> >
> > Agents may not be written in java so relying on these variable names to
> > get the info. One such example is Hyper-V agent.
> >
> > Hyper-V support is currently broken as there are some variables renamed
> in
> > PR https://github.com/apache/cloudstack/pull/816.
> >
> > Regards,
> > Anshul
> >
> >
> >
> >
> >
> >
> > DISCLAIMER
> > ==
> > This e-mail may contain privileged and confidential information which is
> > the property of Accelerite, a Persistent Systems business. It is intended
> > only for the use of the individual or entity to which it is addressed. If
> > you are not the intended recipient, you are not authorized to read,
> retain,
> > copy, print, distribute or use this message. If you have received this
> > communication in error, please notify the sender and delete all copies of
> > this message. Accelerite, a Persistent Systems business does not accept
> any
> > liability for virus infected mails.
> >
>
>
>
> --
> Daan
>

--
Rafael Weingärtner

[GitHub] cloudstack pull request: Refactor system VM default network creati...

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1360#issuecomment-220656462
  


### CI RESULTS

```
Tests Run: 82
  Skipped: 0
   Failed: 1
   Errors: 4
 Duration: 10h 22m 36s
```

**Summary of the problem(s):**
```
FAIL: Test destroy(expunge) Virtual Machine
--
Traceback (most recent call last):
  File 
"/data/git/cs1/cloudstack/test/integration/smoke/test_vm_life_cycle.py", line 
646, in test_09_expunge_vm
self.assertEqual(list_vm_response,None,"Check Expunged virtual machine 
is in listVirtualMachines response")
AssertionError: Check Expunged virtual machine is in listVirtualMachines 
response
--
Additional details in: /tmp/MarvinLogs/test_vpc_routers_NMPJUY/results.txt
```

```
ERROR: Test to verify access to loadbalancer haproxy admin stats page
--
Traceback (most recent call last):
  File 
"/data/git/cs1/cloudstack/test/integration/smoke/test_internal_lb.py", line 
854, in tearDown
raise Exception("Cleanup failed with %s" % e)
Exception: Cleanup failed with Job failed: {jobprocstatus : 0, created : 
u'2016-05-20T12:35:56+0200', jobresult : {errorcode : 530, errortext : u'Failed 
to delete network'}, cmd : 
u'org.apache.cloudstack.api.command.user.network.DeleteNetworkCmd', userid : 
u'af61c686-1e47-11e6-9347-5254001daa61', jobstatus : 2, jobid : 
u'dd08012d-1a5d-40cd-a569-4fc4b474b235', jobresultcode : 530, jobresulttype : 
u'object', jobinstancetype : u'Network', accountid : 
u'af61aacc-1e47-11e6-9347-5254001daa61'}
--
Additional details in: /tmp/MarvinLogs/test_network_0JEOCP/results.txt
```

```
ERROR: test suite for 
--
Traceback (most recent call last):
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
209, in run
self.setUp()
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
292, in setUp
self.setupContext(ancestor)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
315, in setupContext
try_run(context, names)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, 
in try_run
return func()
  File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", 
line 835, in setUpClass
cls.template.download(cls.apiclient)
  File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1350, in 
download
elif 'Downloaded' in template.status:
TypeError: argument of type 'NoneType' is not iterable
--
Additional details in: /tmp/MarvinLogs/test_network_0JEOCP/results.txt
```

```
ERROR: test suite for 
--
Traceback (most recent call last):
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
209, in run
self.setUp()
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
292, in setUp
self.setupContext(ancestor)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
315, in setupContext
try_run(context, names)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, 
in try_run
return func()
  File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", 
line 293, in setUpClass
cls.template.download(cls.apiclient)
  File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1350, in 
download
elif 'Downloaded' in template.status:
TypeError: argument of type 'NoneType' is not iterable
--
Additional details in: /tmp/MarvinLogs/test_network_0JEOCP/results.txt
```

```
ERROR: test suite for 
--
Traceback (most recent call last):
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
209, in run
self.setUp()
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
292, in setUp
self.setupContext(ancestor)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
315, in setupContext
try_run(context, names)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", li

[GitHub] cloudstack pull request: Refactor system VM default network creati...

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1360#issuecomment-220656774
  
Ran again because the error was not something I had seen often.  The errors 
in the new run are not related to this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Variable renaming in classes meant for Agents

You are right Mike about the “_”. The point is that in some other language
the use of “_” makes sense, whereas in Java it does not, at least not the
way it has being used in ACS.

We have code conventions, it can be found in [1]. The problem is that it is
a bit outdated and I think it could benefit from some others tutorials. For
instance, a clear and simple tutorial explaining what is a test case and
showing how to create a proper test case; I am referring to the
unit/integration test case that we write using Junit and other tools.

Also, we lack some information on how to prepare code to be tested.
Once we have that kind of standard defined and tutorials written, we could
work out ways to educate our community. It is not a problem not to know
those things; we cannot expect everyone to know how to use every single
methodology and technology that is out there. But, we can help people to
learn, that is the point of a community, it should be a place where people
exchange ideas and experience in a way that benefits everyone.

As soon as you open the PR, please let us know, so we can review it and
help you get it merge as soon as possible. I think this is something that
should go in the 4.9 release.


On Fri, May 20, 2016 at 1:27 PM, Tutkowski, Mike 
wrote:

> It sounds like most people don't like a preceding "_" for member variables
> and that is fine. Do we have any formal Java coding standards for
> CloudStack, by the way? I'm not aware of any.
>
> The main problem here, though, is that this particular piece of code is
> super fragile, so it would be great to harden it up.
>
> I'm going to open a PR and revert the names in those changed "Command"
> files for 4.9. That will solve the immediate problem.
> 
> From: Rafael Weingärtner 
> Sent: Friday, May 20, 2016 9:12 AM
> To: dev@cloudstack.apache.org
> Subject: Re: Variable renaming in classes meant for Agents
>
> Hi guys,
> I agree with Daan that if class fields have improper (not descriptive or
> not suitable) names we should change them. However, I do not find the
> change (on variable names) introduced by PR #816 good. It added an
> “_”(underline) before variable names; even though Apache CloudStack has a
> lot of that currently, I think that is a pattern we should avoid.
>
> Your ideas to use annotations to avoid relying on variable names are great;
> but, let’s not re-create the well here. There is a research [1] that has
> been conducted in 2014 that tackled exactly that problem; the proposal
> presented in [1] decoupled client and server sides from variable name by
> using semantic annotations. The concept, the formalization and the
> experiments are all presented in paper [1]. The serialization and
> deserialization core of the proposal presented in [1] can be found in [2].
>
> The idea of decoupling our web APIs from variable names is great, but it is
> something that will require some effort to be fully and properly
> implemented. If you wish to push that forward count on me.
>
> [1] http://ieeexplore.ieee.org/xpls/abs_all.jsp?arnumber=6928953&tag=1
> [2] https://github.com/ivansalvadori/gsonld
>
>
> On Fri, May 20, 2016 at 3:30 AM, Daan Hoogland 
> wrote:
>
> > Guys, we should rename fields that have improper names. I do not agreee
> > with the statement at all. Your two solutions to the serialisation hazard
> > are both acceptable to me. leaving a non compliant or non explanatory
> name
> > in because it slipped through the nets at some points does not seem
> > acceptable to me. We must improve are code.
> >
> > On Fri, May 20, 2016 at 6:53 AM, Tutkowski, Mike <
> > mike.tutkow...@netapp.com>
> > wrote:
> >
> > > Thanks for sending out this e-mail, Anshul.
> > >
> > > This is a bit of a strange situation because we need to make sure
> people
> > > are either aware of the fact that properties in Command classes are
> > > serialized (and not change existing variable names) or come up with a
> > less
> > > fragile way of choosing property names when sending data (perhaps using
> > > annotations).
> > >
> > > At the very least, we should have comments in these classes indicating
> > the
> > > dangers of changing property names. It might also be beneficial to have
> > > unit tests in place that expect certain variable names and assert if
> they
> > > are not as expected.
> > >
> > > In the meanwhile, I plan to change the variable names back that were
> > > changed in PR #816.
> > >
> > > Additional thoughts on how this should be addressed long term?
> > >
> > > Thanks!
> > > Mike
> > > 
> > > From: Anshul Gangwar 
> > > Sent: Thursday, May 19, 2016 10:47 PM
> > > To: dev@cloudstack.apache.org
> > > Subject: Variable renaming in classes meant for Agents
> > >
> > > Hi,
> > >
> > > We should not allow renaming of variables in classes which ends with
> > > Command and TO. As these objects are meant to be consumed by Agents.
> > >
> > > Agents may not be written in java so re

Re: Variable renaming in classes meant for Agents

Also, does this mean that we have zero Hyper-V integration tests run during CI?

From: Tutkowski, Mike 
Sent: Friday, May 20, 2016 10:47 AM
To: dev@cloudstack.apache.org
Subject: Re: Variable renaming in classes meant for Agents

Yeah, it has to go into 4.9. :) Unless no one cares about Hyper-V.

From: Rafael Weingärtner 
Sent: Friday, May 20, 2016 10:42 AM
To: dev@cloudstack.apache.org
Subject: Re: Variable renaming in classes meant for Agents

You are right Mike about the “_”. The point is that in some other language
the use of “_” makes sense, whereas in Java it does not, at least not the
way it has being used in ACS.

We have code conventions, it can be found in [1]. The problem is that it is
a bit outdated and I think it could benefit from some others tutorials. For
instance, a clear and simple tutorial explaining what is a test case and
showing how to create a proper test case; I am referring to the
unit/integration test case that we write using Junit and other tools.

Also, we lack some information on how to prepare code to be tested.
Once we have that kind of standard defined and tutorials written, we could
work out ways to educate our community. It is not a problem not to know
those things; we cannot expect everyone to know how to use every single
methodology and technology that is out there. But, we can help people to
learn, that is the point of a community, it should be a place where people
exchange ideas and experience in a way that benefits everyone.

As soon as you open the PR, please let us know, so we can review it and
help you get it merge as soon as possible. I think this is something that
should go in the 4.9 release.


On Fri, May 20, 2016 at 1:27 PM, Tutkowski, Mike 
wrote:

> It sounds like most people don't like a preceding "_" for member variables
> and that is fine. Do we have any formal Java coding standards for
> CloudStack, by the way? I'm not aware of any.
>
> The main problem here, though, is that this particular piece of code is
> super fragile, so it would be great to harden it up.
>
> I'm going to open a PR and revert the names in those changed "Command"
> files for 4.9. That will solve the immediate problem.
> 
> From: Rafael Weingärtner 
> Sent: Friday, May 20, 2016 9:12 AM
> To: dev@cloudstack.apache.org
> Subject: Re: Variable renaming in classes meant for Agents
>
> Hi guys,
> I agree with Daan that if class fields have improper (not descriptive or
> not suitable) names we should change them. However, I do not find the
> change (on variable names) introduced by PR #816 good. It added an
> “_”(underline) before variable names; even though Apache CloudStack has a
> lot of that currently, I think that is a pattern we should avoid.
>
> Your ideas to use annotations to avoid relying on variable names are great;
> but, let’s not re-create the well here. There is a research [1] that has
> been conducted in 2014 that tackled exactly that problem; the proposal
> presented in [1] decoupled client and server sides from variable name by
> using semantic annotations. The concept, the formalization and the
> experiments are all presented in paper [1]. The serialization and
> deserialization core of the proposal presented in [1] can be found in [2].
>
> The idea of decoupling our web APIs from variable names is great, but it is
> something that will require some effort to be fully and properly
> implemented. If you wish to push that forward count on me.
>
> [1] http://ieeexplore.ieee.org/xpls/abs_all.jsp?arnumber=6928953&tag=1
> [2] https://github.com/ivansalvadori/gsonld
>
>
> On Fri, May 20, 2016 at 3:30 AM, Daan Hoogland 
> wrote:
>
> > Guys, we should rename fields that have improper names. I do not agreee
> > with the statement at all. Your two solutions to the serialisation hazard
> > are both acceptable to me. leaving a non compliant or non explanatory
> name
> > in because it slipped through the nets at some points does not seem
> > acceptable to me. We must improve are code.
> >
> > On Fri, May 20, 2016 at 6:53 AM, Tutkowski, Mike <
> > mike.tutkow...@netapp.com>
> > wrote:
> >
> > > Thanks for sending out this e-mail, Anshul.
> > >
> > > This is a bit of a strange situation because we need to make sure
> people
> > > are either aware of the fact that properties in Command classes are
> > > serialized (and not change existing variable names) or come up with a
> > less
> > > fragile way of choosing property names when sending data (perhaps using
> > > annotations).
> > >
> > > At the very least, we should have comments in these classes indicating
> > the
> > > dangers of changing property names. It might also be beneficial to have
> > > unit tests in place that expect certain variable names and assert if
> they
> > > are not as expected.
> > >
> > > In the meanwhile, I plan to change the variable names back that were
> > > changed in PR #816.
> > >
> > > Add

Re: Variable renaming in classes meant for Agents

I think that if we say we support Hyper-V we should care about it.

On Fri, May 20, 2016 at 1:47 PM, Tutkowski, Mike 
wrote:

> Yeah, it has to go into 4.9. :) Unless no one cares about Hyper-V.
> 
> From: Rafael Weingärtner 
> Sent: Friday, May 20, 2016 10:42 AM
> To: dev@cloudstack.apache.org
> Subject: Re: Variable renaming in classes meant for Agents
>
> You are right Mike about the “_”. The point is that in some other language
> the use of “_” makes sense, whereas in Java it does not, at least not the
> way it has being used in ACS.
>
> We have code conventions, it can be found in [1]. The problem is that it is
> a bit outdated and I think it could benefit from some others tutorials. For
> instance, a clear and simple tutorial explaining what is a test case and
> showing how to create a proper test case; I am referring to the
> unit/integration test case that we write using Junit and other tools.
>
> Also, we lack some information on how to prepare code to be tested.
> Once we have that kind of standard defined and tutorials written, we could
> work out ways to educate our community. It is not a problem not to know
> those things; we cannot expect everyone to know how to use every single
> methodology and technology that is out there. But, we can help people to
> learn, that is the point of a community, it should be a place where people
> exchange ideas and experience in a way that benefits everyone.
>
> As soon as you open the PR, please let us know, so we can review it and
> help you get it merge as soon as possible. I think this is something that
> should go in the 4.9 release.
>
>
> On Fri, May 20, 2016 at 1:27 PM, Tutkowski, Mike <
> mike.tutkow...@netapp.com>
> wrote:
>
> > It sounds like most people don't like a preceding "_" for member
> variables
> > and that is fine. Do we have any formal Java coding standards for
> > CloudStack, by the way? I'm not aware of any.
> >
> > The main problem here, though, is that this particular piece of code is
> > super fragile, so it would be great to harden it up.
> >
> > I'm going to open a PR and revert the names in those changed "Command"
> > files for 4.9. That will solve the immediate problem.
> > 
> > From: Rafael Weingärtner 
> > Sent: Friday, May 20, 2016 9:12 AM
> > To: dev@cloudstack.apache.org
> > Subject: Re: Variable renaming in classes meant for Agents
> >
> > Hi guys,
> > I agree with Daan that if class fields have improper (not descriptive or
> > not suitable) names we should change them. However, I do not find the
> > change (on variable names) introduced by PR #816 good. It added an
> > “_”(underline) before variable names; even though Apache CloudStack has a
> > lot of that currently, I think that is a pattern we should avoid.
> >
> > Your ideas to use annotations to avoid relying on variable names are
> great;
> > but, let’s not re-create the well here. There is a research [1] that has
> > been conducted in 2014 that tackled exactly that problem; the proposal
> > presented in [1] decoupled client and server sides from variable name by
> > using semantic annotations. The concept, the formalization and the
> > experiments are all presented in paper [1]. The serialization and
> > deserialization core of the proposal presented in [1] can be found in
> [2].
> >
> > The idea of decoupling our web APIs from variable names is great, but it
> is
> > something that will require some effort to be fully and properly
> > implemented. If you wish to push that forward count on me.
> >
> > [1] http://ieeexplore.ieee.org/xpls/abs_all.jsp?arnumber=6928953&tag=1
> > [2] https://github.com/ivansalvadori/gsonld
> >
> >
> > On Fri, May 20, 2016 at 3:30 AM, Daan Hoogland 
> > wrote:
> >
> > > Guys, we should rename fields that have improper names. I do not agreee
> > > with the statement at all. Your two solutions to the serialisation
> hazard
> > > are both acceptable to me. leaving a non compliant or non explanatory
> > name
> > > in because it slipped through the nets at some points does not seem
> > > acceptable to me. We must improve are code.
> > >
> > > On Fri, May 20, 2016 at 6:53 AM, Tutkowski, Mike <
> > > mike.tutkow...@netapp.com>
> > > wrote:
> > >
> > > > Thanks for sending out this e-mail, Anshul.
> > > >
> > > > This is a bit of a strange situation because we need to make sure
> > people
> > > > are either aware of the fact that properties in Command classes are
> > > > serialized (and not change existing variable names) or come up with a
> > > less
> > > > fragile way of choosing property names when sending data (perhaps
> using
> > > > annotations).
> > > >
> > > > At the very least, we should have comments in these classes
> indicating
> > > the
> > > > dangers of changing property names. It might also be beneficial to
> have
> > > > unit tests in place that expect certain variable names and assert if
> > they
> > > > are not as expected.
> > > >
> > > > In the me

Re: Variable renaming in classes meant for Agents

Yeah, I'm just teasing. :) The PR needs to go into 4.9 to fix Hyper-V.

From: Rafael Weingärtner 
Sent: Friday, May 20, 2016 10:49 AM
To: dev@cloudstack.apache.org
Subject: Re: Variable renaming in classes meant for Agents

I think that if we say we support Hyper-V we should care about it.

On Fri, May 20, 2016 at 1:47 PM, Tutkowski, Mike 
wrote:

> Yeah, it has to go into 4.9. :) Unless no one cares about Hyper-V.
> 
> From: Rafael Weingärtner 
> Sent: Friday, May 20, 2016 10:42 AM
> To: dev@cloudstack.apache.org
> Subject: Re: Variable renaming in classes meant for Agents
>
> You are right Mike about the “_”. The point is that in some other language
> the use of “_” makes sense, whereas in Java it does not, at least not the
> way it has being used in ACS.
>
> We have code conventions, it can be found in [1]. The problem is that it is
> a bit outdated and I think it could benefit from some others tutorials. For
> instance, a clear and simple tutorial explaining what is a test case and
> showing how to create a proper test case; I am referring to the
> unit/integration test case that we write using Junit and other tools.
>
> Also, we lack some information on how to prepare code to be tested.
> Once we have that kind of standard defined and tutorials written, we could
> work out ways to educate our community. It is not a problem not to know
> those things; we cannot expect everyone to know how to use every single
> methodology and technology that is out there. But, we can help people to
> learn, that is the point of a community, it should be a place where people
> exchange ideas and experience in a way that benefits everyone.
>
> As soon as you open the PR, please let us know, so we can review it and
> help you get it merge as soon as possible. I think this is something that
> should go in the 4.9 release.
>
>
> On Fri, May 20, 2016 at 1:27 PM, Tutkowski, Mike <
> mike.tutkow...@netapp.com>
> wrote:
>
> > It sounds like most people don't like a preceding "_" for member
> variables
> > and that is fine. Do we have any formal Java coding standards for
> > CloudStack, by the way? I'm not aware of any.
> >
> > The main problem here, though, is that this particular piece of code is
> > super fragile, so it would be great to harden it up.
> >
> > I'm going to open a PR and revert the names in those changed "Command"
> > files for 4.9. That will solve the immediate problem.
> > 
> > From: Rafael Weingärtner 
> > Sent: Friday, May 20, 2016 9:12 AM
> > To: dev@cloudstack.apache.org
> > Subject: Re: Variable renaming in classes meant for Agents
> >
> > Hi guys,
> > I agree with Daan that if class fields have improper (not descriptive or
> > not suitable) names we should change them. However, I do not find the
> > change (on variable names) introduced by PR #816 good. It added an
> > “_”(underline) before variable names; even though Apache CloudStack has a
> > lot of that currently, I think that is a pattern we should avoid.
> >
> > Your ideas to use annotations to avoid relying on variable names are
> great;
> > but, let’s not re-create the well here. There is a research [1] that has
> > been conducted in 2014 that tackled exactly that problem; the proposal
> > presented in [1] decoupled client and server sides from variable name by
> > using semantic annotations. The concept, the formalization and the
> > experiments are all presented in paper [1]. The serialization and
> > deserialization core of the proposal presented in [1] can be found in
> [2].
> >
> > The idea of decoupling our web APIs from variable names is great, but it
> is
> > something that will require some effort to be fully and properly
> > implemented. If you wish to push that forward count on me.
> >
> > [1] http://ieeexplore.ieee.org/xpls/abs_all.jsp?arnumber=6928953&tag=1
> > [2] https://github.com/ivansalvadori/gsonld
> >
> >
> > On Fri, May 20, 2016 at 3:30 AM, Daan Hoogland 
> > wrote:
> >
> > > Guys, we should rename fields that have improper names. I do not agreee
> > > with the statement at all. Your two solutions to the serialisation
> hazard
> > > are both acceptable to me. leaving a non compliant or non explanatory
> > name
> > > in because it slipped through the nets at some points does not seem
> > > acceptable to me. We must improve are code.
> > >
> > > On Fri, May 20, 2016 at 6:53 AM, Tutkowski, Mike <
> > > mike.tutkow...@netapp.com>
> > > wrote:
> > >
> > > > Thanks for sending out this e-mail, Anshul.
> > > >
> > > > This is a bit of a strange situation because we need to make sure
> > people
> > > > are either aware of the fact that properties in Command classes are
> > > > serialized (and not change existing variable names) or come up with a
> > > less
> > > > fragile way of choosing property names when sending data (perhaps
> using
> > > > annotations).
> > > >
> > > > At the very least, we should have comment

Re: Migrating CloudStack content from download.cloud.com

2016-05-20 Thread Chiradeep Vittal

:) According to Raja, there is some time before download.cloud.com is
doomed. Let's pretend that date is Jan 1 2017. Now pretend that it is Dec
25, 2016 and we're still debating mirror list vs steps and what not. Now,
just change the 2017 to 2016 and re-consider. We need this done yesterday!







On Fri, May 20, 2016 at 1:53 AM, Daan Hoogland 
wrote:

> send by tablet, no warranties in existence
> On 20 May 2016 09:29, "Paul Angus"  wrote:
> >
> > I'm a -1 on adding another step to the installation process.
> >
> > I agree with Will, it will only be another barrier to platform adoption.
> >
> > The SSVM going and downloading the built-in template is a good milestone
> in a CloudStack build.
> >
> > To be honest the mgmt. server should be able to go get the template
> itself if required rather than making it a user installation step.
> great idea, looking forward to your PR.
>
> >
> > Kind regards,
> >
> > Paul Angus
> >
> > paul.an...@shapeblue.com
> > www.shapeblue.com
> > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> > @shapeblue
> >
> >
> >
> > -Original Message-
> > From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
> > Sent: 19 May 2016 23:06
> > To: dev 
> > Subject: Re: Migrating CloudStack content from download.cloud.com
> >
> > sounds good, so if we put both sections together the worry is over. acs
> is a complex system and requires a lot of reading so let''s not put it in a
> different section. would be duplicate code anyhow.
> >
> > On Thu, May 19, 2016 at 11:56 PM, Chiradeep Vittal  >
> > wrote:
> >
> > > Well, you have to define "worry" :)
> > >
> > > I'm proposing an almost identical step to
> > >
> > > http://docs.cloudstack.apache.org/projects/cloudstack-installation/en/
> > > 4.6/management-server/#prepare-the-system-vm-template
> > >
> > > If they can do that, then it is not a stretch to assume they can
> > > download the default template in a similar manner. The
> > > "cloud-install-default-template" (proposed) script can do the mirror
> > > checking etc.
> > >
> > >
> > >
> > >
> > > On Thu, May 19, 2016 at 2:44 PM, Will Stevens 
> > > wrote:
> > >
> > > > I definitely agree with this.  I don't think people doing a PoC
> > > > should
> > > have
> > > > to worry about getting a template installed on first setup.  I think
> > > > that is a basic feature if we want platform adoption.  Getting the
> > > > first boot process from download to first VM launched should be as
> > > > smooth as
> > > possible.
> > > >
> > > > *Will STEVENS*
> > > > Lead Developer
> > > >
> > > > *CloudOps* *| *Cloud Solutions Experts
> > > > 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6 w cloudops.com *|*
> > > > tw @CloudOps_
> > > >
> > > > On Thu, May 19, 2016 at 5:37 PM, Daan Hoogland
> > > > 
> > > > wrote:
> > > >
> > > > > Chiradeep,
> > > > >
> > > > > It makes sense not to have this old default very insecure guest
> > > template
> > > > > still be downloaded but it would be nice to have some kind of
> > > > > meta-data pointing to the latest version of an acceptable template
> > > > > (symlink) for trial installs so PoCcers are swiftly on their way.
> Would you agree?
> > > > >
> > > > > On Thu, May 19, 2016 at 8:15 PM, Chiradeep Vittal <
> > > chirade...@gmail.com>
> > > > > wrote:
> > > > >
> > > > > > Pierre,
> > > > > > I meant the auto-download of default templates, not systemvm.
> > > > > > Note that the initial systemvm template has to be
> > > > > > hand-downloaded
> > > > anyway.
> > > > > > If you are a single hypervisor cloud, then that is all that is
> > > needed.
> > > > > >
> > > > > > On Thu, May 19, 2016 at 11:08 AM, Pierre-Luc Dion <
> > > pd...@cloudops.com>
> > > > > > wrote:
> > > > > >
> > > > > > > I would be -1 about disabling the autodownload of the systemvm
> > > > > template,
> > > > > > > has this should be simplify deployment of a cloudstack system.
> > > > > > > although, the download URL should be a configurable value,
> > > > > > > maybe
> > > in a
> > > > > > > property file or thru the API somehow or via a pre-install
> command.
> > > > > > >
> > > > > > > I really like  download.cloudstack.org + mirror. I'm looking
> > > > > > > at
> > > > > getting
> > > > > > > the
> > > > > > > DNS entry: builds.cloudstack.org for the new Jenkins and I got
> > > > > > > no objections on using the cloudstack.org domain for community
> > > services
> > > > > so
> > > > > > > I'm
> > > > > > > pretty sure we would be ok to use download.cloudstack.org,
> > > > > > > where
> > > > would
> > > > > > we
> > > > > > > setting this up? on the current webserver of our website?
> > > > > > > could we
> > > ?
> > > > > > >
> > > > > > >
> > > > > > > Cheers,
> > > > > > >
> > > > > > > PL
> > > > > > >
> > > > > > > On Thu, May 19, 2016 at 11:00 AM, Giles Sirett <
> > > > > > giles.sir...@shapeblue.com
> > > > > > > >
> > > > > > > wrote:
> > > > > > >
> > > > > > > > Erik
> > > > > > > > I agree on the existing users - not the end of the world. We
> > > could
> > > > > even

Re: Variable renaming in classes meant for Agents

I noticed ;)


Yes, we do not have Marvin tests for Hyper-V (at least that is what I
know). I believe most of the tests that are being executed nowadays use
either KVM or XenServer; some people might be executing few of them too in
VMware environments.

On Fri, May 20, 2016 at 1:50 PM, Tutkowski, Mike 
wrote:

> Yeah, I'm just teasing. :) The PR needs to go into 4.9 to fix Hyper-V.
> 
> From: Rafael Weingärtner 
> Sent: Friday, May 20, 2016 10:49 AM
> To: dev@cloudstack.apache.org
> Subject: Re: Variable renaming in classes meant for Agents
>
> I think that if we say we support Hyper-V we should care about it.
>
> On Fri, May 20, 2016 at 1:47 PM, Tutkowski, Mike <
> mike.tutkow...@netapp.com>
> wrote:
>
> > Yeah, it has to go into 4.9. :) Unless no one cares about Hyper-V.
> > 
> > From: Rafael Weingärtner 
> > Sent: Friday, May 20, 2016 10:42 AM
> > To: dev@cloudstack.apache.org
> > Subject: Re: Variable renaming in classes meant for Agents
> >
> > You are right Mike about the “_”. The point is that in some other
> language
> > the use of “_” makes sense, whereas in Java it does not, at least not the
> > way it has being used in ACS.
> >
> > We have code conventions, it can be found in [1]. The problem is that it
> is
> > a bit outdated and I think it could benefit from some others tutorials.
> For
> > instance, a clear and simple tutorial explaining what is a test case and
> > showing how to create a proper test case; I am referring to the
> > unit/integration test case that we write using Junit and other tools.
> >
> > Also, we lack some information on how to prepare code to be tested.
> > Once we have that kind of standard defined and tutorials written, we
> could
> > work out ways to educate our community. It is not a problem not to know
> > those things; we cannot expect everyone to know how to use every single
> > methodology and technology that is out there. But, we can help people to
> > learn, that is the point of a community, it should be a place where
> people
> > exchange ideas and experience in a way that benefits everyone.
> >
> > As soon as you open the PR, please let us know, so we can review it and
> > help you get it merge as soon as possible. I think this is something that
> > should go in the 4.9 release.
> >
> >
> > On Fri, May 20, 2016 at 1:27 PM, Tutkowski, Mike <
> > mike.tutkow...@netapp.com>
> > wrote:
> >
> > > It sounds like most people don't like a preceding "_" for member
> > variables
> > > and that is fine. Do we have any formal Java coding standards for
> > > CloudStack, by the way? I'm not aware of any.
> > >
> > > The main problem here, though, is that this particular piece of code is
> > > super fragile, so it would be great to harden it up.
> > >
> > > I'm going to open a PR and revert the names in those changed "Command"
> > > files for 4.9. That will solve the immediate problem.
> > > 
> > > From: Rafael Weingärtner 
> > > Sent: Friday, May 20, 2016 9:12 AM
> > > To: dev@cloudstack.apache.org
> > > Subject: Re: Variable renaming in classes meant for Agents
> > >
> > > Hi guys,
> > > I agree with Daan that if class fields have improper (not descriptive
> or
> > > not suitable) names we should change them. However, I do not find the
> > > change (on variable names) introduced by PR #816 good. It added an
> > > “_”(underline) before variable names; even though Apache CloudStack
> has a
> > > lot of that currently, I think that is a pattern we should avoid.
> > >
> > > Your ideas to use annotations to avoid relying on variable names are
> > great;
> > > but, let’s not re-create the well here. There is a research [1] that
> has
> > > been conducted in 2014 that tackled exactly that problem; the proposal
> > > presented in [1] decoupled client and server sides from variable name
> by
> > > using semantic annotations. The concept, the formalization and the
> > > experiments are all presented in paper [1]. The serialization and
> > > deserialization core of the proposal presented in [1] can be found in
> > [2].
> > >
> > > The idea of decoupling our web APIs from variable names is great, but
> it
> > is
> > > something that will require some effort to be fully and properly
> > > implemented. If you wish to push that forward count on me.
> > >
> > > [1] http://ieeexplore.ieee.org/xpls/abs_all.jsp?arnumber=6928953&tag=1
> > > [2] https://github.com/ivansalvadori/gsonld
> > >
> > >
> > > On Fri, May 20, 2016 at 3:30 AM, Daan Hoogland <
> daan.hoogl...@gmail.com>
> > > wrote:
> > >
> > > > Guys, we should rename fields that have improper names. I do not
> agreee
> > > > with the statement at all. Your two solutions to the serialisation
> > hazard
> > > > are both acceptable to me. leaving a non compliant or non explanatory
> > > name
> > > > in because it slipped through the nets at some points does not seem
> > > > acceptable to me. We must improve are code.
>

Re: Migrating CloudStack content from download.cloud.com

2016-05-20 Thread Chiradeep Vittal

Agree with Daan : we shouldn't be pushing these ancient insecure templates!


On Fri, May 20, 2016 at 9:51 AM, Chiradeep Vittal 
wrote:

> :) According to Raja, there is some time before download.cloud.com is
> doomed. Let's pretend that date is Jan 1 2017. Now pretend that it is Dec
> 25, 2016 and we're still debating mirror list vs steps and what not. Now,
> just change the 2017 to 2016 and re-consider. We need this done yesterday!
>
>
>
>
>
>
>
> On Fri, May 20, 2016 at 1:53 AM, Daan Hoogland 
> wrote:
>
>> send by tablet, no warranties in existence
>> On 20 May 2016 09:29, "Paul Angus"  wrote:
>> >
>> > I'm a -1 on adding another step to the installation process.
>> >
>> > I agree with Will, it will only be another barrier to platform adoption.
>> >
>> > The SSVM going and downloading the built-in template is a good milestone
>> in a CloudStack build.
>> >
>> > To be honest the mgmt. server should be able to go get the template
>> itself if required rather than making it a user installation step.
>> great idea, looking forward to your PR.
>>
>> >
>> > Kind regards,
>> >
>> > Paul Angus
>> >
>> > paul.an...@shapeblue.com
>> > www.shapeblue.com
>> > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
>> > @shapeblue
>> >
>> >
>> >
>> > -Original Message-
>> > From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
>> > Sent: 19 May 2016 23:06
>> > To: dev 
>> > Subject: Re: Migrating CloudStack content from download.cloud.com
>> >
>> > sounds good, so if we put both sections together the worry is over. acs
>> is a complex system and requires a lot of reading so let''s not put it in
>> a
>> different section. would be duplicate code anyhow.
>> >
>> > On Thu, May 19, 2016 at 11:56 PM, Chiradeep Vittal <
>> chirade...@gmail.com>
>> > wrote:
>> >
>> > > Well, you have to define "worry" :)
>> > >
>> > > I'm proposing an almost identical step to
>> > >
>> > >
>> http://docs.cloudstack.apache.org/projects/cloudstack-installation/en/
>> > > 4.6/management-server/#prepare-the-system-vm-template
>> > >
>> > > If they can do that, then it is not a stretch to assume they can
>> > > download the default template in a similar manner. The
>> > > "cloud-install-default-template" (proposed) script can do the mirror
>> > > checking etc.
>> > >
>> > >
>> > >
>> > >
>> > > On Thu, May 19, 2016 at 2:44 PM, Will Stevens 
>> > > wrote:
>> > >
>> > > > I definitely agree with this.  I don't think people doing a PoC
>> > > > should
>> > > have
>> > > > to worry about getting a template installed on first setup.  I think
>> > > > that is a basic feature if we want platform adoption.  Getting the
>> > > > first boot process from download to first VM launched should be as
>> > > > smooth as
>> > > possible.
>> > > >
>> > > > *Will STEVENS*
>> > > > Lead Developer
>> > > >
>> > > > *CloudOps* *| *Cloud Solutions Experts
>> > > > 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6 w cloudops.com *|*
>> > > > tw @CloudOps_
>> > > >
>> > > > On Thu, May 19, 2016 at 5:37 PM, Daan Hoogland
>> > > > 
>> > > > wrote:
>> > > >
>> > > > > Chiradeep,
>> > > > >
>> > > > > It makes sense not to have this old default very insecure guest
>> > > template
>> > > > > still be downloaded but it would be nice to have some kind of
>> > > > > meta-data pointing to the latest version of an acceptable template
>> > > > > (symlink) for trial installs so PoCcers are swiftly on their way.
>> Would you agree?
>> > > > >
>> > > > > On Thu, May 19, 2016 at 8:15 PM, Chiradeep Vittal <
>> > > chirade...@gmail.com>
>> > > > > wrote:
>> > > > >
>> > > > > > Pierre,
>> > > > > > I meant the auto-download of default templates, not systemvm.
>> > > > > > Note that the initial systemvm template has to be
>> > > > > > hand-downloaded
>> > > > anyway.
>> > > > > > If you are a single hypervisor cloud, then that is all that is
>> > > needed.
>> > > > > >
>> > > > > > On Thu, May 19, 2016 at 11:08 AM, Pierre-Luc Dion <
>> > > pd...@cloudops.com>
>> > > > > > wrote:
>> > > > > >
>> > > > > > > I would be -1 about disabling the autodownload of the systemvm
>> > > > > template,
>> > > > > > > has this should be simplify deployment of a cloudstack system.
>> > > > > > > although, the download URL should be a configurable value,
>> > > > > > > maybe
>> > > in a
>> > > > > > > property file or thru the API somehow or via a pre-install
>> command.
>> > > > > > >
>> > > > > > > I really like  download.cloudstack.org + mirror. I'm looking
>> > > > > > > at
>> > > > > getting
>> > > > > > > the
>> > > > > > > DNS entry: builds.cloudstack.org for the new Jenkins and I
>> got
>> > > > > > > no objections on using the cloudstack.org domain for
>> community
>> > > services
>> > > > > so
>> > > > > > > I'm
>> > > > > > > pretty sure we would be ok to use download.cloudstack.org,
>> > > > > > > where
>> > > > would
>> > > > > > we
>> > > > > > > setting this up? on the current webserver of our website?
>> > > > > > > could we
>> > > ?
>> > > > > > >
>> > > > > > >
>> > > > > > > Cheers,

Re: Variable renaming in classes meant for Agents

Yeah, it has to go into 4.9. :) Unless no one cares about Hyper-V.

From: Rafael Weingärtner 
Sent: Friday, May 20, 2016 10:42 AM
To: dev@cloudstack.apache.org
Subject: Re: Variable renaming in classes meant for Agents

You are right Mike about the “_”. The point is that in some other language
the use of “_” makes sense, whereas in Java it does not, at least not the
way it has being used in ACS.

We have code conventions, it can be found in [1]. The problem is that it is
a bit outdated and I think it could benefit from some others tutorials. For
instance, a clear and simple tutorial explaining what is a test case and
showing how to create a proper test case; I am referring to the
unit/integration test case that we write using Junit and other tools.

Also, we lack some information on how to prepare code to be tested.
Once we have that kind of standard defined and tutorials written, we could
work out ways to educate our community. It is not a problem not to know
those things; we cannot expect everyone to know how to use every single
methodology and technology that is out there. But, we can help people to
learn, that is the point of a community, it should be a place where people
exchange ideas and experience in a way that benefits everyone.

As soon as you open the PR, please let us know, so we can review it and
help you get it merge as soon as possible. I think this is something that
should go in the 4.9 release.


On Fri, May 20, 2016 at 1:27 PM, Tutkowski, Mike 
wrote:

> It sounds like most people don't like a preceding "_" for member variables
> and that is fine. Do we have any formal Java coding standards for
> CloudStack, by the way? I'm not aware of any.
>
> The main problem here, though, is that this particular piece of code is
> super fragile, so it would be great to harden it up.
>
> I'm going to open a PR and revert the names in those changed "Command"
> files for 4.9. That will solve the immediate problem.
> 
> From: Rafael Weingärtner 
> Sent: Friday, May 20, 2016 9:12 AM
> To: dev@cloudstack.apache.org
> Subject: Re: Variable renaming in classes meant for Agents
>
> Hi guys,
> I agree with Daan that if class fields have improper (not descriptive or
> not suitable) names we should change them. However, I do not find the
> change (on variable names) introduced by PR #816 good. It added an
> “_”(underline) before variable names; even though Apache CloudStack has a
> lot of that currently, I think that is a pattern we should avoid.
>
> Your ideas to use annotations to avoid relying on variable names are great;
> but, let’s not re-create the well here. There is a research [1] that has
> been conducted in 2014 that tackled exactly that problem; the proposal
> presented in [1] decoupled client and server sides from variable name by
> using semantic annotations. The concept, the formalization and the
> experiments are all presented in paper [1]. The serialization and
> deserialization core of the proposal presented in [1] can be found in [2].
>
> The idea of decoupling our web APIs from variable names is great, but it is
> something that will require some effort to be fully and properly
> implemented. If you wish to push that forward count on me.
>
> [1] http://ieeexplore.ieee.org/xpls/abs_all.jsp?arnumber=6928953&tag=1
> [2] https://github.com/ivansalvadori/gsonld
>
>
> On Fri, May 20, 2016 at 3:30 AM, Daan Hoogland 
> wrote:
>
> > Guys, we should rename fields that have improper names. I do not agreee
> > with the statement at all. Your two solutions to the serialisation hazard
> > are both acceptable to me. leaving a non compliant or non explanatory
> name
> > in because it slipped through the nets at some points does not seem
> > acceptable to me. We must improve are code.
> >
> > On Fri, May 20, 2016 at 6:53 AM, Tutkowski, Mike <
> > mike.tutkow...@netapp.com>
> > wrote:
> >
> > > Thanks for sending out this e-mail, Anshul.
> > >
> > > This is a bit of a strange situation because we need to make sure
> people
> > > are either aware of the fact that properties in Command classes are
> > > serialized (and not change existing variable names) or come up with a
> > less
> > > fragile way of choosing property names when sending data (perhaps using
> > > annotations).
> > >
> > > At the very least, we should have comments in these classes indicating
> > the
> > > dangers of changing property names. It might also be beneficial to have
> > > unit tests in place that expect certain variable names and assert if
> they
> > > are not as expected.
> > >
> > > In the meanwhile, I plan to change the variable names back that were
> > > changed in PR #816.
> > >
> > > Additional thoughts on how this should be addressed long term?
> > >
> > > Thanks!
> > > Mike
> > > 
> > > From: Anshul Gangwar 
> > > Sent: Thursday, May 19, 2016 10:47 PM
> > > To: dev@cloudstack.apache.org
> > > Subject: Variable

Re: Migrating CloudStack content from download.cloud.com

2016-05-20 Thread Chiradeep Vittal

I was proposing a new S3 bucket earlier (templates.cloudstack.org), but I
realized that someone needs to own the account. There is no legal entity
for Apache CloudStack (except the ASF) that can enter into a contract with
AWS (even if it is for a few bucks a month).  To make this work,
alternatives:
 (1) ASF Infra creates this bucket and IAM keys to the PMC to operate this
bucket. ACS users might want to make targeted donations to support this
bucket, but I don't believe that it is possible.

(2) Cloudstack.org gets registered as a (non-profit?) entity etc and ACS
users make donations to this entity. PMC has control over the bucket.

A mirror list and a python script (e.g., [1]) sounds like a much better
idea :)

Raise of hands:
Who is willing to host a mirror of systemvm templates and default
templates. I figure we need at least 5, preferably all over the world,
especially in East Asia.

[1]
http://code.activestate.com/recipes/284631-a-python-script-to-test-download-mirrors/





On Fri, May 20, 2016 at 9:52 AM, Chiradeep Vittal 
wrote:

> Agree with Daan : we shouldn't be pushing these ancient insecure
> templates!
>
>
> On Fri, May 20, 2016 at 9:51 AM, Chiradeep Vittal 
> wrote:
>
>> :) According to Raja, there is some time before download.cloud.com is
>> doomed. Let's pretend that date is Jan 1 2017. Now pretend that it is Dec
>> 25, 2016 and we're still debating mirror list vs steps and what not. Now,
>> just change the 2017 to 2016 and re-consider. We need this done yesterday!
>>
>>
>>
>>
>>
>>
>>
>> On Fri, May 20, 2016 at 1:53 AM, Daan Hoogland 
>> wrote:
>>
>>> send by tablet, no warranties in existence
>>> On 20 May 2016 09:29, "Paul Angus"  wrote:
>>> >
>>> > I'm a -1 on adding another step to the installation process.
>>> >
>>> > I agree with Will, it will only be another barrier to platform
>>> adoption.
>>> >
>>> > The SSVM going and downloading the built-in template is a good
>>> milestone
>>> in a CloudStack build.
>>> >
>>> > To be honest the mgmt. server should be able to go get the template
>>> itself if required rather than making it a user installation step.
>>> great idea, looking forward to your PR.
>>>
>>> >
>>> > Kind regards,
>>> >
>>> > Paul Angus
>>> >
>>> > paul.an...@shapeblue.com
>>> > www.shapeblue.com
>>> > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
>>> > @shapeblue
>>> >
>>> >
>>> >
>>> > -Original Message-
>>> > From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
>>> > Sent: 19 May 2016 23:06
>>> > To: dev 
>>> > Subject: Re: Migrating CloudStack content from download.cloud.com
>>> >
>>> > sounds good, so if we put both sections together the worry is over. acs
>>> is a complex system and requires a lot of reading so let''s not put it
>>> in a
>>> different section. would be duplicate code anyhow.
>>> >
>>> > On Thu, May 19, 2016 at 11:56 PM, Chiradeep Vittal <
>>> chirade...@gmail.com>
>>> > wrote:
>>> >
>>> > > Well, you have to define "worry" :)
>>> > >
>>> > > I'm proposing an almost identical step to
>>> > >
>>> > >
>>> http://docs.cloudstack.apache.org/projects/cloudstack-installation/en/
>>> > > 4.6/management-server/#prepare-the-system-vm-template
>>> > >
>>> > > If they can do that, then it is not a stretch to assume they can
>>> > > download the default template in a similar manner. The
>>> > > "cloud-install-default-template" (proposed) script can do the mirror
>>> > > checking etc.
>>> > >
>>> > >
>>> > >
>>> > >
>>> > > On Thu, May 19, 2016 at 2:44 PM, Will Stevens >> >
>>> > > wrote:
>>> > >
>>> > > > I definitely agree with this.  I don't think people doing a PoC
>>> > > > should
>>> > > have
>>> > > > to worry about getting a template installed on first setup.  I
>>> think
>>> > > > that is a basic feature if we want platform adoption.  Getting the
>>> > > > first boot process from download to first VM launched should be as
>>> > > > smooth as
>>> > > possible.
>>> > > >
>>> > > > *Will STEVENS*
>>> > > > Lead Developer
>>> > > >
>>> > > > *CloudOps* *| *Cloud Solutions Experts
>>> > > > 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6 w cloudops.com *|*
>>> > > > tw @CloudOps_
>>> > > >
>>> > > > On Thu, May 19, 2016 at 5:37 PM, Daan Hoogland
>>> > > > 
>>> > > > wrote:
>>> > > >
>>> > > > > Chiradeep,
>>> > > > >
>>> > > > > It makes sense not to have this old default very insecure guest
>>> > > template
>>> > > > > still be downloaded but it would be nice to have some kind of
>>> > > > > meta-data pointing to the latest version of an acceptable
>>> template
>>> > > > > (symlink) for trial installs so PoCcers are swiftly on their way.
>>> Would you agree?
>>> > > > >
>>> > > > > On Thu, May 19, 2016 at 8:15 PM, Chiradeep Vittal <
>>> > > chirade...@gmail.com>
>>> > > > > wrote:
>>> > > > >
>>> > > > > > Pierre,
>>> > > > > > I meant the auto-download of default templates, not systemvm.
>>> > > > > > Note that the initial systemvm template has to be
>>> > > > > > hand-downloaded
>>> > > > anyway.
>>> > > > > > If you are a single hyperviso

Re: Migrating CloudStack content from download.cloud.com

We could host a mirror here. We are in South America, Brazil.

On Fri, May 20, 2016 at 2:01 PM, Chiradeep Vittal 
wrote:

> I was proposing a new S3 bucket earlier (templates.cloudstack.org), but I
> realized that someone needs to own the account. There is no legal entity
> for Apache CloudStack (except the ASF) that can enter into a contract with
> AWS (even if it is for a few bucks a month).  To make this work,
> alternatives:
>  (1) ASF Infra creates this bucket and IAM keys to the PMC to operate this
> bucket. ACS users might want to make targeted donations to support this
> bucket, but I don't believe that it is possible.
>
> (2) Cloudstack.org gets registered as a (non-profit?) entity etc and ACS
> users make donations to this entity. PMC has control over the bucket.
>
> A mirror list and a python script (e.g., [1]) sounds like a much better
> idea :)
>
> Raise of hands:
> Who is willing to host a mirror of systemvm templates and default
> templates. I figure we need at least 5, preferably all over the world,
> especially in East Asia.
>
> [1]
>
> http://code.activestate.com/recipes/284631-a-python-script-to-test-download-mirrors/
>
>
>
>
>
> On Fri, May 20, 2016 at 9:52 AM, Chiradeep Vittal 
> wrote:
>
> > Agree with Daan : we shouldn't be pushing these ancient insecure
> > templates!
> >
> >
> > On Fri, May 20, 2016 at 9:51 AM, Chiradeep Vittal 
> > wrote:
> >
> >> :) According to Raja, there is some time before download.cloud.com is
> >> doomed. Let's pretend that date is Jan 1 2017. Now pretend that it is
> Dec
> >> 25, 2016 and we're still debating mirror list vs steps and what not.
> Now,
> >> just change the 2017 to 2016 and re-consider. We need this done
> yesterday!
> >>
> >>
> >>
> >>
> >>
> >>
> >>
> >> On Fri, May 20, 2016 at 1:53 AM, Daan Hoogland  >
> >> wrote:
> >>
> >>> send by tablet, no warranties in existence
> >>> On 20 May 2016 09:29, "Paul Angus"  wrote:
> >>> >
> >>> > I'm a -1 on adding another step to the installation process.
> >>> >
> >>> > I agree with Will, it will only be another barrier to platform
> >>> adoption.
> >>> >
> >>> > The SSVM going and downloading the built-in template is a good
> >>> milestone
> >>> in a CloudStack build.
> >>> >
> >>> > To be honest the mgmt. server should be able to go get the template
> >>> itself if required rather than making it a user installation step.
> >>> great idea, looking forward to your PR.
> >>>
> >>> >
> >>> > Kind regards,
> >>> >
> >>> > Paul Angus
> >>> >
> >>> > paul.an...@shapeblue.com
> >>> > www.shapeblue.com
> >>> > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> >>> > @shapeblue
> >>> >
> >>> >
> >>> >
> >>> > -Original Message-
> >>> > From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
> >>> > Sent: 19 May 2016 23:06
> >>> > To: dev 
> >>> > Subject: Re: Migrating CloudStack content from download.cloud.com
> >>> >
> >>> > sounds good, so if we put both sections together the worry is over.
> acs
> >>> is a complex system and requires a lot of reading so let''s not put it
> >>> in a
> >>> different section. would be duplicate code anyhow.
> >>> >
> >>> > On Thu, May 19, 2016 at 11:56 PM, Chiradeep Vittal <
> >>> chirade...@gmail.com>
> >>> > wrote:
> >>> >
> >>> > > Well, you have to define "worry" :)
> >>> > >
> >>> > > I'm proposing an almost identical step to
> >>> > >
> >>> > >
> >>> http://docs.cloudstack.apache.org/projects/cloudstack-installation/en/
> >>> > > 4.6/management-server/#prepare-the-system-vm-template
> >>> > >
> >>> > > If they can do that, then it is not a stretch to assume they can
> >>> > > download the default template in a similar manner. The
> >>> > > "cloud-install-default-template" (proposed) script can do the
> mirror
> >>> > > checking etc.
> >>> > >
> >>> > >
> >>> > >
> >>> > >
> >>> > > On Thu, May 19, 2016 at 2:44 PM, Will Stevens <
> wstev...@cloudops.com
> >>> >
> >>> > > wrote:
> >>> > >
> >>> > > > I definitely agree with this.  I don't think people doing a PoC
> >>> > > > should
> >>> > > have
> >>> > > > to worry about getting a template installed on first setup.  I
> >>> think
> >>> > > > that is a basic feature if we want platform adoption.  Getting
> the
> >>> > > > first boot process from download to first VM launched should be
> as
> >>> > > > smooth as
> >>> > > possible.
> >>> > > >
> >>> > > > *Will STEVENS*
> >>> > > > Lead Developer
> >>> > > >
> >>> > > > *CloudOps* *| *Cloud Solutions Experts
> >>> > > > 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6 w cloudops.com
> *|*
> >>> > > > tw @CloudOps_
> >>> > > >
> >>> > > > On Thu, May 19, 2016 at 5:37 PM, Daan Hoogland
> >>> > > > 
> >>> > > > wrote:
> >>> > > >
> >>> > > > > Chiradeep,
> >>> > > > >
> >>> > > > > It makes sense not to have this old default very insecure guest
> >>> > > template
> >>> > > > > still be downloaded but it would be nice to have some kind of
> >>> > > > > meta-data pointing to the latest version of an acceptable
> >>> template
> >>> > > > > (symlink) for trial installs so

Re: Migrating CloudStack content from download.cloud.com

is there no way, within foundation bylaws, to host this somewhere on
apache.org? we are using peoples wibesites for tests as well, aren't we.

On Fri, May 20, 2016 at 7:04 PM, Rafael Weingärtner <
rafaelweingart...@gmail.com> wrote:

> We could host a mirror here. We are in South America, Brazil.
>
> On Fri, May 20, 2016 at 2:01 PM, Chiradeep Vittal 
> wrote:
>
> > I was proposing a new S3 bucket earlier (templates.cloudstack.org), but
> I
> > realized that someone needs to own the account. There is no legal entity
> > for Apache CloudStack (except the ASF) that can enter into a contract
> with
> > AWS (even if it is for a few bucks a month).  To make this work,
> > alternatives:
> >  (1) ASF Infra creates this bucket and IAM keys to the PMC to operate
> this
> > bucket. ACS users might want to make targeted donations to support this
> > bucket, but I don't believe that it is possible.
> >
> > (2) Cloudstack.org gets registered as a (non-profit?) entity etc and ACS
> > users make donations to this entity. PMC has control over the bucket.
> >
> > A mirror list and a python script (e.g., [1]) sounds like a much better
> > idea :)
> >
> > Raise of hands:
> > Who is willing to host a mirror of systemvm templates and default
> > templates. I figure we need at least 5, preferably all over the world,
> > especially in East Asia.
> >
> > [1]
> >
> >
> http://code.activestate.com/recipes/284631-a-python-script-to-test-download-mirrors/
> >
> >
> >
> >
> >
> > On Fri, May 20, 2016 at 9:52 AM, Chiradeep Vittal 
> > wrote:
> >
> > > Agree with Daan : we shouldn't be pushing these ancient insecure
> > > templates!
> > >
> > >
> > > On Fri, May 20, 2016 at 9:51 AM, Chiradeep Vittal <
> chirade...@gmail.com>
> > > wrote:
> > >
> > >> :) According to Raja, there is some time before download.cloud.com is
> > >> doomed. Let's pretend that date is Jan 1 2017. Now pretend that it is
> > Dec
> > >> 25, 2016 and we're still debating mirror list vs steps and what not.
> > Now,
> > >> just change the 2017 to 2016 and re-consider. We need this done
> > yesterday!
> > >>
> > >>
> > >>
> > >>
> > >>
> > >>
> > >>
> > >> On Fri, May 20, 2016 at 1:53 AM, Daan Hoogland <
> daan.hoogl...@gmail.com
> > >
> > >> wrote:
> > >>
> > >>> send by tablet, no warranties in existence
> > >>> On 20 May 2016 09:29, "Paul Angus"  wrote:
> > >>> >
> > >>> > I'm a -1 on adding another step to the installation process.
> > >>> >
> > >>> > I agree with Will, it will only be another barrier to platform
> > >>> adoption.
> > >>> >
> > >>> > The SSVM going and downloading the built-in template is a good
> > >>> milestone
> > >>> in a CloudStack build.
> > >>> >
> > >>> > To be honest the mgmt. server should be able to go get the template
> > >>> itself if required rather than making it a user installation step.
> > >>> great idea, looking forward to your PR.
> > >>>
> > >>> >
> > >>> > Kind regards,
> > >>> >
> > >>> > Paul Angus
> > >>> >
> > >>> > paul.an...@shapeblue.com
> > >>> > www.shapeblue.com
> > >>> > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> > >>> > @shapeblue
> > >>> >
> > >>> >
> > >>> >
> > >>> > -Original Message-
> > >>> > From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
> > >>> > Sent: 19 May 2016 23:06
> > >>> > To: dev 
> > >>> > Subject: Re: Migrating CloudStack content from download.cloud.com
> > >>> >
> > >>> > sounds good, so if we put both sections together the worry is over.
> > acs
> > >>> is a complex system and requires a lot of reading so let''s not put
> it
> > >>> in a
> > >>> different section. would be duplicate code anyhow.
> > >>> >
> > >>> > On Thu, May 19, 2016 at 11:56 PM, Chiradeep Vittal <
> > >>> chirade...@gmail.com>
> > >>> > wrote:
> > >>> >
> > >>> > > Well, you have to define "worry" :)
> > >>> > >
> > >>> > > I'm proposing an almost identical step to
> > >>> > >
> > >>> > >
> > >>>
> http://docs.cloudstack.apache.org/projects/cloudstack-installation/en/
> > >>> > > 4.6/management-server/#prepare-the-system-vm-template
> > >>> > >
> > >>> > > If they can do that, then it is not a stretch to assume they can
> > >>> > > download the default template in a similar manner. The
> > >>> > > "cloud-install-default-template" (proposed) script can do the
> > mirror
> > >>> > > checking etc.
> > >>> > >
> > >>> > >
> > >>> > >
> > >>> > >
> > >>> > > On Thu, May 19, 2016 at 2:44 PM, Will Stevens <
> > wstev...@cloudops.com
> > >>> >
> > >>> > > wrote:
> > >>> > >
> > >>> > > > I definitely agree with this.  I don't think people doing a PoC
> > >>> > > > should
> > >>> > > have
> > >>> > > > to worry about getting a template installed on first setup.  I
> > >>> think
> > >>> > > > that is a basic feature if we want platform adoption.  Getting
> > the
> > >>> > > > first boot process from download to first VM launched should be
> > as
> > >>> > > > smooth as
> > >>> > > possible.
> > >>> > > >
> > >>> > > > *Will STEVENS*
> > >>> > > > Lead Developer
> > >>> > > >
> > >>> > > > *CloudOps* *| *Cloud S

[GitHub] cloudstack pull request: Remodeling of Nuage VSP Plugin + CLOUDSTA...

2016-05-20 Thread KrisSterckx

Github user KrisSterckx commented on the pull request:

https://github.com/apache/cloudstack/pull/1494#issuecomment-220667799
  
Thanks @swill. Folks, pls review :)

Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Remodeling of Nuage VSP Plugin + CLOUDSTA...

2016-05-20 Thread GabrielBrascher

Github user GabrielBrascher commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1494#discussion_r64078451
  
--- Diff: 
plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java
 ---
@@ -270,15 +258,15 @@ public PingCommand getCurrentStatus(long id) {
 _shouldAudit = true;
 return null;
 }
-if (_cmsUserInfo == null || _cmsUserInfo.length < 2) {
+if (_cmsUserLogin == null || _cmsUserLogin.isEmpty() || 
_cmsUserPassword == null || _cmsUserPassword.isEmpty()) {
--- End diff --

@nlivens you can use StringUtils.isEmpty(CharString cs) 
[https://commons.apache.org/proper/commons-lang/apidocs/org/apache/commons/lang3/StringUtils.html]
 in order to check if a String is empty or null.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Remodeling of Nuage VSP Plugin + CLOUDSTA...

2016-05-20 Thread GabrielBrascher

Github user GabrielBrascher commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1494#discussion_r64080090
  
--- Diff: 
plugins/network-elements/nuage-vsp/src/com/cloud/util/NuageVspEntityBuilder.java
 ---
@@ -0,0 +1,370 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package com.cloud.util;
+
+import com.cloud.dc.VlanVO;
+import com.cloud.dc.dao.VlanDao;
+import com.cloud.domain.Domain;
+import com.cloud.domain.DomainVO;
+import com.cloud.domain.dao.DomainDao;
+import com.cloud.exception.InsufficientVirtualNetworkCapacityException;
+import com.cloud.network.Network;
+import com.cloud.network.NetworkModel;
+import com.cloud.network.dao.IPAddressDao;
+import com.cloud.network.dao.IPAddressVO;
+import com.cloud.network.dao.NetworkDetailsDao;
+import com.cloud.network.rules.FirewallRule;
+import com.cloud.network.vpc.NetworkACLItem;
+import com.cloud.network.vpc.VpcVO;
+import com.cloud.network.vpc.dao.VpcDao;
+import com.cloud.offerings.NetworkOfferingVO;
+import com.cloud.offerings.dao.NetworkOfferingDao;
+import com.cloud.offerings.dao.NetworkOfferingServiceMapDao;
+import com.cloud.user.AccountVO;
+import com.cloud.user.dao.AccountDao;
+import com.cloud.utils.exception.CloudRuntimeException;
+import com.cloud.utils.net.NetUtils;
+import com.cloud.vm.NicProfile;
+import com.cloud.vm.NicVO;
+import com.cloud.vm.VirtualMachine;
+import com.google.common.collect.Iterables;
+import com.google.common.collect.Lists;
+import net.nuage.vsp.acs.client.api.model.VspAclRule;
+import net.nuage.vsp.acs.client.api.model.VspDomain;
+import net.nuage.vsp.acs.client.api.model.VspNetwork;
+import net.nuage.vsp.acs.client.api.model.VspNic;
+import net.nuage.vsp.acs.client.api.model.VspStaticNat;
+import net.nuage.vsp.acs.client.api.model.VspVm;
+import net.nuage.vsp.acs.client.common.model.Pair;
+import org.apache.cloudstack.framework.config.dao.ConfigurationDao;
+import org.apache.commons.lang.StringUtils;
+import org.apache.log4j.Logger;
+
+import javax.inject.Inject;
+import java.util.HashSet;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Set;
+import java.util.TreeSet;
+
+public class NuageVspEntityBuilder {
+private static final Logger s_logger = 
Logger.getLogger(NuageVspEntityBuilder.class);
+
+@Inject
+VpcDao _vpcDao;
+@Inject
+DomainDao _domainDao;
+@Inject
+AccountDao _accountDao;
+@Inject
+NetworkOfferingDao _networkOfferingDao;
+@Inject
+NetworkOfferingServiceMapDao _networkOfferingServiceMapDao;
+@Inject
+NetworkModel _networkModel;
+@Inject
+VlanDao _vlanDao;
+@Inject
+ConfigurationDao _configurationDao;
+@Inject
+IPAddressDao _ipAddressDao;
+@Inject
+NetworkDetailsDao _networkDetailsDao;
--- End diff --

@nlivens shouldn't those variables be private? Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [Discuss] CloudStack documentation

2016-05-20 Thread Ron Wheeler

A couple of comments.

The definition of the audience for each document should be clearly
understood.
Size: What is targeted for large organizations (hundreds of servers)
with dedicated staff and sophisticated needs - what is targeted for SMB
(5-50 servers) with limited staff and simple needs. Where are new user
organizations coming from
Knowledge required - How to organize and present information in a way
that is accessible by dedicated specialists while making it easy for
system administrators with limited time and less specialized knowledge
to get what they need.

I may not understand the reStructured Text philosophy but it seems to be
very difficult to reuse topics and very hard to use any of the
documentation to build a custom manual for an installation. It seems to
be hard to avoid having the same idea expressed in multiple places with
contradictory terminology and sometime contradictory factual statements.
The monolithic nature of the topics makes it hard to follow the flow of
the documents and hard to share the editing tasks.

I have been using DITA and it seems like a better way to produce and
maintain documentation in that it encourages reuse rather than copy and
paste and breaks the documents into smaller more focused chunks that can
be maintained by edits that affect only a small fragment of text rather
than having to search through a large documents to find the places
requiring changes.

I will be attending the conference and will be providing a living
example of someone with almost no practical experience with Cloudstack
which I hope will balance out the great depth of the other participants
when it come to reviewing documentation for readability and clarity.

Ron

On 20/05/2016 10:43 AM, Rajsekhar K wrote:

Hi, All,

I agree with Dag Sonstebo that we need to improve the layout and navigation of
CloudStack documentation. I think that the improvement should begin from the
home page.

New users may not find the way the information presented on the home page very
intuitive. A few tweaking on the home page will help us improve the information
experience of CloudStack users.

Here are my thoughts on improving CloudStack documentation:

• Our users - mostly experienced administrators- would install CloudStack
and understand the basic concepts, deployment architecture, and terminologies
first. After doing this, they would be delighted to see the big picture of the
tasks that they can do with CloudStack.

So, a home page for CloudStack documentation that displays the big
picture of the tasks that the users can do with CloudStack will be appreciated.
We can display the big picture of the tasks in distinct content blocks on the
Home page. Each block will have a link to the documentation and a brief
description of the major task. Users will click the link to the documentation
to land on the page for that major task. They can, now, see the ToC for the
major ask. This ToC will delineate the flow of minor (sub) tasks that
constitute the major task.

• It is useful if we can incorporate videos and lectures on the Home
page. Professionally made videos will be very helpful to the users.

• I think we need to think beyond 'guides' (such as Installation Guide,
Administration Guide, and so on) when we present the information online.
CloudStack users would be delighted to see a topic that directly answers the
question in their mind (such as 'Configuring a XenServer host with CloudStack')
than logically locating a help topic by navigating to a guide first, then to a
section in the guide and then locating the information. They would be able to
access and read the documentation in non-linear manner.

• Let's ensure that the information on upgrading CloudStack is available
distinctly on the Home page. This will help avoid directing the users, who want
to upgrade to the next CloudStack version, to the Installation section.
Installation section can cater to the users who want to install CloudStack in
their environment.

• I think the home page should highlight the link to API reference pages.
Also, I feel that we must improve CloudStack API reference pages by
incorporating more useful information to each page.
Based on the discussions that we had in the community sometime back, I
have created a specification document and a template for API references at:
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Improving+CloudStack+API+References+-+Specifications

• We can consolidate all matrixes at one location. Along with
compatibility matrix, we need to identify information that we can present as
matrix. The users should be able to access all these information from the
documentation home page.

• I would like to mention the effort that we have started on creating a
reference book for the CloudStack configuration parameters. I hope, this will
enhance the information experience of CloudStack users by educat

[GitHub] cloudstack pull request: dynamic-roles: packaging improvements

Github user rhtyd commented on the pull request:

https://github.com/apache/cloudstack/pull/1551#issuecomment-220675652
  
Thanks @swill if we keep getting this error, I'll try to find some time to 
see what's causing this as well


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9377: Fix metrics pagesize iss...

Github user rhtyd commented on the pull request:

https://github.com/apache/cloudstack/pull/1540#issuecomment-220675720
  
Thanks @swill 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9348: NioConnection improvemen...

Github user rhtyd commented on the pull request:

https://github.com/apache/cloudstack/pull/1549#issuecomment-220675936
  
@swill thank you for your time in testing this


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9348: NioConnection improvemen...

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1549#issuecomment-220715003
  
And of course the first build I do after I merge it into master I get the 
`addHost` error and I did not get it once after I pulled it out.  Haha...  I 
will build again and see...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9348: NioConnection improvemen...

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1549#issuecomment-220715486
  
@rhtyd can you specify the logs you need if I run into this issue so you 
can track down why it is happening?  I will leave it in for now but I would 
like to send you the logs every time there is an issue so you can understand 
what is going on so we can try to fix it (once and for all).  Thanks...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: dynamic-roles: packaging improvements

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1551#issuecomment-220715917
  
I am getting it on almost every PR right now (if you notice the last 6 or 7 
CI runs), so I will have to review this as it seems to have been introduced 
recently...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: dynamic-roles: packaging improvements

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1551#issuecomment-220716022
  
I think since it is an intermittent issue, we did not catch it on the 
actual PR it was introduced in.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Migrating CloudStack content from download.cloud.com

Cant we just host the mirror list in apache.org and then actually host the
mirrors in different places around the world?  A company could sponsor the
few bucks a month for AWS and have one of the mirrors be in AWS and the
mirror list in apache.org would just be updated to add the AWS mirror.

Isn't that basically what we are proposing here?  The ability to have
different mirrors with the 'official' endpoint being in an apache.org
endpoint to list the mirrors?

*Will STEVENS*
Lead Developer

*CloudOps* *| *Cloud Solutions Experts
420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
w cloudops.com *|* tw @CloudOps_

On Fri, May 20, 2016 at 1:17 PM, Daan Hoogland 
wrote:

> is there no way, within foundation bylaws, to host this somewhere on
> apache.org? we are using peoples wibesites for tests as well, aren't we.
>
> On Fri, May 20, 2016 at 7:04 PM, Rafael Weingärtner <
> rafaelweingart...@gmail.com> wrote:
>
> > We could host a mirror here. We are in South America, Brazil.
> >
> > On Fri, May 20, 2016 at 2:01 PM, Chiradeep Vittal 
> > wrote:
> >
> > > I was proposing a new S3 bucket earlier (templates.cloudstack.org),
> but
> > I
> > > realized that someone needs to own the account. There is no legal
> entity
> > > for Apache CloudStack (except the ASF) that can enter into a contract
> > with
> > > AWS (even if it is for a few bucks a month).  To make this work,
> > > alternatives:
> > >  (1) ASF Infra creates this bucket and IAM keys to the PMC to operate
> > this
> > > bucket. ACS users might want to make targeted donations to support this
> > > bucket, but I don't believe that it is possible.
> > >
> > > (2) Cloudstack.org gets registered as a (non-profit?) entity etc and
> ACS
> > > users make donations to this entity. PMC has control over the bucket.
> > >
> > > A mirror list and a python script (e.g., [1]) sounds like a much better
> > > idea :)
> > >
> > > Raise of hands:
> > > Who is willing to host a mirror of systemvm templates and default
> > > templates. I figure we need at least 5, preferably all over the world,
> > > especially in East Asia.
> > >
> > > [1]
> > >
> > >
> >
> http://code.activestate.com/recipes/284631-a-python-script-to-test-download-mirrors/
> > >
> > >
> > >
> > >
> > >
> > > On Fri, May 20, 2016 at 9:52 AM, Chiradeep Vittal <
> chirade...@gmail.com>
> > > wrote:
> > >
> > > > Agree with Daan : we shouldn't be pushing these ancient insecure
> > > > templates!
> > > >
> > > >
> > > > On Fri, May 20, 2016 at 9:51 AM, Chiradeep Vittal <
> > chirade...@gmail.com>
> > > > wrote:
> > > >
> > > >> :) According to Raja, there is some time before download.cloud.com
> is
> > > >> doomed. Let's pretend that date is Jan 1 2017. Now pretend that it
> is
> > > Dec
> > > >> 25, 2016 and we're still debating mirror list vs steps and what not.
> > > Now,
> > > >> just change the 2017 to 2016 and re-consider. We need this done
> > > yesterday!
> > > >>
> > > >>
> > > >>
> > > >>
> > > >>
> > > >>
> > > >>
> > > >> On Fri, May 20, 2016 at 1:53 AM, Daan Hoogland <
> > daan.hoogl...@gmail.com
> > > >
> > > >> wrote:
> > > >>
> > > >>> send by tablet, no warranties in existence
> > > >>> On 20 May 2016 09:29, "Paul Angus" 
> wrote:
> > > >>> >
> > > >>> > I'm a -1 on adding another step to the installation process.
> > > >>> >
> > > >>> > I agree with Will, it will only be another barrier to platform
> > > >>> adoption.
> > > >>> >
> > > >>> > The SSVM going and downloading the built-in template is a good
> > > >>> milestone
> > > >>> in a CloudStack build.
> > > >>> >
> > > >>> > To be honest the mgmt. server should be able to go get the
> template
> > > >>> itself if required rather than making it a user installation step.
> > > >>> great idea, looking forward to your PR.
> > > >>>
> > > >>> >
> > > >>> > Kind regards,
> > > >>> >
> > > >>> > Paul Angus
> > > >>> >
> > > >>> > paul.an...@shapeblue.com
> > > >>> > www.shapeblue.com
> > > >>> > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> > > >>> > @shapeblue
> > > >>> >
> > > >>> >
> > > >>> >
> > > >>> > -Original Message-
> > > >>> > From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
> > > >>> > Sent: 19 May 2016 23:06
> > > >>> > To: dev 
> > > >>> > Subject: Re: Migrating CloudStack content from
> download.cloud.com
> > > >>> >
> > > >>> > sounds good, so if we put both sections together the worry is
> over.
> > > acs
> > > >>> is a complex system and requires a lot of reading so let''s not put
> > it
> > > >>> in a
> > > >>> different section. would be duplicate code anyhow.
> > > >>> >
> > > >>> > On Thu, May 19, 2016 at 11:56 PM, Chiradeep Vittal <
> > > >>> chirade...@gmail.com>
> > > >>> > wrote:
> > > >>> >
> > > >>> > > Well, you have to define "worry" :)
> > > >>> > >
> > > >>> > > I'm proposing an almost identical step to
> > > >>> > >
> > > >>> > >
> > > >>>
> > http://docs.cloudstack.apache.org/projects/cloudstack-installation/en/
> > > >>> > > 4.6/management-server/#prepare-the-system-vm-template
> > > >>> > >
> > >

[GitHub] cloudstack pull request: CLOUDSTACK-9348: NioConnection improvemen...

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1549#issuecomment-220735448
  
@rhtyd uggg...  The first two builds on master after merging this back in 
have both resulted in the `addHost` error.  :(  Let me know what you need to 
troubleshoot this.  I have a couple PRs I want to do a final round of testing 
on, so I will try to get them tested and we will see if they also run into this 
issue when I try to test them.  If they do, I may have to revert again.  I am 
trying my best to get a bunch of the PRs that are close in, so I am pushing the 
freeze date a bit (obviously).  I will probably freeze over the weekend or 
early next week.  I would like to make sure we have this resolved though.  I 
don't want this to derail my final testing.  I will launch a bunch more CI 
right now and we will see how things go...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Variable renaming in classes meant for Agents

Can you add your link for [1], I think you forgot to add the link.  I was
not aware of a coding standard for this project.  I know there has been
debated a lot recently about the preceding `_` on some variables.
Historically it was done that way, but recently a lot of people have taken
offense to it.  I don't care what format the community agrees on, but I
understand why people follow the existing styling.  Also, I think that if
we ask someone to remove the `_` in their PR for a class, we should also
ask them to remove it for the entire class because the only thing worse
than not following a standard is to have both situations in a single
class.  Thats just my opinion, but as a developer, that would drive me
nuts...

*Will STEVENS*
Lead Developer

*CloudOps* *| *Cloud Solutions Experts
420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
w cloudops.com *|* tw @CloudOps_

On Fri, May 20, 2016 at 12:42 PM, Rafael Weingärtner <
rafaelweingart...@gmail.com> wrote:

> You are right Mike about the “_”. The point is that in some other language
> the use of “_” makes sense, whereas in Java it does not, at least not the
> way it has being used in ACS.
>
> We have code conventions, it can be found in [1]. The problem is that it is
> a bit outdated and I think it could benefit from some others tutorials. For
> instance, a clear and simple tutorial explaining what is a test case and
> showing how to create a proper test case; I am referring to the
> unit/integration test case that we write using Junit and other tools.
>
> Also, we lack some information on how to prepare code to be tested.
> Once we have that kind of standard defined and tutorials written, we could
> work out ways to educate our community. It is not a problem not to know
> those things; we cannot expect everyone to know how to use every single
> methodology and technology that is out there. But, we can help people to
> learn, that is the point of a community, it should be a place where people
> exchange ideas and experience in a way that benefits everyone.
>
> As soon as you open the PR, please let us know, so we can review it and
> help you get it merge as soon as possible. I think this is something that
> should go in the 4.9 release.
>
>
> On Fri, May 20, 2016 at 1:27 PM, Tutkowski, Mike <
> mike.tutkow...@netapp.com>
> wrote:
>
> > It sounds like most people don't like a preceding "_" for member
> variables
> > and that is fine. Do we have any formal Java coding standards for
> > CloudStack, by the way? I'm not aware of any.
> >
> > The main problem here, though, is that this particular piece of code is
> > super fragile, so it would be great to harden it up.
> >
> > I'm going to open a PR and revert the names in those changed "Command"
> > files for 4.9. That will solve the immediate problem.
> > 
> > From: Rafael Weingärtner 
> > Sent: Friday, May 20, 2016 9:12 AM
> > To: dev@cloudstack.apache.org
> > Subject: Re: Variable renaming in classes meant for Agents
> >
> > Hi guys,
> > I agree with Daan that if class fields have improper (not descriptive or
> > not suitable) names we should change them. However, I do not find the
> > change (on variable names) introduced by PR #816 good. It added an
> > “_”(underline) before variable names; even though Apache CloudStack has a
> > lot of that currently, I think that is a pattern we should avoid.
> >
> > Your ideas to use annotations to avoid relying on variable names are
> great;
> > but, let’s not re-create the well here. There is a research [1] that has
> > been conducted in 2014 that tackled exactly that problem; the proposal
> > presented in [1] decoupled client and server sides from variable name by
> > using semantic annotations. The concept, the formalization and the
> > experiments are all presented in paper [1]. The serialization and
> > deserialization core of the proposal presented in [1] can be found in
> [2].
> >
> > The idea of decoupling our web APIs from variable names is great, but it
> is
> > something that will require some effort to be fully and properly
> > implemented. If you wish to push that forward count on me.
> >
> > [1] http://ieeexplore.ieee.org/xpls/abs_all.jsp?arnumber=6928953&tag=1
> > [2] https://github.com/ivansalvadori/gsonld
> >
> >
> > On Fri, May 20, 2016 at 3:30 AM, Daan Hoogland 
> > wrote:
> >
> > > Guys, we should rename fields that have improper names. I do not agreee
> > > with the statement at all. Your two solutions to the serialisation
> hazard
> > > are both acceptable to me. leaving a non compliant or non explanatory
> > name
> > > in because it slipped through the nets at some points does not seem
> > > acceptable to me. We must improve are code.
> > >
> > > On Fri, May 20, 2016 at 6:53 AM, Tutkowski, Mike <
> > > mike.tutkow...@netapp.com>
> > > wrote:
> > >
> > > > Thanks for sending out this e-mail, Anshul.
> > > >
> > > > This is a bit of a strange situation because we need to make sure
> > people
> > > > are either

Re: Variable renaming in classes meant for Agents

You are right Will.
I am sorry for the link, here it is:
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Coding+conventions

On Fri, May 20, 2016 at 7:52 PM, Will Stevens  wrote:

> Can you add your link for [1], I think you forgot to add the link.  I was
> not aware of a coding standard for this project.  I know there has been
> debated a lot recently about the preceding `_` on some variables.
> Historically it was done that way, but recently a lot of people have taken
> offense to it.  I don't care what format the community agrees on, but I
> understand why people follow the existing styling.  Also, I think that if
> we ask someone to remove the `_` in their PR for a class, we should also
> ask them to remove it for the entire class because the only thing worse
> than not following a standard is to have both situations in a single
> class.  Thats just my opinion, but as a developer, that would drive me
> nuts...
>
> *Will STEVENS*
> Lead Developer
>
> *CloudOps* *| *Cloud Solutions Experts
> 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
> w cloudops.com *|* tw @CloudOps_
>
> On Fri, May 20, 2016 at 12:42 PM, Rafael Weingärtner <
> rafaelweingart...@gmail.com> wrote:
>
> > You are right Mike about the “_”. The point is that in some other
> language
> > the use of “_” makes sense, whereas in Java it does not, at least not the
> > way it has being used in ACS.
> >
> > We have code conventions, it can be found in [1]. The problem is that it
> is
> > a bit outdated and I think it could benefit from some others tutorials.
> For
> > instance, a clear and simple tutorial explaining what is a test case and
> > showing how to create a proper test case; I am referring to the
> > unit/integration test case that we write using Junit and other tools.
> >
> > Also, we lack some information on how to prepare code to be tested.
> > Once we have that kind of standard defined and tutorials written, we
> could
> > work out ways to educate our community. It is not a problem not to know
> > those things; we cannot expect everyone to know how to use every single
> > methodology and technology that is out there. But, we can help people to
> > learn, that is the point of a community, it should be a place where
> people
> > exchange ideas and experience in a way that benefits everyone.
> >
> > As soon as you open the PR, please let us know, so we can review it and
> > help you get it merge as soon as possible. I think this is something that
> > should go in the 4.9 release.
> >
> >
> > On Fri, May 20, 2016 at 1:27 PM, Tutkowski, Mike <
> > mike.tutkow...@netapp.com>
> > wrote:
> >
> > > It sounds like most people don't like a preceding "_" for member
> > variables
> > > and that is fine. Do we have any formal Java coding standards for
> > > CloudStack, by the way? I'm not aware of any.
> > >
> > > The main problem here, though, is that this particular piece of code is
> > > super fragile, so it would be great to harden it up.
> > >
> > > I'm going to open a PR and revert the names in those changed "Command"
> > > files for 4.9. That will solve the immediate problem.
> > > 
> > > From: Rafael Weingärtner 
> > > Sent: Friday, May 20, 2016 9:12 AM
> > > To: dev@cloudstack.apache.org
> > > Subject: Re: Variable renaming in classes meant for Agents
> > >
> > > Hi guys,
> > > I agree with Daan that if class fields have improper (not descriptive
> or
> > > not suitable) names we should change them. However, I do not find the
> > > change (on variable names) introduced by PR #816 good. It added an
> > > “_”(underline) before variable names; even though Apache CloudStack
> has a
> > > lot of that currently, I think that is a pattern we should avoid.
> > >
> > > Your ideas to use annotations to avoid relying on variable names are
> > great;
> > > but, let’s not re-create the well here. There is a research [1] that
> has
> > > been conducted in 2014 that tackled exactly that problem; the proposal
> > > presented in [1] decoupled client and server sides from variable name
> by
> > > using semantic annotations. The concept, the formalization and the
> > > experiments are all presented in paper [1]. The serialization and
> > > deserialization core of the proposal presented in [1] can be found in
> > [2].
> > >
> > > The idea of decoupling our web APIs from variable names is great, but
> it
> > is
> > > something that will require some effort to be fully and properly
> > > implemented. If you wish to push that forward count on me.
> > >
> > > [1] http://ieeexplore.ieee.org/xpls/abs_all.jsp?arnumber=6928953&tag=1
> > > [2] https://github.com/ivansalvadori/gsonld
> > >
> > >
> > > On Fri, May 20, 2016 at 3:30 AM, Daan Hoogland <
> daan.hoogl...@gmail.com>
> > > wrote:
> > >
> > > > Guys, we should rename fields that have improper names. I do not
> agreee
> > > > with the statement at all. Your two solutions to the serialisation
> > hazard
> > > > are both acceptable to me. leaving a non compliant o

Re: Variable renaming in classes meant for Agents