[GitHub] cloudstack pull request: CLOUDSTACK-9340: General DB Optimization
Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1466#issuecomment-207823632 Thanks @rafaelweingartner, @swill and @bhaisaab for your help. I pushed changes again --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9340: General DB Optimization
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1466#issuecomment-207824671 @nvazquez can you explain how did you find out which keys (i.e indexes) to drop? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Restore iptables at once using iptables-r...
GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/1482 Restore iptables at once using iptables-restore instead of calling iptables numerous times This makes handling the firewall rules about 50-60 times faster because it is generated in memory and then loaded once. It's work by @borisroman see PR #1400. Reopened it here because I think this is a great improvement. You can merge this pull request into a Git repository by running: $ git pull https://github.com/remibergsma/cloudstack iptables-fix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1482.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1482 commit 0f75042566b7cc72666708485bdaa9337721e9fe Author: Boris Schrijver Date: 2016-02-01T14:57:26Z Add iptables copnversion script. Source: https://raw.githubusercontent.com/sl0/conv/master/iptables_converter.py commit b857f79fcb14b9594840e483cfcf0e4c0fac2f6b Author: Boris Schrijver Date: 2016-02-01T14:58:27Z Restore iptables at once using iptables-restore instead of calling iptables numerous times commit 69e9348900e6337a16788a54283d5c9ee3b7a221 Author: Boris Schrijver Date: 2016-02-03T14:30:19Z Remove duplicate spaces, and thus duplicate rules. commit eb9706b6558d5113000a6c10d861308fbc8cd692 Author: Boris Schrijver Date: 2016-02-03T15:15:28Z Wait for dnsmasq to finish restart commit 18d5cd285536954403cf5eec64024e5909e55d41 Author: Boris Schrijver Date: 2016-02-05T20:04:06Z Do not load previous firewall rules as we replace everyhing anyway commit 709be45cf0f32bacc54ec2384be9e54bd62a5acf Author: Boris Schrijver Date: 2016-02-05T20:06:53Z Check the existence of 'forceencap' parameter before use commit 30741a3309da346f324a8f365cb6ef8e1aab39d8 Author: Boris Schrijver Date: 2016-02-05T20:11:59Z Split the cidr lists so we won't hit the iptables-resture limits --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9287 - Fix unique mac address ...
GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/1483 CLOUDSTACK-9287 - Fix unique mac address per rVPC router This is work by @wilderrodrigues, see PR #1413 It contains important fixes and I think it needs to be included so I send the PR again. You can merge this pull request into a Git repository by running: $ git pull https://github.com/remibergsma/cloudstack pr1413-wilder-47 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1483.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1483 commit f921ec686bcf339968040c57bf0ae9fceffd8fed Author: Wilder Rodrigues Date: 2016-02-13T11:59:20Z CLOUDSTACK-9287 - Generate new mac address if router is redundant and nic profile exists commit d93b008deb2ced326b314fefbe11511d798be5e8 Author: Wilder Rodrigues Date: 2016-02-13T14:48:30Z CLOUDSTACK-9287 - Put private gateway interface down on backup router commit 250be376e879b6c43792fdb5af0f5c49747689da Author: Wilder Rodrigues Date: 2016-02-13T16:29:14Z CLOUDSTACK-9287 - Add integration test to cover the private gw interface/mac address issues commit 057b54aa3e8a462b3ced9b53d7a55dd5a64a0e4e Author: Remi Bergsma Date: 2016-02-14T13:39:53Z CLOUDSTACK-9287 - Make sure private gw interface is not used for default gw commit 6a767732f959186e95c71d31a2ed49bb67a85473 Author: Remi Bergsma Date: 2016-02-14T17:09:03Z CLOUDSTACK-9287 - Bring up the private gw interface on state change to master commit 850fb1a557b8eec04de79124fea5b6f923530d66 Author: Wilder Rodrigues Date: 2016-02-17T06:16:23Z CLOUDSTACK-9287 - Check if the nic profile has already been removed from a certain router - In case of redundant VPCs, the ACL items are revoked in the first iteration. Since the econd iteration is needed in order to remove the private network, we have to check if the nic profile is gone before trying to revoke the ACL items again, which would throw a NPE. - Some variable extraction in order to ease debugging. commit c41edc1fe62cf92ab85c59c6da4dced9e626d961 Author: Wilder Rodrigues Date: 2016-02-17T06:31:39Z CLOUDSTACK-9287 - Refactor the interface state configuration - This also refactors the CsAddress in order to offer better readability in a couple of methods. commit 0e91468964b3b256497fa9dac50c63f9235ca102 Author: Wilder Rodrigues Date: 2016-02-17T06:33:48Z CLOUDSTACK-9287 - Add integration test to cover the private gateway related changes commit 78bbd498e7c7cb58570025b85d02c8ff921065d5 Author: Wilder Rodrigues Date: 2016-02-17T15:07:34Z CLOUDSTACK-9287 - Fix RVR public interface commit ffd8fdb45debe1ddcdf7c6706725cd26d4742cf2 Author: Wilder Rodrigues Date: 2016-02-17T15:43:16Z CLOUDSTACK-9287 - Improve test by checking if pvt gw is removed and fix typos --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Cloudstack-9285 exception log addition
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/1479#issuecomment-207838857 @kiwiflyer I can't seem to find that PR discussion you mention. Maybe you got the wrong handle? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: [ANNOUNCE] Registration open for CloudStack Collaboration Conference North America 2016
We've just completed the new cloudstackcollab website http://cloudstackcollab.net/ for the CloudStack Collaboration event. There are still speaking spots available, So if you have a topic you would like to present, please submit your talk... See you in June ! Pierre-Luc On Wed, Mar 30, 2016 at 3:15 PM, Pierre-Luc Dion wrote: > Minor clarification, > > Has you will see on the event site, it's from June 1st to 3rd. Since we > are expecting people traveling on June 1st we were planning to startup the > event on the Wednesday (June 1st) late afternoon. It's still not clear if > we would initiate the hackathon, or perform a round table about all things > going on in CloudStack, it is a TBD but also open to suggestion. Happy hour > might happen too. > > Regards, > > > On Wed, Mar 30, 2016 at 2:50 PM, Pierre-Luc Dion > wrote: > >> All, >> >> We are pleased to announce that the registration for the CloudStack >> Collaboration Conference North America 2016 is open. We would like to >> invite you all to Montreal, Canada on June 2 and 3 to participate in this >> conference. Registrations are now available, so head over to the evenbrite ( >> https://www.eventbrite.ca/e/apache-cloudstacktm-conference-montreal-2016-tickets-23815552960) >> to >> register your tickets today. >> >> The call-for-papers is also still open. There are still speaking spots >> available, so if you have a topic you would like to present, please submit >> your talk using the following form: https://goo.gl/r5Wmjk >> >> >> Hope to see you all in Montreal! >> >> Kind Regards, >> >> CCCNA Organizers >> >> >
[GitHub] cloudstack pull request: CLOUDSTACK-9287 - Fix unique mac address ...
Github user alexandrelimassantana commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1483#discussion_r59121072 --- Diff: server/src/com/cloud/network/element/VpcVirtualRouterElement.java --- @@ -466,7 +466,7 @@ public boolean deletePrivateGateway(final PrivateGateway gateway) throws Concurr } } -return result > 0 ? true : false; +return result == routers.size() ? true : false; } --- End diff -- This line is equivallent to ```Java return result == routers.size(); ``` please take the ternary operator away --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Cloudstack-9285 exception log addition
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1479#issuecomment-207861224 I apologize @miguelaferreira. You are correct, I tagged the wrong handle. It was actually @rafaelweingartner. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: PRs for 4.9 Release
I'd LOVE to see this in 4.9, a much needed feature. " CLOUDSTACK-9203 Implement security group move on updateVM API call #1297 " https://github.com/apache/cloudstack/pull/1297 -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro - Original Message - > From: "Will Stevens" > To: dev@cloudstack.apache.org > Sent: Thursday, 7 April, 2016 17:15:38 > Subject: PRs for 4.9 Release > I know this is not how this usually works, but I need to crowd source some > info to be more effective. > > I am slowly getting things rolling for the 4.9 release. My CI is chugging > away and I have a queue of PRs to get tested, so I will be getting through > them as quickly as I can. I have finally gotten to where I have a > relatively steady stream of merges going in and I am working through final > logistics on a whole bunch. > > I would like some help prioritizing PRs that we feel MUST get into 4.9. > There are almost 200 PRs open right now so it is not realistic for me to > expect to get them all into the 4.9 release simply due to the number of CI > hours needed. > > If you know of PRs that you think are important to get in, please reply > with a link to the Github PR so I can get them into my active list. > > One more thing... > > If you have any extra hardware available that is not currently being used > and you are willing to help with the CI effort, please email me and I will > get you setup so you can contribute to testing. I would like to try to get > a distributed network of CI environments working to better test the ACS > code base, so even if you only have the hardware free for 2 weeks, we can > make use of it. I can help you get the hardware up and running ready for > testing in a couple hours. > > Thanks you for the support... > > Will
[GitHub] cloudstack pull request: Cloudstack-9285 exception log addition
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1479#issuecomment-207866865 For whatever reason, I can't seem to force push this. I'll try again from my laptop this evening. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1331#issuecomment-207898130 @rafaelweingartner Done. Although I didn't create any test cases yet. There is nothing much to test. The function doesn't throw any execptions, doesn't expect any results so I think this should be good. @swill I've rebased again so it is still a single commit --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1423#issuecomment-207898283 @swill I beleieve we can do a better test. After the VPN is set up we can do something like `ike-scan -M 172.16.21.200` to see if the VPN opened up. I'll test this and update --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Remove unused params from NetworkHelperIm...
GitHub user GabrielBrascher opened a pull request:
https://github.com/apache/cloudstack/pull/1484
Remove unused params from NetworkHelperImpl.start method
The contributions of this PR are:
- Removed unused params ("User" and "Account") from:
- method that does nothing with the variables:
com.cloud.network.router.NetworkHelperImpl.start(DomainRouterVO,
Map, DeploymentPlan);
- method that calls the "NetworkHelperImpl.start" method:
com.cloud.network.router.NetworkHelperImpl.startVirtualRouter(DomainRouterVO,
Map);
- method from the interface :
com.cloud.network.router.NetworkHelperImpl.startVirtualRouter(DomainRouterVO,
Map).
- removed **_** from variables names: private variables with **_** at the
beginning is common in C++ but not in Java;
- changed access level of some variables from protected or public to
private;
- removed variables that are not read.
This PR intends to perform simple changes in order to improve the code of
the following classes:
- com.cloud.network.router.NetworkHelper
- com.cloud.network.router.NetworkHelperImpl
- com.cloud.network.router.VirtualNetworkApplianceManagerImpl
- com.cloud.network.router.VpcVirtualNetworkApplianceManagerImpl
- com.cloud.network.router.VpcNetworkHelperImpl
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/GabrielBrascher/cloudstack
brascher-NetworkHelperImplUnusedParams
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1484.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1484
commit 893bdeea24a64818ff5ede2059393930565d462d
Author: gabrascher
Date: 2016-04-10T03:26:02Z
Remove unused params from NetworkHelperImpl.start.
This commit also changes the access level of variables, removes
unused variables and "_" from beginning of names.
- Remove unused params ("User" and "Account") from:
- method that does nothing with the variables:
com.cloud.network.router.NetworkHelperImpl.start(DomainRouterVO,
Map, DeploymentPlan);
- method that calls the start method:
com.cloud.network.router.NetworkHelperImpl.startVirtualRouter(DomainRouterVO,
Map);
- method from the interface :
com.cloud.network.router.NetworkHelperImpl.startVirtualRouter(DomainRouterVO,
Map).
- Removed â_â from variables names: private variables with â_â at
the
beginning is common in C++ but not in Java;
- Methods and variables access level reviewed, changing some variables
from protected or public to private;
- Remove variables that are not read.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Removed unused code from com.cloud.api.Ap...
Github user GabrielBrascher commented on the pull request: https://github.com/apache/cloudstack/pull/1263#issuecomment-207914050 Seems that `push -f` is not making the Jenkins and Travis to rerun their tests. Is there any workaround for that? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1423#issuecomment-207917699 thank you sir. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
