[GitHub] cloudstack pull request: L10N update before 4.7.0 RC1

[milamberspace]

Github user milamberspace commented on the pull request:

https://github.com/apache/cloudstack/pull/1217#issuecomment-164242640
  
@remibergsma Probably yes, no more update on Transifex since the Dutch. You 
can merge this just before the start of RC process. Thanks.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9153: When negative credits ar...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1234#issuecomment-164243359
  
@agneya2001 looks good, I don't understand all of it yet, partly because 
this is rather new functionality. Any plans on integration tests?

I'll add some questions and comments and run number 1234 through the 
regression suite. ;)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9153: When negative credits ar...

[agneya2001]

Github user agneya2001 commented on the pull request:

https://github.com/apache/cloudstack/pull/1234#issuecomment-164243999
  
@DaanHoogland  This does have a smoke test here: 
test/integration/smoke/test_quota.py. This is very basic, will add more test 
scenarios to it. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9153: When negative credits ar...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1234#issuecomment-164244364
  
Thanks abhi, I will run it after the regular suite passes and add it to my 
fork of it, and of course report here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9153: When negative credits ar...

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1234#discussion_r47442747
  
--- Diff: 
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
 ---
@@ -383,31 +383,41 @@ public QuotaTariffVO 
updateQuotaTariffPlan(QuotaTariffUpdateCmd cmd) {
 
 @Override
--- End diff --

it is removed from QuotaResponseBuilder (why?) but still marked as 
@Override here. any purpose?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9153: When negative credits ar...

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1234#discussion_r47442757
  
--- Diff: 
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
 ---
@@ -95,7 +95,7 @@
 @Inject
 private DomainDao _domainDao;
 @Inject
-private RegionManager _regionMgr;
+private AccountManager _accountMgr;
--- End diff --

out of scope: let's get rid of the '_'-prefix convention.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9153: When negative credits ar...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1234#issuecomment-164246827
  
@agneya2001 is this 'only' a major bug? it seems to me to be the purpose of 
the quota system. blocker may be overdone but I really like this in before 4.7 
as regular part of the quota system. ping @remibergsma 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9155 make sure logrotate is ef...

[remibergsma]

GitHub user remibergsma opened a pull request:

https://github.com/apache/cloudstack/pull/1235

CLOUDSTACK-9155 make sure logrotate is effective for cloud.log

Many processes on the VRs log to cloud.log. When log rotate kicks in, the 
file is rotated but the scripts still write to the old inode (cloud.log.1 after 
rotate). Tis quickly fills up the tiny log partition.

Using 'copytruncate' is a small tradeoff, there is a slight change of 
missing a log entry, but in the old situation nothing ended up in cloud.log 
after rotate (except for stuff that was (re)started) so I think this is the 
best solution until we properly rewrite the script to either use their own 
script or syslog.

More details: https://issues.apache.org/jira/browse/CLOUDSTACK-9155

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/remibergsma/cloudstack 
fix-passwd-server-logging

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1235.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1235


commit 0742535e13c51372c63b045181d6a20198fb397e
Author: Remi Bergsma 
Date:   2015-12-13T10:53:45Z

CLOUDSTACK-9155 make sure logrotate is effective

Many processes on the VRs log to cloud.log. When logrotate
kicks in, the file is rotated but the scripts still write
to the old inode (cloud.log.1 after rotate). Tis quickly
fills up the tiny log partition.

Using 'copytruncate' is a tradeoff, there is a slight
change of missing a log entry, but in the old situation
we were missing all of them after logrotate.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9155 make sure logrotate is ef...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1235#issuecomment-164247329
  
Pinging @wilderrodrigues @fborn @DaanHoogland @borisroman to review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9153: When negative credits ar...

[agneya2001]

Github user agneya2001 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1234#discussion_r47443252
  
--- Diff: 
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
 ---
@@ -383,31 +383,41 @@ public QuotaTariffVO 
updateQuotaTariffPlan(QuotaTariffUpdateCmd cmd) {
 
 @Override
--- End diff --

There were two "addQuotaCredits" methods here, the first one with only a 
check. So combined the two. That removed on '@override' but still kept the 
'@Override' of the removed method.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9153: When negative credits ar...

[agneya2001]

Github user agneya2001 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1234#discussion_r47443258
  
--- Diff: 
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
 ---
@@ -95,7 +95,7 @@
 @Inject
 private DomainDao _domainDao;
 @Inject
-private RegionManager _regionMgr;
+private AccountManager _accountMgr;
--- End diff --

Noted.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9153: When negative credits ar...

[agneya2001]

Github user agneya2001 commented on the pull request:

https://github.com/apache/cloudstack/pull/1234#issuecomment-164248806
  
Kept it as a major bug as the account with negative quota will still get 
locked if quota is enforced, by the quota service thread, when it runs next.

While with this fix you can lock the account with the add credit API, 
instead of waiting for quota service to do that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9155 make sure logrotate is ef...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1235#issuecomment-164251561
  
@remibergsma sounds like the scripts that are the problem do an open for 
write instead of log-call, do they? I saw your list of processes and most of 
them seem legit. Any idea which is the culprit. It seems like a quickfix.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9153: When negative credits ar...

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1234#discussion_r47443410
  
--- Diff: 
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
 ---
@@ -383,31 +383,41 @@ public QuotaTariffVO 
updateQuotaTariffPlan(QuotaTariffUpdateCmd cmd) {
 
 @Override
--- End diff --

Yes I saw, sorry for the confusion. I wasn't paying attention at first.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9155 make sure logrotate is ef...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1235#issuecomment-164253007
  
@DaanHoogland There are many different solutions in place, some are 
bash/python scripts that do `>/var/log/cloud.log` etc, some use `nohup` to keep 
running and others are daemons that also log into the same file. There is no 
easy way to make logrotate restart those without some refactoring.

Also, close to release I didn't want to refactor the whole thing, as we'll 
have regression issues from that if we do it too quickly. This seems a safe fix 
for now, we should refactor it in the next release. Using syslog could be a 
simple solution, as that handles many of these scenarios already.

This is the best way to resolve the issue now IMHO.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9151 - As a Developer I want t...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/1231#issuecomment-164253054
  
Thanks @DaanHoogland @remibergsma @bhaisaab and @borisroman for reacting 
very quickly!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9155 make sure logrotate is ef...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1235#issuecomment-164253411
  
@remibergsma agree and let's not close the jira ticket on merging as this 
obviously needs tlc.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9155 make sure logrotate is ef...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/1235#issuecomment-164253492
  
The change LGTM. We should get this in and for ACS 4.8  we do a refactor in 
order to have a proper solution in place.

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9155 make sure logrotate is ef...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1235#issuecomment-164254871
  
Before PR this was seen after log rotate:
```
root@r-996-VM:/etc# lsof | grep cloud.log.1
_plutorun 767 root 3w REG 202,10 26054919 71 /var/log/cloud.log.1
logger 768 root 3w REG 202,10 26054919 71 /var/log/cloud.log.1
_plutorun 772 root 3w REG 202,10 26054919 71 /var/log/cloud.log.1
_plutoloa 773 root 3w REG 202,10 26054919 71 /var/log/cloud.log.1
xl2tpd 843 root 3w REG 202,10 26054919 71 /var/log/cloud.log.1
python 854 root 3w REG 202,10 26054919 71 /var/log/cloud.log.1
passwd_se 860 root 1w REG 202,10 26054919 71 /var/log/cloud.log.1
passwd_se 860 root 2w REG 202,10 26054919 71 /var/log/cloud.log.1
passwd_se 860 root 3w REG 202,10 26054919 71 /var/log/cloud.log.1
python 863 root 3w REG 202,10 26054919 71 /var/log/cloud.log.1
passwd_se 869 root 1w REG 202,10 26054919 71 /var/log/cloud.log.1
passwd_se 869 root 2w REG 202,10 26054919 71 /var/log/cloud.log.1
passwd_se 869 root 3w REG 202,10 26054919 71 /var/log/cloud.log.1
python 871 root 3w REG 202,10 26054919 71 /var/log/cloud.log.1
```

After change:
```
root@r-996-VM:/etc# lsof | grep cloud.log.1
(no results)
```

They all still have `cloud.log` open.

Logrotate works:
```
root@r-996-VM:/var/log# ls -lah cloud*
-rw-r--r-- 1 root root 3.6M Dec 13 10:49 cloud_demo
-rw-r--r-- 1 root root0 Dec 13 10:50 cloud.log
-rw-r--r-- 1 root root  18M Dec 13 10:50 cloud.log.1
-rw-r- 1 root adm 0 Dec 13 10:16 cloud-service.log
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9155 make sure logrotate is ef...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1235#issuecomment-164255438
  
The new script ends up on the router:

```
root@r-15-VM:~# cat /etc/logrotate.d/cloud 
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements.  See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership.  The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License.  You may obtain a copy of the License at
# 
#   http://www.apache.org/licenses/LICENSE-2.0
# 
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied.  See the License for the
# specific language governing permissions and limitations
# under the License.
/var/log/cloud.log {
rotate 4
daily
size 10M
missingok
notifempty
compress
delaycompress
# CLOUDSTACK-9155: We cannot tell the processes that are writing to 
this
# file to use the new inode, so instead we copy the original file, 
truncate
# it and keep the same inode.
copytruncate
}
```

Truncated list of processes that have `cloud.log` open:
```
apache2   3636 3686 www-data3w  REG 254,10   264891 
59 /var/log/cloud.log
apache2   3636 3687 www-data3w  REG 254,10   265499 
59 /var/log/cloud.log
apache2   3636 3688 www-data3w  REG 254,10   265499 
59 /var/log/cloud.log
apache2   3636 3689 www-data3w  REG 254,10   265499 
59 /var/log/cloud.log
apache2   3636 3690 www-data3w  REG 254,10   265499 
59 /var/log/cloud.log
conntrack 3837  root3w  REG 254,10   265499 
59 /var/log/cloud.log
keepalive 3851  root3w  REG 254,10   265499 
59 /var/log/cloud.log
keepalive 3852  root3w  REG 254,10   265499 
59 /var/log/cloud.log
keepalive 3853  root3w  REG 254,10   265499 
59 /var/log/cloud.log
_plutorun 4141  root3w  REG 254,10   265499 
59 /var/log/cloud.log
logger4142  root3w  REG 254,10   265499 
59 /var/log/cloud.log
_plutorun 4145  root3w  REG 254,10   265499 
59 /var/log/cloud.log
_plutoloa 4146  root3w  REG 254,10   265499 
59 /var/log/cloud.log
xl2tpd4203  root3w  REG 254,10   265499 
59 /var/log/cloud.log
passwd_se 4225  root1w  REG 254,10   265499 
59 /var/log/cloud.log
passwd_se 4225  root2w  REG 254,10   265499 
59 /var/log/cloud.log
passwd_se 4225  root3w  REG 254,10   265499 
59 /var/log/cloud.log
python4229  root3w  REG 254,10   265499 
59 /var/log/cloud.log
update_co 4927  root3r  REG 254,10   265499 
59 /var/log/cloud.log
```

Force logrotate:
```
logrotate /etc/logrotate.conf -f
```

Same processes, they still have `cloud.log` open (instead of `cloud.log.1`)
```
apache2   3636 3686 www-data3w  REG 254,10   264891 
59 /var/log/cloud.log
apache2   3636 3687 www-data3w  REG 254,10   265499 
59 /var/log/cloud.log
apache2   3636 3688 www-data3w  REG 254,10   265499 
59 /var/log/cloud.log
apache2   3636 3689 www-data3w  REG 254,10   265499 
59 /var/log/cloud.log
apache2   3636 3690 www-data3w  REG 254,10   265499 
59 /var/log/cloud.log
conntrack 3837  root3w  REG 254,10   265499 
59 /var/log/cloud.log
keepalive 3851  root3w  REG 254,10   265499 
59 /var/log/cloud.log
keepalive 3852  root3w  REG 254,10   265499 
59 /var/log/cloud.log
keepalive 3853  root3w  REG 254,10   265499 
59 /var/log/cloud.log
_plutorun 4141  root3w  REG 254,10   265499 
59 /var/log/cloud.log
logger4142  root3w  REG 254,10   265499 
59 /var/log/cloud.log
_plutorun 41

[GitHub] cloudstack pull request: CLOUDSTACK-9153: When negative credits ar...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1234#issuecomment-16428
  
Ping @bhaisaab any chance to get this reviewed today? ;-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9155 make sure logrotate is ef...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1235#issuecomment-164255579
  
As you asked on im @remibergsma : LGTM more explicitely


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9155 make sure logrotate is ef...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1235#issuecomment-164255956
  
Based on explanation and code review: LGTM :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Removed cloud-cli folder and contents, as...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1228#issuecomment-164255977
  
@DaanHoogland That's an LGTM :+1: right? :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Removed cloud-cli folder and contents, as...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1228#issuecomment-164256015
  
@borisroman I must learn to be less brittish ;) LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9155 make sure logrotate is ef...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1235#issuecomment-164258629
  
Integration tests make no real sense, but tried a few to be sure:

```
Check the password file in the Router VM ... === TestName: 
test_isolate_network_password_server | Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : 
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and 
check default routes ... === TestName: test_02_redundant_VPC_default_routes | 
Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: 
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Status : 
SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: 
test_02_routervm_iptables_policies | Status : SUCCESS ===
```

Looking good.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9155 make sure logrotate is ef...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1235


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Removed .pydevproject from plugin kvm hyp...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1226#issuecomment-164261409
  
@DaanHoogland It's already in .gitignore, I think these we're never 
removed...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9153: When negative credits ar...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1234#issuecomment-164266288
  
@agneya2001 I ran test_quota.py 
```
nosetests --with-marvin 
--marvin-config=/data/shared/marvin/mct-zone1-kvm1-kvm2-zwps.cfg  -s -a 
tags=advanced,required_hardware=false 
/data/git/cs1/cloudstack/test/integration/smoke/test_quota.py
```
all tests failed with exceptions like
```
==
ERROR: test_01_quota (integration.smoke.test_quota.TestQuota)
--
Traceback (most recent call last):
  File "/data/git/cs1/cloudstack/test/integration/smoke/test_quota.py", 
line 59, in test_01_quota
response = self.apiclient.quotaTariffList(cmd)
  File 
"/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", 
line 2972, in quotaTariffList
response = self.connection.marvinRequest(command, 
response_type=response, method=method)
  File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", 
line 379, in marvinRequest
raise e
CloudstackAPIException: Execute cmd: error failed, due to: errorCode: 432, 
errorText:The given command does not exist or it is not available for user
```
might I be missing something?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9153: When negative credits ar...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1234#issuecomment-164268405
  
LGTM
@DaanHoogland to use the plugin and run tests, your zone cfg need to enable 
the quota plugin global setting and restart mgmt server before the plugin/apis 
can be used.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9153: When negative credits ar...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1234#issuecomment-164269573
  
thanks @bhaisaab I forgot  setting indeed, 5 out of 7 tests now succeed. 
investigating the other two now


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9158: Removed SLF4J, it's abun...

[borisroman]

GitHub user borisroman opened a pull request:

https://github.com/apache/cloudstack/pull/1236

CLOUDSTACK-9158: Removed SLF4J, it's abundant due to log4j

In the entire project we use log4j, so why also use slf4j? I've removed 
slf4j and all references to it from the codebase.

Also I've let the top-level pom depend on log4j so not every project has to 
define it for itself.

Ping @remibergsma @DaanHoogland @miguelaferreira @wilderrodrigues @wido 

Builds ok, running integration tests now!
```
[INFO] 

[INFO] BUILD SUCCESS
[INFO] 

[INFO] Total time: 6:33.329s
[INFO] Finished at: Sun Dec 13 16:53:55 CET 2015
[INFO] Final Memory: 104M/813M
[INFO] 

```

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/borisroman/cloudstack CLOUDSTACK-9158

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1236.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1236


commit e7a6a0a38e36bc8deac7aa77b0aa624aa055bc1b
Author: Boris Schrijver 
Date:   2015-12-13T15:04:57Z

CLOUDSTACK-9158: Remove SLF4J, it's abundant due to log4j




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9146: Refactor Hypervisor KVM ...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1224#issuecomment-164270707
  
@DaanHoogland @borisroman - I sincerely don't grok the benefits of these 
changes, which is why I'm asking what are the benefits of the changes?

Some potential issues I can think of, wrt changing file names and paths 
are: (1) doing branch maintenance will become difficult, so cherry-picks and 
backporting bugfixes will become error prone, (2) while switching branches IDEs 
will be slow as they would need to re-index files/paths, (3) it becomes 
difficult to diff across branches (like git diff branch1..branch2 
some/file/path/file.txt) as files/paths have changed (I for example run sanity 
checks in db related files to make sure we don't change older db paths etc). 

While I understand, Maven users want to have convention over configuration, 
other than that argument I don't understand the pros. I would request that you 
please hold this PR for merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9153: When negative credits ar...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1234#issuecomment-164270791
  
I think the problem is in the tests as it starts with an empty balance. Can 
you confirm @bhaisaab , @agneya2001 ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9152: Remove unused folder(s)/...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1232#issuecomment-164270851
  
LGTM, though we might need to ask on dev@ as I remember someone using this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Removed cloud-cli folder and contents, as...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1228#issuecomment-164270975
  
I think we might need to test if package building still works with the 
changes, i.e. is rpm/deb packaging are using or referencing it. Possible test 
would be to build CentOS6/CentOS7 and Debian packages and install the packages 
(mgmt server, usage, agent for KVM hosts) to make sure we don't break 
packages/installation.

Otherwise, LGTM. Good cleanup @borisroman 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Removed .pydevproject from plugin kvm hyp...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1226#issuecomment-164271025
  
LGTM, not sure why they exist or if anyone (still) uses them.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9147: In hypervisor-plugin-kvm...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1225#issuecomment-164271090
  
@borisroman do you need to remove one of the commits around moving to 
default maven project structure? I see two commits.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9153: When negative credits ar...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1234#issuecomment-164271142
  
@DaanHoogland thanks, I think you're right but only @agneya2001 can confirm 
this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9146: Refactor Hypervisor KVM ...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1224#issuecomment-164271374
  
@bhaisaab I don't like maven but we are using it! cherry-picking is really 
not an argument and backporting is difficult for worse reasons then this one.
Using maven we better adhere to the conventions in the maven world as 
keeping our diversions from it correct will become increasingly difficult over 
time. I will meet you half way so we can abandon 4.5 first and continue to 
prove our fwd-merge schedule over several versions. We will face issues in this 
respect as well, btw, if at the time of 4.11 we will be fixing things in 4.6 ;)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9147: In hypervisor-plugin-kvm...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1225#issuecomment-164271411
  
Hi @bhaisaab,

True, that you see 2 commits! Due to the fact that this PR depends heavily 
on #1224. The commit id of the first commit is the same as the one in #1224.

So if #1224 is merged before this one, then the commit id of the first 
commit ill be already in the master branch, and therefore only the second will 
be merged.

If this PR is merged before #1224 then #1224 can be closed, as this pr 
includes the commit from that pr.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9153: When negative credits ar...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1234#issuecomment-164271487
  
I will try a run without this PR to confirm it is not a problem with the 
code


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Removed cloud-cli folder and contents, as...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1228#issuecomment-164271512
  
@bhaisaab I've already build the RPM's! We use them when running 
integration tests, so nothing broke in that area.

I'll build the DEB packages now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9146: Refactor Hypervisor KVM ...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1224#issuecomment-164271638
  
@DaanHoogland I'm not opposed to the change it is just that I think it 
makes my life challenging with some of the things I do on day-to-day basis :) 
We do follow all the Maven conventions except for the directory structure (src 
and test paths) which I thought was not end of the world.

Nevertheless, I'm curious to know what are the pros or cons of not 
following the Maven convention (specifically the src/ and test/ directory 
structure) in the long.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9147: In hypervisor-plugin-kvm...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1225#issuecomment-164272026
  
@borisroman alright, so we review/merge the other PR first and then come to 
this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9146: Refactor Hypervisor KVM ...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1224#issuecomment-164272024
  
@bhaisaab me too, and I am willing to put it on a long track but let's 
investigate and discuss more


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9147: In hypervisor-plugin-kvm...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1225#issuecomment-164272079
  
@bhaisaab Yes!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9153: When negative credits ar...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1234#issuecomment-164277189
  
@remibergsma @bhaisaab @agneya2001 confirmed that the problem with the last 
two tests is in master as well. I am satisfied nothing breaks in the quota 
plugin, both this PR and master show the following output:
```
=== TestName: test_01_quota | Status : SUCCESS ===

=== TestName: test_02_quota | Status : SUCCESS ===

=== TestName: test_03_quota | Status : SUCCESS ===

=== TestName: test_04_quota | Status : SUCCESS ===

=== TestName: test_05_quota | Status : SUCCESS ===

=== TestName: test_06_quota | Status : FAILED ===

=== TestName: test_07_quota | Status : FAILED ===
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9153: When negative credits ar...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1234#issuecomment-164277430
  
@DaanHoogland thanks Daan, I'll look into the failing issues with Abhi 
tomorrow.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Reducing expunge delay and interval on de...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1135#issuecomment-164278929
  
@pdube @remibergsma and i have been noticing extra failures in the 
integration tests with such short expunge timeouts. maybe it should work and 
can with some extra work but like this I don't like :(


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8968: UI icon over VM snapshot...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1150#issuecomment-164279018
  
@bhaisaab did you test this? should we merge before the RC tonight?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9134: set device_id as the fir...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1209#issuecomment-164279515
  
LGTM :+1: 

Based on code-review and @remibergsma tests.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9134: set device_id as the fir...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1209


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Remove unused folder(s)/file(s); HypervDu...

[borisroman]

GitHub user borisroman opened a pull request:

https://github.com/apache/cloudstack/pull/1237

Remove unused folder(s)/file(s); HypervDummyResourceBase.java

Dead code, never called and consist only of auto-generated methods.

As a developer I want
 - a clean project to work on
 - a project with maintained code
 - a project without dead code or files

Builds ok:
```
[INFO] 

[INFO] BUILD SUCCESS
[INFO] 

[INFO] Total time: 6:44.207s
[INFO] Finished at: Sun Dec 13 19:11:08 CET 2015
[INFO] Final Memory: 101M/800M
[INFO] 

```

Ping @bhaisaab @wido @remibergsma @DaanHoogland @miguelaferreira 
@wilderrodrigues 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/borisroman/cloudstack CLOUDSTACK-9159

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1237.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1237


commit c262bf53237ce61bb3decaee1d9ffe254e7299f1
Author: Boris Schrijver 
Date:   2015-12-13T18:02:06Z

Remove unused folder(s)/file(s); HypervDummyResourceBase.java

Dead code, never called and consist only of auto-generated methods.

As a developer I want
 - a clean project to work on
 - a project with maintained code
 - a project without dead code or files




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Remove unused folder(s)/file(s); HypervDu...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1237#issuecomment-164285184
  
Integration tests ran fine!

**Environment**
 - 2 KVM host on CentOS 7.1
 - 1 Management Server on CentOS 7.1
 - Agent + Common RPMs built from source

**Integration test suite 1**
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=true \
component/test_password_server.py \
smoke/test_vpc_redundant.py \
smoke/test_routers_iptables_default_policy.py \
smoke/test_routers_network_ops.py \
smoke/test_vpc_router_nics.py \
smoke/test_router_dhcphosts.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_vpc_vpn.py \
smoke/test_privategw_acl.py \
smoke/test_network.py
```

**Result test suite 1**
```
Check the password file in the Router VM ... === TestName: 
test_isolate_network_password_server | Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : 
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and 
check default routes ... === TestName: test_02_redundant_VPC_default_routes | 
Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: 
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Status : 
SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: 
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_03_RVR_Network_check_router_state | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... === 
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS 
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 
| Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS 
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS 
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS 
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS 
===
ok
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn 
| Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : SUCCESS 
===
ok
test_01_vpc_privategw_acl 
(integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName: 
test_01_vpc_privategw_acl | Status : SUCCESS ===
ok
test_02_vpc_privategw_static_r

[GitHub] cloudstack pull request: Remove unused folder(s)/file(s); HypervDu...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1237#issuecomment-164285459
  
@borisroman you know by now I agree on those principles but your 
integration test results are quite useless as we are talking about hyperv code. 
Let's do a short period of inquisition on the usage amongst teh hyperv users 
and experts.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Remove unused folder(s)/file(s); HypervDu...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1237#issuecomment-164285932
  
@DaanHoogland The integration tests show nothing broke on the KVM part, the 
code of course does need to be reviewed. But that doesn't mean the tests are 
useless.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[VOTE] Apache CloudStack 4.6.2

[Remi Bergsma]

Hi all,

In the past two weeks (since 4.6.1), 23 pull [1] requests have been merged to 
4.6 branch and then to master/4.7.0. Therefore it makes sense to wrap-up the 
4.6 release cycle with a final release and bring all the improvements to our 
users. Vote e-mail below. Later today we will send another RC for 4.7.0.


I've created a 4.6.2 release candidate, with the following artifacts up for a 
vote:

Git Branch and Commit SH:
https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=4.6.2-RC20151213T1914

Commit: 10e0130dd6e0c06deae4f5ccfd43d5bcecea57b6

Source release (checksums and signatures are available at the same
location):
https://dist.apache.org/repos/dist/dev/cloudstack/4.6.2/

PGP release keys (signed using A47DDC4F):
https://dist.apache.org/repos/dist/release/cloudstack/KEYS

Vote will be open for at least 72 hours.

For sanity in tallying the vote, can PMC members please be sure to indicate 
"(binding)" with their vote?

[ ] +1  approve
[ ] +0  no opinion
[ ] -1  disapprove (and reason why)


[1] git log --pretty=oneline --abbrev-commit 4.6.1..4.6.2-RC20151213T1914 | 
grep "Merge pull request"

[GitHub] cloudstack pull request: L10N update before 4.7.0 RC1

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1217


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Remove unused folder(s)/file(s); HypervDu...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1237#issuecomment-164286918
  
@borisroman I can not decide based on these tests if the removal is ok, so 
to me they are useless


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9153: When negative credits ar...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1234#issuecomment-164288018
  
For the sake of it, I run a some generic integration tests and they are 
happy.

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=true \
component/test_password_server.py \
smoke/test_vpc_redundant.py \
smoke/test_routers_iptables_default_policy.py \
smoke/test_routers_network_ops.py \
smoke/test_vpc_router_nics.py \
smoke/test_router_dhcphosts.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_vpc_vpn.py \
smoke/test_privategw_acl.py \
smoke/test_network.py
```

Result:

```
Check the password file in the Router VM ... === TestName: 
test_isolate_network_password_server | Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : 
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and 
check default routes ... === TestName: test_02_redundant_VPC_default_routes | 
Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: 
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Status : 
SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: 
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_03_RVR_Network_check_router_state | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... === 
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS 
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 
| Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS 
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS 
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS 
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS 
===
ok
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn 
| Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : SUCCESS 
===
ok
test_01_vpc_privategw_acl 
(integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName: 
test_01_vpc_privategw_acl | Status : SUCCESS ===
ok
test_02_vpc_privategw_static_routes 
(integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName: 
test_02_vpc_privategw_static_routes | Status : SUCCESS ===
ok
test_03_rvpc_privategw_static_

[GitHub] cloudstack pull request: CLOUDSTACK-9153: When negative credits ar...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1234


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Remove unused folder(s)/file(s); HypervDu...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1237#issuecomment-164288191
  
@borisroman @DaanHoogland Let's ask someone to test whether HyperV is still 
happy and then we'll know.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Remove unused folder(s)/file(s); HypervDu...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1237#issuecomment-164289083
  
@remibergsma @DaanHoogland Back to the point, who could we ping for a 
HyperV review?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9160: Remove unused folder(s)/...

[borisroman]

GitHub user borisroman opened a pull request:

https://github.com/apache/cloudstack/pull/1238

CLOUDSTACK-9160: Remove unused folder(s)/file(s); engine/api/src/org/…

…apache/engine/subsystem/api/storage/disktype

Empty files. Moved DiskFormat.java to 
engine/api/src/org/apache/engine/subsystem/api/storage/type

As a developer I want
 - a clean project to work on
 - a project with maintained code
 - a project without dead code or files

Builds ok:
```
[INFO] 

[INFO] BUILD SUCCESS
[INFO] 

[INFO] Total time: 6:04.428s (Wall Clock)
[INFO] Finished at: Sun Dec 13 20:25:49 CET 2015
[INFO] Final Memory: 95M/787M
[INFO] 

```

Ping @wido @DaanHoogland @remibergsma @miguelaferreira @wilderrodrigues 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/borisroman/cloudstack CLOUDSTACK-9160

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1238.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1238


commit f47e11b6dcf31d0c4973d37d71acd9847edd9f4d
Author: Boris Schrijver 
Date:   2015-12-13T19:27:02Z

CLOUDSTACK-9160: Remove unused folder(s)/file(s); 
engine/api/src/org/apache/engine/subsystem/api/storage/disktype

Empty files. Moved DiskFormat.java to 
engine/api/src/org/apache/engine/subsystem/api/storage/type

As a developer I want
 - a clean project to work on
 - a project with maintained code
 - a project without dead code or files




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: build_asf.sh: fix debian changelog alteri...

[remibergsma]

GitHub user remibergsma opened a pull request:

https://github.com/apache/cloudstack/pull/1239

build_asf.sh: fix debian changelog altering

The script already adds a new entry so we shouldn't replace the
previous one. That is done only in the next version script.

As discussed with @DaanHoogland 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/remibergsma/cloudstack fix-debian-changelog

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1239.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1239


commit 97b5e12704b8254283cdd2cb3b6c77765ec63a70
Author: Remi Bergsma 
Date:   2015-12-13T19:41:56Z

build_asf.sh: fix debian changelog altering

The script already adds a new entry so we shouldn't replace the
previous one. That is done only in the next version script.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: build_asf.sh: fix debian changelog alteri...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1239#issuecomment-164290759
  
LGTM, let's merge on my review only as we don't have a second RM to review


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: build_asf.sh: fix debian changelog alteri...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1239#issuecomment-164291121
  
The changelog file will need to be handled more carefully.

LGTM :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: build_asf.sh: fix debian changelog alteri...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1239#issuecomment-164291346
  
@borisroman we should separate it from the CloudStack repo ;-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: build_asf.sh: fix debian changelog alteri...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1239


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: QUOTA: Ensuring that the dates displayed ...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1205#issuecomment-164293808
  
did a code review and trustin @bhaisaab his testing skills: LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: QUOTA: Ensuring that the dates displayed ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1205


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8841: Storage XenMotion from X...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/815#issuecomment-164294423
  
a test setup for this is not trivial, I can live with it but would like to 
see some proof before merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fixed: Error given when creating VPN user...

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/826#discussion_r47449550
  
--- Diff: server/src/com/cloud/storage/ImageStoreUploadMonitorImpl.java ---
@@ -117,7 +117,7 @@
 public boolean configure(String name, Map params) 
throws ConfigurationException {
 _executor = Executors.newScheduledThreadPool(1, new 
NamedThreadFactory("Upload-Monitor"));
 _monitoringInterval = UploadMonitoringInterval.value();
-_uploadOperationTimeout = UploadOperationTimeout.value() * 60 * 
1000;
+_uploadOperationTimeout = UploadOperationTimeout.value() * 60 * 
1000L;
--- End diff --

please find or define a definition of 60 seconds


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[VOTE] Apache CloudStack 4.7.0

[Remi Bergsma]

Hi all,

Since our 4.6.0 release (on Nov 13th, exactly 1 month ago), we have merged 100+ 
pull requests [1] with lots of bug fixes, refactoring and of course new 
features. Time for a new release!


I've created a 4.7.0 release candidate, with the following artifacts up for a 
vote:

Git Branch and Commit SH:
https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=4.7.0-RC20151213T2109

Commit: 2f26a859a971a9852ed9f6f34fe35e52fe6028a9

Source release (checksums and signatures are available at the same location):
https://dist.apache.org/repos/dist/dev/cloudstack/4.7.0/

PGP release keys (signed using A47DDC4F):
https://dist.apache.org/repos/dist/release/cloudstack/KEYS

Vote will be open for at least 72 hours.

For sanity in tallying the vote, can PMC members please be sure to indicate 
"(binding)" with their vote?

[ ] +1  approve
[ ] +0  no opinion
[ ] -1  disapprove (and reason why)


[1] git log --pretty=oneline --abbrev-commit origin/4.6..4.7.0-RC20151213T2109 
| grep "Merge pull request"

Re: Need with InsufficientServerCapacityException while adding instance

[Mike Tutkowski]

The unfortunate part with that exception is that is could mean a lot of
things.

Off the top of my head, I've encountered it for the following reasons:

* Not enough storage space for the root disk.

* I had not applied the free license for my XenServer 6.1 hosts.

* CloudStack couldn't find primary storage that was tagged in a way to
satisfy the requirements of the computer or disk offering.

* Not an available IP address to assign to the VM.

Basically it's saying it couldn't secure one or more of the required
resources to create the VM.

On Sun, Dec 13, 2015 at 1:40 PM, B Prakash  wrote:

> Hi, I might be missing something please can someone help me with this?  I
> am using CS 4.6 host Xenserver 6.5 both on Virtual box.  I have a default
> centos template that I am using to create an instance.  I have created a
> basic zone, while creating instance, I get the following exception;
>
>
> WARN  [o.a.c.alerts] (API-Job-Executor-12:ctx-9e35591b job-20
> ctx-de2eef61)  alertType:: 8 // dataCenterId:: 1 // podId:: null //
> clusterId:: null // message:: Failed to deploy Vm with Id: 4, on Host with
> Id: null
> INFO  [o.a.c.a.c.a.v.DeployVMCmdByAdmin] (API-Job-Executor-12:ctx-9e35591b
> job-20 ctx-de2eef61)
> com.cloud.exception.InsufficientServerCapacityException: Unable to create a
> deployment for VM[User|i-2-4-VM]Scope=interface com.cloud.dc.DataCenter;
> id=1
> INFO  [o.a.c.a.c.a.v.DeployVMCmdByAdmin] (API-Job-Executor-12:ctx-9e35591b
> job-20 ctx-de2eef61) Unable to create a deployment for VM[User|i-2-4-VM]
> com.cloud.exception.InsufficientServerCapacityException: Unable to create
> a deployment for VM[User|i-2-4-VM]Scope=interface com.cloud.dc.DataCenter;
> id=1
> at
> org.apache.cloudstack.engine.cloud.entity.api.VMEntityManagerImpl.reserveVirtualMachine(VMEntityManagerImpl.java:214)
> at
> org.apache.cloudstack.engine.cloud.entity.api.VirtualMachineEntityImpl.reserve(VirtualMachineEntityImpl.java:200)
> at
> com.cloud.vm.UserVmManagerImpl.startVirtualMachine(UserVmManagerImpl.java:3869)
> at
> com.cloud.vm.UserVmManagerImpl.startVirtualMachine(UserVmManagerImpl.java:3488)
> at
> com.cloud.vm.UserVmManagerImpl.startVirtualMachine(UserVmManagerImpl.java:3476)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
>
>
>


-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
*™*

Re: Need with InsufficientServerCapacityException while adding instance

[Nux!]

Yeah, usually it takes a bit more looking up and down the logfile to realise 
the cause, as well as checking the HVs logs.
First thing to do is turn on DEBUG mode in the logging:
sed -i 's/INFO/DEBUG/g' log4j-cloud.xml

--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro

- Original Message -
> From: "Mike Tutkowski" 
> To: dev@cloudstack.apache.org
> Sent: Sunday, 13 December, 2015 22:48:44
> Subject: Re: Need with InsufficientServerCapacityException while adding 
> instance

> The unfortunate part with that exception is that is could mean a lot of
> things.
> 
> Off the top of my head, I've encountered it for the following reasons:
> 
> * Not enough storage space for the root disk.
> 
> * I had not applied the free license for my XenServer 6.1 hosts.
> 
> * CloudStack couldn't find primary storage that was tagged in a way to
> satisfy the requirements of the computer or disk offering.
> 
> * Not an available IP address to assign to the VM.
> 
> Basically it's saying it couldn't secure one or more of the required
> resources to create the VM.
> 
> On Sun, Dec 13, 2015 at 1:40 PM, B Prakash  wrote:
> 
>> Hi, I might be missing something please can someone help me with this?  I
>> am using CS 4.6 host Xenserver 6.5 both on Virtual box.  I have a default
>> centos template that I am using to create an instance.  I have created a
>> basic zone, while creating instance, I get the following exception;
>>
>>
>> WARN  [o.a.c.alerts] (API-Job-Executor-12:ctx-9e35591b job-20
>> ctx-de2eef61)  alertType:: 8 // dataCenterId:: 1 // podId:: null //
>> clusterId:: null // message:: Failed to deploy Vm with Id: 4, on Host with
>> Id: null
>> INFO  [o.a.c.a.c.a.v.DeployVMCmdByAdmin] (API-Job-Executor-12:ctx-9e35591b
>> job-20 ctx-de2eef61)
>> com.cloud.exception.InsufficientServerCapacityException: Unable to create a
>> deployment for VM[User|i-2-4-VM]Scope=interface com.cloud.dc.DataCenter;
>> id=1
>> INFO  [o.a.c.a.c.a.v.DeployVMCmdByAdmin] (API-Job-Executor-12:ctx-9e35591b
>> job-20 ctx-de2eef61) Unable to create a deployment for VM[User|i-2-4-VM]
>> com.cloud.exception.InsufficientServerCapacityException: Unable to create
>> a deployment for VM[User|i-2-4-VM]Scope=interface com.cloud.dc.DataCenter;
>> id=1
>> at
>> org.apache.cloudstack.engine.cloud.entity.api.VMEntityManagerImpl.reserveVirtualMachine(VMEntityManagerImpl.java:214)
>> at
>> org.apache.cloudstack.engine.cloud.entity.api.VirtualMachineEntityImpl.reserve(VirtualMachineEntityImpl.java:200)
>> at
>> com.cloud.vm.UserVmManagerImpl.startVirtualMachine(UserVmManagerImpl.java:3869)
>> at
>> com.cloud.vm.UserVmManagerImpl.startVirtualMachine(UserVmManagerImpl.java:3488)
>> at
>> com.cloud.vm.UserVmManagerImpl.startVirtualMachine(UserVmManagerImpl.java:3476)
>> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>> at
>> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
>>
>>
>>
> 
> 
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the cloud
> *™*

[GitHub] cloudstack-docs-rn pull request: 4.7.0

[pdion891]

GitHub user pdion891 opened a pull request:

https://github.com/apache/cloudstack-docs-rn/pull/27

4.7.0

Please review what's new section and approuve or not the use of a 
screenshot for the Metric section.

Thanks,

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pdion891/cloudstack-docs-rn master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack-docs-rn/pull/27.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #27


commit 24aa40fcdefb42383d2e502e03b86c0911ff22be
Author: Pierre-Luc Dion 
Date:   2015-11-18T03:24:39Z

fix pre 4.5 upgrade instruction

commit 79b5cb3dac248971b0bb6173e1d0d8d0c68ead81
Author: Pierre-Luc Dion 
Date:   2015-11-25T00:19:59Z

update awsapi removal instruction

commit 7f5d07f1fdcc7332cfc088dd44b90001d3adbb48
Author: Pierre-Luc Dion 
Date:   2015-11-25T13:24:00Z

fix typos

commit 347cdef9172135def25046d8f07829448caf0775
Author: Pierre-Luc Dion 
Date:   2015-12-13T20:45:24Z

4.6.1 initial commit

commit 09137a415e53ab37ff2141ca5083c74b72dbb607
Author: Pierre-Luc Dion 
Date:   2015-12-14T01:02:12Z

update for 4.7.0




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[TEST] 4.7.0-RC1 Instance password not set

[Pierre-Luc Dion]

I'm not sure if this issue start  at 4.7.0 or is just related to my test
environment. But I can't get the password provide by cloudstack to the vm,
In this case the instance is centos6.6 using the
usual cloud-set-guest-password

here is the log from the Instance:
/var/log/messages
Dec 14 00:32:56 c6-1 cloud: Found password server IP 10.10.0.78 in
/var/lib/dhclient/dhclient-eth0.leases
Dec 14 00:32:56 c6-1 cloud: Sending request to password server at 10.10.0.78
Dec 14 00:32:57 c6-1 cloud: Got response from server at 10.10.0.78
Dec 14 00:32:57 c6-1 cloud: Password server at 10.10.0.78 did not have any
password for the VM
Dec 14 00:32:57 c6-1 cloud: Did not need to change password.
Dec 14 00:32:57 c6-1 cloud: Sending request to ssh key server at 10.10.0.78
Dec 14 00:32:57 c6-1 cloud: Got response from server at 10.10.0.78
Dec 14 00:32:57 c6-1 cloud: Sending request to ssh key server at 10.10.0.78
Dec 14 00:32:57 c6-1 cloud: Got response from server at 10.10.0.78

Anyone is having this issue?  ssh key does work.

Thanks,

[GitHub] cloudstack pull request: Strongswan vpn feature

[jayapalu]

Github user jayapalu commented on the pull request:

https://github.com/apache/cloudstack/pull/872#issuecomment-164340450
  
@remibergsma  This job is success now. I am downloading the template from 
this.
http://jenkins.buildacloud.org/job/build-systemvm64-github/


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

[nitin-maharana]

Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/1206#issuecomment-164344691
  
@DaanHoogland : Yes, your idea also looks good. Previously, it was 
generating a random value only in case of NULL. But if we pass an empty string, 
it was creating a volume with the empty name. I will modify the condition and 
update the PR. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9103 : Missing OS Mappings for...

[maneesha-p]

Github user maneesha-p commented on the pull request:

https://github.com/apache/cloudstack/pull/1216#issuecomment-164347886
  
@bhaisaab @agneya2001 @DaanHoogland  2 LGTMs can it be merged?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9104: VM naming convention in ...

[priyankparihar]

Github user priyankparihar commented on the pull request:

https://github.com/apache/cloudstack/pull/1165#issuecomment-164348885
  
@bhaisaab 
User with different account cannot create VMs with the same name, which was 
possible earlier (I am not sure in which CCP version). That time naming 
convention used was like this “I--”
Currently if vm.instancename.flag is set to true the VM name will be 
exactly as display name given.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9127 Missing PV-bootloader-arg...

[SudharmaJain]

Github user SudharmaJain commented on the pull request:

https://github.com/apache/cloudstack/pull/1196#issuecomment-164350819
  
Fixed the build. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8841: Storage XenMotion from X...

[priyankparihar]

Github user priyankparihar commented on the pull request:

https://github.com/apache/cloudstack/pull/815#issuecomment-164354949
  
 @DaanHoogland  I have tested it on my machines. what kind of proof do you 
need ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Building Cloudstack failing on windows

[Sudharma Jain]

While building Cloudstack on windows, it fails with following exceptions.

Tests run: 4, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 2.052 sec
<<< FAILURE! - in com.cloud.utils.TestProfiler
testProfilerInNano(com.cloud.utils.TestProfiler)  Time elapsed: 1.004 sec
 <<< FAILURE!
java.lang.AssertionError: null
at org.junit.Assert.fail(Assert.java:86)
at org.junit.Assert.assertTrue(Assert.java:41)
at org.junit.Assert.assertTrue(Assert.java:52)
at
com.cloud.utils.TestProfiler.testProfilerInNano(TestProfiler.java:71)


Tests run: 4, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.001 sec
<<< FAILURE! - in
com.cloud.hypervisor.kvm.resource.wrapper.LibvirtUtilitiesHelperTest
testSSHKeyPaths(com.cloud.hypervisor.kvm.resource.wrapper.LibvirtUtilitiesHelperTest)
 Time elapsed: 0.001 sec  <<< FAILURE!
junit.framework.ComparisonFailure: expected:
but was:
at junit.framework.Assert.assertEquals(Assert.java:100)
at junit.framework.Assert.assertEquals(Assert.java:107)
at junit.framework.TestCase.assertEquals(TestCase.java:269)
at
com.cloud.hypervisor.kvm.resource.wrapper.LibvirtUtilitiesHelperTest.testSSHKeyPaths(LibvirtUtilitiesHelperTest.java:40)

Thanks,
Sudharma

[GitHub] cloudstack pull request: [blocker/critical] CLOUDSTACK-9025 : [Xen...

[anshul1886]

Github user anshul1886 closed the pull request at:

https://github.com/apache/cloudstack/pull/1030


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9161: fix the quota marvin tes...

[agneya2001]

GitHub user agneya2001 opened a pull request:

https://github.com/apache/cloudstack/pull/1240

CLOUDSTACK-9161: fix the quota marvin test

  1. Create a dummy user, as existing user may already have stale quota
  data
  2. fix the tests to use the dummy user
  3. a boundary condition was revealed and fixed for a new user where
  quota service has never run and created bootstrap entries

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shapeblue/cloudstack master-9161

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1240.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1240


commit b9ff4abadecc44924b0f77ebd2c8cb2d4f9cc253
Author: Abhinandan Prateek 
Date:   2015-12-14T06:40:48Z

CLOUDSTACK-9161: fix the quota marvin test

  1. Create a dummy user, as existing user may already have stale quota
  data
  2. fix the tests to use the dummy user
  3. a boundary condition was revealed and fixed for a new user where
  quota service has never run and created bootstrap entries




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [blocker/critical] CLOUDSTACK-9025 : [Xen...

[anshul1886]

Github user anshul1886 commented on the pull request:

https://github.com/apache/cloudstack/pull/1030#issuecomment-164359761
  
Closing this PR as this got fixed by PR #1176 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9128: Testcase to verify physi...

[pritisarap12]

Github user pritisarap12 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1199#discussion_r47465693
  
--- Diff: test/integration/testpaths/testpath_snapshot_limits.py ---
@@ -358,3 +362,129 @@ def test_01_storage_snapshots_limits(self):
 )
 
 return
+
+@attr(tags=["advanced", "basic"], required_hardware="true")
+def test_02_snapshot_size_check(self):
+""" Check Snapshots size in database
+1. Create file on ROOT disk of deployed VM.
+2. Create Snapshot of ROOT disk.
+3. Check if physiacal_size parameter of snapshot_store_ref 
table
+   has physical size of snapshot
+"""
+if self.hypervisor.lower() not in ["xenserver", "vmware"]:
+self.skipTest("Test not to be run on %s" % self.hypervisor)
--- End diff --

Here we are running the test for Xenserver and VMWare  i.e. skip the test 
if the hypervisor is not XS or VMWare .
So the test run on Xenserver.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9128: Testcase to verify physi...

[pritisarap12]

Github user pritisarap12 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1199#discussion_r47465783
  
--- Diff: test/integration/testpaths/testpath_snapshot_limits.py ---
@@ -358,3 +362,129 @@ def test_01_storage_snapshots_limits(self):
 )
 
 return
+
+@attr(tags=["advanced", "basic"], required_hardware="true")
+def test_02_snapshot_size_check(self):
+""" Check Snapshots size in database
+1. Create file on ROOT disk of deployed VM.
+2. Create Snapshot of ROOT disk.
+3. Check if physiacal_size parameter of snapshot_store_ref 
table
+   has physical size of snapshot
+"""
+if self.hypervisor.lower() not in ["xenserver", "vmware"]:
+self.skipTest("Test not to be run on %s" % self.hypervisor)
+
+root_volumes_list = list_volumes(
+self.apiclient,
+virtualmachineid=self.vm.id,
+type=ROOT,
+listall=True
+)
+
+status = validateList(root_volumes_list)
+self.assertEqual(
+status[0],
+PASS,
+"Check listVolumes response for ROOT Disk")
+
+root_volume = root_volumes_list[0]
+
+# Get Secondary Storage Value from Database
+qryresult_before_snapshot = self.dbclient.execute(
+" select id, account_name, secondaryStorageTotal\
+from account_view where account_name = '%s';" %
+self.account.name)
+
+self.assertNotEqual(
+len(qryresult_before_snapshot),
+0,
+"Check sql query to return SecondaryStorageTotal of account")
+
+storage_qry_result_old = qryresult_before_snapshot[0]
+secondary_storage_old = storage_qry_result_old[2]
+
+createChecksum(
+self.testdata,
+self.vm,
+root_volume,
+"rootdiskdevice")
+
+time.sleep(30)
--- End diff --

createChecksum function logins the VM and performs some operation on VM 
disk which takes some time, so wait for 30s is added there.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9162: Unable to add VPN user v...

[kansal]

GitHub user kansal opened a pull request:

https://github.com/apache/cloudstack/pull/1241

CLOUDSTACK-9162: Unable to add VPN user via API with Required Paramet…

…ers - Fixed

RCA:
When we do not provide account parameter which is an optional field , API 
picks up the account from which we are logged in. So this works fine with 
cloudmonkey and ACS UI. But if we fire API directly from the browser(Make sure 
no cookies are stored and you are not logged in), by default system account is 
picked and the VPN users addition fails. This behaviour is expected, but no 
exception is thrown. So users think that VPN user is created.

Fix: Added an exception when VPN users are added in the system account. 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kansal/cloudstack CLOUDSTACK-9162

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1241.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1241


commit b8497b2a375b256a9f96ffaaaebd0829c88fd45c
Author: Kshitij Kansal 
Date:   2015-12-14T07:16:40Z

CLOUDSTACK-9162: Unable to add VPN user via API with Required Parameters - 
Fixed




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

[nitin-maharana]

Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/1206#issuecomment-164366344
  
API with non-empty name:


http://10.102.192.122:8080/client/api?command=createVolume&response=json&name=TempVolume&zoneId=18b1cb1a-bb8b-4e3d-aab8-a48475ed3c60&diskOfferingId=dc8a8d64-34a6-481e-99f9-89a49ee94824&size=1&_=1450077422731


![ss_withname_nitin](https://cloud.githubusercontent.com/assets/12583725/11775056/9b18f778-a261-11e5-91d5-05b79e6d31f0.png)


API with empty name:
=

http://10.102.192.122:8080/client/api?command=createVolume&response=json&name=&zoneId=18b1cb1a-bb8b-4e3d-aab8-a48475ed3c60&diskOfferingId=dc8a8d64-34a6-481e-99f9-89a49ee94824&size=1&_=1450077422731


![ss_withoutname_nitin](https://cloud.githubusercontent.com/assets/12583725/11775062/a68f66c8-a261-11e5-9456-4e7eece196fb.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8841: Storage XenMotion from X...

[runseb]

Github user runseb commented on the pull request:

https://github.com/apache/cloudstack/pull/815#issuecomment-164369338
  
-1

Just on the fact that "it runs on my machine" is the single most horrible 
reason to justify working software.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9146: Refactor Hypervisor KVM ...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/1224#issuecomment-164371097
  
@DaanHoogland @bhaisaab 

The first thing is that using a standard is better than doing the way 
nobody else is doing. When one adopts a technology is essential to stick with 
what that technology has standardised. It help in the long run when other 
people, used to that technology, will join the project. In addition, ACS is not 
our only Maven project. So, sticking with the standard is great.

Nothing personal, but I'm not a fan of ```the only issue for me is that 
most users are not as agile as we want them to be.``` those kind or arguments. 
We have to improve, as much as we can, and it should not be stopped because 
other users cannot improve. What we do is to make our work better and also to 
help them see the better way of doing things. A bit philosophical, but I 
believe that we have to lead by example.

This code should have been merged before the 4.7 cut.

More on this: 
https://maven.apache.org/guides/introduction/introduction-to-the-standard-directory-layout.html


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---