[GitHub] cloudstack pull request: CLOUDSTACK-9122: latest credit entries sh...
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1192#issuecomment-164125511
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component/test_password_server.py \
smoke/test_vpc_redundant.py \
smoke/test_routers_iptables_default_policy.py \
smoke/test_routers_network_ops.py \
smoke/test_vpc_router_nics.py \
smoke/test_router_dhcphosts.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_vpc_vpn.py \
smoke/test_privategw_acl.py \
smoke/test_network.py
```
Result:
```
Check the password file in the Router VM ... === TestName:
test_isolate_network_password_server | Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ...
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status :
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and
check default routes ... === TestName: test_02_redundant_VPC_default_routes |
Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ...
=== TestName:
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Status :
SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName:
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... ===
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_03_RVR_Network_check_router_state | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status :
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... ===
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName:
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName:
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName:
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... ===
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80
| Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status :
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status :
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS
===
ok
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn
| Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : SUCCESS
===
ok
test_01_vpc_privategw_acl
(integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName:
test_01_vpc_privategw_acl | Status : SUCCESS ===
ok
test_02_vpc_privategw_static_routes
(integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName:
test_02_vpc_privategw_static_routes | Status : SUCCESS ===
ok
test_03_rvpc_privategw_static_routes
(integration.smoke.test_privategw_acl.TestPri
[GitHub] cloudstack pull request: CLOUDSTACK-9122: latest credit entries sh...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1192#issuecomment-164125653 Jenkins error is unrelated to PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9086: ACS allows to create iso...
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1188#issuecomment-164125758
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component/test_password_server.py \
smoke/test_vpc_redundant.py \
smoke/test_routers_iptables_default_policy.py \
smoke/test_routers_network_ops.py \
smoke/test_vpc_router_nics.py \
smoke/test_router_dhcphosts.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_vpc_vpn.py \
smoke/test_privategw_acl.py \
smoke/test_network.py
```
Result:
```
Check the password file in the Router VM ... === TestName:
test_isolate_network_password_server | Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ...
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status :
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and
check default routes ... === TestName: test_02_redundant_VPC_default_routes |
Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ...
=== TestName:
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Status :
SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName:
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... ===
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_03_RVR_Network_check_router_state | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status :
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... ===
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName:
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName:
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName:
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... ===
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80
| Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status :
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status :
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS
===
ok
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn
| Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : SUCCESS
===
ok
test_01_vpc_privategw_acl
(integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName:
test_01_vpc_privategw_acl | Status : SUCCESS ===
ok
test_02_vpc_privategw_static_routes
(integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName:
test_02_vpc_privategw_static_routes | Status : SUCCESS ===
ok
test_03_rvpc_privategw_static_routes
(integration.smoke.test_privategw_acl.TestPri
[GitHub] cloudstack pull request: CLOUDSTACK-9139 make zwps default when de...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1219#issuecomment-164125989 LGTM, I could still do all my deployments using Marvin. So, didn't test this feature but did prove the existing functionality still works. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-4374 - As a Developer I want t...
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1222#issuecomment-164126939
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component/test_password_server.py \
smoke/test_vpc_redundant.py \
smoke/test_routers_iptables_default_policy.py \
smoke/test_routers_network_ops.py \
smoke/test_vpc_router_nics.py \
smoke/test_router_dhcphosts.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_vpc_vpn.py \
smoke/test_privategw_acl.py \
smoke/test_network.py
```
Result:
```
Check the password file in the Router VM ... === TestName:
test_isolate_network_password_server | Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ...
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status :
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and
check default routes ... === TestName: test_02_redundant_VPC_default_routes |
Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ...
=== TestName:
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Status :
SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName:
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... ===
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_03_RVR_Network_check_router_state | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status :
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... ===
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName:
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName:
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName:
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... ===
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80
| Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status :
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status :
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS
===
ok
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn
| Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : SUCCESS
===
ok
test_01_vpc_privategw_acl
(integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName:
test_01_vpc_privategw_acl | Status : SUCCESS ===
ok
test_02_vpc_privategw_static_routes
(integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName:
test_02_vpc_privategw_static_routes | Status : SUCCESS ===
ok
test_03_rvpc_privategw_static_routes
(integration.smoke.test_privategw_acl.TestPri
[GitHub] cloudstack pull request: CLOUDSTACK-4374 - As a Developer I want t...
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1222#issuecomment-164127045 Awesome! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9069: Newly added project is n...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1082#issuecomment-164127282 Hi @nitin-maharana thanks for the info! I built a new cloud and still have the issue that after creating a project it keeps loading forever (see image above). I tried the same on master and there it works. Also, after creating a project on master, I do see it in the list without refreshing? https://cloud.githubusercontent.com/assets/1630096/11761162/8f2f1114-a0b7-11e5-9c28-bb5a332ef6b6.png";> I might not understand what you fixed, but in any way you seem to introduce a new problem for me. Please have a look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: [UI] bug fix: Delete added ACL lists is n...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1211#issuecomment-164129115 LGTM based on the below test. Original on current master: - create domain, account and login - create vpc - create acl - no option to delete it https://cloud.githubusercontent.com/assets/1630096/11761241/8142a3ec-a0ba-11e5-9a3d-d1cc13abd531.png";> The same on this PR: https://cloud.githubusercontent.com/assets/1630096/11761242/934f58f0-a0ba-11e5-87d9-61b7f0d3eca9.png";> Option to delete is now there: https://cloud.githubusercontent.com/assets/1630096/11761243/9b8dd0dc-a0ba-11e5-9e6f-d59fcfca23b0.png";> And gone: https://cloud.githubusercontent.com/assets/1630096/11761244/a3cb0e04-a0ba-11e5-9c74-24c6d2cc6bc6.png";> Thanks for the fix @ustcweizhou ! Pinging @DaanHoogland @bhaisaab @wilderrodrigues to do a second review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Remove template ulimit from createtmplt.s...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1223#issuecomment-164132726 @syed Thanks! @bhaisaab @DaanHoogland Do you guys know why this was put in? It was in the original source import years ago. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Removed .pydevproject from plugin kvm hyp...
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1226#issuecomment-164134435 No idea why that is in there indeed. LGTM Is just a metadata file, never touched by packaging either. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9147: In hypervisor-plugin-kvm...
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1225#issuecomment-164134517 The build still works indeed, bu I'd love to see if all the tests still work. We transfer TOs between the Agent and Mgmt server and they contain full package names, are we sure they didn't break? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9141: Validate userdata for va...
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1220#issuecomment-164134556 @remibergsma Hmm, that's weird. It compiled on my desktop. This seems like a Java version thingy. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9135 - As a Developer I want t...
Github user wilderrodrigues commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1221#discussion_r47429990 --- Diff: test/integration/smoke/test_internal_lb.py --- @@ -286,9 +302,12 @@ def setUpClass(cls): %s" % (cls.account.name, cls.account.id)) -cls.cleanup = [cls.template, cls.account, cls.compute_offering] +cls._cleanup = [cls.template, cls.account, cls.compute_offering] --- End diff -- Hi @borisroman I added a setUp() and tearDown() methods that are called before/after each test. By doing so, we make sure that each test is done in isolation. The tearDown() method uses the cleanup list, whilst the tearDownClass() method uses the _cleanup list. The tearDownClass() is called only when all the tests are done. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9135 - As a Developer I want t...
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1221#issuecomment-164135820 Thanks for the reviw, @borisroman! :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Show actual diff in commits after merge w...
GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/1227 Show actual diff in commits after merge with git-pr / git-fwd-merge This shows the diff in commits after using `git-pr` and `git-fwd-merge` tools, like this: ``` 44e8c92 Merge pull request #1226 from borisroman/CLOUDSTACK-9148 0554610 Removed .pydevproject from plugin kvm hypervisor. ``` That helps in quickly seeing what change is applied and whether it makes sense. It doesn't touch the actual code base. I'm using this patch for some time already. You can merge this pull request into a Git repository by running: $ git pull https://github.com/remibergsma/cloudstack git-pr-show-commits Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1227.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1227 commit 52edbbb6cc2e2c58e360b737143c10adddc43880 Author: Remi Bergsma Date: 2015-12-12T10:00:41Z Show actual diff in commits after merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9135 - As a Developer I want t...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1221#issuecomment-164137434 LGTM based on running the tests: ``` [root@cs1 integration]# cat /tmp//MarvinLogs/test_internal_lb_SFTBEY/results.txt Test create, assign, remove of an Internal LB with roundrobin http traffic to 3 vm's in a Single VPC ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Status : SUCCESS === ok Test create, assign, remove of an Internal LB with roundrobin http traffic to 3 vm's in a Redundant VPC ... === TestName: test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | Status : SUCCESS === ok Test to verify access to loadbalancer haproxy admin stats page ... === TestName: test_03_vpc_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS === ok Test to verify access to loadbalancer haproxy admin stats page ... === TestName: test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS === ok -- Ran 4 tests in 3847.453s OK ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Show actual diff in commits after merge w...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1227#issuecomment-164138076 Example of merging PR 1221: https://cloud.githubusercontent.com/assets/1630096/11761460/05e97f22-a0c4-11e5-8c4a-da8cf67c973e.png";> --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Show actual diff in commits after merge w...
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1227#issuecomment-164139213 Cool! Also nice you put the screenshot to show it in action. LGTM Cheers, Wilder --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-4374 - As a Developer I want t...
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1222 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9086: ACS allows to create iso...
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1188 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9135 - As a Developer I want t...
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1221 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9122: latest credit entries sh...
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1192 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Remove template ulimit from createtmplt.s...
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1223#issuecomment-164140671 @remibergsma possible someone added this historically and nobody cared but now. I can check this later and get back to you. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9128: Testcase to verify physi...
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1199#discussion_r47431233
--- Diff: test/integration/testpaths/testpath_snapshot_limits.py ---
@@ -358,3 +362,129 @@ def test_01_storage_snapshots_limits(self):
)
return
+
+@attr(tags=["advanced", "basic"], required_hardware="true")
+def test_02_snapshot_size_check(self):
+""" Check Snapshots size in database
+1. Create file on ROOT disk of deployed VM.
+2. Create Snapshot of ROOT disk.
+3. Check if physiacal_size parameter of snapshot_store_ref
table
+ has physical size of snapshot
+"""
+if self.hypervisor.lower() not in ["xenserver", "vmware"]:
+self.skipTest("Test not to be run on %s" % self.hypervisor)
--- End diff --
Why can't this run on xenserver?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9128: Testcase to verify physi...
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1199#discussion_r47431243
--- Diff: test/integration/testpaths/testpath_snapshot_limits.py ---
@@ -358,3 +362,129 @@ def test_01_storage_snapshots_limits(self):
)
return
+
+@attr(tags=["advanced", "basic"], required_hardware="true")
+def test_02_snapshot_size_check(self):
+""" Check Snapshots size in database
+1. Create file on ROOT disk of deployed VM.
+2. Create Snapshot of ROOT disk.
+3. Check if physiacal_size parameter of snapshot_store_ref
table
+ has physical size of snapshot
+"""
+if self.hypervisor.lower() not in ["xenserver", "vmware"]:
+self.skipTest("Test not to be run on %s" % self.hypervisor)
+
+root_volumes_list = list_volumes(
+self.apiclient,
+virtualmachineid=self.vm.id,
+type=ROOT,
+listall=True
+)
+
+status = validateList(root_volumes_list)
+self.assertEqual(
+status[0],
+PASS,
+"Check listVolumes response for ROOT Disk")
+
+root_volume = root_volumes_list[0]
+
+# Get Secondary Storage Value from Database
+qryresult_before_snapshot = self.dbclient.execute(
+" select id, account_name, secondaryStorageTotal\
+from account_view where account_name = '%s';" %
+self.account.name)
+
+self.assertNotEqual(
+len(qryresult_before_snapshot),
+0,
+"Check sql query to return SecondaryStorageTotal of account")
+
+storage_qry_result_old = qryresult_before_snapshot[0]
+secondary_storage_old = storage_qry_result_old[2]
+
+createChecksum(
+self.testdata,
+self.vm,
+root_volume,
+"rootdiskdevice")
+
+time.sleep(30)
--- End diff --
Can you please explain why we wait 30s here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9127 Missing PV-bootloader-arg...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1196#issuecomment-164146123 Ping @wilderrodrigues --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Show actual diff in commits after merge w...
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1227#issuecomment-164146356 Nice! LGTM :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-9113: skip vm with incon...
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1182#issuecomment-164146578 LGTM based on the code. It does implement a use case that should be tested. not sure if we need it in this PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Show actual diff in commits after merge w...
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1227#issuecomment-164147061 LGTM, this is why we want to be merging code instead of rebasing, no more commits on master! only merges! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Show actual diff in commits after merge w...
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1227 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-9113: skip vm with incon...
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1182 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: [UI] bug fix: Delete added ACL lists is n...
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1211#issuecomment-164148314 LGTM, thanks for testing @remibergsma. I am going to trust on sight and as this as it is a port from the custom leaseweb code in 4.2.1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9127 Missing PV-bootloader-arg...
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1196#issuecomment-164148706 lgtm, doing a test build, now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9127 Missing PV-bootloader-arg...
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1196#discussion_r47431578
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixHelper.java
---
@@ -236,4 +236,15 @@ public static String getProductVersion(final
Host.Record record) {
}
return prodVersion;
}
+
+public static String getPVbootloaderArgs(String guestOS) {
+if (guestOS.startsWith("SUSE Linux Enterprise Server")) {
+if (guestOS.contains("64-bit")) {
+return "--kernel /boot/vmlinuz-xen --ramdisk
/boot/initrd-xen";
+} else if (guestOS.contains("32-bit")) {
+return "--kernel /boot/vmlinuz-xenpae --ramdisk
/boot/initrd-xenpae";
+}
+}
+return "";
+}
--- End diff --
Awesome! Thanks, @SudharmaJain !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9127 Missing PV-bootloader-arg...
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1196#issuecomment-164149214 Go for it, @remibergsma! Changes LGTM :+1: @DaanHoogland: should we wait for the outcome of your build? Cheers, Wilder --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-4787 - vmware diskcontro...
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1132#issuecomment-164150715 code LGTM and @remibergsma his test succeed, as this is in 4.5 I think it must go in 4.6 as well, however it contains way to little tests and can not be guaranteed to continue working. @bhaisaab please consider continued maintenance by automation, i.e. both unit - and integration tests. merging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9127 Missing PV-bootloader-arg...
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1196#discussion_r47431643 --- Diff: plugins/hypervisors/xenserver/test/com/cloud/hypervisor/xenserver/resource/CitrixHelperTest.java --- @@ -0,0 +1,35 @@ +package com.cloud.hypervisor.xenserver.resource; + +import junit.framework.Assert; +import org.junit.Test; + +import static org.junit.Assert.*; --- End diff -- import * is not accepted per the style guidelines enforced by checkstyle. please replace. ``` [INFO] Starting audit... /Users/daan/cloudstack/cloudstack/plugins/hypervisors/xenserver/test/com/cloud/hypervisor/xenserver/resource/CitrixHelperTest.java:6: Using the '.*' form of import should be avoided - org.junit.Assert.*. Audit done. ``` hence ``` [INFO] [INFO] BUILD FAILURE [INFO] [INFO] Total time: 07:29 min [INFO] Finished at: 2015-12-12T14:18:54+01:00 [INFO] Final Memory: 93M/788M [INFO] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) on project cloud-plugin-hypervisor-xenserver: Failed during checkstyle execution: There are 1 checkstyle errors. -> [Help 1] ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9127 Missing PV-bootloader-arg...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1196#issuecomment-164151105 Nice find @DaanHoogland Can you please fix this @SudharmaJain ? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-4787 - vmware diskcontro...
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1132 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: [UI] bug fix: Delete added ACL lists is n...
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1211 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Removed cloud-cli folder and contents, as...
GitHub user borisroman opened a pull request: https://github.com/apache/cloudstack/pull/1228 Removed cloud-cli folder and contents, as it is not maintained or used anymore. Remove legacy code. You can merge this pull request into a Git repository by running: $ git pull https://github.com/borisroman/cloudstack CLOUDSTACK-9149 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1228.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1228 commit 7f2bbcbfff909ad4bb155f6db1fa923794e85ef2 Author: Boris Schrijver Date: 2015-12-12T13:57:51Z Removed cloud-cli folder and contents, as it is not maintained or used anymore. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9146: Refactor Hypervisor KVM ...
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1224#issuecomment-164157579 Nice one, @borisroman ! LGTM :+1: Waiting for the test results. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9150: Remove docs/.tx/config
GitHub user borisroman opened a pull request: https://github.com/apache/cloudstack/pull/1229 CLOUDSTACK-9150: Remove docs/.tx/config The config file docs/.tx/config has been replaced with tools/transifex/.tx/config. It's not maintained or used so it must be removed. You can merge this pull request into a Git repository by running: $ git pull https://github.com/borisroman/cloudstack CLOUDSTACK-9150 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1229.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1229 commit 27e23fb11c80e14518afc48c91d5a18977d898c0 Author: Boris Schrijver Date: 2015-12-12T14:13:48Z Remove docs/.tx/config The config file docs/.tx/config has been replaced with tools/transifex/.tx/config. It's not maintained or used so it must be removed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: L10N update before 4.7.0 RC1
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1217#issuecomment-164159167 @milamberspace Dutch complemented --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Remove template ulimit from createtmplt.s...
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1223#issuecomment-164159535 40G sounds like an old fs limit. doesn't make sense nowadays. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8302: Removing snapshots on RB...
GitHub user dmytro-shevchenko opened a pull request: https://github.com/apache/cloudstack/pull/1230 CLOUDSTACK-8302: Removing snapshots on RBD Snapshot removing implemented if primary datastore is RBD https://issues.apache.org/jira/browse/CLOUDSTACK-8302 You can merge this pull request into a Git repository by running: $ git pull https://github.com/SafeSwissCloud/cloudstack CLOUDSTACK-8302 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1230.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1230 commit 32df243422d5985c8631686a0b2a29835f804079 Author: Amin Date: 2015-11-30T13:39:50Z Merge pull request #1 from apache/master Volume snapshot lifecycle patch on RBD as primary storage commit c4d749f3b41090c47d98431aef67fa769642c798 Author: Dmytro Shevchenko Date: 2015-12-10T15:07:58Z Merge from apache/master commit a47b9300e414039734017fde0a41d162b54891f2 Author: Dmytro Shevchenko Date: 2015-12-12T14:44:09Z https://issues.apache.org/jira/browse/CLOUDSTACK-8302 Snapshot removing implemented on RBD --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9151 - As a Developer I want t...
GitHub user wilderrodrigues opened a pull request: https://github.com/apache/cloudstack/pull/1231 CLOUDSTACK-9151 - As a Developer I want the VRID to be set within the limits of KeepaliveD This PR fixes a blocker issue! - Just like with RVRs, use the VRID 51 instead of making it dependent on the VPCID - Reason: arbitary unique number 0..255 used to differentiate multiple instances of vrrpd running on the same NIC (and hence same socket). virtual_router_id 51 You can merge this pull request into a Git repository by running: $ git pull https://github.com/ekholabs/cloudstack fix/vrid-rvpc-CLOUDSTACK-9151 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1231.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1231 commit 2bebb7f8a38c3ef94bbd55c69d7ec1070450dc22 Author: Wilder Rodrigues Date: 2015-12-12T15:26:00Z CLOUDSTACK-9151 - Removes the replacement of the VRID in the CsRedundant file - Just like with RVRs, use the VRID 51 instead of making it dependent on the VPCID - Reason: arbitary unique number 0..255 used to differentiate multiple instances of vrrpd running on the same NIC (and hence same socket). virtual_router_id 51 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9151 - As a Developer I want t...
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1231#issuecomment-164161230 Ping @remibergsma @DaanHoogland @borisroman Could you guys test it before the RC? I just fixed, but have to go to a concert now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8302: Removing snapshots on RB...
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1230#issuecomment-164161973 Hi @dmytro-shevchenko Thanks for implementing the removal code. Could you squash the commits and add a descriptive commit message? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Removed cloud-cli folder and contents, as...
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1228#issuecomment-164162326
*Environment*
- 1 KVM host on CentOS 7.1
- 1 Management Server on CentOS 7.1
- Agent + Common RPMs built from source
*Integration test suite 1*
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component/test_password_server.py \
smoke/test_vpc_redundant.py \
smoke/test_routers_iptables_default_policy.py \
smoke/test_routers_network_ops.py \
smoke/test_vpc_router_nics.py \
smoke/test_router_dhcphosts.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_vpc_vpn.py \
smoke/test_privategw_acl.py \
smoke/test_network.py
```
*Result test suite 1*
```
Check the password file in the Router VM ... === TestName:
test_isolate_network_password_server | Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ...
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status :
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and
check default routes ... === TestName: test_02_redundant_VPC_default_routes |
Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ...
=== TestName:
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Status :
SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName:
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... ===
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_03_RVR_Network_check_router_state | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status :
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... ===
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName:
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName:
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName:
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... ===
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80
| Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status :
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status :
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS
===
ok
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn
| Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : SUCCESS
===
ok
test_01_vpc_privategw_acl
(integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName:
test_01_vpc_privategw_acl | Status : SUCCESS ===
ok
test_02_vpc_privategw_static_routes
(integration.smoke.test_privategw_ac
[GitHub] cloudstack pull request: Removed .pydevproject from plugin kvm hyp...
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1226#issuecomment-164162389
**Environment**
- 1 KVM host on CentOS 7.1
- 1 Management Server on CentOS 7.1
- Agent + Common RPMs built from source
**Integration test suite 1**
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component/test_password_server.py \
smoke/test_vpc_redundant.py \
smoke/test_routers_iptables_default_policy.py \
smoke/test_routers_network_ops.py \
smoke/test_vpc_router_nics.py \
smoke/test_router_dhcphosts.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_vpc_vpn.py \
smoke/test_privategw_acl.py \
smoke/test_network.py
```
**Result test suite 1**
```
Check the password file in the Router VM ... === TestName:
test_isolate_network_password_server | Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ...
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status :
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and
check default routes ... === TestName: test_02_redundant_VPC_default_routes |
Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ...
=== TestName:
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Status :
SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName:
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... ===
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_03_RVR_Network_check_router_state | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status :
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... ===
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName:
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName:
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName:
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... ===
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80
| Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status :
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status :
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS
===
ok
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn
| Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : SUCCESS
===
ok
test_01_vpc_privategw_acl
(integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName:
test_01_vpc_privategw_acl | Status : SUCCESS ===
ok
test_02_vpc_privategw_static_routes
(integration.smoke.test_privat
[GitHub] cloudstack pull request: CLOUDSTACK-9146: Refactor Hypervisor KVM ...
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1224#issuecomment-164163315
It works! Though please tests yourself for more confidence!
**Environment**
- 1 KVM host on CentOS 7.1
- 1 Management Server on CentOS 7.1
- Agent + Common RPMs built from source
**Integration test suite 1**
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component/test_password_server.py \
smoke/test_vpc_redundant.py \
smoke/test_routers_iptables_default_policy.py \
smoke/test_routers_network_ops.py \
smoke/test_vpc_router_nics.py \
smoke/test_router_dhcphosts.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_vpc_vpn.py \
smoke/test_privategw_acl.py \
smoke/test_network.py
```
**Result test suite 1**
```
Check the password file in the Router VM ... === TestName:
test_isolate_network_password_server | Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ...
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status :
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and
check default routes ... === TestName: test_02_redundant_VPC_default_routes |
Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ...
=== TestName:
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Status :
SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName:
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... ===
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_03_RVR_Network_check_router_state | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status :
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... ===
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName:
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName:
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName:
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... ===
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80
| Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status :
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status :
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS
===
ok
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn
| Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : SUCCESS
===
ok
test_01_vpc_privategw_acl
(integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName:
test_01_vpc_privategw_acl | Status : SUCCESS ===
ok
[GitHub] cloudstack pull request: CLOUDSTACK-9147: In hypervisor-plugin-kvm...
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1225#issuecomment-164163506
It works! Though please tests yourself for more confidence!
@wilderrodrigues @miguelaferreira @remibergsma
**Environment**
- 1 KVM host on CentOS 7.1
- 1 Management Server on CentOS 7.1
- Agent + Common RPMs built from source
**Integration test suite 1**
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component/test_password_server.py \
smoke/test_vpc_redundant.py \
smoke/test_routers_iptables_default_policy.py \
smoke/test_routers_network_ops.py \
smoke/test_vpc_router_nics.py \
smoke/test_router_dhcphosts.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_vpc_vpn.py \
smoke/test_privategw_acl.py \
smoke/test_network.py
```
**Result test suite 1**
```
Check the password file in the Router VM ... === TestName:
test_isolate_network_password_server | Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ...
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status :
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and
check default routes ... === TestName: test_02_redundant_VPC_default_routes |
Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ...
=== TestName:
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Status :
SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName:
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... ===
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_03_RVR_Network_check_router_state | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status :
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... ===
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName:
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName:
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName:
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... ===
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80
| Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status :
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status :
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS
===
ok
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn
| Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : SUCCESS
===
ok
test_01_vpc_privategw_acl
(integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName:
test_01_vp
[GitHub] cloudstack pull request: CLOUDSTACK-9151 - As a Developer I want t...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1231#issuecomment-164163586 Thanks for the quick fix @wilderrodrigues. Bit explanation: redundant routers worked fine in our 4.7 cloud, then all of a sudden were broken. Root cause was due to `virtual_router_id` was set to vpc_id. When we got more than 255 it broke, as this `keepalived` setting can only be 0-255. This keeps the default in the template, which is in `keepalived.conf.templ`: ``` virtual_router_id 51 ``` Thanks @fborn for discovering the issue! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9151 - As a Developer I want t...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1231#issuecomment-164163749 You can read the following from man keepalived.conf: ``` # arbitary unique number 0..255 # used to differentiate multiple instances of vrrpd # running on the same NIC (and hence same socket). virtual_router_id 51 ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-4787 - vmware diskcontro...
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1132#issuecomment-164165606 @DaanHoogland thanks for merging. This is not yet in 4.5 as I'm yet to merge the 4.5 based PR https://github.com/apache/cloudstack/pull/1131 Will do that on Monday :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9151 - As a Developer I want t...
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1231#issuecomment-164167571 LGTM, perhaps we can use VPCID % 255 to get a value that is less than 255 but greater than 0? @remibergsma @fborn @wilderrodrigues Do you think using a static/fixed value can cause any issue (maybe in future)? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9150: Remove docs/.tx/config
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1229#issuecomment-164167598 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9146: Refactor Hypervisor KVM ...
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1224#issuecomment-164167703 This is codebase wide issue that we're not following the default maven directory structure for all the maven projects/modules. What is the motivation behind doing this only for KVM plugin, any benefit we would get out of this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9141: Validate userdata for va...
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1220#issuecomment-164167812 Time to move to Java 8, post 4.7 perhaps? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9141: Validate userdata for va...
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1220#issuecomment-164168237 @bhaisaab Good idea to do that indeed. I think many of us want Java 8. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9146: Refactor Hypervisor KVM ...
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/1224#issuecomment-164169348 Since no one is making a PR to improve all modules, I would say that incremental improvement is better than no improvement at all. I have done the same to the NSX plugin and to the untold module. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9146: Refactor Hypervisor KVM ...
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/1224#issuecomment-164169391 And btw LGTM! Nice one @borisroman --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9146: Refactor Hypervisor KVM ...
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1224#issuecomment-164169497 @miguelaferreira I also think incremental is better. Keeps changed contained and documented. Else it would be a PR that changes "OVER " files... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/1094#issuecomment-164169523 Thanks for the instructions @serg38 I will attempt to reproduce this early this week. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9146: Refactor Hypervisor KVM ...
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1224#issuecomment-164169626 @bhaisaab I think an incremental approach is better. I will also create issue for all other projects and move the each at a time. The plugin-hypervisor-kvm just happens to be the first. Once everything is moved we'll have benefits. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9151 - As a Developer I want t...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1231#issuecomment-164170412 @bhaisaab nice suggestion! Not sure if it is needed though. The vrrp is done over the first guest network, so it cannot clash with other router pairs. Other tiers are handled by the same keepalived/vrrp instance so that's also fine. I cannot think of a way it'd clash. And even when we make it 0-255, it could still clash (and be harder to spot). First testing it now to see if it resolves the issues we see. Will report back soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9150: Remove docs/.tx/config
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1229#issuecomment-164170453 Ping @milamberspace to have a look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Removed cloud-cli folder and contents, as...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1228#issuecomment-164170827 LGTM based on the above tests. Makes no sense to run the same tests again :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9146: Refactor Hypervisor KVM ...
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1224#issuecomment-164171043 @borisroman what benefits we will have? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9152: Remove unused folder(s)/...
GitHub user borisroman opened a pull request: https://github.com/apache/cloudstack/pull/1232 CLOUDSTACK-9152: Remove unused folder(s)/file(s); utils/bindir As a developer I want a project without dead or unused code. Builds ok ``` [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 5:54.304s (Wall Clock) [INFO] Finished at: Sat Dec 12 18:47:43 CET 2015 [INFO] Final Memory: 96M/788M [INFO] ``` You can merge this pull request into a Git repository by running: $ git pull https://github.com/borisroman/cloudstack CLOUDSTACK-9152 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1232.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1232 commit 7c1ea231f2918ff84d36ecf1dfb7a39115e2923c Author: Boris Schrijver Date: 2015-12-12T17:35:48Z CLOUDSTACK-9152: Remove unused folder(s)/file(s); utils/bindir --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9151 - As a Developer I want t...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1231#issuecomment-164171363 Jenkins error unrelated to PR change: ``` Build timed out (after 120 minutes). Marking the build as aborted. ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9151 - As a Developer I want t...
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1231#issuecomment-164172595
First test results:
keepalived.conf looks as expected:
```
vrrp_instance inside_network {
state EQUAL
interface eth2
virtual_router_id 51
nopreempt
```
Service is running:
```
root@r-11-VM:/etc/keepalived# ps aux | grep keepalived
root 4058 0.1 0.4 47040 1032 ?Ss 17:56 0:00
/usr/sbin/keepalived
root 4059 0.1 0.9 53308 2368 ?S17:56 0:00
/usr/sbin/keepalived
root 4060 0.2 0.7 53308 1768 ?S17:56 0:00
/usr/sbin/keepalived
root 5994 0.0 0.3 8076 852 pts/1S+ 18:00 0:00 grep
keepalived
```
Logs:
```
Dec 12 17:56:12 r-11-VM Keepalived_vrrp[4060]: Registering Kernel netlink
reflector
Dec 12 17:56:12 r-11-VM Keepalived_vrrp[4060]: Registering Kernel netlink
command channel
Dec 12 17:56:12 r-11-VM Keepalived_vrrp[4060]: Registering gratuitous ARP
shared channel
Dec 12 17:56:12 r-11-VM Keepalived_vrrp[4060]: Opening file
'/etc/keepalived/keepalived.conf'.
Dec 12 17:56:12 r-11-VM Keepalived_vrrp[4060]: Truncating auth_pass to 8
characters
Dec 12 17:56:12 r-11-VM Keepalived_vrrp[4060]: Configuration is using :
64669 Bytes
Dec 12 17:56:12 r-11-VM Keepalived_vrrp[4060]: Using LinkWatch kernel
netlink reflector...
Dec 12 17:56:12 r-11-VM Keepalived_vrrp[4060]:
VRRP_Instance(inside_network) Entering BACKUP STATE
Dec 12 17:56:13 r-11-VM Keepalived_vrrp[4060]: VRRP_Script(heartbeat)
succeeded
Dec 12 17:56:16 r-11-VM Keepalived_vrrp[4060]:
VRRP_Instance(inside_network) Transition to MASTER STATE
Dec 12 17:56:17 r-11-VM Keepalived_vrrp[4060]:
VRRP_Instance(inside_network) Entering MASTER STATE
```
https://cloud.githubusercontent.com/assets/1630096/11763223/ea78f8a0-a102-11e5-87dc-eb5f8fdaecd3.png";>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9146: Refactor Hypervisor KVM ...
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1224#issuecomment-164174058
LGTM based on these tests (run on KVM):
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component/test_password_server.py \
smoke/test_vpc_redundant.py \
smoke/test_routers_iptables_default_policy.py \
smoke/test_routers_network_ops.py \
smoke/test_vpc_router_nics.py \
smoke/test_router_dhcphosts.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_vpc_vpn.py \
smoke/test_privategw_acl.py \
smoke/test_network.py
```
Result:
```
Check the password file in the Router VM ... === TestName:
test_isolate_network_password_server | Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ...
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status :
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and
check default routes ... === TestName: test_02_redundant_VPC_default_routes |
Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ...
=== TestName:
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Status :
SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName:
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... ===
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_03_RVR_Network_check_router_state | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status :
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... ===
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName:
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName:
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName:
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... ===
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80
| Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status :
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status :
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS
===
ok
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn
| Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : SUCCESS
===
ok
test_01_vpc_privategw_acl
(integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName:
test_01_vpc_privategw_acl | Status : SUCCESS ===
ok
test_02_vpc_privategw_static_routes
(integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName:
test_02_vpc_privategw_static_routes | Status : SUCCESS ===
ok
test_03_rvpc_privategw_static_routes
(integration.smoke.test_privateg
[GitHub] cloudstack pull request: CLOUDSTACK-9147: In hypervisor-plugin-kvm...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1225#issuecomment-164174234 @borisroman I can't get it to run. It builds but after start it errors out like this: ``` 2015-12-12 10:01:33,843 WARN [o.a.c.s.m.c.ResourceApplicationContext] (main:null) (logid:) Exception encountered during context initialization - cancelling refresh attempt org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'org.apache.cloudstack.spring.lifecycle.ConfigDepotLifeCycle#0': Injection of autowired dependencies failed; nested excep tion is org.springframework.beans.factory.BeanCreationException: Could not autowire field: org.apache.cloudstack.framework.config.ConfigDepotAdmin org.apache.cloudstack.spring.lifecycle.ConfigDepotLifeCycle.c onfigDepotAdmin; nested exception is org.springframework.beans.factory.CannotLoadBeanClassException: Cannot find class [com.cloud.ha.KVMInvestigator] for bean with name 'KVMInvestigator' defined in URL [jar:f ile:/root/.m2/repository/org/apache/cloudstack/cloud-plugin-hypervisor-kvm/4.7.0-SNAPSHOT/cloud-plugin-hypervisor-kvm-4.7.0-SNAPSHOT.jar!/META-INF/cloudstack/kvm-compute/spring-kvm-compute-context.xml]; neste d exception is java.lang.ClassNotFoundException: com.cloud.ha.KVMInvestigator at org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor.postProcessPropertyValues(AutowiredAnnotationBeanPostProcessor.java:298) at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.populateBean(AbstractAutowireCapableBeanFactory.java:1148) at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:519) at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:458) at org.springframework.beans.factory.support.AbstractBeanFactory$1.getObject(AbstractBeanFactory.java:293) at org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:223) at org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:290) at org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:195) at org.springframework.context.support.AbstractApplicationContext.registerBeanPostProcessors(AbstractApplicationContext.java:755) at org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:464) at org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.loadContext(DefaultModuleDefinitionSet.java:145) at org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet$2.with(DefaultModuleDefinitionSet.java:122) at org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.withModule(DefaultModuleDefinitionSet.java:245) at org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.withModule(DefaultModuleDefinitionSet.java:250) at org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.withModule(DefaultModuleDefinitionSet.java:250) at org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.withModule(DefaultModuleDefinitionSet.java:250) at org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.withModule(DefaultModuleDefinitionSet.java:250) at org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.withModule(DefaultModuleDefinitionSet.java:250) at org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.withModule(DefaultModuleDefinitionSet.java:233) at org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.loadContexts(DefaultModuleDefinitionSet.java:117) at org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.load(DefaultModuleDefinitionSet.java:79) at org.apache.cloudstack.spring.module.factory.ModuleBasedContextFactory.loadModules(ModuleBasedContextFactory.java:37) at org.apache.cloudstack.spring.module.factory.CloudStackSpringContext.init(CloudStackSpringContext.java:71) at org.apache.cloudstack.spring.module.factory.CloudStackSpringContext.(CloudStackSpringContext.java:58) at org.apache.cloudstack.spring.module.factory.CloudStackSpringContext.(CloudStackSpringContext.java:62) at org.apache.cloudstack.spring.module.web.CloudStackContextLoaderListener.contextInitialized(CloudStackContextLoaderListener.java:52) at org.mortbay.jetty.handler.ContextHandler.startContext(ContextHandler.java:549)
[GitHub] cloudstack pull request: CLOUDSTACK-9134: set device_id as the fir...
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1209#issuecomment-164174368
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component/test_password_server.py \
smoke/test_vpc_redundant.py \
smoke/test_routers_iptables_default_policy.py \
smoke/test_routers_network_ops.py \
smoke/test_vpc_router_nics.py \
smoke/test_router_dhcphosts.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_vpc_vpn.py \
smoke/test_privategw_acl.py \
smoke/test_network.py
```
Result:
```
Check the password file in the Router VM ... === TestName:
test_isolate_network_password_server | Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ...
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status :
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and
check default routes ... === TestName: test_02_redundant_VPC_default_routes |
Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ...
=== TestName:
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Status :
SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName:
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... ===
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_03_RVR_Network_check_router_state | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status :
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... ===
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName:
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName:
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName:
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... ===
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80
| Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status :
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status :
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS
===
ok
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn
| Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : SUCCESS
===
ok
test_01_vpc_privategw_acl
(integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName:
test_01_vpc_privategw_acl | Status : SUCCESS ===
ok
test_02_vpc_privategw_static_routes
(integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName:
test_02_vpc_privategw_static_routes | Status : SUCCESS ===
ok
test_03_rvpc_privategw_static_routes
(integration.smoke.test_privategw_acl.TestPri
[GitHub] cloudstack pull request: CLOUDSTACK-9136: remove ssh keypairs alon...
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1212#issuecomment-164174462
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component/test_password_server.py \
smoke/test_vpc_redundant.py \
smoke/test_routers_iptables_default_policy.py \
smoke/test_routers_network_ops.py \
smoke/test_vpc_router_nics.py \
smoke/test_router_dhcphosts.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_vpc_vpn.py \
smoke/test_privategw_acl.py \
smoke/test_network.py
```
Result:
```
Check the password file in the Router VM ... === TestName:
test_isolate_network_password_server | Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ...
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status :
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and
check default routes ... === TestName: test_02_redundant_VPC_default_routes |
Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ...
=== TestName:
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Status :
SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName:
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... ===
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_03_RVR_Network_check_router_state | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status :
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... ===
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName:
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName:
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName:
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... ===
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80
| Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status :
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status :
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS
===
ok
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn
| Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : SUCCESS
===
ok
test_01_vpc_privategw_acl
(integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName:
test_01_vpc_privategw_acl | Status : SUCCESS ===
ok
test_02_vpc_privategw_static_routes
(integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName:
test_02_vpc_privategw_static_routes | Status : SUCCESS ===
ok
test_03_rvpc_privategw_static_routes
(integration.smoke.test_privategw_acl.TestPri
[GitHub] cloudstack pull request: CLOUDSTACK-9147: In hypervisor-plugin-kvm...
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1225#issuecomment-164175379 @remibergsma Please try again! I changed a few files today. You probably didn't notice because I squashed them in the commit from yesterday. (Which you likely build) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9150: Remove docs/.tx/config
Github user milamberspace commented on the pull request: https://github.com/apache/cloudstack/pull/1229#issuecomment-164176128 Yes, this config file doesn't use at this place. Can be remove. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: L10N update before 4.7.0 RC1
Github user milamberspace commented on the pull request: https://github.com/apache/cloudstack/pull/1217#issuecomment-164176177 Thanks @DaanHoogland PR updated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9151 - As a Developer I want t...
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1231#issuecomment-164176274 As an operator I want this in :p have only read the feature description in jira and the diff but lgtm based on that and @remibergsma his test results. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9151 - As a Developer I want t...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1231#issuecomment-164176585 @DaanHoogland Thanks. Deploying to a real cloud as we speak. Will verify there too. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: L10N update before 4.7.0 RC1
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1217#issuecomment-164177113 @milamberspace @remibergsma @DaanHoogland LGTM :+1: Only did code review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9133: Two volume.delete usage ...
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1207#issuecomment-164177131 @priyankparihar these are nice results but I have no way of verifying the latter is actually the good result. can you write a test that proves proper behaviour? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9151 - As a Developer I want t...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1231#issuecomment-164177507 Update: Verified the same as above in our pre-production environment (aka Employee Cloud). Will now deploy to production as it works as expected. When the integration tests are done and show nothing broke, we will merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Bug-ID: CLOUDSTACK-8882: calculate networ...
Github user borisroman commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/859#discussion_r47435639
--- Diff: engine/schema/src/com/cloud/usage/UsageVO.java ---
@@ -125,6 +125,25 @@ public UsageVO(Long zoneId, Long accountId, Long
domainId, String description, S
this.endDate = endDate;
}
+//Network Offering Usage
+public UsageVO(Long zoneId, Long accountId, Long domainId, String
description, String usageDisplay, int usageType, Double rawUsage, Long vmId,
+ Long offeringId, Long usageId, Long networkId, Date
startDate, Date endDate) {
+this.zoneId = zoneId;
+this.accountId = accountId;
+this.domainId = domainId;
+this.description = description;
+this.usageDisplay = usageDisplay;
+this.usageType = usageType;
+this.rawUsage = rawUsage;
+this.vmInstanceId = vmId;
+this.offeringId = offeringId;
+this.usageId = usageId;
+this.startDate = startDate;
+this.endDate = endDate;
+this.networkId = networkId;
+}
+
+
public UsageVO(Long zoneId, Long accountId, Long domainId, String
description, String usageDisplay, int usageType, Double rawUsage, Long vmId,
String vmName,
--- End diff --
Isn't it possible to extends this one instead of creating a new
constructor?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9133: Two volume.delete usage ...
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1207#issuecomment-164178065 @priyankparihar Could you point me where in VolumeStateListener it is emitted? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9136: remove ssh keypairs alon...
Github user borisroman commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1212#discussion_r47435698 --- Diff: server/test/com/cloud/user/AccountManagerImplTest.java --- @@ -185,6 +186,8 @@ @Mock GlobalLoadBalancerRuleDao _gslbRuleDao; @Mock +SSHKeyPairDao _sshKeyPairDao; --- End diff -- You've added _sshKeyPairDao here. Without using it! Could you please write a test for the functionality you improved? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8968: UI icon over VM snapshot...
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1150#issuecomment-164178250 @nitin-maharana @bhaisaab both I and @remibergsma don't work with vmware as part of our cloudstack installs, can you do testing and preferably write tests for proving the continued funtioning of the change? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9136: remove ssh keypairs alon...
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1212#issuecomment-164178288 Until either a test is added, which is preferred! Or the dead code (see comment) is removed, :-1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9104: VM naming convention in ...
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1165#issuecomment-164178352 @bhaisaab @priyankparihar what is the verdict on this change? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9139 make zwps default when de...
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1219#issuecomment-164179455 LGTM :+1: Deployed with Ceph.  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Changed UsageEventUtils to UsageEventEmit...
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1191#discussion_r47435785
--- Diff:
engine/components-api/src/com/cloud/event/UsageEventEmitterImpl.java ---
@@ -38,44 +34,37 @@
import com.cloud.event.dao.UsageEventDao;
import com.cloud.user.Account;
import com.cloud.user.dao.AccountDao;
-import com.cloud.utils.component.ComponentContext;
-public class UsageEventUtils {
-private static UsageEventDao s_usageEventDao;
-private static AccountDao s_accountDao;
-private static DataCenterDao s_dcDao;
-private static final Logger s_logger =
Logger.getLogger(UsageEventUtils.class);
-protected static EventBus s_eventBus = null;
-protected static ConfigurationDao s_configDao;
+public class UsageEventEmitterImpl implements UsageEventEmitter {
+private static final Logger s_logger =
Logger.getLogger(UsageEventEmitterImpl.class);
+
+@Inject
+UsageEventDao _usageEventDao;
--- End diff --
please do not prefix members with '_'
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Changed UsageEventUtils to UsageEventEmit...
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1191#discussion_r47435795
--- Diff:
engine/components-api/src/com/cloud/event/UsageEventEmitterImpl.java ---
@@ -131,54 +127,55 @@ public static void publishUsageEvent(String
usageType, long accountId, long zone
}
-private static void saveUsageEvent(String usageType, long accountId,
long zoneId, long resourceId, String resourceName, Long offeringId, Long
templateId,
+private void saveUsageEvent(String usageType, long accountId, long
zoneId, long resourceId, String resourceName, Long offeringId, Long templateId,
String resourceType, Map details) {
UsageEventVO usageEvent = new UsageEventVO(usageType, accountId,
zoneId, resourceId, resourceName, offeringId, templateId, resourceType);
-s_usageEventDao.persist(usageEvent);
-s_usageEventDao.saveDetails(usageEvent.getId(), details);
+_usageEventDao.persist(usageEvent);
--- End diff --
please change to usageEventDao. no reason in morden days to use these
prefixes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9134: set device_id as the fir...
Github user borisroman commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1209#discussion_r47435854
--- Diff: engine/schema/src/com/cloud/vm/dao/NicDaoImpl.java ---
@@ -222,11 +222,20 @@ public String getIpAddress(long networkId, long
instanceId) {
}
@Override
-public int countNics(long instanceId) {
-SearchCriteria sc = CountBy.create();
-sc.setParameters("vmId", instanceId);
-List results = customSearch(sc, null);
-return results.get(0);
+public int getFreeDeviceId(long instanceId) {
+Filter searchFilter = new Filter(NicVO.class, "deviceId", true,
null, null);
+SearchCriteria sc = deviceIdSearch.create();
+sc.setParameters("instance", instanceId);
+List deviceIds = customSearch(sc, searchFilter);
+
+int freeDeviceId = 0;
+for (int deviceId : deviceIds) {
--- End diff --
@ustcweizhou Could you elaborate on what the logic does?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Changed UsageEventUtils to UsageEventEmit...
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1191#discussion_r47435856
--- Diff:
server/test/org/apache/cloudstack/networkoffering/MockUsageEventEmitter.java ---
@@ -0,0 +1,134 @@
+package org.apache.cloudstack.networkoffering;
+
+import java.util.Map;
+
+import com.cloud.event.UsageEventEmitter;
+
+public class MockUsageEventEmitter implements UsageEventEmitter {
+
+@Override
+public void publishUsageEvent(String paramString1, long paramLong1,
+long paramLong2, long paramLong3, String paramString2,
+Long paramLong4, Long paramLong5, Long paramLong6,
+String paramString3, String paramString4) {
+// TODO Auto-generated method stub
--- End diff --
this (type of) comment can be removed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9139 make zwps default when de...
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1219 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9114: restartnetwork with clea...
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1198#issuecomment-164186641 I will look at improving the integration tests but can you do the improvements to the code as @wilderrodrigues suggested (or comment on them)? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9151 - As a Developer I want t...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1231#issuecomment-164186662 Update: this resolved our production problem. It now works fine in master+this PR. LGTM :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1206#issuecomment-164187066 @nitin-maharana I don't agree we should allow the user to get a default name if (s)he doesn't care. I'd say let the name be the uuid-generated one when empty (as well as when null). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
