[GitHub] cloudstack pull request: Strongswan vpn feature
Github user jayapalu commented on the pull request: https://github.com/apache/cloudstack/pull/872#issuecomment-162812927 @remibergsma It seems the systemvmvbuilder machine is down. He is having access to these machines ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: [GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script
@terbolour, as per the previous logic in the test, it will register xenserver template for any hypervisor other than kvm and vm deployment fails for other hypervisors like vmware,hyper-v and lxc. So I was asking how we should handle this. On Tue, Dec 8, 2015 at 12:44 PM, terbolous wrote: > Github user terbolous commented on the pull request: > > https://github.com/apache/cloudstack/pull/1156#issuecomment-162797528 > > @sanju1010 it works for XenServer as well atleast, haven't tried > VMware. But you'll have to change your script to adjust to the different > output > > > --- > If your project is set up for it, you can reply to this email and have your > reply appear on GitHub as well. If your project does not have this feature > enabled and wishes so, or if the feature is enabled but not working, please > contact infrastructure at infrastruct...@apache.org or file a JIRA ticket > with INFRA. > --- >
[GitHub] cloudstack pull request: CLOUDSTACK-9112: Deploy VM failing freque...
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1180#issuecomment-162821748 Hi @harikrishna-patnala Anyway we can test this? Is there any integration test that we can use to cover your changes? Concerning the new methods you introduced, any chance to get some unit tests to cover the logic? Could you describe which steps you followed to test those changes? Would be nice to come up with some strategy that will help reviewers to test your changes. Cheers, Wilder --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fix for CLOUDSTACK-8937 - XenServer migra...
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1037#issuecomment-162824106 Ping @bhaisaab @atrbgithub If I get some details on how to test - steps - I can give it a try. Cheers, Wilder --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: Feature freeze ACS 4.7 next Monday
Hi there cs user,
If you put some details on the PR about how to test it, I can help out and,
perhaps, even write a test for it.
Cheers,
Wilder
> On 07 Dec 2015, at 15:09, cs user wrote:
>
> Hi Folks,
>
> Would anyone else be able to give
> https://github.com/apache/cloudstack/pull/1037 a try at some point?
>
> Quite a serious issue when running in clustered mode with Xen, and trying
> to perform VM migrations between hosts.
>
> Thanks!
>
> On Mon, Dec 7, 2015 at 12:08 PM, sebgoa wrote:
>
>> The rn repo contains a script that polls JIRA for a release filter and
>> generates the tables of issues fixed:
>>
>> https://github.com/apache/cloudstack-docs-rn/blob/master/utils/jira.py
>>
>> but we are not tracking the ones that really are *features*….
>>
>> small detail that would be nice to sort out.
>>
>> On Dec 7, 2015, at 12:01 PM, Remi Bergsma
>> wrote:
>>
>>> Hi Seb,
>>>
>>> Now that we merge everything and have a smaller scope, it should be
>> easier to get the list of pull requests that got in since 4.6.
>>>
>>> Quick attempt:
>>>
>>> git log --pretty=oneline --abbrev-commit upstream/4.6..master | grep
>> Merge | grep -v release | grep -v 4\.6 | awk {'print $5'} | sed s/\#//g |
>> sort -n
>>>
>>> 801
>>> 834
>>> 840
>>> 841
>>> 850
>>> 929
>>> 935
>>> 937
>>> 942
>>> 943
>>> 944
>>> 1007
>>> 1013
>>> 1018
>>> 1019
>>> 1021
>>> 1035
>>> 1038
>>> 1049
>>> 1051
>>> 1057
>>> 1065
>>> 1068
>>> 1069
>>> 1071
>>> 1083
>>> 1084
>>> 1086
>>> 1092
>>> 1100
>>> 1102
>>> 1107
>>> 1108
>>> 1110
>>> 1118
>>> 1122
>>> 1128
>>> 1129
>>> 1137
>>> 1139
>>> 1140
>>> 1143
>>> 1167
>>> 1172
>>> 1173
>>>
>>> If we make a script that gets this output and queries Github, we can get
>> a list of the PR titles. Then we need to make sure those titles are any
>> good ;-)
>>>
>>>
>>> Regards,
>>> Remi
>>>
>>>
>>>
>>>
>>> On 07/12/15 10:13, "sebgoa" wrote:
>>>
On Dec 7, 2015, at 9:56 AM, Daan Hoogland
>> wrote:
> Rohit, Sebastien,
>
> I think we do not need to hurry any issues. work on 4.8 will start in
> January or february at the latest.
I don't want to hurry anything, I want to be able to have release notes
>> that describe *all* the features added.
Check the 4.6 release notes, I am sure we did more than this, but since
>> dev more often than not don't care much about the RN, the features are not
>> publicized.
>
> On Mon, Dec 7, 2015 at 8:55 AM, sebgoa wrote:
>
>> Hate to be a pain, but could you make sure to keep the exact list of
>> Features merged, so that the Release notes are accurate ?
>>
>> thanks
>>
>> On Dec 4, 2015, at 11:58 PM, Remi Bergsma <
>> rberg...@schubergphilis.com>
>> wrote:
>>
>>> Hi all,
>>>
>>> Next Monday we'll feature freeze for our upcoming 4.7 release. We
>> looked
>> through all open Pull Requests and below is our "whish list" to get
>> in 4.7.
>> Feel free to nominate any other changes that should go in 4.7. No
>> guarantees, there is limited time so only PRs that we actively work
>> on will
>> make it.
>>>
>>> The RC of 4.7.0 is scheduled for Monday Dec 14th so that we all will
>> have a nice Christmas present ;-)
>>>
>>> Please help us review these PRs. Most have already had some review
>> and
>> when we can reach 2xLGTM we can include them in 4.7 on time and make
>> another great release.
>>>
>>> Happy testing and reviewing!
>>>
>>> Regards,
>>> Daan & Remi
>>>
>>>
>>> Features & Fixes PRs:
>>>
>>> Quota
>>> https://github.com/apache/cloudstack/pull/768
>>>
>>> Logging enhancement
>>> https://github.com/apache/cloudstack/pull/1167
>>>
>>> VMware diskcontrollers
>>> https://github.com/apache/cloudstack/pull/1132
>>>
>>> ACS allows to create isolated networks with invalid gateway ip
>>> https://github.com/apache/cloudstack/pull/1125
>>>
>>> Update nic IP address of stopped vm
>>> https://github.com/apache/cloudstack/pull/1086
>>>
>>> Hypervisor changes to support UserData for Nuage VSP
>>> https://github.com/apache/cloudstack/pull/1142
>>>
>>> Support shared networking in NiciraNVP Plugin
>>> https://github.com/apache/cloudstack/pull/1094
>>>
>>> Strongswan vpn feature
>>> https://github.com/apache/cloudstack/pull/872
>>>
>>> VM Snapshotting implementation for KVM
>>> https://github.com/apache/cloudstack/pull/977
>>>
>>> Redundant VPC improvement
>>> (PR will follow over the weekend)
>>>
>>>
>>> UI PRs:
>>>
>>> [UI] fix bug: Cannot delete SSH keypairs in projects
>>> https://github.com/apache/cloudstack/pull/1154
>>>
>>> UI icon over VM snapshot to deploy user instance
>>> https://github.com/apache/cloudstack/pull/1150
>>>
>>> Newly added project is not showing in the drop
[GitHub] cloudstack pull request: Strongswan vpn feature
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/872#issuecomment-162825327 @jayapalu Can you share the right systemvm template somewhere? Otherwise I cannot test this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fix for CLOUDSTACK-8937 - XenServer migra...
Github user atrbgithub commented on the pull request: https://github.com/apache/cloudstack/pull/1037#issuecomment-162829832 Hi @wilderrodrigues To test this you would need to have 2 or more cloudstack management servers operating in a cluster with Xen hosts. Before applying this fix, when you try to live migrate vm's between hosts (root disks on local storage or primary storage), occasionally this will fail. It is random depending on which management servers are allocated the job. After applying the change in the pull request, migrations should no longer fail. Hope that is ok. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Jenkins job to build systemvm templates
Hi, It seems Jenkins slave ‘systemvmbuilder’ is down so I cannot build a systemvm template to build / test PR 872 (strong swan). Does anyone know another way to build a template? Regards, Remi
[GitHub] cloudstack pull request: CLOUDSTACK-9086: ACS allows to create iso...
GitHub user kansal opened a pull request: https://github.com/apache/cloudstack/pull/1188 CLOUDSTACK-9086: ACS allows to create isolated networks with invalide⦠⦠gateway IP address - Fixed and Test cases added Problem: There was no check for the network and broadcast IP addresses in the case where we provide the gateway and netmask while creating the isolated network. As a result the provided IP gets assigned to the eth0 interface of the VR. Note: This is in continuation of PR #1125 which I closed. You can merge this pull request into a Git repository by running: $ git pull https://github.com/kansal/cloudstack CLOUDSTACK-9086 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1188.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1188 commit 1b607b9c75bca7ac42086f56d79a6b83fa9d4bc0 Author: Kshitij Kansal Date: 2015-12-08T07:31:39Z CLOUDSTACK-9086: ACS allows to create isolated networks with invalide gateway IP address - Fixed and Test cases added --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script
Github user michaelandersen commented on the pull request: https://github.com/apache/cloudstack/pull/1156#issuecomment-162837936 Gotcha. We could add templates for the other hypervisors (vmware and hyperv) from http://dl.openvm.eu/cloudstack/macchinina/x86_64/ And remove the default_hypervisor variable and replace it for a dynamic template selection based on the nosetests hypervisor parameter. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Adapted HypervisorUtilsTest to no longer ...
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1187#discussion_r46934510 --- Diff: utils/src/test/java/org/apache/cloudstack/utils/hypervisor/HypervisorUtilsTest.java --- @@ -106,6 +104,8 @@ private void setupcheckVolumeFileForActivityFile(File file, long minSize) throws writer.write(chars); written += chars.length; } +long creationTime = System.currentTimeMillis(); --- End diff -- @nlivens How about moving this line one down just to be extremely sure? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9118 - As a Developer I want t...
GitHub user wilderrodrigues opened a pull request: https://github.com/apache/cloudstack/pull/1189 CLOUDSTACK-9118 - As a Developer I want the checkrouter.sh script to report the right information about RVR routers state This PR fixes the RVR routers state information retrieved by the Management Server via the ```checkrouter.sh``` script. In order to cover the changes, a new test has been added to the component/test_routers_network_ops.py test suite: test_03_RVR_Network_check_router_state You can merge this pull request into a Git repository by running: $ git pull https://github.com/ekholabs/cloudstack fix/4.6-rvr_routers_state-CLOUDSTACK-9118 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1189.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1189 commit f81a29351d2c20714db1220c32fee4cdff61ed3b Author: Wilder Rodrigues Date: 2015-12-07T18:18:20Z CLOUDSTACK-9118 - Improves the existing checkrouter.sh script commit 848ef78158b29749ac20f8d4fdf919b07e722af6 Author: Wilder Rodrigues Date: 2015-12-07T18:26:43Z CLOUDSTACK-9118 - Adds integration test to cover routers state. - Refactoring the existing tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9118 - As a Developer I want t...
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1189#issuecomment-162839426 Ping @remibergsma @bhaisaab @DaanHoogland @miguelaferreira @borisroman I'm currently running the other tests, but feel free to start testing now. * Result of the newly added test ``` Test redundant router internals ... === TestName: test_03_RVR_Network_check_router_state | Status : SUCCESS === ok -- Ran 5 tests in 736.443s OK (SKIP=4) /tmp//MarvinLogs/test_routers_network_ops_AXSXD3/results.txt (END) ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9086: ACS allows to create iso...
Github user kansal commented on the pull request: https://github.com/apache/cloudstack/pull/1188#issuecomment-162839268 cc @bhaisaab @DaanHoogland I closed the previous PR. Created this one and rebased with the master. Not sure why the tests were failing in the previous one. Maybe some mistakes in the merge conflicts resolving while rebasing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Adapted HypervisorUtilsTest to no longer ...
Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1187#discussion_r46935277 --- Diff: utils/src/test/java/org/apache/cloudstack/utils/hypervisor/HypervisorUtilsTest.java --- @@ -106,6 +104,8 @@ private void setupcheckVolumeFileForActivityFile(File file, long minSize) throws writer.write(chars); written += chars.length; } +long creationTime = System.currentTimeMillis(); --- End diff -- Not really, if you move it one line down, after writer.close(), the test could still give false positives because there could still be a hickup during writer.close() while the file has already been written. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: [GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script
Thanks @michaelandersen, I will take those templates and make the test generic. On Tue, Dec 8, 2015 at 3:35 PM, michaelandersen wrote: > Github user michaelandersen commented on the pull request: > > https://github.com/apache/cloudstack/pull/1156#issuecomment-162837936 > > Gotcha. We could add templates for the other hypervisors (vmware and > hyperv) from http://dl.openvm.eu/cloudstack/macchinina/x86_64/ > > And remove the default_hypervisor variable and replace it for a > dynamic template selection based on the nosetests hypervisor parameter. > > > --- > If your project is set up for it, you can reply to this email and have your > reply appear on GitHub as well. If your project does not have this feature > enabled and wishes so, or if the feature is enabled but not working, please > contact infrastructure at infrastruct...@apache.org or file a JIRA ticket > with INFRA. > --- >
[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-9113: skip vm with incon...
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1182#issuecomment-162850730
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
component/test_routers_iptables_default_policy.py \
component/test_routers_network_ops.py \
component/test_vpc_router_nics.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_network.py
```
Result:
```
Test iptables default INPUT/FORWARD policies on VPC router ... ===
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status :
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check the password file in the Router VM ... === TestName:
test_isolate_network_password_server | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... ===
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName:
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName:
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName:
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... ===
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80
| Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status :
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status :
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS
===
ok
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn
| Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : SUCCESS
===
ok
Test for port forwarding on source NAT ... === TestName:
test_01_port_fwd_on_src_nat | Status : SUCCESS ===
ok
Test for port forwarding on non source NAT ... === TestName:
test_02_port_fwd_on_non_src_nat | Status : SUCCESS ===
ok
Test for reboot router ... === TestName: test_reboot_router | Status :
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... ===
TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status :
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... ===
TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : SUCCESS
===
ok
Test for Router rules for network rules on acquired public IP ... ===
TestName: test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Status :
SUCCESS ===
ok
--
Ran 33 tests in 17748.128s
OK
```
And:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=false \
smoke/test_routers.py \
smoke/test_network_acl.py \
smoke/test_privategw_acl.py \
smoke/test_reset_vm_on_reboot.py \
smoke/test_vm_life_cycle.py \
smoke/test_vpc_vpn.py \
smoke/test_service_offerings.py \
component/test
[GitHub] cloudstack pull request: CLOUDSTACK-9121: Adding VmSnapshot valida...
GitHub user pritisarap12 opened a pull request: https://github.com/apache/cloudstack/pull/1190 CLOUDSTACK-9121: Adding VmSnapshot validation in testpath_revert_snap.py In testpath_revert_snap.py, there was no code to check if VM snapshot is created or not hence adding code for snapshot validation. You can merge this pull request into a Git repository by running: $ git pull https://github.com/pritisarap12/cloudstack CLOUDSTACK-9121-Adding-VmSnapshot-validation-in-testpath_revert_snap.py Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1190.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1190 commit 1cf44dee3a94dcac765aff9b2827e20cd05f971f Author: Priti Sarap Date: 2015-12-08T10:59:13Z CLOUDSTACK-9121: Adding VmSnapshot validation in testpath_revert_snap.py --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9121: Adding VmSnapshot valida...
Github user pritisarap12 commented on the pull request: https://github.com/apache/cloudstack/pull/1190#issuecomment-162851170 Testpath Result: Test revert snapshot on XenServer ... === TestName: test_01_check_revert_snapshot | Status : SUCCESS === ok -- Ran 1 test in 119.808s OK --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Adapted HypervisorUtilsTest to no longer ...
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1187#issuecomment-162851336
@nlivens Thanks for the patch. Just for the sake of it, run the integration
tests and they show OK (no surprise ;-) ):
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
component/test_routers_iptables_default_policy.py \
component/test_routers_network_ops.py \
component/test_vpc_router_nics.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_network.py
```
Result:
```
Test iptables default INPUT/FORWARD policies on VPC router ... ===
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status :
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check the password file in the Router VM ... === TestName:
test_isolate_network_password_server | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... ===
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName:
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName:
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName:
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... ===
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80
| Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status :
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status :
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS
===
ok
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn
| Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : SUCCESS
===
ok
Test for port forwarding on source NAT ... === TestName:
test_01_port_fwd_on_src_nat | Status : SUCCESS ===
ok
Test for port forwarding on non source NAT ... === TestName:
test_02_port_fwd_on_non_src_nat | Status : SUCCESS ===
ok
Test for reboot router ... === TestName: test_reboot_router | Status :
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... ===
TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status :
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... ===
TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : SUCCESS
===
ok
Test for Router rules for network rules on acquired public IP ... ===
TestName: test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Status :
SUCCESS ===
ok
--
Ran 33 tests in 17414.934s
OK
```
And:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=false \
smoke/test_routers.py \
smoke/test_network_acl.py \
smoke/test_privategw_acl.py \
smoke/test_reset_vm_on_reboot.py \
smoke/test_vm_life_cy
[GitHub] cloudstack pull request: CLOUDSTACK-9112: Deploy VM failing freque...
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1180#issuecomment-162851856
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
component/test_routers_iptables_default_policy.py \
component/test_routers_network_ops.py \
component/test_vpc_router_nics.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_network.py
```
Result:
```
Test iptables default INPUT/FORWARD policies on VPC router ... ===
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status :
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check the password file in the Router VM ... === TestName:
test_isolate_network_password_server | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... ===
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName:
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName:
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName:
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... ===
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80
| Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status :
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status :
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS
===
ok
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn
| Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : SUCCESS
===
ok
Test for port forwarding on source NAT ... === TestName:
test_01_port_fwd_on_src_nat | Status : SUCCESS ===
ok
Test for port forwarding on non source NAT ... === TestName:
test_02_port_fwd_on_non_src_nat | Status : SUCCESS ===
ok
Test for reboot router ... === TestName: test_reboot_router | Status :
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... ===
TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status :
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... ===
TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : SUCCESS
===
ok
Test for Router rules for network rules on acquired public IP ... ===
TestName: test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Status :
SUCCESS ===
ok
--
Ran 33 tests in 17222.324s
OK
```
And:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=false \
smoke/test_routers.py \
smoke/test_network_acl.py \
smoke/test_privategw_acl.py \
smoke/test_reset_vm_on_reboot.py \
smoke/test_vm_life_cycle.py \
smoke/test_vpc_vpn.py \
smoke/test_service_offerings.py \
component/test
[GitHub] cloudstack pull request: CLOUDSTACK-9118 - As a Developer I want t...
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1189#issuecomment-162860695 Ping @DaanHoogland @remibergsma @miguelaferreira @borisroman @bhaisaab @karuturi Since I changed the checkrouter.sh, also used by rVPCs, I will run some more tests. * Environment * Hardware required: TRUE * Management Server + MySQL on CentOS 7.1 * One KVM Host on CentOS 7.1 * Agent + Common RPMs built from 4.6.1 source * Tests executed ``` nosetests --with-marvin --marvin-config=/data/shared/marvin/mct-zone2-kvm2-ISOLATED.cfg -s -a tags=advanced,required_hardware=true component/test_routers_network_ops.py ``` * Results `` Test redundant router internals ... === TestName: test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS === ok Test redundant router internals ... === TestName: test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS === ok Test redundant router internals ... === TestName: test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS === ok Test redundant router internals ... === TestName: test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS === ok Test redundant router internals ... === TestName: test_03_RVR_Network_check_router_state | Status : SUCCESS === ok -- Ran 5 tests in 3068.947s OK /tmp//MarvinLogs/test_routers_network_ops_2ZGX9V/results.txt (END) `` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
BVT report for the week of 12/7
Here are the BVT results based on the latest master, going forward please expect to see an email on the BVTs beginning of every week: - XS Basic - 97.3% (4.6 RC passrate 96.9%) - XS Adv - 92.7% (4.6 RC passrate 93.4%) - KVM Basic - 98.6% (4.6 RC passrate - 98.6%) - KVM Adv - 96.4% (4.6 RC passrate - 96.3%) Following are failing on both XS Adv and KVM Adv setups and possible product defects * :setup //Issue: Failed to create firewall rule * :setup //Issue: Failed to apply port forwarding rule * integration.smoke.test_privategw_acl.TestPrivateGwACL.test_02_vpc_privategw_static_routes //Issue: Ping to outside world from VM should be successful * integration.smoke.test_privategw_acl.TestPrivateGwACL.test_03_rvpc_privategw_static_routes //Issue: Ping to outside world from VM should be successful Failed Test cases - XS Basic - - integration.smoke.test_vm_snapshots.TestSnapshots.test_01_test_vm_volume_snapshot // testcase issue - integration.smoke.test_iso.TestISO.test_07_list_default_iso //known testcase issue KVM Basic - * integration.smoke.test_iso.TestCreateIso.test_01_create_iso //Timeout waiting for response from storage host * integration.smoke.test_iso.TestISO.test_07_list_default_iso //known testcase issue XS Adv - * integration.smoke.test_quota.TestQuota.test_01_quota //New tests added, test setup issue * integration.smoke.test_quota.TestQuota.test_02_quota //New tests added, test setup issue * integration.smoke.test_quota.TestQuota.test_03_quota //New tests added, test setup issue * integration.smoke.test_quota.TestQuota.test_04_quota //New tests added, test setup issue * integration.smoke.test_quota.TestQuota.test_05_quota //New tests added, test setup issue * integration.smoke.test_quota.TestQuota.test_06_quota //New tests added, test setup issue * integration.smoke.test_quota.TestQuota.test_07_quota //New tests added, test setup issue * :setup //Issue: Failed to create firewall rule * :setup //Issue: Failed to apply port forwarding rule * integration.smoke.test_privategw_acl.TestPrivateGwACL.test_02_vpc_privategw_static_routes //Issue: Ping to outside world from VM should be successful * integration.smoke.test_privategw_acl.TestPrivateGwACL.test_03_rvpc_privategw_static_routes //Issue: Ping to outside world from VM should be successful * integration.smoke.test_vpc_vpn.TestVpcRemoteAccessVpn.test_vpc_remote_access_vpn * integration.smoke.test_vpc_vpn.TestVpcSite2SiteVpn.test_vpc_site2site_vpn //testcase issue * integration.smoke.test_internal_lb.TestInternalLb.test02_internallb_haproxy_stats_on_all_interfaces //testcase issue * integration.smoke.test_internal_lb.TestInternalLb.test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 // testcase issue * integration.smoke.test_vm_snapshots.TestSnapshots.test_01_test_vm_volume_snapshot // testcase issue * integration.smoke.test_iso.TestISO.test_07_list_default_iso // known testcase issue KVM Adv- * integration.smoke.test_quota.TestQuota.test_01_quota //New tests added, test setup issue * integration.smoke.test_quota.TestQuota.test_02_quota //New tests added, test setup issue * integration.smoke.test_quota.TestQuota.test_03_quota //New tests added, test setup issue * integration.smoke.test_quota.TestQuota.test_04_quota //New tests added, test setup issue * integration.smoke.test_quota.TestQuota.test_05_quota //New tests added, test setup issue * integration.smoke.test_quota.TestQuota.test_06_quota //New tests added, test setup issue * integration.smoke.test_quota.TestQuota.test_07_quota //New tests added, test setup issue * :setup //Testcase issue * integration.smoke.test_privategw_acl.TestPrivateGwACL.test_02_vpc_privategw_static_routes //Issue: Ping to outside world from VM should be successful * integration.smoke.test_privategw_acl.TestPrivateGwACL.test_03_rvpc_privategw_static_routes //Issue: Ping to outside world from VM should be successful * integration.smoke.test_iso.TestISO.test_07_list_default_iso //known testcase issue --end-
[GitHub] cloudstack pull request: CLOUDSTACK-9099: SecretKey is returned fr...
Github user kansal commented on the pull request: https://github.com/apache/cloudstack/pull/1152#issuecomment-162867278 @jburwell @DaanHoogland @kishankavala Have included some changes related to the UI. Now after generating the keys from UI, after ListUserCmd() api, listKeysCmd() will be called to fill the secret key as I have removed it from the response value of other API's. Also added a test in which a normal user tries to call the listKeysCmd() for the admin account and hence giving a permission denied exception. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9099: SecretKey is returned fr...
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1152#discussion_r46947711
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/user/ListKeysCmd.java ---
@@ -0,0 +1,74 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.cloudstack.api.command.admin.user;
+
+
+import com.cloud.user.Account;
+import com.cloud.user.User;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.response.RegisterResponse;
+import org.apache.cloudstack.api.response.UserResponse;
+
+import java.util.List;
+import java.util.logging.Logger;
+
+@APICommand(name = "listUserKeys",
+description = "This command allows the user to query the
seceret and API keys for the account",
+responseObject = RegisterResponse.class,
+requestHasSensitiveInfo = false,
+responseHasSensitiveInfo = true)
+
+public class ListKeysCmd extends BaseCmd{
+
+@Parameter(name= ApiConstants.ID, type = CommandType.UUID, entityType
= UserResponse.class, required = true, description = "ID of the user whose keys
are required")
+private Long id;
+
+public static final Logger s_logger =
Logger.getLogger(RegisterCmd.class.getName());
--- End diff --
how about using LOGGER as a name for this static final? would be more in
line with standards
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9099: SecretKey is returned fr...
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1152#discussion_r46947731
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/user/ListKeysCmd.java ---
@@ -0,0 +1,74 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.cloudstack.api.command.admin.user;
+
+
+import com.cloud.user.Account;
+import com.cloud.user.User;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.response.RegisterResponse;
+import org.apache.cloudstack.api.response.UserResponse;
+
+import java.util.List;
+import java.util.logging.Logger;
+
+@APICommand(name = "listUserKeys",
+description = "This command allows the user to query the
seceret and API keys for the account",
+responseObject = RegisterResponse.class,
+requestHasSensitiveInfo = false,
+responseHasSensitiveInfo = true)
+
+public class ListKeysCmd extends BaseCmd{
+
+@Parameter(name= ApiConstants.ID, type = CommandType.UUID, entityType
= UserResponse.class, required = true, description = "ID of the user whose keys
are required")
+private Long id;
+
+public static final Logger s_logger =
Logger.getLogger(RegisterCmd.class.getName());
+public static final String s_name = "listuserkeysresponse";
--- End diff --
same here
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9099: SecretKey is returned fr...
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1152#issuecomment-162869020 @kansal looks good, but for a change like this I would like a marvin test to prove it and guarantee it's continued functioning/functionality Do you see chance to add that? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Strongswan vpn feature
Github user remibergsma commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/872#discussion_r46961653 --- Diff: systemvm/patches/debian/vpn/etc/ipsec.d/l2tp.conf --- @@ -30,4 +35,5 @@ conn L2TP-PSK # -- # Change 'ignore' to 'add' to enable this configuration. # +rightsubnetwithin=10.1.2.0/8 --- End diff -- This is probably not going to work. Why is this hardcoded? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Changed UsageEventUtils to UsageEventEmit...
GitHub user nnesic opened a pull request: https://github.com/apache/cloudstack/pull/1191 Changed UsageEventUtils to UsageEventEmitter and made it injectable Refactored code to make the UsageEventEmitter injectable. Fixed unit tests where required, but otherwise no changes in the logic of event emitting. You can merge this pull request into a Git repository by running: $ git pull https://github.com/greenqloud/cloudstack pr/destatic-usage-event-utils Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1191.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1191 commit dafaa9441d2e3a56fbb18ba781c050f91c916fc8 Author: nnesic Date: 2015-11-26T16:02:44Z Changed UsageEventUtils to UsageEventEmitter and made it injectable --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9118 - As a Developer I want t...
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1189#issuecomment-162941648 Hi @wilderrodrigues, I tested it just now! Looking good! Ran against Ubuntu 14.04 KVM management/hypervisor. ``` Test redundant router internals ... === TestName: test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS === ok Test redundant router internals ... === TestName: test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS === ok Test redundant router internals ... === TestName: test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS === ok Test redundant router internals ... === TestName: test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS === ok Test redundant router internals ... === TestName: test_03_RVR_Network_check_router_state | Status : SUCCESS === ok -- Ran 5 tests in 2569.926s ``` LGTM :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8847: ListServiceOfferings is ...
Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/823#issuecomment-162947373 The functionality purely depends on the meaning of compatibility. Here is what I understood about the compatibility. For example, if our current compute offering is associated with tags (x,y) then the new compute offering should have tags atleast (x,y), then only it can have the same functionality as the current one. Suppose the new offering has the only tag(x), then it is missing the functionality associated with tag(y). One more example, Suppose we have three hosts H1,H2,H3. The tags associated with H1 is (x,y), H2 is only (y) and H3 is (x,y,z). Suppose our current compute offering has (x,y) as host tags. So the VM can be placed in H1 or H3 as both the tags are associated with these hosts but cannot be placed in H2 as tag (x) is missing. But according to the prior situation, it can list a compute offering which has host tag only (y), so the VM can be placed in H2 also. I think this is an issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9118 - As a Developer I want t...
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1189#issuecomment-162984674
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
component/test_routers_iptables_default_policy.py \
component/test_routers_network_ops.py \
component/test_vpc_router_nics.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_network.py
```
Result:
```
Test iptables default INPUT/FORWARD policies on VPC router ... ===
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status :
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check the password file in the Router VM ... === TestName:
test_isolate_network_password_server | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... ===
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName:
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName:
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName:
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... ===
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80
| Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status :
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status :
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS
===
ok
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn
| Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : SUCCESS
===
ok
Test for port forwarding on source NAT ... === TestName:
test_01_port_fwd_on_src_nat | Status : SUCCESS ===
ok
Test for port forwarding on non source NAT ... === TestName:
test_02_port_fwd_on_non_src_nat | Status : SUCCESS ===
ok
Test for reboot router ... === TestName: test_reboot_router | Status :
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... ===
TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status :
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... ===
TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : SUCCESS
===
ok
Test for Router rules for network rules on acquired public IP ... ===
TestName: test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Status :
SUCCESS ===
ok
--
Ran 33 tests in 17793.167s
OK
```
And:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=false \
smoke/test_routers.py \
smoke/test_network_acl.py \
smoke/test_privategw_acl.py \
smoke/test_reset_vm_on_reboot.py \
smoke/test_vm_life_cycle.py \
smoke/test_vpc_vpn.py \
smoke/test_service_offerings.py \
component/test
[GitHub] cloudstack pull request: CLOUDSTACK-9118 - As a Developer I want t...
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1189 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...
Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1094#issuecomment-162990802 @remibergsma my mistake, I meant to modify schema-460to470.sql and schema-461to470.sql but not setup/db/db/schema-410to420-cleanup.sql as I did. I'll push some other changes and also fix this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9112: Deploy VM failing freque...
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1180#issuecomment-162994057 @remibergsma It doesn't break things covered by the tests that were execute, which is fine. However, @harikrishna-patnala hasn't provided any support in terms of how to test it; if there is any integration test to help; or about the unit tests for the new methods he introduced. I'm not very keen to LGTM a PR without support from the author himself. Unless he comes back with some more details, I will hold a :-1: for this PR. Cheers, Wilder --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Lists admin, please unsubscribe/remove andrewlore...@gmx.com
Hi, Whoever is list admin, please remove andrewlore...@gmx.com from the user/dev MLs, his inbox has reached quota and it's generating bouncebacks. This has been going on for a while, at least a few weeks. Thanks! -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro
[GitHub] cloudstack pull request: Fix for CLOUDSTACK-8937 - XenServer migra...
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1037#issuecomment-162995054 Hi @atrbgithub Yes, the info clarifies feel things, but unfortunately I'm also busy and do not have time to write a test to cover it. I also have some refactoring/development to do and cannot be 100% allocated to write tests to run against other PRs. Since you mentioned in your comment that ```Everything appears to compile ok and tests pass``` I thought you were talking about existing integration tests. Unfortunately, unless someone tests this PR with the setup provided by @atrbgithub, I will have to hold a :-1: against it. Cheers, Wilder --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
40GB hard limit on template size
Hi Guys, Does anyone know why there is a 40GB hard limit on the template size? https://github.com/apache/cloudstack/blob/master/scripts/storage/secondary/createvolume.sh#L30 and https://github.com/apache/cloudstack/blob/master/scripts/storage/secondary/createtmplt.sh#L30 We had a customer who was trying to create a template which was > 40GB and we hit this. Not sure why it is there. Would love some insight. -Syed
[GitHub] cloudstack pull request: Strongswan vpn feature
Github user jayapalu commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/872#discussion_r47049123 --- Diff: systemvm/patches/debian/vpn/etc/ipsec.d/l2tp.conf --- @@ -30,4 +35,5 @@ conn L2TP-PSK # -- # Change 'ignore' to 'add' to enable this configuration. # +rightsubnetwithin=10.1.2.0/8 --- End diff -- Default is 10.1.2.0/8. In configure.py 'configure_l2tpIpsec' method will update its value. We have only ip range ex:10.1.2.2-10.1.2.8 we don't have the cidr in DB. In global setting we have option to configure only range not the cidr. We have to derive the cidr from the range and it may not be correct some times. If we hard code to /24 it may will be problem if the range crossing the /24. If we introduce the global setting to configure the cidr, it is mess for the backward compatibility. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9112: Deploy VM failing freque...
Github user harikrishna-patnala commented on the pull request: https://github.com/apache/cloudstack/pull/1180#issuecomment-163112385 Thank you for the feedback, I'll add the unit tests for the new methods and integration tests for the changes that I have made. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9122: future credit etries sho...
GitHub user agneya2001 opened a pull request: https://github.com/apache/cloudstack/pull/1192 CLOUDSTACK-9122: future credit etries should be incorporated when the⦠future credit etries should be incorporated when the balance is calculated 1. Some code is refactored so that unit tests (TODO in future) are more comprehensive 2. The fix is to incorporate the credit entries on line 228. https://issues.apache.org/jira/browse/CLOUDSTACK-9122 You can merge this pull request into a Git repository by running: $ git pull https://github.com/shapeblue/cloudstack master-9122 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1192.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1192 commit f6828268ccb6c2218650e9870d09843714dfd791 Author: Abhinandan Prateek Date: 2015-12-08T11:51:00Z CLOUDSTACK-9122: future credit etries should be incorporated when the balance is calculated --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: QUOTA: ENSURING THAT THE DATES DISPLAYED ...
GitHub user agneya2001 opened a pull request: https://github.com/apache/cloudstack/pull/1193 QUOTA: ENSURING THAT THE DATES DISPLAYED ARE AS PER USER EXPECTATIONS When querying db we use start of next day to query quota usage for today, but while displaying it to user we still need to show it as todays date. A regression due to feature review fixes is also made. You can merge this pull request into a Git repository by running: $ git pull https://github.com/shapeblue/cloudstack master-9126 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1193.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1193 commit 5243ec882dc078edcbf10d5f0f618f7d9d9f5592 Author: Abhinandan Prateek Date: 2015-12-08T04:29:06Z QUOTA: ENSURING THAT THE DATES DISPLAYED ARE AS PER USER EXPECTATIONS When querying db we use start of next day to query quota usage for today, but while displaying it to user we still need to show it as todays date --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9125: Brazilian translations
GitHub user agneya2001 opened a pull request: https://github.com/apache/cloudstack/pull/1194 CLOUDSTACK-9125: Brazilian translations The pull request contains brazilian translations for quota labels. You can merge this pull request into a Git repository by running: $ git pull https://github.com/shapeblue/cloudstack master-9125 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1194.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1194 commit 7859c6813c00af5de8c7f6e1e7416334ca0a049b Author: Abhinandan Prateek Date: 2015-12-08T06:10:00Z CLOUDSTACK-9125: Brazilian translations --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9120 - As a Developer I want t...
GitHub user wilderrodrigues opened a pull request: https://github.com/apache/cloudstack/pull/1195 CLOUDSTACK-9120 - As a Developer I want the new component tests to be moved into the smoke directory This PR only moves the tests I wrote form the ```component``` to the ```smoke``` directory. Given the nature of the tests, the should be moved. - Those tests are doing a lot more than component tests would do. They require hardware and a lot of resources from real hypervisors. I'm now running the five test files that were moved and will post results once they are done. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ekholabs/cloudstack refactor/smoke_tests-CLOUDSTACK-9120 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1195.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1195 commit fb92de52623f5a5a354cf78f5e91dafa3ee6f337 Author: Wilder Rodrigues Date: 2015-12-08T19:28:07Z CLOUDSTACK-9120 - Moves tests to the smoke directory - Those tests are doing a lot more than component tests would do. They require hardware and a lot of resources from real hypervisors. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9127 Missing PV-bootloader-arg...
GitHub user SudharmaJain opened a pull request:
https://github.com/apache/cloudstack/pull/1196
CLOUDSTACK-9127 Missing PV-bootloader-args for "SUSE Linux Enterpriseâ¦
⦠Server 10 SP2 and SP3"
ISSUE
STOP-START of SUSE Linux VMs fail, as PV-bootloader-args are missing during
the start command.
DESCRIPTION
--
Repro steps
1. Upload Suse ISO
2. Create a VM with this ISO, and install it.
3. Detach ISO from the VM.
4. Reboot the VM, : This will work fine, as the pv-bootloader-args are
not missing during reboot.
5.Stop the VM from CCP(VM will get destroyed in Xencenter)
6. Start the same VM from CCP , it will try to start but will fail.
Before Applying the fix
Before applying the starting the VM failed with following exception
com.cloud.utils.exception.CloudRuntimeException: Unable to start
VM(i-2-6-VM) on host(7cfd6388-b763-4c09-b3a3-9679db2904a3) due to Task failed!
Task record: uuid: 21a6799f-9523-7c0e-bb86-1de750a38d74
nameLabel: Async.VM.start_on
nameDescription:
allowedOperations: []
currentOperations: {}
created: Wed Dec 09 07:00:29 UTC 2015
finished: Wed Dec 09 07:00:31 UTC 2015
status: failure
residentOn: com.xensource.xenapi.Host@513d238c
progress: 1.0
type:
result:
errorInfo: [BOOTLOADER_FAILED,
OpaqueRef:0b10b6ac-837d-29af-da9d-6ef1e11a064a, Unable to find partition
containing kernel
]
otherConfig: {}
subtaskOf: com.xensource.xenapi.Task@aaf13f6f
subtasks: []
After Applying the fix
--
After applying the fix I am able to start the vm.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SudharmaJain/cloudstack cs-9127
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1196.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1196
commit fa81844812a26832e42b31e415de66277c59e3c5
Author: SudharmaJain
Date: 2015-12-09T06:23:51Z
CLOUDSTACK-9127 Missing PV-bootloader-args for "SUSE Linux Enterprise
Server 10 SP2 and SP3"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9094: Multiple threads are bei...
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/1140#issuecomment-163140058 @DaanHoogland the fix is simple. We do not need special /extra process for VPC routers. @bhaisaab this issue does not exist in 4.5, as @koushik-das mentioned, it is a regression bug in 4.6. LGTM this is almost same to commit e444a03, so we can merge it or cherry pick the old commit --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9094: Multiple threads are bei...
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/1140#issuecomment-163140236 sorry guys, just notice it is already merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9120 - As a Developer I want t...
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1195#issuecomment-163140684 fine by me. I will get soem time to add a PR with read.me files per directory indicating what type of test should go where. LGTM pending the outcome of the tests. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
