Re: Feature freeze ACS 4.7 next Monday

[sebgoa]

Hate to be a pain, but could you make sure to keep the exact list of Features 
merged, so that the Release notes are accurate ?

thanks

On Dec 4, 2015, at 11:58 PM, Remi Bergsma  wrote:

> Hi all,
> 
> Next Monday we'll feature freeze for our upcoming 4.7 release. We looked 
> through all open Pull Requests and below is our "whish list" to get in 4.7. 
> Feel free to nominate any other changes that should go in 4.7. No guarantees, 
> there is limited time so only PRs that we actively work on will make it.
> 
> The RC of 4.7.0 is scheduled for Monday Dec 14th so that we all will have a 
> nice Christmas present ;-)
> 
> Please help us review these PRs. Most have already had some review and when 
> we can reach 2xLGTM we can include them in 4.7 on time and make another great 
> release.
> 
> Happy testing and reviewing!
> 
> Regards,
> Daan & Remi
> 
> 
> Features & Fixes PRs:
> 
> Quota
> https://github.com/apache/cloudstack/pull/768
> 
> Logging enhancement
> https://github.com/apache/cloudstack/pull/1167
> 
> VMware diskcontrollers
> https://github.com/apache/cloudstack/pull/1132
> 
> ACS allows to create isolated networks with invalid gateway ip
> https://github.com/apache/cloudstack/pull/1125
> 
> Update nic IP address of stopped vm
> https://github.com/apache/cloudstack/pull/1086
> 
> Hypervisor changes to support UserData for Nuage VSP
> https://github.com/apache/cloudstack/pull/1142
> 
> Support shared networking in NiciraNVP Plugin
> https://github.com/apache/cloudstack/pull/1094
> 
> Strongswan vpn feature
> https://github.com/apache/cloudstack/pull/872
> 
> VM Snapshotting implementation for KVM
> https://github.com/apache/cloudstack/pull/977
> 
> Redundant VPC improvement
> (PR will follow over the weekend)
> 
> 
> UI PRs:
> 
> [UI] fix bug: Cannot delete SSH keypairs in projects
> https://github.com/apache/cloudstack/pull/1154
> 
> UI icon over VM snapshot to deploy user instance
> https://github.com/apache/cloudstack/pull/1150
> 
> Newly added project is not showing in the drop down until the browser is 
> refreshed
> https://github.com/apache/cloudstack/pull/1082

[GitHub] cloudstack pull request: CLOUDSTACK-8964: Ovm3HypervisorGuru handl...

[snuf]

Github user snuf commented on the pull request:

https://github.com/apache/cloudstack/pull/1177#issuecomment-162448978
  
Seems like we have the same problem in the XenServer code, as I stated 
earlier in another pull request somewhere out there, where this code originates 
from (XenServerGuru.java) . The place it's been done correctly is the 
VmwareGuru.java it seems, they actually check the hypervisor type, opposed to 
the XenServerGuru.java. So yes it's a fix, but it doesn't fix other places 
where the same logic has been applied in the past.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Quota

[agneya2001]

Github user agneya2001 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/768#discussion_r46796541
  
--- Diff: 
framework/quota/test/org/apache/cloudstack/quota/QuotaAlertManagerImplTest.java 
---
@@ -0,0 +1,205 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.quota;
+
+import com.cloud.domain.DomainVO;
+import com.cloud.domain.dao.DomainDao;
+import com.cloud.user.Account;
+import com.cloud.user.AccountVO;
+import com.cloud.user.UserVO;
+import com.cloud.user.dao.AccountDao;
+import com.cloud.user.dao.UserDao;
+import com.cloud.utils.db.TransactionLegacy;
+import junit.framework.TestCase;
+import org.apache.cloudstack.framework.config.dao.ConfigurationDao;
+import org.apache.cloudstack.quota.constant.QuotaConfig;
+import org.apache.cloudstack.quota.dao.QuotaAccountDao;
+import org.apache.cloudstack.quota.dao.QuotaEmailTemplatesDao;
+import org.apache.cloudstack.quota.dao.QuotaUsageDao;
+import org.apache.cloudstack.quota.vo.QuotaAccountVO;
+import org.apache.cloudstack.quota.vo.QuotaEmailTemplatesVO;
+import org.joda.time.DateTime;
+import org.junit.Before;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.mockito.Mock;
+import org.mockito.Mockito;
+import org.mockito.Spy;
+import org.mockito.runners.MockitoJUnitRunner;
+
+import javax.mail.MessagingException;
+import javax.naming.ConfigurationException;
+import java.io.UnsupportedEncodingException;
+import java.lang.reflect.Field;
+import java.math.BigDecimal;
+import java.util.ArrayList;
+import java.util.Date;
+import java.util.List;
+
+@RunWith(MockitoJUnitRunner.class)
+public class QuotaAlertManagerImplTest extends TestCase {
+
+@Mock
+AccountDao accountDao;
+@Mock
+QuotaAccountDao quotaAcc;
+@Mock
+UserDao userDao;
+@Mock
+DomainDao domainDao;
+@Mock
+QuotaEmailTemplatesDao quotaEmailTemplateDao;
+@Mock
+ConfigurationDao configDao;
+@Mock
+QuotaUsageDao quotaUsage;
+@Mock
+QuotaAlertManagerImpl.EmailQuotaAlert emailQuotaAlert;
+
+@Spy
+QuotaAlertManagerImpl quotaAlertManager = new QuotaAlertManagerImpl();
+
+private void injectMockToField(Object mock, String fieldName) throws 
NoSuchFieldException, IllegalAccessException {
+Field f = QuotaAlertManagerImpl.class.getDeclaredField(fieldName);
+f.setAccessible(true);
+f.set(quotaAlertManager, mock);
+}
+
+@Before
+public void setup() throws IllegalAccessException, 
NoSuchFieldException, ConfigurationException {
+// Dummy transaction stack setup
+TransactionLegacy.open("QuotaAlertManagerImplTest");
+
+injectMockToField(accountDao, "_accountDao");
+injectMockToField(quotaAcc, "_quotaAcc");
+injectMockToField(userDao, "_userDao");
+injectMockToField(domainDao, "_domainDao");
+injectMockToField(quotaEmailTemplateDao, "_quotaEmailTemplateDao");
+injectMockToField(configDao, "_configDao");
+injectMockToField(quotaUsage, "_quotaUsage");
+injectMockToField(emailQuotaAlert, "_emailQuotaAlert");
+}
+
+@Test
+public void testStartStop() {
+try {
+quotaAlertManager.start(); // expected to fail as pid is not 
available
+} catch (NumberFormatException ignored) {
+}
+assertTrue(quotaAlertManager.stop());
+}
+
+@Test
+public void testCheckAndSendQuotaAlertEmails() {
+AccountVO accountVO = new AccountVO();
+accountVO.setId(2L);
+accountVO.setDomainId(1L);
+accountVO.setType(Account.ACCOUNT_TYPE_NORMAL);
+
Mockito.when(accountDao.findById(Mockito.anyLong())).thenReturn(accountVO);
+
+QuotaAccountVO acc = new QuotaAccoun

[GitHub] cloudstack pull request: Quota

[agneya2001]

Github user agneya2001 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/768#discussion_r46796893
  
--- Diff: 
framework/quota/test/org/apache/cloudstack/quota/QuotaAlertManagerImplTest.java 
---
@@ -0,0 +1,205 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.quota;
+
+import com.cloud.domain.DomainVO;
+import com.cloud.domain.dao.DomainDao;
+import com.cloud.user.Account;
+import com.cloud.user.AccountVO;
+import com.cloud.user.UserVO;
+import com.cloud.user.dao.AccountDao;
+import com.cloud.user.dao.UserDao;
+import com.cloud.utils.db.TransactionLegacy;
+import junit.framework.TestCase;
+import org.apache.cloudstack.framework.config.dao.ConfigurationDao;
+import org.apache.cloudstack.quota.constant.QuotaConfig;
+import org.apache.cloudstack.quota.dao.QuotaAccountDao;
+import org.apache.cloudstack.quota.dao.QuotaEmailTemplatesDao;
+import org.apache.cloudstack.quota.dao.QuotaUsageDao;
+import org.apache.cloudstack.quota.vo.QuotaAccountVO;
+import org.apache.cloudstack.quota.vo.QuotaEmailTemplatesVO;
+import org.joda.time.DateTime;
+import org.junit.Before;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.mockito.Mock;
+import org.mockito.Mockito;
+import org.mockito.Spy;
+import org.mockito.runners.MockitoJUnitRunner;
+
+import javax.mail.MessagingException;
+import javax.naming.ConfigurationException;
+import java.io.UnsupportedEncodingException;
+import java.lang.reflect.Field;
+import java.math.BigDecimal;
+import java.util.ArrayList;
+import java.util.Date;
+import java.util.List;
+
+@RunWith(MockitoJUnitRunner.class)
+public class QuotaAlertManagerImplTest extends TestCase {
+
+@Mock
+AccountDao accountDao;
+@Mock
+QuotaAccountDao quotaAcc;
+@Mock
+UserDao userDao;
+@Mock
+DomainDao domainDao;
+@Mock
+QuotaEmailTemplatesDao quotaEmailTemplateDao;
+@Mock
+ConfigurationDao configDao;
+@Mock
+QuotaUsageDao quotaUsage;
+@Mock
+QuotaAlertManagerImpl.EmailQuotaAlert emailQuotaAlert;
+
+@Spy
+QuotaAlertManagerImpl quotaAlertManager = new QuotaAlertManagerImpl();
+
+private void injectMockToField(Object mock, String fieldName) throws 
NoSuchFieldException, IllegalAccessException {
+Field f = QuotaAlertManagerImpl.class.getDeclaredField(fieldName);
+f.setAccessible(true);
+f.set(quotaAlertManager, mock);
+}
+
+@Before
+public void setup() throws IllegalAccessException, 
NoSuchFieldException, ConfigurationException {
+// Dummy transaction stack setup
+TransactionLegacy.open("QuotaAlertManagerImplTest");
+
+injectMockToField(accountDao, "_accountDao");
+injectMockToField(quotaAcc, "_quotaAcc");
+injectMockToField(userDao, "_userDao");
+injectMockToField(domainDao, "_domainDao");
+injectMockToField(quotaEmailTemplateDao, "_quotaEmailTemplateDao");
+injectMockToField(configDao, "_configDao");
+injectMockToField(quotaUsage, "_quotaUsage");
+injectMockToField(emailQuotaAlert, "_emailQuotaAlert");
+}
+
+@Test
+public void testStartStop() {
+try {
+quotaAlertManager.start(); // expected to fail as pid is not 
available
+} catch (NumberFormatException ignored) {
+}
+assertTrue(quotaAlertManager.stop());
+}
+
+@Test
+public void testCheckAndSendQuotaAlertEmails() {
+AccountVO accountVO = new AccountVO();
+accountVO.setId(2L);
+accountVO.setDomainId(1L);
+accountVO.setType(Account.ACCOUNT_TYPE_NORMAL);
+
Mockito.when(accountDao.findById(Mockito.anyLong())).thenReturn(accountVO);
+
+QuotaAccountVO acc = new QuotaAccoun

[GitHub] cloudstack pull request: Quota

[agneya2001]

Github user agneya2001 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/768#discussion_r46796854
  
--- Diff: 
framework/quota/test/org/apache/cloudstack/quota/QuotaManagerImplTest.java ---
@@ -0,0 +1,203 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.quota;
+
+import com.cloud.usage.UsageVO;
+import com.cloud.usage.dao.UsageDao;
+import com.cloud.user.Account;
+import com.cloud.user.AccountVO;
+import com.cloud.user.dao.AccountDao;
+import com.cloud.utils.Pair;
+import com.cloud.utils.db.TransactionLegacy;
+import junit.framework.TestCase;
+import org.apache.cloudstack.framework.config.dao.ConfigurationDao;
+import org.apache.cloudstack.quota.dao.QuotaAccountDao;
+import org.apache.cloudstack.quota.dao.QuotaBalanceDao;
+import org.apache.cloudstack.quota.dao.QuotaTariffDao;
+import org.apache.cloudstack.quota.dao.QuotaUsageDao;
+import org.apache.cloudstack.quota.dao.ServiceOfferingDao;
+import org.apache.cloudstack.quota.vo.QuotaAccountVO;
+import org.apache.cloudstack.quota.vo.QuotaTariffVO;
+import org.apache.cloudstack.quota.vo.QuotaUsageVO;
+import org.apache.cloudstack.usage.UsageTypes;
+import org.junit.Before;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.mockito.Mock;
+import org.mockito.Mockito;
+import org.mockito.Spy;
+import org.mockito.runners.MockitoJUnitRunner;
+
+import javax.naming.ConfigurationException;
+import java.lang.reflect.Field;
+import java.math.BigDecimal;
+import java.util.ArrayList;
+import java.util.Date;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+
+@RunWith(MockitoJUnitRunner.class)
+public class QuotaManagerImplTest extends TestCase {
+
+@Mock
+private AccountDao accountDao;
+@Mock
+private QuotaAccountDao quotaAcc;
+@Mock
+private UsageDao usageDao;
+@Mock
+private QuotaTariffDao quotaTariffDao;
+@Mock
+private QuotaUsageDao quotaUsageDao;
+@Mock
+private ServiceOfferingDao serviceOfferingDao;
+@Mock
+private QuotaBalanceDao quotaBalanceDao;
+@Mock
+private ConfigurationDao configDao;
+
+@Spy
+QuotaManagerImpl quotaManager = new QuotaManagerImpl();
+
+private void injectMockToField(Object mock, String fieldName) throws 
NoSuchFieldException, IllegalAccessException {
+Field f = QuotaManagerImpl.class.getDeclaredField(fieldName);
+f.setAccessible(true);
+f.set(quotaManager, mock);
+}
+
+@Before
+public void setup() throws IllegalAccessException, 
NoSuchFieldException, ConfigurationException {
+// Dummy transaction stack setup
+TransactionLegacy.open("QuotaManagerImplTest");
+
+injectMockToField(accountDao, "_accountDao");
+injectMockToField(quotaAcc, "_quotaAcc");
+injectMockToField(usageDao, "_usageDao");
+injectMockToField(quotaTariffDao, "_quotaTariffDao");
+injectMockToField(quotaUsageDao, "_quotaUsageDao");
+injectMockToField(serviceOfferingDao, "_serviceOfferingDao");
+injectMockToField(quotaBalanceDao, "_quotaBalanceDao");
+injectMockToField(configDao, "_configDao");
+}
+
+@Test
+public void testStartStop() {
+try {
+quotaManager.start(); // expected to fail as pid is not 
available
+} catch (NumberFormatException ignored) {
+}
+assertTrue(quotaManager.stop());
+}
+
+@Test
+public void testConfig() throws ConfigurationException {
+
Mockito.when(configDao.getConfiguration(Mockito.anyMapOf(String.class, 
Object.class))).thenReturn(new HashMap());
+Map map = new HashMap<>();
+map.put("usage.stats.job.aggregation.range", "0");
+assertTrue(quotaManager.con

[GitHub] cloudstack pull request: CLOUDSTACK-8964: Ovm3HypervisorGuru handl...

[ustcweizhou]

Github user ustcweizhou commented on the pull request:

https://github.com/apache/cloudstack/pull/1177#issuecomment-162450640
  
@snuf 
The procedure getCommandHostDelegation are overrided in three hypervisor: 
XenserverGuru, VmwareGuru and Ovm3HypervisorGuru.

We should make sure these three files handle the corresponding hypervisor 
type (eg XenserverGuru only handle xenserver). This is why @anshulgangwar made 
in #1176  and I made in   this PR #1177, we added the check on 
srcData.getHypervisorTyp. We think the issue is fixed on Xenserver and Ovm3.
I checked the VmwareGuru, it handles only vmware hypervisor, so it looks 
good.

I tested creating a template from snapshot on KVM, the command CopyCommand 
is handled by ssvm, it works.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Feature freeze ACS 4.7 next Monday

[Daan Hoogland]

Rohit, Sebastien,

I think we do not need to hurry any issues. work on 4.8 will start in
January or february at the latest.

On Mon, Dec 7, 2015 at 8:55 AM, sebgoa  wrote:

> Hate to be a pain, but could you make sure to keep the exact list of
> Features merged, so that the Release notes are accurate ?
>
> thanks
>
> On Dec 4, 2015, at 11:58 PM, Remi Bergsma 
> wrote:
>
> > Hi all,
> >
> > Next Monday we'll feature freeze for our upcoming 4.7 release. We looked
> through all open Pull Requests and below is our "whish list" to get in 4.7.
> Feel free to nominate any other changes that should go in 4.7. No
> guarantees, there is limited time so only PRs that we actively work on will
> make it.
> >
> > The RC of 4.7.0 is scheduled for Monday Dec 14th so that we all will
> have a nice Christmas present ;-)
> >
> > Please help us review these PRs. Most have already had some review and
> when we can reach 2xLGTM we can include them in 4.7 on time and make
> another great release.
> >
> > Happy testing and reviewing!
> >
> > Regards,
> > Daan & Remi
> >
> >
> > Features & Fixes PRs:
> >
> > Quota
> > https://github.com/apache/cloudstack/pull/768
> >
> > Logging enhancement
> > https://github.com/apache/cloudstack/pull/1167
> >
> > VMware diskcontrollers
> > https://github.com/apache/cloudstack/pull/1132
> >
> > ACS allows to create isolated networks with invalid gateway ip
> > https://github.com/apache/cloudstack/pull/1125
> >
> > Update nic IP address of stopped vm
> > https://github.com/apache/cloudstack/pull/1086
> >
> > Hypervisor changes to support UserData for Nuage VSP
> > https://github.com/apache/cloudstack/pull/1142
> >
> > Support shared networking in NiciraNVP Plugin
> > https://github.com/apache/cloudstack/pull/1094
> >
> > Strongswan vpn feature
> > https://github.com/apache/cloudstack/pull/872
> >
> > VM Snapshotting implementation for KVM
> > https://github.com/apache/cloudstack/pull/977
> >
> > Redundant VPC improvement
> > (PR will follow over the weekend)
> >
> >
> > UI PRs:
> >
> > [UI] fix bug: Cannot delete SSH keypairs in projects
> > https://github.com/apache/cloudstack/pull/1154
> >
> > UI icon over VM snapshot to deploy user instance
> > https://github.com/apache/cloudstack/pull/1150
> >
> > Newly added project is not showing in the drop down until the browser is
> refreshed
> > https://github.com/apache/cloudstack/pull/1082
>
>


-- 
Daan

[GitHub] cloudstack pull request: Quota

[bhaisaab]

Github user bhaisaab commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/768#discussion_r46797933
  
--- Diff: 
framework/quota/test/org/apache/cloudstack/quota/QuotaAlertManagerImplTest.java 
---
@@ -0,0 +1,205 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.quota;
+
+import com.cloud.domain.DomainVO;
+import com.cloud.domain.dao.DomainDao;
+import com.cloud.user.Account;
+import com.cloud.user.AccountVO;
+import com.cloud.user.UserVO;
+import com.cloud.user.dao.AccountDao;
+import com.cloud.user.dao.UserDao;
+import com.cloud.utils.db.TransactionLegacy;
+import junit.framework.TestCase;
+import org.apache.cloudstack.framework.config.dao.ConfigurationDao;
+import org.apache.cloudstack.quota.constant.QuotaConfig;
+import org.apache.cloudstack.quota.dao.QuotaAccountDao;
+import org.apache.cloudstack.quota.dao.QuotaEmailTemplatesDao;
+import org.apache.cloudstack.quota.dao.QuotaUsageDao;
+import org.apache.cloudstack.quota.vo.QuotaAccountVO;
+import org.apache.cloudstack.quota.vo.QuotaEmailTemplatesVO;
+import org.joda.time.DateTime;
+import org.junit.Before;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.mockito.Mock;
+import org.mockito.Mockito;
+import org.mockito.Spy;
+import org.mockito.runners.MockitoJUnitRunner;
+
+import javax.mail.MessagingException;
+import javax.naming.ConfigurationException;
+import java.io.UnsupportedEncodingException;
+import java.lang.reflect.Field;
+import java.math.BigDecimal;
+import java.util.ArrayList;
+import java.util.Date;
+import java.util.List;
+
+@RunWith(MockitoJUnitRunner.class)
+public class QuotaAlertManagerImplTest extends TestCase {
+
+@Mock
+AccountDao accountDao;
+@Mock
+QuotaAccountDao quotaAcc;
+@Mock
+UserDao userDao;
+@Mock
+DomainDao domainDao;
+@Mock
+QuotaEmailTemplatesDao quotaEmailTemplateDao;
+@Mock
+ConfigurationDao configDao;
+@Mock
+QuotaUsageDao quotaUsage;
+@Mock
+QuotaAlertManagerImpl.EmailQuotaAlert emailQuotaAlert;
+
+@Spy
+QuotaAlertManagerImpl quotaAlertManager = new QuotaAlertManagerImpl();
+
+private void injectMockToField(Object mock, String fieldName) throws 
NoSuchFieldException, IllegalAccessException {
+Field f = QuotaAlertManagerImpl.class.getDeclaredField(fieldName);
+f.setAccessible(true);
+f.set(quotaAlertManager, mock);
+}
+
+@Before
+public void setup() throws IllegalAccessException, 
NoSuchFieldException, ConfigurationException {
+// Dummy transaction stack setup
+TransactionLegacy.open("QuotaAlertManagerImplTest");
+
+injectMockToField(accountDao, "_accountDao");
+injectMockToField(quotaAcc, "_quotaAcc");
+injectMockToField(userDao, "_userDao");
+injectMockToField(domainDao, "_domainDao");
+injectMockToField(quotaEmailTemplateDao, "_quotaEmailTemplateDao");
+injectMockToField(configDao, "_configDao");
+injectMockToField(quotaUsage, "_quotaUsage");
+injectMockToField(emailQuotaAlert, "_emailQuotaAlert");
+}
+
+@Test
+public void testStartStop() {
+try {
+quotaAlertManager.start(); // expected to fail as pid is not 
available
+} catch (NumberFormatException ignored) {
+}
+assertTrue(quotaAlertManager.stop());
+}
+
+@Test
+public void testCheckAndSendQuotaAlertEmails() {
+AccountVO accountVO = new AccountVO();
+accountVO.setId(2L);
+accountVO.setDomainId(1L);
+accountVO.setType(Account.ACCOUNT_TYPE_NORMAL);
+
Mockito.when(accountDao.findById(Mockito.anyLong())).thenReturn(accountVO);
+
+QuotaAccountVO acc = new QuotaAccountV

[GitHub] cloudstack pull request: CLOUDSTACK-8858: listVolumes API fails fo...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/830#issuecomment-162453199
  
Though I would like to see how this situation is reproduced, the code is 
fine and sensible.

LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Quota

[bhaisaab]

Github user bhaisaab commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/768#discussion_r46797960
  
--- Diff: 
framework/quota/test/org/apache/cloudstack/quota/QuotaManagerImplTest.java ---
@@ -0,0 +1,203 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.quota;
+
+import com.cloud.usage.UsageVO;
+import com.cloud.usage.dao.UsageDao;
+import com.cloud.user.Account;
+import com.cloud.user.AccountVO;
+import com.cloud.user.dao.AccountDao;
+import com.cloud.utils.Pair;
+import com.cloud.utils.db.TransactionLegacy;
+import junit.framework.TestCase;
+import org.apache.cloudstack.framework.config.dao.ConfigurationDao;
+import org.apache.cloudstack.quota.dao.QuotaAccountDao;
+import org.apache.cloudstack.quota.dao.QuotaBalanceDao;
+import org.apache.cloudstack.quota.dao.QuotaTariffDao;
+import org.apache.cloudstack.quota.dao.QuotaUsageDao;
+import org.apache.cloudstack.quota.dao.ServiceOfferingDao;
+import org.apache.cloudstack.quota.vo.QuotaAccountVO;
+import org.apache.cloudstack.quota.vo.QuotaTariffVO;
+import org.apache.cloudstack.quota.vo.QuotaUsageVO;
+import org.apache.cloudstack.usage.UsageTypes;
+import org.junit.Before;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.mockito.Mock;
+import org.mockito.Mockito;
+import org.mockito.Spy;
+import org.mockito.runners.MockitoJUnitRunner;
+
+import javax.naming.ConfigurationException;
+import java.lang.reflect.Field;
+import java.math.BigDecimal;
+import java.util.ArrayList;
+import java.util.Date;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+
+@RunWith(MockitoJUnitRunner.class)
+public class QuotaManagerImplTest extends TestCase {
+
+@Mock
+private AccountDao accountDao;
+@Mock
+private QuotaAccountDao quotaAcc;
+@Mock
+private UsageDao usageDao;
+@Mock
+private QuotaTariffDao quotaTariffDao;
+@Mock
+private QuotaUsageDao quotaUsageDao;
+@Mock
+private ServiceOfferingDao serviceOfferingDao;
+@Mock
+private QuotaBalanceDao quotaBalanceDao;
+@Mock
+private ConfigurationDao configDao;
+
+@Spy
+QuotaManagerImpl quotaManager = new QuotaManagerImpl();
+
+private void injectMockToField(Object mock, String fieldName) throws 
NoSuchFieldException, IllegalAccessException {
+Field f = QuotaManagerImpl.class.getDeclaredField(fieldName);
+f.setAccessible(true);
+f.set(quotaManager, mock);
+}
+
+@Before
+public void setup() throws IllegalAccessException, 
NoSuchFieldException, ConfigurationException {
+// Dummy transaction stack setup
+TransactionLegacy.open("QuotaManagerImplTest");
+
+injectMockToField(accountDao, "_accountDao");
+injectMockToField(quotaAcc, "_quotaAcc");
+injectMockToField(usageDao, "_usageDao");
+injectMockToField(quotaTariffDao, "_quotaTariffDao");
+injectMockToField(quotaUsageDao, "_quotaUsageDao");
+injectMockToField(serviceOfferingDao, "_serviceOfferingDao");
+injectMockToField(quotaBalanceDao, "_quotaBalanceDao");
+injectMockToField(configDao, "_configDao");
+}
+
+@Test
+public void testStartStop() {
+try {
+quotaManager.start(); // expected to fail as pid is not 
available
+} catch (NumberFormatException ignored) {
+}
+assertTrue(quotaManager.stop());
+}
+
+@Test
+public void testConfig() throws ConfigurationException {
+
Mockito.when(configDao.getConfiguration(Mockito.anyMapOf(String.class, 
Object.class))).thenReturn(new HashMap());
+Map map = new HashMap<>();
+map.put("usage.stats.job.aggregation.range", "0");
+assertTrue(quotaManager.confi

[GitHub] cloudstack pull request: CLOUDSTACK-8847: ListServiceOfferings is ...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/823#issuecomment-162454833
  
The code looks good but I am wondering about the functionality. The prior 
situation was that the new offering should have a subset of the old one. Now it 
has to have a superset. Why not an exact match? What are scenarios and what 
about users relying on the old behaviour?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Feature freeze ACS 4.7 next Monday

[sebgoa]

On Dec 7, 2015, at 9:56 AM, Daan Hoogland  wrote:

> Rohit, Sebastien,
> 
> I think we do not need to hurry any issues. work on 4.8 will start in
> January or february at the latest.


I don't want to hurry anything, I want to be able to have release notes that 
describe *all* the features added.

Check the 4.6 release notes, I am sure we did more than this, but since dev 
more often than not don't care much about the RN, the features are not 
publicized.



> 
> On Mon, Dec 7, 2015 at 8:55 AM, sebgoa  wrote:
> 
>> Hate to be a pain, but could you make sure to keep the exact list of
>> Features merged, so that the Release notes are accurate ?
>> 
>> thanks
>> 
>> On Dec 4, 2015, at 11:58 PM, Remi Bergsma 
>> wrote:
>> 
>>> Hi all,
>>> 
>>> Next Monday we'll feature freeze for our upcoming 4.7 release. We looked
>> through all open Pull Requests and below is our "whish list" to get in 4.7.
>> Feel free to nominate any other changes that should go in 4.7. No
>> guarantees, there is limited time so only PRs that we actively work on will
>> make it.
>>> 
>>> The RC of 4.7.0 is scheduled for Monday Dec 14th so that we all will
>> have a nice Christmas present ;-)
>>> 
>>> Please help us review these PRs. Most have already had some review and
>> when we can reach 2xLGTM we can include them in 4.7 on time and make
>> another great release.
>>> 
>>> Happy testing and reviewing!
>>> 
>>> Regards,
>>> Daan & Remi
>>> 
>>> 
>>> Features & Fixes PRs:
>>> 
>>> Quota
>>> https://github.com/apache/cloudstack/pull/768
>>> 
>>> Logging enhancement
>>> https://github.com/apache/cloudstack/pull/1167
>>> 
>>> VMware diskcontrollers
>>> https://github.com/apache/cloudstack/pull/1132
>>> 
>>> ACS allows to create isolated networks with invalid gateway ip
>>> https://github.com/apache/cloudstack/pull/1125
>>> 
>>> Update nic IP address of stopped vm
>>> https://github.com/apache/cloudstack/pull/1086
>>> 
>>> Hypervisor changes to support UserData for Nuage VSP
>>> https://github.com/apache/cloudstack/pull/1142
>>> 
>>> Support shared networking in NiciraNVP Plugin
>>> https://github.com/apache/cloudstack/pull/1094
>>> 
>>> Strongswan vpn feature
>>> https://github.com/apache/cloudstack/pull/872
>>> 
>>> VM Snapshotting implementation for KVM
>>> https://github.com/apache/cloudstack/pull/977
>>> 
>>> Redundant VPC improvement
>>> (PR will follow over the weekend)
>>> 
>>> 
>>> UI PRs:
>>> 
>>> [UI] fix bug: Cannot delete SSH keypairs in projects
>>> https://github.com/apache/cloudstack/pull/1154
>>> 
>>> UI icon over VM snapshot to deploy user instance
>>> https://github.com/apache/cloudstack/pull/1150
>>> 
>>> Newly added project is not showing in the drop down until the browser is
>> refreshed
>>> https://github.com/apache/cloudstack/pull/1082
>> 
>> 
> 
> 
> -- 
> Daan

[GitHub] cloudstack pull request: CLOUDSTACK-8841: Storage XenMotion from X...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/815#issuecomment-162455918
  
Does what it says but probably more. Do we not mind any other version? 
@priyankparihar can you show how ACS doesn't allow invalid migrations, "Storage 
XenMotion( because inconsistent(version) Hypervisor Hosts will not be listed 
for migration in UI)."?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9106 - As a Developer I want t...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/1179#issuecomment-162460207
  
@remibergsma @DaanHoogland 

I'm closing this PR and will create a new one against 4.6.

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9106 - As a Developer I want t...

[wilderrodrigues]

Github user wilderrodrigues closed the pull request at:

https://github.com/apache/cloudstack/pull/1179


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-www pull request: developer page: fixed some repo links...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack-www/pull/21


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9095 : Hypervisor changes to s...

[nlivens]

Github user nlivens commented on the pull request:

https://github.com/apache/cloudstack/pull/1142#issuecomment-162462731
  
@jburwell, thanks for the review! I've handled your comments. Thanks 
@bhaisaab, would be great if we can still get this in 4.7


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9095 : Hypervisor changes to s...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1142#issuecomment-162464119
  
@nlivens cool, LGTM. Will merge on 4.6 once the build checks complete.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9095 : Hypervisor changes to s...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1142#issuecomment-162464159
  
s/4.6/master


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9094: Multiple threads are bei...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1140#issuecomment-162464615
  
Guys, this got merged on only code review. No tests are described showing 
the old and new behaviours. No unit tests are added. No regression tests are 
added. It is like this fix is not important.

My intuition says that if the VpcVirtualNetworkApplianceManager.start() is 
called then VirtualNetworkApplianceManager.start() should not have been and the 
real bug is not in this code at all.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Strongswan vpn feature

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/872#issuecomment-162464916
  
@terbolous your real question is: Can we get this in 4.6/4.7? right? I 
sugest you start a discuss thread on dev@ if you feel it should.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9094: Multiple threads are bei...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1140#issuecomment-162465934
  
@DaanHoogland let's revert, and ask @harikrishna-patnala to add more tests?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Strongswan vpn feature

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/872#issuecomment-162466163
  
@jayapalu I see some new commits. Did you change anything yet? Should we 
start testing?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Strongswan vpn feature

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/872#issuecomment-162466433
  
@terbolous @DaanHoogland This seems like a bug fix, but since it needs a 
new systemvm template there is no way we will add this to 4.6. For the same 
reason, I want to have this in today, so we can test the proper working of the 
systemvm template. Otherwise it will bring too much unstability close for 
release. Let's try to get this in today!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Strongswan vpn feature

[terbolous]

Github user terbolous commented on the pull request:

https://github.com/apache/cloudstack/pull/872#issuecomment-162467255
  
@DaanHoogland: yes, we're unable to use 4.6 due to the bug mentioned. now, 
the original issue may be fixed in 4.6 with openswan later, but i would much 
rather see this PR being included in 4.7 and focus on that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9094: Multiple threads are bei...

[koushik-das]

Github user koushik-das commented on the pull request:

https://github.com/apache/cloudstack/pull/1140#issuecomment-162468306
  
Actually I was looking at the history and this is what I found. This was 
originally fixed with commit

commit e444a03819ccf72f61cb04e8428d20cc65b145e1
Author: Wei Zhou 
Date:   Thu Nov 14 16:51:28 2013 +0100

remove duplicated scheduled tasks from 
VpcVirtualNetworkApplianceManagerImpl


Then was removed with commit

commit a5d6f90f666798e7575c6b7d3af5b3024af8768e
Author: wilderrodrigues 
Date:   Mon Jan 26 17:33:50 2015 +0100

Implementing redundant router arguments to add redundant_state
Implementing the arguments on the python side


And then fixed again with this PR. Not sure why it got removed at the first 
place.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9094: Multiple threads are bei...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1140#issuecomment-162469279
  
@koushik-das good find, that means we also need to fix this for 4.6. We 
would still need a round of tests just in case.

@harikrishna-patnala can you open a PR against 4.6 branch (and 4.5 branch 
if needed). Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Strongswan vpn feature

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/872#issuecomment-162469649
  
@jayapalu looks like you're still working on this, making progress. Please 
ping us when you want us to start some testing today (hopefully before EOD 
12PM/CET). Please also squash the commits, or split them logically as suitable.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9086: ACS allows to create iso...

[kansal]

Github user kansal commented on the pull request:

https://github.com/apache/cloudstack/pull/1125#issuecomment-162471051
  
cc @bhaisaab @DaanHoogland . Added test cases and made some minor changes 
to the function. Please have a look.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9094: Multiple threads are bei...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1140#issuecomment-162472783
  
Thanks for picking this up, guys.

I still think there is calling code that should not be allowed to call 
start twice. It should skip the VirtualNetworkApplianceManager.start() in case 
we are dealing with a VPC.

More important this has been allowed to become regression because it was 
not put into tests.
/me is looking for an :i told you so: emoticon.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8858: listVolumes API fails fo...

[ustcweizhou]

Github user ustcweizhou commented on the pull request:

https://github.com/apache/cloudstack/pull/830#issuecomment-162473175
  
I have the same concern with Daan. How to reproduce this issue ?
Check my env

mysql> select * from volumes where volume_type is null or provisioning_type 
is null or state is null;
Empty set (0.00 sec)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9086: ACS allows to create iso...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1125#issuecomment-162474888
  
LGTM
I will run a test build on this
also github reports conflicts on this branch, did you fork this of master? 
and when? It may need a rebase to merge with adjacent changes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-5822: keep user-added sshkeys ...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1044#issuecomment-162476357
  
regression tests executed:

[1044.network.results.txt](https://github.com/apache/cloudstack/files/53778/1044.network.results.txt)

[1044.vpc.results.txt](https://github.com/apache/cloudstack/files/53779/1044.vpc.results.txt)
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9086: ACS allows to create iso...

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1125#discussion_r46805977
  
--- Diff: utils/src/main/java/com/cloud/utils/net/NetUtils.java ---
@@ -1523,7 +1524,15 @@ public static boolean isIpWithtInCidrRange(final 
String ipAddress, final String
 
 final boolean isInRange = 
subnetUtils.getInfo().isInRange(ipAddress);
 
-return isInRange;
+return !isInRange;
--- End diff --

why did you reverse this return value @kansal ? I missed it in the first 
itteration


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9086: ACS allows to create iso...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1125#issuecomment-162480371
  
Not sure if it is related but

```
Running com.cloud.utils.net.NetUtilsTest
2015-12-07 11:33:08,471 INFO  [utils.net.NetUtils] (main:) Invalid value of 
cidr 10.3.6.5/50
2015-12-07 11:33:08,480 INFO  [utils.net.NetUtilsTest] (main:) IP is 
1234:5678::1
2015-12-07 11:33:08,480 INFO  [utils.net.NetUtilsTest] (main:) IP is 
1234:5678::2
2015-12-07 11:33:08,483 INFO  [utils.net.NetUtilsTest] (main:) IP is 
1234:5678::1
2015-12-07 11:33:08,488 INFO  [utils.net.NetUtilsTest] (main:) IP is 
1234:5678::1
2015-12-07 11:33:08,490 INFO  [utils.net.NetUtilsTest] (main:) IP is 
1234:5678::1
2015-12-07 11:33:08,492 INFO  [utils.net.NetUtilsTest] (main:) IP is 
1234:5678::99d6:578:c6d0:4d1e
2015-12-07 11:33:08,497 INFO  [utils.net.NetUtilsTest] (main:) IP is 
1234:5678::c2ad:5357:a636:5465
2015-12-07 11:33:08,500 INFO  [utils.net.NetUtilsTest] (main:) IP is 
1234:5678::f54c:4cd1:fafc:6d08
2015-12-07 11:33:08,509 INFO  [utils.net.NetUtilsTest] (main:) IP is 
1234:5678::54d1:5897:eba:aced
2015-12-07 11:33:08,511 INFO  [utils.net.NetUtilsTest] (main:) IP is 
1234:5678::a924:8a89:5af3:2039
2015-12-07 11:33:08,512 INFO  [utils.net.NetUtilsTest] (main:) IP is 
1234:5678::1442:6ab4:8a7f:1495
2015-12-07 11:33:08,518 INFO  [utils.net.NetUtilsTest] (main:) IP is 
1234:5678::e319:8c5f:b31c:eda1
2015-12-07 11:33:08,520 INFO  [utils.net.NetUtilsTest] (main:) IP is 
1234:5678::e380:62c1:5705:769f
2015-12-07 11:33:08,521 INFO  [utils.net.NetUtilsTest] (main:) IP is 
1234:5678::a764:8dd3:1f33:bc29
2015-12-07 11:33:08,522 INFO  [utils.net.NetUtilsTest] (main:) IP is 
1234:5678::9b2d:3bd9:7c1c:3df1
2015-12-07 11:33:08,564 ERROR [utils.net.NetUtils] (main:) Failed to 
convert a string to an IPv6 address
java.lang.IllegalArgumentException: can not parse []
at 
com.googlecode.ipv6.IPv6Address.tryParseStringArrayIntoLongArray(IPv6Address.java:94)
at com.googlecode.ipv6.IPv6Address.fromString(IPv6Address.java:80)
at com.cloud.utils.net.NetUtils.countIp6InRange(NetUtils.java:1317)
at 
com.cloud.utils.net.NetUtilsTest.testCountIp6InRangeWithNullStart(NetUtilsTest.java:152)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:497)
at 
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
at 
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at 
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
at 
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:283)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:173)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:128)
at 
org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:203)
at 
org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:155)
at 
org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103)
Tests run: 40, Failures: 3, Errors: 0, Skipped: 0, Time elapsed: 0.143 sec 
<<< FAILURE! - in com.cloud.utils.net.NetUtilsTest
test31BitPrefixEnd(com.cloud.utils.net.NetUtilsTest)  Time elapsed: 0.019 
sec  <<< FAILURE!
java.lang.AssertionError: Check if the 
subnetUtils.setInclusiveHostCount(true) has been called.
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.assertTrue(Assert.java:41)
at 
com.cloud.utils.net.NetUtilsTest.test31BitPrefixEnd(NetUtilsTest.java:362)

test31BitPrefixFail(com.cloud.utils.net.NetUtilsTest)  

[GitHub] cloudstack pull request: CLOUDSTACK-9069: Newly added project is n...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1082#issuecomment-162481574
  
@nitin-maharana How do I test this? I tried adding a project but the page 
keeps loading forever. Which dropdown should I look at?

![screen shot 2015-12-07 at 11 50 
52](https://cloud.githubusercontent.com/assets/1630096/11625159/f87cd49a-9cd8-11e5-8842-bfbe55acb2b3.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9095 : Hypervisor changes to s...

[fmaximus]

Github user fmaximus commented on the pull request:

https://github.com/apache/cloudstack/pull/1142#issuecomment-162483085
  
Are we still taking Travis into account? It has a unit test failure in 
HypervisorUtilTest, which also failed in other builds on Travis. This test 
seems to fail randomly. I've also seen that the other Travis threads, which 
were successful, in fact didn't do anything as thay failed to find nosetests.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Feature freeze ACS 4.7 next Monday

[Remi Bergsma]

Hi Seb,

Now that we merge everything and have a smaller scope, it should be easier to 
get the list of pull requests that got in since 4.6.

Quick attempt:

git log --pretty=oneline --abbrev-commit upstream/4.6..master | grep Merge | 
grep -v release | grep -v 4\.6 | awk {'print $5'} | sed s/\#//g | sort -n

801
834
840
841
850
929
935
937
942
943
944
1007
1013
1018
1019
1021
1035
1038
1049
1051
1057
1065
1068
1069
1071
1083
1084
1086
1092
1100
1102
1107
1108
1110
1118
1122
1128
1129
1137
1139
1140
1143
1167
1172
1173

If we make a script that gets this output and queries Github, we can get a list 
of the PR titles. Then we need to make sure those titles are any good ;-)


Regards,
Remi




On 07/12/15 10:13, "sebgoa"  wrote:

>
>On Dec 7, 2015, at 9:56 AM, Daan Hoogland  wrote:
>
>> Rohit, Sebastien,
>> 
>> I think we do not need to hurry any issues. work on 4.8 will start in
>> January or february at the latest.
>
>
>I don't want to hurry anything, I want to be able to have release notes that 
>describe *all* the features added.
>
>Check the 4.6 release notes, I am sure we did more than this, but since dev 
>more often than not don't care much about the RN, the features are not 
>publicized.
>
>
>
>> 
>> On Mon, Dec 7, 2015 at 8:55 AM, sebgoa  wrote:
>> 
>>> Hate to be a pain, but could you make sure to keep the exact list of
>>> Features merged, so that the Release notes are accurate ?
>>> 
>>> thanks
>>> 
>>> On Dec 4, 2015, at 11:58 PM, Remi Bergsma 
>>> wrote:
>>> 
 Hi all,
 
 Next Monday we'll feature freeze for our upcoming 4.7 release. We looked
>>> through all open Pull Requests and below is our "whish list" to get in 4.7.
>>> Feel free to nominate any other changes that should go in 4.7. No
>>> guarantees, there is limited time so only PRs that we actively work on will
>>> make it.
 
 The RC of 4.7.0 is scheduled for Monday Dec 14th so that we all will
>>> have a nice Christmas present ;-)
 
 Please help us review these PRs. Most have already had some review and
>>> when we can reach 2xLGTM we can include them in 4.7 on time and make
>>> another great release.
 
 Happy testing and reviewing!
 
 Regards,
 Daan & Remi
 
 
 Features & Fixes PRs:
 
 Quota
 https://github.com/apache/cloudstack/pull/768
 
 Logging enhancement
 https://github.com/apache/cloudstack/pull/1167
 
 VMware diskcontrollers
 https://github.com/apache/cloudstack/pull/1132
 
 ACS allows to create isolated networks with invalid gateway ip
 https://github.com/apache/cloudstack/pull/1125
 
 Update nic IP address of stopped vm
 https://github.com/apache/cloudstack/pull/1086
 
 Hypervisor changes to support UserData for Nuage VSP
 https://github.com/apache/cloudstack/pull/1142
 
 Support shared networking in NiciraNVP Plugin
 https://github.com/apache/cloudstack/pull/1094
 
 Strongswan vpn feature
 https://github.com/apache/cloudstack/pull/872
 
 VM Snapshotting implementation for KVM
 https://github.com/apache/cloudstack/pull/977
 
 Redundant VPC improvement
 (PR will follow over the weekend)
 
 
 UI PRs:
 
 [UI] fix bug: Cannot delete SSH keypairs in projects
 https://github.com/apache/cloudstack/pull/1154
 
 UI icon over VM snapshot to deploy user instance
 https://github.com/apache/cloudstack/pull/1150
 
 Newly added project is not showing in the drop down until the browser is
>>> refreshed
 https://github.com/apache/cloudstack/pull/1082
>>> 
>>> 
>> 
>> 
>> -- 
>> Daan
>

[GitHub] cloudstack pull request: CLOUDSTACK-8858: listVolumes API fails fo...

[sureshanaparti]

Github user sureshanaparti commented on the pull request:

https://github.com/apache/cloudstack/pull/830#issuecomment-162483571
  
@DaanHoogland , @ustcweizhou 
This issue is reproduced when the volume associated vm instance has null or 
invalid state (vm_state in volume_view). The code changes would guard this 
situation since it should not block volume listing.

mysql> SELECT id, name, volume_type, state, vm_state FROM cloud.volume_view 
where vm_state is null;
++--+-+--+--+
| id | name | volume_type | state| vm_state |
++--+-+--+--+
| 57 | ROOT-57  | ROOT| Expunged | NULL |
| 69 | mytestvolume | DATADISK| Ready| NULL |
| 71 | DATA-69  | DATADISK| Expunged | NULL |
| 73 | DATA-70  | DATADISK| Expunged | NULL |
| 78 | testvolcreated   | DATADISK| Ready| NULL |
| 81 | test2volume  | DATADISK| Destroy  | NULL |
| 83 | testvol07| DATADISK| Ready| NULL |
| 87 | testattachvolcreated | DATADISK| Ready| NULL |
++--+-+--+--+
8 rows in set (0.00 sec)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8858: listVolumes API fails fo...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/830#issuecomment-162484552
  
@sureshanaparti How do we force such a situation to occur?
It seems to me that should be guarded on input and alerted on on output 
instead of silently filtered.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8968: UI icon over VM snapshot...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1150#issuecomment-162484701
  
@nitin-maharana @bhaisaab I looked around but just don't find what's 
changed. Please post screenshots of what is changed or instruct exactly how it 
should work. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8968: UI icon over VM snapshot...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1150#issuecomment-162485224
  
Hmm.. this isn't supported on KVM, is it? That may be why I can't find it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8858: listVolumes API fails fo...

[ustcweizhou]

Github user ustcweizhou commented on the pull request:

https://github.com/apache/cloudstack/pull/830#issuecomment-162486767
  
@sureshanaparti 

mysql> SELECT id, name, volume_type, state, vm_state FROM cloud.volume_view 
where vm_state is null and vm_id is not null;
Empty set (0.00 sec)

even in vm_instance

mysql> select * from vm_instance where state is null;
Empty set (0.00 sec)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9086: ACS allows to create iso...

[kansal]

Github user kansal commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1125#discussion_r46809694
  
--- Diff: utils/src/main/java/com/cloud/utils/net/NetUtils.java ---
@@ -1523,7 +1524,15 @@ public static boolean isIpWithtInCidrRange(final 
String ipAddress, final String
 
 final boolean isInRange = 
subnetUtils.getInfo().isInRange(ipAddress);
 
-return isInRange;
+return !isInRange;
--- End diff --

@DaanHoogland Nothing changes functionality wise. I reversed it so as it 
makes sense with the name of the function isNetworkorBroadCastIP() should 
return true if its a network or broadcast IP. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9113: skip vm with inconsisten...

[ustcweizhou]

GitHub user ustcweizhou opened a pull request:

https://github.com/apache/cloudstack/pull/1181

CLOUDSTACK-9113: skip vm with inconsistent state when 
getVmStats/getVmDiskStats

on KVM, if there is a vm has inconsistent state between hypervisor and db, 
the getVmStat will terminate and return nothing, all vm stats will not be 
updated.
we should skip the vm which has inconsistent state, and continue on others.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ustcweizhou/cloudstack 
CLOUDSTACK-9113-getVmStats

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1181.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1181


commit 24edf1c1e4892b2f34b334b6e6fa13364bc413e2
Author: Wei Zhou 
Date:   2015-12-07T11:02:43Z

CLOUDSTACK-9113: skip vm with inconsistent state when 
getVmStats/getVmDiskStats




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9113: skip vm with inconsisten...

[ustcweizhou]

Github user ustcweizhou closed the pull request at:

https://github.com/apache/cloudstack/pull/1181


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9113: skip vm with inconsisten...

[ustcweizhou]

Github user ustcweizhou commented on the pull request:

https://github.com/apache/cloudstack/pull/1181#issuecomment-162488604
  
wrong branch


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9113: skip vm with inconsisten...

[ustcweizhou]

GitHub user ustcweizhou opened a pull request:

https://github.com/apache/cloudstack/pull/1182

CLOUDSTACK-9113: skip vm with inconsistent state when 
getVmStats/getVmDiskStats

on KVM, if there is a vm has inconsistent state between hypervisor and db, 
the getVmStat will terminate and return null, all vm stats will not be updated.
we should skip the vm which has inconsistent state, and continue on others.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ustcweizhou/cloudstack 
CLOUDSTACK-9113-getVmStats

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1182.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1182


commit 24edf1c1e4892b2f34b334b6e6fa13364bc413e2
Author: Wei Zhou 
Date:   2015-12-07T11:02:43Z

CLOUDSTACK-9113: skip vm with inconsistent state when 
getVmStats/getVmDiskStats




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9086: ACS allows to create iso...

[kansal]

Github user kansal commented on the pull request:

https://github.com/apache/cloudstack/pull/1125#issuecomment-162490625
  
@DaanHoogland I see a test case in the NetUtilsTest.java class' 
testIsSameIpRange() function. 
 assertFalse(NetUtils.isSameIpRange(cidrFirst, "10.3.6.5/50"));

I think this is the one causing the problem? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8858: listVolumes API fails fo...

[sureshanaparti]

Github user sureshanaparti commented on the pull request:

https://github.com/apache/cloudstack/pull/830#issuecomment-162493826
  
@ustcweizhou , Same with my result set as well.
mysql> select * from vm_instance where state is null;
Empty set (0.00 sec)

mysql> SELECT id, name, volume_type, state, vm_state FROM cloud.volume_view 
where vm_state is null and vm_id is not null;
Empty set (0.00 sec)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9095 : Hypervisor changes to s...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1142#issuecomment-162493847
  
@remibergsma Do you remember any changes that might be causing 
HypervisorUtilsTest.checkVolumeFileForActivityTest to fail?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8858: listVolumes API fails fo...

[sureshanaparti]

Github user sureshanaparti commented on the pull request:

https://github.com/apache/cloudstack/pull/830#issuecomment-162494808
  
The volumes, in Ready state and are not attached to any VM have their 
vm_state has null and querying such volumes may result in NPE. These changes 
are only to safe guard.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9095 : Hypervisor changes to s...

[nlivens]

Github user nlivens commented on the pull request:

https://github.com/apache/cloudstack/pull/1142#issuecomment-162496553
  
@bhaisaab, we've looked into the code of that test, and the results are 
unreliable.
The steps that are done in that test (along with the implementation of the 
called method)
1. Create file
2. Register start time
3. Loop until the diff between now and last modified or last accessed time 
is higher than a passed threshold (2000ms)
4. Register end time
5. Check if diff between start and end time is lower than passed threshold 
(2000ms)

It's possible that between step 1 and 2, mostly on a loaded system, the 
thread that is running the test has to wait for available resources on your 
system. Therefore it's possible that step 3 returns immediately without 
looping. So, the end time will be really close to the start time, and will be 
below those 2000ms.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9086: ACS allows to create iso...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1125#issuecomment-162497602
  
it is the NetUtilsTest.test31BitPrefix...() family of tests that are failing


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

CloudStack Logging, the log4j Configuration file

[Chaz PC]

I am studying the logging process used by CloudStack and came accross the 
configuration file that is used by Log4j. What is confusing to me is that all 
the resources is stating that the "log4j-cloud.xml" is supposed to be the file 
used to confiugre the logging, but what I have noticed is that no matter what 
are the changes I made using this file it would just go back to what it was. 
Never the less I found if I change the "log4j-cloud.xml.in" file these changes 
will be reflected on the created log files. 

There are around 13 "log4j-cloud.xml" files  as well as 13 "log4-cloud.xml.in" 
files spreaded accross the source code. These files are not the same, some of 
them may have the same configuration but mostly they differ. 

Can you please explain the diffrences between these files. 

Waiting for your answer. 

Best Regards

Hanan 

[GitHub] cloudstack pull request: CLOUDSTACK-9095 : Hypervisor changes to s...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1142#issuecomment-162498348
  
@nlivens there are several tests like this bugging us. Do you know an 
alternative for this one?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

ROOT volume resize fails if the VM is stopped

[Nux!]

Hello,

Just hit this today.. Opened the following issue with it. Functionality is 
restored if I use a v4.4 qcow2/resizevolume.sh script.
https://issues.apache.org/jira/browse/CLOUDSTACK-9115

--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro

CloudStack Logging, the log4j Configuration file

[Chaz PC]

Hello,




I am studying the logging process used by CloudStack and came accross the 
configuration file that is used by Log4j. What is confusing to me is that all 
the resources is stating that the "log4j-cloud.xml" is supposed to be the file 
used to confiugre the logging, but what I have noticed is that no matter what 
are the changes I made using this file it would just go back to what it was. 
Never the less I found if I change the "log4j-cloud.xml.in" file these changes 
will be reflected on the created log files. 

There are around 13 "log4j-cloud.xml" files  as well as 13 "log4-cloud.xml.in" 
files spreaded accross the source code. These files are not the same, some of 
them may have the same configuration but mostly they differ. 

Can you please explain the diffrences between these files. 

Waiting for your answer. 

Best Regards

Hanan   
  

[GitHub] cloudstack pull request: Quota

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/768#issuecomment-162506613
  
Abhi has fixed the issues, changes  are now incorporated, commits squashed 
into one.
cc @remibergsma @jburwell

LGTM, let's merge this before EOD.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Feature freeze ACS 4.7 next Monday

[sebgoa]

The rn repo contains a script that polls JIRA for a release filter and 
generates the tables of issues fixed:

https://github.com/apache/cloudstack-docs-rn/blob/master/utils/jira.py

but we are not tracking the ones that really are *features*….

small detail that would be nice to sort out.

On Dec 7, 2015, at 12:01 PM, Remi Bergsma  wrote:

> Hi Seb,
> 
> Now that we merge everything and have a smaller scope, it should be easier to 
> get the list of pull requests that got in since 4.6.
> 
> Quick attempt:
> 
> git log --pretty=oneline --abbrev-commit upstream/4.6..master | grep Merge | 
> grep -v release | grep -v 4\.6 | awk {'print $5'} | sed s/\#//g | sort -n
> 
> 801
> 834
> 840
> 841
> 850
> 929
> 935
> 937
> 942
> 943
> 944
> 1007
> 1013
> 1018
> 1019
> 1021
> 1035
> 1038
> 1049
> 1051
> 1057
> 1065
> 1068
> 1069
> 1071
> 1083
> 1084
> 1086
> 1092
> 1100
> 1102
> 1107
> 1108
> 1110
> 1118
> 1122
> 1128
> 1129
> 1137
> 1139
> 1140
> 1143
> 1167
> 1172
> 1173
> 
> If we make a script that gets this output and queries Github, we can get a 
> list of the PR titles. Then we need to make sure those titles are any good ;-)
> 
> 
> Regards,
> Remi
> 
> 
> 
> 
> On 07/12/15 10:13, "sebgoa"  wrote:
> 
>> 
>> On Dec 7, 2015, at 9:56 AM, Daan Hoogland  wrote:
>> 
>>> Rohit, Sebastien,
>>> 
>>> I think we do not need to hurry any issues. work on 4.8 will start in
>>> January or february at the latest.
>> 
>> 
>> I don't want to hurry anything, I want to be able to have release notes that 
>> describe *all* the features added.
>> 
>> Check the 4.6 release notes, I am sure we did more than this, but since dev 
>> more often than not don't care much about the RN, the features are not 
>> publicized.
>> 
>> 
>> 
>>> 
>>> On Mon, Dec 7, 2015 at 8:55 AM, sebgoa  wrote:
>>> 
 Hate to be a pain, but could you make sure to keep the exact list of
 Features merged, so that the Release notes are accurate ?
 
 thanks
 
 On Dec 4, 2015, at 11:58 PM, Remi Bergsma 
 wrote:
 
> Hi all,
> 
> Next Monday we'll feature freeze for our upcoming 4.7 release. We looked
 through all open Pull Requests and below is our "whish list" to get in 4.7.
 Feel free to nominate any other changes that should go in 4.7. No
 guarantees, there is limited time so only PRs that we actively work on will
 make it.
> 
> The RC of 4.7.0 is scheduled for Monday Dec 14th so that we all will
 have a nice Christmas present ;-)
> 
> Please help us review these PRs. Most have already had some review and
 when we can reach 2xLGTM we can include them in 4.7 on time and make
 another great release.
> 
> Happy testing and reviewing!
> 
> Regards,
> Daan & Remi
> 
> 
> Features & Fixes PRs:
> 
> Quota
> https://github.com/apache/cloudstack/pull/768
> 
> Logging enhancement
> https://github.com/apache/cloudstack/pull/1167
> 
> VMware diskcontrollers
> https://github.com/apache/cloudstack/pull/1132
> 
> ACS allows to create isolated networks with invalid gateway ip
> https://github.com/apache/cloudstack/pull/1125
> 
> Update nic IP address of stopped vm
> https://github.com/apache/cloudstack/pull/1086
> 
> Hypervisor changes to support UserData for Nuage VSP
> https://github.com/apache/cloudstack/pull/1142
> 
> Support shared networking in NiciraNVP Plugin
> https://github.com/apache/cloudstack/pull/1094
> 
> Strongswan vpn feature
> https://github.com/apache/cloudstack/pull/872
> 
> VM Snapshotting implementation for KVM
> https://github.com/apache/cloudstack/pull/977
> 
> Redundant VPC improvement
> (PR will follow over the weekend)
> 
> 
> UI PRs:
> 
> [UI] fix bug: Cannot delete SSH keypairs in projects
> https://github.com/apache/cloudstack/pull/1154
> 
> UI icon over VM snapshot to deploy user instance
> https://github.com/apache/cloudstack/pull/1150
> 
> Newly added project is not showing in the drop down until the browser is
 refreshed
> https://github.com/apache/cloudstack/pull/1082
 
 
>>> 
>>> 
>>> -- 
>>> Daan
>> 

[GitHub] cloudstack pull request: Marvin test to verify that adding TCP por...

[sanju1010]

GitHub user sanju1010 opened a pull request:

https://github.com/apache/cloudstack/pull/1183

Marvin test to verify that adding TCP ports 500,4500 and 1701 in vpn should 
not fail

Please refer to JIRA ticket for more details
https://issues.apache.org/jira/browse/CLOUDSTACK-9117

Following is the result info:
Test to add TCP Port Forwarding rule for specific ports(500,1701 and 4500) 
in VPN ... === TestName: test_08_add_TCP_PF_Rule_In_VPN | Status : SUCCESS ===
ok

--
Ran 1 test in 166.799s

OK


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sanju1010/cloudstack tcpports

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1183.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1183


commit d09ebac31892cf24246801f129c7325692efcbd4
Author: sanjeevn 
Date:   2015-12-07T12:25:50Z

Marvin test to verify that adding TCP ports 500,4500 and 1701
in vpn should not fail
Bug-Id: CS-43653
Reviewed-by: Self




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Strongswan vpn feature

[jayapalu]

Github user jayapalu commented on the pull request:

https://github.com/apache/cloudstack/pull/872#issuecomment-162517321
  
Remote access vpn test results:
nosetests-2.7 --with-marvin 
--marvin-config=/Users/jayapalreddy/advanced.cfg 
/Users/jayapalreddy/dev/github/cloudstack/test/integration/component/test_vpn_users.py
 -a tags=advanced   —hypervisor=xenserver

JayMac:internal-cloudstack jayapalreddy$ tail -f 
/tmp//MarvinLogs//Dec_07_2015_17_18_10_ZYH2JF/results.txt
VPN remote access user limit tests ... === TestName: test_01_VPN_user_limit 
| Status : SUCCESS ===
ok
Test create VPN when L2TP port in use ... === TestName: 
test_02_use_vpn_port | Status : SUCCESS ===
ok
Test create NAT rule when VPN when L2TP enabled ... === TestName: 
test_03_enable_vpn_use_port | Status : SUCCESS ===
ok
Test add new users to existing VPN ... === TestName: test_04_add_new_users 
| Status : SUCCESS ===
ok
Test add duplicate user to existing VPN ... === TestName: 
test_05_add_duplicate_user | Status : SUCCESS ===
ok
Test as global admin, add a new VPN user to an existing VPN entry ... === 
TestName: test_06_add_VPN_user_global_admin | Status : SUCCESS ===
ok
Test as domain admin, add a new VPN user to an existing VPN entry ... === 
TestName: test_07_add_VPN_user_domain_admin | Status : SUCCESS ===
ok


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script

[michaelandersen]

Github user michaelandersen commented on the pull request:

https://github.com/apache/cloudstack/pull/1156#issuecomment-162520027
  
Just tested this on 4.6.1-SNAPSHOT with the command:
``` 
nosetests --with-marvin 
--marvin-config=/data/shared/marvin/mct-zone1-xen1.cfg -a 
tags=advanced,required_hardware=true /tmp/test_vpc_vpn.py
```
and it failed:
```
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn 
| Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : 
EXCEPTION ===
ERROR

==
ERROR: Test VPN in VPC
--
Traceback (most recent call last):
  File "/tmp/test_vpc_vpn.py", line 712, in test_vpc_site2site_vpn
self.assert_(int(packet_loss) == 0, "Ping did not succeed")
ValueError: invalid literal for int() with base 10: 'received,'
 >> begin captured stdout << -
=== TestName: test_vpc_site2site_vpn | Status : EXCEPTION ===


- >> end captured stdout << --
```
I'm pretty sure this has to do with: 
https://github.com/sanju1010/cloudstack/blob/09409a7ac264e864c45146927b86229c8e67fbc8/test/integration/smoke/test_vpc_vpn.py/#L711




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8858: listVolumes API fails fo...

[ustcweizhou]

Github user ustcweizhou commented on the pull request:

https://github.com/apache/cloudstack/pull/830#issuecomment-162520618
  
@sureshanaparti 
I do not get NPE when listVolumes.

please notice the code:
long instanceId = volume.getVmId();
if (instanceId > 0 && volume.getState() != Volume.State.Destroy) {
...

if the volume is not attached, this judgment returns false.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script

[michaelandersen]

Github user michaelandersen commented on the pull request:

https://github.com/apache/cloudstack/pull/1156#issuecomment-162522267
  
ping @sanju1010 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9095 : Hypervisor changes to s...

[nlivens]

Github user nlivens commented on the pull request:

https://github.com/apache/cloudstack/pull/1142#issuecomment-162523432
  
@DaanHoogland, below you can find a possible alternative for this test file.

[HypervisorUtilsTestPatch.txt](https://github.com/apache/cloudstack/files/53965/HypervisorUtilsTestPatch.txt)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Strongswan vpn feature

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/872#issuecomment-162526429
  
@jayapalu Nice! Did you also test site2site VPN?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9106 - As a Developer I want t...

[wilderrodrigues]

GitHub user wilderrodrigues opened a pull request:

https://github.com/apache/cloudstack/pull/1184

CLOUDSTACK-9106 - As a Developer I want the Redundant VPC private gateway 
feature fixed

This PR contains the same fixes from PR #1179, which was created against 
the master branch.

In addition, the points mentioned by @DaanHoogland were handled in this new 
PR:

* Made the code more consistent
  - result = result && methodCall(), instead of throwing exceptions in some 
places or not checking 2 consecutive returns - in case of rVPC.
* Added an unit test to cover changes in the 
VpcRouterElementImpl.applyVpnUsers() method. The method returns an array of 
String, so I had to make sure it would contain the users from 2 consecutive 
calls. There are 2 tests to cover negative scenarios.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ekholabs/cloudstack 
fix/4.6-rvpc-pvtgw-CLOUDSTACK-9106

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1184.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1184


commit a168a69c3cdf023a296ad9a8793e3ab4d7e47cee
Author: Wilder Rodrigues 
Date:   2015-12-04T17:41:03Z

CLOUDSTACK-9106 - Reduces the amount of iterations through the routers of a 
VPC

   - It was causing problems because Nics were expected to be plugged 
before they actually exist. Only in rVPC cases.
   - Applies ACL items to routers only after the Pvt GW is setup.

commit 24dafc2cc242b69e986d83a94baae30af368b132
Author: Wilder Rodrigues 
Date:   2015-12-05T13:03:50Z

CLOUDSTACK-9106 - Refactor the createPrivateNicProfileForGateway() method

- Use the router to retrieve the instance ID
- Check if the VPC is redundant in order to reuse the private gateway 
address.
- Brings the private gateways interfaces up.

commit 1738ce174005096f4106673bb5b35cd1351a5f56
Author: Wilder Rodrigues 
Date:   2015-12-05T16:33:55Z

CLOUDSTACK-9106 - Enables private gateway tests on Redundant VPCs

commit 13eb78938820489efc0251cf85ed4e7fd01f685d
Author: Wilder Rodrigues 
Date:   2015-12-07T12:40:12Z

CLOUDSTACK-9106 - Makes the router commands call more consistent.

   - Checks the result of a call against the previous result. Either both 
are true or the method returns false.
   - Do not thrown exceptions because some calls are not 
handling/rethrowing them. It would cause runtime problems.
   - When doing a list.addAll(Arrays.asList(String[]{}) will cause problems 
when trying to cast the list.toArray() into an aray of String
 It would only work if instead of calling addAll() I would pass it 
straight into the constructor:
 e.g. List l = new ArrayList(Arrays.asList(new String[]{});
  Stirng [] s = (String[]) l.toArray();
 But I did not like that implementation because it would require 2 
arrays of string and combine them at the end.

commit 5973f4ea77ed3328e74c79069dcf5b1eff2f049f
Author: Wilder Rodrigues 
Date:   2015-12-07T12:42:29Z

CLOUDSTACK-9106 - Adds a test to cover the changes in the applyVpnUsers() 
method

   - Changed the NetworkTopologyContext class just to make the private 
member accessible from the test
   - Added a test class to cover the positive scenario of the 
VpcVirtualRouterElementTest.applyVpnUsers() method.
   - Covering when there is either no VPC or no routers.

commit 14db2d3dc4f8afefaa48a52c70d8141b8b4222ad
Author: Wilder Rodrigues 
Date:   2015-12-07T12:43:46Z

CLOUDSTACK-9106 - Makes Enum name compliant with Java code conventions.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9106 - As a Developer I want t...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/1184#issuecomment-162527902
  
Ping @DaanHoogland @remibergsma @borisroman 

I will continue the tests, but PR is ready to be reviewed.

* Environment
  - Hardware required: TRUE
  - Management Server + MySQL on CentOS 7.1
  - One KVM Host on CentOS 7.1
  - Agent + Common RPMs built from 4.6.1 source

* Tests executed
```
nosetests --with-marvin 
--marvin-config=/data/shared/marvin/mct-zone1-kvm1-ISOLATED.cfg -s -a 
tags=advanced,required_hardware=true smoke/test_privategw_acl.py
```

* Results

```
test_01_vpc_privategw_acl 
(integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName: 
test_01_vpc_privategw_acl | Status : SUCCESS ===
ok
test_02_vpc_privategw_static_routes 
(integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName: 
test_02_vpc_privategw_static_routes | Status : SUCCESS ===
ok
test_03_rvpc_privategw_static_routes 
(integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName: 
test_03_rvpc_privategw_static_routes | Status : SUCCESS ===
ok

--
Ran 3 tests in 2359.021s

OK
/tmp//MarvinLogs/test_privategw_acl_11STHV/results.txt (END)
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Quota

[agneya2001]

Github user agneya2001 commented on the pull request:

https://github.com/apache/cloudstack/pull/768#issuecomment-162529656
  
@bhaisaab @remibergsma there is still one issue that I am looking at now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...

[serg38]

Github user serg38 commented on the pull request:

https://github.com/apache/cloudstack/pull/1094#issuecomment-162532791
  
This index comes from schema-40to410.sql:

CREATE TABLE `cloud`.`nicira_nvp_router_map` (

  `id` bigint unsigned NOT NULL AUTO_INCREMENT COMMENT 'id',

  `logicalrouter_uuid` varchar(255) NOT NULL UNIQUE COMMENT 'nicira uuid of 
logical router',

  `network_id` bigint unsigned NOT NULL UNIQUE COMMENT 'cloudstack id of 
the network',

  PRIMARY KEY (`id`),

  CONSTRAINT `fk_nicira_nvp_router_map__network_id` FOREIGN KEY 
(`network_id`) REFERENCES `networks`(`id`) ON DELETE CASCADE

) ENGINE=InnoDB DEFAULT CHARSET=utf8; 







There might be variation how UNIQUE attribute is enforced in different 
versions of MySQL.

In 5.5 it generate unique index  `logicalrouter_uuid`

To take it out the correct statement is

ALTER TABLE `cloud`.`nicira_nvp_router_map` 
DROP INDEX `logicalrouter_uuid` ;

Can you check if schema-40to410.sql got applied in your environment? What 
version of MySQL do you use?

The drop index logicalrouter_uuid should come from schema-470to471.sql (or 
later upgrade script)but not from schema-410to420-cleanup.sql.



From:  Remi Bergsma 
Reply-To:  apache/cloudstack 
Date:  Sunday, December 6, 2015 at 11:59 AM
To:  apache/cloudstack 
Cc:  Sergey Levitskiy 
Subject:  Re: [cloudstack] CLOUDSTACK-9074: Support shared networking in 
NiciraNVP Plugin (#1094)


Guys, I cannot build a cloud from this branch any more. The build itself 
works, but the database deployment gives an SQL error: Can't DROP 
'logicalrouter_uuid'; check that column/key exists

Details:
[INFO] --- exec-maven-plugin:1.2.1:java (create-schema) @ cloud-developer 
---
log4j:WARN No appenders could be found for logger 
(org.springframework.core.env.StandardEnvironment).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for 
more info.
> WARNING: Provided file does not exist: 
/data/git/cs1/cloudstack/developer/../utils/conf/db.properties.override
> WARNING: Provided file does not exist: 
/data/git/cs1/cloudstack/developer/developer-prefill.sql.override
> Initializing database=cloud with host=localhost port=3306 
username=cloud password=cloud
> Running query: drop database if exists `cloud`
> Running query: create database `cloud`
> Running query: GRANT ALL ON cloud.* to 'cloud'@`localhost` 
identified by 'cloud'
> Running query: GRANT ALL ON cloud.* to 'cloud'@`%` identified 
by 'cloud'
> Initializing database=cloud_usage with host=localhost port=3306 
username=cloud password=cloud
> Running query: drop database if exists `cloud_usage`
> Running query: create database `cloud_usage`
> Running query: GRANT ALL ON cloud_usage.* to 
'cloud'@`localhost` identified by 'cloud'
> Running query: GRANT ALL ON cloud_usage.* to 'cloud'@`%` 
identified by 'cloud'
> Processing SQL file at 
/data/git/cs1/cloudstack/developer/target/db/create-schema.sql
> Processing SQL file at 
/data/git/cs1/cloudstack/developer/target/db/create-schema-premium.sql
> Processing SQL file at 
/data/git/cs1/cloudstack/developer/target/db/templates.sql
> Processing SQL file at 
/data/git/cs1/cloudstack/developer/developer-prefill.sql
> Processing upgrade: com.cloud.upgrade.DatabaseUpgradeChecker
[WARNING]
java.lang.reflect.InvocationTargetException
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at org.codehaus.mojo.exec.ExecJavaMojo$1.run(ExecJavaMojo.java:297)
at java.lang.Thread.run(Thread.java:745)
Caused by: com.cloud.utils.exception.CloudRuntimeException: Unable to 
execute upgrade script: 
/data/git/cs1/cloudstack/developer/target/db/db/schema-410to420-cleanup.sql
at 
com.cloud.upgrade.DatabaseUpgradeChecker.runScript(DatabaseUpgradeChecker.java:290)
at 
com.cloud.upgrade.DatabaseUpgradeChecker.upgrade(DatabaseUpgradeChecker.java:425)
at 
com.cloud.upgrade.DatabaseUpgradeChecker.check(DatabaseUpgradeChecker.java:474)
at com.cloud.upgrade.DatabaseCreator.main(DatabaseCreator.java:217)
... 6 more
Caused by: com.mysql.jdbc.exceptions.jdbc4.MySQLSyntaxErrorException: Can't 
DROP 'logicalrouter_uuid'; check that column/key exists
at com.c

Re: Feature freeze ACS 4.7 next Monday

[cs user]

Hi Folks,

Would anyone else be able to give
https://github.com/apache/cloudstack/pull/1037 a try at some point?

Quite a serious issue when running in clustered mode with Xen, and trying
to perform VM migrations between hosts.

Thanks!

On Mon, Dec 7, 2015 at 12:08 PM, sebgoa  wrote:

> The rn repo contains a script that polls JIRA for a release filter and
> generates the tables of issues fixed:
>
> https://github.com/apache/cloudstack-docs-rn/blob/master/utils/jira.py
>
> but we are not tracking the ones that really are *features*….
>
> small detail that would be nice to sort out.
>
> On Dec 7, 2015, at 12:01 PM, Remi Bergsma 
> wrote:
>
> > Hi Seb,
> >
> > Now that we merge everything and have a smaller scope, it should be
> easier to get the list of pull requests that got in since 4.6.
> >
> > Quick attempt:
> >
> > git log --pretty=oneline --abbrev-commit upstream/4.6..master | grep
> Merge | grep -v release | grep -v 4\.6 | awk {'print $5'} | sed s/\#//g |
> sort -n
> >
> > 801
> > 834
> > 840
> > 841
> > 850
> > 929
> > 935
> > 937
> > 942
> > 943
> > 944
> > 1007
> > 1013
> > 1018
> > 1019
> > 1021
> > 1035
> > 1038
> > 1049
> > 1051
> > 1057
> > 1065
> > 1068
> > 1069
> > 1071
> > 1083
> > 1084
> > 1086
> > 1092
> > 1100
> > 1102
> > 1107
> > 1108
> > 1110
> > 1118
> > 1122
> > 1128
> > 1129
> > 1137
> > 1139
> > 1140
> > 1143
> > 1167
> > 1172
> > 1173
> >
> > If we make a script that gets this output and queries Github, we can get
> a list of the PR titles. Then we need to make sure those titles are any
> good ;-)
> >
> >
> > Regards,
> > Remi
> >
> >
> >
> >
> > On 07/12/15 10:13, "sebgoa"  wrote:
> >
> >>
> >> On Dec 7, 2015, at 9:56 AM, Daan Hoogland 
> wrote:
> >>
> >>> Rohit, Sebastien,
> >>>
> >>> I think we do not need to hurry any issues. work on 4.8 will start in
> >>> January or february at the latest.
> >>
> >>
> >> I don't want to hurry anything, I want to be able to have release notes
> that describe *all* the features added.
> >>
> >> Check the 4.6 release notes, I am sure we did more than this, but since
> dev more often than not don't care much about the RN, the features are not
> publicized.
> >>
> >>
> >>
> >>>
> >>> On Mon, Dec 7, 2015 at 8:55 AM, sebgoa  wrote:
> >>>
>  Hate to be a pain, but could you make sure to keep the exact list of
>  Features merged, so that the Release notes are accurate ?
> 
>  thanks
> 
>  On Dec 4, 2015, at 11:58 PM, Remi Bergsma <
> rberg...@schubergphilis.com>
>  wrote:
> 
> > Hi all,
> >
> > Next Monday we'll feature freeze for our upcoming 4.7 release. We
> looked
>  through all open Pull Requests and below is our "whish list" to get
> in 4.7.
>  Feel free to nominate any other changes that should go in 4.7. No
>  guarantees, there is limited time so only PRs that we actively work
> on will
>  make it.
> >
> > The RC of 4.7.0 is scheduled for Monday Dec 14th so that we all will
>  have a nice Christmas present ;-)
> >
> > Please help us review these PRs. Most have already had some review
> and
>  when we can reach 2xLGTM we can include them in 4.7 on time and make
>  another great release.
> >
> > Happy testing and reviewing!
> >
> > Regards,
> > Daan & Remi
> >
> >
> > Features & Fixes PRs:
> >
> > Quota
> > https://github.com/apache/cloudstack/pull/768
> >
> > Logging enhancement
> > https://github.com/apache/cloudstack/pull/1167
> >
> > VMware diskcontrollers
> > https://github.com/apache/cloudstack/pull/1132
> >
> > ACS allows to create isolated networks with invalid gateway ip
> > https://github.com/apache/cloudstack/pull/1125
> >
> > Update nic IP address of stopped vm
> > https://github.com/apache/cloudstack/pull/1086
> >
> > Hypervisor changes to support UserData for Nuage VSP
> > https://github.com/apache/cloudstack/pull/1142
> >
> > Support shared networking in NiciraNVP Plugin
> > https://github.com/apache/cloudstack/pull/1094
> >
> > Strongswan vpn feature
> > https://github.com/apache/cloudstack/pull/872
> >
> > VM Snapshotting implementation for KVM
> > https://github.com/apache/cloudstack/pull/977
> >
> > Redundant VPC improvement
> > (PR will follow over the weekend)
> >
> >
> > UI PRs:
> >
> > [UI] fix bug: Cannot delete SSH keypairs in projects
> > https://github.com/apache/cloudstack/pull/1154
> >
> > UI icon over VM snapshot to deploy user instance
> > https://github.com/apache/cloudstack/pull/1150
> >
> > Newly added project is not showing in the drop down until the
> browser is
>  refreshed
> > https://github.com/apache/cloudstack/pull/1082
> 
> 
> >>>
> >>>
> >>> --
> >>> Daan
> >>
>
>

[GitHub] cloudstack pull request: Removal of class AgentBasedStandaloneCons...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/855#issuecomment-162533617
  
LGTM based on these tests:

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
component/test_routers_iptables_default_policy.py \
component/test_routers_network_ops.py \
component/test_vpc_router_nics.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_network.py

```

Result:

```
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check the password file in the Router VM ... === TestName: 
test_isolate_network_password_server | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... === 
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS 
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 
| Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS 
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS 
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS 
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS 
===
ok
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn 
| Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : SUCCESS 
===
ok
Test for port forwarding on source NAT ... === TestName: 
test_01_port_fwd_on_src_nat | Status : SUCCESS ===
ok
Test for port forwarding on non source NAT ... === TestName: 
test_02_port_fwd_on_non_src_nat | Status : SUCCESS ===
ok
Test for reboot router ... === TestName: test_reboot_router | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : SUCCESS 
===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Status : 
SUCCESS ===
ok

--
Ran 33 tests in 17592.484s

OK
```


And:

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=false \
smoke/test_routers.py \
smoke/test_network_acl.py \
smoke/test_privategw_acl.py \
smoke/test_reset_vm_on_reboot.py \
smoke/test_vm_life_cycle.py \
smoke/test_vpc_vpn.py \
smoke/test_service_offerings.py \
component/test_

[GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1156#issuecomment-162535442
  
Doesn't work for me either:

```
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn 
| Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : 
EXCEPTION ===
ERROR
```

The original one works:

```
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn 
| Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : SUCCESS 
===
ok

--
Ran 2 tests in 1054.998s

OK
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script

[sanju1010]

Github user sanju1010 commented on the pull request:

https://github.com/apache/cloudstack/pull/1156#issuecomment-162539384
  
Hi Remi,

As I mentioned in my PR the second test failure is related to connectivity
issues between the vms part of s2s vpn. It is not because of my changes.

Thanks,
Sanjeev
On Dec 7, 2015 7:48 PM, "Remi Bergsma"  wrote:

> Doesn't work for me either:
>
> Test Remote Access VPN in VPC ... === TestName: 
test_vpc_remote_access_vpn | Status : SUCCESS ===
> ok
> Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : 
EXCEPTION ===
> ERROR
>
> The original one works:
>
> Test Remote Access VPN in VPC ... === TestName: 
test_vpc_remote_access_vpn | Status : SUCCESS ===
> ok
> Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : 
SUCCESS ===
> ok
>
> --
> Ran 2 tests in 1054.998s
>
> OK
>
> —
> Reply to this email directly or view it on GitHub
> .
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: CloudStack Logging, the log4j Configuration file

[Miguel Ferreira]

+1 on this question.
I too would like to know the reason for having all these files in different 
modules.



On 07/12/15 12:52, "Chaz PC"  wrote:

>Hello,
>
>
>
>
>I am studying the logging process used by CloudStack and came accross the 
>configuration file that is used by Log4j. What is confusing to me is that all 
>the resources is stating that the "log4j-cloud.xml" is supposed to be the file 
>used to confiugre the logging, but what I have noticed is that no matter what 
>are the changes I made using this file it would just go back to what it was. 
>Never the less I found if I change the "log4j-cloud.xml.in" file these changes 
>will be reflected on the created log files. 
>
>There are around 13 "log4j-cloud.xml" files  as well as 13 "log4-cloud.xml.in" 
>files spreaded accross the source code. These files are not the same, some of 
>them may have the same configuration but mostly they differ. 
>
>Can you please explain the diffrences between these files. 
>
>Waiting for your answer. 
>
>Best Regards
>
>Hanan  
>  

[GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script

[terbolous]

Github user terbolous commented on the pull request:

https://github.com/apache/cloudstack/pull/1156#issuecomment-162544664
  
@sanju1010 the error lies in the script due to different outputs. the test 
seems to use macchinina as template, which has the following output for ping:
# ping -c 1 -t 1 x.y.z.40
PING x.y.z.40 (x.y.z.40): 56 data bytes

--- x.y.z.40 ping statistics ---
1 packets transmitted, 0 packets received, 100% packet loss

The cut on line 711 picks field 6, which is 'received' and not 0.

a regular debian derivate has the following output:
--- x.y.z.40 ping statistics ---
1 packets transmitted, 0 received, +1 errors, 100% packet loss, time 0ms

where your cut would match '+1' and work.

conclusion; either change the template or change the cut


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script

[michaelandersen]

Github user michaelandersen commented on the pull request:

https://github.com/apache/cloudstack/pull/1156#issuecomment-162545461
  
Hi Sanju,

Isn't it the point of the test to verify this exact connectivity?

But I any case I don't believe connectivity is the reason this test is
failing. I changed the -f option on line 711 back to field 7 and the test
passes now.

Please refactor that line and try again.

Best regards, Michael


On Monday, 7 December 2015, sanju1010  wrote:

> Hi Remi,
>
> As I mentioned in my PR the second test failure is related to connectivity
> issues between the vms part of s2s vpn. It is not because of my changes.
>
> Thanks,
> Sanjeev
> On Dec 7, 2015 7:48 PM, "Remi Bergsma"  > wrote:
>
> > Doesn't work for me either:
> >
> > Test Remote Access VPN in VPC ... === TestName:
> test_vpc_remote_access_vpn | Status : SUCCESS ===
> > ok
> > Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status :
> EXCEPTION ===
> > ERROR
> >
> > The original one works:
> >
> > Test Remote Access VPN in VPC ... === TestName:
> test_vpc_remote_access_vpn | Status : SUCCESS ===
> > ok
> > Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status :
> SUCCESS ===
> > ok
> >
> > --
> > Ran 2 tests in 1054.998s
> >
> > OK
> >
> > —
> > Reply to this email directly or view it on GitHub
> > .
> >
>
> —
> Reply to this email directly or view it on GitHub
> .
>


-- 
Michael Andersen



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1156#issuecomment-162546287
  
:-1: Tests are failing, we need to fix it before we consider a merge, sorry.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9106 - As a Developer I want t...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/1184#issuecomment-162548576
  
Jenkins known issue:


![image](https://cloud.githubusercontent.com/assets/5129209/11629982/7a0ef4a8-9cfb-11e5-8c46-8083306958b8.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9095 : Hypervisor changes to s...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1142#issuecomment-162549079
  
@nlivens I like your patch, can you send that as a separate PR please?
LGTM, cc @remibergsma please merge this (do you need to run your tests, if 
necessary?)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Adapted HypervisorUtilsTest to no longer ...

[nlivens]

GitHub user nlivens opened a pull request:

https://github.com/apache/cloudstack/pull/1185

Adapted HypervisorUtilsTest to no longer give false positives



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nlivens/cloudstack test_improvement

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1185.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1185


commit 994ce15c743fc0dc277e089f6240b7c09caed219
Author: Nick Livens 
Date:   2015-12-07T15:04:41Z

Adapted HypervisorUtilsTest to no longer give false positives




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Adapted HypervisorUtilsTest to no longer ...

[nlivens]

Github user nlivens commented on the pull request:

https://github.com/apache/cloudstack/pull/1185#issuecomment-162551073
  
@bhaisaab, this is the PR for the test adaptation discussed in PR#1142


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8746: VM Snapshotting im...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/977#issuecomment-162565931
  
Run the tests again. LGTM based on these tests:

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
component/test_routers_iptables_default_policy.py \
component/test_routers_network_ops.py \
component/test_vpc_router_nics.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_network.py

```

Result:

```
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check the password file in the Router VM ... === TestName: 
test_isolate_network_password_server | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... === 
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS 
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 
| Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS 
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS 
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS 
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS 
===
ok
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn 
| Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : SUCCESS 
===
ok
Test for port forwarding on source NAT ... === TestName: 
test_01_port_fwd_on_src_nat | Status : SUCCESS ===
ok
Test for port forwarding on non source NAT ... === TestName: 
test_02_port_fwd_on_non_src_nat | Status : SUCCESS ===
ok
Test for reboot router ... === TestName: test_reboot_router | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : SUCCESS 
===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Status : 
SUCCESS ===
ok

--
Ran 33 tests in 16765.438s

OK
```


And:

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=false \
smoke/test_routers.py \
smoke/test_network_acl.py \
smoke/test_privategw_acl.py \
smoke/test_reset_vm_on_reboot.py \
smoke/test_vm_life_cycle.py \
smoke/test_vpc_vpn.py \
smoke/test_service_offerings.py 

[GitHub] cloudstack pull request: Quota

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/768#issuecomment-162572129
  
@agneya2001 OK, please ping me when done!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Quota

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/768#issuecomment-162572535
  
@bhaisaab Minor thing: could you also rename the title to "Implement Quota 
service"?

I will make sure it will be merged before we freeze.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Quota

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/768#issuecomment-162573927
  
@remibergsma sure, I'm discussing with Abhi on that minor fix. After that, 
will squash/amend the message in the git log.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9106 - As a Developer I want t...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/1184#issuecomment-162574201
  
Ping @remibergsma @miguelaferreira @DaanHoogland @borisroman 

Problem with my PR! I haven’t seen that one failing before. Will 
investigate.

```=== TestName: test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false 
| Status : FAILED ===```



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Adapted HypervisorUtilsTest to no longer ...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1185#issuecomment-162578278
  
Great thanks, LGTM.
cc @remibergsma  - let's merge this, just so to have less Travis failures? 
(possibly also merge on 4.6?)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Adapted HypervisorUtilsTest to no longer ...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1185#issuecomment-162588761
  
@nlivens @bhaisaab If you guys want this in 4.6 as well (which seems like a 
good idea) please open a PR against 4.6. That will then be forward merged to 
master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Implement Quota service

[agneya2001]

Github user agneya2001 commented on the pull request:

https://github.com/apache/cloudstack/pull/768#issuecomment-162595100
  
@bhaisaab the issue is resolved.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9106 - As a Developer I want t...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/1184#issuecomment-162598613
  
Ping @remibergsma @DaanHoogland @miguelaferreira @borisroman 

Deployed another DC and followed the same step as the test, but did it 
manually:

Result:

* Without egress configured to open ports
```
sbpltk1zffh04:sbp_dev wrodrigues$ ssh root@192.168.23.54
root@192.168.23.54's password: 
# ping 8.8.8.8
PING 8.8.8.8 (8.8.8.8): 56 data bytes
^C
--- 8.8.8.8 ping statistics ---
3 packets transmitted, 0 packets received, 100% packet loss
```

* After configuring egress
```
sbpltk1zffh04:sbp_dev wrodrigues$ ssh root@192.168.23.54
root@192.168.23.54's password: 
# wget google.com
--2015-12-07 17:15:16--  http://google.com/
Resolving google.com... 2a00:1450:4013:c00::8b, 173.194.65.102, 
173.194.65.138, ...
Connecting to google.com|2a00:1450:4013:c00::8b|:80... failed: Network is 
unreachable.
Connecting to google.com|173.194.65.102|:80... connected.
HTTP request sent, awaiting response... 302 Found
Location: http://www.google.nl/?gfe_rd=cr&ei=pL5lVsbhOpGwOvj-nUg [following]
--2015-12-07 17:15:16--  
http://www.google.nl/?gfe_rd=cr&ei=pL5lVsbhOpGwOvj-nUg
Resolving www.google.nl... 2a00:1450:4013:c00::5e, 173.194.65.94
Connecting to www.google.nl|2a00:1450:4013:c00::5e|:80... failed: Network 
is unreachable.
Connecting to www.google.nl|173.194.65.94|:80... connected.
HTTP request sent, awaiting response... 200 OK
Length: unspecified [text/html]
Saving to: 'index.html.1'

index.html.1   [ <=>
 ]  
18.59K  --.-KB/s   in 0.03s  

2015-12-07 17:15:17 (590 KB/s) - 'index.html.1' saved [19036]

# wget google.com
--2015-12-07 17:17:41--  http://google.com/
Resolving google.com... 2a00:1450:4013:c00::8b, 173.194.65.113, 
173.194.65.102, ...
Connecting to google.com|2a00:1450:4013:c00::8b|:80... failed: Network is 
unreachable.
Connecting to google.com|173.194.65.113|:80... connected.
HTTP request sent, awaiting response... 302 Found
Location: http://www.google.nl/?gfe_rd=cr&ei=Nr9lVqvUBIyOOpHGhnA [following]
--2015-12-07 17:17:41--  
http://www.google.nl/?gfe_rd=cr&ei=Nr9lVqvUBIyOOpHGhnA
Resolving www.google.nl... 2a00:1450:4013:c00::5e, 173.194.65.94
Connecting to www.google.nl|2a00:1450:4013:c00::5e|:80... failed: Network 
is unreachable.
Connecting to www.google.nl|173.194.65.94|:80... connected.
HTTP request sent, awaiting response... 200 OK
Length: unspecified [text/html]
Saving to: 'index.html.2'

index.html.2   [ <=>
 ]  
18.68K  --.-KB/s   in 0.01s  

2015-12-07 17:17:42 (1.54 MB/s) - 'index.html.2' saved [19132]

# wget -t 1 -T 1 www.google.com
--2015-12-07 17:18:04--  http://www.google.com/
Resolving www.google.com... 2a00:1450:4013:c00::93, 173.194.65.103, 
173.194.65.99, ...
Connecting to www.google.com|2a00:1450:4013:c00::93|:80... failed: Network 
is unreachable.
Connecting to www.google.com|173.194.65.103|:80... connected.
HTTP request sent, awaiting response... 302 Found
Location: http://www.google.nl/?gfe_rd=cr&ei=Tb9lVtaAA8mvOrmhisgG 
[following]
--2015-12-07 17:18:04--  
http://www.google.nl/?gfe_rd=cr&ei=Tb9lVtaAA8mvOrmhisgG
Resolving www.google.nl... 2a00:1450:4013:c00::5e, 173.194.65.94
Connecting to www.google.nl|2a00:1450:4013:c00::5e|:80... failed: Network 
is unreachable.
Connecting to www.google.nl|173.194.65.94|:80... connected.
HTTP request sent, awaiting response... 200 OK
Length: unspecified [text/html]
Saving to: 'index.html.3'

index.html.3   [ <=>
 ]  
18.68K  --.-KB/s   in 0.01s  

2015-12-07 17:18:05 (1.25 MB/s) - 'index.html.3' saved [19133]

#
```

Waiting for your feedback on your tests.

Cheers,
Wilder



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Implement Quota service

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/768#issuecomment-162601030
  
@agneya2001 thanks, squashing the change and pushing now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Implement Quota service

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/768#issuecomment-162601662
  
@remibergsma LGTM, final issue fixed. Let's merge now!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Adapted HypervisorUtilsTest to no longer ...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1185#issuecomment-162603163
  
Good idea. @nlivens please open the same patch/PR again 4.6 branch, thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9106 - As a Developer I want t...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/1184#issuecomment-162611887
  
Although it worked manually, I'm running the test again... in an brand new 
DC.

```
nosetests --with-marvin 
--marvin-config=/data/shared/marvin/mct-zone2-kvm2-ISOLATED.cfg -s -a 
tags=advanced,required_hardware=true component/test_routers_network_ops.py
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8968: UI icon over VM snapshot...

[nitin-maharana]

Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/1150#issuecomment-162612180
  
@bhaisaab @DaanHoogland I updated the change with current 4.6 branch and 
removed the commented codes. @remibergsma This only supports in VMware. Thanks 
:) 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8858: listVolumes API fails fo...

[sureshanaparti]

Github user sureshanaparti commented on the pull request:

https://github.com/apache/cloudstack/pull/830#issuecomment-162612642
  
@ustcweizhou , Yes. I agree. In case on instance id, vm_state is not null.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Implement Quota service

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/768


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9106 - As a Developer I want t...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1184#issuecomment-162614546
  
Went through the code. Looks Good To Me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---