Re: Feature freeze ACS 4.7 next Monday
I'm loving it! Hopefully the rVPC Private Gateway will be fixed within the next hour! Few things were not anticipated on the Java side of the code. I have already refactored the NicProfileHelper and some other classes. Deploying a DC and will test it soon. Cheers, Wilder Sent from my iPhone > On 04 Dec 2015, at 23:58, Remi Bergsma wrote: > > Hi all, > > Next Monday we'll feature freeze for our upcoming 4.7 release. We looked > through all open Pull Requests and below is our "whish list" to get in 4.7. > Feel free to nominate any other changes that should go in 4.7. No guarantees, > there is limited time so only PRs that we actively work on will make it. > > The RC of 4.7.0 is scheduled for Monday Dec 14th so that we all will have a > nice Christmas present ;-) > > Please help us review these PRs. Most have already had some review and when > we can reach 2xLGTM we can include them in 4.7 on time and make another great > release. > > Happy testing and reviewing! > > Regards, > Daan & Remi > > > Features & Fixes PRs: > > Quota > https://github.com/apache/cloudstack/pull/768 > > Logging enhancement > https://github.com/apache/cloudstack/pull/1167 > > VMware diskcontrollers > https://github.com/apache/cloudstack/pull/1132 > > ACS allows to create isolated networks with invalid gateway ip > https://github.com/apache/cloudstack/pull/1125 > > Update nic IP address of stopped vm > https://github.com/apache/cloudstack/pull/1086 > > Hypervisor changes to support UserData for Nuage VSP > https://github.com/apache/cloudstack/pull/1142 > > Support shared networking in NiciraNVP Plugin > https://github.com/apache/cloudstack/pull/1094 > > Strongswan vpn feature > https://github.com/apache/cloudstack/pull/872 > > VM Snapshotting implementation for KVM > https://github.com/apache/cloudstack/pull/977 > > Redundant VPC improvement > (PR will follow over the weekend) > > > UI PRs: > > [UI] fix bug: Cannot delete SSH keypairs in projects > https://github.com/apache/cloudstack/pull/1154 > > UI icon over VM snapshot to deploy user instance > https://github.com/apache/cloudstack/pull/1150 > > Newly added project is not showing in the drop down until the browser is > refreshed > https://github.com/apache/cloudstack/pull/1082
[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...
Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1094#issuecomment-162187421 Hi @remibergsma @miguelaferreira I've been working in marvin test file to cover this new features, those are test03 y test04 in test/integration/smoke/test_nicira_controller.py I attach my test results: ``` $ cat /tmp/MarvinLogs/test_nicira_controller_1Z39R8/results.txt test_01_nicira_controller (integration.smoke.test_nicira_controller.TestNiciraContoller) ... === TestName: test_01_nicira_controller | Status : SUCCESS === ok Nicira clusters will redirect clients (in this case ACS) to the master node. ... === TestName: test_02_nicira_controller_redirect | Status : SUCCESS === ok Shared Networks Support ... === TestName: test_03_nicira_shared_networks_numerical_vlanid | Status : SUCCESS === ok # Shared Networks Support ... === TestName: test_04_nicira_shared_networks_lrouter_uuid_vlan_id | Status : SUCCESS === ok -- Ran 4 tests in 1415.297s OK ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Quota
Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/768#issuecomment-162211091 I will review the code later today/this evening. I will also verify that all of our known issues have been addressed. > On Dec 4, 2015, at 6:13 PM, Remi Bergsma wrote: > > @bhaisaab @abhinandanprateek Just tested again. It's cool, the UI tweaks are very nice. Much better, I like it! > > I can also confirm the menu option is not shown when the plugin is disabled (which is the default). Once you enable it, restart mgt server, it appears and looks like the screenshot above. > > @jburwell Since you did the code review I'd like to hear from you if you are all OK as it is right now. Once you give your OK, I will proceed and merge it. I will make sure this will be included in 4.7. > > Great work guys! > > â > Reply to this email directly or view it on GitHub. > --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/1094#issuecomment-162211138 I'm finishing my own test, and will test this PR asap. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Default route is not configured on Redundant VPC VR (tier 2)
Hi all. My environment: CloudStack 4.6.1 http://packages.shapeblue.com/cloudstack/upstream/centos7/4.6/ Hypervisor CentOS7/KVM SystemVM http://cloudstack.apt-get.eu/systemvm/4.6/systemvm64template-4.6.0-kvm.qcow2.bz2 Steps to reproduce: 1)Create VPC (Redundant VPC offering) 2)Create tier1 & tier2 3)Create VM Instance on tier1 & tier2 4)Check VPC VR IP Address (no problem) root@r-9-VM:~# ip a 1: lo: mtu 16436 qdisc noqueue state UNKNOWN link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00 inet 127.0.0.1/8 scope host lo 2: eth0: mtu 1500 qdisc pfifo_fast state UP qlen 1000 link/ether 0e:00:a9:fe:00:9a brd ff:ff:ff:ff:ff:ff inet 169.254.0.154/16 brd 169.254.255.255 scope global eth0 3: eth1: mtu 1500 qdisc pfifo_fast state UP qlen 1000 link/ether 06:ac:80:00:00:21 brd ff:ff:ff:ff:ff:ff inet 10.0.1.102/24 brd 10.0.1.255 scope global eth1 inet 10.0.1.103/24 brd 10.0.1.255 scope global secondary eth1 4: eth2: mtu 1500 qdisc pfifo_fast state UP qlen 1000 link/ether 02:00:7f:b8:00:05 brd ff:ff:ff:ff:ff:ff inet 172.16.0.67/24 brd 172.16.0.255 scope global eth2 inet 172.16.0.1/24 brd 172.16.0.255 scope global secondary eth2 5: eth3: mtu 1500 qdisc pfifo_fast state UP qlen 1000 link/ether 02:00:03:56:00:04 brd ff:ff:ff:ff:ff:ff inet 172.16.1.25/24 brd 172.16.1.255 scope global eth3 inet 172.16.1.1/24 brd 172.16.1.255 scope global secondary eth3 root@r-9-VM:~# root@r-10-VM:~# ip a 1: lo: mtu 16436 qdisc noqueue state UNKNOWN link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00 inet 127.0.0.1/8 scope host lo 2: eth0: mtu 1500 qdisc pfifo_fast state UP qlen 1000 link/ether 0e:00:a9:fe:00:49 brd ff:ff:ff:ff:ff:ff inet 169.254.0.73/16 brd 169.254.255.255 scope global eth0 3: eth1: mtu 1500 qdisc noop state DOWN qlen 1000 link/ether 06:ac:80:00:00:21 brd ff:ff:ff:ff:ff:ff inet 10.0.1.102/24 brd 10.0.1.255 scope global eth1 inet 10.0.1.103/24 brd 10.0.1.255 scope global secondary eth1 4: eth2: mtu 1500 qdisc pfifo_fast state UP qlen 1000 link/ether 02:00:19:11:00:06 brd ff:ff:ff:ff:ff:ff inet 172.16.0.233/24 brd 172.16.0.255 scope global eth2 5: eth3: mtu 1500 qdisc pfifo_fast state UP qlen 1000 link/ether 02:00:20:19:00:05 brd ff:ff:ff:ff:ff:ff inet 172.16.1.231/24 brd 172.16.1.255 scope global eth3 root@r-10-VM:~# 5)Reboot VPC VR r-9-VM 6)Check VPC VR IP Address (no problem) root@r-9-VM:~# ip a 1: lo: mtu 16436 qdisc noqueue state UNKNOWN link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00 inet 127.0.0.1/8 scope host lo 2: eth0: mtu 1500 qdisc pfifo_fast state UP qlen 1000 link/ether 0e:00:a9:fe:01:28 brd ff:ff:ff:ff:ff:ff inet 169.254.1.40/16 brd 169.254.255.255 scope global eth0 3: eth1: mtu 1500 qdisc noop state DOWN qlen 1000 link/ether 06:ac:80:00:00:21 brd ff:ff:ff:ff:ff:ff inet 10.0.1.103/24 brd 10.0.1.255 scope global eth1 inet 10.0.1.102/24 brd 10.0.1.255 scope global secondary eth1 4: eth2: mtu 1500 qdisc pfifo_fast state UP qlen 1000 link/ether 02:00:7f:b8:00:05 brd ff:ff:ff:ff:ff:ff inet 172.16.0.67/24 brd 172.16.0.255 scope global eth2 5: eth3: mtu 1500 qdisc pfifo_fast state UP qlen 1000 link/ether 02:00:03:56:00:04 brd ff:ff:ff:ff:ff:ff inet 172.16.1.25/24 brd 172.16.1.255 scope global eth3 root@r-9-VM:~# root@r-10-VM:~# ip a 1: lo: mtu 16436 qdisc noqueue state UNKNOWN link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00 inet 127.0.0.1/8 scope host lo 2: eth0: mtu 1500 qdisc pfifo_fast state UP qlen 1000 link/ether 0e:00:a9:fe:00:49 brd ff:ff:ff:ff:ff:ff inet 169.254.0.73/16 brd 169.254.255.255 scope global eth0 3: eth1: mtu 1500 qdisc pfifo_fast state UP qlen 1000 link/ether 06:ac:80:00:00:21 brd ff:ff:ff:ff:ff:ff inet 10.0.1.102/24 brd 10.0.1.255 scope global eth1 inet 10.0.1.103/24 brd 10.0.1.255 scope global secondary eth1 4: eth2: mtu 1500 qdisc pfifo_fast state UP qlen 1000 link/ether 02:00:19:11:00:06 brd ff:ff:ff:ff:ff:ff inet 172.16.0.233/24 brd 172.16.0.255 scope global eth2 inet 172.16.0.1/24 brd 172.16.0.255 scope global secondary eth2 5: eth3: mtu 1500 qdisc pfifo_fast state UP qlen 1000 link/ether 02:00:20:19:00:05 brd ff:ff:ff:ff:ff:ff inet 172.16.1.231/24 brd 172.16.1.255 scope global eth3 inet 172.16.1.1/24 brd 172.16.1.255 scope global secondary eth3 root@r-10-VM:~# 7)Reboot VPC VR r-10-VM 8)Check VPC VR IP Address (problem) Default route is not configured on Redundant VPC VR (tier 2) Missing 172.16.1.1 at eth3. root@r-9-VM:~# ip a 1: lo: mtu 16436 qdisc noqueue state UNKNOWN link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00 inet 127.0.0.1/8 scope host lo 2: eth0: mtu 1500 qdisc pfifo_fast state UP qlen 1000 link/ether 0e:00:a9:fe:01:28 brd ff:ff:ff:ff:ff:ff inet 169.254.1.40/16 brd 169.254.255.255 scope global eth0 3: eth1: mtu 1500 qdisc pfifo_fast state UP qlen 1000 link/ether 06:ac:80:00:00:21 brd ff:ff:ff:ff:ff:ff in
[GitHub] cloudstack pull request: Prevent live-lock in NSX API client
GitHub user miguelaferreira opened a pull request: https://github.com/apache/cloudstack/pull/1178 Prevent live-lock in NSX API client The NSX api client relies on a sequence of responses to identify the need to authenticate and to follow redirects. In order to avoid live-locks, the NSX API client has a counter that will abort the execution after 5 consecutive requests that do not produce a Success (200) response. When a NSX controller enters a faulty state it can allow authentication requests but deny any other API call. In such cases the NSX API client will consider the denied request a reason to follow a redirect and will enter into a live-lock (because the actual redirection is not happening). This PR changes the NSX API client to no reset it's counter on a Success response from an authentication request. That is, the counter is only reset if another type of API call yields a Success response. In addition, this PR also: * changes the configuration of the license-maven-plugin to ignore files generated by pmd * moves the NSX marvin test to a plugins folder * refactors the NSX marvin test to reduce duplication * adds an extra test case to the NSX marvin test that checks that NSX tunnels are properly created You can merge this pull request into a Git repository by running: $ git pull https://github.com/miguelaferreira/cloudstack nsx-livelock Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1178.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1178 commit d248e61a3128fe285a18c9836d1c7d18b5b946e9 Author: Miguel Ferreira Date: 2015-12-02T13:53:26Z Add test for NSX plugin that simulates a live lock commit cfe14462a3380c053ad174e0016632e6024e3573 Author: Miguel Ferreira Date: 2015-12-02T13:53:56Z Fix NSX rest client to not reset execution counter after a login commit 86e836196ed3374912da805f598961b3fe9c9033 Author: Miguel Ferreira Date: 2015-12-02T14:42:38Z Ignore pmd generated files during license check This has been happening for the NSX and BigSwitch plugins. The maven build prints something like: [WARNING] Unknown file extension: .../plugins/network-elements/nicira-nvp/.pmd [WARNING] Missing header in: .../plugins/network-elements/nicira-nvp/.pmdruleset.xml commit bafc2313bb872efa07c01dca2fdff4bec9b8dbb6 Author: Miguel Ferreira Date: 2015-12-04T10:40:09Z Move NSX integrationt test to new plugins folder commit 1e820e3906023ae43dbd3f01d632fbef5bb77430 Author: Miguel Ferreira Date: 2015-12-04T10:46:08Z Use logger to print debug messages during test commit a633ef811324a8dbf868c85922235c16a08cb1a0 Author: Miguel Ferreira Date: 2015-12-04T11:10:55Z Refactor test cases to reduce duplication commit 811f254e4ddcc8de0bc0375f35783eea4e04ef6d Author: Miguel Ferreira Date: 2015-12-05T14:51:07Z Test NSX tunnel in guest network --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Prevent live-lock in NSX API client
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/1178#issuecomment-162225661 As for testing, I've built the entire project executing all unit tests (including the one I've added to prevent a regression on this issue), the existing marvin tests and a new one that checks that a VM in a NSX backed network has connectivity via a NSX managed tunnel between two hosts. maven build: ```bash mvn clean install -T4 -Pdeveloper,systemvm (...) [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 08:43 min (Wall Clock) [INFO] Finished at: 2015-12-05T18:27:47+01:00 [INFO] Final Memory: 110M/1614M [INFO] ``` marvin tests: ```bash nosetests --with-marvin --marvin-config=mct-zone1-kvm1-kvm2-NVP.cfg -s -a tags=advanced,required_hardware=true test/integration/plugins/test_nicira_controller.py (...) === TestName: test_01_nicira_controller | Status : SUCCESS === ok === TestName: test_02_nicira_controller_redirect | Status : SUCCESS === ok === TestName: test_03_nicira_tunnel_guest_network | Status : SUCCESS === ok -- Ran 3 tests in 1204.495s OK ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Prevent live-lock in NSX API client
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/1178#issuecomment-162225746 ping @nvazquez would you be able to test this PR? The new marvin test I added requires two hosts in order to test the NSX tunnel between them. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8852 Database shows that manag...
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/840#issuecomment-162229695
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
component/test_routers_iptables_default_policy.py \
component/test_routers_network_ops.py \
component/test_vpc_router_nics.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_network.py
```
Result:
```
Create a redundant VPC with two networks with two VMs in each network ...
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status :
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and
check default routes ... === TestName: test_02_redundant_VPC_default_routes |
Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ...
=== TestName:
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Status :
SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName:
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... ===
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status :
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check the password file in the Router VM ... === TestName:
test_isolate_network_password_server | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... ===
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName:
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName:
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName:
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... ===
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80
| Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status :
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status :
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS
===
ok
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn
| Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : SUCCESS
===
ok
Test for port forwarding on source NAT ... === TestName:
test_01_port_fwd_on_src_nat | Status : SUCCESS ===
ok
Test for port forwarding on non source NAT ... === TestName:
test_02_port_fwd_on_non_src_nat | Status : SUCCESS ===
ok
Test for reboot router ... === TestName: test_reboot_router | Status :
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... ===
TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status :
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... ===
TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : SUCCESS
===
[GitHub] cloudstack pull request: CLOUDSTACK-8976 - Sorting of security gro...
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/937 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8852 Database shows that manag...
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/840 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CID-1338387: Deletion of method endPointS...
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1124#issuecomment-162230888
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
component/test_routers_iptables_default_policy.py \
component/test_routers_network_ops.py \
component/test_vpc_router_nics.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_network.py
```
Result:
```
Create a redundant VPC with two networks with two VMs in each network ...
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status :
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and
check default routes ... === TestName: test_02_redundant_VPC_default_routes |
Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ...
=== TestName:
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Status :
SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName:
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... ===
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status :
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check the password file in the Router VM ... === TestName:
test_isolate_network_password_server | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... ===
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName:
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName:
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName:
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... ===
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80
| Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status :
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status :
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS
===
ok
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn
| Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : SUCCESS
===
ok
Test for port forwarding on source NAT ... === TestName:
test_01_port_fwd_on_src_nat | Status : SUCCESS ===
ok
Test for port forwarding on non source NAT ... === TestName:
test_02_port_fwd_on_non_src_nat | Status : SUCCESS ===
ok
Test for reboot router ... === TestName: test_reboot_router | Status :
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... ===
TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status :
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... ===
TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : SUCCESS
===
[GitHub] cloudstack pull request: CLOUDSTACK-9025: Fixed can't create usabl...
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1176#issuecomment-162231182
Run the tests again and it looks good.
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
component/test_routers_iptables_default_policy.py \
component/test_routers_network_ops.py \
component/test_vpc_router_nics.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_network.py
```
Result:
```
Create a redundant VPC with two networks with two VMs in each network ...
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status :
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and
check default routes ... === TestName: test_02_redundant_VPC_default_routes |
Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ...
=== TestName:
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Status :
SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName:
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... ===
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status :
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check the password file in the Router VM ... === TestName:
test_isolate_network_password_server | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... ===
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName:
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName:
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName:
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... ===
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80
| Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status :
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status :
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS
===
ok
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn
| Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : SUCCESS
===
ok
Test for port forwarding on source NAT ... === TestName:
test_01_port_fwd_on_src_nat | Status : SUCCESS ===
ok
Test for port forwarding on non source NAT ... === TestName:
test_02_port_fwd_on_non_src_nat | Status : SUCCESS ===
ok
Test for reboot router ... === TestName: test_reboot_router | Status :
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... ===
TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status :
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... ===
TestName: test_network_rules_acquir
[GitHub] cloudstack pull request: CLOUDSTACK-9025: Fixed can't create usabl...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1176#issuecomment-162231372 @anshul1886 Please address comments made above. After that we can merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Prevent live-lock in NSX API client
Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1178#issuecomment-162231638 Ok, I'll post results later --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Removed the PlannerBase class because it ...
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1108#issuecomment-162231828
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
component/test_routers_iptables_default_policy.py \
component/test_routers_network_ops.py \
component/test_vpc_router_nics.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_network.py
```
Result:
```
Create a redundant VPC with two networks with two VMs in each network ...
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status :
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and
check default routes ... === TestName: test_02_redundant_VPC_default_routes |
Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ...
=== TestName:
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Status :
SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName:
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... ===
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status :
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check the password file in the Router VM ... === TestName:
test_isolate_network_password_server | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... ===
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName:
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName:
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName:
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... ===
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80
| Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status :
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status :
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS
===
ok
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn
| Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : SUCCESS
===
ok
Test for port forwarding on source NAT ... === TestName:
test_01_port_fwd_on_src_nat | Status : SUCCESS ===
ok
Test for port forwarding on non source NAT ... === TestName:
test_02_port_fwd_on_non_src_nat | Status : SUCCESS ===
ok
Test for reboot router ... === TestName: test_reboot_router | Status :
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... ===
TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status :
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... ===
TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : SUCCESS
===
[GitHub] cloudstack pull request: Removed the PlannerBase class because it ...
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1108 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8746: VM Snapshotting im...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/977#issuecomment-162232240 @ustcweizhou Can you please rebase and resolve the conflict? I can then run the tests again. @wido @DaanHoogland Do we want this in 4.7? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Strongswan vpn feature
Github user remibergsma commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/872#discussion_r46761289 --- Diff: systemvm/patches/debian/vpn/etc/ipsec.d/l2tp.conf --- @@ -30,4 +33,6 @@ conn L2TP-PSK # -- # Change 'ignore' to 'add' to enable this configuration. # + +rightsubnetwithin=10.1.2.0/8 --- End diff -- @jayapalu Can you respond to these comments please? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9106 - As a Developer I want t...
GitHub user wilderrodrigues opened a pull request: https://github.com/apache/cloudstack/pull/1179 CLOUDSTACK-9106 - As a Developer I want the Redundant VPC private gateway feature fixed This PR fixes the Private Gateway feature when using Redundant VPCs. In order to get it to work, I had to refactor some of the Java code in order to reduce the number of iterations we had with the routers list. It caused an issue when trying to configure ACL rules in a router (the backup one) that did not have the interface setup yet. The rVPC Pvt GW integration test is not being skipped anymore and is 100% green! You can merge this pull request into a Git repository by running: $ git pull https://github.com/ekholabs/cloudstack fix/rvpc-pvtgw-CLOUDSTACK-9106 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1179.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1179 commit ae325f601605c2dec285db621660bacdc2959d4b Author: Wilder Rodrigues Date: 2015-12-04T17:41:03Z CLOUDSTACK-9106 - Reduces the amount of iterations through the routers of a VPC - It was causing problems because Nics were expected to be plugged before they actually exist. Only in rVPC cases. - Applies ACL items to routers only after the Pvt GW is setup. commit 78e15d1cfa27937935f1269c9e9b6ec5a91db08f Author: Wilder Rodrigues Date: 2015-12-05T13:03:50Z CLOUDSTACK-9106 - Refactor the createPrivateNicProfileForGateway() method - Use the router to retrieve the instance ID - Check if the VPC is redundant in order to reuse the private gateway address. - Brings the private gateways interfaces up. commit 6dab3613e475aac524e448f0d52fe575fbdf5e23 Author: Wilder Rodrigues Date: 2015-12-05T16:33:55Z CLOUDSTACK-9106 - Enables private gateway tests on Redundant VPCs --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9106 - As a Developer I want t...
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1179#issuecomment-162233742 Ping @remibergsma @DaanHoogland @bhaisaab @karuturi @borisroman @miguelaferreira Could you please review this PR? I will execute more tests now. * Environment * Hardware required: TRUE * Management Server + MySQL on CentOS 7.1 * One KVM Host on CentOS 7.1 * Agent + Common RPMs built from source * Test executed ``` nosetests --with-marvin --marvin-config=/data/shared/marvin/mct-zone2-kvm2-ISOLATED.cfg -s -a tags=advanced,required_hardware=true smoke/test_privategw_acl.py ``` * Results ``` test_01_vpc_privategw_acl (integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName: test_01_vpc_privategw_acl | Status : SUCCESS === ok test_02_vpc_privategw_static_routes (integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName: test_02_vpc_privategw_static_routes | Status : SUCCESS === ok test_03_rvpc_privategw_static_routes (integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName: test_03_rvpc_privategw_static_routes | Status : SUCCESS === ok -- Ran 3 tests in 2493.111s OK /tmp//MarvinLogs/test_privategw_acl_V6KWGZ/results.txt (END) ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8746: VM Snapshotting im...
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/977#issuecomment-162234338 Yes we do, it might not be the final solution as per the discussion above but it is an improvement. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9106 - As a Developer I want t...
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1179#issuecomment-162237710 I like the scrum style title but just to be nitpicking: isn't this more of a network engineer feature instead of a developer tool? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9106 - As a Developer I want t...
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1179#discussion_r46761808
--- Diff:
plugins/network-elements/ovs/src/com/cloud/network/element/OvsElement.java ---
@@ -445,13 +446,14 @@ public boolean applyIps(final Network network,
return true;
}
-DataCenterVO dcVO = _dcDao.findById(network.getDataCenterId());
-NetworkTopology networkTopology =
_networkTopologyContext.retrieveNetworkTopology(dcVO);
+final DataCenterVO dcVO =
_dcDao.findById(network.getDataCenterId());
+final NetworkTopology networkTopology =
_networkTopologyContext.retrieveNetworkTopology(dcVO);
-return networkTopology.associatePublicIP(network, ipAddress,
routers);
-} else {
-return false;
+for (final DomainRouterVO domainRouterVO : routers) {
+result = networkTopology.associatePublicIP(network,
ipAddress, domainRouterVO);
--- End diff --
will we forget all intermediate results and only return the last one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9106 - As a Developer I want t...
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1179#discussion_r46761835 --- Diff: plugins/network-elements/ovs/src/com/cloud/network/element/OvsElement.java --- @@ -468,19 +470,23 @@ public boolean applyStaticNats(final Network network, final List
[GitHub] cloudstack pull request: CLOUDSTACK-9106 - As a Developer I want t...
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1179#discussion_r46761845 --- Diff: plugins/network-elements/ovs/src/com/cloud/network/element/OvsElement.java --- @@ -488,50 +494,54 @@ public boolean applyPFRules(final Network network, final List
[GitHub] cloudstack pull request: CLOUDSTACK-9106 - As a Developer I want t...
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1179#issuecomment-162237998 @DaanHoogland Agree... ;) Sometimes I find difficult to wear different hats, although I could do it just fine. Should I change the title here and on the issue? Cheers, Wilder --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9106 - As a Developer I want t...
Github user wilderrodrigues commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1179#discussion_r46761916 --- Diff: plugins/network-elements/ovs/src/com/cloud/network/element/OvsElement.java --- @@ -468,19 +470,23 @@ public boolean applyStaticNats(final Network network, final List
[GitHub] cloudstack pull request: CLOUDSTACK-9106 - As a Developer I want t...
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1179#discussion_r46761920 --- Diff: server/src/com/cloud/network/element/VirtualRouterElement.java --- @@ -509,10 +512,11 @@ public boolean applyIps(final Network network, final List
[GitHub] cloudstack pull request: CLOUDSTACK-9106 - As a Developer I want t...
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1179#discussion_r46761947
--- Diff: server/src/com/cloud/network/element/VirtualRouterElement.java ---
@@ -656,20 +660,22 @@ public static String getHAProxyStickinessCapability()
{
@Override
public boolean applyStaticNats(final Network network, final List rules) throws ResourceUnavailableException {
+boolean result = true;
if (canHandle(network, Service.StaticNat)) {
final List routers =
_routerDao.listByNetworkAndRole(network.getId(), Role.VIRTUAL_ROUTER);
if (routers == null || routers.isEmpty()) {
s_logger.debug("Virtual router elemnt doesn't need to
apply static nat on the backend; virtual " + "router doesn't exist in the
network " + network.getId());
-return true;
+return result;
}
final DataCenterVO dcVO =
_dcDao.findById(network.getDataCenterId());
final NetworkTopology networkTopology =
networkTopologyContext.retrieveNetworkTopology(dcVO);
-return networkTopology.applyStaticNats(network, rules,
routers);
-} else {
-return true;
+for (final DomainRouterVO domainRouterVO : routers) {
+result = networkTopology.applyStaticNats(network, rules,
domainRouterVO);
--- End diff --
&=
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9106 - As a Developer I want t...
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1179#discussion_r46761941 --- Diff: plugins/network-elements/ovs/src/com/cloud/network/element/OvsElement.java --- @@ -468,19 +470,23 @@ public boolean applyStaticNats(final Network network, final List
[GitHub] cloudstack pull request: CLOUDSTACK-9106 - As a Developer I want t...
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1179#discussion_r46761965
--- Diff: server/src/com/cloud/network/element/VirtualRouterElement.java ---
@@ -765,18 +773,23 @@ public boolean saveSSHKey(final Network network,
final NicProfile nic, final Vir
final DataCenterVO dcVO =
_dcDao.findById(network.getDataCenterId());
final NetworkTopology networkTopology =
networkTopologyContext.retrieveNetworkTopology(dcVO);
-return networkTopology.saveSSHPublicKeyToRouter(network, nic,
uservm, routers, sshPublicKey);
+for (final DomainRouterVO domainRouterVO : routers) {
+result = networkTopology.saveSSHPublicKeyToRouter(network,
nic, uservm, domainRouterVO, sshPublicKey);
--- End diff --
&=
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9106 - As a Developer I want t...
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1179#discussion_r46761967
--- Diff: server/src/com/cloud/network/element/VirtualRouterElement.java ---
@@ -751,13 +757,15 @@ public boolean savePassword(final Network network,
final NicProfile nic, final V
@Override
public boolean saveSSHKey(final Network network, final NicProfile nic,
final VirtualMachineProfile vm, final String sshPublicKey) throws
ResourceUnavailableException {
+boolean result = false;
if (!canHandle(network, null)) {
-return false;
+return result;
}
final List routers =
_routerDao.listByNetworkAndRole(network.getId(), Role.VIRTUAL_ROUTER);
if (routers == null || routers.isEmpty()) {
s_logger.debug("Can't find virtual router element in network "
+ network.getId());
-return true;
+result = true;
--- End diff --
huh? why not return true;?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9106 - As a Developer I want t...
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1179#discussion_r46761973
--- Diff: server/src/com/cloud/network/element/VirtualRouterElement.java ---
@@ -841,24 +857,26 @@ public VirtualRouterProvider addElement(final Long
nspId, final Type providerTyp
@Override
public boolean applyPFRules(final Network network, final
List rules) throws ResourceUnavailableException {
+boolean result = false;
if (canHandle(network, Service.PortForwarding)) {
final List routers =
_routerDao.listByNetworkAndRole(network.getId(), Role.VIRTUAL_ROUTER);
if (routers == null || routers.isEmpty()) {
s_logger.debug("Virtual router elemnt doesn't need to
apply firewall rules on the backend; virtual " + "router doesn't exist in the
network " + network.getId());
-return true;
+result = true;
--- End diff --
return true; would work wouldn't it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9106 - As a Developer I want t...
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1179#discussion_r46761989
--- Diff: server/src/com/cloud/network/element/VpcVirtualRouterElement.java
---
@@ -479,48 +482,47 @@ public boolean applyIps(final Network network, final
List routers =
_routerDao.listByNetworkAndRole(network.getId(), Role.VIRTUAL_ROUTER);
if (routers == null || routers.isEmpty()) {
s_logger.debug(getName() + " element doesn't need to
associate ip addresses on the backend; VPC virtual " + "router doesn't exist in
the network "
+ network.getId());
-return true;
+return result;
}
final DataCenterVO dcVO =
_dcDao.findById(network.getDataCenterId());
final NetworkTopology networkTopology =
networkTopologyContext.retrieveNetworkTopology(dcVO);
-return networkTopology.associatePublicIP(network, ipAddress,
routers);
-} else {
-return false;
+for (final DomainRouterVO domainRouterVO : routers) {
+result = networkTopology.associatePublicIP(network,
ipAddress, domainRouterVO);
--- End diff --
result &= ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9106 - As a Developer I want t...
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1179#discussion_r46761996
--- Diff: server/src/com/cloud/network/element/VpcVirtualRouterElement.java
---
@@ -479,48 +482,47 @@ public boolean applyIps(final Network network, final
List routers =
_routerDao.listByNetworkAndRole(network.getId(), Role.VIRTUAL_ROUTER);
if (routers == null || routers.isEmpty()) {
s_logger.debug(getName() + " element doesn't need to
associate ip addresses on the backend; VPC virtual " + "router doesn't exist in
the network "
+ network.getId());
-return true;
+return result;
}
final DataCenterVO dcVO =
_dcDao.findById(network.getDataCenterId());
final NetworkTopology networkTopology =
networkTopologyContext.retrieveNetworkTopology(dcVO);
-return networkTopology.associatePublicIP(network, ipAddress,
routers);
-} else {
-return false;
+for (final DomainRouterVO domainRouterVO : routers) {
+result = networkTopology.associatePublicIP(network,
ipAddress, domainRouterVO);
+}
}
+return result;
}
@Override
public boolean applyNetworkACLs(final Network network, final List rules) throws ResourceUnavailableException {
+boolean result = true;
if (canHandle(network, Service.NetworkACL)) {
final List routers =
_routerDao.listByNetworkAndRole(network.getId(), Role.VIRTUAL_ROUTER);
if (routers == null || routers.isEmpty()) {
s_logger.debug("Virtual router elemnt doesn't need to
apply firewall rules on the backend; virtual " + "router doesn't exist in the
network " + network.getId());
-return true;
+return result;
}
final DataCenterVO dcVO =
_dcDao.findById(network.getDataCenterId());
final NetworkTopology networkTopology =
networkTopologyContext.retrieveNetworkTopology(dcVO);
-try {
-if (!networkTopology.applyNetworkACLs(network, rules,
routers, false)) {
-return false;
-} else {
-return true;
+for (final DomainRouterVO domainRouterVO : routers) {
+try {
+result = networkTopology.applyNetworkACLs(network,
rules, domainRouterVO, false);
--- End diff --
result &=
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9106 - As a Developer I want t...
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1179#issuecomment-162243159 Wilder can this one be on 4.6 please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Removal of class AgentBasedStandaloneCons...
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/855#issuecomment-162243277 @anshul1886 I trust you are alright with this change in comment, are you? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8845: Fixed list snapshots com...
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/1166#issuecomment-162249766 @anshul1886 Can you please close this PR or will you change to almost same to #1168 ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9106 - As a Developer I want t...
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1179#discussion_r46765484
--- Diff: server/src/com/cloud/network/element/VirtualRouterElement.java ---
@@ -751,13 +757,15 @@ public boolean savePassword(final Network network,
final NicProfile nic, final V
@Override
public boolean saveSSHKey(final Network network, final NicProfile nic,
final VirtualMachineProfile vm, final String sshPublicKey) throws
ResourceUnavailableException {
+boolean result = false;
if (!canHandle(network, null)) {
-return false;
+return result;
}
final List routers =
_routerDao.listByNetworkAndRole(network.getId(), Role.VIRTUAL_ROUTER);
if (routers == null || routers.isEmpty()) {
s_logger.debug("Can't find virtual router element in network "
+ network.getId());
-return true;
+result = true;
--- End diff --
Because I do not want to return a literal. And the same for the other
comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9106 - As a Developer I want t...
Github user wilderrodrigues commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1179#discussion_r46765516 --- Diff: plugins/network-elements/ovs/src/com/cloud/network/element/OvsElement.java --- @@ -488,50 +494,54 @@ public boolean applyPFRules(final Network network, final List
[GitHub] cloudstack pull request: CLOUDSTACK-9106 - As a Developer I want t...
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1179#issuecomment-162262512 More tests... On the same environment, but with hardware TRUE. ``` Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: test_02_routervm_iptables_policies | Status : SUCCESS === ok Test iptables default INPUT/FORWARD policies on VPC router ... === TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS === ok Test redundant router internals ... === TestName: test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS === ok Test redundant router internals ... === TestName: test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS === ok Test redundant router internals ... === TestName: test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS === ok Test redundant router internals ... === TestName: test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS === ok Create a VPC with two networks with one VM in each network and test nics after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : SUCCESS === ok Create a VPC with two networks with one VM in each network and test default routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS === ok Check the password file in the Router VM ... === TestName: test_isolate_network_password_server | Status : SUCCESS === ok Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... === TestName: test_router_dhcphosts | Status : SUCCESS === ok Test to create Load balancing rule with source NAT ... === TestName: test_01_create_lb_rule_src_nat | Status : SUCCESS === ok Test to create Load balancing rule with non source NAT ... === TestName: test_02_create_lb_rule_non_nat | Status : SUCCESS === ok Test for assign & removing load balancing rule ... === TestName: test_assign_and_removal_lb | Status : SUCCESS === ok Test to verify access to loadbalancer haproxy admin stats page ... === TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS === ok Test create, assign, remove of an Internal LB with roundrobin http traffic to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Status : SUCCESS === ok Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : SUCCESS === ok Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : SUCCESS === ok Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS === ok Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS === ok Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS === ok Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS === ok Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS === ok Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS === ok Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn | Status : SUCCESS === ok Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : SUCCESS === ok Test for port forwarding on source NAT ... === TestName: test_01_port_fwd_on_src_nat | Status : SUCCESS === ok Test for port forwarding on non source NAT ... === TestName: test_02_port_fwd_on_non_src_nat | Status : SUCCESS === ok Test for reboot router ... === TestName: test_reboot_router | Status : SUCCESS === ok Test for Router rules for network rules on acquired public IP ... === TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status : SUCCESS === ok Test for Router rules for network rules on acquired public IP ... === TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : SUCCESS === ok Test for Router rules for network rules on acquired public IP ... === TestName: test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Status : SUCCESS === ok -- Ran 31 tests in 13956.667s OK (END) ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9025: Fixed can't create usabl...
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1176#discussion_r46767279
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/XenServerGuru.java ---
@@ -185,7 +185,8 @@ public boolean trackVmHostChange() {
DataTO srcData = cpyCommand.getSrcTO();
DataTO destData = cpyCommand.getDestTO();
-if (srcData.getObjectType() == DataObjectType.SNAPSHOT &&
destData.getObjectType() == DataObjectType.TEMPLATE) {
+if (srcData.getHypervisorType() == HypervisorType.XenServer &&
srcData.getObjectType() == DataObjectType.SNAPSHOT &&
--- End diff --
@ustcweizhou @bhaisaab I prefer == to equals() method here for two reasons
1) Enum equals() method has same code internally
http://grepcode.com/file/repository.grepcode.com/java/root/jdk/openjdk/6-b14/java/lang/Enum.java#Enum.equals%28java.lang.Object%29
2) This will not result in NullPointerExceptions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8845: Fixed list snapshots com...
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/1166#issuecomment-162284129 @ustcweizhou Closing this PR as #1168 fixes the same issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8845: Fixed list snapshots com...
Github user anshul1886 closed the pull request at: https://github.com/apache/cloudstack/pull/1166 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Removal of class AgentBasedStandaloneCons...
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/855#issuecomment-162284601 LGTM. I am ok with this change. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
