[GitHub] cloudstack pull request: CLOUDSTACK-8840: Systemd service for the ...

2015-09-17 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/820


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8805: Domains become inactive ...

2015-09-17 Thread nitin-maharana
Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/790#issuecomment-140999446
  
@remibergsma Yes this one should be closed. PR #775 does the same thing. 
Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8805: Domains become inactive ...

2015-09-17 Thread nitin-maharana
Github user nitin-maharana closed the pull request at:

https://github.com/apache/cloudstack/pull/790


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: VPC router issue

2015-09-17 Thread Wilder Rodrigues
Hi Rajani,


The last commit from 8 September works: 
https://github.com/apache/cloudstack/commit/5e9e9b84fb1a4ca029c32e5b1c305124bfa4d4af

The merge commit just before the 5e9e9b does NOT work: 
https://github.com/apache/cloudstack/commit/237e0e4611dd3d0ae56a8c0557dba93e7fbd3440

And the commit before it WORKS: 
https://github.com/apache/cloudstack/commit/30792532ed0f3f0622ac3ef6856d9b7d7a48d1d0.
 That’s the commit of PR #777, which is the parent of PR #765

So I believe we have a good candidate! The fix for CLOUDSTACK-8688 on PR #765.

Apologies for the problems caused by the fix, although nobody complained except 
myself.

I will proceed with creating a blocker issue and fixing the problem.

Chers,
Wilder


On 16 Sep 2015, at 10:47, Rajani Karuturi 
mailto:rajani.karut...@citrix.com>> wrote:

Raja,
Do you know the commit ids between the last successful and first failed builds?

~Rajani



On 16-Sep-2015, at 10:05 am, Raja Pullela 
mailto:raja.pull...@citrix.com>> wrote:

Hi Wilder,   BTW, I just checked my setup and it was passing on Sep 9th and was 
regressed after that.

Thanks for checking this out,
Raja
-Original Message-
From: Wilder Rodrigues [mailto:wrodrig...@schubergphilis.com]
Sent: Tuesday, September 15, 2015 7:12 PM
To: dev@cloudstack.apache.org
Cc: Remi Bergsma 
mailto:rberg...@schubergphilis.com>>; Rohit Yadav 
mailto:rohit.ya...@shapeblue.com>>; Rajani Karuturi 
mailto:raj...@apache.org>>; Daan Hoogland 
mailto:daan.hoogl...@gmail.com>>
Subject: Re: VPC router issue

6 days ago test_pc_routers.py succeeded with  PR 788:

https://github.com/apache/cloudstack/pull/788

It’s in the test results I put there.

I’m now testing Master to verify if it’s still occurring there. I tested the PR 
#808 (https://github.com/apache/cloudstack/pull/805), which had a bunch of 
tests executed against, but not the test_vpc_routers, and there it fails.

So, the problem occurred between 788 and 805.

Will keep digging.

Cheers,
Wilder


On 15 Sep 2015, at 14:18, Wilder Rodrigues 
mailto:wrodrig...@schubergphilis.com>> wrote:

Hi all,

This morning I shared a message on our Slack channel about the current issue 
I’m facing with VPC routers. The problem was caught by the test_vpc_routers.py 
tests, which are unable to verify the following:

* Create a VPC with 2 Tiers, 3 VMs, 2Pub IPs, and 1 ACL
* Stop the VPC router
* Start the VPC router

I have been busy trying to figure out when it stopped working when I then 
stopped at commit 
https://github.com/apache/cloudstack/commit/f5e5f4d0026f8ffd6f3aa7e8e4c7be0cd809d6c9
 - although it’s not really the one causing the issue given what I have changed 
there.

The only way to get it working is by restarting the VPC with the cleanup option 
- os destroying the VPC router and just restarting the VPC.

Since not many people have been testing the routers as much as I do, it seems 
no one is aware of this issue.

Long story short: current master is broken.

/me digging through PRs to find the root cause.

Cheers,
Wilder





Re: VPC router issue

2015-09-17 Thread Wilder Rodrigues
Issue is here: https://issues.apache.org/jira/browse/CLOUDSTACK-8878

Cheers,
Wilder

On 17 Sep 2015, at 10:14, Wilder Rodrigues 
mailto:wrodrig...@schubergphilis.com>> wrote:

Hi Rajani,


The last commit from 8 September works: 
https://github.com/apache/cloudstack/commit/5e9e9b84fb1a4ca029c32e5b1c305124bfa4d4af

The merge commit just before the 5e9e9b does NOT work: 
https://github.com/apache/cloudstack/commit/237e0e4611dd3d0ae56a8c0557dba93e7fbd3440

And the commit before it WORKS: 
https://github.com/apache/cloudstack/commit/30792532ed0f3f0622ac3ef6856d9b7d7a48d1d0.
 That’s the commit of PR #777, which is the parent of PR #765

So I believe we have a good candidate! The fix for CLOUDSTACK-8688 on PR #765.

Apologies for the problems caused by the fix, although nobody complained except 
myself.

I will proceed with creating a blocker issue and fixing the problem.

Chers,
Wilder


On 16 Sep 2015, at 10:47, Rajani Karuturi 
mailto:rajani.karut...@citrix.com>>
 wrote:

Raja,
Do you know the commit ids between the last successful and first failed builds?

~Rajani



On 16-Sep-2015, at 10:05 am, Raja Pullela 
mailto:raja.pull...@citrix.com>>
 wrote:

Hi Wilder,   BTW, I just checked my setup and it was passing on Sep 9th and was 
regressed after that.

Thanks for checking this out,
Raja
-Original Message-
From: Wilder Rodrigues [mailto:wrodrig...@schubergphilis.com]
Sent: Tuesday, September 15, 2015 7:12 PM
To: 
dev@cloudstack.apache.org
Cc: Remi Bergsma 
mailto:rberg...@schubergphilis.com>>;
 Rohit Yadav 
mailto:rohit.ya...@shapeblue.com>>;
 Rajani Karuturi 
mailto:raj...@apache.org>>; Daan 
Hoogland 
mailto:daan.hoogl...@gmail.com>>
Subject: Re: VPC router issue

6 days ago test_pc_routers.py succeeded with  PR 788:

https://github.com/apache/cloudstack/pull/788

It’s in the test results I put there.

I’m now testing Master to verify if it’s still occurring there. I tested the PR 
#808 (https://github.com/apache/cloudstack/pull/805), which had a bunch of 
tests executed against, but not the test_vpc_routers, and there it fails.

So, the problem occurred between 788 and 805.

Will keep digging.

Cheers,
Wilder


On 15 Sep 2015, at 14:18, Wilder Rodrigues 
mailto:wrodrig...@schubergphilis.com>> wrote:

Hi all,

This morning I shared a message on our Slack channel about the current issue 
I’m facing with VPC routers. The problem was caught by the test_vpc_routers.py 
tests, which are unable to verify the following:

* Create a VPC with 2 Tiers, 3 VMs, 2Pub IPs, and 1 ACL
* Stop the VPC router
* Start the VPC router

I have been busy trying to figure out when it stopped working when I then 
stopped at commit 
https://github.com/apache/cloudstack/commit/f5e5f4d0026f8ffd6f3aa7e8e4c7be0cd809d6c9
 - although it’s not really the one causing the issue given what I have changed 
there.

The only way to get it working is by restarting the VPC with the cleanup option 
- os destroying the VPC router and just restarting the VPC.

Since not many people have been testing the routers as much as I do, it seems 
no one is aware of this issue.

Long story short: current master is broken.

/me digging through PRs to find the root cause.

Cheers,
Wilder






[GitHub] cloudstack pull request: CLOUDSTACK-8843: Fixed issue in default i...

2015-09-17 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/842#issuecomment-141001813
  
Thanks, @jayapalu 

I will try to take some time today to test your PR.

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8872: Replaced all occurences ...

2015-09-17 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/832#issuecomment-141002870
  
Thanks, @borisroman ! :)

I will have a look at your PR again later today.

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Cloudstack 8868: use PasswordGenerator.ge...

2015-09-17 Thread wido
Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/841#issuecomment-141004554
  
@karuturi I think that 8 is a good thing, that brings in much more 
combinations. Maybe even 10?

And I agree with @bhaisaab, no more global settings :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8867: Added retry logic to rec...

2015-09-17 Thread wido
Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/835#issuecomment-141004854
  
I agree with @DaanHoogland That should be unit tested.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8805: Domains become inactive ...

2015-09-17 Thread nitin-maharana
Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/775#issuecomment-141015775
  
@DaanHoogland, @rafaelweingartner Yes I understand, I also think there 
should be test cases for a change because we don't know the entire logic. As 
there is not enough docs in java files. Any inputs from yourside on how to 
write the unit tests will be very helpful. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: [4.6][BLOCKER]CLOUDSTACK-8763: Resolved P...

2015-09-17 Thread borisroman
Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/845#issuecomment-141022408
  
@remibergsma @wilderrodrigues @karuturi Please review!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...

2015-09-17 Thread DaanHoogland
Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/829#issuecomment-141050957
  
If @remibergsma is right then the design is really broken. two events come 
in during migration:
# PowerOn (or Off or what ever is actual)
# PowerReportMissing (interpreted as whatever, in our present case PowerOff)
The second one should definitely not be interpreted as some other event but 
merits its treatment (handler code) of its own. It should investigate if a 
migration is busy and ignore if it is so. In this case it should have been 
ignored. So the question, @anshul1886, @koushik-das is what other possible 
states yielding a PowerReportMissing event are.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-7985: assignVM in Advanced zon...

2015-09-17 Thread DaanHoogland
Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/844#issuecomment-141051316
  
@ustcweizhou @miguelaferreira @karuturi @remibergsma so no merges till this 
is fixed?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-7985: assignVM in Advanced zon...

2015-09-17 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/844#issuecomment-141052485
  
@ustcweizhou ,

Which tests did you execute?

I would say: no merge until it's fixed, tested by @ustcweizhou and he let 
us know how we should be able to test.

Cheers,
Wilder 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8805: Domains become inactive ...

2015-09-17 Thread DaanHoogland
Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/775#issuecomment-141056052
  
in general: factor out a small chunk of the method into a private method or 
helper class. (commit 1)
then unit test that. (commit 2)
then apply your fix (commit three) bull's eye (hopefully)
In your more particular case @nitin-maharana , I think we don't have the 
test infrastructure to do it.
We need to create it. I am not burdonning you with this but if you want to: 
the replace call you make is in the sql domain and what we'd need is sql unit 
stuff.

I am starting to feel my wearyness is ungrounded but those feeling are 
always dangerous. A replacement of the replace call in java space could make it 
more (read easier) testable. it might have performance ramifications.

that all said; let's discus risk versus priority of this fix. Does anybody 
have ideas on this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: [4.6][BLOCKER]CLOUDSTACK-8763: Resolved P...

2015-09-17 Thread DaanHoogland
Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/845#issuecomment-141057501
  
@borisroman there are no (unit) tests. can you add or describe or at least 
how to prove this fix?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-7985: assignVM in Advanced zon...

2015-09-17 Thread DaanHoogland
Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/844#issuecomment-141058143
  
@wilderrodrigues that is not fair, it is not @ustcweizhou 's bug that needs 
fixing!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-7985: assignVM in Advanced zon...

2015-09-17 Thread miguelaferreira
Github user miguelaferreira commented on the pull request:

https://github.com/apache/cloudstack/pull/844#issuecomment-141059487
  
@DaanHoogland @wilderrodrigues @ustcweizhou  I agree with Daan, the problem 
is most likely elsewhere. But I also agree with Wilder, first we need to figure 
out where the problem is, fix it, rebase all PRs to branch off after the fix 
and then continue the normal process. We can't be merging things hoping all 
will be well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: [4.6][BLOCKER]CLOUDSTACK-8763: Resolved P...

2015-09-17 Thread borisroman
Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/845#issuecomment-141059956
  
@DaanHoogland That was also one of my questions on Slack. There are no Unit 
tests regarding Dao classes in  /cloud-engine-schema/test/. So how do I test 
these?

I've functionally tested all by starting with a fully deployed cloud and 
removing all components (hosts, ips , clusters, pods, .. ) until I could 
confirm all exceptions where thrown in the right place.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: [4.6][BLOCKER]CLOUDSTACK-8763: Resolved P...

2015-09-17 Thread DaanHoogland
Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/845#issuecomment-141061213
  
@borisroman so please add a description of your manual test scheme in the 
description area of this PR 
( and help us think of a better dao implementation ;)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-7985: assignVM in Advanced zon...

2015-09-17 Thread miguelaferreira
Github user miguelaferreira commented on the pull request:

https://github.com/apache/cloudstack/pull/844#issuecomment-141064763
  
Thanks for rebasing @ustcweizhou 

The pull-analysis is now running.
https://builds.apache.org/job/cloudstack-pull-analysis/583/
Lets keep an eye on it, hopefully the problem will be gone.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-7985: assignVM in Advanced zon...

2015-09-17 Thread ustcweizhou
Github user ustcweizhou commented on the pull request:

https://github.com/apache/cloudstack/pull/844#issuecomment-141065052
  
@DaanHoogland @miguelaferreira @wilderrodrigues 
I have rebase with the lastest master, and force push to github. 
let's see if it will be fixed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: ACS 4.5 - volume snapshots NOT removed from CEPH (only from Secondaryt NFS and DB)

2015-09-17 Thread Dmytro Shevchenko
Nice work. I compiled and install new version into local maven 
repository, but now I can't compile Cloudstack with this library. I 
changed dependency version in pom file to new, but got next exception 
while compiling 'cloud-plugin-hypervisor-kvm':


Konsole output
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile 
(default-compile) on project cloud-plugin-hypervisor-kvm: Compilation 
failure: Co

mpilation failure:
[ERROR] Picked up JAVA_TOOL_OPTIONS: 
-javaagent:/usr/share/java/jayatanaag.jar
[ERROR] 
/home/dmytro.shevchenko/test/cloudstack/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:[80,21] 
error: cannot find symbol

[ERROR] symbol:   class RadosException
[ERROR] location: package com.ceph.rados

After investigation I found that class RadosException was moved to 
Konsole output 'exceptions' subdirectory, but in 
LibvirtComputingResource.java it import as " import 
com.ceph.rados.RadosException;". Question is next, if I want compile 
some release version with this new changes, which way would be 
preferred? change import path LibvirtComputingResource.java and other 
places where this class is used to 
"com.ceph.rados.exceptions.RadosException"?



--
Best regards
Dmytro Shevchenko
dmytro.shevche...@safeswisscloud.com
skype: demonsh_mk



On 09/15/2015 03:11 PM, Wido den Hollander wrote:


On 15-09-15 13:56, Dmytro Shevchenko wrote:

Hello Wido, I saw you updated this code again. Maybe you know, what
procedure for rebuilding this library in Apache maven repository?
Because here http://repo.maven.apache.org/maven2/com/ceph/rados/ still
present only old 0.1.4 version and it's impossible recompile Cloudstack
with new patches.  Of cause we can download source code from Github,
compile it and replace 'jar' file on production, but this is dirty hack
and not acceptable for 'continues integration'.


It's up to me to do a new release of rados-java and I haven't done that
yet since I wanted to know for sure if the code works.

While writing some code for libvirt yesterday I came up with a better
solution for rados-java as well.

https://www.redhat.com/archives/libvir-list/2015-September/msg00458.html

For now you can replace 'rados.jar' on the production systems, but for
4.6 I want to make sure we depend on a new, to be released, version of
rados-java.

Wido


---
Best regards
Dmytro Shevchenko
dshevchenko.m...@gmail.com
skype: demonsh_mk


On 09/12/2015 06:16 PM, Wido den Hollander wrote:

On 09/11/2015 05:08 PM, Andrija Panic wrote:

THx a lot Wido !!! - we will patch this - For my understanding - is this
"temorary"solution - since it raises limit to 256 snaps ? Or am I
wrong ? I
mean, since we dont stil have proper snapshots removal etc, so after
i.e.
3-6months we will again have 256 snapshots of a single volume on CEPH ?


No, it will also work with >256 snapshots. I've tested it with 256 and
that worked fine. I see no reason why it won't work with 1024 or 2048
for example.


BTW we also have other exception, that causes same consequences - agent
disocnnecting and VMs going down...
As Dmytro explained, unprotecting snapshot causes same consequence...

  From my understanding, any RBD exception, might cause Agent to
disconnect
(or actually mgmt server to disconnect agent)...

Any clue on this, recommendation?


No, I don't have a clue. It could be that the job hangs somewhere inside
the Agent due to a uncaught exception though.


Thx a lot for fixing rados-java stuff !


You're welcome!

Wido


Andrija

On 11 September 2015 at 15:28, Wido den Hollander
wrote:


On 11-09-15 14:43, Dmytro Shevchenko wrote:

Thanks a lot Wido! Any chance to find out why management server
decided
that it lost connection to agent after that exceptions? It's not so
critical as this bug with 16 snapshots, but during last week we catch
situation when Agent failed unprotect snapshot, rise exception and
this
is was a reason of disconnection a bit later after that. (It is not
clear why CS decided remove that volume, it was template with one
'gold'
snapshot with several active clones)


No, I didn't look at CS at all. I just spend the day improving the
RADOS
bindings.

Wido


On 09/11/2015 03:20 PM, Wido den Hollander wrote:

On 11-09-15 10:19, Wido den Hollander wrote:

On 10-09-15 23:15, Andrija Panic wrote:

Wido,

could you folow maybe what my colegue Dmytro just sent ?


Yes, seems logical.


Its not only matter of question fixing rados-java (16 snaps limit)
- it
seems that for any RBD exception, ACS will freak out...


No, a RbdException will be caught, but the Rados Bindings shouldn't
throw NegativeArraySizeException in any case.

That's the main problem.


Seems to be fixed with this commit:


https://github.com/ceph/rados-java/commit/5584f3961c95d998d2a9eff947a5b7b4d4ba0b64


Just tested it with 256 snapshots:

---
T E S T S
---
Run

[GitHub] cloudstack pull request: [4.6][BLOCKER]CLOUDSTACK-8763: Resolved P...

2015-09-17 Thread remibergsma
Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/845#issuecomment-141086717
  
Hi @borisroman I deployed a DC and then added an extra POD. Then without 
creating even a cluster, tried to delete it. It failed saying:

```
The pod cannot be deleted because there are virtual machines in this pod.
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-7985: assignVM in Advanced zon...

2015-09-17 Thread miguelaferreira
Github user miguelaferreira commented on the pull request:

https://github.com/apache/cloudstack/pull/844#issuecomment-141086916
  
The build job already passed the point it had failed before 
(fingers-crossed)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8843: Fixed issue in default i...

2015-09-17 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/842#issuecomment-141091132
  
@jayapalu 

Which integration tests did you execute?

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: [4.6][BLOCKER]CLOUDSTACK-8763: Resolved P...

2015-09-17 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/845#issuecomment-141090948
  
:-1:  until we get steps to test it.

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-7985: assignVM in Advanced zon...

2015-09-17 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/844#issuecomment-141095617
  
Hi @ustcweizhou ,

I will :-1:  this PR until we get to know which integration tests you 
executed, against which environment and the steps so we can do the same.

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: [4.6][BLOCKER]CLOUDSTACK-8763: Resolved P...

2015-09-17 Thread remibergsma
Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/845#issuecomment-141124718
  
@borisroman Just successfully deleted a POD and a ZONE.

![screen shot 2015-09-17 at 17 02 
02](https://cloud.githubusercontent.com/assets/1630096/9937055/4d5335ea-5d5f-11e5-83c9-04f309c93005.png)

![screen shot 2015-09-17 at 17 02 
35](https://cloud.githubusercontent.com/assets/1630096/9937087/7cc4fc64-5d5f-11e5-87e9-48454ca5974d.png)

![screen shot 2015-09-17 at 17 02 
27](https://cloud.githubusercontent.com/assets/1630096/9937063/55e801e0-5d5f-11e5-973d-a93bb67c207d.png)

![screen shot 2015-09-17 at 17 11 
25](https://cloud.githubusercontent.com/assets/1630096/9937071/644880fc-5d5f-11e5-9d90-0e546dbb8637.png)

![screen shot 2015-09-17 at 17 11 
41](https://cloud.githubusercontent.com/assets/1630096/9937073/68184dfc-5d5f-11e5-9ea4-0cf1cfdd74f3.png)

LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...

2015-09-17 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/778#issuecomment-141135958
  
Hi there @rafaelweingartner,

No hard feelings, dude. 

Long story short:

* we are going through a critical phase with ACS - release
* I have been working on ACS since 2013, and it's always the same. We 
stable master, we have a release and after that master is screwed again. After 
6 months we go through this infinite loop of mess and nightmares.
* ACS is super uber tightly coupled, by the [bad] design it has. If I would 
tell you that we had production problems because of 1 class of 1 hypervisor, 
that we don't even use, was f*dup, you wouldn't believe me. So, any simple 
change has the potential to make a huge mess. That's why the tests, etc.
* I respect your efforts and also the guys working with you. I will be an 
student till I die!

If you can find a way to apply/submit your changes in an progressive way, 
I'm more than glad to help.

Cheers,
Wilder

P.S.: adamantium claws, you know... I got to use them sometimes. ;)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8688 - default policies for IN...

2015-09-17 Thread borisroman
Github user borisroman commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/765#discussion_r39765711
  
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py ---
@@ -414,7 +426,7 @@ def fw_router(self):
 self.fw.append(['', '', '-A NETWORK_STATS -i eth2 -o eth0'])
 self.fw.append(['', '', '-A NETWORK_STATS -o eth2 ! -i eth0 -p 
tcp'])
 self.fw.append(['', '', '-A NETWORK_STATS -i eth2 ! -o eth0 -p 
tcp'])
-
+
--- End diff --

@wilderrodrigues Seems like you hadn't removed the trailing white spaces. 
Maybe a good time to remove them when PRing CLOUDSTACK-8878 or CLOUDSTACK-8795? 
:)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...

2015-09-17 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/778#issuecomment-141142775
  
@wilderrodrigues, 
Of course no hard feelings.

I understand the pain that you feel when you stabilize everything and 
people come and breaking things. 

About our PR, we are starting to investigate that hierarchic, we believe 
that some classes do not need to be there. Therefore, it would enable us to 
shorter the hierarchic and de-couple a little bit the code.

See you in the next PR ;)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: [4.6][BLOCKER]CLOUDSTACK-8763: Resolved P...

2015-09-17 Thread remibergsma
Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/845#issuecomment-141170729
  
For the record, I tested against fa5f388fe91bc2fd477b1f6752c2a31ac69d5051.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: [4.6][BLOCKER]CLOUDSTACK-8763: Resolved P...

2015-09-17 Thread remibergsma
Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/845#issuecomment-141175510
  
@wilderrodrigues The steps to test this are simply creating a POD, then 
deleting it. It fails in current master and succeeds in this PR. Same with a 
zone. If you deploy with Marvin and make sure it cannot find the hypervisor, 
the cleanup should succeed. That doesn't work either on current master as it 
leaves you with a half cleaned-up mess preventing you from deploying again.

I showed the manual tests above (screenshots). Here's the failing Marvin 
deploy with successful cleanup. I made sure the hypervisor was down so it 
couldn't succeed.

```
[root@cs1 cloudstack]# python 
/data/git/$HOSTNAME/cloudstack/tools/marvin/marvin/deployDataCenter.py -i 
/data/shared/marvin/mct-zone2-xen2.cfg

 Log Folder Path: 
/tmp//MarvinLogs//DeployDataCenter__Sep_17_2015_18_20_59_Z1US54. All logs will 
be available here 

 Deploy DC Started 
Exception Occurred :['Traceback (most recent call last):\n', '  File 
"/data/git/cs1/cloudstack/tools/marvin/marvin/deployDataCenter.py", line 136, 
in addHosts\nret = self.__apiClient.addHost(hostcmd)\n', '  File 
"/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", 
line 1572, in addHost\nresponse = self.connection.marvinRequest(command, 
response_type=response, method=method)\n', '  File 
"/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in 
marvinRequest\nraise e\n', 'CloudstackAPIException: Execute cmd: addhost 
failed, due to: errorCode: 530, errorText:Unable to add the host\n']

===deploy dc failed, so cleaning the created entries===

DeployDC: CleanUp Started

Clean Up Entries=== {'PhysicalNetwork': 
[u'd69f38fc-6fa9-474d-a89a-b8d8a7219cf4'], 'Cluster': 
[u'1a51747a-fc04-4a57-9b4f-5b1b3dcaa3ba'], 'Pod': 
[u'73132578-a301-4e89-8397-df043568efa7'], 'order': ['Cluster', 'Pod', 
'PhysicalNetwork', 'Zone'], 'Zone': [u'406ec1f9-1c90-46a1-9a3a-ee137f5baf7b']}

===Removing DataCenter Successful===
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: ACS 4.5 - volume snapshots NOT removed from CEPH (only from Secondaryt NFS and DB)

2015-09-17 Thread Wido den Hollander


On 09/17/2015 02:33 PM, Dmytro Shevchenko wrote:
> Nice work. I compiled and install new version into local maven
> repository, but now I can't compile Cloudstack with this library. I
> changed dependency version in pom file to new, but got next exception
> while compiling 'cloud-plugin-hypervisor-kvm':
> 
> Konsole output
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile
> (default-compile) on project cloud-plugin-hypervisor-kvm: Compilation
> failure: Co
> mpilation failure:
> [ERROR] Picked up JAVA_TOOL_OPTIONS:
> -javaagent:/usr/share/java/jayatanaag.jar
> [ERROR]
> /home/dmytro.shevchenko/test/cloudstack/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:[80,21]
> error: cannot find symbol
> [ERROR] symbol:   class RadosException
> [ERROR] location: package com.ceph.rados
> 
> After investigation I found that class RadosException was moved to
> Konsole output 'exceptions' subdirectory, but in
> LibvirtComputingResource.java it import as " import
> com.ceph.rados.RadosException;". Question is next, if I want compile
> some release version with this new changes, which way would be
> preferred? change import path LibvirtComputingResource.java and other
> places where this class is used to
> "com.ceph.rados.exceptions.RadosException"?
> 
> 

The latter would be the preferred indeed. I pushed a new version of
rados-java and it's making it's way to Maven central now.

When that is done I can push a PR for CloudStack which we might get
backported to 4.5.3

Wido



[GitHub] cloudstack pull request: Bug-ID: CLOUDSTACK-8870: Skip external de...

2015-09-17 Thread kishankavala
GitHub user kishankavala opened a pull request:

https://github.com/apache/cloudstack/pull/846

Bug-ID: CLOUDSTACK-8870: Skip external device usage collection if no 
external devices exist

external network device usage monitor thread that runs every 5mins by 
default (based on global config external.network.stats.interval) and runs 
coalesce query to acquire a lock. When there are no external devices exist, 
there is no need to run usage collection.
Added test case to verify that usage collection task is not run when there 
are no External LB or External FW

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kishankavala/cloudstack CLOUDSTACK-8870

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/846.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #846


commit a77dc78bfead71d0c9b5afa5813575ac67880f11
Author: Kishan Kavala 
Date:   2015-09-16T15:15:06Z

Bug-ID: CLOUDSTACK-8870: Skip external device usage collection if no 
external devices exist.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: [4.5.3]Cherry-pick PR #795 into 4.5 branc...

2015-09-17 Thread bhaisaab
Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/817#issuecomment-141342804
  
LGTM, merging this this is already merged on master and builds are passing 
on 4.5 branch now


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8852 Database shows that manag...

2015-09-17 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/840#discussion_r39823849
  
--- Diff: 
framework/spring/lifecycle/src/main/java/org/apache/cloudstack/spring/lifecycle/CloudStackExtendedLifeCycle.java
 ---
@@ -96,12 +96,13 @@ public void with(ComponentLifecycle lifecycle) {
 }
 
 public void stopBeans() {
-with(new WithComponentLifeCycle() {
-@Override
-public void with(ComponentLifecycle lifecycle) {
-lifecycle.stop();
-}
-});
+with(new WithComponentLifeCycle() {
--- End diff --

Fix double indentation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: [4.5.3]Cherry-pick PR #795 into 4.5 branc...

2015-09-17 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/817


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8852 Database shows that manag...

2015-09-17 Thread bhaisaab
Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/840#issuecomment-141343287
  
LGTM, pl fix one of the indentation issues and perhaps use better and 
verbose log messages.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8851 Redundant VR getting star...

2015-09-17 Thread bhaisaab
Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/839#issuecomment-141343706
  
LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8854: Apple Mac OS/X VM get cr...

2015-09-17 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/828#discussion_r39824131
  
--- Diff: 
vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareHelper.java ---
@@ -598,6 +601,19 @@ public static void 
setBasicVmConfig(VirtualMachineConfigSpec vmConfig, int cpuCo
 vmConfig.setGuestId(guestOsIdentifier);
 }
 
+public static void addUSBController(VirtualMachineConfigSpec 
vmConfigSpec) {
--- End diff --

@sureshanaparti if other methods are like and you're simply follow those 
conventions, then it's fine though it becomes easier to test methods 
functionally if they return objects instead of modifying them. In either case, 
can you add a simple unit test for this. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8843: Fixed issue in default i...

2015-09-17 Thread jayapalu
Github user jayapalu commented on the pull request:

https://github.com/apache/cloudstack/pull/842#issuecomment-141348042
  
@wilderrodrigues 
I have tested the changes on my local against the VR. It is specific to 
shared network and the fix is also specific to shared network VR. I think it 
will not impact the other type of VRs.

But I have not run the integration tests on it. Let me try  running test 
cases on it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[Blocker] PF, static nat, LB, egress rules not working in case of isolated networks

2015-09-17 Thread Raja Pullela
Hi,

Created a blocker - https://issues.apache.org/jira/browse/CLOUDSTACK-8881
This is failing a bunch of BVTs in Adv for XS/KVM and VMWare.
Can someone please look at this ?

best,
Raja



[GitHub] cloudstack pull request: Bug-ID: CLOUDSTACK-8880: calculate free m...

2015-09-17 Thread kishankavala
GitHub user kishankavala opened a pull request:

https://github.com/apache/cloudstack/pull/847

Bug-ID: CLOUDSTACK-8880: calculate free memory on host before deploying Vm. 
 free memory = total memory - (all vm memory)

With memory over-provisioning set to 1, when mgmt server starts VMs in 
parallel on one host, then the memory allocated on that kvm can be larger than 
the actual physcial memory of the kvm host.

Fixed by checking free memory on host before starting Vm.
Added test case to check memory usage on Host.
Verified Vm deploy on Host with enough capacity and also without capacity


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kishankavala/cloudstack CLOUDSTACK-8880

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/847.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #847


commit e2a879f040e894c32defd3fb9bb3b127fd96702d
Author: Kishan Kavala 
Date:   2015-09-18T05:40:52Z

Bug-ID: CLOUDSTACK-8880: calculate free memory on host before deploying Vm. 
 free memory = total memory - (all vm memory)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


RE: [Blocker] PF, static nat, LB, egress rules not working in case of isolated networks

2015-09-17 Thread Raja Pullela
correction - not "BVT"  - "Regression Tests"  in Advanced zone. 

-Original Message-
From: Raja Pullela [mailto:raja.pull...@citrix.com] 
Sent: Friday, September 18, 2015 11:12 AM
To: CloudStack Dev (dev@cloudstack.apache.org) 
Subject: [Blocker] PF, static nat, LB, egress rules not working in case of 
isolated networks

Hi,

Created a blocker - https://issues.apache.org/jira/browse/CLOUDSTACK-8881
This is failing a bunch of BVTs in Adv for XS/KVM and VMWare.
Can someone please look at this ?

best,
Raja



[GitHub] cloudstack pull request: CLOUDSTACK-8854: Apple Mac OS/X VM get cr...

2015-09-17 Thread sureshanaparti
Github user sureshanaparti commented on the pull request:

https://github.com/apache/cloudstack/pull/828#issuecomment-141356708
  
@bhaisaab @sateesh-chodapuneedi  Update code as per the existing 
conventions. Please check. Working on the unit test. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8826: XenServer - Use device i...

2015-09-17 Thread koushik-das
Github user koushik-das commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/792#discussion_r39827592
  
--- Diff: 
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
 ---
@@ -3407,6 +3390,18 @@ public void handleSrAndVdiDetach(final String iqn, 
final Connection conn) throws
 removeSR(conn, sr);
 }
 
+protected void destroyUnattachedVBD(Connection conn, VM vm) {
+try {
+for (VBD vbd : vm.getVBDs(conn)) {
+if (Types.VbdType.DISK.equals(vbd.getType(conn)) && 
!vbd.getCurrentlyAttached(conn)) {
+vbd.destroy(conn);
+}
+}
+} catch (final Exception e) {
+s_logger.debug("destroyUnattachedVBD failed due to " + 
e.toString());
--- End diff --

@DaanHoogland Are you suggesting to log the full exception? Currently only 
the message is getting logged. The destroyUnattachedVBD is a best-effort call 
to cleanup VBDs.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: Recurring snapshot taking full every time

2015-09-17 Thread raja sekhar
Hi Abhinandan,

I have force reconnect the hosts but no use and i didn't find any error in
SMlog. please suggest me the error is still
generating.

Regards,
Rajasekhar.

On Wed, Sep 16, 2015 at 8:58 AM, Abhinandan Prateek <
abhinandan.prat...@shapeblue.com> wrote:

> Can you check in the SMlog on the concerned host if you see any error when
> the plugin is being invoked ?
>
> > On 14-Sep-2015, at 5:01 pm, raja sekhar  wrote:
> >
> > Hi abhinandan,
> >
> > Thanks for your reply.
> > We are facing the issue only for root volumes in that host. The snapshot
> > recurring policy for data disks in same host is working fine.
> > if the host configuration is not properly instrumented the policy for
> data
> > disks also fails, but it is working fine.
> > please suggest us.
> >
> > Note: The manual snapshots for root disk is working fine,and it is taking
> > child when second manual is configured , problem only with root daily
> > snapshots every day it is taking full instead of taking child snapshots
> > throwing error "*Failed to get parent snapshot**, due to There was a
> > failure communicating with the plugin*".
> >
> > Regards,
> > rajasekhar.
> >
> > On Mon, Sep 14, 2015 at 4:00 PM, Abhinandan Prateek <
> > abhinandan.prat...@shapeblue.com> wrote:
> >
> >> Looks like the host is not instrumented properly and management server
> is
> >> unable to invoke plugin on the host.
> >> Can you force-reconnect the host that is throwing this error ? That
> should
> >> recopy the plugins on to the host.
> >>
> >>> On 14-Sep-2015, at 3:15 pm, raja sekhar 
> wrote:
> >>>
> >>> Hi All,
> >>>
> >>> I am using CS 4.3.1 and xenserver 6.2
> >>> I have configured daily recurring snapshot policy for all the root
> >> volumes.
> >>> but recent three days onwards it is taking full snapshots and not
> taking
> >>> any child snapshots.
> >>> I have configured snapshot.delta.max to 16.
> >>> please help me my secondary storage is becoming full.
> >>>
> >>> The log file details shows:
> >>>
> >>> 2015-09-14 01:03:29,973 DEBUG [c.c.a.m.DirectAgentAttache]
> >>> (DirectAgent-24:ctx-d68622c5) Seq 4-482873005: Response Received:
> >>> 2015-09-14 01:03:29,973 DEBUG [c.c.a.m.ClusteredAgentManagerImpl]
> >>> (DirectAgent-24:ctx-d68622c5) Seq 4-482873005: MgmtId 195780927071877:
> >>> Resp: Routing to peer
> >>> 2015-09-14 01:03:32,233 DEBUG [c.c.c.ConsoleProxyManagerImpl]
> >>> (consoleproxy-1:ctx-b1db30de) Zone 1 is ready to launch console proxy
> >>> 2015-09-14 01:03:32,334 DEBUG [c.c.s.s.SecondaryStorageManagerImpl]
> >>> (secstorage-1:ctx-e024d41b) Zone 1 is ready to launch secondary storage
> >> VM
> >>> 2015-09-14 01:03:33,934 WARN  [c.c.u.n.Link]
> (AgentManager-Selector:null)
> >>> SSL: Fail to find the generated keystore. Loading fail-safe one to
> >> continue.
> >>> 2015-09-14 01:03:34,044 DEBUG [c.c.a.t.Request]
> >>> (AgentManager-Handler-10:null) Seq 1-457572529: Executing:  { Cmd ,
> >> MgmtId:
> >>> 108371418365724, via: 1, Ver: v1, Flags: 100011,
> >>>
> >>
> [{"org.apache.cloudstack.storage.command.CreateObjectCommand":{"data":{"org.apache.cloudstack.storage.to.SnapshotObjectTO":{"volume":{"uuid":"bcf7653a-33db-461a-9355-e5d518012679","volumeType":"ROOT","dataStore":{"org.apache.cloudstack.storage.to.PrimaryDataStoreTO":{"uuid":"165fb777-4225-326a-bc48-f5b465f9486b","id":1,"poolType":"NetworkFilesystem","host":"172.30.36.51","path":"/vS02304090GCSP_NAS05","port":2049,"url":"NetworkFilesystem://
> >>>
> >>
> 172.30.36.51//vS02304090GCSP_NAS05/?ROLE=Primary&STOREUUID=165fb777-4225-326a-bc48-f5b465f9486b
> >>>
> >>
> "}},"name":"ROOT-189","size":85899345920,"path":"9deefbf6-86e6-4359-acb3-99e1aebcb359","volumeId":696,"vmName":"i-11-189-VM","accountId":11,"format":"VHD","id":696,"deviceId":0,"hypervisorType":"XenServer"},"parentSnapshotPath":"3a6e9e1a-fd95-4530-ae67-03a368b3e2fd","dataStore":{"org.apache.cloudstack.storage.to.PrimaryDataStoreTO":{"uuid":"165fb777-4225-326a-bc48-f5b465f9486b","id":1,"poolType":"NetworkFilesystem","host":"172.30.36.51","path":"/vS02304090GCSP_NAS05","port":2049,"url":"NetworkFilesystem://
> >>>
> >>
> 172.30.36.51//vS02304090GCSP_NAS05/?ROLE=Primary&STOREUUID=165fb777-4225-326a-bc48-f5b465f9486b
> >>
> "}},"vmName":"i-11-189-VM","name":"SAGXD02_ROOT-189_20150914090333","hypervisorType":"XenServer","id":6732,"quiescevm":false,"parents":["3a6e9e1a-fd95-4530-ae67-03a368b3e2fd"],"physicalSize":0}},"wait":0}}]
> >>> }
> >>> 2015-09-14 01:03:34,045 DEBUG [c.c.a.m.DirectAgentAttache]
> >>> (DirectAgent-333:ctx-c3e7c331) Seq 1-457572529: Executing request
> >>> 2015-09-14 01:03:35,421 WARN  [c.c.h.x.r.CitrixResourceBase]
> >>> (DirectAgent-333:ctx-c3e7c331) callHostPlugin failed for cmd:
> >> getVhdParent
> >>> with args snapshotUuid: 3a6e9e1a-fd95-4530-ae67-03a368b3e2fd, isISCSI:
> >>> false, primaryStorageSRUuid: a6a7f65a-a1d2-83e3-d3b0-f38792863fb6,  due
> >> to
> >>> There was a failure communicating with the plugin.
> >>> 2015-09-14 01:03:35,421 DEBUG [c.c.h.x.r.XenServerStorageProcessor]
> >>> (Dire