Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/845#issuecomment-141175510
@wilderrodrigues The steps to test this are simply creating a POD, then
deleting it. It fails in current master and succeeds in this PR. Same with a
zone. If you deploy with Marvin and make sure it cannot find the hypervisor,
the cleanup should succeed. That doesn't work either on current master as it
leaves you with a half cleaned-up mess preventing you from deploying again.
I showed the manual tests above (screenshots). Here's the failing Marvin
deploy with successful cleanup. I made sure the hypervisor was down so it
couldn't succeed.
```
[root@cs1 cloudstack]# python
/data/git/$HOSTNAME/cloudstack/tools/marvin/marvin/deployDataCenter.py -i
/data/shared/marvin/mct-zone2-xen2.cfg
==== Log Folder Path:
/tmp//MarvinLogs//DeployDataCenter__Sep_17_2015_18_20_59_Z1US54. All logs will
be available here ====
==== Deploy DC Started ====
Exception Occurred :['Traceback (most recent call last):\n', ' File
"/data/git/cs1/cloudstack/tools/marvin/marvin/deployDataCenter.py", line 136,
in addHosts\n ret = self.__apiClient.addHost(hostcmd)\n', ' File
"/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py",
line 1572, in addHost\n response = self.connection.marvinRequest(command,
response_type=response, method=method)\n', ' File
"/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in
marvinRequest\n raise e\n', 'CloudstackAPIException: Execute cmd: addhost
failed, due to: errorCode: 530, errorText:Unable to add the host\n']
===deploy dc failed, so cleaning the created entries===
====DeployDC: CleanUp Started====
====Clean Up Entries=== {'PhysicalNetwork':
[u'd69f38fc-6fa9-474d-a89a-b8d8a7219cf4'], 'Cluster':
[u'1a51747a-fc04-4a57-9b4f-5b1b3dcaa3ba'], 'Pod':
[u'73132578-a301-4e89-8397-df043568efa7'], 'order': ['Cluster', 'Pod',
'PhysicalNetwork', 'Zone'], 'Zone': [u'406ec1f9-1c90-46a1-9a3a-ee137f5baf7b']}
===Removing DataCenter Successful===
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
