[GitHub] cloudstack pull request: Replace some profiler.getDuration with pr...

2015-08-24 Thread ustcweizhou
Github user ustcweizhou commented on the pull request:

https://github.com/apache/cloudstack/pull/730#issuecomment-134069656
  
@karuturi @wilderrodrigues I just created a ticket for it. 
https://issues.apache.org/jira/browse/CLOUDSTACK-8761



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8443: Support CentOS 7 as KVM ...

2015-08-24 Thread borisroman
Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/731#issuecomment-134071270
  
LGTM -> Deployed on Centos7 started 2 systemvms, 1 router and 1 guest vm 
without libvirt errors.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


CloudStack Docker images on Docker hub.

2015-08-24 Thread Sebastien Goasguen
Hi Everyone,

Last week David and I worked on the Docker hub to get automated builds for 
ec2stack and cloudmonkey.

You can now get those on Docker hub:

$ docker pull cloudstack/cloudmonkey
$ docker pull cloudstack/ec2stack

These are automated build of master, I will work to get other tags that 
corresponds to the release.

Please try it and let me know how that works. If you see any issues feel free 
to send PR to the respective projects.
The images will build automatically and you should be able to test it right 
away.

Also you have images for the simulator and the mgt server under cents

$ docker pull cloudstack/simulator
$ docker pull cloudstack/management_centos6

We need to split the MySQL db from the mgt server and get a build going for the 
usage server as well.

The goal would be to have a docker-compose file that starts the mgt server, db, 
usage server and ec2stack.
PR welcome for this, it’s a fun project for anyone interested in Docker.

Enjoy,


-Sebastien

[GitHub] cloudstack pull request: CLOUDSTACK-8727: API call listVirtualMach...

2015-08-24 Thread DaanHoogland
Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/685#issuecomment-134088772
  
I would like to see two unit tests for checkForKeyByPublicKey. The succes 
and the failure cases. I am not sure if this check shows a very good pattern 
but that is out of scope for this PR. Other then unit tests missing, LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8754: VM migration triggered b...

2015-08-24 Thread DaanHoogland
Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/725#issuecomment-134089286
  
@kishankavala a trivial test is better then none. for better tests, a jira 
ticket can be created and comments in the test class can be added.

that said LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Fixing syntax error introduced in PR #717

2015-08-24 Thread bhaisaab
Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/722#issuecomment-134097022
  
LGTM, merging. Thanks @miguelaferreira for fixing this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


How does the parameter startdate/enddate of api listEvents() use new time format like 'yyyy-MM-dd HH:mm:ss' ?

2015-08-24 Thread tony_caotong

Hello Every.

I know this is a very simple question to most of you. but it is really 
hard for me to continue my work.


So could Anyone spend your three minutes to give me some advice, it will 
be very usefull to me.


my question is:

How does the parameter startdate/enddate of api listEvents() use 
new time format  like '-MM-dd HH:mm:ss' ?



>>> Event({'listall':'True', 'startdate':'2015-08-24 00:00:00'})
http://10.0.1.100:8080/client/api?apiKey=hjZ12EQ4JfFasIHO3RCXBLji-3RbBmdC973utGwCL5388WypVKwtaNsDso-JzVQIZXUVwfaT1vANdDUJs3Vkkg&command=listEvents&listall=True&response=json&startdate=2015-08-24+00%3A00%3A00&signature=z4LQCw7yzGmTK5B7TzAbzl1biXI%3D 


Traceback (most recent call last):
  File "", line 1, in 
  File "SignedAPICall.py", line 67, in Event
a = api.listEvents(request)
  File "SignedAPICall.py", line 49, in handlerFunction
return self._make_request(name, args[0])
  File "SignedAPICall.py", line 61, in _make_request
data = self._http_get(self.value)
  File "SignedAPICall.py", line 54, in _http_get
response = urllib.urlopen(url)
  File "/usr/lib64/python2.7/urllib.py", line 87, in urlopen
return opener.open(url)
  File "/usr/lib64/python2.7/urllib.py", line 208, in open
return getattr(self, name)(url)
  File "/usr/lib64/python2.7/urllib.py", line 359, in open_http
return self.http_error(url, fp, errcode, errmsg, headers)
  File "/usr/lib64/python2.7/urllib.py", line 372, in http_error
result = method(url, fp, errcode, errmsg, headers)
  File "/usr/lib64/python2.7/urllib.py", line 683, in http_error_401
errcode, errmsg, headers)
  File "/usr/lib64/python2.7/urllib.py", line 381, in http_error_default
raise IOError, ('http error', errcode, errmsg, headers)
IOError: ('http error', 401, 'Unauthorized', instance at 0x7f083da78998>)


---
Cao Tong

On 08/19/2015 10:32 AM, tony_caot...@163.com wrote:


Hi All:

Does any one have any idea ? Thanks.

---
Cao Tong

On 08/18/2015 06:04 PM, tony_caot...@163.com wrote:


In ParamProcessWorker::setFieldValue() I found this lins:

   case DATE:
// This piece of code is for maintaining backward 
compatibility

// and support both the date formats(Bug 9724)

Is it related to my problem?  Where can I found the descriptions 
about BUG9724 ?


---
Cao Tong

On 08/18/2015 05:54 PM, tony_caot...@163.com wrote:


Hello,

When I use timestamp format startdate="2015-07-31", it works find.
When I use it like this startdate="2015-07-31 13:00:00".
It return a error
IOError: ('http error', 401, 'Unauthorized', instance at 0x16dca70>)


Could anyone tell me why ?

I have read the code 
"DefaultLoginAPIAuthenticatorCmd::authenticate()" , but I am still 
not understand what was happening,

it seems authenticate failed, but why??

---
Cao Tong

On 07/31/2015 07:07 PM, tony_caot...@163.com wrote:


Hi,

was this format is enabled in ACS 4.5.1 like /"-MM-dd 
HH:mm:ss"



/I found it in 4.5.0 API doc, but it seems not enabled.

http://cloudstack.apache.org/api/apidocs-4.5/user/listEvents.html

>>> api.listEvents(startdate="2015-07-31 13:00:00")
Traceback (most recent call last):
  File "", line 1, in 
  File "call.py", line 48, in handlerFunction
return self._make_request(name, kwargs)
  File "call.py", line 60, in _make_request
data = self._http_get(self.value)
  File "call.py", line 53, in _http_get
response = urllib.urlopen(url)
  File "/usr/lib64/python2.7/urllib.py", line 87, in urlopen
return opener.open(url)
  File "/usr/lib64/python2.7/urllib.py", line 208, in open
return getattr(self, name)(url)
  File "/usr/lib64/python2.7/urllib.py", line 359, in open_http
return self.http_error(url, fp, errcode, errmsg, headers)
  File "/usr/lib64/python2.7/urllib.py", line 372, in http_error
result = method(url, fp, errcode, errmsg, headers)
  File "/usr/lib64/python2.7/urllib.py", line 683, in http_error_401
errcode, errmsg, headers)
  File "/usr/lib64/python2.7/urllib.py", line 381, in 
http_error_default

raise IOError, ('http error', errcode, errmsg, headers)
IOError: ('http error', 401, 'Unauthorized', instance at 0x16dca70>)

>>>


my ACS version:

[root@cs ~]# rpm -qa |grep cloud
cloudstack-management-4.5.1-shapeblue0.el6.x86_64
cloudstack-awsapi-4.5.1-shapeblue0.el6.x86_64
cloudstack-agent-4.5.1-shapeblue0.el6.x86_64
cloudstack-common-4.5.1-shapeblue0.el6.x86_64
















[GitHub] cloudstack pull request: Fixing syntax error introduced in PR #717

2015-08-24 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/722


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8748: VM UUID accessible in Cr...

2015-08-24 Thread bhaisaab
Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/717#issuecomment-134098323
  
Merged on master through: https://github.com/apache/cloudstack/pull/722


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: [VOTE] Apache Cloudstack 4.5.2 (Round 2)

2015-08-24 Thread Tomasz Zięba
Hi all,

+1

Env:
  XenServer 6.2,  6.5, Advanced zone,
upgrade 4.2.1 -> 4.5.2



2015-08-20 20:23 GMT+02:00 Remi Bergsma :

> Hi all,
>
> +1 (binding)
>
> Tested:
> 
> 1. Advanced zone with XenServer
> - Deployed VPCs, VMs and VPNs between them
> - Crashed a XenServer, watched it recover
> - Tested it again and all was fine. All I had to do was reset the VPN
> connection, but maybe it'd have done it automatically if I waited longer.
>
> 2. Advanced zone with KVM (on CentOS 7 that is, after some manual tweaks)
> - Advanced zone with XenServer
> - Deployed VPCs, VMs and VPNs between them
> - Crashed a KVM hypervisor, watched it recover
> - Tested it again and all was fine. VPN recovery was automatic.
>
> 3. Upgraded 4.4.4 -> 4.5.2
> It went fine.
>
> About KVM on CentOS 7
> At work we're actually running KVM on CentOS 7, on ACS 4.4.x. Although I
> know not many people do. I tried it on 4.5.2 and encountered the issues
> described in CLOUDSTACK-8443. I checked the documentation and it said we
> only support CentOS 6.3 (I assume .3 should be .x but anyway) on ACS 4.5.x
> so I'll just ignore this for now.
>
> I have updated the Jira issue with some findings and I will investigate
> this further, so we can fix it and at least start supporting CentOS 7 as a
> KVM hypervisor out-of-the-box in 4.6.
>
> If we feel we want to fix KVM on CentOS 7 in 4.5.2 then we need another
> 4.5.2RC, in which case I'm happy to help making it happen ;-)
>
> Regards,
> Remi
>
>
>
> > On 20 Aug 2015, at 08:26, Rajani Karuturi  wrote:
> >
> > +1(binding)
> >
> > tested fresh install on xenserver 6.5 advanced zone setup.
> >
> > register template, create network, launch vm, view console etc. worked
> fine.
> >
> >
> > ~Rajani
> >
> > On Thu, Aug 20, 2015 at 12:04 AM, Milamber  wrote:
> >
> >> Hello,
> >>
> >> +1 (binding)
> >>
> >> * Building CloudStack ubuntu packages from Git 4.5.2 RC2 tag.
> >>
> >> * Tests migration from 4.4.4 -> 4.5.2rc2 on Ubuntu 14.04.3 (1 mgr, 2
> >> nodes, 1 nfs), basic install, NFS storage, KVM, SystemVM shapeblue,
> After
> >> migration: some tests on HA (crash node), some tests with templates,
> >> account management in webui, test localization french, and
> CS<->cloud-init
> >> on debian.
> >>
> >> * Tests fresh install on Ubuntu 14.04.3 (1 mgr, 2 nodes, 1 nfs),
> advanced
> >> network install NFS storage, KVM, SystemVM shapeblue, some tests on HA
> >> (crash node), some tests with templates, and CS<->cloud-init on debian.
> >>
> >> * Some tests (register template, create network, register ssh key,
> create
> >> instance, get IP) with Ansible + ansible-cloudstack module from @resmo
> >>
> >> Thanks for the RM.
> >>
> >> Milamber
> >>
> >>
> >> Please note this bug message in the last migration step (when I rebooted
> >> all systemvm/router).
> >>
> >> root@cs-mgr1:~# cloudstack-sysvmadm -d 127.0.0.1 -u cloud -p cloudPass
> -a
> >> /usr/bin/cloudstack-sysvmadm: line 21: /etc/rc.d/init.d/functions: No
> such
> >> file or directory
> >>
> >> Stopping and starting 1 secondary storage vm(s)...
> >> Done stopping and starting secondary storage vm(s)
> >>
> >> Stopping and starting 1 console proxy vm(s)...
> >> Done stopping and starting console proxy vm(s) .
> >>
> >> Stopping and starting 1 running routing vm(s)...
> >> Done restarting router(s).
> >>
> >>
> >>
> >>
> >> On 19/08/2015 10:22, Rohit Yadav wrote:
> >>
> >>> Hi All,
> >>>
> >>> I've created a 4.5.2 release, with the following artifacts up for a
> vote:
> >>>
> >>> Git Branch and Commit SH:
> >>>
> >>>
> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.5-RC20150819T1442
> >>> Commit: 7385441807ba3fde3d45c226df6b1bdd2f36ae26
> >>> Tag: 4.5.2-rc2
> >>>
> >>> List of changes:
> >>>
> >>>
> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.5-RC20150819T1442
> >>>
> >>> Source release (checksums and signatures are available at the same
> >>> location):
> >>> https://dist.apache.org/repos/dist/dev/cloudstack/4.5.2/
> >>>
> >>> PGP release keys (signed using 0EE3D884):
> >>> https://dist.apache.org/repos/dist/release/cloudstack/KEYS
> >>>
> >>> The vote will be open for 72 hours.
> >>>
> >>> For sanity in tallying the vote, can PMC members please be sure to
> >>> indicate "(binding)" with their vote?
> >>>
> >>> [ ] +1  approve
> >>> [ ] +0  no opinion
> >>> [ ] -1  disapprove (and reason why)
> >>>
> >>> Regards.
> >>>
> >>>
> >>
>
>


-- 
Regards,
Tomasz Zięba
Twitter: @TZieba
LinkedIn: pl.linkedin.com/pub/tomasz-zięba-ph-d/3b/7a8/ab6/



[GitHub] cloudstack pull request: CLOUDSTACK-5863: revert volume snapshot f...

2015-08-24 Thread ustcweizhou
GitHub user ustcweizhou opened a pull request:

https://github.com/apache/cloudstack/pull/732

CLOUDSTACK-5863: revert volume snapshot for KVM/QCOW2

Guys, can you review it? things need to be discussed:
(1) this supports KVM/QCOW2 only. Anyone want to implement for other 
Hypervisor/format ?
(2) The original data volume (on primary storage) will be removed.
(3) The script uses the default timeout in libvirtComputingResource. Do we 
need to add one in global configuration (like copy.volume.wait or 
backup.snapshot.wait, create.volume.from.snapshot.wait)
(4) In scripts/storage/qcow2/managesnapshot.sh, I use "qemu-img convert -f 
qcow2 -O qcow2" to copy the snapshot from secondary to primary (hence there is 
no base image file), instead of "cp -f", this is because convert is faster than 
cp in my testing.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ustcweizhou/cloudstack 
revert-volume-snapshot-master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/732.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #732


commit 92344c006dfa8abf4ce81e2a25839cbb762d1b17
Author: Wei Zhou 
Date:   2015-08-24T09:01:50Z

CLOUDSTACK-5863: revert volume snapshot for KVM/QCOW2




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Fixing syntax error introduced in PR #717

2015-08-24 Thread miguelaferreira
Github user miguelaferreira commented on the pull request:

https://github.com/apache/cloudstack/pull/722#issuecomment-134105943
  
@bhaisaab 

You are very welcome.

Just one thing, when I look at master I see this PR was not merged. I mean, 
there is no merge commit, and the SHAs of my commits are different in master 
than in the PR.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Fixing syntax error introduced in PR #717

2015-08-24 Thread bhaisaab
Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/722#issuecomment-134107177
  
@miguelaferreira yeah, I could not make the git-pr script work on my 
system; so used the old one. have figured the issue, will use the git-pr script 
next time.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8749: Add checks to prevent ma...

2015-08-24 Thread bhaisaab
GitHub user bhaisaab opened a pull request:

https://github.com/apache/cloudstack/pull/733

CLOUDSTACK-8749: Add checks to prevent malformed/unexpected input

Based on @jburwell's comment on PR #718


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shapeblue/cloudstack kvm-linkbr-checks

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/733.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #733


commit 86d29c48a9854350293c1821154215988dd3ea11
Author: Rohit Yadav 
Date:   2015-08-24T09:16:09Z

CLOUDSTACK-8749: Add checks to prevent malformed/unexpected input

Based on @jburwell's comment on PR #718

Signed-off-by: Rohit Yadav 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8443: Support CentOS 7 as KVM ...

2015-08-24 Thread bhaisaab
Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/731#issuecomment-134107765
  
@remibergsma looks good, but let me test it and get back to you on this; 
also for a small patch a single commit is preferred as multiple commits dilute 
the main motive of the fix when someone is browsing git history or referencing 
in future - 'Supporting CentOS7 as KVM hypervisor host'


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


IPv6 in ACS and Basic Zones

2015-08-24 Thread Boris Schrijver
Hi all,

The first steps toward IPv6 support [0] had been taken by Sheng Yang in late
2012 / early 2013. [1][2] Since then it has been awfully quite around IPv6. Remi
Bergsma from Schuberg Philis created a design document for IPv6 in VPCs but had
not implemented it yet. [3] I'm going to give a try at implementing IPv6 for
basic zones and lay a good base for IPv6 in VPC's, although the latter will not
be my main concern right now. [4]

In my opinion the code written for IPv6 in the ACS project is a not of very much
help and misses a few concepts. (Besides the basic implementation) MySQL tables
where created for IPv6 in ACS version 4.1 and have thereafter never been
changed.

The question which I would like to ask to all developers:

Do any of you use IPv6 in ACS or know people/parties who use it? The code from
Sheng Yang his ipv6 branch, not a custom implementation.

If none use it I will rewrite it the IPv6 part entirely and start a firm and
clean base, this will include restructuring the IPv6 database tables, concepts
and layout.

Best regards,

Boris Schrijver

TEL: +31633784542
MAIL: bo...@pcextreme.nl 

[0] https://issues.apache.org/jira/browse/CLOUDSTACK-452
[1] https://issues.apache.org/jira/browse/CLOUDSTACK-673
[2] https://github.com/apache/cloudstack/commits/ipv6
[3] https://cwiki.apache.org/confluence/display/CLOUDSTACK/IPv6+in+VPC+Router
[4] https://issues.apache.org/jira/browse/CLOUDSTACK-674

[GitHub] cloudstack pull request: Git PR merge script improvements

2015-08-24 Thread remibergsma
GitHub user remibergsma opened a pull request:

https://github.com/apache/cloudstack/pull/734

Git PR merge script improvements

Processed feedback from @bhaisaab and (a colleague of) @karuturi 

- make the help message better (I also updated Confluence)
- make sure we can use it on other repo's as well (Documentation and such)

Tested it and works fine for me.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/remibergsma/cloudstack git-pr-errormsg

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/734.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #734


commit 23b93659967d82494207e8804b8091cb031126f6
Author: Remi Bergsma 
Date:   2015-08-24T09:52:03Z

Improve error/help message in case of missing git remote

commit 69d751c6cdad63b358f09bdcf529802ba3828fa6
Author: Remi Bergsma 
Date:   2015-08-24T09:59:24Z

make it work with any Apache repository mirrored on GitHub




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8443: Support CentOS 7 as KVM ...

2015-08-24 Thread remibergsma
Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/731#issuecomment-134154979
  
@borisroman @bhaisaab Thanks for testing! 

I'll have another look at the commits and see if it makes sense to quash 
some of them together (I'll make them atomic).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8733: Host stuck in rebalancin...

2015-08-24 Thread remibergsma
Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/698#issuecomment-134155661
  
@koushik-das Thanks for merging, sorry I forgot to do it for you ;-) Could 
you have a look at this script, to help you merge it? 
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61311655 If 
you have feedback or need help: let me know! 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8749: Add checks to prevent ma...

2015-08-24 Thread remibergsma
Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/733#issuecomment-134158150
  
@bhaisaab Can you send this PR against master please? For now, I'd rather 
merge to master, then cherry-pick back to 4.5 as I want to prevent all the 
cherry-picks in master (as we need to put them in a PR anyway in order for the 
tests to run first).

Once 4.6 is out and we'll be working on 4.7, we'll be able to send PRs 
against 4.6, then merge forward to 4.7/master.

Pinging @karuturi 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8749: Add checks to prevent ma...

2015-08-24 Thread bhaisaab
Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/733#issuecomment-134160459
  
@remibergsma merges cleanly on master, if you LGTM; I can merge this on 
master and 4.5


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Git PR merge script improvements

2015-08-24 Thread karuturi
Github user karuturi commented on the pull request:

https://github.com/apache/cloudstack/pull/734#issuecomment-134160535
  
tested with a cloudstack-docs-admin PR and a cloudstack PR. worked great. 
Thanks for the update. 
:+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8749: Add checks to prevent ma...

2015-08-24 Thread bhaisaab
Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/733#issuecomment-134160495
  
@remibergsma sending another PR just for master


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8749: Add checks to prevent ma...

2015-08-24 Thread bhaisaab
GitHub user bhaisaab opened a pull request:

https://github.com/apache/cloudstack/pull/735

CLOUDSTACK-8749: Add checks to prevent malformed/unexpected input

Based on @jburwell's comment on PR #718

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shapeblue/cloudstack kvm-linkbr-checks-master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/735.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #735


commit 972117e5ebf5e04302d0b915e40a10040dbbe00f
Author: Rohit Yadav 
Date:   2015-08-24T09:16:09Z

CLOUDSTACK-8749: Add checks to prevent malformed/unexpected input

Based on @jburwell's comment on PR #718

Signed-off-by: Rohit Yadav 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8749: Add checks to prevent ma...

2015-08-24 Thread bhaisaab
Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/733#issuecomment-134161439
  
@remibergsma here: https://github.com/apache/cloudstack/pull/735


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Git PR merge script improvements

2015-08-24 Thread terbolous
Github user terbolous commented on the pull request:

https://github.com/apache/cloudstack/pull/734#issuecomment-134163369
  
Might not be related as this is the first time I try the script, but I'm 
getting this:
eriweb@eriweb:~/git/cloudstack/tools/git master$ git pr 735 --force
WARNING: You used --force to merge a PR with non-clean merge state 
'unstable'.
ERROR: We couldn't find a git remote pointing to 'apache/cloudstack.git' to 
merge the PR from.
INFO: Current remotes:
origin  g...@github.com:apache/cloudstack (fetch)
origin  g...@github.com:apache/cloudstack (push)

Seems to be because i used the g...@github.com (which lacks the .git 
suffix), rather than the https form. Should be an easy fix (probably just drop 
the .git while greping)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Git PR merge script improvements

2015-08-24 Thread terbolous
Github user terbolous commented on the pull request:

https://github.com/apache/cloudstack/pull/734#issuecomment-134163621
  
On the other side, if you just drop the '.git' suffix, you risk matching 
things like 'cloudstack-docs-rn' while you really mean 'cloudstack'


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8733: Host stuck in rebalancin...

2015-08-24 Thread koushik-das
Github user koushik-das commented on the pull request:

https://github.com/apache/cloudstack/pull/698#issuecomment-134164677
  
@remibergsma I used the script to do the merge. This is how I used it 
tools/git/git-pr 698


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8749: Add checks to prevent ma...

2015-08-24 Thread remibergsma
Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/733#issuecomment-134164753
  
@bhaisaab Thanks, now the tests can run on master as well :-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8749: Add checks to prevent ma...

2015-08-24 Thread remibergsma
Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/733#issuecomment-134164828
  
LGTM on this one, will do the other once the tests are done.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Git PR merge script improvements

2015-08-24 Thread remibergsma
Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/734#issuecomment-134165204
  
@terbolous You need to point to the Apache mirror on GitHub, not your fork. 
The PRs are at the mirror repository. Also, the version from this PR gives more 
descriptive error messages. Another thing I note is that you do not have the 
Apache upstream repo in your remotes. Please see: 
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61311655 Let 
me know if you need more help!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Git PR merge script improvements

2015-08-24 Thread bhaisaab
Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/734#issuecomment-134165993
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Git PR merge script improvements

2015-08-24 Thread terbolous
Github user terbolous commented on the pull request:

https://github.com/apache/cloudstack/pull/734#issuecomment-134167474
  
@remibergsma it does point to the apache repo, but with a somewhat 
different url

I used 'git clone gh:apache/cloudstack' to initialize the repo, and that 
doesn't seem to include .git in the path.

My url: g...@github.com:apache/cloudstack 
Script expected url: g...@github.com:apache/cloudstack.git (or using https 
mode)
Both works, so I just wanted to give a heads up as more people might 
experience the same.

It is true that I didn't have the apache official repo added yet, but that 
isn't relevant to the error.

I can fix it on my end by changing the path to include .git, but this can 
easily confuse others (as the repo is present)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8733: Host stuck in rebalancin...

2015-08-24 Thread bhaisaab
Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/698#issuecomment-134168798
  
@koushik-das this issue seems to affect 4.5.0, have you already or can you 
port/merge this on 4.5 branch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8443: Support CentOS 7 as KVM ...

2015-08-24 Thread bhaisaab
Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/731#issuecomment-134169583
  
just to clarify I've not tested this against a real env, just reviewed the 
code; there are few cgroup related things I don't completely grok but I'll 
invest time on them


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8765: fix vm migration failure...

2015-08-24 Thread ustcweizhou
GitHub user ustcweizhou opened a pull request:

https://github.com/apache/cloudstack/pull/736

CLOUDSTACK-8765: fix vm migration failure due to different dev name on KVM



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ustcweizhou/cloudstack CLOUDSTACK-8765

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/736.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #736


commit bb8f7c652e42caacff5adce1ce60342603677605
Author: Wei Zhou 
Date:   2015-08-24T12:28:13Z

CLOUDSTACK-8765: fix vm migration failure due to different dev name on KVM




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8733: Host stuck in rebalancin...

2015-08-24 Thread koushik-das
Github user koushik-das commented on the pull request:

https://github.com/apache/cloudstack/pull/698#issuecomment-134173550
  
@bhaisaab I haven't merged it to 4.5


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Git PR merge script improvements

2015-08-24 Thread remibergsma
Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/734#issuecomment-134174620
  
@terbolous Ah, I see your point now ;-) Thanks, I will make it work.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8733: Host stuck in rebalancin...

2015-08-24 Thread bhaisaab
Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/698#issuecomment-134176791
  
@koushik-das if this applies for 4.5.x, it would be great to have it in 4.5 
branch as well


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-5863: revert volume snapshot f...

2015-08-24 Thread wido
Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/732#issuecomment-134179676
  
LGTM to me.

We should however stay as far away as possible from invoking all kinds of 
scripts.

Implementing this for RBD is also a lot easier since you laid some 
groundwork. The java RBD bindings should be able to do this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: SDN solutions in use today with CloudStack

2015-08-24 Thread Simon Weller

>The others I have never tried. Really wondering if anyone is using GRE in 
>CloudStack?

Just FYI. There was a post today on the user lists where someone was attempting 
to setup GRE, so it appears it is probably out there.

- Si

> On 20 Aug 2015, at 20:41, Simon Weller  wrote:
>
> Hi all,
>
> We  are currently exploring options for improving our networking setup (read 
> SDN) within CS for our advanced zones.
>
> There are a few plugins currently available for various third party SDN 
> providers (Nicira, Big Switch VNS, MidoNet, Stratosphere SSP, Nuage VSP  et 
> al), as well as some pre-SDN functionality using native VXLAN, OVS GRE and of 
> course vlans.
>
> Most of the organizations mentioned above appear to have drunken the 
> OpenStack kool-aid and don't even mention support for CloudStack on their 
> commercial websites.
>
> It seems that some of these plugins are getting rather old now and I'd be 
> interesting to know (if you're willing to share) what is in use in the 
> community today.
>
> - Si
>
>
>



[GitHub] cloudstack pull request: Git PR merge script improvements

2015-08-24 Thread remibergsma
Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/734#issuecomment-134198135
  
@terbolous Hmm, the default always includes .git in the end (both for https 
and ssh). Although, as you said, omitting the .git part works (in both cases). 
Just submitted a patch to make it work, please test.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8443: Support CentOS 7 as KVM ...

2015-08-24 Thread remibergsma
Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/731#issuecomment-134211424
  
Squashed some commits that belong to each other.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Git PR merge script improvements

2015-08-24 Thread remibergsma
Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/734#issuecomment-134215959
  
@terbolous Squashed the latest fix into an earlier commit, as that makes 
more sense. If you want to see the diff that should fix your issue, look here: 
https://github.com/remibergsma/cloudstack/commit/221e0e3d8340e10d8231677347a42d5f14eec9b0


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: [cloudstack] Changed variable s_logger to non-static and fixed its name in “com.cloud.utils.component.ComponentLifecycleBase” and its subclasses (#714)

2015-08-24 Thread Rafael Weingärtner
No trouble Rajani ;)

We worked just because we already had all of the classes mapped that would
need some work.

On Mon, Aug 24, 2015 at 1:19 AM, Rajani Karuturi  wrote:

> Hi Rafael,
> I assigned the issue while doing some jira cleanup. I saw some PRs in the
> comments. I thought you werent able to assign it yourslef as you didnt have
> the required permissions. Hence, I gave them and assigned the ticket to
> you. sorry for the trouble.
>
> ~Rajani
>
> On Sat, Aug 22, 2015 at 2:22 AM, Daan Hoogland 
> wrote:
>
> > H Rafael, I saw Rajani assigning the ticket to Pedro and as he created
> it I
> > thought he would be informed of it so he can undo if needed.
> >
> > Thanks for the report. Due to the extensiveness I can not determine the
> > full implication but as it seems the largest part (132/167) are spring
> > instantiated singletons I am alright with investigating further.
> >
> > You can reopen or create a new PR. Equal to me but for your own tracking
> > reopening the last one might be convenient.
> >
> > As far as I know the @Local are remnants of an abandoned architectural
> > path. Investigation needed. You will find some corpses and babies in
> > closets on this quest! good hunting and thanks for picking it up.
> >
> > On Fri, Aug 21, 2015 at 9:54 PM, Rafael Weingartner <
> > notificati...@github.com> wrote:
> >
> > > Hi @DaanHoogland , after we opened
> the
> > > Jira Ticket, someone ended up assigning them to us!? So, we decided to
> > take
> > > a lead and analyzed the impact that the proposed changed may cause. It
> > > turns out that most of the classes of that hierarchic are singletons,
> > > therefore it would not have an impact on memory consumption. The result
> > of
> > > the analysis is the following:
> > >
> > > Beans instantiated with @Component :
> > > 1.
> > >
> >
> /cloudstack/engine/storage/src/org/apache/cloudstack/storage/allocator/LocalStoragePoolAllocator.java
> > > 2.
> > >
> >
> /cloudstack/engine/storage/src/org/apache/cloudstack/storage/allocator/ZoneWideStoragePoolAllocator.java
> > > 3.
> > >
> >
> /cloudstack/plugins/api/rate-limit/src/org/apache/cloudstack/ratelimit/ApiRateLimitServiceImpl.java
> > > 4.
> > >
> >
> /cloudstack/server/src/com/cloud/agent/manager/authn/impl/BasicAgentAuthManager.java
> > > 5.
> > >
> >
> /cloudstack/plugins/network-elements/bigswitch/src/com/cloud/network/element/BigSwitchBcfElement.java
> > > 6.
> > >
> >
> /cloudstack/plugins/network-elements/brocade-vcs/src/com/cloud/network/element/BrocadeVcsElement.java
> > > 7.
> > >
> >
> /cloudstack/server/src/com/cloud/hypervisor/CloudZonesStartupProcessor.java
> > > 8. /cloudstack/server/src/com/cloud/alert/ClusterAlertAdapter.java
> > > 9.
> > >
> >
> /cloudstack/engine/orchestration/src/com/cloud/cluster/agentlb/ClusterBasedAgentLoadBalancerPlanner.java
> > > 10.
> /cloudstack/server/src/com/cloud/alert/ConsoleProxyAlertAdapter.java
> > > 11.
> > >
> >
> /cloudstack/plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java
> > > 12.
> > >
> >
> /cloudstack/plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailVpcElementImpl.java
> > > 13.
> > >
> >
> /cloudstack/plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ManagementNetworkGuru.java
> > > 14.
> > >
> >
> /cloudstack/engine/schema/src/com/cloud/upgrade/DatabaseIntegrityChecker.java
> > > 15. /cloudstack/server/src/com/cloud/resource/DummyHostDiscoverer.java
> > > 16.
> > >
> >
> /cloudstack/plugins/network-elements/elastic-loadbalancer/src/com/cloud/network/element/ElasticLoadBalancerElement.java
> > > 17.
> > >
> >
> /cloudstack/server/src/com/cloud/agent/manager/allocator/impl/FirstFitAllocator.java
> > > 18.
> > >
> >
> /cloudstack/server/src/com/cloud/agent/manager/allocator/impl/RecreateHostAllocator.java
> > > 19.
> > >
> >
> /cloudstack/plugins/network-elements/globodns/src/com/globo/globodns/cloudstack/element/GloboDnsElement.java
> > > 20.
> > >
> >
> /cloudstack/plugins/network-elements/midonet/src/com/cloud/network/guru/MidoNetGuestNetworkGuru.java
> > > 21.
> > >
> >
> /cloudstack/plugins/network-elements/ovs/src/com/cloud/network/guru/OvsGuestNetworkGuru.java
> > > 22.
> > >
> >
> /cloudstack/plugins/network-elements/vxlan/src/com/cloud/network/guru/VxlanGuestNetworkGuru.java
> > > 23.
> > >
> >
> /cloudstack/plugins/network-elements/midonet/src/com/cloud/network/element/MidoNetElement.java
> > > 24.
> > >
> >
> /cloudstack/plugins/network-elements/nicira-nvp/src/com/cloud/network/element/NiciraNvpElement.java
> > > 25.
> > >
> >
> /cloudstack/plugins/network-elements/opendaylight/src/main/java/org/apache/cloudstack/network/opendaylight/OpendaylightElement.java
> > > 26.
> > >
> >
> /cloudstack/plugins/host-allocators/random/src/com/cloud/agent/manager/allocator/impl/RandomAllocator.java
> > > 27. /cloudstac

[GitHub] cloudstack pull request: CLOUDSTACK-8733: Host stuck in rebalancin...

2015-08-24 Thread remibergsma
Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/698#issuecomment-134219947
  
@koushik-das Thanks for letting me know, there might be an issue because 
part of the merge message is missing. Will fix it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8758: Handle redirects in comm...

2015-08-24 Thread miguelaferreira
GitHub user miguelaferreira opened a pull request:

https://github.com/apache/cloudstack/pull/737

CLOUDSTACK-8758: Handle redirects in communication with NXS controller 
(a.k.a. Nicira NVP)

When an NSX controller node is part of a cluster it will redirect API calls 
to the master controller. Because the ACS management server does not follow 
such redirects, if there is a change of master within a NSX controller, the NSX 
device (a.k.a.  NiciraNvp) needs to be reconfigured (via the management server 
DB).

The goal of this PR is to enable ACS management server to follow HTTP 
redirects sent by NSX controllers. However, other changes were made to the 
cloud-utils module that provides the REST client that the NSX plugin uses.

Cosmetic changes:
 * Upgrade maven module structure for cloud-utils and 
cloud-plugin-netowkr-nvp to comply with maven default
* Several refactorings on both modules to consistently format the code, 
remove unused code, declare final when possible, remove auto generated 
comments, etc

Other changes:
* Upgrade HTTP library used in REST client to latest version of Apache HTTP 
Components
* Implement NSX specific REST client that support following HTTP redirects
* Simplify NSX api implementation
* Previously existing unit tests for both the REST client and NSX api were 
either maintained in the same test classes, moved to new test classes (because 
code under tests also moved), or removed (because code under tests was also 
removed)
* New Marvin tests for NSX controllers

Testing:
* Ran all unit tests present in the project
* Ran Java Integration tests for NSX api targeting both a master and a 
slave controller
* Ran new Marvin test for NSX controller
* Manual inspection of logs to confirm redirection is taking place


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/miguelaferreira/cloudstack 
feature/mferreira/ncx-follow-redirects-gardened-rebase

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/737.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #737


commit 31679f7dbcb861277b03849f5ffa7a805192f3ec
Author: Miguel Ferreira 
Date:   2015-08-05T14:03:28Z

Create Nicira NVP devices and enable plugin at deploy

commit fcd39e8586ae367e946b327409c0390ac23b0cb5
Author: Miguel Ferreira 
Date:   2015-08-21T15:39:02Z

Add Marvin test for Nicira NVP plugin

commit 357a223cc210a27696eada3abfa37df33b574739
Author: Miguel Ferreira 
Date:   2015-08-23T14:11:06Z

Fix unit-test library dependencies

- XML formatting
- Fix license header

- Reorder hamcrest, junit, mockito and powermock dependencies
  * Since several libraries include a subset of hamcrest classes,
hamcrest should be declared first in the pom, inorder for its
classes to be loaded first by the JVM
- Depdend on hamcrest-all and exclude hamcrest classes from other
  libraries

commit a92c419231f1383f66929e59a8c9e2de2e3e70f7
Author: Miguel Ferreira 
Date:   2015-08-23T14:03:11Z

Refactor cloud-utils project into Maven default structure

commit ebe27281651ac7a0e8959c48aa41948a25006e0d
Author: Miguel Ferreira 
Date:   2015-08-22T18:48:27Z

Refactor cloud-plugin-network-nvp project into Maven default structure

commit 9018ab4be818c418779d44bcde0a2b9b8e1ea366
Author: Miguel Ferreira 
Date:   2015-08-22T18:53:12Z

Code clean up in cloud-utils project

- Code formatting
- Remove unused methods

commit fafc33c7bf2ca65eafc9a0ee78ee8ae6781dd32e
Author: Miguel Ferreira 
Date:   2015-08-21T15:44:57Z

Add basic RestClient implentation based on HTTP Components 4.5

- Upgrade version of HTTP Components to 4.5
- Add helper class to create Http clients
- Add helper class to build http requests
- Add enum with the different Http Methods
- Add constants class for HTTP related values

commit 87e5852edb22910b57d756a656f361638810f0ae
Author: Miguel Ferreira 
Date:   2015-08-22T18:53:28Z

Code clean up in cloud-plugin-network-nvp project

- Code formatting
- Declare final where possible
- Remove unused methods
- Remove throws declarations where not needed
- Remove generated comments (e.g. "TODO Auto-generated method stub")

commit 151ed6e032ba5a7a0bb0e8b89fbe48fea71664ac
Author: Miguel Ferreira 
Date:   2015-08-23T13:11:29Z

Delegate HTTP protocol activity in RESTServiceConnector to RestClient

- All HTTP protocol activities are now handled by RestClient
- This service is now only responsible for creating requests, and
  dispatching them to the client
- Provides a Simple API for creating, updating, retrieving and deleting
  objects

commit 4af32bcf13ad3f30a4f30a24a1c86bb0eb4031a0
Author:

[GitHub] cloudstack pull request: Quota master

2015-08-24 Thread jburwell
Github user jburwell commented on the pull request:

https://github.com/apache/cloudstack/pull/689#issuecomment-134245543
  
@abhi An connection pool makes acquiring a scarce resource less expensive, 
but it is not cost-free.  By taking a connection when the pool is under load, 
the following could occur:

* This code may request a connection when none are available causing the 
connection pool to create another ad hoc connection or blocking the thread 
until a connection becomes available -- dependent on the pool configuration.
* This code may exhaust the last connection in the pool causing other 
thread(s) to create ad hoc connection(s) or to block waiting for a connection 
to become available -- dependent on the pool configuration.

There are variety of patterns that can be employed to address this problem. 
  I lean towards a construct such as the following:

```
Transaction transaction = new Transaction(USAGE_DB).attempt(new 
TransactionWork() {

  public void execute(final Connection connection) throws SQLException{

 // Do database work ...
  }

}
```

The ``Transaction.attempt`` method wraps the call to the passed 
``TransactionWork.execute`` method with the following boilerplate that appears 
throughout the code base:

1. Capturing the current database ID from ``TransactionLegacy``
2. Open a connection to the requested database
3. Handling exceptions including translation and proper logging
4. Aborting/commiting/closing the transaction via ``TransactionLegacy`` as 
needed
5. If necessary, switching ``TransactionLegacy`` back to the previous 
database ID

These steps assume that ``TransactionLegacy`` has a ``switch`` method that 
changes the ``ThreadLocal`` tracking the current database ID without consuming 
a connection from the pool.

I prefer this approach because it allows DAO to declare transactional 
blocks in a side-effect free manner.  This form of code should be immune to a 
replacement of ``TransationLegacy`` because it only relies on the JDBC API and 
makes no assumptions about the call flow.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Fix for missing defaultroute on VPC route...

2015-08-24 Thread michaelandersen
GitHub user michaelandersen opened a pull request:

https://github.com/apache/cloudstack/pull/738

Fix for missing defaultroute on VPC router 

https://issues.apache.org/jira/browse/CLOUDSTACK-8685

Refactored CsRoute and CsAddress to:
 - add methods to add and verify the defaultroute
 - renamed methods flush, add, and routeTable to flush_table, add_route, 
add_table respectively. 

Added some suboptimal unit tests to TestCsRoutes

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/michaelandersen/cloudstack 
vpc_defaultroute_fix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/738.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #738


commit bb93a61ee70de491ef52806785828e3903f53853
Author: Michael Andersen 
Date:   2015-08-24T09:59:35Z

pep8 cleanup

commit a9eb4ba5c90136176b5ec395f0444a489abc639e
Author: Michael Andersen 
Date:   2015-08-24T10:53:19Z

Fixed defaultroute on VPC routers in CsRoute and CsAddress
Refactored CsRoute




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8749: Add checks to prevent ma...

2015-08-24 Thread remibergsma
Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/735#issuecomment-134329574
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8761: Replace some profiler.ge...

2015-08-24 Thread remibergsma
Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/730#issuecomment-134331260
  
@ustcweizhou Thanks for fixing this!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Fix for missing defaultroute on VPC route...

2015-08-24 Thread remibergsma
Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/738#issuecomment-134343822
  
LGTM
Deployed advanced zone with two VPCs, each with a tier, two VMs. Verified 
the default routes were there (and that the VMs could reach the internet)

```
root@r-6-VM:~# ip route show
default via 192.168.23.1 dev eth1 
10.0.2.0/24 dev eth2  proto kernel  scope link  src 10.0.2.1 
169.254.0.0/16 dev eth0  proto kernel  scope link  src 169.254.1.232 
192.168.23.0/24 dev eth1  proto kernel  scope link  src 192.168.23.5 
```

Note: In my dev environment `192.168.23.1` is the public gateway.

Created site-to-site VPNs and now those also work without modification.
Nice work @michaelandersen :-)

Minor comment: please prepend the PR title with "CLOUDSTACK-8685: "

@karuturi @jayapalu Could one of you also review this? Thanks! 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Git PR merge script improvements

2015-08-24 Thread terbolous
Github user terbolous commented on the pull request:

https://github.com/apache/cloudstack/pull/734#issuecomment-134350634
  
Verified that it now works on my weird URL as well.

LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8443: Support CentOS 7 as KVM ...

2015-08-24 Thread remibergsma
Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/731#issuecomment-134363088
  
@bhaisaab No worries, took me some time as well to understand how it is 
supposed to work and I'm also still learning.

In the Jira issue you mention two issues. The first:
```
org.libvirt.LibvirtException: Controller 'cpuacct' is not wanted, but 'cpu' 
is co-mounted: Invalid argument
```

This is due to the co-mount: both 'cpu' and 'cpuacct' are on one mount 
point, and our previous config instructs it to use only 'cpu'. So, the 
'cpuacct' is `not wanted` by our config. This was solved in my PR by relying on 
the default.

The second issue:
```
unsupported configuration: CPU tuning is not available on this host
```

This issue also went away by updating the `libvirtd` config. When I look at 
the Libvirt source 
(https://github.com/virtualopensystems/libvirt/blob/master/src/qemu/qemu_cgroup.c#L635)
 I see this error is thrown in qemu_cgroup.c I assume the 
VIR_ERR_CONFIG_UNSUPPORTED aka `unsupported configuration` also has to do with 
the rather weird cgroup config that we put there before but I don't know for 
sure.

If you have some time, please give it a go. I'll also ask @wilderrodrigues 
to review it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Git PR merge script improvements

2015-08-24 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/734


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8757:FTP modules are not loade...

2015-08-24 Thread remibergsma
Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/729#issuecomment-134364759
  
@shwetaag Could you change the title to: "CLOUDSTACK-8757: Test to verify 
if FTP modules are loaded in VR" as right now it looks like there is a defect, 
which there is not.

Also, could you post the test results please. I'll have a look tomorrow and 
see if I can run the test as well.

Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8749: Add checks to prevent ma...

2015-08-24 Thread remibergsma
Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/735#issuecomment-134364893
  
@jburwell can you review this please? Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8749: Add checks to prevent ma...

2015-08-24 Thread remibergsma
Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/733#issuecomment-134364934
  
@jburwell can you review this please? Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...

2015-08-24 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/714#issuecomment-134380116
  
I think that the best way to merge this PR is for us to create it over a 
head version. We have a script that changes almost everything automatically. 
Therefore, whenever you approve this PR and want to merge it, we can get the 
head revision of master, execute our scripts and commit the changes


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: review wanted

2015-08-24 Thread Rafael Weingärtner
Hi Daan,
I think that we should do a proper introduction.
It might seem kind of odd to some people that a bunch of folks suddenly
started working for free.

Our first PR was done a while ago:
https://github.com/apache/cloudstack/pull/560. Then we did
https://github.com/apache/cloudstack/pull/700, and the last one was the
https://github.com/apache/cloudstack/pull/714, that is still in the review
process.

Until now you know Pedro (PR 714) and Critofolini (PR 700), but we are a
team of five. We work under the same project and the improvements/clean ups
that we have been doing to the ACS is a way we found to improve our
knowledge of the software that we are using.

I am a Ph. D. candidate, researching/developing autonomic models that can
be used to manage and optimize a cloud computing environment that provide
infrastructure as a service. We have done an extensive work comparing and
discussing cloud computing orchestration platforms that are most widely
used. CloudStack was the orchestration tool chosen to develop my proposals,
in order to test and validate them.

I have several undergrad students working with me; none of them had real
experience developing java web applications, the PRs we are creating is the
way we found to teach them some Java developing skills, while getting to
know a little better of ACS core and architecture. At the same time we are
contributing to the software we use.

The team that works with me and you will probably see creating more PRs is
the following:

   - Gabriel Beims Bräscher
   - Pedro Henrique Pereira Martins
   - Lucas Berri Cristofolini
   - Alexandre Santana


All of them are Computer Science student. They all are developing their
graduation projects within my thesis.  Sadly, some of the things we are
doing here and that we have already prototyped, we cannot commit to the ACS
community (at least not yet); hence it is part of a thesis project.
However, once we start publishing papers, I think you will like what we
have been working on.

Hope we can keep up the good work and keep learning with you all guys from
the ACS community.
Waiting to hear the feedbacks on PR 714 ;)


On Sat, Aug 22, 2015 at 1:10 AM, Daan Hoogland 
wrote:
>
> everybody, I will LGTM PR #714 [1] and I would like to have more then one
> extra pair of eyes this time. Some group of folks, I know there is at
least
> three of them, have decided to invest in cleaning some code in CS and I
> think their work deserves full attention. they worked on refactoring some
> of the CitrixResourceBase hierarchy [2] and now they are busy on the
> ComponentLifecycleBase
> hierarchy.
>
> Please have a look,
>
> [1] https://github.com/apache/cloudstack/pull/714
> [2] https://github.com/apache/cloudstack/pull/700
>
> --
> Daan




--
Rafael Weingärtner


[GitHub] cloudstack pull request: CLOUDSTACK-8733: Host stuck in rebalancin...

2015-08-24 Thread koushik-das
Github user koushik-das commented on the pull request:

https://github.com/apache/cloudstack/pull/698#issuecomment-134467595
  
@bhaisaab Should I simply cherry-pick to 4.5 branch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---



[GitHub] cloudstack pull request: CLOUDSTACK-8733: Host stuck in rebalancin...

2015-08-24 Thread bhaisaab
Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/698#issuecomment-134472326
  
@koushik-das yes that will work, you may also send a PR with the 
cherry-picked commit so we can be sure it does not break smoke tests/travis


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[ANNOUNCE] Apache CloudStack CloudMonkey 5.3.2

2015-08-24 Thread Rohit Yadav
25 August 2015 —Apache CloudStack, the mature, turnkey Open Source
cloud computing software platform used for creating private, public,
and hybrid cloud environments, today announced Apache CloudMonkey
v5.3.2, the latest release of its command line interface tool.

CloudMonkey is written in Python, and can be used both as an
interactive shell and as a command line tool that simplifies
CloudStack configuration and management.

Apache CloudMonkey v5.3.2 is the latest feature release of the 5.x
line that was first released in September 2013. The changes in this
version includes;

* A new CSV output/display mode
* A new XML output/display mode
* Tabular output improvements
* API Response checking improvements
* Better SSL based request support
* Better spinner printing for async blocker api calls
* Configurable API signature version

Downloads and Documentation

The official source code for CloudMonkey v5.3.2 can be downloaded from
http://cloudstack.apache.org/downloads.html. A community-maintained
distribution is available at the Python Package Index (PyPi) at
http://pypi.python.org/pypi/cloudmonkey/

CloudMonkey's usage is documented at
https://cwiki.apache.org/confluence/display/CLOUDSTACK/CloudStack+CloudMonkey+CLI

Package documentation can be found at http://pythonhosted.org/cloudmonkey/

Availability and Oversight

As with all Apache products, CloudMonkey v5.3.2 is released under the
Apache License v2.0, and is overseen by a self-selected team of active
contributors to the project. The Apache CloudStack Project Management
Committee (PMC) guides the Project's day-to-day operations, including
community development and product releases.

About Apache CloudStack

Apache CloudStack is a mature, turnkey integrated
Infrastructure-as-a-Service (IaaS) Open Source software platform that
allows users to build feature-rich public and private cloud
environments. Hailed by Gartner Group as "a solid product", CloudStack
includes an intuitive user interface and rich APIs for managing the
compute, networking, software, and storage infrastructure resources.
CloudStack entered the Apache Incubator in April 2012 and became an
Apache Top-level Project in March 2013. For downloads, documentation,
and ways to become involved with Apache CloudStack, visit
http://cloudstack.apache.org/ and https://twitter.com/CloudStack

--
Regards.


[ANNOUNCE] Apache CloudStack 4.5.2 release

2015-08-24 Thread Rohit Yadav
25 August 2015 - The Apache CloudStack project is pleased to announce
the 4.5.2 release
of the CloudStack, the cloud orchestration platform. The 4.5.2 release
contains more than 80 bug-fixes and improvements since the last minor
CloudStack 4.5.1 release announced on 11 May 2015.

# Documentation

What's new in CloudStack 4.5:
http://docs.cloudstack.apache.org/projects/cloudstack-release-notes/en/4.5.2/about.html

The 4.5.2 release notes includes full list of corrected issues as well
as upgrade instructions from previous versions of Apache CloudStack.
Please see the Release Notes for a full list of corrected issues and
upgrade instructions:
http://docs.cloudstack.apache.org/projects/cloudstack-release-notes/en/4.5.2/

The official installation, administration and API documentation for
each release are available on our Documentation Page:
http://docs.cloudstack.apache.org/

# Downloads

The official source code for the 4.5.2 release can be downloaded from
our Downloads Page:
http://cloudstack.apache.org/downloads.html

# Availability and Oversight

As with all Apache products, Apache CloudStack v4.5.2 is released
under the Apache License v2.0, and is overseen by a self-selected team
of active contributors to the project. A Project Management Committee
(PMC) guides the Project's day-to-day operations, including community
development and product releases. For documentation and to learn how
to join and contribute to the Apache CloudStack community please visit
our website: http://cloudstack.apache.org

For additional marketing or communications information, please contact
the marketing mailing list: market...@cloudstack.apache.org

Join members of the Apache CloudStack community at the CloudStack
Collaboration Conference, taking place 8-9 October 2015 in Dublin,
Ireland. For more information, visit
http://events.linuxfoundation.org/events/cloudstack-collaboration-conference-europe

# About

Apache CloudStack is open source software designed to deploy and
manage large networks of virtual machines, as a highly available,
highly scalable Infrastructure as a Service (IaaS) cloud computing
platform. CloudStack is used by a number of service providers to offer
public cloud services, and by many companies to provide an on-premises
(private) cloud offering, or as part of a hybrid cloud solution.

CloudStack became an Apache Top-level Project (TLP) in March 2013.
"Apache", "CloudStack", "Apache CloudStack", and "ApacheCon" are
trademarks of The Apache Software Foundation. All other brands and
trademarks are the property of their respective owners.

--
Regards.


[GitHub] cloudstack pull request: Quota master

2015-08-24 Thread abhinandanprateek
Github user abhinandanprateek commented on the pull request:

https://github.com/apache/cloudstack/pull/689#issuecomment-134480002
  
I think we should not be using TransactionLegacy anymore. It was used in 
first place just to be consistent with UsageServer and due to time constraints. 
I think if we should revamp this by using the new translation framework and do 
it like:

Transaction.execute(new TransactionCallback() {
@Override
public Object doInTransaction(TransactionStatus status) {
// ... do something ...
return myresult;
}
});

This is described here by Darren 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Database+Transactions.

I propose that we revamp the Quota with the new Transaction model and as 
well as the usage server as just the one without the other is still half work. 
Will work on that.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8728: Testcase to Verify if VR...

2015-08-24 Thread pritisarap12
Github user pritisarap12 commented on the pull request:

https://github.com/apache/cloudstack/pull/684#issuecomment-134488914
  
Merged the testcase in test_routers.py file.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8728: Testcase to Verify if VR...

2015-08-24 Thread pritisarap12
Github user pritisarap12 commented on the pull request:

https://github.com/apache/cloudstack/pull/684#issuecomment-134489114
  
Testcase result:

Check if Virtual Router has same IP after network restart or not. ... === 
TestName: test_10_vr_has_same_ip | Status : SUCCESS ===
ok

--
Ran 1 test in 294.769s

OK


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8766: Fix infinite scrolling p...

2015-08-24 Thread bhaisaab
GitHub user bhaisaab opened a pull request:

https://github.com/apache/cloudstack/pull/739

CLOUDSTACK-8766: Fix infinite scrolling pagination for zonal template…

… listing

Uses listViewDataProvider to implement pagination on listTemplates API
requests in the UI, when a template's zone tab is viewed.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shapeblue/cloudstack CLOUDSTACK-8766

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/739.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #739


commit 95c76efc3944aab9a620559a026fe37e53d8f53d
Author: Rohit Yadav 
Date:   2015-08-25T05:59:21Z

CLOUDSTACK-8766: Fix infinite scrolling pagination for zonal template 
listing

Uses listViewDataProvider to implement pagination on listTemplates API
requests in the UI, when a template's zone tab is viewed.

Signed-off-by: Rohit Yadav 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8766: Fix infinite scrolling p...

2015-08-24 Thread bhaisaab
GitHub user bhaisaab opened a pull request:

https://github.com/apache/cloudstack/pull/740

CLOUDSTACK-8766: Fix infinite scrolling pagination for zonal template…

… listing

Uses listViewDataProvider to implement pagination on listTemplates API
requests in the UI, when a template's zone tab is viewed.

(cherry picked from commit 95c76efc3944aab9a620559a026fe37e53d8f53d)

This from the other PR, for master branch.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shapeblue/cloudstack CLOUDSTACK-8766-master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/740.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #740


commit 1ad2f848adcccdf23a73b3ee43d05470e95c8d30
Author: Rohit Yadav 
Date:   2015-08-25T05:59:21Z

CLOUDSTACK-8766: Fix infinite scrolling pagination for zonal template 
listing

Uses listViewDataProvider to implement pagination on listTemplates API
requests in the UI, when a template's zone tab is viewed.

(cherry picked from commit 95c76efc3944aab9a620559a026fe37e53d8f53d)
Signed-off-by: Rohit Yadav 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8733: Host stuck in rebalancin...

2015-08-24 Thread koushik-das
Github user koushik-das commented on the pull request:

https://github.com/apache/cloudstack/pull/698#issuecomment-134491115
  
@bhaisaab Cherry-picked to 4.5 with commit 
3d9cbf0bcb011f4012c94f0df040d9b8ddd325bc


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8733: Host stuck in rebalancin...

2015-08-24 Thread bhaisaab
Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/698#issuecomment-134491315
  
@koushik-das thanks :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: [ANNOUNCE] Apache CloudStack 4.5.2 release

2015-08-24 Thread Wido den Hollander
Awesome!

The RPM en DEB packages should come online on cloudstack.apt-get.eu
automatically since Jenkins now syncs them there.

Let's see if that really works.

Wido

On 08/25/2015 07:11 AM, Rohit Yadav wrote:
> 25 August 2015 - The Apache CloudStack project is pleased to announce
> the 4.5.2 release
> of the CloudStack, the cloud orchestration platform. The 4.5.2 release
> contains more than 80 bug-fixes and improvements since the last minor
> CloudStack 4.5.1 release announced on 11 May 2015.
> 
> # Documentation
> 
> What's new in CloudStack 4.5:
> http://docs.cloudstack.apache.org/projects/cloudstack-release-notes/en/4.5.2/about.html
> 
> The 4.5.2 release notes includes full list of corrected issues as well
> as upgrade instructions from previous versions of Apache CloudStack.
> Please see the Release Notes for a full list of corrected issues and
> upgrade instructions:
> http://docs.cloudstack.apache.org/projects/cloudstack-release-notes/en/4.5.2/
> 
> The official installation, administration and API documentation for
> each release are available on our Documentation Page:
> http://docs.cloudstack.apache.org/
> 
> # Downloads
> 
> The official source code for the 4.5.2 release can be downloaded from
> our Downloads Page:
> http://cloudstack.apache.org/downloads.html
> 
> # Availability and Oversight
> 
> As with all Apache products, Apache CloudStack v4.5.2 is released
> under the Apache License v2.0, and is overseen by a self-selected team
> of active contributors to the project. A Project Management Committee
> (PMC) guides the Project's day-to-day operations, including community
> development and product releases. For documentation and to learn how
> to join and contribute to the Apache CloudStack community please visit
> our website: http://cloudstack.apache.org
> 
> For additional marketing or communications information, please contact
> the marketing mailing list: market...@cloudstack.apache.org
> 
> Join members of the Apache CloudStack community at the CloudStack
> Collaboration Conference, taking place 8-9 October 2015 in Dublin,
> Ireland. For more information, visit
> http://events.linuxfoundation.org/events/cloudstack-collaboration-conference-europe
> 
> # About
> 
> Apache CloudStack is open source software designed to deploy and
> manage large networks of virtual machines, as a highly available,
> highly scalable Infrastructure as a Service (IaaS) cloud computing
> platform. CloudStack is used by a number of service providers to offer
> public cloud services, and by many companies to provide an on-premises
> (private) cloud offering, or as part of a hybrid cloud solution.
> 
> CloudStack became an Apache Top-level Project (TLP) in March 2013.
> "Apache", "CloudStack", "Apache CloudStack", and "ApacheCon" are
> trademarks of The Apache Software Foundation. All other brands and
> trademarks are the property of their respective owners.
> 
> --
> Regards.
> 


Build failed in Jenkins: simulator-4.5-singlerun #265

2015-08-24 Thread jenkins
See 

--
Started by upstream project "build-4.5-simulator" build number 320
originally caused by:
 Started by upstream project "build-4.5" build number 517
 originally caused by:
  Started by an SCM change
[EnvInject] - Loading node environment variables.
Building remotely on simulator in workspace 

Cloning the remote Git repository
Cloning repository https://git-wip-us.apache.org/repos/asf/cloudstack.git
 > /usr/bin/git init 
 >  # 
 > timeout=400
Fetching upstream changes from 
https://git-wip-us.apache.org/repos/asf/cloudstack.git
 > /usr/bin/git --version # timeout=400
 > /usr/bin/git fetch --tags --progress 
 > https://git-wip-us.apache.org/repos/asf/cloudstack.git 
 > +refs/heads/*:refs/remotes/origin/*
ERROR: Error cloning remote repo 'origin'
ERROR: Error cloning remote repo 'origin'
[xUnit] [INFO] - Starting to record.
[xUnit] [INFO] - Processing JUnit
[xUnit] [INFO] - [JUnit] - No test report file(s) were found with the pattern 
'xunit.xml' relative to 
' for the 
testing framework 'JUnit'.  Did you enter a pattern relative to the correct 
directory?  Did you generate the result report(s) for 'JUnit'?
[xUnit] [ERROR] - No test reports found for the metric 'JUnit' with the 
resolved pattern 'xunit.xml'. Configuration error?.
[xUnit] [INFO] - Failing BUILD.
[xUnit] [INFO] - There are errors when processing test results.
[xUnit] [INFO] - Skipping tests recording.
[xUnit] [INFO] - Stop build.


Re: [ANNOUNCE] Apache CloudStack 4.5.2 release

2015-08-24 Thread Rohit Yadav
Hi Wido,

On 25-Aug-2015, at 11:42 am, Wido den Hollander 
mailto:w...@widodh.nl>> wrote:

Awesome!

The RPM en DEB packages should come online on 
cloudstack.apt-get.eu
automatically since Jenkins now syncs them there.

Cool.

FYI - I’ve updated the 4.5.2 systemvms here: 
http://cloudstack.apt-get.eu/systemvm/4.5/
The old 4.5 systemvms have been moved to: 
http://cloudstack.apt-get.eu/systemvm/4.5/old

The systemvms in above location were generated from b.a.o Jenkins, and are same 
as on:
http://packages.shapeblue.com/systemvmtemplate/4.5/4.5.2/

ShapeBlue managed BT hosted ACS repos have 4.5.2 rpms/debs here:
http://packages.shapeblue.com/cloudstack/upstream/


Let's see if that really works.

Wido

Regards,
Rohit Yadav
Software Architect, ShapeBlue


[cid:9DD97B41-04C5-45F0-92A7-951F3E962F7A]


M. +91 88 262 30892 | 
rohit.ya...@shapeblue.com
Blog: bhaisaab.org | Twitter: @_bhaisaab




Find out more about ShapeBlue and our range of CloudStack related services

IaaS Cloud Design & Build
CSForge – rapid IaaS deployment framework
CloudStack Consulting
CloudStack Software 
Engineering
CloudStack Infrastructure 
Support
CloudStack Bootcamp Training Courses

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England & Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company 
registered by The Republic of South Africa and is traded under license from 
Shape Blue Ltd. ShapeBlue is a registered trademark.


[GitHub] cloudstack pull request: CLOUDSTACK-8443: Support CentOS 7 as KVM ...

2015-08-24 Thread karuturi
Github user karuturi commented on the pull request:

https://github.com/apache/cloudstack/pull/731#issuecomment-134502526
  
This is what I have done to test

installed a fresh setup with centos63 rpms on MS with 6.3 and KVM host with 
6.3. 
verified that systemvms, VR and user instances successfully started.
verified that cgroup_controllers=["cpu"] doesnt exists at 
host:/etc/libvirt/qemu.conf

installed a fresh setup with centos7 rpms on MS with 7 and KVM host with 7.
verified that systemvms, VR and user instances successfully started.
verified that cgroup_controllers=["cpu"] doesnt exists at 
host:/etc/libvirt/qemu.conf

:+1: 

Thanks for the detailed description :) 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8757:FTP modules are not loade...

2015-08-24 Thread shwetaag
Github user shwetaag commented on the pull request:

https://github.com/apache/cloudstack/pull/729#issuecomment-134502839
  
Result information: 
test_01_FTPModulesInVR 
(integration.component.maint.test_escalations_routers.TestVR) ... === TestName: 
test_01_FTPModulesInVR | Status : SUCCESS ===
ok

--
Ran 1 test in 233.348s

OK



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8685: Fix for missing defaultr...

2015-08-24 Thread karuturi
Github user karuturi commented on the pull request:

https://github.com/apache/cloudstack/pull/738#issuecomment-134503158
  
I do not understand most of this stuff. not a good candidate to review :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8756:Incorrect guest os mappin...

2015-08-24 Thread shwetaag
Github user shwetaag commented on the pull request:

https://github.com/apache/cloudstack/pull/728#issuecomment-134504120
  
result information :

@desc:Incorrect guest os mapping in vmware for CentOS 5.9 and above ... === 
TestName: test2_attach_ISO_in_CentOSVM | Status : SUCCESS ===
ok

--
Ran 1 test in 392.003s

OK



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---