Re: [GitHub] cloudstack pull request: CLOUDSTACK-8693-Adding-missing-code-in-te...

[Sanjeev N]

LGTM!!


On Mon, Aug 10, 2015 at 11:34 AM, pritisarap12  wrote:

> GitHub user pritisarap12 opened a pull request:
>
> https://github.com/apache/cloudstack/pull/668
>
>
> CLOUDSTACK-8693-Adding-missing-code-in-testpath_same_vm_name.py_testpath
>
> -Adding "cls.hypervisor = cls.testClient.getHypervisorInfo()"
> -Fixed pep8 issues
>
> You can merge this pull request into a Git repository by running:
>
> $ git pull https://github.com/pritisarap12/cloudstack
> CLOUDSTACK-8693-Adding-missing-code-in-testpath_same_vm_name.py_testpatha
>
> Alternatively you can review and apply these changes as the patch at:
>
> https://github.com/apache/cloudstack/pull/668.patch
>
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
>
> This closes #668
>
> 
> commit 23ac5588fb354b9ba36c9e0096287c700a85775f
> Author: Priti Sarap 
> Date:   2015-08-10T06:00:55Z
>
>
> CLOUDSTACK-8693-Adding-missing-code-in-testpath_same_vm_name.py_testpatha
> -Adding "cls.hypervisor = cls.testClient.getHypervisorInfo()"
>
> 
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
>

[GitHub] cloudstack pull request: CLOUDSTACK-8704: Schedule restart of rout...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/656#issuecomment-129334661
  
@koushik-das Check. If you fix the commits, I'll LGTM and merge. Let me 
know if you need help.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8711: public_ip type resource ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/662


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8704: Schedule restart of rout...

[koushik-das]

Github user koushik-das commented on the pull request:

https://github.com/apache/cloudstack/pull/656#issuecomment-129335984
  
@remibergsma I have fixed the commits, please check.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Implemented condition that only admin or ...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/658#issuecomment-129336998
  
@manuiiit Thanks! Final request: please squash the 3 commits you have now 
into one. After that, force push to this branch. Once done, I'll LGTM and merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8601. VMFS storage added as lo...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/547#issuecomment-129337423
  
@mike-tutkowski Thanks! It seems the testing / verification is still to do 
and that is the work. Merging itself can be done with a one-liner. Are you able 
to verify the fix in your lab?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

[anshul1886]

GitHub user anshul1886 opened a pull request:

https://github.com/apache/cloudstack/pull/669

Made the adding new keyboard language support easier

This branch has implemented following improvements in console proxy 
keyboard language support

1) ajaxviewer.js and ajaxkeys.js are main files involved in key code 
translations. These files now can be copied in systemvm/js folder and they will 
be copied to CPVM with stop/start performed on it.
2) Started passing parameters to CPVM needed to resolve the ambiguous cases 
of keycode translations.
3) Generalise the framework such that one needs to modify only ajaxkeys.js 
(file which has keycode mappings) without need of much knowledge in js.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/anshul1886/cloudstack-1 nonuskeyboardsupport

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/669.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #669


commit 94995312a97716417cd0bbe7c2a323aa5cc09f5e
Author: Anshul Gangwar 
Date:   2015-08-04T04:54:16Z

Added support for copying js files from management server to console proxy 
VM with stop start

commit 9e5f1c7b071f48d3c608b314e8111f77a0018a0d
Author: Anshul Gangwar 
Date:   2015-08-07T05:45:03Z

Added CopyFileInVmCommand support in ovm3 and simulator and added fallback 
path for js files

commit 130827f928cae4f56cd76a9431745f5959d50349
Author: Anshul Gangwar 
Date:   2015-08-07T08:38:32Z

generalize console proxy keyboard support framework
and added the additional parameters which will be needed for keyboard 
mappings

commit 2d20c2c9b0bfa11157f3412080144df81d149438
Author: Anshul Gangwar 
Date:   2015-08-10T06:27:03Z

Moved the console Keyboard Options to new file so that user can add 
keyboard options easily




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

[sedukull]

Github user sedukull commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/669#discussion_r36608900
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCopyFileInVmCommandWrapper.java
 ---
@@ -0,0 +1,59 @@
+/*
+ *   Licensed to the Apache Software Foundation (ASF) under one
+ *   or more contributor license agreements.  See the NOTICE file
+ *   distributed with this work for additional information
+ *   regarding copyright ownership.  The ASF licenses this file
+ *   to you under the Apache License, Version 2.0 (the
+ *   "License"); you may not use this file except in compliance
+ *   with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *   Unless required by applicable law or agreed to in writing,
+ *   software distributed under the License is distributed on an
+ *   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ *   KIND, either express or implied.  See the License for the
+ *   specific language governing permissions and limitations
+ *   under the License.
+ */
+
+package com.cloud.hypervisor.kvm.resource.wrapper;
+
+import com.cloud.agent.api.Answer;
+import com.cloud.agent.api.CopyFileInVmAnswer;
+import com.cloud.agent.api.CopyFileInVmCommand;
+import com.cloud.hypervisor.kvm.resource.LibvirtComputingResource;
+import com.cloud.resource.CommandWrapper;
+import com.cloud.resource.ResourceWrapper;
+import com.cloud.utils.ssh.SshHelper;
+import org.apache.commons.io.FileUtils;
+import org.apache.commons.io.filefilter.TrueFileFilter;
+import org.apache.log4j.Logger;
+
+import java.io.File;
+
+@ResourceWrapper(handles = CopyFileInVmCommand.class)
+public class LibvirtCopyFileInVmCommandWrapper   extends 
CommandWrapper {
+
+private static final Logger s_logger = 
Logger.getLogger(LibvirtCopyFileInVmCommandWrapper.class);
+
+@Override public Answer execute(CopyFileInVmCommand cmd, 
LibvirtComputingResource libvirtComputingResource) {
+final File keyFile = new File("/root/.ssh/id_rsa.cloud");
+try {
+File file = new File(cmd.getSrc());
--- End diff --

This code seems repetitive, can this be made as a lib, or convert to a 
factory based upon given hypervisor type and use that pattern in each command 
execute call?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

[sedukull]

Github user sedukull commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/669#discussion_r36609019
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 ---
@@ -1279,6 +1285,27 @@ private static DiskTO getIsoDiskTO(DiskTO[] disks) {
 return null;
 }
 
+private CopyFileInVmAnswer execute(CopyFileInVmCommand cmd) {
+VmwareManager mgr = 
getServiceContext().getStockObject(VmwareManager.CONTEXT_STOCK_NAME);
+File keyFile = mgr.getSystemVMKeyFile();
+try {
+File file = new File(cmd.getSrc());
--- End diff --

Does file object consumes a resource to be flushed or closed post the usage 
or its auto closed? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

[sedukull]

Github user sedukull commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/669#discussion_r36609071
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 ---
@@ -1279,6 +1285,27 @@ private static DiskTO getIsoDiskTO(DiskTO[] disks) {
 return null;
 }
 
+private CopyFileInVmAnswer execute(CopyFileInVmCommand cmd) {
+VmwareManager mgr = 
getServiceContext().getStockObject(VmwareManager.CONTEXT_STOCK_NAME);
+File keyFile = mgr.getSystemVMKeyFile();
+try {
+File file = new File(cmd.getSrc());
+if(file.exists()) {
+if(file.isDirectory()) {
+for (File f : FileUtils.listFiles(new 
File(cmd.getSrc()), TrueFileFilter.INSTANCE, TrueFileFilter.INSTANCE)) {
--- End diff --

As well, here if its a directory, we are using multiple file objects, are 
these auto closed and resources consumed are released back or does the api for 
File..provides that facility?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

[sedukull]

Github user sedukull commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/669#discussion_r36609212
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCopyFileInVmCommandWrapper.java
 ---
@@ -0,0 +1,59 @@
+/*
+ *   Licensed to the Apache Software Foundation (ASF) under one
+ *   or more contributor license agreements.  See the NOTICE file
+ *   distributed with this work for additional information
+ *   regarding copyright ownership.  The ASF licenses this file
+ *   to you under the Apache License, Version 2.0 (the
+ *   "License"); you may not use this file except in compliance
+ *   with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *   Unless required by applicable law or agreed to in writing,
+ *   software distributed under the License is distributed on an
+ *   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ *   KIND, either express or implied.  See the License for the
+ *   specific language governing permissions and limitations
+ *   under the License.
+ */
+
+package com.cloud.hypervisor.kvm.resource.wrapper;
+
+import com.cloud.agent.api.Answer;
+import com.cloud.agent.api.CopyFileInVmAnswer;
+import com.cloud.agent.api.CopyFileInVmCommand;
+import com.cloud.hypervisor.kvm.resource.LibvirtComputingResource;
+import com.cloud.resource.CommandWrapper;
+import com.cloud.resource.ResourceWrapper;
+import com.cloud.utils.ssh.SshHelper;
+import org.apache.commons.io.FileUtils;
+import org.apache.commons.io.filefilter.TrueFileFilter;
+import org.apache.log4j.Logger;
+
+import java.io.File;
+
+@ResourceWrapper(handles = CopyFileInVmCommand.class)
+public class LibvirtCopyFileInVmCommandWrapper   extends 
CommandWrapper {
+
+private static final Logger s_logger = 
Logger.getLogger(LibvirtCopyFileInVmCommandWrapper.class);
+
+@Override public Answer execute(CopyFileInVmCommand cmd, 
LibvirtComputingResource libvirtComputingResource) {
+final File keyFile = new File("/root/.ssh/id_rsa.cloud");
+try {
+File file = new File(cmd.getSrc());
+if(file.exists()) {
+if(file.isDirectory()) {
+for (File f : FileUtils.listFiles(new 
File(cmd.getSrc()), TrueFileFilter.INSTANCE, TrueFileFilter.INSTANCE)) {
+SshHelper.scpTo(cmd.getVmIp(), 3922, "root", 
keyFile, null, cmd.getDest(), f.getCanonicalPath(), null);
+}
+} else {
--- End diff --

If its not a directory, but can be a block or socket file possible? Is 
there any criteria check to be added for file type to be copied?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

[anshul1886]

Github user anshul1886 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/669#discussion_r36609278
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCopyFileInVmCommandWrapper.java
 ---
@@ -0,0 +1,59 @@
+/*
+ *   Licensed to the Apache Software Foundation (ASF) under one
+ *   or more contributor license agreements.  See the NOTICE file
+ *   distributed with this work for additional information
+ *   regarding copyright ownership.  The ASF licenses this file
+ *   to you under the Apache License, Version 2.0 (the
+ *   "License"); you may not use this file except in compliance
+ *   with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *   Unless required by applicable law or agreed to in writing,
+ *   software distributed under the License is distributed on an
+ *   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ *   KIND, either express or implied.  See the License for the
+ *   specific language governing permissions and limitations
+ *   under the License.
+ */
+
+package com.cloud.hypervisor.kvm.resource.wrapper;
+
+import com.cloud.agent.api.Answer;
+import com.cloud.agent.api.CopyFileInVmAnswer;
+import com.cloud.agent.api.CopyFileInVmCommand;
+import com.cloud.hypervisor.kvm.resource.LibvirtComputingResource;
+import com.cloud.resource.CommandWrapper;
+import com.cloud.resource.ResourceWrapper;
+import com.cloud.utils.ssh.SshHelper;
+import org.apache.commons.io.FileUtils;
+import org.apache.commons.io.filefilter.TrueFileFilter;
+import org.apache.log4j.Logger;
+
+import java.io.File;
+
+@ResourceWrapper(handles = CopyFileInVmCommand.class)
+public class LibvirtCopyFileInVmCommandWrapper   extends 
CommandWrapper {
+
+private static final Logger s_logger = 
Logger.getLogger(LibvirtCopyFileInVmCommandWrapper.class);
+
+@Override public Answer execute(CopyFileInVmCommand cmd, 
LibvirtComputingResource libvirtComputingResource) {
+final File keyFile = new File("/root/.ssh/id_rsa.cloud");
+try {
+File file = new File(cmd.getSrc());
--- End diff --

@sedukull Could you please elaborate more on what is repetitive here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

[sedukull]

Github user sedukull commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/669#discussion_r36609308
  
--- Diff: 
plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java
 ---
@@ -595,6 +597,25 @@ private PlugNicAnswer execute(PlugNicCommand cmd) {
 }
 }
 
+private CopyFileInVmAnswer execute(CopyFileInVmCommand cmd) {
+File keyFile = getSystemVMKeyFile();
+try {
+File file = new File(cmd.getSrc());
+if(file.exists()) {
+if(file.isDirectory()) {
+for (File f : FileUtils.listFiles(new 
File(cmd.getSrc()), TrueFileFilter.INSTANCE, TrueFileFilter.INSTANCE)) {
+SshHelper.scpTo(cmd.getVmIp(), 3922, "root", 
keyFile, null, cmd.getDest(), f.getCanonicalPath(), null);
+}
+} else {
+SshHelper.scpTo(cmd.getVmIp(), 3922, "root", keyFile, 
null, cmd.getDest(), file.getCanonicalPath(), null);
+}
+}
+} catch (Exception e) {
+s_logger.error("Fail to copy file " + cmd.getSrc() + " in VM " 
+ cmd.getVmIp(), e);
+return new CopyFileInVmAnswer(cmd, e);
+}
+return new CopyFileInVmAnswer(cmd);
--- End diff --

Should this be moved inside to end of try block?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Revisit Process for creating Blocker bugs

[Sebastien Goasguen]

> On Aug 6, 2015, at 7:35 AM, Raja Pullela  wrote:
> 
> Looks like there are few of us who differ with the current 
> process/restriction.  
> Just to close this thread - there are already guidelines that exist currently 
> and we should continue to adopt or follow those.Let the Release Manager 
> or other people closely involved with a particular release decide on whether 
> a particular bug is correctly categorized or not.  They should have the veto 
> power to downgrade or upgrade, as necessary.
> 

I would not call it veto power.

Folks will file tickets and put a priority level, a RM will see blockers and 
when those are not resolved, the RM should go on the list and get a feel from 
the community about those blockers (whether they are or not).

I did not see (or understand) a major change proposed or needed in this thread.


> Assess Priority - 
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=30746287 
> When creating a new Jira ticket, please take a minute to correctly assess the 
> priority of the issue. By default, Jira assigns a new issue a Priority level 
> of Major. In many cases, this is wrong. Please be sure to set the Priority 
> correctly:
> Blocker: Blocks development and/or testing work, production cannot run. 
> Security issues.
> Critical: Crashes, loss of data, severe memory leak.
> Major: Major loss of function, broken feature, returns incorrect information, 
> etc.
> Minor: Minor loss of function, problem with an easy workaround. Wishlist 
> items.
> Trivial: Typos that don't affect comprehension of the UI, misaligned text, 
> etc.
> 
> -Original Message-
> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] 
> Sent: Wednesday, August 5, 2015 2:19 PM
> To: dev 
> Subject: Re: Revisit Process for creating Blocker bugs
> 
> Koushik, that would be true if we had our upgrade process in order.
> 
> On Wed, Aug 5, 2015 at 7:14 AM, Koushik Das  wrote:
> 
>> If there is a group of users in dire need for a specific feature they 
>> can always take the code and use it. No need to wait for an official release.
>> Official release should adhere to quality guidelines (at least in 
>> terms of any reported regressions) even if it means release getting delayed.
>> 
>> 
>> On 05-Aug-2015, at 2:39 AM, Daan Hoogland  wrote:
>> 
>>> Yes we can if there is a group of users that don't use it but are in 
>>> dire need far another feature. We just have to document and market 
>>> it properly
>>> 
>>> On Tue, Aug 4, 2015 at 6:48 PM, Ramanath Katru 
>>>  wrote:
 Daan,
 
 I beg to differ. This is very much a product issue. We cannot 
 knowingly
>> release with an existing/working functionality broken. Especially if 
>> it is one of the features that users expect to be there. Remote Access 
>> VPN is an example. Right now this functionality is broken.
 
 Ram Katru
 
 -Original Message-
 From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
 Sent: Tuesday, August 4, 2015 4:57 PM
 To: dev 
 Subject: Re: Revisit Process for creating Blocker bugs
 
 Ram,
 
 This is a marketing issue, not a release issue. making a release or
>> marketing it to the general public are two different things.
 
 Daan
 
 On Tue, Aug 4, 2015 at 12:41 PM, Ramanath Katru <
>> ramanath.ka...@citrix.com> wrote:
> While we can say if a bug doesn’t effect "majority" of current 
> users,
>> we can go ahead and release, but we should also look at a product 
>> perspective not just release perspective. There are some features that 
>> are important for cloudstack as a product and these cannot be broken 
>> in a release. If we do not evaluate from a product perspective, then 
>> we will be turning potential new users away.
> 
> Ram Katru
> 
> -Original Message-
> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
> Sent: Tuesday, August 4, 2015 1:54 AM
> To: dev 
> Subject: Re: Revisit Process for creating Blocker bugs
> 
> On Mon, Aug 3, 2015 at 10:16 PM, Somesh Naidu 
> 
> wrote:
> 
>> I would like to add that while the # of users affected is 
>> definitely a major factor when ascertaining severity of an issue, 
>> should we not consider the technical scope and/or use-case of a 
>> defect. For example, let's say there is only one user using basic 
>> zone setup with VMware in the community but the bug/regression 
>> has caused a major failure like "No provisioning of VMs". Would 
>> this be considered a
>> release blocker?
>> 
> 
> This is exactly the kind of discussion we need to have when such a
>> case comes by. For this as purely hypothetical case I would say, release.
>> We can not have other users abstain from badly needed features because 
>> one can not share in the joy. We would have to release a fix for this 
>> afterwards.
> 
> just a 0.02 in virtual currency
> 
> 
> 
> --
> Daan
>>

Re: [DISCUSS][PROPOSAL] cleanup repo

[Sebastien Goasguen]

I’d just be a bit careful here.

There might be some tale branches that still have useful info.
like the ‘docker’ branch. it might just be 100 LOC that are interesting but 
yet, that’s where they are.

> On Aug 3, 2015, at 6:06 PM, Remi Bergsma  wrote:
> 
> +1
> 
>> On 02 Aug 2015, at 15:46, Daan Hoogland  wrote:
>> 
>> As we are changing our review process I want to clean up the
>> repository at apache getting rid of stale branches. Of course the
>> release branches of old releases should stay, but a lot of old
>> branches have been merged at unknown places in the master or old
>> release branches. I want to propose to delete them as much as
>> possible.
>> 
>> - I want to delete any branch that has no commits newer then one year old
>> - I want to ask the last commiter on any branch with commits newer
>> then one year to review if 'their' branch can be removed
>> - All branches that are merged back are to remain untouched.
>> 
>> ideally only the branches 4.0, 4.1, 4.2, 4.3, 4.4, 4.5 and master will
>> remain as branches HEAD. This is unfortunately not true for some older
>> releases that were never merged back into their respective release
>> branches. Any work in progress will of course not be touched.
>> 
>> comments?
>> -- 
>> Daan
> 

[GitHub] cloudstack pull request: CLOUDSTACK-8704: Schedule restart of rout...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/656#issuecomment-129365283
  
Travis failure is due to timeout.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Revisit Process for creating Blocker bugs

[Sebastien Goasguen]

> On Aug 4, 2015, at 6:48 PM, Ramanath Katru  wrote:
> 
> Daan,
> 
> I beg to differ. This is very much a product issue. We cannot knowingly 
> release with an existing/working functionality broken. Especially if it is 
> one of the features that users expect to be there. Remote Access VPN is an 
> example. Right now this functionality is broken.
> 

Then as contributor to cloudstack, put this ticket as a blocker (if you feel it 
needs to be a blocker).

Then the RM will have to deal with it and a discussion might follow on the list 
to solve this particular issue.



> Ram Katru
> 
> -Original Message-
> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] 
> Sent: Tuesday, August 4, 2015 4:57 PM
> To: dev 
> Subject: Re: Revisit Process for creating Blocker bugs
> 
> Ram,
> 
> This is a marketing issue, not a release issue. making a release or marketing 
> it to the general public are two different things.
> 
> Daan
> 
> On Tue, Aug 4, 2015 at 12:41 PM, Ramanath Katru  
> wrote:
>> While we can say if a bug doesn’t effect "majority" of current users, we can 
>> go ahead and release, but we should also look at a product perspective not 
>> just release perspective. There are some features that are important for 
>> cloudstack as a product and these cannot be broken in a release. If we do 
>> not evaluate from a product perspective, then we will be turning potential 
>> new users away.
>> 
>> Ram Katru
>> 
>> -Original Message-
>> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
>> Sent: Tuesday, August 4, 2015 1:54 AM
>> To: dev 
>> Subject: Re: Revisit Process for creating Blocker bugs
>> 
>> On Mon, Aug 3, 2015 at 10:16 PM, Somesh Naidu 
>> 
>> wrote:
>> 
>>> I would like to add that while the # of users affected is definitely 
>>> a major factor when ascertaining severity of an issue, should we not 
>>> consider the technical scope and/or use-case of a defect. For 
>>> example, let's say there is only one user using basic zone setup with 
>>> VMware in the community but the bug/regression has caused a major 
>>> failure like "No provisioning of VMs". Would this be considered a release 
>>> blocker?
>>> 
>> 
>> This is exactly the kind of discussion we need to have when such a case 
>> comes by. For this as purely hypothetical case I would say, release. We can 
>> not have other users abstain from badly needed features because one can not 
>> share in the joy. We would have to release a fix for this afterwards.
>> 
>> just a 0.02 in virtual currency
>> 
>> 
>> 
>> --
>> Daan
> 
> 
> 
> --
> Daan

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

[anshul1886]

Github user anshul1886 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/669#discussion_r36611014
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 ---
@@ -1279,6 +1285,27 @@ private static DiskTO getIsoDiskTO(DiskTO[] disks) {
 return null;
 }
 
+private CopyFileInVmAnswer execute(CopyFileInVmCommand cmd) {
+VmwareManager mgr = 
getServiceContext().getStockObject(VmwareManager.CONTEXT_STOCK_NAME);
+File keyFile = mgr.getSystemVMKeyFile();
+try {
+File file = new File(cmd.getSrc());
--- End diff --

No. There is no file open operation involved here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

[anshul1886]

Github user anshul1886 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/669#discussion_r36611046
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 ---
@@ -1279,6 +1285,27 @@ private static DiskTO getIsoDiskTO(DiskTO[] disks) {
 return null;
 }
 
+private CopyFileInVmAnswer execute(CopyFileInVmCommand cmd) {
+VmwareManager mgr = 
getServiceContext().getStockObject(VmwareManager.CONTEXT_STOCK_NAME);
+File keyFile = mgr.getSystemVMKeyFile();
+try {
+File file = new File(cmd.getSrc());
+if(file.exists()) {
+if(file.isDirectory()) {
+for (File f : FileUtils.listFiles(new 
File(cmd.getSrc()), TrueFileFilter.INSTANCE, TrueFileFilter.INSTANCE)) {
--- End diff --

same as above answer


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

[anshul1886]

Github user anshul1886 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/669#discussion_r36611140
  
--- Diff: 
plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java
 ---
@@ -595,6 +597,25 @@ private PlugNicAnswer execute(PlugNicCommand cmd) {
 }
 }
 
+private CopyFileInVmAnswer execute(CopyFileInVmCommand cmd) {
+File keyFile = getSystemVMKeyFile();
+try {
+File file = new File(cmd.getSrc());
+if(file.exists()) {
+if(file.isDirectory()) {
+for (File f : FileUtils.listFiles(new 
File(cmd.getSrc()), TrueFileFilter.INSTANCE, TrueFileFilter.INSTANCE)) {
+SshHelper.scpTo(cmd.getVmIp(), 3922, "root", 
keyFile, null, cmd.getDest(), f.getCanonicalPath(), null);
+}
+} else {
+SshHelper.scpTo(cmd.getVmIp(), 3922, "root", keyFile, 
null, cmd.getDest(), file.getCanonicalPath(), null);
+}
+}
+} catch (Exception e) {
+s_logger.error("Fail to copy file " + cmd.getSrc() + " in VM " 
+ cmd.getVmIp(), e);
+return new CopyFileInVmAnswer(cmd, e);
+}
+return new CopyFileInVmAnswer(cmd);
--- End diff --

What purpose will it serve?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

[sedukull]

Github user sedukull commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/669#discussion_r36611175
  
--- Diff: server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java ---
@@ -1425,19 +1423,39 @@ public boolean finalizeCommandsOnStart(Commands 
cmds, VirtualMachineProfile prof
 CheckSshCommand check = new 
CheckSshCommand(profile.getInstanceName(), controlNic.getIp4Address(), 3922);
 cmds.addCommand("checkSsh", check);
 
+try {
+File uiFiles = new File("systemvm/js");
+if (!uiFiles.exists()) {
+uiFiles = new 
File("/usr/share/cloudstack-common/systemvm/js");
+}
+if (uiFiles.exists() && uiFiles.isDirectory()) {
+CopyFileInVmCommand copyFile = new 
CopyFileInVmCommand(uiFiles.getCanonicalPath(), "/usr/local/cloud/systemvm/js", 
controlNic.getIp4Address());
+cmds.addCommand("copyFile", copyFile);
+} else {
+s_logger.error("Couldn't locate localization files for 
console proxy");
+return false;
+}
+} catch (IOException e) {
+s_logger.error("Failed to copy localization files for console 
proxy: " + e.getMessage());
--- End diff --

should we return false in case of an exception?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

[sedukull]

Github user sedukull commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/669#discussion_r36611238
  
--- Diff: server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java ---
@@ -1425,19 +1423,39 @@ public boolean finalizeCommandsOnStart(Commands 
cmds, VirtualMachineProfile prof
 CheckSshCommand check = new 
CheckSshCommand(profile.getInstanceName(), controlNic.getIp4Address(), 3922);
 cmds.addCommand("checkSsh", check);
 
+try {
+File uiFiles = new File("systemvm/js");
+if (!uiFiles.exists()) {
+uiFiles = new 
File("/usr/share/cloudstack-common/systemvm/js");
+}
+if (uiFiles.exists() && uiFiles.isDirectory()) {
+CopyFileInVmCommand copyFile = new 
CopyFileInVmCommand(uiFiles.getCanonicalPath(), "/usr/local/cloud/systemvm/js", 
controlNic.getIp4Address());
+cmds.addCommand("copyFile", copyFile);
+} else {
+s_logger.error("Couldn't locate localization files for 
console proxy");
+return false;
+}
+} catch (IOException e) {
+s_logger.error("Failed to copy localization files for console 
proxy: " + e.getMessage());
+}
+
 return true;
 }
 
 @Override
 public boolean finalizeStart(VirtualMachineProfile profile, long 
hostId, Commands cmds, ReservationContext context) {
-CheckSshAnswer answer = (CheckSshAnswer)cmds.getAnswer("checkSsh");
-if (answer == null || !answer.getResult()) {
-if (answer != null) {
-s_logger.warn("Unable to ssh to the VM: " + 
answer.getDetails());
-} else {
-s_logger.warn("Unable to ssh to the VM: null answer");
+for(Answer answer : cmds.getAnswers()) {
+if(answer == null || !answer.getResult()) {
+if (answer != null) {
+s_logger.warn("Unable to ssh to the VM: " + 
answer.getDetails());
+} else {
+s_logger.warn("Unable to ssh to the VM: null answer");
+}
+if(cmds.getAnswer("copyFile") == answer) {
+continue;
+}
+return false;
--- End diff --

It seems this return seems to be inside of if..block, so for loop 
effectively has no effect and returns for one run?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Ec2stack not working with current aws cli

[Sebastien Goasguen]

since we don’t have docs for ec2stack yet.

Can you make a PR that updates the README with this config option…

thanks

> On Aug 6, 2015, at 3:07 AM, Carlos Reategui  wrote:
> 
> BTW I figured out how to force the cli to send v2.  It would still be nice
> to update Ec2Stack though:
> 
> aws configure set profile..ec2.signature_version v2
> 
> 
> Or for your default profile:
> 
> 
> aws configure set default.ec2.signature_version v2
> 
> 
> The above will update your ~/.aws/config file.
> 
> 
> 
> 
> On Wed, Aug 5, 2015 at 5:49 PM, Carlos Reategui  wrote:
> 
>> Hi,
>> I am having trouble with the current aws cli.  Ec2stack is expecting AWS
>> signature version 2 but the current aws cli uses v4.
>> 
>> Do I file a JIRA in under cloudstack?  I did not see an ec2stack component.
>> 
>> Here is a wireshark capture:
>> 
>> POST / HTTP/1.1
>> Host: localhost:5000
>> Accept-Encoding: identity
>> Content-Length: 40
>> Content-Type: application/x-www-form-urlencoded
>> X-Amz-Date: 20150806T002150Z
>> Authorization: AWS4-HMAC-SHA256
>> Credential=x/20150806//ec2/aws4_request,
>> SignedHeaders=host;user-agent;x-amz-date, Signature=xx
>> User-Agent: aws-cli/1.7.42 Python/2.7.6 Darwin/14.4.0
>> 
>> Action=DescribeImages&Version=2015-04-15
>> 
>> HTTP/1.0 400 BAD REQUEST
>> Content-Type: application/xml
>> Content-Length: 314
>> Server: Werkzeug/0.10.4 Python/2.7.3
>> Date: Thu, 06 Aug 2015 00:21:50 GMT
>> 
>> 
>> 
>> 
>> 
>> 
>>   
>>   MissingParameter
>>   The request must contain the parameter
>> SignatureVersion
>>   
>> 
>> 
>> 
>> 
>>21ba5526-3bd1-11e5-abbc-d4ae52927e09
>> 
>> 
>> 

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

[anshul1886]

Github user anshul1886 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/669#discussion_r36611296
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCopyFileInVmCommandWrapper.java
 ---
@@ -0,0 +1,59 @@
+/*
+ *   Licensed to the Apache Software Foundation (ASF) under one
+ *   or more contributor license agreements.  See the NOTICE file
+ *   distributed with this work for additional information
+ *   regarding copyright ownership.  The ASF licenses this file
+ *   to you under the Apache License, Version 2.0 (the
+ *   "License"); you may not use this file except in compliance
+ *   with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *   Unless required by applicable law or agreed to in writing,
+ *   software distributed under the License is distributed on an
+ *   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ *   KIND, either express or implied.  See the License for the
+ *   specific language governing permissions and limitations
+ *   under the License.
+ */
+
+package com.cloud.hypervisor.kvm.resource.wrapper;
+
+import com.cloud.agent.api.Answer;
+import com.cloud.agent.api.CopyFileInVmAnswer;
+import com.cloud.agent.api.CopyFileInVmCommand;
+import com.cloud.hypervisor.kvm.resource.LibvirtComputingResource;
+import com.cloud.resource.CommandWrapper;
+import com.cloud.resource.ResourceWrapper;
+import com.cloud.utils.ssh.SshHelper;
+import org.apache.commons.io.FileUtils;
+import org.apache.commons.io.filefilter.TrueFileFilter;
+import org.apache.log4j.Logger;
+
+import java.io.File;
+
+@ResourceWrapper(handles = CopyFileInVmCommand.class)
+public class LibvirtCopyFileInVmCommandWrapper   extends 
CommandWrapper {
+
+private static final Logger s_logger = 
Logger.getLogger(LibvirtCopyFileInVmCommandWrapper.class);
+
+@Override public Answer execute(CopyFileInVmCommand cmd, 
LibvirtComputingResource libvirtComputingResource) {
+final File keyFile = new File("/root/.ssh/id_rsa.cloud");
+try {
+File file = new File(cmd.getSrc());
+if(file.exists()) {
+if(file.isDirectory()) {
+for (File f : FileUtils.listFiles(new 
File(cmd.getSrc()), TrueFileFilter.INSTANCE, TrueFileFilter.INSTANCE)) {
+SshHelper.scpTo(cmd.getVmIp(), 3922, "root", 
keyFile, null, cmd.getDest(), f.getCanonicalPath(), null);
+}
+} else {
--- End diff --

If its just a file then else part will take care. And I don't understand 
how does socket file is involved here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

[sedukull]

Github user sedukull commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/669#discussion_r36611512
  
--- Diff: 
plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java
 ---
@@ -595,6 +597,25 @@ private PlugNicAnswer execute(PlugNicCommand cmd) {
 }
 }
 
+private CopyFileInVmAnswer execute(CopyFileInVmCommand cmd) {
+File keyFile = getSystemVMKeyFile();
+try {
+File file = new File(cmd.getSrc());
+if(file.exists()) {
+if(file.isDirectory()) {
+for (File f : FileUtils.listFiles(new 
File(cmd.getSrc()), TrueFileFilter.INSTANCE, TrueFileFilter.INSTANCE)) {
+SshHelper.scpTo(cmd.getVmIp(), 3922, "root", 
keyFile, null, cmd.getDest(), f.getCanonicalPath(), null);
+}
+} else {
+SshHelper.scpTo(cmd.getVmIp(), 3922, "root", keyFile, 
null, cmd.getDest(), file.getCanonicalPath(), null);
+}
+}
+} catch (Exception e) {
+s_logger.error("Fail to copy file " + cmd.getSrc() + " in VM " 
+ cmd.getVmIp(), e);
+return new CopyFileInVmAnswer(cmd, e);
+}
+return new CopyFileInVmAnswer(cmd);
--- End diff --

I mean in case a copyfilein..if moved inside try block throws an exception 
, then the code return new...copyfile inside catch still works.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

[sedukull]

Github user sedukull commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/669#discussion_r36611661
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCopyFileInVmCommandWrapper.java
 ---
@@ -0,0 +1,59 @@
+/*
+ *   Licensed to the Apache Software Foundation (ASF) under one
+ *   or more contributor license agreements.  See the NOTICE file
+ *   distributed with this work for additional information
+ *   regarding copyright ownership.  The ASF licenses this file
+ *   to you under the Apache License, Version 2.0 (the
+ *   "License"); you may not use this file except in compliance
+ *   with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *   Unless required by applicable law or agreed to in writing,
+ *   software distributed under the License is distributed on an
+ *   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ *   KIND, either express or implied.  See the License for the
+ *   specific language governing permissions and limitations
+ *   under the License.
+ */
+
+package com.cloud.hypervisor.kvm.resource.wrapper;
+
+import com.cloud.agent.api.Answer;
+import com.cloud.agent.api.CopyFileInVmAnswer;
+import com.cloud.agent.api.CopyFileInVmCommand;
+import com.cloud.hypervisor.kvm.resource.LibvirtComputingResource;
+import com.cloud.resource.CommandWrapper;
+import com.cloud.resource.ResourceWrapper;
+import com.cloud.utils.ssh.SshHelper;
+import org.apache.commons.io.FileUtils;
+import org.apache.commons.io.filefilter.TrueFileFilter;
+import org.apache.log4j.Logger;
+
+import java.io.File;
+
+@ResourceWrapper(handles = CopyFileInVmCommand.class)
+public class LibvirtCopyFileInVmCommandWrapper   extends 
CommandWrapper {
+
+private static final Logger s_logger = 
Logger.getLogger(LibvirtCopyFileInVmCommandWrapper.class);
+
+@Override public Answer execute(CopyFileInVmCommand cmd, 
LibvirtComputingResource libvirtComputingResource) {
+final File keyFile = new File("/root/.ssh/id_rsa.cloud");
+try {
+File file = new File(cmd.getSrc());
+if(file.exists()) {
+if(file.isDirectory()) {
+for (File f : FileUtils.listFiles(new 
File(cmd.getSrc()), TrueFileFilter.INSTANCE, TrueFileFilter.INSTANCE)) {
+SshHelper.scpTo(cmd.getVmIp(), 3922, "root", 
keyFile, null, cmd.getDest(), f.getCanonicalPath(), null);
+}
+} else {
--- End diff --

I mean we are checking whether its directory or not, but if its not a 
directory, other types can come EX: block, socket, or other file types defined 
by attributes ( like d,b etc), i mean do we have a specific requirement to copy 
with specific file type. EX: if we have group of files ( directory, block type, 
socket type , plain text files etc) , with above logic it returns all which is 
not of directory "type",  iam inquiring to see we want to be explicit in code 
for a given file type?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8379:add support to marvin to ...

[sanju1010]

Github user sanju1010 commented on the pull request:

https://github.com/apache/cloudstack/pull/158#issuecomment-129368171
  
-1
Without changes it works fine, because if we don't specify the "enabled" 
attribute for the zone in the config file, it will enable the zone by default. 
Even if the zone has the attribute "enabled" without any value , then also we 
enable the zone. It anything other than "true" then only we won't enable the 
zone.

With @srikanteswartalluri changes this functionality will be broken because 
he is converting the "None" to string in "getattr" method. So the following 
line will always have some string:
enabled = enabled if enabled else 'true' 
and if the zone object does not have the "enabled" attribute we are not 
calling the enableZone which is not expected.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8704: Schedule restart of rout...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/656#issuecomment-129368352
  
@koushik-das Thanks, glad the merge commit is gone now. Do you want to keep 
two commits? I'd say squash them together. From the subject line I cannot tell 
the difference. Let me know and I'll proceed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8693-Adding-missing-code-in-te...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/668#issuecomment-129368593
  
@pritisarap12 Please remove the merge commit and force push again. See PR 
#656 on how to do this. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

[anshul1886]

Github user anshul1886 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/669#discussion_r36611905
  
--- Diff: server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java ---
@@ -1425,19 +1423,39 @@ public boolean finalizeCommandsOnStart(Commands 
cmds, VirtualMachineProfile prof
 CheckSshCommand check = new 
CheckSshCommand(profile.getInstanceName(), controlNic.getIp4Address(), 3922);
 cmds.addCommand("checkSsh", check);
 
+try {
+File uiFiles = new File("systemvm/js");
+if (!uiFiles.exists()) {
+uiFiles = new 
File("/usr/share/cloudstack-common/systemvm/js");
+}
+if (uiFiles.exists() && uiFiles.isDirectory()) {
+CopyFileInVmCommand copyFile = new 
CopyFileInVmCommand(uiFiles.getCanonicalPath(), "/usr/local/cloud/systemvm/js", 
controlNic.getIp4Address());
+cmds.addCommand("copyFile", copyFile);
+} else {
+s_logger.error("Couldn't locate localization files for 
console proxy");
+return false;
+}
+} catch (IOException e) {
+s_logger.error("Failed to copy localization files for console 
proxy: " + e.getMessage());
+}
+
 return true;
 }
 
 @Override
 public boolean finalizeStart(VirtualMachineProfile profile, long 
hostId, Commands cmds, ReservationContext context) {
-CheckSshAnswer answer = (CheckSshAnswer)cmds.getAnswer("checkSsh");
-if (answer == null || !answer.getResult()) {
-if (answer != null) {
-s_logger.warn("Unable to ssh to the VM: " + 
answer.getDetails());
-} else {
-s_logger.warn("Unable to ssh to the VM: null answer");
+for(Answer answer : cmds.getAnswers()) {
+if(answer == null || !answer.getResult()) {
+if (answer != null) {
+s_logger.warn("Unable to ssh to the VM: " + 
answer.getDetails());
+} else {
+s_logger.warn("Unable to ssh to the VM: null answer");
+}
+if(cmds.getAnswer("copyFile") == answer) {
+continue;
+}
+return false;
--- End diff --

Its returning false if the command is failed or has not returned answer and 
that is failure case. In case of copyFile we are ignoring the answer and 
continuing. So if block is making sense for that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8704: Schedule restart of rout...

[koushik-das]

Github user koushik-das commented on the pull request:

https://github.com/apache/cloudstack/pull/656#issuecomment-129371706
  
@remibergsma Yes the commits can be squashed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

[anshul1886]

Github user anshul1886 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/669#discussion_r36612331
  
--- Diff: server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java ---
@@ -1425,19 +1423,39 @@ public boolean finalizeCommandsOnStart(Commands 
cmds, VirtualMachineProfile prof
 CheckSshCommand check = new 
CheckSshCommand(profile.getInstanceName(), controlNic.getIp4Address(), 3922);
 cmds.addCommand("checkSsh", check);
 
+try {
+File uiFiles = new File("systemvm/js");
+if (!uiFiles.exists()) {
+uiFiles = new 
File("/usr/share/cloudstack-common/systemvm/js");
+}
+if (uiFiles.exists() && uiFiles.isDirectory()) {
+CopyFileInVmCommand copyFile = new 
CopyFileInVmCommand(uiFiles.getCanonicalPath(), "/usr/local/cloud/systemvm/js", 
controlNic.getIp4Address());
+cmds.addCommand("copyFile", copyFile);
+} else {
+s_logger.error("Couldn't locate localization files for 
console proxy");
+return false;
+}
+} catch (IOException e) {
+s_logger.error("Failed to copy localization files for console 
proxy: " + e.getMessage());
--- End diff --

We are copying some files (using pom.xml) in that folder so these files are 
expected there. If these files do not exist there then he may have forgotten to 
add there those file. Returning false will make him identify the issue because 
of that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

[anshul1886]

Github user anshul1886 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/669#discussion_r36612463
  
--- Diff: 
plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java
 ---
@@ -595,6 +597,25 @@ private PlugNicAnswer execute(PlugNicCommand cmd) {
 }
 }
 
+private CopyFileInVmAnswer execute(CopyFileInVmCommand cmd) {
+File keyFile = getSystemVMKeyFile();
+try {
+File file = new File(cmd.getSrc());
+if(file.exists()) {
+if(file.isDirectory()) {
+for (File f : FileUtils.listFiles(new 
File(cmd.getSrc()), TrueFileFilter.INSTANCE, TrueFileFilter.INSTANCE)) {
+SshHelper.scpTo(cmd.getVmIp(), 3922, "root", 
keyFile, null, cmd.getDest(), f.getCanonicalPath(), null);
+}
+} else {
+SshHelper.scpTo(cmd.getVmIp(), 3922, "root", keyFile, 
null, cmd.getDest(), file.getCanonicalPath(), null);
+}
+}
+} catch (Exception e) {
+s_logger.error("Fail to copy file " + cmd.getSrc() + " in VM " 
+ cmd.getVmIp(), e);
+return new CopyFileInVmAnswer(cmd, e);
+}
+return new CopyFileInVmAnswer(cmd);
--- End diff --

I got your point but I don't understand how will that make any difference 
here


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

[anshul1886]

Github user anshul1886 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/669#discussion_r36612869
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCopyFileInVmCommandWrapper.java
 ---
@@ -0,0 +1,59 @@
+/*
+ *   Licensed to the Apache Software Foundation (ASF) under one
+ *   or more contributor license agreements.  See the NOTICE file
+ *   distributed with this work for additional information
+ *   regarding copyright ownership.  The ASF licenses this file
+ *   to you under the Apache License, Version 2.0 (the
+ *   "License"); you may not use this file except in compliance
+ *   with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *   Unless required by applicable law or agreed to in writing,
+ *   software distributed under the License is distributed on an
+ *   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ *   KIND, either express or implied.  See the License for the
+ *   specific language governing permissions and limitations
+ *   under the License.
+ */
+
+package com.cloud.hypervisor.kvm.resource.wrapper;
+
+import com.cloud.agent.api.Answer;
+import com.cloud.agent.api.CopyFileInVmAnswer;
+import com.cloud.agent.api.CopyFileInVmCommand;
+import com.cloud.hypervisor.kvm.resource.LibvirtComputingResource;
+import com.cloud.resource.CommandWrapper;
+import com.cloud.resource.ResourceWrapper;
+import com.cloud.utils.ssh.SshHelper;
+import org.apache.commons.io.FileUtils;
+import org.apache.commons.io.filefilter.TrueFileFilter;
+import org.apache.log4j.Logger;
+
+import java.io.File;
+
+@ResourceWrapper(handles = CopyFileInVmCommand.class)
+public class LibvirtCopyFileInVmCommandWrapper   extends 
CommandWrapper {
+
+private static final Logger s_logger = 
Logger.getLogger(LibvirtCopyFileInVmCommandWrapper.class);
+
+@Override public Answer execute(CopyFileInVmCommand cmd, 
LibvirtComputingResource libvirtComputingResource) {
+final File keyFile = new File("/root/.ssh/id_rsa.cloud");
+try {
+File file = new File(cmd.getSrc());
+if(file.exists()) {
+if(file.isDirectory()) {
+for (File f : FileUtils.listFiles(new 
File(cmd.getSrc()), TrueFileFilter.INSTANCE, TrueFileFilter.INSTANCE)) {
+SshHelper.scpTo(cmd.getVmIp(), 3922, "root", 
keyFile, null, cmd.getDest(), f.getCanonicalPath(), null);
+}
+} else {
--- End diff --

Here if it is a file then I am copying it directly as can be seen in else 
block but if it is a directory then I am listing files and then copying files 
individually as the library which we are using elsewhere in CloudStack doesn't 
support copying directories. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [DISCUSS][PROPOSAL] cleanup repo

[Daan Hoogland]

I will, Sebastien. I know that some of this is gems. A lot of it has been
merged or really abandoned and superseded by other code. I know you and
Pierre-Luc are working on docker so I would definitely inquire with you
guys about this branch.

On Mon, Aug 10, 2015 at 10:29 AM, Sebastien Goasguen 
wrote:

> I’d just be a bit careful here.
>
> There might be some tale branches that still have useful info.
> like the ‘docker’ branch. it might just be 100 LOC that are interesting
> but yet, that’s where they are.
>
> > On Aug 3, 2015, at 6:06 PM, Remi Bergsma 
> wrote:
> >
> > +1
> >
> >> On 02 Aug 2015, at 15:46, Daan Hoogland 
> wrote:
> >>
> >> As we are changing our review process I want to clean up the
> >> repository at apache getting rid of stale branches. Of course the
> >> release branches of old releases should stay, but a lot of old
> >> branches have been merged at unknown places in the master or old
> >> release branches. I want to propose to delete them as much as
> >> possible.
> >>
> >> - I want to delete any branch that has no commits newer then one year
> old
> >> - I want to ask the last commiter on any branch with commits newer
> >> then one year to review if 'their' branch can be removed
> >> - All branches that are merged back are to remain untouched.
> >>
> >> ideally only the branches 4.0, 4.1, 4.2, 4.3, 4.4, 4.5 and master will
> >> remain as branches HEAD. This is unfortunately not true for some older
> >> releases that were never merged back into their respective release
> >> branches. Any work in progress will of course not be touched.
> >>
> >> comments?
> >> --
> >> Daan
> >
>
>


-- 
Daan

happy birthday dear cloudstack.git

[Daan Hoogland]

Ladies and gentleman,

At the 11th of August 2010, Manuel Amador made the first commit in our
repository. I never met the guy but want to take the occasion to
congratulate him and all other contributors with the 5th aniversary of our
repository.

​:beer::cake::clappinghands:​
-- 
Daan

[GitHub] cloudstack pull request: CLOUDSTACK-8704: Schedule restart of rout...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/656#issuecomment-129374324
  
@koushik-das Check, please squash and then force push again. After that 
I'll merge it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Made interface changes related to CLOUDST...

[kevindierkx]

GitHub user kevindierkx opened a pull request:

https://github.com/apache/cloudstack/pull/670

Made interface changes related to CLOUDSTACK-8580



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kevindierkx/cloudstack CLOUDSTACK-8580

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/670.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #670


commit 3be14e978aa0c9b286d9f57bf1fc60ebe50990c7
Author: Kevin Dierkx 
Date:   2015-08-07T12:20:44Z

Made interface changes related to CLOUDSTACK-8580




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8687: Prepare template only on...

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/635#discussion_r36613344
  
--- Diff: 
api/src/org/apache/cloudstack/api/command/admin/template/PrepareTemplateCmd.java
 ---
@@ -60,6 +61,15 @@
description = "template ID of the template to be prepared 
in primary storage(s).")
 private Long templateId;
 
+@ACL(accessType = AccessType.OperateEntry)
+@Parameter(name = ApiConstants.STORAGE_ID,
+type = CommandType.UUID,
+entityType = StoragePoolResponse.class,
+required = false,
+description = "storage pool ID of the primary storage pool to 
which the template should be prepared. If it is not provided the template" +
+" is prepared on all the available primary storage 
pools.")
+private Long storageId;
--- End diff --

@remibergsma, @kishankavala is concurring with the observation by @devdeep 
that his call was good in the name of consistency. I think he was being 
unconditional about his LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: happy birthday dear cloudstack.git

[Wido den Hollander]

Congrats! Great :-)

On 10-08-15 11:17, Daan Hoogland wrote:
> Ladies and gentleman,
> 
> At the 11th of August 2010, Manuel Amador made the first commit in our
> repository. I never met the guy but want to take the occasion to
> congratulate him and all other contributors with the 5th aniversary of our
> repository.
> 
> ​:beer::cake::clappinghands:​
> 

[GitHub] cloudstack pull request: CLOUDSTACK-8720: Handle corner case in re...

[sanju1010]

GitHub user sanju1010 opened a pull request:

https://github.com/apache/cloudstack/pull/671

CLOUDSTACK-8720: Handle corner case in remove nic from vm

Please see the bug for more details

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sanju1010/cloudstack CSBug

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/671.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #671


commit 41be8f4ef8bc914eb94549003b72387d729a3ef4
Author: sanjeev 
Date:   2015-08-07T12:39:09Z

CLOUDSTACK-8720: Handle corner case in remove nic from vm
Please see the bug for more details




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Allow VM snapshots and volume snapshots t...

[anshul1886]

GitHub user anshul1886 opened a pull request:

https://github.com/apache/cloudstack/pull/672

Allow VM snapshots and volume snapshots to exist together

This branch fixes issues involved in allowing VM snapshots and volume 
snapshots to exist together.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/anshul1886/cloudstack-1 vmsnapshots

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/672.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #672


commit 10295e99a6b03350a132d66444a5c26b2f0fa60a
Author: Anshul Gangwar 
Date:   2015-07-24T09:15:20Z

Allow VM and volume snapshots to exist together

commit eed632026028385325a638cfd90ce65fc8ec3543
Author: Anshul Gangwar 
Date:   2015-07-27T05:30:49Z

Reverting VM to disk only snapshot in Xenserver corrupts VM

commit c91f100b64e17b042dc1596e162f36e344389bcb
Author: Anshul Gangwar 
Date:   2015-07-27T05:38:45Z

Stale NFS secondary storage on XS leads to volume creation failure from 
snapshot




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: happy birthday dear cloudstack.git

[Punith S]

Wow! happy birthday cloudstack :)

On Mon, Aug 10, 2015 at 3:03 PM, Wido den Hollander  wrote:

> Congrats! Great :-)
>
> On 10-08-15 11:17, Daan Hoogland wrote:
> > Ladies and gentleman,
> >
> > At the 11th of August 2010, Manuel Amador made the first commit in our
> > repository. I never met the guy but want to take the occasion to
> > congratulate him and all other contributors with the 5th aniversary of
> our
> > repository.
> >
> > ​:beer::cake::clappinghands:​
> >
>



-- 
Regards,

punith s
cloudbyte.com

[GitHub] cloudstack pull request: CLOUDSTACK-8720: Handle corner case in re...

[sanju1010]

Github user sanju1010 commented on the pull request:

https://github.com/apache/cloudstack/pull/671#issuecomment-129378007
  
Test to verify remove nic from vm if the nic ip is same as another vm ip in 
another network ... === TestName: test_29_remove_nic_CS22503 | Status : SUCCESS 
===
ok

--
Ran 1 test in 359.186s

OK



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Made interface changes related to CLOUDST...

[kevindierkx]

Github user kevindierkx commented on the pull request:

https://github.com/apache/cloudstack/pull/670#issuecomment-129381995
  
Looks like the changes to listCapabilities aren't merged yet. (@borisroman) 
Ignore this pull-request =D


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Made interface changes related to CLOUDST...

[kevindierkx]

Github user kevindierkx closed the pull request at:

https://github.com/apache/cloudstack/pull/670


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: happy birthday dear cloudstack.git

[Sebastien Goasguen]

> On Aug 10, 2015, at 11:17 AM, Daan Hoogland  wrote:
> 
> Ladies and gentleman,
> 
> At the 11th of August 2010, Manuel Amador made the first commit in our
> repository. I never met the guy but want to take the occasion to
> congratulate him and all other contributors with the 5th aniversary of our
> repository.
> 
> ​:beer::cake::clappinghands:​

Indeed, happy birthday

> -- 
> Daan

[GitHub] cloudstack pull request: CLOUDSTACK-8704: Schedule restart of rout...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/656#issuecomment-129396359
  
@koushik-das Thank you!
LGTM, merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8704: Schedule restart of rout...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/656


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8720: Handle corner case in re...

[pavanb018]

Github user pavanb018 commented on the pull request:

https://github.com/apache/cloudstack/pull/671#issuecomment-129398162
  
Looks Good to me. 

Probably remove_nic might return an error if the NIC is not removed , but 
just wondering if a check is needed in the below step , to validate that only 1 
NIC exists for the VM by listing nics after the remove nic operation? If you 
feel the check is redundant then leave it.: 

#Try to remove nic 2 from vm1
+try:
+vm1.remove_nic(self.apiclient, self.nics[0].id)
+except Exception as e:
+self.fail("Failed to delete the nic from vm")
+return


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Cisco ACI SDN

[Erik Weber]

Hi devs,

Just wondering if anyone is looking at implementing Cisco ACI support in
CloudStack?

-- 
Erik

[GitHub] cloudstack pull request: CLOUDSTACK-8720: Handle corner case in re...

[nitt10prashant]

Github user nitt10prashant commented on the pull request:

https://github.com/apache/cloudstack/pull/671#issuecomment-129401139
  
Looks Good


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8721: Fixed Setting details of...

[anshul1886]

GitHub user anshul1886 opened a pull request:

https://github.com/apache/cloudstack/pull/673

CLOUDSTACK-8721: Fixed Setting details of VM through API results in removal 
of all other details except the one passed in API



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/anshul1886/cloudstack-1 CLOUDSTACK-8721

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/673.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #673


commit 728635a3d3c4a4080ebcbcfbee54c0450b10012d
Author: Anshul Gangwar 
Date:   2015-08-10T10:43:42Z

CLOUDSTACK-8721: Fixed Setting details of VM through API results in removal 
of all other details except the one passed in API




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8704: Schedule restart of rout...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/656#issuecomment-129405117
  
@remibergsma ahum,... LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8721: Fixed Setting details of...

[anshul1886]

Github user anshul1886 commented on the pull request:

https://github.com/apache/cloudstack/pull/673#issuecomment-129407249
  
cloudstack-pull-requests #945 failure is because of some random error in 
git fetching


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8704: Schedule restart of rout...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/656#issuecomment-129407180
  
@DaanHoogland You already gave your LGTM? See here: 
https://github.com/apache/cloudstack/pull/656#issuecomment-127529005



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8687: Prepare template only on...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/635#issuecomment-129408998
  
@devdeep How about testing if the right (number of) threads are being 
started? Does my comment make any sense?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8687: Prepare template only on...

[remibergsma]

Github user remibergsma commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/635#discussion_r36620562
  
--- Diff: 
api/src/org/apache/cloudstack/api/command/admin/template/PrepareTemplateCmd.java
 ---
@@ -60,6 +61,15 @@
description = "template ID of the template to be prepared 
in primary storage(s).")
 private Long templateId;
 
+@ACL(accessType = AccessType.OperateEntry)
+@Parameter(name = ApiConstants.STORAGE_ID,
+type = CommandType.UUID,
+entityType = StoragePoolResponse.class,
+required = false,
+description = "storage pool ID of the primary storage pool to 
which the template should be prepared. If it is not provided the template" +
+" is prepared on all the available primary storage 
pools.")
+private Long storageId;
--- End diff --

Ok, thanks for clarifying!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: test case automated for list template pag...

[shwetaag]

Github user shwetaag commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/646#discussion_r36620849
  
--- Diff: test/integration/component/maint/test_escalation_templates.py ---
@@ -0,0 +1,394 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from marvin.cloudstackTestCase import cloudstackTestCase, unittest
+from marvin.lib.base import (Account,
+ Domain, Template, 
Configurations,VirtualMachine,Snapshot,ServiceOffering
+ )
+from marvin.lib.utils import (cleanup_resources, validateList)
+from marvin.lib.common import (get_zone, get_template, 
get_builtin_template_info,update_resource_limit,list_volumes )
+from nose.plugins.attrib import attr
+from marvin.codes import PASS
+from marvin.sshClient import SshClient
+from marvin.cloudstackException import CloudstackAPIException
+import time
+
+
+class TestlistTemplates(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+
+testClient = super(
+TestlistTemplates, cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls.testdata = testClient.getParsedTestDataConfig()
+cls.zone = get_zone(cls.apiclient, 
cls.testClient.getZoneForTests())
+cls.template = get_template(
+cls.apiclient,
+cls.zone.id,
+cls.testdata["ostype"]
+)
+cls.hypervisor = cls.testClient.getHypervisorInfo()
+builtin_info = get_builtin_template_info(cls.apiclient, 
cls.zone.id)
+cls.testdata["templates"]["url"] = builtin_info[0]
+cls.testdata["templates"]["hypervisor"] = builtin_info[1]
+cls.testdata["templates"]["format"] = builtin_info[2]
+if cls.zone.localstorageenabled:
+cls.storagetype = 'local'
+cls.testdata["service_offerings"]["tiny"]["storagetype"] = 
'local'
+cls.testdata["disk_offering"]["storagetype"] = 'local'
+else:
+cls.storagetype = 'shared'
+cls.testdata["service_offerings"]["tiny"]["storagetype"] = 
'shared'
+cls.testdata["disk_offering"]["storagetype"] = 'shared'
+cls.testdata["virtual_machine"]["hypervisor"] = cls.hypervisor
+cls.testdata["virtual_machine"]["zoneid"] = cls.zone.id
+cls.testdata["virtual_machine"]["template"] = cls.template.id
+cls.testdata["custom_volume"]["zoneid"] = cls.zone.id
+cls.service_offering = ServiceOffering.create(
+cls.apiclient,
+cls.testdata["service_offerings"]["tiny"]
+)
+cls.mgtSvrDetails = cls.config.__dict__["mgtSvr"][0].__dict__
+cls.cleanup = []
+
+# Create 1 domain admin account
+
+cls.domain = Domain.create(
+cls.apiclient,
+cls.testdata["domain"])
+
+cls.account = Account.create(
+cls.apiclient,
+cls.testdata["account"],
+admin=True,
+domainid=cls.domain.id)
+
+cls.debug("Created account %s in domain %s" %
+  (cls.account.name, cls.domain.id))
+
+cls.cleanup.append(cls.account)
+cls.cleanup.append(cls.domain)
+
+@classmethod
+def tearDownClass(cls):
+try:
+# Cleanup resources used
+cleanup_resources(cls.apiclient, cls.cleanup)
+
+except Exception as e:
+raise Exception("Warning: Exception during cleanup : %s" % e)
+return
+def RestartServers(self):
+""" Restart management server and usage server """
+
+sshClient = SshClient(
+self.mgtSvrDetails["mgtSvrIp"],
+22,
+self.mgtSvrDetails["user"],
+self.mgtSvrDetails["passwd"]
+)
+command = "

[GitHub] cloudstack pull request: test case automated for list template pag...

[shwetaag]

Github user shwetaag commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/646#discussion_r36621050
  
--- Diff: test/integration/component/maint/test_escalation_templates.py ---
@@ -0,0 +1,394 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from marvin.cloudstackTestCase import cloudstackTestCase, unittest
+from marvin.lib.base import (Account,
+ Domain, Template, 
Configurations,VirtualMachine,Snapshot,ServiceOffering
+ )
+from marvin.lib.utils import (cleanup_resources, validateList)
+from marvin.lib.common import (get_zone, get_template, 
get_builtin_template_info,update_resource_limit,list_volumes )
+from nose.plugins.attrib import attr
+from marvin.codes import PASS
+from marvin.sshClient import SshClient
+from marvin.cloudstackException import CloudstackAPIException
+import time
+
+
+class TestlistTemplates(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+
+testClient = super(
+TestlistTemplates, cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls.testdata = testClient.getParsedTestDataConfig()
+cls.zone = get_zone(cls.apiclient, 
cls.testClient.getZoneForTests())
+cls.template = get_template(
+cls.apiclient,
+cls.zone.id,
+cls.testdata["ostype"]
+)
+cls.hypervisor = cls.testClient.getHypervisorInfo()
+builtin_info = get_builtin_template_info(cls.apiclient, 
cls.zone.id)
+cls.testdata["templates"]["url"] = builtin_info[0]
+cls.testdata["templates"]["hypervisor"] = builtin_info[1]
+cls.testdata["templates"]["format"] = builtin_info[2]
+if cls.zone.localstorageenabled:
+cls.storagetype = 'local'
+cls.testdata["service_offerings"]["tiny"]["storagetype"] = 
'local'
+cls.testdata["disk_offering"]["storagetype"] = 'local'
+else:
+cls.storagetype = 'shared'
+cls.testdata["service_offerings"]["tiny"]["storagetype"] = 
'shared'
+cls.testdata["disk_offering"]["storagetype"] = 'shared'
+cls.testdata["virtual_machine"]["hypervisor"] = cls.hypervisor
+cls.testdata["virtual_machine"]["zoneid"] = cls.zone.id
+cls.testdata["virtual_machine"]["template"] = cls.template.id
+cls.testdata["custom_volume"]["zoneid"] = cls.zone.id
+cls.service_offering = ServiceOffering.create(
+cls.apiclient,
+cls.testdata["service_offerings"]["tiny"]
+)
+cls.mgtSvrDetails = cls.config.__dict__["mgtSvr"][0].__dict__
+cls.cleanup = []
+
+# Create 1 domain admin account
+
+cls.domain = Domain.create(
+cls.apiclient,
+cls.testdata["domain"])
+
+cls.account = Account.create(
+cls.apiclient,
+cls.testdata["account"],
+admin=True,
+domainid=cls.domain.id)
+
+cls.debug("Created account %s in domain %s" %
+  (cls.account.name, cls.domain.id))
+
+cls.cleanup.append(cls.account)
+cls.cleanup.append(cls.domain)
+
+@classmethod
+def tearDownClass(cls):
+try:
+# Cleanup resources used
+cleanup_resources(cls.apiclient, cls.cleanup)
+
+except Exception as e:
+raise Exception("Warning: Exception during cleanup : %s" % e)
+return
+def RestartServers(self):
+""" Restart management server and usage server """
+
+sshClient = SshClient(
+self.mgtSvrDetails["mgtSvrIp"],
+22,
+self.mgtSvrDetails["user"],
+self.mgtSvrDetails["passwd"]
+)
+command = "

[GitHub] cloudstack pull request: APIServlet, AuthCmd, SAML fixes

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/650#discussion_r36621140
  
--- Diff: 
plugins/user-authenticators/saml2/src/org/apache/cloudstack/api/command/SAML2LoginAPIAuthenticatorCmd.java
 ---
@@ -322,21 +306,11 @@ public String authenticate(final String command, 
final Map par
 if (_apiServer.verifyUser(userAccount.getId())) {
 LoginCmdResponse loginResponse = 
(LoginCmdResponse) _apiServer.loginUser(session, userAccount.getUsername(), 
userAccount.getUsername() + userAccount.getSource().toString(),
 userAccount.getDomainId(), null, 
remoteAddress, params);
-resp.addCookie(new Cookie("userid", 
URLEncoder.encode(loginResponse.getUserId(), HttpUtils.UTF_8)));
-resp.addCookie(new Cookie("domainid", 
URLEncoder.encode(loginResponse.getDomainId(), HttpUtils.UTF_8)));
-resp.addCookie(new Cookie("role", 
URLEncoder.encode(loginResponse.getType(), HttpUtils.UTF_8)));
-resp.addCookie(new Cookie("username", 
URLEncoder.encode(loginResponse.getUsername(), HttpUtils.UTF_8)));
-resp.addCookie(new Cookie("account", 
URLEncoder.encode(loginResponse.getAccount(), HttpUtils.UTF_8)));
-String timezone = loginResponse.getTimeZone();
-if (timezone != null) {
-resp.addCookie(new Cookie("timezone", 
URLEncoder.encode(timezone, HttpUtils.UTF_8)));
-}
-resp.addCookie(new Cookie("userfullname", 
URLEncoder.encode(loginResponse.getFirstName() + " " + 
loginResponse.getLastName(), HttpUtils.UTF_8).replace("+", "%20")));
-resp.addHeader("SET-COOKIE", 
String.format("%s=%s;HttpOnly", ApiConstants.SESSIONKEY, 
loginResponse.getSessionKey()));
+SAMLUtils.setupSamlUserCookies(loginResponse, 
resp);
 
resp.sendRedirect(SAML2AuthManager.SAMLCloudStackRedirectionUrl.value());
 return 
ApiResponseSerializer.toSerializedString(loginResponse, responseType);
 }
-} catch (final CloudAuthenticationException ignored) {
+} catch (final Exception ignored) {
--- End diff --

Do we really want to ignore unchecked exceptions here?  Seems like we 
should be explicitly catching the expected checked exceptions.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8687: Prepare template only on...

[devdeep]

Github user devdeep commented on the pull request:

https://github.com/apache/cloudstack/pull/635#issuecomment-129411154
  
@DaanHoogland That is what I am looking into; how to get the number of 
threads that have been started by the executor service.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: APIServlet, AuthCmd, SAML fixes

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/650#discussion_r36621580
  
--- Diff: 
plugins/user-authenticators/saml2/src/org/apache/cloudstack/api/command/SAML2LoginAPIAuthenticatorCmd.java
 ---
@@ -322,21 +306,11 @@ public String authenticate(final String command, 
final Map par
 if (_apiServer.verifyUser(userAccount.getId())) {
 LoginCmdResponse loginResponse = 
(LoginCmdResponse) _apiServer.loginUser(session, userAccount.getUsername(), 
userAccount.getUsername() + userAccount.getSource().toString(),
 userAccount.getDomainId(), null, 
remoteAddress, params);
-resp.addCookie(new Cookie("userid", 
URLEncoder.encode(loginResponse.getUserId(), HttpUtils.UTF_8)));
-resp.addCookie(new Cookie("domainid", 
URLEncoder.encode(loginResponse.getDomainId(), HttpUtils.UTF_8)));
-resp.addCookie(new Cookie("role", 
URLEncoder.encode(loginResponse.getType(), HttpUtils.UTF_8)));
-resp.addCookie(new Cookie("username", 
URLEncoder.encode(loginResponse.getUsername(), HttpUtils.UTF_8)));
-resp.addCookie(new Cookie("account", 
URLEncoder.encode(loginResponse.getAccount(), HttpUtils.UTF_8)));
-String timezone = loginResponse.getTimeZone();
-if (timezone != null) {
-resp.addCookie(new Cookie("timezone", 
URLEncoder.encode(timezone, HttpUtils.UTF_8)));
-}
-resp.addCookie(new Cookie("userfullname", 
URLEncoder.encode(loginResponse.getFirstName() + " " + 
loginResponse.getLastName(), HttpUtils.UTF_8).replace("+", "%20")));
-resp.addHeader("SET-COOKIE", 
String.format("%s=%s;HttpOnly", ApiConstants.SESSIONKEY, 
loginResponse.getSessionKey()));
+SAMLUtils.setupSamlUserCookies(loginResponse, 
resp);
 
resp.sendRedirect(SAML2AuthManager.SAMLCloudStackRedirectionUrl.value());
 return 
ApiResponseSerializer.toSerializedString(loginResponse, responseType);
 }
-} catch (final CloudAuthenticationException ignored) {
+} catch (final Exception ignored) {
--- End diff --

I agree with @jburwell and want to add that any catch should, if not 
handling the exception explicitely, at least log the fact that it has been 
caught.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8687: Prepare template only on...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/635#issuecomment-129412845
  
You can mock the call and verify how often it has been called with mockito.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

acs github branch 4.5 - compiling error

[Tomasz Zięba]

Hello,

We have problems with compiling 4.5 branch.
We think that this problem occurs for last week.

Cound someone confirm this  ?

Step to reproduce:
1. Download source
https://github.com/apache/cloudstack/archive/4.5.zip

2. mvn install
3. errror

Running rdpclient.MockServerTest
Error in mock server: Received fatal alert: unexpected_message
javax.net.ssl.SSLException: Received fatal alert: unexpected_message
at sun.security.ssl.Alerts.getSSLException(Alerts.java:208)
at sun.security.ssl.Alerts.getSSLException(Alerts.java:154)
at sun.security.ssl.SSLSocketImpl.recvAlert(SSLSocketImpl.java:1991)
at
sun.security.ssl.SSLSocketImpl.readRecord(SSLSocketImpl.java:1098)
at
sun.security.ssl.SSLSocketImpl.performInitialHandshake(SSLSocketImpl.java:1344)
at
sun.security.ssl.SSLSocketImpl.startHandshake(SSLSocketImpl.java:1371)
at
sun.security.ssl.SSLSocketImpl.startHandshake(SSLSocketImpl.java:1355)
at streamer.debug.MockServer.run(MockServer.java:120)
at java.lang.Thread.run(Thread.java:745)
Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.143 sec
<<< FAILURE!

Results :

Tests in error:
  testIsMockServerCanUpgradeConnectionToSsl(rdpclient.MockServerTest):
Failed to find any kerberos service ticket for host/tes...@example.com

Tests run: 404, Failures: 0, Errors: 1, Skipped: 0


[INFO] Apache CloudStack Client UI ... SUCCESS [14.814s]
[INFO] Apache CloudStack Console Proxy - RDP Client .. FAILURE [20.100s]
[INFO] Apache CloudStack Console Proxy ... SKIPPED
[INFO] Apache CloudStack Console Proxy - Server .. SKIPPED
[INFO] Apache CloudStack Framework - QuickCloud .. SKIPPED
[INFO]

[INFO] BUILD FAILURE
[INFO]

[INFO] Total time: 19:49.102s
[INFO] Finished at: Mon Aug 10 13:22:21 CEST 2015
[INFO] Final Memory: 76M/290M
[INFO]

[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-surefire-plugin:2.12:test (default-test) on
project cloudstack-service-console-proxy-rdpclient: There are test failures.
[ERROR]
[ERROR] Please refer to
/root/cs452/cloudstack-4.5/services/console-proxy-rdp/rdpconsole/target/surefire-reports
for the individual test results.
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions,
please read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the
command
[ERROR]   mvn  -rf :cloudstack-service-console-proxy-rdpclient


-- 
Regards,
Tomasz Zięba
Twitter: @TZieba
LinkedIn: pl.linkedin.com/pub/tomasz-zięba-ph-d/3b/7a8/ab6/

Re: happy birthday dear cloudstack.git

[Rohit Yadav]

Fantastic :)

On 10-Aug-2015, at 3:07 pm, Punith S 
mailto:punit...@cloudbyte.com>> wrote:

Wow! happy birthday cloudstack :)

On Mon, Aug 10, 2015 at 3:03 PM, Wido den Hollander 
mailto:w...@widodh.nl>> wrote:

Congrats! Great :-)

On 10-08-15 11:17, Daan Hoogland wrote:
Ladies and gentleman,

At the 11th of August 2010, Manuel Amador made the first commit in our
repository. I never met the guy but want to take the occasion to
congratulate him and all other contributors with the 5th aniversary of
our
repository.

​:beer::cake::clappinghands:​





--
Regards,

punith s
cloudbyte.com

Regards,
Rohit Yadav
Software Architect, ShapeBlue


[cid:9DD97B41-04C5-45F0-92A7-951F3E962F7A]


M. +91 88 262 30892 | 
rohit.ya...@shapeblue.com
Blog: bhaisaab.org | Twitter: @_bhaisaab




Find out more about ShapeBlue and our range of CloudStack related services

IaaS Cloud Design & Build
CSForge – rapid IaaS deployment framework
CloudStack Consulting
CloudStack Software 
Engineering
CloudStack Infrastructure 
Support
CloudStack Bootcamp Training Courses

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England & Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company 
registered by The Republic of South Africa and is traded under license from 
Shape Blue Ltd. ShapeBlue is a registered trademark.

Re: happy birthday dear cloudstack.git

[Remi Bergsma]

Awesome! Happy birthday :-)

On 10 Aug 2015, at 13:39, Rohit Yadav 
mailto:rohit.ya...@shapeblue.com>> wrote:

Fantastic :)

On 10-Aug-2015, at 3:07 pm, Punith S 
mailto:punit...@cloudbyte.com>> wrote:

Wow! happy birthday cloudstack :)

On Mon, Aug 10, 2015 at 3:03 PM, Wido den Hollander 
mailto:w...@widodh.nl>> wrote:

Congrats! Great :-)

On 10-08-15 11:17, Daan Hoogland wrote:
Ladies and gentleman,

At the 11th of August 2010, Manuel Amador made the first commit in our
repository. I never met the guy but want to take the occasion to
congratulate him and all other contributors with the 5th aniversary of
our
repository.

​:beer::cake::clappinghands:​





--
Regards,

punith s
cloudbyte.com

Regards,
Rohit Yadav
Software Architect, ShapeBlue




M. +91 88 262 30892 | 
rohit.ya...@shapeblue.com
Blog: bhaisaab.org | Twitter: @_bhaisaab




Find out more about ShapeBlue and our range of CloudStack related services

IaaS Cloud Design & Build
CSForge – rapid IaaS deployment framework
CloudStack Consulting
CloudStack Software 
Engineering
CloudStack Infrastructure 
Support
CloudStack Bootcamp Training Courses

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England & Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company 
registered by The Republic of South Africa and is traded under license from 
Shape Blue Ltd. ShapeBlue is a registered trademark.

[GitHub] cloudstack pull request: CLOUDSTACK-8696: Create Region fails with...

[karuturi]

Github user karuturi commented on the pull request:

https://github.com/apache/cloudstack/pull/657#issuecomment-129423682
  
WRT master/4.6 4.5.2 was assumed frozen. There are other changes in 
452to462 sql as well which may/maynot be bug fixes. 
A separate PR needs to be done for 451to452


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: test case automated for list template pag...

[sanju1010]

Github user sanju1010 commented on the pull request:

https://github.com/apache/cloudstack/pull/646#issuecomment-129424914
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Database consistency check

[Daan Hoogland]

Norbert, I haven't begun to think about it. including dev@ to gather ideas.
The db structure is based on updates since 4.0. A new install will be a 4.0
DB which will then undergo a series of upgrade steps. A validation of the
db could be divided in a basic part and an incremental part, maybe.

A good tactic might be to start a collection of smaller checks that
validate only individual parts. An example would be orphaned volumes, or
removed volumes that are still attached to VMs. completeness of link tables
is another one.

This is not going to be caught in a single story, i'm afraid.

On Mon, Aug 10, 2015 at 2:03 PM, Norbert Klein <
norbert.kl...@infosecprojects.net> wrote:

> Do you have any idea where to start? (I am not a developer). If there is
> no script avaible
> I think a developer has to do it or at least I need the criterias from
> them. Without knowing
> the internal CS structure I don't know exactly what to check.
>
> Am 10.08.2015 um 13:51 schrieb Daan Hoogland:
> > Good point Norbert, I don't think there is. would be a great addition
> > though. You want to take this on or at least create a ticket for it in
> > jira?
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20CLOUDSTACK
> >
> > On Mon, Aug 10, 2015 at 1:48 PM, Norbert Klein <
> > norbert.kl...@infosecprojects.net> wrote:
> >
> >> Hi all,
> >>
> >> what is the best way to check the cloudstack database consistency?
> >> Is there any tool or script available which we could use to make sure
> >> the database structure and content
> >> is in a valid state? (for example after manual changes).
> >>
> >> Thx
> >> Norbert
> >>
> >>
> >
>



-- 
Daan

Re: [DISCUSS] Improving API reference pages

[Rajsekhar K]

Hi, Dave, Somesh,

Thanks for your feedback. Thanks for the help that you promised on this
task.

Hi, Dave,

Thanks for providing the Style Guide for the API Guides and some good
pointers on improving the API content. This is helpful.

Hi, Somesh,

Thanks for your willingness to help with the content.

I will use the information that you shared with me to create an efficient
plan for improving content for the 20 APIs that I listed in my earlier
email. Will get back to all of you with my plan for this task soon.

Regards,
Rajsekhar

On Mon, Aug 3, 2015 at 9:28 PM, Somesh Naidu 
wrote:

> {should you be adding [DISCUSS] and/or [PROPOSAL] to the subject?}
>
> +1
>
> Definitely required. Improvements in description/function required for
> both the API call itself and associated parameters. I am willing to help
> with the content.
>
> Regards,
> Somesh
>
>
> -Original Message-
> From: Dave Dunaway [mailto:dave.duna...@gmail.com]
> Sent: Monday, August 03, 2015 9:24 AM
> To: us...@cloudstack.apache.org
> Cc: dev@cloudstack.apache.org
> Subject: Re: Improving API reference pages
>
> I would definitely say this is needed. A few calls need to specify "types"
> of which there is not description or they are poorly worded.
>
> If the API doc page could have comments... that would be good too. Let the
> community add examples or suggestions.
>
> However the real deal is to document the attributes and return values for
>  each call. Show a basic call using curl. Describe what the call does (some
> have no description). Like what most other sites with API's do :)
>
> Here's a "style" guide for API documentation creation... it seems pretty
> good.
>
> http://blog.parse.com/learn/engineering/designing-great-api-docs/
>
> HTH
>
> dave.
>
>
>
> On Mon, Aug 3, 2015 at 5:37 AM, Rajsekhar K 
> wrote:
>
> > Hi, All,
> >
> > This is part of our effort to improve user experience of
> > Cloudstack/CloudPlatform API reference pages.
> >
> > Majority of the CloudStack/CloudPlatform API reference pages do not
> >  adequately describe the usage of the parameters associated with them.
> Many
> > of these parameters contain only a single line description, which does
> not
> > really enhance the user's experience with these APIs.
> >
> > CloudPlatform had received a few documentation tickets on this, with
> > requests to improve the description, add information on the format, and
> an
> > example on how to use the parameter. One of the tickets was on the
> > *migrateto *parameter in the *migrateVirtualMachineWithVolume* API
> > reference page. We have improved the description of the *migrateto
> > *parameter
> > as follows:
> >
> > *Parameter*
> >
> > *Description*
> >
> > *Required*
> >
> > *migrateto*
> >
> > Storage to pool mapping. This parameter specifies the mapping between a
> > volume and a pool where you want to migrate that volume. Format of this
> > parameter:
> >
> >
> migrateto[volume-index].volume=&migrateto[volume-index].pool=Where,
> > [volume-index] indicates the index to identify the volume that you want
> to
> > migrate, volume= indicates the UUID of the volume that you want to
> > migrate, and pool= indicates the UUID of the pool where you want to
> > migrate the volume. Example:
> >
> >
> migrateto[0].volume=<71f43cd6-69b0-4d3b-9fbc-67f50963d60b>&migrateto[0].pool=&migrateto[1].volume=<88de0173-55c0-4c1c-a269-83d0279eeedf>&migrateto[1].pool=<95d6e97c-6766-4d67-9a30-c449c15011d1>&migrateto[2].volume=<1b331390-59f2-4796-9993-bf11c6e76225>&migrateto[2].pool=<41fdb564-9d3b-447d-88ed-7628f7640cbc>
> >
> > False
> >
> > (This will be updated in the *migrateVirtualMachineWithVolume* API
> > reference page of CloudStack soon.)
> >
> > I think I can take this as a base and improve the descriptions of the
> > parameters in the CloudStack/Cloudplatform API reference pages. As an
> > initial step, I have identified the following 20 API functions and I am
> > planning to improve the description of the parameters in their reference
> > pages:
> >
> >
> >-
> > *listAccounts *
> >-
> > *listCapacity *
> >-
> > *listLoadBalancerRules *
> >-
> > *listNetworks *
> >-
> > *listPublicIpAddresses *
> >-
> > *listSnapshots *
> >-
> > *listTemplates *
> >-
> > *listVirtualMachines *
> >-
> > *listVolumes *
> >-
> > *listZones *
> >-
> > *stopVirtualMachine *
> >-
> > *associateIPAddress *
> >-
> > *attachVolume *
> >-
> > *createSnapshot *
> >-
> > *startVirtualMachine *
> >-
> > *deployVirtualMachine *
> >-
> > *migrateVirtualMachineWithVolume *
> >-
> > *login *
> >-
> > *logout *
> >- *updateVirtualMachine*
> >
> > Could you please provide your thoughts on this suggestion? Also, please
> let
> > me know how you can help/contribute in this effort.
> >
> > Regards,
> > Rajsekhar
> >
>

New Defects reported by Coverity Scan for cloudstack

[scan-admin]

Hi,

Please find the latest report on new defect(s) introduced to cloudstack found 
with Coverity Scan.

17 new defect(s) introduced to cloudstack found with Coverity Scan.
55 defect(s), reported by Coverity Scan earlier, were marked fixed in the 
recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 17 of 17 defect(s)


** CID 1114596:  Class hierarchy inconsistencies  (CALL_SUPER)
/awsapi/src/com/cloud/bridge/io/DimeDelimitedInputStream.java: 475 in 
com.cloud.bridge.io.DimeDelimitedInputStream.close()()



*** CID 1114596:  Class hierarchy inconsistencies  (CALL_SUPER)
/awsapi/src/com/cloud/bridge/io/DimeDelimitedInputStream.java: 475 in 
com.cloud.bridge.io.DimeDelimitedInputStream.close()()
469  * This will take care of flushing any remaining data to the stream.
470  * Multiple calls to this method will result in the stream being 
closed once
471  * and then all subsequent calls being ignored.
472  *
473  * @throws IOException if the stream could not be closed
474  */
>>> CID 1114596:  Class hierarchy inconsistencies  (CALL_SUPER)
>>> Missing call to "java.io.FilterInputStream.close()" (as is done 
>>> elsewhere 5 out of 7 times).
475 public void close() throws IOException {
476 synchronized (this) {
477 if (closed)
478 return;
479 closed = true;//mark it closed.
480 }

** CID 1315774:  Resource leaks  (RESOURCE_LEAK)
/framework/db/src/com/cloud/utils/db/DbUtil.java: 257 in 
com.cloud.utils.db.DbUtil.releaseGlobalLock(java.lang.String)()



*** CID 1315774:  Resource leaks  (RESOURCE_LEAK)
/framework/db/src/com/cloud/utils/db/DbUtil.java: 257 in 
com.cloud.utils.db.DbUtil.releaseGlobalLock(java.lang.String)()
251 } catch (Throwable e) {
252 s_logger.error("RELEASE_LOCK() throws exception ", e);
253 } finally {
254 closeResultSet(rs);
255 closeStatement(pstmt);
256 closeConnection(conn);
>>> CID 1315774:  Resource leaks  (RESOURCE_LEAK)
>>> Variable "pstmt" going out of scope leaks the resource it refers to.
257 }
258 return false;
259 }
260 
261 public static void closeResources(final Connection connection, 
final Statement statement, final ResultSet resultSet) {
262 

** CID 1315775:(RESOURCE_LEAK)
/engine/schema/src/com/cloud/upgrade/dao/Upgrade30xBase.java: 51 in 
com.cloud.upgrade.dao.Upgrade30xBase.getNetworkLabelFromConfig(java.sql.Connection,
 java.lang.String)()
/engine/schema/src/com/cloud/upgrade/dao/Upgrade30xBase.java: 52 in 
com.cloud.upgrade.dao.Upgrade30xBase.getNetworkLabelFromConfig(java.sql.Connection,
 java.lang.String)()



*** CID 1315775:(RESOURCE_LEAK)
/engine/schema/src/com/cloud/upgrade/dao/Upgrade30xBase.java: 51 in 
com.cloud.upgrade.dao.Upgrade30xBase.getNetworkLabelFromConfig(java.sql.Connection,
 java.lang.String)()
45 }
46 } catch (SQLException e) {
47 throw new CloudRuntimeException("Unable to fetch network 
label from configuration", e);
48 } finally {
49 closeAutoCloseable(rs);
50 closeAutoCloseable(pstmt);
>>> CID 1315775:(RESOURCE_LEAK)
>>> Variable "pstmt" going out of scope leaks the resource it refers to.
51 }
52 return networkLabel;
53 }
54 
55 protected long addPhysicalNetworkToZone(Connection conn, long 
zoneId, String zoneName, String networkType, String vnet, Long domainId) {
56 
/engine/schema/src/com/cloud/upgrade/dao/Upgrade30xBase.java: 52 in 
com.cloud.upgrade.dao.Upgrade30xBase.getNetworkLabelFromConfig(java.sql.Connection,
 java.lang.String)()
46 } catch (SQLException e) {
47 throw new CloudRuntimeException("Unable to fetch network 
label from configuration", e);
48 } finally {
49 closeAutoCloseable(rs);
50 closeAutoCloseable(pstmt);
51 }
>>> CID 1315775:(RESOURCE_LEAK)
>>> Variable "pstmt" going out of scope leaks the resource it refers to.
52 return networkLabel;
53 }
54 
55 protected long addPhysicalNetworkToZone(Connection conn, long 
zoneId, String zoneName, String networkType, String vnet, Long domainId) {
56 
57 String getNextNetworkSequenceSql = "SELECT value from 
`cloud`.`sequence` where name='physical_networks_seq'";

** CID 1315776:  Exceptional resource leaks  (RESOURCE_LEAK)
/engine/schema/src/com/cloud/upgrade/dao/Upg

RE: happy birthday dear cloudstack.git

[Somesh Naidu]

Happy Birthday Cloudstack :)

@Daan - IIRC, Manuel moved the source code from sccs to git so all the commits, 
since 2008 until this date, reflect his name :)

Regards,
Somesh

-Original Message-
From: Remi Bergsma [mailto:rberg...@schubergphilis.com] 
Sent: Monday, August 10, 2015 7:48 AM
To: dev@cloudstack.apache.org
Subject: Re: happy birthday dear cloudstack.git

Awesome! Happy birthday :-)

On 10 Aug 2015, at 13:39, Rohit Yadav 
mailto:rohit.ya...@shapeblue.com>> wrote:

Fantastic :)

On 10-Aug-2015, at 3:07 pm, Punith S 
mailto:punit...@cloudbyte.com>> wrote:

Wow! happy birthday cloudstack :)

On Mon, Aug 10, 2015 at 3:03 PM, Wido den Hollander 
mailto:w...@widodh.nl>> wrote:

Congrats! Great :-)

On 10-08-15 11:17, Daan Hoogland wrote:
Ladies and gentleman,

At the 11th of August 2010, Manuel Amador made the first commit in our
repository. I never met the guy but want to take the occasion to
congratulate him and all other contributors with the 5th aniversary of
our
repository.

​:beer::cake::clappinghands:​





--
Regards,

punith s
cloudbyte.com

Regards,
Rohit Yadav
Software Architect, ShapeBlue




M. +91 88 262 30892 | 
rohit.ya...@shapeblue.com
Blog: bhaisaab.org | Twitter: @_bhaisaab




Find out more about ShapeBlue and our range of CloudStack related services

IaaS Cloud Design & Build
CSForge – rapid IaaS deployment framework
CloudStack Consulting
CloudStack Software 
Engineering
CloudStack Infrastructure 
Support
CloudStack Bootcamp Training Courses

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England & Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company 
registered by The Republic of South Africa and is traded under license from 
Shape Blue Ltd. ShapeBlue is a registered trademark.

RE: Revisit Process for creating Blocker bugs

[Somesh Naidu]

> I did not see (or understand) a major change proposed or needed in this 
> thread.

The primary topic of discussion is categorization of a defect as Blocker, that 
is, how to qualify a defect as Blocker. The discussion scope widened and 
included process to raise an issue as "Blocker".

The issue/discussion seems to have risen due to some folks (Raja and team) 
raising a blocker without discussion on ML. As a counter measure, these defects 
were downgraded to "Critical" (by Daan).

In terms of qualification for a blocker, the two school of thoughts were,
Raja/Ram - consideration should be drawn from the technical/functional impact 
irrespective of how many users are affected.
Daan - consideration should be drawn from how many users are affected (achieved 
by voting).

In terms of the process, two approaches proposed were,
Raja/Ram - the reporter should first set the priority level to "Blocker" and in 
parallel raise it for discussion on the ML.
Daan - the reporter should raise such defect as "Critical" and then work on 
promoting it to "Blocker" via lazy consensus.

I am not entirely sure which approach suggests a change.

@Daan/Raja - My sincere apologies in case my summary has inaccuracies; please 
feel free to correct.

My proposal was (matches with mostly what Sebastian said),
1. Create a wiki page with more detailed guidelines and processes for Release 
Blockers.
2. The reporter should raise a defect by qualifying against the above 
guidelines.
3. In case the reporter feels the defect qualifies as a Blocker, they should 
raise it as Blocker and create a discussion/voting thread on the ML for the 
same.
4. RM should ensure an explicit decision is made on the severity and 
upgrade/downgrade accordingly. Note, RM having the responsibility and authority 
to drive closure does not equate to veto power.

Regards,
Somesh


-Original Message-
From: Sebastien Goasguen [mailto:run...@gmail.com] 
Sent: Monday, August 10, 2015 4:23 AM
To: dev@cloudstack.apache.org
Subject: Re: Revisit Process for creating Blocker bugs


> On Aug 6, 2015, at 7:35 AM, Raja Pullela  wrote:
> 
> Looks like there are few of us who differ with the current 
> process/restriction.  
> Just to close this thread - there are already guidelines that exist currently 
> and we should continue to adopt or follow those.Let the Release Manager 
> or other people closely involved with a particular release decide on whether 
> a particular bug is correctly categorized or not.  They should have the veto 
> power to downgrade or upgrade, as necessary.
> 

I would not call it veto power.

Folks will file tickets and put a priority level, a RM will see blockers and 
when those are not resolved, the RM should go on the list and get a feel from 
the community about those blockers (whether they are or not).

I did not see (or understand) a major change proposed or needed in this thread.


> Assess Priority - 
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=30746287 
> When creating a new Jira ticket, please take a minute to correctly assess the 
> priority of the issue. By default, Jira assigns a new issue a Priority level 
> of Major. In many cases, this is wrong. Please be sure to set the Priority 
> correctly:
> Blocker: Blocks development and/or testing work, production cannot run. 
> Security issues.
> Critical: Crashes, loss of data, severe memory leak.
> Major: Major loss of function, broken feature, returns incorrect information, 
> etc.
> Minor: Minor loss of function, problem with an easy workaround. Wishlist 
> items.
> Trivial: Typos that don't affect comprehension of the UI, misaligned text, 
> etc.
> 
> -Original Message-
> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] 
> Sent: Wednesday, August 5, 2015 2:19 PM
> To: dev 
> Subject: Re: Revisit Process for creating Blocker bugs
> 
> Koushik, that would be true if we had our upgrade process in order.
> 
> On Wed, Aug 5, 2015 at 7:14 AM, Koushik Das  wrote:
> 
>> If there is a group of users in dire need for a specific feature they 
>> can always take the code and use it. No need to wait for an official release.
>> Official release should adhere to quality guidelines (at least in 
>> terms of any reported regressions) even if it means release getting delayed.
>> 
>> 
>> On 05-Aug-2015, at 2:39 AM, Daan Hoogland  wrote:
>> 
>>> Yes we can if there is a group of users that don't use it but are in 
>>> dire need far another feature. We just have to document and market 
>>> it properly
>>> 
>>> On Tue, Aug 4, 2015 at 6:48 PM, Ramanath Katru 
>>>  wrote:
 Daan,
 
 I beg to differ. This is very much a product issue. We cannot 
 knowingly
>> release with an existing/working functionality broken. Especially if 
>> it is one of the features that users expect to be there. Remote Access 
>> VPN is an example. Right now this functionality is broken.
 
 Ram Katru
 
 -Original Message-
 From: Daan Hoogland [mailto:da

Remi Bergsma joins the PMC

[Daan Hoogland]

LS,

Today the PMC has invited Remi Bergsma to join its ranks. I am happy to say
that he accepted. Please join me in congratulating Remi.

​regards,​
-- 
Daan

Re: Remi Bergsma joins the PMC

[Todd Pigram]

Congrats!!

On Monday, August 10, 2015, Daan Hoogland  wrote:

> LS,
>
> Today the PMC has invited Remi Bergsma to join its ranks. I am happy to say
> that he accepted. Please join me in congratulating Remi.
>
> ​regards,​
> --
> Daan
>


-- 


Todd Pigram
http://about.me/ToddPigram
www.linkedin.com/in/toddpigram/
@pigram86 on twitter
https://plus.google.com/+ToddPigram86
Mobile - 216-224-5769

PGP Public Key

Re: Remi Bergsma joins the PMC

[Simon Weller]

Congratulations Remi!



From: Daan Hoogland 
Sent: Monday, August 10, 2015 12:08 PM
To: dev
Subject: Remi Bergsma joins the PMC

LS,

Today the PMC has invited Remi Bergsma to join its ranks. I am happy to say
that he accepted. Please join me in congratulating Remi.

​regards,​
--
Daan

Re: Remi Bergsma joins the PMC

[Milamber]

Congrats Remi!

On 10/08/2015 18:08, Daan Hoogland wrote:

LS,

Today the PMC has invited Remi Bergsma to join its ranks. I am happy to say
that he accepted. Please join me in congratulating Remi.

​regards,​

Re: Remi Bergsma joins the PMC

[Ahmad Emneina]

Congrats Remi! Well deserved.

Ahmad E

> On Aug 10, 2015, at 10:08 AM, Daan Hoogland  wrote:
> 
> LS,
> 
> Today the PMC has invited Remi Bergsma to join its ranks. I am happy to say
> that he accepted. Please join me in congratulating Remi.
> 
> ​regards,​
> -- 
> Daan

Re: Remi Bergsma joins the PMC

[Mike Tutkowski]

Congratulations, Remi!

On Mon, Aug 10, 2015 at 11:08 AM, Daan Hoogland 
wrote:

> LS,
>
> Today the PMC has invited Remi Bergsma to join its ranks. I am happy to say
> that he accepted. Please join me in congratulating Remi.
>
> ​regards,​
> --
> Daan
>



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
*™*

Re: Anyone wants to take over these orphaned PRs?

[Mike Tutkowski]

I should be able to test it.

Talk to you soon,
Mike

On Sun, Aug 9, 2015 at 10:40 PM, Remi Bergsma 
wrote:

> Hi Mike,
>
> Thanks! It seems the testing / verification is still to do and that is the
> work. Merging itself can be done with a one-liner.
>
> Are you able to verify the fix in your lab?
>
> Sent from my iPhone
>
> > On 10 Aug 2015, at 04:13, Mike Tutkowski 
> wrote:
> >
> > I could take this one:
> >
> > CLOUDSTACK-8601. VMFS storage added as local storage can be re-added ...
> > #547
> > https://github.com/apache/cloudstack/pull/547
> > ==> 1x LGTM
> >
> > I asked this in the PR discussion, but are we under the impression that
> > this code has been tested well enough? If so, I can just merge it as the
> > code itself LGTM.
> >
> > On Sun, Aug 9, 2015 at 12:49 PM, Remi Bergsma <
> rberg...@schubergphilis.com>
> > wrote:
> >
> >> Hi all,
> >>
> >> These are 9 PRs sent by Likitha. If I understand correctly Likitha is no
> >> longer working with Citrix/ACS. The PRs seem mostly VMware related. Some
> >> have LGTM(s), most have comments about missing unit tests.
> >>
> >> What do we want to do with them? There's probably not gonna be an update
> >> from Likitha, so waiting for that does not make sense. Does anyone
> wants to
> >> step in and finalize a PR? You can get the PR to your own branch and add
> >> some work on top of the existing commits and finally send it as a new
> PR.
> >>
> >> I'll add a comment to each of them. If no one wants to take it over, I
> >> think we should close the PRs without merging. It's a pity, but I would
> >> rather not have long lists of orphaned PRs laying around. The less PRs
> are
> >> open, the better.
> >>
> >> Any comments?
> >>
> >> Regards,
> >> Remi
> >>
> >> Cloudstack 8612 [VMware] #562
> >> https://github.com/apache/cloudstack/pull/562
> >>
> >> CLOUDSTACK-8611. CS waits indefinitely for CheckS2SVpnConnectionsComm...
> >> #561
> >> https://github.com/apache/cloudstack/pull/561
> >>
> >> CLOUDSTACK-8609. [VMware] VM is not accessible after a migration acro...
> >> #556
> >> https://github.com/apache/cloudstack/pull/556
> >>
> >> CLOUDSTACK-8608. [VMware] System VM's failed to start due to permissions
> >> issue. #555
> >> https://github.com/apache/cloudstack/pull/555
> >>
> >> CLOUDSTACK-8610. Unable to attach 7th Disk to Windows Server 2012 R2 ...
> >> #554
> >> https://github.com/apache/cloudstack/pull/554
> >> ==> This one has 2xLGTM, but also some remarks to add unit tests.
> >>
> >> CLOUDSTACK-8602. MigrateVirtualMachineWithVolume leaves old chain dat...
> >> #548
> >> https://github.com/apache/cloudstack/pull/548
> >> ==> 1x LGTM
> >>
> >> CLOUDSTACK-8601. VMFS storage added as local storage can be re-added ...
> >> #547
> >> https://github.com/apache/cloudstack/pull/547
> >> ==> 1x LGTM
> >>
> >> CLOUDSTACK-8599. CS reports failure for a successful migration. #544
> >> https://github.com/apache/cloudstack/pull/544
> >>
> >> CLOUDSTACK-8415. SSVM shutdown during snapshot operation leaves behin...
> >> #540
> >> https://github.com/apache/cloudstack/pull/540
> >
> >
> > --
> > *Mike Tutkowski*
> > *Senior CloudStack Developer, SolidFire Inc.*
> > e: mike.tutkow...@solidfire.com
> > o: 303.746.7302
> > Advancing the way the world uses the cloud
> > *™*
>



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
*™*

[GitHub] cloudstack pull request: CLOUDSTACK-8379:add support to marvin to ...

[srikanteswartalluri]

Github user srikanteswartalluri commented on the pull request:

https://github.com/apache/cloudstack/pull/158#issuecomment-129546119
  
Folks, 
i am closing the PR. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8379:add support to marvin to ...

[srikanteswartalluri]

Github user srikanteswartalluri closed the pull request at:

https://github.com/apache/cloudstack/pull/158


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Remi Bergsma joins the PMC

[Erik Weber]

On Mon, Aug 10, 2015 at 7:08 PM, Daan Hoogland 
wrote:

> LS,
>
> Today the PMC has invited Remi Bergsma to join its ranks. I am happy to say
> that he accepted. Please join me in congratulating Remi.
>
>
Congratulations Remi :-)

-- 
Erik

Re: Anyone wants to take over these orphaned PRs?

[Remi Bergsma]

Hi Suresh,

Thanks for picking this up! Some PRs got feedback, it’d be great if that could 
be addressed. In a perfect world, changes are submitted with tests. I see many 
reviewers ask for them, so adding them definitely helps in getting LGTMs. 

Not 100% sure what you mean by “Can we take up the testcases for LGTM(s) PRs 
later and merge them”. You want to add the tests later? You can also take some 
more time and send it all in once. No hurries.

Do you want to keep the current PRs open for now or should we close them?

Regards, Remi

> On 10 Aug 2015, at 06:25, Suresh Kumar Anaparti 
>  wrote:
> 
> Hi Remi,
> 
> I'll work on these PRs and finalize them. Will send new PRs for them. As 
> Likitha is not responding, Can we take up the testcases for LGTM(s) PRs later 
> and merge them?  
> 
> Thanks,
> Suresh
> 
> -Original Message-
> From: Remi Bergsma [mailto:rberg...@schubergphilis.com] 
> Sent: Monday, 10 August 2015 12:20 AM
> To: 'dev@cloudstack.apache.org'
> Subject: Anyone wants to take over these orphaned PRs?
> 
> Hi all,
> 
> These are 9 PRs sent by Likitha. If I understand correctly Likitha is no 
> longer working with Citrix/ACS. The PRs seem mostly VMware related. Some have 
> LGTM(s), most have comments about missing unit tests.
> 
> What do we want to do with them? There's probably not gonna be an update from 
> Likitha, so waiting for that does not make sense. Does anyone wants to step 
> in and finalize a PR? You can get the PR to your own branch and add some work 
> on top of the existing commits and finally send it as a new PR.
> 
> I'll add a comment to each of them. If no one wants to take it over, I think 
> we should close the PRs without merging. It's a pity, but I would rather not 
> have long lists of orphaned PRs laying around. The less PRs are open, the 
> better.
> 
> Any comments?
> 
> Regards,
> Remi
> 
> Cloudstack 8612 [VMware] #562
> https://github.com/apache/cloudstack/pull/562
> 
> CLOUDSTACK-8611. CS waits indefinitely for CheckS2SVpnConnectionsComm... #561
> https://github.com/apache/cloudstack/pull/561
> 
> CLOUDSTACK-8609. [VMware] VM is not accessible after a migration acro... #556
> https://github.com/apache/cloudstack/pull/556
> 
> CLOUDSTACK-8608. [VMware] System VM's failed to start due to permissions 
> issue. #555
> https://github.com/apache/cloudstack/pull/555
> 
> CLOUDSTACK-8610. Unable to attach 7th Disk to Windows Server 2012 R2 ... #554
> https://github.com/apache/cloudstack/pull/554
> ==> This one has 2xLGTM, but also some remarks to add unit tests.
> 
> CLOUDSTACK-8602. MigrateVirtualMachineWithVolume leaves old chain dat... #548
> https://github.com/apache/cloudstack/pull/548
> ==> 1x LGTM
> 
> CLOUDSTACK-8601. VMFS storage added as local storage can be re-added ... #547
> https://github.com/apache/cloudstack/pull/547
> ==> 1x LGTM
> 
> CLOUDSTACK-8599. CS reports failure for a successful migration. #544
> https://github.com/apache/cloudstack/pull/544
> 
> CLOUDSTACK-8415. SSVM shutdown during snapshot operation leaves behin... #540
> https://github.com/apache/cloudstack/pull/540
> 
> 

RE: Remi Bergsma joins the PMC

[Somesh Naidu]

Congratulations Remi!

Regards,
Somesh


-Original Message-
From: Erik Weber [mailto:terbol...@gmail.com] 
Sent: Monday, August 10, 2015 2:13 PM
To: dev
Subject: Re: Remi Bergsma joins the PMC

On Mon, Aug 10, 2015 at 7:08 PM, Daan Hoogland 
wrote:

> LS,
>
> Today the PMC has invited Remi Bergsma to join its ranks. I am happy to say
> that he accepted. Please join me in congratulating Remi.
>
>
Congratulations Remi :-)

-- 
Erik

[GitHub] cloudstack pull request: CLOUDSTACK-8721: Fixed Setting details of...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/673#issuecomment-129572848
  
@anshul1886 I want to test this but haven't used the 'details' feature 
before. In what format am I supposed to send the key/value pairs? If you have a 
CloudMonkey or Marvin example, that would be great. I'll then verify it in my 
lab. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

RE: Remi Bergsma joins the PMC

[Boris Schrijver]

Congrats Remi!

Best regards,

Boris Schrijver

TEL: +31633784542
MAIL: bo...@pcextreme.nl

> 
> On August 10, 2015 at 8:57 PM Somesh Naidu 
> wrote:
> 
> 
> Congratulations Remi!
> 
> Regards,
> Somesh
> 
> 
> -Original Message-
> From: Erik Weber [mailto:terbol...@gmail.com]
> Sent: Monday, August 10, 2015 2:13 PM
> To: dev
> Subject: Re: Remi Bergsma joins the PMC
> 
> On Mon, Aug 10, 2015 at 7:08 PM, Daan Hoogland 
> wrote:
> 
> > LS,
> >
> > Today the PMC has invited Remi Bergsma to join its ranks. I am happy to
> > say
> > that he accepted. Please join me in congratulating Remi.
> >
> >
> Congratulations Remi :-)
> 
> --
> Erik
> 

Re: Remi Bergsma joins the PMC

[Ian Rae]

Fantastic, well deserved Remi!

On Mon, Aug 10, 2015 at 4:10 PM, Boris Schrijver  wrote:

> Congrats Remi!
>
> Best regards,
>
> Boris Schrijver
>
> TEL: +31633784542
> MAIL: bo...@pcextreme.nl
>
> >
> > On August 10, 2015 at 8:57 PM Somesh Naidu 
> > wrote:
> >
> >
> > Congratulations Remi!
> >
> > Regards,
> > Somesh
> >
> >
> > -Original Message-
> > From: Erik Weber [mailto:terbol...@gmail.com]
> > Sent: Monday, August 10, 2015 2:13 PM
> > To: dev
> > Subject: Re: Remi Bergsma joins the PMC
> >
> > On Mon, Aug 10, 2015 at 7:08 PM, Daan Hoogland <
> daan.hoogl...@gmail.com>
> > wrote:
> >
> > > LS,
> > >
> > > Today the PMC has invited Remi Bergsma to join its ranks. I am
> happy to
> > > say
> > > that he accepted. Please join me in congratulating Remi.
> > >
> > >
> > Congratulations Remi :-)
> >
> > --
> > Erik
> >
>



-- 
Ian Rae
CEO | PDG
c: 514.944.4008

CloudOps | Cloud Infrastructure and Networking Solutions
www.cloudops.com | 420 rue Guy | Montreal | Canada | H3J 1S6

Re: Ec2stack not working with current aws cli

[Carlos Reátegui]

> 
> Can you make a PR that updates the README with this config option…

Done. 


> 
> thanks
> 
>> On Aug 6, 2015, at 3:07 AM, Carlos Reategui  wrote:
>> 
>> BTW I figured out how to force the cli to send v2.  It would still be nice
>> to update Ec2Stack though:
>> 
>> aws configure set profile..ec2.signature_version v2
>> 
>> 
>> Or for your default profile:
>> 
>> 
>> aws configure set default.ec2.signature_version v2
>> 
>> 
>> The above will update your ~/.aws/config file.
>> 
>> 
>> 
>> 
>> On Wed, Aug 5, 2015 at 5:49 PM, Carlos Reategui  wrote:
>> 
>>> Hi,
>>> I am having trouble with the current aws cli.  Ec2stack is expecting AWS
>>> signature version 2 but the current aws cli uses v4.
>>> 
>>> Do I file a JIRA in under cloudstack?  I did not see an ec2stack component.
>>> 
>>> Here is a wireshark capture:
>>> 
>>> POST / HTTP/1.1
>>> Host: localhost:5000
>>> Accept-Encoding: identity
>>> Content-Length: 40
>>> Content-Type: application/x-www-form-urlencoded
>>> X-Amz-Date: 20150806T002150Z
>>> Authorization: AWS4-HMAC-SHA256
>>> Credential=x/20150806//ec2/aws4_request,
>>> SignedHeaders=host;user-agent;x-amz-date, Signature=xx
>>> User-Agent: aws-cli/1.7.42 Python/2.7.6 Darwin/14.4.0
>>> 
>>> Action=DescribeImages&Version=2015-04-15
>>> 
>>> HTTP/1.0 400 BAD REQUEST
>>> Content-Type: application/xml
>>> Content-Length: 314
>>> Server: Werkzeug/0.10.4 Python/2.7.3
>>> Date: Thu, 06 Aug 2015 00:21:50 GMT
>>> 
>>> 
>>> 
>>> 
>>> 
>>> 
>>>  
>>>  MissingParameter
>>>  The request must contain the parameter
>>> SignatureVersion
>>>  
>>> 
>>> 
>>> 
>>> 
>>>   21ba5526-3bd1-11e5-abbc-d4ae52927e09
>>> 
>>> 
>>> 
> 

[GitHub] cloudstack pull request: getUsedBytes should query the SolidFire c...

[mike-tutkowski]

GitHub user mike-tutkowski opened a pull request:

https://github.com/apache/cloudstack/pull/674

getUsedBytes should query the SolidFire cluster to acquire the size o…

…f the given volume if there is no volume_details info for that volume 
(and then create a volume_details row for this volume so we don't have to make 
that cluster call for this purpose again)



This only impacts the SolidFire storage plug-in.

In supporting back-end snapshots, I re-wrote how the getUsedBytes method 
works (which is called by the capacity manager).

The implementation now depends on a new row in the volume_details table for 
the volume in question that says how large the backend volume that supports 
your virtual disk is (the virtual disk's size is kept track of in the volumes 
table).

Since this addition to the volume_details table is new in 4.6 and these 
kinds of volumes have been created before 4.6, we need to make sure if no 
applicable volume_details row exits for the volume in question that we go 
retrieve the necessary info from the applicable SolidFire cluster and create a 
row in the volume_details table for future reference.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mike-tutkowski/cloudstack sf-related

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/674.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #674


commit 0f2f6f3b7e82f8a24f3fc76e0b52cb94feb0e794
Author: Mike Tutkowski 
Date:   2015-08-06T17:59:30Z

getUsedBytes should query the SolidFire cluster to acquire the size of the 
given volume if there is no volume_details info for that volume (and then 
create a volume_details row for this volume so we don't have to make that 
cluster call for this purpose again)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Anyone able to review PR 674 (it should be quick to do)?

[Mike Tutkowski]

Hi,

I just opened the following PR:

https://github.com/apache/cloudstack/pull/674

This only impacts the SolidFire storage plug-in.

Anyone able to spend a few minutes reviewing it for me?

Thanks!

-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
*™*

Re: Revisit Process for creating Blocker bugs

[Mike Tutkowski]

"3. In case the reporter feels the defect qualifies as a Blocker, they
should raise it as Blocker and create a discussion/voting thread on the ML
for the same."

This is what I always do these days and I think it makes a lot of sense: Go
ahead and mark the bug as a Blocker, but then send out an obvious e-mail
(i.e. well-named Subject) to the list to begin discussion around it.

On Mon, Aug 10, 2015 at 10:24 AM, Somesh Naidu 
wrote:

> > I did not see (or understand) a major change proposed or needed in this
> thread.
>
> The primary topic of discussion is categorization of a defect as Blocker,
> that is, how to qualify a defect as Blocker. The discussion scope widened
> and included process to raise an issue as "Blocker".
>
> The issue/discussion seems to have risen due to some folks (Raja and team)
> raising a blocker without discussion on ML. As a counter measure, these
> defects were downgraded to "Critical" (by Daan).
>
> In terms of qualification for a blocker, the two school of thoughts were,
> Raja/Ram - consideration should be drawn from the technical/functional
> impact irrespective of how many users are affected.
> Daan - consideration should be drawn from how many users are affected
> (achieved by voting).
>
> In terms of the process, two approaches proposed were,
> Raja/Ram - the reporter should first set the priority level to "Blocker"
> and in parallel raise it for discussion on the ML.
> Daan - the reporter should raise such defect as "Critical" and then work
> on promoting it to "Blocker" via lazy consensus.
>
> I am not entirely sure which approach suggests a change.
>
> @Daan/Raja - My sincere apologies in case my summary has inaccuracies;
> please feel free to correct.
>
> My proposal was (matches with mostly what Sebastian said),
> 1. Create a wiki page with more detailed guidelines and processes for
> Release Blockers.
> 2. The reporter should raise a defect by qualifying against the above
> guidelines.
> 3. In case the reporter feels the defect qualifies as a Blocker, they
> should raise it as Blocker and create a discussion/voting thread on the ML
> for the same.
> 4. RM should ensure an explicit decision is made on the severity and
> upgrade/downgrade accordingly. Note, RM having the responsibility and
> authority to drive closure does not equate to veto power.
>
> Regards,
> Somesh
>
>
> -Original Message-
> From: Sebastien Goasguen [mailto:run...@gmail.com]
> Sent: Monday, August 10, 2015 4:23 AM
> To: dev@cloudstack.apache.org
> Subject: Re: Revisit Process for creating Blocker bugs
>
>
> > On Aug 6, 2015, at 7:35 AM, Raja Pullela 
> wrote:
> >
> > Looks like there are few of us who differ with the current
> process/restriction.
> > Just to close this thread - there are already guidelines that exist
> currently and we should continue to adopt or follow those.Let the
> Release Manager or other people closely involved with a particular release
> decide on whether a particular bug is correctly categorized or not.  They
> should have the veto power to downgrade or upgrade, as necessary.
> >
>
> I would not call it veto power.
>
> Folks will file tickets and put a priority level, a RM will see blockers
> and when those are not resolved, the RM should go on the list and get a
> feel from the community about those blockers (whether they are or not).
>
> I did not see (or understand) a major change proposed or needed in this
> thread.
>
>
> > Assess Priority -
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=30746287
> > When creating a new Jira ticket, please take a minute to correctly
> assess the priority of the issue. By default, Jira assigns a new issue a
> Priority level of Major. In many cases, this is wrong. Please be sure to
> set the Priority correctly:
> > Blocker: Blocks development and/or testing work, production cannot run.
> Security issues.
> > Critical: Crashes, loss of data, severe memory leak.
> > Major: Major loss of function, broken feature, returns incorrect
> information, etc.
> > Minor: Minor loss of function, problem with an easy workaround. Wishlist
> items.
> > Trivial: Typos that don't affect comprehension of the UI, misaligned
> text, etc.
> >
> > -Original Message-
> > From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
> > Sent: Wednesday, August 5, 2015 2:19 PM
> > To: dev 
> > Subject: Re: Revisit Process for creating Blocker bugs
> >
> > Koushik, that would be true if we had our upgrade process in order.
> >
> > On Wed, Aug 5, 2015 at 7:14 AM, Koushik Das 
> wrote:
> >
> >> If there is a group of users in dire need for a specific feature they
> >> can always take the code and use it. No need to wait for an official
> release.
> >> Official release should adhere to quality guidelines (at least in
> >> terms of any reported regressions) even if it means release getting
> delayed.
> >>
> >>
> >> On 05-Aug-2015, at 2:39 AM, Daan Hoogland 
> wrote:
> >>
> >>> Yes we can if there is a group of users that don't use it but 

[GitHub] cloudstack pull request: CLOUDSTACK-8601. VMFS storage added as lo...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/547


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Anyone wants to take over these orphaned PRs?

[Mike Tutkowski]

I went ahead and tested, then checked in PR 547:

https://github.com/apache/cloudstack/pull/547/files

I also resolved and closed the JIRA ticket for it:

https://issues.apache.org/jira/browse/CLOUDSTACK-8601

On Mon, Aug 10, 2015 at 11:43 AM, Mike Tutkowski <
mike.tutkow...@solidfire.com> wrote:

> I should be able to test it.
>
> Talk to you soon,
> Mike
>
> On Sun, Aug 9, 2015 at 10:40 PM, Remi Bergsma  > wrote:
>
>> Hi Mike,
>>
>> Thanks! It seems the testing / verification is still to do and that is
>> the work. Merging itself can be done with a one-liner.
>>
>> Are you able to verify the fix in your lab?
>>
>> Sent from my iPhone
>>
>> > On 10 Aug 2015, at 04:13, Mike Tutkowski 
>> wrote:
>> >
>> > I could take this one:
>> >
>> > CLOUDSTACK-8601. VMFS storage added as local storage can be re-added ...
>> > #547
>> > https://github.com/apache/cloudstack/pull/547
>> > ==> 1x LGTM
>> >
>> > I asked this in the PR discussion, but are we under the impression that
>> > this code has been tested well enough? If so, I can just merge it as the
>> > code itself LGTM.
>> >
>> > On Sun, Aug 9, 2015 at 12:49 PM, Remi Bergsma <
>> rberg...@schubergphilis.com>
>> > wrote:
>> >
>> >> Hi all,
>> >>
>> >> These are 9 PRs sent by Likitha. If I understand correctly Likitha is
>> no
>> >> longer working with Citrix/ACS. The PRs seem mostly VMware related.
>> Some
>> >> have LGTM(s), most have comments about missing unit tests.
>> >>
>> >> What do we want to do with them? There's probably not gonna be an
>> update
>> >> from Likitha, so waiting for that does not make sense. Does anyone
>> wants to
>> >> step in and finalize a PR? You can get the PR to your own branch and
>> add
>> >> some work on top of the existing commits and finally send it as a new
>> PR.
>> >>
>> >> I'll add a comment to each of them. If no one wants to take it over, I
>> >> think we should close the PRs without merging. It's a pity, but I would
>> >> rather not have long lists of orphaned PRs laying around. The less PRs
>> are
>> >> open, the better.
>> >>
>> >> Any comments?
>> >>
>> >> Regards,
>> >> Remi
>> >>
>> >> Cloudstack 8612 [VMware] #562
>> >> https://github.com/apache/cloudstack/pull/562
>> >>
>> >> CLOUDSTACK-8611. CS waits indefinitely for
>> CheckS2SVpnConnectionsComm...
>> >> #561
>> >> https://github.com/apache/cloudstack/pull/561
>> >>
>> >> CLOUDSTACK-8609. [VMware] VM is not accessible after a migration
>> acro...
>> >> #556
>> >> https://github.com/apache/cloudstack/pull/556
>> >>
>> >> CLOUDSTACK-8608. [VMware] System VM's failed to start due to
>> permissions
>> >> issue. #555
>> >> https://github.com/apache/cloudstack/pull/555
>> >>
>> >> CLOUDSTACK-8610. Unable to attach 7th Disk to Windows Server 2012 R2
>> ...
>> >> #554
>> >> https://github.com/apache/cloudstack/pull/554
>> >> ==> This one has 2xLGTM, but also some remarks to add unit tests.
>> >>
>> >> CLOUDSTACK-8602. MigrateVirtualMachineWithVolume leaves old chain
>> dat...
>> >> #548
>> >> https://github.com/apache/cloudstack/pull/548
>> >> ==> 1x LGTM
>> >>
>> >> CLOUDSTACK-8601. VMFS storage added as local storage can be re-added
>> ...
>> >> #547
>> >> https://github.com/apache/cloudstack/pull/547
>> >> ==> 1x LGTM
>> >>
>> >> CLOUDSTACK-8599. CS reports failure for a successful migration. #544
>> >> https://github.com/apache/cloudstack/pull/544
>> >>
>> >> CLOUDSTACK-8415. SSVM shutdown during snapshot operation leaves
>> behin...
>> >> #540
>> >> https://github.com/apache/cloudstack/pull/540
>> >
>> >
>> > --
>> > *Mike Tutkowski*
>> > *Senior CloudStack Developer, SolidFire Inc.*
>> > e: mike.tutkow...@solidfire.com
>> > o: 303.746.7302
>> > Advancing the way the world uses the cloud
>> > *™*
>>
>
>
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the cloud
> *™*
>



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
*™*

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

[sedukull]

Github user sedukull commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/669#discussion_r36704745
  
--- Diff: server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java ---
@@ -1425,19 +1423,39 @@ public boolean finalizeCommandsOnStart(Commands 
cmds, VirtualMachineProfile prof
 CheckSshCommand check = new 
CheckSshCommand(profile.getInstanceName(), controlNic.getIp4Address(), 3922);
 cmds.addCommand("checkSsh", check);
 
+try {
+File uiFiles = new File("systemvm/js");
+if (!uiFiles.exists()) {
+uiFiles = new 
File("/usr/share/cloudstack-common/systemvm/js");
+}
+if (uiFiles.exists() && uiFiles.isDirectory()) {
+CopyFileInVmCommand copyFile = new 
CopyFileInVmCommand(uiFiles.getCanonicalPath(), "/usr/local/cloud/systemvm/js", 
controlNic.getIp4Address());
+cmds.addCommand("copyFile", copyFile);
+} else {
+s_logger.error("Couldn't locate localization files for 
console proxy");
+return false;
+}
+} catch (IOException e) {
+s_logger.error("Failed to copy localization files for console 
proxy: " + e.getMessage());
--- End diff --

My note is related to catch block, once an io exception is caught, do we 
want to return false to callee ( inside the catch block)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

[sedukull]

Github user sedukull commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/669#discussion_r36705033
  
--- Diff: systemvm/js/ajaxviewer.js ---
@@ -184,7 +205,7 @@ KeyboardMapper.prototype = {
if(eventType == AjaxViewer.KEY_UP && (code == 
AjaxViewer.JS_KEY_ALT || code == AjaxViewer.JS_KEY_CTRL))
this.mappedInput.push({type : eventType, code: 
this.jsX11KeysymMap[code], modifiers: modifiers});

-   } else if(eventType == AjaxViewer.KEY_PRESS && guestos == 
'null') {
+   } else if(eventType == AjaxViewer.KEY_PRESS && 
guestos.toLowerCase() != 'windows') {
--- End diff --

This might be existing code, but for more cleaner way, do we want to remote 
all os strings and make them as constants or sort of enums defined at one place 
and use them with reference here? 
something like:
gustos.toLowerCase() != OsTypes.WINDOWS


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

[sedukull]

Github user sedukull commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/669#discussion_r36705202
  
--- Diff: 
plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java
 ---
@@ -595,6 +597,25 @@ private PlugNicAnswer execute(PlugNicCommand cmd) {
 }
 }
 
+private CopyFileInVmAnswer execute(CopyFileInVmCommand cmd) {
+File keyFile = getSystemVMKeyFile();
+try {
+File file = new File(cmd.getSrc());
+if(file.exists()) {
+if(file.isDirectory()) {
+for (File f : FileUtils.listFiles(new 
File(cmd.getSrc()), TrueFileFilter.INSTANCE, TrueFileFilter.INSTANCE)) {
+SshHelper.scpTo(cmd.getVmIp(), 3922, "root", 
keyFile, null, cmd.getDest(), f.getCanonicalPath(), null);
+}
+} else {
+SshHelper.scpTo(cmd.getVmIp(), 3922, "root", keyFile, 
null, cmd.getDest(), file.getCanonicalPath(), null);
+}
+}
+} catch (Exception e) {
+s_logger.error("Fail to copy file " + cmd.getSrc() + " in VM " 
+ cmd.getVmIp(), e);
+return new CopyFileInVmAnswer(cmd, e);
+}
+return new CopyFileInVmAnswer(cmd);
--- End diff --

Its not a big issue as such, but iam seeing like if there is an exception 
at liine 617:  "return new CopyFileIn.. (cmd)", then catch will still throw 
your new object created. Again, its not a great issue to be worry about!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

[sedukull]

Github user sedukull commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/669#discussion_r36705320
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCopyFileInVmCommandWrapper.java
 ---
@@ -0,0 +1,59 @@
+/*
+ *   Licensed to the Apache Software Foundation (ASF) under one
+ *   or more contributor license agreements.  See the NOTICE file
+ *   distributed with this work for additional information
+ *   regarding copyright ownership.  The ASF licenses this file
+ *   to you under the Apache License, Version 2.0 (the
+ *   "License"); you may not use this file except in compliance
+ *   with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *   Unless required by applicable law or agreed to in writing,
+ *   software distributed under the License is distributed on an
+ *   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ *   KIND, either express or implied.  See the License for the
+ *   specific language governing permissions and limitations
+ *   under the License.
+ */
+
+package com.cloud.hypervisor.kvm.resource.wrapper;
+
+import com.cloud.agent.api.Answer;
+import com.cloud.agent.api.CopyFileInVmAnswer;
+import com.cloud.agent.api.CopyFileInVmCommand;
+import com.cloud.hypervisor.kvm.resource.LibvirtComputingResource;
+import com.cloud.resource.CommandWrapper;
+import com.cloud.resource.ResourceWrapper;
+import com.cloud.utils.ssh.SshHelper;
+import org.apache.commons.io.FileUtils;
+import org.apache.commons.io.filefilter.TrueFileFilter;
+import org.apache.log4j.Logger;
+
+import java.io.File;
+
+@ResourceWrapper(handles = CopyFileInVmCommand.class)
+public class LibvirtCopyFileInVmCommandWrapper   extends 
CommandWrapper {
+
+private static final Logger s_logger = 
Logger.getLogger(LibvirtCopyFileInVmCommandWrapper.class);
+
+@Override public Answer execute(CopyFileInVmCommand cmd, 
LibvirtComputingResource libvirtComputingResource) {
+final File keyFile = new File("/root/.ssh/id_rsa.cloud");
+try {
+File file = new File(cmd.getSrc());
--- End diff --

I mean the below code is used across few code files in same form or some 
modified form, thats where i made a note, to avoid duplication. If its possible 
to make one common definition and use across.
File file = new File(cmd.getSrc());
+if(file.exists()) {
+if(file.isDirectory()) {
+for(File f : FileUtils.listFiles(file, 
TrueFileFilter.INSTANCE, TrueFileFilter.INSTANCE)) {
+ExecutionResult result = 
citrixResourceBase.copyFileInVm(cmd.getVmIp(), f, cmd.getDest());
+if(!result.isSuccess()) {
+return new CopyFileInVmAnswer(cmd, 
result.getDetails());
+}
+}
+} else {
+ExecutionResult result = 
citrixResourceBase.copyFileInVm(cmd.getVmIp(), file, cmd.getDest());


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

[sedukull]

Github user sedukull commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/669#discussion_r36705867
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCopyFileInVmCommandWrapper.java
 ---
@@ -0,0 +1,59 @@
+/*
+ *   Licensed to the Apache Software Foundation (ASF) under one
+ *   or more contributor license agreements.  See the NOTICE file
+ *   distributed with this work for additional information
+ *   regarding copyright ownership.  The ASF licenses this file
+ *   to you under the Apache License, Version 2.0 (the
+ *   "License"); you may not use this file except in compliance
+ *   with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *   Unless required by applicable law or agreed to in writing,
+ *   software distributed under the License is distributed on an
+ *   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ *   KIND, either express or implied.  See the License for the
+ *   specific language governing permissions and limitations
+ *   under the License.
+ */
+
+package com.cloud.hypervisor.kvm.resource.wrapper;
+
+import com.cloud.agent.api.Answer;
+import com.cloud.agent.api.CopyFileInVmAnswer;
+import com.cloud.agent.api.CopyFileInVmCommand;
+import com.cloud.hypervisor.kvm.resource.LibvirtComputingResource;
+import com.cloud.resource.CommandWrapper;
+import com.cloud.resource.ResourceWrapper;
+import com.cloud.utils.ssh.SshHelper;
+import org.apache.commons.io.FileUtils;
+import org.apache.commons.io.filefilter.TrueFileFilter;
+import org.apache.log4j.Logger;
+
+import java.io.File;
+
+@ResourceWrapper(handles = CopyFileInVmCommand.class)
+public class LibvirtCopyFileInVmCommandWrapper   extends 
CommandWrapper {
+
+private static final Logger s_logger = 
Logger.getLogger(LibvirtCopyFileInVmCommandWrapper.class);
+
+@Override public Answer execute(CopyFileInVmCommand cmd, 
LibvirtComputingResource libvirtComputingResource) {
+final File keyFile = new File("/root/.ssh/id_rsa.cloud");
+try {
+File file = new File(cmd.getSrc());
+if(file.exists()) {
+if(file.isDirectory()) {
+for (File f : FileUtils.listFiles(new 
File(cmd.getSrc()), TrueFileFilter.INSTANCE, TrueFileFilter.INSTANCE)) {
+SshHelper.scpTo(cmd.getVmIp(), 3922, "root", 
keyFile, null, cmd.getDest(), f.getCanonicalPath(), null);
+}
+} else {
--- End diff --

My note was related to the below example.
example_dir_for_iteration contains say 5 entries as follows (dira, 
text_file_a,socket_file_a,block_device_file_a,zip_file_a), in else block of the 
code, we are copying all files. Now, in your case where you explicitly 
mentioned key file path(/root/..) these file types may not be possible,  but 
these type  of copying without file types checks, leads to vulnerabilities in 
the application long run. So, i mentioned to see we are copying files as 
mentioned in else block, do we want to add some file type check that we are 
interesting in copying, for that i gave an example where directory contains 
multiple file types.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---