Re: [DISCUSS][PROPOSAL] CloudStack Upgrade Policy

[Daan Hoogland]

John,

You wrote this here and on users and I think it is a good proposal.
There is one technical catch and I don't think it is worth bothering
users@ with: our current db installation scheme starts with a 4.0.0
database and performs all upgrade steps from that point onward. This
can be solved in the policy or we can start working on maintaining the
scheme if we drop older upgrade scripts as well.

+1


On Tue, Jul 21, 2015 at 7:09 AM, John Burwell
 wrote:
> All,
>
> A recently proposed change [1] to remove older upgrade code has prompted a 
> wider discussion regarding the policy we should employ regarding upgrade 
> support.  Currently, we have no policy regarding how far back the process 
> will function.  As the system evolves, it is simply unsustainable to expect a 
> deliver a reliable upgrade from releases that are many years old (e.g. 3.x to 
> the latest 4.x). Currently, we do not verify that all upgrade paths work for 
> each release.
>
> My straw-man proposal is that effective with the 4.6 release, we only support 
> upgrades from two minor releases back of release with revisions inclusive.  
> For example, upgrades to 4.6.x would be supported from 4.4.x and 4.5.x.  The 
> upgrade process from releases prior to 4.4.0 would require a two step process 
> — upgrade to the latest version 4.5 release and then upgrade from the latest 
> 4.5 release to the latest 4.6 release.  This approach provides backwards 
> compatibility while establishing an upgrade process that is reasonably 
> testable.
>
> In my opinion, any upgrade policy should satisfy two criteria — support the 
> operational processes of the majority and be verifiable through automated 
> testing.
>
> Thanks,
> -John
>
> [1]: https://github.com/apache/cloudstack/pull/608
>
> ---
> John Burwell (@john_burwell)
> VP of Software Engineering, ShapeBlue
> (571) 403-2411 | +44 20 3603 0542
> http://www.shapeblue.com
> Please join us at CloudStack Collab EU — 
> http://events.linuxfoundation.org/events/cloudstack-collaboration-conference-europe
>
>
>
>
> Find out more about ShapeBlue and our range of CloudStack related services
>
> IaaS Cloud Design & Build
> CSForge – rapid IaaS deployment framework
> CloudStack Consulting
> CloudStack Software 
> Engineering
> CloudStack Infrastructure 
> Support
> CloudStack Bootcamp Training 
> Courses
>
> This email and any attachments to it may be confidential and are intended 
> solely for the use of the individual to whom it is addressed. Any views or 
> opinions expressed are solely those of the author and do not necessarily 
> represent those of Shape Blue Ltd or related companies. If you are not the 
> intended recipient of this email, you must neither take any action based upon 
> its contents, nor copy or show it to anyone. Please contact the sender if you 
> believe you have received this email in error. Shape Blue Ltd is a company 
> incorporated in England & Wales. ShapeBlue Services India LLP is a company 
> incorporated in India and is operated under license from Shape Blue Ltd. 
> Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
> operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company 
> registered by The Republic of South Africa and is traded under license from 
> Shape Blue Ltd. ShapeBlue is a registered trademark.



-- 
Daan

[GitHub] cloudstack pull request: CLOUDSTACK-8655: [Browser Based Upload Vo...

[koushik-das]

GitHub user koushik-das opened a pull request:

https://github.com/apache/cloudstack/pull/611

CLOUDSTACK-8655: [Browser Based Upload Volume] Partially uploaded vol…

…umes are not getting destroyed as part of storage GC

As part of volume sync, that runs during of SSVM start-up, the 
volume_store_ref entry was getting deleted. Volume GC relies on this entry to 
move volume to destroyed state.
Since the entry was getting deleted, GC thread never moved the volume from 
UploadError/UploadAbandoned to Destroyed. Fix is to not remove the 
volume_store_ref entry as part
of volume sync and let GC thread handle the clean up.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/koushik-das/cloudstack CLOUDSTACK-8655

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/611.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #611


commit b3e0099e0a0ea9b22a350320f56a8421823fedc1
Author: Koushik Das 
Date:   2015-07-21T08:58:38Z

CLOUDSTACK-8655: [Browser Based Upload Volume] Partially uploaded volumes 
are not getting destroyed as part of storage GC
As part of volume sync, that runs during of SSVM start-up, the 
volume_store_ref entry was getting deleted. Volume GC relies on this entry to 
move volume to destroyed state.
Since the entry was getting deleted, GC thread never moved the volume from 
UploadError/UploadAbandoned to Destroyed. Fix is to not remove the 
volume_store_ref entry as part
of volume sync and let GC thread handle the clean up.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8655: [Browser Based Upload Vo...

[koushik-das]

Github user koushik-das commented on the pull request:

https://github.com/apache/cloudstack/pull/611#issuecomment-123227873
  
Test browser based incomplete volume upload, followed by SSVM destroy. 
Volume should go to UploadAbandoned/Error state and get cleaned up. ... === 
TestName: test_browser_upload_volume_incomplete | Status : SUCCESS ===
ok

--
Ran 1 test in 351.347s

OK



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-7539: coverity regression dead...

[koushik-das]

Github user koushik-das commented on the pull request:

https://github.com/apache/cloudstack/pull/610#issuecomment-123232196
  
Changes look good. Not sure what "dead local store" mean.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-7539: coverity regression dead...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/610#issuecomment-123252820
  
@koushik-das 'dead local storage' is a source analysis term for 'unused 
variable'. Not severe unless it happens a lot, because of memory consumption.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

CloudStack UI Plugins section not showing

[Hopkins, Michael]

Hi,
I’m trying to write a 3rd party UI plugin for cloudstack for a university 
project, unfortunately I can’t seem to get the “plugins” section of the UI to 
display.

In usr/share/cloudstack-management/webapps/client/plugins

I have two test plugins “testPlugin” and “csMyFirstPlugin” which are folders 
containing all the relevant files as per the tutorial provided in the 
documentation.

In plugins.js I have registered them as per the instructions in the tutorial. 

It seems that in /scripts/cloudStack.js the plugins section is hidden if 
cloudstack.plugins.length is 0. 

I thought that registering the plugins in plugins.js would suffice to make the 
section visible but is there another step? I can’t find any answers online.

Thanks, Michael

Re: CloudStack UI Plugins section not showing

[Rohit Yadav]

Define and include your plugin in the top plugins.js file, also remove any 
.js.gz file. Which CloudStack branch are you working against? Make sure to 
define correct names and use something like firebug or chrome dev-tools to see 
if require.js is missing to load any plugin asset (like js, css, image files).

I’m currently working on a UI plugin, if this gives you any hints:
https://github.com/shapeblue/cloudstack/tree/quota/ui/plugins

On 21-Jul-2015, at 4:05 pm, Hopkins, Michael 
mailto:michael.hopkin...@imperial.ac.uk>> 
wrote:

Hi,
I’m trying to write a 3rd party UI plugin for cloudstack for a university 
project, unfortunately I can’t seem to get the “plugins” section of the UI to 
display.

In usr/share/cloudstack-management/webapps/client/plugins

I have two test plugins “testPlugin” and “csMyFirstPlugin” which are folders 
containing all the relevant files as per the tutorial provided in the 
documentation.

In plugins.js I have registered them as per the instructions in the tutorial.

It seems that in /scripts/cloudStack.js the plugins section is hidden if 
cloudstack.plugins.length is 0.

I thought that registering the plugins in plugins.js would suffice to make the 
section visible but is there another step? I can’t find any answers online.

Thanks, Michael

Regards,
Rohit Yadav
Software Architect, ShapeBlue


[cid:9DD97B41-04C5-45F0-92A7-951F3E962F7A]


M. +91 88 262 30892 | 
rohit.ya...@shapeblue.com
Blog: bhaisaab.org | Twitter: @_bhaisaab




Find out more about ShapeBlue and our range of CloudStack related services

IaaS Cloud Design & Build
CSForge – rapid IaaS deployment framework
CloudStack Consulting
CloudStack Software 
Engineering
CloudStack Infrastructure 
Support
CloudStack Bootcamp Training Courses

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England & Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company 
registered by The Republic of South Africa and is traded under license from 
Shape Blue Ltd. ShapeBlue is a registered trademark.

[GitHub] cloudstack pull request: CLOUDSTACK-7539: coverity regression dead...

[koushik-das]

Github user koushik-das commented on the pull request:

https://github.com/apache/cloudstack/pull/610#issuecomment-123272585
  
@DaanHoogland Thanks for the information.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8648: Do not configure the Ima...

[karuturi]

Github user karuturi commented on the pull request:

https://github.com/apache/cloudstack/pull/606#issuecomment-123278333
  
while I agree with the code change based on the current implementations of 
getVirtualSize, should we just pass the storage layer in the params so that any 
new implementation if required can use the storage layer?
```
Map params = new HashMap();
params.put(StorageLayer.InstanceConfigKey, _storage);
processor.configure("template processor", new HashMap());
```



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8658: make initializer static ...

[DaanHoogland]

GitHub user DaanHoogland opened a pull request:

https://github.com/apache/cloudstack/pull/612

CLOUDSTACK-8658: make initializer static instead of default

bad bug: ommision of the static keyword on initializer leaves data 
uninitialized :{

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/DaanHoogland/cloudstack CLOUDSTACK-8658

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/612.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #612


commit 3394dc0c21e8c2176f43552092e590153d7850b8
Author: Daan Hoogland 
Date:   2015-07-21T15:42:41Z

CLOUDSTACK-8658: make initializer static instead of default




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8648: Do not configure the Ima...

[wido]

Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/606#issuecomment-123381112
  
Shouldn't we then pass "params" to the configure method? That seems to be 
missing in your example.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

RE: [PROPOSAL] drop old upgrade code

[Kishan Kavala]

-1 on dropping old upgrade code.

I prefer skipping old upgrade paths during coverity scan instead of removing 
the code altogether.
Even with multi-step upgrade, user will be forced to register system templates 
multiple times (once for every step).  
Agree with John regarding the need to establish a standard upgrade policy.

-Original Message-
From: John Burwell [mailto:john.burw...@shapeblue.com] 
Sent: 20 July 2015 09:41 PM
To: dev@cloudstack.apache.org
Subject: Re: [PROPOSAL] drop old upgrade code

Daan,

While I see the desire to remove outstanding scan issues, doing it at the 
expense of a feature required by users is not acceptable to me.  My first 
question is how many users are still running pre-4.x versions?  In its current 
state, the commit message lacks an explanation of the reasoning for the change, 
and there is no documentation about the change.  Until these basic bits of 
documentation are addressed, and we have a good feel for the user impact, I am 
-1 on this change.

With this change, I think we should also establish a standard upgrade support 
policy (e.g. current minor release - x revisions).  If a user falls far enough 
behind, they would be require to execute a multi-step upgrade in order to 
upgrade to latest.  Whatever we decide, it should be clearly documented, and 
discussed on dev@ and user@.

I am happy to pose these questions on user@ to get a feel for the potential 
impact of this change and input on the desired upgrade policy.

Thanks,
-John

---
John Burwell (@john_burwell)
VP of Software Engineering, ShapeBlue
(571) 403-2411 | +44 20 3603 0542
http://www.shapeblue.com
Please join us at CloudStack Collab EU — 
http://events.linuxfoundation.org/events/cloudstack-collaboration-conference-europe




> On Jul 20, 2015, at 10:27 AM, Daan Hoogland  wrote:
>
> in anticipation of loads of +1's I made a new PR (at [2])
>
> On Mon, Jul 20, 2015 at 2:29 PM, Wido den Hollander  wrote:
>>
>>
>> On 20-07-15 13:48, Daan Hoogland wrote:
>>> LS,
>>>
>>> In coverity the only remaining high impact issues are concerned with 
>>> upgrade code. Some of it is in 4.3 and 4.5 code but most in pre-4 
>>> upgrades.
>>>
>>> I addressed the file Upgrade218to22.java in a PR [1] and I move that 
>>> we don't pull it but instead drop the file altogether together with 
>>> all upgrade code dating prior to 4.0.0. anybody on older versions 
>>> can still upgrade to any version between 4.0 and 4.5 and move on 
>>> from there.
>>>
>>> My objective is to have no high impact issues remaining so we 
>>> clearly see when we are digressing beit by hand or in  an automated way.
>>>
>>> +1?
>>>
>>
>> +1 I don't see a reason to keep supporting these ancient upgrade paths.
>>
>> Wido
>>
>>> [1] https://github.com/apache/cloudstack/pull/603
>
> [2] https://github.com/apache/cloudstack/pull/608
>
>
> --
> Daan

Find out more about ShapeBlue and our range of CloudStack related services

IaaS Cloud Design & Build
CSForge – rapid IaaS deployment framework
CloudStack Consulting
CloudStack Software 
Engineering
CloudStack Infrastructure 
Support
CloudStack Bootcamp Training Courses

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England & Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company 
registered by The Republic of South Africa and is traded under license from 
Shape Blue Ltd. ShapeBlue is a registered trademark.

RE: [PROPOSAL] drop old upgrade code

[Somesh Naidu]

+1

Reasons:
1. Technically speaking, Apache Cloudstack never had version less than 4.0. But 
even if they are considered they would be EOL'd at some point.
2. At some point the feature set disparity between version will make it really 
complex to have direct upgrade paths.
3. As Daan mentioned, 2.x and 3.x users can still upgrade to 4.6+ using a 
multi-step approach (upgrading to 4.3/4.5 first).

Regards,
Somesh

-Original Message-
From: Erik Weber [mailto:terbol...@gmail.com] 
Sent: Monday, July 20, 2015 2:30 PM
To: dev@cloudstack.apache.org
Subject: Re: [PROPOSAL] drop old upgrade code

As a user, I'd say +1.

I understand the concerns, but as long as there is a workaround I'm fine
with it.

Would be great though if the upgrade scripts abort if it notices an upgrade
from an unsupported versions.

Erik


Den mandag 20. juli 2015 skrev Daan Hoogland 
følgende:

> LS,
>
> In coverity the only remaining high impact issues are concerned with
> upgrade code. Some of it is in 4.3 and 4.5 code but most in pre-4
> upgrades.
>
> I addressed the file Upgrade218to22.java in a PR [1] and I move that
> we don't pull it but instead drop the file altogether together with
> all upgrade code dating prior to 4.0.0. anybody on older versions can
> still upgrade to any version between 4.0 and 4.5 and move on from
> there.
>
> My objective is to have no high impact issues remaining so we clearly
> see when we are digressing beit by hand or in  an automated way.
>
> +1?
>
> [1] https://github.com/apache/cloudstack/pull/603
> --
> Daan
>

[GitHub] cloudstack pull request: CLOUDSTACK-8658: make initializer static ...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/612#issuecomment-123387872
  
Hey @DaanHoogland 

Could you write a test for that, please? :)

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

RE: CloudStack UI Plugins section not showing

[Hopkins, Michael]

Thanks very much Rohit,
The plugins section is now displaying, I believe because I removed 
plugins.js.gz. I'm using Cloudstack version 4.5.1
Michael

From: Rohit Yadav [rohit.ya...@shapeblue.com]
Sent: Tuesday, July 21, 2015 12:00 PM
To: dev@cloudstack.apache.org
Subject: Re: CloudStack UI Plugins section not showing

Define and include your plugin in the top plugins.js file, also remove any 
.js.gz file. Which CloudStack branch are you working against? Make sure to 
define correct names and use something like firebug or chrome dev-tools to see 
if require.js is missing to load any plugin asset (like js, css, image files).

I’m currently working on a UI plugin, if this gives you any hints:
https://github.com/shapeblue/cloudstack/tree/quota/ui/plugins

On 21-Jul-2015, at 4:05 pm, Hopkins, Michael 
mailto:michael.hopkin...@imperial.ac.uk>> 
wrote:

Hi,
I’m trying to write a 3rd party UI plugin for cloudstack for a university 
project, unfortunately I can’t seem to get the “plugins” section of the UI to 
display.

In usr/share/cloudstack-management/webapps/client/plugins

I have two test plugins “testPlugin” and “csMyFirstPlugin” which are folders 
containing all the relevant files as per the tutorial provided in the 
documentation.

In plugins.js I have registered them as per the instructions in the tutorial.

It seems that in /scripts/cloudStack.js the plugins section is hidden if 
cloudstack.plugins.length is 0.

I thought that registering the plugins in plugins.js would suffice to make the 
section visible but is there another step? I can’t find any answers online.

Thanks, Michael

Regards,
Rohit Yadav
Software Architect, ShapeBlue




M. +91 88 262 30892 | 
rohit.ya...@shapeblue.com
Blog: bhaisaab.org | Twitter: @_bhaisaab




Find out more about ShapeBlue and our range of CloudStack related services

IaaS Cloud Design & Build
CSForge – rapid IaaS deployment framework
CloudStack Consulting
CloudStack Software 
Engineering
CloudStack Infrastructure 
Support
CloudStack Bootcamp Training Courses

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England & Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company 
registered by The Republic of South Africa and is traded under license from 
Shape Blue Ltd. ShapeBlue is a registered trademark.

[GitHub] cloudstack pull request: CLOUDSTACK-8658: make initializer static ...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/612#issuecomment-123460301
  
@wilderrodrigues of course, sure you want to wait for that?
And to what extend? we want tests for this initializer but also for the 
agent and it's functioning


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8658: make initializer static ...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/612#issuecomment-123471733
  
Hey @DaanHoogland 

Just the initialiser stuff and the return of the getPreferredCharset() 
method.

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8658: make initializer static ...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/612#issuecomment-123526216
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8655: [Browser Based Upload Vo...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/611#issuecomment-123526321
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8650: Fix securitygroups ingre...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/601#issuecomment-123526526
  
LGTM, though I've not tested this with a real host


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8648: Do not configure the Ima...

[karuturi]

Github user karuturi commented on the pull request:

https://github.com/apache/cloudstack/pull/606#issuecomment-123554934
  
yes. copy paste error :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Review Request for PR 609

[Rajani Karuturi]

Can someone please review PR 609? Its an enhancement to LDAP import users
functionality

https://github.com/apache/cloudstack/pull/609

Thanks,
~Rajani

[GitHub] cloudstack pull request: BUG-ID: CLOUDSTACK-8483 - Private templat...

[karuturi]

Github user karuturi commented on the pull request:

https://github.com/apache/cloudstack/pull/334#issuecomment-123562895
  
@sudhansu7 can you please rebase the changes for master?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8596 ability to query nested g...

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/609#discussion_r35181750
  
--- Diff: 
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapConfiguration.java
 ---
@@ -43,14 +45,14 @@
 private ConfigurationDao _configDao;
 
 @Inject
-private LdapManager _ldapManager;
+private LdapConfigurationDao _ldapConfigurationDao;
 
 public LdapConfiguration() {
 }
 
-public LdapConfiguration(final ConfigurationDao configDao, final 
LdapManager ldapManager) {
+public LdapConfiguration(final ConfigurationDao configDao, final 
LdapConfigurationDao ldapConfigurationDao) {
 _configDao = configDao;
-_ldapManager = ldapManager;
+_ldapConfigurationDao = ldapConfigurationDao;
--- End diff --

Why inject and pass on in the constructor. Do both have usage scenarios?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8596 ability to query nested g...

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/609#discussion_r35181833
  
--- Diff: 
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
 ---
@@ -57,17 +57,22 @@
 private LdapContextFactory _ldapContextFactory;
 
 @Inject
-private LdapUserManager _ldapUserManager;
+private LdapConfiguration _ldapConfiguration;
+
+@Inject LdapUserManagerFactory _ldapUserManagerFactory;
+
 
 public LdapManagerImpl() {
 super();
 }
 
-public LdapManagerImpl(final LdapConfigurationDao 
ldapConfigurationDao, final LdapContextFactory ldapContextFactory, final 
LdapUserManager ldapUserManager) {
+public LdapManagerImpl(final LdapConfigurationDao 
ldapConfigurationDao, final LdapContextFactory ldapContextFactory, final 
LdapUserManagerFactory ldapUserManagerFactory,
+   final LdapConfiguration ldapConfiguration) {
--- End diff --

why inject and pass into constructor? is the ldap-provider-selector going 
to change on runtime?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request for PR 609

[Daan Hoogland]

Lot of work Rajani, I don't understand the spec files in groovy, yet.
How can I verify these are run?

On Wed, Jul 22, 2015 at 6:39 AM, Rajani Karuturi  wrote:
> Can someone please review PR 609? Its an enhancement to LDAP import users
> functionality
>
> https://github.com/apache/cloudstack/pull/609
>
> Thanks,
> ~Rajani



-- 
Daan

[GitHub] cloudstack pull request: CLOUDSTACK-8658: make initializer static ...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/612#issuecomment-123571169
  
Will test it against KVM + Agent.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [PROPOSAL] drop old upgrade code

[Wido den Hollander]

On 07/21/2015 06:01 PM, Somesh Naidu wrote:
> +1
> 
> Reasons:
> 1. Technically speaking, Apache Cloudstack never had version less than 4.0. 
> But even if they are considered they would be EOL'd at some point.
> 2. At some point the feature set disparity between version will make it 
> really complex to have direct upgrade paths.
> 3. As Daan mentioned, 2.x and 3.x users can still upgrade to 4.6+ using a 
> multi-step approach (upgrading to 4.3/4.5 first).
> 

+1 I agree. Imho prior to 4.0 isn't really something we want to support.

Upgrade to 4.0 first and then go to a ACS release.

Wido

> Regards,
> Somesh
> 
> -Original Message-
> From: Erik Weber [mailto:terbol...@gmail.com] 
> Sent: Monday, July 20, 2015 2:30 PM
> To: dev@cloudstack.apache.org
> Subject: Re: [PROPOSAL] drop old upgrade code
> 
> As a user, I'd say +1.
> 
> I understand the concerns, but as long as there is a workaround I'm fine
> with it.
> 
> Would be great though if the upgrade scripts abort if it notices an upgrade
> from an unsupported versions.
> 
> Erik
> 
> 
> Den mandag 20. juli 2015 skrev Daan Hoogland 
> følgende:
> 
>> LS,
>>
>> In coverity the only remaining high impact issues are concerned with
>> upgrade code. Some of it is in 4.3 and 4.5 code but most in pre-4
>> upgrades.
>>
>> I addressed the file Upgrade218to22.java in a PR [1] and I move that
>> we don't pull it but instead drop the file altogether together with
>> all upgrade code dating prior to 4.0.0. anybody on older versions can
>> still upgrade to any version between 4.0 and 4.5 and move on from
>> there.
>>
>> My objective is to have no high impact issues remaining so we clearly
>> see when we are digressing beit by hand or in  an automated way.
>>
>> +1?
>>
>> [1] https://github.com/apache/cloudstack/pull/603
>> --
>> Daan
>>

[GitHub] cloudstack pull request: CLOUDSTACK-8596 ability to query nested g...

[karuturi]

Github user karuturi commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/609#discussion_r35184810
  
--- Diff: 
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapConfiguration.java
 ---
@@ -43,14 +45,14 @@
 private ConfigurationDao _configDao;
 
 @Inject
-private LdapManager _ldapManager;
+private LdapConfigurationDao _ldapConfigurationDao;
 
 public LdapConfiguration() {
 }
 
-public LdapConfiguration(final ConfigurationDao configDao, final 
LdapManager ldapManager) {
+public LdapConfiguration(final ConfigurationDao configDao, final 
LdapConfigurationDao ldapConfigurationDao) {
 _configDao = configDao;
-_ldapManager = ldapManager;
+_ldapConfigurationDao = ldapConfigurationDao;
--- End diff --

constructor initialized ones were used in the unit tests to supply mocks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8596 ability to query nested g...

[karuturi]

Github user karuturi commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/609#discussion_r35184816
  
--- Diff: 
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
 ---
@@ -57,17 +57,22 @@
 private LdapContextFactory _ldapContextFactory;
 
 @Inject
-private LdapUserManager _ldapUserManager;
+private LdapConfiguration _ldapConfiguration;
+
+@Inject LdapUserManagerFactory _ldapUserManagerFactory;
+
 
 public LdapManagerImpl() {
 super();
 }
 
-public LdapManagerImpl(final LdapConfigurationDao 
ldapConfigurationDao, final LdapContextFactory ldapContextFactory, final 
LdapUserManager ldapUserManager) {
+public LdapManagerImpl(final LdapConfigurationDao 
ldapConfigurationDao, final LdapContextFactory ldapContextFactory, final 
LdapUserManagerFactory ldapUserManagerFactory,
+   final LdapConfiguration ldapConfiguration) {
--- End diff --

constructor initialized ones were used in the unit tests to supply mocks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8658: make initializer static ...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/612#issuecomment-123579225
  
Keys are being created:

[root@kvm1 ~]# ls -lart ~/.ssh/
total 16
dr-xr-x---. 3 root root 4096 Jul 22 02:37 ..
drwx--. 2 root root 4096 Jul 22 02:42 .
-rw-r--r--. 1 root root  389 Jul 22 02:42 id_rsa.pub.cloud
-rw---. 1 root root 1678 Jul 22 02:42 id_rsa.cloud
[root@kvm1 ~]# 

I will now run some basic tests: vm_life_cycle


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---