Pickle can't clear US custom.

[Kanzhe Jiang]

KC,

The chinese postal service refused to ship the pickle, stating that it will be 
rejected by US custom. The package cannot contain water.

Even if it gets through the custom, the fastest delivery will ship the package 
in 5 to 7 business days, which will be after my return date. I will bring them 
with me then.

Kanzhe

RE: [VOTE] git workflow

[Rajani Karuturi]

So far we got all +1 on the proposal with a couple+0 and a few  
suggestions/queries. I will try to summarize and send an update tomorrow.

~Rajani
Sent from my Windows Phone

-Original Message-
From: "Animesh Chaturvedi" 
Sent: ‎03-‎08-‎2014 10:20
To: "dev@cloudstack.apache.org" 
Subject: RE: [VOTE] git workflow

+0

While this protects master with only commits which are merges from release 
branch and keeps it clean but the issues that we have shift to develop branch. 


> -Original Message-
> From: Rajani Karuturi [mailto:rajani.karut...@citrix.com]
> Sent: Thursday, July 31, 2014 3:28 AM
> To: dev
> Subject: [VOTE] git workflow
> 
> Hi All,
> 
> We had long discussions on the git flow.
> I tried to capture the summary of it @
> http://markmail.org/message/j5z7dxjcqxfkfhpj
> This is updated on wiki @
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Git#Git-
> ProposedGitflowbasedCheck-inProcess and is up for a vote:
> 
> Can you share your opinion on the proposal?
> 
> [ ] +1  approve
> [ ] +0  no opinion
> [ ] -1  disapprove (and reason why)
> 
> 
> Thanks,
> ~Rajani
> 
> 

Re: [VOTE] git workflow

[Daan Hoogland]

Animesh,

There will always be developers creating conflicts or not taking into
account the semantics of other peoples code. Certainly in a worldwide
project like ACS. I see your reservation. The question is if we
improve the situation by working differently. I don't know but I think
we will. More important is that people educate themselves on the way
of working. (I am repeating myself, am I?)

regards,
Daan

On Sun, Aug 3, 2014 at 6:50 AM, Animesh Chaturvedi
 wrote:
> +0
>
> While this protects master with only commits which are merges from release 
> branch and keeps it clean but the issues that we have shift to develop branch.
>
>
>> -Original Message-
>> From: Rajani Karuturi [mailto:rajani.karut...@citrix.com]
>> Sent: Thursday, July 31, 2014 3:28 AM
>> To: dev
>> Subject: [VOTE] git workflow
>>
>> Hi All,
>>
>> We had long discussions on the git flow.
>> I tried to capture the summary of it @
>> http://markmail.org/message/j5z7dxjcqxfkfhpj
>> This is updated on wiki @
>> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Git#Git-
>> ProposedGitflowbasedCheck-inProcess and is up for a vote:
>>
>> Can you share your opinion on the proposal?
>>
>> [ ] +1  approve
>> [ ] +0  no opinion
>> [ ] -1  disapprove (and reason why)
>>
>>
>> Thanks,
>> ~Rajani
>>
>>
>



-- 
Daan

[ACS44] comparing 4.4 and -forward branches

[Daan Hoogland]

H,

I have been weeding through the big diff of the branches 4.4 and
4.4-forward and have found that (other the the one Anshul fixed), the
versions in 4.4 are the ones to keep. I will let them rest for a day
and be sending question about specific diffs tomorrow to the
respective writers tomorrow to ask for consult in case of doubt.

-- 
Daan

[ACS44][TEST] test_network diff

[Daan Hoogland]

H test developers,

One of the diffs between 4.4 and 4.4-forward I am not sure of is the folowing

diff --git a/test/integration/smoke/test_network.py
b/test/integration/smoke/test_network.py
index 988a162..4943b47 100644
--- a/test/integration/smoke/test_network.py
+++ b/test/integration/smoke/test_network.py
@@ -383,13 +383,12 @@ class TestPortForwarding(cloudstackTestCase):

 try:
 nat_rule.delete(self.apiclient)
-except Exception as e:
-self.fail("NAT Rule Deletion Failed: %s" % e)
-
-# NAT rule listing should fail as the nat rule does not exist
-with self.assertRaises(Exception):
-list_nat_rules(self.apiclient,
-   id=nat_rule.id)
+list_nat_rule_response = list_nat_rules(
+self.apiclient,
+id=nat_rule.id
+)
+except CloudstackAPIException:
+self.fail("Nat Rule Deletion or Listing Failed")

 # Check if the Public SSH port is inaccessible
 with self.assertRaises(Exception):

It would seem that the original (- minus signs) is the one to keep,
please comment on this

-- 
Daan

DB Upgrade from 4.0 to 4.4

[Ian Duffy]

Hi all,

I'm attempting to use the simulator with the database prefilled as little
as possible and all other sql scripts loaded in via the upgrade checker.

I manually load in the following sql scripts:

create-database.sql, create-database-premium.sql,
create-database-simulator.sql, create-schema.sql,
create-schema-premium.sql, create-schema-simulator.sql, templates.sql,
templates.simulator.sql, hypervisor_capabilities.simulator.sql (in this
specific order.)

I then place the contents of setup/db/db into my working directory and
launch the management server using

java -Xmx512m -XX:MaxPermSize=512m -jar
/vagrant/cloudstack/jetty-runner.jar --path /client
/vagrant/cloudstack/cloud-client.war --lib /vagrant/cloudstack/lib

(where /vagrant/cloudstack/lib contains a jar of the mysql-connector).

The simulator starts coming up and starts doing the upgrade of the database
but I get a bunch of foreign key constraint failures.

Is there a sql script i'm forgetting to manually import?

Thanks,

Ian

Re: DB Upgrade from 4.0 to 4.4

[Ian Duffy]

Log over at: https://gist.github.com/imduffy15/f93c28a259f21569bec9


On 4 August 2014 01:39, Ian Duffy  wrote:

> Hi all,
>
> I'm attempting to use the simulator with the database prefilled as little
> as possible and all other sql scripts loaded in via the upgrade checker.
>
> I manually load in the following sql scripts:
>
> create-database.sql, create-database-premium.sql,
> create-database-simulator.sql, create-schema.sql,
> create-schema-premium.sql, create-schema-simulator.sql, templates.sql,
> templates.simulator.sql, hypervisor_capabilities.simulator.sql (in this
> specific order.)
>
> I then place the contents of setup/db/db into my working directory and
> launch the management server using
>
> java -Xmx512m -XX:MaxPermSize=512m -jar
> /vagrant/cloudstack/jetty-runner.jar --path /client
> /vagrant/cloudstack/cloud-client.war --lib /vagrant/cloudstack/lib
>
> (where /vagrant/cloudstack/lib contains a jar of the mysql-connector).
>
> The simulator starts coming up and starts doing the upgrade of the
> database but I get a bunch of foreign key constraint failures.
>
> Is there a sql script i'm forgetting to manually import?
>
> Thanks,
>
> Ian
>

Re: Review Request 24111: Coverity findings for brocade-plugin

[Santhosh Edukulla]

> On Aug. 1, 2014, 5:57 a.m., Santhosh Edukulla wrote:
> > plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java,
> >  line 547
> > 
> >
> > It seems there is no corresponding catch here, did compilation worked?
> 
> Ritu  Sabharwal wrote:
> Hi Santhosh,
> 
> This log statement is not there in the latest patch that I submitted.
> 
> There is a throws clause in the method signature private String 
> responseToErrorMessage(HttpResponse response) throws IOException  and the 
> IOException is handled in the caller methods.
> 
> The compilation works fine.
> 
> Thanks,
> Ritu S.

It seems that patch was not in correct git format, we can do "git apply" and 
"git commit -m --author=...", if its ok.

Hugo, 

if we don't have any other concerns, we can push i believe.

Santhosh


- Santhosh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24111/#review49323
---


On July 31, 2014, 5:57 p.m., Ritu  Sabharwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24111/
> ---
> 
> (Updated July 31, 2014, 5:57 p.m.)
> 
> 
> Review request for cloudstack and Hugo Trippaers.
> 
> 
> Bugs: CLOUDSTACK-6823
> https://issues.apache.org/jira/browse/CLOUDSTACK-6823
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fixed Coverity findings for brocade-plugin
> 
> 
> Diffs
> -
> 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/api/response/BrocadeVcsDeviceResponse.java
>  60edbcf 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java
>  d5f06f8 
> 
> Diff: https://reviews.apache.org/r/24111/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ritu  Sabharwal
> 
>

Re: Review Request 24182: CLOUDSTACK-7223 Wait for System VM agent state to be connected before verication

[Santhosh Edukulla]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24182/#review49443
---

Ship it!


John,

1. Just mark the open issues as resolved.
2. As well, mention the branch information to which it need to be applied.

Santhosh

- Santhosh Edukulla


On Aug. 1, 2014, 7:13 p.m., John Dilley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24182/
> ---
> 
> (Updated Aug. 1, 2014, 7:13 p.m.)
> 
> 
> Review request for cloudstack and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-7223
> https://issues.apache.org/jira/browse/CLOUDSTACK-7223
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> This change waits for the system VM agent state to be up in the testcases 
> that stop/reboot/destroy system VMs before verifying that they are 
> functioning properly.
> 
> 
> Diffs
> -
> 
>   test/integration/smoke/test_ssvm.py ac4079e 
> 
> Diff: https://reviews.apache.org/r/24182/diff/
> 
> 
> Testing
> ---
> 
> Tested against KVM advanced zone
> 
> 
> Thanks,
> 
> John Dilley
> 
>

[RESULT][VOTE] git workflow

[Rajani Karuturi]

There were 17 votes on the proposal

+1 15 people
+0 2 people
-1 none

Thanks everyone for participating.

The only open question I see in the thread is about hot fix branch naming 
convention.
Since there aren’t any major concerns and the vote has passed, I believe we 
should start adopting to this.

Sebastian/Daan/Hugo
Can we start on following this and make the necessary git branches?


Thanks,
~Rajani



On 31-Jul-2014, at 3:58 pm, Rajani Karuturi  wrote:

> Hi All,
> 
> We had long discussions on the git flow.
> I tried to capture the summary of it @ 
> http://markmail.org/message/j5z7dxjcqxfkfhpj
> This is updated on wiki @ 
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Git#Git-ProposedGitflowbasedCheck-inProcess
>  and is up for a vote:
> 
> Can you share your opinion on the proposal?
> 
> [ ] +1  approve
> [ ] +0  no opinion
> [ ] -1  disapprove (and reason why)
> 
> 
> Thanks,
> ~Rajani
> 
> 
> 

Re: [ACS44][TEST] test_network diff

[Gaurav Aradhye]

Yes Daan, the one with (-) is the one to keep.

Regards,
Gaurav


On Mon, Aug 4, 2014 at 12:11 AM, Daan Hoogland 
wrote:

> H test developers,
>
> One of the diffs between 4.4 and 4.4-forward I am not sure of is the
> folowing
>
> diff --git a/test/integration/smoke/test_network.py
> b/test/integration/smoke/test_network.py
> index 988a162..4943b47 100644
> --- a/test/integration/smoke/test_network.py
> +++ b/test/integration/smoke/test_network.py
> @@ -383,13 +383,12 @@ class TestPortForwarding(cloudstackTestCase):
>
>  try:
>  nat_rule.delete(self.apiclient)
> -except Exception as e:
> -self.fail("NAT Rule Deletion Failed: %s" % e)
> -
> -# NAT rule listing should fail as the nat rule does not exist
> -with self.assertRaises(Exception):
> -list_nat_rules(self.apiclient,
> -   id=nat_rule.id)
> +list_nat_rule_response = list_nat_rules(
> +self.apiclient,
> +id=nat_rule.id
> +)
> +except CloudstackAPIException:
> +self.fail("Nat Rule Deletion or Listing Failed")
>
>  # Check if the Public SSH port is inaccessible
>  with self.assertRaises(Exception):
>
> It would seem that the original (- minus signs) is the one to keep,
> please comment on this
>
> --
> Daan
>

RE: [RESULT][VOTE] git workflow

[Suresh Sadhu]

+1 

-Original Message-
From: Rajani Karuturi [mailto:rajani.karut...@citrix.com] 
Sent: 04 August 2014 10:07
To: dev@cloudstack.apache.org
Subject: [RESULT][VOTE] git workflow

There were 17 votes on the proposal

+1 15 people
+0 2 people
-1 none

Thanks everyone for participating.

The only open question I see in the thread is about hot fix branch naming 
convention.
Since there aren't any major concerns and the vote has passed, I believe we 
should start adopting to this.

Sebastian/Daan/Hugo
Can we start on following this and make the necessary git branches?


Thanks,
~Rajani



On 31-Jul-2014, at 3:58 pm, Rajani Karuturi  wrote:

> Hi All,
> 
> We had long discussions on the git flow.
> I tried to capture the summary of it @ 
> http://markmail.org/message/j5z7dxjcqxfkfhpj
> This is updated on wiki @ 
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Git#Git-ProposedGitflowbasedCheck-inProcess
>  and is up for a vote:
> 
> Can you share your opinion on the proposal?
> 
> [ ] +1  approve
> [ ] +0  no opinion
> [ ] -1  disapprove (and reason why)
> 
> 
> Thanks,
> ~Rajani
> 
> 
> 

Re: Review Request 23813: CLOUDSTACK-7044: Portable IP Range test case changes - reading portable ip range from test_data.py file

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23813/#review49444
---


Commit 98e2a0444f74e3e8f6993319c822cc12bc491931 in cloudstack's branch 
refs/heads/master from Girish Shilamkar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=98e2a04 ]

Revert "CLOUDSTACK-7044: Portable IP Range test case changes - reading portable 
ip range from test_data.py file"

This reverts commit 613eb12104af5c27935091127a1a19941f96e336.


- ASF Subversion and Git Services


On July 22, 2014, 3:54 p.m., Ashutosh Kelkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23813/
> ---
> 
> (Updated July 22, 2014, 3:54 p.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-7044
> https://issues.apache.org/jira/browse/CLOUDSTACK-7044
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Changes:
> 1. Removing method "getPortableIpRangeServices" from common.py file
> 2. Reading the portable IP range data from test_data.py file
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_portable_ip.py ce27dd8 
>   tools/marvin/marvin/config/test_data.py 19b9aa4 
>   tools/marvin/marvin/lib/common.py bc6b9c7 
> 
> Diff: https://reviews.apache.org/r/23813/diff/
> 
> 
> Testing
> ---
> 
> Yes. Tested on KVM Advanced setup.
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>

Re: Review Request 24154: CLOUDSTACK-7215: Make expunge=True as default parameter value while calling destroyVirtualMachine through base library

[Gaurav Aradhye]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24154/#review49445
---


Hi Santhoshe, can you please review this?

- Gaurav Aradhye


On July 31, 2014, 8:28 p.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24154/
> ---
> 
> (Updated July 31, 2014, 8:28 p.m.)
> 
> 
> Review request for cloudstack and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-7215
> https://issues.apache.org/jira/browse/CLOUDSTACK-7215
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> In almost 90% of the scenarios where VMs are created through test case, VMs 
> are added to cleanup list and the delete method is called for them through 
> cleanup_resources method in utils.py file.
> 
> These VMs remain in destroyed state for long time and keep blocking the 
> resources (IP Address etc) and hence the load on the setup on which 
> regression build is fired increases.
> 
> Making expunge=True as default parameter in destroyVirtualMachine api call 
> through base library will make all these VMs expunge quickly making resources 
> available for next test cases.
> 
> Also, it can be passed as False whenever we don't want VM to expunge 
> immediately, and in case when we recover the VM through test case after 
> destroying it. Pass expunge=False for all such scenarios.
> 
> This will hugely boost the test cases execution speed too.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_advancedsg_networks.py 2794f96 
>   test/integration/component/test_multiple_ips_per_nic.py 24b85df 
>   test/integration/component/test_ps_domain_limits.py afb0955 
>   test/integration/component/test_ps_limits.py 1993e93 
>   test/integration/component/test_vpc_vm_life_cycle.py fd995cd 
>   tools/marvin/marvin/lib/base.py 58033c6 
> 
> Diff: https://reviews.apache.org/r/24154/diff/
> 
> 
> Testing
> ---
> 
> Yes.
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Review Request 24226: CLOUDSTACK-7234: stop sending smb credentials to Hyper-V Agent

[Anshul Gangwar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24226/
---

Review request for cloudstack, Devdeep Singh and Rajesh Battala.


Bugs: CLOUDSTACK-7234
https://issues.apache.org/jira/browse/CLOUDSTACK-7234


Repository: cloudstack-git


Description
---

We no longer uses SMB credentials on Hyper-V Agent so we are stopping to send 
SMB credentials to Hyper-V


Diffs
-

  
engine/schema/src/org/apache/cloudstack/storage/datastore/db/StoragePoolVO.java 
1508ce0 
  
plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/CloudStackTypes.cs
 4516191 
  plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/Utils.cs 
b40cb8f 
  
plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java
 2671b20 

Diff: https://reviews.apache.org/r/24226/diff/


Testing
---

verified on Hyper-V agent that we are not receiving SMB credentials.


Thanks,

Anshul Gangwar

Re: Review Request 24182: CLOUDSTACK-7223 Wait for System VM agent state to be connected before verication

[John Dilley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24182/
---

(Updated Aug. 4, 2014, 6:19 a.m.)


Review request for cloudstack and Santhosh Edukulla.


Bugs: CLOUDSTACK-7223
https://issues.apache.org/jira/browse/CLOUDSTACK-7223


Repository: cloudstack-git


Description
---

This change waits for the system VM agent state to be up in the testcases that 
stop/reboot/destroy system VMs before verifying that they are functioning 
properly.


Diffs
-

  test/integration/smoke/test_ssvm.py ac4079e 

Diff: https://reviews.apache.org/r/24182/diff/


Testing
---

Tested against KVM advanced zone


Thanks,

John Dilley

Re: Review Request 24182: CLOUDSTACK-7223 Wait for System VM agent state to be connected before verication

[Santhosh Edukulla]

> On Aug. 4, 2014, 4:35 a.m., Santhosh Edukulla wrote:
> > John,
> > 
> > 1. Just mark the open issues as resolved.
> > 2. As well, mention the branch information to which it need to be applied.
> > 
> > Santhosh

Hi John,

Sorry, iam getting trailing whitespace errors as below, while applying patch. 
Going ahead, once we create a patch, may be we can just check to apply it once 
to avoid these errors.

/home/santhosh/softwares/cs_new_master/cloudstack/.git/rebase-apply/patch:15: 
trailing whitespace.

/home/santhosh/softwares/cs_new_master/cloudstack/.git/rebase-apply/patch:60: 
trailing whitespace.

/home/santhosh/softwares/cs_new_master/cloudstack/.git/rebase-apply/patch:117: 
trailing whitespace.
   
warning: 3 lines add whitespace errors.

Santhosh


- Santhosh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24182/#review49443
---


On Aug. 4, 2014, 6:19 a.m., John Dilley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24182/
> ---
> 
> (Updated Aug. 4, 2014, 6:19 a.m.)
> 
> 
> Review request for cloudstack and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-7223
> https://issues.apache.org/jira/browse/CLOUDSTACK-7223
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> This change waits for the system VM agent state to be up in the testcases 
> that stop/reboot/destroy system VMs before verifying that they are 
> functioning properly.
> 
> 
> Diffs
> -
> 
>   test/integration/smoke/test_ssvm.py ac4079e 
> 
> Diff: https://reviews.apache.org/r/24182/diff/
> 
> 
> Testing
> ---
> 
> Tested against KVM advanced zone
> 
> 
> Thanks,
> 
> John Dilley
> 
>

Re: Review Request 24154: CLOUDSTACK-7215: Make expunge=True as default parameter value while calling destroyVirtualMachine through base library

[Santhosh Edukulla]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24154/#review49447
---

Ship it!


Ship It!

- Santhosh Edukulla


On July 31, 2014, 2:58 p.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24154/
> ---
> 
> (Updated July 31, 2014, 2:58 p.m.)
> 
> 
> Review request for cloudstack and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-7215
> https://issues.apache.org/jira/browse/CLOUDSTACK-7215
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> In almost 90% of the scenarios where VMs are created through test case, VMs 
> are added to cleanup list and the delete method is called for them through 
> cleanup_resources method in utils.py file.
> 
> These VMs remain in destroyed state for long time and keep blocking the 
> resources (IP Address etc) and hence the load on the setup on which 
> regression build is fired increases.
> 
> Making expunge=True as default parameter in destroyVirtualMachine api call 
> through base library will make all these VMs expunge quickly making resources 
> available for next test cases.
> 
> Also, it can be passed as False whenever we don't want VM to expunge 
> immediately, and in case when we recover the VM through test case after 
> destroying it. Pass expunge=False for all such scenarios.
> 
> This will hugely boost the test cases execution speed too.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_advancedsg_networks.py 2794f96 
>   test/integration/component/test_multiple_ips_per_nic.py 24b85df 
>   test/integration/component/test_ps_domain_limits.py afb0955 
>   test/integration/component/test_ps_limits.py 1993e93 
>   test/integration/component/test_vpc_vm_life_cycle.py fd995cd 
>   tools/marvin/marvin/lib/base.py 58033c6 
> 
> Diff: https://reviews.apache.org/r/24154/diff/
> 
> 
> Testing
> ---
> 
> Yes.
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Re: Review Request 24154: CLOUDSTACK-7215: Make expunge=True as default parameter value while calling destroyVirtualMachine through base library

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24154/#review49448
---


Commit c32b19a07d0eaa6dc0195ecf1aa9b952a91dc997 in cloudstack's branch 
refs/heads/master from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=c32b19a ]

CLOUDSTACK-7215: Make expunge=True as default parameter value while calling 
destroyVirtualMachine through base library

Signed-off-by: Santhosh Edukulla 


- ASF Subversion and Git Services


On July 31, 2014, 2:58 p.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24154/
> ---
> 
> (Updated July 31, 2014, 2:58 p.m.)
> 
> 
> Review request for cloudstack and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-7215
> https://issues.apache.org/jira/browse/CLOUDSTACK-7215
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> In almost 90% of the scenarios where VMs are created through test case, VMs 
> are added to cleanup list and the delete method is called for them through 
> cleanup_resources method in utils.py file.
> 
> These VMs remain in destroyed state for long time and keep blocking the 
> resources (IP Address etc) and hence the load on the setup on which 
> regression build is fired increases.
> 
> Making expunge=True as default parameter in destroyVirtualMachine api call 
> through base library will make all these VMs expunge quickly making resources 
> available for next test cases.
> 
> Also, it can be passed as False whenever we don't want VM to expunge 
> immediately, and in case when we recover the VM through test case after 
> destroying it. Pass expunge=False for all such scenarios.
> 
> This will hugely boost the test cases execution speed too.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_advancedsg_networks.py 2794f96 
>   test/integration/component/test_multiple_ips_per_nic.py 24b85df 
>   test/integration/component/test_ps_domain_limits.py afb0955 
>   test/integration/component/test_ps_limits.py 1993e93 
>   test/integration/component/test_vpc_vm_life_cycle.py fd995cd 
>   tools/marvin/marvin/lib/base.py 58033c6 
> 
> Diff: https://reviews.apache.org/r/24154/diff/
> 
> 
> Testing
> ---
> 
> Yes.
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>