Re: Review Request 23410: Improvised CloudByte Storage Plugin for 4.5 and above. jira id : CLOUDSTACK-7098

[punith s]

> On July 18, 2014, 9:36 a.m., Mike Tutkowski wrote:
> > Ship It!
> 
> Mike Tutkowski wrote:
> Changes were put into ACS repo with this commit:
> 
> f3cbb699955243007ffb53b335d9508b2e422a06

sure thanks mike :)


- punith


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23410/#review48107
---


On July 15, 2014, 7:48 p.m., punith s wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23410/
> ---
> 
> (Updated July 15, 2014, 7:48 p.m.)
> 
> 
> Review request for cloudstack, amit kumar das, edison su, and Mike Tutkowski.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> The new improvised cloudbyte plugin for cloudstack supports the following 
> features
> 
> * support for managed storage, where each vm disk has the guaranteed QoS.
> 
> * supports resize of the volume.
> 
> * supports both iscsi and nfs protocols in XEN server, and iscsi protocol for 
> KVM and vmware ESX with respect to managed storage.
> 
> * supports storage level snapshot capabilites as well as hypervisor level 
> snapshot feature.
> 
> * also exposing the custom api's for better ui integration.
> 
> * support for unlimited storage nodes across the sites.
> 
> * account integration in cloudbyte with respect to domains in cloudstack.
> 
> 
> Diffs
> -
> 
>   
> plugins/storage/volume/cloudbyte/resources/META-INF/cloudstack/storage-volume-cloudbyte/spring-storage-volume-cloudbyte-context.xml
>  87c5f51 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/driver/ElastistorPrimaryDataStoreDriver.java
>  99d1e2a 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/lifecycle/ElastistorPrimaryDataStoreLifeCycle.java
>  33004e3 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/provider/ElastistorHostListener.java
>  de4711a 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/provider/ElastistorPrimaryDataStoreProvider.java
>  e591082 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ElastistorUtil.java
>  b75d12a 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ElastistorVolumeApiService.java
>  PRE-CREATION 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ElastistorVolumeApiServiceImpl.java
>  PRE-CREATION 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ListElastistorInterfaceCmd.java
>  PRE-CREATION 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ListElastistorInterfaceResponse.java
>  PRE-CREATION 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ListElastistorPoolCmd.java
>  PRE-CREATION 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ListElastistorPoolResponse.java
>  PRE-CREATION 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ListElastistorVolumeCmd.java
>  PRE-CREATION 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ListElastistorVolumeResponse.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/23410/diff/
> 
> 
> Testing
> ---
> 
> system testing done.
> 
> 
> Thanks,
> 
> punith s
> 
>

Re: Review Request 23547: CLOUDSTACK-7113: Ability to reset password when Router VM is stopped

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23547/#review48115
---


Commit 0069037573247e2cbe545e8d01d609040444e453 in cloudstack's branch 
refs/heads/master from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=0069037 ]

CLOUDSTACK-7113: Ability to reset password when Router VM is stopped
With this improvement password reset also happens when router is in stopped 
state on resetPasswordCmd and restoreVM


- ASF Subversion and Git Services


On July 16, 2014, 10:06 a.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23547/
> ---
> 
> (Updated July 16, 2014, 10:06 a.m.)
> 
> 
> Review request for cloudstack, Jayapal Reddy and Kishan Kavala.
> 
> 
> Bugs: CLOUDSTACK-7113
> https://issues.apache.org/jira/browse/CLOUDSTACK-7113
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-7113: Ability to reset password when Router VM is stopped 
> With this improvement password reset also happens when router is in stopped 
> state on resetPasswordCmd and restoreVM
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/network/element/VirtualRouterElement.java 3b3cacd 
>   server/src/com/cloud/vm/UserVmManagerImpl.java dac4acf 
> 
> Diff: https://reviews.apache.org/r/23547/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Re: Review Request 22927: Bugfix CLOUDSTACK-6261: remove the forceful timeout setting when login to NetScaler.

[Rajesh Battala]

> On July 9, 2014, 4:45 p.m., ASF Subversion and Git Services wrote:
> > Commit e07d0ddabfedad137856c3c9ae7de3a96fe25feb in cloudstack's branch 
> > refs/heads/master from Sujaya Maiyya
> > [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=e07d0dd ]
> > 
> > fixed CLOUDSTACK-6261: remove the forceful timeout setting when login to 
> > NetScaler.
> >

I have pushed to master branch. can you close this review request


- Rajesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22927/#review47503
---


On July 8, 2014, 9:28 a.m., Sujaya Maiyya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22927/
> ---
> 
> (Updated July 8, 2014, 9:28 a.m.)
> 
> 
> Review request for cloudstack, Murali Reddy and Rajesh Battala.
> 
> 
> Bugs: CLOUDSTACK-6261
> https://issues.apache.org/jira/browse/CLOUDSTACK-6261
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> The NetScaler Resource forces a idle timeout of 100,000 seconds during login. 
> It is best to leave it to the system default which is 30 mins. The timeout 
> has been removed from NetscalerResource in order to support login for 
> Netscaler 10.5 devices.
> 
> 
> Diffs
> -
> 
>   
> plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java
>  ff51ef9 
> 
> Diff: https://reviews.apache.org/r/22927/diff/
> 
> 
> Testing
> ---
> 
> Timeout was removed and login to the Netscaler devices with the default 
> timeout of 30 minutes was successful. It was tested for Netscaler builds 10.1 
> and 10.5.
> 
> 
> Thanks,
> 
> Sujaya Maiyya
> 
>

Re: Review Request 22799: Golden (Base) Primary Storage feature

[Hieu LE]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22799/
---

(Updated July 18, 2014, 10:26 a.m.)


Review request for cloudstack, Mike Tutkowski and Tim Mackey.


Changes
---

Add some minor fix in UI display
Add new parameter in ListStoragePool API


Repository: cloudstack-git


Description
---

As discussed in mailing list, this patch is applied for golden primary storage 
in [1].
I have changed the term from "golden" to "base" because there are some 
functions and variables in CloudStack also use "base" for base image.
This patch only apply for Xen Server.

[1]: 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Golden+Primary+Storage


Diffs (updated)
-

  api/src/com/cloud/deploy/DeployDestination.java 
4ded5ebe7a18252da471ee25019856f2b2f772e0 
  api/src/com/cloud/storage/StoragePool.java 
8e03c3348f3a6dd3156ab9e440126ea317957dc0 
  api/src/com/cloud/template/VirtualMachineTemplate.java 
599212bb039fdbb78511019e8f0a6ea4b4a84440 
  api/src/org/apache/cloudstack/api/ApiConstants.java 
ae5d6f05b6b52f60b151369a641cb11fcbb558af 
  api/src/org/apache/cloudstack/api/BaseUpdateTemplateOrIsoCmd.java 
2350f6b389203e2c6cc2182fe03fe9a95e936b81 
  
api/src/org/apache/cloudstack/api/command/admin/storage/CreateStoragePoolCmd.java
 ae44bc9373232d242e4ebdcf76844969f0fe69fc 
  
api/src/org/apache/cloudstack/api/command/admin/storage/ListStoragePoolsCmd.java
 ed123db 
  
api/src/org/apache/cloudstack/api/command/admin/storage/UpdateStoragePoolCmd.java
 3d1a77353257c814efaf60875ffdf99603bc414e 
  
api/src/org/apache/cloudstack/api/command/user/template/RegisterTemplateCmd.java
 f478c9bc8eebf867a03deb4add1bf695ac3ec0ad 
  api/src/org/apache/cloudstack/api/response/StoragePoolResponse.java 
3571866fe74dca9aa5fe0d11373313eab97e94ac 
  api/src/org/apache/cloudstack/api/response/TemplateResponse.java 
3e21043e339103c021d3c9e767acac8b3837f760 
  core/src/com/cloud/agent/api/CheckPoolBelongToHostAnswer.java PRE-CREATION 
  core/src/com/cloud/agent/api/CheckPoolBelongToHostCommand.java PRE-CREATION 
  core/src/org/apache/cloudstack/storage/to/PrimaryDataStoreTO.java 
29e53b0d9581f764a17ea285606213d2c045b029 
  core/src/org/apache/cloudstack/storage/to/TemplateObjectTO.java 
b201c386f4975913f13c575d7685e50cedc7d92f 
  core/test/org/apache/cloudstack/api/agent/test/BackupSnapshotCommandTest.java 
33361e87265df05e00bfa6dba810d2b68ae8d923 
  core/test/org/apache/cloudstack/api/agent/test/CheckNetworkAnswerTest.java 
66feaecb5ef20053db50956e2801fec096a350c9 
  core/test/org/apache/cloudstack/api/agent/test/SnapshotCommandTest.java 
114c8854d1504436523aa99c78bf2b4d84a12077 
  
engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/PrimaryDataStoreParameters.java
 1dbff59a8911ad8f0933ef17a2c2b1d3e33523b9 
  
engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/StoragePoolAllocator.java
 dfdbd8ab92c47799f6ad23637fa63e030f0be968 
  
engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/VolumeInfo.java
 f93f4efac83c565cd33eb7eb67dcaca335f1c226 
  engine/components-api/src/com/cloud/deploy/DeploymentPlanningManager.java 
ee6721ab445a5222d0087dc9170e0b58f9eef91a 
  engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java 
4aa5fc80d9660d2f985db98124c33465bd99767f 
  
engine/orchestration/src/org/apache/cloudstack/engine/cloud/entity/api/VMEntityManagerImpl.java
 b1ac2f853374d6f1ddd9087919dbc16db0433f59 
  
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java
 6256e2526ef9bd4632a5e3873c4d9531eb301c7f 
  engine/schema/src/com/cloud/storage/VMTemplateVO.java 
9a77cbf873aa9e422985fbcdc0ae7e18b8c78d4c 
  engine/schema/src/com/cloud/storage/VolumeVO.java 
e328253a596891029c2b55bea81b7ead425251ee 
  
engine/schema/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDao.java
 a976bfbf6fe46306d20ad939c335bba6b9b7be54 
  
engine/schema/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImpl.java
 92793f1fb1a08a455a78667ba4a39ae162378360 
  
engine/schema/src/org/apache/cloudstack/storage/datastore/db/StoragePoolVO.java 
1508ce0b28c83968c25d9601b6dae34e1a73dbb0 
  
engine/storage/image/src/org/apache/cloudstack/storage/image/store/TemplateObject.java
 7288d454c30fdb81445e43549145f1f2da8533e4 
  
engine/storage/src/org/apache/cloudstack/storage/allocator/ClusterScopeStoragePoolAllocator.java
 ea084c7555468001a12376640d9785b1cf852948 
  
engine/storage/src/org/apache/cloudstack/storage/allocator/LocalStoragePoolAllocator.java
 446e101141bafde28615d766fdffd3a36ee8f3ce 
  
engine/storage/src/org/apache/cloudstack/storage/image/TemplateEntityImpl.java 
c1aa8c2f0d49eb6bc6ff124dd4d87b7b714f62e9 
  
engine/storage/src/org/apache/cloudstack/storage/volume/datastore/PrimaryDataStoreHelper.java
 6b129755009413faae6685a62cfb3ae7b62b42f3 
  
engine/storage/volume/src/org/apache/clou

[Issue]: Wrong status of System VM after destroy them

[huangchunmei]

Hi Alex,

 

For cloudStack 4.3, I found the status of SSVM and CPVM are always in
Destroyed status after destroyed them. This would lead to an issue that zone
could be deleted if there are VMs with Destroyed status.

Would you please help to check why we change the status to "Expunging", then
update it to "Destroyed"? Or I missed something, maybe other thread to
handle system VMs with "Destroyed" status.

Following are the related codes:

/server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java,


public boolean destroyProxy(long vmId) {

ConsoleProxyVO proxy = _consoleProxyDao.findById(vmId);

try {

//expunge the vm

_itMgr.expunge(proxy.getUuid()); // change status to "Expunging"

proxy.setPublicIpAddress(null);

proxy.setPublicMacAddress(null);

proxy.setPublicNetmask(null);

proxy.setPrivateMacAddress(null);

proxy.setPrivateIpAddress(null);

_consoleProxyDao.update(proxy.getId(), proxy);

_consoleProxyDao.remove(vmId); // change status to "Destroyed"

/engine/schema/src/com/cloud/vm/dao/ConsoleProxyDaoImpl.java


public boolean remove(Long id) {

TransactionLegacy txn = TransactionLegacy.currentTxn();

txn.start();

ConsoleProxyVO proxy = createForUpdate();

proxy.setPublicIpAddress(null);

proxy.setPrivateIpAddress(null);



UpdateBuilder ub = getUpdateBuilder(proxy);

ub.set(proxy, "state", State.Destroyed);

ub.set(proxy, "privateIpAddress", null);

update(id, ub, proxy);



boolean result = super.remove(id);

txn.commit();

return result;

}

 

 

Thanks very much

Chunmei Huang

Re: Review Request 23617: Add Nic UUID to the context so that we can read the same in event bus after create a nic

[Damodar Reddy Talakanti]

> On July 17, 2014, 4:55 p.m., Nitin Mehta wrote:
> > server/src/com/cloud/vm/UserVmManagerImpl.java, line 960
> > 
> >
> > Why is it made create=true when it is not a BaseAyncCreate cmd ? 
> > create=true should be added only when its invoked through the create() 
> > method of a  BaseAyncCreate cmd

We can not extend AddNicToVMCmd by BaseAsyncCreate cmd as it is doing many 
checks before creating the entry NIC. As it is creating entity did made 
create=true there.


- Damodar Reddy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23617/#review48016
---


On July 17, 2014, 4:43 p.m., Damodar Reddy Talakanti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23617/
> ---
> 
> (Updated July 17, 2014, 4:43 p.m.)
> 
> 
> Review request for cloudstack and Nitin Mehta.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Putting the create event into event bus for addNicToVirutalMachine command 
> explicitly as we can not use BaseAsyncCreateCommand.We can not extend this 
> with BaseAsyncCreateCmd due to the checks we do before creating the nic.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/event/EventTypes.java 71bfdb6 
>   server/src/com/cloud/vm/UserVmManagerImpl.java d0bc186 
> 
> Diff: https://reviews.apache.org/r/23617/diff/
> 
> 
> Testing
> ---
> 
> Tested against the following setup:
> 
> 1. XenServer 6.2
> 2. Master Branch
> 
> 
> Thanks,
> 
> Damodar Reddy Talakanti
> 
>

Review Request 23677: CLOUDSTACK-7024: Resolved cleanup issue in test script

[Ashutosh Kelkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23677/
---

Review request for cloudstack and Girish Shilamkar.


Bugs: CLOUDSTACK-7024
https://issues.apache.org/jira/browse/CLOUDSTACK-7024


Repository: cloudstack-git


Description
---

Resolved issue related to order of cleanup items. The project must be removed 
before the account which manages it.


Diffs
-

  test/integration/component/test_project_usage.py 5e0dda5 

Diff: https://reviews.apache.org/r/23677/diff/


Testing
---

Yes.

Log:
Test Upload/ delete a template and verify correct usage is generated ... === 
TestName: test_01_template_usage | Status : SUCCESS ===
ok

--
Ran 1 test in 285.451s

OK


Thanks,

Ashutosh Kelkar

Re: What to modify to increase instance password length?

[Harikrishna Patnala]

Hi Ian, 

The commit was made only in 4.4 and not in master. 
Can you cherry pick the same to master.

Thanks,
Harikrishna
On 26-Jun-2014, at 12:23 am, Ian Duffy  wrote:

> Just pushed a change for this to the 4.4-forward branch.
> 
> Daan, will you review / cherrypick? 96412e3e58fd1ced9d269e4552aaa6410bedf556
> 
> Testing done:
> 
> Brought up simulator.
> 
> Changed password flag for the builtin template.
> 
> Brought up VM, password was displayed at length of 6. Stopped the VM, reset
> the password, new password was displayed at length of 6.
> 
> Went into global settings, modified the value for vm.password.length to 20.
> Restarted the management server.
> Created a new VM, password was displayed at length of 20. Stopped the VM,
> reset the password, new password was displayed at length of 20.
> 
> Thanks,
> 
> Ian
> 
> On 25 June 2014 18:50, Nux!  wrote:
> 
>> Volunteer to do it in time for 4.4?
>> 
>> Lucian
>> 
>> --
>> Sent from the Delta quadrant using Borg technology!
>> 
>> Nux!
>> www.nux.ro
>> 
>> 
>> - Original Message -
>> From: "ilya musayev" 
>> To: dev@cloudstack.apache.org
>> Sent: Wednesday, 25 June, 2014 6:30:25 PM
>> Subject: Re: What to modify to increase instance password length?
>> 
>> You should ask if this can be done as global setting variable - not hard
>> coded.
>> 
>> This should be an easy one.
>> 
>> On 6/25/14, 10:14 AM, Nux! wrote:
>>> I should submit a bug report to rewrite ACS in a scripting language.
>>> 
>>> Cheers :)
>>> 
>>> --
>>> Sent from the Delta quadrant using Borg technology!
>>> 
>>> Nux!
>>> www.nux.ro
>>> 
>>> 
>>> - Original Message -
>>> From: "Ian Duffy" 
>>> To: "CloudStack Dev" 
>>> Sent: Wednesday, 25 June, 2014 6:11:23 PM
>>> Subject: Re: What to modify to increase instance password length?
>>> 
>>> Afaik yes. (Will to be corrected on this but it appears to be hard coded)
>>> 
>>> 
>>> On 25 June 2014 18:06, Nux!  wrote:
>>> 
 Thanks, Ian,
 
 This means I need to modify the source, rebuild the RPMs and update,
 right? (ie it's not something that I can just modify on the mgmt server
 right now).
 
 Lucian
 
 --
 Sent from the Delta quadrant using Borg technology!
 
 Nux!
 www.nux.ro
 
 
 - Original Message -
 From: "Ian Duffy" 
 To: "CloudStack Dev" 
 Sent: Wednesday, 25 June, 2014 6:02:12 PM
 Subject: Re: What to modify to increase instance password length?
 
 Hi Lucian,
 
 Take a look at server/src/com/cloud/server/ManagementServerImpl.java
 
 Line 895 - 898
 
 @Override
 public String generateRandomPassword() {
 return PasswordGenerator.generateRandomPassword(6);
 }
 
 
 
 
 On 25 June 2014 17:16, Nux!  wrote:
 
> Hi guys,
> 
> Can anyone tell me which changes I should make in order to increase
> password length for instances?
> Currently I get something like "tK2yptbby" which might have been secure
 10
> years ago, but now it's way too short.
> 
> Thanks!
> Lucian
> 
> --
> Sent from the Delta quadrant using Borg technology!
> 
> Nux!
> www.nux.ro
> 
> 
>> 
>> 

[JENKINS] devcloud-continuous-tests

[Hugo Trippaers]

Hey Talluri,

Do you know what happend to this jenkins slave? The console log tells me that 
the system was halted?

Cheers,

Hugo

Re: Review Request 23282: CLOUDSTACK-6845 : First Code drop for NuageVsp Network plugin

[Hugo Trippaers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23282/#review48121
---


* Unit tests complete successfully

* Findbugs output reports no problems
[INFO] <<< findbugs-maven-plugin:2.5.3:check (default-cli) @ 
cloud-plugin-network-vsp <<<
[INFO] 
[INFO] --- findbugs-maven-plugin:2.5.3:check (default-cli) @ 
cloud-plugin-network-vsp ---
[INFO] BugInstance size is 0
[INFO] Error size is 0
[INFO] No errors/warnings found

* rat check failed
  
plugins/network-elements/nuage-vsp/src/net/nuage/vsp/acs/NuageVspPluginClientLoader.java
  
plugins/network-elements/nuage-vsp/test/com/cloud/network/manager/NuageVspManagerTest.java
  
plugins/network-elements/nuage-vsp/test/com/cloud/network/sync/NuageVspSyncTest.java


These are the last two remaining items. 
1) Can you add the following to the pom.xml for the plugin in the build/plugins 
section and fix any detected license issues?
  
com.mycila
license-maven-plugin

  
cloudstack-checklicence
process-classes

  check

  

  

2) It would be nice if you could add the plugin to the noredist build as 
discussed on the dev list, but i can do that as well if you like. 

When the license is fixed i can merge it into master. If you could create the 
next diff with git format-patch that would be great, but i can work with the 
current format as well.

Cheers,

Hugo



- Hugo Trippaers


On July 18, 2014, 3:15 a.m., Suresh Ramamurthy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23282/
> ---
> 
> (Updated July 18, 2014, 3:15 a.m.)
> 
> 
> Review request for cloudstack, Alena Prokharchyk, Hugo Trippaers, and Sheng 
> Yang.
> 
> 
> Bugs: CLOUDSTACK-6845
> https://issues.apache.org/jira/browse/CLOUDSTACK-6845
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> This is first code drop for NuageVsp Network plugin support that will bring 
> the Nuage VSP network virtualization technology to CloudStack.
> 
> We need a new branch to checkin the fixes once the review is done. Please 
> create a new branch for NuageVsp plugin.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/event/EventTypes.java 71bfdb6 
>   api/src/com/cloud/network/Network.java 885bffe 
>   api/src/com/cloud/network/Networks.java 1e4d229 
>   api/src/com/cloud/network/PhysicalNetwork.java 8cc214e 
>   client/WEB-INF/classes/resources/messages.properties b192cb0 
>   client/WEB-INF/classes/resources/messages_zh_CN.properties 1ec4e95 
>   client/pom.xml 46933d9 
>   client/tomcatconf/commands.properties.in b9ac27b 
>   
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/OvsVifDriver.java
>  8e4c710 
>   
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
>  0922765 
>   
> plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
>  5881d68 
>   plugins/network-elements/nuage-vsp/pom.xml PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/resources/META-INF/cloudstack/vsp/module.properties
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/resources/META-INF/cloudstack/vsp/spring-vsp-context.xml
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/StartupVspCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/VspResourceAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/VspResourceCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyAclRuleVspAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyAclRuleVspCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyStaticNatVspAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyStaticNatVspCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ShutDownVpcVspAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ShutDownVpcVspCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/DeallocateVmVspAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/DeallocateVmVspCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ImplementNetworkVspAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ImplementNetworkVs

Re: Review Request 23677: CLOUDSTACK-7024: Resolved cleanup issue in test script

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23677/#review48122
---


Commit ec49669f1cf525b207889ae13a8a2b01a0271933 in cloudstack's branch 
refs/heads/4.4-forward from Ashutosh K
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=ec49669 ]

CLOUDSTACK-7024: Resolved cleanup issue in test script


- ASF Subversion and Git Services


On July 18, 2014, 12:08 p.m., Ashutosh Kelkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23677/
> ---
> 
> (Updated July 18, 2014, 12:08 p.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-7024
> https://issues.apache.org/jira/browse/CLOUDSTACK-7024
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Resolved issue related to order of cleanup items. The project must be removed 
> before the account which manages it.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_project_usage.py 5e0dda5 
> 
> Diff: https://reviews.apache.org/r/23677/diff/
> 
> 
> Testing
> ---
> 
> Yes.
> 
> Log:
> Test Upload/ delete a template and verify correct usage is generated ... === 
> TestName: test_01_template_usage | Status : SUCCESS ===
> ok
> 
> --
> Ran 1 test in 285.451s
> 
> OK
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>

Re: Review Request 23677: CLOUDSTACK-7024: Resolved cleanup issue in test script

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23677/#review48124
---


Commit 5f87056e950e0cae042d0c836f10a091800b8dbc in cloudstack's branch 
refs/heads/master from Ashutosh K
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5f87056 ]

CLOUDSTACK-7024: Resolved cleanup issue in test script


- ASF Subversion and Git Services


On July 18, 2014, 12:08 p.m., Ashutosh Kelkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23677/
> ---
> 
> (Updated July 18, 2014, 12:08 p.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-7024
> https://issues.apache.org/jira/browse/CLOUDSTACK-7024
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Resolved issue related to order of cleanup items. The project must be removed 
> before the account which manages it.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_project_usage.py 5e0dda5 
> 
> Diff: https://reviews.apache.org/r/23677/diff/
> 
> 
> Testing
> ---
> 
> Yes.
> 
> Log:
> Test Upload/ delete a template and verify correct usage is generated ... === 
> TestName: test_01_template_usage | Status : SUCCESS ===
> ok
> 
> --
> Ran 1 test in 285.451s
> 
> OK
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>

RE: [PROPOSAL] Adding a plugin to check the password strength of all users

[Demetrius Tsitrelis]

Will the plugin merely show the strength of the password or will the plugin 
prevent the use of weak passwords?


From: Damoder Reddy [damoder.re...@citrix.com]
Sent: Thursday, July 17, 2014 11:02 PM
To: dev@cloudstack.apache.org
Subject: [PROPOSAL] Adding a plugin to check the password strength of all users

Hi all,

I am thinking to add a plugin which enables to check the password strength of a 
user while setting/resetting the password for that user.
why as a plugin because different companies may have a different rule sets to 
check the password strength.

The default implementation will have the password strength calculation based on 
the following parameters
1. Length of the password
2. Number of Character Sets involved in the password defined. For ex, Upper 
Case Letter, Lower Case letter, Digits and special character set.

Ay suggestions/Comments?

Thanks
Damoder

Review Request 23679: CLOUDSTACK-7130: Tagging failed test cases with product bug Id

[Gaurav Aradhye]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23679/
---

Review request for cloudstack and Girish Shilamkar.


Bugs: CLOUDSTACK-7130
https://issues.apache.org/jira/browse/CLOUDSTACK-7130


Repository: cloudstack-git


Description
---

Tagging failed test cases with product bug Id.


Diffs
-

  test/integration/smoke/test_volumes.py 7fbcc21 

Diff: https://reviews.apache.org/r/23679/diff/


Testing
---


Thanks,

Gaurav Aradhye

rfc: newsystemvm

[Leo Simons]

Hey folks,

https://github.com/schubergphilis/cloudstack/commit/f125f1564e8921def00dc0235ecca51470a2a22e
https://github.com/schubergphilis/cloudstack/tree/f125f1564e8921def00dc0235ecca51470a2a22e/tools/appliance

This started out as wanting the systemvm build to take 
systemvm/patches/debian/{debian,vpn} from the local machine/branch, rather than 
downloading from the apache git master [1]. In working out how on earth to get 
veewee to do that cleanly (hint: you can’t, hence resorting to shar usage) I 
got quite frustrated with the image rebuild times.

It so happens that veewee has a --skip-to-postinstall instruction which is 
_quite_ useful while debugging these scripts. To get that working requires the 
post install steps to be retryable/convergent. Of course, our existing scripts 
weren’t set up for that. So I had to add a bunch of tests whether changes had 
applied already. Which implied a pretty significant refactor.

I think I was careful enough and I expect this new template will work just as 
well as the old one. This is a change that we can (and probably should?) merge 
to master independently of the redundant VPC work (though the `apt-get install 
chef` would need to be taken out). But, given how big of a chunk of code has 
changed here, before upstreaming (a version of) this to apache we (I) need to 
do more testing. So for now I’ve put this change next to the existing 
definitions rather than replace ‘em, to not block anything else.

Comments/thoughts?


cheers,


Leo


[1] 
https://github.com/schubergphilis/cloudstack/blob/master/tools/appliance/definitions/systemvmtemplate/postinstall.sh#L228

Begin forwarded message:
...
>M tools/appliance/build.sh
...
>A tools/appliance/definitions/newsystemvm/apt_upgrade.sh
>A tools/appliance/definitions/newsystemvm/authorized_keys.sh
>A tools/appliance/definitions/newsystemvm/build_time.sh
>A tools/appliance/definitions/newsystemvm/cleanup.sh
>A tools/appliance/definitions/newsystemvm/configure_acpid.sh
>A tools/appliance/definitions/newsystemvm/configure_conntrack.sh
>A tools/appliance/definitions/newsystemvm/configure_grub.sh
>A tools/appliance/definitions/newsystemvm/configure_locale.sh
>A tools/appliance/definitions/newsystemvm/configure_login.sh
>A tools/appliance/definitions/newsystemvm/configure_networking.sh
>A tools/appliance/definitions/newsystemvm/configure_systemvm_services.sh
>A tools/appliance/definitions/newsystemvm/definition.rb
>A tools/appliance/definitions/newsystemvm/install_systemvm_packages.sh
>A tools/appliance/definitions/newsystemvm/preseed.cfg
>A tools/appliance/definitions/newsystemvm/zerodisk.sh
>A tools/appliance/shar_cloud_scripts.sh
>A tools/appliance/test.sh
...
> Work in progress to rewrite systemvm box definition in clean code.
> 
> * Refactor build.sh to use functions and pretty logging.
> * Add a new test.sh which tries several different build.sh invocations.
> * Add a new 'debianbase' definition which is just the basic debian box (no 
> systemvm functionality). This is used for testing.
> * Add a new 'newsystemvm' definition which is a work-in-progress replacement 
> of the 'systemvmtemplate' definition:
> ** reduce duplication between preseed.cfg and postinstall.sh
> ** remove duplication between postinstall.sh and cloud-scripts
> ** install cloud-scripts from current working copy instead of tying to a 
> download of the apache master branch
> ** split up postinstall.sh into small utility scripts and clean up that code
> ** clean up preseed.cfg to match current veewee/debian best practices and 
> remove cruft

Re: Review Request 23679: CLOUDSTACK-7130: Tagging failed test cases with product bug Id

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23679/#review48125
---


Commit 24da72f37395a6bb612ea1d073db0155289cf000 in cloudstack's branch 
refs/heads/master from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=24da72f ]

CLOUDSTACK-7130: Adding BugId to failed test cases


- ASF Subversion and Git Services


On July 18, 2014, 1:52 p.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23679/
> ---
> 
> (Updated July 18, 2014, 1:52 p.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-7130
> https://issues.apache.org/jira/browse/CLOUDSTACK-7130
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Tagging failed test cases with product bug Id.
> 
> 
> Diffs
> -
> 
>   test/integration/smoke/test_volumes.py 7fbcc21 
> 
> Diff: https://reviews.apache.org/r/23679/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Review Request #22863 , #23314 : Brocade Plugin review request...

[Ritu Sabharwal]

Hi Hugo,

I have fixed the 3 items as proposed by you:

1.   Added the unit tests

2.   Added integration test

3.   Removed the configuration from properties file to networks service 
provider configuration using APIs or GUI.

Can you please review the plugin code so that we can make it by July 19th.

Thanks for reviewing the plugin and supporting us.

Thanks & Regards,
Ritu S.

Re: vms stopped while restarted by user

[Tomasz Zięba]

Hello,

After analyzing the code, I am convinced that 10 minutes is indeed
associated with the parameters that gave Daan, and specifically in:

class: HighAvailabilityManagerImpl.java

function: protected Long stopVM(final HaWorkVO work) throws
ConcurrentOperationException
..
work.setTimesTried(work.getTimesTried() + 1);
if (s_logger.isDebugEnabled()) {
s_logger.debug("Stop was unsuccessful.  Rescheduling");
}
return (System.currentTimeMillis() >> 10) + _stopRetryInterval;
.

where:
value = params.get("stop.retry.interval");
_stopRetryInterval = NumbersUtil.parseInt(value, 10 * 60);



However, I believe that the problem lies elsewhere than in the wrong value
of these parameters.
In any case, where machine has a problem with Reschduling, HAworker process
is preceded by message, ie:

2014-07-17 12:43:27,800 DEBUG [vm.dao.VMInstanceDaoImpl]
(HA-Worker-0:work-2824) Unable to update VM[User|centos-min-10G-test]: DB
Data={Host=null; State=Stopped; updated=5; time=Thu Jul 17 12:43:27 CEST
2014} New Data: {Host=null; State=Stopped; updated=5; time=Thu Jul 17
12:43:27 CEST 2014} Stale Data: {Host=58; State=Stopping; updated=4;
time=Thu Jul 17 12:43:15 CEST 2014}

For entry to the log corresponds to the:

class: VMInstanceDaoImpl.java
function: public boolean updateState(State oldState, Event event, State
newState, VirtualMachine vm, Object opaque)

However, at this moment we can not diagnose what is the cause.

Maybe someone has an idea?




2014-07-15 21:12 GMT+02:00 Chiradeep Vittal :

>  Agree. Not sure why your system is so slow, but these parameters should
> help
>
>   From: Daan Hoogland 
> Reply-To: "dev@cloudstack.apache.org" 
> Date: Tuesday, July 15, 2014 at 6:29 AM
> To: Tomasz Zięba 
> Cc: "dev@cloudstack.apache.org" , Marcus
> Sorensen , Damoder Reddy 
> Subject: vms stopped while restarted by user
>
>   Tomasz,
>
>  I can only fantasize on the full rationale of the implementation of
> the retry but in general it makes sense to me. A job has a time to try
> and a times tried field. the worker manager has time to sleep and max
> retries. As you can see below these are read from the configuration:
>
>  value = params.get("time.to.sleep");
> _timeToSleep = NumbersUtil.parseInt(value, 60) * 1000;
>
>  value = params.get("max.retries");
> _maxRetries = NumbersUtil.parseInt(value, 5);
>
>  there is also
>
>  value = params.get("stop.retry.interval");
> _stopRetryInterval = NumbersUtil.parseInt(value, 10 * 60);
>
>
>  The time.to.sleep and stop.retry.interval seem to jointly explain the
> ten minute scenario you described in the bug report. They don't do
> completely as some of the handling of the values is based on
> bitshifting and not on datetime calculus (using mixed factors of
> 1000,60,60,24 and 365.25)
> You can try and play with those to tune your setting. In any case
> looking at the vm to decide to restart the vm is not usefull as
> Cloudstack will do some cleanup after stopping the instance. You
> should really wait untill cloudstack reports on the job with either
> succes or error.
>
>  On Tue, Jul 15, 2014 at 3:12 PM, Tomasz Zięba 
> wrote:
>
> Hello,
>
>  The user does not receive confirmation of the operation.
> From the point of view of user input it looks like the machine itself
> stopped.
>
>  As you can see in the logs, the ACS explicitly sends stop command, as if
> they press the Stop button from the GUI, so it is aware of the action from
> the perspective of the ACS / MS.
>
>  I can not point out which component may be responsible for it.
> We have tried to analyze the code to understand what is happening,
> but the part of the code related to HAWorker is not very clear.
> Unfortunately we could not find online any assumptions on the level of
> architecture / design of HAWorker.
>
>  Maybe method of small steps help find a solution.
> First a small question: why HAWorker performs reschedule. What was the idea
> for such action.
>
>
>
>
>  2014-07-15 14:26 GMT+02:00 Daan Hoogland :
>
>  Tomasz,
>
>  As I understand the issue this is what happens:
>
>  The user stops the vm from the UI
> The MS sends the stop command to the machine
> The machine stops and takes a long time for it
> The MS reschedules the stop
> Then machine stops
> the user starts the machine
> the MS get by stopping the machine
>
>  Did the user ever get a confirmation that the machine was stopped or
> that stopping failed? If so, this is the bug, as it seems the MS works
> as designed.
>
>  Don't get me wrong; I am trying to figure out a path to a solution for
> you. I am not convinced there is a bug in the management server
> though. That doesn't mean it can be in cloudstack over all. Either at
> a design level or for instance in some inter-process communication.
>
>  kind regards,
> Daan Hoogland
>
>
>  On Fri, Jul 11, 2014 at 2:45 PM, Tomasz Zięba 
> wrote:
> > Hello,
> >
> > We are waiting for the patch with longingly.
> >
> > Error associated with self-clos

Re: [PROPOSAL] Adding a plugin to check the password strength of all users

[Damoder Reddy]

Will show the strength of the password as well.


On 18-Jul-2014, at 6:53 pm, Demetrius Tsitrelis 
 wrote:

> Will the plugin merely show the strength of the password or will the plugin 
> prevent the use of weak passwords?
> 
> 
> From: Damoder Reddy [damoder.re...@citrix.com]
> Sent: Thursday, July 17, 2014 11:02 PM
> To: dev@cloudstack.apache.org
> Subject: [PROPOSAL] Adding a plugin to check the password strength of all 
> users
> 
> Hi all,
> 
> I am thinking to add a plugin which enables to check the password strength of 
> a user while setting/resetting the password for that user.
> why as a plugin because different companies may have a different rule sets to 
> check the password strength.
> 
> The default implementation will have the password strength calculation based 
> on the following parameters
> 1. Length of the password
> 2. Number of Character Sets involved in the password defined. For ex, Upper 
> Case Letter, Lower Case letter, Digits and special character set.
> 
> Ay suggestions/Comments?
> 
> Thanks
> Damoder

RE: [PROPOSAL] Adding a plugin to check the password strength of all users

[Demetrius Tsitrelis]

So the plugin will show the strength AND it will enforce the strength when a 
user is created or updates his password.  Will it be possible for an 
administrator to disable either of these?

For both of those capabilities is the plugin's behavior configurable for 
different authentication encoders?  That is, could I have one set of rules for 
the SHA256 authenticator and a different set of rules for the MD5 authenticator?

-Original Message-
From: Damoder Reddy [mailto:damoder.re...@citrix.com] 
Sent: Friday, July 18, 2014 9:13 AM
To: dev@cloudstack.apache.org
Subject: Re: [PROPOSAL] Adding a plugin to check the password strength of all 
users

Will show the strength of the password as well.


On 18-Jul-2014, at 6:53 pm, Demetrius Tsitrelis 
 wrote:

> Will the plugin merely show the strength of the password or will the plugin 
> prevent the use of weak passwords?
> 
> 
> From: Damoder Reddy [damoder.re...@citrix.com]
> Sent: Thursday, July 17, 2014 11:02 PM
> To: dev@cloudstack.apache.org
> Subject: [PROPOSAL] Adding a plugin to check the password strength of 
> all users
> 
> Hi all,
> 
> I am thinking to add a plugin which enables to check the password strength of 
> a user while setting/resetting the password for that user.
> why as a plugin because different companies may have a different rule sets to 
> check the password strength.
> 
> The default implementation will have the password strength calculation 
> based on the following parameters 1. Length of the password 2. Number 
> of Character Sets involved in the password defined. For ex, Upper Case 
> Letter, Lower Case letter, Digits and special character set.
> 
> Ay suggestions/Comments?
> 
> Thanks
> Damoder

Re: rfc: newsystemvm

[Chiradeep Vittal]

Thanks Leo. Can you summarize the changes (it is a lot of changes)

From: Leo Simons mailto:lsim...@schubergphilis.com>>
Reply-To: "dev@cloudstack.apache.org" 
mailto:dev@cloudstack.apache.org>>
Date: Friday, July 18, 2014 at 7:42 AM
To: int-toolkit 
mailto:int-tool...@schubergphilis.com>>, 
"dev@cloudstack.apache.org" 
mailto:dev@cloudstack.apache.org>>
Subject: rfc: newsystemvm

Hey folks,

https://github.com/schubergphilis/cloudstack/commit/f125f1564e8921def00dc0235ecca51470a2a22e
https://github.com/schubergphilis/cloudstack/tree/f125f1564e8921def00dc0235ecca51470a2a22e/tools/appliance

This started out as wanting the systemvm build to take 
systemvm/patches/debian/{debian,vpn} from the local machine/branch, rather than 
downloading from the apache git master [1]. In working out how on earth to get 
veewee to do that cleanly (hint: you can’t, hence resorting to shar usage) I 
got quite frustrated with the image rebuild times.

It so happens that veewee has a --skip-to-postinstall instruction which is 
_quite_ useful while debugging these scripts. To get that working requires the 
post install steps to be retryable/convergent. Of course, our existing scripts 
weren’t set up for that. So I had to add a bunch of tests whether changes had 
applied already. Which implied a pretty significant refactor.

I think I was careful enough and I expect this new template will work just as 
well as the old one. This is a change that we can (and probably should?) merge 
to master independently of the redundant VPC work (though the `apt-get install 
chef` would need to be taken out). But, given how big of a chunk of code has 
changed here, before upstreaming (a version of) this to apache we (I) need to 
do more testing. So for now I’ve put this change next to the existing 
definitions rather than replace ‘em, to not block anything else.

Comments/thoughts?


cheers,


Leo


[1] 
https://github.com/schubergphilis/cloudstack/blob/master/tools/appliance/definitions/systemvmtemplate/postinstall.sh#L228

Begin forwarded message:
...
M tools/appliance/build.sh
...
A tools/appliance/definitions/newsystemvm/apt_upgrade.sh
A tools/appliance/definitions/newsystemvm/authorized_keys.sh
A tools/appliance/definitions/newsystemvm/build_time.sh
A tools/appliance/definitions/newsystemvm/cleanup.sh
A tools/appliance/definitions/newsystemvm/configure_acpid.sh
A tools/appliance/definitions/newsystemvm/configure_conntrack.sh
A tools/appliance/definitions/newsystemvm/configure_grub.sh
A tools/appliance/definitions/newsystemvm/configure_locale.sh
A tools/appliance/definitions/newsystemvm/configure_login.sh
A tools/appliance/definitions/newsystemvm/configure_networking.sh
A tools/appliance/definitions/newsystemvm/configure_systemvm_services.sh
A tools/appliance/definitions/newsystemvm/definition.rb
A tools/appliance/definitions/newsystemvm/install_systemvm_packages.sh
A tools/appliance/definitions/newsystemvm/preseed.cfg
A tools/appliance/definitions/newsystemvm/zerodisk.sh
A tools/appliance/shar_cloud_scripts.sh
A tools/appliance/test.sh
...
Work in progress to rewrite systemvm box definition in clean code.
* Refactor build.sh to use functions and pretty logging.
* Add a new test.sh which tries several different build.sh invocations.
* Add a new 'debianbase' definition which is just the basic debian box (no 
systemvm functionality). This is used for testing.
* Add a new 'newsystemvm' definition which is a work-in-progress replacement of 
the 'systemvmtemplate' definition:
** reduce duplication between preseed.cfg and postinstall.sh
** remove duplication between postinstall.sh and cloud-scripts
** install cloud-scripts from current working copy instead of tying to a 
download of the apache master branch
** split up postinstall.sh into small utility scripts and clean up that code
** clean up preseed.cfg to match current veewee/debian best practices and 
remove cruft

Re: Infiniband support

[Chiradeep Vittal]

Is this for storage (presumably)? You can use a “pre-setup” storage

From: Dan Crowe mailto:dan.cr...@shapeblue.com>>
Reply-To: "dev@cloudstack.apache.org" 
mailto:dev@cloudstack.apache.org>>
Date: Wednesday, July 16, 2014 at 3:49 AM
To: "dev@cloudstack.apache.org" 
mailto:dev@cloudstack.apache.org>>
Subject: Infiniband support

Hi all

I have a query re support for Infiniband on ACS - are there any plans to 
support moving forward?  I did see some mails on the list, but am unsure of 
current status?

Thanks

Dan

Find out more about ShapeBlue and our range of CloudStack related services

IaaS Cloud Design & Build
CSForge - rapid IaaS deployment framework
CloudStack Consulting
CloudStack Infrastructure 
Support
CloudStack Bootcamp Training Courses

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England & Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company 
registered by The Republic of South Africa and is traded under license from 
Shape Blue Ltd. ShapeBlue is a registered trademark.

Re: Infiniband support

[ilya musayev]

Hi Dan

In what sense do you see support for infiniband and cloudstack?

CloudStack manages pre-set infrastructure. Infiniband is usually 
something that you setup initially, and then hopefully you never have to 
touch it again - until new addition comes thru.


Regards
ilya
On 7/16/14, 3:49 AM, Dan Crowe wrote:

Hi all

I have a query re support for Infiniband on ACS - are there any plans to 
support moving forward?  I did see some mails on the list, but am unsure of 
current status?

Thanks

Dan

Find out more about ShapeBlue and our range of CloudStack related services

IaaS Cloud Design & Build
CSForge - rapid IaaS deployment framework
CloudStack Consulting
CloudStack Infrastructure 
Support
CloudStack Bootcamp Training Courses

This email and any attachments to it may be confidential and are intended solely 
for the use of the individual to whom it is addressed. Any views or opinions 
expressed are solely those of the author and do not necessarily represent those of 
Shape Blue Ltd or related companies. If you are not the intended recipient of this 
email, you must neither take any action based upon its contents, nor copy or show 
it to anyone. Please contact the sender if you believe you have received this email 
in error. Shape Blue Ltd is a company incorporated in England & Wales. 
ShapeBlue Services India LLP is a company incorporated in India and is operated 
under license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company 
incorporated in Brasil and is operated under license from Shape Blue Ltd. ShapeBlue 
SA Pty Ltd is a company registered by The Republic of South Africa and is traded 
under license from Shape Blue Ltd. ShapeBlue is a registered trademark.

Re: Review Request 23617: Add Nic UUID to the context so that we can read the same in event bus after create a nic

[Nitin Mehta]

> On July 17, 2014, 4:55 p.m., Nitin Mehta wrote:
> > server/src/com/cloud/vm/UserVmManagerImpl.java, line 960
> > 
> >
> > Why is it made create=true when it is not a BaseAyncCreate cmd ? 
> > create=true should be added only when its invoked through the create() 
> > method of a  BaseAyncCreate cmd
> 
> Damodar Reddy Talakanti wrote:
> We can not extend AddNicToVMCmd by BaseAsyncCreate cmd as it is doing 
> many checks before creating the entry NIC. As it is creating entity did made 
> create=true there.

Many checks is not a problem as long as they are DB checks. Do note we make a 
command async generally because it is contacting the resource and can take 
time. If it is just DB checks I would think we can make the command 
BaseAsyncCreate. Also best that you review with Kishan if create=true will 
generate all the events (scheduled, started, completed) an async command 
generates 


- Nitin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23617/#review48016
---


On July 17, 2014, 4:43 p.m., Damodar Reddy Talakanti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23617/
> ---
> 
> (Updated July 17, 2014, 4:43 p.m.)
> 
> 
> Review request for cloudstack and Nitin Mehta.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Putting the create event into event bus for addNicToVirutalMachine command 
> explicitly as we can not use BaseAsyncCreateCommand.We can not extend this 
> with BaseAsyncCreateCmd due to the checks we do before creating the nic.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/event/EventTypes.java 71bfdb6 
>   server/src/com/cloud/vm/UserVmManagerImpl.java d0bc186 
> 
> Diff: https://reviews.apache.org/r/23617/diff/
> 
> 
> Testing
> ---
> 
> Tested against the following setup:
> 
> 1. XenServer 6.2
> 2. Master Branch
> 
> 
> Thanks,
> 
> Damodar Reddy Talakanti
> 
>

Daily CI test summary 07/18/14

[Rayees Namathponnan]

Hi All,

We enabled KVM in our CI environment, you can see the current status at 
https://cwiki.apache.org/confluence/x/RAGTAg

Simulator 100% pass
KVM   9 failures
Xen   2 failures

There is no new issue reported with lastets build, below falures are known 
issues and details are below


Simulator
-
Run No  Total Ex  Failed
1395  62   0
1385  62   0
1370  62   0


KVM
---

Run No  Total Ex  Failed
1393  27   9   1)TestCreateVolume.test_01_create_volume 
  CLOUDSTACK-7110
  TestVolumes.test_02_attach_volume
  TestVolumes.test_06_download_detached_volume
  TestVolumes.test_07_resize_fail
2) TestISO 
CLOUDSTACK-6933
3) TestTemplates.test_06_copy_template 
Need to look
4) test_deploy_vm_root_resize  
Need to look
5) test_01_primary_storage_iscsi   
CLOUDSTACK-7074



Xen
---
Run No  Total   Ex   Failed
1401  29   2   ISO failure (CLOUDSTACK-7074)

TestPrimaryStorageServices.test_01_primary_storage_iscsi (CLOUDSTACK-7074)
1386  29   2   ISO failure (CLOUDSTACK-6933)

TestPrimaryStorageServices.test_01_primary_storage_iscsi (CLOUDSTACK-7074)
1377  29   2   ISO failure (CLOUDSTACK-7074)

TestPrimaryStorageServices.test_01_primary_storage_iscsi (CLOUDSTACK-7074)

Regards,
Rayees

Re: Review Request 23282: CLOUDSTACK-6845 : First Code drop for NuageVsp Network plugin

[Suresh Ramamurthy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23282/
---

(Updated July 19, 2014, 12:49 a.m.)


Review request for cloudstack, Alena Prokharchyk, Hugo Trippaers, and Sheng 
Yang.


Changes
---

Hi Hugo,

I have fixed the license header. I ran mvn license:check 
-Dlicense.header=LICENSE.header and also mvn license:format 
-Dlicense.header=LICENSE.header to make sure every thing is fine.

I have also done changes for noredist. Please review it, hopefully I have 
modified all the needed pom.xml files.
I had following questions regarding compiling only nuagevsp plugin
  a) To build only nuagevsp, is below command correct. 
 mvn clean install -P developer,nuagevsp

  b) To run client with nuagevsp in development setup, is the below correct:
 mvn -pl :cloud-client-ui jetty:run -P nuagevsp

  c) To create rpm using package.sh, we need to pass NOREDIST option. But, this 
requires all the dependent jar file to be copied.
 Please correct me if my understanding is wrong. How do we build rpm with 
only nuagevsp plugin?

I tried to create a patch, but it created lot of files. So, I attached the diff 
files. Sorry for the inconvenience.

Thanks for helping us,
Suresh Ramamurthy
 


Bugs: CLOUDSTACK-6845
https://issues.apache.org/jira/browse/CLOUDSTACK-6845


Repository: cloudstack-git


Description
---

This is first code drop for NuageVsp Network plugin support that will bring the 
Nuage VSP network virtualization technology to CloudStack.

We need a new branch to checkin the fixes once the review is done. Please 
create a new branch for NuageVsp plugin.


Diffs (updated)
-

  api/src/com/cloud/event/EventTypes.java 71bfdb6 
  api/src/com/cloud/network/Network.java 885bffe 
  api/src/com/cloud/network/Networks.java 1e4d229 
  api/src/com/cloud/network/PhysicalNetwork.java 8cc214e 
  client/WEB-INF/classes/resources/messages.properties b192cb0 
  client/WEB-INF/classes/resources/messages_zh_CN.properties 1ec4e95 
  client/pom.xml 46933d9 
  client/tomcatconf/commands.properties.in b9ac27b 
  
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/OvsVifDriver.java 
8e4c710 
  
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 0922765 
  
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
 a2b9625 
  plugins/network-elements/nuage-vsp/pom.xml PRE-CREATION 
  
plugins/network-elements/nuage-vsp/resources/META-INF/cloudstack/vsp/module.properties
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/resources/META-INF/cloudstack/vsp/spring-vsp-context.xml
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/StartupVspCommand.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/VspResourceAnswer.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/VspResourceCommand.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyAclRuleVspAnswer.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyAclRuleVspCommand.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyStaticNatVspAnswer.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyStaticNatVspCommand.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ShutDownVpcVspAnswer.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ShutDownVpcVspCommand.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/DeallocateVmVspAnswer.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/DeallocateVmVspCommand.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ImplementNetworkVspAnswer.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ImplementNetworkVspCommand.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ReleaseVmVspAnswer.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ReleaseVmVspCommand.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ReserveVmInterfaceVspAnswer.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ReserveVmInterfaceVspCommand.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/TrashNetworkVspAnswer.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/TrashNetworkVspCommand.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/sync/SyncVspAnswer.java
 PRE-CREATION 
  
plugins/network-el