Hi Ian, 

The commit was made only in 4.4 and not in master. 
Can you cherry pick the same to master.

Thanks,
Harikrishna
On 26-Jun-2014, at 12:23 am, Ian Duffy <i...@ianduffy.ie> wrote:

> Just pushed a change for this to the 4.4-forward branch.
> 
> Daan, will you review / cherrypick? 96412e3e58fd1ced9d269e4552aaa6410bedf556
> 
> Testing done:
> 
> Brought up simulator.
> 
> Changed password flag for the builtin template.
> 
> Brought up VM, password was displayed at length of 6. Stopped the VM, reset
> the password, new password was displayed at length of 6.
> 
> Went into global settings, modified the value for vm.password.length to 20.
> Restarted the management server.
> Created a new VM, password was displayed at length of 20. Stopped the VM,
> reset the password, new password was displayed at length of 20.
> 
> Thanks,
> 
> Ian
> 
> On 25 June 2014 18:50, Nux! <n...@li.nux.ro> wrote:
> 
>> Volunteer to do it in time for 4.4?
>> 
>> Lucian
>> 
>> --
>> Sent from the Delta quadrant using Borg technology!
>> 
>> Nux!
>> www.nux.ro
>> 
>> 
>> ----- Original Message -----
>> From: "ilya musayev" <ilya.mailing.li...@gmail.com>
>> To: dev@cloudstack.apache.org
>> Sent: Wednesday, 25 June, 2014 6:30:25 PM
>> Subject: Re: What to modify to increase instance password length?
>> 
>> You should ask if this can be done as global setting variable - not hard
>> coded.
>> 
>> This should be an easy one.
>> 
>> On 6/25/14, 10:14 AM, Nux! wrote:
>>> I should submit a bug report to rewrite ACS in a scripting language.
>>> 
>>> Cheers :)
>>> 
>>> --
>>> Sent from the Delta quadrant using Borg technology!
>>> 
>>> Nux!
>>> www.nux.ro
>>> 
>>> 
>>> ----- Original Message -----
>>> From: "Ian Duffy" <i...@ianduffy.ie>
>>> To: "CloudStack Dev" <dev@cloudstack.apache.org>
>>> Sent: Wednesday, 25 June, 2014 6:11:23 PM
>>> Subject: Re: What to modify to increase instance password length?
>>> 
>>> Afaik yes. (Will to be corrected on this but it appears to be hard coded)
>>> 
>>> 
>>> On 25 June 2014 18:06, Nux! <n...@li.nux.ro> wrote:
>>> 
>>>> Thanks, Ian,
>>>> 
>>>> This means I need to modify the source, rebuild the RPMs and update,
>>>> right? (ie it's not something that I can just modify on the mgmt server
>>>> right now).
>>>> 
>>>> Lucian
>>>> 
>>>> --
>>>> Sent from the Delta quadrant using Borg technology!
>>>> 
>>>> Nux!
>>>> www.nux.ro
>>>> 
>>>> 
>>>> ----- Original Message -----
>>>> From: "Ian Duffy" <i...@ianduffy.ie>
>>>> To: "CloudStack Dev" <dev@cloudstack.apache.org>
>>>> Sent: Wednesday, 25 June, 2014 6:02:12 PM
>>>> Subject: Re: What to modify to increase instance password length?
>>>> 
>>>> Hi Lucian,
>>>> 
>>>> Take a look at server/src/com/cloud/server/ManagementServerImpl.java
>>>> 
>>>> Line 895 - 898
>>>> 
>>>>     @Override
>>>>     public String generateRandomPassword() {
>>>>         return PasswordGenerator.generateRandomPassword(6);
>>>>     }
>>>> 
>>>> 
>>>> 
>>>> 
>>>> On 25 June 2014 17:16, Nux! <n...@li.nux.ro> wrote:
>>>> 
>>>>> Hi guys,
>>>>> 
>>>>> Can anyone tell me which changes I should make in order to increase
>>>>> password length for instances?
>>>>> Currently I get something like "tK2yptbby" which might have been secure
>>>> 10
>>>>> years ago, but now it's way too short.
>>>>> 
>>>>> Thanks!
>>>>> Lucian
>>>>> 
>>>>> --
>>>>> Sent from the Delta quadrant using Borg technology!
>>>>> 
>>>>> Nux!
>>>>> www.nux.ro
>>>>> 
>>>>> 
>> 
>> 

Reply via email to