Re: [VOTE] Apache Cloudstack 4.4.0

[Erik Weber]

Considering adding centos 7 and rhel 7 while at it.

Erik
17. juli 2014 00:32 skrev "Marcus"  følgende:

> Yes, thats it. I have no idea how these mappings are created, but we need
> to ensure that both upgrades and new installs work
>
>
> On Wed, Jul 16, 2014 at 3:25 PM, Amogh Vasekar 
> wrote:
>
> > Hi,
> >
> > It is probably due to missing mapping in guest_os_hypervisor table. I had
> > created default entries for KVM using :
> > http://bit.ly/1rrML8n
> >
> > I can add the missing mapping to it.
> >
> > Thanks,
> > Amogh
> >
> > On 7/16/14 2:08 PM, "Marcus"  wrote:
> >
> > >I have another big issue to report with 4.4 in testing these artifacts.
> I
> > >register a CentOS 6.5 template, and launch VMs for it on KVM, and the
> > >disks/nics are not virtio.
> > >
> > >It looks like it is due to the following commit, which changes how the
> KVM
> > >agent determines if a template is PV enabled. The
> 'getPlatformEmulator()'
> > >is empty. I have reopened the associated bug and commented on it.
> > >
> > > -DiskDef.diskBus diskBusType =
> > >getGuestDiskModel(vmSpec.getOs());
> > >+DiskDef.diskBus diskBusType =
> > >getGuestDiskModel(vmSpec.getPlatformEmulator());
> > >
> > >commit 02bd3d0671b0cde46f8aa7892f20aa0bb0d48d1c
> > >Author: Amogh Vasekar 
> > >Date:   Wed May 7 15:16:55 2014 -0700
> > >
> > >CLOUDSTACK-6358: As a part of supporting dynamic guest OS defined by
> > >user, removing the hard-coded dependencies.
> > >This patch is for KVM
> > >
> > >1. Local testing on KVM
> > >2. Successfully got up system VMs
> > >3. Successfully created a CentOS VM
> > >4. Snapshots are not supported for KVM
> > >
> > > Signed off by :- Nitin Mehta
> > >
> > >
> > >
> > >On Wed, Jul 16, 2014 at 2:57 PM, Alena Prokharchyk <
> > >alena.prokharc...@citrix.com> wrote:
> > >
> > >> Daan, during 4.4 testing, I found the following regression bug:
> > >>
> > >> https://issues.apache.org/jira/browse/CLOUDSTACK-7118
> > >>
> > >>
> > >> "Unable to expunge vms in error state"
> > >>
> > >> There is a workaround for it - I¹ve mentioned it in the bug - yet
> > >>ideally
> > >> I would prefer the fix to be cherry-picked from 4.4-forward:
> > >>
> > >> commit 822b38761f1655ef3d5d3648985a197f5c2c1262
> > >>
> > >>
> > >>
> > >> Thank you,
> > >> Alena.
> > >>
> > >> On 7/16/14, 4:47 AM, "Daan Hoogland"  wrote:
> > >>
> > >> >On Thu, Jul 3, 2014 at 1:41 AM, Marcus  wrote:
> > >> >> I tested this release with
> > >> >> cherry-picking 2ec7359b4eb501b0d9e80ed87af7a54938e9d505 from
> > >> >>4.4-forward.
> > >> >
> > >> >
> > >> >I have cherry-picked and pushed. I will address the last remaining
> > >> >issue by editting the pom.xml from build_asf.sh and roll out a new
> RC.
> > >> >
> > >> >Hope all of you have continued testing and have now more issues to
> > >> >block this release
> > >> >
> > >> >--
> > >> >Daan
> > >>
> > >>
> >
> >
>

Review Request 23604: CLOUDSTACK-7108: Reading provisioningtype in library for sparse and fat provisioning types

[Ashutosh Kelkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23604/
---

Review request for cloudstack and Girish Shilamkar.


Bugs: CLOUDSTACK-7108
https://issues.apache.org/jira/browse/CLOUDSTACK-7108


Repository: cloudstack-git


Description
---

The provisioning type was passes through test case, but was not read in the 
library, hence not passed to the API. Hence the test cases failed as the 
provioning type would be thin by default instead of sparse/fat.


Diffs
-

  tools/marvin/marvin/lib/base.py fe257f0 

Diff: https://reviews.apache.org/r/23604/diff/


Testing
---

Yes.

Log:
Test to create disk offering ... === TestName: test_01_create_disk_offering | 
Status : SUCCESS ===
ok
Test to create  a sparse type disk offering ... === TestName: 
test_02_create_sparse_type_disk_offering | Status : SUCCESS ===
ok
Test to create  a sparse type disk offering ... === TestName: 
test_04_create_fat_type_disk_offering | Status : SUCCESS ===
ok
Test to update existing disk offering ... SKIP: skip
Test to delete disk offering ... SKIP: skip

--
Ran 5 tests in 0.301s

OK (SKIP=2)


Thanks,

Ashutosh Kelkar

Re: Review Request 23604: CLOUDSTACK-7108: Reading provisioningtype in library for sparse and fat provisioning types

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23604/#review47986
---


Commit 6f9b3cc9d13bd1bc002ce0afad3ed416b590f882 in cloudstack's branch 
refs/heads/master from Ashutosh K
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=6f9b3cc ]

CLOUDSTACK-7108: Reading provisioningtype for disk offering in base.py


- ASF Subversion and Git Services


On July 17, 2014, 7:25 a.m., Ashutosh Kelkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23604/
> ---
> 
> (Updated July 17, 2014, 7:25 a.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-7108
> https://issues.apache.org/jira/browse/CLOUDSTACK-7108
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> The provisioning type was passes through test case, but was not read in the 
> library, hence not passed to the API. Hence the test cases failed as the 
> provioning type would be thin by default instead of sparse/fat.
> 
> 
> Diffs
> -
> 
>   tools/marvin/marvin/lib/base.py fe257f0 
> 
> Diff: https://reviews.apache.org/r/23604/diff/
> 
> 
> Testing
> ---
> 
> Yes.
> 
> Log:
> Test to create disk offering ... === TestName: test_01_create_disk_offering | 
> Status : SUCCESS ===
> ok
> Test to create  a sparse type disk offering ... === TestName: 
> test_02_create_sparse_type_disk_offering | Status : SUCCESS ===
> ok
> Test to create  a sparse type disk offering ... === TestName: 
> test_04_create_fat_type_disk_offering | Status : SUCCESS ===
> ok
> Test to update existing disk offering ... SKIP: skip
> Test to delete disk offering ... SKIP: skip
> 
> --
> Ran 5 tests in 0.301s
> 
> OK (SKIP=2)
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>

Re: [DISCUSS]CLOUDSTACK-6191

[Daan Hoogland]

Seems like it could have been fixed with a smaller code replace but I
guess you are right.

@Santosh, Can you split your commit and reapply. At least chipping off
the BridgeVifDriver bit, but preferably all chopped up as other issues
will probably come up.

thanks,

On Wed, Jul 16, 2014 at 6:57 PM, Edison Su  wrote:
> The commit: a600d8408ea86782318139c17cf346c8497943d0, only fixes the "issues" 
> reported by coverity. Sometimes, coverity may report false alarm, that's what 
> happened in the code I reverted.
> If we want to make coverity happy, we'd better refactor the code in 
> BridgeVifDriver->Plug
>
>> -Original Message-
>> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
>> Sent: Tuesday, July 15, 2014 4:43 AM
>> To: dev; Edison Su; Santhosh Edukulla
>> Subject: Re: [DISCUSS]CLOUDSTACK-6191
>>
>> Edison,
>>
>> You reverted a600d8408ea86782318139c17cf346c8497943d0 in the end. The
>> code in there is solving a lot of resource problems. Did you pinpoint the 
>> exact
>> problem? I can not imagine that there is not a side effect that Santhosh 
>> didn't
>> know about and is undesirable that is really the really the root case. We
>> should find that and not just revert because an existing bug was uncovered.
>>
>>
>> On Mon, Jul 14, 2014 at 11:18 PM, Edison Su  wrote:
>> > Yoshikazu fixed the issue related to qemu-img which introduced by his
>> patch in cloudstack-6191.
>> > But there is another issue introduced by commit:
>> a600d8408ea86782318139c17cf346c8497943d0, which causes starting vm
>> failure.
>> > So I checked in a commit: e1095b0110f08fb0c7965f9cf293a6073bbce511, to
>> fix CLOUDSTACK-7051.
>> > So I think, both CLOUDSTACK-6191 and CLOUDSTACK-7051 should be fixed
>> now, no need to revert or change CLOUDSTACK-6191.
>> >
>> >> -Original Message-
>> >> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
>> >> Sent: Saturday, July 12, 2014 11:02 AM
>> >> To: dev
>> >> Subject: Re: [DISCUSS]CLOUDSTACK-6191
>> >>
>> >> -0 What does it fix and is the solution bonifide. We should fix the
>> >> test suite if it is. The test suite not working is not enough reason
>> >> to revert a commit, it should block the test-suite because the system
>> >> is broken, not because of the way the test suite works.
>> >>
>> >> Disclaimer: I do not know enough of KVM to make a judgement call. I
>> >> just got triggered by the motivation in the mail thread.
>> >>
>> >> On Sat, Jul 12, 2014 at 12:21 AM, Rayees Namathponnan
>> >>  wrote:
>> >> > +1 Revert now and enable after complete full test in KVM
>> >> >
>> >> > KVM automation blocked more than 7 days due to this defect
>> >> >
>> >> > https://issues.apache.org/jira/browse/CLOUDSTACK-7051
>> >> >
>> >> > Regards,
>> >> > Rayees
>> >> >
>> >> > -Original Message-
>> >> > From: Edison Su [mailto:edison...@citrix.com]
>> >> > Sent: Friday, July 11, 2014 2:49 PM
>> >> > To: dev@cloudstack.apache.org
>> >> > Subject: [DISCUSS]CLOUDSTACK-6191
>> >> >
>> >> > Move the discussion to the list about CloudStack-6191:
>> >> > Automation test is blocked by this bug, we need to find a solution.
>> >> > My
>> >> suggestion is sort-of-revert-the-patch, but still give admin the
>> >> opportunity to specify the way to optimize KVM volume creation. The
>> reasons:
>> >> >
>> >> > 1.   End user shouldn't care about how the volume is created, is it
>> >> sparse,flat/thin-provisoned or whatever technology used by
>> >> hypervisor. So we'd better not expose this option in disk offering.
>> >> >
>> >> > 2.It's true that admin does care about how the volume is 
>> >> > created, so
>> >> we can add a global configuration just for the kvm volume creation.
>> >> For vmware, the option is already there(vmware.create.full.clone to
>> >> control whether link clone or full clone is used to create volume).
>> >> We can add an option, something like kvm.qcow2.volume.create.options.
>> >> > Comments?
>> >>
>> >>
>> >>
>> >> --
>> >> Daan
>>
>>
>>
>> --
>> Daan



-- 
Daan

Review Request 23605: CLOUDSTACK-7107: Disabling failed test cases

[Gaurav Aradhye]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23605/
---

Review request for cloudstack and Girish Shilamkar.


Bugs: CLOUDSTACK-7074 and CLOUDSTACK-7107
https://issues.apache.org/jira/browse/CLOUDSTACK-7074
https://issues.apache.org/jira/browse/CLOUDSTACK-7107


Repository: cloudstack-git


Description
---

Disabling failed test cases on master.


Diffs
-

  test/integration/smoke/test_primary_storage.py 66aec59 
  test/integration/smoke/test_vm_life_cycle.py 240ab68 

Diff: https://reviews.apache.org/r/23605/diff/


Testing
---


Thanks,

Gaurav Aradhye

Re: [VOTE] Apache Cloudstack 4.4.0

[Daan Hoogland]

On Wed, Jul 16, 2014 at 10:57 PM, Alena Prokharchyk
 wrote:
> 822b38761f1655ef3d5d3648985a197f5c2c1262


is in

-- 
Daan

Re: Volume provisioning type in createDiskOffering API

[Gaurav Aradhye]

Issue has been resolved. May be I was on different branch.
Ashutosh has put a patch for original issue - fixing test script related to
smoke tests of this feature - https://reviews.apache.org/r/23604/

Regards,
Gaurav


On Wed, Jul 16, 2014 at 4:47 PM, Gaurav Aradhye 
wrote:

> Hi Punith,
>
> Thanks! I already referred to the feature specification. I can't find
> "provisioningtype" parameter in the request of createDiskOffering as
> mentioned in the FS. The smoke tests have been added for this feature in
> master branch and those are failing currently.
>
> Regards,
> Gaurav
>
>
> On Wed, Jul 16, 2014 at 4:38 PM, Punith S  wrote:
>
>> hi gaurav,
>>
>> noji has written a document on this.
>> refer this link ->
>>
>> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Volume+provisioning+type+option
>>
>> thanks
>>
>>
>> On Wed, Jul 16, 2014 at 2:06 PM, Gaurav Aradhye <
>> gaurav.arad...@clogeny.com>
>> wrote:
>>
>> > Hi,
>> >
>> > I believe this feature is in master branch, but I don't see the
>> > "provisioningtype" parameter in createDiskOffering API. Any idea why? I
>> can
>> > see it defined in CreateDiskOfferingCmd.java file.
>> >
>> >
>> > Regards,
>> > Gaurav
>> >
>>
>>
>>
>> --
>> regards,
>>
>> punith s
>> cloudbyte.com
>>
>
>

Re: [VOTE] Apache Cloudstack 4.4.0

[Daan Hoogland]

Marcus, Amogh, WHat is the work to do and the ETA? As I read your
mail, it seems we are not going to revert but I have no idea on what a
forward fix would be. Just adding mappings to KVMGuestOsMapper?

@Marcus: is this regression? As in do I agree with you making this a
blocker. You seem to imply so and I want to read you write it;)

On Thu, Jul 17, 2014 at 9:14 AM, Erik Weber  wrote:
> Considering adding centos 7 and rhel 7 while at it.
>
> Erik
> 17. juli 2014 00:32 skrev "Marcus"  følgende:
>
>> Yes, thats it. I have no idea how these mappings are created, but we need
>> to ensure that both upgrades and new installs work
>>
>>
>> On Wed, Jul 16, 2014 at 3:25 PM, Amogh Vasekar 
>> wrote:
>>
>> > Hi,
>> >
>> > It is probably due to missing mapping in guest_os_hypervisor table. I had
>> > created default entries for KVM using :
>> > http://bit.ly/1rrML8n
>> >
>> > I can add the missing mapping to it.
>> >
>> > Thanks,
>> > Amogh
>> >
>> > On 7/16/14 2:08 PM, "Marcus"  wrote:
>> >
>> > >I have another big issue to report with 4.4 in testing these artifacts.
>> I
>> > >register a CentOS 6.5 template, and launch VMs for it on KVM, and the
>> > >disks/nics are not virtio.
>> > >
>> > >It looks like it is due to the following commit, which changes how the
>> KVM
>> > >agent determines if a template is PV enabled. The
>> 'getPlatformEmulator()'
>> > >is empty. I have reopened the associated bug and commented on it.
>> > >
>> > > -DiskDef.diskBus diskBusType =
>> > >getGuestDiskModel(vmSpec.getOs());
>> > >+DiskDef.diskBus diskBusType =
>> > >getGuestDiskModel(vmSpec.getPlatformEmulator());
>> > >
>> > >commit 02bd3d0671b0cde46f8aa7892f20aa0bb0d48d1c
>> > >Author: Amogh Vasekar 
>> > >Date:   Wed May 7 15:16:55 2014 -0700
>> > >
>> > >CLOUDSTACK-6358: As a part of supporting dynamic guest OS defined by
>> > >user, removing the hard-coded dependencies.
>> > >This patch is for KVM
>> > >
>> > >1. Local testing on KVM
>> > >2. Successfully got up system VMs
>> > >3. Successfully created a CentOS VM
>> > >4. Snapshots are not supported for KVM
>> > >
>> > > Signed off by :- Nitin Mehta
>> > >
>> > >
>> > >
>> > >On Wed, Jul 16, 2014 at 2:57 PM, Alena Prokharchyk <
>> > >alena.prokharc...@citrix.com> wrote:
>> > >
>> > >> Daan, during 4.4 testing, I found the following regression bug:
>> > >>
>> > >> https://issues.apache.org/jira/browse/CLOUDSTACK-7118
>> > >>
>> > >>
>> > >> "Unable to expunge vms in error state"
>> > >>
>> > >> There is a workaround for it - I¹ve mentioned it in the bug - yet
>> > >>ideally
>> > >> I would prefer the fix to be cherry-picked from 4.4-forward:
>> > >>
>> > >> commit 822b38761f1655ef3d5d3648985a197f5c2c1262
>> > >>
>> > >>
>> > >>
>> > >> Thank you,
>> > >> Alena.
>> > >>
>> > >> On 7/16/14, 4:47 AM, "Daan Hoogland"  wrote:
>> > >>
>> > >> >On Thu, Jul 3, 2014 at 1:41 AM, Marcus  wrote:
>> > >> >> I tested this release with
>> > >> >> cherry-picking 2ec7359b4eb501b0d9e80ed87af7a54938e9d505 from
>> > >> >>4.4-forward.
>> > >> >
>> > >> >
>> > >> >I have cherry-picked and pushed. I will address the last remaining
>> > >> >issue by editting the pom.xml from build_asf.sh and roll out a new
>> RC.
>> > >> >
>> > >> >Hope all of you have continued testing and have now more issues to
>> > >> >block this release
>> > >> >
>> > >> >--
>> > >> >Daan
>> > >>
>> > >>
>> >
>> >
>>



-- 
Daan

Re: Review Request 23604: CLOUDSTACK-7108: Reading provisioningtype in library for sparse and fat provisioning types

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23604/#review47988
---


Commit 6f9b3cc9d13bd1bc002ce0afad3ed416b590f882 in cloudstack's branch 
refs/heads/vpc-toolkit-hugo from Ashutosh K
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=6f9b3cc ]

CLOUDSTACK-7108: Reading provisioningtype for disk offering in base.py


- ASF Subversion and Git Services


On July 17, 2014, 7:25 a.m., Ashutosh Kelkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23604/
> ---
> 
> (Updated July 17, 2014, 7:25 a.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-7108
> https://issues.apache.org/jira/browse/CLOUDSTACK-7108
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> The provisioning type was passes through test case, but was not read in the 
> library, hence not passed to the API. Hence the test cases failed as the 
> provioning type would be thin by default instead of sparse/fat.
> 
> 
> Diffs
> -
> 
>   tools/marvin/marvin/lib/base.py fe257f0 
> 
> Diff: https://reviews.apache.org/r/23604/diff/
> 
> 
> Testing
> ---
> 
> Yes.
> 
> Log:
> Test to create disk offering ... === TestName: test_01_create_disk_offering | 
> Status : SUCCESS ===
> ok
> Test to create  a sparse type disk offering ... === TestName: 
> test_02_create_sparse_type_disk_offering | Status : SUCCESS ===
> ok
> Test to create  a sparse type disk offering ... === TestName: 
> test_04_create_fat_type_disk_offering | Status : SUCCESS ===
> ok
> Test to update existing disk offering ... SKIP: skip
> Test to delete disk offering ... SKIP: skip
> 
> --
> Ran 5 tests in 0.301s
> 
> OK (SKIP=2)
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>

Re: Review Request 23605: CLOUDSTACK-7107: Disabling failed test cases

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23605/#review47990
---


Commit 186606a0bf82402e7755cd7998f133023cc96c6c in cloudstack's branch 
refs/heads/master from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=186606a ]

CLOUDSTACK-7107: Disabling failed test case


- ASF Subversion and Git Services


On July 17, 2014, 7:47 a.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23605/
> ---
> 
> (Updated July 17, 2014, 7:47 a.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-7074 and CLOUDSTACK-7107
> https://issues.apache.org/jira/browse/CLOUDSTACK-7074
> https://issues.apache.org/jira/browse/CLOUDSTACK-7107
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Disabling failed test cases on master.
> 
> 
> Diffs
> -
> 
>   test/integration/smoke/test_primary_storage.py 66aec59 
>   test/integration/smoke/test_vm_life_cycle.py 240ab68 
> 
> Diff: https://reviews.apache.org/r/23605/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Review Request 23606: CLOUDSTACK-7025: Resolving test script issue

[Ashutosh Kelkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23606/
---

Review request for cloudstack and Girish Shilamkar.


Bugs: CLOUDSTACK-7025
https://issues.apache.org/jira/browse/CLOUDSTACK-7025


Repository: cloudstack-git


Description
---

defaultNetworkId was not specified. Specified it in the setupClass.


Diffs
-

  test/integration/component/test_add_remove_network.py 4222f7a 

Diff: https://reviews.apache.org/r/23606/diff/


Testing
---

4 Test cases fixed by this.

Log:
Add network to running VM ... SKIP: skip
Add network to running VM ... SKIP: skip
Add network to stopped VM ... SKIP: skip
Add network to stopped VM ... SKIP: skip
Add same network multiple times to running VM ... === TestName: 
test_03_add_nw_multiple_times_1_isolated | Status : SUCCESS ===
ok
Add same network multiple times to running VM ... === TestName: 
test_03_add_nw_multiple_times_2_shared | Status : SUCCESS ===
ok
Add VPC network to running VM belonging to isolated network ... === TestName: 
test_04_vpc_nw_running_vm_1_isolated | Status : SUCCESS ===
ok
Add VPC network to stopped VM belonging to isolated network ... SKIP: skip
Add network and ip address to running VM ... === TestName: 
test_06_add_nw_ipaddress_running_vm | Status : SUCCESS ===
ok
Add network with invalid ip address to running VM ... SKIP: skip
Add network to running VM ... SKIP: skip
Add network to running VM ... SKIP: skip
Add network to running VM ... SKIP: skip
Add network to VM with maximum network limit reached ... SKIP: skip

--
Ran 14 tests in 1523.655s

OK (SKIP=10)


Thanks,

Ashutosh Kelkar

Review Request 23607: CLOUDSTACK-7020:Fixed test script issue

[Ashutosh Kelkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23607/
---

Review request for cloudstack and Girish Shilamkar.


Bugs: CLOUDSTACK-7020
https://issues.apache.org/jira/browse/CLOUDSTACK-7020


Repository: cloudstack-git


Description
---

Fixed test script issue related to cleanup


Diffs
-

  test/integration/component/test_usage.py 4413f43 

Diff: https://reviews.apache.org/r/23607/diff/


Testing
---

Yes.

Log:
Test Upload/ delete a template and verify correct usage is generated ... === 
TestName: test_01_template_usage | Status : SUCCESS ===
ok

--
Ran 1 test in 573.037s

OK


Thanks,

Ashutosh Kelkar

Review Request 23609: Signature changes to delete method in VirtualMachine class in base.py

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23609/
---

Review request for cloudstack, Santhosh Edukulla and SrikanteswaraRao Talluri.


Repository: cloudstack-git


Description
---

destroyVirtualMachine API takes only one parameter (id-virtualmachine id) till 
CS 4.2. In 4.3 we have added expunge parameter to expunge the vm at the destroy 
time instead of waiting for expunge interval.
Made changes to delete method to accept additional parameters.


Diffs
-

  tools/marvin/marvin/lib/base.py e9d5bb4 

Diff: https://reviews.apache.org/r/23609/diff/


Testing
---

yes


Thanks,

sanjeev n

Review Request 23608: CLOUDSTACK-7014: Resolving test script related to affinity groups tests

[Ashutosh Kelkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23608/
---

Review request for cloudstack and Girish Shilamkar.


Bugs: CLOUDSTACK-7014
https://issues.apache.org/jira/browse/CLOUDSTACK-7014


Repository: cloudstack-git


Description
---

Changing __cleanup to _cleanup


Diffs
-

  test/integration/component/test_affinity_groups.py de5f007 

Diff: https://reviews.apache.org/r/23608/diff/


Testing
---

Yes


Thanks,

Ashutosh Kelkar

Review Request 23610: New script for verifying multiple shared networks with overlapped cidrs in different vlans

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23610/
---

Review request for cloudstack and SrikanteswaraRao Talluri.


Bugs: cs-4282
https://issues.apache.org/jira/browse/cs-4282


Repository: cloudstack-git


Description
---

Adding new script for verifying multiple shared networks support with 
overlapped cidrs in different vlans.
1.Create network1 with cidr1 and vlan1--pass
2.Create network2 with cidr1 and vlan1--fails
3.Create network3 with cidr1 and vlan2- pass


Diffs
-

  test/integration/component/test_shared_networks.py f99bfbf 

Diff: https://reviews.apache.org/r/23610/diff/


Testing
---

yes


Thanks,

sanjeev n

Re: Review Request 23606: CLOUDSTACK-7025: Resolving test script issue

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23606/#review47994
---


Commit 33fdfbc83407037b45624ca84ca436fab72e59ab in cloudstack's branch 
refs/heads/4.4-forward from Ashutosh K
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=33fdfbc ]

CLOUDSTACK-7025: Resolving test script issue


- ASF Subversion and Git Services


On July 17, 2014, 8:53 a.m., Ashutosh Kelkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23606/
> ---
> 
> (Updated July 17, 2014, 8:53 a.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-7025
> https://issues.apache.org/jira/browse/CLOUDSTACK-7025
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> defaultNetworkId was not specified. Specified it in the setupClass.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_add_remove_network.py 4222f7a 
> 
> Diff: https://reviews.apache.org/r/23606/diff/
> 
> 
> Testing
> ---
> 
> 4 Test cases fixed by this.
> 
> Log:
> Add network to running VM ... SKIP: skip
> Add network to running VM ... SKIP: skip
> Add network to stopped VM ... SKIP: skip
> Add network to stopped VM ... SKIP: skip
> Add same network multiple times to running VM ... === TestName: 
> test_03_add_nw_multiple_times_1_isolated | Status : SUCCESS ===
> ok
> Add same network multiple times to running VM ... === TestName: 
> test_03_add_nw_multiple_times_2_shared | Status : SUCCESS ===
> ok
> Add VPC network to running VM belonging to isolated network ... === TestName: 
> test_04_vpc_nw_running_vm_1_isolated | Status : SUCCESS ===
> ok
> Add VPC network to stopped VM belonging to isolated network ... SKIP: skip
> Add network and ip address to running VM ... === TestName: 
> test_06_add_nw_ipaddress_running_vm | Status : SUCCESS ===
> ok
> Add network with invalid ip address to running VM ... SKIP: skip
> Add network to running VM ... SKIP: skip
> Add network to running VM ... SKIP: skip
> Add network to running VM ... SKIP: skip
> Add network to VM with maximum network limit reached ... SKIP: skip
> 
> --
> Ran 14 tests in 1523.655s
> 
> OK (SKIP=10)
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>

Re: Review Request 23606: CLOUDSTACK-7025: Resolving test script issue

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23606/#review47995
---


Commit 28a4ae3713af85b95bc0aae52f7fff032ee595aa in cloudstack's branch 
refs/heads/master from Ashutosh K
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=28a4ae3 ]

CLOUDSTACK-7025: Resolving test script issue


- ASF Subversion and Git Services


On July 17, 2014, 8:53 a.m., Ashutosh Kelkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23606/
> ---
> 
> (Updated July 17, 2014, 8:53 a.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-7025
> https://issues.apache.org/jira/browse/CLOUDSTACK-7025
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> defaultNetworkId was not specified. Specified it in the setupClass.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_add_remove_network.py 4222f7a 
> 
> Diff: https://reviews.apache.org/r/23606/diff/
> 
> 
> Testing
> ---
> 
> 4 Test cases fixed by this.
> 
> Log:
> Add network to running VM ... SKIP: skip
> Add network to running VM ... SKIP: skip
> Add network to stopped VM ... SKIP: skip
> Add network to stopped VM ... SKIP: skip
> Add same network multiple times to running VM ... === TestName: 
> test_03_add_nw_multiple_times_1_isolated | Status : SUCCESS ===
> ok
> Add same network multiple times to running VM ... === TestName: 
> test_03_add_nw_multiple_times_2_shared | Status : SUCCESS ===
> ok
> Add VPC network to running VM belonging to isolated network ... === TestName: 
> test_04_vpc_nw_running_vm_1_isolated | Status : SUCCESS ===
> ok
> Add VPC network to stopped VM belonging to isolated network ... SKIP: skip
> Add network and ip address to running VM ... === TestName: 
> test_06_add_nw_ipaddress_running_vm | Status : SUCCESS ===
> ok
> Add network with invalid ip address to running VM ... SKIP: skip
> Add network to running VM ... SKIP: skip
> Add network to running VM ... SKIP: skip
> Add network to running VM ... SKIP: skip
> Add network to VM with maximum network limit reached ... SKIP: skip
> 
> --
> Ran 14 tests in 1523.655s
> 
> OK (SKIP=10)
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>

Re: Review Request 23607: CLOUDSTACK-7020:Fixed test script issue

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23607/#review47996
---


Commit b7d445873c36d523571896ea1c51a49f65024445 in cloudstack's branch 
refs/heads/4.4-forward from Ashutosh K
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=b7d4458 ]

CLOUDSTACK-7020:Fixed test script issue


- ASF Subversion and Git Services


On July 17, 2014, 9:02 a.m., Ashutosh Kelkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23607/
> ---
> 
> (Updated July 17, 2014, 9:02 a.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-7020
> https://issues.apache.org/jira/browse/CLOUDSTACK-7020
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fixed test script issue related to cleanup
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_usage.py 4413f43 
> 
> Diff: https://reviews.apache.org/r/23607/diff/
> 
> 
> Testing
> ---
> 
> Yes.
> 
> Log:
> Test Upload/ delete a template and verify correct usage is generated ... === 
> TestName: test_01_template_usage | Status : SUCCESS ===
> ok
> 
> --
> Ran 1 test in 573.037s
> 
> OK
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>

Re: Review Request 23607: CLOUDSTACK-7020:Fixed test script issue

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23607/#review47997
---


Commit 0c050e04fd80b83dccdeb9d4abe4298aedcf0ea0 in cloudstack's branch 
refs/heads/master from Ashutosh K
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=0c050e0 ]

CLOUDSTACK-7020:Fixed test script issue


- ASF Subversion and Git Services


On July 17, 2014, 9:02 a.m., Ashutosh Kelkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23607/
> ---
> 
> (Updated July 17, 2014, 9:02 a.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-7020
> https://issues.apache.org/jira/browse/CLOUDSTACK-7020
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fixed test script issue related to cleanup
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_usage.py 4413f43 
> 
> Diff: https://reviews.apache.org/r/23607/diff/
> 
> 
> Testing
> ---
> 
> Yes.
> 
> Log:
> Test Upload/ delete a template and verify correct usage is generated ... === 
> TestName: test_01_template_usage | Status : SUCCESS ===
> ok
> 
> --
> Ran 1 test in 573.037s
> 
> OK
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>

Re: Review Request 23608: CLOUDSTACK-7014: Resolving test script related to affinity groups tests

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23608/#review47998
---


Commit 7f6ea4bbed344c012011820735409ee8731e08b0 in cloudstack's branch 
refs/heads/master from Ashutosh K
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=7f6ea4b ]

CLOUDSTACK-7014: Resolving test script related to affinity groups tests


- ASF Subversion and Git Services


On July 17, 2014, 9:23 a.m., Ashutosh Kelkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23608/
> ---
> 
> (Updated July 17, 2014, 9:23 a.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-7014
> https://issues.apache.org/jira/browse/CLOUDSTACK-7014
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Changing __cleanup to _cleanup
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_affinity_groups.py de5f007 
> 
> Diff: https://reviews.apache.org/r/23608/diff/
> 
> 
> Testing
> ---
> 
> Yes
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>

Re: Review Request 23608: CLOUDSTACK-7014: Resolving test script related to affinity groups tests

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23608/#review47999
---


Commit 1cc6317b5e744afb74b63af6600af32bdfedb888 in cloudstack's branch 
refs/heads/4.4-forward from Ashutosh K
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=1cc6317 ]

CLOUDSTACK-7014: Resolving test script related to affinity groups tests


- ASF Subversion and Git Services


On July 17, 2014, 9:23 a.m., Ashutosh Kelkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23608/
> ---
> 
> (Updated July 17, 2014, 9:23 a.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-7014
> https://issues.apache.org/jira/browse/CLOUDSTACK-7014
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Changing __cleanup to _cleanup
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_affinity_groups.py de5f007 
> 
> Diff: https://reviews.apache.org/r/23608/diff/
> 
> 
> Testing
> ---
> 
> Yes
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>

Review Request 23611: CLOUDSTACK-7013: Fixing test script issue in test_add_remove_network.py

[Ashutosh Kelkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23611/
---

Review request for cloudstack and Girish Shilamkar.


Bugs: CLOUDSTACK-7013
https://issues.apache.org/jira/browse/CLOUDSTACK-7013


Repository: cloudstack-git


Description
---

Corrected typo. cls.append to cls._cleanup.append


Diffs
-

  test/integration/component/test_add_remove_network.py dbba59b 

Diff: https://reviews.apache.org/r/23611/diff/


Testing
---

Yes.

Log:

Try to remove nic from a vm providing wrong vm id to API ... === TestName: 
test_19_remove_nic_wrong_vm_id | Status : SUCCESS ===
ok

--
Ran 1 test in 172.776s

OK


Thanks,

Ashutosh Kelkar

Re: Review Request 23611: CLOUDSTACK-7013: Fixing test script issue in test_add_remove_network.py

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23611/#review48000
---


Commit f99a96f38a1f2433cb01bd7af25890789716e070 in cloudstack's branch 
refs/heads/4.4-forward from Ashutosh K
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=f99a96f ]

CLOUDSTACK-7013: Fixing test script issue in test_add_remove_network.py


- ASF Subversion and Git Services


On July 17, 2014, 10:24 a.m., Ashutosh Kelkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23611/
> ---
> 
> (Updated July 17, 2014, 10:24 a.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-7013
> https://issues.apache.org/jira/browse/CLOUDSTACK-7013
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Corrected typo. cls.append to cls._cleanup.append
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_add_remove_network.py dbba59b 
> 
> Diff: https://reviews.apache.org/r/23611/diff/
> 
> 
> Testing
> ---
> 
> Yes.
> 
> Log:
> 
> Try to remove nic from a vm providing wrong vm id to API ... === TestName: 
> test_19_remove_nic_wrong_vm_id | Status : SUCCESS ===
> ok
> 
> --
> Ran 1 test in 172.776s
> 
> OK
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>

Re: Review Request 23611: CLOUDSTACK-7013: Fixing test script issue in test_add_remove_network.py

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23611/#review48001
---


Commit 332191b1bf2935bcad4c05a9fd61d0ebc30f035b in cloudstack's branch 
refs/heads/master from Ashutosh K
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=332191b ]

CLOUDSTACK-7013: Fixing test script issue in test_add_remove_network.py


- ASF Subversion and Git Services


On July 17, 2014, 10:24 a.m., Ashutosh Kelkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23611/
> ---
> 
> (Updated July 17, 2014, 10:24 a.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-7013
> https://issues.apache.org/jira/browse/CLOUDSTACK-7013
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Corrected typo. cls.append to cls._cleanup.append
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_add_remove_network.py dbba59b 
> 
> Diff: https://reviews.apache.org/r/23611/diff/
> 
> 
> Testing
> ---
> 
> Yes.
> 
> Log:
> 
> Try to remove nic from a vm providing wrong vm id to API ... === TestName: 
> test_19_remove_nic_wrong_vm_id | Status : SUCCESS ===
> ok
> 
> --
> Ran 1 test in 172.776s
> 
> OK
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>

Review Request 23613: CLOUDSTACK-7022: Fixed typo

[Ashutosh Kelkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23613/
---

Review request for cloudstack and Girish Shilamkar.


Bugs: CLOUDSTACK-7022
https://issues.apache.org/jira/browse/CLOUDSTACK-7022


Repository: cloudstack-git


Description
---

Fixed typo.


Diffs
-

  test/integration/component/test_usage.py 4f9d1d7 

Diff: https://reviews.apache.org/r/23613/diff/


Testing
---


Thanks,

Ashutosh Kelkar

Review Request 23614: New test for deploying vm with static ip address

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23614/
---

Review request for cloudstack and SrikanteswaraRao Talluri.


Repository: cloudstack-git


Description
---

This is new script for deploying vm with static ip address.
1.Create isolated network with some ip range
2.Deploy vm with one of those ips instead of CS assigning the guest ip to vm
3.Verify the ip address after deployment


Diffs
-

  test/integration/component/test_escalations_instances.py 4900ff6 

Diff: https://reviews.apache.org/r/23614/diff/


Testing
---

yes


Thanks,

sanjeev n

Re: Review Request 23613: CLOUDSTACK-7022: Fixed typo

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23613/#review48006
---


Commit 4bab99972f5e87bb6059f34cd0a302db703342f7 in cloudstack's branch 
refs/heads/master from Ashutosh K
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=4bab999 ]

CLOUDSTACK-7022: Fixed typo


- ASF Subversion and Git Services


On July 17, 2014, 11:03 a.m., Ashutosh Kelkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23613/
> ---
> 
> (Updated July 17, 2014, 11:03 a.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-7022
> https://issues.apache.org/jira/browse/CLOUDSTACK-7022
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fixed typo.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_usage.py 4f9d1d7 
> 
> Diff: https://reviews.apache.org/r/23613/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>

Re: Review Request 23613: CLOUDSTACK-7022: Fixed typo

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23613/#review48008
---


Commit 967b82f16b93bf1df4473b7ce8dd314f015098e8 in cloudstack's branch 
refs/heads/4.4-forward from Ashutosh K
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=967b82f ]

CLOUDSTACK-7022: Fixed typo


- ASF Subversion and Git Services


On July 17, 2014, 11:03 a.m., Ashutosh Kelkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23613/
> ---
> 
> (Updated July 17, 2014, 11:03 a.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-7022
> https://issues.apache.org/jira/browse/CLOUDSTACK-7022
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fixed typo.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_usage.py 4f9d1d7 
> 
> Diff: https://reviews.apache.org/r/23613/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>

changing cpu.overprovisioning.factor

[Pierre-Luc Dion]

I've tried to change the cpu.overprovisioning.factor in Cloudstack 4.3
using Global Settings, even after restarting cloudstack-managment server
 GHz available remain the same in the zone.

Turns out that changing the value in the cluster did update value
automatically without restarts.

Is this a wanted behaviour ?

Thanks,

*Pierre-Luc DION*
Architecte de Solution Cloud | Cloud Solutions Architect
t 855.652.5683

*CloudOps* Votre partenaire infonuagique* | *Cloud Solutions Experts
420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
w cloudops.com *|* tw @CloudOps_

Review Request 23617: Add Nic UUID to the context so that we can read the same in event bus after create a nic

[Damodar Reddy Talakanti]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23617/
---

Review request for cloudstack and Nitin Mehta.


Repository: cloudstack-git


Description
---

Putting the create event into event bus for addNicToVirutalMachine command 
explicitly as we can not use BaseAsyncCreateCommand.We can not extend this with 
BaseAsyncCreateCmd due to the checks we do before creating the nic.


Diffs
-

  api/src/com/cloud/event/EventTypes.java 71bfdb6 
  server/src/com/cloud/vm/UserVmManagerImpl.java d0bc186 

Diff: https://reviews.apache.org/r/23617/diff/


Testing
---

Tested against the following setup:

1. XenServer 6.2
2. Master Branch


Thanks,

Damodar Reddy Talakanti

Re: changing cpu.overprovisioning.factor

[Nitin Mehta]

Did you change the global config or the cluster config ?
Global config is inherited when a new cluster is created but once the
cluster is created you need to modify it at the cluster for it take
affect. See if that helps.

Thanks,
-Nitin

On 17/07/14 9:41 AM, "Pierre-Luc Dion"  wrote:

>I've tried to change the cpu.overprovisioning.factor in Cloudstack 4.3
>using Global Settings, even after restarting cloudstack-managment server
> GHz available remain the same in the zone.
>
>Turns out that changing the value in the cluster did update value
>automatically without restarts.
>
>Is this a wanted behaviour ?
>
>Thanks,
>
>*Pierre-Luc DION*
>Architecte de Solution Cloud | Cloud Solutions Architect
>t 855.652.5683
>
>*CloudOps* Votre partenaire infonuagique* | *Cloud Solutions Experts
>420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
>w cloudops.com *|* tw @CloudOps_

Re: changing cpu.overprovisioning.factor

[Pierre-Luc Dion]

Nitin, This is the behaviour I've observe and make sense too.  Updating
cluster config does work.

I think our documentation need to reflect that behaviour maybe in the admin
guide...

Thanks !


*Pierre-Luc DION*
Architecte de Solution Cloud | Cloud Solutions Architect
t 855.652.5683

*CloudOps* Votre partenaire infonuagique* | *Cloud Solutions Experts
420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
w cloudops.com *|* tw @CloudOps_



On Thu, Jul 17, 2014 at 12:50 PM, Nitin Mehta 
wrote:

> Did you change the global config or the cluster config ?
> Global config is inherited when a new cluster is created but once the
> cluster is created you need to modify it at the cluster for it take
> affect. See if that helps.
>
> Thanks,
> -Nitin
>
> On 17/07/14 9:41 AM, "Pierre-Luc Dion"  wrote:
>
> >I've tried to change the cpu.overprovisioning.factor in Cloudstack 4.3
> >using Global Settings, even after restarting cloudstack-managment server
> > GHz available remain the same in the zone.
> >
> >Turns out that changing the value in the cluster did update value
> >automatically without restarts.
> >
> >Is this a wanted behaviour ?
> >
> >Thanks,
> >
> >*Pierre-Luc DION*
> >Architecte de Solution Cloud | Cloud Solutions Architect
> >t 855.652.5683
> >
> >*CloudOps* Votre partenaire infonuagique* | *Cloud Solutions Experts
> >420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
> >w cloudops.com *|* tw @CloudOps_
>
>

Re: Review Request 23617: Add Nic UUID to the context so that we can read the same in event bus after create a nic

[Nitin Mehta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23617/#review48016
---



server/src/com/cloud/vm/UserVmManagerImpl.java


Why is it made create=true when it is not a BaseAyncCreate cmd ? 
create=true should be added only when its invoked through the create() method 
of a  BaseAyncCreate cmd 


- Nitin Mehta


On July 17, 2014, 4:43 p.m., Damodar Reddy Talakanti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23617/
> ---
> 
> (Updated July 17, 2014, 4:43 p.m.)
> 
> 
> Review request for cloudstack and Nitin Mehta.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Putting the create event into event bus for addNicToVirutalMachine command 
> explicitly as we can not use BaseAsyncCreateCommand.We can not extend this 
> with BaseAsyncCreateCmd due to the checks we do before creating the nic.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/event/EventTypes.java 71bfdb6 
>   server/src/com/cloud/vm/UserVmManagerImpl.java d0bc186 
> 
> Diff: https://reviews.apache.org/r/23617/diff/
> 
> 
> Testing
> ---
> 
> Tested against the following setup:
> 
> 1. XenServer 6.2
> 2. Master Branch
> 
> 
> Thanks,
> 
> Damodar Reddy Talakanti
> 
>

Re: changing cpu.overprovisioning.factor

[Nitin Mehta]

Thanks for confirming. Could you please create a bug at JIRA for adding
this into documentation ?

-Nitin

On 17/07/14 9:53 AM, "Pierre-Luc Dion"  wrote:

>Nitin, This is the behaviour I've observe and make sense too.  Updating
>cluster config does work.
>
>I think our documentation need to reflect that behaviour maybe in the
>admin
>guide...
>
>Thanks !
>
>
>*Pierre-Luc DION*
>Architecte de Solution Cloud | Cloud Solutions Architect
>t 855.652.5683
>
>*CloudOps* Votre partenaire infonuagique* | *Cloud Solutions Experts
>420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
>w cloudops.com *|* tw @CloudOps_
>
>
>
>On Thu, Jul 17, 2014 at 12:50 PM, Nitin Mehta 
>wrote:
>
>> Did you change the global config or the cluster config ?
>> Global config is inherited when a new cluster is created but once the
>> cluster is created you need to modify it at the cluster for it take
>> affect. See if that helps.
>>
>> Thanks,
>> -Nitin
>>
>> On 17/07/14 9:41 AM, "Pierre-Luc Dion"  wrote:
>>
>> >I've tried to change the cpu.overprovisioning.factor in Cloudstack 4.3
>> >using Global Settings, even after restarting cloudstack-managment
>>server
>> > GHz available remain the same in the zone.
>> >
>> >Turns out that changing the value in the cluster did update value
>> >automatically without restarts.
>> >
>> >Is this a wanted behaviour ?
>> >
>> >Thanks,
>> >
>> >*Pierre-Luc DION*
>> >Architecte de Solution Cloud | Cloud Solutions Architect
>> >t 855.652.5683
>> >
>> >*CloudOps* Votre partenaire infonuagique* | *Cloud Solutions Experts
>> >420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
>> >w cloudops.com *|* tw @CloudOps_
>>
>>

Re: changing cpu.overprovisioning.factor

[Pierre-Luc Dion]

good idea, doing it now ...


*Pierre-Luc DION*
Architecte de Solution Cloud | Cloud Solutions Architect
t 855.652.5683

*CloudOps* Votre partenaire infonuagique* | *Cloud Solutions Experts
420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
w cloudops.com *|* tw @CloudOps_



On Thu, Jul 17, 2014 at 12:57 PM, Nitin Mehta 
wrote:

> Thanks for confirming. Could you please create a bug at JIRA for adding
> this into documentation ?
>
> -Nitin
>
> On 17/07/14 9:53 AM, "Pierre-Luc Dion"  wrote:
>
> >Nitin, This is the behaviour I've observe and make sense too.  Updating
> >cluster config does work.
> >
> >I think our documentation need to reflect that behaviour maybe in the
> >admin
> >guide...
> >
> >Thanks !
> >
> >
> >*Pierre-Luc DION*
> >Architecte de Solution Cloud | Cloud Solutions Architect
> >t 855.652.5683
> >
> >*CloudOps* Votre partenaire infonuagique* | *Cloud Solutions Experts
> >420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
> >w cloudops.com *|* tw @CloudOps_
> >
> >
> >
> >On Thu, Jul 17, 2014 at 12:50 PM, Nitin Mehta 
> >wrote:
> >
> >> Did you change the global config or the cluster config ?
> >> Global config is inherited when a new cluster is created but once the
> >> cluster is created you need to modify it at the cluster for it take
> >> affect. See if that helps.
> >>
> >> Thanks,
> >> -Nitin
> >>
> >> On 17/07/14 9:41 AM, "Pierre-Luc Dion"  wrote:
> >>
> >> >I've tried to change the cpu.overprovisioning.factor in Cloudstack 4.3
> >> >using Global Settings, even after restarting cloudstack-managment
> >>server
> >> > GHz available remain the same in the zone.
> >> >
> >> >Turns out that changing the value in the cluster did update value
> >> >automatically without restarts.
> >> >
> >> >Is this a wanted behaviour ?
> >> >
> >> >Thanks,
> >> >
> >> >*Pierre-Luc DION*
> >> >Architecte de Solution Cloud | Cloud Solutions Architect
> >> >t 855.652.5683
> >> >
> >> >*CloudOps* Votre partenaire infonuagique* | *Cloud Solutions Experts
> >> >420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
> >> >w cloudops.com *|* tw @CloudOps_
> >>
> >>
>
>

Re: [VOTE] Apache Cloudstack 4.4.0

[Marcus]

Yes, it's a regression. The impact is that upgraders to 4.4 may have
existing VMs that don't boot when rebooted, or templates that won't work,
because the virtual hardware is changed and not what was expected.


On Thu, Jul 17, 2014 at 1:56 AM, Daan Hoogland 
wrote:

> Marcus, Amogh, WHat is the work to do and the ETA? As I read your
> mail, it seems we are not going to revert but I have no idea on what a
> forward fix would be. Just adding mappings to KVMGuestOsMapper?
>
> @Marcus: is this regression? As in do I agree with you making this a
> blocker. You seem to imply so and I want to read you write it;)
>
> On Thu, Jul 17, 2014 at 9:14 AM, Erik Weber  wrote:
> > Considering adding centos 7 and rhel 7 while at it.
> >
> > Erik
> > 17. juli 2014 00:32 skrev "Marcus"  følgende:
> >
> >> Yes, thats it. I have no idea how these mappings are created, but we
> need
> >> to ensure that both upgrades and new installs work
> >>
> >>
> >> On Wed, Jul 16, 2014 at 3:25 PM, Amogh Vasekar <
> amogh.vase...@citrix.com>
> >> wrote:
> >>
> >> > Hi,
> >> >
> >> > It is probably due to missing mapping in guest_os_hypervisor table. I
> had
> >> > created default entries for KVM using :
> >> > http://bit.ly/1rrML8n
> >> >
> >> > I can add the missing mapping to it.
> >> >
> >> > Thanks,
> >> > Amogh
> >> >
> >> > On 7/16/14 2:08 PM, "Marcus"  wrote:
> >> >
> >> > >I have another big issue to report with 4.4 in testing these
> artifacts.
> >> I
> >> > >register a CentOS 6.5 template, and launch VMs for it on KVM, and the
> >> > >disks/nics are not virtio.
> >> > >
> >> > >It looks like it is due to the following commit, which changes how
> the
> >> KVM
> >> > >agent determines if a template is PV enabled. The
> >> 'getPlatformEmulator()'
> >> > >is empty. I have reopened the associated bug and commented on it.
> >> > >
> >> > > -DiskDef.diskBus diskBusType =
> >> > >getGuestDiskModel(vmSpec.getOs());
> >> > >+DiskDef.diskBus diskBusType =
> >> > >getGuestDiskModel(vmSpec.getPlatformEmulator());
> >> > >
> >> > >commit 02bd3d0671b0cde46f8aa7892f20aa0bb0d48d1c
> >> > >Author: Amogh Vasekar 
> >> > >Date:   Wed May 7 15:16:55 2014 -0700
> >> > >
> >> > >CLOUDSTACK-6358: As a part of supporting dynamic guest OS
> defined by
> >> > >user, removing the hard-coded dependencies.
> >> > >This patch is for KVM
> >> > >
> >> > >1. Local testing on KVM
> >> > >2. Successfully got up system VMs
> >> > >3. Successfully created a CentOS VM
> >> > >4. Snapshots are not supported for KVM
> >> > >
> >> > > Signed off by :- Nitin Mehta
> >> > >
> >> > >
> >> > >
> >> > >On Wed, Jul 16, 2014 at 2:57 PM, Alena Prokharchyk <
> >> > >alena.prokharc...@citrix.com> wrote:
> >> > >
> >> > >> Daan, during 4.4 testing, I found the following regression bug:
> >> > >>
> >> > >> https://issues.apache.org/jira/browse/CLOUDSTACK-7118
> >> > >>
> >> > >>
> >> > >> "Unable to expunge vms in error state"
> >> > >>
> >> > >> There is a workaround for it - I¹ve mentioned it in the bug - yet
> >> > >>ideally
> >> > >> I would prefer the fix to be cherry-picked from 4.4-forward:
> >> > >>
> >> > >> commit 822b38761f1655ef3d5d3648985a197f5c2c1262
> >> > >>
> >> > >>
> >> > >>
> >> > >> Thank you,
> >> > >> Alena.
> >> > >>
> >> > >> On 7/16/14, 4:47 AM, "Daan Hoogland" 
> wrote:
> >> > >>
> >> > >> >On Thu, Jul 3, 2014 at 1:41 AM, Marcus 
> wrote:
> >> > >> >> I tested this release with
> >> > >> >> cherry-picking 2ec7359b4eb501b0d9e80ed87af7a54938e9d505 from
> >> > >> >>4.4-forward.
> >> > >> >
> >> > >> >
> >> > >> >I have cherry-picked and pushed. I will address the last remaining
> >> > >> >issue by editting the pom.xml from build_asf.sh and roll out a new
> >> RC.
> >> > >> >
> >> > >> >Hope all of you have continued testing and have now more issues to
> >> > >> >block this release
> >> > >> >
> >> > >> >--
> >> > >> >Daan
> >> > >>
> >> > >>
> >> >
> >> >
> >>
>
>
>
> --
> Daan
>

Re: changing cpu.overprovisioning.factor

[Harikrishna Patnala]

Please create a doc bug only for two parameters cpu and memory overprovisioning 
factors. 

Because for the remaining parameters till the value is defined at granular 
level, CS uses the value at global level.  

So in your case if it would have some parameter other than cpu and memory over 
provisioning factors, then changing the value at global level should affect at 
cluster level also.


Thanks,
Harikrishna


On 17-Jul-2014, at 10:38 pm, Pierre-Luc Dion  wrote:

> good idea, doing it now ...
> 
> 
> *Pierre-Luc DION*
> Architecte de Solution Cloud | Cloud Solutions Architect
> t 855.652.5683
> 
> *CloudOps* Votre partenaire infonuagique* | *Cloud Solutions Experts
> 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
> w cloudops.com *|* tw @CloudOps_
> 
> 
> 
> On Thu, Jul 17, 2014 at 12:57 PM, Nitin Mehta 
> wrote:
> 
>> Thanks for confirming. Could you please create a bug at JIRA for adding
>> this into documentation ?
>> 
>> -Nitin
>> 
>> On 17/07/14 9:53 AM, "Pierre-Luc Dion"  wrote:
>> 
>>> Nitin, This is the behaviour I've observe and make sense too.  Updating
>>> cluster config does work.
>>> 
>>> I think our documentation need to reflect that behaviour maybe in the
>>> admin
>>> guide...
>>> 
>>> Thanks !
>>> 
>>> 
>>> *Pierre-Luc DION*
>>> Architecte de Solution Cloud | Cloud Solutions Architect
>>> t 855.652.5683
>>> 
>>> *CloudOps* Votre partenaire infonuagique* | *Cloud Solutions Experts
>>> 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
>>> w cloudops.com *|* tw @CloudOps_
>>> 
>>> 
>>> 
>>> On Thu, Jul 17, 2014 at 12:50 PM, Nitin Mehta 
>>> wrote:
>>> 
 Did you change the global config or the cluster config ?
 Global config is inherited when a new cluster is created but once the
 cluster is created you need to modify it at the cluster for it take
 affect. See if that helps.
 
 Thanks,
 -Nitin
 
 On 17/07/14 9:41 AM, "Pierre-Luc Dion"  wrote:
 
> I've tried to change the cpu.overprovisioning.factor in Cloudstack 4.3
> using Global Settings, even after restarting cloudstack-managment
 server
> GHz available remain the same in the zone.
> 
> Turns out that changing the value in the cluster did update value
> automatically without restarts.
> 
> Is this a wanted behaviour ?
> 
> Thanks,
> 
> *Pierre-Luc DION*
> Architecte de Solution Cloud | Cloud Solutions Architect
> t 855.652.5683
> 
> *CloudOps* Votre partenaire infonuagique* | *Cloud Solutions Experts
> 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
> w cloudops.com *|* tw @CloudOps_
 
 
>> 
>> 

Re: changing cpu.overprovisioning.factor

[Pierre-Luc Dion]

https://issues.apache.org/jira/browse/CLOUDSTACK-7120

updated.


*Pierre-Luc DION*
Architecte de Solution Cloud | Cloud Solutions Architect
t 855.652.5683

*CloudOps* Votre partenaire infonuagique* | *Cloud Solutions Experts
420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
w cloudops.com *|* tw @CloudOps_



On Thu, Jul 17, 2014 at 2:35 PM, Harikrishna Patnala <
harikrishna.patn...@citrix.com> wrote:

> Please create a doc bug only for two parameters cpu and memory
> overprovisioning factors.
>
> Because for the remaining parameters till the value is defined at granular
> level, CS uses the value at global level.
>
> So in your case if it would have some parameter other than cpu and memory
> over provisioning factors, then changing the value at global level should
> affect at cluster level also.
>
>
> Thanks,
> Harikrishna
>
>
> On 17-Jul-2014, at 10:38 pm, Pierre-Luc Dion  wrote:
>
> > good idea, doing it now ...
> >
> >
> > *Pierre-Luc DION*
> > Architecte de Solution Cloud | Cloud Solutions Architect
> > t 855.652.5683
> >
> > *CloudOps* Votre partenaire infonuagique* | *Cloud Solutions Experts
> > 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
> > w cloudops.com *|* tw @CloudOps_
> >
> >
> >
> > On Thu, Jul 17, 2014 at 12:57 PM, Nitin Mehta 
> > wrote:
> >
> >> Thanks for confirming. Could you please create a bug at JIRA for adding
> >> this into documentation ?
> >>
> >> -Nitin
> >>
> >> On 17/07/14 9:53 AM, "Pierre-Luc Dion"  wrote:
> >>
> >>> Nitin, This is the behaviour I've observe and make sense too.  Updating
> >>> cluster config does work.
> >>>
> >>> I think our documentation need to reflect that behaviour maybe in the
> >>> admin
> >>> guide...
> >>>
> >>> Thanks !
> >>>
> >>>
> >>> *Pierre-Luc DION*
> >>> Architecte de Solution Cloud | Cloud Solutions Architect
> >>> t 855.652.5683
> >>>
> >>> *CloudOps* Votre partenaire infonuagique* | *Cloud Solutions Experts
> >>> 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
> >>> w cloudops.com *|* tw @CloudOps_
> >>>
> >>>
> >>>
> >>> On Thu, Jul 17, 2014 at 12:50 PM, Nitin Mehta 
> >>> wrote:
> >>>
>  Did you change the global config or the cluster config ?
>  Global config is inherited when a new cluster is created but once the
>  cluster is created you need to modify it at the cluster for it take
>  affect. See if that helps.
> 
>  Thanks,
>  -Nitin
> 
>  On 17/07/14 9:41 AM, "Pierre-Luc Dion"  wrote:
> 
> > I've tried to change the cpu.overprovisioning.factor in Cloudstack
> 4.3
> > using Global Settings, even after restarting cloudstack-managment
>  server
> > GHz available remain the same in the zone.
> >
> > Turns out that changing the value in the cluster did update value
> > automatically without restarts.
> >
> > Is this a wanted behaviour ?
> >
> > Thanks,
> >
> > *Pierre-Luc DION*
> > Architecte de Solution Cloud | Cloud Solutions Architect
> > t 855.652.5683
> >
> > *CloudOps* Votre partenaire infonuagique* | *Cloud Solutions Experts
> > 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
> > w cloudops.com *|* tw @CloudOps_
> 
> 
> >>
> >>
>
>

Daily Continues Integration test summary

[Rayees Namathponnan]

Hi All,

We are running Continues Integration inside Citrix  environment,  tests are 
running in both mater and release branches in every 3 hours.

Currently only BVT test cases executing on Simulator, Xen and KVM. We are 
working towards to add regression suite,  vmware and external devices test 
cases like NetScaler, F5 etc

I will publish daily result summary in dev mailing list, also you can see this 
from https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=43188548


Current CI BVT summary with master build
---

Simulator
-
Run No  Total Ex  Failed Failed test case
1370  62   0
1365  64   1 
test_vm_life_cycle.TestVMLifeCycle.test_08_migrate_vm Disabled this test 
now, until fixing in master
1362  64   3 
TestCreateDiskOffering.test_02_create_sparse_type_disk_offeringFixed first 
two failures, 08_migrate_vm disabled now
1358  64   3 
TestCreateDiskOffering.test_02_create_sparse_type_disk_offeringFixed first 
two failures, 08_migrate_vm disabled now

KVM
---
Run No  Total Ex  Failed Failed test caseComments
Disabled  Disabled   Disabled due to 
product issue, its fixed now, we will enable this soon


XEN
---
Run No  Total Ex  Failed Failed test caseComments
1371  29   2 ISO failureCLOUDSTACK-7074
1363  29   2 ISO failureCLOUDSTACK-7074
1359  29   2 ISO failureCLOUDSTACK-7074
1355  29   2 ISO failureCLOUDSTACK-7074


Regards,
Rayees

[ACS 4.4] Cherry pick request

[Amogh Vasekar]

Hi Daan,
Can you please cherry-pick c8ca15b95a57a3d79b71c76c913e295f6490f05d

This is for CLOUDSTACK-6358.

Thanks,
Amogh

4.4 and master system template jobs failing

[Rayees Namathponnan]

Hi All,

4.4 and master system template jobs failing from 
http://jenkins.buildacloud.org;  these jobs try to download ISO  from below 
location and fail with 404 error;

http://cdimage.debian.org/mirror/cdimage/archive/7.4.0/amd64/iso-cd/debian-7.4.0-amd64-netinst.iso
http://ftp.acc.umu.se/mirror/cdimage/release/7.4.0/amd64/iso-cd/debian-7.4.0-amd64-netinst.iso



I can see the debian-7.4.0-i386-netinst.iso  at 
http://ftp.cae.tntech.edu/debian-cd/debian-7.4.0-amd64-netinst.iso   ? probably 
we may need to update our system scripts to download from here.

Build jobs failing with below error



The isofile VBoxGuestAdditions_4.2.6.iso already exists.

Building Box systemvmtemplate with Definition systemvmtemplate:

- debug : false

- cwd : /home/jenkins/workspace/cloudstack-4.4-systemvm/tools/appliance

- force : false

- nogui : true

- auto : true

- checksum : false

- redirectconsole : false

- postinstall_include : []

- postinstall_exclude : []

- skip_to_postinstall : false



We did not find an isofile here : 
/home/jenkins/workspace/cloudstack-4.4-systemvm/tools/appliance/iso/debian-7.4.0-i386-netinst.iso.



The definition provided the following download information:

- Download url: 
http://cdimage.debian.org/mirror/cdimage/archive/7.4.0/i386/iso-cd/debian-7.4.0-i386-netinst.iso

- Md5 Checksum: 7339b668a81b417ac023d73739dc6a03





Checking if isofile debian-7.4.0-i386-netinst.iso already exists.

Full path: 
/home/jenkins/workspace/cloudstack-4.4-systemvm/tools/appliance/iso/debian-7.4.0-i386-netinst.iso

There was an error downloading 
http://cdimage.debian.org/mirror/cdimage/archive/7.4.0/i386/iso-cd/debian-7.4.0-i386-netinst.iso:

404 Not Found

There was an error downloading 
http://cdimage.debian.org/mirror/cdimage/archive/7.4.0/i386/iso-cd/debian-7.4.0-i386-netinst.iso:

404 Not Found

+ bundle exec veewee vbox halt systemvmtemplate

Box is not running

++ vboxmanage list runningvms

++ grep systemvmtemplate

++ wc -l

+ [[ 1 -ne 0 ]]

+ echo 'Waiting for systemvmtemplate to shutdown'

Waiting for systemvmtemplate to shutdown

+ sleep 2

++ vboxmanage list runningvms

++ grep systemvmtemplate

++ wc -l

+ [[ 1 -ne 0 ]]

+ echo 'Waiting for systemvmtemplate to shutdown'

Waiting for systemvmtemplate to shutdown


Regards,
Rayees

Re: [VOTE] Apache Cloudstack 4.4.0

[Amogh Vasekar]

Hi,

Centos 7 and RHEL 7 don't show up in guest_os table list, hence can't add
just yet to the guest_os_hypervisor table.

Thanks,
Amogh

On 7/17/14 12:14 AM, "Erik Weber"  wrote:

>Considering adding centos 7 and rhel 7 while at it.
>
>Erik
>17. juli 2014 00:32 skrev "Marcus"  følgende:
>
>> Yes, thats it. I have no idea how these mappings are created, but we
>>need
>> to ensure that both upgrades and new installs work
>>
>>
>> On Wed, Jul 16, 2014 at 3:25 PM, Amogh Vasekar
>>
>> wrote:
>>
>> > Hi,
>> >
>> > It is probably due to missing mapping in guest_os_hypervisor table. I
>>had
>> > created default entries for KVM using :
>> > http://bit.ly/1rrML8n
>> >
>> > I can add the missing mapping to it.
>> >
>> > Thanks,
>> > Amogh
>> >
>> > On 7/16/14 2:08 PM, "Marcus"  wrote:
>> >
>> > >I have another big issue to report with 4.4 in testing these
>>artifacts.
>> I
>> > >register a CentOS 6.5 template, and launch VMs for it on KVM, and the
>> > >disks/nics are not virtio.
>> > >
>> > >It looks like it is due to the following commit, which changes how
>>the
>> KVM
>> > >agent determines if a template is PV enabled. The
>> 'getPlatformEmulator()'
>> > >is empty. I have reopened the associated bug and commented on it.
>> > >
>> > > -DiskDef.diskBus diskBusType =
>> > >getGuestDiskModel(vmSpec.getOs());
>> > >+DiskDef.diskBus diskBusType =
>> > >getGuestDiskModel(vmSpec.getPlatformEmulator());
>> > >
>> > >commit 02bd3d0671b0cde46f8aa7892f20aa0bb0d48d1c
>> > >Author: Amogh Vasekar 
>> > >Date:   Wed May 7 15:16:55 2014 -0700
>> > >
>> > >CLOUDSTACK-6358: As a part of supporting dynamic guest OS
>>defined by
>> > >user, removing the hard-coded dependencies.
>> > >This patch is for KVM
>> > >
>> > >1. Local testing on KVM
>> > >2. Successfully got up system VMs
>> > >3. Successfully created a CentOS VM
>> > >4. Snapshots are not supported for KVM
>> > >
>> > > Signed off by :- Nitin Mehta
>> > >
>> > >
>> > >
>> > >On Wed, Jul 16, 2014 at 2:57 PM, Alena Prokharchyk <
>> > >alena.prokharc...@citrix.com> wrote:
>> > >
>> > >> Daan, during 4.4 testing, I found the following regression bug:
>> > >>
>> > >> https://issues.apache.org/jira/browse/CLOUDSTACK-7118
>> > >>
>> > >>
>> > >> "Unable to expunge vms in error state"
>> > >>
>> > >> There is a workaround for it - I¹ve mentioned it in the bug - yet
>> > >>ideally
>> > >> I would prefer the fix to be cherry-picked from 4.4-forward:
>> > >>
>> > >> commit 822b38761f1655ef3d5d3648985a197f5c2c1262
>> > >>
>> > >>
>> > >>
>> > >> Thank you,
>> > >> Alena.
>> > >>
>> > >> On 7/16/14, 4:47 AM, "Daan Hoogland" 
>>wrote:
>> > >>
>> > >> >On Thu, Jul 3, 2014 at 1:41 AM, Marcus 
>>wrote:
>> > >> >> I tested this release with
>> > >> >> cherry-picking 2ec7359b4eb501b0d9e80ed87af7a54938e9d505 from
>> > >> >>4.4-forward.
>> > >> >
>> > >> >
>> > >> >I have cherry-picked and pushed. I will address the last remaining
>> > >> >issue by editting the pom.xml from build_asf.sh and roll out a new
>> RC.
>> > >> >
>> > >> >Hope all of you have continued testing and have now more issues to
>> > >> >block this release
>> > >> >
>> > >> >--
>> > >> >Daan
>> > >>
>> > >>
>> >
>> >
>>

Re: [ACS 4.4] Cherry pick request

[Daan Hoogland]

On Thu, Jul 17, 2014 at 11:19 PM, Amogh Vasekar
 wrote:
> c8ca15b95a57a3d79b71c76c913e295f6490f05d

Amogh, it has conflicts. I will have a look at those in the morning

-- 
Daan

Re: [ACS 4.4] Cherry pick request

[Daan Hoogland]

Amogh, I couldn't help myself. please have a look at the resulting
setup/db/db/schema-430to440.sql

On Thu, Jul 17, 2014 at 11:35 PM, Daan Hoogland  wrote:
> On Thu, Jul 17, 2014 at 11:19 PM, Amogh Vasekar
>  wrote:
>> c8ca15b95a57a3d79b71c76c913e295f6490f05d
>
> Amogh, it has conflicts. I will have a look at those in the morning
>
> --
> Daan



-- 
Daan

Re: [ACS 4.4] Cherry pick request

[Amogh Vasekar]

Seems good, looks like was an issue with a newline somewhere. But deploydb
went fine on 4.4

Thanks,
Amogh

On 7/17/14 2:42 PM, "Daan Hoogland"  wrote:

>Amogh, I couldn't help myself. please have a look at the resulting
>setup/db/db/schema-430to440.sql
>
>On Thu, Jul 17, 2014 at 11:35 PM, Daan Hoogland 
>wrote:
>> On Thu, Jul 17, 2014 at 11:19 PM, Amogh Vasekar
>>  wrote:
>>> c8ca15b95a57a3d79b71c76c913e295f6490f05d
>>
>> Amogh, it has conflicts. I will have a look at those in the morning
>>
>> --
>> Daan
>
>
>
>-- 
>Daan

Re: [ACS 4.4] Cherry pick request

[Daan Hoogland]

sure? I saw that the last few lines where not in the last version.

I'm not confortable with this bit, it has been coming up a few time
before already looks like some commit on 4.4-forward is trying to
sneak it's way into the release:

@@ -2439,4 +2474,16 @@
   CONSTRAINT `fk_lb_healthcheck_policy_details__lb_healthcheck_policy_id`
FOREIGN KEY 
`fk_lb_healthcheck_policy_details__lb_healthcheck_policy_id`(`lb_policy_id`)
REFERENCES `load_balancer_healthcheck_policies`(`id`) ON DELETE
CASCADE
 ) ENGINE=InnoDB DEFAULT CHARSET=utf8;

+ALTER TABLE `cloud`.`snapshot_policy` ADD COLUMN `display` tinyint(1)
NOT NULL DEFAULT '1' COMMENT 'True if the policy can be displayed to
the end user';
+
+CREATE TABLE `cloud`.`snapshot_policy_details` (
+  `id` bigint unsigned NOT NULL auto_increment,
+  `policy_id` bigint unsigned NOT NULL COMMENT 'snapshot policy id',
+  `name` varchar(255) NOT NULL,
+  `value` varchar(1024) NOT NULL,
+  `display` tinyint(1) NOT NULL DEFAULT '1' COMMENT 'True if the
detail can be displayed to the end user',
+  PRIMARY KEY (`id`),
+  CONSTRAINT `fk_snapshot_policy_details__snapshot_policy_id` FOREIGN
KEY `fk_snapshot_policy_details__snapshot_policy_id`(`policy_id`)
REFERENCES `snapshot_policy`(`id`) ON DELETE CASCADE
+) ENGINE=InnoDB DEFAULT CHARSET=utf8;
+
 INSERT INTO `cloud`.`configuration`(category, instance, component,
name, value, description, default_value) VALUES ('Advanced',
'DEFAULT', 'management-server', 'vm.password.length', '6', 'Specifies
the length of a randomly generated password', '6') ON DUPLICATE KEY
UPDATE category='Advanced';

On Thu, Jul 17, 2014 at 11:53 PM, Amogh Vasekar
 wrote:
> Seems good, looks like was an issue with a newline somewhere. But deploydb
> went fine on 4.4
>
> Thanks,
> Amogh
>
> On 7/17/14 2:42 PM, "Daan Hoogland"  wrote:
>
>>Amogh, I couldn't help myself. please have a look at the resulting
>>setup/db/db/schema-430to440.sql
>>
>>On Thu, Jul 17, 2014 at 11:35 PM, Daan Hoogland 
>>wrote:
>>> On Thu, Jul 17, 2014 at 11:19 PM, Amogh Vasekar
>>>  wrote:
 c8ca15b95a57a3d79b71c76c913e295f6490f05d
>>>
>>> Amogh, it has conflicts. I will have a look at those in the morning
>>>
>>> --
>>> Daan
>>
>>
>>
>>--
>>Daan
>



-- 
Daan

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

[Ritu Sabharwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/
---

(Updated July 17, 2014, 10:04 p.m.)


Review request for cloudstack and Hugo Trippaers.


Changes
---

Added marvin integration test.


Bugs: CLOUDSTACK-6823
https://issues.apache.org/jira/browse/CLOUDSTACK-6823


Repository: cloudstack-git


Description
---

First code drop for Brocade Network plugin to orchestrate Brocade VDX switches 
for L2 connectivity. Please create a new branch for Brocade plugin.


Diffs (updated)
-

  api/src/com/cloud/network/Network.java 885bffe 
  api/src/com/cloud/network/Networks.java 1e4d229 
  api/src/com/cloud/network/PhysicalNetwork.java 8cc214e 
  api/src/org/apache/cloudstack/network/ExternalNetworkDeviceManager.java 
e73f526 
  client/WEB-INF/classes/resources/messages.properties b504a18 
  client/WEB-INF/classes/resources/messages_zh_CN.properties 1ec4e95 
  client/pom.xml 29fef4f 
  client/tomcatconf/commands.properties.in d247aa0 
  plugins/pom.xml b5e6a61 
  setup/db/db/schema-440to450.sql 77445a9 
  setup/dev/advancedvcs.cfg PRE-CREATION 
  test/integration/component/test_brocade_vcs.py PRE-CREATION 
  tools/apidoc/gen_toc.py 827d6bf 
  ui/dictionary.jsp 9026a36 
  ui/scripts/system.js 9a98a5c 
  ui/scripts/ui-custom/zoneWizard.js 4091c03 

Diff: https://reviews.apache.org/r/22863/diff/


Testing
---

•   Create an isolated network; verify that the port-profile is created on 
the Brocade switch.
•   Attach a VM to the network; verify that the VMs MAC address is 
associated with the port profile of the network on the Brocade switch.
•   Delete VMs for an isolated network; verify that the VMs MAC address is 
disassociated with the port profile of the network on the Brocade switch.
•   Delete the isolated network; verify that the port-profile is deleted 
from the Brocade switch.


File Attachments


Diff for the existing cloudstack code
  
https://reviews.apache.org/media/uploaded/files/2014/06/23/8fc3cfb1-7a21-4714-98f3-6514cf54ba84__diff
Patch file for Brocade functionality code
  
https://reviews.apache.org/media/uploaded/files/2014/06/26/92bb0014-a7b7-4f0b-97c9-018d615b658a__brocade-vcs.patch


Thanks,

Ritu  Sabharwal

Re: [ACS 4.4] Cherry pick request

[Nitin Mehta]

Hi Daan - I am not sure I get your point here. These changes were put in
as I want them in 4.4.1, but were not critical enough to be put in 4.4.

Thanks,
-Nitin

On 17/07/14 2:58 PM, "Daan Hoogland"  wrote:

>sure? I saw that the last few lines where not in the last version.
>
>I'm not confortable with this bit, it has been coming up a few time
>before already looks like some commit on 4.4-forward is trying to
>sneak it's way into the release:
>
>@@ -2439,4 +2474,16 @@
>   CONSTRAINT `fk_lb_healthcheck_policy_details__lb_healthcheck_policy_id`
>FOREIGN KEY 
>`fk_lb_healthcheck_policy_details__lb_healthcheck_policy_id`(`lb_policy_id
>`)
>REFERENCES `load_balancer_healthcheck_policies`(`id`) ON DELETE
>CASCADE
> ) ENGINE=InnoDB DEFAULT CHARSET=utf8;
>
>+ALTER TABLE `cloud`.`snapshot_policy` ADD COLUMN `display` tinyint(1)
>NOT NULL DEFAULT '1' COMMENT 'True if the policy can be displayed to
>the end user';
>+
>+CREATE TABLE `cloud`.`snapshot_policy_details` (
>+  `id` bigint unsigned NOT NULL auto_increment,
>+  `policy_id` bigint unsigned NOT NULL COMMENT 'snapshot policy id',
>+  `name` varchar(255) NOT NULL,
>+  `value` varchar(1024) NOT NULL,
>+  `display` tinyint(1) NOT NULL DEFAULT '1' COMMENT 'True if the
>detail can be displayed to the end user',
>+  PRIMARY KEY (`id`),
>+  CONSTRAINT `fk_snapshot_policy_details__snapshot_policy_id` FOREIGN
>KEY `fk_snapshot_policy_details__snapshot_policy_id`(`policy_id`)
>REFERENCES `snapshot_policy`(`id`) ON DELETE CASCADE
>+) ENGINE=InnoDB DEFAULT CHARSET=utf8;
>+
> INSERT INTO `cloud`.`configuration`(category, instance, component,
>name, value, description, default_value) VALUES ('Advanced',
>'DEFAULT', 'management-server', 'vm.password.length', '6', 'Specifies
>the length of a randomly generated password', '6') ON DUPLICATE KEY
>UPDATE category='Advanced';
>
>On Thu, Jul 17, 2014 at 11:53 PM, Amogh Vasekar
> wrote:
>> Seems good, looks like was an issue with a newline somewhere. But
>>deploydb
>> went fine on 4.4
>>
>> Thanks,
>> Amogh
>>
>> On 7/17/14 2:42 PM, "Daan Hoogland"  wrote:
>>
>>>Amogh, I couldn't help myself. please have a look at the resulting
>>>setup/db/db/schema-430to440.sql
>>>
>>>On Thu, Jul 17, 2014 at 11:35 PM, Daan Hoogland
>>>
>>>wrote:
 On Thu, Jul 17, 2014 at 11:19 PM, Amogh Vasekar
  wrote:
> c8ca15b95a57a3d79b71c76c913e295f6490f05d

 Amogh, it has conflicts. I will have a look at those in the morning

 --
 Daan
>>>
>>>
>>>
>>>--
>>>Daan
>>
>
>
>
>-- 
>Daan

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

[Ritu Sabharwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/
---

(Updated July 17, 2014, 11:52 p.m.)


Review request for cloudstack and Hugo Trippaers.


Changes
---

Removed the cfg file from patch. Only for testing.


Bugs: CLOUDSTACK-6823
https://issues.apache.org/jira/browse/CLOUDSTACK-6823


Repository: cloudstack-git


Description
---

First code drop for Brocade Network plugin to orchestrate Brocade VDX switches 
for L2 connectivity. Please create a new branch for Brocade plugin.


Diffs (updated)
-

  api/src/com/cloud/network/Network.java 885bffe 
  api/src/com/cloud/network/Networks.java 1e4d229 
  api/src/com/cloud/network/PhysicalNetwork.java 8cc214e 
  api/src/org/apache/cloudstack/network/ExternalNetworkDeviceManager.java 
e73f526 
  client/WEB-INF/classes/resources/messages.properties b504a18 
  client/WEB-INF/classes/resources/messages_zh_CN.properties 1ec4e95 
  client/pom.xml 29fef4f 
  client/tomcatconf/commands.properties.in d247aa0 
  plugins/pom.xml b5e6a61 
  setup/db/db/schema-440to450.sql 77445a9 
  test/integration/component/test_brocade_vcs.py PRE-CREATION 
  tools/apidoc/gen_toc.py 827d6bf 
  ui/dictionary.jsp 9026a36 
  ui/scripts/system.js 9a98a5c 
  ui/scripts/ui-custom/zoneWizard.js 4091c03 

Diff: https://reviews.apache.org/r/22863/diff/


Testing (updated)
---

•   Create an isolated network; verify that the port-profile is created on 
the Brocade switch.
•   Attach a VM to the network; verify that the VMs MAC address is 
associated with the port profile of the network on the Brocade switch.
•   Delete VMs for an isolated network; verify that the VMs MAC address is 
disassociated with the port profile of the network on the Brocade switch.
•   Delete the isolated network; verify that the port-profile is deleted 
from the Brocade switch.

Integration test result:

Test Brocade Network and VM Creation ... === TestName: test_network_vcs | 
Status : SUCCESS ===
ok

--
Ran 1 test in 297.497s

OK


File Attachments


Diff for the existing cloudstack code
  
https://reviews.apache.org/media/uploaded/files/2014/06/23/8fc3cfb1-7a21-4714-98f3-6514cf54ba84__diff
Patch file for Brocade functionality code
  
https://reviews.apache.org/media/uploaded/files/2014/06/26/92bb0014-a7b7-4f0b-97c9-018d615b658a__brocade-vcs.patch


Thanks,

Ritu  Sabharwal

VirtualRoutingResource bugs CLOUDSTACK-7111 after refactor

[Sheng Yang]

Hi Hugo,

I saw you refactor the VirtualRoutingResource, but it introduced
https://issues.apache.org/jira/browse/CLOUDSTACK-7111 .

Here are the lines you deleted.

-ExecutionResult result = new ExecutionResult(true, "No
configure to be applied");
-for (ConfigItem c : cfg) {
-result = applyConfigToVR(cmd, c);
-if (!result.isSuccess()) {
-break;
-}
-}
-return new Answer(cmd, result.isSuccess(),
result.getDetails());
-}

The result is true by default, because in some cases, configuration won't
be generated since VR determined it's not necessary, for example when VPN
is created first time, there is no VPN user available. So cfg can be null
and success.

And here is the new code.

boolean finalResult = false;
for (ConfigItem configItem : cfg) {
ExecutionResult result =
applyConfigToVR(cmd.getRouterAccessIp(), configItem);
if (result == null) {
result = new ExecutionResult(false, "null execution
result");
}
results.add(result);
details.add(configItem.getInfo() + (result.isSuccess() ? " -
success: " : " - failed: ") + result.getDetails());
finalResult = result.isSuccess();
}

// Not sure why this matters, but log it anyway
if (cmd.getAnswersCount() != results.size()) {
s_logger.warn("Expected " + cmd.getAnswersCount() + " answers
while executing " + cmd.getClass().getSimpleName() + " but received " +
results.size());
}

If cfg is null, then you would have less Answers than cfg.

Then finalResult is false in the new code, which caused bug on create VPN
failure.

Could you check on it?

Thanks.

--Sheng

Build failed in Jenkins: build-master #1147

[jenkins]

See 

Changes:

[sheng.yang] CLOUDSTACK-7124: Fix semicolon caused VPN programming issue

--
[...truncated 935 lines...]
Audit done.

[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ 
cloud-framework-security ---
[INFO] 
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ 
cloud-framework-security ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 1 resource
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ 
cloud-framework-security ---
[INFO] Compiling 7 source files to 

[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-framework-security ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ 
cloud-framework-security ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.12:test (default-test) @ 
cloud-framework-security ---
[INFO] Surefire report directory: 


---
 T E S T S
---

Results :

Tests run: 0, Failures: 0, Errors: 0, Skipped: 0

[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Core 4.5.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ cloud-core ---
[INFO] Deleting 
 (includes = 
[**/*], excludes = [])
[INFO] Deleting  
(includes = [target, dist], excludes = [])
[INFO] 
[INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ 
cloud-core ---
[INFO] Starting audit...
Audit done.

[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ cloud-core ---
[INFO] 
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ 
cloud-core ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 26 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ cloud-core 
---
[INFO] Compiling 329 source files to 

[INFO] 
[INFO] --- license-maven-plugin:2.5:check (cloudstack-checklicence) @ 
cloud-core ---
[INFO] Checking licenses...
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-core ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ 
cloud-core ---
[INFO] Compiling 21 source files to 

[INFO] 
[INFO] --- maven-surefire-plugin:2.12:test (default-test) @ cloud-core ---
[INFO] Surefire report directory: 


---
 T E S T S
---
Running com.cloud.network.HAProxyConfiguratorTest
log4j:WARN No appenders could be found for logger 
(com.cloud.network.HAProxyConfigurator).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more 
info.
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.134 sec
Running com.cloud.agent.resource.virtualnetwork.VirtualRoutingResourceTest
Tests run: 20, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.562 sec <<< 
FAILURE!
Running com.cloud.agent.transport.RequestTest
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.282 sec
Running org.apache.cloudstack.api.agent.test.BackupSnapshotAnswerTest
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.015 sec
Running org.apache.cloudstack.api.agent.test.AttachVolumeCommandTest
Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.005 sec
Running org.apache.cloudstack.api.agent.test.ChangeAgentCommandTest
Te

Jenkins build is back to normal : build-master #1148

[jenkins]

See 

Re: [ACS4.5] When is feature freeze?

[Mike Tutkowski]

So, how do we plan on enforcing feature freeze (July 19th) without a RM for
4.5?

I would take the role, but I don't have the bandwidth it demands.


On Wed, Jul 16, 2014 at 5:36 AM, Daan Hoogland 
wrote:

> On Wed, Jul 16, 2014 at 8:55 AM, Sebastien Goasguen 
> wrote:
> >
> > On Jul 16, 2014, at 2:38 AM, Daan Hoogland 
> wrote:
> >
> >> I hope so, but we don't have a release manager.
> >>
> >
> > What's the point of talking 4.5 when 4.4 is not out of the door …
> It makes perfect sense to do a feature freeze on the next release when
> the load of getting features right is stopping us from releasing this
> one.
>
> >
> > Honestly, there is something very broken in the way we do things.
> something? we all know what.
>
>
>
> --
> Daan
>



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
*™*

Re: Review Request 23282: CLOUDSTACK-6845 : First Code drop for NuageVsp Network plugin

[Suresh Ramamurthy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23282/
---

(Updated July 18, 2014, 3:15 a.m.)


Review request for cloudstack, Alena Prokharchyk, Hugo Trippaers, and Sheng 
Yang.


Changes
---

Hi Hugo,

We have added more unit test for all the major classes like Manager, Element, 
Guru and Resource. It has around 43% of the code coveragen now.
We also added marvin integration cases and also verified the results. Our 
integration test covers

1. Setup stage.
a. The testcase check for the presence of the nuage VSP as network service 
provider
b. If it does not exist the testcase adds it, and also adds the Nuage vsp 
device
c. Network offering is created and enabled
2. Start testcase
a. Create network using network offering
b. Start 1 vm
c. Verify that this vm is in Running state.
d. Start another vm
e. Verify that this vm is in Running state.
f. Delete vms
g. Delete network and verify
3. Teardown

Could you please have a look at the diffs and let us know if we are fine with 
our plugin code changes?

Thanks,
Suresh Ramamurthy


Bugs: CLOUDSTACK-6845
https://issues.apache.org/jira/browse/CLOUDSTACK-6845


Repository: cloudstack-git


Description
---

This is first code drop for NuageVsp Network plugin support that will bring the 
Nuage VSP network virtualization technology to CloudStack.

We need a new branch to checkin the fixes once the review is done. Please 
create a new branch for NuageVsp plugin.


Diffs (updated)
-

  api/src/com/cloud/event/EventTypes.java 71bfdb6 
  api/src/com/cloud/network/Network.java 885bffe 
  api/src/com/cloud/network/Networks.java 1e4d229 
  api/src/com/cloud/network/PhysicalNetwork.java 8cc214e 
  client/WEB-INF/classes/resources/messages.properties b192cb0 
  client/WEB-INF/classes/resources/messages_zh_CN.properties 1ec4e95 
  client/pom.xml 46933d9 
  client/tomcatconf/commands.properties.in b9ac27b 
  
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/OvsVifDriver.java 
8e4c710 
  
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 0922765 
  
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
 5881d68 
  plugins/network-elements/nuage-vsp/pom.xml PRE-CREATION 
  
plugins/network-elements/nuage-vsp/resources/META-INF/cloudstack/vsp/module.properties
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/resources/META-INF/cloudstack/vsp/spring-vsp-context.xml
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/StartupVspCommand.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/VspResourceAnswer.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/VspResourceCommand.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyAclRuleVspAnswer.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyAclRuleVspCommand.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyStaticNatVspAnswer.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyStaticNatVspCommand.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ShutDownVpcVspAnswer.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ShutDownVpcVspCommand.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/DeallocateVmVspAnswer.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/DeallocateVmVspCommand.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ImplementNetworkVspAnswer.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ImplementNetworkVspCommand.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ReleaseVmVspAnswer.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ReleaseVmVspCommand.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ReserveVmInterfaceVspAnswer.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ReserveVmInterfaceVspCommand.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/TrashNetworkVspAnswer.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/TrashNetworkVspCommand.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/sync/SyncVspAnswer.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/sync/SyncVspCommand.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cl

Re: Question regarding Quiesce VM feature in ACS 4.3 wrt XEN hypervisor

[Mike Tutkowski]

Hi Amit,

I don't really know these details in depth (NetApp added this feature in
v4.3).

I have CCed David La Motta from NetApp. Perhaps he can explain more than I
did.

I do know that from a storage standpoint you don't have to implement
anything if you just want to ignore this feature.

The idea is that if you want to support this feature, then you (I think)
need to implement a snapshot strategy (a CS interface) (or perhaps use the
one NetApp implemented).

The overall idea is that this works for NFS if you want to take a snapshot
of a file on a share and you want to try to take the snapshot when the VM
is in a quiesced state.

Step one is the VM gets quiesced.

Step two is a hypervisor snapshot is taken (which leads to a new (delta)
file on the XenServer Shared (NFS) Storage Repository).

Step three is you can have your storage plug-in notified and it can take a
snapshot of this new file.

Step four is cleanup related on the hypervisor: The VM snapshot is deleted
and the delta file can be merged back into its parent by XenServer.

I think the reason we take a hypervisor snapshot is so we can then quickly
un-quiesce the VM and asynchronously have the storage plug-in take its
snapshot. Then we can later go back and delete the hypervisor snapshot, so
this virtual disk can have its parent and delta files merged back together.

Talk to you later,
Mike


On Wed, Jul 16, 2014 at 9:31 AM, Amit Das  wrote:

> W.r.t hypervisor specific snapshots :
> - why is this snapshot required when a VM or its hypervisor supports
> quiesce operation.
> - what exactly happens during hypervisor snapshot ? Can this step be
> excluded.
>
>
> On Wednesday, July 16, 2014, Mike Tutkowski 
> wrote:
>
>> This line at the bottom of my previous e-mail was redundant...I meant to
>> remove it before sending:
>>
>> A vendor snapshot can be created of the hypervisor snapshot file, then CS
>> can automatically delete
>>
>>
>> On Wed, Jul 16, 2014 at 8:10 AM, Mike Tutkowski <
>> mike.tutkow...@solidfire.com> wrote:
>>
>>> I believe this is what happens:
>>>
>>> * The VM gets quiesced.
>>> * Hypervisor snapshots are taken of all VM disks (so a new delta file
>>> shows up on each applicable SR).
>>>  * The applicable storage plug-in can be invoked to take a
>>> vendor-specific snapshot of a given hypervisor snapshot delta file.
>>> * Once the storage plug-in is done, CS can delete the hypervisor
>>> snapshot delta file(s) that was/were created.
>>>
>>> A couple notes about this:
>>>
>>> * Since you are taking a vendor-side snap of a particular file, this
>>> relates to NFS.
>>>
>>> * I believe all disks of the VM need to be supported by the same storage
>>> vendor (i.e. if the root and data disks are on different SRs, each SR needs
>>> to be supported by the storage of the same backend vendor)
>>>
>>> A vendor snapshot can be created of the hypervisor snapshot file, then
>>> CS can automatically delete
>>>
>>> On Wednesday, July 16, 2014, Punith S  wrote:
>>>
 hi,

 while i was referring the ACS 4.3 doc for VM snapshot,
 i see a feature Quiesce VM supported only by vmware hypervisor if the
 cloudstack default primary storage is used,
 but it also mentions that Quiesce VM can be supported if you are using a
 third party primary storage plugin, the quiesce operation is provided by
 plugin implementation!

 is Quiesce VM is a limitation of  XEN hypervisor or is it not
 implemented
 by xen agent in cloudstack ?

 how is third party primary storage plugin related to hypervisor feature
 ?

 --
 regards,

 punith s
 cloudbyte.com

>>>
>>
>>
>> --
>> *Mike Tutkowski*
>> *Senior CloudStack Developer, SolidFire Inc.*
>> e: mike.tutkow...@solidfire.com
>> o: 303.746.7302
>> Advancing the way the world uses the cloud
>> *™*
>>
>
>
> --
> Regards,
> Amit
> *CloudByte Inc.* 
>
>


-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
*™*

Re: [ACS 4.4] Cherry pick request

[Daan Hoogland]

They keep coming in with cherry-picks that include this file. I will
remove them.

On Fri, Jul 18, 2014 at 12:22 AM, Nitin Mehta  wrote:
> Hi Daan - I am not sure I get your point here. These changes were put in
> as I want them in 4.4.1, but were not critical enough to be put in 4.4.
>
> Thanks,
> -Nitin
>
> On 17/07/14 2:58 PM, "Daan Hoogland"  wrote:
>
>>sure? I saw that the last few lines where not in the last version.
>>
>>I'm not confortable with this bit, it has been coming up a few time
>>before already looks like some commit on 4.4-forward is trying to
>>sneak it's way into the release:
>>
>>@@ -2439,4 +2474,16 @@
>>   CONSTRAINT `fk_lb_healthcheck_policy_details__lb_healthcheck_policy_id`
>>FOREIGN KEY
>>`fk_lb_healthcheck_policy_details__lb_healthcheck_policy_id`(`lb_policy_id
>>`)
>>REFERENCES `load_balancer_healthcheck_policies`(`id`) ON DELETE
>>CASCADE
>> ) ENGINE=InnoDB DEFAULT CHARSET=utf8;
>>
>>+ALTER TABLE `cloud`.`snapshot_policy` ADD COLUMN `display` tinyint(1)
>>NOT NULL DEFAULT '1' COMMENT 'True if the policy can be displayed to
>>the end user';
>>+
>>+CREATE TABLE `cloud`.`snapshot_policy_details` (
>>+  `id` bigint unsigned NOT NULL auto_increment,
>>+  `policy_id` bigint unsigned NOT NULL COMMENT 'snapshot policy id',
>>+  `name` varchar(255) NOT NULL,
>>+  `value` varchar(1024) NOT NULL,
>>+  `display` tinyint(1) NOT NULL DEFAULT '1' COMMENT 'True if the
>>detail can be displayed to the end user',
>>+  PRIMARY KEY (`id`),
>>+  CONSTRAINT `fk_snapshot_policy_details__snapshot_policy_id` FOREIGN
>>KEY `fk_snapshot_policy_details__snapshot_policy_id`(`policy_id`)
>>REFERENCES `snapshot_policy`(`id`) ON DELETE CASCADE
>>+) ENGINE=InnoDB DEFAULT CHARSET=utf8;
>>+
>> INSERT INTO `cloud`.`configuration`(category, instance, component,
>>name, value, description, default_value) VALUES ('Advanced',
>>'DEFAULT', 'management-server', 'vm.password.length', '6', 'Specifies
>>the length of a randomly generated password', '6') ON DUPLICATE KEY
>>UPDATE category='Advanced';
>>
>>On Thu, Jul 17, 2014 at 11:53 PM, Amogh Vasekar
>> wrote:
>>> Seems good, looks like was an issue with a newline somewhere. But
>>>deploydb
>>> went fine on 4.4
>>>
>>> Thanks,
>>> Amogh
>>>
>>> On 7/17/14 2:42 PM, "Daan Hoogland"  wrote:
>>>
Amogh, I couldn't help myself. please have a look at the resulting
setup/db/db/schema-430to440.sql

On Thu, Jul 17, 2014 at 11:35 PM, Daan Hoogland

wrote:
> On Thu, Jul 17, 2014 at 11:19 PM, Amogh Vasekar
>  wrote:
>> c8ca15b95a57a3d79b71c76c913e295f6490f05d
>
> Amogh, it has conflicts. I will have a look at those in the morning
>
> --
> Daan



--
Daan
>>>
>>
>>
>>
>>--
>>Daan
>



-- 
Daan

Re: [ACS 4.4] Cherry pick request

[Mike Tutkowski]

Perhaps there is some confusion again as to the nature of the 4.4-forward
branch.

A while back, we agreed that changes put in here would not be cherry picked
to 4.4 unless requested so by the developer and agreed to by the RM.

Changes in 4.4-forward that do not go into 4.4 will at least go into 4.4.1
(assuming such a release happens).


On Thu, Jul 17, 2014 at 9:48 PM, Daan Hoogland 
wrote:

> They keep coming in with cherry-picks that include this file. I will
> remove them.
>
> On Fri, Jul 18, 2014 at 12:22 AM, Nitin Mehta 
> wrote:
> > Hi Daan - I am not sure I get your point here. These changes were put in
> > as I want them in 4.4.1, but were not critical enough to be put in 4.4.
> >
> > Thanks,
> > -Nitin
> >
> > On 17/07/14 2:58 PM, "Daan Hoogland"  wrote:
> >
> >>sure? I saw that the last few lines where not in the last version.
> >>
> >>I'm not confortable with this bit, it has been coming up a few time
> >>before already looks like some commit on 4.4-forward is trying to
> >>sneak it's way into the release:
> >>
> >>@@ -2439,4 +2474,16 @@
> >>   CONSTRAINT
> `fk_lb_healthcheck_policy_details__lb_healthcheck_policy_id`
> >>FOREIGN KEY
>
> >>`fk_lb_healthcheck_policy_details__lb_healthcheck_policy_id`(`lb_policy_id
> >>`)
> >>REFERENCES `load_balancer_healthcheck_policies`(`id`) ON DELETE
> >>CASCADE
> >> ) ENGINE=InnoDB DEFAULT CHARSET=utf8;
> >>
> >>+ALTER TABLE `cloud`.`snapshot_policy` ADD COLUMN `display` tinyint(1)
> >>NOT NULL DEFAULT '1' COMMENT 'True if the policy can be displayed to
> >>the end user';
> >>+
> >>+CREATE TABLE `cloud`.`snapshot_policy_details` (
> >>+  `id` bigint unsigned NOT NULL auto_increment,
> >>+  `policy_id` bigint unsigned NOT NULL COMMENT 'snapshot policy id',
> >>+  `name` varchar(255) NOT NULL,
> >>+  `value` varchar(1024) NOT NULL,
> >>+  `display` tinyint(1) NOT NULL DEFAULT '1' COMMENT 'True if the
> >>detail can be displayed to the end user',
> >>+  PRIMARY KEY (`id`),
> >>+  CONSTRAINT `fk_snapshot_policy_details__snapshot_policy_id` FOREIGN
> >>KEY `fk_snapshot_policy_details__snapshot_policy_id`(`policy_id`)
> >>REFERENCES `snapshot_policy`(`id`) ON DELETE CASCADE
> >>+) ENGINE=InnoDB DEFAULT CHARSET=utf8;
> >>+
> >> INSERT INTO `cloud`.`configuration`(category, instance, component,
> >>name, value, description, default_value) VALUES ('Advanced',
> >>'DEFAULT', 'management-server', 'vm.password.length', '6', 'Specifies
> >>the length of a randomly generated password', '6') ON DUPLICATE KEY
> >>UPDATE category='Advanced';
> >>
> >>On Thu, Jul 17, 2014 at 11:53 PM, Amogh Vasekar
> >> wrote:
> >>> Seems good, looks like was an issue with a newline somewhere. But
> >>>deploydb
> >>> went fine on 4.4
> >>>
> >>> Thanks,
> >>> Amogh
> >>>
> >>> On 7/17/14 2:42 PM, "Daan Hoogland"  wrote:
> >>>
> Amogh, I couldn't help myself. please have a look at the resulting
> setup/db/db/schema-430to440.sql
> 
> On Thu, Jul 17, 2014 at 11:35 PM, Daan Hoogland
> 
> wrote:
> > On Thu, Jul 17, 2014 at 11:19 PM, Amogh Vasekar
> >  wrote:
> >> c8ca15b95a57a3d79b71c76c913e295f6490f05d
> >
> > Amogh, it has conflicts. I will have a look at those in the morning
> >
> > --
> > Daan
> 
> 
> 
> --
> Daan
> >>>
> >>
> >>
> >>
> >>--
> >>Daan
> >
>
>
>
> --
> Daan
>



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
*™*

Re: Review Request 23410: Improvised CloudByte Storage Plugin for 4.5 and above. jira id : CLOUDSTACK-7098

[Mike Tutkowski]

> On July 17, 2014, 10:06 p.m., Mike Tutkowski wrote:
> > Ship It!

Changes were put into ACS repo with this commit:

f3cbb699955243007ffb53b335d9508b2e422a06


- Mike


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23410/#review48107
---


On July 15, 2014, 8:18 a.m., punith s wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23410/
> ---
> 
> (Updated July 15, 2014, 8:18 a.m.)
> 
> 
> Review request for cloudstack, amit kumar das, edison su, and Mike Tutkowski.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> The new improvised cloudbyte plugin for cloudstack supports the following 
> features
> 
> * support for managed storage, where each vm disk has the guaranteed QoS.
> 
> * supports resize of the volume.
> 
> * supports both iscsi and nfs protocols in XEN server, and iscsi protocol for 
> KVM and vmware ESX with respect to managed storage.
> 
> * supports storage level snapshot capabilites as well as hypervisor level 
> snapshot feature.
> 
> * also exposing the custom api's for better ui integration.
> 
> * support for unlimited storage nodes across the sites.
> 
> * account integration in cloudbyte with respect to domains in cloudstack.
> 
> 
> Diffs
> -
> 
>   
> plugins/storage/volume/cloudbyte/resources/META-INF/cloudstack/storage-volume-cloudbyte/spring-storage-volume-cloudbyte-context.xml
>  87c5f51 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/driver/ElastistorPrimaryDataStoreDriver.java
>  99d1e2a 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/lifecycle/ElastistorPrimaryDataStoreLifeCycle.java
>  33004e3 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/provider/ElastistorHostListener.java
>  de4711a 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/provider/ElastistorPrimaryDataStoreProvider.java
>  e591082 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ElastistorUtil.java
>  b75d12a 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ElastistorVolumeApiService.java
>  PRE-CREATION 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ElastistorVolumeApiServiceImpl.java
>  PRE-CREATION 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ListElastistorInterfaceCmd.java
>  PRE-CREATION 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ListElastistorInterfaceResponse.java
>  PRE-CREATION 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ListElastistorPoolCmd.java
>  PRE-CREATION 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ListElastistorPoolResponse.java
>  PRE-CREATION 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ListElastistorVolumeCmd.java
>  PRE-CREATION 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ListElastistorVolumeResponse.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/23410/diff/
> 
> 
> Testing
> ---
> 
> system testing done.
> 
> 
> Thanks,
> 
> punith s
> 
>

Re: Review Request 23410: Improvised CloudByte Storage Plugin for 4.5 and above. jira id : CLOUDSTACK-7098

[Mike Tutkowski]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23410/#review48107
---

Ship it!


Ship It!

- Mike Tutkowski


On July 15, 2014, 8:18 a.m., punith s wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23410/
> ---
> 
> (Updated July 15, 2014, 8:18 a.m.)
> 
> 
> Review request for cloudstack, amit kumar das, edison su, and Mike Tutkowski.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> The new improvised cloudbyte plugin for cloudstack supports the following 
> features
> 
> * support for managed storage, where each vm disk has the guaranteed QoS.
> 
> * supports resize of the volume.
> 
> * supports both iscsi and nfs protocols in XEN server, and iscsi protocol for 
> KVM and vmware ESX with respect to managed storage.
> 
> * supports storage level snapshot capabilites as well as hypervisor level 
> snapshot feature.
> 
> * also exposing the custom api's for better ui integration.
> 
> * support for unlimited storage nodes across the sites.
> 
> * account integration in cloudbyte with respect to domains in cloudstack.
> 
> 
> Diffs
> -
> 
>   
> plugins/storage/volume/cloudbyte/resources/META-INF/cloudstack/storage-volume-cloudbyte/spring-storage-volume-cloudbyte-context.xml
>  87c5f51 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/driver/ElastistorPrimaryDataStoreDriver.java
>  99d1e2a 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/lifecycle/ElastistorPrimaryDataStoreLifeCycle.java
>  33004e3 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/provider/ElastistorHostListener.java
>  de4711a 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/provider/ElastistorPrimaryDataStoreProvider.java
>  e591082 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ElastistorUtil.java
>  b75d12a 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ElastistorVolumeApiService.java
>  PRE-CREATION 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ElastistorVolumeApiServiceImpl.java
>  PRE-CREATION 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ListElastistorInterfaceCmd.java
>  PRE-CREATION 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ListElastistorInterfaceResponse.java
>  PRE-CREATION 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ListElastistorPoolCmd.java
>  PRE-CREATION 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ListElastistorPoolResponse.java
>  PRE-CREATION 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ListElastistorVolumeCmd.java
>  PRE-CREATION 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ListElastistorVolumeResponse.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/23410/diff/
> 
> 
> Testing
> ---
> 
> system testing done.
> 
> 
> Thanks,
> 
> punith s
> 
>

Re: [ACS 4.4] Cherry pick request

[Daan Hoogland]

That is not the confusion Mike. The problem is that some changes that
don't go into 4.4 keep causing conflicts. I made the mistake of adding
the conflicting lines this time. this 4.4-forward branch is not
suitable for providing cherry-picks for an RM because of this. I thin
people should just branch 4.4 for their changes and let me cherry-pick
from there. Also the automation tests running on 4.4-forward instead
of 4.4 is not very useful.



On Fri, Jul 18, 2014 at 6:00 AM, Mike Tutkowski
 wrote:
> Perhaps there is some confusion again as to the nature of the 4.4-forward
> branch.
>
> A while back, we agreed that changes put in here would not be cherry picked
> to 4.4 unless requested so by the developer and agreed to by the RM.
>
> Changes in 4.4-forward that do not go into 4.4 will at least go into 4.4.1
> (assuming such a release happens).
>
>
> On Thu, Jul 17, 2014 at 9:48 PM, Daan Hoogland 
> wrote:
>
>> They keep coming in with cherry-picks that include this file. I will
>> remove them.
>>
>> On Fri, Jul 18, 2014 at 12:22 AM, Nitin Mehta 
>> wrote:
>> > Hi Daan - I am not sure I get your point here. These changes were put in
>> > as I want them in 4.4.1, but were not critical enough to be put in 4.4.
>> >
>> > Thanks,
>> > -Nitin
>> >
>> > On 17/07/14 2:58 PM, "Daan Hoogland"  wrote:
>> >
>> >>sure? I saw that the last few lines where not in the last version.
>> >>
>> >>I'm not confortable with this bit, it has been coming up a few time
>> >>before already looks like some commit on 4.4-forward is trying to
>> >>sneak it's way into the release:
>> >>
>> >>@@ -2439,4 +2474,16 @@
>> >>   CONSTRAINT
>> `fk_lb_healthcheck_policy_details__lb_healthcheck_policy_id`
>> >>FOREIGN KEY
>>
>> >>`fk_lb_healthcheck_policy_details__lb_healthcheck_policy_id`(`lb_policy_id
>> >>`)
>> >>REFERENCES `load_balancer_healthcheck_policies`(`id`) ON DELETE
>> >>CASCADE
>> >> ) ENGINE=InnoDB DEFAULT CHARSET=utf8;
>> >>
>> >>+ALTER TABLE `cloud`.`snapshot_policy` ADD COLUMN `display` tinyint(1)
>> >>NOT NULL DEFAULT '1' COMMENT 'True if the policy can be displayed to
>> >>the end user';
>> >>+
>> >>+CREATE TABLE `cloud`.`snapshot_policy_details` (
>> >>+  `id` bigint unsigned NOT NULL auto_increment,
>> >>+  `policy_id` bigint unsigned NOT NULL COMMENT 'snapshot policy id',
>> >>+  `name` varchar(255) NOT NULL,
>> >>+  `value` varchar(1024) NOT NULL,
>> >>+  `display` tinyint(1) NOT NULL DEFAULT '1' COMMENT 'True if the
>> >>detail can be displayed to the end user',
>> >>+  PRIMARY KEY (`id`),
>> >>+  CONSTRAINT `fk_snapshot_policy_details__snapshot_policy_id` FOREIGN
>> >>KEY `fk_snapshot_policy_details__snapshot_policy_id`(`policy_id`)
>> >>REFERENCES `snapshot_policy`(`id`) ON DELETE CASCADE
>> >>+) ENGINE=InnoDB DEFAULT CHARSET=utf8;
>> >>+
>> >> INSERT INTO `cloud`.`configuration`(category, instance, component,
>> >>name, value, description, default_value) VALUES ('Advanced',
>> >>'DEFAULT', 'management-server', 'vm.password.length', '6', 'Specifies
>> >>the length of a randomly generated password', '6') ON DUPLICATE KEY
>> >>UPDATE category='Advanced';
>> >>
>> >>On Thu, Jul 17, 2014 at 11:53 PM, Amogh Vasekar
>> >> wrote:
>> >>> Seems good, looks like was an issue with a newline somewhere. But
>> >>>deploydb
>> >>> went fine on 4.4
>> >>>
>> >>> Thanks,
>> >>> Amogh
>> >>>
>> >>> On 7/17/14 2:42 PM, "Daan Hoogland"  wrote:
>> >>>
>> Amogh, I couldn't help myself. please have a look at the resulting
>> setup/db/db/schema-430to440.sql
>> 
>> On Thu, Jul 17, 2014 at 11:35 PM, Daan Hoogland
>> 
>> wrote:
>> > On Thu, Jul 17, 2014 at 11:19 PM, Amogh Vasekar
>> >  wrote:
>> >> c8ca15b95a57a3d79b71c76c913e295f6490f05d
>> >
>> > Amogh, it has conflicts. I will have a look at those in the morning
>> >
>> > --
>> > Daan
>> 
>> 
>> 
>> --
>> Daan
>> >>>
>> >>
>> >>
>> >>
>> >>--
>> >>Daan
>> >
>>
>>
>>
>> --
>> Daan
>>
>
>
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the cloud
> *™*



-- 
Daan

Re: [ACS 4.4] Cherry pick request

[Mike Tutkowski]

I see, Daan - thanks for the clarification.

This is probably another good reason why we should seriously consider
implementing the branching approach Sebastien recommended here:

http://nvie.com/posts/a-successful-git-branching-model/


On Thu, Jul 17, 2014 at 10:06 PM, Daan Hoogland 
wrote:

> That is not the confusion Mike. The problem is that some changes that
> don't go into 4.4 keep causing conflicts. I made the mistake of adding
> the conflicting lines this time. this 4.4-forward branch is not
> suitable for providing cherry-picks for an RM because of this. I thin
> people should just branch 4.4 for their changes and let me cherry-pick
> from there. Also the automation tests running on 4.4-forward instead
> of 4.4 is not very useful.
>
>
>
> On Fri, Jul 18, 2014 at 6:00 AM, Mike Tutkowski
>  wrote:
> > Perhaps there is some confusion again as to the nature of the 4.4-forward
> > branch.
> >
> > A while back, we agreed that changes put in here would not be cherry
> picked
> > to 4.4 unless requested so by the developer and agreed to by the RM.
> >
> > Changes in 4.4-forward that do not go into 4.4 will at least go into
> 4.4.1
> > (assuming such a release happens).
> >
> >
> > On Thu, Jul 17, 2014 at 9:48 PM, Daan Hoogland 
> > wrote:
> >
> >> They keep coming in with cherry-picks that include this file. I will
> >> remove them.
> >>
> >> On Fri, Jul 18, 2014 at 12:22 AM, Nitin Mehta 
> >> wrote:
> >> > Hi Daan - I am not sure I get your point here. These changes were put
> in
> >> > as I want them in 4.4.1, but were not critical enough to be put in
> 4.4.
> >> >
> >> > Thanks,
> >> > -Nitin
> >> >
> >> > On 17/07/14 2:58 PM, "Daan Hoogland"  wrote:
> >> >
> >> >>sure? I saw that the last few lines where not in the last version.
> >> >>
> >> >>I'm not confortable with this bit, it has been coming up a few time
> >> >>before already looks like some commit on 4.4-forward is trying to
> >> >>sneak it's way into the release:
> >> >>
> >> >>@@ -2439,4 +2474,16 @@
> >> >>   CONSTRAINT
> >> `fk_lb_healthcheck_policy_details__lb_healthcheck_policy_id`
> >> >>FOREIGN KEY
> >>
> >>
> >>`fk_lb_healthcheck_policy_details__lb_healthcheck_policy_id`(`lb_policy_id
> >> >>`)
> >> >>REFERENCES `load_balancer_healthcheck_policies`(`id`) ON DELETE
> >> >>CASCADE
> >> >> ) ENGINE=InnoDB DEFAULT CHARSET=utf8;
> >> >>
> >> >>+ALTER TABLE `cloud`.`snapshot_policy` ADD COLUMN `display` tinyint(1)
> >> >>NOT NULL DEFAULT '1' COMMENT 'True if the policy can be displayed to
> >> >>the end user';
> >> >>+
> >> >>+CREATE TABLE `cloud`.`snapshot_policy_details` (
> >> >>+  `id` bigint unsigned NOT NULL auto_increment,
> >> >>+  `policy_id` bigint unsigned NOT NULL COMMENT 'snapshot policy id',
> >> >>+  `name` varchar(255) NOT NULL,
> >> >>+  `value` varchar(1024) NOT NULL,
> >> >>+  `display` tinyint(1) NOT NULL DEFAULT '1' COMMENT 'True if the
> >> >>detail can be displayed to the end user',
> >> >>+  PRIMARY KEY (`id`),
> >> >>+  CONSTRAINT `fk_snapshot_policy_details__snapshot_policy_id` FOREIGN
> >> >>KEY `fk_snapshot_policy_details__snapshot_policy_id`(`policy_id`)
> >> >>REFERENCES `snapshot_policy`(`id`) ON DELETE CASCADE
> >> >>+) ENGINE=InnoDB DEFAULT CHARSET=utf8;
> >> >>+
> >> >> INSERT INTO `cloud`.`configuration`(category, instance, component,
> >> >>name, value, description, default_value) VALUES ('Advanced',
> >> >>'DEFAULT', 'management-server', 'vm.password.length', '6', 'Specifies
> >> >>the length of a randomly generated password', '6') ON DUPLICATE KEY
> >> >>UPDATE category='Advanced';
> >> >>
> >> >>On Thu, Jul 17, 2014 at 11:53 PM, Amogh Vasekar
> >> >> wrote:
> >> >>> Seems good, looks like was an issue with a newline somewhere. But
> >> >>>deploydb
> >> >>> went fine on 4.4
> >> >>>
> >> >>> Thanks,
> >> >>> Amogh
> >> >>>
> >> >>> On 7/17/14 2:42 PM, "Daan Hoogland" 
> wrote:
> >> >>>
> >> Amogh, I couldn't help myself. please have a look at the resulting
> >> setup/db/db/schema-430to440.sql
> >> 
> >> On Thu, Jul 17, 2014 at 11:35 PM, Daan Hoogland
> >> 
> >> wrote:
> >> > On Thu, Jul 17, 2014 at 11:19 PM, Amogh Vasekar
> >> >  wrote:
> >> >> c8ca15b95a57a3d79b71c76c913e295f6490f05d
> >> >
> >> > Amogh, it has conflicts. I will have a look at those in the
> morning
> >> >
> >> > --
> >> > Daan
> >> 
> >> 
> >> 
> >> --
> >> Daan
> >> >>>
> >> >>
> >> >>
> >> >>
> >> >>--
> >> >>Daan
> >> >
> >>
> >>
> >>
> >> --
> >> Daan
> >>
> >
> >
> >
> > --
> > *Mike Tutkowski*
> > *Senior CloudStack Developer, SolidFire Inc.*
> > e: mike.tutkow...@solidfire.com
> > o: 303.746.7302
> > Advancing the way the world uses the cloud
> > *™*
>
>
>
> --
> Daan
>



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
*™*

Re: Question regarding Quiesce VM feature in ACS 4.3 wrt XEN hypervisor

[Amit Das]

thanks Mike. I shall have a look at the implementation details.

Will be looking forward to any documentation if any.

Regards,
Amit
*CloudByte Inc.* 


On Fri, Jul 18, 2014 at 8:58 AM, Mike Tutkowski <
mike.tutkow...@solidfire.com> wrote:

> Hi Amit,
>
> I don't really know these details in depth (NetApp added this feature in
> v4.3).
>
> I have CCed David La Motta from NetApp. Perhaps he can explain more than I
> did.
>
> I do know that from a storage standpoint you don't have to implement
> anything if you just want to ignore this feature.
>
> The idea is that if you want to support this feature, then you (I think)
> need to implement a snapshot strategy (a CS interface) (or perhaps use the
> one NetApp implemented).
>
> The overall idea is that this works for NFS if you want to take a snapshot
> of a file on a share and you want to try to take the snapshot when the VM
> is in a quiesced state.
>
> Step one is the VM gets quiesced.
>
> Step two is a hypervisor snapshot is taken (which leads to a new (delta)
> file on the XenServer Shared (NFS) Storage Repository).
>
> Step three is you can have your storage plug-in notified and it can take a
> snapshot of this new file.
>
> Step four is cleanup related on the hypervisor: The VM snapshot is deleted
> and the delta file can be merged back into its parent by XenServer.
>
> I think the reason we take a hypervisor snapshot is so we can then quickly
> un-quiesce the VM and asynchronously have the storage plug-in take its
> snapshot. Then we can later go back and delete the hypervisor snapshot, so
> this virtual disk can have its parent and delta files merged back together.
>
> Talk to you later,
> Mike
>
>
> On Wed, Jul 16, 2014 at 9:31 AM, Amit Das  wrote:
>
>> W.r.t hypervisor specific snapshots :
>> - why is this snapshot required when a VM or its hypervisor supports
>> quiesce operation.
>> - what exactly happens during hypervisor snapshot ? Can this step be
>> excluded.
>>
>>
>> On Wednesday, July 16, 2014, Mike Tutkowski 
>> wrote:
>>
>>> This line at the bottom of my previous e-mail was redundant...I meant to
>>> remove it before sending:
>>>
>>> A vendor snapshot can be created of the hypervisor snapshot file, then
>>> CS can automatically delete
>>>
>>>
>>> On Wed, Jul 16, 2014 at 8:10 AM, Mike Tutkowski <
>>> mike.tutkow...@solidfire.com> wrote:
>>>
 I believe this is what happens:

 * The VM gets quiesced.
 * Hypervisor snapshots are taken of all VM disks (so a new delta file
 shows up on each applicable SR).
  * The applicable storage plug-in can be invoked to take a
 vendor-specific snapshot of a given hypervisor snapshot delta file.
 * Once the storage plug-in is done, CS can delete the hypervisor
 snapshot delta file(s) that was/were created.

 A couple notes about this:

 * Since you are taking a vendor-side snap of a particular file, this
 relates to NFS.

 * I believe all disks of the VM need to be supported by the same
 storage vendor (i.e. if the root and data disks are on different SRs, each
 SR needs to be supported by the storage of the same backend vendor)

 A vendor snapshot can be created of the hypervisor snapshot file, then
 CS can automatically delete

 On Wednesday, July 16, 2014, Punith S  wrote:

> hi,
>
> while i was referring the ACS 4.3 doc for VM snapshot,
> i see a feature Quiesce VM supported only by vmware hypervisor if the
> cloudstack default primary storage is used,
> but it also mentions that Quiesce VM can be supported if you are using
> a
> third party primary storage plugin, the quiesce operation is provided
> by
> plugin implementation!
>
> is Quiesce VM is a limitation of  XEN hypervisor or is it not
> implemented
> by xen agent in cloudstack ?
>
> how is third party primary storage plugin related to hypervisor
> feature ?
>
> --
> regards,
>
> punith s
> cloudbyte.com
>

>>>
>>>
>>> --
>>> *Mike Tutkowski*
>>> *Senior CloudStack Developer, SolidFire Inc.*
>>> e: mike.tutkow...@solidfire.com
>>> o: 303.746.7302
>>> Advancing the way the world uses the cloud
>>> *™*
>>>
>>
>>
>> --
>> Regards,
>> Amit
>> *CloudByte Inc.* 
>>
>>
>
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the cloud
> *™*
>

Re: Review Request 22799: Golden (Base) Primary Storage feature

[Mike Tutkowski]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22799/#review48109
---


Hi,

It's been a while since we've had any activity review wise on this feature.

Can you guys tell me where we're currently at?

Thanks!
Mike

- Mike Tutkowski


On June 19, 2014, 9:46 p.m., Hieu LE wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22799/
> ---
> 
> (Updated June 19, 2014, 9:46 p.m.)
> 
> 
> Review request for cloudstack, Mike Tutkowski and Tim Mackey.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> As discussed in mailing list, this patch is applied for golden primary 
> storage in [1].
> I have changed the term from "golden" to "base" because there are some 
> functions and variables in CloudStack also use "base" for base image.
> This patch only apply for Xen Server.
> 
> [1]: 
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Golden+Primary+Storage
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/deploy/DeployDestination.java 
> 4ded5ebe7a18252da471ee25019856f2b2f772e0 
>   api/src/com/cloud/storage/StoragePool.java 
> 8e03c3348f3a6dd3156ab9e440126ea317957dc0 
>   api/src/com/cloud/template/VirtualMachineTemplate.java 
> 599212bb039fdbb78511019e8f0a6ea4b4a84440 
>   api/src/org/apache/cloudstack/api/ApiConstants.java 
> ae5d6f05b6b52f60b151369a641cb11fcbb558af 
>   api/src/org/apache/cloudstack/api/BaseUpdateTemplateOrIsoCmd.java 
> 2350f6b389203e2c6cc2182fe03fe9a95e936b81 
>   
> api/src/org/apache/cloudstack/api/command/admin/storage/CreateStoragePoolCmd.java
>  ae44bc9373232d242e4ebdcf76844969f0fe69fc 
>   
> api/src/org/apache/cloudstack/api/command/admin/storage/UpdateStoragePoolCmd.java
>  3d1a77353257c814efaf60875ffdf99603bc414e 
>   
> api/src/org/apache/cloudstack/api/command/user/template/RegisterTemplateCmd.java
>  f478c9bc8eebf867a03deb4add1bf695ac3ec0ad 
>   api/src/org/apache/cloudstack/api/response/StoragePoolResponse.java 
> 3571866fe74dca9aa5fe0d11373313eab97e94ac 
>   api/src/org/apache/cloudstack/api/response/TemplateResponse.java 
> 3e21043e339103c021d3c9e767acac8b3837f760 
>   core/src/com/cloud/agent/api/CheckPoolBelongToHostAnswer.java PRE-CREATION 
>   core/src/com/cloud/agent/api/CheckPoolBelongToHostCommand.java PRE-CREATION 
>   core/src/org/apache/cloudstack/storage/to/PrimaryDataStoreTO.java 
> 29e53b0d9581f764a17ea285606213d2c045b029 
>   core/src/org/apache/cloudstack/storage/to/TemplateObjectTO.java 
> b201c386f4975913f13c575d7685e50cedc7d92f 
>   
> core/test/org/apache/cloudstack/api/agent/test/BackupSnapshotCommandTest.java 
> 33361e87265df05e00bfa6dba810d2b68ae8d923 
>   core/test/org/apache/cloudstack/api/agent/test/CheckNetworkAnswerTest.java 
> 66feaecb5ef20053db50956e2801fec096a350c9 
>   core/test/org/apache/cloudstack/api/agent/test/SnapshotCommandTest.java 
> 114c8854d1504436523aa99c78bf2b4d84a12077 
>   
> engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/PrimaryDataStoreParameters.java
>  1dbff59a8911ad8f0933ef17a2c2b1d3e33523b9 
>   
> engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/StoragePoolAllocator.java
>  dfdbd8ab92c47799f6ad23637fa63e030f0be968 
>   
> engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/VolumeInfo.java
>  f93f4efac83c565cd33eb7eb67dcaca335f1c226 
>   engine/components-api/src/com/cloud/deploy/DeploymentPlanningManager.java 
> ee6721ab445a5222d0087dc9170e0b58f9eef91a 
>   engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java 
> 4aa5fc80d9660d2f985db98124c33465bd99767f 
>   
> engine/orchestration/src/org/apache/cloudstack/engine/cloud/entity/api/VMEntityManagerImpl.java
>  b1ac2f853374d6f1ddd9087919dbc16db0433f59 
>   
> engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java
>  6256e2526ef9bd4632a5e3873c4d9531eb301c7f 
>   engine/schema/src/com/cloud/storage/VMTemplateVO.java 
> 9a77cbf873aa9e422985fbcdc0ae7e18b8c78d4c 
>   engine/schema/src/com/cloud/storage/VolumeVO.java 
> e328253a596891029c2b55bea81b7ead425251ee 
>   
> engine/schema/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDao.java
>  a976bfbf6fe46306d20ad939c335bba6b9b7be54 
>   
> engine/schema/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImpl.java
>  92793f1fb1a08a455a78667ba4a39ae162378360 
>   
> engine/schema/src/org/apache/cloudstack/storage/datastore/db/StoragePoolVO.java
>  1508ce0b28c83968c25d9601b6dae34e1a73dbb0 
>   
> engine/storage/image/src/org/apache/cloudstack/storage/image/store/TemplateObject.java
>  7288d454c30fdb81445e43549145f1f2da8533e4 
>   
> engine/storage/src/org/apache/cloudstack/storage/allocator/ClusterScopeStoragePoolAllocator.java
>  ea084c7555468001a12376640d9785b1cf85

Re: [ACS 4.4] Cherry pick request

[Daan Hoogland]

Well, maybe, we are not even far of from it. call 'master' 'develop'
and create a new 'master'. next make sure every body develops in a
feature branch. also call x.y-forward hotfix-x.y. Don't bet your life
this approach is going to save our world. What would really help is if
everybody would really study the post and become an RM themselves.

On Fri, Jul 18, 2014 at 6:08 AM, Mike Tutkowski
 wrote:
> I see, Daan - thanks for the clarification.
>
> This is probably another good reason why we should seriously consider
> implementing the branching approach Sebastien recommended here:
>
> http://nvie.com/posts/a-successful-git-branching-model/
>
>
> On Thu, Jul 17, 2014 at 10:06 PM, Daan Hoogland 
> wrote:
>
>> That is not the confusion Mike. The problem is that some changes that
>> don't go into 4.4 keep causing conflicts. I made the mistake of adding
>> the conflicting lines this time. this 4.4-forward branch is not
>> suitable for providing cherry-picks for an RM because of this. I thin
>> people should just branch 4.4 for their changes and let me cherry-pick
>> from there. Also the automation tests running on 4.4-forward instead
>> of 4.4 is not very useful.
>>
>>
>>
>> On Fri, Jul 18, 2014 at 6:00 AM, Mike Tutkowski
>>  wrote:
>> > Perhaps there is some confusion again as to the nature of the 4.4-forward
>> > branch.
>> >
>> > A while back, we agreed that changes put in here would not be cherry
>> picked
>> > to 4.4 unless requested so by the developer and agreed to by the RM.
>> >
>> > Changes in 4.4-forward that do not go into 4.4 will at least go into
>> 4.4.1
>> > (assuming such a release happens).
>> >
>> >
>> > On Thu, Jul 17, 2014 at 9:48 PM, Daan Hoogland 
>> > wrote:
>> >
>> >> They keep coming in with cherry-picks that include this file. I will
>> >> remove them.
>> >>
>> >> On Fri, Jul 18, 2014 at 12:22 AM, Nitin Mehta 
>> >> wrote:
>> >> > Hi Daan - I am not sure I get your point here. These changes were put
>> in
>> >> > as I want them in 4.4.1, but were not critical enough to be put in
>> 4.4.
>> >> >
>> >> > Thanks,
>> >> > -Nitin
>> >> >
>> >> > On 17/07/14 2:58 PM, "Daan Hoogland"  wrote:
>> >> >
>> >> >>sure? I saw that the last few lines where not in the last version.
>> >> >>
>> >> >>I'm not confortable with this bit, it has been coming up a few time
>> >> >>before already looks like some commit on 4.4-forward is trying to
>> >> >>sneak it's way into the release:
>> >> >>
>> >> >>@@ -2439,4 +2474,16 @@
>> >> >>   CONSTRAINT
>> >> `fk_lb_healthcheck_policy_details__lb_healthcheck_policy_id`
>> >> >>FOREIGN KEY
>> >>
>> >>
>> >>`fk_lb_healthcheck_policy_details__lb_healthcheck_policy_id`(`lb_policy_id
>> >> >>`)
>> >> >>REFERENCES `load_balancer_healthcheck_policies`(`id`) ON DELETE
>> >> >>CASCADE
>> >> >> ) ENGINE=InnoDB DEFAULT CHARSET=utf8;
>> >> >>
>> >> >>+ALTER TABLE `cloud`.`snapshot_policy` ADD COLUMN `display` tinyint(1)
>> >> >>NOT NULL DEFAULT '1' COMMENT 'True if the policy can be displayed to
>> >> >>the end user';
>> >> >>+
>> >> >>+CREATE TABLE `cloud`.`snapshot_policy_details` (
>> >> >>+  `id` bigint unsigned NOT NULL auto_increment,
>> >> >>+  `policy_id` bigint unsigned NOT NULL COMMENT 'snapshot policy id',
>> >> >>+  `name` varchar(255) NOT NULL,
>> >> >>+  `value` varchar(1024) NOT NULL,
>> >> >>+  `display` tinyint(1) NOT NULL DEFAULT '1' COMMENT 'True if the
>> >> >>detail can be displayed to the end user',
>> >> >>+  PRIMARY KEY (`id`),
>> >> >>+  CONSTRAINT `fk_snapshot_policy_details__snapshot_policy_id` FOREIGN
>> >> >>KEY `fk_snapshot_policy_details__snapshot_policy_id`(`policy_id`)
>> >> >>REFERENCES `snapshot_policy`(`id`) ON DELETE CASCADE
>> >> >>+) ENGINE=InnoDB DEFAULT CHARSET=utf8;
>> >> >>+
>> >> >> INSERT INTO `cloud`.`configuration`(category, instance, component,
>> >> >>name, value, description, default_value) VALUES ('Advanced',
>> >> >>'DEFAULT', 'management-server', 'vm.password.length', '6', 'Specifies
>> >> >>the length of a randomly generated password', '6') ON DUPLICATE KEY
>> >> >>UPDATE category='Advanced';
>> >> >>
>> >> >>On Thu, Jul 17, 2014 at 11:53 PM, Amogh Vasekar
>> >> >> wrote:
>> >> >>> Seems good, looks like was an issue with a newline somewhere. But
>> >> >>>deploydb
>> >> >>> went fine on 4.4
>> >> >>>
>> >> >>> Thanks,
>> >> >>> Amogh
>> >> >>>
>> >> >>> On 7/17/14 2:42 PM, "Daan Hoogland" 
>> wrote:
>> >> >>>
>> >> Amogh, I couldn't help myself. please have a look at the resulting
>> >> setup/db/db/schema-430to440.sql
>> >> 
>> >> On Thu, Jul 17, 2014 at 11:35 PM, Daan Hoogland
>> >> 
>> >> wrote:
>> >> > On Thu, Jul 17, 2014 at 11:19 PM, Amogh Vasekar
>> >> >  wrote:
>> >> >> c8ca15b95a57a3d79b71c76c913e295f6490f05d
>> >> >
>> >> > Amogh, it has conflicts. I will have a look at those in the
>> morning
>> >> >
>> >> > --
>> >> > Daan
>> >> 
>> >> 
>> >> 
>> >> --
>> >> Daan
>> >> >>>
>> >> >>
>> >> >>
>> >> >>
>> >> >>--
>> >> >>Daan
>> >> >
>> >>
>>

[PROPOSAL] Adding a plugin to check the password strength of all users

[Damoder Reddy]

Hi all,

I am thinking to add a plugin which enables to check the password strength of a 
user while setting/resetting the password for that user.
why as a plugin because different companies may have a different rule sets to 
check the password strength.

The default implementation will have the password strength calculation based on 
the following parameters
1. Length of the password
2. Number of Character Sets involved in the password defined. For ex, Upper 
Case Letter, Lower Case letter, Digits and special character set.

Ay suggestions/Comments?

Thanks
Damoder

Re: Daily Continues Integration test summary

[Hugo Trippaers]

Rayees,

That's great, but is there any way to make this available for the community? So 
we can run it from Jenkins? Than everybody can see the status immediately and 
you don't need to send reports.

It would tie in nicely with our existing tests on Jenkins.buildacloud.org

Cheers,

Hugo 

Sent from my iPhone

> On 17 jul. 2014, at 22:01, Rayees Namathponnan 
>  wrote:
> 
> Hi All,
> 
> We are running Continues Integration inside Citrix  environment,  tests are 
> running in both mater and release branches in every 3 hours.
> 
> Currently only BVT test cases executing on Simulator, Xen and KVM. We are 
> working towards to add regression suite,  vmware and external devices test 
> cases like NetScaler, F5 etc
> 
> I will publish daily result summary in dev mailing list, also you can see 
> this from 
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=43188548
> 
> 
> Current CI BVT summary with master build
> ---
> 
> Simulator
> -
> Run No  Total Ex  Failed Failed test case
> 1370  62   0
> 1365  64   1 
> test_vm_life_cycle.TestVMLifeCycle.test_08_migrate_vm Disabled this test 
> now, until fixing in master
> 1362  64   3 
> TestCreateDiskOffering.test_02_create_sparse_type_disk_offeringFixed 
> first two failures, 08_migrate_vm disabled now
> 1358  64   3 
> TestCreateDiskOffering.test_02_create_sparse_type_disk_offeringFixed 
> first two failures, 08_migrate_vm disabled now
> 
> KVM
> ---
> Run No  Total Ex  Failed Failed test caseComments
> Disabled  Disabled   Disabled due to 
> product issue, its fixed now, we will enable this soon
> 
> 
> XEN
> ---
> Run No  Total Ex  Failed Failed test caseComments
> 1371  29   2 ISO failureCLOUDSTACK-7074
> 1363  29   2 ISO failureCLOUDSTACK-7074
> 1359  29   2 ISO failureCLOUDSTACK-7074
> 1355  29   2 ISO failureCLOUDSTACK-7074
> 
> 
> Regards,
> Rayees
> 
> 

Re: Review Request 23547: CLOUDSTACK-7113: Ability to reset password when Router VM is stopped

[Kishan Kavala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23547/#review48112
---

Ship it!


Ship It!

- Kishan Kavala


On July 16, 2014, 3:36 p.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23547/
> ---
> 
> (Updated July 16, 2014, 3:36 p.m.)
> 
> 
> Review request for cloudstack, Jayapal Reddy and Kishan Kavala.
> 
> 
> Bugs: CLOUDSTACK-7113
> https://issues.apache.org/jira/browse/CLOUDSTACK-7113
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-7113: Ability to reset password when Router VM is stopped 
> With this improvement password reset also happens when router is in stopped 
> state on resetPasswordCmd and restoreVM
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/network/element/VirtualRouterElement.java 3b3cacd 
>   server/src/com/cloud/vm/UserVmManagerImpl.java dac4acf 
> 
> Diff: https://reviews.apache.org/r/23547/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>