----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23604/#review47986 -----------------------------------------------------------
Commit 6f9b3cc9d13bd1bc002ce0afad3ed416b590f882 in cloudstack's branch refs/heads/master from Ashutosh K [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=6f9b3cc ] CLOUDSTACK-7108: Reading provisioningtype for disk offering in base.py - ASF Subversion and Git Services On July 17, 2014, 7:25 a.m., Ashutosh Kelkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23604/ > ----------------------------------------------------------- > > (Updated July 17, 2014, 7:25 a.m.) > > > Review request for cloudstack and Girish Shilamkar. > > > Bugs: CLOUDSTACK-7108 > https://issues.apache.org/jira/browse/CLOUDSTACK-7108 > > > Repository: cloudstack-git > > > Description > ------- > > The provisioning type was passes through test case, but was not read in the > library, hence not passed to the API. Hence the test cases failed as the > provioning type would be thin by default instead of sparse/fat. > > > Diffs > ----- > > tools/marvin/marvin/lib/base.py fe257f0 > > Diff: https://reviews.apache.org/r/23604/diff/ > > > Testing > ------- > > Yes. > > Log: > Test to create disk offering ... === TestName: test_01_create_disk_offering | > Status : SUCCESS === > ok > Test to create a sparse type disk offering ... === TestName: > test_02_create_sparse_type_disk_offering | Status : SUCCESS === > ok > Test to create a sparse type disk offering ... === TestName: > test_04_create_fat_type_disk_offering | Status : SUCCESS === > ok > Test to update existing disk offering ... SKIP: skip > Test to delete disk offering ... SKIP: skip > > ---------------------------------------------------------------------- > Ran 5 tests in 0.301s > > OK (SKIP=2) > > > Thanks, > > Ashutosh Kelkar > >
