Re: Ubuntu noredist

[Hugo Trippaers]

Hey Wido,

This is particular ticket is about the mysql Ha module. It is part of the 
noredist build as we have a build time dependency on the mysql connector. The 
module also needs to be installed in a specific location in order to be loaded 
by the tomcat system class loader instead of the web app class loader.

Cheers,

Hugo


On 7 jul. 2014, at 07:32, Wido den Hollander  wrote:

> 
> 
> On 07/04/2014 08:48 PM, Wido den Hollander wrote:
>> 
>> 
>> On 07/04/2014 03:36 PM, Sebastien Goasguen wrote:
>>> Hi,
>>> 
>>> To fix: http://issues.apache.org/jira/browse/CLOUDSTACK-6892 on ubuntu
>>> we need a noredist build.
>>> 
>>> anyone using Ubuntu out there, could check out the fix that was done
>>> for CentOS and provide a patch for Ubuntu ?
>> 
>> I'll see if I can come up with a patch over the weekend!
>> 
> 
> Ah, so this is about a noredist package for the MySQL connector and there is 
> no 'noredist' architecture at all in the Debian packages.
> 
> Currently the Debian packages simply depend on libmysql-java, so shouldn't 
> that be sufficient?
> 
> Wido
> 
>> Wido
>> 
>>> 
>>> thanks,
>>> 
>>> -Sebastien
>>> 
>>> 

Re: Review Request 23169: CLOUDSTACK-7010: Add domain to createZones in marvin

[John Dilley]

> On July 1, 2014, 3 p.m., Santhosh Edukulla wrote:
> > tools/marvin/marvin/configGenerator.py, line 91
> > 
> >
> > Does cfg, files used has these option of domain?
> > 
> > As well, please test it on both 4.4-forward and master, if it need to 
> > go to both?

> Does cfg, files used has these option of domain?

Hi Santhosh,

Not quite sure what you mean here - can you clarify?

Thanks,

John


- John


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23169/#review47065
---


On June 30, 2014, 2:30 p.m., John Dilley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23169/
> ---
> 
> (Updated June 30, 2014, 2:30 p.m.)
> 
> 
> Review request for cloudstack and Santhosh Edukulla.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Add domain to createZones in deployDataCenter
> 
> 
> Diffs
> -
> 
>   tools/marvin/marvin/configGenerator.py 8d9 
>   tools/marvin/marvin/deployDataCenter.py c097238 
> 
> Diff: https://reviews.apache.org/r/23169/diff/
> 
> 
> Testing
> ---
> 
> Tested deployDataCenter, both with and without specifying a domain
> 
> 
> Thanks,
> 
> John Dilley
> 
>

Re: Review Request 23169: CLOUDSTACK-7010: Add domain to createZones in marvin

[John Dilley]

> On July 1, 2014, 3 p.m., Santhosh Edukulla wrote:
> >

Tested on 4.4-forward and master - both work.


- John


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23169/#review47065
---


On June 30, 2014, 2:30 p.m., John Dilley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23169/
> ---
> 
> (Updated June 30, 2014, 2:30 p.m.)
> 
> 
> Review request for cloudstack and Santhosh Edukulla.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Add domain to createZones in deployDataCenter
> 
> 
> Diffs
> -
> 
>   tools/marvin/marvin/configGenerator.py 8d9 
>   tools/marvin/marvin/deployDataCenter.py c097238 
> 
> Diff: https://reviews.apache.org/r/23169/diff/
> 
> 
> Testing
> ---
> 
> Tested deployDataCenter, both with and without specifying a domain
> 
> 
> Thanks,
> 
> John Dilley
> 
>

Re: Review Request 23169: CLOUDSTACK-7010: Add domain to createZones in marvin

[Santhosh Edukulla]

> On July 1, 2014, 3 p.m., Santhosh Edukulla wrote:
> > tools/marvin/marvin/configGenerator.py, line 91
> > 
> >
> > Does cfg, files used has these option of domain?
> > 
> > As well, please test it on both 4.4-forward and master, if it need to 
> > go to both?
> 
> John Dilley wrote:
> > Does cfg, files used has these option of domain?
> 
> Hi Santhosh,
> 
> Not quite sure what you mean here - can you clarify?
> 
> Thanks,
> 
> John

I mean, does cfg file say advanced.cfg requires this flag, as well, what if 
zone.domain is None, does createZone command leads to any issue?


- Santhosh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23169/#review47065
---


On June 30, 2014, 2:30 p.m., John Dilley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23169/
> ---
> 
> (Updated June 30, 2014, 2:30 p.m.)
> 
> 
> Review request for cloudstack and Santhosh Edukulla.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Add domain to createZones in deployDataCenter
> 
> 
> Diffs
> -
> 
>   tools/marvin/marvin/configGenerator.py 8d9 
>   tools/marvin/marvin/deployDataCenter.py c097238 
> 
> Diff: https://reviews.apache.org/r/23169/diff/
> 
> 
> Testing
> ---
> 
> Tested deployDataCenter, both with and without specifying a domain
> 
> 
> Thanks,
> 
> John Dilley
> 
>

Re: Review Request 23169: CLOUDSTACK-7010: Add domain to createZones in marvin

[John Dilley]

> On July 1, 2014, 3 p.m., Santhosh Edukulla wrote:
> > tools/marvin/marvin/configGenerator.py, line 91
> > 
> >
> > Does cfg, files used has these option of domain?
> > 
> > As well, please test it on both 4.4-forward and master, if it need to 
> > go to both?
> 
> John Dilley wrote:
> > Does cfg, files used has these option of domain?
> 
> Hi Santhosh,
> 
> Not quite sure what you mean here - can you clarify?
> 
> Thanks,
> 
> John
> 
> Santhosh Edukulla wrote:
> I mean, does cfg file say advanced.cfg requires this flag, as well, what 
> if zone.domain is None, does createZone command leads to any issue?

No problem if zone.domain is not specified - createZone will behave as before, 
not specifying a domain (and will default to cs.internal)


- John


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23169/#review47065
---


On June 30, 2014, 2:30 p.m., John Dilley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23169/
> ---
> 
> (Updated June 30, 2014, 2:30 p.m.)
> 
> 
> Review request for cloudstack and Santhosh Edukulla.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Add domain to createZones in deployDataCenter
> 
> 
> Diffs
> -
> 
>   tools/marvin/marvin/configGenerator.py 8d9 
>   tools/marvin/marvin/deployDataCenter.py c097238 
> 
> Diff: https://reviews.apache.org/r/23169/diff/
> 
> 
> Testing
> ---
> 
> Tested deployDataCenter, both with and without specifying a domain
> 
> 
> Thanks,
> 
> John Dilley
> 
>

Re: Review Request 23169: CLOUDSTACK-7010: Add domain to createZones in marvin

[Santhosh Edukulla]

> On July 1, 2014, 3 p.m., Santhosh Edukulla wrote:
> > tools/marvin/marvin/configGenerator.py, line 91
> > 
> >
> > Does cfg, files used has these option of domain?
> > 
> > As well, please test it on both 4.4-forward and master, if it need to 
> > go to both?
> 
> John Dilley wrote:
> > Does cfg, files used has these option of domain?
> 
> Hi Santhosh,
> 
> Not quite sure what you mean here - can you clarify?
> 
> Thanks,
> 
> John
> 
> Santhosh Edukulla wrote:
> I mean, does cfg file say advanced.cfg requires this flag, as well, what 
> if zone.domain is None, does createZone command leads to any issue?
> 
> John Dilley wrote:
> No problem if zone.domain is not specified - createZone will behave as 
> before, not specifying a domain (and will default to cs.internal)

Ok, can you please mention the bugid, and related branches information for this 
review submission?


- Santhosh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23169/#review47065
---


On June 30, 2014, 2:30 p.m., John Dilley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23169/
> ---
> 
> (Updated June 30, 2014, 2:30 p.m.)
> 
> 
> Review request for cloudstack and Santhosh Edukulla.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Add domain to createZones in deployDataCenter
> 
> 
> Diffs
> -
> 
>   tools/marvin/marvin/configGenerator.py 8d9 
>   tools/marvin/marvin/deployDataCenter.py c097238 
> 
> Diff: https://reviews.apache.org/r/23169/diff/
> 
> 
> Testing
> ---
> 
> Tested deployDataCenter, both with and without specifying a domain
> 
> 
> Thanks,
> 
> John Dilley
> 
>

Re: How to change primary storage

[Giri Prasad]

Hi All,

Thanks everybody for all your valuable insights. I am working on this as of now 
and I will keep you all posted, once I am thru with this.

Regards,




 From: Prashant Kumar Mishra 
To: "dev@cloudstack.apache.org" ; Giri Prasad 
 
Cc: "us...@cloudstack.apache.org"  
Sent: Monday, 7 July 2014 10:56 AM
Subject: RE: How to change primary storage
 

Manually changing the db can help you but I prefer These steps ,  can be done  
without any downtime .

1-add http://XXX.XXX.1.20 with /export/dd
2- migrate volumes from http://XXX.XXX.1.5 to http://XXX.XXX.1.20
3-put http://XXX.XXX.1.5 to maintains mode
4- remove http://XXX.XXX.1.5.

thanks



-Original Message-
From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com] 
Sent: Monday, July 07, 2014 10:48 AM
To: dev@cloudstack.apache.org; Giri Prasad
Cc: us...@cloudstack.apache.org
Subject: Re: How to change primary storage

You can probably change the host_address field of the storage_pool table to 
change the IP address of your primary storage.

You will probably want to make sure you don't have any (non-deleted) volumes on 
the storage pool (primary storage) in question, though.

As you likely have seen, the volumes table is linked to the storage_pool table 
via the storage_pool.id and volumes.pool_id fields.

It might be easier for you to create new primary storage and migrate your 
volumes on the old primary storage to the new primary storage.


On Sun, Jul 6, 2014 at 11:07 PM, Giri Prasad 
wrote:

> Thanks.
>
> I want to change the primary storage IP address from 
> http://XXX.XXX.1.5 to http://XXX.XXX.1.20. Also, I need to change the 
> primary storage directory, from /export/aa to /export/dd.  What is the 
> procedure?
>
>
>
> 
>  From: Prashant Kumar Mishra 
> To: Giri Prasad ; "dev@cloudstack.apache.org" < 
> dev@cloudstack.apache.org>; "us...@cloudstack.apache.org" < 
> us...@cloudstack.apache.org>
> Sent: Monday, 7 July 2014 10:30 AM
> Subject: RE: How to change primary storage
>
>
> For error like "The storage pool will not be used but cleanup is needed"
> you should check global settings "global.clenup.interaval " ,For quick 
> cleanup you can set it to 300ms and check  parameter related to 
> cleanup like storage.template.cleanup.enable  , storage cleanup 
> enabled etc. If global settings are properly tuned I don't think  any 
> database modifications required
>
> ->cloud.volume  stores volumes information , if you are not able to 
> ->delete
> storage because"volume still exist on the storage" change the volume 
> state and delete.
>
> -> storage_pool, storage_pool_view  for primary storage
>
> Thanks
> Prashant
>
>
> -Original Message-
> From: Giri Prasad [mailto:g_p...@yahoo.com]
> Sent: Monday, July 07, 2014 10:00 AM
> To: Prashant Kumar Mishra; dev@cloudstack.apache.org; 
> us...@cloudstack.apache.org
> Subject: Re: How to change primary storage
>
> Hello,
>
> Thanks for suggestion, which I will try.
>
> Btw, I saw a lead as:
> http://comments.gmane.org/gmane.comp.apache.cloudstack.user/7000
> Which says :
>
> when I've had issues deleting primary storages in the past, I've ended 
> up having to delete volumes that were still associated with the 
> datastore from the cloud.volumes table.
>
> Is cloud.volumes the mysql table, where all the primary/secondary 
> storage setups are stored? Or what is the exact db.tablename which 
> stores the primary/secondary storage setups?
>
>
> Regards,
> D.Giriprasad
>
>
>
> - Original Message -
> From: Prashant Kumar Mishra 
> To: "dev@cloudstack.apache.org" ; Giri 
> Prasad < g_p...@yahoo.com>; "us...@cloudstack.apache.org" < 
> us...@cloudstack.apache.org>
> Cc:
> Sent: Sunday, 6 July 2014 9:42 AM
> Subject: RE: How to change primary storage
>
>
> I would suggest add you new  primary storage ,migrate volumes  from 
> old storage to new storage and  then remove ur old primary storage 
> after enabling  maintenance mode.
>
> Thanks
> Prashant
>
>
>
> -Original Message-
> From: Giri Prasad [mailto:g_p...@yahoo.com.INVALID]
> Sent: Saturday, July 05, 2014 10:16 AM
> To: us...@cloudstack.apache.org; dev@cloudstack.apache.org
> Subject: How to change primary storage
>
> Hello All,
>
>  I installed CS 4.1 on ubuntu, with primary storage in /export/aa and 
> secondary storage in /export/bb, both in the same hard disk as the 
> management server of CS 4.1. The Ip of the server is  http://XXX.XXX.1.5.
>
>
>  Recently, I configured the My Book Live Device, to the IP of 
> http://XXX.XXX.1.20. I am able to mount this device to linux dir and 
> view files on it.
>
>  The CS 4.1 was installed before mounting this external My Book Live 
> Device.
>
> Now I want to change the primary storage of the IP address from
> http://XXX.XXX.1.5 to http://XXX.XXX.1.20. Also, I need to change the 
> primary storage directory.
>
>  Can, anybody provide insights, on which Mysql table, should I update 
> for CS 4.1 setup. Or is there

Re: [ANNOUNCE] New PMC Member: Mark Hinkle

[Mark Hinkle]

Thanks for the asking me to join and everyone's kind words though if you start 
accepting my spaghetti code patches. I will vote for my own dismissal ;)

Regards, Mark


On Jul 3, 2014, at 1:50 PM, John Burwell 
mailto:jburw...@basho.com>> wrote:

The Project Management Committee (PMC) for Apache CloudStack has asked Mark 
Hinkle to join the PMC and we are pleased to announce that he has accepted.

Join me in congratulating Mark!


-The CloudStack PMC

Re: CLOUDSTACK-5583: vmopsSnapshot plug-in (XenServer) does not return an error when it should

[Mandar Barve]

I followed the steps you mentioned on the bug using a software iSCSI target
in a VM and could reproduce the problem. I do see INSUFFICIENT_SPACE
exception being thrown when "xe snapshot-revert" is called by the
vmopsSnapshot plug in. When this happens the plugin doesn't throw any
exception or return any error.

The problem looks like this xe command is called via os.system module by
the python plugin. xe is a different program and any error/exception thrown
by this won't get propagated to the caller. To fix this os.system can be
replaced by subprocess.call with a check for the return code. I tried this
and this will return a non zero error code to the management server. It may
still not return the child process's exception code.

Let me know what you think.

Thanks,
Mandar


On Fri, Mar 14, 2014 at 11:55 AM, Mandar Barve 
wrote:

> I tried to reproduce the issue the way you mentioned with few changes. I
> don't have iSCSI SAN on my setup. I connected a 2 GB disk that I presented
> as storage tagged NFS primary to CS. I created a 1GB disk offering and then
> deployed a VM on this new primary. Took a couple of snapshots like you
> mentioned and when tried to revert to one of them I did see an error in
> vmops log that said revert_memory_snapshot returned NULL. Exception was
> thrown with async job status result code 530 and text response as "Failed
> to revert VM snapshot". I think this exception came later. The vmops
> snapshot plugin code itself may not have landed into exception handling
> path. I need to double check this.
>
> Is this what you are referring to? Could you attach snippets of SMlog and
> mops.log when the failure happened to the JIRA?
>
> Thanks,
> Mandar
>
>
> On Tue, Mar 11, 2014 at 3:25 AM, Mike Tutkowski <
> mike.tutkow...@solidfire.com> wrote:
>
>> Here is the comment I just added in JIRA for this ticket. Thanks!
>>
>> Hi,
>>
>> Here is how I reproduced it:
>>
>> I created an iSCSI volume on my SAN that is only 2 GB.
>>
>> I created a XenServer SR based on this SAN volume.
>>
>> I created Primary Storage in CloudStack based on this XenServer SR.
>>
>> I created a Disk Offering that was storage tagged to use this Primary
>> Storage. It will lead to the creation of a 1 GB volume when executed and
>> attached to a VM for the first time.
>>
>> I executed the Disk Offering to create a CloudStack volume and attached
>> this volume to a VM.
>>
>> I took two hypervisor snapshots of the VM, then reverted to the first
>> hypervisor snapshot.
>>
>> I looked at the SR that should contain my CloudStack volume and its
>> hypervisor snapshots. I saw two snapshots, but no active VDI. I should see
>> two hypervisor snapshots and an active VDI.
>>
>> Thanks!
>>
>>
>> On Mon, Mar 10, 2014 at 9:27 AM, Mike Tutkowski <
>> mike.tutkow...@solidfire.com> wrote:
>>
>>> I did look at it, but haven't had a chance to try to repo.
>>>
>>> I should be able to try to repo it today.
>>>
>>> Thanks!
>>>
>>>
>>> On Sun, Mar 9, 2014 at 10:05 PM, Mandar Barve 
>>> wrote:
>>>
 Hi Mike,
  Did you get a chance to look at this?

 Thanks,
 Mandar


 On Wed, Mar 5, 2014 at 10:12 AM, Mandar Barve >>> > wrote:

> I tested this with CS 4.3.
>
> Thanks,
> Mandar
>
>
> On Tue, Mar 4, 2014 at 9:09 PM, Mike Tutkowski <
> mike.tutkow...@solidfire.com> wrote:
>
>> Hi,
>>
>> Can you tell me what release you tested this with? I noticed the
>> problem while developing on CloudStack 4.3.
>>
>> Thanks!
>>
>>
>> On Tue, Mar 4, 2014 at 3:43 AM, Mandar Barve <
>> mandar.ba...@sungard.com> wrote:
>>
>>> Hi,
>>> I tried to reproduce the issue but couldn't get this to fail
>>> for insufficient space. I then injected an exception trying to list 
>>> files
>>> from a non existent path (added this code in the "try" block). This 
>>> landed
>>> me into the exception handling code. It raised correct exception saying
>>> "file not found" which was captured in the management server vmops log
>>> file. It was not displayed by the GUI. GUI just reported Error (Are we
>>> looking for GUI displaying error code?). The plugin code returns "0"
>>> immediately after the line of code that raises exception but I think 
>>> this
>>> applies only for successful execution of the plugin code that reverts 
>>> the
>>> snapshot.
>>>
>>>If any exception is raised (e.g. in the reported case here
>>> insufficient space) then the code should return appropriate error 
>>> message
>>> to the caller as I found. In exception handling path return "0" wouldn't
>>> execute.
>>>
>>> I don't see any problem here. Let me know if I am missing anything.
>>>
>>> Thanks,
>>> Mandar
>>>
>>
>>
>>
>> --
>> *Mike Tutkowski*
>>  *Senior CloudStack Developer, SolidFire Inc.*
>> e: mike.tutkow...@solidfire.com
>> o: 303.74

Hyper-V hypervisor: Donot have permission to access downloading URL of vomue

[huangchunmei]

Hi All,

 

I installed CS 4.3 and setup a Hype-V vm. When downloading volume of the VM,
I met below issues, any idea to fixed it? Thanks in advance.

Download one volume of Hyper-V vm, then click the link in pop-up, get
following issue,




 

Check the folder "/var/www/html/userdata" of SSVM with command "ls -l", got
below results,



 

 

Thanks,

Mary

Re: CloudStack adoption survey

[Mike Tutkowski]

Hi everyone,

Please, please take a moment to fill out the survey that Giles referenced
(below). :)

It is very important to the continued health of the CloudStack Community
that we be able to build up an ever-increasing list of companies that use
CloudStack as many people "out there" have simply never heard of it.

Due to the sheer mismatch of marketing dollars, it is a common
misperception that a cloud-orchestration system like OpenStack is the only
viable product in this space. Clearly, we'd like to show that this is, in
fact, not the case and that many companies have chosen CloudStack.

Thanks so much!
Mike


On Fri, Jun 27, 2014 at 11:47 AM, Giles Sirett 
wrote:

>  [cross posting]
>
>
>
> All
>
>
>
> We have just launched two new things on the Cloudstack.org website.
>
>
>
> a)  A list of known users of Cloudstack (
> http://cloudstack.apache.org/users.html)
>
> b)  A survey of cloudstack adoption for users of the software to
> complete (http://cloudstack.apache.org/survey.html)
>
>
>
>
>
> As those of you who follow the marketing list will already know, Sally has
> been working really hard to try and establish our known user base.
>
> Getting people to complete this survey is a REALLY important element in
> that: it will help Sally get the marketing message on ACS out.
>
>
>
> The plan is to use the survey data to add and augment the initial user
> list published
>
>
>
> So please help us out:
>
>
>
> 1.   If you’re using cloudstack at your org  (I guess most of us are J
> ) – TAKE THE SURVEY
>
> 2.   If you’re friend at work is using cloudstack in the org: get
> them to - TAKE THE SURVEY
>
> 3.   If you buy instances from a provider using cloudstack, get them
> to  - TAKE THE SURVEY
>
> 4.   If you know customers or others using cloudstack. Get them to
> TAKE THE SURVEY
>
> 5.   Please get busy on twitter, linkedin ,blogs,etc  – encourage
> people to - TAKE THE SURVEY
>
> 6.   If somebody you once met at a conference is using Cloudstack,
> call them up and get them to – go figure
>
>
>
> Please please get involved in helping to promote this. Don’t leave it to
> others – get involved !
>
>
>
> Kind Regards
>
> Giles
>
>
>
> Giles Sirett
>
> *CEO*
>
>
>
> [image: Description: Mail Logo Bottom Align]
>
>
>
> D: +44 20 3603 0541 | S: +44 20 3603 0540 | M: +44 796 111 2055
>
>
>
> giles.sir...@shapeblue.com | www.shapeblue.com | Twitter:@shapeBlue
> 
>
>
>
>
>  Find out more about ShapeBlue and our range of CloudStack related
> services
>
> IaaS Cloud Design & Build
> 
> CSForge – rapid IaaS deployment framework 
> CloudStack Consulting 
> CloudStack Infrastructure Support
> 
> CloudStack Bootcamp Training Courses
> 
>
> This email and any attachments to it may be confidential and are intended
> solely for the use of the individual to whom it is addressed. Any views or
> opinions expressed are solely those of the author and do not necessarily
> represent those of Shape Blue Ltd or related companies. If you are not the
> intended recipient of this email, you must neither take any action based
> upon its contents, nor copy or show it to anyone. Please contact the sender
> if you believe you have received this email in error. Shape Blue Ltd is a
> company incorporated in England & Wales. ShapeBlue Services India LLP is a
> company incorporated in India and is operated under license from Shape Blue
> Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil
> and is operated under license from Shape Blue Ltd. ShapeBlue is a
> registered trademark.
>



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
*™*

Re: CLOUDSTACK-6242 - the fix needs to be reverted temporarily

[Alena Prokharchyk]

Yes, that¹s what I mean - by now, we should log them, but without logging
the trace. So your fix is correct.

Later, we should fix the installation process so the user is inserted only
once; and change the logic in ConfigurationServer - instead of logging the
exception, we should throw the RuntimeException indicating that essential
CS configuration failed, and that exception should fail MS startup. I will
file a bug for that after you submit your fix.

Thank you,
Alena.

On 7/3/14, 1:38 PM, "Daan Hoogland"  wrote:

>Alena, I really want to fix issues in this line, because I really want
>us to use exceptions properly and never ignore them. So I would like
>handle them or log at least. Thanks for your patients.
>
>I am not sure of what you mean. Is this close:
>
>diff --git a/server/src/com/cloud/server/ConfigurationServerImpl.java
>b/server/src/com/cloud/server/ConfigurationServerImpl.java
>index b66e52d..a166372 100755
>--- a/server/src/com/cloud/server/ConfigurationServerImpl.java
>+++ b/server/src/com/cloud/server/ConfigurationServerImpl.java
>@@ -462,21 +462,21 @@
>
> try {
> PreparedStatement stmt =
>txn.prepareAutoCloseStatement(insertSql);
> stmt.executeUpdate();
> } catch (SQLException ex) {
>-s_logger.debug("Caught SQLException when
>inserting system account ", ex);
>+s_logger.debug("Caught SQLException when
>inserting system account: " + ex.getLocalizedMessage());
> }
> // insert system user
> insertSql = "INSERT INTO `cloud`.`user` (id, uuid,
>username, password, account_id, firstname, lastname, created,
>user.default)"
> + " VALUES (1, UUID(), 'system', RAND(), 1,
>'system', 'cloud', now(), 1)";
>
> try {
> PreparedStatement stmt =
>txn.prepareAutoCloseStatement(insertSql);
> stmt.executeUpdate();
> } catch (SQLException ex) {
>-s_logger.debug("Caught SQLException when
>inserting system user ", ex);
>+s_logger.debug("Caught SQLException when
>inserting system user: " + ex.getLocalizedMessage());
> }
>
> // insert admin user, but leave the account disabled
>until we set a
> // password with the user authenticator
> long id = 2;
>@@ -489,22 +489,22 @@
> + "', '1', '1', 1)";
> try {
> PreparedStatement stmt =
>txn.prepareAutoCloseStatement(insertSql);
> stmt.executeUpdate();
> } catch (SQLException ex) {
>-s_logger.debug("Caught SQLException when creating
>admin account ", ex);
>+s_logger.debug("Caught SQLException when creating
>admin account: " + ex.getLocalizedMessage());
> }
>
> // now insert the user
> insertSql = "INSERT INTO `cloud`.`user` (id, uuid,
>username, password, account_id, firstname, lastname, created, state,
>user.default) " + "VALUES (" + id
> + ", UUID(), '" + username + "', RAND(), 2,
>'" + firstname + "','" + lastname + "',now(), 'disabled', 1)";
>
> try {
> PreparedStatement stmt =
>txn.prepareAutoCloseStatement(insertSql);
> stmt.executeUpdate();
> } catch (SQLException ex) {
>-s_logger.debug("Caught SQLException when
>inserting user ", ex);
>+s_logger.debug("Caught SQLException when
>inserting user " + ex.getLocalizedMessage());
> }
>
> try {
> String tableName = "security_group";
> try {
>
>On Thu, Jul 3, 2014 at 10:23 PM, Alena Prokharchyk
> wrote:
>> Daan, there are similar problem in saveaccount/saveuser methods in thr
>>same class - introduced by this commit as well. I can fix it myself on
>>Monday (Its holiday days today and tomorrow at Citrix, usa); or you can
>>revert them as well along with the fix you do for network groups.
>>
>> Let me know, and thank you for the follow up.
>>
>> -alena
>>
>>> On Jul 2, 2014, at 11:43 PM, "Daan Hoogland" 
>>>wrote:
>>>
>>> On Thu, Jul 3, 2014 at 12:27 AM, Alena Prokharchyk
>>>  wrote:
 In any case, fixes done to ConfigurationManagerImpl are not correct,
and
 logging should be fixed by reverting/reapplying the commit by
following
 the rules defined in a) or b).
>>>
>>>
>>> changing to
>>> } catch (Exception ex) {
>>>// if network_groups table exists, create the
>>> default security group there
>>>s_logger.debug("Caught (SQL?)Exception: no
>>> network_group  " + ex.getLocalizedMessage());
>>>}
>>> for now
>>>
>>> --
>>> Daan
>
>
>
>-- 
>Daan

Re: [ANNOUNCE] New PMC Member: Mark Hinkle

[Alena Prokharchyk]

Congratulations, Mark!

-alena.

On 7/3/14, 10:50 AM, "John Burwell"  wrote:

>The Project Management Committee (PMC) for Apache CloudStack has asked
>Mark Hinkle to join the PMC and we are pleased to announce that he has
>accepted. 
>
>Join me in congratulating Mark!
>
>
>-The CloudStack PMC

RE: [ANNOUNCE] New PMC Member: Mark Hinkle

[Radhika Puthiyetath]

Congrats Mark !

-Original Message-
From: John Burwell [mailto:jburw...@basho.com] 
Sent: Thursday, July 03, 2014 10:51 AM
To: dev@cloudstack.apache.org
Cc: market...@cloudstack.apache.org
Subject: [ANNOUNCE] New PMC Member: Mark Hinkle

The Project Management Committee (PMC) for Apache CloudStack has asked Mark 
Hinkle to join the PMC and we are pleased to announce that he has accepted. 

Join me in congratulating Mark! 


-The CloudStack PMC

RE: [ANNOUNCE] Santhosh Edukulla as a committer...

[Radhika Puthiyetath]

Congrats Santhosh !

-Original Message-
From: Alex Huang [mailto:alex.hu...@citrix.com] 
Sent: Monday, June 30, 2014 9:25 AM
To: dev@cloudstack.apache.org
Subject: [ANNOUNCE] Santhosh Edukulla as a committer...

Hi All,

The Project Management Committee (PMC) for Apache CloudStack has asked Santhosh 
Edukulla to become a committer and we are pleased to announce that he has 
accepted.

Being a committer allows many contributors to contribute more autonomously. For 
developers, it makes it easier to submit changes and eliminates the need to 
have contributions reviewed via the patch submission process. Whether 
contributions are development-related or otherwise, it is a recognition of a 
contributor's participation in the project and commitment to the project and 
the Apache Way.

Please join me in congratulating Santhosh!

--Alex, on behalf of the CloudStack PMC

Re: Review Request 23282: CLOUDSTACK-6845 : First Code drop for NuageVsp Network plugin

[Suresh Ramamurthy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23282/
---

(Updated July 7, 2014, 6 p.m.)


Review request for cloudstack and Hugo Trippaers.


Changes
---

Added request to create a branch for NuageVsp Plugin.


Bugs: CLOUDSTACK-6845
https://issues.apache.org/jira/browse/CLOUDSTACK-6845


Repository: cloudstack-git


Description (updated)
---

This is first code drop for NuageVsp Network plugin support that will bring the 
Nuage VSP network virtualization technology to CloudStack.

We need a new branch to checkin the fixes once the review is done. Please 
create a new branch for NuageVsp plugin.


Diffs
-

  api/src/com/cloud/event/EventTypes.java 5b9ea5c 
  api/src/com/cloud/network/Network.java 885bffe 
  api/src/com/cloud/network/Networks.java 1e4d229 
  api/src/com/cloud/network/PhysicalNetwork.java 8cc214e 
  build/replace.properties 265f335 
  client/WEB-INF/classes/resources/messages.properties b192cb0 
  client/WEB-INF/classes/resources/messages_zh_CN.properties 1ec4e95 
  client/pom.xml 29fef4f 
  client/tomcatconf/commands.properties.in b9ac27b 
  client/tomcatconf/log4j-cloud.xml.in 08021f2 
  packaging/debian/replace.properties 5a0bd58 
  
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/OvsVifDriver.java 
8e4c710 
  
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 5b49e5b 
  
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
 a9840bd 
  plugins/network-elements/nuage-vsp/pom.xml PRE-CREATION 
  
plugins/network-elements/nuage-vsp/resources/META-INF/cloudstack/vsp/module.properties
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/resources/META-INF/cloudstack/vsp/spring-vsp-context.xml
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/resources/META-INF/cloudstack/vsp/vsp-defaults.ini
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/StartupVspCommand.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/VspResourceAnswer.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/VspResourceCommand.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyAclRuleVspAnswer.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyAclRuleVspCommand.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyStaticNatVspAnswer.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyStaticNatVspCommand.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ShutDownVpcVspAnswer.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ShutDownVpcVspCommand.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/DeallocateVmVspAnswer.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/DeallocateVmVspCommand.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ImplementNetworkVspAnswer.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ImplementNetworkVspCommand.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ReleaseVmVspAnswer.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ReleaseVmVspCommand.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ReserveVmInterfaceVspAnswer.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ReserveVmInterfaceVspCommand.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/TrashNetworkVspAnswer.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/TrashNetworkVspCommand.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/sync/SyncVspAnswer.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/sync/SyncVspCommand.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/api/commands/AddNuageVspDeviceCmd.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/api/commands/DeleteNuageVspDeviceCmd.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/api/commands/IssueNuageVspResourceRequestCmd.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/api/commands/ListNuageVspDevicesCmd.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/api/commands/VspConstants.java 
PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/api/response/NuageVspDeviceResponse.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp

Re: Review Request 23282: CLOUDSTACK-6845 : First Code drop for NuageVsp Network plugin

[Suresh Ramamurthy]

Hi Hugo, Sheng Yang,

I have posted the first code drop for NuageVsp network plugin in the review
board(https://reviews.apache.org/r/23282/).

Could you please review them and let me know your comments.

Also, we need a new branch to check-in the fixes once the review is done.
Could you please create a new branch for NuageVsp network plugin.

Thanks,
Suresh




On Sat, Jul 5, 2014 at 6:55 PM, Suresh Ramamurthy <
suresh.ramamur...@nuagenetworks.net> wrote:

>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23282/
> ---
>
> Review request for cloudstack and Hugo Trippaers.
>
>
> Bugs: CLOUDSTACK-6845
> https://issues.apache.org/jira/browse/CLOUDSTACK-6845
>
>
> Repository: cloudstack-git
>
>
> Description
> ---
>
> This is first code drop for NuageVsp Network plugin support that will
> bring the Nuage VSP network virtualization technology to CloudStack.
>
>
> Diffs
> -
>
>   api/src/com/cloud/event/EventTypes.java 5b9ea5c
>   api/src/com/cloud/network/Network.java 885bffe
>   api/src/com/cloud/network/Networks.java 1e4d229
>   api/src/com/cloud/network/PhysicalNetwork.java 8cc214e
>   build/replace.properties 265f335
>   client/WEB-INF/classes/resources/messages.properties b192cb0
>   client/WEB-INF/classes/resources/messages_zh_CN.properties 1ec4e95
>   client/pom.xml 29fef4f
>   client/tomcatconf/commands.properties.in b9ac27b
>   client/tomcatconf/log4j-cloud.xml.in 08021f2
>   packaging/debian/replace.properties 5a0bd58
>
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/OvsVifDriver.java
> 8e4c710
>
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
> 5b49e5b
>
> plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
> a9840bd
>   plugins/network-elements/nuage-vsp/pom.xml PRE-CREATION
>
> plugins/network-elements/nuage-vsp/resources/META-INF/cloudstack/vsp/module.properties
> PRE-CREATION
>
> plugins/network-elements/nuage-vsp/resources/META-INF/cloudstack/vsp/spring-vsp-context.xml
> PRE-CREATION
>
> plugins/network-elements/nuage-vsp/resources/META-INF/cloudstack/vsp/vsp-defaults.ini
> PRE-CREATION
>
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/StartupVspCommand.java
> PRE-CREATION
>
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/VspResourceAnswer.java
> PRE-CREATION
>
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/VspResourceCommand.java
> PRE-CREATION
>
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyAclRuleVspAnswer.java
> PRE-CREATION
>
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyAclRuleVspCommand.java
> PRE-CREATION
>
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyStaticNatVspAnswer.java
> PRE-CREATION
>
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyStaticNatVspCommand.java
> PRE-CREATION
>
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ShutDownVpcVspAnswer.java
> PRE-CREATION
>
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ShutDownVpcVspCommand.java
> PRE-CREATION
>
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/DeallocateVmVspAnswer.java
> PRE-CREATION
>
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/DeallocateVmVspCommand.java
> PRE-CREATION
>
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ImplementNetworkVspAnswer.java
> PRE-CREATION
>
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ImplementNetworkVspCommand.java
> PRE-CREATION
>
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ReleaseVmVspAnswer.java
> PRE-CREATION
>
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ReleaseVmVspCommand.java
> PRE-CREATION
>
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ReserveVmInterfaceVspAnswer.java
> PRE-CREATION
>
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ReserveVmInterfaceVspCommand.java
> PRE-CREATION
>
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/TrashNetworkVspAnswer.java
> PRE-CREATION
>
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/TrashNetworkVspCommand.java
> PRE-CREATION
>
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/sync/SyncVspAnswer.java
> PRE-CREATION
>
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/sync/SyncVspCommand.java
> PRE-CREATION
>
> plugins/network-elements/nuage-vsp/src/com/cloud/api/commands/AddNuageVspDeviceCmd.java
> PRE-CREATION
>
> plugins/network-elements/nuage-vsp/src/com/cloud/api/commands/DeleteNuageVspDeviceCmd.java
> PRE-CREATION
>
> plugins/network-elements/nuage-vsp/src/com/cloud/api/commands/IssueNuageVspResourceRequestCmd.java
> PRE-CREATION
>
> plugins/network-elements/nuage-vsp/src

Review Request 23314: Plugin specific code for the Brocade Network Plugin

[Ritu Sabharwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23314/
---

Review request for cloudstack.


Summary (updated)
-

Plugin specific code for the Brocade Network Plugin


Bugs: CLOUDSTACK-6823
https://issues.apache.org/jira/browse/CLOUDSTACK-6823


Repository: cloudstack-git


Description (updated)
---

Plugin specific code.


Diffs (updated)
-

  plugins/network-elements/brocade-vcs/pom.xml PRE-CREATION 
  plugins/network-elements/brocade-vcs/resources/BrocadeInterfaceSchema.xsd 
PRE-CREATION 
  plugins/network-elements/brocade-vcs/resources/BrocadePortProfileSchema.xsd 
PRE-CREATION 
  
plugins/network-elements/brocade-vcs/resources/META-INF/cloudstack/vcs/module.properties
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/resources/META-INF/cloudstack/vcs/spring-vcs-context.xml
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/AssociateMacToNetworkAnswer.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/AssociateMacToNetworkCommand.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/CreateNetworkAnswer.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/CreateNetworkCommand.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DeleteNetworkAnswer.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DeleteNetworkCommand.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DisassociateMacFromNetworkAnswer.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DisassociateMacFromNetworkCommand.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/StartupBrocadeVcsCommand.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/BrocadeVcsNetworkHostMappingVO.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApiException.java
 PRE-CREATION 
  plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/Cache.java 
PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/CacheManager.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/Switch.java 
PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/dao/BrocadeVcsNetworkHostMappingDao.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/dao/BrocadeVcsNetworkHostMappingDaoImpl.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/element/BrocadeVcsElement.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/guru/BrocadeVcsGuestNetworkGuru.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/resource/BrocadeVcsResource.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/23314/diff/


Testing
---


Thanks,

Ritu  Sabharwal

Re: Review Request 23314: Plugin specific code for the Brocade Network Plugin

[Ritu Sabharwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23314/
---

(Updated July 7, 2014, 7:08 p.m.)


Review request for cloudstack.


Bugs: CLOUDSTACK-6823
https://issues.apache.org/jira/browse/CLOUDSTACK-6823


Repository: cloudstack-git


Description
---

Plugin specific code.


Diffs (updated)
-

  plugins/network-elements/brocade-vcs/pom.xml PRE-CREATION 
  plugins/network-elements/brocade-vcs/resources/BrocadeInterfaceSchema.xsd 
PRE-CREATION 
  plugins/network-elements/brocade-vcs/resources/BrocadePortProfileSchema.xsd 
PRE-CREATION 
  plugins/network-elements/brocade-vcs/resources/BrocadeShowVcsSchema.xsd 
PRE-CREATION 
  
plugins/network-elements/brocade-vcs/resources/META-INF/cloudstack/vcs/module.properties
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/resources/META-INF/cloudstack/vcs/spring-vcs-context.xml
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/AssociateMacToNetworkAnswer.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/AssociateMacToNetworkCommand.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/CreateNetworkAnswer.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/CreateNetworkCommand.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DeleteNetworkAnswer.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DeleteNetworkCommand.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DisassociateMacFromNetworkAnswer.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DisassociateMacFromNetworkCommand.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/StartupBrocadeVcsCommand.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/BrocadeVcsNetworkHostMappingVO.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApiException.java
 PRE-CREATION 
  plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/Cache.java 
PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/CacheManager.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/Constants.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/Switch.java 
PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/dao/BrocadeVcsNetworkHostMappingDao.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/dao/BrocadeVcsNetworkHostMappingDaoImpl.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/element/BrocadeVcsElement.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/guru/BrocadeVcsGuestNetworkGuru.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/resource/BrocadeVcsResource.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/23314/diff/


Testing
---


Thanks,

Ritu  Sabharwal

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

[Ritu Sabharwal]

> On June 24, 2014, 6:40 a.m., Hugo Trippaers wrote:
> > Hey,
> > 
> > There are a number of issues with this patch, i've made the commments on 
> > the lines directly. Also where is the real functionality? The code in this 
> > patch seems to only be the hook into the existing cloudstack code and not 
> > the brocade code itself?
> > 
> > Cheers,
> > 
> > Hugo
> 
> Ritu  Sabharwal wrote:
> Hi Hugo,
> 
> I commented on the review comments directly. I included a patch file 
> brocade-vcs.patch which has Brocade code. 
> 
> I followed these steps to create the patch:
> 
> -git add plugins/network-elements/brocade-vcs
> -git commit -m "Commit message“
> -git format-patch master --stdout > ~/brocade-vcs.patch
> 
> Is there any other way to include Brocade code in the diffs? Please let 
> me know. I will submit that for review.
> 
> Thanks,
> Ritu.
>
> 
> Hugo Trippaers wrote:
> You can create a separate review request for the vcs code (and post a 
> link in this review) or create a single big patch with everything. I'm fine 
> with either option, but we need the patch in review board as that will help 
> us do the review properly.
> 
> Thanks for fixing the other items.
> 
> Cheers,
> 
> Hugo

Hi Hugo,

I have created another request for vcs specific code. Please find the link for 
the review request: https://reviews.apache.org/r/23314/ 

Hope this helps to review it properly.

Thanks & Regards,
Ritu S.


- Ritu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/#review46498
---


On July 4, 2014, 9:35 a.m., Ritu  Sabharwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22863/
> ---
> 
> (Updated July 4, 2014, 9:35 a.m.)
> 
> 
> Review request for cloudstack and Hugo Trippaers.
> 
> 
> Bugs: CLOUDSTACK-6823
> https://issues.apache.org/jira/browse/CLOUDSTACK-6823
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> First code drop for Brocade Network plugin to orchestrate Brocade VDX 
> switches for L2 connectivity. Please create a new branch for Brocade plugin.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/network/Network.java 885bffe 
>   api/src/com/cloud/network/Networks.java 1e4d229 
>   api/src/com/cloud/network/PhysicalNetwork.java 8cc214e 
>   client/pom.xml 29fef4f 
>   plugins/pom.xml b5e6a61 
>   setup/db/db/schema-440to450.sql 77445a9 
>   ui/scripts/system.js 9a98a5c 
> 
> Diff: https://reviews.apache.org/r/22863/diff/
> 
> 
> Testing
> ---
> 
> • Create an isolated network; verify that the port-profile is created on 
> the Brocade switch.
> • Attach a VM to the network; verify that the VMs MAC address is 
> associated with the port profile of the network on the Brocade switch.
> • Delete VMs for an isolated network; verify that the VMs MAC address is 
> disassociated with the port profile of the network on the Brocade switch.
> • Delete the isolated network; verify that the port-profile is deleted 
> from the Brocade switch.
> 
> 
> File Attachments
> 
> 
> Diff for the existing cloudstack code
>   
> https://reviews.apache.org/media/uploaded/files/2014/06/23/8fc3cfb1-7a21-4714-98f3-6514cf54ba84__diff
> Patch file for Brocade functionality code
>   
> https://reviews.apache.org/media/uploaded/files/2014/06/26/92bb0014-a7b7-4f0b-97c9-018d615b658a__brocade-vcs.patch
> 
> 
> Thanks,
> 
> Ritu  Sabharwal
> 
>

RE: [VOTE] Apache Cloudstack 4.4.0

[Animesh Chaturvedi]

Hugo

My understanding is only binding  votes are counted. Non-binding votes are 
informational

> -Original Message-
> From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers
> Sent: Wednesday, July 02, 2014 11:50 PM
> To: dev@cloudstack.apache.org
> Subject: Re: [VOTE] Apache Cloudstack 4.4.0
> 
> Hey Mike,
> 
> That is technically not the way this vote works. Release votes a a “Lazy
> Majority” vote. This means that the vote requires at least 3 binding +1
> votes and more +1 votes than -1 votes.  For the exact working see
> paragraphs 3.4.4 and 3.2.2 of the Apache CloudStack bylaws.
> 
> 
> 
> Cheers,
> 
> Hugo
> 
> 
> On 3 jul. 2014, at 02:13, Mike Tutkowski 
> wrote:
> 
> > We have at least one binding -1, so this VOTE won't pass.
> >
> > We should continue to test on this RC, though, as Marcus mentioned, in
> > an effort to reduce RC spin.
> >
> > We also shouldn't spin up a new RC until next week as many in the U.S.
> > are on a long weekend starting tomorrow.
> >
> > On Wednesday, July 2, 2014, Marcus  wrote:
> >
> >> -1
> >>
> >> I'm unable to add a KVM host. It seems to be related to changes in
> >> the SshCmdHelper. The mgmt server issues an ssh check to see of the
> >> host has kvm modules installed, which it shows it does, but there is
> >> a null pointer in the SshCmdHelper and it doesn't interpret the
> >> result correctly.  I saw this once, over a month ago, and commented
> >> on CLOUDSTACK-6804. They say the null pointer is fixed in
> >> CLOUDSTACK-6844, but it looks like it was committed in 4.4-forward and
> never pulled in to the release branch.
> >>
> >> I tested this release with
> >> cherry-picking 2ec7359b4eb501b0d9e80ed87af7a54938e9d505 from
> 4.4-forward.
> >> It seems to work, though the fix seems a bit hacky (sleep loop for up
> >> to 1s, waiting for null pointer to not be null), but perhaps I just
> >> don't understand the problem well enough. In the interest of reducing
> >> RC iterations, I went ahead and continued to test per the devcloud-kvm
> docs.
> >> So far everything looks good as far as basic deployment and built-in
> >> storage types.
> >>
> >> * Launched VPC with a default-allow network and a default-deny
> >> network
> >> * launched an nfs-based vm in default-deny and clvm based in
> >> default-allow with qcow2 template
> >> * registered vmdk template for KVM, launched a vm based on it, for
> >> both nfs and lvm
> >> * registered raw image template, launched one for nfs and lvm
> >> * set up port forward for 22 on half of vms, static nat on the other
> >> half, verified default-allow/deny worked as needed
> >> * updated acls to allow 22 into everything, logged in to all servers
> >> to verify they deployed correctly
> >>
> >> I don't believe CLOUDSTACK-6036 should block this release, FWIW.
> >> First, there's no indication from the bug that it still affects
> >> 4.4.0, second, it's not a regression, third, it didn't block the 4.3
> >> release either, fourth, from the sound of it, the worst of the issue
> >> is that a vm is inadvertently stopped if it previously had an issue
> >> stopping and upgrade timing happens to be just right, with a fix of
> simply restarting the vm.
> >>
> >>
> >> On Wed, Jul 2, 2014 at 3:51 PM, Tomasz Zięba  >> > wrote:
> >>
> >>> -1 because CLOUDSTACK-6036
> >>>
> >>>
> >>> 2014-07-02 22:18 GMT+02:00 Daan Hoogland
>  >> >:
> >>>
>  Hi All,
> 
>  I've created a 4.4.0 release, with the following artifacts up for a
> >> vote:
> 
>  Git Branch and Commit SH:
> 
> 
> >>>
> >> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h
> >> =refs/heads/4.4-RC20140702T2107
>  Commit: 379387961bd05d1f84fe2e9a1997e9ecdceef91a
> 
>  List of changes:
> 
> 
> >>>
> >> http://docs.cloudstack.apache.org/projects/cloudstack-release-notes/e
> >> n/latest/
> 
>  Source release (checksums and signatures are available at the same
>  location):
>  https://dist.apache.org/repos/dist/dev/cloudstack/4.4.0/
> 
>  PGP release keys (signed using 4096R/AA4736F3):
>  https://dist.apache.org/repos/dist/release/cloudstack/KEYS
> 
>  Vote will be open for 72 hours.
> 
>  For sanity in tallying the vote, can PMC members please be sure to
>  indicate "(binding)" with their vote?
> 
>  [ ] +1  approve
>  [ ] +0  no opinion
>  [ ] -1  disapprove (and reason why)
> 
> 
>  I will ad my key to the mentioned KEYS file as soon as possible,
>  --
>  Daan
> 
> >>>
> >>>
> >>>
> >>> --
> >>> Regards,
> >>> Tomasz Zięba
> >>> Twitter: @TZieba
> >>> LinkedIn: pl.linkedin.com/pub/tomasz-zięba-ph-d/3b/7a8/ab6/
> >> 
> >>> 
> >>> 
> >>>
> >>
> >
> >
> > --
> > *Mike Tutkowski*
> > *Senior CloudStack Developer, SolidFire Inc.*
> > e: mike.

Testing a Cloudstack Virtual Router (SystemVM).

[Karl Harris]

What is the current framework used to test a Cloudstack Virtual Router
(SystemVM) in isolation aka without Management Server if any?

I'd like to call a SystemVM script with a set of configuration parameters
(changes for VPCVrr, etc.) and observe the changes to the virtual routers
configuration.

Since I will eventually need the ethernet connections to be added and
deleted I would like to aviod using ethernet to make the connection to the
SystemVM image. Ideally I don't want to change the SystemVM image from what
is build by tools/appliance/build.sh.

How was this testing done in the past?

Thanks,

Karl

Re: CLOUDSTACK-6242 - the fix needs to be reverted temporarily

[Daan Hoogland]

Alena, I had no time at all to look at cloudstack today, could you
apply it please. My $dayjob duties are requiring a slightly different
focus the coming week(s)

thanks

On Mon, Jul 7, 2014 at 6:42 PM, Alena Prokharchyk
 wrote:
> Yes, that¹s what I mean - by now, we should log them, but without logging
> the trace. So your fix is correct.
>
> Later, we should fix the installation process so the user is inserted only
> once; and change the logic in ConfigurationServer - instead of logging the
> exception, we should throw the RuntimeException indicating that essential
> CS configuration failed, and that exception should fail MS startup. I will
> file a bug for that after you submit your fix.
>
> Thank you,
> Alena.
>
> On 7/3/14, 1:38 PM, "Daan Hoogland"  wrote:
>
>>Alena, I really want to fix issues in this line, because I really want
>>us to use exceptions properly and never ignore them. So I would like
>>handle them or log at least. Thanks for your patients.
>>
>>I am not sure of what you mean. Is this close:
>>
>>diff --git a/server/src/com/cloud/server/ConfigurationServerImpl.java
>>b/server/src/com/cloud/server/ConfigurationServerImpl.java
>>index b66e52d..a166372 100755
>>--- a/server/src/com/cloud/server/ConfigurationServerImpl.java
>>+++ b/server/src/com/cloud/server/ConfigurationServerImpl.java
>>@@ -462,21 +462,21 @@
>>
>> try {
>> PreparedStatement stmt =
>>txn.prepareAutoCloseStatement(insertSql);
>> stmt.executeUpdate();
>> } catch (SQLException ex) {
>>-s_logger.debug("Caught SQLException when
>>inserting system account ", ex);
>>+s_logger.debug("Caught SQLException when
>>inserting system account: " + ex.getLocalizedMessage());
>> }
>> // insert system user
>> insertSql = "INSERT INTO `cloud`.`user` (id, uuid,
>>username, password, account_id, firstname, lastname, created,
>>user.default)"
>> + " VALUES (1, UUID(), 'system', RAND(), 1,
>>'system', 'cloud', now(), 1)";
>>
>> try {
>> PreparedStatement stmt =
>>txn.prepareAutoCloseStatement(insertSql);
>> stmt.executeUpdate();
>> } catch (SQLException ex) {
>>-s_logger.debug("Caught SQLException when
>>inserting system user ", ex);
>>+s_logger.debug("Caught SQLException when
>>inserting system user: " + ex.getLocalizedMessage());
>> }
>>
>> // insert admin user, but leave the account disabled
>>until we set a
>> // password with the user authenticator
>> long id = 2;
>>@@ -489,22 +489,22 @@
>> + "', '1', '1', 1)";
>> try {
>> PreparedStatement stmt =
>>txn.prepareAutoCloseStatement(insertSql);
>> stmt.executeUpdate();
>> } catch (SQLException ex) {
>>-s_logger.debug("Caught SQLException when creating
>>admin account ", ex);
>>+s_logger.debug("Caught SQLException when creating
>>admin account: " + ex.getLocalizedMessage());
>> }
>>
>> // now insert the user
>> insertSql = "INSERT INTO `cloud`.`user` (id, uuid,
>>username, password, account_id, firstname, lastname, created, state,
>>user.default) " + "VALUES (" + id
>> + ", UUID(), '" + username + "', RAND(), 2,
>>'" + firstname + "','" + lastname + "',now(), 'disabled', 1)";
>>
>> try {
>> PreparedStatement stmt =
>>txn.prepareAutoCloseStatement(insertSql);
>> stmt.executeUpdate();
>> } catch (SQLException ex) {
>>-s_logger.debug("Caught SQLException when
>>inserting user ", ex);
>>+s_logger.debug("Caught SQLException when
>>inserting user " + ex.getLocalizedMessage());
>> }
>>
>> try {
>> String tableName = "security_group";
>> try {
>>
>>On Thu, Jul 3, 2014 at 10:23 PM, Alena Prokharchyk
>> wrote:
>>> Daan, there are similar problem in saveaccount/saveuser methods in thr
>>>same class - introduced by this commit as well. I can fix it myself on
>>>Monday (Its holiday days today and tomorrow at Citrix, usa); or you can
>>>revert them as well along with the fix you do for network groups.
>>>
>>> Let me know, and thank you for the follow up.
>>>
>>> -alena
>>>
 On Jul 2, 2014, at 11:43 PM, "Daan Hoogland" 
wrote:

 On Thu, Jul 3, 2014 at 12:27 AM, Alena Prokharchyk
  wrote:
> In any case, fixes done to ConfigurationManagerImpl are not correct,
>and
> logging should be fixed by reverting/reapplying the commit by
>following
> the rules defined in a) or b).


 changing to
 } catch (Excep

Re: CLOUDSTACK-6242 - the fix needs to be reverted temporarily

[Alena Prokharchyk]

Sure.

On 7/7/14, 2:01 PM, "Daan Hoogland"  wrote:

>Alena, I had no time at all to look at cloudstack today, could you
>apply it please. My $dayjob duties are requiring a slightly different
>focus the coming week(s)
>
>thanks
>
>On Mon, Jul 7, 2014 at 6:42 PM, Alena Prokharchyk
> wrote:
>> Yes, that¹s what I mean - by now, we should log them, but without
>>logging
>> the trace. So your fix is correct.
>>
>> Later, we should fix the installation process so the user is inserted
>>only
>> once; and change the logic in ConfigurationServer - instead of logging
>>the
>> exception, we should throw the RuntimeException indicating that
>>essential
>> CS configuration failed, and that exception should fail MS startup. I
>>will
>> file a bug for that after you submit your fix.
>>
>> Thank you,
>> Alena.
>>
>> On 7/3/14, 1:38 PM, "Daan Hoogland"  wrote:
>>
>>>Alena, I really want to fix issues in this line, because I really want
>>>us to use exceptions properly and never ignore them. So I would like
>>>handle them or log at least. Thanks for your patients.
>>>
>>>I am not sure of what you mean. Is this close:
>>>
>>>diff --git a/server/src/com/cloud/server/ConfigurationServerImpl.java
>>>b/server/src/com/cloud/server/ConfigurationServerImpl.java
>>>index b66e52d..a166372 100755
>>>--- a/server/src/com/cloud/server/ConfigurationServerImpl.java
>>>+++ b/server/src/com/cloud/server/ConfigurationServerImpl.java
>>>@@ -462,21 +462,21 @@
>>>
>>> try {
>>> PreparedStatement stmt =
>>>txn.prepareAutoCloseStatement(insertSql);
>>> stmt.executeUpdate();
>>> } catch (SQLException ex) {
>>>-s_logger.debug("Caught SQLException when
>>>inserting system account ", ex);
>>>+s_logger.debug("Caught SQLException when
>>>inserting system account: " + ex.getLocalizedMessage());
>>> }
>>> // insert system user
>>> insertSql = "INSERT INTO `cloud`.`user` (id, uuid,
>>>username, password, account_id, firstname, lastname, created,
>>>user.default)"
>>> + " VALUES (1, UUID(), 'system', RAND(), 1,
>>>'system', 'cloud', now(), 1)";
>>>
>>> try {
>>> PreparedStatement stmt =
>>>txn.prepareAutoCloseStatement(insertSql);
>>> stmt.executeUpdate();
>>> } catch (SQLException ex) {
>>>-s_logger.debug("Caught SQLException when
>>>inserting system user ", ex);
>>>+s_logger.debug("Caught SQLException when
>>>inserting system user: " + ex.getLocalizedMessage());
>>> }
>>>
>>> // insert admin user, but leave the account disabled
>>>until we set a
>>> // password with the user authenticator
>>> long id = 2;
>>>@@ -489,22 +489,22 @@
>>> + "', '1', '1', 1)";
>>> try {
>>> PreparedStatement stmt =
>>>txn.prepareAutoCloseStatement(insertSql);
>>> stmt.executeUpdate();
>>> } catch (SQLException ex) {
>>>-s_logger.debug("Caught SQLException when creating
>>>admin account ", ex);
>>>+s_logger.debug("Caught SQLException when creating
>>>admin account: " + ex.getLocalizedMessage());
>>> }
>>>
>>> // now insert the user
>>> insertSql = "INSERT INTO `cloud`.`user` (id, uuid,
>>>username, password, account_id, firstname, lastname, created, state,
>>>user.default) " + "VALUES (" + id
>>> + ", UUID(), '" + username + "', RAND(), 2,
>>>'" + firstname + "','" + lastname + "',now(), 'disabled', 1)";
>>>
>>> try {
>>> PreparedStatement stmt =
>>>txn.prepareAutoCloseStatement(insertSql);
>>> stmt.executeUpdate();
>>> } catch (SQLException ex) {
>>>-s_logger.debug("Caught SQLException when
>>>inserting user ", ex);
>>>+s_logger.debug("Caught SQLException when
>>>inserting user " + ex.getLocalizedMessage());
>>> }
>>>
>>> try {
>>> String tableName = "security_group";
>>> try {
>>>
>>>On Thu, Jul 3, 2014 at 10:23 PM, Alena Prokharchyk
>>> wrote:
 Daan, there are similar problem in saveaccount/saveuser methods in thr
same class - introduced by this commit as well. I can fix it myself on
Monday (Its holiday days today and tomorrow at Citrix, usa); or you can
revert them as well along with the fix you do for network groups.

 Let me know, and thank you for the follow up.

 -alena

> On Jul 2, 2014, at 11:43 PM, "Daan Hoogland"
>
>wrote:
>
> On Thu, Jul 3, 2014 at 12:27 AM, Alena Prokharchyk
>  wrote:
>> In any case, fixes done to ConfigurationManagerImpl are not correct,
>>and

Re: Review Request 22717: refactor StoragePoolAllocator#filter logic

[Mike Tutkowski]

I found one issue related to this change. I had to amend the logic in the
filter method of AbstractStoragePoolAllocator to include a check for
HypervisorType.Any (otherwise zone-wide storage with the type of Any is
skipped, which is what's happening to me right now):

} else if (pool.getHypervisor() != null &&
!pool.getHypervisor().equals(HypervisorType.Any) && !(pool.getHypervisor()
== dskCh.getHypervisorType())) {

if (s_logger.isDebugEnabled()) {

s_logger.debug("StoragePool does not have required
hypervisorType, skipping this pool");

}

return false;

}

I plan to check this code in later tonight (this is for master only, by the
way).


On Fri, Jun 27, 2014 at 1:30 PM, Mike Tutkowski <
mike.tutkow...@solidfire.com> wrote:

>
>
> > On June 26, 2014, 11:46 p.m., Mike Tutkowski wrote:
> > > I first had a chance to run this patch through a sophisticated test
> tonight and noticed an issue with zone-wide primary storage that's based on
> the iSCSI protocol.
> > >
> > > This patch leads to iSCSI storage being filtered out for ROOT volumes,
> which is a legitimate use case in my scenario.
> > >
> > > As such, I had to return the filter method to the
> ZoneWideStoragePoolAllocator class.
> > >
> > > I left in the other modification to the AbstractStoragePoolAllocator.
> >
> > Yoshikazu Nojima wrote:
> > I thought the root volume filtering logic weird, but I didn't dig
> into the problem.
> > Since this is a good opportunity, I would like to rethink this logic.
> > which storage requires the root volume filtering logic?
> > I understand that SolidFire's storage doesn't require it, but what
> about other iSCSI storage?
> > Is there any reason that other iSCSI storage cannot handle a root
> volume? Does anyone know?
> > Even if SolidFire's storage is the only iSCSI storage that can
> handle a root volume, I think SolidFire's storage should be exempted from
> the filtering logic not because storage is zone wide, but because storage
> is SolidFire's.
> >
> >
> > Mike Tutkowski wrote:
> > I'm pretty sure any vendor's iSCSI storage can handle root volumes
> as it's just data placed on a disk. I don't know why that logic is there.
> >
> > Any thoughts on how this code ended up in 4.4 and 4.4-forward (since
> the review request is just for master)? If that would have went out to the
> field, it would have rendered my plug-in completely useless.
> >
> > Thanks!
> >
> > Yoshikazu Nojima wrote:
> > Hi Mike,
> >
> > What about reverting your latest
> commit(12e92e10ffbd9f86ebff11c2a1b22c5bafafb3d1) and removing root disk
> filtering logic for iSCSI storage in AbstractStoragePoolAllocator?
> > If you are OK, I'll make a commit.
> >
> > Thanks.
>
> Yeah, no problem. As long as it's only in the master branch, that works.
>
>
> - Mike
>
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22717/#review46838
> ---
>
>
> On June 18, 2014, 12:10 a.m., Yoshikazu Nojima wrote:
> >
> > ---
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/22717/
> > ---
> >
> > (Updated June 18, 2014, 12:10 a.m.)
> >
> >
> > Review request for cloudstack, Mike Tutkowski and Prachi Damle.
> >
> >
> > Repository: cloudstack-git
> >
> >
> > Description
> > ---
> >
> > refactor StoragePoolAllocator#filter logic to enable hypervisor type
> check, storage type check for root volume and avoid list check, and to
> support IOPS capacity control in a cluster wide storage pool and a local
> storage pool.
> >
> >
> > Diffs
> > -
> >
> >
> engine/storage/src/org/apache/cloudstack/storage/allocator/AbstractStoragePoolAllocator.java
> ddbb5a4
> >
> engine/storage/src/org/apache/cloudstack/storage/allocator/ZoneWideStoragePoolAllocator.java
> 8fb9c8d
> >
> > Diff: https://reviews.apache.org/r/22717/diff/
> >
> >
> > Testing
> > ---
> >
> >
> > Thanks,
> >
> > Yoshikazu Nojima
> >
> >
>
>


-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
*™*

deploydb is broken on master (4.5)

[Alena Prokharchyk]

Sebastian/Tim,

DeployDB is broken on master due to commit

commit a8212d9ef458dd7ac64b021e6fa33fcf64b3cce0
Author: Tim Mackey 
Date:   Thu Apr 10 15:57:24 2014 -0400

Cleanup of Xen and XenServer terms. Cloned xen plugin creating a xenserver 
plugin, then removed xen plugin

Signed-off-by: Tim Mackey 
Signed-off-by: Sebastien Goasguen 


The part breaking the build caused by renaming the field “xen_network_label” to 
“xenserver_network_label”.

The field is renamed twice – once in create-schema.sql:

+++ b/setup/db/create-schema.sql
@@ -2091,7 +2091,7 @@ CREATE TABLE `cloud`.`physical_network_traffic_types` (

-  `xen_network_label` varchar(255) COMMENT 'The network name label of the 
physical device dedicated to this traffic on a XenServer host',
+  `xenserver_network_label` varchar(255) COMMENT 'The network name label of 
the physical device dedicated to this traffic on a XenServer host',

 another attempt to modify is done in schema-440to450.sql file:

+ALTER TABLE `cloud`.`physical_network_traffic_types` CHANGE 
`xen_network_label` `xenserver_network_label` varchar(255) COMMENT 'The network 
name label of the physical device dedicated to this traffic on a XenSer

Its incorrect way of doing things as create-schema.sql is executed as a 3.0 
base when deploy the db, and then all upgrade scripts are executed on top. In 
4.5 scenario both create-schema.sql and 44-45upgrade.sql scripts will be 
executed, and the last one will fail because the field was initially created 
with the right name.

Why nobody observed the breakage? Because the line in 44-45.sql script the line 
you’ve added, is the last line and it wasn’t appended with “;”, therefore it 
was never executed :) Once you insert more update statements to the same 
script, the error will come up.

To fix:


  *   remove the update from create-schema.sql.
  *   Append “;” to the last ALTER statement in “schema-440to450.sql"

I’m going to fix it myself as a part of one of my commits.

In the future:


  *   all changes to the db should be done through the upgrade scripts for 
corresponding release (44-45.sql for 4.5 release, 45-46 for 4.6 release, etc), 
without touching the base (create-schema.sql), or modifying previous db upgrade 
scripts
  *   Always append “;” to the end of mysql statement inserted to the .sql 
script otherwise the line won’t be executed

Thank you,
Alena.

Timeout error while brining up VM console from UI for testing Brocade Network Plugin: CLOUDSTACK-6823

[Ritu Sabharwal]

Hi,

I have tested the plugin functionality with the Simulator by creating the 
datacenter with the marvin script and configuring the Brocade VDX switches.

The Brocade VDX switches are configured with the port-profiles and interfaces 
at appropriate lifecycles of VMs.

I can see the VMs coming up and running. I need to bring up the console for the 
VMs to test the ping across the VMs.

In the CloudStack UI, when I click the console button for a VM, I don't get the 
console but see a timeout message.

Thanks & Regards,
Ritu S.

RE: Failing to start Management Server due to bug CLOUDSTACK-7043 on master branch

[Chandan Purushothama]

Hello,

Can anyone aware of the root cause fix the bug on master branch. I am not able 
to work with the management server,

Thank you,
Chandan.

-Original Message-
From: Suresh Sadhu [mailto:suresh.sa...@citrix.com] 
Sent: Friday, July 04, 2014 1:47 AM
To: dev@cloudstack.apache.org
Subject: RE: Failing to start Management Server due to bug CLOUDSTACK-7043 on 
master branch

I am also hitting this bug on master branch  and  its noticed  when we restart 
the management server.in my case management server is up  even though it throws 
sqlexceptions as mentioned in the issue.

Also CPVM fail  to start due decrypt failure error as mentioned in the 
clodstack-7053. 

Regards
Sadhu


-Original Message-
From: Chandan Purushothama [mailto:chandan.purushoth...@citrix.com] 
Sent: 03 July 2014 06:44
To: dev@cloudstack.apache.org
Subject: Failing to start Management Server due to bug CLOUDSTACK-7043 on 
master branch

Hello,

I am hitting bug https://issues.apache.org/jira/browse/CLOUDSTACK-7043 . The 
bug appears similar to bug 
https://issues.apache.org/jira/browse/CLOUDSTACK-7005 . Can anyone aware of the 
root cause fix the bug on master branch,

Thank you,
Chandan.

Re: Failing to start Management Server due to bug CLOUDSTACK-7043 on master branch

[Alena Prokharchyk]

Chandan, are you sure that this bug is the cause of the management server
startup failure? I can see that even after "Error while decrypting:
ZXc_-8u2x0AFV__uuk5y5g² MS continues loading classes/managers. The log
file you¹ve attached to the bug, shows this in the end:

2014-07-02 10:08:30,251 DEBUG [c.c.u.c.DBEncryptionUtil] (main:null) Error
while decrypting: ZXc_-8u2x0AFV__uuk5y5g
2014-07-02 10:08:40,930 INFO  [c.c.u.c.ComponentContext] (main:null)
Configuring 
com.cloud.bridge.persist.dao.CloudStackAccountDaoImpl_EnhancerByCloudStack_
fa


Š...
014-07-02 10:08:41,285 INFO  [c.c.u.c.ComponentContext] (main:null)
Starting 
com.cloud.bridge.service.core.ec2.EC2Engine_EnhancerByCloudStack_1f9e3f8e
2014-07-02 10:08:41,285 INFO  [c.c.u.c.ComponentContext] (main:null)
Starting 
com.cloud.bridge.service.controller.s3.ServiceProvider_EnhancerByCloudStack
_4aceda03



I don¹t see anything indicating MS startup failure in the log. Can you
please double check the error you see the last before MS server process
interrupts? And attach the log to the bug.

Encryption failure should be resolved regardless, but you also have to
debug the MS startup failure root cause.

Thanks,
Alena.

On 7/7/14, 4:23 PM, "Chandan Purushothama"
 wrote:

>Hello,
>
>Can anyone aware of the root cause fix the bug on master branch. I am not
>able to work with the management server,
>
>Thank you,
>Chandan.
>
>-Original Message-
>From: Suresh Sadhu [mailto:suresh.sa...@citrix.com]
>Sent: Friday, July 04, 2014 1:47 AM
>To: dev@cloudstack.apache.org
>Subject: RE: Failing to start Management Server due to bug
>CLOUDSTACK-7043 on master branch
>
>I am also hitting this bug on master branch  and  its noticed  when we
>restart the management server.in my case management server is up  even
>though it throws sqlexceptions as mentioned in the issue.
>
>Also CPVM fail  to start due decrypt failure error as mentioned in the
>clodstack-7053. 
>
>Regards
>Sadhu
>
>
>-Original Message-
>From: Chandan Purushothama [mailto:chandan.purushoth...@citrix.com]
>Sent: 03 July 2014 06:44
>To: dev@cloudstack.apache.org
>Subject: Failing to start Management Server due to bug CLOUDSTACK-7043 on
>master branch
>
>Hello,
>
>I am hitting bug https://issues.apache.org/jira/browse/CLOUDSTACK-7043 .
>The bug appears similar to bug
>https://issues.apache.org/jira/browse/CLOUDSTACK-7005 . Can anyone aware
>of the root cause fix the bug on master branch,
>
>Thank you,
>Chandan.

[DB-CHANGE]

[Alena Prokharchyk]

Please run these mysql statements after getting commit 
5a96d8ef5cbc88df366016ae9dd7ee46e4ca417a on master branch:

ALTER TABLE `cloud`.`user` ADD COLUMN domain_id bigint(20) unsigned DEFAULT 
NULL;
ALTER TABLE `cloud`.`user` ADD CONSTRAINT `fk_user__domain_id` FOREIGN KEY 
`fk_user__domain_id`(`domain_id`) REFERENCES `domain`(`id`) ON DELETE CASCADE;
UPDATE `cloud`.`user` SET `cloud`.`user`.domain_id=(SELECT 
`cloud`.`account`.domain_id   FROM `cloud`.`account`   WHERE 
`cloud`.`account`.id=`cloud`.`user`.account_id) where id > 0;
ALTER TABLE `cloud`.`user` ADD UNIQUE KEY `username_domain_id` 
(`username`,`domain_id`);


-alena.

Master Branch : Network label for XenServer is not updated to "xenservernetworklabel" in zoneWizard.js

[Suresh Ramamurthy]

Hi,

I found that the network label for XenServer is updated to
"xenservernetworklabel" in ApiConstants.java. But, this is value is not
updated in zoneWizard.js.

Due to this, network labels are always set to "Use default gateway" for all
the traffic type for XenServer host. Did any one face this issue with
XenServer host?

Could any one please let me know the process to become a committer so that
I can fix this issue.
I verified the fix in my setup and fix works.

Thanks,
Suresh

P.S. : I tried looking at Contributing page but it is blank (
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Contributing)

Hyper-V hypervisor: Donot have permission to access downloading URL of vomue

[huangchunmei]

Hi All,

 

I installed CS 4.3 and setup a Hype-V vm. When downloading volume of the VM,
I met below issues, any idea to fixed it? Thanks in advance.

Download one volume of Hyper-V vm, then click the link in pop-up, get
following issue,




 

Check the folder "/var/www/html/userdata" of SSVM with command "ls -l", got
below results,



 

 

Thanks,

Mary

撤回: Hyper-V hypervisor: Donot have permission to access downloading URL of vomue

[huangchunmei]

huangchunmei 将撤回邮件“Hyper-V hypervisor: Donot have permission to access
downloading URL of vomue”。

Re: [DB-CHANGE]

[Mike Tutkowski]

Thanks, Alena!

For those of you who may be new to the [DB-CHANGE] tag, the idea, as the
tag implies, is that a developer has changed the schema of the DB. In an
effort to help you not to have an issue after fetching his/her change, the
developer is telling you how you can alter your DB so you don't have to
completely scratch your existing cloud (due to an incompatibility between
the code and the DB) and create it from scratch again.

This typically happens on the master branch as that branch is the most
susceptible to these kinds of changes during development and there is no
script that we maintain to upgrade a DB of the same [major.minor] version.


On Mon, Jul 7, 2014 at 5:36 PM, Alena Prokharchyk <
alena.prokharc...@citrix.com> wrote:

> Please run these mysql statements after getting commit
> 5a96d8ef5cbc88df366016ae9dd7ee46e4ca417a on master branch:
>
> ALTER TABLE `cloud`.`user` ADD COLUMN domain_id bigint(20) unsigned
> DEFAULT NULL;
> ALTER TABLE `cloud`.`user` ADD CONSTRAINT `fk_user__domain_id` FOREIGN KEY
> `fk_user__domain_id`(`domain_id`) REFERENCES `domain`(`id`) ON DELETE
> CASCADE;
> UPDATE `cloud`.`user` SET `cloud`.`user`.domain_id=(SELECT
> `cloud`.`account`.domain_id   FROM `cloud`.`account`   WHERE
> `cloud`.`account`.id=`cloud`.`user`.account_id) where id > 0;
> ALTER TABLE `cloud`.`user` ADD UNIQUE KEY `username_domain_id`
> (`username`,`domain_id`);
>
>
> -alena.
>



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
*™*

RE: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector

[Damoder Reddy]

Ok,

To clarify the windows MSI will not build in the default profile. I have 
enabled a new profile "buildw" to build windows MSI installer which explicitly 
we need to pass similar to nonoss?

Is that sufficient to make it nonoss or still we need to move it under nonoss 
profile explicitly?

Thanks
Damoder/

-Original Message-
From: David Nalley [mailto:da...@gnsa.us] 
Sent: Thursday, 3 July 2014 9:58 PM
To: dev@cloudstack.apache.org
Cc: Damoder Reddy; Koushik Das
Subject: Re: Review Request 23192: Adding Readme and run checkbox at the end of 
the installation. Also installing mysql connector

On Thu, Jul 3, 2014 at 12:08 PM, Chip Childers  wrote:
> On Thu, Jul 03, 2014 at 03:14:30PM +, Leo Simons wrote:
>> It looks like that maven pom on windows _by default_ downloads and 
>> installs a variety of non-apache-license (and/or non-mit/bsd/variant
>> license) software. That shouldnąt really happen. The principle is one 
>> of łleast surprise˛: As a user or developer who does not RTFM, 
>> following the default commands/tools/etc, you should end up with a 
>> more-or-less apache-licensed build result (*) that you can 
>> redistribute the result under.
>
> +1
>
>>
>> But apache policy is that it is acceptable to provide scripts/build 
>> tools/assistance to help those same users/developers do things that 
>> they want to do. As long as they understand the legal situation they end up 
>> in.
>>
>> I would recommend adding a "nonoss" maven profile that the 
>> developer/user has to explicitly select in order to do those 
>> downloads. As long as that option is described clearly, thatąs then 
>> ok. See
>>
>>   http://svn.apache.org/repos/asf/apr/apr/trunk/README
>>
>> for an example of how to point out the license situation.
>
> We already have the nonoss profile, so this is a pretty good fix for 
> the windows build issues noted above IMO.
>
> Damoder/Koushik - please make this change.
>
>>
>> Something similar is true by the way (IMHO, but as a project 
>> cloudstack can definitely decide differently), for a possible MSI 
>> script. Making an MSI script that prompts the user whether to 
>> download mysql at the point of install, **clearly pointing out the 
>> license situation** if they choose to do so, seems reasonable, and I 
>> personally would not object to shipping _that_ kind of script as part of an 
>> apache source release.
>>
>
> +1 - that's a reasonable approach as well.  Damoder / Koushik - what 
> +do
> you think about this approach?
>

I like this approach. We have a number of things that aren't in the 'default' 
build because of policy reasons. This is just another of them.



>> Finally, the _spirit_ behind the apache policies is that there should 
>> be an option to use cloudstack with a license-compatible database 
>> (say, postgres), even if most users will use mysql (just like most 
>> people that use dbm with httpd will use berkely dbm, but you _can_ 
>> use something else). Itąs perhaps unfortunate that this isnąt 
>> supported, but thatąs not apache policy, and given the license 
>> situation of other system dependencies, I can imagine no-one here wants to 
>> make it a priority.
>
> Yeah, that would be nice...  but somebody would have to decide that 
> they want to do that.
>
>>
>>
>> cheers,
>>
>>
>> Leo
>>
>> PS: IANAL, but, a lot of this discussion is a bit beyond legal, and 
>> is about choice/policy, and the policy is supposed to be based on 
>> common sense much more than license stuff tends to be :)
>
> Agreed - this is about policy not legality.
>