Re: [ACS4.5] SQL Error

[sebgoa]

Looping Daan in,

I created an ovmsupport branch to drop some early WIP about ovm3 support. This 
is not yet ready for merge to master.
No ovm3 stuff should be committed to master.

@Daan, can you revert the commits you made yesterday ?

-Sebastien


On Jun 24, 2014, at 12:14 AM, Mike Tutkowski  
wrote:

> Looks like we have another SQL issue on master (this time clicking on the
> Storage button in the GUI):
> 
> DB Exception on: com.mysql.jdbc.JDBC4PreparedStatement@7e1b4c2b: SELECT
> volume_view.id, volume_view.uuid, volume_view.name, volume_view.device_id,
> volume_view.volume_type, volume_view.provisioning_type, volume_view.size,
> volume_view.min_iops, volume_view.max_iops, volume_view.state,
> volume_view.created, volume_view.attached, volume_view.removed,
> volume_view.account_id, volume_view.account_uuid, volume_view.account_name,
> volume_view.account_type, volume_view.domain_id, volume_view.domain_uuid,
> volume_view.domain_name, volume_view.domain_path, volume_view.project_id,
> volume_view.project_uuid, volume_view.project_name, volume_view.pod_id,
> volume_view.data_center_id, volume_view.data_center_uuid,
> volume_view.data_center_name, volume_view.vm_id, volume_view.vm_uuid,
> volume_view.vm_name, volume_view.vm_display_name, volume_view.vm_state,
> volume_view.vm_type, volume_view.volume_store_size,
> volume_view.created_on_store, volume_view.format, volume_view.download_pct,
> volume_view.download_state, volume_view.error_str,
> volume_view.hypervisor_type, volume_view.disk_offering_id,
> volume_view.disk_offering_uuid, volume_view.disk_offering_name,
> volume_view.disk_offering_display_text, volume_view.system_use,
> volume_view.use_local_storage, volume_view.bytes_read_rate,
> volume_view.bytes_write_rate, volume_view.iops_read_rate,
> volume_view.iops_write_rate, volume_view.pool_id, volume_view.pool_uuid,
> volume_view.pool_name, volume_view.template_id, volume_view.template_uuid,
> volume_view.template_name, volume_view.template_display_text,
> volume_view.extractable, volume_view.template_type, volume_view.iso_id,
> volume_view.iso_uuid, volume_view.iso_name, volume_view.iso_display_text,
> volume_view.job_id, volume_view.job_uuid, volume_view.job_status,
> volume_view.tag_id, volume_view.tag_uuid, volume_view.tag_key,
> volume_view.tag_value, volume_view.tag_domain_id,
> volume_view.tag_account_id, volume_view.tag_resource_id,
> volume_view.tag_resource_uuid, volume_view.tag_resource_type,
> volume_view.tag_customer, volume_view.display_volume, volume_view.path,
> volume_view.chain_info FROM volume_view WHERE volume_view.id=3
> 
> 
> On Mon, Jun 23, 2014 at 1:47 PM, Mike Tutkowski <
> mike.tutkow...@solidfire.com> wrote:
> 
>> I see they had an extra couple "$" chars in the code. Thanks for removing
>> them, Ian.
>> 
>> 
>> On Mon, Jun 23, 2014 at 1:43 PM, Mike Tutkowski <
>> mike.tutkow...@solidfire.com> wrote:
>> 
>>> Thanks, Ian
>>> 
>>> 
>>> On Mon, Jun 23, 2014 at 1:41 PM, Ian Duffy  wrote:
>>> 
 Just pushed a fix for it.
 
> The OVM stuff was put in the ovmsupport branch, nothing should be on
 master
 
 There is stuff in master
 
 
 https://github.com/apache/cloudstack/commit/8a485b9b59e4108e862022baf7477f768380b325
 
 On 23 June 2014 20:38, Sebastien Goasguen  wrote:
 
> 
> On Jun 23, 2014, at 3:34 PM, Ian Duffy  wrote:
> 
>> Hey Mike,
>> 
>> This appears to be correct.
>> 
>> There newly added lines in create-schema-sql ending in ;$
>> 
>> They appear to be introduced with the OVM stuff.
> 
> The OVM stuff was put in the ovmsupport branch, nothing should be on
 master
> 
> 
> 
>> 
>> 
>> On 23 June 2014 20:17, Mike Tutkowski 
> wrote:
>> 
>>> Do we seriously have an error in our SQL code? :) I ran mvn -P
 developer
>>> -pl developer -D deploydb and received the following:
>>> 
>>> > Processing SQL file at
>>> /home/cloudstack/cloudstack/developer/target/db/create-schema.sql
>>> Unable to execute
>>> /home/cloudstack/cloudstack/developer/target/db/create-schema.sql:
 You
> have
>>> an error in your SQL syntax; check the manual that corresponds to
 your
>>> MySQL server version for the right syntax to use near '$ INSERT
 IGNORE
> INTO
>>> `cloud`.`hypervisor_capabilities`(hypervisor_type, hypervis' at
 line 1
>>> 
>>> --
>>> *Mike Tutkowski*
>>> *Senior CloudStack Developer, SolidFire Inc.*
>>> e: mike.tutkow...@solidfire.com
>>> o: 303.746.7302
>>> Advancing the way the world uses the cloud
>>> *™*
>>> 
> 
> 
 
>>> 
>>> 
>>> 
>>> --
>>> *Mike Tutkowski*
>>> *Senior CloudStack Developer, SolidFire Inc.*
>>> e: mike.tutkow...@solidfire.com
>>> o: 303.746.7302
>>> Advancing the way the world uses the cloud
>>> *™*
>>> 
>>

Custom popup forms w.r.t Plugin Provider

[Punith S]

hi,

I am in process of adding a new Add Primary Storage (specific to my Storage
plugin) form  whose labels & certain values will be different than the
current Default Provider's Add Primary Storage form.
also looping the GSoC'14
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Create+GUI+to+add+primary+storage+based+on+plug-ins

it seems adding more checks and if-else clauses in system.js will make it
more fragile and unmanageable.

use case:
since each vendor requires to use ui with their own specific params,

for example with add primary storage:
referring the attachment, popup form will be dynamically changed to have
different params wrt the selected storage providers.

hence instead of writing the vendor specific code inside system.js(common
file)
is it acceptable to modularize the code to different vendor specific js
files like in writing a third party UI plugin ?
ref -
https://cwiki.apache.org/confluence/display/CLOUDSTACK/UI+Plugin+Tutorial

thanks
-- 
regards,

punith s
cloudbyte.com

Re: Problem with Management server and connection to the databse

[sebgoa]

you are probably hitting the warning:

http://docs.cloudstack.apache.org/projects/cloudstack-installation/en/latest/installation.html#install-on-ubuntu



On Jun 23, 2014, at 11:54 PM, Ian Duffy  wrote:

> Sounds like a missing mysql driver jar.
> 
> Please see the following solution:
> http://blog.widodh.nl/2014/03/sql-connection-error-after-upgrade-to-cloudstack-4-3-0/
> 
> 
> On 23 June 2014 22:41, Seif Eddine Jemli  wrote:
> 
>> Hi everyone,
>> 
>> I am having a 404 error when trying to access  *
>> http://localhost:8080/client
>> ,  *this exception is in the
>> management-server.log
>> 
>> 
>> 2014-06-23 20:43:26,899 INFO  [c.c.u.d.T.Transaction] (main:null) Is Data
>> Base High Availiability enabled? Ans : false
>> 2014-06-23 20:43:26,915 ERROR [c.c.u.d.Merovingian2] (main:null) Unable to
>> get a new db connection
>> *java.sql.SQLException: No suitable driver found for
>> jdbc:mysql://localhost:3306/cloud?*
>> autoReconnect=true&prepStmtCacheSize=517&cachePrepStmts=true
>> at java.sql.DriverManager.getConnection(DriverManager.java:596)
>> at java.sql.DriverManager.getConnection(DriverManager.java:215)
>> at
>> 
>> org.apache.commons.dbcp.DriverManagerConnectionFactory.createConnection(DriverManagerConnectionFactory.java:75)
>> at
>> 
>> org.apache.commons.dbcp.PoolableConnectionFactory.makeObject(PoolableConnectionFactory.java:582)
>> at
>> 
>> org.apache.commons.pool.impl.GenericObjectPool.borrowObject(GenericObjectPool.java:1188)
>> at
>> 
>> org.apache.commons.dbcp.PoolingDataSource.getConnection(PoolingDataSource.java:106)
>> at
>> 
>> com.cloud.utils.db.TransactionLegacy.getStandaloneConnectionWithException(TransactionLegacy.java:204)
>> at com.cloud.utils.db.Merovingian2.(Merovingian2.java:68)
>> at com.cloud.utils.db.Merovingian2.createLockMaster(Merovingian2.java:80)
>> at com.cloud.server.LockMasterListener.(LockMasterListener.java:33)
>> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
>> at
>> 
>> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:57)
>> at
>> 
>> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
>> at java.lang.reflect.Constructor.newInstance(Constructor.java:526)
>> at org.springframework.beans.BeanUtils.instantiateClass(BeanUtils.java:148)
>> at
>> 
>> org.springframework.beans.factory.support.SimpleInstantiationStrategy.instantiate(SimpleInstantiationStrategy.java:121)
>> at
>> 
>> org.springframework.beans.factory.support.ConstructorResolver.autowireConstructor(ConstructorResolver.java:280)
>> at
>> 
>> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.autowireConstructor(AbstractAutowireCapableBeanFactory.java:1045)
>> 
>> 
>> what can be the problem?
>> thanks.
>> 

Re: CS 4.3 - Registering network-element plugin

[Pradeep Cloudstack]

Thanks Punith.
We had tried this.
However the jar file that is built didnot include the spring-*-context.xml and 
module.properties
as a result of which our plugin didnot get registered.

We followed the approach that was taken for vxlan and created artifacts on 
similar lines.

Can you pls help on what we are missing ?


-Pradeep




 From: Punith S 
To: cloudstack ; Pradeep Cloudstack 
 
Sent: Tuesday, June 24, 2014 12:11 PM
Subject: Re: CS 4.3 - Registering network-element plugin
 

hi pradeep,

the spring framework has been modularized in 4.3 onwards,
this link might help you in registering the new plugin.
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Plug-ins%2C+Modules%2C+and+Extensions

thanks,





On Tue, Jun 24, 2014 at 11:57 AM, Pradeep Cloudstack <
pradeepcloudst...@yahoo.com.invalid> wrote:

> Hi team,
> I need some help in registering network-element plugin in a 4.3
> installation.
>
> In 4.2 release, we used to make entries in componentContext.xml.
>
> However in 4.3, looks like there is a NetworkGuru Registry.
> How do we register our plugin here?
>
> -Pradeep
>



-- 
regards,

punith s
cloudbyte.com

[ACS4.4] release meeting + query on release readiness

[Daan Hoogland]

H,

Yesterday I cancelled the second release meeting on IRC due to poor
attendance. At the moment there is a lot of work going on on the 4.4
branch and I still get between two and ten pull requests a day. On the
other hand I don't see any discussion on the list on how serious or
trivial the remaining issues in 4.4 are. This is very frustrating. It
is like there is a beast behind a wall and I don't know which of the
two is stronger. I could bake an RC now but I know we will get into a
tiresome iteration of finding and solving one blocker at the time.,
so:

Please describe any remaining issues that you have with the present
state of the 4.4 branch.

-- 
Daan

RE: [DISCUSS] Global Settings - Inheritance Rules

[Ram Ganesh]

In the cloudstack UI we do have certain parameters defined at Zone and Cluster 
level which can be used to override the global values. Say for zone level 
parameters browse to  Infrastructure > Zones >  Settings tab. You 
will see  bunch of settings defined. Similarly the case with cluster. I am sure 
there are lot more settings that be defined here. Also missing is settings at 
Storage for example.  Or are you referring to defining a first class entity say 
Profile which can used to define a group of these settings and then the profile 
can either be assigned at the global level or zone or cluster or host level?


> -Original Message-
> From: Chiradeep Vittal [mailto:chiradeep.vit...@citrix.com]
> Sent: 24 June 2014 11:46
> To: dev@cloudstack.apache.org
> Subject: Re: [DISCUSS] Global Settings - Inheritance Rules
> 
> Sounds reasonable, but I think it would take a certain amount of refactoring.
> 
> From: ilya musayev
> mailto:ilya.mailing.li...@gmail.com>>
> Reply-To:
> "dev@cloudstack.apache.org"
> mailto:dev@cloudstack.apache.org>>
> Date: Monday, June 23, 2014 at 2:37 PM
> To: "dev@cloudstack.apache.org"
> mailto:dev@cloudstack.apache.org>>
> Subject: [DISCUSS] Global Settings - Inheritance Rules
> 
> Not certain if this mechanism exists, if it does, please let me know.
> 
> Some settings in ACS that are defined as global setting - can be used on much
> lower level, for example vm.full.clone - can be used on global, zone, pod,
> cluster and possibly even VM itself.
> systemvm.use.local.disk - should be a global and zone vm.instancename.flag
> - can be used on zone level, pod and cluster (or even VM)
> 
> Instead of porting one call at a time based on customer request, would it be
> possible to define Global Setting inheritance rule set. For example if
> inheritance rule is set to global, it can be overriden on zone leve, and even
> cluster or host. We would need a settings inheritance tab - that shows what
> configs have been inherited from upstream and ability to override the config
> on lower level.
> 
> I'd propose for inheritance to go from Global Setting, Zone, Pod, Cluster,
> Host and VM. Needless to say, not all Global Settings can be in each category.
> 
> Any thoughts on this?

Re: CS 4.3 - Registering network-element plugin

[Punith S]

hi pradeep,

can you make sure your jar is present in the cloud war.
to make this happen you have to register the dependency in the client
pom.xml file.

also you need to register your plugin in the plugin pom.xml file and make
sure the provider name matches.

thanks.



On Tue, Jun 24, 2014 at 12:38 PM, Pradeep Cloudstack <
pradeepcloudst...@yahoo.com.invalid> wrote:

> Thanks Punith.
> We had tried this.
> However the jar file that is built didnot include the spring-*-context.xml
> and module.properties
> as a result of which our plugin didnot get registered.
>
> We followed the approach that was taken for vxlan and created artifacts on
> similar lines.
>
> Can you pls help on what we are missing ?
>
>
> -Pradeep
>
>
>
> 
>  From: Punith S 
> To: cloudstack ; Pradeep Cloudstack <
> pradeepcloudst...@yahoo.com>
> Sent: Tuesday, June 24, 2014 12:11 PM
> Subject: Re: CS 4.3 - Registering network-element plugin
>
>
> hi pradeep,
>
> the spring framework has been modularized in 4.3 onwards,
> this link might help you in registering the new plugin.
>
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Plug-ins%2C+Modules%2C+and+Extensions
>
> thanks,
>
>
>
>
>
> On Tue, Jun 24, 2014 at 11:57 AM, Pradeep Cloudstack <
> pradeepcloudst...@yahoo.com.invalid> wrote:
>
> > Hi team,
> > I need some help in registering network-element plugin in a 4.3
> > installation.
> >
> > In 4.2 release, we used to make entries in componentContext.xml.
> >
> > However in 4.3, looks like there is a NetworkGuru Registry.
> > How do we register our plugin here?
> >
> > -Pradeep
> >
>
>
>
> --
> regards,
>
> punith s
> cloudbyte.com
>



-- 
regards,

punith s
cloudbyte.com

Re: Review Request 22672: CLOUDSTACK-6914: Fixed the mentioned issue for vgpu cases along with tagging

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22672/#review46503
---


Commit c7d00d52b2b7e375008f3fabbd1ec96c1e6e7238 in cloudstack's branch 
refs/heads/4.4-forward from Girish Shilamkar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=c7d00d5 ]

CLOUDSTACK-6914: Disabling few failing BVTs


- ASF Subversion and Git Services


On June 17, 2014, 5:01 a.m., Santhosh Edukulla wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22672/
> ---
> 
> (Updated June 17, 2014, 5:01 a.m.)
> 
> 
> Review request for cloudstack and Abhinandan Prateek.
> 
> 
> Bugs: CLOUDSTACK-6914
> https://issues.apache.org/jira/browse/CLOUDSTACK-6914
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fixed the vgpu case hypervisor check, and added missing tags to master.
> 
> 
> Diffs
> -
> 
>   test/integration/smoke/test_affinity_groups.py bb0a524 
>   test/integration/smoke/test_deploy_vgpu_enabled_vm.py 13fad61 
>   test/integration/smoke/test_deploy_vm.py 87e0011 
>   test/integration/smoke/test_deploy_vm_root_resize.py 8097d08 
>   test/integration/smoke/test_deploy_vm_with_userdata.py 7616b82 
>   test/integration/smoke/test_deploy_vms_with_varied_deploymentplanners.py 
> 420925e 
>   test/integration/smoke/test_disk_offerings.py 780c154 
>   test/integration/smoke/test_global_settings.py ace2db3 
>   test/integration/smoke/test_guest_vlan_range.py f5bcdf4 
>   test/integration/smoke/test_internal_lb.py d6f3477 
>   test/integration/smoke/test_iso.py 6741633 
>   test/integration/smoke/test_loadbalance.py daa5fee 
>   test/integration/smoke/test_multipleips_per_nic.py ad3a3cf 
>   test/integration/smoke/test_network.py 52efc32 
>   test/integration/smoke/test_network_acl.py 68e5067 
>   test/integration/smoke/test_nic.py 592a839 
>   test/integration/smoke/test_non_contigiousvlan.py 50b48d0 
>   test/integration/smoke/test_over_provisioning.py 1c5d8a5 
>   test/integration/smoke/test_portable_publicip.py 2d02a71 
>   test/integration/smoke/test_primary_storage.py 3147d86 
>   test/integration/smoke/test_privategw_acl.py c86beb1 
>   test/integration/smoke/test_public_ip_range.py b961dc3 
>   test/integration/smoke/test_pvlan.py 7d1aa5d 
>   test/integration/smoke/test_regions.py 389f878 
>   test/integration/smoke/test_reset_vm_on_reboot.py 4709df4 
>   test/integration/smoke/test_resource_detail.py 7f4a6e7 
>   test/integration/smoke/test_routers.py 2aa83c3 
>   test/integration/smoke/test_scale_vm.py f0ec534 
>   test/integration/smoke/test_secondary_storage.py 90304b3 
>   test/integration/smoke/test_service_offerings.py 980e110 
>   test/integration/smoke/test_snapshots.py a960e70 
>   test/integration/smoke/test_ssvm.py ffa620b 
>   test/integration/smoke/test_templates.py c7594bb 
>   test/integration/smoke/test_vm_ha.py 4063946 
>   test/integration/smoke/test_vm_life_cycle.py 104b86c 
>   test/integration/smoke/test_vm_snapshots.py e884d42 
>   test/integration/smoke/test_volumes.py c6ea09d 
>   test/integration/smoke/test_vpc_vpn.py 03826e9 
>   tools/marvin/marvin/config/test_data.py cfc4556 
> 
> Diff: https://reviews.apache.org/r/22672/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>

Re: Review Request 22672: CLOUDSTACK-6914: Fixed the mentioned issue for vgpu cases along with tagging

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22672/#review46504
---


Commit fef55acbbf4c567e4e5d122d7a6cc45b19cd7872 in cloudstack's branch 
refs/heads/master from Girish Shilamkar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=fef55ac ]

CLOUDSTACK-6914: Disabling few failing BVTs


- ASF Subversion and Git Services


On June 17, 2014, 5:01 a.m., Santhosh Edukulla wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22672/
> ---
> 
> (Updated June 17, 2014, 5:01 a.m.)
> 
> 
> Review request for cloudstack and Abhinandan Prateek.
> 
> 
> Bugs: CLOUDSTACK-6914
> https://issues.apache.org/jira/browse/CLOUDSTACK-6914
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fixed the vgpu case hypervisor check, and added missing tags to master.
> 
> 
> Diffs
> -
> 
>   test/integration/smoke/test_affinity_groups.py bb0a524 
>   test/integration/smoke/test_deploy_vgpu_enabled_vm.py 13fad61 
>   test/integration/smoke/test_deploy_vm.py 87e0011 
>   test/integration/smoke/test_deploy_vm_root_resize.py 8097d08 
>   test/integration/smoke/test_deploy_vm_with_userdata.py 7616b82 
>   test/integration/smoke/test_deploy_vms_with_varied_deploymentplanners.py 
> 420925e 
>   test/integration/smoke/test_disk_offerings.py 780c154 
>   test/integration/smoke/test_global_settings.py ace2db3 
>   test/integration/smoke/test_guest_vlan_range.py f5bcdf4 
>   test/integration/smoke/test_internal_lb.py d6f3477 
>   test/integration/smoke/test_iso.py 6741633 
>   test/integration/smoke/test_loadbalance.py daa5fee 
>   test/integration/smoke/test_multipleips_per_nic.py ad3a3cf 
>   test/integration/smoke/test_network.py 52efc32 
>   test/integration/smoke/test_network_acl.py 68e5067 
>   test/integration/smoke/test_nic.py 592a839 
>   test/integration/smoke/test_non_contigiousvlan.py 50b48d0 
>   test/integration/smoke/test_over_provisioning.py 1c5d8a5 
>   test/integration/smoke/test_portable_publicip.py 2d02a71 
>   test/integration/smoke/test_primary_storage.py 3147d86 
>   test/integration/smoke/test_privategw_acl.py c86beb1 
>   test/integration/smoke/test_public_ip_range.py b961dc3 
>   test/integration/smoke/test_pvlan.py 7d1aa5d 
>   test/integration/smoke/test_regions.py 389f878 
>   test/integration/smoke/test_reset_vm_on_reboot.py 4709df4 
>   test/integration/smoke/test_resource_detail.py 7f4a6e7 
>   test/integration/smoke/test_routers.py 2aa83c3 
>   test/integration/smoke/test_scale_vm.py f0ec534 
>   test/integration/smoke/test_secondary_storage.py 90304b3 
>   test/integration/smoke/test_service_offerings.py 980e110 
>   test/integration/smoke/test_snapshots.py a960e70 
>   test/integration/smoke/test_ssvm.py ffa620b 
>   test/integration/smoke/test_templates.py c7594bb 
>   test/integration/smoke/test_vm_ha.py 4063946 
>   test/integration/smoke/test_vm_life_cycle.py 104b86c 
>   test/integration/smoke/test_vm_snapshots.py e884d42 
>   test/integration/smoke/test_volumes.py c6ea09d 
>   test/integration/smoke/test_vpc_vpn.py 03826e9 
>   tools/marvin/marvin/config/test_data.py cfc4556 
> 
> Diff: https://reviews.apache.org/r/22672/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>

Re: [ACS-4.4] cherry-pick

[Daan Hoogland]

On Tue, Jun 24, 2014 at 7:38 AM, Jayapal Reddy Uradi
 wrote:
> a195e50ae7da4b4392844e2984823c1331ca1396


is in

-- 
Daan

Re: [ACS4.5] SQL Error

[Daan Hoogland]

I will revert, this is definatelly my bad.

On Tue, Jun 24, 2014 at 9:00 AM, sebgoa  wrote:
> Looping Daan in,
>
> I created an ovmsupport branch to drop some early WIP about ovm3 support. 
> This is not yet ready for merge to master.
> No ovm3 stuff should be committed to master.
>
> @Daan, can you revert the commits you made yesterday ?
>
> -Sebastien
>
>
> On Jun 24, 2014, at 12:14 AM, Mike Tutkowski  
> wrote:
>
>> Looks like we have another SQL issue on master (this time clicking on the
>> Storage button in the GUI):
>>
>> DB Exception on: com.mysql.jdbc.JDBC4PreparedStatement@7e1b4c2b: SELECT
>> volume_view.id, volume_view.uuid, volume_view.name, volume_view.device_id,
>> volume_view.volume_type, volume_view.provisioning_type, volume_view.size,
>> volume_view.min_iops, volume_view.max_iops, volume_view.state,
>> volume_view.created, volume_view.attached, volume_view.removed,
>> volume_view.account_id, volume_view.account_uuid, volume_view.account_name,
>> volume_view.account_type, volume_view.domain_id, volume_view.domain_uuid,
>> volume_view.domain_name, volume_view.domain_path, volume_view.project_id,
>> volume_view.project_uuid, volume_view.project_name, volume_view.pod_id,
>> volume_view.data_center_id, volume_view.data_center_uuid,
>> volume_view.data_center_name, volume_view.vm_id, volume_view.vm_uuid,
>> volume_view.vm_name, volume_view.vm_display_name, volume_view.vm_state,
>> volume_view.vm_type, volume_view.volume_store_size,
>> volume_view.created_on_store, volume_view.format, volume_view.download_pct,
>> volume_view.download_state, volume_view.error_str,
>> volume_view.hypervisor_type, volume_view.disk_offering_id,
>> volume_view.disk_offering_uuid, volume_view.disk_offering_name,
>> volume_view.disk_offering_display_text, volume_view.system_use,
>> volume_view.use_local_storage, volume_view.bytes_read_rate,
>> volume_view.bytes_write_rate, volume_view.iops_read_rate,
>> volume_view.iops_write_rate, volume_view.pool_id, volume_view.pool_uuid,
>> volume_view.pool_name, volume_view.template_id, volume_view.template_uuid,
>> volume_view.template_name, volume_view.template_display_text,
>> volume_view.extractable, volume_view.template_type, volume_view.iso_id,
>> volume_view.iso_uuid, volume_view.iso_name, volume_view.iso_display_text,
>> volume_view.job_id, volume_view.job_uuid, volume_view.job_status,
>> volume_view.tag_id, volume_view.tag_uuid, volume_view.tag_key,
>> volume_view.tag_value, volume_view.tag_domain_id,
>> volume_view.tag_account_id, volume_view.tag_resource_id,
>> volume_view.tag_resource_uuid, volume_view.tag_resource_type,
>> volume_view.tag_customer, volume_view.display_volume, volume_view.path,
>> volume_view.chain_info FROM volume_view WHERE volume_view.id=3
>>
>>
>> On Mon, Jun 23, 2014 at 1:47 PM, Mike Tutkowski <
>> mike.tutkow...@solidfire.com> wrote:
>>
>>> I see they had an extra couple "$" chars in the code. Thanks for removing
>>> them, Ian.
>>>
>>>
>>> On Mon, Jun 23, 2014 at 1:43 PM, Mike Tutkowski <
>>> mike.tutkow...@solidfire.com> wrote:
>>>
 Thanks, Ian


 On Mon, Jun 23, 2014 at 1:41 PM, Ian Duffy  wrote:

> Just pushed a fix for it.
>
>> The OVM stuff was put in the ovmsupport branch, nothing should be on
> master
>
> There is stuff in master
>
>
> https://github.com/apache/cloudstack/commit/8a485b9b59e4108e862022baf7477f768380b325
>
> On 23 June 2014 20:38, Sebastien Goasguen  wrote:
>
>>
>> On Jun 23, 2014, at 3:34 PM, Ian Duffy  wrote:
>>
>>> Hey Mike,
>>>
>>> This appears to be correct.
>>>
>>> There newly added lines in create-schema-sql ending in ;$
>>>
>>> They appear to be introduced with the OVM stuff.
>>
>> The OVM stuff was put in the ovmsupport branch, nothing should be on
> master
>>
>>
>>
>>>
>>>
>>> On 23 June 2014 20:17, Mike Tutkowski 
>> wrote:
>>>
 Do we seriously have an error in our SQL code? :) I ran mvn -P
> developer
 -pl developer -D deploydb and received the following:

 > Processing SQL file at
 /home/cloudstack/cloudstack/developer/target/db/create-schema.sql
 Unable to execute
 /home/cloudstack/cloudstack/developer/target/db/create-schema.sql:
> You
>> have
 an error in your SQL syntax; check the manual that corresponds to
> your
 MySQL server version for the right syntax to use near '$ INSERT
> IGNORE
>> INTO
 `cloud`.`hypervisor_capabilities`(hypervisor_type, hypervis' at
> line 1

 --
 *Mike Tutkowski*
 *Senior CloudStack Developer, SolidFire Inc.*
 e: mike.tutkow...@solidfire.com
 o: 303.746.7302
 Advancing the way the world uses the cloud
 *™*

>>
>>
>



 --
 *Mike Tutkowski*
 *Senior CloudStack 

Re: [ACS4.5] SQL Error

[Daan Hoogland]

I reverted my and Ian's commits. I will have a look on how to rebase
them in ovmsupport on latest master.

On Tue, Jun 24, 2014 at 10:19 AM, Daan Hoogland  wrote:
> I will revert, this is definatelly my bad.
>
> On Tue, Jun 24, 2014 at 9:00 AM, sebgoa  wrote:
>> Looping Daan in,
>>
>> I created an ovmsupport branch to drop some early WIP about ovm3 support. 
>> This is not yet ready for merge to master.
>> No ovm3 stuff should be committed to master.
>>
>> @Daan, can you revert the commits you made yesterday ?
>>
>> -Sebastien
>>
>>
>> On Jun 24, 2014, at 12:14 AM, Mike Tutkowski  
>> wrote:
>>
>>> Looks like we have another SQL issue on master (this time clicking on the
>>> Storage button in the GUI):
>>>
>>> DB Exception on: com.mysql.jdbc.JDBC4PreparedStatement@7e1b4c2b: SELECT
>>> volume_view.id, volume_view.uuid, volume_view.name, volume_view.device_id,
>>> volume_view.volume_type, volume_view.provisioning_type, volume_view.size,
>>> volume_view.min_iops, volume_view.max_iops, volume_view.state,
>>> volume_view.created, volume_view.attached, volume_view.removed,
>>> volume_view.account_id, volume_view.account_uuid, volume_view.account_name,
>>> volume_view.account_type, volume_view.domain_id, volume_view.domain_uuid,
>>> volume_view.domain_name, volume_view.domain_path, volume_view.project_id,
>>> volume_view.project_uuid, volume_view.project_name, volume_view.pod_id,
>>> volume_view.data_center_id, volume_view.data_center_uuid,
>>> volume_view.data_center_name, volume_view.vm_id, volume_view.vm_uuid,
>>> volume_view.vm_name, volume_view.vm_display_name, volume_view.vm_state,
>>> volume_view.vm_type, volume_view.volume_store_size,
>>> volume_view.created_on_store, volume_view.format, volume_view.download_pct,
>>> volume_view.download_state, volume_view.error_str,
>>> volume_view.hypervisor_type, volume_view.disk_offering_id,
>>> volume_view.disk_offering_uuid, volume_view.disk_offering_name,
>>> volume_view.disk_offering_display_text, volume_view.system_use,
>>> volume_view.use_local_storage, volume_view.bytes_read_rate,
>>> volume_view.bytes_write_rate, volume_view.iops_read_rate,
>>> volume_view.iops_write_rate, volume_view.pool_id, volume_view.pool_uuid,
>>> volume_view.pool_name, volume_view.template_id, volume_view.template_uuid,
>>> volume_view.template_name, volume_view.template_display_text,
>>> volume_view.extractable, volume_view.template_type, volume_view.iso_id,
>>> volume_view.iso_uuid, volume_view.iso_name, volume_view.iso_display_text,
>>> volume_view.job_id, volume_view.job_uuid, volume_view.job_status,
>>> volume_view.tag_id, volume_view.tag_uuid, volume_view.tag_key,
>>> volume_view.tag_value, volume_view.tag_domain_id,
>>> volume_view.tag_account_id, volume_view.tag_resource_id,
>>> volume_view.tag_resource_uuid, volume_view.tag_resource_type,
>>> volume_view.tag_customer, volume_view.display_volume, volume_view.path,
>>> volume_view.chain_info FROM volume_view WHERE volume_view.id=3
>>>
>>>
>>> On Mon, Jun 23, 2014 at 1:47 PM, Mike Tutkowski <
>>> mike.tutkow...@solidfire.com> wrote:
>>>
 I see they had an extra couple "$" chars in the code. Thanks for removing
 them, Ian.


 On Mon, Jun 23, 2014 at 1:43 PM, Mike Tutkowski <
 mike.tutkow...@solidfire.com> wrote:

> Thanks, Ian
>
>
> On Mon, Jun 23, 2014 at 1:41 PM, Ian Duffy  wrote:
>
>> Just pushed a fix for it.
>>
>>> The OVM stuff was put in the ovmsupport branch, nothing should be on
>> master
>>
>> There is stuff in master
>>
>>
>> https://github.com/apache/cloudstack/commit/8a485b9b59e4108e862022baf7477f768380b325
>>
>> On 23 June 2014 20:38, Sebastien Goasguen  wrote:
>>
>>>
>>> On Jun 23, 2014, at 3:34 PM, Ian Duffy  wrote:
>>>
 Hey Mike,

 This appears to be correct.

 There newly added lines in create-schema-sql ending in ;$

 They appear to be introduced with the OVM stuff.
>>>
>>> The OVM stuff was put in the ovmsupport branch, nothing should be on
>> master
>>>
>>>
>>>


 On 23 June 2014 20:17, Mike Tutkowski 
>>> wrote:

> Do we seriously have an error in our SQL code? :) I ran mvn -P
>> developer
> -pl developer -D deploydb and received the following:
>
> > Processing SQL file at
> /home/cloudstack/cloudstack/developer/target/db/create-schema.sql
> Unable to execute
> /home/cloudstack/cloudstack/developer/target/db/create-schema.sql:
>> You
>>> have
> an error in your SQL syntax; check the manual that corresponds to
>> your
> MySQL server version for the right syntax to use near '$ INSERT
>> IGNORE
>>> INTO
> `cloud`.`hypervisor_capabilities`(hypervisor_type, hypervis' at
>> line 1
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire

create_schema.sql

[Hugo Trippaers]

Dear committers,


When either committing or reviewing, please pay attention to the fact the 
create_schema.sql should NOT be modified under any circumstances. Since release 
4.1 this file is considered frozen and updates to the schema will be in the 
upgrade scripts for the versions.

At the moment a number of commits have been accepted that modify the schema 
which we now have to clean up or revert.

Please pay attention to this.


Cheers,

Hugo

Re: [security] The case of the open dns resolver

[Nux!]

Hi,

I'm on 4.3/KVM/ADV+SG. The rules that I am talking about are the ones from 
within the VR and they explicitly open port 53 to everyone.

Lucian

--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro


- Original Message -
From: "Erik Weber" 
To: "dev" 
Sent: Monday, 23 June, 2014 9:02:23 PM
Subject: Re: [security] The case of the open dns resolver

On Mon, Jun 23, 2014 at 12:31 PM, Nux!  wrote:

> Hi,
>
> Today I've been bitten again by the $subject and complaints were sent to
> my hoster's abuse email address; apparently someone used my VR in a DDOS
> attack.
> It is my fault as I knew about this issue, but I'd like to throw the blame
> on Cloudstack. :)
>
> So, the VR is accepting DNS requests from everybody on the interwebs and
> this should be changed, imho.
>
> I see there are already iptables rules concerning port 8080 of the VR and
> only the public IP ranges are allowed. Why isn't this the case for port 53
> as well?
>
> I have placed this script in my VR's rc.local, but it's not kosher at all.
>
> # disallows global DNS traffic and only allows it from the cloud public
> subnets
> for i in `iptables-save |grep 8080|awk '{print $4}'`; do iptables -I INPUT
> -s $i -p tcp -m tcp --dport 53 -j ACCEPT; iptables -I INPUT -s $i -p udp -m
> udp --dport 53 -j ACCEPT; done
> iptables -D INPUT -i eth0 -p udp -m udp --dport 53 -j ACCEPT
> iptables -D INPUT -i eth0 -p tcp -m tcp --dport 53 -j ACCEPT
>
> This could be greatly improved and added in the official tree.
> Currently I'm getting the subnets by checking which IPs the 8080 rules
> apply, how can I retrieve this information in a more elegant way?
>


Which version are you running?

On a 4.3 installation I see no iptables rules that allow it on the public
interface, and testing it externally fails due to the default DROP rule.


-- 
Erik Weber

Re: [ACS4.5] SQL Error

[sebgoa]

On Jun 24, 2014, at 10:25 AM, Daan Hoogland  wrote:

> I reverted my and Ian's commits. I will have a look on how to rebase
> them in ovmsupport on latest master.

Right, Funs should submit reviews for the ovmsupport branch to get it in sync 
with master.
The branch was created off an old commit dated back January 2014 (because 
that's when he started).

Once the branch is tested, rebased etc…we should call a [MERGE]...

> 
> On Tue, Jun 24, 2014 at 10:19 AM, Daan Hoogland  
> wrote:
>> I will revert, this is definatelly my bad.
>> 
>> On Tue, Jun 24, 2014 at 9:00 AM, sebgoa  wrote:
>>> Looping Daan in,
>>> 
>>> I created an ovmsupport branch to drop some early WIP about ovm3 support. 
>>> This is not yet ready for merge to master.
>>> No ovm3 stuff should be committed to master.
>>> 
>>> @Daan, can you revert the commits you made yesterday ?
>>> 
>>> -Sebastien
>>> 
>>> 
>>> On Jun 24, 2014, at 12:14 AM, Mike Tutkowski  
>>> wrote:
>>> 
 Looks like we have another SQL issue on master (this time clicking on the
 Storage button in the GUI):
 
 DB Exception on: com.mysql.jdbc.JDBC4PreparedStatement@7e1b4c2b: SELECT
 volume_view.id, volume_view.uuid, volume_view.name, volume_view.device_id,
 volume_view.volume_type, volume_view.provisioning_type, volume_view.size,
 volume_view.min_iops, volume_view.max_iops, volume_view.state,
 volume_view.created, volume_view.attached, volume_view.removed,
 volume_view.account_id, volume_view.account_uuid, volume_view.account_name,
 volume_view.account_type, volume_view.domain_id, volume_view.domain_uuid,
 volume_view.domain_name, volume_view.domain_path, volume_view.project_id,
 volume_view.project_uuid, volume_view.project_name, volume_view.pod_id,
 volume_view.data_center_id, volume_view.data_center_uuid,
 volume_view.data_center_name, volume_view.vm_id, volume_view.vm_uuid,
 volume_view.vm_name, volume_view.vm_display_name, volume_view.vm_state,
 volume_view.vm_type, volume_view.volume_store_size,
 volume_view.created_on_store, volume_view.format, volume_view.download_pct,
 volume_view.download_state, volume_view.error_str,
 volume_view.hypervisor_type, volume_view.disk_offering_id,
 volume_view.disk_offering_uuid, volume_view.disk_offering_name,
 volume_view.disk_offering_display_text, volume_view.system_use,
 volume_view.use_local_storage, volume_view.bytes_read_rate,
 volume_view.bytes_write_rate, volume_view.iops_read_rate,
 volume_view.iops_write_rate, volume_view.pool_id, volume_view.pool_uuid,
 volume_view.pool_name, volume_view.template_id, volume_view.template_uuid,
 volume_view.template_name, volume_view.template_display_text,
 volume_view.extractable, volume_view.template_type, volume_view.iso_id,
 volume_view.iso_uuid, volume_view.iso_name, volume_view.iso_display_text,
 volume_view.job_id, volume_view.job_uuid, volume_view.job_status,
 volume_view.tag_id, volume_view.tag_uuid, volume_view.tag_key,
 volume_view.tag_value, volume_view.tag_domain_id,
 volume_view.tag_account_id, volume_view.tag_resource_id,
 volume_view.tag_resource_uuid, volume_view.tag_resource_type,
 volume_view.tag_customer, volume_view.display_volume, volume_view.path,
 volume_view.chain_info FROM volume_view WHERE volume_view.id=3
 
 
 On Mon, Jun 23, 2014 at 1:47 PM, Mike Tutkowski <
 mike.tutkow...@solidfire.com> wrote:
 
> I see they had an extra couple "$" chars in the code. Thanks for removing
> them, Ian.
> 
> 
> On Mon, Jun 23, 2014 at 1:43 PM, Mike Tutkowski <
> mike.tutkow...@solidfire.com> wrote:
> 
>> Thanks, Ian
>> 
>> 
>> On Mon, Jun 23, 2014 at 1:41 PM, Ian Duffy  wrote:
>> 
>>> Just pushed a fix for it.
>>> 
 The OVM stuff was put in the ovmsupport branch, nothing should be on
>>> master
>>> 
>>> There is stuff in master
>>> 
>>> 
>>> https://github.com/apache/cloudstack/commit/8a485b9b59e4108e862022baf7477f768380b325
>>> 
>>> On 23 June 2014 20:38, Sebastien Goasguen  wrote:
>>> 
 
 On Jun 23, 2014, at 3:34 PM, Ian Duffy  wrote:
 
> Hey Mike,
> 
> This appears to be correct.
> 
> There newly added lines in create-schema-sql ending in ;$
> 
> They appear to be introduced with the OVM stuff.
 
 The OVM stuff was put in the ovmsupport branch, nothing should be on
>>> master
 
 
 
> 
> 
> On 23 June 2014 20:17, Mike Tutkowski 
 wrote:
> 
>> Do we seriously have an error in our SQL code? :) I ran mvn -P
>>> developer
>> -pl developer -D deploydb and received the following:
>> 
>> > Processing SQL file at
>> /home/cloudstack/cloudstack/developer/target/db/create-schema.sql
>> Unable to execute
>

Re: S3 use with simulator

[sebgoa]

On Jun 23, 2014, at 3:45 PM, sebgoa  wrote:

> 
> On Jun 23, 2014, at 3:33 PM, Prasanna Santhanam  wrote:
> 
>> Be advised that advanced.cfg might be adding the NFS store as
>> secondary storage as opposed to cacheStorage that the S3 image store
>> needs it to be. At least that's how it was the last time I ran it.
> 
> Thanks. 
> 
> That's exactly what I am trying to figure out. Can we migrate from a NFS 
> secondary storage to an object store.
> 
> If I move the NFS to be a cache store then I can add a new ImageStore. But 
> the updatecloudstoobjectstore which is supposed to do everything at once, 
> does not work for me.
> 


Ok, problem solved. When using the API, the provider key is case sensitive. so 
you need to pass S3 and not s3 :(



>> 
>> On Mon, Jun 23, 2014 at 02:45:55PM +0200, sebgoa wrote:
>>> 
>>> On Jun 23, 2014, at 2:30 PM, Koushik Das  wrote:
>>> 
 This has nothing to do with the zoneId. If you search the source code for 
 the error message "Failed to add data store: DataCenter id is null, and 
 simulator image store has to be associated with a data center", it points 
 toSimulatorImageStoreLifeCycleImpl.initialize() method. This indicates 
 that somehow the image store provider for Simulator is getting picked up. 
 For S3 provider type, the S3ImageStoreLifeCycleImpl should get invoked and 
 in that the zoneId is not used so there won't be issues.
>>> 
>>> Happy to discuss it on IRC, if you could join.
>>> 
>>> in SimulatorImageStoreLifeCycleImpl.initialize() on 4.4-forward I see:
>>> 
>>> Long dcId = (Long)dsInfos.get("zoneId");
>>>   String url = (String)dsInfos.get("url");
>>>   String name = (String)dsInfos.get("name");
>>>   if (name == null) {
>>>   name = url;
>>>   }
>>>...
>>> 
>>>   if (dcId == null) {
>>>   throw new InvalidParameterValueException("DataCenter id is null, 
>>> and simulator image store has to be associated with a data center");
>>>   }
>>> 
>>> So my non Java expertise tells me that dcId is null because zoneId is not 
>>> set ???
>>> 
>>> 
 
 
 -Original Message-
 From: Sebastien Goasguen [mailto:run...@gmail.com] 
 Sent: Monday, 23 June 2014 5:47 PM
 To: dev@cloudstack.apache.org
 Subject: Re: S3 use with simulator
 
 
 On Jun 23, 2014, at 7:14 AM, Koushik Das  wrote:
 
> This is the request
> 
> http://localhost:8096/api?command=updateCloudToUseObjectStore&url=http
> ://localhost:1234/test&name=test&provider=S3&details[0].key=accesskey&
> details[0].value=dummy&details[1].key=secretkey&details[1].value=dummy
 
 Any chance you can try with a signed api request ?
 
 It looks like it's not finding a zoneId ...hence dcId is null
 
> 
> 
> -Original Message-
> From: sebgoa [mailto:run...@gmail.com]
> Sent: Monday, 23 June 2014 4:40 PM
> To: dev@cloudstack.apache.org
> Subject: Re: S3 use with simulator
> 
> 
> On Jun 23, 2014, at 12:51 PM, Koushik Das  wrote:
> 
>> inline
>> 
>> On 23-Jun-2014, at 4:05 PM, Sebastien Goasguen  wrote:
>> 
>>> Hi Koushik, thanks for the hint, I checked out 4.4-forward and made 
>>> that small change.
>>> 
>>> I still add the same error:
>>> 
 update cloudtouseobjectstore url=http://localhost:9081/riak-cs 
 name=riakcs provider=s3 details[0].key=accesskey 
 details[0].value=ZMJD6-90S2MST4NZMK1Z details[1].key=secretkey 
 details[1].value=ecJlaZebrYKj_qYaIfzlRR_1izojGVWjBRFx0Q==
>>> 530: Failed to add data store: DataCenter id is null, and simulator 
>>> image store has to be associated with a data center
>>> 
>>> However this actually *removed* the NFS store (from the simulated basic 
>>> zone).
>>> 
>> 
>> I verified using advanced zone, not sure if there are any issues with 
>> basic zone. The API response I get is the following:
>> > cloud-stack-version="4.4.0-SNAPSHOT">55b7e6f7-ec27-4d
>> a 
>> 8-b4a0-b209a3e3d825testhttp://localhost:1234/t
>> e 
>> sthttpS3> e
>>> REGIONsecretkeydummy>> e
>> tails>accesskeydummy> tails>i
>> magestore>
>> 
> 
> Hum, strange. I just checked with an advanced zone from 
> setup/dev/advanced.cfg and I get the same error 'datacenter id is null'.
> 
> Can you send the exact request that you sent ?
> 
>> Also in the image_store table the entries look like below, note that the 
>> 'role' of NFS store changed to 'ImageCache'.
>> 
>> '1', 'nfs://10.147.28.6:/export/home/sandbox/secondary', 'NFS', 
>> 'nfs', 'nfs://10.147.28.6:/export/home/sandbox/secondary', '1', 
>> 'ZONE', 'ImageCache', '8eb3e701-7e2b-4925-87f8-f8ea5f97b863',
>> '/mnt/05b33ef7-da6a-33eb-9981-b4efb90ed99b/', '2014-06-23 06:27:58', 
>> NULL, NULL, NULL '2', 'test', 'S3', 'http', 
>> 'http://localhost:1234/test',

Re: create_schema.sql

[Prasanna Santhanam]

On Tue, Jun 24, 2014 at 10:27:56AM +0200, Hugo Trippaers wrote:
> Dear committers,
> 
> 
> When either committing or reviewing, please pay attention to the
> fact the create_schema.sql should NOT be modified under any
> circumstances. Since release 4.1 this file is considered frozen and
> updates to the schema will be in the upgrade scripts for the
> versions.
> 
> At the moment a number of commits have been accepted that modify the
> schema which we now have to clean up or revert.
> 
> Please pay attention to this.

How about removing the file from all release-branches as they are cut?
That way any changes that went into create-schema.sql is never brought
in to release branches. Whoever starts with CloudStack is expected to
seed the schema while on master at least once?

> 
> 
> Cheers,
> 
> Hugo

-- 
Prasanna.,


Powered by BigRock.com

Re: create_schema.sql

[Daan Hoogland]

It should be included in any release

On Tue, Jun 24, 2014 at 10:44 AM, Prasanna Santhanam  wrote:
> On Tue, Jun 24, 2014 at 10:27:56AM +0200, Hugo Trippaers wrote:
>> Dear committers,
>>
>>
>> When either committing or reviewing, please pay attention to the
>> fact the create_schema.sql should NOT be modified under any
>> circumstances. Since release 4.1 this file is considered frozen and
>> updates to the schema will be in the upgrade scripts for the
>> versions.
>>
>> At the moment a number of commits have been accepted that modify the
>> schema which we now have to clean up or revert.
>>
>> Please pay attention to this.
>
> How about removing the file from all release-branches as they are cut?
> That way any changes that went into create-schema.sql is never brought
> in to release branches. Whoever starts with CloudStack is expected to
> seed the schema while on master at least once?
>
>>
>>
>> Cheers,
>>
>> Hugo
>
> --
> Prasanna.,
>
> 
> Powered by BigRock.com
>



-- 
Daan

ovmsupport branch

[Daan Hoogland]

Ian, Funs,

I have been to eager to help out on this. Whatever you do should
remain on the ovmsupport branch. Please use a fork on github to do
your changes on. Any rebase of the code on master should go there.

to get it back to the wip-repo you could create pull requests.

-- 
Daan

Re: create_schema.sql

[Prasanna Santhanam]

On Tue, Jun 24, 2014 at 10:51:31AM +0200, Daan Hoogland wrote:
> It should be included in any release
> 
so packaging can bring it back i thought. just a thought.
-- 
Prasanna.,


Powered by BigRock.com

Re: create_schema.sql

[Daan Hoogland]

including the source release? I don't like:( I do agree that some kind
of guard would help, though

On Tue, Jun 24, 2014 at 10:57 AM, Prasanna Santhanam  wrote:
> On Tue, Jun 24, 2014 at 10:51:31AM +0200, Daan Hoogland wrote:
>> It should be included in any release
>>
> so packaging can bring it back i thought. just a thought.
> --
> Prasanna.,
>
> 
> Powered by BigRock.com
>



-- 
Daan

Re: CS 4.3 - Registering network-element plugin

[Pradeep Cloudstack]

Hi Punith,
the war contains the jar file. Also, the names are correct.

In out network-element pom.xml file, we had made entries to ensure that a 
property file
is bundled with the jar

***  
  
 
   
 src
 false
 
 JuniperNetworkGuru.properties
 
   
 
   
***

This seems to be causing the issue. If I remove this entry, I see that the 
spring.xml and module.properties
are bundled in the jar, but our JuniperNetworkGuru.properties will not get 
bundled

-Pradeep




 From: Punith S 
To: cloudstack ; Pradeep Cloudstack 
 
Sent: Tuesday, June 24, 2014 12:55 PM
Subject: Re: CS 4.3 - Registering network-element plugin
 

hi pradeep,

can you make sure your jar is present in the cloud war.
to make this happen you have to register the dependency in the client
pom.xml file.

also you need to register your plugin in the plugin pom.xml file and make
sure the provider name matches.

thanks.



On Tue, Jun 24, 2014 at 12:38 PM, Pradeep Cloudstack <
pradeepcloudst...@yahoo.com.invalid> wrote:

> Thanks Punith.
> We had tried this.
> However the jar file that is built didnot include the spring-*-context.xml
> and module.properties
> as a result of which our plugin didnot get registered.
>
> We followed the approach that was taken for vxlan and created artifacts on
> similar lines.
>
> Can you pls help on what we are missing ?
>
>
> -Pradeep
>
>
>
> 
>  From: Punith S 
> To: cloudstack ; Pradeep Cloudstack <
> pradeepcloudst...@yahoo.com>
> Sent: Tuesday, June 24, 2014 12:11 PM
> Subject: Re: CS 4.3 - Registering network-element plugin
>
>
> hi pradeep,
>
> the spring framework has been modularized in 4.3 onwards,
> this link might help you in registering the new plugin.
>
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Plug-ins%2C+Modules%2C+and+Extensions
>
> thanks,
>
>
>
>
>
> On Tue, Jun 24, 2014 at 11:57 AM, Pradeep Cloudstack <
> pradeepcloudst...@yahoo.com.invalid> wrote:
>
> > Hi team,
> > I need some help in registering network-element plugin in a 4.3
> > installation.
> >
> > In 4.2 release, we used to make entries in componentContext.xml.
> >
> > However in 4.3, looks like there is a NetworkGuru Registry.
> > How do we register our plugin here?
> >
> > -Pradeep
> >
>
>
>
> --
> regards,

>
> punith s
> cloudbyte.com
>



-- 
regards,

punith s
cloudbyte.com

Re: create_schema.sql

[Rajani Karuturi]

how about calculating the md5 checksum of the file and a build failure incase 
the checksum changes?

liquibase(http://www.liquibase.org/) manages its changesets using md5 hash.


~Rajani



On 24-Jun-2014, at 2:48 pm, Daan Hoogland 
mailto:daan.hoogl...@gmail.com>> wrote:

including the source release? I don't like:( I do agree that some kind
of guard would help, though

On Tue, Jun 24, 2014 at 10:57 AM, Prasanna Santhanam 
mailto:t...@apache.org>> wrote:
On Tue, Jun 24, 2014 at 10:51:31AM +0200, Daan Hoogland wrote:
It should be included in any release

so packaging can bring it back i thought. just a thought.
--
Prasanna.,


Powered by BigRock.com




--
Daan

Re: [ACS4.5] SQL Error

[Rajani Karuturi]

I also faced this issue on master today. Logged a defect in jira 
https://issues.apache.org/jira/browse/CLOUDSTACK-6986


~Rajani



On 24-Jun-2014, at 3:44 am, Mike Tutkowski 
mailto:mike.tutkow...@solidfire.com>> wrote:

Looks like we have another SQL issue on master (this time clicking on the
Storage button in the GUI):

DB Exception on: com.mysql.jdbc.JDBC4PreparedStatement@7e1b4c2b: SELECT
volume_view.id, volume_view.uuid, volume_view.name, volume_view.device_id,
volume_view.volume_type, volume_view.provisioning_type, volume_view.size,
volume_view.min_iops, volume_view.max_iops, volume_view.state,
volume_view.created, volume_view.attached, volume_view.removed,
volume_view.account_id, volume_view.account_uuid, volume_view.account_name,
volume_view.account_type, volume_view.domain_id, volume_view.domain_uuid,
volume_view.domain_name, volume_view.domain_path, volume_view.project_id,
volume_view.project_uuid, volume_view.project_name, volume_view.pod_id,
volume_view.data_center_id, volume_view.data_center_uuid,
volume_view.data_center_name, volume_view.vm_id, volume_view.vm_uuid,
volume_view.vm_name, volume_view.vm_display_name, volume_view.vm_state,
volume_view.vm_type, volume_view.volume_store_size,
volume_view.created_on_store, volume_view.format, volume_view.download_pct,
volume_view.download_state, volume_view.error_str,
volume_view.hypervisor_type, volume_view.disk_offering_id,
volume_view.disk_offering_uuid, volume_view.disk_offering_name,
volume_view.disk_offering_display_text, volume_view.system_use,
volume_view.use_local_storage, volume_view.bytes_read_rate,
volume_view.bytes_write_rate, volume_view.iops_read_rate,
volume_view.iops_write_rate, volume_view.pool_id, volume_view.pool_uuid,
volume_view.pool_name, volume_view.template_id, volume_view.template_uuid,
volume_view.template_name, volume_view.template_display_text,
volume_view.extractable, volume_view.template_type, volume_view.iso_id,
volume_view.iso_uuid, volume_view.iso_name, volume_view.iso_display_text,
volume_view.job_id, volume_view.job_uuid, volume_view.job_status,
volume_view.tag_id, volume_view.tag_uuid, volume_view.tag_key,
volume_view.tag_value, volume_view.tag_domain_id,
volume_view.tag_account_id, volume_view.tag_resource_id,
volume_view.tag_resource_uuid, volume_view.tag_resource_type,
volume_view.tag_customer, volume_view.display_volume, volume_view.path,
volume_view.chain_info FROM volume_view WHERE volume_view.id=3


On Mon, Jun 23, 2014 at 1:47 PM, Mike Tutkowski <
mike.tutkow...@solidfire.com> wrote:

I see they had an extra couple "$" chars in the code. Thanks for removing
them, Ian.


On Mon, Jun 23, 2014 at 1:43 PM, Mike Tutkowski <
mike.tutkow...@solidfire.com> wrote:

Thanks, Ian


On Mon, Jun 23, 2014 at 1:41 PM, Ian Duffy 
mailto:i...@ianduffy.ie>> wrote:

Just pushed a fix for it.

The OVM stuff was put in the ovmsupport branch, nothing should be on
master

There is stuff in master


https://github.com/apache/cloudstack/commit/8a485b9b59e4108e862022baf7477f768380b325

On 23 June 2014 20:38, Sebastien Goasguen  wrote:


On Jun 23, 2014, at 3:34 PM, Ian Duffy  wrote:

Hey Mike,

This appears to be correct.

There newly added lines in create-schema-sql ending in ;$

They appear to be introduced with the OVM stuff.

The OVM stuff was put in the ovmsupport branch, nothing should be on
master





On 23 June 2014 20:17, Mike Tutkowski 
wrote:

Do we seriously have an error in our SQL code? :) I ran mvn -P
developer
-pl developer -D deploydb and received the following:

> Processing SQL file at
/home/cloudstack/cloudstack/developer/target/db/create-schema.sql
Unable to execute
/home/cloudstack/cloudstack/developer/target/db/create-schema.sql:
You
have
an error in your SQL syntax; check the manual that corresponds to
your
MySQL server version for the right syntax to use near '$ INSERT
IGNORE
INTO
`cloud`.`hypervisor_capabilities`(hypervisor_type, hypervis' at
line 1

--
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
*™*







--
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
*™*




--
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
*™*




--
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
*™*

Re: [ACS4.5] SQL Error

[Rajani Karuturi]

oops... looks like its already fixed. will close once i take the latest and 
test.

~Rajani



On 24-Jun-2014, at 3:05 pm, Rajani Karuturi 
mailto:rajani.karut...@citrix.com>> wrote:

I also faced this issue on master today. Logged a defect in jira 
https://issues.apache.org/jira/browse/CLOUDSTACK-6986


~Rajani



On 24-Jun-2014, at 3:44 am, Mike Tutkowski 
mailto:mike.tutkow...@solidfire.com>> wrote:

Looks like we have another SQL issue on master (this time clicking on the
Storage button in the GUI):

DB Exception on: com.mysql.jdbc.JDBC4PreparedStatement@7e1b4c2b: SELECT
volume_view.id, volume_view.uuid, volume_view.name, volume_view.device_id,
volume_view.volume_type, volume_view.provisioning_type, volume_view.size,
volume_view.min_iops, volume_view.max_iops, volume_view.state,
volume_view.created, volume_view.attached, volume_view.removed,
volume_view.account_id, volume_view.account_uuid, volume_view.account_name,
volume_view.account_type, volume_view.domain_id, volume_view.domain_uuid,
volume_view.domain_name, volume_view.domain_path, volume_view.project_id,
volume_view.project_uuid, volume_view.project_name, volume_view.pod_id,
volume_view.data_center_id, volume_view.data_center_uuid,
volume_view.data_center_name, volume_view.vm_id, volume_view.vm_uuid,
volume_view.vm_name, volume_view.vm_display_name, volume_view.vm_state,
volume_view.vm_type, volume_view.volume_store_size,
volume_view.created_on_store, volume_view.format, volume_view.download_pct,
volume_view.download_state, volume_view.error_str,
volume_view.hypervisor_type, volume_view.disk_offering_id,
volume_view.disk_offering_uuid, volume_view.disk_offering_name,
volume_view.disk_offering_display_text, volume_view.system_use,
volume_view.use_local_storage, volume_view.bytes_read_rate,
volume_view.bytes_write_rate, volume_view.iops_read_rate,
volume_view.iops_write_rate, volume_view.pool_id, volume_view.pool_uuid,
volume_view.pool_name, volume_view.template_id, volume_view.template_uuid,
volume_view.template_name, volume_view.template_display_text,
volume_view.extractable, volume_view.template_type, volume_view.iso_id,
volume_view.iso_uuid, volume_view.iso_name, volume_view.iso_display_text,
volume_view.job_id, volume_view.job_uuid, volume_view.job_status,
volume_view.tag_id, volume_view.tag_uuid, volume_view.tag_key,
volume_view.tag_value, volume_view.tag_domain_id,
volume_view.tag_account_id, volume_view.tag_resource_id,
volume_view.tag_resource_uuid, volume_view.tag_resource_type,
volume_view.tag_customer, volume_view.display_volume, volume_view.path,
volume_view.chain_info FROM volume_view WHERE volume_view.id=3


On Mon, Jun 23, 2014 at 1:47 PM, Mike Tutkowski <
mike.tutkow...@solidfire.com> wrote:

I see they had an extra couple "$" chars in the code. Thanks for removing
them, Ian.


On Mon, Jun 23, 2014 at 1:43 PM, Mike Tutkowski <
mike.tutkow...@solidfire.com> wrote:

Thanks, Ian


On Mon, Jun 23, 2014 at 1:41 PM, Ian Duffy 
mailto:i...@ianduffy.ie>> wrote:

Just pushed a fix for it.

The OVM stuff was put in the ovmsupport branch, nothing should be on
master

There is stuff in master


https://github.com/apache/cloudstack/commit/8a485b9b59e4108e862022baf7477f768380b325

On 23 June 2014 20:38, Sebastien Goasguen 
mailto:run...@gmail.com>> wrote:


On Jun 23, 2014, at 3:34 PM, Ian Duffy 
mailto:i...@ianduffy.ie>> wrote:

Hey Mike,

This appears to be correct.

There newly added lines in create-schema-sql ending in ;$

They appear to be introduced with the OVM stuff.

The OVM stuff was put in the ovmsupport branch, nothing should be on
master





On 23 June 2014 20:17, Mike Tutkowski 
mailto:mike.tutkow...@solidfire.com>>
wrote:

Do we seriously have an error in our SQL code? :) I ran mvn -P
developer
-pl developer -D deploydb and received the following:

> Processing SQL file at
/home/cloudstack/cloudstack/developer/target/db/create-schema.sql
Unable to execute
/home/cloudstack/cloudstack/developer/target/db/create-schema.sql:
You
have
an error in your SQL syntax; check the manual that corresponds to
your
MySQL server version for the right syntax to use near '$ INSERT
IGNORE
INTO
`cloud`.`hypervisor_capabilities`(hypervisor_type, hypervis' at
line 1

--
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
*™*







--
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
*™*




--
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud

Re: create_schema.sql

[Ian Duffy]

Apologizes for my commit to it yesterday.

Was removing erroneous lines brought in by the other commit.


On 24 June 2014 10:27, Rajani Karuturi  wrote:

> how about calculating the md5 checksum of the file and a build failure
> incase the checksum changes?
>
> liquibase(http://www.liquibase.org/) manages its changesets using md5
> hash.
>
>
> ~Rajani
>
>
>
> On 24-Jun-2014, at 2:48 pm, Daan Hoogland  daan.hoogl...@gmail.com>> wrote:
>
> including the source release? I don't like:( I do agree that some kind
> of guard would help, though
>
> On Tue, Jun 24, 2014 at 10:57 AM, Prasanna Santhanam  > wrote:
> On Tue, Jun 24, 2014 at 10:51:31AM +0200, Daan Hoogland wrote:
> It should be included in any release
>
> so packaging can bring it back i thought. just a thought.
> --
> Prasanna.,
>
> 
> Powered by BigRock.com
>
>
>
>
> --
> Daan
>
>

big revert

[Daan Hoogland]

H,

I just reverted six commits. I did most of those commits myself. There
was a misunderstanding on my part on the validity of the commits and
the place these should go. If you have any questions about it, feel
free to ask.

the short version: they should have gone in the feature branch 'ovmsupport'.

regards,
-- 
Daan

Review Request 22928: Fixed resource leaks and added support for secstoragefirewallcfg command to simulator in master

[Santhosh Edukulla]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22928/
---

Review request for cloudstack, Abhinandan Prateek and daan Hoogland.


Repository: cloudstack-git


Description
---

1. Fixed few Resource Leaks reported by coverity in master
2. As well added support for a config command to simulator in master


Diffs
-

  engine/schema/src/com/cloud/upgrade/dao/DatabaseAccessObject.java 836a537 
  framework/db/src/com/cloud/utils/crypt/EncryptionSecretKeyChanger.java 
4cee081 
  framework/db/src/com/cloud/utils/db/ScriptRunner.java 932b37b 
  
plugins/hypervisors/simulator/src/com/cloud/agent/manager/SimulatorManagerImpl.java
 321f06f 

Diff: https://reviews.apache.org/r/22928/diff/


Testing
---

Built the simulator code and deployed a datacenter


Thanks,

Santhosh Edukulla

Review Request 22927: Bugfix CLOUDSTACK-6261: remove the forceful timeout setting when login to NetScaler.

[Sujaya Maiyya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22927/
---

Review request for cloudstack, Murali Reddy and Rajesh Battala.


Bugs: 6261
https://issues.apache.org/jira/browse/6261


Repository: cloudstack-git


Description
---

The NetScaler Resource forces a idle timeout of 100,000 seconds during login. 
It is best to leave it to the system default which is 30 mins. The timeout has 
been removed from NetscalerResource in order to support login for Netscaler 
10.5 devices.


Diffs
-

  
plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java
 54e5d50 

Diff: https://reviews.apache.org/r/22927/diff/


Testing
---

Timeout was removed and login to the Netscaler devices with the default timeout 
of 30 minutes was successful. It was tested for Netscaler builds 10.1 and 10.5.


Thanks,

Sujaya Maiyya

Re: CS 4.3 - Registering network-element plugin

[Punith S]

hi pradeep,

does the JuniperNetworkGuru.properties file contain your custom key value
pairs to be used in the plugin ?

thanks.


On Tue, Jun 24, 2014 at 2:56 PM, Pradeep Cloudstack <
pradeepcloudst...@yahoo.com.invalid> wrote:

> Hi Punith,
> the war contains the jar file. Also, the names are correct.
>
> In out network-element pom.xml file, we had made entries to ensure that a
> property file
> is bundled with the jar
>
> ***
>   
>  
>
>  src
>  false
>  
>  JuniperNetworkGuru.properties
>  
>
>  
>
> ***
>
> This seems to be causing the issue. If I remove this entry, I see that the
> spring.xml and module.properties
> are bundled in the jar, but our JuniperNetworkGuru.properties will not get
> bundled
>
> -Pradeep
>
>
>
> 
>  From: Punith S 
> To: cloudstack ; Pradeep Cloudstack <
> pradeepcloudst...@yahoo.com>
> Sent: Tuesday, June 24, 2014 12:55 PM
> Subject: Re: CS 4.3 - Registering network-element plugin
>
>
> hi pradeep,
>
> can you make sure your jar is present in the cloud war.
> to make this happen you have to register the dependency in the client
> pom.xml file.
>
> also you need to register your plugin in the plugin pom.xml file and make
> sure the provider name matches.
>
> thanks.
>
>
>
> On Tue, Jun 24, 2014 at 12:38 PM, Pradeep Cloudstack <
> pradeepcloudst...@yahoo.com.invalid> wrote:
>
> > Thanks Punith.
> > We had tried this.
> > However the jar file that is built didnot include the
> spring-*-context.xml
> > and module.properties
> > as a result of which our plugin didnot get registered.
> >
> > We followed the approach that was taken for vxlan and created artifacts
> on
> > similar lines.
> >
> > Can you pls help on what we are missing ?
> >
> >
> > -Pradeep
> >
> >
> >
> > 
> >  From: Punith S 
> > To: cloudstack ; Pradeep Cloudstack <
> > pradeepcloudst...@yahoo.com>
> > Sent: Tuesday, June 24, 2014 12:11 PM
> > Subject: Re: CS 4.3 - Registering network-element plugin
> >
> >
> > hi pradeep,
> >
> > the spring framework has been modularized in 4.3 onwards,
> > this link might help you in registering the new plugin.
> >
> >
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Plug-ins%2C+Modules%2C+and+Extensions
> >
> > thanks,
> >
> >
> >
> >
> >
> > On Tue, Jun 24, 2014 at 11:57 AM, Pradeep Cloudstack <
> > pradeepcloudst...@yahoo.com.invalid> wrote:
> >
> > > Hi team,
> > > I need some help in registering network-element plugin in a 4.3
> > > installation.
> > >
> > > In 4.2 release, we used to make entries in componentContext.xml.
> > >
> > > However in 4.3, looks like there is a NetworkGuru Registry.
> > > How do we register our plugin here?
> > >
> > > -Pradeep
> > >
> >
> >
> >
> > --
> > regards,
>
> >
> > punith s
> > cloudbyte.com
> >
>
>
>
> --
> regards,
>
> punith s
> cloudbyte.com
>



-- 
regards,

punith s
cloudbyte.com

Re: Review Request 22927: Bugfix CLOUDSTACK-6261: remove the forceful timeout setting when login to NetScaler.

[Sujaya Maiyya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22927/
---

(Updated June 24, 2014, 10:23 a.m.)


Review request for cloudstack, Murali Reddy and Rajesh Battala.


Bugs: CLOUDSTACK-6261
https://issues.apache.org/jira/browse/CLOUDSTACK-6261


Repository: cloudstack-git


Description
---

The NetScaler Resource forces a idle timeout of 100,000 seconds during login. 
It is best to leave it to the system default which is 30 mins. The timeout has 
been removed from NetscalerResource in order to support login for Netscaler 
10.5 devices.


Diffs
-

  
plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java
 54e5d50 

Diff: https://reviews.apache.org/r/22927/diff/


Testing
---

Timeout was removed and login to the Netscaler devices with the default timeout 
of 30 minutes was successful. It was tested for Netscaler builds 10.1 and 10.5.


Thanks,

Sujaya Maiyya

Re: Management Server HA & DB Replication

[Abhinandan Prateek]

MS will work in a cluster pointing to same DB. The DB can be configured as
master-slave.

https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=34838207

-abhi

On 24/06/14 9:53 am, "Tejas Gadaria"  wrote:

>Hi,
>
>I want to make MS on high availability, with automatic failover.
>I have MS & DB on same server. & planning to create slave DB on separate
>server.
>
>but if I create separate Slave MS for HA, how can point it to DB so
>command
>issued from any of MS will trigger to same infrastructure.
>
>Regards,
>Tejas

Re: CS 4.3 - Registering network-element plugin

[Pradeep Cloudstack]

Hi Punith,
yes; the properties file contains custom key value pairs

We have decided move this file out of our jar. So, no issues now

-Pradeep




 From: Punith S 
To: cloudstack ; Pradeep Cloudstack 
 
Sent: Tuesday, June 24, 2014 3:52 PM
Subject: Re: CS 4.3 - Registering network-element plugin
 

hi pradeep,

does the JuniperNetworkGuru.properties file contain your custom key value
pairs to be used in the plugin ?

thanks.


On Tue, Jun 24, 2014 at 2:56 PM, Pradeep Cloudstack <
pradeepcloudst...@yahoo.com.invalid> wrote:

> Hi Punith,
> the war contains the jar file. Also, the names are correct.
>
> In out network-element pom.xml file, we had made entries to ensure that a
> property file
> is bundled with the jar
>
> ***
>   
>      
>        
>          src
>          false
>          
>                  JuniperNetworkGuru.properties
>              
>        
>      
>    
> ***
>
> This seems to be causing the issue. If I remove this entry, I see that the
> spring.xml and module.properties
> are bundled in the jar, but our JuniperNetworkGuru.properties will not get
> bundled
>
> -Pradeep
>
>
>
> 
>  From: Punith S 
> To: cloudstack ; Pradeep Cloudstack <
> pradeepcloudst...@yahoo.com>
> Sent: Tuesday, June 24, 2014 12:55 PM
> Subject: Re: CS 4.3 - Registering network-element plugin
>
>
> hi pradeep,
>
> can you make sure your jar is present in the cloud war.
> to make this happen you have to register the dependency in the client
> pom.xml file.
>
> also you need to register your plugin in the plugin pom.xml file and make
> sure the provider name matches.
>
> thanks.
>
>
>
> On Tue, Jun 24, 2014 at 12:38 PM, Pradeep Cloudstack <
> pradeepcloudst...@yahoo.com.invalid> wrote:
>
> > Thanks Punith.
> > We had tried this.
> > However the jar file that is built didnot include the
> spring-*-context.xml
> > and module.properties
> > as a result of which our plugin didnot get registered.
> >
> > We followed the approach that was taken for vxlan and created artifacts
> on
> > similar lines.
> >
> > Can you pls help on what we are missing ?
> >
> >
> > -Pradeep
> >
> >
> >
> > 
> >  From: Punith S 
> > To: cloudstack ; Pradeep Cloudstack <
> > pradeepcloudst...@yahoo.com>
> > Sent: Tuesday, June 24, 2014 12:11 PM
> > Subject: Re: CS 4.3 - Registering network-element plugin
> >
> >
> > hi pradeep,
> >
> > the spring framework has been modularized in 4.3 onwards,
> > this link might help you in registering the new plugin.
> >
> >
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Plug-ins%2C+Modules%2C+and+Extensions
> >
> > thanks,
> >
> >
> >
> >
> >
> > On Tue, Jun 24, 2014 at 11:57 AM, Pradeep Cloudstack <
> > pradeepcloudst...@yahoo.com.invalid> wrote:
> >
> > > Hi team,
> > > I need some help in registering network-element plugin in a 4.3
> > > installation.
> > >
> > > In 4.2 release, we used to make entries in componentContext.xml.
> > >
> > > However in 4.3, looks like there is a NetworkGuru Registry.
> > > How do we register our plugin here?
> > >
> > > -Pradeep
> > >
> >
> >
> >
> > --
> > regards,



>
> >
> > punith s
> > cloudbyte.com
> >
>
>
>
> --
> regards,
>
> punith s
> cloudbyte.com
>



-- 
regards,

punith s
cloudbyte.com

Re: CS 4.3 - Registering network-element plugin

[Punith S]

hi pradeep,

you can put your custom key value pairs in your *-context.xml inside your
bean

for example








  

also i'm curious to know how to move these properties out of the jar ?, can
you please elaborate.

thanks.



On Tue, Jun 24, 2014 at 4:02 PM, Pradeep Cloudstack <
pradeepcloudst...@yahoo.com.invalid> wrote:

> Hi Punith,
> yes; the properties file contains custom key value pairs
>
> We have decided move this file out of our jar. So, no issues now
>
> -Pradeep
>
>
>
> 
>  From: Punith S 
> To: cloudstack ; Pradeep Cloudstack <
> pradeepcloudst...@yahoo.com>
> Sent: Tuesday, June 24, 2014 3:52 PM
> Subject: Re: CS 4.3 - Registering network-element plugin
>
>
> hi pradeep,
>
> does the JuniperNetworkGuru.properties file contain your custom key value
> pairs to be used in the plugin ?
>
> thanks.
>
>
> On Tue, Jun 24, 2014 at 2:56 PM, Pradeep Cloudstack <
> pradeepcloudst...@yahoo.com.invalid> wrote:
>
> > Hi Punith,
> > the war contains the jar file. Also, the names are correct.
> >
> > In out network-element pom.xml file, we had made entries to ensure that a
> > property file
> > is bundled with the jar
> >
> > ***
> >   
> >  
> >
> >  src
> >  false
> >  
> >  JuniperNetworkGuru.properties
> >  
> >
> >  
> >
> > ***
> >
> > This seems to be causing the issue. If I remove this entry, I see that
> the
> > spring.xml and module.properties
> > are bundled in the jar, but our JuniperNetworkGuru.properties will not
> get
> > bundled
> >
> > -Pradeep
> >
> >
> >
> > 
> >  From: Punith S 
> > To: cloudstack ; Pradeep Cloudstack <
> > pradeepcloudst...@yahoo.com>
> > Sent: Tuesday, June 24, 2014 12:55 PM
> > Subject: Re: CS 4.3 - Registering network-element plugin
> >
> >
> > hi pradeep,
> >
> > can you make sure your jar is present in the cloud war.
> > to make this happen you have to register the dependency in the client
> > pom.xml file.
> >
> > also you need to register your plugin in the plugin pom.xml file and make
> > sure the provider name matches.
> >
> > thanks.
> >
> >
> >
> > On Tue, Jun 24, 2014 at 12:38 PM, Pradeep Cloudstack <
> > pradeepcloudst...@yahoo.com.invalid> wrote:
> >
> > > Thanks Punith.
> > > We had tried this.
> > > However the jar file that is built didnot include the
> > spring-*-context.xml
> > > and module.properties
> > > as a result of which our plugin didnot get registered.
> > >
> > > We followed the approach that was taken for vxlan and created artifacts
> > on
> > > similar lines.
> > >
> > > Can you pls help on what we are missing ?
> > >
> > >
> > > -Pradeep
> > >
> > >
> > >
> > > 
> > >  From: Punith S 
> > > To: cloudstack ; Pradeep Cloudstack <
> > > pradeepcloudst...@yahoo.com>
> > > Sent: Tuesday, June 24, 2014 12:11 PM
> > > Subject: Re: CS 4.3 - Registering network-element plugin
> > >
> > >
> > > hi pradeep,
> > >
> > > the spring framework has been modularized in 4.3 onwards,
> > > this link might help you in registering the new plugin.
> > >
> > >
> >
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Plug-ins%2C+Modules%2C+and+Extensions
> > >
> > > thanks,
> > >
> > >
> > >
> > >
> > >
> > > On Tue, Jun 24, 2014 at 11:57 AM, Pradeep Cloudstack <
> > > pradeepcloudst...@yahoo.com.invalid> wrote:
> > >
> > > > Hi team,
> > > > I need some help in registering network-element plugin in a 4.3
> > > > installation.
> > > >
> > > > In 4.2 release, we used to make entries in componentContext.xml.
> > > >
> > > > However in 4.3, looks like there is a NetworkGuru Registry.
> > > > How do we register our plugin here?
> > > >
> > > > -Pradeep
> > > >
> > >
> > >
> > >
> > > --
> > > regards,
>
>
>
> >
> > >
> > > punith s
> > > cloudbyte.com
> > >
> >
> >
> >
> > --
> > regards,
> >
> > punith s
> > cloudbyte.com
> >
>
>
>
> --
> regards,
>
> punith s
> cloudbyte.com
>



-- 
regards,

punith s
cloudbyte.com

Re: [security] The case of the open dns resolver

[Abhinandan Prateek]

https://issues.apache.org/jira/browse/CLOUDSTACK-5494

Also need to take care of changes in subnets too.

-abhi  

On 23/06/14 4:01 pm, "Nux!"  wrote:

>Hi,
>
>Today I've been bitten again by the $subject and complaints were sent to
>my hoster's abuse email address; apparently someone used my VR in a DDOS
>attack.
>It is my fault as I knew about this issue, but I'd like to throw the
>blame on Cloudstack. :)
>
>So, the VR is accepting DNS requests from everybody on the interwebs and
>this should be changed, imho.
>
>I see there are already iptables rules concerning port 8080 of the VR and
>only the public IP ranges are allowed. Why isn't this the case for port
>53 as well?
>
>I have placed this script in my VR's rc.local, but it's not kosher at all.
>
># disallows global DNS traffic and only allows it from the cloud public
>subnets
>for i in `iptables-save |grep 8080|awk '{print $4}'`; do iptables -I
>INPUT -s $i -p tcp -m tcp --dport 53 -j ACCEPT; iptables -I INPUT -s $i
>-p udp -m udp --dport 53 -j ACCEPT; done
>iptables -D INPUT -i eth0 -p udp -m udp --dport 53 -j ACCEPT
>iptables -D INPUT -i eth0 -p tcp -m tcp --dport 53 -j ACCEPT
>
>This could be greatly improved and added in the official tree.
>Currently I'm getting the subnets by checking which IPs the 8080 rules
>apply, how can I retrieve this information in a more elegant way?
>
>Lucian
>
>--
>Sent from the Delta quadrant using Borg technology!
>
>Nux!
>www.nux.ro
>

Re: CS 4.3 - Registering network-element plugin

[Pradeep Cloudstack]

Hi Punith,
we will have this file under /etc/cloudstack/management
Customer can also edit this file


-Pradeep




 From: Punith S 
To: cloudstack ; Pradeep Cloudstack 
 
Sent: Tuesday, June 24, 2014 4:08 PM
Subject: Re: CS 4.3 - Registering network-element plugin
 

hi pradeep,

you can put your custom key value pairs in your *-context.xml inside your
bean

for example

        
        
        
        
        
        
        
  

also i'm curious to know how to move these properties out of the jar ?, can
you please elaborate.

thanks.



On Tue, Jun 24, 2014 at 4:02 PM, Pradeep Cloudstack <
pradeepcloudst...@yahoo.com.invalid> wrote:

> Hi Punith,
> yes; the properties file contains custom key value pairs
>
> We have decided move this file out of our jar. So, no issues now
>
> -Pradeep
>
>
>
> 
>  From: Punith S 
> To: cloudstack ; Pradeep Cloudstack <
> pradeepcloudst...@yahoo.com>
> Sent: Tuesday, June 24, 2014 3:52 PM
> Subject: Re: CS 4.3 - Registering network-element plugin
>
>
> hi pradeep,
>
> does the JuniperNetworkGuru.properties file contain your custom key value
> pairs to be used in the plugin ?
>
> thanks.
>
>
> On Tue, Jun 24, 2014 at 2:56 PM, Pradeep Cloudstack <
> pradeepcloudst...@yahoo.com.invalid> wrote:
>
> > Hi Punith,
> > the war contains the jar file. Also, the names are correct.
> >
> > In out network-element pom.xml file, we had made entries to ensure that a
> > property file
> > is bundled with the jar
> >
> > ***
> >   
> >      
> >        
> >          src
> >          false
> >          
> >                  JuniperNetworkGuru.properties
> >              
> >        
> >      
> >    
> > ***
> >
> > This seems to be causing the issue. If I remove this entry, I see that
> the
> > spring.xml and module.properties
> > are bundled in the jar, but our JuniperNetworkGuru.properties will not
> get
> > bundled
> >
> > -Pradeep
> >
> >
> >
> > 
> >  From: Punith S 
> > To: cloudstack ; Pradeep Cloudstack <
> > pradeepcloudst...@yahoo.com>
> > Sent: Tuesday, June 24, 2014 12:55 PM
> > Subject: Re: CS 4.3 - Registering network-element plugin
> >
> >
> > hi pradeep,
> >
> > can you make sure your jar is present in the cloud war.
> > to make this happen you have to register the dependency in the client
> > pom.xml file.
> >
> > also you need to register your plugin in the plugin pom.xml file and make
> > sure the provider name matches.
> >
> > thanks.
> >
> >
> >
> > On Tue, Jun 24, 2014 at 12:38 PM, Pradeep Cloudstack <
> > pradeepcloudst...@yahoo.com.invalid> wrote:
> >
> > > Thanks Punith.
> > > We had tried this.
> > > However the jar file that is built didnot include the
> > spring-*-context.xml
> > > and module.properties
> > > as a result of which our plugin didnot get registered.
> > >
> > > We followed the approach that was taken for vxlan and created artifacts
> > on
> > > similar lines.
> > >
> > > Can you pls help on what we are missing ?
> > >
> > >
> > > -Pradeep
> > >
> > >
> > >
> > > 
> > >  From: Punith S 
> > > To: cloudstack ; Pradeep Cloudstack <
> > > pradeepcloudst...@yahoo.com>
> > > Sent: Tuesday, June 24, 2014 12:11 PM
> > > Subject: Re: CS 4.3 - Registering network-element plugin
> > >
> > >
> > > hi pradeep,
> > >
> > > the spring framework has been modularized in 4.3 onwards,
> > > this link might help you in registering the new plugin.
> > >
> > >
> >
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Plug-ins%2C+Modules%2C+and+Extensions
> > >
> > > thanks,
> > >
> > >
> > >
> > >
> > >
> > > On Tue, Jun 24, 2014 at 11:57 AM, Pradeep Cloudstack <
> > > pradeepcloudst...@yahoo.com.invalid> wrote:
> > >
> > > > Hi team,
> > > > I need some help in registering network-element plugin in a 4.3
> > > > installation.
> > > >
> > > > In 4.2 release, we used to make entries in componentContext.xml.
> > > >
> > > > However in 4.3, looks like there is a NetworkGuru Registry.
> > > > How do we register our plugin here?
> > > >
> > > > -Pradeep
> > > >
> > >
> > >
> > >
> > > --
> > > regards,



>
>
>
> >
> > >
> > > punith s
> > > cloudbyte.com
> > >
> >
> >
> >
> > --
> > regards,
> >
> > punith s
> > cloudbyte.com
> >
>
>
>
> --
> regards,
>
> punith s
> cloudbyte.com
>



-- 
regards,

punith s
cloudbyte.com

Re: Management Server HA & DB Replication

[Tejas Gadaria]

Hi abhi,

My 1st MS & DB Master running on : 10.1.1.2
2nd MS & DB Slave running on : 10.1.1.3

MS will be in cluster so

Both MS will be pointed to : 10.1.1.2
Is it correct ?

If so,
Which parameter should I change in db.properties to point MS cluster to db
master?

Regards,
Tejas


On Tue, Jun 24, 2014 at 3:54 PM, Abhinandan Prateek <
abhinandan.prat...@citrix.com> wrote:

> MS will work in a cluster pointing to same DB. The DB can be configured as
> master-slave.
>
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=34838207
>
> -abhi
>
> On 24/06/14 9:53 am, "Tejas Gadaria"  wrote:
>
> >Hi,
> >
> >I want to make MS on high availability, with automatic failover.
> >I have MS & DB on same server. & planning to create slave DB on separate
> >server.
> >
> >but if I create separate Slave MS for HA, how can point it to DB so
> >command
> >issued from any of MS will trigger to same infrastructure.
> >
> >Regards,
> >Tejas
>
>

Why to have API Commands for Admin actions?

[Wilder Rodrigues]

Hi all,

We are currently working on the redundant VPC implementation. In order to take 
the right steps from the beginning, we started analyzing the existing code 
base, from the API commands into the VPCVirtualNetworkAppliancaManagerImpl.

Although it's not related to the feature itself, we found out that the current 
way of using the APICommand annotation and the CreateVPCCmd class (and its 
derived) is not really clear. For example, there are 2 command classes to 
create a VPC. The difference between them is: one has ResponseView.Full 
parameter in the @APICommand (ie. CreateVPCCmdByAdmin); and the other has 
ResponseView.Rstricted parameter in the @APICommand (i.e. CreateVPCCmd). 
Moreover, the call to responseGenerator.createVpcresponde() method uses a 
ResponseView enum according to what has been specified in the annotation 
parameter.

We understand that having a different enum in the 
responseGenerator.createVpcresponde() method will affect many things, because 
it goes deep into the code until reaches the APIDBUtils and the database. It is 
also checked in the ApiServer class, when the command is evaluated based on a 
string passed to the getCmdClass() method.

Since we can identify the user in the account manager, also checking the kind 
of access the user has, what is the point in having the Annotation + the Enum 
in the code? Keep in mind that the latter is passed several times as parameters 
to other methods, which adds many "ifs" and unnecessary complexity.

We could also make possible to use the Annotation in the method itself, which 
could avoid having to pass the Enum to the method. That means that the Enum 
would be removed from the annotation and we would use the annotation only to 
identify the API name, response object and entity type. In order to check the 
user's credentials, we would use the checkAccess() from the account manager, as 
it is already being used in the ApiDispatcher class.

I know those are huge changes, if we actually agree in going for anything like 
this in the future. But the Admin commands are not doing much except for change 
the enum which is passed to the create response method. Most of the content of 
the execute() method is a copy/paste from the extended Command class.

Just trying to start some chat towards the subject.

Thanks for your time.

Cheers,
Wilder

Not able to deploy Ubuntu VM on xenserver 12.04

[Tejas Gadaria]

I was trying to create Ubuntu instance from ISO on xenserver 6.2 & received
below error..

2014-06-24 17:28:38,600 DEBUG [c.c.a.ApiServlet]
(catalina-exec-17:ctx-736ea19c ctx-d2da377e) ===END===  192.168.160.192 --
GET
command=queryAsyncJobResult&jobId=06293d5e-1349-453c-a1c6-45646ff093d1&response=json&sessionkey=hRCT8eVG2WFHAM6sev8pPoXvpLs%3D&_=140368528
2014-06-24 17:28:40,416 WARN  [c.c.h.x.r.CitrixResourceBase]
(DirectAgent-236:ctx-4a340f40) Task failed! Task record:
uuid: becfe1fc-7bc9-7162-6bfc-afd9b7a9ddd0
   nameLabel: Async.VM.start_on
 nameDescription:
   allowedOperations: []
   currentOperations: {}
 created: Tue Jun 24 17:42:43 IST 2014
finished: Tue Jun 24 17:28:40 IST 2014
  status: failure
  residentOn: com.xensource.xenapi.Host@3851c289
progress: 1.0
type: 
  result:
   errorInfo: [BOOTLOADER_FAILED,
OpaqueRef:616ef71d-af09-2b86-3581-63c070f30519, INVALID_SOURCE
Unable to access a required file in the specified repository:
file:///tmp/cdrom-repo-LvMRCB/install/vmlinuz.

]
 otherConfig: {}
   subtaskOf: com.xensource.xenapi.Task@aaf13f6f
subtasks: []

2014-06-24 17:28:40,499 WARN  [c.c.h.x.r.CitrixResourceBase]
(DirectAgent-236:ctx-4a340f40) Unable to start VM(i-2-42-VM) on
host(dc1d7e1c-b09b-45a5-a10e-5479f50aa16f) due to Task failed! Task
record: uuid: becfe1fc-7bc9-7162-6bfc-afd9b7a9ddd0
   nameLabel: Async.VM.start_on
 nameDescription:
   allowedOperations: []
   currentOperations: {}
 created: Tue Jun 24 17:42:43 IST 2014
finished: Tue Jun 24 17:28:40 IST 2014
  status: failure
  residentOn: com.xensource.xenapi.Host@3851c289
progress: 1.0
type: 
  result:
   errorInfo: [BOOTLOADER_FAILED,
OpaqueRef:616ef71d-af09-2b86-3581-63c070f30519, INVALID_SOURCE
Unable to access a required file in the specified repository:
file:///tmp/cdrom-repo-LvMRCB/install/vmlinuz.

]
 otherConfig: {}
   subtaskOf: com.xensource.xenapi.Task@aaf13f6f
subtasks: []

Task failed! Task record: uuid:
becfe1fc-7bc9-7162-6bfc-afd9b7a9ddd0
   nameLabel: Async.VM.start_on
 nameDescription:
   allowedOperations: []
   currentOperations: {}
 created: Tue Jun 24 17:42:43 IST 2014
finished: Tue Jun 24 17:28:40 IST 2014
  status: failure
  residentOn: com.xensource.xenapi.Host@3851c289
progress: 1.0
type: 
  result:
   errorInfo: [BOOTLOADER_FAILED,
OpaqueRef:616ef71d-af09-2b86-3581-63c070f30519, INVALID_SOURCE
Unable to access a required file in the specified repository:
file:///tmp/cdrom-repo-LvMRCB/install/vmlinuz.

]
 otherConfig: {}
   subtaskOf: com.xensource.xenapi.Task@aaf13f6f
subtasks: []

at
com.cloud.hypervisor.xen.resource.CitrixResourceBase.checkForSuccess(CitrixResourceBase.java:3764)
at
com.cloud.hypervisor.xen.resource.CitrixResourceBase.startVM(CitrixResourceBase.java:3876)
at
com.cloud.hypervisor.xen.resource.CitrixResourceBase.execute(CitrixResourceBase.java:1721)
at
com.cloud.hypervisor.xen.resource.CitrixResourceBase.executeRequest(CitrixResourceBase.java:545)
at
com.cloud.hypervisor.xen.resource.XenServer56Resource.executeRequest(XenServer56Resource.java:59)
at
com.cloud.hypervisor.xen.resource.XenServer610Resource.executeRequest(XenServer610Resource.java:106)
at
com.cloud.agent.manager.DirectAgentAttache$Task.runInContext(DirectAgentAttache.java:216)
at
org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:49)
at
org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56)
at
org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103)
at
org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53)
at
org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:46)
at
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
at java.util.concurrent.FutureTask.run(FutureTask.java:166)
at
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$101(ScheduledThreadPoolExecutor.java:165)
at
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:266)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
at java.lang.Thread.run(Thread.java:679)
2014-06-24 17:28:40,505 WARN  [c.c.h.x.r.CitrixResourceBase]
(DirectAgent-236:ctx-4a340

RE: Management Server HA & DB Replication

[Suresh Sadhu]

IN a cluster management setup:

ON Master  MS you will install master db  with deploy option 
Cloudstack-setup-databases cloud@10.1.1.2 --deploy-as=root

On slave MS : you will point to master db
Cloudstack-setup-databases cloud@10.1.1.2 

( here don't mention --deploy-as  option on slave if you mention then it will 
overwrite  the master db content)

Once you ran the above command on slave you can see 
"db.cloud.host" point to master  IP in db.properties file


Note: always take a baclkup of your DB before doing cluster management setup 
.Due  to any mistake if master db got overwritten and you can safely  revert 
back using ur backup copy

Regards
Sadhu

-Original Message-
From: Tejas Gadaria [mailto:refond.g...@gmail.com] 
Sent: 24 June 2014 17:04
To: dev@cloudstack.apache.org
Cc: us...@cloudstack.apache.org
Subject: Re: Management Server HA & DB Replication

Hi abhi,

My 1st MS & DB Master running on : 10.1.1.2 2nd MS & DB Slave running on : 
10.1.1.3

MS will be in cluster so

Both MS will be pointed to : 10.1.1.2
Is it correct ?

If so,
Which parameter should I change in db.properties to point MS cluster to db 
master?

Regards,
Tejas


On Tue, Jun 24, 2014 at 3:54 PM, Abhinandan Prateek < 
abhinandan.prat...@citrix.com> wrote:

> MS will work in a cluster pointing to same DB. The DB can be 
> configured as master-slave.
>
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=34838
> 207
>
> -abhi
>
> On 24/06/14 9:53 am, "Tejas Gadaria"  wrote:
>
> >Hi,
> >
> >I want to make MS on high availability, with automatic failover.
> >I have MS & DB on same server. & planning to create slave DB on 
> >separate server.
> >
> >but if I create separate Slave MS for HA, how can point it to DB so 
> >command issued from any of MS will trigger to same infrastructure.
> >
> >Regards,
> >Tejas
>
>

Re: Review Request 22799: Golden (Base) Primary Storage feature

[Tim Mackey]

Hieu,

It would also be good in your design doc and testing to validate which
XenServer versions you expect this to work with, and don't forget about
xcp-xapi in pure Linux as part of that.  If you have time, I'd also be
curious if XenServer Creedence Read cache has any impact on your
results/implementation.  That was part of the alpha.2 drop.

-tim


On Mon, Jun 23, 2014 at 11:24 PM, Mike Tutkowski <
mike.tutkow...@solidfire.com> wrote:

> Hi,
>
> Yes, Marvin is great for automated regression testing of CloudStack.
>
> However, I was hoping you could note even manual testing (new and
> regression tests) you may have run to verify correctness of the system
> within reason (even if these are not automated).
>
> If you have time, automated tests would be excellent, as well.
>
> Thanks!
> Mike
>
>
> On Mon, Jun 23, 2014 at 8:50 PM, Hieu LE  wrote:
>
>> Hi Tim and Mike,
>>
>>
>> On Tue, Jun 24, 2014 at 5:59 AM, Tim Mackey  wrote:
>>
>>>This is an automatically generated e-mail. To reply, visit:
>>> https://reviews.apache.org/r/22799/
>>>
>>> On June 23rd, 2014, 9:16 p.m. UTC, *Mike Tutkowski* wrote:
>>>
>>> I was wondering if you could fill out the section about tests that have 
>>> been performed?
>>>
>>> I would be interested in both new and regression testing.
>>>
>>> Thanks!
>>>
>>> Thank you Mike, will I use marvin for regression testing ?
>>
>>
>>>   It looked like some functions added parameters, but didn't include 
>>> descriptions of those parameters.
>>>
>>> Having just gone through some refactoring, I'd like to see some of the 
>>> abbreviations made clearer.  I'm thinking of future people who might not be 
>>> as familiar with this code.
>>>
>>> Thank you, I will refactor my code to make it clearer.
>>
>>
>>>
>>>
>>> You made changes to schema-421to430, but that represents shipping versions. 
>>>  Please ensure schema changes are done in 4.5 (aka master).
>>>
>>> Sure !
>>
>>> I didn't see anything which limited this to XenServer only.  I could easily 
>>> have missed it, but if this is only XenServer, I'd prefer to see some check 
>>> to keep people from accidentally configuring something which isn't expected 
>>> to work for them.
>>>
>>> I have implemented some checks in this patch which limited to XenServer,
>> e.g: in DeploymentPlanningManagerImpl class, function planBaseDeployment,
>> line 298, or basePsHostCheck function to check that host can communicate
>> with pool.
>>
>>
>>>
>>>
>>> Thanks
>>>
>>> -tim
>>>
>>>
>>> - Tim
>>>
>>> On June 20th, 2014, 3:46 a.m. UTC, Hieu LE wrote:
>>>Review request for cloudstack, Mike Tutkowski and Tim Mackey.
>>> By Hieu LE.
>>>
>>> *Updated June 20, 2014, 3:46 a.m.*
>>>  *Repository: * cloudstack-git
>>> Description
>>>
>>> As discussed in mailing list, this patch is applied for golden primary 
>>> storage in [1].
>>> I have changed the term from "golden" to "base" because there are some 
>>> functions and variables in CloudStack also use "base" for base image.
>>> This patch only apply for Xen Server.
>>>
>>> [1]: 
>>> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Golden+Primary+Storage
>>>
>>>   Diffs
>>>
>>>- api/src/com/cloud/deploy/DeployDestination.java
>>>(4ded5ebe7a18252da471ee25019856f2b2f772e0)
>>>- api/src/com/cloud/storage/StoragePool.java
>>>(8e03c3348f3a6dd3156ab9e440126ea317957dc0)
>>>- api/src/com/cloud/template/VirtualMachineTemplate.java
>>>(599212bb039fdbb78511019e8f0a6ea4b4a84440)
>>>- api/src/org/apache/cloudstack/api/ApiConstants.java
>>>(ae5d6f05b6b52f60b151369a641cb11fcbb558af)
>>>- api/src/org/apache/cloudstack/api/BaseUpdateTemplateOrIsoCmd.java
>>>(2350f6b389203e2c6cc2182fe03fe9a95e936b81)
>>>- 
>>> api/src/org/apache/cloudstack/api/command/admin/storage/CreateStoragePoolCmd.java
>>>(ae44bc9373232d242e4ebdcf76844969f0fe69fc)
>>>- 
>>> api/src/org/apache/cloudstack/api/command/admin/storage/UpdateStoragePoolCmd.java
>>>(3d1a77353257c814efaf60875ffdf99603bc414e)
>>>- 
>>> api/src/org/apache/cloudstack/api/command/user/template/RegisterTemplateCmd.java
>>>(f478c9bc8eebf867a03deb4add1bf695ac3ec0ad)
>>>- api/src/org/apache/cloudstack/api/response/StoragePoolResponse.java
>>>(3571866fe74dca9aa5fe0d11373313eab97e94ac)
>>>- api/src/org/apache/cloudstack/api/response/TemplateResponse.java
>>>(3e21043e339103c021d3c9e767acac8b3837f760)
>>>- core/src/com/cloud/agent/api/CheckPoolBelongToHostAnswer.java
>>>(PRE-CREATION)
>>>- core/src/com/cloud/agent/api/CheckPoolBelongToHostCommand.java
>>>(PRE-CREATION)
>>>- core/src/org/apache/cloudstack/storage/to/PrimaryDataStoreTO.java
>>>(29e53b0d9581f764a17ea285606213d2c045b029)
>>>- core/src/org/apache/cloudstack/storage/to/TemplateObjectTO.java
>>>(b201c386f4975913f13c575d7685e50cedc7d92f)
>>>- 
>>> core/test/org/apache/cloudstack/api/agent/test/BackupSnapshotCommandTest.java
>>>(33361e87265df05e00bfa6dba810d2b68ae8d923)
>>>- 
>>> core/test/org/apache/cloudsta

Re: Management Server HA & DB Replication

[Tejas Gadaria]

Thanks Suresh!

Regards,
Tejas


On Tue, Jun 24, 2014 at 5:37 PM, Suresh Sadhu 
wrote:

> IN a cluster management setup:
>
> ON Master  MS you will install master db  with deploy option
> Cloudstack-setup-databases cloud@10.1.1.2 --deploy-as=root
>
> On slave MS : you will point to master db
> Cloudstack-setup-databases cloud@10.1.1.2
>
> ( here don't mention --deploy-as  option on slave if you mention then it
> will overwrite  the master db content)
>
> Once you ran the above command on slave you can see
> "db.cloud.host" point to master  IP in db.properties file
>
>
> Note: always take a baclkup of your DB before doing cluster management
> setup .Due  to any mistake if master db got overwritten and you can safely
>  revert back using ur backup copy
>
> Regards
> Sadhu
>
> -Original Message-
> From: Tejas Gadaria [mailto:refond.g...@gmail.com]
> Sent: 24 June 2014 17:04
> To: dev@cloudstack.apache.org
> Cc: us...@cloudstack.apache.org
> Subject: Re: Management Server HA & DB Replication
>
> Hi abhi,
>
> My 1st MS & DB Master running on : 10.1.1.2 2nd MS & DB Slave running on :
> 10.1.1.3
>
> MS will be in cluster so
>
> Both MS will be pointed to : 10.1.1.2
> Is it correct ?
>
> If so,
> Which parameter should I change in db.properties to point MS cluster to db
> master?
>
> Regards,
> Tejas
>
>
> On Tue, Jun 24, 2014 at 3:54 PM, Abhinandan Prateek <
> abhinandan.prat...@citrix.com> wrote:
>
> > MS will work in a cluster pointing to same DB. The DB can be
> > configured as master-slave.
> >
> > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=34838
> > 207
> >
> > -abhi
> >
> > On 24/06/14 9:53 am, "Tejas Gadaria"  wrote:
> >
> > >Hi,
> > >
> > >I want to make MS on high availability, with automatic failover.
> > >I have MS & DB on same server. & planning to create slave DB on
> > >separate server.
> > >
> > >but if I create separate Slave MS for HA, how can point it to DB so
> > >command issued from any of MS will trigger to same infrastructure.
> > >
> > >Regards,
> > >Tejas
> >
> >
>

non-OSS Build Required?

[Xerex Bueno]

I was curious if you are planning on using Cloudstack in an environment that 
runs VMware and Netscalers if you still need to build from source.  Also where 
can I get the latest files that need to be included in the build for VMware and 
Citrix Netscalers.  Thanks in advance.



This document is PROPRIETARY and CONFIDENTIAL and may not be duplicated, 
redistributed, or displayed to any other party without the expressed written 
permission of LPS Integration, Inc. If you are not the intended recipient and 
have received this email in error, please destroy the email and contact the LPS 
Integration Security Officer at 866-577-2902 (Phone), 615-349-9009 (Fax) or 230 
Great Circle Rd. Suite 218 Nashville, TN 37228 (US Mail)

Re: Review Request 22721: removed hard coded jdk_dirs in cloud-usage script

[Rayees Namathponnan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22721/#review46525
---

Ship it!


Ship It!

- Rayees Namathponnan


On June 18, 2014, 10:15 a.m., Rajani Karuturi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22721/
> ---
> 
> (Updated June 18, 2014, 10:15 a.m.)
> 
> 
> Review request for cloudstack, Kishan Kavala and Rayees Namathponnan.
> 
> 
> Bugs: CLOUDSTACK-6926
> https://issues.apache.org/jira/browse/CLOUDSTACK-6926
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> used to readlink -e and dirname to get the JAVA_HOME
> if JAVA_HOME is not already defined, sets it to jdk home if javac is present 
> else jre home if java is present.
> if nothing is present, it exits with error
> 
> 
> Diffs
> -
> 
>   packaging/centos63/cloud-usage.rc 6170379 
>   packaging/debian/init/cloud-usage 1cc75cc 
> 
> Diff: https://reviews.apache.org/r/22721/diff/
> 
> 
> Testing
> ---
> 
> 
> tested it when java is not installed, jre is installed, jdk installed or when 
> a older version is installed on centos 6.4 and ubuntu 14.04 
> 
> 
> Thanks,
> 
> Rajani Karuturi
> 
>

[GSOC][CLOUDSTACK-6045] Progress Update

[Seif Eddine Jemli]

Hi guys,


As you probably know, I am working on this project whose goal is making the
GUI support adding primary storage to CS that is based on storage plug-ins
(
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Create+GUI+to+add+primary+storage+based+on+plug-ins
)

After studying the GUI code, I have been able to change the "Add Primary
Storage Form" as the storage guys : Mike( my mentor) and Punith wanted to.
(I enclosed two screenshots).

I am currently trying to make the Tags inputs (like Storage tags in the
'add primary storage' form) more user-friendly. This task include creating
a new API call to get the Tags.
I had a hard time at the beginning to set up Cloudstack for development and
to understand the GUI code patterns. But I think that progress will be much
faster now.

I am all ears to feedback or suggestions that aim to improve the GUI.
Thanks.

RE: big revert

[Donal Lafferty]

How did you catch the problem?

> -Original Message-
> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
> Sent: 24 June 2014 10:58
> To: dev
> Subject: big revert
> 
> H,
> 
> I just reverted six commits. I did most of those commits myself. There was a
> misunderstanding on my part on the validity of the commits and the place
> these should go. If you have any questions about it, feel free to ask.
> 
> the short version: they should have gone in the feature branch 'ovmsupport'.
> 
> regards,
> --
> Daan

Re: Custom popup forms w.r.t Plugin Provider

[Mike Tutkowski]

Hi Seif,

I wonder if it would make sense for you to deploy this as a custom GUI
plug-in. I believe the NetApp guys did something like this for their
situation, as well.

David La Motta from NetApp might be able to say more (I've included him).

Talk to you later,
Mike


On Tue, Jun 24, 2014 at 1:03 AM, Punith S  wrote:

> hi,
>
> I am in process of adding a new Add Primary Storage (specific to my
> Storage plugin) form  whose labels & certain values will be different than
> the current Default Provider's Add Primary Storage form.
> also looping the GSoC'14
>
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Create+GUI+to+add+primary+storage+based+on+plug-ins
>
> it seems adding more checks and if-else clauses in system.js will make it
> more fragile and unmanageable.
>
> use case:
> since each vendor requires to use ui with their own specific params,
>
> for example with add primary storage:
> referring the attachment, popup form will be dynamically changed to have
> different params wrt the selected storage providers.
>
> hence instead of writing the vendor specific code inside system.js(common
> file)
> is it acceptable to modularize the code to different vendor specific js
> files like in writing a third party UI plugin ?
> ref -
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/UI+Plugin+Tutorial
>
> thanks
> --
> regards,
>
> punith s
> cloudbyte.com
>



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
*™*

Re: big revert

[Daan Hoogland]

I got stomped ;} from three sides.

no seriously. Sebastien wondered about it as he actually made the
branch and was surprised that it was committed on master,
Mike and Hugo started asking questions about sql code that I didn't catch.

On Tue, Jun 24, 2014 at 4:27 PM, Donal Lafferty
 wrote:
> How did you catch the problem?
>
>> -Original Message-
>> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
>> Sent: 24 June 2014 10:58
>> To: dev
>> Subject: big revert
>>
>> H,
>>
>> I just reverted six commits. I did most of those commits myself. There was a
>> misunderstanding on my part on the validity of the commits and the place
>> these should go. If you have any questions about it, feel free to ask.
>>
>> the short version: they should have gone in the feature branch 'ovmsupport'.
>>
>> regards,
>> --
>> Daan



-- 
Daan

Re: [ACS4.4] release meeting + query on release readiness

[Mike Tutkowski]

Thanks for the e-mail here, Daan.

Let's see how people respond and, if reasonable, maybe we could build our
first RC in a week or so?


On Tue, Jun 24, 2014 at 1:11 AM, Daan Hoogland 
wrote:

> H,
>
> Yesterday I cancelled the second release meeting on IRC due to poor
> attendance. At the moment there is a lot of work going on on the 4.4
> branch and I still get between two and ten pull requests a day. On the
> other hand I don't see any discussion on the list on how serious or
> trivial the remaining issues in 4.4 are. This is very frustrating. It
> is like there is a beast behind a wall and I don't know which of the
> two is stronger. I could bake an RC now but I know we will get into a
> tiresome iteration of finding and solving one blocker at the time.,
> so:
>
> Please describe any remaining issues that you have with the present
> state of the 4.4 branch.
>
> --
> Daan
>



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
*™*

Re: [GSOC][CLOUDSTACK-6045] Progress Update

[Seif Eddine Jemli]

http://imgur.com/II3r0wK

http://imgur.com/05p8lAG

I didn't know that the mailing list doesn't accept enclosed screenshots.


2014-06-24 16:21 GMT+02:00 Seif Eddine Jemli :

> Hi guys,
>
>
> As you probably know, I am working on this project whose goal is making
> the GUI support adding primary storage to CS that is based on storage
> plug-ins
> (
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Create+GUI+to+add+primary+storage+based+on+plug-ins
> )
>
> After studying the GUI code, I have been able to change the "Add Primary
> Storage Form" as the storage guys : Mike( my mentor) and Punith wanted to.
> (I enclosed two screenshots).
>
> I am currently trying to make the Tags inputs (like Storage tags in the
> 'add primary storage' form) more user-friendly. This task include creating
> a new API call to get the Tags.
> I had a hard time at the beginning to set up Cloudstack for development
> and to understand the GUI code patterns. But I think that progress will be
> much faster now.
>
> I am all ears to feedback or suggestions that aim to improve the GUI.
> Thanks.
>

Review Request 22934: CLOUDSTACK-6984: Fixing few issues found durign simulator run

[Gaurav Aradhye]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22934/
---

Review request for cloudstack and Girish Shilamkar.


Bugs: CLOUDSTACK-6984
https://issues.apache.org/jira/browse/CLOUDSTACK-6984


Repository: cloudstack-git


Description
---

Fixing issues found in simulator run.

1. test_01_stop_vm failed on simulator because of escape sequences present in 
the response from simulator
2. test_releaseIP failed due to incorrect listing of IP address. The IP address 
which was was associated was not listed exactly (Listed by passing account id 
and domain id which listed other IP addresses associated with the account along 
with desired IP). The IP address which is not used for source nat should get 
listed instead.


Diffs
-

  test/integration/smoke/test_network.py 0ae777e 
  test/integration/smoke/test_vm_life_cycle.py 9ab7848 
  tools/marvin/marvin/lib/base.py c3d98c9 

Diff: https://reviews.apache.org/r/22934/diff/


Testing
---

yes.


Thanks,

Gaurav Aradhye

Re: Custom popup forms w.r.t Plugin Provider

[Mike Tutkowski]

Sorry...I mean "Hi Punith" :)


On Tue, Jun 24, 2014 at 8:33 AM, Mike Tutkowski <
mike.tutkow...@solidfire.com> wrote:

> Hi Seif,
>
> I wonder if it would make sense for you to deploy this as a custom GUI
> plug-in. I believe the NetApp guys did something like this for their
> situation, as well.
>
> David La Motta from NetApp might be able to say more (I've included him).
>
> Talk to you later,
> Mike
>
>
> On Tue, Jun 24, 2014 at 1:03 AM, Punith S  wrote:
>
>> hi,
>>
>> I am in process of adding a new Add Primary Storage (specific to my
>> Storage plugin) form  whose labels & certain values will be different than
>> the current Default Provider's Add Primary Storage form.
>> also looping the GSoC'14
>>
>> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Create+GUI+to+add+primary+storage+based+on+plug-ins
>>
>> it seems adding more checks and if-else clauses in system.js will make
>> it more fragile and unmanageable.
>>
>> use case:
>> since each vendor requires to use ui with their own specific params,
>>
>> for example with add primary storage:
>> referring the attachment, popup form will be dynamically changed to have
>> different params wrt the selected storage providers.
>>
>> hence instead of writing the vendor specific code inside system.js(common
>> file)
>> is it acceptable to modularize the code to different vendor specific js
>> files like in writing a third party UI plugin ?
>> ref -
>> https://cwiki.apache.org/confluence/display/CLOUDSTACK/UI+Plugin+Tutorial
>>
>> thanks
>> --
>> regards,
>>
>> punith s
>> cloudbyte.com
>>
>
>
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the cloud
> *™*
>



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
*™*

Re: Review Request 22934: CLOUDSTACK-6984: Fixing few issues found durign simulator run

[Girish Shilamkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22934/#review46530
---

Ship it!


Ship It!

- Girish Shilamkar


On June 24, 2014, 3:04 p.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22934/
> ---
> 
> (Updated June 24, 2014, 3:04 p.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-6984
> https://issues.apache.org/jira/browse/CLOUDSTACK-6984
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fixing issues found in simulator run.
> 
> 1. test_01_stop_vm failed on simulator because of escape sequences present in 
> the response from simulator
> 2. test_releaseIP failed due to incorrect listing of IP address. The IP 
> address which was was associated was not listed exactly (Listed by passing 
> account id and domain id which listed other IP addresses associated with the 
> account along with desired IP). The IP address which is not used for source 
> nat should get listed instead.
> 
> 
> Diffs
> -
> 
>   test/integration/smoke/test_network.py 0ae777e 
>   test/integration/smoke/test_vm_life_cycle.py 9ab7848 
>   tools/marvin/marvin/lib/base.py c3d98c9 
> 
> Diff: https://reviews.apache.org/r/22934/diff/
> 
> 
> Testing
> ---
> 
> yes.
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Re: Review Request 22934: CLOUDSTACK-6984: Fixing few issues found durign simulator run

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22934/#review46531
---


Commit 8de18f144c680287c762a4b5db1b6e1d596f5723 in cloudstack's branch 
refs/heads/4.4-forward from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=8de18f1 ]

CLOUDSTACK-6984: Resolving simulator issues


- ASF Subversion and Git Services


On June 24, 2014, 3:04 p.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22934/
> ---
> 
> (Updated June 24, 2014, 3:04 p.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-6984
> https://issues.apache.org/jira/browse/CLOUDSTACK-6984
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fixing issues found in simulator run.
> 
> 1. test_01_stop_vm failed on simulator because of escape sequences present in 
> the response from simulator
> 2. test_releaseIP failed due to incorrect listing of IP address. The IP 
> address which was was associated was not listed exactly (Listed by passing 
> account id and domain id which listed other IP addresses associated with the 
> account along with desired IP). The IP address which is not used for source 
> nat should get listed instead.
> 
> 
> Diffs
> -
> 
>   test/integration/smoke/test_network.py 0ae777e 
>   test/integration/smoke/test_vm_life_cycle.py 9ab7848 
>   tools/marvin/marvin/lib/base.py c3d98c9 
> 
> Diff: https://reviews.apache.org/r/22934/diff/
> 
> 
> Testing
> ---
> 
> yes.
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Re: Review Request 22934: CLOUDSTACK-6984: Fixing few issues found durign simulator run

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22934/#review46532
---


Commit 0df156c09e152845d6c6332fa1d91fe9c15c7cc6 in cloudstack's branch 
refs/heads/master from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=0df156c ]

CLOUDSTACK-6984: Resolving issues found during simulator run


- ASF Subversion and Git Services


On June 24, 2014, 3:04 p.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22934/
> ---
> 
> (Updated June 24, 2014, 3:04 p.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-6984
> https://issues.apache.org/jira/browse/CLOUDSTACK-6984
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fixing issues found in simulator run.
> 
> 1. test_01_stop_vm failed on simulator because of escape sequences present in 
> the response from simulator
> 2. test_releaseIP failed due to incorrect listing of IP address. The IP 
> address which was was associated was not listed exactly (Listed by passing 
> account id and domain id which listed other IP addresses associated with the 
> account along with desired IP). The IP address which is not used for source 
> nat should get listed instead.
> 
> 
> Diffs
> -
> 
>   test/integration/smoke/test_network.py 0ae777e 
>   test/integration/smoke/test_vm_life_cycle.py 9ab7848 
>   tools/marvin/marvin/lib/base.py c3d98c9 
> 
> Diff: https://reviews.apache.org/r/22934/diff/
> 
> 
> Testing
> ---
> 
> yes.
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Re: Review Request 17790: Domain-Account-User Sync Up Among Multiple Regions (New Plugin)

[Alex Ough]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17790/
---

(Updated June 24, 2014, 3:52 p.m.)


Review request for cloudstack.


Changes
---

Hope this is the final!


Repository: cloudstack-git


Description
---

Currently, under the environment of cloudstack with multiple regions, each 
region has its own management server running with a separate database, which 
will cause data discrepancies when users create/update/delete 
domain/account/user data independently in each management server. So to support 
multiple regions and provide one point of entry for each customer, this 
implementation duplicates domain/account/user information of customers in one 
region to all of the regions independently whenever there is any change.

https://issues.apache.org/jira/browse/CLOUDSTACK-4992
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Domain-Account-User+Sync+Up+Among+Multiple+Regions


Diffs (updated)
-

  engine/schema/src/org/apache/cloudstack/multiregion/RmapVO.java PRE-CREATION 
  engine/schema/src/org/apache/cloudstack/multiregion/RsyncVO.java PRE-CREATION 
  engine/schema/src/org/apache/cloudstack/multiregion/dao/RmapDao.java 
PRE-CREATION 
  engine/schema/src/org/apache/cloudstack/multiregion/dao/RmapDaoImpl.java 
PRE-CREATION 
  engine/schema/src/org/apache/cloudstack/multiregion/dao/RsyncDao.java 
PRE-CREATION 
  engine/schema/src/org/apache/cloudstack/multiregion/dao/RsyncDaoImpl.java 
PRE-CREATION 
  plugins/event-bus/multiregion/pom.xml PRE-CREATION 
  
plugins/event-bus/multiregion/resources/META-INF/cloudstack/core/spring-plugin-multiregion-system-context.xml
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/FullSyncer.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/InjectedCollection.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/MultiRegionEventBus.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/StringManipulator.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/api/AccountCaller.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/api/BaseCaller.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/api/DomainCaller.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/api/UserCaller.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/api/command/ListSyncAccountsCmd.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/api/command/ListSyncAccountsCmdByAdmin.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/api/command/ListSyncDomainChildrenCmd.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/api/command/ListSyncDomainsCmd.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/api/command/ListSyncUsersCmd.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/api/dao/SyncAccountJoinDao.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/api/dao/SyncAccountJoinDaoImpl.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/api/dao/SyncUserAccountJoinDao.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/api/dao/SyncUserAccountJoinDaoImpl.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/api/response/ApiSyncResponseHelper.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/api/response/SyncAccountResponse.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/api/response/SyncDomainResponse.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/api/response/SyncQueryManagerImpl.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/api/response/SyncQueryService.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/api/response/SyncUserResponse.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/event/SyncActionEventInterceptor.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/event/SyncActionEventUtils.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/exception/APIFailureException.java
 PRE-CREATION 
  
plugins/event-bus/multiregion

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

[Alex Ough]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20099/
---

(Updated June 24, 2014, 3:54 p.m.)


Review request for cloudstack.


Changes
---

Hope this is the final!


Repository: cloudstack-git


Description
---

This is the review request for the core changes related with #17790 that has 
only the new plugin codes.


Diffs (updated)
-

  api/src/com/cloud/event/EventTypes.java 0fa3cd5 
  api/src/com/cloud/user/AccountService.java eac8a76 
  api/src/com/cloud/user/DomainService.java 4c1f93d 
  api/src/org/apache/cloudstack/api/ApiConstants.java adda5f4 
  api/src/org/apache/cloudstack/api/BaseCmd.java ac9a208 
  api/src/org/apache/cloudstack/api/command/admin/account/CreateAccountCmd.java 
50d67d9 
  api/src/org/apache/cloudstack/api/command/admin/account/DeleteAccountCmd.java 
5754ec5 
  
api/src/org/apache/cloudstack/api/command/admin/account/DisableAccountCmd.java 
3e5e1d3 
  api/src/org/apache/cloudstack/api/command/admin/account/EnableAccountCmd.java 
f30c985 
  api/src/org/apache/cloudstack/api/command/admin/account/LockAccountCmd.java 
3c185e4 
  api/src/org/apache/cloudstack/api/command/admin/account/UpdateAccountCmd.java 
a7ce74a 
  api/src/org/apache/cloudstack/api/command/admin/domain/CreateDomainCmd.java 
312c9ee 
  api/src/org/apache/cloudstack/api/command/admin/domain/DeleteDomainCmd.java 
a6d2b0b 
  api/src/org/apache/cloudstack/api/command/admin/domain/UpdateDomainCmd.java 
409a84d 
  api/src/org/apache/cloudstack/api/command/admin/region/AddRegionCmd.java 
f6743ba 
  api/src/org/apache/cloudstack/api/command/admin/region/UpdateRegionCmd.java 
b08cbbb 
  api/src/org/apache/cloudstack/api/command/admin/user/CreateUserCmd.java 
8f223ac 
  api/src/org/apache/cloudstack/api/command/admin/user/DeleteUserCmd.java 
08ba521 
  api/src/org/apache/cloudstack/api/command/admin/user/DisableUserCmd.java 
c6e09ef 
  api/src/org/apache/cloudstack/api/command/admin/user/EnableUserCmd.java 
d69eccf 
  api/src/org/apache/cloudstack/api/command/admin/user/LockUserCmd.java 69623d0 
  api/src/org/apache/cloudstack/api/command/admin/user/RegisterCmd.java 2090d21 
  api/src/org/apache/cloudstack/api/command/admin/user/UpdateUserCmd.java 
f21e264 
  api/src/org/apache/cloudstack/api/response/RegionResponse.java 6c74fa6 
  api/src/org/apache/cloudstack/region/Region.java df64e44 
  api/src/org/apache/cloudstack/region/RegionService.java afefcc7 
  api/test/org/apache/cloudstack/api/command/test/RegionCmdTest.java 10c3d85 
  client/pom.xml 29fef4f 
  
engine/schema/resources/META-INF/cloudstack/core/spring-engine-schema-core-daos-context.xml
 2ef0d20 
  engine/schema/src/com/cloud/user/AccountVO.java 0f5a044 
  engine/schema/src/org/apache/cloudstack/region/RegionVO.java 608bd2b 
  
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/MockAccountManager.java
 4136b5c 
  plugins/pom.xml b5e6a61 
  
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapCreateAccountCmd.java
 b753952 
  
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapImportUsersCmd.java
 6f7be90 
  server/src/com/cloud/api/ApiResponseHelper.java f1f0d2c 
  server/src/com/cloud/api/dispatch/ParamProcessWorker.java 1592b93 
  server/src/com/cloud/event/ActionEventUtils.java 2b3cfea 
  server/src/com/cloud/projects/ProjectManagerImpl.java d10c059 
  server/src/com/cloud/user/AccountManager.java 194c5d2 
  server/src/com/cloud/user/AccountManagerImpl.java 7a889f1 
  server/src/com/cloud/user/DomainManager.java f72b18a 
  server/src/com/cloud/user/DomainManagerImpl.java fbbe0c2 
  server/src/org/apache/cloudstack/region/RegionManager.java 6f25481 
  server/src/org/apache/cloudstack/region/RegionManagerImpl.java 8910714 
  server/src/org/apache/cloudstack/region/RegionServiceImpl.java 98cf500 
  server/test/com/cloud/user/AccountManagerImplTest.java 176cf1d 
  server/test/com/cloud/user/MockAccountManagerImpl.java 746fa1b 
  server/test/com/cloud/user/MockDomainManagerImpl.java 7dddefb 
  server/test/org/apache/cloudstack/region/RegionManagerTest.java d7bc537 
  setup/db/db/schema-440to450.sql ee419a2 
  ui/scripts/regions.js 368c1bf 

Diff: https://reviews.apache.org/r/20099/diff/


Testing
---

1. Successfully tested real time synchronization as soon as resources are 
created/deleted/modified in one region.
2. Successfully tested full scans to synchronize resources that were missed 
during real time synchronization because of any reasons like network connection 
issues.
3. The tests were done manually and also automatically by randomly generating 
changes each region.


Thanks,

Alex Ough

RE: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

[Ritu Sabharwal]

Hi Hugo,

There is a separate file


From: Hugo Trippaers [mailto:nore...@reviews.apache.org] On Behalf Of Hugo 
Trippaers
Sent: Monday, June 23, 2014 11:41 PM
To: Ritu Sabharwal; Hugo Trippaers; cloudstack
Subject: Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for 
Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

This is an automatically generated e-mail. To reply, visit: 
https://reviews.apache.org/r/22863/




Hey,



There are a number of issues with this patch, i've made the commments on the 
lines directly. Also where is the real functionality? The code in this patch 
seems to only be the hook into the existing cloudstack code and not the brocade 
code itself?



Cheers,



Hugo

api/src/com/cloud/network/Network.java
 (Diff revision 1)


public static class Provider {


135





Please remove tabs from the sources.

build/replace.properties
 (Diff revision 1)

20


DBROOTPW=

20


DBROOTPW=password


This change will break some developer setups. Can you remove this file from the 
patch.

plugins/pom.xml
 (Diff revision 1)


71


test


Why do you need to include test in the main build process?

setup/db/create-schema.sql
 (Diff revision 1)


148


DROP TABLE IF EXISTS `cloud`.`brocade_network_host_map`;


Don't make changes to this file. Add the new tables to the upgrade files. In 
this case you need to make the changes in the 4.4 to 4.5 upgrade file.

utils/conf/db.properties
 (Diff revision 1)

28


db.root.password=

28


db.root.password=password


Please don't commit any changes to this file.


- Hugo Trippaers


On June 23rd, 2014, 5:49 p.m. UTC, Ritu Sabharwal wrote:
Review request for cloudstack.
By Ritu Sabharwal.

Updated June 23, 2014, 5:49 p.m.
Bugs: CLOUDSTACK-6823
Repository: cloudstack-git
Description

First code drop for Brocade Network plugin to orchestrate Brocade VDX switches 
for L2 connectivity. Please create a new branch for Brocade plugin.


Testing

•   Create an isolated network; verify that the port-profile is created on 
the Brocade switch.

•   Attach a VM to the network; verify that the VMs MAC address is 
associated with the port profile of the network on the Brocade switch.

•   Delete VMs for an isolated network; verify that the VMs MAC address is 
disassociated with the port profile of the network on the Brocade switch.

•   Delete the isolated network; verify that the port-profile is deleted 
from the Brocade switch.


Diffs

 *   api/src/com/cloud/network/Network.java (b5e8173)
 *   api/src/com/cloud/network/Networks.java (3159f6e)
 *   api/src/com/cloud/network/PhysicalNetwork.java (5d38b50)
 *   build/replace.properties (265f335)
 *   client/pom.xml (3995f6e)
 *   plugins/pom.xml (4f7805a)
 *   setup/db/create-schema.sql (55cb4cc)
 *   ui/scripts/system.js (0c56baf)
 *   utils/conf/db.properties (e1b5fe9)

View Diff

File Attachments

 *   Diff for the existing cloudstack 
code
 *   Patch for the plugin 
code

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

[Ritu Sabharwal]

> On June 24, 2014, 6:40 a.m., Hugo Trippaers wrote:
> > Hey,
> > 
> > There are a number of issues with this patch, i've made the commments on 
> > the lines directly. Also where is the real functionality? The code in this 
> > patch seems to only be the hook into the existing cloudstack code and not 
> > the brocade code itself?
> > 
> > Cheers,
> > 
> > Hugo

Hi Hugo,

I commented on the review comments directly. I included a patch file 
brocade-vcs.patch which has Brocade code. 

I followed these steps to create the patch:

-git add plugins/network-elements/brocade-vcs
-git commit -m "Commit message“
-git format-patch master --stdout > ~/brocade-vcs.patch

Is there any other way to include Brocade code in the diffs? Please let me 
know. I will submit that for review.

Thanks,
Ritu.


> On June 24, 2014, 6:40 a.m., Hugo Trippaers wrote:
> > build/replace.properties, line 20
> > 
> >
> > This change will break some developer setups. Can you remove this file 
> > from the patch.

The changes in this file are for my local server. I will remove this file from 
the patch.


> On June 24, 2014, 6:40 a.m., Hugo Trippaers wrote:
> > api/src/com/cloud/network/Network.java, line 135
> > 
> >
> > Please remove tabs from the sources.

I will fix this.


> On June 24, 2014, 6:40 a.m., Hugo Trippaers wrote:
> > plugins/pom.xml, line 71
> > 
> >
> > Why do you need to include test in the main build process?

I created some test project for my testing. I will fix this.


> On June 24, 2014, 6:40 a.m., Hugo Trippaers wrote:
> > setup/db/create-schema.sql, line 148
> > 
> >
> > Don't make changes to this file. Add the new tables to the upgrade 
> > files. In this case you need to make the changes in the 4.4 to 4.5 upgrade 
> > file.

I will fix this.


> On June 24, 2014, 6:40 a.m., Hugo Trippaers wrote:
> > utils/conf/db.properties, line 28
> > 
> >
> > Please don't commit any changes to this file.

This again is for my local server. I will remove this file from the patch.


- Ritu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/#review46498
---


On June 23, 2014, 5:49 p.m., Ritu  Sabharwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22863/
> ---
> 
> (Updated June 23, 2014, 5:49 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Bugs: CLOUDSTACK-6823
> https://issues.apache.org/jira/browse/CLOUDSTACK-6823
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> First code drop for Brocade Network plugin to orchestrate Brocade VDX 
> switches for L2 connectivity. Please create a new branch for Brocade plugin.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/network/Network.java b5e8173 
>   api/src/com/cloud/network/Networks.java 3159f6e 
>   api/src/com/cloud/network/PhysicalNetwork.java 5d38b50 
>   build/replace.properties 265f335 
>   client/pom.xml 3995f6e 
>   plugins/pom.xml 4f7805a 
>   setup/db/create-schema.sql 55cb4cc 
>   ui/scripts/system.js 0c56baf 
>   utils/conf/db.properties e1b5fe9 
> 
> Diff: https://reviews.apache.org/r/22863/diff/
> 
> 
> Testing
> ---
> 
> • Create an isolated network; verify that the port-profile is created on 
> the Brocade switch.
> • Attach a VM to the network; verify that the VMs MAC address is 
> associated with the port profile of the network on the Brocade switch.
> • Delete VMs for an isolated network; verify that the VMs MAC address is 
> disassociated with the port profile of the network on the Brocade switch.
> • Delete the isolated network; verify that the port-profile is deleted 
> from the Brocade switch.
> 
> 
> File Attachments
> 
> 
> Diff for the existing cloudstack code
>   
> https://reviews.apache.org/media/uploaded/files/2014/06/23/8fc3cfb1-7a21-4714-98f3-6514cf54ba84__diff
> Patch for the plugin code
>   
> https://reviews.apache.org/media/uploaded/files/2014/06/23/fbb2b949-a42c-4b22-afa7-60e691c778df__brocade-vcs.patch
> 
> 
> Thanks,
> 
> Ritu  Sabharwal
> 
>

Adding a distant KVM host

[Seif Eddine Jemli]

Hi,

I am trying to add a distant *KVM* host. I created a *VPN* for this
purpose.
I have a management server and a distant host now connected via a VPN (it
is a point to point VPN). so KVM host has the ip address 10.0.0.1 on the
ppp0 interface (specific to the VPN) and the MS has the address 10.0.0.100
on his ppp0 interface too. (point to point VPN).

I didn't know how to configure the /etc/network/interfaces on the KVM host.
I couldn't try much because any error can make the server inaccessible.
The problem is that I am not sure if I can put the ppp0 in the
/etc/network/interfaces, because it is not a physical interface.
How can I configure the network?

thanks

Re: Why to have API Commands for Admin actions?

[Min Chen]

Hi Wilder,

This is a recent change introduced by IAM feature, see FS here
https://cwiki.apache.org/confluence/display/CLOUDSTACK/CloudStack+Identity+
and+Access+Management+%28IAM%29+Plugin, particularly see details in
Response View section. The intention of this is to eventually provide
custom response view for different custom IAM roles. As the first step, we
only provided two static response view: Full and Restricted, and just map
Full view to current admin commands. In the future, we should allow admin
to define custom response view through column filter, and associate each
custom response view with IAM policy. Hope that this can give you some
context on this part of code.

Thanks.
-min

On 6/24/14 4:55 AM, "Wilder Rodrigues" 
wrote:

>Hi all,
>
>We are currently working on the redundant VPC implementation. In order to
>take the right steps from the beginning, we started analyzing the
>existing code base, from the API commands into the
>VPCVirtualNetworkAppliancaManagerImpl.
>
>Although it's not related to the feature itself, we found out that the
>current way of using the APICommand annotation and the CreateVPCCmd class
>(and its derived) is not really clear. For example, there are 2 command
>classes to create a VPC. The difference between them is: one has
>ResponseView.Full parameter in the @APICommand (ie. CreateVPCCmdByAdmin);
>and the other has ResponseView.Rstricted parameter in the @APICommand
>(i.e. CreateVPCCmd). Moreover, the call to
>responseGenerator.createVpcresponde() method uses a ResponseView enum
>according to what has been specified in the annotation parameter.
>
>We understand that having a different enum in the
>responseGenerator.createVpcresponde() method will affect many things,
>because it goes deep into the code until reaches the APIDBUtils and the
>database. It is also checked in the ApiServer class, when the command is
>evaluated based on a string passed to the getCmdClass() method.
>
>Since we can identify the user in the account manager, also checking the
>kind of access the user has, what is the point in having the Annotation +
>the Enum in the code? Keep in mind that the latter is passed several
>times as parameters to other methods, which adds many "ifs" and
>unnecessary complexity.
>
>We could also make possible to use the Annotation in the method itself,
>which could avoid having to pass the Enum to the method. That means that
>the Enum would be removed from the annotation and we would use the
>annotation only to identify the API name, response object and entity
>type. In order to check the user's credentials, we would use the
>checkAccess() from the account manager, as it is already being used in
>the ApiDispatcher class.
>
>I know those are huge changes, if we actually agree in going for anything
>like this in the future. But the Admin commands are not doing much except
>for change the enum which is passed to the create response method. Most
>of the content of the execute() method is a copy/paste from the extended
>Command class.
>
>Just trying to start some chat towards the subject.
>
>Thanks for your time.
>
>Cheers,
>Wilder

Review Request 22939: CLOUDSTACK-6460 - CLVM primary storage migration fails due to incorrect identification of source format.

[Simon Weller]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22939/
---

Review request for cloudstack.


Bugs: CLOUDSTACK-6460
https://issues.apache.org/jira/browse/CLOUDSTACK-6460


Repository: cloudstack-git


Description
---

Addresses CLOUDSTACK-6460.
CLVM storage source was being identified as QCOW2, rather than raw when 
attempting a primary storage migration.  This caused the migration to fail when 
qemu-img attempted to image the file back from secondary storage to the new 
primary storage selected. This patch forces CLVM to be treated as RAW while 
continuing to acquire sourceFormat from other storage types via 
disk.getFormat();


Diffs
-

  
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java
 ecf3e08 

Diff: https://reviews.apache.org/r/22939/diff/


Testing
---

Stop VM. Migrate from one primary storage to another. Migration completes 
successfully. Start vm.


Thanks,

Simon Weller

Re: Review Request 22928: Fixed resource leaks and added support for secstoragefirewallcfg command to simulator in master

[Santhosh Edukulla]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22928/
---

(Updated June 24, 2014, 6:06 p.m.)


Review request for cloudstack, Abhinandan Prateek and daan Hoogland.


Bugs: coverity
https://issues.apache.org/jira/browse/coverity


Repository: cloudstack-git


Description
---

1. Fixed few Resource Leaks reported by coverity in master
2. As well added support for a config command to simulator in master


Diffs
-

  engine/schema/src/com/cloud/upgrade/dao/DatabaseAccessObject.java 836a537 
  framework/db/src/com/cloud/utils/crypt/EncryptionSecretKeyChanger.java 
4cee081 
  framework/db/src/com/cloud/utils/db/ScriptRunner.java 932b37b 
  
plugins/hypervisors/simulator/src/com/cloud/agent/manager/SimulatorManagerImpl.java
 321f06f 

Diff: https://reviews.apache.org/r/22928/diff/


Testing
---

Built the simulator code and deployed a datacenter


Thanks,

Santhosh Edukulla

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

[Alena Prokharchyk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20099/#review46557
---


Alex, one small thing.

Just noticed that in the API commands you pass regionUUID as a string. You 
should pass it as a type of UUID and specify the entityType parameter in 
@Parameter so the entity validation is done correctly. Example:

@Parameter(name=ApiConstants.ZONE_ID, type=CommandType.UUID, entityType = 
ZoneResponse.class,
required=true, description="the Zone ID for the network")
private Long zoneId;

That is the rule when passing id/uuid of the first class CS object to the API 
call

Then be aware of the fact that the APIDispatcher will transform UUID to the 
actual DB id, and that would be the Id that you pass to the services call. If 
what you need is UUID, not the actual id, to be saved in the callContext, you 
have to transform it explicitly.

- Alena Prokharchyk


On June 24, 2014, 3:54 p.m., Alex Ough wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20099/
> ---
> 
> (Updated June 24, 2014, 3:54 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> This is the review request for the core changes related with #17790 that has 
> only the new plugin codes.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/event/EventTypes.java 0fa3cd5 
>   api/src/com/cloud/user/AccountService.java eac8a76 
>   api/src/com/cloud/user/DomainService.java 4c1f93d 
>   api/src/org/apache/cloudstack/api/ApiConstants.java adda5f4 
>   api/src/org/apache/cloudstack/api/BaseCmd.java ac9a208 
>   
> api/src/org/apache/cloudstack/api/command/admin/account/CreateAccountCmd.java 
> 50d67d9 
>   
> api/src/org/apache/cloudstack/api/command/admin/account/DeleteAccountCmd.java 
> 5754ec5 
>   
> api/src/org/apache/cloudstack/api/command/admin/account/DisableAccountCmd.java
>  3e5e1d3 
>   
> api/src/org/apache/cloudstack/api/command/admin/account/EnableAccountCmd.java 
> f30c985 
>   api/src/org/apache/cloudstack/api/command/admin/account/LockAccountCmd.java 
> 3c185e4 
>   
> api/src/org/apache/cloudstack/api/command/admin/account/UpdateAccountCmd.java 
> a7ce74a 
>   api/src/org/apache/cloudstack/api/command/admin/domain/CreateDomainCmd.java 
> 312c9ee 
>   api/src/org/apache/cloudstack/api/command/admin/domain/DeleteDomainCmd.java 
> a6d2b0b 
>   api/src/org/apache/cloudstack/api/command/admin/domain/UpdateDomainCmd.java 
> 409a84d 
>   api/src/org/apache/cloudstack/api/command/admin/region/AddRegionCmd.java 
> f6743ba 
>   api/src/org/apache/cloudstack/api/command/admin/region/UpdateRegionCmd.java 
> b08cbbb 
>   api/src/org/apache/cloudstack/api/command/admin/user/CreateUserCmd.java 
> 8f223ac 
>   api/src/org/apache/cloudstack/api/command/admin/user/DeleteUserCmd.java 
> 08ba521 
>   api/src/org/apache/cloudstack/api/command/admin/user/DisableUserCmd.java 
> c6e09ef 
>   api/src/org/apache/cloudstack/api/command/admin/user/EnableUserCmd.java 
> d69eccf 
>   api/src/org/apache/cloudstack/api/command/admin/user/LockUserCmd.java 
> 69623d0 
>   api/src/org/apache/cloudstack/api/command/admin/user/RegisterCmd.java 
> 2090d21 
>   api/src/org/apache/cloudstack/api/command/admin/user/UpdateUserCmd.java 
> f21e264 
>   api/src/org/apache/cloudstack/api/response/RegionResponse.java 6c74fa6 
>   api/src/org/apache/cloudstack/region/Region.java df64e44 
>   api/src/org/apache/cloudstack/region/RegionService.java afefcc7 
>   api/test/org/apache/cloudstack/api/command/test/RegionCmdTest.java 10c3d85 
>   client/pom.xml 29fef4f 
>   
> engine/schema/resources/META-INF/cloudstack/core/spring-engine-schema-core-daos-context.xml
>  2ef0d20 
>   engine/schema/src/com/cloud/user/AccountVO.java 0f5a044 
>   engine/schema/src/org/apache/cloudstack/region/RegionVO.java 608bd2b 
>   
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/MockAccountManager.java
>  4136b5c 
>   plugins/pom.xml b5e6a61 
>   
> plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapCreateAccountCmd.java
>  b753952 
>   
> plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapImportUsersCmd.java
>  6f7be90 
>   server/src/com/cloud/api/ApiResponseHelper.java f1f0d2c 
>   server/src/com/cloud/api/dispatch/ParamProcessWorker.java 1592b93 
>   server/src/com/cloud/event/ActionEventUtils.java 2b3cfea 
>   server/src/com/cloud/projects/ProjectManagerImpl.java d10c059 
>   server/src/com/cloud/user/AccountManager.java 194c5d2 
>   server/src/com/cloud/user/AccountManagerImpl.java 7a889f1 
>   server/src/com/cloud/user/DomainManager.java f72b18a 
>   server/src/com/cloud/user/DomainManagerImpl.java fbbe0c2 
>   serv

[GSOC] End of term update

[Darren Brogan]

Hi guys,

Since my last email I've done quite a bit of work on gstack. I added
uniitests to make future changes easier. The coverage is at 95% currently.
I added gstack to coveralls to keep track of test results, you can view the
statistics at https://coveralls.io/r/NOPping/gstack

I refactored quite a bit of code in controllers. My original plan to
achieve this was to use templates but they proved to be troublesome with
json. Instead, I opted to just clean the current implementation and extract
repeated code to a common script.

I added support for configuration profiles. This means you can use gstack
against multiple clouds without having to rerun gstack-configure each time.
profiles are utilized with the '-p' / '--profile' flags when configuring
and running the application.

Example:

Re: [GSOC] End of term update

[Darren Brogan]

Apologies, send that prematurely.

Anyway getting back to it, an example of profile usage:

$ gstack-configure -p exampleprofile

$ gstack -p exampleprofile

Along with that the user now has the ability to debug the app with the '-d'
/ '--debug' flags when running the application.

$ gstack -d True

Version 1.0.0 of gstack was released today. You can download / upgrade
using pip. https://pypi.python.org/pypi/gstack

The first term was a lot of fun and I made a good bit of progress with
gstack. Ec2stack is next.

If you have any feedback or advice I'd be glad to hear it.

Thanks,
Darren


On Tue, Jun 24, 2014 at 7:56 PM, Darren Brogan 
wrote:

> Hi guys,
>
> Since my last email I've done quite a bit of work on gstack. I added
> uniitests to make future changes easier. The coverage is at 95% currently.
> I added gstack to coveralls to keep track of test results, you can view the
> statistics at https://coveralls.io/r/NOPping/gstack
>
> I refactored quite a bit of code in controllers. My original plan to
> achieve this was to use templates but they proved to be troublesome with
> json. Instead, I opted to just clean the current implementation and extract
> repeated code to a common script.
>
> I added support for configuration profiles. This means you can use gstack
> against multiple clouds without having to rerun gstack-configure each time.
> profiles are utilized with the '-p' / '--profile' flags when configuring
> and running the application.
>
> Example:
>
>

Re: [GSOC] End of term update

[sebgoa]

On Jun 24, 2014, at 9:05 PM, Darren Brogan  wrote:

> Apologies, send that prematurely.
> 
> Anyway getting back to it, an example of profile usage:
> 
> $ gstack-configure -p exampleprofile
> 
> $ gstack -p exampleprofile
> 
> Along with that the user now has the ability to debug the app with the '-d'
> / '--debug' flags when running the application.
> 
> $ gstack -d True
> 
> Version 1.0.0 of gstack was released today. You can download / upgrade
> using pip. https://pypi.python.org/pypi/gstack
> 
> The first term was a lot of fun and I made a good bit of progress with
> gstack. Ec2stack is next.
> 
> If you have any feedback or advice I'd be glad to hear it.
> 
> Thanks,
> Darren

Thanks Darren,

Good work,

For those that did not follow. gstack is a python flask application that 
provides a GCE compliant interface. It forwards requests to cloudstack api 
server.

It's all on github:

https://github.com/NOPping/gstack

It's not clear to me yet, if we need this under cloudstack ASF repos. @anyone 
thoughts ?

The app is automatically build tested on Travis, with unit test coverage 
published on coveralls. the app is available through pypi.

@Darren, github still shows pypi package at 0.1.0.

Two small things:

-Would be nice to have a little read me on how to add an API

-Would be nice to have a little read me on how to use something like gunicorn 
to run the app as a linux service.

Otherwise, I tested for basic zones and it works just fine.

Good work,

> 
> 
> On Tue, Jun 24, 2014 at 7:56 PM, Darren Brogan 
> wrote:
> 
>> Hi guys,
>> 
>> Since my last email I've done quite a bit of work on gstack. I added
>> uniitests to make future changes easier. The coverage is at 95% currently.
>> I added gstack to coveralls to keep track of test results, you can view the
>> statistics at https://coveralls.io/r/NOPping/gstack
>> 
>> I refactored quite a bit of code in controllers. My original plan to
>> achieve this was to use templates but they proved to be troublesome with
>> json. Instead, I opted to just clean the current implementation and extract
>> repeated code to a common script.
>> 
>> I added support for configuration profiles. This means you can use gstack
>> against multiple clouds without having to rerun gstack-configure each time.
>> profiles are utilized with the '-p' / '--profile' flags when configuring
>> and running the application.
>> 
>> Example:
>> 
>> 

Re: Managing individual ESXi instances

[ilya musayev]

The WSDL is still available on ESXi port 443, you are loosing the 
vCenter fanciness - which maybe big for some folks, but other than that 
- it works fine.


The API calls will have to be altered as they will no longer be bound to 
vCenter, but most of the calls can be re-used.


You can use local storage iSCSI, local datastore formatted as VMFS and NFS.

On 6/18/14, 8:53 AM, Tim Mackey wrote:

Mike,

I wouldn't expect things with the VMware Hypervisor (what they refer to
standalone ESXi) to work out of the box.  Since you can't cluster things,
I'd expect only raw iSCSI to work, but it's been years since I've worked
with raw ESXi.

-tim


On Wed, Jun 18, 2014 at 11:40 AM, Mike Tutkowski <
mike.tutkow...@solidfire.com> wrote:


Or I'd like to know if it doesn't work (as is the case for Hyper-V until I
get time to add that kind of support for it).


On Wed, Jun 18, 2014 at 9:37 AM, Mike Tutkowski <
mike.tutkow...@solidfire.com> wrote:


I know, for example, that I'd like to test out that managed storage works
with it.

I've added support for managed storage to XenServer, ESX/vCenter, and KVM
for CloudStack.

Another hypervisor type - to me personally - means I'd to verify managed
storage works with it.

Depending on how radical the changes for an ESX-only solution are, it may
or may not work "out of the box" for managed storage.


On Wed, Jun 18, 2014 at 9:30 AM, Ivan Efremov  wrote:


Hi Alex,

How do you think, what is the rough estimation of adding ESX API support
to CloudStack?
AFAIU the main point of integration of the new API is
plugins/hypervisors. Are there any other major points that should be
patched when adding a new hypervisor type?


Thanks,
Ivan

18.06.2014, 18:24, "Alex Huang" :

IIRC, the reason is because the vCenter API is more powerful than the

ESX API.  At the time (before Apache), the features that requested

needed

vCenter. There's currently no proposal to use plain ESXi.  Would love to
see one though.

--Alex

  -Original Message-
  From: Ivan Efremov [mailto:e...@yandex.ru]
  Sent: Tuesday, June 17, 2014 8:26 PM
  To: dev@cloudstack.apache.org
  Subject: Managing individual ESXi instances

  Hi all,

  I've sent this mail to the users list but this one looks as the

better destination.

  I'm new to the CloudStack platform and I'm wondering why the

platform

  does need the vCenter API and can not use ESXi directly,

  Can anyone elaborate on this?
  Are there any proposals for adding ESXi integration to CloudStack?

  Thanks,
  Ivan



--
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
*™*




--
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
*™*

Re: Review Request 21776: AWSAPI: cloudstack api on POST requests (instead GET), ssl enabling fixed

[Prachi Damle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21776/#review46567
---


Hi,

1) EC2Engine.java: I see a lot of new line breaks introduced and its hard to 
know what the changes are.
Is it possible to clean this or provide a list of changes/line numbers changed?

2) CloudStackClient.java: 
What are the reasons for:
- Deletion of JsonAccessor.java and using JsonElement instead
- Changes in CloudStackClient::call() method around error handling

3)CloudStackApi.java:
- What are the reasons to replace CloudStackCommand by CloudStackQueryBuilder?


- Prachi Damle


On May 27, 2014, 8:04 p.m., Dmitry Batkovich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21776/
> ---
> 
> (Updated May 27, 2014, 8:04 p.m.)
> 
> 
> Review request for cloudstack, Chiradeep Vittal, daan Hoogland, and Prachi 
> Damle.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> * CloudStackClient.java http request mechanism replaced from GET requests to 
> POST for supporting EC2 requests larger than 2KB
> * SSL enabling fixed in EC2Engine.java
> 
> continuation of https://reviews.apache.org/r/17586/
> 
> 
> Diffs
> -
> 
>   awsapi/conf/ec2-service.properties.in 82f5ad8 
>   awsapi/src/com/cloud/bridge/service/core/ec2/EC2Engine.java cd20214 
>   awsapi/src/com/cloud/bridge/util/JsonAccessor.java 2a94dea 
>   awsapi/src/com/cloud/bridge/util/JsonElementUtil.java PRE-CREATION 
>   awsapi/src/com/cloud/stack/CloudStackApi.java b7a1210 
>   awsapi/src/com/cloud/stack/CloudStackClient.java 03eba96 
>   awsapi/src/com/cloud/stack/CloudStackClientException.java PRE-CREATION 
>   awsapi/src/com/cloud/stack/CloudStackCommand.java 8d6aa68 
>   awsapi/src/com/cloud/stack/CloudStackQueryBuilder.java PRE-CREATION 
>   awsapi/test/com/cloud/gate/util/CloudStackClientTestCase.java 826cb3a 
>   awsapi/test/com/cloud/gate/util/JsonAccessorTestCase.java 8603e59 
>   awsapi/test/com/cloud/gate/util/JsonElementUtilTestCase.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/21776/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dmitry Batkovich
> 
>

Re: [GSOC] End of term update

[Darren Brogan]

> @Darren, github still shows pypi package at 0.1.0

Ah, this is down to caching, it'll update itself very shortly.

> Would be nice to have a little read me on how to add an API

Ah yes, I'm planning to move the configuration / setup out of README and
into a "User Guide" section of the wiki. When I'm migrating that over I can
create a "Developer Guide" section with testing / extension guides.

> Would be nice to have a little read me on how to use something like
gunicorn to run the app as a linux service.

I''ll take a look into this, should be fine, again this can be added into
wiki :)

> Otherwise, I tested for basic zones and it works just fine.

Great to hear, thanks.

Darren


On Tue, Jun 24, 2014 at 8:13 PM, sebgoa  wrote:

>
> On Jun 24, 2014, at 9:05 PM, Darren Brogan 
> wrote:
>
> > Apologies, send that prematurely.
> >
> > Anyway getting back to it, an example of profile usage:
> >
> > $ gstack-configure -p exampleprofile
> >
> > $ gstack -p exampleprofile
> >
> > Along with that the user now has the ability to debug the app with the
> '-d'
> > / '--debug' flags when running the application.
> >
> > $ gstack -d True
> >
> > Version 1.0.0 of gstack was released today. You can download / upgrade
> > using pip. https://pypi.python.org/pypi/gstack
> >
> > The first term was a lot of fun and I made a good bit of progress with
> > gstack. Ec2stack is next.
> >
> > If you have any feedback or advice I'd be glad to hear it.
> >
> > Thanks,
> > Darren
>
> Thanks Darren,
>
> Good work,
>
> For those that did not follow. gstack is a python flask application that
> provides a GCE compliant interface. It forwards requests to cloudstack api
> server.
>
> It's all on github:
>
> https://github.com/NOPping/gstack
>
> It's not clear to me yet, if we need this under cloudstack ASF repos.
> @anyone thoughts ?
>
> The app is automatically build tested on Travis, with unit test coverage
> published on coveralls. the app is available through pypi.
>
> @Darren, github still shows pypi package at 0.1.0.
>
> Two small things:
>
> -Would be nice to have a little read me on how to add an API
>
> -Would be nice to have a little read me on how to use something like
> gunicorn to run the app as a linux service.
>
> Otherwise, I tested for basic zones and it works just fine.
>
> Good work,
>
> >
> >
> > On Tue, Jun 24, 2014 at 7:56 PM, Darren Brogan <
> brogan...@darrenbrogan.ie>
> > wrote:
> >
> >> Hi guys,
> >>
> >> Since my last email I've done quite a bit of work on gstack. I added
> >> uniitests to make future changes easier. The coverage is at 95%
> currently.
> >> I added gstack to coveralls to keep track of test results, you can view
> the
> >> statistics at https://coveralls.io/r/NOPping/gstack
> >>
> >> I refactored quite a bit of code in controllers. My original plan to
> >> achieve this was to use templates but they proved to be troublesome with
> >> json. Instead, I opted to just clean the current implementation and
> extract
> >> repeated code to a common script.
> >>
> >> I added support for configuration profiles. This means you can use
> gstack
> >> against multiple clouds without having to rerun gstack-configure each
> time.
> >> profiles are utilized with the '-p' / '--profile' flags when configuring
> >> and running the application.
> >>
> >> Example:
> >>
> >>
>
>

Re: create_schema.sql

[Rohit Yadav]

Hi Daan and others,

Let me share a way to guard files that interest us by alerting us using the
following shell script git hook:

Put the following your .git/hooks/post-merge (make sure to chmod +x the
following shell script):

# START OF SCRIPT

#/usr/bin/env bash
changed_files="$(git diff-tree -r --name-only --no-commit-id ORIG_HEAD
HEAD)"

check_run() {
echo "$changed_files" | grep --quiet "$1" && eval "$2"
}

check_run .*.sql "say 'Found new delta. Please run it'" # on OSX this will
literary speak out these words, fix as needed

# END OF SCRIPT

Acknowledgement: I did not invent this but reused this from Sindre Sorhus
of sindresorhus.com

Change filenames and regexes as needed. This will run everytime one does a
git pull (not fetch, it runs post merging a remote/local branch to
master/current branch).

Hope this helps.


On Tue, Jun 24, 2014 at 2:48 PM, Daan Hoogland 
wrote:

> including the source release? I don't like:( I do agree that some kind
> of guard would help, though
>
> On Tue, Jun 24, 2014 at 10:57 AM, Prasanna Santhanam 
> wrote:
> > On Tue, Jun 24, 2014 at 10:51:31AM +0200, Daan Hoogland wrote:
> >> It should be included in any release
> >>
> > so packaging can bring it back i thought. just a thought.
> > --
> > Prasanna.,
> >
> > 
> > Powered by BigRock.com
> >
>
>
>
> --
> Daan
>

Re: [GSOC][CLOUDSTACK-6045] Progress Update

[Mike Tutkowski]

Thanks, Seif!

Seif and I have been communicating pretty much on a daily basis with
regards to his GSoC project.

He's new to CloudStack, so there was a lot of startup-related overhead.
Once he got past that, he started to make great progress.

Over the past weekend, he finished coding an enhancement for the Add
Primary Storage dialog to enable admins who use custom storage plug-ins
(ex. from SolidFire, CloudByte, NetApp, etc.) to be able to provide all
necessary configuration details. Prior to this, the admin would have needed
to use CloudMonkey or write a script to call the CloudStack API
(createStoragePool) directly.

I plan to check Seif's code in this week.

Seif is now moving on to building a better way for admins to enter in tags
(storage or host tags, for example). Right now, we expect admins to enter
in a comma-separated list of identifiers, which can be a bit error prone.
Seif and I are thinking it would be nicer if CloudStack had a mechanism
like JIRA does for accepting such values.

If Seif has enough time available toward the end, I'd like to get him some
exposure to the generic key/value pairs that are being investigated for 4.6:

https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=42566111


On Tue, Jun 24, 2014 at 8:55 AM, Seif Eddine Jemli <
seifeddineje...@gmail.com> wrote:

> http://imgur.com/II3r0wK
>
> http://imgur.com/05p8lAG
>
> I didn't know that the mailing list doesn't accept enclosed screenshots.
>
>
> 2014-06-24 16:21 GMT+02:00 Seif Eddine Jemli :
>
> > Hi guys,
> >
> >
> > As you probably know, I am working on this project whose goal is making
> > the GUI support adding primary storage to CS that is based on storage
> > plug-ins
> > (
> >
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Create+GUI+to+add+primary+storage+based+on+plug-ins
> > )
> >
> > After studying the GUI code, I have been able to change the "Add Primary
> > Storage Form" as the storage guys : Mike( my mentor) and Punith wanted
> to.
> > (I enclosed two screenshots).
> >
> > I am currently trying to make the Tags inputs (like Storage tags in the
> > 'add primary storage' form) more user-friendly. This task include
> creating
> > a new API call to get the Tags.
> > I had a hard time at the beginning to set up Cloudstack for development
> > and to understand the GUI code patterns. But I think that progress will
> be
> > much faster now.
> >
> > I am all ears to feedback or suggestions that aim to improve the GUI.
> > Thanks.
> >
>



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
*™*

Re: Adding a distant KVM host

[Mike Tutkowski]

Hey Marcus,

Do you have any thoughts on this?

Thanks!
Mike


On Tue, Jun 24, 2014 at 10:20 AM, Seif Eddine Jemli <
seifeddineje...@gmail.com> wrote:

> Hi,
>
> I am trying to add a distant *KVM* host. I created a *VPN* for this
> purpose.
> I have a management server and a distant host now connected via a VPN (it
> is a point to point VPN). so KVM host has the ip address 10.0.0.1 on the
> ppp0 interface (specific to the VPN) and the MS has the address 10.0.0.100
> on his ppp0 interface too. (point to point VPN).
>
> I didn't know how to configure the /etc/network/interfaces on the KVM host.
> I couldn't try much because any error can make the server inaccessible.
> The problem is that I am not sure if I can put the ppp0 in the
> /etc/network/interfaces, because it is not a physical interface.
> How can I configure the network?
>
> thanks
>



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
*™*

Re: Why to have API Commands for Admin actions?

[Rohit Yadav]

Hi Wilder,


On Tue, Jun 24, 2014 at 5:25 PM, Wilder Rodrigues <
wrodrig...@schubergphilis.com> wrote:

> Hi all,
>
> We are currently working on the redundant VPC implementation. In order to
> take the right steps from the beginning, we started analyzing the existing
> code base, from the API commands into the
> VPCVirtualNetworkAppliancaManagerImpl.
>
> Although it's not related to the feature itself, we found out that the
> current way of using the APICommand annotation and the CreateVPCCmd class
> (and its derived) is not really clear. For example, there are 2 command
> classes to create a VPC. The difference between them is: one has
> ResponseView.Full parameter in the @APICommand (ie. CreateVPCCmdByAdmin);
> and the other has ResponseView.Rstricted parameter in the @APICommand (i.e.
> CreateVPCCmd). Moreover, the call to responseGenerator.createVpcresponde()
> method uses a ResponseView enum according to what has been specified in the
> annotation parameter.
>
> We understand that having a different enum in the
> responseGenerator.createVpcresponde() method will affect many things,
> because it goes deep into the code until reaches the APIDBUtils and the
> database. It is also checked in the ApiServer class, when the command is
> evaluated based on a string passed to the getCmdClass() method.
>

You're right.


> Since we can identify the user in the account manager, also checking the
> kind of access the user has, what is the point in having the Annotation +
> the Enum in the code?


It may sound bit weird, one of the reasons is for developers to know
looking at annotation what the API is supposed to do, it is also used to
sort of group them (though it lacks clarity). There was some refactoring
work to fix it (but it failed to address everything) [1]. IMO I never spend
more time on this, I thought by now (2014) we would have a new api
layer/service :)

Api doc generation and plugin such as ApiDiscovery [2] uses annotations and
enums to map relations (there is for example a way that barely works in
cloudmonkey, the CLI, to auto complete API params using these things but it
does not always work). You


> Keep in mind that the latter is passed several times as parameters to
> other methods, which adds many "ifs" and unnecessary complexity.


> We could also make possible to use the Annotation in the method itself,
> which could avoid having to pass the Enum to the method. That means that
> the Enum would be removed from the annotation and we would use the
> annotation only to identify the API name, response object and entity type.
> In order to check the user's credentials, we would use the checkAccess()
> from the account manager, as it is already being used in the ApiDispatcher
> class.
>

You may do it, but ideally I would want the functionality to stay
refactored in one place, so keep checkAccess and other ACL stuff in
separate pure (ACL) plugins and not mix them in other than ACL plugins.


> I know those are huge changes, if we actually agree in going for anything
> like this in the future. But the Admin commands are not doing much except
> for change the enum which is passed to the create response method. Most of
> the content of the execute() method is a copy/paste from the extended
> Command class.
>

I appreciate you reaching out on this. IMO it will be needed to fix it
everywhere (which will be huge change like you said) and bigger challenge
is to keep the layer backward compatible, test it and what not. But I'll
support anyone taking such a task and contribute to as well.

IMHO we should avoid changing the outside layer(s) too much or often such
as API stuff since these are the layer(s) a lot of people depend on while
building things on top of CloudStack (not necessarily have interests in the
whole ACS codebase) -- this has to do with investment of time/energy by
people to learn/adapt/change and it's more challenging than just the
technical ability to fixing things. As a project we don't want to
disappoint users.

Instead I hope for separating the whole business layers (users, accounts,
api etc.) as distribute services from the core orchestration parts of
CloudStack, the API becomes RESTful (or unRESTful using something like
Thrift) with versioning (which can be done for both RESTful HTTP APIs and
unRESTful Thrift based APIs).

[1]
https://cwiki.apache.org/confluence/display/CLOUDSTACK/CloudStack+API+refactoring
[2]
https://cwiki.apache.org/confluence/display/CLOUDSTACK/API+Discovery+Service

Regards.


>
> Cheers,
> Wilder
>

Re: Custom popup forms w.r.t Plugin Provider

[Mike Tutkowski]

You may also wish to opt for the GUI-plug-in approach because this would
make it easier for you to provide an interface for customers to update a
given storage pool with your custom parameters (otherwise you'll be looking
at customizing the update-related code in the GUI similarly to how you're
looking to customize the create-related code).


On Tue, Jun 24, 2014 at 9:08 AM, Mike Tutkowski <
mike.tutkow...@solidfire.com> wrote:

> Sorry...I mean "Hi Punith" :)
>
>
> On Tue, Jun 24, 2014 at 8:33 AM, Mike Tutkowski <
> mike.tutkow...@solidfire.com> wrote:
>
>> Hi Seif,
>>
>> I wonder if it would make sense for you to deploy this as a custom GUI
>> plug-in. I believe the NetApp guys did something like this for their
>> situation, as well.
>>
>> David La Motta from NetApp might be able to say more (I've included him).
>>
>> Talk to you later,
>> Mike
>>
>>
>> On Tue, Jun 24, 2014 at 1:03 AM, Punith S  wrote:
>>
>>> hi,
>>>
>>> I am in process of adding a new Add Primary Storage (specific to my
>>> Storage plugin) form  whose labels & certain values will be different than
>>> the current Default Provider's Add Primary Storage form.
>>> also looping the GSoC'14
>>>
>>> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Create+GUI+to+add+primary+storage+based+on+plug-ins
>>>
>>> it seems adding more checks and if-else clauses in system.js will make
>>> it more fragile and unmanageable.
>>>
>>> use case:
>>> since each vendor requires to use ui with their own specific params,
>>>
>>> for example with add primary storage:
>>> referring the attachment, popup form will be dynamically changed to have
>>> different params wrt the selected storage providers.
>>>
>>> hence instead of writing the vendor specific code inside
>>> system.js(common file)
>>> is it acceptable to modularize the code to different vendor specific js
>>> files like in writing a third party UI plugin ?
>>> ref -
>>> https://cwiki.apache.org/confluence/display/CLOUDSTACK/UI+Plugin+Tutorial
>>>
>>> thanks
>>> --
>>> regards,
>>>
>>> punith s
>>> cloudbyte.com
>>>
>>
>>
>>
>> --
>> *Mike Tutkowski*
>>  *Senior CloudStack Developer, SolidFire Inc.*
>> e: mike.tutkow...@solidfire.com
>> o: 303.746.7302
>> Advancing the way the world uses the cloud
>> *™*
>>
>
>
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the cloud
> *™*
>



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
*™*

Re: feature : changing volume properties dynamically in 4.5

[Mike Tutkowski]

OK, I've completed work on enabling a storage plug-in to be notified when
the size and/or IOPS of the primary storage that it represents is changed:

https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=c344693e48d80313270d1a972b0a3badf315567d

This is related to the updateStoragePool API.

I plan to switch my focus now to the resizeVolume API so that individual
CloudStack volumes (as opposed to the entire storage pool they are from)
can have not only their size, but their IOPS updated.


On Fri, Jun 20, 2014 at 12:31 AM, Mike Tutkowski <
mike.tutkow...@solidfire.com> wrote:

> I'll define constants for the keys in PrimaryDataStoreLifeCycle.
>
>
> On Friday, June 20, 2014, Mike Tutkowski 
> wrote:
>
>> In fact, we do use a hash-map approach for some KVM storage code, too.
>>
>> Let's do that here, as well.
>>
>> I'll make that change.
>>
>> Thanks
>>
>> On Friday, June 20, 2014, Mike Tutkowski 
>> wrote:
>>
>>> We do - in some places in the code - use a hash map...like what you
>>> describe.
>>>
>>> I guess the trade off there would be that the values that contain our
>>> numbers would end up being high-level objects instead of numbers (because
>>> we don't really know what future values might be).
>>>
>>> I'm OK with either approach.
>>>
>>> On Friday, June 20, 2014, Mike Tutkowski 
>>> wrote:
>>>
 Unfortunately, at the time being, the updateStoragePool API (from the
 public-facing API) only takes in bytes, IOPS, and storage tags...not
 details (createStoragePool takes in a lot more parameters...including
 details).

 So - for now at least - we're a little limited in what the new
 interface method can tell storage providers about (unless we wanted to
 spend time adding to the parameter list of updateStoragePool).

 On Friday, June 20, 2014, Amit Das  wrote:

> Hi Mike,
>
> Is there any use case to have a more generic signature for
> updateStoragePool API ?
>
> e.g
> void updateStoragePool(StoragePool storagePool, Map updateDetails
> );
> // not too sure of what should be E & V as of now. To start with E & V
> can be String types or Enums for better static checks.
>
> instead of below
> void updateCapacity(StoragePool storagePool, Long capacityBytes, Long
>  capacityIops);
>
> ​​
>
> Regards,
> Amit
> *CloudByte Inc.* 
>
>
> On Fri, Jun 20, 2014 at 10:37 AM, Mike Tutkowski <
> mike.tutkow...@solidfire.com> wrote:
>
>> I just wanted to update those who are interested in this thread about
>> work I've done on this over the past couple days.
>>
>> This gist is that I've added a new method to the
>> PrimaryDataStoreLifeCycle interface that has the following signature 
>> (this
>> code is not yet checked in):
>>
>> void updateCapacity(StoragePool storagePool, Long capacityBytes, Long
>> capacityIops);
>>
>> This method can be invoked from StorageManagerImpl when the
>> updateStoragePool API is called.
>>
>> This gives the storage plug-in that backs the primary storage in
>> question an opportunity to update the backend storage it represents, if
>> that makes sense to do in your particular case (for example, changing the
>> size and/or IOPS of a volume).
>>
>> There is a related enhancement to the resizeVolume API that I plan to
>> tackle next week. That one will be particularly useful for managed 
>> storage
>> plug-ins.
>>
>> Also, I have been collecting input on the generic key/value proposal
>> here:
>>
>>
>> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=42566111
>>
>> That may turn into a considerable amount of work. I was initially
>> thinking it could be fit into 4.5, but it might be 4.6.
>>
>> Thanks for any feedback!
>>
>>
>> On Thu, Jun 12, 2014 at 11:09 PM, Mike Tutkowski <
>> mike.tutkow...@solidfire.com> wrote:
>>
>>> As I think about this more, there are two situations we should cover:
>>>
>>> 1) Non-managed storage that has control over IOPS.
>>>
>>> When you invoke the createStoragePool API, you can pass in
>>> capacityIops.
>>>
>>> We should support modifying capacityIops via the updateStoragePool
>>> API.
>>>
>>> 2) Managed storage that has control over IOPS.
>>>
>>> In this environment, there is a 1:1 mapping between a SAN volume and
>>> a CloudStack volume.
>>>
>>> This is where we need to augment the resizeVolume API to accept - in
>>> a similar fashion to size - a new value for Min and/or Max IOPS.
>>>
>>> For example, a resizeVolume can be initiated by simply selecting a
>>> new Disk Offering.
>>>
>>> In this situation, the size and IOPS are part of the new Disk
>>> Offering (i.e. neither size nor IOPS can be marked as custom) and when 
>>> 

Re: Review Request 22631: supporting nfs protocol and resize feature for managed storage in xenserver.

[Mike Tutkowski]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22631/#review46580
---

Ship it!


I checked this code in under 4d6c682f18d9bca50c145b55d8fa61ea1ab71755. Please 
verify that it is as you expected it to be. Thanks!

I also checked in 3d9eaf07537aa7ef5da291912c308ea7dc08df81 to correct some 
formatting issues in 4d6c682f18d9bca50c145b55d8fa61ea1ab71755.

- Mike Tutkowski


On June 17, 2014, 9:28 a.m., punith s wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22631/
> ---
> 
> (Updated June 17, 2014, 9:28 a.m.)
> 
> 
> Review request for cloudstack, amit kumar das, edison su, and Mike Tutkowski.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> currently managed storage only supports iscsi protocol.
> 
> hence now adding support for nfs protocol and also resizing the vdi to the SR 
> size, hence fully utilizing the SR space in managed storage.
> 
> to support nfs, the getNfsSR method's signature has to changed similar to 
> existing getIscsiSR method.
> 
> SR will be created based on the volume's protocoltype.
> 
> jira id - CLOUDSTACK-6916
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/agent/api/to/DiskTO.java 5901367 
>   
> engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java
>  eea931e 
>   
> plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
>  9979802 
>   server/src/com/cloud/storage/VolumeApiServiceImpl.java 9b034e9 
> 
> Diff: https://reviews.apache.org/r/22631/diff/
> 
> 
> Testing
> ---
> 
> system testing done.
> 
> 
> Thanks,
> 
> punith s
> 
>

RE: Why to have API Commands for Admin actions?

[Prachi Damle]

To elaborate further, I would like to add that even if this is adding some 
if-else code around checking the enum value when generating the response, it is 
replacing several other if-else's that were present in the code earlier that 
used to check if the user is an Admin/Domain Admin/regular user against the Db.

With IAM, we cannot have such if-else conditions around hardcoded roles. The 
design should work with custom roles and custom 'response views' allocated to 
the user.
This change is a first step in achieving this.

Prachi

-Original Message-
From: Min Chen [mailto:min.c...@citrix.com] 
Sent: Tuesday, June 24, 2014 10:04 AM
To: dev@cloudstack.apache.org
Cc: int-toolkit
Subject: Re: Why to have API Commands for Admin actions?

Hi Wilder,

This is a recent change introduced by IAM feature, see FS here 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/CloudStack+Identity+
and+Access+Management+%28IAM%29+Plugin, particularly see details in
Response View section. The intention of this is to eventually provide custom 
response view for different custom IAM roles. As the first step, we only 
provided two static response view: Full and Restricted, and just map Full view 
to current admin commands. In the future, we should allow admin to define 
custom response view through column filter, and associate each custom response 
view with IAM policy. Hope that this can give you some context on this part of 
code.

Thanks.
-min

On 6/24/14 4:55 AM, "Wilder Rodrigues" 
wrote:

>Hi all,
>
>We are currently working on the redundant VPC implementation. In order 
>to take the right steps from the beginning, we started analyzing the 
>existing code base, from the API commands into the 
>VPCVirtualNetworkAppliancaManagerImpl.
>
>Although it's not related to the feature itself, we found out that the 
>current way of using the APICommand annotation and the CreateVPCCmd 
>class (and its derived) is not really clear. For example, there are 2 
>command classes to create a VPC. The difference between them is: one 
>has ResponseView.Full parameter in the @APICommand (ie. 
>CreateVPCCmdByAdmin); and the other has ResponseView.Rstricted 
>parameter in the @APICommand (i.e. CreateVPCCmd). Moreover, the call to
>responseGenerator.createVpcresponde() method uses a ResponseView enum 
>according to what has been specified in the annotation parameter.
>
>We understand that having a different enum in the
>responseGenerator.createVpcresponde() method will affect many things, 
>because it goes deep into the code until reaches the APIDBUtils and the 
>database. It is also checked in the ApiServer class, when the command 
>is evaluated based on a string passed to the getCmdClass() method.
>
>Since we can identify the user in the account manager, also checking 
>the kind of access the user has, what is the point in having the 
>Annotation + the Enum in the code? Keep in mind that the latter is 
>passed several times as parameters to other methods, which adds many 
>"ifs" and unnecessary complexity.
>
>We could also make possible to use the Annotation in the method itself, 
>which could avoid having to pass the Enum to the method. That means 
>that the Enum would be removed from the annotation and we would use the 
>annotation only to identify the API name, response object and entity 
>type. In order to check the user's credentials, we would use the
>checkAccess() from the account manager, as it is already being used in 
>the ApiDispatcher class.
>
>I know those are huge changes, if we actually agree in going for 
>anything like this in the future. But the Admin commands are not doing 
>much except for change the enum which is passed to the create response 
>method. Most of the content of the execute() method is a copy/paste 
>from the extended Command class.
>
>Just trying to start some chat towards the subject.
>
>Thanks for your time.
>
>Cheers,
>Wilder

Re: Review Request 21776: AWSAPI: cloudstack api on POST requests (instead GET), ssl enabling fixed

[Demetrius Tsitrelis]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21776/#review46589
---


The only change I can see regarding "SSL enabling" is to the getProperty() 
method for the default value.  It looks like that change to null wouldn't 
matter as the constructor for CloudStackApi() would just reassign 8080?

- Demetrius Tsitrelis


On May 27, 2014, 8:04 p.m., Dmitry Batkovich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21776/
> ---
> 
> (Updated May 27, 2014, 8:04 p.m.)
> 
> 
> Review request for cloudstack, Chiradeep Vittal, daan Hoogland, and Prachi 
> Damle.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> * CloudStackClient.java http request mechanism replaced from GET requests to 
> POST for supporting EC2 requests larger than 2KB
> * SSL enabling fixed in EC2Engine.java
> 
> continuation of https://reviews.apache.org/r/17586/
> 
> 
> Diffs
> -
> 
>   awsapi/conf/ec2-service.properties.in 82f5ad8 
>   awsapi/src/com/cloud/bridge/service/core/ec2/EC2Engine.java cd20214 
>   awsapi/src/com/cloud/bridge/util/JsonAccessor.java 2a94dea 
>   awsapi/src/com/cloud/bridge/util/JsonElementUtil.java PRE-CREATION 
>   awsapi/src/com/cloud/stack/CloudStackApi.java b7a1210 
>   awsapi/src/com/cloud/stack/CloudStackClient.java 03eba96 
>   awsapi/src/com/cloud/stack/CloudStackClientException.java PRE-CREATION 
>   awsapi/src/com/cloud/stack/CloudStackCommand.java 8d6aa68 
>   awsapi/src/com/cloud/stack/CloudStackQueryBuilder.java PRE-CREATION 
>   awsapi/test/com/cloud/gate/util/CloudStackClientTestCase.java 826cb3a 
>   awsapi/test/com/cloud/gate/util/JsonAccessorTestCase.java 8603e59 
>   awsapi/test/com/cloud/gate/util/JsonElementUtilTestCase.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/21776/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dmitry Batkovich
> 
>

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

[Alena Prokharchyk]

Moving the discussion to the mailing list as it doesn’t have to be private. 
Kishan/Murali, can you please follow up on the remaining review for 
https://reviews.apache.org/r/20099/ (see my last comment and the discussion 
below)

Basically what Alex wants to do is – pass the originated region to 
create/update/deleteAccount commands. And the question is – what type this 
parameter should have (see details below)

Thanks,
Alena.

From: Alena Prokharchyk 
mailto:alena.prokharc...@citrix.com>>
Date: Tuesday, June 24, 2014 at 3:06 PM
To: Alex Ough mailto:alex.o...@sungardas.com>>, Kishan 
Kavala mailto:kishan.kav...@citrix.com>>, Murali 
Reddy mailto:murali.re...@citrix.com>>
Cc: Animesh Chaturvedi 
mailto:animesh.chaturv...@citrix.com>>, Ram 
Ganesh mailto:ram.gan...@citrix.com>>
Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple 
Regions (Core Changes)

Adding Kishan to the thread as he was the one who implemented the region 
feature originally.

Kishan, in a situation when there are 2 regions in the system, we expect 
“region” table to be populated with the same id/name in both Dbs for both 
regions, right? So my question is – what uniquely identifies the region in CS 
system in cross region setup – id/name?

That unique identifier should be the value that is passed to the calls you 
modify, Alex. WE can’t just pass some random name to the call without making 
any further verification.

Kishan/Murali, please help to verify this part of Alex’s fix as it should 
really be someone with an expertise in Regions. I’ve reviewed the rest of the 
feature, just this one item is open. See my latest comment to the 
https://reviews.apache.org/r/17790/diff/?page=1#0 as well as refer to this 
email thread for the context.

-Alena.

From: Alena Prokharchyk 
mailto:alena.prokharc...@citrix.com>>
Date: Tuesday, June 24, 2014 at 2:54 PM
To: Alex Ough mailto:alex.o...@sungardas.com>>
Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple 
Regions (Core Changes)

That what would everybody assume 100% just by looking at the parameter 
description and parameter – that you refer to region UUID : "Region where this 
account is created.”/ORIGINATEDREGIONUUID
In CS the UUID has a special meaning. It has to have the UUID format, and its 
randomly generated value that is stored in the DB along with the actual db id. 
I can see that regionVO lacks UUID field. Looks like existing RegionVO object 
lacks this filed unlike other CS objects (uservm, etc). I will follow up with 
Murali on that.

Alex, so originatedRegionUUID refers to the region name, correct?. Why don’t 
use the region id instead? That’s what we do when refer to CS objects – we 
always refer to them by id which is unique. Which is true even for the region:

mysql> show create table region;

 UNIQUE KEY `id` (`id`),
  UNIQUE KEY `name` (`name`)


That’s what you do when you manipulate the region itself (delete/updateRegion) 
- refer to the region by its id. And this field is returned to you when you 
call listRegions API:

http://localhost:8096/?command=listRegions

1
Local
http://localhost:8080/client/
true
false



Please correct if I miss something.
-Alena.

From: Alex Ough mailto:alex.o...@sungardas.com>>
Date: Tuesday, June 24, 2014 at 2:33 PM
To: Alena Prokharchyk 
mailto:alena.prokharc...@citrix.com>>
Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple 
Regions (Core Changes)

Thanks for the clarification, but here is a thing.

I'm passing names as the values of originatedRegionUuids because the uuids are 
randomly generated and the same regions do NOT have the same uuidss.
So I'd like to change the parameter types into String.
Let me know if you think otherwise.

Thanks
Alex Ough


On Tue, Jun 24, 2014 at 5:17 PM, Alena Prokharchyk 
mailto:alena.prokharc...@citrix.com>> wrote:
Alex,

take a look at ParamProcessWorker class, and how API parameters are being 
dispatched/verified.


1)  public void processParameters(final BaseCmd cmd, final Map params) method

First of all, EntityType parameter should be defined in the @Parameter 
annotation for the originatedRegionID field. This parameter is used by 
paramProcessWorker to make "if entity exists" validation


2) Check another method in the same class:

private void setFieldValue(final Field field, final BaseCmd cmdObj, final 
Object paramObj, final Parameter annotation) throws IllegalArgumentException, 
ParseException {

Thats the method responsible for dispatching/setting the field values. Here is 
the snippet of the code for the case when UUID is defined:

 case UUID:
if (paramObj.toString().isEmpty())
break;
final Long internalId = 
translateUuidToInternalId(paramObj.toString(), annotation);
field.set(cmdObj, internalId);
break;

it always transforms the UUID to Long id, not string. And at the end, it will 
be internal DB UUID, not the UUID

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

[Alex Ough]

All,

There is one open question in this topic, which is to figure out which
value is appropriate to pass the region object, id or name?
During this implementation, we decided to add the information of regions
where user/account/domain objects have been originally
created/modified/removed.
But the ids of regions are not same across the regions and currently the
regions do not have uuids(they will not be same either if we add them to
regions), so I'd like to use names.

Please let me know what you think.
Thanks
Alex Ough


On Tue, Jun 24, 2014 at 7:05 PM, Animesh Chaturvedi <
animesh.chaturv...@citrix.com> wrote:

>  Let’s have the discussion on dev mailing list
>
>
>
> Thanks
>
> Animesh
>
>
>
> *From:* Alena Prokharchyk
> *Sent:* Tuesday, June 24, 2014 3:06 PM
> *To:* Alex Ough; Kishan Kavala; Murali Reddy
> *Cc:* Animesh Chaturvedi; Ram Ganesh
>
> *Subject:* Re: Review Request 20099: Domain-Account-User Sync Up Among
> Multiple Regions (Core Changes)
>
>
>
> Adding Kishan to the thread as he was the one who implemented the region
> feature originally.
>
>
>
> Kishan, in a situation when there are 2 regions in the system, we expect
> “region” table to be populated with the same id/name in both Dbs for both
> regions, right? So my question is – what uniquely identifies the region in
> CS system in cross region setup – id/name?
>
>
>
> That unique identifier should be the value that is passed to the calls you
> modify, Alex. WE can’t just pass some random name to the call without
> making any further verification.
>
>
>
> Kishan/Murali, please help to verify this part of Alex’s fix as it should
> really be someone with an expertise in Regions. I’ve reviewed the rest of
> the feature, just this one item is open. See my latest comment to the
> https://reviews.apache.org/r/17790/diff/?page=1#0 as well as refer to
> this email thread for the context.
>
>
>
> -Alena.
>
>
>
> *From: *Alena Prokharchyk 
> *Date: *Tuesday, June 24, 2014 at 2:54 PM
> *To: *Alex Ough 
> *Subject: *Re: Review Request 20099: Domain-Account-User Sync Up Among
> Multiple Regions (Core Changes)
>
>
>
> That what would everybody assume 100% just by looking at the parameter
> description and parameter – that you refer to region UUID : "Region where
> this account is created.”/ORIGINATEDREGIONUUID
>
> In CS the UUID has a special meaning. It has to have the UUID format, and
> its randomly generated value that is stored in the DB along with the actual
> db id. I can see that regionVO lacks UUID field. Looks like existing
> RegionVO object lacks this filed unlike other CS objects (uservm, etc). I
> will follow up with Murali on that.
>
>
>
> Alex, so originatedRegionUUID refers to the region name, correct?. Why
> don’t use the region id instead? That’s what we do when refer to CS objects
> – we always refer to them by id which is unique. Which is true even for the
> region:
>
>
>
> mysql> show create table region;
>
>
>
>  UNIQUE KEY `id` (`id`),
>
>   UNIQUE KEY `name` (`name`)
>
>
>
>
>
> That’s what you do when you manipulate the region itself
> (delete/updateRegion) - refer to the region by its id. And this field is
> returned to you when you call listRegions API:
>
>
>
> http://localhost:8096/?command=listRegions
>
> 
>
> 1
>
> Local
>
> http://localhost:8080/client/
>
> true
>
> false
>
> 
>
>
>
>
>
> Please correct if I miss something.
>
> -Alena.
>
>
>
> *From: *Alex Ough 
> *Date: *Tuesday, June 24, 2014 at 2:33 PM
> *To: *Alena Prokharchyk 
> *Subject: *Re: Review Request 20099: Domain-Account-User Sync Up Among
> Multiple Regions (Core Changes)
>
>
>
> Thanks for the clarification, but here is a thing.
>
>
>
> I'm passing names as the values of originatedRegionUuids because the uuids
> are randomly generated and the same regions do NOT have the same uuidss.
>
> So I'd like to change the parameter types into String.
>
> Let me know if you think otherwise.
>
>
>
> Thanks
>
> Alex Ough
>
>
>
> On Tue, Jun 24, 2014 at 5:17 PM, Alena Prokharchyk <
> alena.prokharc...@citrix.com> wrote:
>
>   Alex,
>
>
>
> take a look at ParamProcessWorker class, and how API parameters are being
> dispatched/verified.
>
>
>
>
>
> 1)  public void processParameters(final BaseCmd cmd, final Map params)
> method
>
>
>
> First of all, EntityType parameter should be defined in the @Parameter
> annotation for the originatedRegionID field. This parameter is used by
> paramProcessWorker to make "if entity exists" validation
>
>
>
>
>
> 2) Check another method in the same class:
>
>
>
> private void setFieldValue(final Field field, final BaseCmd cmdObj, final
> Object paramObj, final Parameter annotation) throws
> IllegalArgumentException, ParseException {
>
>
>
> Thats the method responsible for dispatching/setting the field values.
> Here is the snippet of the code for the case when UUID is defined:
>
>
>
>  case UUID:
>
> if (paramObj.toString().isEmpty())
>
> break;
>
> final Long internalId =
> tr

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

[Alena Prokharchyk]

Alex, thank you for summarizing.

 I still don’t see why id can’t be unique across regions as you can control the 
id assignment – id is required when createRegion call is made. And that’s how 
the region should be represented in other region’s Dbs – by its id that is 
unique across the regions. Kishan/Murali, please confirm.

Thank you,
Alena.

From: Alex Ough mailto:alex.o...@sungardas.com>>
Date: Tuesday, June 24, 2014 at 4:22 PM
To: "dev@cloudstack.apache.org" 
mailto:dev@cloudstack.apache.org>>
Cc: Alena Prokharchyk 
mailto:alena.prokharc...@citrix.com>>, Kishan 
Kavala mailto:kishan.kav...@citrix.com>>, Murali 
Reddy mailto:murali.re...@citrix.com>>, Ram Ganesh 
mailto:ram.gan...@citrix.com>>, Animesh Chaturvedi 
mailto:animesh.chaturv...@citrix.com>>
Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple 
Regions (Core Changes)

All,

There is one open question in this topic, which is to figure out which value is 
appropriate to pass the region object, id or name?
During this implementation, we decided to add the information of regions where 
user/account/domain objects have been originally created/modified/removed.
But the ids of regions are not same across the regions and currently the 
regions do not have uuids(they will not be same either if we add them to 
regions), so I'd like to use names.

Please let me know what you think.
Thanks
Alex Ough


On Tue, Jun 24, 2014 at 7:05 PM, Animesh Chaturvedi 
mailto:animesh.chaturv...@citrix.com>> wrote:
Let’s have the discussion on dev mailing list

Thanks
Animesh

From: Alena Prokharchyk
Sent: Tuesday, June 24, 2014 3:06 PM
To: Alex Ough; Kishan Kavala; Murali Reddy
Cc: Animesh Chaturvedi; Ram Ganesh

Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple 
Regions (Core Changes)

Adding Kishan to the thread as he was the one who implemented the region 
feature originally.

Kishan, in a situation when there are 2 regions in the system, we expect 
“region” table to be populated with the same id/name in both Dbs for both 
regions, right? So my question is – what uniquely identifies the region in CS 
system in cross region setup – id/name?

That unique identifier should be the value that is passed to the calls you 
modify, Alex. WE can’t just pass some random name to the call without making 
any further verification.

Kishan/Murali, please help to verify this part of Alex’s fix as it should 
really be someone with an expertise in Regions. I’ve reviewed the rest of the 
feature, just this one item is open. See my latest comment to the 
https://reviews.apache.org/r/17790/diff/?page=1#0 as well as refer to this 
email thread for the context.

-Alena.

From: Alena Prokharchyk 
mailto:alena.prokharc...@citrix.com>>
Date: Tuesday, June 24, 2014 at 2:54 PM
To: Alex Ough mailto:alex.o...@sungardas.com>>
Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple 
Regions (Core Changes)

That what would everybody assume 100% just by looking at the parameter 
description and parameter – that you refer to region UUID : "Region where this 
account is created.”/ORIGINATEDREGIONUUID
In CS the UUID has a special meaning. It has to have the UUID format, and its 
randomly generated value that is stored in the DB along with the actual db id. 
I can see that regionVO lacks UUID field. Looks like existing RegionVO object 
lacks this filed unlike other CS objects (uservm, etc). I will follow up with 
Murali on that.

Alex, so originatedRegionUUID refers to the region name, correct?. Why don’t 
use the region id instead? That’s what we do when refer to CS objects – we 
always refer to them by id which is unique. Which is true even for the region:

mysql> show create table region;

 UNIQUE KEY `id` (`id`),
  UNIQUE KEY `name` (`name`)


That’s what you do when you manipulate the region itself (delete/updateRegion) 
- refer to the region by its id. And this field is returned to you when you 
call listRegions API:

http://localhost:8096/?command=listRegions

1
Local
http://localhost:8080/client/
true
false



Please correct if I miss something.
-Alena.

From: Alex Ough mailto:alex.o...@sungardas.com>>
Date: Tuesday, June 24, 2014 at 2:33 PM
To: Alena Prokharchyk 
mailto:alena.prokharc...@citrix.com>>
Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple 
Regions (Core Changes)

Thanks for the clarification, but here is a thing.

I'm passing names as the values of originatedRegionUuids because the uuids are 
randomly generated and the same regions do NOT have the same uuidss.
So I'd like to change the parameter types into String.
Let me know if you think otherwise.

Thanks
Alex Ough

On Tue, Jun 24, 2014 at 5:17 PM, Alena Prokharchyk 
mailto:alena.prokharc...@citrix.com>> wrote:
Alex,

take a look at ParamProcessWorker class, and how API parameters are being 
dispatched/verified.


1)  public void processParameters(final BaseCmd cmd, final Map params) method

Firs

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

[Alex Ough]

What I'm trying to say is that when we pass the ids of regions, the
receivers do not know what the originated region is and the id of each
region is not same across all the regions.

Thanks
Alex Ough


On Tue, Jun 24, 2014 at 7:35 PM, Alena Prokharchyk <
alena.prokharc...@citrix.com> wrote:

>  Alex, thank you for summarizing.
>
>   I still don’t see why id can’t be unique across regions as you can
> control the id assignment – id is required when createRegion call is made.
> And that’s how the region should be represented in other region’s Dbs – by
> its id that is unique across the regions. Kishan/Murali, please confirm.
>
>  Thank you,
> Alena.
>
>   From: Alex Ough 
> Date: Tuesday, June 24, 2014 at 4:22 PM
> To: "dev@cloudstack.apache.org" 
> Cc: Alena Prokharchyk , Kishan Kavala <
> kishan.kav...@citrix.com>, Murali Reddy , Ram
> Ganesh , Animesh Chaturvedi <
> animesh.chaturv...@citrix.com>
>
> Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among
> Multiple Regions (Core Changes)
>
>   All,
>
>  There is one open question in this topic, which is to figure out which
> value is appropriate to pass the region object, id or name?
> During this implementation, we decided to add the information of regions
> where user/account/domain objects have been originally
> created/modified/removed.
> But the ids of regions are not same across the regions and currently the
> regions do not have uuids(they will not be same either if we add them to
> regions), so I'd like to use names.
>
>  Please let me know what you think.
> Thanks
> Alex Ough
>
>
> On Tue, Jun 24, 2014 at 7:05 PM, Animesh Chaturvedi <
> animesh.chaturv...@citrix.com> wrote:
>
>>  Let’s have the discussion on dev mailing list
>>
>>
>>
>> Thanks
>>
>> Animesh
>>
>>
>>
>> *From:* Alena Prokharchyk
>> *Sent:* Tuesday, June 24, 2014 3:06 PM
>> *To:* Alex Ough; Kishan Kavala; Murali Reddy
>> *Cc:* Animesh Chaturvedi; Ram Ganesh
>>
>> *Subject:* Re: Review Request 20099: Domain-Account-User Sync Up Among
>> Multiple Regions (Core Changes)
>>
>>
>>
>> Adding Kishan to the thread as he was the one who implemented the region
>> feature originally.
>>
>>
>>
>> Kishan, in a situation when there are 2 regions in the system, we expect
>> “region” table to be populated with the same id/name in both Dbs for both
>> regions, right? So my question is – what uniquely identifies the region in
>> CS system in cross region setup – id/name?
>>
>>
>>
>> That unique identifier should be the value that is passed to the calls
>> you modify, Alex. WE can’t just pass some random name to the call without
>> making any further verification.
>>
>>
>>
>> Kishan/Murali, please help to verify this part of Alex’s fix as it should
>> really be someone with an expertise in Regions. I’ve reviewed the rest of
>> the feature, just this one item is open. See my latest comment to the
>> https://reviews.apache.org/r/17790/diff/?page=1#0 as well as refer to
>> this email thread for the context.
>>
>>
>>
>> -Alena.
>>
>>
>>
>> *From: *Alena Prokharchyk 
>> *Date: *Tuesday, June 24, 2014 at 2:54 PM
>> *To: *Alex Ough 
>> *Subject: *Re: Review Request 20099: Domain-Account-User Sync Up Among
>> Multiple Regions (Core Changes)
>>
>>
>>
>> That what would everybody assume 100% just by looking at the parameter
>> description and parameter – that you refer to region UUID : "Region where
>> this account is created.”/ORIGINATEDREGIONUUID
>>
>> In CS the UUID has a special meaning. It has to have the UUID format, and
>> its randomly generated value that is stored in the DB along with the actual
>> db id. I can see that regionVO lacks UUID field. Looks like existing
>> RegionVO object lacks this filed unlike other CS objects (uservm, etc). I
>> will follow up with Murali on that.
>>
>>
>>
>> Alex, so originatedRegionUUID refers to the region name, correct?. Why
>> don’t use the region id instead? That’s what we do when refer to CS objects
>> – we always refer to them by id which is unique. Which is true even for the
>> region:
>>
>>
>>
>> mysql> show create table region;
>>
>>
>>
>>  UNIQUE KEY `id` (`id`),
>>
>>   UNIQUE KEY `name` (`name`)
>>
>>
>>
>>
>>
>> That’s what you do when you manipulate the region itself
>> (delete/updateRegion) - refer to the region by its id. And this field is
>> returned to you when you call listRegions API:
>>
>>
>>
>> http://localhost:8096/?command=listRegions
>>
>> 
>>
>> 1
>>
>> Local
>>
>> http://localhost:8080/client/
>>
>> true
>>
>> false
>>
>> 
>>
>>
>>
>>
>>
>> Please correct if I miss something.
>>
>> -Alena.
>>
>>
>>
>> *From: *Alex Ough 
>> *Date: *Tuesday, June 24, 2014 at 2:33 PM
>> *To: *Alena Prokharchyk 
>> *Subject: *Re: Review Request 20099: Domain-Account-User Sync Up Among
>> Multiple Regions (Core Changes)
>>
>>
>>
>> Thanks for the clarification, but here is a thing.
>>
>>
>>
>> I'm passing names as the values of originatedRegionUuids because the
>> uuids are randomly generated and the same regions do NOT have the same
>> uuidss.
>>

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

[Alena Prokharchyk]

Aren’t we supposed to sync the regions across the multiple regions Dbs? Because 
that’s what region FS states:

https://cwiki.apache.org/confluence/display/CLOUDSTACK/AWS-Style+Regions+Functional+Spec,
 “Adding 2nd region” paragraph, bullet #4:


1. Install a 2nd CS instance.

2. While installing database set region_id using -r option in 
cloud-setup-databases script (Make sure database_key is same across all 
regions).

cloud-setup-databases cloud:@localhost --deploy-as=root: 
-e  -m  -k  -r 

3. Start mgmt server

4. Using addRegion API, add region 1 to region 2 and also region 2 to region 1.


I assume that we expect the admin to add the region with the same name and the 
same id to ALL regions Dbs (both id and name should be passed to createRegion 
call). So they are all in sync. Isn’t it the requirement? If so, we should rely 
on the fact that all regions Dbs will have the same set of regions having the 
same ids and names cross regions.


Thanks,

Alena.

From: Alex Ough mailto:alex.o...@sungardas.com>>
Date: Tuesday, June 24, 2014 at 5:17 PM
To: Alena Prokharchyk 
mailto:alena.prokharc...@citrix.com>>
Cc: "dev@cloudstack.apache.org" 
mailto:dev@cloudstack.apache.org>>, Kishan Kavala 
mailto:kishan.kav...@citrix.com>>, Murali Reddy 
mailto:murali.re...@citrix.com>>, Ram Ganesh 
mailto:ram.gan...@citrix.com>>, Animesh Chaturvedi 
mailto:animesh.chaturv...@citrix.com>>
Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple 
Regions (Core Changes)

What I'm trying to say is that when we pass the ids of regions, the receivers 
do not know what the originated region is and the id of each region is not same 
across all the regions.

Thanks
Alex Ough


On Tue, Jun 24, 2014 at 7:35 PM, Alena Prokharchyk 
mailto:alena.prokharc...@citrix.com>> wrote:
Alex, thank you for summarizing.

 I still don’t see why id can’t be unique across regions as you can control the 
id assignment – id is required when createRegion call is made. And that’s how 
the region should be represented in other region’s Dbs – by its id that is 
unique across the regions. Kishan/Murali, please confirm.

Thank you,
Alena.

From: Alex Ough mailto:alex.o...@sungardas.com>>
Date: Tuesday, June 24, 2014 at 4:22 PM
To: "dev@cloudstack.apache.org" 
mailto:dev@cloudstack.apache.org>>
Cc: Alena Prokharchyk 
mailto:alena.prokharc...@citrix.com>>, Kishan 
Kavala mailto:kishan.kav...@citrix.com>>, Murali 
Reddy mailto:murali.re...@citrix.com>>, Ram Ganesh 
mailto:ram.gan...@citrix.com>>, Animesh Chaturvedi 
mailto:animesh.chaturv...@citrix.com>>

Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple 
Regions (Core Changes)

All,

There is one open question in this topic, which is to figure out which value is 
appropriate to pass the region object, id or name?
During this implementation, we decided to add the information of regions where 
user/account/domain objects have been originally created/modified/removed.
But the ids of regions are not same across the regions and currently the 
regions do not have uuids(they will not be same either if we add them to 
regions), so I'd like to use names.

Please let me know what you think.
Thanks
Alex Ough


On Tue, Jun 24, 2014 at 7:05 PM, Animesh Chaturvedi 
mailto:animesh.chaturv...@citrix.com>> wrote:
Let’s have the discussion on dev mailing list

Thanks
Animesh

From: Alena Prokharchyk
Sent: Tuesday, June 24, 2014 3:06 PM
To: Alex Ough; Kishan Kavala; Murali Reddy
Cc: Animesh Chaturvedi; Ram Ganesh

Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple 
Regions (Core Changes)

Adding Kishan to the thread as he was the one who implemented the region 
feature originally.

Kishan, in a situation when there are 2 regions in the system, we expect 
“region” table to be populated with the same id/name in both Dbs for both 
regions, right? So my question is – what uniquely identifies the region in CS 
system in cross region setup – id/name?

That unique identifier should be the value that is passed to the calls you 
modify, Alex. WE can’t just pass some random name to the call without making 
any further verification.

Kishan/Murali, please help to verify this part of Alex’s fix as it should 
really be someone with an expertise in Regions. I’ve reviewed the rest of the 
feature, just this one item is open. See my latest comment to the 
https://reviews.apache.org/r/17790/diff/?page=1#0 as well as refer to this 
email thread for the context.

-Alena.

From: Alena Prokharchyk 
mailto:alena.prokharc...@citrix.com>>
Date: Tuesday, June 24, 2014 at 2:54 PM
To: Alex Ough mailto:alex.o...@sungardas.com>>
Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple 
Regions (Core Changes)

That what would everybody assume 100% just by looking at the parameter 
description and parameter – that you refer to region UUID : "Region where this 
account is created.”/ORIGINATEDREGI

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

[Alex Ough]

We can use the same ids & names, but we don't have to use the same ids if
we use names, which is a little easier because names are user readable but
ids are not, so we don't need to memorize/check all the ids when we add new
regions in multiple regions, which can be confusing.

Thanks
Alex Ough


On Tue, Jun 24, 2014 at 8:33 PM, Alena Prokharchyk <
alena.prokharc...@citrix.com> wrote:

>  Aren’t we supposed to sync the regions across the multiple regions Dbs?
> Because that’s what region FS states:
>
>
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/AWS-Style+Regions+Functional+Spec,
> “Adding 2nd region” paragraph, bullet #4:
>
>   1. Install a 2nd CS instance.
>
> 2. While installing database set region_id using -r option in
> cloud-setup-databases script (Make sure *database_key* is same across all
> regions).
>
> *cloud-setup-databases cloud:**<**dbpassword**>**@localhost
> --deploy-as=root:**<**password**>** -e **<**encryption_type**>** -m **<*
> *management_server_key**>** -k **<**database_key**> **-r *
>
> 3. Start mgmt server
>
> 4. *Using addRegion API, add region 1 to region 2 and also region 2 to
> region 1.*
>
>
>  I assume that we expect the admin to add the region with the same name
> and the same id to ALL regions Dbs (both id and name should be passed to
> createRegion call). So they are all in sync. Isn’t it the requirement? If
> so, we should rely on the fact that all regions Dbs will have the same set
> of regions having the same ids and names cross regions.
>
>
>  Thanks,
>
> Alena.
>   From: Alex Ough 
> Date: Tuesday, June 24, 2014 at 5:17 PM
> To: Alena Prokharchyk 
> Cc: "dev@cloudstack.apache.org" , Kishan
> Kavala , Murali Reddy ,
> Ram Ganesh , Animesh Chaturvedi <
> animesh.chaturv...@citrix.com>
>
> Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among
> Multiple Regions (Core Changes)
>
>   What I'm trying to say is that when we pass the ids of regions, the
> receivers do not know what the originated region is and the id of each
> region is not same across all the regions.
>
>  Thanks
> Alex Ough
>
>
> On Tue, Jun 24, 2014 at 7:35 PM, Alena Prokharchyk <
> alena.prokharc...@citrix.com> wrote:
>
>>  Alex, thank you for summarizing.
>>
>>   I still don’t see why id can’t be unique across regions as you can
>> control the id assignment – id is required when createRegion call is made.
>> And that’s how the region should be represented in other region’s Dbs – by
>> its id that is unique across the regions. Kishan/Murali, please confirm.
>>
>>  Thank you,
>> Alena.
>>
>>   From: Alex Ough 
>> Date: Tuesday, June 24, 2014 at 4:22 PM
>> To: "dev@cloudstack.apache.org" 
>> Cc: Alena Prokharchyk , Kishan Kavala <
>> kishan.kav...@citrix.com>, Murali Reddy , Ram
>> Ganesh , Animesh Chaturvedi <
>> animesh.chaturv...@citrix.com>
>>
>> Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among
>> Multiple Regions (Core Changes)
>>
>>   All,
>>
>>  There is one open question in this topic, which is to figure out which
>> value is appropriate to pass the region object, id or name?
>> During this implementation, we decided to add the information of regions
>> where user/account/domain objects have been originally
>> created/modified/removed.
>> But the ids of regions are not same across the regions and currently the
>> regions do not have uuids(they will not be same either if we add them to
>> regions), so I'd like to use names.
>>
>>  Please let me know what you think.
>> Thanks
>> Alex Ough
>>
>>
>> On Tue, Jun 24, 2014 at 7:05 PM, Animesh Chaturvedi <
>> animesh.chaturv...@citrix.com> wrote:
>>
>>>  Let’s have the discussion on dev mailing list
>>>
>>>
>>>
>>> Thanks
>>>
>>> Animesh
>>>
>>>
>>>
>>> *From:* Alena Prokharchyk
>>> *Sent:* Tuesday, June 24, 2014 3:06 PM
>>> *To:* Alex Ough; Kishan Kavala; Murali Reddy
>>> *Cc:* Animesh Chaturvedi; Ram Ganesh
>>>
>>> *Subject:* Re: Review Request 20099: Domain-Account-User Sync Up Among
>>> Multiple Regions (Core Changes)
>>>
>>>
>>>
>>> Adding Kishan to the thread as he was the one who implemented the region
>>> feature originally.
>>>
>>>
>>>
>>> Kishan, in a situation when there are 2 regions in the system, we expect
>>> “region” table to be populated with the same id/name in both Dbs for both
>>> regions, right? So my question is – what uniquely identifies the region in
>>> CS system in cross region setup – id/name?
>>>
>>>
>>>
>>> That unique identifier should be the value that is passed to the calls
>>> you modify, Alex. WE can’t just pass some random name to the call without
>>> making any further verification.
>>>
>>>
>>>
>>> Kishan/Murali, please help to verify this part of Alex’s fix as it
>>> should really be someone with an expertise in Regions. I’ve reviewed the
>>> rest of the feature, just this one item is open. See my latest comment to
>>> the https://reviews.apache.org/r/17790/diff/?page=1#0 as well as refer
>>> to this email thread for the context.
>>>
>>>
>>>
>>> -Alena.
>>>
>>>
>>>
>>> *From

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

[Alena Prokharchyk]

Alex, id is used as a unique identifier for CS objects. And it is the CS 
requirement to refer to the object by id if the id is present. Look at all the 
other APIs. We nowhere refer to the network/vpc/vm by name just because its 
more human readable. The id is used by Api layer when parameter validation is 
done, by lots of Dao methods (findById is one of them), etc.  Even look at 
updateRegion/deleteRegion – we don’t refer to them by name, but by the id.

The reason why Kishan added the support for controlling the id by adding it to 
the createRegion call (and making it unique) is exactly that – region 
administrator can decide what id to set on the region, and to introduce the 
region with the same id to the other regions’ db.

So I would still suggest on using the id of the region in the API calls you are 
modifying. Unless developers who worked on regions feature – Kishan/Murali – 
come up with the valid objection.

Thanks,
Alena.

From: Alex Ough mailto:alex.o...@sungardas.com>>
Date: Tuesday, June 24, 2014 at 5:41 PM
To: Alena Prokharchyk 
mailto:alena.prokharc...@citrix.com>>
Cc: "dev@cloudstack.apache.org" 
mailto:dev@cloudstack.apache.org>>, Kishan Kavala 
mailto:kishan.kav...@citrix.com>>, Murali Reddy 
mailto:murali.re...@citrix.com>>, Ram Ganesh 
mailto:ram.gan...@citrix.com>>, Animesh Chaturvedi 
mailto:animesh.chaturv...@citrix.com>>
Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple 
Regions (Core Changes)

We can use the same ids & names, but we don't have to use the same ids if we 
use names, which is a little easier because names are user readable but ids are 
not, so we don't need to memorize/check all the ids when we add new regions in 
multiple regions, which can be confusing.

Thanks
Alex Ough


On Tue, Jun 24, 2014 at 8:33 PM, Alena Prokharchyk 
mailto:alena.prokharc...@citrix.com>> wrote:
Aren’t we supposed to sync the regions across the multiple regions Dbs? Because 
that’s what region FS states:

https://cwiki.apache.org/confluence/display/CLOUDSTACK/AWS-Style+Regions+Functional+Spec,
 “Adding 2nd region” paragraph, bullet #4:


1. Install a 2nd CS instance.

2. While installing database set region_id using -r option in 
cloud-setup-databases script (Make sure database_key is same across all 
regions).

cloud-setup-databases cloud:@localhost --deploy-as=root: 
-e  -m  -k  -r 

3. Start mgmt server

4. Using addRegion API, add region 1 to region 2 and also region 2 to region 1.


I assume that we expect the admin to add the region with the same name and the 
same id to ALL regions Dbs (both id and name should be passed to createRegion 
call). So they are all in sync. Isn’t it the requirement? If so, we should rely 
on the fact that all regions Dbs will have the same set of regions having the 
same ids and names cross regions.


Thanks,

Alena.

From: Alex Ough mailto:alex.o...@sungardas.com>>
Date: Tuesday, June 24, 2014 at 5:17 PM
To: Alena Prokharchyk 
mailto:alena.prokharc...@citrix.com>>
Cc: "dev@cloudstack.apache.org" 
mailto:dev@cloudstack.apache.org>>, Kishan Kavala 
mailto:kishan.kav...@citrix.com>>, Murali Reddy 
mailto:murali.re...@citrix.com>>, Ram Ganesh 
mailto:ram.gan...@citrix.com>>, Animesh Chaturvedi 
mailto:animesh.chaturv...@citrix.com>>

Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple 
Regions (Core Changes)

What I'm trying to say is that when we pass the ids of regions, the receivers 
do not know what the originated region is and the id of each region is not same 
across all the regions.

Thanks
Alex Ough


On Tue, Jun 24, 2014 at 7:35 PM, Alena Prokharchyk 
mailto:alena.prokharc...@citrix.com>> wrote:
Alex, thank you for summarizing.

 I still don’t see why id can’t be unique across regions as you can control the 
id assignment – id is required when createRegion call is made. And that’s how 
the region should be represented in other region’s Dbs – by its id that is 
unique across the regions. Kishan/Murali, please confirm.

Thank you,
Alena.

From: Alex Ough mailto:alex.o...@sungardas.com>>
Date: Tuesday, June 24, 2014 at 4:22 PM
To: "dev@cloudstack.apache.org" 
mailto:dev@cloudstack.apache.org>>
Cc: Alena Prokharchyk 
mailto:alena.prokharc...@citrix.com>>, Kishan 
Kavala mailto:kishan.kav...@citrix.com>>, Murali 
Reddy mailto:murali.re...@citrix.com>>, Ram Ganesh 
mailto:ram.gan...@citrix.com>>, Animesh Chaturvedi 
mailto:animesh.chaturv...@citrix.com>>

Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple 
Regions (Core Changes)

All,

There is one open question in this topic, which is to figure out which value is 
appropriate to pass the region object, id or name?
During this implementation, we decided to add the information of regions where 
user/account/domain objects have been originally created/modified/removed.
But the ids of regions are not same across the regions and 

build path errors when importing cloudstack in eclipse

[Kuang-Ching Wang]

I am new to CloudStack.  While trying to set up a dev environment, after 
importing the cloned maven project into eclipse, all projects show build path 
errors.  Did I miss some step?  Or do I need to manually add the build path in 
eclipse?

Thanks,
KC

Re: build path errors when importing cloudstack in eclipse

[Mike Tutkowski]

Are you seeing errors in Maven POM files? If so, those are business as
usual and are OK (Plugin execution not covered by lifecycle configuration).


On Tue, Jun 24, 2014 at 6:53 PM, Kuang-Ching Wang  wrote:

> I am new to CloudStack.  While trying to set up a dev environment, after
> importing the cloned maven project into eclipse, all projects show build
> path errors.  Did I miss some step?  Or do I need to manually add the build
> path in eclipse?
>
> Thanks,
> KC




-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
*™*

Re: [GSOC] End of term update

[David Nalley]

>
> It's not clear to me yet, if we need this under cloudstack ASF repos. @anyone 
> thoughts ?
>

So it's strictly not needed; it's an add-on. That said, I'd personally
love to see us have this in the ACS fold.

--David

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

[Alex Ough]

I agree with that the ids are unique identifier, but they are usually
internal purpose not exposed to the users. So it is a little strange to ask
users to assign ids when they add new regions. And if we do not allow
duplicated names, I'm not sure why it is not good to use names as a unique
identifier.

It's been a long way to come this far with several reasons, so I really
want to wrap this up as soon as possible, and this doesn't seem to be a
major obstacle, so let me just use 'id' as a parameter if there is no one
with a different thought until tomorrow morning.

Thanks
Alex Ough


On Tue, Jun 24, 2014 at 8:52 PM, Alena Prokharchyk <
alena.prokharc...@citrix.com> wrote:

>  Alex, id is used as a unique identifier for CS objects. And it is the CS
> requirement to refer to the object by id if the id is present. Look at all
> the other APIs. We nowhere refer to the network/vpc/vm by name just because
> its more human readable. The id is used by Api layer when parameter
> validation is done, by lots of Dao methods (findById is one of them), etc.
>  Even look at updateRegion/deleteRegion – we don’t refer to them by name,
> but by the id.
>
>  The reason why Kishan added the support for controlling the id by adding
> it to the createRegion call (and making it unique) is exactly that – region
> administrator can decide what id to set on the region, and to introduce the
> region with the same id to the other regions’ db.
>
>  So I would still suggest on using the id of the region in the API calls
> you are modifying. Unless developers who worked on regions feature –
> Kishan/Murali – come up with the valid objection.
>
>  Thanks,
> Alena.
>
>   From: Alex Ough 
> Date: Tuesday, June 24, 2014 at 5:41 PM
>
> To: Alena Prokharchyk 
> Cc: "dev@cloudstack.apache.org" , Kishan
> Kavala , Murali Reddy ,
> Ram Ganesh , Animesh Chaturvedi <
> animesh.chaturv...@citrix.com>
> Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among
> Multiple Regions (Core Changes)
>
>   We can use the same ids & names, but we don't have to use the same ids
> if we use names, which is a little easier because names are user readable
> but ids are not, so we don't need to memorize/check all the ids when we add
> new regions in multiple regions, which can be confusing.
>
>  Thanks
> Alex Ough
>
>
> On Tue, Jun 24, 2014 at 8:33 PM, Alena Prokharchyk <
> alena.prokharc...@citrix.com> wrote:
>
>>  Aren’t we supposed to sync the regions across the multiple regions Dbs?
>> Because that’s what region FS states:
>>
>>
>> https://cwiki.apache.org/confluence/display/CLOUDSTACK/AWS-Style+Regions+Functional+Spec,
>> “Adding 2nd region” paragraph, bullet #4:
>>
>>   1. Install a 2nd CS instance.
>>
>> 2. While installing database set region_id using -r option in
>> cloud-setup-databases script (Make sure *database_key* is same across
>> all regions).
>>
>> *cloud-setup-databases cloud:**<**dbpassword**>**@localhost
>> --deploy-as=root:**<**password**>** -e **<**encryption_type**>** -m **<*
>> *management_server_key**>** -k **<**database_key**> **-r *
>>
>> 3. Start mgmt server
>>
>> 4. *Using addRegion API, add region 1 to region 2 and also region 2 to
>> region 1.*
>>
>>
>>  I assume that we expect the admin to add the region with the same name
>> and the same id to ALL regions Dbs (both id and name should be passed to
>> createRegion call). So they are all in sync. Isn’t it the requirement? If
>> so, we should rely on the fact that all regions Dbs will have the same set
>> of regions having the same ids and names cross regions.
>>
>>
>>  Thanks,
>>
>> Alena.
>>   From: Alex Ough 
>> Date: Tuesday, June 24, 2014 at 5:17 PM
>> To: Alena Prokharchyk 
>> Cc: "dev@cloudstack.apache.org" , Kishan
>> Kavala , Murali Reddy ,
>> Ram Ganesh , Animesh Chaturvedi <
>> animesh.chaturv...@citrix.com>
>>
>> Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among
>> Multiple Regions (Core Changes)
>>
>>   What I'm trying to say is that when we pass the ids of regions, the
>> receivers do not know what the originated region is and the id of each
>> region is not same across all the regions.
>>
>>  Thanks
>> Alex Ough
>>
>>
>> On Tue, Jun 24, 2014 at 7:35 PM, Alena Prokharchyk <
>> alena.prokharc...@citrix.com> wrote:
>>
>>>  Alex, thank you for summarizing.
>>>
>>>   I still don’t see why id can’t be unique across regions as you can
>>> control the id assignment – id is required when createRegion call is made.
>>> And that’s how the region should be represented in other region’s Dbs – by
>>> its id that is unique across the regions. Kishan/Murali, please confirm.
>>>
>>>  Thank you,
>>> Alena.
>>>
>>>   From: Alex Ough 
>>> Date: Tuesday, June 24, 2014 at 4:22 PM
>>> To: "dev@cloudstack.apache.org" 
>>> Cc: Alena Prokharchyk , Kishan Kavala <
>>> kishan.kav...@citrix.com>, Murali Reddy , Ram
>>> Ganesh , Animesh Chaturvedi <
>>> animesh.chaturv...@citrix.com>
>>>
>>> Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among
>>> Mult

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

[Alex Ough]

There is one thing that was not mentioned, which is that currently the id
of 'Local' region is always 1 and if we do not guarantee that, there is no
way to find out which is the local region unless we add one more field to
tells which is the local region.
I'm wondering if we have a solution for this now.

Thanks
Alex Ough


On Tue, Jun 24, 2014 at 9:59 PM, Alex Ough  wrote:

> I agree with that the ids are unique identifier, but they are usually
> internal purpose not exposed to the users. So it is a little strange to ask
> users to assign ids when they add new regions. And if we do not allow
> duplicated names, I'm not sure why it is not good to use names as a unique
> identifier.
>
> It's been a long way to come this far with several reasons, so I really
> want to wrap this up as soon as possible, and this doesn't seem to be a
> major obstacle, so let me just use 'id' as a parameter if there is no one
> with a different thought until tomorrow morning.
>
> Thanks
> Alex Ough
>
>
> On Tue, Jun 24, 2014 at 8:52 PM, Alena Prokharchyk <
> alena.prokharc...@citrix.com> wrote:
>
>>  Alex, id is used as a unique identifier for CS objects. And it is the
>> CS requirement to refer to the object by id if the id is present. Look at
>> all the other APIs. We nowhere refer to the network/vpc/vm by name just
>> because its more human readable. The id is used by Api layer when parameter
>> validation is done, by lots of Dao methods (findById is one of them), etc.
>>  Even look at updateRegion/deleteRegion – we don’t refer to them by name,
>> but by the id.
>>
>>  The reason why Kishan added the support for controlling the id by
>> adding it to the createRegion call (and making it unique) is exactly that –
>> region administrator can decide what id to set on the region, and to
>> introduce the region with the same id to the other regions’ db.
>>
>>  So I would still suggest on using the id of the region in the API calls
>> you are modifying. Unless developers who worked on regions feature –
>> Kishan/Murali – come up with the valid objection.
>>
>>  Thanks,
>> Alena.
>>
>>   From: Alex Ough 
>> Date: Tuesday, June 24, 2014 at 5:41 PM
>>
>> To: Alena Prokharchyk 
>> Cc: "dev@cloudstack.apache.org" , Kishan
>> Kavala , Murali Reddy ,
>> Ram Ganesh , Animesh Chaturvedi <
>> animesh.chaturv...@citrix.com>
>> Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among
>> Multiple Regions (Core Changes)
>>
>>   We can use the same ids & names, but we don't have to use the same ids
>> if we use names, which is a little easier because names are user readable
>> but ids are not, so we don't need to memorize/check all the ids when we add
>> new regions in multiple regions, which can be confusing.
>>
>>  Thanks
>> Alex Ough
>>
>>
>> On Tue, Jun 24, 2014 at 8:33 PM, Alena Prokharchyk <
>> alena.prokharc...@citrix.com> wrote:
>>
>>>  Aren’t we supposed to sync the regions across the multiple regions
>>> Dbs? Because that’s what region FS states:
>>>
>>>
>>> https://cwiki.apache.org/confluence/display/CLOUDSTACK/AWS-Style+Regions+Functional+Spec,
>>> “Adding 2nd region” paragraph, bullet #4:
>>>
>>>   1. Install a 2nd CS instance.
>>>
>>> 2. While installing database set region_id using -r option in
>>> cloud-setup-databases script (Make sure *database_key* is same across
>>> all regions).
>>>
>>> *cloud-setup-databases cloud:**<**dbpassword**>**@localhost
>>> --deploy-as=root:**<**password**>** -e **<**encryption_type**>** -m **<*
>>> *management_server_key**>** -k **<**database_key**> **-r *
>>>
>>> 3. Start mgmt server
>>>
>>> 4. *Using addRegion API, add region 1 to region 2 and also region 2 to
>>> region 1.*
>>>
>>>
>>>  I assume that we expect the admin to add the region with the same name
>>> and the same id to ALL regions Dbs (both id and name should be passed to
>>> createRegion call). So they are all in sync. Isn’t it the requirement? If
>>> so, we should rely on the fact that all regions Dbs will have the same set
>>> of regions having the same ids and names cross regions.
>>>
>>>
>>>  Thanks,
>>>
>>> Alena.
>>>   From: Alex Ough 
>>> Date: Tuesday, June 24, 2014 at 5:17 PM
>>> To: Alena Prokharchyk 
>>> Cc: "dev@cloudstack.apache.org" , Kishan
>>> Kavala , Murali Reddy ,
>>> Ram Ganesh , Animesh Chaturvedi <
>>> animesh.chaturv...@citrix.com>
>>>
>>> Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among
>>> Multiple Regions (Core Changes)
>>>
>>>   What I'm trying to say is that when we pass the ids of regions, the
>>> receivers do not know what the originated region is and the id of each
>>> region is not same across all the regions.
>>>
>>>  Thanks
>>> Alex Ough
>>>
>>>
>>> On Tue, Jun 24, 2014 at 7:35 PM, Alena Prokharchyk <
>>> alena.prokharc...@citrix.com> wrote:
>>>
  Alex, thank you for summarizing.

   I still don’t see why id can’t be unique across regions as you can
 control the id assignment – id is required when createRegion call is made.
 And that’s how the region s

Multiple IP in Guest VM

[Tejas Gadaria]

Hi,

I have 2 diff VLAN created by "default shared Network offering". I want to
assign one ip from both VLAN to Linux guest VM. Is it possible ? I am using
CS 4.3 with Xen 6.2 SP1.

Regards,
Tejas

RE: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

[Kishan Kavala]

Alex,
As Alena mentioned, it is admin’s responsibility to keep ids same across 
Regions. Ids should be used as unique identifier. Region name is merely 
descriptive name and its mostly associated with geographic location.
Also note that region name can be updated anytime using updateRegion API.

Unlike, other internal Ids in CS, region Ids are assigned by admin. So exposing 
region Id to admin should not be an issue.

Id of the local region cannot be guaranteed to be “1” always. Region Id has to 
be unique across all regions. While creating new region admin will provide 
unique region id to cloud-setup-databases script. Id of the local region is 
stored in db.properties. To identify a Local region you can use one of the 
following options:

1.   Look up region.id in db.properties

2.   Add a new column in region table


From: Alex Ough [mailto:alex.o...@sungardas.com]
Sent: Wednesday, 25 June 2014 8:18 AM
To: Alena Prokharchyk
Cc: dev@cloudstack.apache.org; Kishan Kavala; Murali Reddy; Ram Ganesh; Animesh 
Chaturvedi
Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple 
Regions (Core Changes)

There is one thing that was not mentioned, which is that currently the id of 
'Local' region is always 1 and if we do not guarantee that, there is no way to 
find out which is the local region unless we add one more field to tells which 
is the local region.
I'm wondering if we have a solution for this now.

Thanks
Alex Ough

On Tue, Jun 24, 2014 at 9:59 PM, Alex Ough 
mailto:alex.o...@sungardas.com>> wrote:
I agree with that the ids are unique identifier, but they are usually internal 
purpose not exposed to the users. So it is a little strange to ask users to 
assign ids when they add new regions. And if we do not allow duplicated names, 
I'm not sure why it is not good to use names as a unique identifier.

It's been a long way to come this far with several reasons, so I really want to 
wrap this up as soon as possible, and this doesn't seem to be a major obstacle, 
so let me just use 'id' as a parameter if there is no one with a different 
thought until tomorrow morning.

Thanks
Alex Ough

On Tue, Jun 24, 2014 at 8:52 PM, Alena Prokharchyk 
mailto:alena.prokharc...@citrix.com>> wrote:
Alex, id is used as a unique identifier for CS objects. And it is the CS 
requirement to refer to the object by id if the id is present. Look at all the 
other APIs. We nowhere refer to the network/vpc/vm by name just because its 
more human readable. The id is used by Api layer when parameter validation is 
done, by lots of Dao methods (findById is one of them), etc.  Even look at 
updateRegion/deleteRegion – we don’t refer to them by name, but by the id.

The reason why Kishan added the support for controlling the id by adding it to 
the createRegion call (and making it unique) is exactly that – region 
administrator can decide what id to set on the region, and to introduce the 
region with the same id to the other regions’ db.

So I would still suggest on using the id of the region in the API calls you are 
modifying. Unless developers who worked on regions feature – Kishan/Murali – 
come up with the valid objection.

Thanks,
Alena.

From: Alex Ough mailto:alex.o...@sungardas.com>>
Date: Tuesday, June 24, 2014 at 5:41 PM

To: Alena Prokharchyk 
mailto:alena.prokharc...@citrix.com>>
Cc: "dev@cloudstack.apache.org" 
mailto:dev@cloudstack.apache.org>>, Kishan Kavala 
mailto:kishan.kav...@citrix.com>>, Murali Reddy 
mailto:murali.re...@citrix.com>>, Ram Ganesh 
mailto:ram.gan...@citrix.com>>, Animesh Chaturvedi 
mailto:animesh.chaturv...@citrix.com>>
Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple 
Regions (Core Changes)

We can use the same ids & names, but we don't have to use the same ids if we 
use names, which is a little easier because names are user readable but ids are 
not, so we don't need to memorize/check all the ids when we add new regions in 
multiple regions, which can be confusing.

Thanks
Alex Ough

On Tue, Jun 24, 2014 at 8:33 PM, Alena Prokharchyk 
mailto:alena.prokharc...@citrix.com>> wrote:
Aren’t we supposed to sync the regions across the multiple regions Dbs? Because 
that’s what region FS states:

https://cwiki.apache.org/confluence/display/CLOUDSTACK/AWS-Style+Regions+Functional+Spec,
 “Adding 2nd region” paragraph, bullet #4:


1. Install a 2nd CS instance.

2. While installing database set region_id using -r option in 
cloud-setup-databases script (Make sure database_key is same across all 
regions).

cloud-setup-databases cloud:@localhost --deploy-as=root: 
-e  -m  -k  -r 

3. Start mgmt server

4. Using addRegion API, add region 1 to region 2 and also region 2 to region 1.



I assume that we expect the admin to add the region with the same name and the 
same id to ALL regions Dbs (both id and name should be passed to createRegion 
call). So they are all in sync. Isn’t it the requirement? If so, we should rely