----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22631/#review46580 -----------------------------------------------------------
Ship it! I checked this code in under 4d6c682f18d9bca50c145b55d8fa61ea1ab71755. Please verify that it is as you expected it to be. Thanks! I also checked in 3d9eaf07537aa7ef5da291912c308ea7dc08df81 to correct some formatting issues in 4d6c682f18d9bca50c145b55d8fa61ea1ab71755. - Mike Tutkowski On June 17, 2014, 9:28 a.m., punith s wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22631/ > ----------------------------------------------------------- > > (Updated June 17, 2014, 9:28 a.m.) > > > Review request for cloudstack, amit kumar das, edison su, and Mike Tutkowski. > > > Repository: cloudstack-git > > > Description > ------- > > currently managed storage only supports iscsi protocol. > > hence now adding support for nfs protocol and also resizing the vdi to the SR > size, hence fully utilizing the SR space in managed storage. > > to support nfs, the getNfsSR method's signature has to changed similar to > existing getIscsiSR method. > > SR will be created based on the volume's protocoltype. > > jira id - CLOUDSTACK-6916 > > > Diffs > ----- > > api/src/com/cloud/agent/api/to/DiskTO.java 5901367 > > engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java > eea931e > > plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java > 9979802 > server/src/com/cloud/storage/VolumeApiServiceImpl.java 9b034e9 > > Diff: https://reviews.apache.org/r/22631/diff/ > > > Testing > ------- > > system testing done. > > > Thanks, > > punith s > >
