Re: Blogs

2014-06-17 Thread sebgoa

On Jun 16, 2014, at 4:34 PM, David Nalley  wrote:

> http://planet.apache.org/cloudstack
> 

added to website on About section


> On Mon, Jun 16, 2014 at 9:24 AM, sebgoa  wrote:
>> The website points to our blog at:
>> 
>> https://blogs.apache.org/cloudstack/
>> 
>> I am pretty sure we used to aggregate bunch of our own blogs there, but it 
>> does not look like it's being done now.
>> 
>> Did something change ?
>> 
>> Also, where is our planet ? I thought we got it done
>> 
>> -sebastien



Re: [EVENT] One week left for CCC Budapest CFP

2014-06-17 Thread ilya musayev

Can i submit a tentative proposal?

If stars align (as they seem to align so far), I will try to present @ 
CCC Budapest.


On 6/16/14, 11:51 PM, sebgoa wrote:

Morning Boys and Girls,

There is one week left to submit your papers for CCC Budapest Nov 19-21:
http://events.linuxfoundation.org/events/cloudstack-collaboration-conference-europe/program/cfp

Come share your CloudStack stories,

Cheers,

-Sebastien




Re: [EVENT] One week left for CCC Budapest CFP

2014-06-17 Thread sebgoa

On Jun 17, 2014, at 9:48 AM, ilya musayev  wrote:

> Can i submit a tentative proposal?

yes

> 
> If stars align (as they seem to align so far), I will try to present @ CCC 
> Budapest.
> 
> On 6/16/14, 11:51 PM, sebgoa wrote:
>> Morning Boys and Girls,
>> 
>> There is one week left to submit your papers for CCC Budapest Nov 19-21:
>> http://events.linuxfoundation.org/events/cloudstack-collaboration-conference-europe/program/cfp
>> 
>> Come share your CloudStack stories,
>> 
>> Cheers,
>> 
>> -Sebastien
> 



Re: Review Request 22631: supporting nfs protocol and resize feature for managed storage in xenserver.

2014-06-17 Thread punith s

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22631/
---

(Updated June 17, 2014, 1:35 p.m.)


Review request for cloudstack, amit kumar das, edison su, and Mike Tutkowski.


Changes
---

since we are using hypervisor reserve for snapshot, now i'm resizing the vdi to 
the size of cloudstack volume size instead of size of the attached SR.


Repository: cloudstack-git


Description
---

currently managed storage only supports iscsi protocol.

hence now adding support for nfs protocol and also resizing the vdi to the SR 
size, hence fully utilizing the SR space in managed storage.

to support nfs, the getNfsSR method's signature has to changed similar to 
existing getIscsiSR method.

SR will be created based on the volume's protocoltype.

jira id - CLOUDSTACK-6916


Diffs (updated)
-

  
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
 9979802 

Diff: https://reviews.apache.org/r/22631/diff/


Testing
---

system testing done.


Thanks,

punith s



Re: Review Request 22672: CLOUDSTACK-6914: Fixed the mentioned issue for vgpu cases along with tagging

2014-06-17 Thread Abhinandan Prateek

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22672/#review45919
---

Ship it!


Ship It!

- Abhinandan Prateek


On June 17, 2014, 5:01 a.m., Santhosh Edukulla wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22672/
> ---
> 
> (Updated June 17, 2014, 5:01 a.m.)
> 
> 
> Review request for cloudstack and Abhinandan Prateek.
> 
> 
> Bugs: CLOUDSTACK-6914
> https://issues.apache.org/jira/browse/CLOUDSTACK-6914
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fixed the vgpu case hypervisor check, and added missing tags to master.
> 
> 
> Diffs
> -
> 
>   test/integration/smoke/test_affinity_groups.py bb0a524 
>   test/integration/smoke/test_deploy_vgpu_enabled_vm.py 13fad61 
>   test/integration/smoke/test_deploy_vm.py 87e0011 
>   test/integration/smoke/test_deploy_vm_root_resize.py 8097d08 
>   test/integration/smoke/test_deploy_vm_with_userdata.py 7616b82 
>   test/integration/smoke/test_deploy_vms_with_varied_deploymentplanners.py 
> 420925e 
>   test/integration/smoke/test_disk_offerings.py 780c154 
>   test/integration/smoke/test_global_settings.py ace2db3 
>   test/integration/smoke/test_guest_vlan_range.py f5bcdf4 
>   test/integration/smoke/test_internal_lb.py d6f3477 
>   test/integration/smoke/test_iso.py 6741633 
>   test/integration/smoke/test_loadbalance.py daa5fee 
>   test/integration/smoke/test_multipleips_per_nic.py ad3a3cf 
>   test/integration/smoke/test_network.py 52efc32 
>   test/integration/smoke/test_network_acl.py 68e5067 
>   test/integration/smoke/test_nic.py 592a839 
>   test/integration/smoke/test_non_contigiousvlan.py 50b48d0 
>   test/integration/smoke/test_over_provisioning.py 1c5d8a5 
>   test/integration/smoke/test_portable_publicip.py 2d02a71 
>   test/integration/smoke/test_primary_storage.py 3147d86 
>   test/integration/smoke/test_privategw_acl.py c86beb1 
>   test/integration/smoke/test_public_ip_range.py b961dc3 
>   test/integration/smoke/test_pvlan.py 7d1aa5d 
>   test/integration/smoke/test_regions.py 389f878 
>   test/integration/smoke/test_reset_vm_on_reboot.py 4709df4 
>   test/integration/smoke/test_resource_detail.py 7f4a6e7 
>   test/integration/smoke/test_routers.py 2aa83c3 
>   test/integration/smoke/test_scale_vm.py f0ec534 
>   test/integration/smoke/test_secondary_storage.py 90304b3 
>   test/integration/smoke/test_service_offerings.py 980e110 
>   test/integration/smoke/test_snapshots.py a960e70 
>   test/integration/smoke/test_ssvm.py ffa620b 
>   test/integration/smoke/test_templates.py c7594bb 
>   test/integration/smoke/test_vm_ha.py 4063946 
>   test/integration/smoke/test_vm_life_cycle.py 104b86c 
>   test/integration/smoke/test_vm_snapshots.py e884d42 
>   test/integration/smoke/test_volumes.py c6ea09d 
>   test/integration/smoke/test_vpc_vpn.py 03826e9 
>   tools/marvin/marvin/config/test_data.py cfc4556 
> 
> Diff: https://reviews.apache.org/r/22672/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>



Re: Review Request 22672: CLOUDSTACK-6914: Fixed the mentioned issue for vgpu cases along with tagging

2014-06-17 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22672/#review45920
---


Commit 7c15f148daf9ebb28a8945296db6a967fcfb19f7 in cloudstack's branch 
refs/heads/master from Santhosh Edukulla
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=7c15f14 ]

CLOUDSTACK-6914: Fixed the mentioned issue

Signed-off-by: Abhinandan Prateek 


- ASF Subversion and Git Services


On June 17, 2014, 5:01 a.m., Santhosh Edukulla wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22672/
> ---
> 
> (Updated June 17, 2014, 5:01 a.m.)
> 
> 
> Review request for cloudstack and Abhinandan Prateek.
> 
> 
> Bugs: CLOUDSTACK-6914
> https://issues.apache.org/jira/browse/CLOUDSTACK-6914
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fixed the vgpu case hypervisor check, and added missing tags to master.
> 
> 
> Diffs
> -
> 
>   test/integration/smoke/test_affinity_groups.py bb0a524 
>   test/integration/smoke/test_deploy_vgpu_enabled_vm.py 13fad61 
>   test/integration/smoke/test_deploy_vm.py 87e0011 
>   test/integration/smoke/test_deploy_vm_root_resize.py 8097d08 
>   test/integration/smoke/test_deploy_vm_with_userdata.py 7616b82 
>   test/integration/smoke/test_deploy_vms_with_varied_deploymentplanners.py 
> 420925e 
>   test/integration/smoke/test_disk_offerings.py 780c154 
>   test/integration/smoke/test_global_settings.py ace2db3 
>   test/integration/smoke/test_guest_vlan_range.py f5bcdf4 
>   test/integration/smoke/test_internal_lb.py d6f3477 
>   test/integration/smoke/test_iso.py 6741633 
>   test/integration/smoke/test_loadbalance.py daa5fee 
>   test/integration/smoke/test_multipleips_per_nic.py ad3a3cf 
>   test/integration/smoke/test_network.py 52efc32 
>   test/integration/smoke/test_network_acl.py 68e5067 
>   test/integration/smoke/test_nic.py 592a839 
>   test/integration/smoke/test_non_contigiousvlan.py 50b48d0 
>   test/integration/smoke/test_over_provisioning.py 1c5d8a5 
>   test/integration/smoke/test_portable_publicip.py 2d02a71 
>   test/integration/smoke/test_primary_storage.py 3147d86 
>   test/integration/smoke/test_privategw_acl.py c86beb1 
>   test/integration/smoke/test_public_ip_range.py b961dc3 
>   test/integration/smoke/test_pvlan.py 7d1aa5d 
>   test/integration/smoke/test_regions.py 389f878 
>   test/integration/smoke/test_reset_vm_on_reboot.py 4709df4 
>   test/integration/smoke/test_resource_detail.py 7f4a6e7 
>   test/integration/smoke/test_routers.py 2aa83c3 
>   test/integration/smoke/test_scale_vm.py f0ec534 
>   test/integration/smoke/test_secondary_storage.py 90304b3 
>   test/integration/smoke/test_service_offerings.py 980e110 
>   test/integration/smoke/test_snapshots.py a960e70 
>   test/integration/smoke/test_ssvm.py ffa620b 
>   test/integration/smoke/test_templates.py c7594bb 
>   test/integration/smoke/test_vm_ha.py 4063946 
>   test/integration/smoke/test_vm_life_cycle.py 104b86c 
>   test/integration/smoke/test_vm_snapshots.py e884d42 
>   test/integration/smoke/test_volumes.py c6ea09d 
>   test/integration/smoke/test_vpc_vpn.py 03826e9 
>   tools/marvin/marvin/config/test_data.py cfc4556 
> 
> Diff: https://reviews.apache.org/r/22672/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>



Review Request 22674: CLOUDSTACK-1466: Automation - Secondary Storage Test Cases

2014-06-17 Thread Ashutosh Kelkar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22674/
---

Review request for cloudstack and Girish Shilamkar.


Bugs: CLOUDSTACK-1466
https://issues.apache.org/jira/browse/CLOUDSTACK-1466


Repository: cloudstack-git


Description
---

Adding 2 test suites for secondary storage limit test cases. More test suites 
to follow. The common and utility functions used are already available in 
primary storage limits patch added by Gaurav 
(https://reviews.apache.org/r/20316/).


Diffs
-

  test/integration/component/test_ss_domain_limits.py PRE-CREATION 
  test/integration/component/test_ss_limits.py PRE-CREATION 
  tools/marvin/marvin/config/test_data.py d870c98 
  tools/marvin/marvin/lib/base.py 8b89087 

Diff: https://reviews.apache.org/r/22674/diff/


Testing
---

Yes.


Thanks,

Ashutosh Kelkar



coverity scan report

2014-06-17 Thread Rajani Karuturi
Is there any change in the coverity scan project settings??
the dashboard says Last Analyzed on Jun 09, 2014 
https://scan.coverity.com/projects/943?tab=overview

while jenkins job is successful 
http://jenkins.buildacloud.org/job/cloudstack-master-twiceweekly-coverity/lastBuild/


~Rajani





Re: Review Request 22631: supporting nfs protocol and resize feature for managed storage in xenserver.

2014-06-17 Thread punith s

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22631/
---

(Updated June 17, 2014, 2:58 p.m.)


Review request for cloudstack, amit kumar das, edison su, and Mike Tutkowski.


Changes
---

had some problem with updating the second patch.


Repository: cloudstack-git


Description
---

currently managed storage only supports iscsi protocol.

hence now adding support for nfs protocol and also resizing the vdi to the SR 
size, hence fully utilizing the SR space in managed storage.

to support nfs, the getNfsSR method's signature has to changed similar to 
existing getIscsiSR method.

SR will be created based on the volume's protocoltype.

jira id - CLOUDSTACK-6916


Diffs (updated)
-

  api/src/com/cloud/agent/api/to/DiskTO.java 5901367 
  
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java
 eea931e 
  
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
 9979802 
  server/src/com/cloud/storage/VolumeApiServiceImpl.java 9b034e9 

Diff: https://reviews.apache.org/r/22631/diff/


Testing
---

system testing done.


Thanks,

punith s



Re: Review Request 19779: Fixed[CLOUDSTACK-5150]:-Creating template from a VM in Simulator results in incorrect size

2014-06-17 Thread Girish Chaudhari

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19779/
---

(Updated June 17, 2014, 9:37 a.m.)


Review request for cloudstack, daan Hoogland and Prasanna Santhanam.


Bugs: CLOUDSTACK-5150
https://issues.apache.org/jira/browse/CLOUDSTACK-5150


Repository: cloudstack-git


Description
---

Problem Statement:- In Simulator, When provisioning the VM using the personal 
template, results into the NullPointerException. 
Root Cause:- The template creation command is setting up the size as NULL in 
the tempalte_store_ref table and which is something causing this issue. 
Solution: To set up the size to 100 ( any Non-Null value) in the template 
create mocking process, which ultimately setting up the size to 100 in the 
tempalte_store_ref table and hence solving the issue.


Diffs
-

  
plugins/hypervisors/simulator/src/com/cloud/resource/SimulatorStorageProcessor.java
 8a78b87 

Diff: https://reviews.apache.org/r/19779/diff/


Testing
---

Tested it on the 4.3, the size in tempalte_store_ref table is getting populated 
as 100 and could instantiate the VM using the personal template.


Thanks,

Girish Chaudhari



Re: Review Request 22631: supporting nfs protocol and resize feature for managed storage in xenserver.

2014-06-17 Thread punith s


> On June 16, 2014, 9 p.m., Mike Tutkowski wrote:
> > I was curious about the resizing of the VDI to take up all of the space of 
> > the SR.
> > 
> > This is actually what I initially did in 4.2; however, it later dawned on 
> > me that - if you want to take hypervisor snapshots - then you need to have 
> > extra space left over in the SR. In other words, the VDI should be less 
> > than the size of the SR.
> > 
> > To support this, I added a new field in 4.3: hypervisor_ss_reserve. This 
> > field is a percentage of the size of the CloudStack volume (the VDI).
> > 
> > For example, if the user wants a 20 GB CloudStack volume (VDI) and the 
> > hypervisor snapshot reserve field is set at 200%, the SR will be 60 GB (20 
> > GB for the VDI + (20 GB * 2)).
> > 
> > Please let me know if you'd like more clarification on this. You can also 
> > examine the SolidFire plug-in to get a feel for how this new field is 
> > utilized.

thanks mike, since i'm still implementing snapshot i forgot to take a look at 
this field.

following your logic, now i'm resizing the vdi only to the cloudstack volume 
size instead of SR size, hence not using the entire SR size which contains the 
hypervisor snapshot reserve.

when a user resizes the volume, let the storage plugin resize the backend 
provider volume using the given snapshot reserve.

eg: from your industry standard logic,
if the current offering is at 10G and 25% reserve, this equates to 12.5 G 
volume in cloudbyte. but the cloudstack volume remains at 10G in the DB.
when the user resizes the volume to a different offering say 20G and 50% 
reserve, this equates to 30G volume in cloudbyte and  the cloudstack volume is 
resized to 20G in the DB.

hence now i'm mapping the vdi size to cloudstack volume size.

thanks.


- punith


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22631/#review45757
---


On June 17, 2014, 2:58 p.m., punith s wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22631/
> ---
> 
> (Updated June 17, 2014, 2:58 p.m.)
> 
> 
> Review request for cloudstack, amit kumar das, edison su, and Mike Tutkowski.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> currently managed storage only supports iscsi protocol.
> 
> hence now adding support for nfs protocol and also resizing the vdi to the SR 
> size, hence fully utilizing the SR space in managed storage.
> 
> to support nfs, the getNfsSR method's signature has to changed similar to 
> existing getIscsiSR method.
> 
> SR will be created based on the volume's protocoltype.
> 
> jira id - CLOUDSTACK-6916
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/agent/api/to/DiskTO.java 5901367 
>   
> engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java
>  eea931e 
>   
> plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
>  9979802 
>   server/src/com/cloud/storage/VolumeApiServiceImpl.java 9b034e9 
> 
> Diff: https://reviews.apache.org/r/22631/diff/
> 
> 
> Testing
> ---
> 
> system testing done.
> 
> 
> Thanks,
> 
> punith s
> 
>



Re: Review Request 21771: Cosmetic fixes in cloud-early-config script

2014-06-17 Thread Joris van Lieshout


> On June 12, 2014, 1:11 p.m., Rajesh Battala wrote:
> > systemvm/patches/debian/config/etc/init.d/cloud-early-config, line 33
> > 
> >
> > This daemon will be installed in the base image itself.

Hi Rajesh, I don't know what you mean by this comment? This daemon is for 
hyperV only, correct? So, on other hypervisors it does not exist making this a 
nice way to suppress the message that the script cannot be found, right? 


- Joris


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21771/#review45493
---


On May 21, 2014, 3:05 p.m., Joris van Lieshout wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21771/
> ---
> 
> (Updated May 21, 2014, 3:05 p.m.)
> 
> 
> Review request for cloudstack, Chiradeep Vittal, daan Hoogland, Rajesh 
> Battala, Hugo Trippaers, and Sheng Yang.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> 1. On start hv_kvp_daemon if it exists. Currently trows an error on the 
> console during boot.
> 2. By adding -f to the rm of boot_up_done it will be silent if it does not 
> exist. Currently also trows an error during bootup.
> 3. Use log_action_msg instead of log_action_begin_msg will make the console 
> look cleaner.
> 
> 
> Diffs
> -
> 
>   systemvm/patches/debian/config/etc/init.d/cloud-early-config ffb23ec 
> 
> Diff: https://reviews.apache.org/r/21771/diff/
> 
> 
> Testing
> ---
> 
> We are running these fixes in our beta and prod env for a while allready
> 
> 
> Thanks,
> 
> Joris van Lieshout
> 
>



Re: Review Request 20316: CLOUDSTACK-1466: Adding automation test cases for Primary Storage Limits

2014-06-17 Thread Girish Shilamkar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20316/#review45925
---

Ship it!


Ship It!

- Girish Shilamkar


On June 6, 2014, 9:40 a.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20316/
> ---
> 
> (Updated June 6, 2014, 9:40 a.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-1466
> https://issues.apache.org/jira/browse/CLOUDSTACK-1466
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Adding test suits in Primary Storage Limits test cases.
> 1)Root/Domain admin limits
> 2)Domain Limits
> 3)Resize volume
> 4)Project Limits
> 5)Maximum Limits
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_ps_domain_limits.py PRE-CREATION 
>   test/integration/component/test_ps_limits.py PRE-CREATION 
>   test/integration/component/test_ps_max_limits.py PRE-CREATION 
>   test/integration/component/test_ps_project_limits.py PRE-CREATION 
>   test/integration/component/test_ps_resize_volume.py PRE-CREATION 
>   tools/marvin/marvin/codes.py ef49c0c 
>   tools/marvin/marvin/lib/base.py 2681724 
>   tools/marvin/marvin/lib/common.py 91fe053 
> 
> Diff: https://reviews.apache.org/r/20316/diff/
> 
> 
> Testing
> ---
> 
> Yes
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>



Xen Project support and state of APIs

2014-06-17 Thread Rohit Yadav
Hi,

Xen Project (previously xen.org xenserver) is widely accessible in several
Linux distributions such as Arch, Fedora etc. Therefore, people may want to
use it instead of XenServer (6.2 or later). The ACS 4.5 design doc [1]
explains about XenServer and how it should be tested etc. but what about
using Xen Project?

Since the recent Xen plugin refactoring as xenserver plugin [1], I'm unable
to get ACS to work with Xen Project 4.4 (on a real host and on a new custom
DevCloud). Using the XenServer ACS plugin, it identifies a Xen Project host
as some version of Xen but then fails. Has anyone tried this with ACS
4.4/master? Are we going to test/support Xen Project (4.x) soon? If so, can
people involved share their plan/vision/roadmap on it?

Lastly, as the design doc [1] suggested XCP's development has stopped, are
we going to favour using XAPI [1] now or libVirt [2] or something else?

[1]
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Convert+Xen+usage+to+XenServer

[2] http://blog.xen.org/index.php/2014/03/10/xen-4-4-released

Regards.


[ACS 4.4] cherry-pick

2014-06-17 Thread Jayapal Reddy Uradi
Hi Daan,

Please cherry pick the following commit into 4.4

commit b0d726a872e2859a56ee677c15079cc3a59ab894
CLOUDSTACK-6923: updated listLBStickinessPolicies API to list using stickiness 
policy id


Thanks,
Jayapal



Re: Xen Project support and state of APIs

2014-06-17 Thread Tim Mackey
Rohit,

We've only supported xapi so far, so I'm curious if you had Xen Project 4.4
working before with xapi and if that is now broken. Nothing I did should
have impacted that, but it wasn't in my test suite so anything is possible
On Jun 17, 2014 11:21 AM, "Rohit Yadav"  wrote:

> Hi,
>
> Xen Project (previously xen.org xenserver) is widely accessible in several
> Linux distributions such as Arch, Fedora etc. Therefore, people may want to
> use it instead of XenServer (6.2 or later). The ACS 4.5 design doc [1]
> explains about XenServer and how it should be tested etc. but what about
> using Xen Project?
>
> Since the recent Xen plugin refactoring as xenserver plugin [1], I'm unable
> to get ACS to work with Xen Project 4.4 (on a real host and on a new custom
> DevCloud). Using the XenServer ACS plugin, it identifies a Xen Project host
> as some version of Xen but then fails. Has anyone tried this with ACS
> 4.4/master? Are we going to test/support Xen Project (4.x) soon? If so, can
> people involved share their plan/vision/roadmap on it?
>
> Lastly, as the design doc [1] suggested XCP's development has stopped, are
> we going to favour using XAPI [1] now or libVirt [2] or something else?
>
> [1]
>
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Convert+Xen+usage+to+XenServer
>
> [2] http://blog.xen.org/index.php/2014/03/10/xen-4-4-released
>
> Regards.
>


Review Request 22677: coverity issues: fixed conflicts in 4.4

2014-06-17 Thread Santhosh Edukulla

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22677/
---

Review request for cloudstack and daan Hoogland.


Repository: cloudstack-git


Description
---

Fixed coverity issues, had conflicts earlier while applying to 4.4. Fixed them.


Diffs
-

  engine/schema/src/com/cloud/upgrade/dao/Upgrade421to430.java 7e26132 
  engine/schema/src/com/cloud/vm/VMInstanceVO.java 849e042 
  
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java
 681fcee 
  server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 
05fbad3 
  utils/src/com/cloud/utils/net/NetUtils.java 6350986 

Diff: https://reviews.apache.org/r/22677/diff/


Testing
---

Built and deployed a data center 


Thanks,

Santhosh Edukulla



Re: [ACS 4.4] cherry-pick

2014-06-17 Thread Daan Hoogland
On Tue, Jun 17, 2014 at 8:41 AM, Jayapal Reddy Uradi
 wrote:
> 2214bd2502a34ee8e671eb6b4efe8cd26e29ac5a


I had conflicts. Can you have a look near line 550? I resolved by
changing IpAddress to PublicIpAddress.

regards
-- 
Daan


RE: [ACS44] Cherry Pick Request

2014-06-17 Thread Santhosh Edukulla
Resolved the conflicts for the mentioned commit.

https://reviews.apache.org/r/22677/

Santhosh

From: Daan Hoogland [daan.hoogl...@gmail.com]
Sent: Monday, June 16, 2014 12:09 PM
To: dev
Subject: Re: [ACS44] Cherry Pick Request

On Mon, Jun 16, 2014 at 4:28 PM, Santhosh Edukulla
 wrote:
> Daan,
>
> Please pick up the below fixes for resource leaks and other Coverity issues.
>
> 4ba3aae2ea0290ca012623083e13625e08a9dde5
was in already?

> 3c5f64c97ab071451aee7f232d8f2cec6d89044d
in

> dbfce8b11e25855a8cb21ec2bbbfe20940bb788d
had conflicts

>
>
> As well, please check the below commit, its fix for CLOUDSTACK-6793
>
> 91d054cb00f6a5818f2be1c7e4d3f44a2c58bfcc
was in already?

>
> Thanks!
> Santhosh



--
Daan

Re: Xen Project support and state of APIs

2014-06-17 Thread Rohit Yadav
Tim,

Thanks for replying, let me clean up everything and re-setup my test infra
after my $dayjob hours and get back to you. The test cases in the design
doc does not discuss Xen Project so I thought I should ask if ACS works
with Xen Project 4.x.

The Xen/XenProject/XenServer/XAPI/XCP is confusing [1]. From what I
understand, XCP was some sort of an opensource version of XenServer, but
since XenServer distribution (which consists of Xen, XenCenter, XAPI, Linux
etc.) is opensource, XCP has been discontinued since 1.6 release?

Now, on many Linux distro XAPI is still available as 'xcp-xapi' such as in
Debian/Ubuntu, so what package(s) do you suggest one needs to install and
configure so I can get DevCloud [2] work again? DevCloud is a VM that runs
Xen (Xen Project) inside it and can be used as a virtual host to
test/develop ACS against it.

[1] http://www.xenproject.org/developers/teams/xapi.html
[2] http://bhaisaab.org/logs/devcloud

Regards.




On Tue, Jun 17, 2014 at 4:27 PM, Tim Mackey  wrote:

> Rohit,
>
> We've only supported xapi so far, so I'm curious if you had Xen Project 4.4
> working before with xapi and if that is now broken. Nothing I did should
> have impacted that, but it wasn't in my test suite so anything is possible
> On Jun 17, 2014 11:21 AM, "Rohit Yadav"  wrote:
>
> > Hi,
> >
> > Xen Project (previously xen.org xenserver) is widely accessible in
> several
> > Linux distributions such as Arch, Fedora etc. Therefore, people may want
> to
> > use it instead of XenServer (6.2 or later). The ACS 4.5 design doc [1]
> > explains about XenServer and how it should be tested etc. but what about
> > using Xen Project?
> >
> > Since the recent Xen plugin refactoring as xenserver plugin [1], I'm
> unable
> > to get ACS to work with Xen Project 4.4 (on a real host and on a new
> custom
> > DevCloud). Using the XenServer ACS plugin, it identifies a Xen Project
> host
> > as some version of Xen but then fails. Has anyone tried this with ACS
> > 4.4/master? Are we going to test/support Xen Project (4.x) soon? If so,
> can
> > people involved share their plan/vision/roadmap on it?
> >
> > Lastly, as the design doc [1] suggested XCP's development has stopped,
> are
> > we going to favour using XAPI [1] now or libVirt [2] or something else?
> >
> > [1]
> >
> >
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Convert+Xen+usage+to+XenServer
> >
> > [2] http://blog.xen.org/index.php/2014/03/10/xen-4-4-released
> >
> > Regards.
> >
>


Re: Review Request 22631: supporting nfs protocol and resize feature for managed storage in xenserver.

2014-06-17 Thread punith s


> On June 16, 2014, 9:28 p.m., Mike Tutkowski wrote:
> > plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java,
> >  line 1963
> > 
> >
> > It looks like in VolumeOrchestrator that the protocol type can be 
> > "null".
> > 
> > That being the case, I recommend you reverse the order of the "if" 
> > statement here to be like this:
> > 
> > if (StoragePoolType.NetworkFilesystem.toString().equals(protocoltype))
> > 
> > This should avoid a NullPointerException if protocoltype is ever 'null'.

thank you.


- punith


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22631/#review45762
---


On June 17, 2014, 2:58 p.m., punith s wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22631/
> ---
> 
> (Updated June 17, 2014, 2:58 p.m.)
> 
> 
> Review request for cloudstack, amit kumar das, edison su, and Mike Tutkowski.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> currently managed storage only supports iscsi protocol.
> 
> hence now adding support for nfs protocol and also resizing the vdi to the SR 
> size, hence fully utilizing the SR space in managed storage.
> 
> to support nfs, the getNfsSR method's signature has to changed similar to 
> existing getIscsiSR method.
> 
> SR will be created based on the volume's protocoltype.
> 
> jira id - CLOUDSTACK-6916
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/agent/api/to/DiskTO.java 5901367 
>   
> engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java
>  eea931e 
>   
> plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
>  9979802 
>   server/src/com/cloud/storage/VolumeApiServiceImpl.java 9b034e9 
> 
> Diff: https://reviews.apache.org/r/22631/diff/
> 
> 
> Testing
> ---
> 
> system testing done.
> 
> 
> Thanks,
> 
> punith s
> 
>



Review Request 22679: Updated events for firewall ingress and egress API

2014-06-17 Thread Jayapal Reddy

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22679/
---

Review request for cloudstack and daan Hoogland.


Bugs: CLOUDSTACK-6922
https://issues.apache.org/jira/browse/CLOUDSTACK-6922


Repository: cloudstack-git


Description
---

Resolved review conflicts for CLOUDSTACK-6922


Diffs
-

  api/src/com/cloud/event/EventTypes.java 5c20dbf 
  api/src/com/cloud/network/firewall/FirewallService.java 5ab7891 
  
api/src/org/apache/cloudstack/api/command/user/firewall/CreateEgressFirewallRuleCmd.java
 579cccb 
  
api/src/org/apache/cloudstack/api/command/user/firewall/CreateFirewallRuleCmd.java
 b09d3a7 
  
api/src/org/apache/cloudstack/api/command/user/firewall/DeleteEgressFirewallRuleCmd.java
 4d22772 
  
api/src/org/apache/cloudstack/api/command/user/firewall/DeleteFirewallRuleCmd.java
 66dcc03 
  
api/src/org/apache/cloudstack/api/command/user/firewall/UpdateEgressFirewallRuleCmd.java
 0795396 
  
api/src/org/apache/cloudstack/api/command/user/firewall/UpdateFirewallRuleCmd.java
 f684371 
  server/src/com/cloud/network/firewall/FirewallManagerImpl.java 4f853b3 
  server/test/com/cloud/network/MockFirewallManagerImpl.java 3c02613 

Diff: https://reviews.apache.org/r/22679/diff/


Testing
---

Tested on 4.4-forward


Thanks,

Jayapal Reddy



Re: [ACS 4.4] cherry-pick

2014-06-17 Thread Jayapal Reddy Uradi
Hi Daan,

Resolved the conflicts and uploaded patch in review board.
https://reviews.apache.org/r/22679/

Thanks,
Jayapal

On 17-Jun-2014, at 4:52 PM, Daan Hoogland 
 wrote:

> On Tue, Jun 17, 2014 at 8:41 AM, Jayapal Reddy Uradi
>  wrote:
>> 2214bd2502a34ee8e671eb6b4efe8cd26e29ac5a
> 
> 
> I had conflicts. Can you have a look near line 550? I resolved by
> changing IpAddress to PublicIpAddress.
> 
> regards
> -- 
> Daan



Re: Review Request 19779: Fixed[CLOUDSTACK-5150]:-Creating template from a VM in Simulator results in incorrect size

2014-06-17 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19779/#review45927
---


Commit 883d8f11196e9ca55324bcf075880e077a2d3df3 in cloudstack's branch 
refs/heads/4.4-forward from Girish chaudhari
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=883d8f1 ]

CLOUDSTACK-5150 - set the template size from source

Signed-off-by: Daan Hoogland 


- ASF Subversion and Git Services


On June 17, 2014, 9:37 a.m., Girish Chaudhari wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19779/
> ---
> 
> (Updated June 17, 2014, 9:37 a.m.)
> 
> 
> Review request for cloudstack, daan Hoogland and Prasanna Santhanam.
> 
> 
> Bugs: CLOUDSTACK-5150
> https://issues.apache.org/jira/browse/CLOUDSTACK-5150
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Problem Statement:- In Simulator, When provisioning the VM using the personal 
> template, results into the NullPointerException. 
> Root Cause:- The template creation command is setting up the size as NULL in 
> the tempalte_store_ref table and which is something causing this issue. 
> Solution: To set up the size to 100 ( any Non-Null value) in the template 
> create mocking process, which ultimately setting up the size to 100 in the 
> tempalte_store_ref table and hence solving the issue.
> 
> 
> Diffs
> -
> 
>   
> plugins/hypervisors/simulator/src/com/cloud/resource/SimulatorStorageProcessor.java
>  8a78b87 
> 
> Diff: https://reviews.apache.org/r/19779/diff/
> 
> 
> Testing
> ---
> 
> Tested it on the 4.3, the size in tempalte_store_ref table is getting 
> populated as 100 and could instantiate the VM using the personal template.
> 
> 
> Thanks,
> 
> Girish Chaudhari
> 
>



Re: Review Request 19779: Fixed[CLOUDSTACK-5150]:-Creating template from a VM in Simulator results in incorrect size

2014-06-17 Thread daan Hoogland

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19779/#review45928
---

Ship it!


883d8f11196e9ca55324bcf075880e077a2d3df3 in 4.4-forward

- daan Hoogland


On June 17, 2014, 9:37 a.m., Girish Chaudhari wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19779/
> ---
> 
> (Updated June 17, 2014, 9:37 a.m.)
> 
> 
> Review request for cloudstack, daan Hoogland and Prasanna Santhanam.
> 
> 
> Bugs: CLOUDSTACK-5150
> https://issues.apache.org/jira/browse/CLOUDSTACK-5150
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Problem Statement:- In Simulator, When provisioning the VM using the personal 
> template, results into the NullPointerException. 
> Root Cause:- The template creation command is setting up the size as NULL in 
> the tempalte_store_ref table and which is something causing this issue. 
> Solution: To set up the size to 100 ( any Non-Null value) in the template 
> create mocking process, which ultimately setting up the size to 100 in the 
> tempalte_store_ref table and hence solving the issue.
> 
> 
> Diffs
> -
> 
>   
> plugins/hypervisors/simulator/src/com/cloud/resource/SimulatorStorageProcessor.java
>  8a78b87 
> 
> Diff: https://reviews.apache.org/r/19779/diff/
> 
> 
> Testing
> ---
> 
> Tested it on the 4.3, the size in tempalte_store_ref table is getting 
> populated as 100 and could instantiate the VM using the personal template.
> 
> 
> Thanks,
> 
> Girish Chaudhari
> 
>



Re: Review Request 19779: Fixed[CLOUDSTACK-5150]:-Creating template from a VM in Simulator results in incorrect size

2014-06-17 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19779/#review45929
---


Commit 591148c4641fd079d7b9b85d30e0c297212984e1 in cloudstack's branch 
refs/heads/master from Girish chaudhari
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=591148c ]

CLOUDSTACK-5150 - set the template size from source

Signed-off-by: Daan Hoogland 
(cherry picked from commit 883d8f11196e9ca55324bcf075880e077a2d3df3)


- ASF Subversion and Git Services


On June 17, 2014, 9:37 a.m., Girish Chaudhari wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19779/
> ---
> 
> (Updated June 17, 2014, 9:37 a.m.)
> 
> 
> Review request for cloudstack, daan Hoogland and Prasanna Santhanam.
> 
> 
> Bugs: CLOUDSTACK-5150
> https://issues.apache.org/jira/browse/CLOUDSTACK-5150
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Problem Statement:- In Simulator, When provisioning the VM using the personal 
> template, results into the NullPointerException. 
> Root Cause:- The template creation command is setting up the size as NULL in 
> the tempalte_store_ref table and which is something causing this issue. 
> Solution: To set up the size to 100 ( any Non-Null value) in the template 
> create mocking process, which ultimately setting up the size to 100 in the 
> tempalte_store_ref table and hence solving the issue.
> 
> 
> Diffs
> -
> 
>   
> plugins/hypervisors/simulator/src/com/cloud/resource/SimulatorStorageProcessor.java
>  8a78b87 
> 
> Diff: https://reviews.apache.org/r/19779/diff/
> 
> 
> Testing
> ---
> 
> Tested it on the 4.3, the size in tempalte_store_ref table is getting 
> populated as 100 and could instantiate the VM using the personal template.
> 
> 
> Thanks,
> 
> Girish Chaudhari
> 
>



Re: Review Request 19779: Fixed[CLOUDSTACK-5150]:-Creating template from a VM in Simulator results in incorrect size

2014-06-17 Thread daan Hoogland


> On June 17, 2014, 11:42 a.m., daan Hoogland wrote:
> > 883d8f11196e9ca55324bcf075880e077a2d3df3 in 4.4-forward

591148c4641fd079d7b9b85d30e0c297212984e1 on master


- daan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19779/#review45928
---


On June 17, 2014, 9:37 a.m., Girish Chaudhari wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19779/
> ---
> 
> (Updated June 17, 2014, 9:37 a.m.)
> 
> 
> Review request for cloudstack, daan Hoogland and Prasanna Santhanam.
> 
> 
> Bugs: CLOUDSTACK-5150
> https://issues.apache.org/jira/browse/CLOUDSTACK-5150
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Problem Statement:- In Simulator, When provisioning the VM using the personal 
> template, results into the NullPointerException. 
> Root Cause:- The template creation command is setting up the size as NULL in 
> the tempalte_store_ref table and which is something causing this issue. 
> Solution: To set up the size to 100 ( any Non-Null value) in the template 
> create mocking process, which ultimately setting up the size to 100 in the 
> tempalte_store_ref table and hence solving the issue.
> 
> 
> Diffs
> -
> 
>   
> plugins/hypervisors/simulator/src/com/cloud/resource/SimulatorStorageProcessor.java
>  8a78b87 
> 
> Diff: https://reviews.apache.org/r/19779/diff/
> 
> 
> Testing
> ---
> 
> Tested it on the 4.3, the size in tempalte_store_ref table is getting 
> populated as 100 and could instantiate the VM using the personal template.
> 
> 
> Thanks,
> 
> Girish Chaudhari
> 
>



Re: Review Request 19779: Fixed[CLOUDSTACK-5150]:-Creating template from a VM in Simulator results in incorrect size

2014-06-17 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19779/#review45931
---


Commit 5cc5483a7895e7876e336349323a5ea5598d5137 in cloudstack's branch 
refs/heads/4.4 from Girish chaudhari
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5cc5483 ]

CLOUDSTACK-5150 - set the template size from source

Signed-off-by: Daan Hoogland 
(cherry picked from commit 883d8f11196e9ca55324bcf075880e077a2d3df3)


- ASF Subversion and Git Services


On June 17, 2014, 9:37 a.m., Girish Chaudhari wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19779/
> ---
> 
> (Updated June 17, 2014, 9:37 a.m.)
> 
> 
> Review request for cloudstack, daan Hoogland and Prasanna Santhanam.
> 
> 
> Bugs: CLOUDSTACK-5150
> https://issues.apache.org/jira/browse/CLOUDSTACK-5150
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Problem Statement:- In Simulator, When provisioning the VM using the personal 
> template, results into the NullPointerException. 
> Root Cause:- The template creation command is setting up the size as NULL in 
> the tempalte_store_ref table and which is something causing this issue. 
> Solution: To set up the size to 100 ( any Non-Null value) in the template 
> create mocking process, which ultimately setting up the size to 100 in the 
> tempalte_store_ref table and hence solving the issue.
> 
> 
> Diffs
> -
> 
>   
> plugins/hypervisors/simulator/src/com/cloud/resource/SimulatorStorageProcessor.java
>  8a78b87 
> 
> Diff: https://reviews.apache.org/r/19779/diff/
> 
> 
> Testing
> ---
> 
> Tested it on the 4.3, the size in tempalte_store_ref table is getting 
> populated as 100 and could instantiate the VM using the personal template.
> 
> 
> Thanks,
> 
> Girish Chaudhari
> 
>



Re: [ACS44] Cherry Pick Request

2014-06-17 Thread Daan Hoogland
applied and pushed,

I have one remark; when fixing issues I would like to see a ref to the
issue (in this case no jira issue but 'coverity:') and a description
of what was solved. your style of commit comments requires a lot of
contextual knowledge. Can you try to make sure someone reading your
commit comment doesn't need to know the contents of the related issues
to get it?

thanks,
Daan

On Tue, Jun 17, 2014 at 1:26 PM, Santhosh Edukulla
 wrote:
> Resolved the conflicts for the mentioned commit.
>
> https://reviews.apache.org/r/22677/
>
> Santhosh
> 
> From: Daan Hoogland [daan.hoogl...@gmail.com]
> Sent: Monday, June 16, 2014 12:09 PM
> To: dev
> Subject: Re: [ACS44] Cherry Pick Request
>
> On Mon, Jun 16, 2014 at 4:28 PM, Santhosh Edukulla
>  wrote:
>> Daan,
>>
>> Please pick up the below fixes for resource leaks and other Coverity issues.
>>
>> 4ba3aae2ea0290ca012623083e13625e08a9dde5
> was in already?
>
>> 3c5f64c97ab071451aee7f232d8f2cec6d89044d
> in
>
>> dbfce8b11e25855a8cb21ec2bbbfe20940bb788d
> had conflicts
>
>>
>>
>> As well, please check the below commit, its fix for CLOUDSTACK-6793
>>
>> 91d054cb00f6a5818f2be1c7e4d3f44a2c58bfcc
> was in already?
>
>>
>> Thanks!
>> Santhosh
>
>
>
> --
> Daan



-- 
Daan


Re: Review Request 22677: coverity issues: fixed conflicts in 4.4

2014-06-17 Thread Santhosh Edukulla

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22677/#review45932
---

Ship it!


Ship It!

- Santhosh Edukulla


On June 17, 2014, 11:15 a.m., Santhosh Edukulla wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22677/
> ---
> 
> (Updated June 17, 2014, 11:15 a.m.)
> 
> 
> Review request for cloudstack and daan Hoogland.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fixed coverity issues, had conflicts earlier while applying to 4.4. Fixed 
> them.
> 
> 
> Diffs
> -
> 
>   engine/schema/src/com/cloud/upgrade/dao/Upgrade421to430.java 7e26132 
>   engine/schema/src/com/cloud/vm/VMInstanceVO.java 849e042 
>   
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java
>  681fcee 
>   server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 
> 05fbad3 
>   utils/src/com/cloud/utils/net/NetUtils.java 6350986 
> 
> Diff: https://reviews.apache.org/r/22677/diff/
> 
> 
> Testing
> ---
> 
> Built and deployed a data center 
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>



Re: Review Request 22677: coverity issues: fixed conflicts in 4.4

2014-06-17 Thread Santhosh Edukulla


> On June 17, 2014, 12:05 p.m., Santhosh Edukulla wrote:
> > Ship It!

CommitId: 61cf175f1c2a45f237d20ab7b729876c072f9e89


- Santhosh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22677/#review45932
---


On June 17, 2014, 11:15 a.m., Santhosh Edukulla wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22677/
> ---
> 
> (Updated June 17, 2014, 11:15 a.m.)
> 
> 
> Review request for cloudstack and daan Hoogland.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fixed coverity issues, had conflicts earlier while applying to 4.4. Fixed 
> them.
> 
> 
> Diffs
> -
> 
>   engine/schema/src/com/cloud/upgrade/dao/Upgrade421to430.java 7e26132 
>   engine/schema/src/com/cloud/vm/VMInstanceVO.java 849e042 
>   
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java
>  681fcee 
>   server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 
> 05fbad3 
>   utils/src/com/cloud/utils/net/NetUtils.java 6350986 
> 
> Diff: https://reviews.apache.org/r/22677/diff/
> 
> 
> Testing
> ---
> 
> Built and deployed a data center 
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>



RE: [ACS44] Cherry Pick Request

2014-06-17 Thread Santhosh Edukulla
Sure.

From: Daan Hoogland [daan.hoogl...@gmail.com]
Sent: Tuesday, June 17, 2014 7:55 AM
To: dev
Subject: Re: [ACS44] Cherry Pick Request

applied and pushed,

I have one remark; when fixing issues I would like to see a ref to the
issue (in this case no jira issue but 'coverity:') and a description
of what was solved. your style of commit comments requires a lot of
contextual knowledge. Can you try to make sure someone reading your
commit comment doesn't need to know the contents of the related issues
to get it?

thanks,
Daan

On Tue, Jun 17, 2014 at 1:26 PM, Santhosh Edukulla
 wrote:
> Resolved the conflicts for the mentioned commit.
>
> https://reviews.apache.org/r/22677/
>
> Santhosh
> 
> From: Daan Hoogland [daan.hoogl...@gmail.com]
> Sent: Monday, June 16, 2014 12:09 PM
> To: dev
> Subject: Re: [ACS44] Cherry Pick Request
>
> On Mon, Jun 16, 2014 at 4:28 PM, Santhosh Edukulla
>  wrote:
>> Daan,
>>
>> Please pick up the below fixes for resource leaks and other Coverity issues.
>>
>> 4ba3aae2ea0290ca012623083e13625e08a9dde5
> was in already?
>
>> 3c5f64c97ab071451aee7f232d8f2cec6d89044d
> in
>
>> dbfce8b11e25855a8cb21ec2bbbfe20940bb788d
> had conflicts
>
>>
>>
>> As well, please check the below commit, its fix for CLOUDSTACK-6793
>>
>> 91d054cb00f6a5818f2be1c7e4d3f44a2c58bfcc
> was in already?
>
>>
>> Thanks!
>> Santhosh
>
>
>
> --
> Daan



--
Daan


Re: [ACS 4.4] cherry-pick

2014-06-17 Thread Daan Hoogland
I don't think I was clear. I don't need a new patch. I did resolve the
conflict. I need you to check if I did the right thing in branch 4.4
in EventTypes near line 550

your new patch doesn't apply to 4.4 or 4.4-forward

> git am -s 
> ~/Downloads/0001-CLOUDSTACK-6922-Updated-events-for-firewall-ingress-.patch
Applying: CLOUDSTACK-6922: Updated events for firewall ingress and egress
error: patch failed: api/src/com/cloud/event/EventTypes.java:126
error: api/src/com/cloud/event/EventTypes.java: patch does not apply
error: patch failed: api/src/com/cloud/network/firewall/FirewallService.java:40
error: api/src/com/cloud/network/firewall/FirewallService.java: patch
does not apply
error: patch failed:
api/src/org/apache/cloudstack/api/command/user/firewall/CreateEgressFirewallRuleCmd.java:154
error: 
api/src/org/apache/cloudstack/api/command/user/firewall/CreateEgressFirewallRuleCmd.java:
patch does not apply
error: patch failed:
api/src/org/apache/cloudstack/api/command/user/firewall/CreateFirewallRuleCmd.java:134
error: 
api/src/org/apache/cloudstack/api/command/user/firewall/CreateFirewallRuleCmd.java:
patch does not apply
error: patch failed:
api/src/org/apache/cloudstack/api/command/user/firewall/DeleteEgressFirewallRuleCmd.java:74
error: 
api/src/org/apache/cloudstack/api/command/user/firewall/DeleteEgressFirewallRuleCmd.java:
patch does not apply
error: patch failed:
api/src/org/apache/cloudstack/api/command/user/firewall/DeleteFirewallRuleCmd.java:96
error: 
api/src/org/apache/cloudstack/api/command/user/firewall/DeleteFirewallRuleCmd.java:
patch does not apply
error: patch failed:
api/src/org/apache/cloudstack/api/command/user/firewall/UpdateEgressFirewallRuleCmd.java:78
error: 
api/src/org/apache/cloudstack/api/command/user/firewall/UpdateEgressFirewallRuleCmd.java:
patch does not apply
error: patch failed:
api/src/org/apache/cloudstack/api/command/user/firewall/UpdateFirewallRuleCmd.java:79
error: 
api/src/org/apache/cloudstack/api/command/user/firewall/UpdateFirewallRuleCmd.java:
patch does not apply
error: patch failed:
server/src/com/cloud/network/firewall/FirewallManagerImpl.java:161
error: server/src/com/cloud/network/firewall/FirewallManagerImpl.java:
patch does not apply
error: patch failed:
server/test/com/cloud/network/MockFirewallManagerImpl.java:70
error: server/test/com/cloud/network/MockFirewallManagerImpl.java:
patch does not apply
Patch failed at 0001 CLOUDSTACK-6922: Updated events for firewall
ingress and egress

On Tue, Jun 17, 2014 at 1:41 PM, Jayapal Reddy Uradi
 wrote:
> Hi Daan,
>
> Resolved the conflicts and uploaded patch in review board.
> https://reviews.apache.org/r/22679/
>
> Thanks,
> Jayapal
>
> On 17-Jun-2014, at 4:52 PM, Daan Hoogland 
>  wrote:
>
>> On Tue, Jun 17, 2014 at 8:41 AM, Jayapal Reddy Uradi
>>  wrote:
>>> 2214bd2502a34ee8e671eb6b4efe8cd26e29ac5a
>>
>>
>> I had conflicts. Can you have a look near line 550? I resolved by
>> changing IpAddress to PublicIpAddress.
>>
>> regards
>> --
>> Daan
>



-- 
Daan


Re: [ACS44] cherry-pick request

2014-06-17 Thread Daan Hoogland
On Tue, Jun 17, 2014 at 2:26 PM, Murali Reddy  wrote:
> 8ca8a7217ec155a37b24e3d9cfc3d5fc67adef2d


is in

-- 
Daan


[ACS44] cherry-pick request

2014-06-17 Thread Murali Reddy

Daan, please cherry-pick below commit in 4.4-forward into 4.4

commit 8ca8a7217ec155a37b24e3d9cfc3d5fc67adef2d
CLOUDSTACK-6925: [OVS] get rid custom logic to create bridges on hosts
in the XenServer pool for GRE tunnel networks


Fix uses XenServer recommended way
Network.other_config:assume_network_is_shared=true
which ensures bridge is created automatically on hosts in the pool for
GRE tunnel networks. Fix also gets rid of  error prone custom logic
that ensures
bridge is created by plugging a VIF into the dom0 and connected to
GRE tunnel network.



Jenkins build is back to normal : cloudstack-4.3-maven-build #536

2014-06-17 Thread jenkins
See 



Re: [DISCUSS] 4.3.1

2014-06-17 Thread sebgoa

On Jun 13, 2014, at 2:55 AM, ilya musayev  wrote:

> Sebastian,
> 
> Please cherry-pick following commits:
> 

Cherry-picked the next three.

keep them coming

> CLOUDSTACK-5891.[VMware] If a template has been registered and 
> "cpu.corespersocket...
> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commitdiff;h=008b029a29460d883ac7d645877e6f4f2945b1e1
> 
> CLOUDSTACK-6317 [VMware] Tagged VLAN support broken for 
> Management/Control/Storage traffic
> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=5bc72ea25000456b4a479baac8f9e0690794c0d2
> 
> CLOUDSTACK-6478: Failed to download Template when having 3 SSVM's in one zone 
> on Vmware.
> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=8e286996c8cdb58255a631b3bd977ad4b4baebd2
> 
> I would ask if we can revert not so useful functionality that actually makes 
> cloudstack very inflexible:
> https://issues.apache.org/jira/browse/CLOUDSTACK-3911
> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=a3b1a49c303a929c754561ca07fd8a9ed84e0382
> 
> Thanks
> ilya
> 
> PS: In the next week or two, i should have a lighter work load and willing to 
> help with testing or whatever else you may need to help with.
> 
> 
> On 6/12/14, 7:17 AM, sebgoa wrote:
>> While we are talking about 4.4
>> 
>> I am game to RM a 4.3.1 , there has been several bug fixes since 4.3.0.
>> 
>> Anybody interested, any suggestions of what would still need to be cherry 
>> picked ?
>> 
>> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.3
>> 
>> -Sebastien
> 



Re: [DISCUSS] 4.3.1

2014-06-17 Thread Nux!
Hi,

Can you guys confirm this will make it into 4.3? Fixes an ipset related bug.
https://issues.apache.org/jira/browse/CLOUDSTACK-6240

Lucian

--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro

- Original Message -
From: "sebgoa" 
To: dev@cloudstack.apache.org
Cc: muralimmre...@gmail.com
Sent: Tuesday, 17 June, 2014 2:34:34 PM
Subject: Re: [DISCUSS] 4.3.1


On Jun 13, 2014, at 2:55 AM, ilya musayev  wrote:

> Sebastian,
> 
> Please cherry-pick following commits:
> 

Cherry-picked the next three.

keep them coming

> CLOUDSTACK-5891.[VMware] If a template has been registered and 
> "cpu.corespersocket...
> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commitdiff;h=008b029a29460d883ac7d645877e6f4f2945b1e1
> 
> CLOUDSTACK-6317 [VMware] Tagged VLAN support broken for 
> Management/Control/Storage traffic
> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=5bc72ea25000456b4a479baac8f9e0690794c0d2
> 
> CLOUDSTACK-6478: Failed to download Template when having 3 SSVM's in one zone 
> on Vmware.
> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=8e286996c8cdb58255a631b3bd977ad4b4baebd2
> 
> I would ask if we can revert not so useful functionality that actually makes 
> cloudstack very inflexible:
> https://issues.apache.org/jira/browse/CLOUDSTACK-3911
> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=a3b1a49c303a929c754561ca07fd8a9ed84e0382
> 
> Thanks
> ilya
> 
> PS: In the next week or two, i should have a lighter work load and willing to 
> help with testing or whatever else you may need to help with.
> 
> 
> On 6/12/14, 7:17 AM, sebgoa wrote:
>> While we are talking about 4.4
>> 
>> I am game to RM a 4.3.1 , there has been several bug fixes since 4.3.0.
>> 
>> Anybody interested, any suggestions of what would still need to be cherry 
>> picked ?
>> 
>> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.3
>> 
>> -Sebastien
> 



RE: coverity scan report

2014-06-17 Thread Santhosh Edukulla
As well, there are two defect densities displayed at links below. Is the first 
one, an overall\all projects density metric, and other for individual 
cloudstack project ?

https://scan.coverity.com/dashboard
https://scan.coverity.com/projects/943?tab=overview

Regards,
Santhosh

From: Rajani Karuturi [rajani.karut...@citrix.com]
Sent: Tuesday, June 17, 2014 5:26 AM
To: cloudstack
Subject: coverity scan report

Is there any change in the coverity scan project settings??
the dashboard says Last Analyzed on Jun 09, 2014 
https://scan.coverity.com/projects/943?tab=overview

while jenkins job is successful 
http://jenkins.buildacloud.org/job/cloudstack-master-twiceweekly-coverity/lastBuild/


~Rajani




Re: [DISCUSS] 4.3.1

2014-06-17 Thread sebgoa

On Jun 17, 2014, at 4:04 PM, Nux!  wrote:

> Hi,
> 
> Can you guys confirm this will make it into 4.3? Fixes an ipset related bug.
> https://issues.apache.org/jira/browse/CLOUDSTACK-6240

yes, I confirm:

https://github.com/apache/cloudstack/commits/4.3


> 
> Lucian
> 
> --
> Sent from the Delta quadrant using Borg technology!
> 
> Nux!
> www.nux.ro
> 
> - Original Message -
> From: "sebgoa" 
> To: dev@cloudstack.apache.org
> Cc: muralimmre...@gmail.com
> Sent: Tuesday, 17 June, 2014 2:34:34 PM
> Subject: Re: [DISCUSS] 4.3.1
> 
> 
> On Jun 13, 2014, at 2:55 AM, ilya musayev  
> wrote:
> 
>> Sebastian,
>> 
>> Please cherry-pick following commits:
>> 
> 
> Cherry-picked the next three.
> 
> keep them coming
> 
>> CLOUDSTACK-5891.[VMware] If a template has been registered and 
>> "cpu.corespersocket...
>> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commitdiff;h=008b029a29460d883ac7d645877e6f4f2945b1e1
>> 
>> CLOUDSTACK-6317 [VMware] Tagged VLAN support broken for 
>> Management/Control/Storage traffic
>> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=5bc72ea25000456b4a479baac8f9e0690794c0d2
>> 
>> CLOUDSTACK-6478: Failed to download Template when having 3 SSVM's in one 
>> zone on Vmware.
>> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=8e286996c8cdb58255a631b3bd977ad4b4baebd2
>> 
>> I would ask if we can revert not so useful functionality that actually makes 
>> cloudstack very inflexible:
>> https://issues.apache.org/jira/browse/CLOUDSTACK-3911
>> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=a3b1a49c303a929c754561ca07fd8a9ed84e0382
>> 
>> Thanks
>> ilya
>> 
>> PS: In the next week or two, i should have a lighter work load and willing 
>> to help with testing or whatever else you may need to help with.
>> 
>> 
>> On 6/12/14, 7:17 AM, sebgoa wrote:
>>> While we are talking about 4.4
>>> 
>>> I am game to RM a 4.3.1 , there has been several bug fixes since 4.3.0.
>>> 
>>> Anybody interested, any suggestions of what would still need to be cherry 
>>> picked ?
>>> 
>>> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.3
>>> 
>>> -Sebastien
>> 
> 



Re: [DISCUSS] 4.3.1

2014-06-17 Thread Nux!
Wunderbar, thanks!

--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro

- Original Message -
From: "sebgoa" 
To: dev@cloudstack.apache.org
Sent: Tuesday, 17 June, 2014 3:43:45 PM
Subject: Re: [DISCUSS] 4.3.1


On Jun 17, 2014, at 4:04 PM, Nux!  wrote:

> Hi,
> 
> Can you guys confirm this will make it into 4.3? Fixes an ipset related bug.
> https://issues.apache.org/jira/browse/CLOUDSTACK-6240

yes, I confirm:

https://github.com/apache/cloudstack/commits/4.3


> 
> Lucian
> 
> --
> Sent from the Delta quadrant using Borg technology!
> 
> Nux!
> www.nux.ro
> 
> - Original Message -
> From: "sebgoa" 
> To: dev@cloudstack.apache.org
> Cc: muralimmre...@gmail.com
> Sent: Tuesday, 17 June, 2014 2:34:34 PM
> Subject: Re: [DISCUSS] 4.3.1
> 
> 
> On Jun 13, 2014, at 2:55 AM, ilya musayev  
> wrote:
> 
>> Sebastian,
>> 
>> Please cherry-pick following commits:
>> 
> 
> Cherry-picked the next three.
> 
> keep them coming
> 
>> CLOUDSTACK-5891.[VMware] If a template has been registered and 
>> "cpu.corespersocket...
>> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commitdiff;h=008b029a29460d883ac7d645877e6f4f2945b1e1
>> 
>> CLOUDSTACK-6317 [VMware] Tagged VLAN support broken for 
>> Management/Control/Storage traffic
>> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=5bc72ea25000456b4a479baac8f9e0690794c0d2
>> 
>> CLOUDSTACK-6478: Failed to download Template when having 3 SSVM's in one 
>> zone on Vmware.
>> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=8e286996c8cdb58255a631b3bd977ad4b4baebd2
>> 
>> I would ask if we can revert not so useful functionality that actually makes 
>> cloudstack very inflexible:
>> https://issues.apache.org/jira/browse/CLOUDSTACK-3911
>> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=a3b1a49c303a929c754561ca07fd8a9ed84e0382
>> 
>> Thanks
>> ilya
>> 
>> PS: In the next week or two, i should have a lighter work load and willing 
>> to help with testing or whatever else you may need to help with.
>> 
>> 
>> On 6/12/14, 7:17 AM, sebgoa wrote:
>>> While we are talking about 4.4
>>> 
>>> I am game to RM a 4.3.1 , there has been several bug fixes since 4.3.0.
>>> 
>>> Anybody interested, any suggestions of what would still need to be cherry 
>>> picked ?
>>> 
>>> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.3
>>> 
>>> -Sebastien
>> 
> 



[ACS431][QUESTION] db upgrace

2014-06-17 Thread Daan Hoogland
In my simple mind it seems we only need to create a
Upgrade430to431.java file and don't need any sql files. Is this going
to fly? AFAICT the only thing to go in there is the vlan fixup in the
vlan table, which is a data migration and not a schema change.

Can anyone point out to me the error in my ways, please?

thanks,
-- 
Daan


Can't build codebase

2014-06-17 Thread Mike Tutkowski
Hi,

Is anyone else seeing this issue when trying to build the codebase under
either 4.4 or master?

Thanks!

[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-remote-resources-plugin:1.3:process
(default) on project cloud-client-ui: Error resolving project artifact:
Could not transfer artifact
net.juniper.contrail:juniper-contrail-api:pom:1.0-SNAPSHOT from/to
apache.snapshots (http://repository.apache.org/snapshots): Failed to
transfer file:
http://repository.apache.org/snapshots/net/juniper/contrail/juniper-contrail-api/1.0-SNAPSHOT/juniper-contrail-api-1.0-SNAPSHOT.pom.
Return code is: 503, ReasonPhrase:Service Temporarily Unavailable. for
project net.juniper.contrail:juniper-contrail-api:jar:1.0-SNAPSHOT -> [Help
1]

-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
*™*


Re: Review Request 22631: supporting nfs protocol and resize feature for managed storage in xenserver.

2014-06-17 Thread Mike Tutkowski


> On June 16, 2014, 3:30 p.m., Mike Tutkowski wrote:
> > I was curious about the resizing of the VDI to take up all of the space of 
> > the SR.
> > 
> > This is actually what I initially did in 4.2; however, it later dawned on 
> > me that - if you want to take hypervisor snapshots - then you need to have 
> > extra space left over in the SR. In other words, the VDI should be less 
> > than the size of the SR.
> > 
> > To support this, I added a new field in 4.3: hypervisor_ss_reserve. This 
> > field is a percentage of the size of the CloudStack volume (the VDI).
> > 
> > For example, if the user wants a 20 GB CloudStack volume (VDI) and the 
> > hypervisor snapshot reserve field is set at 200%, the SR will be 60 GB (20 
> > GB for the VDI + (20 GB * 2)).
> > 
> > Please let me know if you'd like more clarification on this. You can also 
> > examine the SolidFire plug-in to get a feel for how this new field is 
> > utilized.
> 
> punith s wrote:
> thanks mike, since i'm still implementing snapshot i forgot to take a 
> look at this field.
> 
> following your logic, now i'm resizing the vdi only to the cloudstack 
> volume size instead of SR size, hence not using the entire SR size which 
> contains the hypervisor snapshot reserve.
> 
> when a user resizes the volume, let the storage plugin resize the backend 
> provider volume using the given snapshot reserve.
> 
> eg: from your industry standard logic,
> if the current offering is at 10G and 25% reserve, this equates to 
> 12.5 G volume in cloudbyte. but the cloudstack volume remains at 10G in the 
> DB.
> when the user resizes the volume to a different offering say 20G and 
> 50% reserve, this equates to 30G volume in cloudbyte and  the cloudstack 
> volume is resized to 20G in the DB.
> 
> hence now i'm mapping the vdi size to cloudstack volume size.
> 
> thanks.

You should actually get hypervisor snapshots for "free." Now, 
CloudByte-specific snapshots are a different story, but hypervisor snapshots 
should just work with the changes I put in for managed storage.


- Mike


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22631/#review45757
---


On June 17, 2014, 9:28 a.m., punith s wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22631/
> ---
> 
> (Updated June 17, 2014, 9:28 a.m.)
> 
> 
> Review request for cloudstack, amit kumar das, edison su, and Mike Tutkowski.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> currently managed storage only supports iscsi protocol.
> 
> hence now adding support for nfs protocol and also resizing the vdi to the SR 
> size, hence fully utilizing the SR space in managed storage.
> 
> to support nfs, the getNfsSR method's signature has to changed similar to 
> existing getIscsiSR method.
> 
> SR will be created based on the volume's protocoltype.
> 
> jira id - CLOUDSTACK-6916
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/agent/api/to/DiskTO.java 5901367 
>   
> engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java
>  eea931e 
>   
> plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
>  9979802 
>   server/src/com/cloud/storage/VolumeApiServiceImpl.java 9b034e9 
> 
> Diff: https://reviews.apache.org/r/22631/diff/
> 
> 
> Testing
> ---
> 
> system testing done.
> 
> 
> Thanks,
> 
> punith s
> 
>



Re: Can't build codebase

2014-06-17 Thread Ian Duffy
Mike,

This seems like an issue with repository.apache.org.

Might be a job for infra?


On 17 June 2014 16:48, Mike Tutkowski  wrote:

> Hi,
>
> Is anyone else seeing this issue when trying to build the codebase under
> either 4.4 or master?
>
> Thanks!
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-remote-resources-plugin:1.3:process
> (default) on project cloud-client-ui: Error resolving project artifact:
> Could not transfer artifact
> net.juniper.contrail:juniper-contrail-api:pom:1.0-SNAPSHOT from/to
> apache.snapshots (http://repository.apache.org/snapshots): Failed to
> transfer file:
>
> http://repository.apache.org/snapshots/net/juniper/contrail/juniper-contrail-api/1.0-SNAPSHOT/juniper-contrail-api-1.0-SNAPSHOT.pom
> .
> Return code is: 503, ReasonPhrase:Service Temporarily Unavailable. for
> project net.juniper.contrail:juniper-contrail-api:jar:1.0-SNAPSHOT -> [Help
> 1]
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the cloud
> *™*
>


Re: Can't build codebase

2014-06-17 Thread Mike Tutkowski
This failed twice this morning, but seems to be OK for me now.


On Tue, Jun 17, 2014 at 9:48 AM, Mike Tutkowski <
mike.tutkow...@solidfire.com> wrote:

> Hi,
>
> Is anyone else seeing this issue when trying to build the codebase under
> either 4.4 or master?
>
> Thanks!
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-remote-resources-plugin:1.3:process
> (default) on project cloud-client-ui: Error resolving project artifact:
> Could not transfer artifact
> net.juniper.contrail:juniper-contrail-api:pom:1.0-SNAPSHOT from/to
> apache.snapshots (http://repository.apache.org/snapshots): Failed to
> transfer file:
> http://repository.apache.org/snapshots/net/juniper/contrail/juniper-contrail-api/1.0-SNAPSHOT/juniper-contrail-api-1.0-SNAPSHOT.pom.
> Return code is: 503, ReasonPhrase:Service Temporarily Unavailable. for
> project net.juniper.contrail:juniper-contrail-api:jar:1.0-SNAPSHOT -> [Help
> 1]
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the cloud
> *™*
>



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
*™*


Re: Can't build codebase

2014-06-17 Thread Ian Duffy
http://repository.apache.org/snapshots/net/juniper/contrail/juniper-contrail-api/1.0-SNAPSHOT/juniper-contrail-api-1.0-SNAPSHOT.pom
returns a 404.

Searching on apache's nexus also returns nothing for juniper or contrail
https://repository.apache.org/index.html

I'd imagine you are working from .m2 cache.


On 17 June 2014 17:19, Mike Tutkowski  wrote:

> This failed twice this morning, but seems to be OK for me now.
>
>
> On Tue, Jun 17, 2014 at 9:48 AM, Mike Tutkowski <
> mike.tutkow...@solidfire.com> wrote:
>
> > Hi,
> >
> > Is anyone else seeing this issue when trying to build the codebase under
> > either 4.4 or master?
> >
> > Thanks!
> >
> > [ERROR] Failed to execute goal
> > org.apache.maven.plugins:maven-remote-resources-plugin:1.3:process
> > (default) on project cloud-client-ui: Error resolving project artifact:
> > Could not transfer artifact
> > net.juniper.contrail:juniper-contrail-api:pom:1.0-SNAPSHOT from/to
> > apache.snapshots (http://repository.apache.org/snapshots): Failed to
> > transfer file:
> >
> http://repository.apache.org/snapshots/net/juniper/contrail/juniper-contrail-api/1.0-SNAPSHOT/juniper-contrail-api-1.0-SNAPSHOT.pom
> .
> > Return code is: 503, ReasonPhrase:Service Temporarily Unavailable. for
> > project net.juniper.contrail:juniper-contrail-api:jar:1.0-SNAPSHOT ->
> [Help
> > 1]
> >
> > --
> > *Mike Tutkowski*
> > *Senior CloudStack Developer, SolidFire Inc.*
> > e: mike.tutkow...@solidfire.com
> > o: 303.746.7302
> > Advancing the way the world uses the cloud
> > *™*
> >
>
>
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the cloud
> *™*
>


Re: Can't build codebase

2014-06-17 Thread Mike Tutkowski
This morning, when I ran that URL, it returned that the service was
unavailable (which is consistent with what Maven said).

Now, as you pointed out, it returns a 404.

It all seems to work now, but before it was failing on both my Mac OS X and
Ubuntu environments.


On Tue, Jun 17, 2014 at 10:31 AM, Ian Duffy  wrote:

>
> http://repository.apache.org/snapshots/net/juniper/contrail/juniper-contrail-api/1.0-SNAPSHOT/juniper-contrail-api-1.0-SNAPSHOT.pom
> returns a 404.
>
> Searching on apache's nexus also returns nothing for juniper or contrail
> https://repository.apache.org/index.html
>
> I'd imagine you are working from .m2 cache.
>
>
> On 17 June 2014 17:19, Mike Tutkowski 
> wrote:
>
> > This failed twice this morning, but seems to be OK for me now.
> >
> >
> > On Tue, Jun 17, 2014 at 9:48 AM, Mike Tutkowski <
> > mike.tutkow...@solidfire.com> wrote:
> >
> > > Hi,
> > >
> > > Is anyone else seeing this issue when trying to build the codebase
> under
> > > either 4.4 or master?
> > >
> > > Thanks!
> > >
> > > [ERROR] Failed to execute goal
> > > org.apache.maven.plugins:maven-remote-resources-plugin:1.3:process
> > > (default) on project cloud-client-ui: Error resolving project artifact:
> > > Could not transfer artifact
> > > net.juniper.contrail:juniper-contrail-api:pom:1.0-SNAPSHOT from/to
> > > apache.snapshots (http://repository.apache.org/snapshots): Failed to
> > > transfer file:
> > >
> >
> http://repository.apache.org/snapshots/net/juniper/contrail/juniper-contrail-api/1.0-SNAPSHOT/juniper-contrail-api-1.0-SNAPSHOT.pom
> > .
> > > Return code is: 503, ReasonPhrase:Service Temporarily Unavailable. for
> > > project net.juniper.contrail:juniper-contrail-api:jar:1.0-SNAPSHOT ->
> > [Help
> > > 1]
> > >
> > > --
> > > *Mike Tutkowski*
> > > *Senior CloudStack Developer, SolidFire Inc.*
> > > e: mike.tutkow...@solidfire.com
> > > o: 303.746.7302
> > > Advancing the way the world uses the cloud
> > > *™*
> > >
> >
> >
> >
> > --
> > *Mike Tutkowski*
> > *Senior CloudStack Developer, SolidFire Inc.*
> > e: mike.tutkow...@solidfire.com
> > o: 303.746.7302
> > Advancing the way the world uses the cloud
> > *™*
> >
>



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
*™*


Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-06-17 Thread Alena Prokharchyk

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20099/#review45955
---


One more comment regarding spring-server-core-managers-context.xml. As your 
code comes as a CS plugin, all the managers of your plugin should be defined in 
your plugin's *-context.xml file, not spring-server-core-managers-context.xml. 
These are the classes of your plugin:







 







If you want to look at the example, look at any CS plugin, for example 
cloud-plugin-hypervisor-vmware (refer to spring-vmware-core-context.xml file to 
see how the managers are defined there)

- Alena Prokharchyk


On June 15, 2014, 9:40 p.m., Alex Ough wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20099/
> ---
> 
> (Updated June 15, 2014, 9:40 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> This is the review request for the core changes related with #17790 that has 
> only the new plugin codes.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/event/EventTypes.java 39ef710 
>   api/src/com/cloud/user/AccountService.java 7e37b38 
>   api/src/com/cloud/user/DomainService.java 4c1f93d 
>   api/src/org/apache/cloudstack/api/ApiConstants.java fdb4558 
>   api/src/org/apache/cloudstack/api/BaseCmd.java f6f21ae 
>   
> api/src/org/apache/cloudstack/api/command/admin/account/CreateAccountCmd.java 
> 50d67d9 
>   
> api/src/org/apache/cloudstack/api/command/admin/account/DeleteAccountCmd.java 
> 5754ec5 
>   
> api/src/org/apache/cloudstack/api/command/admin/account/DisableAccountCmd.java
>  3e5e1d3 
>   
> api/src/org/apache/cloudstack/api/command/admin/account/EnableAccountCmd.java 
> f30c985 
>   api/src/org/apache/cloudstack/api/command/admin/account/LockAccountCmd.java 
> 3c185e4 
>   
> api/src/org/apache/cloudstack/api/command/admin/account/UpdateAccountCmd.java 
> a7ce74a 
>   api/src/org/apache/cloudstack/api/command/admin/domain/CreateDomainCmd.java 
> 312c9ee 
>   api/src/org/apache/cloudstack/api/command/admin/domain/DeleteDomainCmd.java 
> a6d2b0b 
>   api/src/org/apache/cloudstack/api/command/admin/domain/UpdateDomainCmd.java 
> 409a84d 
>   api/src/org/apache/cloudstack/api/command/admin/region/AddRegionCmd.java 
> f6743ba 
>   api/src/org/apache/cloudstack/api/command/admin/region/UpdateRegionCmd.java 
> b08cbbb 
>   api/src/org/apache/cloudstack/api/command/admin/user/CreateUserCmd.java 
> 51e218d 
>   api/src/org/apache/cloudstack/api/command/admin/user/DeleteUserCmd.java 
> 08ba521 
>   api/src/org/apache/cloudstack/api/command/admin/user/DisableUserCmd.java 
> c6e09ef 
>   api/src/org/apache/cloudstack/api/command/admin/user/EnableUserCmd.java 
> d69eccf 
>   api/src/org/apache/cloudstack/api/command/admin/user/LockUserCmd.java 
> 69623d0 
>   api/src/org/apache/cloudstack/api/command/admin/user/RegisterCmd.java 
> 2090d21 
>   api/src/org/apache/cloudstack/api/command/admin/user/UpdateUserCmd.java 
> cf5d355 
>   api/src/org/apache/cloudstack/api/response/RegionResponse.java 6c74fa6 
>   api/src/org/apache/cloudstack/region/Region.java df64e44 
>   api/src/org/apache/cloudstack/region/RegionService.java afefcc7 
>   api/test/org/apache/cloudstack/api/command/test/RegionCmdTest.java 10c3d85 
>   client/pom.xml d8dbde7 
>   client/tomcatconf/commands.properties.in 45debe4 
>   
> engine/schema/resources/META-INF/cloudstack/core/spring-engine-schema-core-daos-context.xml
>  489b37d 
>   engine/schema/src/com/cloud/user/AccountVO.java 0f5a044 
>   engine/schema/src/org/apache/cloudstack/region/RegionVO.java 608bd2b 
>   
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/MockAccountManager.java
>  957f708 
>   plugins/pom.xml 9b391b8 
>   
> plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapCreateAccountCmd.java
>  626bb8f 
>   
> plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapImportUsersCmd.java
>  887ad00 
>   
> server/resources/META-INF/cloudstack/core/spring-server-core-managers-context.xml
>  fc1c7e2 
>   server/src/com/cloud/api/ApiResponseHelper.java 38f2f0b 
>   server/src/com/cloud/api/dispatch/ParamProcessWorker.java e9bdd8b 
>   server/src/com/cloud/event/ActionEventUtils.java 28e5680 
>   server/src/com/cloud/projects/ProjectManagerImpl.java d10c059 
>   server/src/com/cloud/user/AccountManager.java 03bf842 
>   server/src/com/cloud/user/AccountManagerImpl.java 2070ee6 
>   server/src/com/cloud/user/DomainManager.java f72b18a 
>   server/src/com/cloud/user/DomainManagerImpl.java fbbe0c2 
>   server/src/org/apache/cloudstack/region/RegionManager.java 6f25481 
>   server/src/org/apache/cloudstack/re

RE: [ANNOUNCE] Amogh Vasekar as committer

2014-06-17 Thread Radhika Puthiyetath
Congrats Amogh.

(too late though!)

-Original Message-
From: John Kinsella [mailto:j...@stratosec.co] 
Sent: Monday, June 02, 2014 11:14 AM
To: 
Subject: [ANNOUNCE] Amogh Vasekar as committer

The Project Management Committee (PMC) for Apache CloudStack has asked Amogh 
Vasekar to become a committer and we are pleased to announce that he has 
accepted.

Being a committer allows many contributors to contribute more autonomously. For 
developers, it makes it easier to submit changes and eliminates the need to 
have contributions reviewed via the patch submission process. Whether 
contributions are development-related or otherwise, it is a recognition of a 
contributor's participation in the project and commitment to the project and 
the Apache Way.

Please join me in congratulating Amogh!

-John, on behalf of the CloudStack PMC


RE: [ANNOUNCE] Saksham Srivastava as committer

2014-06-17 Thread Radhika Puthiyetath
I am too late to wish you on ML. Congrats

Welcome aboard, and don't forget to drive the BLR Meetup group..:-)

-Original Message-
From: sebgoa [mailto:run...@gmail.com] 
Sent: Wednesday, May 28, 2014 11:48 PM
To: dev@cloudstack.apache.org
Subject: [ANNOUNCE] Saksham Srivastava as committer

The Project Management Committee (PMC) for Apache CloudStack has asked Saksham 
Srivastava to become a committer and we are pleased to announce that he has 
accepted.

Being a committer allows many contributors to contribute more autonomously. For 
developers, it makes it easier to submit changes and eliminates the need to 
have contributions reviewed via the patch submission process. Whether 
contributions are development-related or otherwise, it is a recognition of a 
contributor's participation in the project and commitment to the project and 
the Apache Way.

Please join me in congratulating Saksham,


-Sebastien, on behalf of the CloudStack PMC


Re: Xen Project support and state of APIs

2014-06-17 Thread Tim Mackey
On Tue, Jun 17, 2014 at 7:30 AM, Rohit Yadav  wrote:

> Tim,
>
> Thanks for replying, let me clean up everything and re-setup my test infra
> after my $dayjob hours and get back to you. The test cases in the design
> doc does not discuss Xen Project so I thought I should ask if ACS works
> with Xen Project 4.x.
>

The longer term objective is to provide support for XenProject without
XAPI, most notably with libvirt.  Effectively XenServer implies XAPI and
XenProject would imply libvirt as the tooling.


>
> The Xen/XenProject/XenServer/XAPI/XCP is confusing [1]. From what I
> understand, XCP was some sort of an opensource version of XenServer, but
> since XenServer distribution (which consists of Xen, XenCenter, XAPI, Linux
> etc.) is opensource, XCP has been discontinued since 1.6 release?
>

XCP was rolled into XenServer as of XenServer 6.2 which means 1.6 was the
last version of XCP.  I tried to sum it up in this blog:
http://open.citrix.com/blog/342-knowing-what-you-ve-got-avoiding-the-xen-vs-xenserver-confusion.html


>
> Now, on many Linux distro XAPI is still available as 'xcp-xapi' such as in
> Debian/Ubuntu, so what package(s) do you suggest one needs to install and
> configure so I can get DevCloud [2] work again? DevCloud is a VM that runs
> Xen (Xen Project) inside it and can be used as a virtual host to
> test/develop ACS against it.
>
>
I see no reason why any other XAPI implementation wouldn't work, but it's
entirely possible the version of xcp-xapi you have has issues with
XenProject 4.4 due to normal versioning type issues.  There also was a
different "productization" attempt called xenserver-core, but that looks to
have died on the vine.  That being said, I could easily have broken
something.  If I've broken something, I probably won't be able to test
until next week due to travels.  The question of xapi inclusion in distros
is one I'd need to check on.



> [1] http://www.xenproject.org/developers/teams/xapi.html
> [2] http://bhaisaab.org/logs/devcloud
>
> Regards.
>
>
>
>
> On Tue, Jun 17, 2014 at 4:27 PM, Tim Mackey  wrote:
>
> > Rohit,
> >
> > We've only supported xapi so far, so I'm curious if you had Xen Project
> 4.4
> > working before with xapi and if that is now broken. Nothing I did should
> > have impacted that, but it wasn't in my test suite so anything is
> possible
> > On Jun 17, 2014 11:21 AM, "Rohit Yadav"  wrote:
> >
> > > Hi,
> > >
> > > Xen Project (previously xen.org xenserver) is widely accessible in
> > several
> > > Linux distributions such as Arch, Fedora etc. Therefore, people may
> want
> > to
> > > use it instead of XenServer (6.2 or later). The ACS 4.5 design doc [1]
> > > explains about XenServer and how it should be tested etc. but what
> about
> > > using Xen Project?
> > >
> > > Since the recent Xen plugin refactoring as xenserver plugin [1], I'm
> > unable
> > > to get ACS to work with Xen Project 4.4 (on a real host and on a new
> > custom
> > > DevCloud). Using the XenServer ACS plugin, it identifies a Xen Project
> > host
> > > as some version of Xen but then fails. Has anyone tried this with ACS
> > > 4.4/master? Are we going to test/support Xen Project (4.x) soon? If so,
> > can
> > > people involved share their plan/vision/roadmap on it?
> > >
> > > Lastly, as the design doc [1] suggested XCP's development has stopped,
> > are
> > > we going to favour using XAPI [1] now or libVirt [2] or something else?
> > >
> > > [1]
> > >
> > >
> >
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Convert+Xen+usage+to+XenServer
> > >
> > > [2] http://blog.xen.org/index.php/2014/03/10/xen-4-4-released
> > >
> > > Regards.
> > >
> >
>


Re: Can't build codebase

2014-06-17 Thread Amogh Vasekar
Kept failing for me yesterday too.

Thanks,
Amogh

On 6/17/14 9:44 AM, "Mike Tutkowski"  wrote:

>This morning, when I ran that URL, it returned that the service was
>unavailable (which is consistent with what Maven said).
>
>Now, as you pointed out, it returns a 404.
>
>It all seems to work now, but before it was failing on both my Mac OS X
>and
>Ubuntu environments.
>
>
>On Tue, Jun 17, 2014 at 10:31 AM, Ian Duffy  wrote:
>
>>
>> 
>>http://repository.apache.org/snapshots/net/juniper/contrail/juniper-contr
>>ail-api/1.0-SNAPSHOT/juniper-contrail-api-1.0-SNAPSHOT.pom
>> returns a 404.
>>
>> Searching on apache's nexus also returns nothing for juniper or contrail
>> https://repository.apache.org/index.html
>>
>> I'd imagine you are working from .m2 cache.
>>
>>
>> On 17 June 2014 17:19, Mike Tutkowski 
>> wrote:
>>
>> > This failed twice this morning, but seems to be OK for me now.
>> >
>> >
>> > On Tue, Jun 17, 2014 at 9:48 AM, Mike Tutkowski <
>> > mike.tutkow...@solidfire.com> wrote:
>> >
>> > > Hi,
>> > >
>> > > Is anyone else seeing this issue when trying to build the codebase
>> under
>> > > either 4.4 or master?
>> > >
>> > > Thanks!
>> > >
>> > > [ERROR] Failed to execute goal
>> > > org.apache.maven.plugins:maven-remote-resources-plugin:1.3:process
>> > > (default) on project cloud-client-ui: Error resolving project
>>artifact:
>> > > Could not transfer artifact
>> > > net.juniper.contrail:juniper-contrail-api:pom:1.0-SNAPSHOT from/to
>> > > apache.snapshots (http://repository.apache.org/snapshots): Failed to
>> > > transfer file:
>> > >
>> >
>> 
>>http://repository.apache.org/snapshots/net/juniper/contrail/juniper-contr
>>ail-api/1.0-SNAPSHOT/juniper-contrail-api-1.0-SNAPSHOT.pom
>> > .
>> > > Return code is: 503, ReasonPhrase:Service Temporarily Unavailable.
>>for
>> > > project net.juniper.contrail:juniper-contrail-api:jar:1.0-SNAPSHOT
>>->
>> > [Help
>> > > 1]
>> > >
>> > > --
>> > > *Mike Tutkowski*
>> > > *Senior CloudStack Developer, SolidFire Inc.*
>> > > e: mike.tutkow...@solidfire.com
>> > > o: 303.746.7302
>> > > Advancing the way the world uses the cloud
>> > > **
>> > >
>> >
>> >
>> >
>> > --
>> > *Mike Tutkowski*
>> > *Senior CloudStack Developer, SolidFire Inc.*
>> > e: mike.tutkow...@solidfire.com
>> > o: 303.746.7302
>> > Advancing the way the world uses the cloud
>> > **
>> >
>>
>
>
>
>-- 
>*Mike Tutkowski*
>*Senior CloudStack Developer, SolidFire Inc.*
>e: mike.tutkow...@solidfire.com
>o: 303.746.7302
>Advancing the way the world uses the cloud
>**



Review Request 22692: Test Suite for Testing Remote Access VPN on VPC

2014-06-17 Thread Chandan Purushothama

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22692/
---

Review request for cloudstack, Girish Shilamkar, Raja Pullela, sanjeev n, 
Santhosh Edukulla, SrikanteswaraRao Talluri, and Sheng Yang.


Repository: cloudstack-git


Description
---

Test Suite for Testing Remote Access VPN on VPC. 

I successfully automated the following components:

1.VPN Client Installation on Linux
2.Component that efficiently verifies Remote VPN Access between client and the 
Server.
3.Developed a component that automates VPN Client Configuration and services.
4.Test Cases of the Feature
5.Tested the Code multiple times on XenServer and fixed the bugs.


Diffs
-

  test/integration/component/test_remotevpn_vpc.py PRE-CREATION 
  tools/marvin/marvin/config/test_data.py d870c98 

Diff: https://reviews.apache.org/r/22692/diff/


Testing
---

Test case no : Enable VPN for Public IP Address on the VPC ... === TestName: 
test_01_RemoteAccessVPN_VPC_EnableVPNAndConnecttoVM | Status : SUCCESS ===
ok
Test case no : Remote a VPN User ... === TestName: test_02_VPC_RemoveVPNUser | 
Status : SUCCESS ===
ok
Test case no : Add a Different VPN User and Test Access with already existing 
VPN User ... === TestName: test_03_VPC_AddDifferentVPNUser | Status : SUCCESS 
===
ok
Test case no : Add a Previously Removed VPN User from the VPC and Test the VPN 
Connectivity ... === TestName: 
test_04_VPC_AddPreviouslyRemovedVPNUserTestConnectivity | Status : SUCCESS ===
ok
Test case no : Disable the VPN Service on the VPC ... === TestName: 
test_05_VPC_DisableVPNServiceOnVPC | Status : SUCCESS ===
ok
Test case no : Enabled Previously Dsiabled VPN Access to VPC. ... === TestName: 
test_06_VPC_EnablePreviouslyDisabledVPNAccesstoVPC | Status : SUCCESS ===
ok
Test case no : Create Nine VPN Users to test the remote.vpn.user.limit=8 
Configuration parameter ... === TestName: 
test_07_ConfigParam_TestRemoteVPNUserLimit | Status : SUCCESS ===
ok

--
Ran 7 tests in 1771.352s

OK


Thanks,

Chandan Purushothama



Re: Review Request 22692: Test Suite for Testing Remote Access VPN on VPC

2014-06-17 Thread Chandan Purushothama

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22692/
---

(Updated June 17, 2014, 7:14 p.m.)


Review request for cloudstack, Girish Shilamkar, Raja Pullela, sangeetha 
hariharan, sanjeev n, Santhosh Edukulla, SrikanteswaraRao Talluri, and Sheng 
Yang.


Repository: cloudstack-git


Description
---

Test Suite for Testing Remote Access VPN on VPC. 

I successfully automated the following components:

1.VPN Client Installation on Linux
2.Component that efficiently verifies Remote VPN Access between client and the 
Server.
3.Developed a component that automates VPN Client Configuration and services.
4.Test Cases of the Feature
5.Tested the Code multiple times on XenServer and fixed the bugs.


Diffs
-

  test/integration/component/test_remotevpn_vpc.py PRE-CREATION 
  tools/marvin/marvin/config/test_data.py d870c98 

Diff: https://reviews.apache.org/r/22692/diff/


Testing
---

Test case no : Enable VPN for Public IP Address on the VPC ... === TestName: 
test_01_RemoteAccessVPN_VPC_EnableVPNAndConnecttoVM | Status : SUCCESS ===
ok
Test case no : Remote a VPN User ... === TestName: test_02_VPC_RemoveVPNUser | 
Status : SUCCESS ===
ok
Test case no : Add a Different VPN User and Test Access with already existing 
VPN User ... === TestName: test_03_VPC_AddDifferentVPNUser | Status : SUCCESS 
===
ok
Test case no : Add a Previously Removed VPN User from the VPC and Test the VPN 
Connectivity ... === TestName: 
test_04_VPC_AddPreviouslyRemovedVPNUserTestConnectivity | Status : SUCCESS ===
ok
Test case no : Disable the VPN Service on the VPC ... === TestName: 
test_05_VPC_DisableVPNServiceOnVPC | Status : SUCCESS ===
ok
Test case no : Enabled Previously Dsiabled VPN Access to VPC. ... === TestName: 
test_06_VPC_EnablePreviouslyDisabledVPNAccesstoVPC | Status : SUCCESS ===
ok
Test case no : Create Nine VPN Users to test the remote.vpn.user.limit=8 
Configuration parameter ... === TestName: 
test_07_ConfigParam_TestRemoteVPNUserLimit | Status : SUCCESS ===
ok

--
Ran 7 tests in 1771.352s

OK


Thanks,

Chandan Purushothama



Re: Review Request 22692: Test Suite for Testing Remote Access VPN on VPC

2014-06-17 Thread Chandan Purushothama

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22692/
---

(Updated June 17, 2014, 7:24 p.m.)


Review request for cloudstack, Girish Shilamkar, Raja Pullela, sangeetha 
hariharan, sanjeev n, Santhosh Edukulla, sudha ponnaganti, SrikanteswaraRao 
Talluri, and Sheng Yang.


Repository: cloudstack-git


Description
---

Test Suite for Testing Remote Access VPN on VPC. 

I successfully automated the following components:

1.VPN Client Installation on Linux
2.Component that efficiently verifies Remote VPN Access between client and the 
Server.
3.Developed a component that automates VPN Client Configuration and services.
4.Test Cases of the Feature
5.Tested the Code multiple times on XenServer and fixed the bugs.


Diffs
-

  test/integration/component/test_remotevpn_vpc.py PRE-CREATION 
  tools/marvin/marvin/config/test_data.py d870c98 

Diff: https://reviews.apache.org/r/22692/diff/


Testing
---

Test case no : Enable VPN for Public IP Address on the VPC ... === TestName: 
test_01_RemoteAccessVPN_VPC_EnableVPNAndConnecttoVM | Status : SUCCESS ===
ok
Test case no : Remote a VPN User ... === TestName: test_02_VPC_RemoveVPNUser | 
Status : SUCCESS ===
ok
Test case no : Add a Different VPN User and Test Access with already existing 
VPN User ... === TestName: test_03_VPC_AddDifferentVPNUser | Status : SUCCESS 
===
ok
Test case no : Add a Previously Removed VPN User from the VPC and Test the VPN 
Connectivity ... === TestName: 
test_04_VPC_AddPreviouslyRemovedVPNUserTestConnectivity | Status : SUCCESS ===
ok
Test case no : Disable the VPN Service on the VPC ... === TestName: 
test_05_VPC_DisableVPNServiceOnVPC | Status : SUCCESS ===
ok
Test case no : Enabled Previously Dsiabled VPN Access to VPC. ... === TestName: 
test_06_VPC_EnablePreviouslyDisabledVPNAccesstoVPC | Status : SUCCESS ===
ok
Test case no : Create Nine VPN Users to test the remote.vpn.user.limit=8 
Configuration parameter ... === TestName: 
test_07_ConfigParam_TestRemoteVPNUserLimit | Status : SUCCESS ===
ok

--
Ran 7 tests in 1771.352s

OK


Thanks,

Chandan Purushothama



Review Request 22693: Added VirtualRouterElements, InternalLoadBalancerElements classes to base.py- Extended methods in DiskOffering, StoragePool and Physical Network classes to accept more parameters

2014-06-17 Thread Chandan Purushothama

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22693/
---

Review request for cloudstack, Girish Shilamkar, Raja Pullela, sangeetha 
hariharan, sanjeev n, Santhosh Edukulla, sudha ponnaganti, and SrikanteswaraRao 
Talluri.


Repository: cloudstack-git


Description
---

Currently methods in DiskOffering, StoragePool and Physical Network restrict 
the programmer to use limited parameters. I made changes to the methods in 
those classes to accept more parameters that can be used during test script 
programming.

Added VirtualRouterElements, InternalLoadBalancerElements classes to base.py . 
The code will make the test script programming easier for programmers writing 
test scripts related to Zones.


Diffs
-

  tools/marvin/marvin/lib/base.py 8b89087 

Diff: https://reviews.apache.org/r/22693/diff/


Testing
---

Test Suite was scripted and tested with the above mentioned additions to 
base.py.


Thanks,

Chandan Purushothama



Review Request 22695: Stress Test to test multiple Remote Access VPN Connections to VPC

2014-06-17 Thread Chandan Purushothama

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22695/
---

Review request for cloudstack, Girish Shilamkar, Raja Pullela, sangeetha 
hariharan, sanjeev n, Santhosh Edukulla, sudha ponnaganti, and SrikanteswaraRao 
Talluri.


Repository: cloudstack-git


Description
---

Stress Test that tests multiple VPN Connections to VPC. The number of VPN 
Connections to be stressed with can be regulated using "vpnclient_count" on 
test_data.py.


Diffs
-

  test/integration/component/test_multipleremotevpn_vpc.py PRE-CREATION 
  tools/marvin/marvin/config/test_data.py d870c98 

Diff: https://reviews.apache.org/r/22695/diff/


Testing
---

Test case no : Enable VPN for Public IP Address on the VPC ... === TestName: 
test_01_Multiple_RemoteAccessVPN_Connections_To_VPC_Ping_Guest_VM_Multiple_Times
 | Status : SUCCESS ===
ok

--
Ran 1 test in 2480.632s

OK


Thanks,

Chandan Purushothama



ZoneWideStoragePoolAllocator#filter seems weird for me

2014-06-17 Thread Yoshikazu Nojima
Hi,

ZoneWideStoragePoolAllocator#filter seems weird for me.

ZoneWideStoragePoolAllocator and ClusterScopeStoragePoolAllocator are
allocator classes to select storage pool.
They extends AbstractStoragePoolAllocator class, which provides
"filter" method to exclude unavailable storage pools.

Why ZoneWideStoragePoolAllocator implements "filter" method (and
doesn't call that of base class) rather than just using that of base
class?

ZoneWideStoragePoolAllocator#filter method seems doesn't care "avoid"
parameter, doesn't skip iSCSI type storage pool even if a volume is a
RootDisk.
(These functions are implemented in
AbstractStoragePoolAllocator#filter method, which used by
ClusterScopeStoragePoolAllocator.)
On the other hand, AbstractStoragePoolAllocator#filter doesn't call
storageMgr.storagePoolHasEnoughIops, so a cluster wide primary storage
would be allocated more volumes than its designated IOPS capacity.

Is there any difference between a zone wide primary storage and a
cluster wide primary storage except its scope?
If it is a bug, I'll fix it.

Regards,
Noji


RE: ZoneWideStoragePoolAllocator#filter seems weird for me

2014-06-17 Thread Prachi Damle
>Why ZoneWideStoragePoolAllocator implements "filter" method (and doesn't call 
>that of base class) rather than just using that of base class?
>ZoneWideStoragePoolAllocator#filter method seems doesn't care "avoid" 
>parameter, doesn't skip iSCSI type storage pool even if a volume is a RootDisk.

The first question seems like a bug to me.

I am not sure about the IOPS

Prachi

-Original Message-
From: ynoj...@ynojima.net [mailto:ynoj...@ynojima.net] On Behalf Of Yoshikazu 
Nojima
Sent: Tuesday, June 17, 2014 1:07 PM
To: dev@cloudstack.apache.org
Subject: ZoneWideStoragePoolAllocator#filter seems weird for me

Hi,

ZoneWideStoragePoolAllocator#filter seems weird for me.

ZoneWideStoragePoolAllocator and ClusterScopeStoragePoolAllocator are allocator 
classes to select storage pool.
They extends AbstractStoragePoolAllocator class, which provides "filter" method 
to exclude unavailable storage pools.

Why ZoneWideStoragePoolAllocator implements "filter" method (and doesn't call 
that of base class) rather than just using that of base class?

ZoneWideStoragePoolAllocator#filter method seems doesn't care "avoid"
parameter, doesn't skip iSCSI type storage pool even if a volume is a RootDisk.
(These functions are implemented in
AbstractStoragePoolAllocator#filter method, which used by
ClusterScopeStoragePoolAllocator.)
On the other hand, AbstractStoragePoolAllocator#filter doesn't call 
storageMgr.storagePoolHasEnoughIops, so a cluster wide primary storage would be 
allocated more volumes than its designated IOPS capacity.

Is there any difference between a zone wide primary storage and a cluster wide 
primary storage except its scope?
If it is a bug, I'll fix it.

Regards,
Noji


Re: Review Request 22695: Stress Test to test multiple Remote Access VPN Connections to VPC

2014-06-17 Thread Chandan Purushothama

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22695/
---

(Updated June 17, 2014, 8:51 p.m.)


Review request for cloudstack, Girish Shilamkar, Raja Pullela, sangeetha 
hariharan, sanjeev n, Santhosh Edukulla, sudha ponnaganti, and SrikanteswaraRao 
Talluri.


Changes
---

Updated test_data.py with 'config_path' Information. This value is required to 
connect to the hypervisor and query the router for its nic information.


Repository: cloudstack-git


Description
---

Stress Test that tests multiple VPN Connections to VPC. The number of VPN 
Connections to be stressed with can be regulated using "vpnclient_count" on 
test_data.py.


Diffs (updated)
-

  tools/marvin/marvin/config/test_data.py 80d8a77 

Diff: https://reviews.apache.org/r/22695/diff/


Testing
---

Test case no : Enable VPN for Public IP Address on the VPC ... === TestName: 
test_01_Multiple_RemoteAccessVPN_Connections_To_VPC_Ping_Guest_VM_Multiple_Times
 | Status : SUCCESS ===
ok

--
Ran 1 test in 2480.632s

OK


Thanks,

Chandan Purushothama



Re: Review Request 22695: Stress Test to test multiple Remote Access VPN Connections to VPC

2014-06-17 Thread Chandan Purushothama

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22695/
---

(Updated June 17, 2014, 8:53 p.m.)


Review request for cloudstack, Girish Shilamkar, Raja Pullela, sangeetha 
hariharan, sanjeev n, Santhosh Edukulla, sudha ponnaganti, and SrikanteswaraRao 
Talluri.


Repository: cloudstack-git


Description
---

Stress Test that tests multiple VPN Connections to VPC. The number of VPN 
Connections to be stressed with can be regulated using "vpnclient_count" on 
test_data.py.


Diffs (updated)
-

  test/integration/component/test_multipleremotevpn_vpc.py PRE-CREATION 
  tools/marvin/marvin/config/test_data.py 4822893 

Diff: https://reviews.apache.org/r/22695/diff/


Testing
---

Test case no : Enable VPN for Public IP Address on the VPC ... === TestName: 
test_01_Multiple_RemoteAccessVPN_Connections_To_VPC_Ping_Guest_VM_Multiple_Times
 | Status : SUCCESS ===
ok

--
Ran 1 test in 2480.632s

OK


Thanks,

Chandan Purushothama



Re: Review Request 22695: Stress Test to test multiple Remote Access VPN Connections to VPC

2014-06-17 Thread Chandan Purushothama

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22695/
---

(Updated June 17, 2014, 9 p.m.)


Review request for cloudstack, Girish Shilamkar, Raja Pullela, sangeetha 
hariharan, sanjeev n, Santhosh Edukulla, sudha ponnaganti, and SrikanteswaraRao 
Talluri.


Repository: cloudstack-git


Description
---

Stress Test that tests multiple VPN Connections to VPC. The number of VPN 
Connections to be stressed with can be regulated using "vpnclient_count" on 
test_data.py.


Diffs (updated)
-

  test/integration/component/test_multipleremotevpn_vpc.py PRE-CREATION 
  tools/marvin/marvin/config/test_data.py d870c98 

Diff: https://reviews.apache.org/r/22695/diff/


Testing
---

Test case no : Enable VPN for Public IP Address on the VPC ... === TestName: 
test_01_Multiple_RemoteAccessVPN_Connections_To_VPC_Ping_Guest_VM_Multiple_Times
 | Status : SUCCESS ===
ok

--
Ran 1 test in 2480.632s

OK


Thanks,

Chandan Purushothama



[GSoC] [CLOUDSTACK-6114] Progress update

2014-06-17 Thread Ian Duffy
Hi All,

This week the project was tested by Sebastien, Rohit and Leo. All
successfully got a cloud up which is good news.

I've separated the project out a bit and the documentation has been updated
thanks to Rohit and suggestions from Leo.

The main repository can be found at:

https://github.com/imduffy15/GSoC-2014

All child projects that make it possible are as follows:

https://github.com/imduffy15/packer-xenserver
https://github.com/imduffy15/cookbook_cloudstack
https://github.com/imduffy15/cookbook_nat-router

I uploaded a new version of the XenServer Vagrant Box. It now includes
hotfixes XS62ESP1 and XS62ESP1004 which will allow us to make use of new
features within 4.4 (e.g. no vhd-util needed).

I did some housekeeping on the cloudstack and nat-router cookbook. They
both include the apache license and a vagrant file for single testing now.

I did some housekeeping on the VagrantFile which brings everything up at
the moment. It throws exceptions on not finding a plugin. Along with this
I've included a script for installing all necessary plugins.

I put some focus into using vagrant-cachier to allow for caching system vm
templates and the tiny linux template. Making use of this is simple, it
just involves overriding the chef attributes for the cloudstack cookbook:

  chef.json = {
  "cloudstack" => {
  "storage" => {
  "temporary" => "/tmp/vagrant-cache/cloudstack"
  }
  }
  }

I am happy with the current state of the project and consider "design 1" to
be completed
http://www.google-melange.com/gsoc/proposal/public/google/gsoc2014/imduffy15/5662278724616192


Re: [API]How to check how many IPs are available in guest network

2014-06-17 Thread ilya musayev


Chiradeep,

So i did a little more digging in your example, I also realized you code 
has assumption that i have /24 entirely dedicated to CloudStack :)


Welcome to enterprise madness where IP space, while being internal and 
free - is close guarded and restricted.


Do we have a concept of IP Pools in future versions? That is an 
aggregate of smaller ip ranges that end user can group into 1 entity. So 
if range x runs out of IP space, we just go to the next range and vlan 
in that pool, without returning and error - "you ran out of IP space".


Thanks,
ilya



On 6/16/14, 12:56 PM, Chiradeep Vittal wrote:

used=$(cloudmonkey list virtualmachines
networkid=f5119c7a-a5b8-47aa-bf26-d0f41dfa2d6b | grep ipaddress | wc -l)
space=$(cloudmonkey list networks id=f5119c7a-a5b8-47aa-bf26-d0f41dfa2d6b
| grep cidr | awk -F":" '{print $2}' | awk -F "/" '{print $2}')

space=${space%\",}
let space="32 - $space"
let space=³2**$space - 1²



let avail="$space - $used -1²
echo ³Available IPs = $avail"




From:  ilya musayev 
Reply-To:  "dev@cloudstack.apache.org" 
Date:  Monday, June 16, 2014 at 3:21 PM
To:  "dev@cloudstack.apache.org" 
Subject:  [API]How to check how many IPs are available in guest network


Is there a way to check how many guest IPs are available in specific
guest network?

Current cloudstack reporting is not granular enough, i could not find a
command that says listAvailableIPs or something similar.

Any help is appreciated.

Thanks,
ilya





Review Request 22705: Test cases relating to access checks for listVirtualMachine() with parameters - id, listall, isrecursive, account and domainid executed as ROOT admin, domain admin and regular us

2014-06-17 Thread sangeetha hariharan

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22705/
---

Review request for cloudstack, Min Chen, Prachi Damle, and Santhosh Edukulla.


Repository: cloudstack-git


Description
---

This test suite contains test cases relating to access checks for 
listVirtualMachine() with parameters - id,listall,isrecursive,account and 
domainid executed as ROOT admin,domain admin and regular users.


Diffs
-

  test/integration/component/test_acl_listvm.py PRE-CREATION 

Diff: https://reviews.apache.org/r/22705/diff/


Testing
---

Executed test suite against the latest 4.4-forward management server using a 
simulator set up:

test_listVM_as_domainadmin (integration.component.test_acl_listvm.TestVMList) 
... === TestName: test_listVM_as_domainadmin | Status : SUCCESS ===
ok
test_listVM_as_domainadmin_cross_domainid 
(integration.component.test_acl_listvm.TestVMList) ... === TestName: 
test_listVM_as_domainadmin_cross_domainid | Status : SUCCESS ===
ok
test_listVM_as_domainadmin_cross_domainid_accountid 
(integration.component.test_acl_listvm.TestVMList) ... === TestName: 
test_listVM_as_domainadmin_cross_domainid_accountid | Status : SUCCESS ===
ok
test_listVM_as_domainadmin_domainid 
(integration.component.test_acl_listvm.TestVMList) ... === TestName: 
test_listVM_as_domainadmin_domainid | Status : SUCCESS ===
ok
test_listVM_as_domainadmin_domainid_accountid 
(integration.component.test_acl_listvm.TestVMList) ... === TestName: 
test_listVM_as_domainadmin_domainid_accountid | Status : SUCCESS ===
ok
test_listVM_as_domainadmin_domainid_accountid_listall_false 
(integration.component.test_acl_listvm.TestVMList) ... === TestName: 
test_listVM_as_domainadmin_domainid_accountid_listall_false | Status : SUCCESS 
===
ok
test_listVM_as_domainadmin_domainid_accountid_listall_false_rec_false 
(integration.component.test_acl_listvm.TestVMList) ... === TestName: 
test_listVM_as_domainadmin_domainid_accountid_listall_false_rec_false | Status 
: SUCCESS ===
ok
test_listVM_as_domainadmin_domainid_accountid_listall_false_rec_true 
(integration.component.test_acl_listvm.TestVMList) ... === TestName: 
test_listVM_as_domainadmin_domainid_accountid_listall_false_rec_true | Status : 
SUCCESS ===
ok
test_listVM_as_domainadmin_domainid_accountid_listall_true 
(integration.component.test_acl_listvm.TestVMList) ... === TestName: 
test_listVM_as_domainadmin_domainid_accountid_listall_true | Status : SUCCESS 
===
ok
test_listVM_as_domainadmin_domainid_accountid_listall_true_rec_false 
(integration.component.test_acl_listvm.TestVMList) ... === TestName: 
test_listVM_as_domainadmin_domainid_accountid_listall_true_rec_false | Status : 
SUCCESS ===
ok
test_listVM_as_domainadmin_domainid_accountid_listall_true_rec_true 
(integration.component.test_acl_listvm.TestVMList) ... === TestName: 
test_listVM_as_domainadmin_domainid_accountid_listall_true_rec_true | Status : 
SUCCESS ===
ok
test_listVM_as_domainadmin_domainid_accountid_rec_false 
(integration.component.test_acl_listvm.TestVMList) ... === TestName: 
test_listVM_as_domainadmin_domainid_accountid_rec_false | Status : SUCCESS ===
ok
test_listVM_as_domainadmin_domainid_accountid_rec_true 
(integration.component.test_acl_listvm.TestVMList) ... === TestName: 
test_listVM_as_domainadmin_domainid_accountid_rec_true | Status : SUCCESS ===
ok
test_listVM_as_domainadmin_domainid_listall_false 
(integration.component.test_acl_listvm.TestVMList) ... === TestName: 
test_listVM_as_domainadmin_domainid_listall_false | Status : SUCCESS ===
ok
test_listVM_as_domainadmin_domainid_listall_false_rec_false 
(integration.component.test_acl_listvm.TestVMList) ... === TestName: 
test_listVM_as_domainadmin_domainid_listall_false_rec_false | Status : SUCCESS 
===
ok
test_listVM_as_domainadmin_domainid_listall_false_rec_true 
(integration.component.test_acl_listvm.TestVMList) ... === TestName: 
test_listVM_as_domainadmin_domainid_listall_false_rec_true | Status : SUCCESS 
===
ok
test_listVM_as_domainadmin_domainid_listall_true 
(integration.component.test_acl_listvm.TestVMList) ... === TestName: 
test_listVM_as_domainadmin_domainid_listall_true | Status : SUCCESS ===
ok
test_listVM_as_domainadmin_domainid_listall_true_rec_false 
(integration.component.test_acl_listvm.TestVMList) ... === TestName: 
test_listVM_as_domainadmin_domainid_listall_true_rec_false | Status : SUCCESS 
===
ok
test_listVM_as_domainadmin_domainid_listall_true_rec_true 
(integration.component.test_acl_listvm.TestVMList) ... === TestName: 
test_listVM_as_domainadmin_domainid_listall_true_rec_true | Status : SUCCESS ===
ok
test_listVM_as_domainadmin_domainid_rec_false 
(integration.component.test_acl_listvm.TestVMList) ... === TestName: 
test_listVM_as_domainadmin_domainid_rec_false | Status : SUCCESS ===
ok
test_listVM_as_domainadmin_domainid_rec_true 
(integration.component.test_ac

Review Request 22706: This test suite contains test cases relating to access checks for listVolume() with parameters - id, listall, isrecursive, account and domainid executed as ROOT admin, domain adm

2014-06-17 Thread sangeetha hariharan

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22706/
---

Review request for cloudstack, Min Chen, Prachi Damle, and Santhosh Edukulla.


Repository: cloudstack-git


Description
---

This test suite contains test cases relating to access checks for listVolume() 
with parameters - id,listall,isrecursive,account and domainid executed as ROOT 
admin,domain admin and regular users.


Diffs
-

  test/integration/component/test_acl_listvolume.py PRE-CREATION 

Diff: https://reviews.apache.org/r/22706/diff/


Testing
---

test_listVolume_as_domainadmin 
(integration.component.test_acl_listvolume.TestVolumeList) ... === TestName: 
test_listVolume_as_domainadmin | Status : SUCCESS ===
ok
test_listVolume_as_domainadmin_cross_domainid 
(integration.component.test_acl_listvolume.TestVolumeList) ... === TestName: 
test_listVolume_as_domainadmin_cross_domainid | Status : SUCCESS ===
ok
test_listVolume_as_domainadmin_cross_domainid_accountid 
(integration.component.test_acl_listvolume.TestVolumeList) ... === TestName: 
test_listVolume_as_domainadmin_cross_domainid_accountid | Status : SUCCESS ===
ok
test_listVolume_as_domainadmin_domainid 
(integration.component.test_acl_listvolume.TestVolumeList) ... === TestName: 
test_listVolume_as_domainadmin_domainid | Status : SUCCESS ===
ok
test_listVolume_as_domainadmin_domainid_accountid 
(integration.component.test_acl_listvolume.TestVolumeList) ... === TestName: 
test_listVolume_as_domainadmin_domainid_accountid | Status : SUCCESS ===
ok
test_listVolume_as_domainadmin_domainid_accountid_listall_false 
(integration.component.test_acl_listvolume.TestVolumeList) ... === TestName: 
test_listVolume_as_domainadmin_domainid_accountid_listall_false | Status : 
SUCCESS ===
ok
test_listVolume_as_domainadmin_domainid_accountid_listall_false_rec_false 
(integration.component.test_acl_listvolume.TestVolumeList) ... === TestName: 
test_listVolume_as_domainadmin_domainid_accountid_listall_false_rec_false | 
Status : SUCCESS ===
ok
test_listVolume_as_domainadmin_domainid_accountid_listall_false_rec_true 
(integration.component.test_acl_listvolume.TestVolumeList) ... === TestName: 
test_listVolume_as_domainadmin_domainid_accountid_listall_false_rec_true | 
Status : SUCCESS ===
ok
test_listVolume_as_domainadmin_domainid_accountid_listall_true 
(integration.component.test_acl_listvolume.TestVolumeList) ... === TestName: 
test_listVolume_as_domainadmin_domainid_accountid_listall_true | Status : 
SUCCESS ===
ok
test_listVolume_as_domainadmin_domainid_accountid_listall_true_rec_false 
(integration.component.test_acl_listvolume.TestVolumeList) ... === TestName: 
test_listVolume_as_domainadmin_domainid_accountid_listall_true_rec_false | 
Status : SUCCESS ===
ok
test_listVolume_as_domainadmin_domainid_accountid_listall_true_rec_true 
(integration.component.test_acl_listvolume.TestVolumeList) ... === TestName: 
test_listVolume_as_domainadmin_domainid_accountid_listall_true_rec_true | 
Status : SUCCESS ===
ok
test_listVolume_as_domainadmin_domainid_accountid_rec_false 
(integration.component.test_acl_listvolume.TestVolumeList) ... === TestName: 
test_listVolume_as_domainadmin_domainid_accountid_rec_false | Status : SUCCESS 
===
ok
test_listVolume_as_domainadmin_domainid_accountid_rec_true 
(integration.component.test_acl_listvolume.TestVolumeList) ... === TestName: 
test_listVolume_as_domainadmin_domainid_accountid_rec_true | Status : SUCCESS 
===
ok
test_listVolume_as_domainadmin_domainid_listall_false 
(integration.component.test_acl_listvolume.TestVolumeList) ... === TestName: 
test_listVolume_as_domainadmin_domainid_listall_false | Status : SUCCESS ===
ok
test_listVolume_as_domainadmin_domainid_listall_false_rec_false 
(integration.component.test_acl_listvolume.TestVolumeList) ... === TestName: 
test_listVolume_as_domainadmin_domainid_listall_false_rec_false | Status : 
SUCCESS ===
ok
test_listVolume_as_domainadmin_domainid_listall_false_rec_true 
(integration.component.test_acl_listvolume.TestVolumeList) ... === TestName: 
test_listVolume_as_domainadmin_domainid_listall_false_rec_true | Status : 
SUCCESS ===
ok
test_listVolume_as_domainadmin_domainid_listall_true 
(integration.component.test_acl_listvolume.TestVolumeList) ... === TestName: 
test_listVolume_as_domainadmin_domainid_listall_true | Status : SUCCESS ===
ok
test_listVolume_as_domainadmin_domainid_listall_true_rec_false 
(integration.component.test_acl_listvolume.TestVolumeList) ... === TestName: 
test_listVolume_as_domainadmin_domainid_listall_true_rec_false | Status : 
SUCCESS ===
ok
test_listVolume_as_domainadmin_domainid_listall_true_rec_true 
(integration.component.test_acl_listvolume.TestVolumeList) ... === TestName: 
test_listVolume_as_domainadmin_domainid_listall_true_rec_true | Status : 
SUCCESS ===
ok
test_listVolume_as_domainadmin_domainid_rec_false 
(integr

Re: Review Request 22706: This test suite contains test cases relating to access checks for listVolume() with parameters - id, listall, isrecursive, account and domainid executed as ROOT admin, domain

2014-06-17 Thread sangeetha hariharan

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22706/
---

(Updated June 18, 2014, 1:06 a.m.)


Review request for cloudstack, Min Chen, Prachi Damle, and Santhosh Edukulla.


Repository: cloudstack-git


Description
---

This test suite contains test cases relating to access checks for listVolume() 
with parameters - id,listall,isrecursive,account and domainid executed as ROOT 
admin,domain admin and regular users.


Diffs
-

  test/integration/component/test_acl_listvolume.py PRE-CREATION 

Diff: https://reviews.apache.org/r/22706/diff/


Testing
---

test_listVolume_as_domainadmin 
(integration.component.test_acl_listvolume.TestVolumeList) ... === TestName: 
test_listVolume_as_domainadmin | Status : SUCCESS ===
ok
test_listVolume_as_domainadmin_cross_domainid 
(integration.component.test_acl_listvolume.TestVolumeList) ... === TestName: 
test_listVolume_as_domainadmin_cross_domainid | Status : SUCCESS ===
ok
test_listVolume_as_domainadmin_cross_domainid_accountid 
(integration.component.test_acl_listvolume.TestVolumeList) ... === TestName: 
test_listVolume_as_domainadmin_cross_domainid_accountid | Status : SUCCESS ===
ok
test_listVolume_as_domainadmin_domainid 
(integration.component.test_acl_listvolume.TestVolumeList) ... === TestName: 
test_listVolume_as_domainadmin_domainid | Status : SUCCESS ===
ok
test_listVolume_as_domainadmin_domainid_accountid 
(integration.component.test_acl_listvolume.TestVolumeList) ... === TestName: 
test_listVolume_as_domainadmin_domainid_accountid | Status : SUCCESS ===
ok
test_listVolume_as_domainadmin_domainid_accountid_listall_false 
(integration.component.test_acl_listvolume.TestVolumeList) ... === TestName: 
test_listVolume_as_domainadmin_domainid_accountid_listall_false | Status : 
SUCCESS ===
ok
test_listVolume_as_domainadmin_domainid_accountid_listall_false_rec_false 
(integration.component.test_acl_listvolume.TestVolumeList) ... === TestName: 
test_listVolume_as_domainadmin_domainid_accountid_listall_false_rec_false | 
Status : SUCCESS ===
ok
test_listVolume_as_domainadmin_domainid_accountid_listall_false_rec_true 
(integration.component.test_acl_listvolume.TestVolumeList) ... === TestName: 
test_listVolume_as_domainadmin_domainid_accountid_listall_false_rec_true | 
Status : SUCCESS ===
ok
test_listVolume_as_domainadmin_domainid_accountid_listall_true 
(integration.component.test_acl_listvolume.TestVolumeList) ... === TestName: 
test_listVolume_as_domainadmin_domainid_accountid_listall_true | Status : 
SUCCESS ===
ok
test_listVolume_as_domainadmin_domainid_accountid_listall_true_rec_false 
(integration.component.test_acl_listvolume.TestVolumeList) ... === TestName: 
test_listVolume_as_domainadmin_domainid_accountid_listall_true_rec_false | 
Status : SUCCESS ===
ok
test_listVolume_as_domainadmin_domainid_accountid_listall_true_rec_true 
(integration.component.test_acl_listvolume.TestVolumeList) ... === TestName: 
test_listVolume_as_domainadmin_domainid_accountid_listall_true_rec_true | 
Status : SUCCESS ===
ok
test_listVolume_as_domainadmin_domainid_accountid_rec_false 
(integration.component.test_acl_listvolume.TestVolumeList) ... === TestName: 
test_listVolume_as_domainadmin_domainid_accountid_rec_false | Status : SUCCESS 
===
ok
test_listVolume_as_domainadmin_domainid_accountid_rec_true 
(integration.component.test_acl_listvolume.TestVolumeList) ... === TestName: 
test_listVolume_as_domainadmin_domainid_accountid_rec_true | Status : SUCCESS 
===
ok
test_listVolume_as_domainadmin_domainid_listall_false 
(integration.component.test_acl_listvolume.TestVolumeList) ... === TestName: 
test_listVolume_as_domainadmin_domainid_listall_false | Status : SUCCESS ===
ok
test_listVolume_as_domainadmin_domainid_listall_false_rec_false 
(integration.component.test_acl_listvolume.TestVolumeList) ... === TestName: 
test_listVolume_as_domainadmin_domainid_listall_false_rec_false | Status : 
SUCCESS ===
ok
test_listVolume_as_domainadmin_domainid_listall_false_rec_true 
(integration.component.test_acl_listvolume.TestVolumeList) ... === TestName: 
test_listVolume_as_domainadmin_domainid_listall_false_rec_true | Status : 
SUCCESS ===
ok
test_listVolume_as_domainadmin_domainid_listall_true 
(integration.component.test_acl_listvolume.TestVolumeList) ... === TestName: 
test_listVolume_as_domainadmin_domainid_listall_true | Status : SUCCESS ===
ok
test_listVolume_as_domainadmin_domainid_listall_true_rec_false 
(integration.component.test_acl_listvolume.TestVolumeList) ... === TestName: 
test_listVolume_as_domainadmin_domainid_listall_true_rec_false | Status : 
SUCCESS ===
ok
test_listVolume_as_domainadmin_domainid_listall_true_rec_true 
(integration.component.test_acl_listvolume.TestVolumeList) ... === TestName: 
test_listVolume_as_domainadmin_domainid_listall_true_rec_true | Status : 
SUCCESS ===
ok
test_listVolume_as_do

Review Request 22707: Test suite contains test cases relating to access checks for listSnapshot() with parameters - id, listall, isrecursive, account and domainid executed as ROOT admin, domain admin

2014-06-17 Thread sangeetha hariharan

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22707/
---

Review request for cloudstack, Min Chen, Prachi Damle, and Santhosh Edukulla.


Repository: cloudstack-git


Description
---

This test suite contains test cases relating to access checks for 
listSnapshot() with parameters - id,listall,isrecursive,account and domainid 
executed as ROOT admin,domain admin and regular users.


Diffs
-

  test/integration/component/test_acl_listsnapshot.py PRE-CREATION 

Diff: https://reviews.apache.org/r/22707/diff/


Testing
---

test_listSnapshot_as_domainadmin 
(integration.component.test_acl_listsnapshot.TestSnapshotList) ... === 
TestName: test_listSnapshot_as_domainadmin | Status : SUCCESS ===
ok
test_listSnapshot_as_domainadmin_cross_domainid 
(integration.component.test_acl_listsnapshot.TestSnapshotList) ... === 
TestName: test_listSnapshot_as_domainadmin_cross_domainid | Status : SUCCESS ===
ok
test_listSnapshot_as_domainadmin_cross_domainid_accountid 
(integration.component.test_acl_listsnapshot.TestSnapshotList) ... === 
TestName: test_listSnapshot_as_domainadmin_cross_domainid_accountid | Status : 
SUCCESS ===
ok
test_listSnapshot_as_domainadmin_domainid 
(integration.component.test_acl_listsnapshot.TestSnapshotList) ... === 
TestName: test_listSnapshot_as_domainadmin_domainid | Status : SUCCESS ===
ok
test_listSnapshot_as_domainadmin_domainid_accountid 
(integration.component.test_acl_listsnapshot.TestSnapshotList) ... === 
TestName: test_listSnapshot_as_domainadmin_domainid_accountid | Status : 
SUCCESS ===
ok
test_listSnapshot_as_domainadmin_domainid_accountid_listall_false 
(integration.component.test_acl_listsnapshot.TestSnapshotList) ... === 
TestName: test_listSnapshot_as_domainadmin_domainid_accountid_listall_false | 
Status : SUCCESS ===
ok
test_listSnapshot_as_domainadmin_domainid_accountid_listall_false_rec_false 
(integration.component.test_acl_listsnapshot.TestSnapshotList) ... === 
TestName: 
test_listSnapshot_as_domainadmin_domainid_accountid_listall_false_rec_false | 
Status : SUCCESS ===
ok
test_listSnapshot_as_domainadmin_domainid_accountid_listall_false_rec_true 
(integration.component.test_acl_listsnapshot.TestSnapshotList) ... === 
TestName: 
test_listSnapshot_as_domainadmin_domainid_accountid_listall_false_rec_true | 
Status : SUCCESS ===
ok
test_listSnapshot_as_domainadmin_domainid_accountid_listall_true 
(integration.component.test_acl_listsnapshot.TestSnapshotList) ... === 
TestName: test_listSnapshot_as_domainadmin_domainid_accountid_listall_true | 
Status : SUCCESS ===
ok
test_listSnapshot_as_domainadmin_domainid_accountid_listall_true_rec_false 
(integration.component.test_acl_listsnapshot.TestSnapshotList) ... === 
TestName: 
test_listSnapshot_as_domainadmin_domainid_accountid_listall_true_rec_false | 
Status : SUCCESS ===
ok
test_listSnapshot_as_domainadmin_domainid_accountid_listall_true_rec_true 
(integration.component.test_acl_listsnapshot.TestSnapshotList) ... === 
TestName: 
test_listSnapshot_as_domainadmin_domainid_accountid_listall_true_rec_true | 
Status : SUCCESS ===
ok
test_listSnapshot_as_domainadmin_domainid_accountid_rec_false 
(integration.component.test_acl_listsnapshot.TestSnapshotList) ... === 
TestName: test_listSnapshot_as_domainadmin_domainid_accountid_rec_false | 
Status : SUCCESS ===
ok
test_listSnapshot_as_domainadmin_domainid_accountid_rec_true 
(integration.component.test_acl_listsnapshot.TestSnapshotList) ... === 
TestName: test_listSnapshot_as_domainadmin_domainid_accountid_rec_true | Status 
: SUCCESS ===
ok
test_listSnapshot_as_domainadmin_domainid_listall_false 
(integration.component.test_acl_listsnapshot.TestSnapshotList) ... === 
TestName: test_listSnapshot_as_domainadmin_domainid_listall_false | Status : 
SUCCESS ===
ok
test_listSnapshot_as_domainadmin_domainid_listall_false_rec_false 
(integration.component.test_acl_listsnapshot.TestSnapshotList) ... === 
TestName: test_listSnapshot_as_domainadmin_domainid_listall_false_rec_false | 
Status : SUCCESS ===
ok
test_listSnapshot_as_domainadmin_domainid_listall_false_rec_true 
(integration.component.test_acl_listsnapshot.TestSnapshotList) ... === 
TestName: test_listSnapshot_as_domainadmin_domainid_listall_false_rec_true | 
Status : SUCCESS ===
ok
test_listSnapshot_as_domainadmin_domainid_listall_true 
(integration.component.test_acl_listsnapshot.TestSnapshotList) ... === 
TestName: test_listSnapshot_as_domainadmin_domainid_listall_true | Status : 
SUCCESS ===
ok
test_listSnapshot_as_domainadmin_domainid_listall_true_rec_false 
(integration.component.test_acl_listsnapshot.TestSnapshotList) ... === 
TestName: test_listSnapshot_as_domainadmin_domainid_listall_true_rec_false | 
Status : SUCCESS ===
ok
test_listSnapshot_as_domainadmin_domainid_listall_true_rec_true 
(integration.component.test_acl_listsnapshot.TestSnapshotList) ... 

Re: Review Request 22707: Test suite contains test cases relating to access checks for listSnapshot() with parameters - id, listall, isrecursive, account and domainid executed as ROOT admin, domain ad

2014-06-17 Thread sangeetha hariharan

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22707/
---

(Updated June 18, 2014, 1:16 a.m.)


Review request for cloudstack, Min Chen, Prachi Damle, and Santhosh Edukulla.


Repository: cloudstack-git


Description
---

This test suite contains test cases relating to access checks for 
listSnapshot() with parameters - id,listall,isrecursive,account and domainid 
executed as ROOT admin,domain admin and regular users.


Diffs
-

  test/integration/component/test_acl_listsnapshot.py PRE-CREATION 

Diff: https://reviews.apache.org/r/22707/diff/


Testing
---

test_listSnapshot_as_domainadmin 
(integration.component.test_acl_listsnapshot.TestSnapshotList) ... === 
TestName: test_listSnapshot_as_domainadmin | Status : SUCCESS ===
ok
test_listSnapshot_as_domainadmin_cross_domainid 
(integration.component.test_acl_listsnapshot.TestSnapshotList) ... === 
TestName: test_listSnapshot_as_domainadmin_cross_domainid | Status : SUCCESS ===
ok
test_listSnapshot_as_domainadmin_cross_domainid_accountid 
(integration.component.test_acl_listsnapshot.TestSnapshotList) ... === 
TestName: test_listSnapshot_as_domainadmin_cross_domainid_accountid | Status : 
SUCCESS ===
ok
test_listSnapshot_as_domainadmin_domainid 
(integration.component.test_acl_listsnapshot.TestSnapshotList) ... === 
TestName: test_listSnapshot_as_domainadmin_domainid | Status : SUCCESS ===
ok
test_listSnapshot_as_domainadmin_domainid_accountid 
(integration.component.test_acl_listsnapshot.TestSnapshotList) ... === 
TestName: test_listSnapshot_as_domainadmin_domainid_accountid | Status : 
SUCCESS ===
ok
test_listSnapshot_as_domainadmin_domainid_accountid_listall_false 
(integration.component.test_acl_listsnapshot.TestSnapshotList) ... === 
TestName: test_listSnapshot_as_domainadmin_domainid_accountid_listall_false | 
Status : SUCCESS ===
ok
test_listSnapshot_as_domainadmin_domainid_accountid_listall_false_rec_false 
(integration.component.test_acl_listsnapshot.TestSnapshotList) ... === 
TestName: 
test_listSnapshot_as_domainadmin_domainid_accountid_listall_false_rec_false | 
Status : SUCCESS ===
ok
test_listSnapshot_as_domainadmin_domainid_accountid_listall_false_rec_true 
(integration.component.test_acl_listsnapshot.TestSnapshotList) ... === 
TestName: 
test_listSnapshot_as_domainadmin_domainid_accountid_listall_false_rec_true | 
Status : SUCCESS ===
ok
test_listSnapshot_as_domainadmin_domainid_accountid_listall_true 
(integration.component.test_acl_listsnapshot.TestSnapshotList) ... === 
TestName: test_listSnapshot_as_domainadmin_domainid_accountid_listall_true | 
Status : SUCCESS ===
ok
test_listSnapshot_as_domainadmin_domainid_accountid_listall_true_rec_false 
(integration.component.test_acl_listsnapshot.TestSnapshotList) ... === 
TestName: 
test_listSnapshot_as_domainadmin_domainid_accountid_listall_true_rec_false | 
Status : SUCCESS ===
ok
test_listSnapshot_as_domainadmin_domainid_accountid_listall_true_rec_true 
(integration.component.test_acl_listsnapshot.TestSnapshotList) ... === 
TestName: 
test_listSnapshot_as_domainadmin_domainid_accountid_listall_true_rec_true | 
Status : SUCCESS ===
ok
test_listSnapshot_as_domainadmin_domainid_accountid_rec_false 
(integration.component.test_acl_listsnapshot.TestSnapshotList) ... === 
TestName: test_listSnapshot_as_domainadmin_domainid_accountid_rec_false | 
Status : SUCCESS ===
ok
test_listSnapshot_as_domainadmin_domainid_accountid_rec_true 
(integration.component.test_acl_listsnapshot.TestSnapshotList) ... === 
TestName: test_listSnapshot_as_domainadmin_domainid_accountid_rec_true | Status 
: SUCCESS ===
ok
test_listSnapshot_as_domainadmin_domainid_listall_false 
(integration.component.test_acl_listsnapshot.TestSnapshotList) ... === 
TestName: test_listSnapshot_as_domainadmin_domainid_listall_false | Status : 
SUCCESS ===
ok
test_listSnapshot_as_domainadmin_domainid_listall_false_rec_false 
(integration.component.test_acl_listsnapshot.TestSnapshotList) ... === 
TestName: test_listSnapshot_as_domainadmin_domainid_listall_false_rec_false | 
Status : SUCCESS ===
ok
test_listSnapshot_as_domainadmin_domainid_listall_false_rec_true 
(integration.component.test_acl_listsnapshot.TestSnapshotList) ... === 
TestName: test_listSnapshot_as_domainadmin_domainid_listall_false_rec_true | 
Status : SUCCESS ===
ok
test_listSnapshot_as_domainadmin_domainid_listall_true 
(integration.component.test_acl_listsnapshot.TestSnapshotList) ... === 
TestName: test_listSnapshot_as_domainadmin_domainid_listall_true | Status : 
SUCCESS ===
ok
test_listSnapshot_as_domainadmin_domainid_listall_true_rec_false 
(integration.component.test_acl_listsnapshot.TestSnapshotList) ... === 
TestName: test_listSnapshot_as_domainadmin_domainid_listall_true_rec_false | 
Status : SUCCESS ===
ok
test_listSnapshot_as_domainadmin_domainid_listall_true_rec_true 
(integration.component.test_ac

Re: ZoneWideStoragePoolAllocator#filter seems weird for me

2014-06-17 Thread Mike Tutkowski
I can comment on the IOPS part.

The IOPS are currently only relevant when using managed storage (which is
currently only applicable at the zone level). That being the case, no
cluster (or local) storage takes advantage of counting IOPS that have been
handed out.

Of course this logic might be expanded in the future, but that's how it
works today.


On Tue, Jun 17, 2014 at 2:47 PM, Prachi Damle 
wrote:

> >Why ZoneWideStoragePoolAllocator implements "filter" method (and doesn't
> call that of base class) rather than just using that of base class?
> >ZoneWideStoragePoolAllocator#filter method seems doesn't care "avoid"
> parameter, doesn't skip iSCSI type storage pool even if a volume is a
> RootDisk.
>
> The first question seems like a bug to me.
>
> I am not sure about the IOPS
>
> Prachi
>
> -Original Message-
> From: ynoj...@ynojima.net [mailto:ynoj...@ynojima.net] On Behalf Of
> Yoshikazu Nojima
> Sent: Tuesday, June 17, 2014 1:07 PM
> To: dev@cloudstack.apache.org
> Subject: ZoneWideStoragePoolAllocator#filter seems weird for me
>
> Hi,
>
> ZoneWideStoragePoolAllocator#filter seems weird for me.
>
> ZoneWideStoragePoolAllocator and ClusterScopeStoragePoolAllocator are
> allocator classes to select storage pool.
> They extends AbstractStoragePoolAllocator class, which provides "filter"
> method to exclude unavailable storage pools.
>
> Why ZoneWideStoragePoolAllocator implements "filter" method (and doesn't
> call that of base class) rather than just using that of base class?
>
> ZoneWideStoragePoolAllocator#filter method seems doesn't care "avoid"
> parameter, doesn't skip iSCSI type storage pool even if a volume is a
> RootDisk.
> (These functions are implemented in
> AbstractStoragePoolAllocator#filter method, which used by
> ClusterScopeStoragePoolAllocator.)
> On the other hand, AbstractStoragePoolAllocator#filter doesn't call
> storageMgr.storagePoolHasEnoughIops, so a cluster wide primary storage
> would be allocated more volumes than its designated IOPS capacity.
>
> Is there any difference between a zone wide primary storage and a cluster
> wide primary storage except its scope?
> If it is a bug, I'll fix it.
>
> Regards,
> Noji
>



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
*™*


Review Request 22709: This test suite contains test cases relating to access checks for createNetwork(), deploying VM in an isolated network and restartNetwork() for Admin, domain admin and regular us

2014-06-17 Thread sangeetha hariharan

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22709/
---

Review request for cloudstack, Min Chen, Prachi Damle, and Santhosh Edukulla.


Repository: cloudstack-git


Description
---

This test suite contains test cases relating to access checks for 
createNetwork(), deploying VM in an isolated network and restartNetwork() for 
Admin, domain admin and regular users.


Diffs
-

  test/integration/component/test_acl_isolatednetwork.py PRE-CREATION 

Diff: https://reviews.apache.org/r/22709/diff/


Testing
---

test_01_createNetwork_admin 
(integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
TestName: test_01_createNetwork_admin | Status : SUCCESS ===
ok
test_02_createNetwork_admin_foruserinsamedomain 
(integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
TestName: test_02_createNetwork_admin_foruserinsamedomain | Status : SUCCESS ===
ok
test_03_createNetwork_admin_foruserinotherdomain 
(integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
TestName: test_03_createNetwork_admin_foruserinotherdomain | Status : SUCCESS 
===
ok
test_04_createNetwork_domaindmin 
(integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
TestName: test_04_createNetwork_domaindmin | Status : SUCCESS ===
ok
test_05_createNetwork_domaindmin_foruserinsamedomain 
(integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
TestName: test_05_createNetwork_domaindmin_foruserinsamedomain | Status : 
SUCCESS ===
ok
test_06_createNetwork_domaindmin_foruserinsubdomain 
(integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
TestName: test_06_createNetwork_domaindmin_foruserinsubdomain | Status : 
SUCCESS ===
ok
test_07_createNetwork_domaindmin_forcrossdomainuser 
(integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
TestName: test_07_createNetwork_domaindmin_forcrossdomainuser | Status : 
SUCCESS ===
ok
test_08_createNetwork_user 
(integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
TestName: test_08_createNetwork_user | Status : SUCCESS ===
ok
test_09_createNetwork_user_foruserinsamedomain 
(integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
TestName: test_09_createNetwork_user_foruserinsamedomain | Status : SUCCESS ===
ok
test_10_createNetwork_user_foruserinotherdomain 
(integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
TestName: test_10_createNetwork_user_foruserinotherdomain | Status : SUCCESS ===
ok
test_11_deployvm_admin 
(integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
TestName: test_11_deployvm_admin | Status : SUCCESS ===
ok
test_12_deployvm_admin_foruserinsamedomain 
(integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
TestName: test_12_deployvm_admin_foruserinsamedomain | Status : SUCCESS ===
ok
test_13_1_deployvm_admin_foruserinotherdomain_crossnetwork 
(integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
TestName: test_13_1_deployvm_admin_foruserinotherdomain_crossnetwork | Status : 
SUCCESS ===
ok
test_13_deployvm_admin_foruserinotherdomain 
(integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
TestName: test_13_deployvm_admin_foruserinotherdomain | Status : SUCCESS ===
ok
test_14_deployvm_domaindmin 
(integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
TestName: test_14_deployvm_domaindmin | Status : SUCCESS ===
ok
test_15_deployvm_domaindmin_foruserinsamedomain 
(integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
TestName: test_15_deployvm_domaindmin_foruserinsamedomain | Status : SUCCESS ===
ok
test_16_deployvm_domaindmin_foruserinsubdomain 
(integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
TestName: test_16_deployvm_domaindmin_foruserinsubdomain | Status : SUCCESS ===
ok
test_17_1_deployvm_domainadmin_foruserinotherdomain_crossnetwork 
(integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
TestName: test_17_1_deployvm_domainadmin_foruserinotherdomain_crossnetwork | 
Status : SUCCESS ===
ok
test_17_deployvm_domaindmin_forcrossdomainuser 
(integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
TestName: test_17_deployvm_domaindmin_forcrossdomainuser | Status : SUCCESS ===
ok
test_18_deployvm_user 
(integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
TestName: test_18_deployvm_user | Status : SUCCESS ===
ok
test_19_deployvm_user_foruserinsamedomain 
(integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
TestName: test_19_deployvm_user_foruserinsamedomain | Status : SUCCESS ===
ok
test_20_1_deployvm_user_incrossnetwork 
(integration.component.test_acl_isolatedne

Review Request 22712: This Test suite has test cases relating to acess checks for deleteNetwork() for Admin, domain admin and regular users

2014-06-17 Thread sangeetha hariharan

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22712/
---

Review request for cloudstack, Min Chen, Prachi Damle, and Santhosh Edukulla.


Repository: cloudstack-git


Description
---

This Test suite has test cases relating to acess checks for deleteNetwork() for 
Admin, domain admin and regular users


Diffs
-

  test/integration/component/test_acl_isolatednetwork_delete.py PRE-CREATION 

Diff: https://reviews.apache.org/r/22712/diff/


Testing
---

Test Suite was executed against a management server built from 4.4-forward 
branch using a simulator set up:
test_deleteNetwork_admin 
(integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete)
 ... === TestName: test_deleteNetwork_admin | Status : SUCCESS ===
ok
test_deleteNetwork_admin_foruserinotherdomain 
(integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete)
 ... === TestName: test_deleteNetwork_admin_foruserinotherdomain | Status : 
SUCCESS ===
ok
test_deleteNetwork_admin_foruserinsamedomain 
(integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete)
 ... === TestName: test_deleteNetwork_admin_foruserinsamedomain | Status : 
SUCCESS ===
ok
test_deleteNetwork_domaindmin 
(integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete)
 ... === TestName: test_deleteNetwork_domaindmin | Status : SUCCESS ===
ok
test_deleteNetwork_domaindmin_forcrossdomainuser 
(integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete)
 ... === TestName: test_deleteNetwork_domaindmin_forcrossdomainuser | Status : 
SUCCESS ===
ok
test_deleteNetwork_domaindmin_foruserinsamedomain 
(integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete)
 ... === TestName: test_deleteNetwork_domaindmin_foruserinsamedomain | Status : 
SUCCESS ===
ok
test_deleteNetwork_domaindmin_foruserinsubdomain 
(integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete)
 ... === TestName: test_deleteNetwork_domaindmin_foruserinsubdomain | Status : 
SUCCESS ===
ok
test_deleteNetwork_user 
(integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete)
 ... === TestName: test_deleteNetwork_user | Status : SUCCESS ===
ok
test_deleteNetwork_user_foruserinotherdomain 
(integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete)
 ... === TestName: test_deleteNetwork_user_foruserinotherdomain | Status : 
SUCCESS ===
ok
test_deleteNetwork_user_foruserinsamedomain 
(integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete)
 ... === TestName: test_deleteNetwork_user_foruserinsamedomain | Status : 
SUCCESS ===
ok

--
Ran 10 tests in 61.766s

OK


Thanks,

sangeetha hariharan



Review Request 22713: This Test suite has test cases for deploying Virtual Machine using impersonation (passing account and domainId parameters) for shared network

2014-06-17 Thread sangeetha hariharan

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22713/
---

Review request for cloudstack, Min Chen, Prachi Damle, and Santhosh Edukulla.


Repository: cloudstack-git


Description
---

This Test suite has test cases for deploying Virtual Machine using 
impersonation (passing account and domainId parameters) for shared network


Diffs
-

  test/integration/component/test_acl_sharednetwork_deployVM-impersonation.py 
PRE-CREATION 

Diff: https://reviews.apache.org/r/22713/diff/


Testing
---

Test Suite was executed against a management server built from 4.4-forward 
branch using a simulator set up:
test_deployVM_in_sharedNetwork_as_admin_scope_account_ROOTuser 
(integration.component.test_acl_sharednetwork_deployVM-impersonation.TestSharedNetwork)
 ... === TestName: 
test_deployVM_in_sharedNetwork_as_admin_scope_account_ROOTuser | Status : 
SUCCESS ===
ok
test_deployVM_in_sharedNetwork_as_admin_scope_account_differentdomain 
(integration.component.test_acl_sharednetwork_deployVM-impersonation.TestSharedNetwork)
 ... === TestName: 
test_deployVM_in_sharedNetwork_as_admin_scope_account_differentdomain | Status 
: SUCCESS ===
ok
test_deployVM_in_sharedNetwork_as_admin_scope_account_domainadminuser 
(integration.component.test_acl_sharednetwork_deployVM-impersonation.TestSharedNetwork)
 ... === TestName: 
test_deployVM_in_sharedNetwork_as_admin_scope_account_domainadminuser | Status 
: SUCCESS ===
ok
test_deployVM_in_sharedNetwork_as_admin_scope_account_domainuser 
(integration.component.test_acl_sharednetwork_deployVM-impersonation.TestSharedNetwork)
 ... === TestName: 
test_deployVM_in_sharedNetwork_as_admin_scope_account_domainuser | Status : 
SUCCESS ===
ok
test_deployVM_in_sharedNetwork_as_admin_scope_account_user 
(integration.component.test_acl_sharednetwork_deployVM-impersonation.TestSharedNetwork)
 ... === TestName: test_deployVM_in_sharedNetwork_as_admin_scope_account_user | 
Status : SUCCESS ===
ok
test_deployVM_in_sharedNetwork_as_admin_scope_all_ROOTuser 
(integration.component.test_acl_sharednetwork_deployVM-impersonation.TestSharedNetwork)
 ... === TestName: test_deployVM_in_sharedNetwork_as_admin_scope_all_ROOTuser | 
Status : SUCCESS ===
ok
test_deployVM_in_sharedNetwork_as_admin_scope_all_domainadminuser 
(integration.component.test_acl_sharednetwork_deployVM-impersonation.TestSharedNetwork)
 ... === TestName: 
test_deployVM_in_sharedNetwork_as_admin_scope_all_domainadminuser | Status : 
SUCCESS ===
ok
test_deployVM_in_sharedNetwork_as_admin_scope_all_domainuser 
(integration.component.test_acl_sharednetwork_deployVM-impersonation.TestSharedNetwork)
 ... === TestName: test_deployVM_in_sharedNetwork_as_admin_scope_all_domainuser 
| Status : SUCCESS ===
ok
test_deployVM_in_sharedNetwork_as_admin_scope_all_subdomainadminuser 
(integration.component.test_acl_sharednetwork_deployVM-impersonation.TestSharedNetwork)
 ... === TestName: 
test_deployVM_in_sharedNetwork_as_admin_scope_all_subdomainadminuser | Status : 
SUCCESS ===
ok
test_deployVM_in_sharedNetwork_as_admin_scope_all_subdomainuser 
(integration.component.test_acl_sharednetwork_deployVM-impersonation.TestSharedNetwork)
 ... === TestName: 
test_deployVM_in_sharedNetwork_as_admin_scope_all_subdomainuser | Status : 
SUCCESS ===
ok
test_deployVM_in_sharedNetwork_as_admin_scope_domain_nosubdomainaccess_ROOTuser 
(integration.component.test_acl_sharednetwork_deployVM-impersonation.TestSharedNetwork)
 ... === TestName: 
test_deployVM_in_sharedNetwork_as_admin_scope_domain_nosubdomainaccess_ROOTuser 
| Status : SUCCESS ===
ok
test_deployVM_in_sharedNetwork_as_admin_scope_domain_nosubdomainaccess_domainadminuser
 
(integration.component.test_acl_sharednetwork_deployVM-impersonation.TestSharedNetwork)
 ... === TestName: 
test_deployVM_in_sharedNetwork_as_admin_scope_domain_nosubdomainaccess_domainadminuser
 | Status : SUCCESS ===
ok
test_deployVM_in_sharedNetwork_as_admin_scope_domain_nosubdomainaccess_domainuser
 
(integration.component.test_acl_sharednetwork_deployVM-impersonation.TestSharedNetwork)
 ... === TestName: 
test_deployVM_in_sharedNetwork_as_admin_scope_domain_nosubdomainaccess_domainuser
 | Status : SUCCESS ===
ok
test_deployVM_in_sharedNetwork_as_admin_scope_domain_nosubdomainaccess_parentdomainadminuser
 
(integration.component.test_acl_sharednetwork_deployVM-impersonation.TestSharedNetwork)
 ... === TestName: 
test_deployVM_in_sharedNetwork_as_admin_scope_domain_nosubdomainaccess_parentdomainadminuser
 | Status : SUCCESS ===
ok
test_deployVM_in_sharedNetwork_as_admin_scope_domain_nosubdomainaccess_parentdomainuser
 
(integration.component.test_acl_sharednetwork_deployVM-impersonation.TestSharedNetwork)
 ... === TestName: 
test_deployVM_in_sharedNetwork_as_admin_scope_domain_nosubdomainaccess_parentdomainuser
 | Status : SUCCESS ===
ok
test_deployVM_in_sharedNetwork_

Review Request 22627: CLOUDSTACK-6906: Fixed volume resize BVT failure

2014-06-17 Thread Gaurav Aradhye

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22627/
---

Review request for cloudstack and Girish Shilamkar.


Bugs: CLOUDSTACK-6906
https://issues.apache.org/jira/browse/CLOUDSTACK-6906


Repository: cloudstack-git


Description
---

The disk offering used while resizing volume was not custom. Changed it to 
custom disk offering so that resize is possible without creating new disk 
offering.


Diffs
-

  test/integration/smoke/test_volumes.py 2e41aa7 

Diff: https://reviews.apache.org/r/22627/diff/


Testing
---


Thanks,

Gaurav Aradhye



Review Request 22614: CLOUDSTACK-6887: Code enhancement to ensure better cleanup

2014-06-17 Thread Gaurav Aradhye

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22614/
---

Review request for cloudstack and Girish Shilamkar.


Bugs: CLOUDSTACK-6887
https://issues.apache.org/jira/browse/CLOUDSTACK-6887


Repository: cloudstack-git


Description
---

Adding patch fixing few more test suites for better cleanup.


Diffs
-

  test/integration/component/test_accounts.py f71dea5 
  test/integration/component/test_add_remove_network.py 7479cee 
  test/integration/component/test_affinity_groups.py d0fa2f7 
  test/integration/component/test_portable_ip.py 538318d 
  test/integration/component/test_vpc_network.py a449948 

Diff: https://reviews.apache.org/r/22614/diff/


Testing
---

Tested with python command.


Thanks,

Gaurav Aradhye



Re: Review Request 20316: CLOUDSTACK-1466: Adding automation test cases for Primary Storage Limits

2014-06-17 Thread Gaurav Aradhye

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20316/
---

(Updated June 18, 2014, 8:53 a.m.)


Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.


Changes
---

Rebased patch.


Bugs: CLOUDSTACK-1466
https://issues.apache.org/jira/browse/CLOUDSTACK-1466


Repository: cloudstack-git


Description
---

Adding test suits in Primary Storage Limits test cases.
1)Root/Domain admin limits
2)Domain Limits
3)Resize volume
4)Project Limits
5)Maximum Limits


Diffs (updated)
-

  test/integration/component/test_ps_domain_limits.py PRE-CREATION 
  test/integration/component/test_ps_limits.py PRE-CREATION 
  test/integration/component/test_ps_max_limits.py PRE-CREATION 
  test/integration/component/test_ps_project_limits.py PRE-CREATION 
  test/integration/component/test_ps_resize_volume.py PRE-CREATION 
  tools/marvin/marvin/codes.py ef49c0c 
  tools/marvin/marvin/lib/base.py 8b89087 
  tools/marvin/marvin/lib/common.py 7753385 

Diff: https://reviews.apache.org/r/20316/diff/


Testing
---

Yes


Thanks,

Gaurav Aradhye



Managing individual ESXi instances

2014-06-17 Thread Ivan Efremov
Hi all,

I've sent this mail to the users list but this one looks as the better 
destination.

I'm new to the CloudStack platform and I'm wondering why the platform does need 
the vCenter API and can not use ESXi directly,

Can anyone elaborate on this?
Are there any proposals for adding ESXi integration to CloudStack?


Thanks,
Ivan


Unscribe me!

2014-06-17 Thread abhisek basu

  

Re: Review Request 20316: CLOUDSTACK-1466: Adding automation test cases for Primary Storage Limits

2014-06-17 Thread Gaurav Aradhye

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20316/
---

(Updated June 18, 2014, 9:36 a.m.)


Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.


Changes
---

Last patch would not apply cleanly.


Bugs: CLOUDSTACK-1466
https://issues.apache.org/jira/browse/CLOUDSTACK-1466


Repository: cloudstack-git


Description
---

Adding test suits in Primary Storage Limits test cases.
1)Root/Domain admin limits
2)Domain Limits
3)Resize volume
4)Project Limits
5)Maximum Limits


Diffs (updated)
-

  test/integration/component/test_ps_domain_limits.py PRE-CREATION 
  test/integration/component/test_ps_limits.py PRE-CREATION 
  test/integration/component/test_ps_max_limits.py PRE-CREATION 
  test/integration/component/test_ps_project_limits.py PRE-CREATION 
  test/integration/component/test_ps_resize_volume.py PRE-CREATION 
  tools/marvin/marvin/codes.py ef49c0c 
  tools/marvin/marvin/lib/base.py 8b89087 
  tools/marvin/marvin/lib/common.py 7753385 

Diff: https://reviews.apache.org/r/20316/diff/


Testing
---

Yes


Thanks,

Gaurav Aradhye



Re: Unscribe me!

2014-06-17 Thread Mike Tutkowski
Instructions for how to unsubscribe:

http://cloudstack.apache.org/mailing-lists.html


On Tue, Jun 17, 2014 at 9:38 PM, abhisek basu  wrote:

>
>




-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
*™*


RE: [ACS431][QUESTION] db upgrace

2014-06-17 Thread Koushik Das
4.3.1 -> 4.4.0 upgrade also needs to be handled.

-Original Message-
From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] 
Sent: Tuesday, 17 June 2014 9:16 PM
To: dev
Subject: [ACS431][QUESTION] db upgrace

In my simple mind it seems we only need to create a Upgrade430to431.java file 
and don't need any sql files. Is this going to fly? AFAICT the only thing to go 
in there is the vlan fixup in the vlan table, which is a data migration and not 
a schema change.

Can anyone point out to me the error in my ways, please?

thanks,
--
Daan


RE: [ANNOUNCE] Saksham Srivastava as committer

2014-06-17 Thread Saksham Srivastava
Thanks again :)

-Original Message-
From: Radhika Puthiyetath [mailto:radhika.puthiyet...@citrix.com] 
Sent: Tuesday, June 17, 2014 10:43 PM
To: dev@cloudstack.apache.org
Subject: RE: [ANNOUNCE] Saksham Srivastava as committer

I am too late to wish you on ML. Congrats

Welcome aboard, and don't forget to drive the BLR Meetup group..:-)

-Original Message-
From: sebgoa [mailto:run...@gmail.com] 
Sent: Wednesday, May 28, 2014 11:48 PM
To: dev@cloudstack.apache.org
Subject: [ANNOUNCE] Saksham Srivastava as committer

The Project Management Committee (PMC) for Apache CloudStack has asked Saksham 
Srivastava to become a committer and we are pleased to announce that he has 
accepted.

Being a committer allows many contributors to contribute more autonomously. For 
developers, it makes it easier to submit changes and eliminates the need to 
have contributions reviewed via the patch submission process. Whether 
contributions are development-related or otherwise, it is a recognition of a 
contributor's participation in the project and commitment to the project and 
the Apache Way.

Please join me in congratulating Saksham,


-Sebastien, on behalf of the CloudStack PMC


Re: [ACS 4.4] cherry-pick

2014-06-17 Thread Jayapal Reddy Uradi
Hi Daan,

The conflicts resolved looks fine.
You can ignore my patch.

Thanks,
Jayapal

On 17-Jun-2014, at 5:50 PM, Daan Hoogland  wrote:

> I don't think I was clear. I don't need a new patch. I did resolve the
> conflict. I need you to check if I did the right thing in branch 4.4
> in EventTypes near line 550
> 
> your new patch doesn't apply to 4.4 or 4.4-forward
> 
>> git am -s 
>> ~/Downloads/0001-CLOUDSTACK-6922-Updated-events-for-firewall-ingress-.patch
> Applying: CLOUDSTACK-6922: Updated events for firewall ingress and egress
> error: patch failed: api/src/com/cloud/event/EventTypes.java:126
> error: api/src/com/cloud/event/EventTypes.java: patch does not apply
> error: patch failed: 
> api/src/com/cloud/network/firewall/FirewallService.java:40
> error: api/src/com/cloud/network/firewall/FirewallService.java: patch
> does not apply
> error: patch failed:
> api/src/org/apache/cloudstack/api/command/user/firewall/CreateEgressFirewallRuleCmd.java:154
> error: 
> api/src/org/apache/cloudstack/api/command/user/firewall/CreateEgressFirewallRuleCmd.java:
> patch does not apply
> error: patch failed:
> api/src/org/apache/cloudstack/api/command/user/firewall/CreateFirewallRuleCmd.java:134
> error: 
> api/src/org/apache/cloudstack/api/command/user/firewall/CreateFirewallRuleCmd.java:
> patch does not apply
> error: patch failed:
> api/src/org/apache/cloudstack/api/command/user/firewall/DeleteEgressFirewallRuleCmd.java:74
> error: 
> api/src/org/apache/cloudstack/api/command/user/firewall/DeleteEgressFirewallRuleCmd.java:
> patch does not apply
> error: patch failed:
> api/src/org/apache/cloudstack/api/command/user/firewall/DeleteFirewallRuleCmd.java:96
> error: 
> api/src/org/apache/cloudstack/api/command/user/firewall/DeleteFirewallRuleCmd.java:
> patch does not apply
> error: patch failed:
> api/src/org/apache/cloudstack/api/command/user/firewall/UpdateEgressFirewallRuleCmd.java:78
> error: 
> api/src/org/apache/cloudstack/api/command/user/firewall/UpdateEgressFirewallRuleCmd.java:
> patch does not apply
> error: patch failed:
> api/src/org/apache/cloudstack/api/command/user/firewall/UpdateFirewallRuleCmd.java:79
> error: 
> api/src/org/apache/cloudstack/api/command/user/firewall/UpdateFirewallRuleCmd.java:
> patch does not apply
> error: patch failed:
> server/src/com/cloud/network/firewall/FirewallManagerImpl.java:161
> error: server/src/com/cloud/network/firewall/FirewallManagerImpl.java:
> patch does not apply
> error: patch failed:
> server/test/com/cloud/network/MockFirewallManagerImpl.java:70
> error: server/test/com/cloud/network/MockFirewallManagerImpl.java:
> patch does not apply
> Patch failed at 0001 CLOUDSTACK-6922: Updated events for firewall
> ingress and egress
> 
> On Tue, Jun 17, 2014 at 1:41 PM, Jayapal Reddy Uradi
>  wrote:
>> Hi Daan,
>> 
>> Resolved the conflicts and uploaded patch in review board.
>> https://reviews.apache.org/r/22679/
>> 
>> Thanks,
>> Jayapal
>> 
>> On 17-Jun-2014, at 4:52 PM, Daan Hoogland 
>> wrote:
>> 
>>> On Tue, Jun 17, 2014 at 8:41 AM, Jayapal Reddy Uradi
>>>  wrote:
 2214bd2502a34ee8e671eb6b4efe8cd26e29ac5a
>>> 
>>> 
>>> I had conflicts. Can you have a look near line 550? I resolved by
>>> changing IpAddress to PublicIpAddress.
>>> 
>>> regards
>>> --
>>> Daan
>> 
> 
> 
> 
> -- 
> Daan



RE: [ANNOUNCE] Saksham Srivastava as committer

2014-06-17 Thread Shweta Agarwal
Congrats Saksham !!

-Original Message-
From: sebgoa [mailto:run...@gmail.com] 
Sent: Thursday, May 29, 2014 12:18 PM
To: dev@cloudstack.apache.org
Subject: [ANNOUNCE] Saksham Srivastava as committer

The Project Management Committee (PMC) for Apache CloudStack has asked Saksham 
Srivastava to become a committer and we are pleased to announce that he has 
accepted.

Being a committer allows many contributors to contribute more autonomously. For 
developers, it makes it easier to submit changes and eliminates the need to 
have contributions reviewed via the patch submission process. Whether 
contributions are development-related or otherwise, it is a recognition of a 
contributor's participation in the project and commitment to the project and 
the Apache Way.

Please join me in congratulating Saksham,


-Sebastien, on behalf of the CloudStack PMC


Re: Anybody addressing this bug ? Overlaping IP subnets across different vlans

2014-06-17 Thread ilya musayev

Anthony,

Thanks for response

While i see your point, i believe its a corner case. Consider this scenario:

I have a network 192.168.1.2 - 10 assigned as management network
I have a network 192.168.1.11 - 200 assigned to guests.

The router VM will get two IPs in this case 192.168.1.2 and 
192.168.1.11. IPs should not overlap if check is done on IP Space level.


If customer is using Advanced Shared Network with VMware and VLAN 
Tagging - basic zone cannot be used. In many other enterprise like 
setups that must leverage advanced shared network, CloudStack is 
completely segregated from outside world. This check maybe helpful to 
folks running public clouds with VPC, but in shared network setup - 
which is what enterprise environments run, its creating IP space waste.


Please comment,

Thanks
ilya


On 6/11/14, 11:16 AM, Anthony Xu wrote:

You can add overlapping IP subnets across different vlans if all vlans belong 
to guest network.

CS treats public network differently, CS doesn't want public subnet overlap 
with other guest network.

If different vlans are routable, it is possible that a VM has the same ip as a 
system VM, public ip is accessible from outside, duplicate ip might cause 
system VMs stop working.

It is very hard for us to help users to recover from this scenarios.

Basically you want to use the same subnet for both public network and guest 
network, maybe basic zone is better fit for you.

Anthony

  





-Original Message-
From: Murali Reddy
Sent: Wednesday, June 11, 2014 2:45 AM
To: dev@cloudstack.apache.org; Anthony Xu
Subject: Re: Anybody addressing this bug ? Overlaping IP subnets across 
different vlans

This is not related to portable IP. This enforcement was added as part of 
commit 657d9e4789d73c7c8ed460e59f088b8cb9aa7697.

Anothony might have context for this check.

On 11/06/14 2:18 PM, "Andrija Panic"  wrote:


It was not there pre 4.3, and it's just causing me problems, I had to
manually add database entries to vlan and user_ip_address tables, not
very convinient...
Thanks,
Andrija


On 11 June 2014 02:45, Chiradeep Vittal 
wrote:


Not sure what this has to do with Portable IP. But I agree that the
check  should be removed.

From: ilya musayev >
Reply-To: "dev@cloudstack.apache.org"
<
dev@cloudstack.apache.org>
Date: Friday, June 6, 2014 at 10:38 AM
To: "dev@cloudstack.apache.org" <
dev@cloudstack.apache.org>
Subject: Re: Anybody addressing this bug ? Overlaping IP subnets
across  different vlans

Andrija

I dont know if we can qualify this as a bug, this check was placed
with some purpose in mind - yet its not clear what it is and why
would someone think its bad.



https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=a3
b1a
49c303a929c754561ca07fd8a9ed84e0382

https://issues.apache.org/jira/browse/CLOUDSTACK-3911

Chime in on the discussion in thread above,

Regards,
ilya


On 6/6/14, 5:48 AM, Andrija Panic wrote:
Hi,
aftger upgrade to 4.3, I reported a bug where CS will not let me add
additional IP ranges when there are 2 vlans using same IP range -
I don't see point comparing IP ranges across two separate broadcast
domains...

https://issues.apache.org/jira/browse/CLOUDSTACK-6814

Thanks,





--

Andrija Panić
--
  http://admintweets.com
--







[GitHub] cloudstack-docs-install pull request: corrected the java version t...

2014-06-17 Thread karuturi
GitHub user karuturi opened a pull request:

https://github.com/apache/cloudstack-docs-install/pull/15

corrected the java version to 1.7

changed java package and JAVA_HOME to 1.7

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/karuturi/cloudstack-docs-install patch-2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack-docs-install/pull/15.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #15


commit 3a22e8356627df230df59c9fe2ffe9c5f207f612
Author: Rajani Karuturi 
Date:   2014-06-18T05:44:58Z

corrected the java version to 1.7

changed java package and JAVA_HOME to 1.7




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: [API]How to check how many IPs are available in guest network

2014-06-17 Thread Chiradeep Vittal
Not sure I understand. Would this be a single network encompassing several 
vlans and ip ranges?

From: ilya musayev 
mailto:ilya.mailing.li...@gmail.com>>
Reply-To: "dev@cloudstack.apache.org" 
mailto:dev@cloudstack.apache.org>>
Date: Tuesday, June 17, 2014 at 6:39 PM
To: "dev@cloudstack.apache.org" 
mailto:dev@cloudstack.apache.org>>
Subject: Re: [API]How to check how many IPs are available in guest network


Chiradeep,

So i did a little more digging in your example, I also realized you code
has assumption that i have /24 entirely dedicated to CloudStack :)

Welcome to enterprise madness where IP space, while being internal and
free - is close guarded and restricted.

Do we have a concept of IP Pools in future versions? That is an
aggregate of smaller ip ranges that end user can group into 1 entity. So
if range x runs out of IP space, we just go to the next range and vlan
in that pool, without returning and error - "you ran out of IP space".

Thanks,
ilya



On 6/16/14, 12:56 PM, Chiradeep Vittal wrote:
used=$(cloudmonkey list virtualmachines
networkid=f5119c7a-a5b8-47aa-bf26-d0f41dfa2d6b | grep ipaddress | wc -l)
space=$(cloudmonkey list networks id=f5119c7a-a5b8-47aa-bf26-d0f41dfa2d6b
| grep cidr | awk -F":" '{print $2}' | awk -F "/" '{print $2}')

space=${space%\",}
let space="32 - $space"
let space=³2**$space - 1²



let avail="$space - $used -1²
echo ³Available IPs = $avail"




From:  ilya musayev 
mailto:ilya.mailing.li...@gmail.com>>
Reply-To:  "dev@cloudstack.apache.org" 
mailto:dev@cloudstack.apache.org>>
Date:  Monday, June 16, 2014 at 3:21 PM
To:  "dev@cloudstack.apache.org" 
mailto:dev@cloudstack.apache.org>>
Subject:  [API]How to check how many IPs are available in guest network


Is there a way to check how many guest IPs are available in specific
guest network?

Current cloudstack reporting is not granular enough, i could not find a
command that says listAvailableIPs or something similar.

Any help is appreciated.

Thanks,
ilya





Re: [API]How to check how many IPs are available in guest network

2014-06-17 Thread Chiradeep Vittal
Or is it that the client doesn’t care about the network (since all networks are 
reachable from one-another) and just wants to run a VM.
This is called a basic zone :)
Some higher level portal could achieve this logic for an advanced zone, I guess.


From: Chiradeep Vittal 
mailto:chiradeep.vit...@citrix.com>>
Date: Tuesday, June 17, 2014 at 10:49 PM
To: "dev@cloudstack.apache.org" 
mailto:dev@cloudstack.apache.org>>
Subject: Re: [API]How to check how many IPs are available in guest network

Not sure I understand. Would this be a single network encompassing several 
vlans and ip ranges?

From: ilya musayev 
mailto:ilya.mailing.li...@gmail.com>>
Reply-To: "dev@cloudstack.apache.org" 
mailto:dev@cloudstack.apache.org>>
Date: Tuesday, June 17, 2014 at 6:39 PM
To: "dev@cloudstack.apache.org" 
mailto:dev@cloudstack.apache.org>>
Subject: Re: [API]How to check how many IPs are available in guest network


Chiradeep,

So i did a little more digging in your example, I also realized you code
has assumption that i have /24 entirely dedicated to CloudStack :)

Welcome to enterprise madness where IP space, while being internal and
free - is close guarded and restricted.

Do we have a concept of IP Pools in future versions? That is an
aggregate of smaller ip ranges that end user can group into 1 entity. So
if range x runs out of IP space, we just go to the next range and vlan
in that pool, without returning and error - "you ran out of IP space".

Thanks,
ilya



On 6/16/14, 12:56 PM, Chiradeep Vittal wrote:
used=$(cloudmonkey list virtualmachines
networkid=f5119c7a-a5b8-47aa-bf26-d0f41dfa2d6b | grep ipaddress | wc -l)
space=$(cloudmonkey list networks id=f5119c7a-a5b8-47aa-bf26-d0f41dfa2d6b
| grep cidr | awk -F":" '{print $2}' | awk -F "/" '{print $2}')

space=${space%\",}
let space="32 - $space"
let space=³2**$space - 1²



let avail="$space - $used -1²
echo ³Available IPs = $avail"




From:  ilya musayev 
mailto:ilya.mailing.li...@gmail.com>>
Reply-To:  "dev@cloudstack.apache.org" 
mailto:dev@cloudstack.apache.org>>
Date:  Monday, June 16, 2014 at 3:21 PM
To:  "dev@cloudstack.apache.org" 
mailto:dev@cloudstack.apache.org>>
Subject:  [API]How to check how many IPs are available in guest network


Is there a way to check how many guest IPs are available in specific
guest network?

Current cloudstack reporting is not granular enough, i could not find a
command that says listAvailableIPs or something similar.

Any help is appreciated.

Thanks,
ilya





Review Request 22717: refactor StoragePoolAllocator#filter logic

2014-06-17 Thread Yoshikazu Nojima

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22717/
---

Review request for cloudstack, Mike Tutkowski and Prachi Damle.


Repository: cloudstack-git


Description
---

refactor StoragePoolAllocator#filter logic to enable hypervisor type check, 
storage type check for root volume and avoid list check, and to support IOPS 
capacity control in a cluster wide storage pool and a local storage pool.


Diffs
-

  
engine/storage/src/org/apache/cloudstack/storage/allocator/AbstractStoragePoolAllocator.java
 ddbb5a4 
  
engine/storage/src/org/apache/cloudstack/storage/allocator/ZoneWideStoragePoolAllocator.java
 8fb9c8d 

Diff: https://reviews.apache.org/r/22717/diff/


Testing
---


Thanks,

Yoshikazu Nojima



Re: ZoneWideStoragePoolAllocator#filter seems weird for me

2014-06-17 Thread Yoshikazu Nojima
Prachi, Mike,
I appreciate your comments.

I think it is a bug that there is a difference between filter logic of
ClusterScopeStoragePoolAllocator and that of
ZoneWideStoragePoolAllocator
(ex. allocator skip iSCSI type storage pool or not when a volume is a RootDisk),
I will unify by implementing it in AbstractStoragePoolAllocator#filter method.

It is new information for me that managed storages only support zone
level. Thank you for let me know.
But when iopscapacity parameter is not set to a primary storage (i.e.
unmanaged storage), storageMgr.storagePoolHasEnoughIops always returns
true.
I suppose calling storageMgr.storagePoolHasEnoughIops from
AbstractStoragePoolAllocator will not cause a problem, and it will
simplify the code.

I created a patch to explain my thought. Could you review it?
https://reviews.apache.org/r/22717/

Regards,
Noji


2014-06-17 19:19 GMT-06:00 Mike Tutkowski :
> I can comment on the IOPS part.
>
> The IOPS are currently only relevant when using managed storage (which is
> currently only applicable at the zone level). That being the case, no
> cluster (or local) storage takes advantage of counting IOPS that have been
> handed out.
>
> Of course this logic might be expanded in the future, but that's how it
> works today.
>
>
> On Tue, Jun 17, 2014 at 2:47 PM, Prachi Damle 
> wrote:
>
>> >Why ZoneWideStoragePoolAllocator implements "filter" method (and doesn't
>> call that of base class) rather than just using that of base class?
>> >ZoneWideStoragePoolAllocator#filter method seems doesn't care "avoid"
>> parameter, doesn't skip iSCSI type storage pool even if a volume is a
>> RootDisk.
>>
>> The first question seems like a bug to me.
>>
>> I am not sure about the IOPS
>>
>> Prachi
>>
>> -Original Message-
>> From: ynoj...@ynojima.net [mailto:ynoj...@ynojima.net] On Behalf Of
>> Yoshikazu Nojima
>> Sent: Tuesday, June 17, 2014 1:07 PM
>> To: dev@cloudstack.apache.org
>> Subject: ZoneWideStoragePoolAllocator#filter seems weird for me
>>
>> Hi,
>>
>> ZoneWideStoragePoolAllocator#filter seems weird for me.
>>
>> ZoneWideStoragePoolAllocator and ClusterScopeStoragePoolAllocator are
>> allocator classes to select storage pool.
>> They extends AbstractStoragePoolAllocator class, which provides "filter"
>> method to exclude unavailable storage pools.
>>
>> Why ZoneWideStoragePoolAllocator implements "filter" method (and doesn't
>> call that of base class) rather than just using that of base class?
>>
>> ZoneWideStoragePoolAllocator#filter method seems doesn't care "avoid"
>> parameter, doesn't skip iSCSI type storage pool even if a volume is a
>> RootDisk.
>> (These functions are implemented in
>> AbstractStoragePoolAllocator#filter method, which used by
>> ClusterScopeStoragePoolAllocator.)
>> On the other hand, AbstractStoragePoolAllocator#filter doesn't call
>> storageMgr.storagePoolHasEnoughIops, so a cluster wide primary storage
>> would be allocated more volumes than its designated IOPS capacity.
>>
>> Is there any difference between a zone wide primary storage and a cluster
>> wide primary storage except its scope?
>> If it is a bug, I'll fix it.
>>
>> Regards,
>> Noji
>>
>
>
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the cloud
> *™*


Re: Review Request 20316: CLOUDSTACK-1466: Adding automation test cases for Primary Storage Limits

2014-06-17 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20316/#review46043
---


Commit a0f19d4bd5d7bec6613aa8130b3da9ecffc71d0b in cloudstack's branch 
refs/heads/4.4-forward from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=a0f19d4 ]

CLOUDSTACK-1466: Automation - Priamary Storage Limits


- ASF Subversion and Git Services


On June 18, 2014, 4:06 a.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20316/
> ---
> 
> (Updated June 18, 2014, 4:06 a.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-1466
> https://issues.apache.org/jira/browse/CLOUDSTACK-1466
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Adding test suits in Primary Storage Limits test cases.
> 1)Root/Domain admin limits
> 2)Domain Limits
> 3)Resize volume
> 4)Project Limits
> 5)Maximum Limits
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_ps_domain_limits.py PRE-CREATION 
>   test/integration/component/test_ps_limits.py PRE-CREATION 
>   test/integration/component/test_ps_max_limits.py PRE-CREATION 
>   test/integration/component/test_ps_project_limits.py PRE-CREATION 
>   test/integration/component/test_ps_resize_volume.py PRE-CREATION 
>   tools/marvin/marvin/codes.py ef49c0c 
>   tools/marvin/marvin/lib/base.py 8b89087 
>   tools/marvin/marvin/lib/common.py 7753385 
> 
> Diff: https://reviews.apache.org/r/20316/diff/
> 
> 
> Testing
> ---
> 
> Yes
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>



Re: Review Request 22510: [Windows] Can not create Template from ROOT snapshot. Fixed the same by adding pathSeparator to the DataStoreTO.java

2014-06-17 Thread Damodar Reddy Talakanti

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22510/
---

(Updated June 18, 2014, 6:50 a.m.)


Review request for cloudstack, edison su, Koushik Das, and Min Chen.


Changes
---

Commit message changes to explicitly mention that changes are related to 
XenServer/NFS only.


Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6636

https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6636


Repository: cloudstack-git


Description
---

Due to File.separator on windows machine the template creation from snapshot is 
failing as it has mis-matched path separator which is windows path 
separator(\). Fixed the same by adding getPathSeparator() method to 
DataStoreTO.java and all it's implementations.


Diffs (updated)
-

  api/src/com/cloud/agent/api/to/DataStoreTO.java 8d47adc 
  api/src/com/cloud/agent/api/to/NfsTO.java 1c9ee38 
  api/src/com/cloud/agent/api/to/S3TO.java f64fe35 
  api/src/com/cloud/agent/api/to/SwiftTO.java 3b76dad 
  core/src/org/apache/cloudstack/storage/to/ImageStoreTO.java 93c62f6 
  core/src/org/apache/cloudstack/storage/to/PrimaryDataStoreTO.java 29e53b0 
  
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XenServerStorageProcessor.java
 e96ebf4 

Diff: https://reviews.apache.org/r/22510/diff/


Testing
---

Tested on Windows 2012 R2 server and on centos. Tested the following use cases.

1. Attach ISO
2. Detach ISO
3. Snapshot creation from root disk
4. Snapshot creation from data disk
5. volume creation from (3)
6. template creation from(3)
7. Launch a VM after registering new template.


Thanks,

Damodar Reddy Talakanti