applied and pushed, I have one remark; when fixing issues I would like to see a ref to the issue (in this case no jira issue but 'coverity:') and a description of what was solved. your style of commit comments requires a lot of contextual knowledge. Can you try to make sure someone reading your commit comment doesn't need to know the contents of the related issues to get it?
thanks, Daan On Tue, Jun 17, 2014 at 1:26 PM, Santhosh Edukulla <santhosh.eduku...@citrix.com> wrote: > Resolved the conflicts for the mentioned commit. > > https://reviews.apache.org/r/22677/ > > Santhosh > ________________________________________ > From: Daan Hoogland [daan.hoogl...@gmail.com] > Sent: Monday, June 16, 2014 12:09 PM > To: dev > Subject: Re: [ACS44] Cherry Pick Request > > On Mon, Jun 16, 2014 at 4:28 PM, Santhosh Edukulla > <santhosh.eduku...@citrix.com> wrote: >> Daan, >> >> Please pick up the below fixes for resource leaks and other Coverity issues. >> >> 4ba3aae2ea0290ca012623083e13625e08a9dde5 > was in already? > >> 3c5f64c97ab071451aee7f232d8f2cec6d89044d > in > >> dbfce8b11e25855a8cb21ec2bbbfe20940bb788d > had conflicts > >> >> >> As well, please check the below commit, its fix for CLOUDSTACK-6793 >> >> 91d054cb00f6a5818f2be1c7e4d3f44a2c58bfcc > was in already? > >> >> Thanks! >> Santhosh > > > > -- > Daan -- Daan
