RE: Code Documentation

2014-06-16 Thread Santhosh Edukulla
Agreed, If we are referring to proper naming convention for self explaining the 
code, yes. 

But, still adding better and more comment strings or doc strings at appropriate 
places, is not going to harm i believe, it just compliments and aids better 
understanding. 

We used to add specific examples as well under comments to explain its use and 
this can be used to auto generate the docs for easy reading thereafter. Once in 
practice and visible, its effect will be more clear i believe.

EX:  Api documentation( I mean generate docs through added comments with 
examples, returns, inputs etc ) can be generated like this and can easily 
document api usage with examples, today, api documentation is not much there i 
believe.  

Regards,
Santhosh

From: rohityada...@gmail.com [rohityada...@gmail.com] on behalf of Rohit Yadav 
[bhais...@apache.org]
Sent: Friday, June 13, 2014 10:59 AM
To: dev@cloudstack.apache.org
Subject: Re: Code Documentation

On Wed, Jun 11, 2014 at 9:58 PM, Santhosh Edukulla <
santhosh.eduku...@citrix.com> wrote:

> Hi All,
>
> Many of code areas under CS, currently don't have enough documentation i
> believe, we have few one liner comments at places. But, largely, was
> missing at various code areas.
>
> We in one of our earlier project, used to enforce strictly a template for
> comments\documentation for every new function added. These comments were
> later retrieved automatically to build code documentation easily. This gets
> enforced during review itself, or otherwise review wont be accepted.  It
> will make the flow lot easier to understand some times i believe.
>
> Please add atleast basic description for every  major
> interface\class\function, description for input\output arguments for
> individual entities.
>

IMO we should prefer writing code so it documents itself and we save
ourselves from maintaining both code and comments.

Regards.


>
> EX: Currently, for below we dont have any comments in general.
>
> public boolean shutdownNetwork(final long networkId, ReservationContext
> context, boolean cleanupElements)
>
>
> Regards,
> Santhosh
>
>


Re: Add S3 secondary storage

2014-06-16 Thread Sebastien Goasguen

On Jun 16, 2014, at 12:14 AM, Sanjeev Neelarapu  
wrote:

> Hi Sebastien,
> 
> #1 For adding S3 object store as secondary storage use "addImageStore" API 
> with provider as "s3"
> http://cloudstack.apache.org/docs/api/apidocs-4.3/root_admin/addImageStore.html

Wow, looking at that API doc, this is terrible:

details[0].key=accesskey&details[0].value=s389ddssaa&details[1].key=secretkey&details[1].value=8dshfss

> 
> #2 We can't add S3 store if a zone already has NFS as secondary store, 
> however we can migrate from NFS to S3
> http://cloudstack.apache.org/docs/api/apidocs-4.3/root_admin/updateCloudToUseObjectStore.html

thanks for the pointer, I will check it out.

So what is the addS3 api used for ?


> 
> Thanks,
> Sanjeev
> 
> -Original Message-
> From: sebgoa [mailto:run...@gmail.com] 
> Sent: Sunday, June 15, 2014 8:28 PM
> To: dev@cloudstack.apache.org
> Subject: Add S3 secondary storage
> 
> Hi folks,
> 
> if we want to add a S3 object store as secondary storage, do we just call 
> addS3 ?
> http://cloudstack.apache.org/docs/api/apidocs-4.3/root_admin/addS3.html
> 
> I have a basic zone with an existing NFS secondary store, can I add a second 
> secondary storage using a S3 store ?
> 
> thanks,
> 
> -sebastien



Re: Can we delete a template after a VM is instantiated from it?

2014-06-16 Thread Nux!
Hi,

You can remove it from the UI, but not directly from the disk as it is used (in 
many cases) as a backing file for the VMs spawned from it.

HTH
Lucian

--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro

- Original Message -
From: "Sanjeev Neelarapu" 
To: dev@cloudstack.apache.org
Sent: Monday, 16 June, 2014 5:18:04 AM
Subject: RE: Can we delete a template after a VM is instantiated from it?

We can delete template without any issues.

-Sanjeev

-Original Message-
From: Rafael Weingartner [mailto:rafaelweingart...@gmail.com] 
Sent: Sunday, June 15, 2014 8:48 PM
To: dev@cloudstack.apache.org
Subject: Can we delete a template after a VM is instantiated from it?

 Hi,

I was wondering if we can delete a template that has already been used to 
instantiate some VMs.

Would that cause any trouble?

--
Rafael Weingärtner


RE: Add S3 secondary storage

2014-06-16 Thread Sanjeev Neelarapu
addS3 api has been deprecated. From 4.3 onwards we use only addImageStore API 
for any type of secondary storage (e.g NFS/S3/Swift)

-Sanjeev

-Original Message-
From: Sebastien Goasguen [mailto:run...@gmail.com] 
Sent: Monday, June 16, 2014 12:59 PM
To: dev@cloudstack.apache.org
Subject: Re: Add S3 secondary storage


On Jun 16, 2014, at 12:14 AM, Sanjeev Neelarapu  
wrote:

> Hi Sebastien,
> 
> #1 For adding S3 object store as secondary storage use "addImageStore" API 
> with provider as "s3"
> http://cloudstack.apache.org/docs/api/apidocs-4.3/root_admin/addImageS
> tore.html

Wow, looking at that API doc, this is terrible:

details[0].key=accesskey&details[0].value=s389ddssaa&details[1].key=secretkey&details[1].value=8dshfss

> 
> #2 We can't add S3 store if a zone already has NFS as secondary store, 
> however we can migrate from NFS to S3 
> http://cloudstack.apache.org/docs/api/apidocs-4.3/root_admin/updateClo
> udToUseObjectStore.html

thanks for the pointer, I will check it out.

So what is the addS3 api used for ?


> 
> Thanks,
> Sanjeev
> 
> -Original Message-
> From: sebgoa [mailto:run...@gmail.com]
> Sent: Sunday, June 15, 2014 8:28 PM
> To: dev@cloudstack.apache.org
> Subject: Add S3 secondary storage
> 
> Hi folks,
> 
> if we want to add a S3 object store as secondary storage, do we just call 
> addS3 ?
> http://cloudstack.apache.org/docs/api/apidocs-4.3/root_admin/addS3.htm
> l
> 
> I have a basic zone with an existing NFS secondary store, can I add a second 
> secondary storage using a S3 store ?
> 
> thanks,
> 
> -sebastien



Re: Code Documentation

2014-06-16 Thread Rajani Karuturi
IMO, comments are part of code. By writing code comments, we aren’t maintaining 
comments and code but rather helping others understand what the code is doing. 
As a developer, if I can easily understand what the code is doing, I won’t even 
look at the comments.

In our codebase we have functions which easily span more than thousand lines of 
code. scanning each and every conditional for all the possible scenarios is 
very difficult and tiresome. 
If we have a codebase which follows some conventions, it would be very easy to 
read code. But, in the current state we are faaar from ideal. 

We can use a tool like doxygen(i don’t know if available for java) to generate 
documentation from source code. Infact, anyone interested can run the doxygen 
build locally and use. 
but, this tool is of no use if we don’t improve the code 
documentation/standards. 

~Rajani



On 13-Jun-2014, at 8:29 pm, Rohit Yadav  wrote:

> On Wed, Jun 11, 2014 at 9:58 PM, Santhosh Edukulla <
> santhosh.eduku...@citrix.com> wrote:
> 
>> Hi All,
>> 
>> Many of code areas under CS, currently don't have enough documentation i
>> believe, we have few one liner comments at places. But, largely, was
>> missing at various code areas.
>> 
>> We in one of our earlier project, used to enforce strictly a template for
>> comments\documentation for every new function added. These comments were
>> later retrieved automatically to build code documentation easily. This gets
>> enforced during review itself, or otherwise review wont be accepted.  It
>> will make the flow lot easier to understand some times i believe.
>> 
>> Please add atleast basic description for every  major
>> interface\class\function, description for input\output arguments for
>> individual entities.
>> 
> 
> IMO we should prefer writing code so it documents itself and we save
> ourselves from maintaining both code and comments.
> 
> Regards.
> 
> 
>> 
>> EX: Currently, for below we dont have any comments in general.
>> 
>> public boolean shutdownNetwork(final long networkId, ReservationContext
>> context, boolean cleanupElements)
>> 
>> 
>> Regards,
>> Santhosh
>> 
>> 



Re: Review Request 22256: CLOUDSTACK-6830 :[hyper-v] fixed vm migration failing between different clusters if volumes are on zone wide primary store

2014-06-16 Thread Anshul Gangwar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22256/
---

(Updated June 16, 2014, 9:58 a.m.)


Review request for cloudstack, Devdeep Singh, Rajesh Battala, and Sateesh 
Chodapuneedi.


Changes
---

now removing hosts from list which doesn't have suitable storage pools t 
accomodate the volumes of VM


Bugs: CLOUDSTACK-6830
https://issues.apache.org/jira/browse/CLOUDSTACK-6830


Repository: cloudstack-git


Description
---

fixed vm migration failing between different clusters if volumes are on zone 
primary store. During VM migration, volumes on zone wide primary store 
requiring storage migration resulting in failure of VM migration

This also improves the hostsformigration api. Firstly we were ttrying to 
list all hosts and then finding suitable storage pools for all volumes
and then we were checking for whether vm migration requires storage 
migration
Now the process is reversed, We are checking for only those volumes which 
are not in zone wide primary store and only verifying
that volumes->poolid->clusterid is different from host clusterid and 
usesLocal then only it requires storage migration


Diffs (updated)
-

  engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java 4502365 
  server/src/com/cloud/server/ManagementServerImpl.java dd4ce0f 

Diff: https://reviews.apache.org/r/22256/diff/


Testing
---

tested following scenarios on my local setup.
1. VM migration for volumes on zone wide primary store is working fine
2. VM migration for volumes on cluster wide primary store is working fine
3. VM migration for volumes on local storage is working fine


Thanks,

Anshul Gangwar



Re: Review Request 20316: CLOUDSTACK-1466: Adding automation test cases for Primary Storage Limits

2014-06-16 Thread Gaurav Aradhye

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20316/#review45730
---


Gentle Reminder.

- Gaurav Aradhye


On June 6, 2014, 3:10 p.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20316/
> ---
> 
> (Updated June 6, 2014, 3:10 p.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-1466
> https://issues.apache.org/jira/browse/CLOUDSTACK-1466
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Adding test suits in Primary Storage Limits test cases.
> 1)Root/Domain admin limits
> 2)Domain Limits
> 3)Resize volume
> 4)Project Limits
> 5)Maximum Limits
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_ps_domain_limits.py PRE-CREATION 
>   test/integration/component/test_ps_limits.py PRE-CREATION 
>   test/integration/component/test_ps_max_limits.py PRE-CREATION 
>   test/integration/component/test_ps_project_limits.py PRE-CREATION 
>   test/integration/component/test_ps_resize_volume.py PRE-CREATION 
>   tools/marvin/marvin/codes.py ef49c0c 
>   tools/marvin/marvin/lib/base.py 2681724 
>   tools/marvin/marvin/lib/common.py 91fe053 
> 
> Diff: https://reviews.apache.org/r/20316/diff/
> 
> 
> Testing
> ---
> 
> Yes
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>



Re: Review Request 20316: CLOUDSTACK-1466: Adding automation test cases for Primary Storage Limits

2014-06-16 Thread Gaurav Aradhye

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20316/#review45731
---


Gentle Reminder.

- Gaurav Aradhye


On June 6, 2014, 3:10 p.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20316/
> ---
> 
> (Updated June 6, 2014, 3:10 p.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-1466
> https://issues.apache.org/jira/browse/CLOUDSTACK-1466
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Adding test suits in Primary Storage Limits test cases.
> 1)Root/Domain admin limits
> 2)Domain Limits
> 3)Resize volume
> 4)Project Limits
> 5)Maximum Limits
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_ps_domain_limits.py PRE-CREATION 
>   test/integration/component/test_ps_limits.py PRE-CREATION 
>   test/integration/component/test_ps_max_limits.py PRE-CREATION 
>   test/integration/component/test_ps_project_limits.py PRE-CREATION 
>   test/integration/component/test_ps_resize_volume.py PRE-CREATION 
>   tools/marvin/marvin/codes.py ef49c0c 
>   tools/marvin/marvin/lib/base.py 2681724 
>   tools/marvin/marvin/lib/common.py 91fe053 
> 
> Diff: https://reviews.apache.org/r/20316/diff/
> 
> 
> Testing
> ---
> 
> Yes
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>



Re: Review Request 22501: CLOUDSTACK-6282 : Modified IPAddresses tests for the failed testcases to create an account at test level not at class level. Also modified Templates to read register data fro

2014-06-16 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22501/#review45733
---


Commit 89c35abb4db0f362f9159ea39a6eb70ad4351921 in cloudstack's branch 
refs/heads/4.4-forward from VinayV
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=89c35ab ]

CLOUDSTACK-6282: Modified IPAddress tests to fix the failures. Modified 
Instances, snapshots, templates tests to handle KVM Hypervisor


- ASF Subversion and Git Services


On June 12, 2014, 8:59 a.m., Vinay Varma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22501/
> ---
> 
> (Updated June 12, 2014, 8:59 a.m.)
> 
> 
> Review request for cloudstack, Rayees Namathponnan and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-6282
> https://issues.apache.org/jira/browse/CLOUDSTACK-6282
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-6282 : Modified IPAddresses tests for the failed testcases to 
> create an account at test level not at class level. Also modified Templates 
> to read register data from test_data file. Modified VM Snapshot tests to be 
> skipped for KVM hypervisor as discussed with Rayees
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_escalations_instances.py 9e040db 
>   test/integration/component/test_escalations_ipaddresses.py 23dd76b 
>   test/integration/component/test_escalations_snapshots.py 2367253 
>   test/integration/component/test_escalations_templates.py 083ba90 
>   tools/marvin/marvin/config/test_data.py 63661ed 
>   tools/marvin/marvin/lib/base.py d9c4fae 
> 
> Diff: https://reviews.apache.org/r/22501/diff/
> 
> 
> Testing
> ---
> 
> Executed the tests after making changes and all the tests are passing. 
> Attached are the log files for master
> 
> 
> File Attachments
> 
> 
> Jun_12_2014-Instances-master.txt
>   
> https://reviews.apache.org/media/uploaded/files/2014/06/12/d01ee156-ef6f-44f3-bbc1-d68c52200772__Jun_12_2014-Instances-master.txt
> Jun_12_2014-IPAddresses-Master.txt
>   
> https://reviews.apache.org/media/uploaded/files/2014/06/12/b74ce2d2-a402-4f04-a77f-0c413db59a7d__Jun_12_2014-IPAddresses-Master.txt
> Jun_12_2014-Snapshots-Master.txt
>   
> https://reviews.apache.org/media/uploaded/files/2014/06/12/b47c552a-79a6-4570-bcdb-b726fda94afb__Jun_12_2014-Snapshots-Master.txt
> Jun_12_2014-Templates-Master.txt
>   
> https://reviews.apache.org/media/uploaded/files/2014/06/12/3ea34c2b-ca46-473e-887f-d347032ffcc0__Jun_12_2014-Templates-Master.txt
> 
> 
> Thanks,
> 
> Vinay Varma
> 
>



Re: Review Request 22501: CLOUDSTACK-6282 : Modified IPAddresses tests for the failed testcases to create an account at test level not at class level. Also modified Templates to read register data fro

2014-06-16 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22501/#review45734
---


Commit 99e4da15da73ac2ccf5597e11d805cb1438831cd in cloudstack's branch 
refs/heads/master from VinayV
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=99e4da1 ]

CLOUDSTACK-6282-Modified IpAddresses, Instances, Templates, Snapshots tests to 
handle KVM and modified IPAddresses for failed list cases


- ASF Subversion and Git Services


On June 12, 2014, 8:59 a.m., Vinay Varma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22501/
> ---
> 
> (Updated June 12, 2014, 8:59 a.m.)
> 
> 
> Review request for cloudstack, Rayees Namathponnan and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-6282
> https://issues.apache.org/jira/browse/CLOUDSTACK-6282
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-6282 : Modified IPAddresses tests for the failed testcases to 
> create an account at test level not at class level. Also modified Templates 
> to read register data from test_data file. Modified VM Snapshot tests to be 
> skipped for KVM hypervisor as discussed with Rayees
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_escalations_instances.py 9e040db 
>   test/integration/component/test_escalations_ipaddresses.py 23dd76b 
>   test/integration/component/test_escalations_snapshots.py 2367253 
>   test/integration/component/test_escalations_templates.py 083ba90 
>   tools/marvin/marvin/config/test_data.py 63661ed 
>   tools/marvin/marvin/lib/base.py d9c4fae 
> 
> Diff: https://reviews.apache.org/r/22501/diff/
> 
> 
> Testing
> ---
> 
> Executed the tests after making changes and all the tests are passing. 
> Attached are the log files for master
> 
> 
> File Attachments
> 
> 
> Jun_12_2014-Instances-master.txt
>   
> https://reviews.apache.org/media/uploaded/files/2014/06/12/d01ee156-ef6f-44f3-bbc1-d68c52200772__Jun_12_2014-Instances-master.txt
> Jun_12_2014-IPAddresses-Master.txt
>   
> https://reviews.apache.org/media/uploaded/files/2014/06/12/b74ce2d2-a402-4f04-a77f-0c413db59a7d__Jun_12_2014-IPAddresses-Master.txt
> Jun_12_2014-Snapshots-Master.txt
>   
> https://reviews.apache.org/media/uploaded/files/2014/06/12/b47c552a-79a6-4570-bcdb-b726fda94afb__Jun_12_2014-Snapshots-Master.txt
> Jun_12_2014-Templates-Master.txt
>   
> https://reviews.apache.org/media/uploaded/files/2014/06/12/3ea34c2b-ca46-473e-887f-d347032ffcc0__Jun_12_2014-Templates-Master.txt
> 
> 
> Thanks,
> 
> Vinay Varma
> 
>



Review Request 22626: CLOUDSTACK-6914 :Fixed the issue

2014-06-16 Thread Santhosh Edukulla

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22626/
---

Review request for cloudstack and Koushik Das.


Bugs: CLOUDSTACK-6914
https://issues.apache.org/jira/browse/CLOUDSTACK-6914


Repository: cloudstack-git


Description
---

1. VGPU test case has an issue where few imports were missing.
2. Moved test data out of test suite.
3. Current tagging has issues in bvt, fixed, added new required_hardware 
attribute = true.


Diffs
-

  test/integration/smoke/test_affinity_groups.py bb0a524 
  test/integration/smoke/test_deploy_vgpu_enabled_vm.py fa33bdc 
  test/integration/smoke/test_deploy_vm.py 8d0a0ed 
  test/integration/smoke/test_deploy_vm_root_resize.py 5d73876 
  test/integration/smoke/test_deploy_vm_with_userdata.py 7616b82 
  test/integration/smoke/test_deploy_vms_with_varied_deploymentplanners.py 
420925e 
  test/integration/smoke/test_disk_offerings.py 45f438f 
  test/integration/smoke/test_global_settings.py ace2db3 
  test/integration/smoke/test_guest_vlan_range.py f5bcdf4 
  test/integration/smoke/test_internal_lb.py d6f3477 
  test/integration/smoke/test_iso.py d394c27 
  test/integration/smoke/test_loadbalance.py daa5fee 
  test/integration/smoke/test_multipleips_per_nic.py ad3a3cf 
  test/integration/smoke/test_network.py 4100878 
  test/integration/smoke/test_network_acl.py 68e5067 
  test/integration/smoke/test_nic.py 592a839 
  test/integration/smoke/test_non_contigiousvlan.py 50b48d0 
  test/integration/smoke/test_over_provisioning.py 1c5d8a5 
  test/integration/smoke/test_portable_publicip.py 2d02a71 
  test/integration/smoke/test_primary_storage.py 3c1aa62 
  test/integration/smoke/test_privategw_acl.py c86beb1 
  test/integration/smoke/test_public_ip_range.py b961dc3 
  test/integration/smoke/test_pvlan.py 9178e62 
  test/integration/smoke/test_regions.py 389f878 
  test/integration/smoke/test_reset_vm_on_reboot.py 4709df4 
  test/integration/smoke/test_resource_detail.py 7f4a6e7 
  test/integration/smoke/test_routers.py d503af1 
  test/integration/smoke/test_scale_vm.py 261fe93 
  test/integration/smoke/test_secondary_storage.py ac80956 
  test/integration/smoke/test_service_offerings.py 980e110 
  test/integration/smoke/test_snapshots.py a9be4e2 
  test/integration/smoke/test_ssvm.py ffa620b 
  test/integration/smoke/test_templates.py c7594bb 
  test/integration/smoke/test_vm_ha.py 1fc6960 
  test/integration/smoke/test_vm_life_cycle.py 1e56571 
  test/integration/smoke/test_vm_snapshots.py e884d42 
  test/integration/smoke/test_volumes.py 2e41aa7 
  test/integration/smoke/test_vpc_vpn.py 1b28447 
  tools/marvin/marvin/config/test_data.py 44ef8d5 

Diff: https://reviews.apache.org/r/22626/diff/


Testing
---

Built the code post the changes.


Thanks,

Santhosh Edukulla



Re: Review Request 22626: CLOUDSTACK-6914 :Fixed the issue

2014-06-16 Thread Santhosh Edukulla

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22626/
---

(Updated June 16, 2014, 11:31 a.m.)


Review request for cloudstack and Abhinandan Prateek.


Bugs: CLOUDSTACK-6914
https://issues.apache.org/jira/browse/CLOUDSTACK-6914


Repository: cloudstack-git


Description
---

1. VGPU test case has an issue where few imports were missing.
2. Moved test data out of test suite.
3. Current tagging has issues in bvt, fixed, added new required_hardware 
attribute = true.


Diffs
-

  test/integration/smoke/test_affinity_groups.py bb0a524 
  test/integration/smoke/test_deploy_vgpu_enabled_vm.py fa33bdc 
  test/integration/smoke/test_deploy_vm.py 8d0a0ed 
  test/integration/smoke/test_deploy_vm_root_resize.py 5d73876 
  test/integration/smoke/test_deploy_vm_with_userdata.py 7616b82 
  test/integration/smoke/test_deploy_vms_with_varied_deploymentplanners.py 
420925e 
  test/integration/smoke/test_disk_offerings.py 45f438f 
  test/integration/smoke/test_global_settings.py ace2db3 
  test/integration/smoke/test_guest_vlan_range.py f5bcdf4 
  test/integration/smoke/test_internal_lb.py d6f3477 
  test/integration/smoke/test_iso.py d394c27 
  test/integration/smoke/test_loadbalance.py daa5fee 
  test/integration/smoke/test_multipleips_per_nic.py ad3a3cf 
  test/integration/smoke/test_network.py 4100878 
  test/integration/smoke/test_network_acl.py 68e5067 
  test/integration/smoke/test_nic.py 592a839 
  test/integration/smoke/test_non_contigiousvlan.py 50b48d0 
  test/integration/smoke/test_over_provisioning.py 1c5d8a5 
  test/integration/smoke/test_portable_publicip.py 2d02a71 
  test/integration/smoke/test_primary_storage.py 3c1aa62 
  test/integration/smoke/test_privategw_acl.py c86beb1 
  test/integration/smoke/test_public_ip_range.py b961dc3 
  test/integration/smoke/test_pvlan.py 9178e62 
  test/integration/smoke/test_regions.py 389f878 
  test/integration/smoke/test_reset_vm_on_reboot.py 4709df4 
  test/integration/smoke/test_resource_detail.py 7f4a6e7 
  test/integration/smoke/test_routers.py d503af1 
  test/integration/smoke/test_scale_vm.py 261fe93 
  test/integration/smoke/test_secondary_storage.py ac80956 
  test/integration/smoke/test_service_offerings.py 980e110 
  test/integration/smoke/test_snapshots.py a9be4e2 
  test/integration/smoke/test_ssvm.py ffa620b 
  test/integration/smoke/test_templates.py c7594bb 
  test/integration/smoke/test_vm_ha.py 1fc6960 
  test/integration/smoke/test_vm_life_cycle.py 1e56571 
  test/integration/smoke/test_vm_snapshots.py e884d42 
  test/integration/smoke/test_volumes.py 2e41aa7 
  test/integration/smoke/test_vpc_vpn.py 1b28447 
  tools/marvin/marvin/config/test_data.py 44ef8d5 

Diff: https://reviews.apache.org/r/22626/diff/


Testing
---

Built the code post the changes.


Thanks,

Santhosh Edukulla



Re: Review Request 22626: CLOUDSTACK-6914 :Fixed the issue

2014-06-16 Thread Abhinandan Prateek

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22626/#review45735
---

Ship it!


Ship It!

- Abhinandan Prateek


On June 16, 2014, 11:31 a.m., Santhosh Edukulla wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22626/
> ---
> 
> (Updated June 16, 2014, 11:31 a.m.)
> 
> 
> Review request for cloudstack and Abhinandan Prateek.
> 
> 
> Bugs: CLOUDSTACK-6914
> https://issues.apache.org/jira/browse/CLOUDSTACK-6914
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> 1. VGPU test case has an issue where few imports were missing.
> 2. Moved test data out of test suite.
> 3. Current tagging has issues in bvt, fixed, added new required_hardware 
> attribute = true.
> 
> 
> Diffs
> -
> 
>   test/integration/smoke/test_affinity_groups.py bb0a524 
>   test/integration/smoke/test_deploy_vgpu_enabled_vm.py fa33bdc 
>   test/integration/smoke/test_deploy_vm.py 8d0a0ed 
>   test/integration/smoke/test_deploy_vm_root_resize.py 5d73876 
>   test/integration/smoke/test_deploy_vm_with_userdata.py 7616b82 
>   test/integration/smoke/test_deploy_vms_with_varied_deploymentplanners.py 
> 420925e 
>   test/integration/smoke/test_disk_offerings.py 45f438f 
>   test/integration/smoke/test_global_settings.py ace2db3 
>   test/integration/smoke/test_guest_vlan_range.py f5bcdf4 
>   test/integration/smoke/test_internal_lb.py d6f3477 
>   test/integration/smoke/test_iso.py d394c27 
>   test/integration/smoke/test_loadbalance.py daa5fee 
>   test/integration/smoke/test_multipleips_per_nic.py ad3a3cf 
>   test/integration/smoke/test_network.py 4100878 
>   test/integration/smoke/test_network_acl.py 68e5067 
>   test/integration/smoke/test_nic.py 592a839 
>   test/integration/smoke/test_non_contigiousvlan.py 50b48d0 
>   test/integration/smoke/test_over_provisioning.py 1c5d8a5 
>   test/integration/smoke/test_portable_publicip.py 2d02a71 
>   test/integration/smoke/test_primary_storage.py 3c1aa62 
>   test/integration/smoke/test_privategw_acl.py c86beb1 
>   test/integration/smoke/test_public_ip_range.py b961dc3 
>   test/integration/smoke/test_pvlan.py 9178e62 
>   test/integration/smoke/test_regions.py 389f878 
>   test/integration/smoke/test_reset_vm_on_reboot.py 4709df4 
>   test/integration/smoke/test_resource_detail.py 7f4a6e7 
>   test/integration/smoke/test_routers.py d503af1 
>   test/integration/smoke/test_scale_vm.py 261fe93 
>   test/integration/smoke/test_secondary_storage.py ac80956 
>   test/integration/smoke/test_service_offerings.py 980e110 
>   test/integration/smoke/test_snapshots.py a9be4e2 
>   test/integration/smoke/test_ssvm.py ffa620b 
>   test/integration/smoke/test_templates.py c7594bb 
>   test/integration/smoke/test_vm_ha.py 1fc6960 
>   test/integration/smoke/test_vm_life_cycle.py 1e56571 
>   test/integration/smoke/test_vm_snapshots.py e884d42 
>   test/integration/smoke/test_volumes.py 2e41aa7 
>   test/integration/smoke/test_vpc_vpn.py 1b28447 
>   tools/marvin/marvin/config/test_data.py 44ef8d5 
> 
> Diff: https://reviews.apache.org/r/22626/diff/
> 
> 
> Testing
> ---
> 
> Built the code post the changes.
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>



Re: Review Request 22626: CLOUDSTACK-6914 :Fixed the issue

2014-06-16 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22626/#review45736
---


Commit 54e4c075287957821e57368f1baf401761f7bda2 in cloudstack's branch 
refs/heads/4.4-forward from Santhosh Edukulla
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=54e4c07 ]

CLOUDSTACK-6914: Fixed the Issue

Signed-off-by: Abhinandan Prateek 


- ASF Subversion and Git Services


On June 16, 2014, 11:31 a.m., Santhosh Edukulla wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22626/
> ---
> 
> (Updated June 16, 2014, 11:31 a.m.)
> 
> 
> Review request for cloudstack and Abhinandan Prateek.
> 
> 
> Bugs: CLOUDSTACK-6914
> https://issues.apache.org/jira/browse/CLOUDSTACK-6914
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> 1. VGPU test case has an issue where few imports were missing.
> 2. Moved test data out of test suite.
> 3. Current tagging has issues in bvt, fixed, added new required_hardware 
> attribute = true.
> 
> 
> Diffs
> -
> 
>   test/integration/smoke/test_affinity_groups.py bb0a524 
>   test/integration/smoke/test_deploy_vgpu_enabled_vm.py fa33bdc 
>   test/integration/smoke/test_deploy_vm.py 8d0a0ed 
>   test/integration/smoke/test_deploy_vm_root_resize.py 5d73876 
>   test/integration/smoke/test_deploy_vm_with_userdata.py 7616b82 
>   test/integration/smoke/test_deploy_vms_with_varied_deploymentplanners.py 
> 420925e 
>   test/integration/smoke/test_disk_offerings.py 45f438f 
>   test/integration/smoke/test_global_settings.py ace2db3 
>   test/integration/smoke/test_guest_vlan_range.py f5bcdf4 
>   test/integration/smoke/test_internal_lb.py d6f3477 
>   test/integration/smoke/test_iso.py d394c27 
>   test/integration/smoke/test_loadbalance.py daa5fee 
>   test/integration/smoke/test_multipleips_per_nic.py ad3a3cf 
>   test/integration/smoke/test_network.py 4100878 
>   test/integration/smoke/test_network_acl.py 68e5067 
>   test/integration/smoke/test_nic.py 592a839 
>   test/integration/smoke/test_non_contigiousvlan.py 50b48d0 
>   test/integration/smoke/test_over_provisioning.py 1c5d8a5 
>   test/integration/smoke/test_portable_publicip.py 2d02a71 
>   test/integration/smoke/test_primary_storage.py 3c1aa62 
>   test/integration/smoke/test_privategw_acl.py c86beb1 
>   test/integration/smoke/test_public_ip_range.py b961dc3 
>   test/integration/smoke/test_pvlan.py 9178e62 
>   test/integration/smoke/test_regions.py 389f878 
>   test/integration/smoke/test_reset_vm_on_reboot.py 4709df4 
>   test/integration/smoke/test_resource_detail.py 7f4a6e7 
>   test/integration/smoke/test_routers.py d503af1 
>   test/integration/smoke/test_scale_vm.py 261fe93 
>   test/integration/smoke/test_secondary_storage.py ac80956 
>   test/integration/smoke/test_service_offerings.py 980e110 
>   test/integration/smoke/test_snapshots.py a9be4e2 
>   test/integration/smoke/test_ssvm.py ffa620b 
>   test/integration/smoke/test_templates.py c7594bb 
>   test/integration/smoke/test_vm_ha.py 1fc6960 
>   test/integration/smoke/test_vm_life_cycle.py 1e56571 
>   test/integration/smoke/test_vm_snapshots.py e884d42 
>   test/integration/smoke/test_volumes.py 2e41aa7 
>   test/integration/smoke/test_vpc_vpn.py 1b28447 
>   tools/marvin/marvin/config/test_data.py 44ef8d5 
> 
> Diff: https://reviews.apache.org/r/22626/diff/
> 
> 
> Testing
> ---
> 
> Built the code post the changes.
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>



Re: Review Request 22544: CLOUDSTACK-6793: Fixed the issue in master

2014-06-16 Thread Abhinandan Prateek

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22544/#review45737
---

Ship it!


Ship It!

- Abhinandan Prateek


On June 13, 2014, 6:21 a.m., Santhosh Edukulla wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22544/
> ---
> 
> (Updated June 13, 2014, 6:21 a.m.)
> 
> 
> Review request for cloudstack and daan Hoogland.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> This issue fix was missing in master, adding it to master now.
> 
> 
> Diffs
> -
> 
>   engine/schema/src/com/cloud/user/dao/AccountDao.java 2f737cd 
>   engine/schema/src/com/cloud/user/dao/AccountDaoImpl.java 4bc23ed 
>   server/src/com/cloud/tags/TaggedResourceManagerImpl.java c4c003e 
> 
> Diff: https://reviews.apache.org/r/22544/diff/
> 
> 
> Testing
> ---
> 
> Ran the build and tested the changes.
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>



Re: Review Request 22544: CLOUDSTACK-6793: Fixed the issue in master

2014-06-16 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22544/#review45738
---


Commit f89100ed72bd8e854dc01af244907fe02e7525a3 in cloudstack's branch 
refs/heads/master from Santhosh Edukulla
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=f89100e ]

CLOUDSTACK-6793 : Added fix

Signed-off-by: Abhinandan Prateek 


- ASF Subversion and Git Services


On June 13, 2014, 6:21 a.m., Santhosh Edukulla wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22544/
> ---
> 
> (Updated June 13, 2014, 6:21 a.m.)
> 
> 
> Review request for cloudstack and daan Hoogland.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> This issue fix was missing in master, adding it to master now.
> 
> 
> Diffs
> -
> 
>   engine/schema/src/com/cloud/user/dao/AccountDao.java 2f737cd 
>   engine/schema/src/com/cloud/user/dao/AccountDaoImpl.java 4bc23ed 
>   server/src/com/cloud/tags/TaggedResourceManagerImpl.java c4c003e 
> 
> Diff: https://reviews.apache.org/r/22544/diff/
> 
> 
> Testing
> ---
> 
> Ran the build and tested the changes.
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>



Re: Review Request 22525: Fixed few reported resource leak issues

2014-06-16 Thread daan Hoogland

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22525/#review45741
---



engine/schema/src/com/cloud/vm/dao/UserVmDaoImpl.java


as said before, i think TransactionLegacy must become Closable


otherwise it seems ok, test compiling before applying

- daan Hoogland


On June 13, 2014, 6:35 a.m., Santhosh Edukulla wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22525/
> ---
> 
> (Updated June 13, 2014, 6:35 a.m.)
> 
> 
> Review request for cloudstack and daan Hoogland.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fixed few coverity issues reported.
> 
> 
> Diffs
> -
> 
>   engine/schema/src/com/cloud/vm/dao/UserVmDaoImpl.java f72690e 
> 
> Diff: https://reviews.apache.org/r/22525/diff/
> 
> 
> Testing
> ---
> 
> Built the CS, ran deploy data center post the change.
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>



Re: Review Request 22525: Fixed few reported resource leak issues

2014-06-16 Thread daan Hoogland

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22525/#review45742
---

Ship it!


3c5f64c97ab071451aee7f232d8f2cec6d89044d in 4.4-forward

- daan Hoogland


On June 13, 2014, 6:35 a.m., Santhosh Edukulla wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22525/
> ---
> 
> (Updated June 13, 2014, 6:35 a.m.)
> 
> 
> Review request for cloudstack and daan Hoogland.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fixed few coverity issues reported.
> 
> 
> Diffs
> -
> 
>   engine/schema/src/com/cloud/vm/dao/UserVmDaoImpl.java f72690e 
> 
> Diff: https://reviews.apache.org/r/22525/diff/
> 
> 
> Testing
> ---
> 
> Built the CS, ran deploy data center post the change.
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>



Re: Review Request 22525: Fixed few reported resource leak issues

2014-06-16 Thread daan Hoogland


> On June 16, 2014, 12:23 p.m., daan Hoogland wrote:
> > 3c5f64c97ab071451aee7f232d8f2cec6d89044d in 4.4-forward

d86b6778adbd754a7e98c29d854b3c265954bca8 in master


- daan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22525/#review45742
---


On June 13, 2014, 6:35 a.m., Santhosh Edukulla wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22525/
> ---
> 
> (Updated June 13, 2014, 6:35 a.m.)
> 
> 
> Review request for cloudstack and daan Hoogland.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fixed few coverity issues reported.
> 
> 
> Diffs
> -
> 
>   engine/schema/src/com/cloud/vm/dao/UserVmDaoImpl.java f72690e 
> 
> Diff: https://reviews.apache.org/r/22525/diff/
> 
> 
> Testing
> ---
> 
> Built the CS, ran deploy data center post the change.
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>



Build failed in Jenkins: build-master #969

2014-06-16 Thread jenkins
See 

Changes:

[Daan Hoogland] Fixed few resource leak issues

--
[...truncated  lines...]

Results :

Tests run: 4, Failures: 0, Errors: 0, Skipped: 0

[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Framework - Clustering 4.5.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloud-framework-cluster ---
[INFO] Deleting 
 
(includes = [**/*], excludes = [])
[INFO] Deleting 
 
(includes = [target, dist], excludes = [])
[INFO] 
[INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ 
cloud-framework-cluster ---
[INFO] Starting audit...
Audit done.

[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ 
cloud-framework-cluster ---
[INFO] 
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ 
cloud-framework-cluster ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 1 resource
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ 
cloud-framework-cluster ---
[INFO] Compiling 28 source files to 

[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-framework-cluster ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ 
cloud-framework-cluster ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.12:test (default-test) @ 
cloud-framework-cluster ---
[INFO] Surefire report directory: 


---
 T E S T S
---

Results :

Tests run: 0, Failures: 0, Errors: 0, Skipped: 0

[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Framework - Event Notification 4.5.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloud-framework-events ---
[INFO] Deleting 
 
(includes = [**/*], excludes = [])
[INFO] Deleting 
 (includes 
= [target, dist], excludes = [])
[INFO] 
[INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ 
cloud-framework-events ---
[INFO] Starting audit...
Audit done.

[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ 
cloud-framework-events ---
[INFO] 
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ 
cloud-framework-events ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ 
cloud-framework-events ---
[INFO] Compiling 5 source files to 

[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-framework-events ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ 
cloud-framework-events ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.12:test (default-test) @ 
cloud-framework-events ---
[INFO] Surefire report directory: 


---
 T E S T S
---

Results :

Tests run: 0, Failures: 0, Errors: 0, Skipped: 0

[INFO]  

Blogs

2014-06-16 Thread sebgoa
The website points to our blog at:

https://blogs.apache.org/cloudstack/

I am pretty sure we used to aggregate bunch of our own blogs there, but it does 
not look like it's being done now.

Did something change ?

Also, where is our planet ? I thought we got it done 

-sebastien

Review Request 22631: supporting nfs protocol and resize feature for managed storage in xenserver.

2014-06-16 Thread punith s

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22631/
---

Review request for cloudstack, amit kumar das, edison su, and Mike Tutkowski.


Repository: cloudstack-git


Description
---

currently managed storage only supports iscsi protocol.

hence now adding support for nfs protocol and also resizing the vdi to the SR 
size, hence fully utilizing the SR space in managed storage.

to support nfs, the getNfsSR method's signature has to changed similar to 
existing getIscsiSR method.

SR will be created based on the volume's protocoltype.

jira id - CLOUDSTACK-6916


Diffs
-

  api/src/com/cloud/agent/api/to/DiskTO.java 5901367 
  
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java
 eea931e 
  
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
 9979802 
  server/src/com/cloud/storage/VolumeApiServiceImpl.java 9b034e9 

Diff: https://reviews.apache.org/r/22631/diff/


Testing
---

system testing done.


Thanks,

punith s



Re: Review Request 22608: Fixed resource leaks, null derefernces and other issues reported

2014-06-16 Thread daan Hoogland

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22608/#review45746
---

Ship it!


dbfce8b11e25855a8cb21ec2bbbfe20940bb788d

- daan Hoogland


On June 14, 2014, 4:57 p.m., Santhosh Edukulla wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22608/
> ---
> 
> (Updated June 14, 2014, 4:57 p.m.)
> 
> 
> Review request for cloudstack and daan Hoogland.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fixed resource leaks, null dereferences and other misc issues reported.
> 
> 
> Diffs
> -
> 
>   engine/schema/src/com/cloud/upgrade/dao/Upgrade421to430.java 889cad4 
>   engine/schema/src/com/cloud/vm/VMInstanceVO.java 849e042 
>   
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java
>  681fcee 
>   server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 
> 05fbad3 
>   utils/src/com/cloud/utils/net/NetUtils.java 6350986 
> 
> Diff: https://reviews.apache.org/r/22608/diff/
> 
> 
> Testing
> ---
> 
> Built and ran to deploy a datacenter
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>



Jenkins build is back to normal : build-master #970

2014-06-16 Thread jenkins
See 



[ACS44] are we RC-ready?

2014-06-16 Thread Daan Hoogland
s far as I can tell the only remaining blocker issue has been fixed
last week. There are 84 criticals. Do we feel we are RC ready as we
are or are some of those critical to critical to go and release? If
so, what needs to be done to get there. Please respond promptly or
show yourself on #cloudstack-meeting in 50 minutes.

with kind regards and loads of gratitude,
-- 
Daan


[ACS44] Cherry Pick Request

2014-06-16 Thread Santhosh Edukulla
Daan,

Please pick up the below fixes for resource leaks and other Coverity issues.

4ba3aae2ea0290ca012623083e13625e08a9dde5
3c5f64c97ab071451aee7f232d8f2cec6d89044d
dbfce8b11e25855a8cb21ec2bbbfe20940bb788d


As well, please check the below commit, its fix for CLOUDSTACK-6793

91d054cb00f6a5818f2be1c7e4d3f44a2c58bfcc

Thanks!
Santhosh

Re: Blogs

2014-06-16 Thread David Nalley
http://planet.apache.org/cloudstack

On Mon, Jun 16, 2014 at 9:24 AM, sebgoa  wrote:
> The website points to our blog at:
>
> https://blogs.apache.org/cloudstack/
>
> I am pretty sure we used to aggregate bunch of our own blogs there, but it 
> does not look like it's being done now.
>
> Did something change ?
>
> Also, where is our planet ? I thought we got it done
>
> -sebastien


#cloudstack-meeting

2014-06-16 Thread Daan Hoogland
I can't connect to irc.freenode.net

anybody else got problems with it?

-- 
Daan


Re: #cloudstack-meeting

2014-06-16 Thread Pierre-Luc Dion
There was this message this morning on IRC:

07:37 ASFBot: [Announcement] Be advised; Our data center in the US is
undergoing upgrades to their network this afternoon. This may lead to
temporary downtime for many core services during the next few hours,
including this lil' IRC bot. We expect the downtime to be no more than 15
minutes, but are unable to say when exactly it will occur. Thank you in
advance for your patience and understanding

other then that, we are some people conencted to #cloudstack-meeting


Pierre-Luc Dion
Architecte de Solution Cloud | Cloud Solutions Architect
855-OK-CLOUD (855-652-5683) x1101
- - -

*CloudOps*420 rue Guy
Montréal QC  H3J 1S6
www.cloudops.com
@CloudOps_


On Mon, Jun 16, 2014 at 11:09 AM, Daan Hoogland 
wrote:

> I can't connect to irc.freenode.net
>
> anybody else got problems with it?
>
> --
> Daan
>


Re: #cloudstack-meeting

2014-06-16 Thread sebgoa
looks like 13 of us are in there right now

On Jun 16, 2014, at 5:09 PM, Daan Hoogland  wrote:

> I can't connect to irc.freenode.net
> 
> anybody else got problems with it?
> 
> -- 
> Daan



Re: #cloudstack-meeting

2014-06-16 Thread Daan Hoogland
hope you have a RM in :(

On Mon, Jun 16, 2014 at 5:12 PM, sebgoa  wrote:
> looks like 13 of us are in there right now
>
> On Jun 16, 2014, at 5:09 PM, Daan Hoogland  wrote:
>
>> I can't connect to irc.freenode.net
>>
>> anybody else got problems with it?
>>
>> --
>> Daan
>



-- 
Daan


Re: Review Request 22631: supporting nfs protocol and resize feature for managed storage in xenserver.

2014-06-16 Thread Mike Tutkowski

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22631/#review45757
---


I was curious about the resizing of the VDI to take up all of the space of the 
SR.

This is actually what I initially did in 4.2; however, it later dawned on me 
that - if you want to take hypervisor snapshots - then you need to have extra 
space left over in the SR. In other words, the VDI should be less than the size 
of the SR.

To support this, I added a new field in 4.3: hypervisor_ss_reserve. This field 
is a percentage of the size of the CloudStack volume (the VDI).

For example, if the user wants a 20 GB CloudStack volume (VDI) and the 
hypervisor snapshot reserve field is set at 200%, the SR will be 60 GB (20 GB 
for the VDI + (20 GB * 2)).

Please let me know if you'd like more clarification on this. You can also 
examine the SolidFire plug-in to get a feel for how this new field is utilized.

- Mike Tutkowski


On June 16, 2014, 1:36 p.m., punith s wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22631/
> ---
> 
> (Updated June 16, 2014, 1:36 p.m.)
> 
> 
> Review request for cloudstack, amit kumar das, edison su, and Mike Tutkowski.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> currently managed storage only supports iscsi protocol.
> 
> hence now adding support for nfs protocol and also resizing the vdi to the SR 
> size, hence fully utilizing the SR space in managed storage.
> 
> to support nfs, the getNfsSR method's signature has to changed similar to 
> existing getIscsiSR method.
> 
> SR will be created based on the volume's protocoltype.
> 
> jira id - CLOUDSTACK-6916
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/agent/api/to/DiskTO.java 5901367 
>   
> engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java
>  eea931e 
>   
> plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
>  9979802 
>   server/src/com/cloud/storage/VolumeApiServiceImpl.java 9b034e9 
> 
> Diff: https://reviews.apache.org/r/22631/diff/
> 
> 
> Testing
> ---
> 
> system testing done.
> 
> 
> Thanks,
> 
> punith s
> 
>



Re: irc meeting on rvr4vpc

2014-06-16 Thread Karl Harris
Outlined below is an overview of the analysis and in process work for
adding Virtual Redundant Routing to CloudStack Virtual Private Clouds.


Current state:

Public networks allow for redundant VR (Virtual Routers).
The network topology is static. The network topology consists of a single
guest
network and a public network. The VR redundancy is implemented using a
second VR
and KeepAlived and Conntrackd software packages configured to match the
static
network topology. The static network topology is configured using parameters
passed to the VR Linux image using /proc/cmdline. The /proc/cmdline line
information
is parsed by a shell script called cloud-early-config.sh. The appropriate
parameters
required for VR redundant setup are used to configured the KeepAlived and
Conntrackd
packages if a boolean named redundant_router is true(1). While changes can
be made
to the guest network using the script guestnw.sh; this shell script assumes
the topology
of the network will not change.

Desired state:

Redundant VR's should be available in not only Public Networks but also
Virtual Private Clouds (VPC)
under CloudStack.

Issues:

VPC allow for, among other things, networks with a dynamic topology, aka
tiers.

Current shells scripts that configure redundant VR's in public networks
cannot
Create, Read, Update, or Delete (CRUD) virtual networks and VR's because of
the
the script(s) and programs used to change the guest network assume a static
network topology.

Minimal unit testing for CRUD functions.


Current Work in Process:

Generate Unit tests to Create, Read, Update and Delete for both redundant
and non redundant
networks using a single System Vritual Machine image VM based on changes to
script files
below.

Generate Unit test to verify VPCVirtualNetworkApplianceManagerImpl.java
will work with CRUD
enabled scripts.

Add the interface and ability to do network CRUD to guestnw.sh and
cloud-early-config.sh.

Modify VPCVirtualNetworkApplianceManagerImpl to allow changes to guest
network using
new CRUD functionality of guesnw.sh mentioned above.

Modify UI and other Java code as required for implantation of VPC redundant
routers.

Karl


On Wed, Jun 11, 2014 at 3:16 PM, Sheng Yang  wrote:

> One note:
>
> In fact the split of MASTER is not a big issue, because that would only
> happen if network runs bad enough, which already cause packet loss.
>
> The problem is it should recover from that situation fast enough.
> Previously due to ARP ping from BACKUP router(which thought it would
> replace MASTER), upstream switch would redirect the traffic to original
> BACKUP router for a while, then as soon as network recovered, MASTER would
> preempt BACKUP once again. But it may take some time for upstream switch to
> aware that MAC/Port/IP mapping has been changed. We once tried different
> MAC for MASTER and BACKUP but found it would result in upstream switch fail
> to recognize the MASTER again. Now we're still using same MAC for MASTER
> and BACKUP, and upstream switch can handle the situation better.
>
> --Sheng
>
>
> On Wed, Jun 11, 2014 at 12:48 AM, Daan Hoogland <
> dhoogl...@schubergphilis.com> wrote:
>
> > H,
> >
> > We had a little meeting on the state of this feature and the way to go. I
> > have no karma for ASFBot meetings so here is my excerpt from the
> transcript:
> >
> > Attendance:
> > K3KH Karl Harris
> > Yasker Sheng Yang
> > Spark404 Hugo Trippaers
> > echaz Eric Chazas
> > LeoSimons Leo Simons
> > dahn Daan Hoogland
> >
> > others where present in the room but not active in the meeting
> >
> > Agenda:
> > -  Feasibility experiment plans by Schuberg Philis
> > -  Reusable work by Karl
> > -  Problems Citrix encountered with the regular redundant router
> > (and how to avoid them)
> > -  Work division
> > -  (next meeting needed?)
> >
> > We tried to follow the agenda but were not very strict on it. I'll
> > summarize outcome per agenda bullet:
> >
> > Schuberg Philis wants to implement a feasibility redundant router on a
> > simulated vpc environment using the operational expertise it has in
> house.
> > The outcome would then be back ported to the device, it's agent and the
> > management server.
> >
> > The implementation tactics is to create a json like configuration
> > description and to let the device do its own configuration. The idea is
> to
> > have a single device for normal and vpc routers and to let the redundancy
> > be a mere property of it. This should lead to the ultimate objective
> which
> > is to have a single relatively simple maintainable device.
> >
> > Karl will describe his endeavors in adapting the existing device on list.
> >
> > Sheng described the QA problems Citrix had with the existing redundant
> > capabilities of the VR and assured us that only one real problem
> persists.
> > The failover time of 3 seconds occasionally leads to a split brain which
> > leads to two VR's assuming the role of master. As the management server
> in
> > a

Re: Review Request 22631: supporting nfs protocol and resize feature for managed storage in xenserver.

2014-06-16 Thread Mike Tutkowski

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22631/#review45762
---



plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java


It looks like in VolumeOrchestrator that the protocol type can be "null".

That being the case, I recommend you reverse the order of the "if" 
statement here to be like this:

if (StoragePoolType.NetworkFilesystem.toString().equals(protocoltype))

This should avoid a NullPointerException if protocoltype is ever 'null'.


- Mike Tutkowski


On June 16, 2014, 1:36 p.m., punith s wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22631/
> ---
> 
> (Updated June 16, 2014, 1:36 p.m.)
> 
> 
> Review request for cloudstack, amit kumar das, edison su, and Mike Tutkowski.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> currently managed storage only supports iscsi protocol.
> 
> hence now adding support for nfs protocol and also resizing the vdi to the SR 
> size, hence fully utilizing the SR space in managed storage.
> 
> to support nfs, the getNfsSR method's signature has to changed similar to 
> existing getIscsiSR method.
> 
> SR will be created based on the volume's protocoltype.
> 
> jira id - CLOUDSTACK-6916
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/agent/api/to/DiskTO.java 5901367 
>   
> engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java
>  eea931e 
>   
> plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
>  9979802 
>   server/src/com/cloud/storage/VolumeApiServiceImpl.java 9b034e9 
> 
> Diff: https://reviews.apache.org/r/22631/diff/
> 
> 
> Testing
> ---
> 
> system testing done.
> 
> 
> Thanks,
> 
> punith s
> 
>



Re: [ACS44] Cherry Pick Request

2014-06-16 Thread Daan Hoogland
On Mon, Jun 16, 2014 at 4:28 PM, Santhosh Edukulla
 wrote:
> Daan,
>
> Please pick up the below fixes for resource leaks and other Coverity issues.
>
> 4ba3aae2ea0290ca012623083e13625e08a9dde5
was in already?

> 3c5f64c97ab071451aee7f232d8f2cec6d89044d
in

> dbfce8b11e25855a8cb21ec2bbbfe20940bb788d
had conflicts

>
>
> As well, please check the below commit, its fix for CLOUDSTACK-6793
>
> 91d054cb00f6a5818f2be1c7e4d3f44a2c58bfcc
was in already?

>
> Thanks!
> Santhosh



-- 
Daan


Re: DevCloud replacement

2014-06-16 Thread Leo Simons
Hey Ian,

Nice work! I got this working on my home PC on the weekend [1].

The readme on github could probably do with pointers to how to set up the
host-only network which is also used for devcloud:

   
https://cwiki.apache.org/confluence/display/CLOUDSTACK/DevCloud#DevCloud-Se
ttingup(VirtualBox)


Cheers,


Leo

[1] today, on my corporate laptop (mac) I cannot quite get it working
since my silly corporate firewall is preventing connection from the VMs
back to the host. I did hack and ssh-tunnel up to the point that the vms
come up (so at least I know it is not a mac-compat or script issue), but
then cloudstack fails to create the system vm instances. Basically what I
need to use here is design 2 or 3; my own local setup at the moment
basically matches design 2.

On 6/13/14, 9:05 PM, "Ian Duffy"  wrote:

>Awesome!
>
>I'm still tweaking things here and there. For whatever reason my internet
>connection to S3 is very poor so I'm insuring that caching of templates on
>the host via vagrant-cachier works 100%.
>
>Will do out more in-depth documentation over the next 2 weeks. Will
>explain
>what makes up the boxes and how all the projects tie into each other.
>
>Still need to deliver on the two other designs 2
>http://www.google-melange.com/gsoc/proposal/public/google/gsoc2014/imduffy
>15/5662278724616192
>
>
>On 13 June 2014 20:02, Rohit Yadav  wrote:
>
>> Thanks for your work Ian, it's up and running, and I finally have a Xen
>> vm/box to play with.
>>
>> Cheers.
>>
>>
>> On Fri, Jun 13, 2014 at 11:51 PM, Ian Duffy  wrote:
>>
>>> Hi Rohit,
>>>
>>> Thank you for the PR :) was meaning to add a section on the vagrant
>>>setup.
>>>
>>> I've recently extended some of it to use vagrant-cachier for caching
>>>the
>>> systemvm templates.
>>>
>>>
>>> On 13 June 2014 19:05, Rohit Yadav  wrote:
>>>
 I've fixed README: https://github.com/imduffy15/GSoC-2014/pull/1

 I installed two vagrant plugins and now it has started to work :)
Still
 under progress.

 Cheers.



 On Fri, Jun 13, 2014 at 11:21 PM, Rohit Yadav 
 wrote:

> Hi Ian,
>
> I tried to launch using vagrant up and getting following errors
>related
> to librarian_chef and omnibus. I just followed the README file -
>cloned
> your repo, updated submodules (so they are cloned too) and did
>vagrant up.
>
> Before opening issue on JIRA, I thought I share it here. Here's the
> full log;
>
> $ vagrant up
>  
>[21:48:22]
>
> Bringing machine 'management' up with 'virtualbox' provider...
>
> Bringing machine 'xenserver' up with 'virtualbox' provider...
>
> ==> management: Box 'chef/centos-6.5' could not be found. Attempting
>to
> find and install...
>
> management: Box Provider: virtualbox
>
> management: Box Version: >= 0
>
> ==> management: Loading metadata for box 'chef/centos-6.5'
>
> management: URL: https://vagrantcloud.com/chef/centos-6.5
>
> ==> management: Adding box 'chef/centos-6.5' (v1.0.0) for provider:
> virtualbox
>
> management: Downloading:
> 
>https://vagrantcloud.com/chef/centos-6.5/version/1/provider/virtualbox
>.box
>
> ==> management: Successfully added box 'chef/centos-6.5' (v1.0.0) for
> 'virtualbox'!
>
> There are errors in the configuration of this machine. Please fix
>
> the following errors and try again:
>
> Vagrant:
>
> * Unknown configuration section 'librarian_chef'.
>
> * Unknown configuration section 'omnibus'.
>
>
>
>
> On Fri, Jun 13, 2014 at 9:41 PM, Rohit Yadav 
> wrote:
>
>> On Fri, Jun 13, 2014 at 9:25 PM, Daan Hoogland <
>> daan.hoogl...@gmail.com> wrote:
>>
>>> Thanks Sebastien and of course Ian,
>>>
>>> I will try. BUT i think the reason is that xcp is not well
>>>supported
>>> and devcloud is not based on xenserver but on xcp or even a vanilla
>>> (debian/ubuntu?) xen. So will we continue on Ians path or go back
>>>and
>>> fix devcloud?
>>>
>>
>> I think there is no point in supporting XCP, so we should continue
>> with Ian's path and start using/testing ACS with xenserver ( or
>>xenproject).
>>
>>  Thanks Ian and Sebastien, trying it out now.
>>
>> The ttylinux image is also accessible here:
>> http://people.apache.org/~bhaisaab/vms/ttylinux_pv.vhd
>>
>> Cheers.
>>
>>
>>>
>>> On Fri, Jun 13, 2014 at 5:36 PM, sebgoa  wrote:
>>> > Hi folks,
>>> >
>>> > As you know I love Devcloud, but it has its pains and lately it
>>>got
>>> broken in 4.3, and I don't think it works with 4.4.
>>> >
>>> > So I encourage you to check out:
>>> >
>>> > https://github.com/imduffy15/GSoC-2014
>>> >
>>> > This works out of the box.
>>> >
>>> > It is from Ian , it uses Vagrant boxes 

[ACS44] irc meeting on release

2014-06-16 Thread Daan Hoogland
We had a badly attended meeting on the next release

here are the minutes
http://wilderness.apache.org/archives/cloudstack-meeting-16_06_2014-5933.html

next week same time (if still needed)
-- 
Daan


Re: Can we delete a template after a VM is instantiated from it?

2014-06-16 Thread Rafael Weingartner
This way, it seems that you have a bug in CS 4.3.0 when starting a machine
that was created from a template that has been deleted.


There will happen a null pointer exception in:
“858 -if (volTemplateId != null && volTemplateId.longValue() !=
template.getId())”

The object, “template” is going to be null, because in:

“811 -  VirtualMachineTemplate template =
_entityMgr.findById(VirtualMachineTemplate.class, vm.getTemplateId());”

The findById, will add a where clause, looking for template that have the
column removed that is null, therefore It will return a null object.



On Mon, Jun 16, 2014 at 4:41 AM, Nux!  wrote:

> Hi,
>
> You can remove it from the UI, but not directly from the disk as it is
> used (in many cases) as a backing file for the VMs spawned from it.
>
> HTH
> Lucian
>
> --
> Sent from the Delta quadrant using Borg technology!
>
> Nux!
> www.nux.ro
>
> - Original Message -
> From: "Sanjeev Neelarapu" 
> To: dev@cloudstack.apache.org
> Sent: Monday, 16 June, 2014 5:18:04 AM
> Subject: RE: Can we delete a template after a VM is instantiated from it?
>
> We can delete template without any issues.
>
> -Sanjeev
>
> -Original Message-
> From: Rafael Weingartner [mailto:rafaelweingart...@gmail.com]
> Sent: Sunday, June 15, 2014 8:48 PM
> To: dev@cloudstack.apache.org
> Subject: Can we delete a template after a VM is instantiated from it?
>
>  Hi,
>
> I was wondering if we can delete a template that has already been used to
> instantiate some VMs.
>
> Would that cause any trouble?
>
> --
> Rafael Weingärtner
>



-- 
Rafael Weingärtner


Re: [ACS44] irc meeting on release

2014-06-16 Thread Mike Tutkowski
Thanks, Daan!

As I mentioned, I had another meeting I had to attend at that time today,
but I should be able to attend next week.


On Mon, Jun 16, 2014 at 10:20 AM, Daan Hoogland 
wrote:

> We had a badly attended meeting on the next release
>
> here are the minutes
>
> http://wilderness.apache.org/archives/cloudstack-meeting-16_06_2014-5933.html
>
> next week same time (if still needed)
> --
> Daan
>



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
*™*


Re: DevCloud replacement

2014-06-16 Thread Rohit Yadav
Hi Leo,

Ian's xenserver vagrant works on host-only too. If you do 'vagrant up' and
if the VMs boot up you verify with VirtualBox that the second VM
(xenserver) will have nic0 (NAT) and nic1 (host-only with promiscuous mode
enabled). If that is not the case I suspect some issue in Chef/Vagrant that
needs debugging.

Regards.


On Mon, Jun 16, 2014 at 9:48 PM, Leo Simons 
wrote:

> Hey Ian,
>
> Nice work! I got this working on my home PC on the weekend [1].
>
> The readme on github could probably do with pointers to how to set up the
> host-only network which is also used for devcloud:
>
>
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/DevCloud#DevCloud-Se
> ttingup(VirtualBox)
>
>
> Cheers,
>
>
> Leo
>
> [1] today, on my corporate laptop (mac) I cannot quite get it working
> since my silly corporate firewall is preventing connection from the VMs
> back to the host. I did hack and ssh-tunnel up to the point that the vms
> come up (so at least I know it is not a mac-compat or script issue), but
> then cloudstack fails to create the system vm instances. Basically what I
> need to use here is design 2 or 3; my own local setup at the moment
> basically matches design 2.
>
> On 6/13/14, 9:05 PM, "Ian Duffy"  wrote:
>
> >Awesome!
> >
> >I'm still tweaking things here and there. For whatever reason my internet
> >connection to S3 is very poor so I'm insuring that caching of templates on
> >the host via vagrant-cachier works 100%.
> >
> >Will do out more in-depth documentation over the next 2 weeks. Will
> >explain
> >what makes up the boxes and how all the projects tie into each other.
> >
> >Still need to deliver on the two other designs 2
> >
> http://www.google-melange.com/gsoc/proposal/public/google/gsoc2014/imduffy
> >15/5662278724616192
> >
> >
> >On 13 June 2014 20:02, Rohit Yadav  wrote:
> >
> >> Thanks for your work Ian, it's up and running, and I finally have a Xen
> >> vm/box to play with.
> >>
> >> Cheers.
> >>
> >>
> >> On Fri, Jun 13, 2014 at 11:51 PM, Ian Duffy  wrote:
> >>
> >>> Hi Rohit,
> >>>
> >>> Thank you for the PR :) was meaning to add a section on the vagrant
> >>>setup.
> >>>
> >>> I've recently extended some of it to use vagrant-cachier for caching
> >>>the
> >>> systemvm templates.
> >>>
> >>>
> >>> On 13 June 2014 19:05, Rohit Yadav  wrote:
> >>>
>  I've fixed README: https://github.com/imduffy15/GSoC-2014/pull/1
> 
>  I installed two vagrant plugins and now it has started to work :)
> Still
>  under progress.
> 
>  Cheers.
> 
> 
> 
>  On Fri, Jun 13, 2014 at 11:21 PM, Rohit Yadav 
>  wrote:
> 
> > Hi Ian,
> >
> > I tried to launch using vagrant up and getting following errors
> >related
> > to librarian_chef and omnibus. I just followed the README file -
> >cloned
> > your repo, updated submodules (so they are cloned too) and did
> >vagrant up.
> >
> > Before opening issue on JIRA, I thought I share it here. Here's the
> > full log;
> >
> > $ vagrant up
> >
> >[21:48:22]
> >
> > Bringing machine 'management' up with 'virtualbox' provider...
> >
> > Bringing machine 'xenserver' up with 'virtualbox' provider...
> >
> > ==> management: Box 'chef/centos-6.5' could not be found. Attempting
> >to
> > find and install...
> >
> > management: Box Provider: virtualbox
> >
> > management: Box Version: >= 0
> >
> > ==> management: Loading metadata for box 'chef/centos-6.5'
> >
> > management: URL: https://vagrantcloud.com/chef/centos-6.5
> >
> > ==> management: Adding box 'chef/centos-6.5' (v1.0.0) for provider:
> > virtualbox
> >
> > management: Downloading:
> >
> >
> https://vagrantcloud.com/chef/centos-6.5/version/1/provider/virtualbox
> >.box
> >
> > ==> management: Successfully added box 'chef/centos-6.5' (v1.0.0) for
> > 'virtualbox'!
> >
> > There are errors in the configuration of this machine. Please fix
> >
> > the following errors and try again:
> >
> > Vagrant:
> >
> > * Unknown configuration section 'librarian_chef'.
> >
> > * Unknown configuration section 'omnibus'.
> >
> >
> >
> >
> > On Fri, Jun 13, 2014 at 9:41 PM, Rohit Yadav 
> > wrote:
> >
> >> On Fri, Jun 13, 2014 at 9:25 PM, Daan Hoogland <
> >> daan.hoogl...@gmail.com> wrote:
> >>
> >>> Thanks Sebastien and of course Ian,
> >>>
> >>> I will try. BUT i think the reason is that xcp is not well
> >>>supported
> >>> and devcloud is not based on xenserver but on xcp or even a vanilla
> >>> (debian/ubuntu?) xen. So will we continue on Ians path or go back
> >>>and
> >>> fix devcloud?
> >>>
> >>
> >> I think there is no point in supporting XCP, so we should continue
> >> with Ian's path and start using/testing ACS with xenserver ( or
> >>xenproject).
> >>
>

Re: DevCloud replacement

2014-06-16 Thread Ian Duffy
Hi Leo,

Thanks for the feedback. Will add some virtualbox network instructions, its
something I always overlook, always set and forget.

The corporate firewall issue sounds interesting. What is the name of it
just out of interest? I've had issues in the past on a mac with
communications being blocked from VM <-> host over a host-only connection.


On 16 June 2014 19:14, Rohit Yadav  wrote:

> Hi Leo,
>
> Ian's xenserver vagrant works on host-only too. If you do 'vagrant up' and
> if the VMs boot up you verify with VirtualBox that the second VM
> (xenserver) will have nic0 (NAT) and nic1 (host-only with promiscuous mode
> enabled). If that is not the case I suspect some issue in Chef/Vagrant that
> needs debugging.
>
> Regards.
>
>
> On Mon, Jun 16, 2014 at 9:48 PM, Leo Simons 
> wrote:
>
> > Hey Ian,
> >
> > Nice work! I got this working on my home PC on the weekend [1].
> >
> > The readme on github could probably do with pointers to how to set up the
> > host-only network which is also used for devcloud:
> >
> >
> >
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/DevCloud#DevCloud-Se
> > ttingup(VirtualBox)
> >
> >
> > Cheers,
> >
> >
> > Leo
> >
> > [1] today, on my corporate laptop (mac) I cannot quite get it working
> > since my silly corporate firewall is preventing connection from the VMs
> > back to the host. I did hack and ssh-tunnel up to the point that the vms
> > come up (so at least I know it is not a mac-compat or script issue), but
> > then cloudstack fails to create the system vm instances. Basically what I
> > need to use here is design 2 or 3; my own local setup at the moment
> > basically matches design 2.
> >
> > On 6/13/14, 9:05 PM, "Ian Duffy"  wrote:
> >
> > >Awesome!
> > >
> > >I'm still tweaking things here and there. For whatever reason my
> internet
> > >connection to S3 is very poor so I'm insuring that caching of templates
> on
> > >the host via vagrant-cachier works 100%.
> > >
> > >Will do out more in-depth documentation over the next 2 weeks. Will
> > >explain
> > >what makes up the boxes and how all the projects tie into each other.
> > >
> > >Still need to deliver on the two other designs 2
> > >
> >
> http://www.google-melange.com/gsoc/proposal/public/google/gsoc2014/imduffy
> > >15/5662278724616192
> > >
> > >
> > >On 13 June 2014 20:02, Rohit Yadav  wrote:
> > >
> > >> Thanks for your work Ian, it's up and running, and I finally have a
> Xen
> > >> vm/box to play with.
> > >>
> > >> Cheers.
> > >>
> > >>
> > >> On Fri, Jun 13, 2014 at 11:51 PM, Ian Duffy  wrote:
> > >>
> > >>> Hi Rohit,
> > >>>
> > >>> Thank you for the PR :) was meaning to add a section on the vagrant
> > >>>setup.
> > >>>
> > >>> I've recently extended some of it to use vagrant-cachier for caching
> > >>>the
> > >>> systemvm templates.
> > >>>
> > >>>
> > >>> On 13 June 2014 19:05, Rohit Yadav  wrote:
> > >>>
> >  I've fixed README: https://github.com/imduffy15/GSoC-2014/pull/1
> > 
> >  I installed two vagrant plugins and now it has started to work :)
> > Still
> >  under progress.
> > 
> >  Cheers.
> > 
> > 
> > 
> >  On Fri, Jun 13, 2014 at 11:21 PM, Rohit Yadav 
> >  wrote:
> > 
> > > Hi Ian,
> > >
> > > I tried to launch using vagrant up and getting following errors
> > >related
> > > to librarian_chef and omnibus. I just followed the README file -
> > >cloned
> > > your repo, updated submodules (so they are cloned too) and did
> > >vagrant up.
> > >
> > > Before opening issue on JIRA, I thought I share it here. Here's the
> > > full log;
> > >
> > > $ vagrant up
> > >
> > >[21:48:22]
> > >
> > > Bringing machine 'management' up with 'virtualbox' provider...
> > >
> > > Bringing machine 'xenserver' up with 'virtualbox' provider...
> > >
> > > ==> management: Box 'chef/centos-6.5' could not be found.
> Attempting
> > >to
> > > find and install...
> > >
> > > management: Box Provider: virtualbox
> > >
> > > management: Box Version: >= 0
> > >
> > > ==> management: Loading metadata for box 'chef/centos-6.5'
> > >
> > > management: URL: https://vagrantcloud.com/chef/centos-6.5
> > >
> > > ==> management: Adding box 'chef/centos-6.5' (v1.0.0) for provider:
> > > virtualbox
> > >
> > > management: Downloading:
> > >
> > >
> > https://vagrantcloud.com/chef/centos-6.5/version/1/provider/virtualbox
> > >.box
> > >
> > > ==> management: Successfully added box 'chef/centos-6.5' (v1.0.0)
> for
> > > 'virtualbox'!
> > >
> > > There are errors in the configuration of this machine. Please fix
> > >
> > > the following errors and try again:
> > >
> > > Vagrant:
> > >
> > > * Unknown configuration section 'librarian_chef'.
> > >
> > > * Unknown configuration section 'omnibus'.
> > >
> > >
> > >
> > >
> > > On Fri,

Re: irc meeting on rvr4vpc

2014-06-16 Thread Daan Hoogland
H Karl,

We will have a look at this with the team at Schuberg Philis, thanks.

On Mon, Jun 16, 2014 at 5:46 PM, Karl Harris  wrote:
> Outlined below is an overview of the analysis and in process work for
> adding Virtual Redundant Routing to CloudStack Virtual Private Clouds.
>
>
> Current state:
>
> Public networks allow for redundant VR (Virtual Routers).
> The network topology is static. The network topology consists of a single
> guest
> network and a public network. The VR redundancy is implemented using a
> second VR
> and KeepAlived and Conntrackd software packages configured to match the
> static
> network topology. The static network topology is configured using parameters
> passed to the VR Linux image using /proc/cmdline. The /proc/cmdline line
> information
> is parsed by a shell script called cloud-early-config.sh. The appropriate
> parameters
> required for VR redundant setup are used to configured the KeepAlived and
> Conntrackd
> packages if a boolean named redundant_router is true(1). While changes can
> be made
> to the guest network using the script guestnw.sh; this shell script assumes
> the topology
> of the network will not change.
>
> Desired state:
>
> Redundant VR's should be available in not only Public Networks but also
> Virtual Private Clouds (VPC)
> under CloudStack.
>
> Issues:
>
> VPC allow for, among other things, networks with a dynamic topology, aka
> tiers.
>
> Current shells scripts that configure redundant VR's in public networks
> cannot
> Create, Read, Update, or Delete (CRUD) virtual networks and VR's because of
> the
> the script(s) and programs used to change the guest network assume a static
> network topology.
>
> Minimal unit testing for CRUD functions.
>
>
> Current Work in Process:
>
> Generate Unit tests to Create, Read, Update and Delete for both redundant
> and non redundant
> networks using a single System Vritual Machine image VM based on changes to
> script files
> below.
>
> Generate Unit test to verify VPCVirtualNetworkApplianceManagerImpl.java
> will work with CRUD
> enabled scripts.
>
> Add the interface and ability to do network CRUD to guestnw.sh and
> cloud-early-config.sh.
>
> Modify VPCVirtualNetworkApplianceManagerImpl to allow changes to guest
> network using
> new CRUD functionality of guesnw.sh mentioned above.
>
> Modify UI and other Java code as required for implantation of VPC redundant
> routers.
>
> Karl
>
>
> On Wed, Jun 11, 2014 at 3:16 PM, Sheng Yang  wrote:
>
>> One note:
>>
>> In fact the split of MASTER is not a big issue, because that would only
>> happen if network runs bad enough, which already cause packet loss.
>>
>> The problem is it should recover from that situation fast enough.
>> Previously due to ARP ping from BACKUP router(which thought it would
>> replace MASTER), upstream switch would redirect the traffic to original
>> BACKUP router for a while, then as soon as network recovered, MASTER would
>> preempt BACKUP once again. But it may take some time for upstream switch to
>> aware that MAC/Port/IP mapping has been changed. We once tried different
>> MAC for MASTER and BACKUP but found it would result in upstream switch fail
>> to recognize the MASTER again. Now we're still using same MAC for MASTER
>> and BACKUP, and upstream switch can handle the situation better.
>>
>> --Sheng
>>
>>
>> On Wed, Jun 11, 2014 at 12:48 AM, Daan Hoogland <
>> dhoogl...@schubergphilis.com> wrote:
>>
>> > H,
>> >
>> > We had a little meeting on the state of this feature and the way to go. I
>> > have no karma for ASFBot meetings so here is my excerpt from the
>> transcript:
>> >
>> > Attendance:
>> > K3KH Karl Harris
>> > Yasker Sheng Yang
>> > Spark404 Hugo Trippaers
>> > echaz Eric Chazas
>> > LeoSimons Leo Simons
>> > dahn Daan Hoogland
>> >
>> > others where present in the room but not active in the meeting
>> >
>> > Agenda:
>> > -  Feasibility experiment plans by Schuberg Philis
>> > -  Reusable work by Karl
>> > -  Problems Citrix encountered with the regular redundant router
>> > (and how to avoid them)
>> > -  Work division
>> > -  (next meeting needed?)
>> >
>> > We tried to follow the agenda but were not very strict on it. I'll
>> > summarize outcome per agenda bullet:
>> >
>> > Schuberg Philis wants to implement a feasibility redundant router on a
>> > simulated vpc environment using the operational expertise it has in
>> house.
>> > The outcome would then be back ported to the device, it's agent and the
>> > management server.
>> >
>> > The implementation tactics is to create a json like configuration
>> > description and to let the device do its own configuration. The idea is
>> to
>> > have a single device for normal and vpc routers and to let the redundancy
>> > be a mere property of it. This should lead to the ultimate objective
>> which
>> > is to have a single relatively simple maintainable device.
>> >
>> > Karl will describe his endeavors in adapting the existing device on list.

Build failed in Jenkins: build-master-noredist #2914

2014-06-16 Thread jenkins
See 

--
Started by upstream project "build-master" build number 968
originally caused by:
 Started by an SCM change
[EnvInject] - Loading node environment variables.
Building remotely on cloudstack-buildslave-centos6-bca 
(cloudstack-buildslave-centos6) in workspace 

Cloning the remote Git repository
Cloning repository https://git-wip-us.apache.org/repos/asf/cloudstack.git
Fetching upstream changes from 
https://git-wip-us.apache.org/repos/asf/cloudstack.git
ERROR: Timeout after 400 minutes
ERROR: Error cloning remote repo 'origin'
hudson.plugins.git.GitException: Command "git fetch --tags --progress 
https://git-wip-us.apache.org/repos/asf/cloudstack.git 
+refs/heads/*:refs/remotes/origin/*" returned status code 128:
stdout: 
stderr: error: RPC failed; result=7, HTTP code = 0
error: fetch-pack died of signal 15

at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1086)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:968)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$200(CliGitAPIImpl.java:71)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:197)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl$2.execute(CliGitAPIImpl.java:329)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:152)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:145)
at hudson.remoting.UserRequest.perform(UserRequest.java:118)
at hudson.remoting.UserRequest.perform(UserRequest.java:48)
at hudson.remoting.Request$2.run(Request.java:328)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
at java.util.concurrent.FutureTask.run(FutureTask.java:166)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1146)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:701)
ERROR: null
Archiving artifacts


Jenkins build is back to normal : build-master-noredist #2915

2014-06-16 Thread jenkins
See 



[API]How to check how many IPs are available in guest network

2014-06-16 Thread ilya musayev
Is there a way to check how many guest IPs are available in specific 
guest network?


Current cloudstack reporting is not granular enough, i could not find a 
command that says listAvailableIPs or something similar.


Any help is appreciated.

Thanks,
ilya


Re: [API]How to check how many IPs are available in guest network

2014-06-16 Thread Wei ZHOU
lisPublicIpAddresses can list all public ips in a shared network, or public
ips used in isolated network.
state=Free means the ip is available.



2014-06-16 21:21 GMT+02:00 ilya musayev :

> Is there a way to check how many guest IPs are available in specific guest
> network?
>
> Current cloudstack reporting is not granular enough, i could not find a
> command that says listAvailableIPs or something similar.
>
> Any help is appreciated.
>
> Thanks,
> ilya
>


Re: [API]How to check how many IPs are available in guest network

2014-06-16 Thread Chiradeep Vittal
used=$(cloudmonkey list virtualmachines
networkid=f5119c7a-a5b8-47aa-bf26-d0f41dfa2d6b | grep ipaddress | wc -l)
space=$(cloudmonkey list networks id=f5119c7a-a5b8-47aa-bf26-d0f41dfa2d6b
| grep cidr | awk -F":" '{print $2}' | awk -F "/" '{print $2}')

space=${space%\",}
let space="32 - $space"
let space=³2**$space - 1²



let avail="$space - $used -1²
echo ³Available IPs = $avail"




From:  ilya musayev 
Reply-To:  "dev@cloudstack.apache.org" 
Date:  Monday, June 16, 2014 at 3:21 PM
To:  "dev@cloudstack.apache.org" 
Subject:  [API]How to check how many IPs are available in guest network


Is there a way to check how many guest IPs are available in specific
guest network?

Current cloudstack reporting is not granular enough, i could not find a
command that says listAvailableIPs or something similar.

Any help is appreciated.

Thanks,
ilya



RE: [ACS44] are we RC-ready?

2014-06-16 Thread Animesh Chaturvedi
84 is  a bug number to call RC ready unless the issues are not really critical

> -Original Message-
> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
> Sent: Monday, June 16, 2014 7:11 AM
> To: dev
> Subject: [ACS44] are we RC-ready?
> 
> s far as I can tell the only remaining blocker issue has been fixed last week.
> There are 84 criticals. Do we feel we are RC ready as we are or are some of
> those critical to critical to go and release? If so, what needs to be done to
> get there. Please respond promptly or show yourself on #cloudstack-
> meeting in 50 minutes.
> 
> with kind regards and loads of gratitude,
> --
> Daan


[ACS44] Cherry pick request

2014-06-16 Thread Amogh Vasekar
Hi Daan,

Can you please cherry-pick de04881da177b28d7cb3efc09adb2d8069f0fdd3 from
4.4-forward to 4.4?

This fixes CLOUDSTACK-6915

Thanks,
Amogh



Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-06-16 Thread Alena Prokharchyk

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20099/#review45853
---


Alex,

* add "since=version" attribute to all new parameters you've added to the 
existing API calls
* remove listSyncAccounts/ listSyncUsers/listSyncDomains/listSyncDomainChildren
* The important one - while on the call with Alex Huang, and later in all the 
countless emails, we've agreed not to modify the event itself, in order not to 
overload it with the details just specific to your plugin or the region. Now I 
see this in ActionEventUtils:

eventDescription.put("oldentityname", oldEntityName);
eventDescription.put("originatedregionuuid", originatedRegionUuid);

You said the parameter would be saved and read to/from CallContext only? 
Without touching anything else in the CS code like account/domain/user/event 
objects. Please remove it from the event. Or come up with a different solution 
that doesn't touch the event.

- Alena Prokharchyk


On June 15, 2014, 9:40 p.m., Alex Ough wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20099/
> ---
> 
> (Updated June 15, 2014, 9:40 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> This is the review request for the core changes related with #17790 that has 
> only the new plugin codes.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/event/EventTypes.java 39ef710 
>   api/src/com/cloud/user/AccountService.java 7e37b38 
>   api/src/com/cloud/user/DomainService.java 4c1f93d 
>   api/src/org/apache/cloudstack/api/ApiConstants.java fdb4558 
>   api/src/org/apache/cloudstack/api/BaseCmd.java f6f21ae 
>   
> api/src/org/apache/cloudstack/api/command/admin/account/CreateAccountCmd.java 
> 50d67d9 
>   
> api/src/org/apache/cloudstack/api/command/admin/account/DeleteAccountCmd.java 
> 5754ec5 
>   
> api/src/org/apache/cloudstack/api/command/admin/account/DisableAccountCmd.java
>  3e5e1d3 
>   
> api/src/org/apache/cloudstack/api/command/admin/account/EnableAccountCmd.java 
> f30c985 
>   api/src/org/apache/cloudstack/api/command/admin/account/LockAccountCmd.java 
> 3c185e4 
>   
> api/src/org/apache/cloudstack/api/command/admin/account/UpdateAccountCmd.java 
> a7ce74a 
>   api/src/org/apache/cloudstack/api/command/admin/domain/CreateDomainCmd.java 
> 312c9ee 
>   api/src/org/apache/cloudstack/api/command/admin/domain/DeleteDomainCmd.java 
> a6d2b0b 
>   api/src/org/apache/cloudstack/api/command/admin/domain/UpdateDomainCmd.java 
> 409a84d 
>   api/src/org/apache/cloudstack/api/command/admin/region/AddRegionCmd.java 
> f6743ba 
>   api/src/org/apache/cloudstack/api/command/admin/region/UpdateRegionCmd.java 
> b08cbbb 
>   api/src/org/apache/cloudstack/api/command/admin/user/CreateUserCmd.java 
> 51e218d 
>   api/src/org/apache/cloudstack/api/command/admin/user/DeleteUserCmd.java 
> 08ba521 
>   api/src/org/apache/cloudstack/api/command/admin/user/DisableUserCmd.java 
> c6e09ef 
>   api/src/org/apache/cloudstack/api/command/admin/user/EnableUserCmd.java 
> d69eccf 
>   api/src/org/apache/cloudstack/api/command/admin/user/LockUserCmd.java 
> 69623d0 
>   api/src/org/apache/cloudstack/api/command/admin/user/RegisterCmd.java 
> 2090d21 
>   api/src/org/apache/cloudstack/api/command/admin/user/UpdateUserCmd.java 
> cf5d355 
>   api/src/org/apache/cloudstack/api/response/RegionResponse.java 6c74fa6 
>   api/src/org/apache/cloudstack/region/Region.java df64e44 
>   api/src/org/apache/cloudstack/region/RegionService.java afefcc7 
>   api/test/org/apache/cloudstack/api/command/test/RegionCmdTest.java 10c3d85 
>   client/pom.xml d8dbde7 
>   client/tomcatconf/commands.properties.in 45debe4 
>   
> engine/schema/resources/META-INF/cloudstack/core/spring-engine-schema-core-daos-context.xml
>  489b37d 
>   engine/schema/src/com/cloud/user/AccountVO.java 0f5a044 
>   engine/schema/src/org/apache/cloudstack/region/RegionVO.java 608bd2b 
>   
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/MockAccountManager.java
>  957f708 
>   plugins/pom.xml 9b391b8 
>   
> plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapCreateAccountCmd.java
>  626bb8f 
>   
> plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapImportUsersCmd.java
>  887ad00 
>   
> server/resources/META-INF/cloudstack/core/spring-server-core-managers-context.xml
>  fc1c7e2 
>   server/src/com/cloud/api/ApiResponseHelper.java 38f2f0b 
>   server/src/com/cloud/api/dispatch/ParamProcessWorker.java e9bdd8b 
>   server/src/com/cloud/event/ActionEventUtils.java 28e5680 
>   server/src/com/cloud/projects/ProjectManagerImpl.java d10c059 
>   server/src/com/cloud/user/AccountManag

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-06-16 Thread Alex Ough
On Mon, Jun 16, 2014 at 7:07 PM, Alena Prokharchyk <
alena.prokharc...@citrix.com> wrote:

>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20099/#review45853
> ---
>
>
> Alex,
>
> * add "since=version" attribute to all new parameters you've added to the
> existing API calls
> * remove listSyncAccounts/
> listSyncUsers/listSyncDomains/listSyncDomainChildren
>
 WHY??


> * The important one - while on the call with Alex Huang, and later in all
> the countless emails, we've agreed not to modify the event itself, in order
> not to overload it with the details just specific to your plugin or the
> region. Now I see this in ActionEventUtils:
>
> eventDescription.put("oldentityname", oldEntityName);
> eventDescription.put("originatedregionuuid", originatedRegionUuid);
>
 WHY???

>
> You said the parameter would be saved and read to/from CallContext only?
> Without touching anything else in the CS code like
> account/domain/user/event objects. Please remove it from the event. Or come
> up with a different solution that doesn't touch the event.
>
 WHAT DO YOU MEAN??

>
> - Alena Prokharchyk
>
>
> On June 15, 2014, 9:40 p.m., Alex Ough wrote:
> >
> > ---
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/20099/
> > ---
> >
> > (Updated June 15, 2014, 9:40 p.m.)
> >
> >
> > Review request for cloudstack.
> >
> >
> > Repository: cloudstack-git
> >
> >
> > Description
> > ---
> >
> > This is the review request for the core changes related with #17790 that
> has only the new plugin codes.
> >
> >
> > Diffs
> > -
> >
> >   api/src/com/cloud/event/EventTypes.java 39ef710
> >   api/src/com/cloud/user/AccountService.java 7e37b38
> >   api/src/com/cloud/user/DomainService.java 4c1f93d
> >   api/src/org/apache/cloudstack/api/ApiConstants.java fdb4558
> >   api/src/org/apache/cloudstack/api/BaseCmd.java f6f21ae
> >
> api/src/org/apache/cloudstack/api/command/admin/account/CreateAccountCmd.java
> 50d67d9
> >
> api/src/org/apache/cloudstack/api/command/admin/account/DeleteAccountCmd.java
> 5754ec5
> >
> api/src/org/apache/cloudstack/api/command/admin/account/DisableAccountCmd.java
> 3e5e1d3
> >
> api/src/org/apache/cloudstack/api/command/admin/account/EnableAccountCmd.java
> f30c985
> >
> api/src/org/apache/cloudstack/api/command/admin/account/LockAccountCmd.java
> 3c185e4
> >
> api/src/org/apache/cloudstack/api/command/admin/account/UpdateAccountCmd.java
> a7ce74a
> >
> api/src/org/apache/cloudstack/api/command/admin/domain/CreateDomainCmd.java
> 312c9ee
> >
> api/src/org/apache/cloudstack/api/command/admin/domain/DeleteDomainCmd.java
> a6d2b0b
> >
> api/src/org/apache/cloudstack/api/command/admin/domain/UpdateDomainCmd.java
> 409a84d
> >
> api/src/org/apache/cloudstack/api/command/admin/region/AddRegionCmd.java
> f6743ba
> >
> api/src/org/apache/cloudstack/api/command/admin/region/UpdateRegionCmd.java
> b08cbbb
> >
> api/src/org/apache/cloudstack/api/command/admin/user/CreateUserCmd.java
> 51e218d
> >
> api/src/org/apache/cloudstack/api/command/admin/user/DeleteUserCmd.java
> 08ba521
> >
> api/src/org/apache/cloudstack/api/command/admin/user/DisableUserCmd.java
> c6e09ef
> >
> api/src/org/apache/cloudstack/api/command/admin/user/EnableUserCmd.java
> d69eccf
> >   api/src/org/apache/cloudstack/api/command/admin/user/LockUserCmd.java
> 69623d0
> >   api/src/org/apache/cloudstack/api/command/admin/user/RegisterCmd.java
> 2090d21
> >
> api/src/org/apache/cloudstack/api/command/admin/user/UpdateUserCmd.java
> cf5d355
> >   api/src/org/apache/cloudstack/api/response/RegionResponse.java 6c74fa6
> >   api/src/org/apache/cloudstack/region/Region.java df64e44
> >   api/src/org/apache/cloudstack/region/RegionService.java afefcc7
> >   api/test/org/apache/cloudstack/api/command/test/RegionCmdTest.java
> 10c3d85
> >   client/pom.xml d8dbde7
> >   client/tomcatconf/commands.properties.in 45debe4
> >
> engine/schema/resources/META-INF/cloudstack/core/spring-engine-schema-core-daos-context.xml
> 489b37d
> >   engine/schema/src/com/cloud/user/AccountVO.java 0f5a044
> >   engine/schema/src/org/apache/cloudstack/region/RegionVO.java 608bd2b
> >
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/MockAccountManager.java
> 957f708
> >   plugins/pom.xml 9b391b8
> >
> plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapCreateAccountCmd.java
> 626bb8f
> >
> plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapImportUsersCmd.java
> 887ad00
> >
> server/resources/META-INF/cloudstack/core/spring-server-core-managers-context.xml
> fc1c7e2
> >   server/src/com/cloud/api/ApiResponseHelper.java 38f2f0b
> >   server/src

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-06-16 Thread Alena Prokharchyk


On 6/16/14, 4:13 PM, "Alex Ough"  wrote:

>On Mon, Jun 16, 2014 at 7:07 PM, Alena Prokharchyk <
>alena.prokharc...@citrix.com> wrote:
>
>>
>> ---
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/20099/#review45853
>> ---
>>
>>
>> Alex,
>>
>> * add "since=version" attribute to all new parameters you've added to
>>the
>> existing API calls
>> * remove listSyncAccounts/
>> listSyncUsers/listSyncDomains/listSyncDomainChildren
>>
> WHY??


Because when the API commands come as a part of your plugin, they don¹t
have to be registered in the commands.properties file. This file defines
the permissions only, and you can define the permissions in your commands
itself. Use ³authorized² parameter in the @ApiCommand annotation. Example:


authorized = {RoleType.Admin}


If the command is available to Root admin only (equivalent to =1 in
commands.properties)

>
>
>> * The important one - while on the call with Alex Huang, and later in
>>all
>> the countless emails, we've agreed not to modify the event itself, in
>>order
>> not to overload it with the details just specific to your plugin or the
>> region. Now I see this in ActionEventUtils:
>>
>> eventDescription.put("oldentityname", oldEntityName);
>> eventDescription.put("originatedregionuuid", originatedRegionUuid);
>>
> WHY???


Alex, because in a numerous number of email threads below we¹ve agreed on
the fact that the event object itself won¹t be overloaded and we will keep
it simple. If every plugin overloads the event with the details only
related to this plugin, there will be a mess. We¹ve discussed the way when
your plugin modifies account/domain/user objects instead, and then reads
from them. Then you said it wouldn¹t work and you would read from the
CallContext (memory). You want me to pull out this thread? There was no
notion about modifying/overloading the event object in the DB itself. If
you can find it and put it here, I would appreciate that.


>
>>
>> You said the parameter would be saved and read to/from CallContext only?
>> Without touching anything else in the CS code like
>> account/domain/user/event objects. Please remove it from the event. Or
>>come
>> up with a different solution that doesn't touch the event.
>>
> WHAT DO YOU MEAN??

>
>>
>> - Alena Prokharchyk
>>
>>
>> On June 15, 2014, 9:40 p.m., Alex Ough wrote:
>> >
>> > ---
>> > This is an automatically generated e-mail. To reply, visit:
>> > https://reviews.apache.org/r/20099/
>> > ---
>> >
>> > (Updated June 15, 2014, 9:40 p.m.)
>> >
>> >
>> > Review request for cloudstack.
>> >
>> >
>> > Repository: cloudstack-git
>> >
>> >
>> > Description
>> > ---
>> >
>> > This is the review request for the core changes related with #17790
>>that
>> has only the new plugin codes.
>> >
>> >
>> > Diffs
>> > -
>> >
>> >   api/src/com/cloud/event/EventTypes.java 39ef710
>> >   api/src/com/cloud/user/AccountService.java 7e37b38
>> >   api/src/com/cloud/user/DomainService.java 4c1f93d
>> >   api/src/org/apache/cloudstack/api/ApiConstants.java fdb4558
>> >   api/src/org/apache/cloudstack/api/BaseCmd.java f6f21ae
>> >
>> 
>>api/src/org/apache/cloudstack/api/command/admin/account/CreateAccountCmd.
>>java
>> 50d67d9
>> >
>> 
>>api/src/org/apache/cloudstack/api/command/admin/account/DeleteAccountCmd.
>>java
>> 5754ec5
>> >
>> 
>>api/src/org/apache/cloudstack/api/command/admin/account/DisableAccountCmd
>>.java
>> 3e5e1d3
>> >
>> 
>>api/src/org/apache/cloudstack/api/command/admin/account/EnableAccountCmd.
>>java
>> f30c985
>> >
>> 
>>api/src/org/apache/cloudstack/api/command/admin/account/LockAccountCmd.ja
>>va
>> 3c185e4
>> >
>> 
>>api/src/org/apache/cloudstack/api/command/admin/account/UpdateAccountCmd.
>>java
>> a7ce74a
>> >
>> 
>>api/src/org/apache/cloudstack/api/command/admin/domain/CreateDomainCmd.ja
>>va
>> 312c9ee
>> >
>> 
>>api/src/org/apache/cloudstack/api/command/admin/domain/DeleteDomainCmd.ja
>>va
>> a6d2b0b
>> >
>> 
>>api/src/org/apache/cloudstack/api/command/admin/domain/UpdateDomainCmd.ja
>>va
>> 409a84d
>> >
>> api/src/org/apache/cloudstack/api/command/admin/region/AddRegionCmd.java
>> f6743ba
>> >
>> 
>>api/src/org/apache/cloudstack/api/command/admin/region/UpdateRegionCmd.ja
>>va
>> b08cbbb
>> >
>> api/src/org/apache/cloudstack/api/command/admin/user/CreateUserCmd.java
>> 51e218d
>> >
>> api/src/org/apache/cloudstack/api/command/admin/user/DeleteUserCmd.java
>> 08ba521
>> >
>> api/src/org/apache/cloudstack/api/command/admin/user/DisableUserCmd.java
>> c6e09ef
>> >
>> api/src/org/apache/cloudstack/api/command/admin/user/EnableUserCmd.java
>> d69eccf
>> >   
>>api/src/org/apache/cloudstack/api/command/admin/user/LockUserCmd.java
>> 69623d0
>> >   
>>api/src/org/apache/cloudstack/api/command/admin/user

Re: #cloudstack-meeting

2014-06-16 Thread ilya musayev

Hi Guys,

Sorry i could not attend as i'm having busy day @ $dayjob.

Are we planning on making these meetings regular occurrence? if so, i 
can block out some time in my calendar.


Thanks,
ilya
On 6/16/14, 8:09 AM, Daan Hoogland wrote:

I can't connect to irc.freenode.net

anybody else got problems with it?





Re: #cloudstack-meeting

2014-06-16 Thread Mike Tutkowski
It sounds like there will be at least one more next Monday at the same time.


On Mon, Jun 16, 2014 at 9:43 PM, ilya musayev 
wrote:

> Hi Guys,
>
> Sorry i could not attend as i'm having busy day @ $dayjob.
>
> Are we planning on making these meetings regular occurrence? if so, i can
> block out some time in my calendar.
>
> Thanks,
> ilya
> On 6/16/14, 8:09 AM, Daan Hoogland wrote:
>
>> I can't connect to irc.freenode.net
>>
>> anybody else got problems with it?
>>
>>
>


-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
*™*


Review Request 22672: CLOUDSTACK-6914: Fixed the mentioned issue for vgpu cases along with tagging

2014-06-16 Thread Santhosh Edukulla

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22672/
---

Review request for cloudstack and Abhinandan Prateek.


Bugs: CLOUDSTACK-6914
https://issues.apache.org/jira/browse/CLOUDSTACK-6914


Repository: cloudstack-git


Description
---

Fixed the vgpu case hypervisor check, and added missing tags to master.


Diffs
-

  test/integration/smoke/test_affinity_groups.py bb0a524 
  test/integration/smoke/test_deploy_vgpu_enabled_vm.py 13fad61 
  test/integration/smoke/test_deploy_vm.py 87e0011 
  test/integration/smoke/test_deploy_vm_root_resize.py 8097d08 
  test/integration/smoke/test_deploy_vm_with_userdata.py 7616b82 
  test/integration/smoke/test_deploy_vms_with_varied_deploymentplanners.py 
420925e 
  test/integration/smoke/test_disk_offerings.py 780c154 
  test/integration/smoke/test_global_settings.py ace2db3 
  test/integration/smoke/test_guest_vlan_range.py f5bcdf4 
  test/integration/smoke/test_internal_lb.py d6f3477 
  test/integration/smoke/test_iso.py 6741633 
  test/integration/smoke/test_loadbalance.py daa5fee 
  test/integration/smoke/test_multipleips_per_nic.py ad3a3cf 
  test/integration/smoke/test_network.py 52efc32 
  test/integration/smoke/test_network_acl.py 68e5067 
  test/integration/smoke/test_nic.py 592a839 
  test/integration/smoke/test_non_contigiousvlan.py 50b48d0 
  test/integration/smoke/test_over_provisioning.py 1c5d8a5 
  test/integration/smoke/test_portable_publicip.py 2d02a71 
  test/integration/smoke/test_primary_storage.py 3147d86 
  test/integration/smoke/test_privategw_acl.py c86beb1 
  test/integration/smoke/test_public_ip_range.py b961dc3 
  test/integration/smoke/test_pvlan.py 7d1aa5d 
  test/integration/smoke/test_regions.py 389f878 
  test/integration/smoke/test_reset_vm_on_reboot.py 4709df4 
  test/integration/smoke/test_resource_detail.py 7f4a6e7 
  test/integration/smoke/test_routers.py 2aa83c3 
  test/integration/smoke/test_scale_vm.py f0ec534 
  test/integration/smoke/test_secondary_storage.py 90304b3 
  test/integration/smoke/test_service_offerings.py 980e110 
  test/integration/smoke/test_snapshots.py a960e70 
  test/integration/smoke/test_ssvm.py ffa620b 
  test/integration/smoke/test_templates.py c7594bb 
  test/integration/smoke/test_vm_ha.py 4063946 
  test/integration/smoke/test_vm_life_cycle.py 104b86c 
  test/integration/smoke/test_vm_snapshots.py e884d42 
  test/integration/smoke/test_volumes.py c6ea09d 
  test/integration/smoke/test_vpc_vpn.py 03826e9 
  tools/marvin/marvin/config/test_data.py cfc4556 

Diff: https://reviews.apache.org/r/22672/diff/


Testing
---


Thanks,

Santhosh Edukulla



Re: [API]How to check how many IPs are available in guest network

2014-06-16 Thread ilya musayev

Thanks Chiradeep and Wei

Unfortunately neither gave me what i needed, so i wrote this SQL script:

SELECT b.name, count(*) FreeIPCount
FROM cloud.user_ip_address a, cloud.networks b
WHERE b.id=a.source_network_id
AND a.state = "Free"
and b.name is not null
group by b.name;

Chiradeep, for some reason list virtualmachines calls in cloudmonkey 
does not always work, especially if you have a very large environment 
with several thousand VMs. I'd think it has something to do with how 
cloudmonkey buffers the output, but i dont know enough about its inner 
working.


On 6/16/14, 12:56 PM, Chiradeep Vittal wrote:

used=$(cloudmonkey list virtualmachines
networkid=f5119c7a-a5b8-47aa-bf26-d0f41dfa2d6b | grep ipaddress | wc -l)
space=$(cloudmonkey list networks id=f5119c7a-a5b8-47aa-bf26-d0f41dfa2d6b
| grep cidr | awk -F":" '{print $2}' | awk -F "/" '{print $2}')

space=${space%\",}
let space="32 - $space"
let space=³2**$space - 1²



let avail="$space - $used -1²
echo ³Available IPs = $avail"




From:  ilya musayev 
Reply-To:  "dev@cloudstack.apache.org" 
Date:  Monday, June 16, 2014 at 3:21 PM
To:  "dev@cloudstack.apache.org" 
Subject:  [API]How to check how many IPs are available in guest network


Is there a way to check how many guest IPs are available in specific
guest network?

Current cloudstack reporting is not granular enough, i could not find a
command that says listAvailableIPs or something similar.

Any help is appreciated.

Thanks,
ilya





Re: [API]How to check how many IPs are available in guest network

2014-06-16 Thread Chiradeep Vittal
Can you explain "does not work"

--
Chiradeep

> On Jun 16, 2014, at 10:02 PM, "ilya musayev"  
> wrote:
> 
> Thanks Chiradeep and Wei
> 
> Unfortunately neither gave me what i needed, so i wrote this SQL script:
> 
> SELECT b.name, count(*) FreeIPCount
> FROM cloud.user_ip_address a, cloud.networks b
> WHERE b.id=a.source_network_id
> AND a.state = "Free"
> and b.name is not null
> group by b.name;
> 
> Chiradeep, for some reason list virtualmachines calls in cloudmonkey does not 
> always work, especially if you have a very large environment with several 
> thousand VMs. I'd think it has something to do with how cloudmonkey buffers 
> the output, but i dont know enough about its inner working.
> 
>> On 6/16/14, 12:56 PM, Chiradeep Vittal wrote:
>> used=$(cloudmonkey list virtualmachines
>> networkid=f5119c7a-a5b8-47aa-bf26-d0f41dfa2d6b | grep ipaddress | wc -l)
>> space=$(cloudmonkey list networks id=f5119c7a-a5b8-47aa-bf26-d0f41dfa2d6b
>> | grep cidr | awk -F":" '{print $2}' | awk -F "/" '{print $2}')
>> 
>> space=${space%\",}
>> let space="32 - $space"
>> let space=³2**$space - 1²
>> 
>> 
>> 
>> let avail="$space - $used -1²
>> echo ³Available IPs = $avail"
>> 
>> 
>> 
>> 
>> From:  ilya musayev 
>> Reply-To:  "dev@cloudstack.apache.org" 
>> Date:  Monday, June 16, 2014 at 3:21 PM
>> To:  "dev@cloudstack.apache.org" 
>> Subject:  [API]How to check how many IPs are available in guest network
>> 
>> 
>> Is there a way to check how many guest IPs are available in specific
>> guest network?
>> 
>> Current cloudstack reporting is not granular enough, i could not find a
>> command that says listAvailableIPs or something similar.
>> 
>> Any help is appreciated.
>> 
>> Thanks,
>> ilya
> 


Re: Review Request 22554: CLOUDSTACK-6909 - fix marvin's handling of SMB credentials for storage

2014-06-16 Thread Santhosh Edukulla

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22554/#review45910
---



tools/marvin/marvin/deployDataCenter.py


Why specifically this?


- Santhosh Edukulla


On June 13, 2014, 4:53 p.m., John Dilley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22554/
> ---
> 
> (Updated June 13, 2014, 4:53 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Bugs: CLOUDSTACK-6909
> https://issues.apache.org/jira/browse/CLOUDSTACK-6909
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fix marvin's handling of details field for primary and secondary storage to 
> cope with SMB credentials. This allows Hyper-V to work.
> 
> 
> Diffs
> -
> 
>   tools/marvin/marvin/deployDataCenter.py 22b78ab 
> 
> Diff: https://reviews.apache.org/r/22554/diff/
> 
> 
> Testing
> ---
> 
> Tested deploydataCenter with this JSON:
> 
> {
>"dbSvr":{
>   "dbSvr":"10.220.137.39",
>   "passwd":"cloud",
>   "db":"cloud",
>   "port":3306,
>   "user":"cloud"
>},
>"zones":[
>   {
>  "name":"XenRT-Zone-0",
>  "guestcidraddress":"192.168.200.0/24",
>  "dns1":"10.220.160.11",
>  "physical_networks":[
> {
>"XRT_VLANRangeSize":10,
>"name":"AdvPhyNetwork",
>"providers":[
>   {
>  "broadcastdomainrange":"ZONE",
>  "name":"VirtualRouter"
>   },
>   {
>  "broadcastdomainrange":"ZONE",
>  "name":"VpcVirtualRouter"
>   },
>   {
>  "broadcastdomainrange":"ZONE",
>  "name":"InternalLbVm"
>   }
>],
>"broadcastdomainrange":"Zone",
>"vlan":"3000-3009",
>"traffictypes":[
>   {
>  "typ":"Guest"
>   },
>   {
>  "typ":"Management"
>   },
>   {
>  "typ":"Public"
>   }
>],
>"isolationmethods":[
>   "VLAN"
>]
> }
>  ],
>  "ipranges":[
> {
>"startip":"10.220.164.0",
>"endip":"10.220.164.9",
>"netmask":"255.255.240.0",
>"XRT_GuestIPRangeSize":10,
>"gateway":"10.220.160.1"
> }
>  ],
>  "networktype":"Advanced",
>  "pods":[
> {
>"XRT_PodIPRangeSize":10,
>"name":"XenRT-Zone-0-Pod-0",
>"endip":"10.220.164.39",
>"startip":"10.220.164.30",
>"netmask":"255.255.240.0",
>"clusters":[
>   {
>  "XRT_HyperVHostIds":"0",
>  "clustername":"XenRT-Zone-0-Pod-0-Cluster-0",
>  "hypervisor":"hyperv",
>  "primaryStorages":[
> {
>"url":"cifs://10.220.163.45/storage/primary",
>"name":"XenRT-Zone-0-Pod-0-Primary-Store",
>"details":[
>   {
>  "user":"Administrator"
>   },
>   {
>  "password":"xenroot01T"
>   },
>   {
>  "domain":"XSQA"
>   }
>]
> }
>  ],
>  "clustertype":"CloudManaged",
>  "hosts":[
> {
>"url":"http://10.220.163.45";,
>"username":"root",
>"password":"xenroot"
> }
>  ],
>  "XRT_Hosts":1
>   }
>],
>"gateway":"10.220.160.1"
> }
>  ],
>  "internaldns1":"10.220.160.11",
>  "secondaryStorages":[
> {
>"url":"cifs://10.220.163.45/storage/secondary",
>"details":{
>   "domain":"XSQA",
>   "password":"xenroot01T",
>   "user":"Administrator"
>},
>"provider":"SMB"
>  

Re: [API]How to check how many IPs are available in guest network

2014-06-16 Thread ilya musayev

It returns nothing, just a blank like.

I will be upgrading our CloudStack instances this week to see if the 
issue still persists with 4.3.0, but i dont believe it will change my 
result.


On 6/16/14, 10:14 PM, Chiradeep Vittal wrote:

Can you explain "does not work"

--
Chiradeep


On Jun 16, 2014, at 10:02 PM, "ilya musayev"  
wrote:

Thanks Chiradeep and Wei

Unfortunately neither gave me what i needed, so i wrote this SQL script:

SELECT b.name, count(*) FreeIPCount
FROM cloud.user_ip_address a, cloud.networks b
WHERE b.id=a.source_network_id
AND a.state = "Free"
and b.name is not null
group by b.name;

Chiradeep, for some reason list virtualmachines calls in cloudmonkey does not 
always work, especially if you have a very large environment with several 
thousand VMs. I'd think it has something to do with how cloudmonkey buffers the 
output, but i dont know enough about its inner working.


On 6/16/14, 12:56 PM, Chiradeep Vittal wrote:
used=$(cloudmonkey list virtualmachines
networkid=f5119c7a-a5b8-47aa-bf26-d0f41dfa2d6b | grep ipaddress | wc -l)
space=$(cloudmonkey list networks id=f5119c7a-a5b8-47aa-bf26-d0f41dfa2d6b
| grep cidr | awk -F":" '{print $2}' | awk -F "/" '{print $2}')

space=${space%\",}
let space="32 - $space"
let space=³2**$space - 1²



let avail="$space - $used -1²
echo ³Available IPs = $avail"




From:  ilya musayev 
Reply-To:  "dev@cloudstack.apache.org" 
Date:  Monday, June 16, 2014 at 3:21 PM
To:  "dev@cloudstack.apache.org" 
Subject:  [API]How to check how many IPs are available in guest network


Is there a way to check how many guest IPs are available in specific
guest network?

Current cloudstack reporting is not granular enough, i could not find a
command that says listAvailableIPs or something similar.

Any help is appreciated.

Thanks,
ilya




Re: [API]How to check how many IPs are available in guest network

2014-06-16 Thread Wei ZHOU
try adding listall=true to cloudmonkey command?


2014-06-17 7:44 GMT+02:00 ilya musayev :

> It returns nothing, just a blank like.
>
> I will be upgrading our CloudStack instances this week to see if the issue
> still persists with 4.3.0, but i dont believe it will change my result.
>
>
> On 6/16/14, 10:14 PM, Chiradeep Vittal wrote:
>
>> Can you explain "does not work"
>>
>> --
>> Chiradeep
>>
>>  On Jun 16, 2014, at 10:02 PM, "ilya musayev" <
>>> ilya.mailing.li...@gmail.com> wrote:
>>>
>>> Thanks Chiradeep and Wei
>>>
>>> Unfortunately neither gave me what i needed, so i wrote this SQL script:
>>>
>>> SELECT b.name, count(*) FreeIPCount
>>> FROM cloud.user_ip_address a, cloud.networks b
>>> WHERE b.id=a.source_network_id
>>> AND a.state = "Free"
>>> and b.name is not null
>>> group by b.name;
>>>
>>> Chiradeep, for some reason list virtualmachines calls in cloudmonkey
>>> does not always work, especially if you have a very large environment with
>>> several thousand VMs. I'd think it has something to do with how cloudmonkey
>>> buffers the output, but i dont know enough about its inner working.
>>>
>>>  On 6/16/14, 12:56 PM, Chiradeep Vittal wrote:
 used=$(cloudmonkey list virtualmachines
 networkid=f5119c7a-a5b8-47aa-bf26-d0f41dfa2d6b | grep ipaddress | wc
 -l)
 space=$(cloudmonkey list networks id=f5119c7a-a5b8-47aa-bf26-
 d0f41dfa2d6b
 | grep cidr | awk -F":" '{print $2}' | awk -F "/" '{print $2}')

 space=${space%\",}
 let space="32 - $space"
 let space=ł2**$space - 1˛




 let avail="$space - $used -1˛
 echo łAvailable IPs = $avail"




 From:  ilya musayev 
 Reply-To:  "dev@cloudstack.apache.org" 
 Date:  Monday, June 16, 2014 at 3:21 PM
 To:  "dev@cloudstack.apache.org" 
 Subject:  [API]How to check how many IPs are available in guest network


 Is there a way to check how many guest IPs are available in specific
 guest network?

 Current cloudstack reporting is not granular enough, i could not find a
 command that says listAvailableIPs or something similar.

 Any help is appreciated.

 Thanks,
 ilya

>>>
>


Re: [ACS44] are we RC-ready?

2014-06-16 Thread Daan Hoogland
I know some of them are not, but a lot may be. We all need to have a
look at that. I will, but the total number is over 350! (including
those not marked as critical.)

On Mon, Jun 16, 2014 at 10:02 PM, Animesh Chaturvedi
 wrote:
> 84 is  a bug number to call RC ready unless the issues are not really critical
>
>> -Original Message-
>> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
>> Sent: Monday, June 16, 2014 7:11 AM
>> To: dev
>> Subject: [ACS44] are we RC-ready?
>>
>> s far as I can tell the only remaining blocker issue has been fixed last 
>> week.
>> There are 84 criticals. Do we feel we are RC ready as we are or are some of
>> those critical to critical to go and release? If so, what needs to be done to
>> get there. Please respond promptly or show yourself on #cloudstack-
>> meeting in 50 minutes.
>>
>> with kind regards and loads of gratitude,
>> --
>> Daan



-- 
Daan


Re: [ACS44] Cherry pick request

2014-06-16 Thread Daan Hoogland
On Mon, Jun 16, 2014 at 11:31 PM, Amogh Vasekar
 wrote:
> de04881da177b28d7cb3efc09adb2d8069f0fdd3


is in

-- 
Daan


Re: #cloudstack-meeting

2014-06-16 Thread Daan Hoogland
Ilja, Mike, Yes at least one I am afraid. I hope we can have as little
as possible but I will keep calling them untill we have a 4.4 out.

On Tue, Jun 17, 2014 at 6:00 AM, Mike Tutkowski
 wrote:
> It sounds like there will be at least one more next Monday at the same time.
>
>
> On Mon, Jun 16, 2014 at 9:43 PM, ilya musayev 
> wrote:
>
>> Hi Guys,
>>
>> Sorry i could not attend as i'm having busy day @ $dayjob.
>>
>> Are we planning on making these meetings regular occurrence? if so, i can
>> block out some time in my calendar.
>>
>> Thanks,
>> ilya
>> On 6/16/14, 8:09 AM, Daan Hoogland wrote:
>>
>>> I can't connect to irc.freenode.net
>>>
>>> anybody else got problems with it?
>>>
>>>
>>
>
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the cloud
> *™*



-- 
Daan


Re: Review Request 22510: [Windows] Can not create Template from ROOT snapshot. Fixed the same by adding pathSeparator to the DataStoreTO.java

2014-06-16 Thread Damodar Reddy Talakanti

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22510/
---

(Updated June 17, 2014, 6:34 a.m.)


Review request for cloudstack, edison su, Koushik Das, and Min Chen.


Changes
---

Incorporated review comments from Koushik


Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6636

https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6636


Repository: cloudstack-git


Description
---

Due to File.separator on windows machine the template creation from snapshot is 
failing as it has mis-matched path separator which is windows path 
separator(\). Fixed the same by adding getPathSeparator() method to 
DataStoreTO.java and all it's implementations.


Diffs (updated)
-

  api/src/com/cloud/agent/api/to/DataStoreTO.java 8d47adc 
  api/src/com/cloud/agent/api/to/NfsTO.java 1c9ee38 
  api/src/com/cloud/agent/api/to/S3TO.java f64fe35 
  api/src/com/cloud/agent/api/to/SwiftTO.java 3b76dad 
  core/src/org/apache/cloudstack/storage/to/ImageStoreTO.java 93c62f6 
  core/src/org/apache/cloudstack/storage/to/PrimaryDataStoreTO.java 29e53b0 
  
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XenServerStorageProcessor.java
 9c86fbe 

Diff: https://reviews.apache.org/r/22510/diff/


Testing
---

Tested on Windows 2012 R2 server and on centos. Tested the following use cases.

1. Attach ISO
2. Detach ISO
3. Snapshot creation from root disk
4. Snapshot creation from data disk
5. volume creation from (3)
6. template creation from(3)
7. Launch a VM after registering new template.


Thanks,

Damodar Reddy Talakanti



Re: Review Request 22510: [Windows] Can not create Template from ROOT snapshot. Fixed the same by adding pathSeparator to the DataStoreTO.java

2014-06-16 Thread Damodar Reddy Talakanti


> On June 16, 2014, 6:04 a.m., Koushik Das wrote:
> > plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XenServerStorageProcessor.java,
> >  line 296
> > 
> >
> > Will data.getPath() return a path with proper separator?

Yes what ever we store in the install_path column of *_store_ref tables.


- Damodar Reddy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22510/#review45720
---


On June 17, 2014, 6:34 a.m., Damodar Reddy Talakanti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22510/
> ---
> 
> (Updated June 17, 2014, 6:34 a.m.)
> 
> 
> Review request for cloudstack, edison su, Koushik Das, and Min Chen.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6636
> 
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6636
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Due to File.separator on windows machine the template creation from snapshot 
> is failing as it has mis-matched path separator which is windows path 
> separator(\). Fixed the same by adding getPathSeparator() method to 
> DataStoreTO.java and all it's implementations.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/agent/api/to/DataStoreTO.java 8d47adc 
>   api/src/com/cloud/agent/api/to/NfsTO.java 1c9ee38 
>   api/src/com/cloud/agent/api/to/S3TO.java f64fe35 
>   api/src/com/cloud/agent/api/to/SwiftTO.java 3b76dad 
>   core/src/org/apache/cloudstack/storage/to/ImageStoreTO.java 93c62f6 
>   core/src/org/apache/cloudstack/storage/to/PrimaryDataStoreTO.java 29e53b0 
>   
> plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XenServerStorageProcessor.java
>  9c86fbe 
> 
> Diff: https://reviews.apache.org/r/22510/diff/
> 
> 
> Testing
> ---
> 
> Tested on Windows 2012 R2 server and on centos. Tested the following use 
> cases.
> 
> 1. Attach ISO
> 2. Detach ISO
> 3. Snapshot creation from root disk
> 4. Snapshot creation from data disk
> 5. volume creation from (3)
> 6. template creation from(3)
> 7. Launch a VM after registering new template.
> 
> 
> Thanks,
> 
> Damodar Reddy Talakanti
> 
>



[ACS 4.4] cherry-pick

2014-06-16 Thread Jayapal Reddy Uradi
Hi Daan,

Please cherry pick the following commit to 4.4

commit 2214bd2502a34ee8e671eb6b4efe8cd26e29ac5a
CLOUDSTACK-6922: Updated events for firewall ingress and egress


Thanks,
Jayapal


[EVENT] One week left for CCC Budapest CFP

2014-06-16 Thread sebgoa
Morning Boys and Girls,

There is one week left to submit your papers for CCC Budapest Nov 19-21:
http://events.linuxfoundation.org/events/cloudstack-collaboration-conference-europe/program/cfp

Come share your CloudStack stories,

Cheers,

-Sebastien