Re: Anyone else see these errors in Eclipse?

2014-03-15 Thread Laszlo Hornyak
you are not alone :)


On Sat, Mar 15, 2014 at 7:38 AM, Mike Tutkowski <
mike.tutkow...@solidfire.com> wrote:

> "display cannot be resolved to a variable"
>
> http://i.imgur.com/Jz2swFS.png
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the
> cloud
> *(tm)*
>



-- 

EOF


Re: [Merge] CloudStack IAM branch to master

2014-03-15 Thread Rajani Karuturi
I think preserving the history is important. Especially for the developer to 
understand the history if it and why he did it this way.

branch merges can also be easily reverted if required.
http://git-scm.com/blog/2010/03/02/undoing-merges.html
https://www.kernel.org/pub/software/scm/git/docs/howto/revert-a-faulty-merge.txt


~Rajani



On 14-Mar-2014, at 11:50 pm, Chiradeep Vittal 
mailto:chiradeep.vit...@citrix.com>> wrote:

For a new feature, I’d agree that squashed-merge is better.

From: Marcus 
mailto:shadow...@gmail.com>>
Reply-To: 
"dev@cloudstack.apache.org"
 
mailto:dev@cloudstack.apache.org>>
Date: Friday, March 14, 2014 at 10:05 AM
To: 
"dev@cloudstack.apache.org"
 
mailto:dev@cloudstack.apache.org>>
Subject: Re: [Merge] CloudStack IAM branch to master

Maybe, although to some extent the action of merging I think should be
seen as saying "this is complete". If the history is important, it
could perhaps be kept around in the feature branch until it becomes
irrelevant. Of course it may have minor issues that aren't known, but
I think the ability to preserve master and easily be able to roll back
an entire feature is attractive.

On Fri, Mar 14, 2014 at 12:01 PM, Prachi Damle 
mailto:prachi.da...@citrix.com>>
 wrote:
Just a thought about the squashed merge, if there are multiple developers 
working on a feature branch as in this case, won't it be better to preserve the 
change history?

-Original Message-
From: Min Chen [mailto:min.c...@citrix.com]
Sent: Friday, March 14, 2014 9:35 AM
To: 
dev@cloudstack.apache.org
Subject: Re: [Merge] CloudStack IAM branch to master

Thanks Marcus. I am not aware of this convention, will remember that next time 
when I do the merge.

-min

On 3/13/14 10:30 PM, "Marcus" 
mailto:shadow...@gmail.com>> 
wrote:

Min, in looking at this branch merge, I need to be reminded whether we
are supposed to squash feature branches when they come in, or preserve
history. It's nice to preserve history, but it's a lot easier to undo a
squashed merge.

On Thu, Mar 13, 2014 at 5:56 PM, Min Chen 
mailto:min.c...@citrix.com>> 
wrote:
IAM branch is now merged to master.

Thanks
-min

On 3/13/14 10:13 AM, "Min Chen" 
mailto:min.c...@citrix.com>> 
wrote:

Since we haven't heard of any objections to this merge for 3 days, I
am going to merge it to master today.

Thanks
-min

On 3/11/14 12:23 PM, "Hugo Trippaers" 
mailto:h...@trippaers.nl>> wrote:


On 11 mrt. 2014, at 19:52, Min Chen 
mailto:min.c...@citrix.com>> 
wrote:

Also, have already run FingBugs on our branch and addressed all
new findings introduced by our branch.

Awesome! :-)


Thanks.
-min

On 3/10/14 7:33 PM, "Min Chen" 
mailto:min.c...@citrix.com>> 
wrote:

No new jar dependencies.

-min

Sent from my iPhone

On Mar 10, 2014, at 7:22 PM, "Chiradeep Vittal"
mailto:chiradeep.vit...@citrix.com>>
 wrote:

Any new jar dependencies?

On 3/10/14, 11:34 AM, "Min Chen" 
mailto:min.c...@citrix.com>> 
wrote:

Hi,

Prachi and I would like to merge CloudStack Identity and Access
Management(IAM) plugin services to the master branch.
Development for  this effort has been done by Prachi and me on
ACS rbac branch


(https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shor
tlo
g;
h
=r
ef
s/heads/rbac).
Checklists for the merge:
1. JIRA ticket:
https://issues.apache.org/jira/browse/CLOUDSTACK-5920.
2. Functional Specs:


https://cwiki.apache.org/confluence/display/CLOUDSTACK/CloudStac
k+I
de
n
ti
ty
+and+Access+Management+%28IAM%29+Plugin. We have proposed this
feature
back in Jan, and accommodated all the feedbacks in our
implementation.
3. Unit tests for the feature are available at:
services/iam/server/test
(for iam server) and services/iam/plugin/test (for iam plugin).
4. Marvin integration tests for the feature are available at:
test/integration/smoke/test_vm_iam.py.
5. Branch has been rebased with master branch up to commit
63e3eea7905e22cab9466b28a2ab2a80b586aeed.
6. RAT test has been passed.

Thanks.
-min










RE: [VOTE] Apache CloudStack 4.3.0 (eighth round)

2014-03-15 Thread Nux!

On 15.03.2014 00:42, Edison Su wrote:

From my test, all the rules got applied. If you stop/start vm, will
the first rule get applied?
Let's for QA team's testing.


Hi Edison,

So I've found out when the first rule doesn't get applied.
Test 1:

I started with
- cloudstack-agent freshly restarted
- I created an instance
- I added a rule (ping) in the otherwise untouched default security 
group

Result: I could not ping the instance

Once I added another rule the ping rule also got applied.

Test 2:
- deleted the above instance and cleared the default security group
- created new instance
- added a rule for ping again
Result: I could ping the instance

So this is an issue that happens just after cloudstack-agent was 
started, once the security groups have processed a couple of rules then 
all goes as expected.

I don't know what to make of this..

--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro


Re: [Merge] CloudStack IAM branch to master

2014-03-15 Thread Marcus
Yeah, I've been down that road before and its not always fun.
On Mar 15, 2014 4:49 AM, "Rajani Karuturi" 
wrote:

> I think preserving the history is important. Especially for the developer
> to understand the history if it and why he did it this way.
>
> branch merges can also be easily reverted if required.
> http://git-scm.com/blog/2010/03/02/undoing-merges.html
>
> https://www.kernel.org/pub/software/scm/git/docs/howto/revert-a-faulty-merge.txt
>
>
> ~Rajani
>
>
>
> On 14-Mar-2014, at 11:50 pm, Chiradeep Vittal  > wrote:
>
> For a new feature, I'd agree that squashed-merge is better.
>
> From: Marcus mailto:shadow...@gmail.com> shadow...@gmail.com>>
> Reply-To: "dev@cloudstack.apache.org >"  dev@cloudstack.apache.org>>
> Date: Friday, March 14, 2014 at 10:05 AM
> To: "dev@cloudstack.apache.org dev@cloudstack.apache.org>"  dev@cloudstack.apache.org>>
> Subject: Re: [Merge] CloudStack IAM branch to master
>
> Maybe, although to some extent the action of merging I think should be
> seen as saying "this is complete". If the history is important, it
> could perhaps be kept around in the feature branch until it becomes
> irrelevant. Of course it may have minor issues that aren't known, but
> I think the ability to preserve master and easily be able to roll back
> an entire feature is attractive.
>
> On Fri, Mar 14, 2014 at 12:01 PM, Prachi Damle  > wrote:
> Just a thought about the squashed merge, if there are multiple developers
> working on a feature branch as in this case, won't it be better to preserve
> the change history?
>
> -Original Message-
> From: Min Chen [mailto:min.c...@citrix.com]
> Sent: Friday, March 14, 2014 9:35 AM
> To: dev@cloudstack.apache.org dev@cloudstack.apache.org>
> Subject: Re: [Merge] CloudStack IAM branch to master
>
> Thanks Marcus. I am not aware of this convention, will remember that next
> time when I do the merge.
>
> -min
>
> On 3/13/14 10:30 PM, "Marcus"  shadow...@gmail.com>> wrote:
>
> Min, in looking at this branch merge, I need to be reminded whether we
> are supposed to squash feature branches when they come in, or preserve
> history. It's nice to preserve history, but it's a lot easier to undo a
> squashed merge.
>
> On Thu, Mar 13, 2014 at 5:56 PM, Min Chen  min.c...@citrix.com>> wrote:
> IAM branch is now merged to master.
>
> Thanks
> -min
>
> On 3/13/14 10:13 AM, "Min Chen"  min.c...@citrix.com>> wrote:
>
> Since we haven't heard of any objections to this merge for 3 days, I
> am going to merge it to master today.
>
> Thanks
> -min
>
> On 3/11/14 12:23 PM, "Hugo Trippaers"  h...@trippaers.nl>> wrote:
>
>
> On 11 mrt. 2014, at 19:52, Min Chen  min.c...@citrix.com>> wrote:
>
> Also, have already run FingBugs on our branch and addressed all
> new findings introduced by our branch.
>
> Awesome! :-)
>
>
> Thanks.
> -min
>
> On 3/10/14 7:33 PM, "Min Chen"  min.c...@citrix.com>> wrote:
>
> No new jar dependencies.
>
> -min
>
> Sent from my iPhone
>
> On Mar 10, 2014, at 7:22 PM, "Chiradeep Vittal"
> mailto:chiradeep.vit...@citrix.com> chiradeep.vit...@citrix.com>> wrote:
>
> Any new jar dependencies?
>
> On 3/10/14, 11:34 AM, "Min Chen"  min.c...@citrix.com>> wrote:
>
> Hi,
>
> Prachi and I would like to merge CloudStack Identity and Access
> Management(IAM) plugin services to the master branch.
> Development for  this effort has been done by Prachi and me on
> ACS rbac branch
>
>
> (https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shor
> tlo
> g;
> h
> =r
> ef
> s/heads/rbac).
> Checklists for the merge:
> 1. JIRA ticket:
> https://issues.apache.org/jira/browse/CLOUDSTACK-5920.
> 2. Functional Specs:
>
>
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/CloudStac
> k+I
> de
> n
> ti
> ty
> +and+Access+Management+%28IAM%29+Plugin. We have proposed this
> feature
> back in Jan, and accommodated all the feedbacks in our
> implementation.
> 3. Unit tests for the feature are available at:
> services/iam/server/test
> (for iam server) and services/iam/plugin/test (for iam plugin).
> 4. Marvin integration tests for the feature are available at:
> test/integration/smoke/test_vm_iam.py.
> 5. Branch has been rebased with master branch up to commit
> 63e3eea7905e22cab9466b28a2ab2a80b586aeed.
> 6. RAT test has been passed.
>
> Thanks.
> -min
>
>
>
>
>
>
>
>
>


Re: [Merge] CloudStack IAM branch to master

2014-03-15 Thread Marcus
I should mention that by default the squashed commit wraps the whole
history up into the commit message. Also, my original comment was more of a
question, as I know this topic has already been thoroughly discussed but I
didn't remember what we were supposed to be doing.
On Mar 15, 2014 7:41 AM, "Marcus"  wrote:

> Yeah, I've been down that road before and its not always fun.
> On Mar 15, 2014 4:49 AM, "Rajani Karuturi" 
> wrote:
>
>> I think preserving the history is important. Especially for the developer
>> to understand the history if it and why he did it this way.
>>
>> branch merges can also be easily reverted if required.
>> http://git-scm.com/blog/2010/03/02/undoing-merges.html
>>
>> https://www.kernel.org/pub/software/scm/git/docs/howto/revert-a-faulty-merge.txt
>>
>>
>> ~Rajani
>>
>>
>>
>> On 14-Mar-2014, at 11:50 pm, Chiradeep Vittal <
>> chiradeep.vit...@citrix.com> wrote:
>>
>> For a new feature, I'd agree that squashed-merge is better.
>>
>> From: Marcus mailto:shadow...@gmail.com>> shadow...@gmail.com>>
>> Reply-To: "dev@cloudstack.apache.org> >" > dev@cloudstack.apache.org>>
>> Date: Friday, March 14, 2014 at 10:05 AM
>> To: "dev@cloudstack.apache.org> dev@cloudstack.apache.org>" > dev@cloudstack.apache.org>>
>> Subject: Re: [Merge] CloudStack IAM branch to master
>>
>> Maybe, although to some extent the action of merging I think should be
>> seen as saying "this is complete". If the history is important, it
>> could perhaps be kept around in the feature branch until it becomes
>> irrelevant. Of course it may have minor issues that aren't known, but
>> I think the ability to preserve master and easily be able to roll back
>> an entire feature is attractive.
>>
>> On Fri, Mar 14, 2014 at 12:01 PM, Prachi Damle > > wrote:
>> Just a thought about the squashed merge, if there are multiple developers
>> working on a feature branch as in this case, won't it be better to preserve
>> the change history?
>>
>> -Original Message-
>> From: Min Chen [mailto:min.c...@citrix.com]
>> Sent: Friday, March 14, 2014 9:35 AM
>> To: dev@cloudstack.apache.org> dev@cloudstack.apache.org>
>> Subject: Re: [Merge] CloudStack IAM branch to master
>>
>> Thanks Marcus. I am not aware of this convention, will remember that next
>> time when I do the merge.
>>
>> -min
>>
>> On 3/13/14 10:30 PM, "Marcus" > shadow...@gmail.com>> wrote:
>>
>> Min, in looking at this branch merge, I need to be reminded whether we
>> are supposed to squash feature branches when they come in, or preserve
>> history. It's nice to preserve history, but it's a lot easier to undo a
>> squashed merge.
>>
>> On Thu, Mar 13, 2014 at 5:56 PM, Min Chen > min.c...@citrix.com>> wrote:
>> IAM branch is now merged to master.
>>
>> Thanks
>> -min
>>
>> On 3/13/14 10:13 AM, "Min Chen" > min.c...@citrix.com>> wrote:
>>
>> Since we haven't heard of any objections to this merge for 3 days, I
>> am going to merge it to master today.
>>
>> Thanks
>> -min
>>
>> On 3/11/14 12:23 PM, "Hugo Trippaers" > h...@trippaers.nl>> wrote:
>>
>>
>> On 11 mrt. 2014, at 19:52, Min Chen > min.c...@citrix.com>> wrote:
>>
>> Also, have already run FingBugs on our branch and addressed all
>> new findings introduced by our branch.
>>
>> Awesome! :-)
>>
>>
>> Thanks.
>> -min
>>
>> On 3/10/14 7:33 PM, "Min Chen" > min.c...@citrix.com>> wrote:
>>
>> No new jar dependencies.
>>
>> -min
>>
>> Sent from my iPhone
>>
>> On Mar 10, 2014, at 7:22 PM, "Chiradeep Vittal"
>> mailto:chiradeep.vit...@citrix.com>> chiradeep.vit...@citrix.com>> wrote:
>>
>> Any new jar dependencies?
>>
>> On 3/10/14, 11:34 AM, "Min Chen" > min.c...@citrix.com>> wrote:
>>
>> Hi,
>>
>> Prachi and I would like to merge CloudStack Identity and Access
>> Management(IAM) plugin services to the master branch.
>> Development for  this effort has been done by Prachi and me on
>> ACS rbac branch
>>
>>
>> (https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shor
>> tlo
>> g;
>> h
>> =r
>> ef
>> s/heads/rbac).
>> Checklists for the merge:
>> 1. JIRA ticket:
>> https://issues.apache.org/jira/browse/CLOUDSTACK-5920.
>> 2. Functional Specs:
>>
>>
>> https://cwiki.apache.org/confluence/display/CLOUDSTACK/CloudStac
>> k+I
>> de
>> n
>> ti
>> ty
>> +and+Access+Management+%28IAM%29+Plugin. We have proposed this
>> feature
>> back in Jan, and accommodated all the feedbacks in our
>> implementation.
>> 3. Unit tests for the feature are available at:
>> services/iam/server/test
>> (for iam server) and services/iam/plugin/test (for iam

Re: Anyone else see these errors in Eclipse?

2014-03-15 Thread Daan Hoogland
so, is eclipse wrong?

On Sat, Mar 15, 2014 at 11:02 AM, Laszlo Hornyak
 wrote:
> you are not alone :)
>
>
> On Sat, Mar 15, 2014 at 7:38 AM, Mike Tutkowski <
> mike.tutkow...@solidfire.com> wrote:
>
>> "display cannot be resolved to a variable"
>>
>> http://i.imgur.com/Jz2swFS.png
>>
>> --
>> *Mike Tutkowski*
>> *Senior CloudStack Developer, SolidFire Inc.*
>> e: mike.tutkow...@solidfire.com
>> o: 303.746.7302
>> Advancing the way the world uses the
>> cloud
>> *(tm)*
>>
>
>
>
> --
>
> EOF



-- 
Daan


Re: Anyone else see these errors in Eclipse?

2014-03-15 Thread Laszlo Hornyak
The project is only compiled if both integration-test and vmware profiles
are activated. but for vmware I need some jars that vmware allows to
download only if I work for a partner company - which I don't. Anyone know
another source?


On Sat, Mar 15, 2014 at 7:38 AM, Mike Tutkowski <
mike.tutkow...@solidfire.com> wrote:

> "display cannot be resolved to a variable"
>
> http://i.imgur.com/Jz2swFS.png
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the
> cloud
> *(tm)*
>



-- 

EOF


Re: Anyone else see these errors in Eclipse?

2014-03-15 Thread Laszlo Hornyak
No, it is really broken, 'display' should be replaced with a boolean
expression. I believe it was something left behind after a refactoring.


On Sat, Mar 15, 2014 at 3:17 PM, Daan Hoogland wrote:

> so, is eclipse wrong?
>
> On Sat, Mar 15, 2014 at 11:02 AM, Laszlo Hornyak
>  wrote:
> > you are not alone :)
> >
> >
> > On Sat, Mar 15, 2014 at 7:38 AM, Mike Tutkowski <
> > mike.tutkow...@solidfire.com> wrote:
> >
> >> "display cannot be resolved to a variable"
> >>
> >> http://i.imgur.com/Jz2swFS.png
> >>
> >> --
> >> *Mike Tutkowski*
> >> *Senior CloudStack Developer, SolidFire Inc.*
> >> e: mike.tutkow...@solidfire.com
> >> o: 303.746.7302
> >> Advancing the way the world uses the
> >> cloud
> >> *(tm)*
> >>
> >
> >
> >
> > --
> >
> > EOF
>
>
>
> --
> Daan
>



-- 

EOF


Re: Anyone else see these errors in Eclipse?

2014-03-15 Thread Daan Hoogland
someone hastily checked in some code without running unit tests!
Unforgivable, especially if it was a refactoring. I am kind of lenient
on quick bug fixes so i say this with some restraint. (excuse my
Dutch)

Do we have a merge conflict between two features or refactorings here?

On Sat, Mar 15, 2014 at 3:37 PM, Laszlo Hornyak
 wrote:
> No, it is really broken, 'display' should be replaced with a boolean
> expression. I believe it was something left behind after a refactoring.
>
>
> On Sat, Mar 15, 2014 at 3:17 PM, Daan Hoogland wrote:
>
>> so, is eclipse wrong?
>>
>> On Sat, Mar 15, 2014 at 11:02 AM, Laszlo Hornyak
>>  wrote:
>> > you are not alone :)
>> >
>> >
>> > On Sat, Mar 15, 2014 at 7:38 AM, Mike Tutkowski <
>> > mike.tutkow...@solidfire.com> wrote:
>> >
>> >> "display cannot be resolved to a variable"
>> >>
>> >> http://i.imgur.com/Jz2swFS.png
>> >>
>> >> --
>> >> *Mike Tutkowski*
>> >> *Senior CloudStack Developer, SolidFire Inc.*
>> >> e: mike.tutkow...@solidfire.com
>> >> o: 303.746.7302
>> >> Advancing the way the world uses the
>> >> cloud
>> >> *(tm)*
>> >>
>> >
>> >
>> >
>> > --
>> >
>> > EOF
>>
>>
>>
>> --
>> Daan
>>
>
>
>
> --
>
> EOF



-- 
Daan


Access to Wiki

2014-03-15 Thread Soheil Eizadi
I am starting on CloudStack again, I have not been on the forum in a while. I 
am trying to update to the latest and setup a new development environment.

Can I get access to Wiki to Edit, I use to have access but looks like it is 
changed.

I would like to update 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Using+Eclipse+With+CloudStack
with instructions to use Java 1.7 the default on my current my Mac is 1.6. Also 
how to use JUNIT to debug Unit Tests.

Thanks,
-Soheil

Re: Anyone else see these errors in Eclipse?

2014-03-15 Thread Laszlo Hornyak
The commiter may not have realized that this profile must be activated to
compile the module, also there are no jenkins builds configured to compile
this module and this is broken for about a month. No one noticed until Mike
told about it. Maybe the build-master-noredist could be a good candidate...


On Sat, Mar 15, 2014 at 3:51 PM, Daan Hoogland wrote:

> someone hastily checked in some code without running unit tests!
> Unforgivable, especially if it was a refactoring. I am kind of lenient
> on quick bug fixes so i say this with some restraint. (excuse my
> Dutch)
>
> Do we have a merge conflict between two features or refactorings here?
>
> On Sat, Mar 15, 2014 at 3:37 PM, Laszlo Hornyak
>  wrote:
> > No, it is really broken, 'display' should be replaced with a boolean
> > expression. I believe it was something left behind after a refactoring.
> >
> >
> > On Sat, Mar 15, 2014 at 3:17 PM, Daan Hoogland  >wrote:
> >
> >> so, is eclipse wrong?
> >>
> >> On Sat, Mar 15, 2014 at 11:02 AM, Laszlo Hornyak
> >>  wrote:
> >> > you are not alone :)
> >> >
> >> >
> >> > On Sat, Mar 15, 2014 at 7:38 AM, Mike Tutkowski <
> >> > mike.tutkow...@solidfire.com> wrote:
> >> >
> >> >> "display cannot be resolved to a variable"
> >> >>
> >> >> http://i.imgur.com/Jz2swFS.png
> >> >>
> >> >> --
> >> >> *Mike Tutkowski*
> >> >> *Senior CloudStack Developer, SolidFire Inc.*
> >> >> e: mike.tutkow...@solidfire.com
> >> >> o: 303.746.7302
> >> >> Advancing the way the world uses the
> >> >> cloud
> >> >> *(tm)*
> >> >>
> >> >
> >> >
> >> >
> >> > --
> >> >
> >> > EOF
> >>
> >>
> >>
> >> --
> >> Daan
> >>
> >
> >
> >
> > --
> >
> > EOF
>
>
>
> --
> Daan
>



-- 

EOF


Re: Access to Wiki

2014-03-15 Thread Daan Hoogland
welcome back,
seizadi has access

On Sat, Mar 15, 2014 at 4:14 PM, Soheil Eizadi  wrote:
> I am starting on CloudStack again, I have not been on the forum in a while. I 
> am trying to update to the latest and setup a new development environment.
>
> Can I get access to Wiki to Edit, I use to have access but looks like it is 
> changed.
>
> I would like to update 
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Using+Eclipse+With+CloudStack
> with instructions to use Java 1.7 the default on my current my Mac is 1.6. 
> Also how to use JUNIT to debug Unit Tests.
>
> Thanks,
> -Soheil



-- 
Daan


[Responsiveness report] 2014w10

2014-03-15 Thread Daan Hoogland
The response report for week 10 of 2014 is ready at
https://cwiki.apache.org/confluence/display/CLOUDSTACK/2014W10

for an explanation of this report see
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Responsiveness+report
-- 
Daan


RE: [VOTE] Apache CloudStack 4.3.0 (eighth round)

2014-03-15 Thread Sangeetha Hariharan
Nux,

- I created an instance
- I added a rule (ping) in the otherwise untouched default security group
- I added a rule (ping) in the otherwise untouched default security group
Result: I could not ping the instance
>> In this case , is it possible that when you tried to ping the instance , the 
>> instance had not booted completely? 

Thanks
Sangeetha

-Original Message-
From: Nux! [mailto:n...@li.nux.ro] 
Sent: Saturday, March 15, 2014 4:02 AM
To: dev@cloudstack.apache.org
Subject: RE: [VOTE] Apache CloudStack 4.3.0 (eighth round)

On 15.03.2014 00:42, Edison Su wrote:
> From my test, all the rules got applied. If you stop/start vm, will 
> the first rule get applied?
> Let's for QA team's testing.

Hi Edison,

So I've found out when the first rule doesn't get applied.
Test 1:

I started with
- cloudstack-agent freshly restarted
- I created an instance
- I added a rule (ping) in the otherwise untouched default security group
Result: I could not ping the instance

Once I added another rule the ping rule also got applied.

Test 2:
- deleted the above instance and cleared the default security group
- created new instance
- added a rule for ping again
Result: I could ping the instance

So this is an issue that happens just after cloudstack-agent was started, once 
the security groups have processed a couple of rules then all goes as expected.
I don't know what to make of this..

--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro


RE: [VOTE] Apache CloudStack 4.3.0 (eighth round)

2014-03-15 Thread Nux!

On 15.03.2014 21:18, Sangeetha Hariharan wrote:
In this case , is it possible that when you tried to ping the 
instance , the instance had not booted completely?


No, I made sure it's fully booted first.

--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro


Review Request 19258: AclService changes to clone Acl for NetworkId

2014-03-15 Thread Antonio Fornie

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19258/
---

Review request for cloudstack, daan Hoogland and Hugo Trippaers.


Repository: cloudstack-git


Description
---

When creating a new ACL Rule, and ONLY if provided Network Id instead of VPC 
Id, we
should make sure we don't change an ACL that is used by other networks. So if 
other
networks use it, we clone it, assign the new one to the given network and add 
the
new ACL Rule. This functionality should dissapear for next release, for that we 
will
not accept the Network Id as a parameter for that command, but only the Vpc ID
(required instead of optional)

On the other hand, having the functionality of cloning ACLs is useful.


Diffs
-

  api/src/com/cloud/network/vpc/NetworkACLService.java 29ae4ea 
  build/replace.properties 265f335 
  engine/schema/src/com/cloud/network/vpc/NetworkACLItemDao.java e278485 
  engine/schema/src/com/cloud/network/vpc/NetworkACLVO.java a0b77c7 
  engine/schema/src/com/cloud/network/vpc/dao/NetworkACLDao.java 5e2a6f5 
  engine/schema/src/com/cloud/network/vpc/dao/NetworkACLDaoImpl.java bc178d3 
  engine/schema/src/com/cloud/network/vpc/dao/NetworkACLItemDaoImpl.java 
31ff6f2 
  server/src/com/cloud/network/vpc/NetworkACLServiceImpl.java ec43883 
  server/test/com/cloud/network/vpc/NetworkACLServiceTest.java PRE-CREATION 
  server/test/com/cloud/vpc/NetworkACLServiceTest.java 786789f 

Diff: https://reviews.apache.org/r/19258/diff/


Testing
---

Full maven build plus execution of ACL and ACL rule functionalities


Thanks,

Antonio Fornie



Re: Review Request 19258: AclService changes to clone Acl for NetworkId

2014-03-15 Thread Antonio Fornie

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19258/
---

(Updated March 16, 2014, 5:14 a.m.)


Review request for cloudstack, daan Hoogland and Hugo Trippaers.


Changes
---

Fixed conflicts with last changes in master


Repository: cloudstack-git


Description
---

When creating a new ACL Rule, and ONLY if provided Network Id instead of VPC 
Id, we
should make sure we don't change an ACL that is used by other networks. So if 
other
networks use it, we clone it, assign the new one to the given network and add 
the
new ACL Rule. This functionality should dissapear for next release, for that we 
will
not accept the Network Id as a parameter for that command, but only the Vpc ID
(required instead of optional)

On the other hand, having the functionality of cloning ACLs is useful.


Diffs (updated)
-

  api/src/com/cloud/network/vpc/NetworkACLService.java 7cd1d3b 
  build/replace.properties 265f335 
  engine/schema/src/com/cloud/network/vpc/NetworkACLItemDao.java e278485 
  engine/schema/src/com/cloud/network/vpc/NetworkACLVO.java b6ed5cb 
  engine/schema/src/com/cloud/network/vpc/dao/NetworkACLDao.java 5e2a6f5 
  engine/schema/src/com/cloud/network/vpc/dao/NetworkACLDaoImpl.java bc178d3 
  engine/schema/src/com/cloud/network/vpc/dao/NetworkACLItemDaoImpl.java 
31ff6f2 
  server/src/com/cloud/network/vpc/NetworkACLServiceImpl.java e024fbe 
  server/test/com/cloud/network/vpc/NetworkACLServiceTest.java PRE-CREATION 
  server/test/com/cloud/vpc/NetworkACLServiceTest.java 5361639 

Diff: https://reviews.apache.org/r/19258/diff/


Testing
---

Full maven build plus execution of ACL and ACL rule functionalities


Thanks,

Antonio Fornie