----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19258/ -----------------------------------------------------------
(Updated March 16, 2014, 5:14 a.m.) Review request for cloudstack, daan Hoogland and Hugo Trippaers. Changes ------- Fixed conflicts with last changes in master Repository: cloudstack-git Description ------- When creating a new ACL Rule, and ONLY if provided Network Id instead of VPC Id, we should make sure we don't change an ACL that is used by other networks. So if other networks use it, we clone it, assign the new one to the given network and add the new ACL Rule. This functionality should dissapear for next release, for that we will not accept the Network Id as a parameter for that command, but only the Vpc ID (required instead of optional) On the other hand, having the functionality of cloning ACLs is useful. Diffs (updated) ----- api/src/com/cloud/network/vpc/NetworkACLService.java 7cd1d3b build/replace.properties 265f335 engine/schema/src/com/cloud/network/vpc/NetworkACLItemDao.java e278485 engine/schema/src/com/cloud/network/vpc/NetworkACLVO.java b6ed5cb engine/schema/src/com/cloud/network/vpc/dao/NetworkACLDao.java 5e2a6f5 engine/schema/src/com/cloud/network/vpc/dao/NetworkACLDaoImpl.java bc178d3 engine/schema/src/com/cloud/network/vpc/dao/NetworkACLItemDaoImpl.java 31ff6f2 server/src/com/cloud/network/vpc/NetworkACLServiceImpl.java e024fbe server/test/com/cloud/network/vpc/NetworkACLServiceTest.java PRE-CREATION server/test/com/cloud/vpc/NetworkACLServiceTest.java 5361639 Diff: https://reviews.apache.org/r/19258/diff/ Testing ------- Full maven build plus execution of ACL and ACL rule functionalities Thanks, Antonio Fornie
