Review Request 16813: Contrail plugin fixes

[Suresh Balineni]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16813/
---

Review request for cloudstack.


Repository: cloudstack-git


Description
---

Contrail plugin fixes
 - this patch is already applied to 4.3
 - a master branch patch.
 


Diffs
-

  api/src/com/cloud/network/Network.java 0b76789 
  
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java
 5adbacd 
  
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java
 079035b 
  
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManager.java
 335299e 
  
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManagerImpl.java
 ed58594 
  
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ModelDatabase.java
 e2845b7 
  
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java
 52fe31e 
  
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandlerImpl.java
 5030bb7 
  
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java
 98be288 
  
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/NetworkPolicyModel.java
 PRE-CREATION 
  
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ServiceInstanceModel.java
 a9bc5c1 
  
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualMachineModel.java
 df0af90 
  
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualNetworkModel.java
 547d4bd 
  
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ManagementServerMock.java
 806dd21 
  
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/NetworkProviderTest.java
 fff4e5a 

Diff: https://reviews.apache.org/r/16813/diff/


Testing
---

compiled and verified locally


Thanks,

Suresh Balineni

Re: Review Request 16813: Contrail plugin fixes

[Suresh Balineni]

Hi Sheng,

Please review and ship this master version patch of contrail plugin fixes : 
https://reviews.apache.org/r/16813/

This patch contains fixes of 4.3 review requests :
https://reviews.apache.org/r/16642/
https://reviews.apache.org/r/16805/

Thanks,
Suresh

From: Suresh Balineni mailto:sbalin...@juniper.net>>
Reply-To: Suresh Balineni 
mailto:sbalin...@service.juniper.net>>
Date: Sunday, January 12, 2014 5:02 PM
To: Suresh Balineni 
mailto:sbalin...@service.juniper.net>>, 
cloudstack mailto:dev@cloudstack.apache.org>>
Subject: Review Request 16813: Contrail plugin fixes

This is an automatically generated e-mail. To reply, visit: 
https://reviews.apache.org/r/16813/

Review request for cloudstack.
By Suresh Balineni.
Repository: cloudstack-git
Description

Contrail plugin fixes
 - this patch is already applied to 4.3
 - a master branch patch.



Testing

compiled and verified locally


Diffs

  *   api/src/com/cloud/network/Network.java (0b76789)
  *   
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java
 (5adbacd)
  *   
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java
 (079035b)
  *   
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManager.java
 (335299e)
  *   
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManagerImpl.java
 (ed58594)
  *   
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ModelDatabase.java
 (e2845b7)
  *   
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java
 (52fe31e)
  *   
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandlerImpl.java
 (5030bb7)
  *   
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java
 (98be288)
  *   
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/NetworkPolicyModel.java
 (PRE-CREATION)
  *   
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ServiceInstanceModel.java
 (a9bc5c1)
  *   
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualMachineModel.java
 (df0af90)
  *   
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualNetworkModel.java
 (547d4bd)
  *   
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ManagementServerMock.java
 (806dd21)
  *   
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/NetworkProviderTest.java
 (fff4e5a)

View Diff

Re: Committer license for IntelliJ set to expire

[Abhinandan Prateek]

I am too.

On 07/01/14 8:48 pm, "Chip Childers"  wrote:

>Hey folks,
>
>The free license we have for IntelliJ for committers is set to expire in
>Feb. I've been in contact with them, and can request a new license when
>it gets closer to that time.
>
>For those of you (committers) using the license, please reply to this so
>that I can get you the renewed license off list when the time comes.
>
>-chip

[Doc] [4.3] Enhanced Upgrade for Virtual Routers for Review (CLOUDSTACK-5288)

[Radhika Puthiyetath]

Hi,

4.3 Documentation is getting ready to be reviewed. I have prepared the first 
draft for the feature, Enhanced Upgrade for Virtual Router.

Please see section 16.5.5. Enhanced Upgrade for Virtual Routers (232), and let 
me know your feedback.

The documentation is uploaded at 
https://issues.apache.org/jira/browse/CLOUDSTACK-5288

Regards
-Radhika

Re: Review Request 16258: Add new physical network isolationMethod (L3VPN) for Juniper Contrail plugin.

[Sachchidanand Vaidya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16258/
---

(Updated Jan. 13, 2014, 5:46 a.m.)


Review request for cloudstack.


Changes
---

Minor correction to previous submission.


Repository: cloudstack-git


Description
---

Add new physical network isolationMethod (L3VPN) for Juniper Contrail network 
Plugin. ContrailGuru checks for IsolationMethod before designing a VN. 


Diffs (updated)
-

  api/src/com/cloud/network/PhysicalNetwork.java cfa236d 
  
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java
 ea52be9 
  
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ManagementServerMock.java
 c449b8a 
  ui/scripts/ui-custom/zoneWizard.js 28df193 

Diff: https://reviews.apache.org/r/16258/diff/


Testing
---

Changes pass unit tests and complete centos63 package build.


Thanks,

Sachchidanand Vaidya

[Doc] [4.3] Service Monitoring Tool for Virtual Router for Review [CLOUDSTACK-5292]

[Radhika Puthiyetath]

Hi,

4.3 Documentation is getting ready to be reviewed. I have prepared the first 
draft for the feature, Enhanced Upgrade for Virtual Router.

Please see section 16.5.4. Service Monitoring Tool for Virtual Router, and let 
me know your feedback.

1.The documentation is uploaded at https://issues.apache.org/jira/browse/ 
CLOUDSTACK-5292
2.

Regards
-Radhika

Re: Review Request 16776: CLOUDSTACK-5748: Egress FW Rules - Refactored code related to executing script on user VM and fixed network cleanup issue

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16776/#review31607
---


Commit f18c7ba740242558f609fb3d76a65ac09e59a7e3 in branch refs/heads/4.3 from 
Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=f18c7ba ]

CLOUDSTACK-5748: Refactored code related to executing script


- ASF Subversion and Git Services


On Jan. 10, 2014, 11:25 a.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16776/
> ---
> 
> (Updated Jan. 10, 2014, 11:25 a.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-5748
> https://issues.apache.org/jira/browse/CLOUDSTACK-5748
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Changes:
> 
> 1) Changed the way in which script is executed on user vm. Earlier we used to 
> execute script through router using expect.
> Now directly added NAT and Firewall rule for public ip belonging to user vm, 
> so that we can ssh to vm and then directly execute the script.
> 
> 2) Changed the tearDown method so that exact reason of the cleanup failure 
> will be known. Network cleanup fails (CLOUDSTACK-5748) sometimes because the 
> vm in the network does not get expunged in the expunge interval.
> Have added extra step to check if the VM is expunged or not, and if is 
> expunged then only proceed to network cleanup or else fail the test case with 
> proper reason.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_egress_fw_rules.py e1568bd 
> 
> Diff: https://reviews.apache.org/r/16776/diff/
> 
> 
> Testing
> ---
> 
> Tested locally, all the test cases ran successfully except the 4 which are 
> already skipped.
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Re: Review Request 16776: CLOUDSTACK-5748: Egress FW Rules - Refactored code related to executing script on user VM and fixed network cleanup issue

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16776/#review31608
---


Commit 1760de47e550aa0540f27ac15d299f093425797e in branch refs/heads/master 
from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=1760de4 ]

CLOUDSTACK-5748: Refactored code related to executing script


- ASF Subversion and Git Services


On Jan. 10, 2014, 11:25 a.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16776/
> ---
> 
> (Updated Jan. 10, 2014, 11:25 a.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-5748
> https://issues.apache.org/jira/browse/CLOUDSTACK-5748
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Changes:
> 
> 1) Changed the way in which script is executed on user vm. Earlier we used to 
> execute script through router using expect.
> Now directly added NAT and Firewall rule for public ip belonging to user vm, 
> so that we can ssh to vm and then directly execute the script.
> 
> 2) Changed the tearDown method so that exact reason of the cleanup failure 
> will be known. Network cleanup fails (CLOUDSTACK-5748) sometimes because the 
> vm in the network does not get expunged in the expunge interval.
> Have added extra step to check if the VM is expunged or not, and if is 
> expunged then only proceed to network cleanup or else fail the test case with 
> proper reason.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_egress_fw_rules.py e1568bd 
> 
> Diff: https://reviews.apache.org/r/16776/diff/
> 
> 
> Testing
> ---
> 
> Tested locally, all the test cases ran successfully except the 4 which are 
> already skipped.
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Communication between Management Server and guest vm deployed by root admin user

[Saurav Lahiri]

Hi,
Would anybody know if  there is a way that guest vms deployed by root admin
 can be included in the system management network or routing configured to
allow traffic flow between the management server and this guest vm.

What I am trying to achieve is push the management server logs to a guest
vm(deployed by the root admin user)  which will parse/index the log files.
It appears that since the guest vm is not part of the system management
network, the cloudstack management server is unable to reach it.


Thanks
Saurav