----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16776/#review31607 -----------------------------------------------------------
Commit f18c7ba740242558f609fb3d76a65ac09e59a7e3 in branch refs/heads/4.3 from Gaurav Aradhye [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=f18c7ba ] CLOUDSTACK-5748: Refactored code related to executing script - ASF Subversion and Git Services On Jan. 10, 2014, 11:25 a.m., Gaurav Aradhye wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16776/ > ----------------------------------------------------------- > > (Updated Jan. 10, 2014, 11:25 a.m.) > > > Review request for cloudstack and Girish Shilamkar. > > > Bugs: CLOUDSTACK-5748 > https://issues.apache.org/jira/browse/CLOUDSTACK-5748 > > > Repository: cloudstack-git > > > Description > ------- > > Changes: > > 1) Changed the way in which script is executed on user vm. Earlier we used to > execute script through router using expect. > Now directly added NAT and Firewall rule for public ip belonging to user vm, > so that we can ssh to vm and then directly execute the script. > > 2) Changed the tearDown method so that exact reason of the cleanup failure > will be known. Network cleanup fails (CLOUDSTACK-5748) sometimes because the > vm in the network does not get expunged in the expunge interval. > Have added extra step to check if the VM is expunged or not, and if is > expunged then only proceed to network cleanup or else fail the test case with > proper reason. > > > Diffs > ----- > > test/integration/component/test_egress_fw_rules.py e1568bd > > Diff: https://reviews.apache.org/r/16776/diff/ > > > Testing > ------- > > Tested locally, all the test cases ran successfully except the 4 which are > already skipped. > > > Thanks, > > Gaurav Aradhye > >
