Review Request 16152: added support for 4.2 ldap apis

2013-12-10 Thread Rajani Karuturi

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16152/
---

Review request for cloudstack, Abhinandan Prateek and Ian Duffy.


Bugs: CLOUDSTACK-5375
https://issues.apache.org/jira/browse/CLOUDSTACK-5375


Repository: cloudstack-git


Description
---

Added support for 4.2 ldap apis
in the old api, queryfilter and ssl are used which doesnt exist in the new api. 
they are ignored.


Diffs
-

  
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LDAPConfigCmd.java
 PRE-CREATION 
  
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LDAPRemoveCmd.java
 PRE-CREATION 
  
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/response/LDAPConfigResponse.java
 PRE-CREATION 
  
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/response/LDAPRemoveResponse.java
 PRE-CREATION 
  
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
 f41bd3a 

Diff: https://reviews.apache.org/r/16152/diff/


Testing
---

manually tested. 


Thanks,

Rajani Karuturi



RE: [DISCUSS][PROPOSAL] Move docs to .rst format and readthedocs

2013-12-10 Thread Radhika Puthiyetath
Hi,

+ 0 because I have not yet got time to understand the tool.

I also have to understand what it takes to pick up the tool. I am not a 
developer to sightlessly say Yes. If developers are ready to contribute the doc 
for their features, I am perfectly fine!

If you are planning it for 4.3 docs,  I might not be able to help. I can 
develop content only in DocBook due to time constraints. If you are keen on 
rolling it out for 4.3, I would request the doc contributors to  convert them 
to RST format, or let developers contribute their feature docs in RST format.

Jessica T has moved out from CloudStack, and I am kind of a single-person army 
from Citrix side. Therefore, my contribution might be limited to ASFCS.

-Radhika

-Original Message-
From: Sebastien Goasguen [mailto:run...@gmail.com] 
Sent: Tuesday, December 10, 2013 1:01 PM
To: dev@cloudstack.apache.org
Cc: Radhika Puthiyetath; msweet@gmail.com; Mike Tutkowski
Subject: Re: [DISCUSS][PROPOSAL] Move docs to .rst format and readthedocs


On Dec 9, 2013, at 9:37 PM, Animesh Chaturvedi  
wrote:

> I am +1 to make documentation easier but we just passed code freeze for 4.3 
> and I feel we need to do it after 4.3.  
> 

docs are not in the 4.3 code branch. it's different releases...

> 
> Animesh
> 
> -Original Message-
> From: sebgoa [mailto:run...@gmail.com] 
> Sent: Monday, December 09, 2013 3:54 AM
> To: dev@cloudstack.apache.org
> Cc: Radhika Puthiyetath; msweet@gmail.com; Mike Tutkowski
> Subject: [DISCUSS][PROPOSAL] Move docs to .rst format and readthedocs
> 
> Hi,
> 
> There has been lots of discussion about docs over the last 3/4 months, in 
> summary the issues are:
> 
> -Difficult to maintain and keep website up to date (issues with lang and 
> issues with pdf formatting lately) -Difficult to contribute to easily, 
> docbook is fine but tedious to work on.
> -Errors in the docs don't get properly fixed -Mix of OS information -Lack of 
> content for certain features -Docs release cycle. Docs have bugs that will 
> never get fixed in that specific release (because we see it as code release)
> 
> To remedy some of those issues and work on a new release process specific to 
> docs we moved the docs to its own repo:
> 
> https://git-wip-us.apache.org/repos/asf?p=cloudstack-docs.git
> 
> *I propose that we move away from docbook and use a more readable format: 
> restructuredtext*
> 
> I have worked on a prototype that uses restructured text:
> http://docutils.sourceforge.net/rst.html
> 
> This format makes it extremely easy to write docs. Existing docbook content 
> could be converted to .rst using a tool like pandoc:
> http://johnmacfarlane.net/pandoc/
> 
> *In addition to changing the format I propose that we use readthedocs.org*
> 
> This will help with the release and build of the docs. readthedocs grabs the 
> docs from a git repo, builds html, pdf and epub.
> It can also maintain several releases. We can apply a specific -theme- to our 
> docs. 
> 
> See a prototype here:
> 
> http://cloudstack.readthedocs.org/en/latest/
> 
> *I propose that we move to this as early as 4.3 documentation*
> 
> Assuming this proposal passes, we would need to:
> 
> -re-architect the repo
> -create the proper cnames to be in accordance with trademark guidelines -we 
> can decide what content to keep or not and convert what we keep.
> -decide how we organize the content
> -start accepting pull requests (noting that pages can be edited directly from 
> github) -make a first release of this new doc site at the same time than 4.3 
> release.
> 
> 
> Thoughts, flames ?
> 
> 
> -Sebastien



RE: Blocker bug: can't create the volumes on Xen 6.2.0 on the latest 4.3

2013-12-10 Thread Anthony Xu
This patch is on both master and 4.3,
Maybe the scripts in the old location were copied before,


Anthony

-Original Message-
From: Koushik Das [mailto:koushik@citrix.com] 
Sent: Monday, December 09, 2013 9:37 PM
To: 
Cc: Alena Prokharchyk
Subject: Re: Blocker bug: can't create the volumes on Xen 6.2.0 on the latest 
4.3

I see that for XS the location of script files in the host has changed from 
/opt/xensource/bin to /opt/cloud/bin. On latest master branch I see that the 
scripts are still getting placed in the old location while adding a host. Is 
there any commit missed out on master?

-Koushik

On 10-Dec-2013, at 8:06 AM, Anthony Xu  wrote:

> Always put vhd-util in your cloudstack source tree, 
> scripts/vm/hypervisor/xenserver/
> 
> 
> Anthony
> 
> -Original Message-
> From: Alena Prokharchyk
> Sent: Monday, December 09, 2013 4:49 PM
> To: dev@cloudstack.apache.org; Anthony Xu
> Subject: Re: Blocker bug: can't create the volumes on Xen 6.2.0 on the 
> latest 4.3
> 
> That helped, thank you Min.
> 
> It would be nice to get a notification email next time from the person making 
> this kind of changes to save everybody else's time on debugging.
> 
> -Alena.
> 
> 
> 
> On 12/9/13, 4:02 PM, "Min Chen"  wrote:
> 
>> Is this happening in your ssvm startup? If so, go to your xen host, 
>> /opt/cloud/bin folder, check if you have vhd-util there. Not sure 
>> why, it seems that we have changed the directory from previous 
>> /opt/xensources to /opt/cloud. I ran into a similar problem in starting up 
>> ssvm.
>> 
>> Thanks
>> -min
>> 
>> On 12/9/13 3:58 PM, "Alena Prokharchyk" 
>> 
>> wrote:
>> 
>>> There is some regression bug on the latest 4.3  volumes creation 
>>> fails on xen 6.2.0. Steps made:
>>> 
>>> 1) Deployed CS code and redeployed the DB
>>> 2) Added xen host to the CS
>>> 3) VDI creation fails with generic error message
>>> 
>>> 
>>> 2013-12-09 15:56:44,629 WARN  [c.c.h.x.r.XenServerStorageProcessor]
>>> (DirectAgent-2:ctx-2d667640) can not create vdi in sr
>>> 734481f8-fee3-59d9-20e8-dbe3b8124a78
>>> 2013-12-09 15:56:44,629 WARN  [c.c.h.x.r.XenServerStorageProcessor]
>>> (DirectAgent-2:ctx-2d667640) Catch Exception 
>>> com.cloud.utils.exception.CloudRuntimeException for template +  due 
>>> to
>>> com.cloud.utils.exception.CloudRuntimeException: can not create vdi 
>>> in sr
>>> 734481f8-fee3-59d9-20e8-dbe3b8124a78
>>> com.cloud.utils.exception.CloudRuntimeException: can not create vdi 
>>> in sr
>>> 734481f8-fee3-59d9-20e8-dbe3b8124a78
>>> 
>>> Anthony, I wonder if it can be related to your latest changes. Can 
>>> you please take a look as its a blocker.
>>> 
>>> -Alena.
>> 
> 



Re: Review Request 16129: CLOUDSTACK-5419: missing parameters in configuration table and to remove unused parameters

2013-12-10 Thread Koushik Das

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16129/#review30087
---



setup/db/db/schema-421to430.sql


In an existing 4.2/master setup I see that the component of both 
vmsnapshot.create.wait and vmsnapshot.max is set to none.

Handle this scenario as well.


- Koushik Das


On Dec. 9, 2013, 1:17 p.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16129/
> ---
> 
> (Updated Dec. 9, 2013, 1:17 p.m.)
> 
> 
> Review request for cloudstack and Koushik Das.
> 
> 
> Bugs: CLOUDSTACK-5419
> https://issues.apache.org/jira/browse/CLOUDSTACK-5419
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-5419: missing parameters in configuration table and to remove 
> unused parameters
> 
> Following parameters are unused which were introduced in 3.0.6.
> "xen.update.url", "update.check.interval", "baremetal_dhcp_devices", 
> "host.updates.enable"
> 
> Following parameters are missing upon upgrade from 3.0.6 to 4.3
> "vmsnapshot.create.wait", "vmsnapshot.max" 
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/configuration/Config.java 6ffeb26 
>   setup/db/db/schema-421to430.sql a9c850f 
> 
> Diff: https://reviews.apache.org/r/16129/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>



Re: Review Request 16129: CLOUDSTACK-5419: missing parameters in configuration table and to remove unused parameters

2013-12-10 Thread Harikrishna Patnala

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16129/
---

(Updated Dec. 10, 2013, 10:55 a.m.)


Review request for cloudstack and Koushik Das.


Bugs: CLOUDSTACK-5419
https://issues.apache.org/jira/browse/CLOUDSTACK-5419


Repository: cloudstack-git


Description
---

CLOUDSTACK-5419: missing parameters in configuration table and to remove unused 
parameters

Following parameters are unused which were introduced in 3.0.6.
"xen.update.url", "update.check.interval", "baremetal_dhcp_devices", 
"host.updates.enable"

Following parameters are missing upon upgrade from 3.0.6 to 4.3
"vmsnapshot.create.wait", "vmsnapshot.max" 


Diffs (updated)
-

  server/src/com/cloud/configuration/Config.java 6ffeb26 
  setup/db/db/schema-421to430.sql ee85cd0 

Diff: https://reviews.apache.org/r/16129/diff/


Testing
---


Thanks,

Harikrishna Patnala



Review Request 16153: Fixing by chanding the constructor of MigrateWithStorageAnswer not to include stack trace in the details.

2013-12-10 Thread Damodar Reddy Talakanti

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16153/
---

Review request for cloudstack, Abhinandan Prateek, Likitha Shetty, and Sateesh 
Chodapuneedi.


Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-4597

https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-4597


Repository: cloudstack-git


Description
---

When an API command involved with Storage migration and if api command fails 
then the complete expection stack trace is getting displayed on the UI.


Diffs
-

  core/src/com/cloud/agent/api/MigrateWithStorageAnswer.java 6468884 
  
plugins/hypervisors/vmware/src/org/apache/cloudstack/storage/motion/VmwareStorageMotionStrategy.java
 5c9b3af 

Diff: https://reviews.apache.org/r/16153/diff/


Testing
---

Tested against Live storage migration involved when a VM is migrated to another 
host with vmoption not enabled in the back end.


Thanks,

Damodar Reddy Talakanti



Re: Review Request 16129: CLOUDSTACK-5419: missing parameters in configuration table and to remove unused parameters

2013-12-10 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16129/#review30088
---


Commit b478eed6550048ef6fdf23b929330de23acc5b54 in branch refs/heads/4.3 from 
Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=b478eed ]

CLOUDSTACK-5419: missing parameters in configuration table and to remove unused 
parameters

Signed-off-by: Koushik Das 


- ASF Subversion and Git Services


On Dec. 10, 2013, 10:55 a.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16129/
> ---
> 
> (Updated Dec. 10, 2013, 10:55 a.m.)
> 
> 
> Review request for cloudstack and Koushik Das.
> 
> 
> Bugs: CLOUDSTACK-5419
> https://issues.apache.org/jira/browse/CLOUDSTACK-5419
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-5419: missing parameters in configuration table and to remove 
> unused parameters
> 
> Following parameters are unused which were introduced in 3.0.6.
> "xen.update.url", "update.check.interval", "baremetal_dhcp_devices", 
> "host.updates.enable"
> 
> Following parameters are missing upon upgrade from 3.0.6 to 4.3
> "vmsnapshot.create.wait", "vmsnapshot.max" 
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/configuration/Config.java 6ffeb26 
>   setup/db/db/schema-421to430.sql ee85cd0 
> 
> Diff: https://reviews.apache.org/r/16129/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>



Re: Review Request 16129: CLOUDSTACK-5419: missing parameters in configuration table and to remove unused parameters

2013-12-10 Thread Koushik Das

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16129/#review30089
---

Ship it!


4.3 -> b478eed6550048ef6fdf23b929330de23acc5b54

- Koushik Das


On Dec. 10, 2013, 10:55 a.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16129/
> ---
> 
> (Updated Dec. 10, 2013, 10:55 a.m.)
> 
> 
> Review request for cloudstack and Koushik Das.
> 
> 
> Bugs: CLOUDSTACK-5419
> https://issues.apache.org/jira/browse/CLOUDSTACK-5419
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-5419: missing parameters in configuration table and to remove 
> unused parameters
> 
> Following parameters are unused which were introduced in 3.0.6.
> "xen.update.url", "update.check.interval", "baremetal_dhcp_devices", 
> "host.updates.enable"
> 
> Following parameters are missing upon upgrade from 3.0.6 to 4.3
> "vmsnapshot.create.wait", "vmsnapshot.max" 
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/configuration/Config.java 6ffeb26 
>   setup/db/db/schema-421to430.sql ee85cd0 
> 
> Diff: https://reviews.apache.org/r/16129/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>



Re: Review Request 16129: CLOUDSTACK-5419: missing parameters in configuration table and to remove unused parameters

2013-12-10 Thread Harikrishna Patnala

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16129/
---

(Updated Dec. 10, 2013, 11:18 a.m.)


Review request for cloudstack and Koushik Das.


Bugs: CLOUDSTACK-5419
https://issues.apache.org/jira/browse/CLOUDSTACK-5419


Repository: cloudstack-git


Description
---

CLOUDSTACK-5419: missing parameters in configuration table and to remove unused 
parameters

Following parameters are unused which were introduced in 3.0.6.
"xen.update.url", "update.check.interval", "baremetal_dhcp_devices", 
"host.updates.enable"

Following parameters are missing upon upgrade from 3.0.6 to 4.3
"vmsnapshot.create.wait", "vmsnapshot.max" 


Diffs (updated)
-

  server/src/com/cloud/configuration/Config.java afc09d6 
  setup/db/db/schema-421to430.sql 5f81050 

Diff: https://reviews.apache.org/r/16129/diff/


Testing
---


Thanks,

Harikrishna Patnala



Re: Review Request 16129: CLOUDSTACK-5419: missing parameters in configuration table and to remove unused parameters

2013-12-10 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16129/#review30090
---


Commit 5036097659d395a66ba36213ac1cfcd6e34bf6aa in branch refs/heads/master 
from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5036097 ]

CLOUDSTACK-5419: missing parameters in configuration table and to remove unused 
parameters

Signed-off-by: Koushik Das 


- ASF Subversion and Git Services


On Dec. 10, 2013, 11:18 a.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16129/
> ---
> 
> (Updated Dec. 10, 2013, 11:18 a.m.)
> 
> 
> Review request for cloudstack and Koushik Das.
> 
> 
> Bugs: CLOUDSTACK-5419
> https://issues.apache.org/jira/browse/CLOUDSTACK-5419
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-5419: missing parameters in configuration table and to remove 
> unused parameters
> 
> Following parameters are unused which were introduced in 3.0.6.
> "xen.update.url", "update.check.interval", "baremetal_dhcp_devices", 
> "host.updates.enable"
> 
> Following parameters are missing upon upgrade from 3.0.6 to 4.3
> "vmsnapshot.create.wait", "vmsnapshot.max" 
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/configuration/Config.java afc09d6 
>   setup/db/db/schema-421to430.sql 5f81050 
> 
> Diff: https://reviews.apache.org/r/16129/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>



Review Request 16154: Fixed CLOUDSTACK-5423

2013-12-10 Thread Santhosh Edukulla

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16154/
---

Review request for cloudstack and Girish Shilamkar.


Bugs: CLOUDSTACK-5423
https://issues.apache.org/jira/browse/CLOUDSTACK-5423


Repository: cloudstack-git


Description
---

1. As part of recent changes to marvin, mentioned files requires some changes. 
2. Some cleaning is as well required for these two files. Did clean up.
3. Did cleanup in deployAndRun and added proper flow for ease of understanding.
4. Removed unwanted logging and used MarvinInit for initialization of Marvin.
5. Removed few unwanted loops and redundant code.
6. Renamed  TestCaseExecuteEngine.py -> tcExecuteEngine.py inline with other 
naming convention for modules in Marvin
7. Added few codes and doc strings.


Diffs
-

  tools/marvin/marvin/TestCaseExecuteEngine.py f5af1fe 
  tools/marvin/marvin/configGenerator.py 3f98aca 
  tools/marvin/marvin/deployAndRun.py 8a758a1 
  tools/marvin/marvin/tcExecuteEngine.py PRE-CREATION 

Diff: https://reviews.apache.org/r/16154/diff/


Testing
---

Tested DeployDC and Running Few test case runs with deployAndRun.


Thanks,

Santhosh Edukulla



Re: Review Request 16153: Fixing by chanding the constructor of MigrateWithStorageAnswer not to include stack trace in the details.

2013-12-10 Thread Sateesh Chodapuneedi

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16153/#review30091
---


Can you please share the exception messages observed in testing against 
exception messages printed in web UI earlier?

- Sateesh Chodapuneedi


On Dec. 10, 2013, 11:13 a.m., Damodar Reddy Talakanti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16153/
> ---
> 
> (Updated Dec. 10, 2013, 11:13 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek, Likitha Shetty, and 
> Sateesh Chodapuneedi.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-4597
> 
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-4597
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> When an API command involved with Storage migration and if api command fails 
> then the complete expection stack trace is getting displayed on the UI.
> 
> 
> Diffs
> -
> 
>   core/src/com/cloud/agent/api/MigrateWithStorageAnswer.java 6468884 
>   
> plugins/hypervisors/vmware/src/org/apache/cloudstack/storage/motion/VmwareStorageMotionStrategy.java
>  5c9b3af 
> 
> Diff: https://reviews.apache.org/r/16153/diff/
> 
> 
> Testing
> ---
> 
> Tested against Live storage migration involved when a VM is migrated to 
> another host with vmoption not enabled in the back end.
> 
> 
> Thanks,
> 
> Damodar Reddy Talakanti
> 
>



Review Request 16155: Fixed CLOUDSTACK-5436

2013-12-10 Thread Santhosh Edukulla

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16155/
---

Review request for cloudstack and Abhinandan Prateek.


Bugs: CLOUDSTACK-5436
https://issues.apache.org/jira/browse/CLOUDSTACK-5436


Repository: cloudstack-git


Description
---

Added License Information to 19 files mentioned under RAT run. Two newly moved 
files already has the license information. 


Diffs
-

  tools/marvin/marvin/misc/build/CI.md c320125 
  tools/marvin/marvin/misc/build/README.md bf0e03c 
  tools/marvin/marvin/misc/build/advanced_env.py b01e912 
  tools/marvin/marvin/misc/build/asf_test.cfg b75827d 
  tools/marvin/marvin/misc/build/bashUtils.py f1bf471 
  tools/marvin/marvin/misc/build/buildGenerator.py 6964943 
  tools/marvin/marvin/misc/build/configure.py 796ab2d 
  tools/marvin/marvin/misc/build/hudson.sh d5ece96 
  tools/marvin/marvin/misc/build/kvm.cfg d02eefa 
  tools/marvin/marvin/misc/build/openport.py ab2726d 
  tools/marvin/marvin/misc/build/redeploy.sh 4ddd302 
  tools/marvin/marvin/misc/build/restartMgmt.py fd005a8 
  tools/marvin/marvin/misc/build/system.properties a4e1e0f 
  tools/marvin/marvin/misc/build/testSetupSuccess.py ed167a1 
  tools/marvin/marvin/misc/build/vm-start.sh 48878fb 
  tools/marvin/marvin/misc/build/vm-uninstall.sh 48f2d74 
  tools/marvin/marvin/misc/build/xen.cfg bdeacda 
  tools/marvin/marvin/misc/build/xunitmp/setup.py b5ad6d8 
  tools/marvin/marvin/misc/build/xunitmp/xunitmultiprocess.py 950a2e3 

Diff: https://reviews.apache.org/r/16155/diff/


Testing
---


Thanks,

Santhosh Edukulla



Review Request 16155: Fixed CLOUDSTACK-5436

2013-12-10 Thread Santhosh Edukulla

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16155/
---

Review request for cloudstack and Abhinandan Prateek.


Bugs: CLOUDSTACK-5436
https://issues.apache.org/jira/browse/CLOUDSTACK-5436


Repository: cloudstack-git


Description
---

Added License Information to 19 files mentioned under RAT run. Two newly moved 
files already has the license information. 


Diffs
-

  tools/marvin/marvin/misc/build/CI.md c320125 
  tools/marvin/marvin/misc/build/README.md bf0e03c 
  tools/marvin/marvin/misc/build/advanced_env.py b01e912 
  tools/marvin/marvin/misc/build/asf_test.cfg b75827d 
  tools/marvin/marvin/misc/build/bashUtils.py f1bf471 
  tools/marvin/marvin/misc/build/buildGenerator.py 6964943 
  tools/marvin/marvin/misc/build/configure.py 796ab2d 
  tools/marvin/marvin/misc/build/hudson.sh d5ece96 
  tools/marvin/marvin/misc/build/kvm.cfg d02eefa 
  tools/marvin/marvin/misc/build/openport.py ab2726d 
  tools/marvin/marvin/misc/build/redeploy.sh 4ddd302 
  tools/marvin/marvin/misc/build/restartMgmt.py fd005a8 
  tools/marvin/marvin/misc/build/system.properties a4e1e0f 
  tools/marvin/marvin/misc/build/testSetupSuccess.py ed167a1 
  tools/marvin/marvin/misc/build/vm-start.sh 48878fb 
  tools/marvin/marvin/misc/build/vm-uninstall.sh 48f2d74 
  tools/marvin/marvin/misc/build/xen.cfg bdeacda 
  tools/marvin/marvin/misc/build/xunitmp/setup.py b5ad6d8 
  tools/marvin/marvin/misc/build/xunitmp/xunitmultiprocess.py 950a2e3 

Diff: https://reviews.apache.org/r/16155/diff/


Testing
---


Thanks,

Santhosh Edukulla



Re: Review Request 16153: Fixing by chanding the constructor of MigrateWithStorageAnswer not to include stack trace in the details.

2013-12-10 Thread Damodar Reddy Talakanti


> On Dec. 10, 2013, 11:57 a.m., Sateesh Chodapuneedi wrote:
> > Can you please share the exception messages observed in testing against 
> > exception messages printed in web UI earlier?


Exception stack trace is there at defect 
https://issues.apache.org/jira/browse/CLOUDSTACK-4597.. For the full trace you 
can go there..


2013-09-02 23:16:34,439 ERROR [storage.motion.VmwareStorageMotionStrategy] 
(Job-Executor-99:job-175 = [ ca1a7028-1aac-44c0-9833-96cb9f911cde ]) copy failed
com.cloud.utils.exception.CloudRuntimeException: Error while migrating the vm 
VM[User|instance5] to host Host[-8-Routing]. Exception: 
javax.xml.ws.WebServiceException
Message: java.net.SocketTimeoutException: Read timed out
Stack: javax.xml.ws.WebServiceException: java.net.SocketTimeoutException: Read 
timed out
at 
com.sun.xml.internal.ws.transport.http.client.HttpClientTransport.readResponseCodeAndMessage(HttpClientTransport.java:201)
at 
com.sun.xml.internal.ws.transport.http.client.HttpTransportPipe.process(HttpTransportPipe.java:151)
at 
com.sun.xml.internal.ws.transport.http.client.HttpTransportPipe.processRequest(HttpTransportPipe.java:83)
at 
com.sun.xml.internal.ws.transport.DeferredTransportPipe.processRequest(DeferredTransportPipe.java:78)
at com.sun.xml.internal.ws.api.pipe.Fiber.__doRun(Fiber.java:587)
at com.sun.xml.internal.ws.api.pipe.Fiber._doRun(Fiber.java:546)
at com.sun.xml.internal.ws.api.pipe.Fiber.doRun(Fiber.java:531)
at com.sun.xml.internal.ws.api.pipe.Fiber.runSync(Fiber.java:428)
at com.sun.xml.internal.ws.client.Stub.process(Stub.java:211)
at 
com.sun.xml.internal.ws.client.sei.SEIStub.doProcess(SEIStub.java:124)
at 
com.sun.xml.internal.ws.client.sei.SyncMethodHandler.invoke(SyncMethodHandler.java:98)
at 
com.sun.xml.internal.ws.client.sei.SyncMethodHandler.invoke(SyncMethodHandler.java:78)
at com.sun.xml.internal.ws.client.sei.SEIStub.invoke(SEIStub.java:107)
at $Proxy89.waitForUpdates(Unknown Source)
at 
com.cloud.hypervisor.vmware.util.VmwareClient.waitForValues(VmwareClient.java:428)
at 
com.cloud.hypervisor.vmware.util.VmwareClient.waitForTask(VmwareClient.java:371)
at 
com.cloud.hypervisor.vmware.mo.VirtualMachineMO.changeDatastore(VirtualMachineMO.java:344)
at 
com.cloud.hypervisor.vmware.resource.VmwareResource.execute(VmwareResource.java:4281)
at 
com.cloud.hypervisor.vmware.resource.VmwareResource.executeRequest(VmwareResource.java:467)
at 
com.cloud.agent.manager.DirectAgentAttache$Task.run(DirectAgentAttache.java:186)
at 
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
at java.util.concurrent.FutureTask.run(FutureTask.java:166)
at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$101(ScheduledThreadPoolExecutor.java:165)
at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:266)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
at java.lang.Thread.run(Thread.java:679)
Caused by: java.net.SocketTimeoutException: Read timed out
at java.net.SocketInputStream.socketRead0(Native Method)
at java.net.SocketInputStream.read(SocketInputStream.java:146)
at sun.security.ssl.InputRecord.readFully(InputRecord.java:312)
at sun.security.ssl.InputRecord.read(InputRecord.java:350)
at sun.security.ssl.SSLSocketImpl.readRecord(SSLSocketImpl.java:850)
at 
sun.security.ssl.SSLSocketImpl.readDataRecord(SSLSocketImpl.java:807) 


- Damodar Reddy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16153/#review30091
---


On Dec. 10, 2013, 11:13 a.m., Damodar Reddy Talakanti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16153/
> ---
> 
> (Updated Dec. 10, 2013, 11:13 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek, Likitha Shetty, and 
> Sateesh Chodapuneedi.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-4597
> 
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-4597
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> When an API command involved with Storage migration and if api command fails 
> then the complete expection stack trace is getting displayed on the UI.
> 
> 
> Diffs
> -
> 
>   core/src/com/cloud/agent/api/MigrateWithStor

Re: Review Request 16153: Fixing by chanding the constructor of MigrateWithStorageAnswer not to include stack trace in the details.

2013-12-10 Thread Sateesh Chodapuneedi


> On Dec. 10, 2013, 11:57 a.m., Sateesh Chodapuneedi wrote:
> > Can you please share the exception messages observed in testing against 
> > exception messages printed in web UI earlier?
> 
> Damodar Reddy Talakanti wrote:
> 
> Exception stack trace is there at defect 
> https://issues.apache.org/jira/browse/CLOUDSTACK-4597.. For the full trace 
> you can go there..
> 
> 
> 
> 
> 
> 
> 
> 
> 2013-09-02 23:16:34,439 ERROR 
> [storage.motion.VmwareStorageMotionStrategy] (Job-Executor-99:job-175 = [ 
> ca1a7028-1aac-44c0-9833-96cb9f911cde ]) copy failed
> com.cloud.utils.exception.CloudRuntimeException: Error while migrating 
> the vm VM[User|instance5] to host Host[-8-Routing]. Exception: 
> javax.xml.ws.WebServiceException
> Message: java.net.SocketTimeoutException: Read timed out
> Stack: javax.xml.ws.WebServiceException: java.net.SocketTimeoutException: 
> Read timed out
> at 
> com.sun.xml.internal.ws.transport.http.client.HttpClientTransport.readResponseCodeAndMessage(HttpClientTransport.java:201)
> at 
> com.sun.xml.internal.ws.transport.http.client.HttpTransportPipe.process(HttpTransportPipe.java:151)
> at 
> com.sun.xml.internal.ws.transport.http.client.HttpTransportPipe.processRequest(HttpTransportPipe.java:83)
> at 
> com.sun.xml.internal.ws.transport.DeferredTransportPipe.processRequest(DeferredTransportPipe.java:78)
> at com.sun.xml.internal.ws.api.pipe.Fiber.__doRun(Fiber.java:587)
> at com.sun.xml.internal.ws.api.pipe.Fiber._doRun(Fiber.java:546)
> at com.sun.xml.internal.ws.api.pipe.Fiber.doRun(Fiber.java:531)
> at com.sun.xml.internal.ws.api.pipe.Fiber.runSync(Fiber.java:428)
> at com.sun.xml.internal.ws.client.Stub.process(Stub.java:211)
> at 
> com.sun.xml.internal.ws.client.sei.SEIStub.doProcess(SEIStub.java:124)
> at 
> com.sun.xml.internal.ws.client.sei.SyncMethodHandler.invoke(SyncMethodHandler.java:98)
> at 
> com.sun.xml.internal.ws.client.sei.SyncMethodHandler.invoke(SyncMethodHandler.java:78)
> at 
> com.sun.xml.internal.ws.client.sei.SEIStub.invoke(SEIStub.java:107)
> at $Proxy89.waitForUpdates(Unknown Source)
> at 
> com.cloud.hypervisor.vmware.util.VmwareClient.waitForValues(VmwareClient.java:428)
> at 
> com.cloud.hypervisor.vmware.util.VmwareClient.waitForTask(VmwareClient.java:371)
> at 
> com.cloud.hypervisor.vmware.mo.VirtualMachineMO.changeDatastore(VirtualMachineMO.java:344)
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.execute(VmwareResource.java:4281)
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.executeRequest(VmwareResource.java:467)
> at 
> com.cloud.agent.manager.DirectAgentAttache$Task.run(DirectAgentAttache.java:186)
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> at 
> java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
> at java.util.concurrent.FutureTask.run(FutureTask.java:166)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$101(ScheduledThreadPoolExecutor.java:165)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:266)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
> at java.lang.Thread.run(Thread.java:679)
> Caused by: java.net.SocketTimeoutException: Read timed out
> at java.net.SocketInputStream.socketRead0(Native Method)
> at java.net.SocketInputStream.read(SocketInputStream.java:146)
> at sun.security.ssl.InputRecord.readFully(InputRecord.java:312)
> at sun.security.ssl.InputRecord.read(InputRecord.java:350)
> at 
> sun.security.ssl.SSLSocketImpl.readRecord(SSLSocketImpl.java:850)
> at 
> sun.security.ssl.SSLSocketImpl.readDataRecord(SSLSocketImpl.java:807)

Hi,
I am looking for the exception messages observed in testing this patch. Would 
like to see them against the messages in the reported bug.
Thanks.


- Sateesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16153/#review30091
---


On Dec. 10, 2013, 11:13 a.m., Damodar Reddy Talakanti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16153/
> ---
> 
> (Updated Dec. 10, 2013, 11:13 a.m.)
> 
> 
> Review request for 

Re: Review Request 16153: Fixing by chanding the constructor of MigrateWithStorageAnswer not to include stack trace in the details.

2013-12-10 Thread Damodar Reddy Talakanti


> On Dec. 10, 2013, 11:57 a.m., Sateesh Chodapuneedi wrote:
> > Can you please share the exception messages observed in testing against 
> > exception messages printed in web UI earlier?
> 
> Damodar Reddy Talakanti wrote:
> 
> Exception stack trace is there at defect 
> https://issues.apache.org/jira/browse/CLOUDSTACK-4597.. For the full trace 
> you can go there..
> 
> 
> 
> 
> 
> 
> 
> 
> 2013-09-02 23:16:34,439 ERROR 
> [storage.motion.VmwareStorageMotionStrategy] (Job-Executor-99:job-175 = [ 
> ca1a7028-1aac-44c0-9833-96cb9f911cde ]) copy failed
> com.cloud.utils.exception.CloudRuntimeException: Error while migrating 
> the vm VM[User|instance5] to host Host[-8-Routing]. Exception: 
> javax.xml.ws.WebServiceException
> Message: java.net.SocketTimeoutException: Read timed out
> Stack: javax.xml.ws.WebServiceException: java.net.SocketTimeoutException: 
> Read timed out
> at 
> com.sun.xml.internal.ws.transport.http.client.HttpClientTransport.readResponseCodeAndMessage(HttpClientTransport.java:201)
> at 
> com.sun.xml.internal.ws.transport.http.client.HttpTransportPipe.process(HttpTransportPipe.java:151)
> at 
> com.sun.xml.internal.ws.transport.http.client.HttpTransportPipe.processRequest(HttpTransportPipe.java:83)
> at 
> com.sun.xml.internal.ws.transport.DeferredTransportPipe.processRequest(DeferredTransportPipe.java:78)
> at com.sun.xml.internal.ws.api.pipe.Fiber.__doRun(Fiber.java:587)
> at com.sun.xml.internal.ws.api.pipe.Fiber._doRun(Fiber.java:546)
> at com.sun.xml.internal.ws.api.pipe.Fiber.doRun(Fiber.java:531)
> at com.sun.xml.internal.ws.api.pipe.Fiber.runSync(Fiber.java:428)
> at com.sun.xml.internal.ws.client.Stub.process(Stub.java:211)
> at 
> com.sun.xml.internal.ws.client.sei.SEIStub.doProcess(SEIStub.java:124)
> at 
> com.sun.xml.internal.ws.client.sei.SyncMethodHandler.invoke(SyncMethodHandler.java:98)
> at 
> com.sun.xml.internal.ws.client.sei.SyncMethodHandler.invoke(SyncMethodHandler.java:78)
> at 
> com.sun.xml.internal.ws.client.sei.SEIStub.invoke(SEIStub.java:107)
> at $Proxy89.waitForUpdates(Unknown Source)
> at 
> com.cloud.hypervisor.vmware.util.VmwareClient.waitForValues(VmwareClient.java:428)
> at 
> com.cloud.hypervisor.vmware.util.VmwareClient.waitForTask(VmwareClient.java:371)
> at 
> com.cloud.hypervisor.vmware.mo.VirtualMachineMO.changeDatastore(VirtualMachineMO.java:344)
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.execute(VmwareResource.java:4281)
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.executeRequest(VmwareResource.java:467)
> at 
> com.cloud.agent.manager.DirectAgentAttache$Task.run(DirectAgentAttache.java:186)
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> at 
> java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
> at java.util.concurrent.FutureTask.run(FutureTask.java:166)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$101(ScheduledThreadPoolExecutor.java:165)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:266)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
> at java.lang.Thread.run(Thread.java:679)
> Caused by: java.net.SocketTimeoutException: Read timed out
> at java.net.SocketInputStream.socketRead0(Native Method)
> at java.net.SocketInputStream.read(SocketInputStream.java:146)
> at sun.security.ssl.InputRecord.readFully(InputRecord.java:312)
> at sun.security.ssl.InputRecord.read(InputRecord.java:350)
> at 
> sun.security.ssl.SSLSocketImpl.readRecord(SSLSocketImpl.java:850)
> at 
> sun.security.ssl.SSLSocketImpl.readDataRecord(SSLSocketImpl.java:807)
> 
> Sateesh Chodapuneedi wrote:
> Hi,
> I am looking for the exception messages observed in testing this patch. 
> Would like to see them against the messages in the reported bug.
> Thanks.

This is what I have seen in the UI (Another trace below this is present in the 
logs)

com.cloud.utils.exception.CloudRuntimeException: Failed to migrated vm 
VM[User|d-5054] along with its volumes. Error while migrating the vm 
VM[User|d-5054] to host Host[-1-Routing]. The vMotion interface is not 
configured (or is misconfigured) on the Source host '10.147.28.15'.
at 
org.apache.cloudstack.engine.orchestration.VolumeOrchestrator.migrateVolumes(VolumeOrchestrator.java:908)
at 
com.cloud.vm.VirtualMachineManagerImpl.orchestra

Re: Review Request 16155: Fixed CLOUDSTACK-5436

2013-12-10 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16155/#review30096
---


Commit 55c56b6cc26d4e1f5156b0a6a387594659d271f5 in branch refs/heads/4.2 from 
Santhosh Edukulla
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=55c56b6 ]

Fixed CLOUDSTACK-5436

Fixed few RAT issues reported for new additions of files to repo.
Signed-off-by: Santhosh Edukulla 
Signed-off-by: Abhinandan Prateek 


- ASF Subversion and Git Services


On Dec. 10, 2013, 12:06 p.m., Santhosh Edukulla wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16155/
> ---
> 
> (Updated Dec. 10, 2013, 12:06 p.m.)
> 
> 
> Review request for cloudstack and Abhinandan Prateek.
> 
> 
> Bugs: CLOUDSTACK-5436
> https://issues.apache.org/jira/browse/CLOUDSTACK-5436
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Added License Information to 19 files mentioned under RAT run. Two newly 
> moved files already has the license information. 
> 
> 
> Diffs
> -
> 
>   tools/marvin/marvin/misc/build/CI.md c320125 
>   tools/marvin/marvin/misc/build/README.md bf0e03c 
>   tools/marvin/marvin/misc/build/advanced_env.py b01e912 
>   tools/marvin/marvin/misc/build/asf_test.cfg b75827d 
>   tools/marvin/marvin/misc/build/bashUtils.py f1bf471 
>   tools/marvin/marvin/misc/build/buildGenerator.py 6964943 
>   tools/marvin/marvin/misc/build/configure.py 796ab2d 
>   tools/marvin/marvin/misc/build/hudson.sh d5ece96 
>   tools/marvin/marvin/misc/build/kvm.cfg d02eefa 
>   tools/marvin/marvin/misc/build/openport.py ab2726d 
>   tools/marvin/marvin/misc/build/redeploy.sh 4ddd302 
>   tools/marvin/marvin/misc/build/restartMgmt.py fd005a8 
>   tools/marvin/marvin/misc/build/system.properties a4e1e0f 
>   tools/marvin/marvin/misc/build/testSetupSuccess.py ed167a1 
>   tools/marvin/marvin/misc/build/vm-start.sh 48878fb 
>   tools/marvin/marvin/misc/build/vm-uninstall.sh 48f2d74 
>   tools/marvin/marvin/misc/build/xen.cfg bdeacda 
>   tools/marvin/marvin/misc/build/xunitmp/setup.py b5ad6d8 
>   tools/marvin/marvin/misc/build/xunitmp/xunitmultiprocess.py 950a2e3 
> 
> Diff: https://reviews.apache.org/r/16155/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>



Re: Review Request 16155: Fixed CLOUDSTACK-5436

2013-12-10 Thread Abhinandan Prateek

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16155/#review30097
---

Ship it!


Ship It!

- Abhinandan Prateek


On Dec. 10, 2013, 12:06 p.m., Santhosh Edukulla wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16155/
> ---
> 
> (Updated Dec. 10, 2013, 12:06 p.m.)
> 
> 
> Review request for cloudstack and Abhinandan Prateek.
> 
> 
> Bugs: CLOUDSTACK-5436
> https://issues.apache.org/jira/browse/CLOUDSTACK-5436
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Added License Information to 19 files mentioned under RAT run. Two newly 
> moved files already has the license information. 
> 
> 
> Diffs
> -
> 
>   tools/marvin/marvin/misc/build/CI.md c320125 
>   tools/marvin/marvin/misc/build/README.md bf0e03c 
>   tools/marvin/marvin/misc/build/advanced_env.py b01e912 
>   tools/marvin/marvin/misc/build/asf_test.cfg b75827d 
>   tools/marvin/marvin/misc/build/bashUtils.py f1bf471 
>   tools/marvin/marvin/misc/build/buildGenerator.py 6964943 
>   tools/marvin/marvin/misc/build/configure.py 796ab2d 
>   tools/marvin/marvin/misc/build/hudson.sh d5ece96 
>   tools/marvin/marvin/misc/build/kvm.cfg d02eefa 
>   tools/marvin/marvin/misc/build/openport.py ab2726d 
>   tools/marvin/marvin/misc/build/redeploy.sh 4ddd302 
>   tools/marvin/marvin/misc/build/restartMgmt.py fd005a8 
>   tools/marvin/marvin/misc/build/system.properties a4e1e0f 
>   tools/marvin/marvin/misc/build/testSetupSuccess.py ed167a1 
>   tools/marvin/marvin/misc/build/vm-start.sh 48878fb 
>   tools/marvin/marvin/misc/build/vm-uninstall.sh 48f2d74 
>   tools/marvin/marvin/misc/build/xen.cfg bdeacda 
>   tools/marvin/marvin/misc/build/xunitmp/setup.py b5ad6d8 
>   tools/marvin/marvin/misc/build/xunitmp/xunitmultiprocess.py 950a2e3 
> 
> Diff: https://reviews.apache.org/r/16155/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>



[VOTE] 2rd round of voting for ASF 4.2.1 third RC

2013-12-10 Thread Abhinandan Prateek
Hi,
  
   This release candidate addresses the following additional issues
reported by community:

1. CLOUDSTACK-5145 : ListNetworkACL API should list ACLs owned by the user
only
2. CLOUDSTACK-5214 : 4.2.1 upgrade is broken
3. The CHANGES file has been fixed to mark some important fixes as such,
instead of new features which they are not.

The details of this RC are as:

https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/
heads/4.2
commit: 43350d64ce66e366f08a9fa13ad09bca462b66da

List of changes are available in Release Notes, a summary can be accessed
in CHANGES file:
https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=blob_plain;f=CHA
NGES;hb=4.2

Source release revision 3865 (checksums and signatures are available at
the same location):
https://dist.apache.org/repos/dist/dev/cloudstack/4.2.1/
  **note that for release notes separate email will go out subsequently.

PGP release keys (signed using RSA Key ID = 42443AA1):
https://dist.apache.org/repos/dist/release/cloudstack/KEYS

Vote will be open for 72 hours (until 12/05 End of day PST).

For sanity in tallying the vote, can PMC members please be sure to
indicate "(binding)" with their vote?

[ ] +1  approve
[ ] +0  no opinion
[ ] -1  disapprove (and reason why)





Re: [VOTE] 2rd round of voting for ASF 4.2.1 third RC

2013-12-10 Thread Abhinandan Prateek
The vote is open till 13 Dec 2013.

On 10/12/13 6:28 pm, "Abhinandan Prateek" 
wrote:

>Hi,
>  
>   This release candidate addresses the following additional issues
>reported by community:
>
>1. CLOUDSTACK-5145 : ListNetworkACL API should list ACLs owned by the user
>only
>2. CLOUDSTACK-5214 : 4.2.1 upgrade is broken
>3. The CHANGES file has been fixed to mark some important fixes as such,
>instead of new features which they are not.
>
>The details of this RC are as:
>
>https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs
>/
>heads/4.2
>commit: 43350d64ce66e366f08a9fa13ad09bca462b66da
>
>List of changes are available in Release Notes, a summary can be accessed
>in CHANGES file:
>https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=blob_plain;f=CH
>A
>NGES;hb=4.2
>
>Source release revision 3865 (checksums and signatures are available at
>the same location):
>https://dist.apache.org/repos/dist/dev/cloudstack/4.2.1/
>  **note that for release notes separate email will go out subsequently.
>
>PGP release keys (signed using RSA Key ID = 42443AA1):
>https://dist.apache.org/repos/dist/release/cloudstack/KEYS
>
>Vote will be open for 72 hours (until 12/05 End of day PST).
>
>For sanity in tallying the vote, can PMC members please be sure to
>indicate "(binding)" with their vote?
>
>[ ] +1  approve
>[ ] +0  no opinion
>[ ] -1  disapprove (and reason why)
>
>
>



[DISCUSS][PROPOSAL]Closing SQLStatement to avoid resource leaks

2013-12-10 Thread Antonio Fornié Casarrubios
Hi all,

I'm trying to fix some typical "Resource Leak" issues in some cloudstack
classes. An example could be Upgrade2214to30, but actually the very same
issue can be found in many other classes.

The reason for this mail is all these occurrences shall be fixed in a
congruent way and I would like to know your thoughts about the following
proposal:

Let's see this exaple code

01PreparedStatement pstmt = conn.prepareStatement("SELECT bla bla bla");
02ResultSet rs = pstmt.executeQuery();
03while (rs.next()) {
04pstmt = conn.prepareStatement("INSERT INTO bla bla");
05pstmt.setLong(1, networkOfferingId);
06pstmt.executeUpdate();
07 }


In line 4 we assign a new PrepSt object to the same variable, so the
previous object is lost and impossible to .close()  and the same will
happen in each following iteration of the loop. Of course we cannot close
the first PrepSt because that would also close the ResultSet and thus brake
the loop, so we could create a second variable insertPstmt and change it
like this:

01PreparedStatement pstmt = conn.prepareStatement("SELECT bla bla bla");
02ResultSet rs = pstmt.executeQuery();
03while (rs.next()) {
04PreparedStatement insertPstmt = conn.prepareStatement("INSERT
INTO bla bla");
05insertPstmt.setLong(1, networkOfferingId);
06insertPstmt.executeUpdate();
07insertPstmt.close();
08}
...
15finally{
16if (pstmt != null) {
17pstmt.close();
18}
19}

This solution could be good for simple scenarios, but in some others we
have several PrepSt open at the same time with 2 or 3 levels of nested
loops... so this solution would mean creating plenty of PrepSt variables,
which I think could be messy and error-prone...

...and on top of that we end up repeating the same code in all the finally
blocks of all the methods as we do now:

} finally {
try {
if (rs != null) {
rs.close();
}

if (pstmt != null) {
pstmt.close();
}
} catch (SQLException e) {
}
}


I propose that in each of these cases we would do something like:
00List pstmt2Close = new
ArrayList();
01PreparedStatement pstmt = conn.prepareStatement("SELECT bla bla bla");
02pstmt2Close.add(pstmt);
03ResultSet rs = pstmt.executeQuery();
04while (rs.next()) {
05pstmt = conn.prepareStatement("INSERT INTO bla bla");
06pstmt2Close.add(pstmt);
06pstmt.setLong(1, networkOfferingId);
07pstmt.executeUpdate();
08}
...
15finally{
16closePstmts(pstmt2Close);
17}

So we have a single List of Statements where I drop all of them as they are
created and in the finally block I call this method:

01protected void closePstmts(List pstmt2Close){
02for(PreparedStatement pstmt : pstmt2Close) {
03try {
04if (pstmt != null && !pstmt.isClosed()) {
05pstmt.close();
06}
07} catch (SQLException e) {
08// It's not possible to recover from this and we need to
continue closing
09e.printStackTrace();
10}
11}
12}


Note1: Once a PreparedStatment is closed it's Resultset is closed too, so
this method doesn't need more.
Note2: We code the finally block only once and for all, instead of having
different developers repeating the same or even worse, coding something
different (Ana prints the Exception msg, Bob doesn't print and Carl throws
a new Ex)

Note3: For next versions of Java (from 1.7 on) PreparedStatement and other
classes implement AutoCloseable, so we can have a list of AutoCloseable and
if we want our method cleaner we can even use DbUtils.closeQuietly().

If you guys don't see any drawbacks I will proceed and do the same in
future similar scenarios.

Thanks. Cheers
antonio


RE: [DISCUSS][PROPOSAL] Move docs to .rst format and readthedocs

2013-12-10 Thread Geoff Higginbottom
+1 from me, anything to make updating Docs easier has to be a positive

Regards

Geoff Higginbottom

D: +44 20 3603 0542 | S: +44 20 3603 0540 | M: +447968161581

geoff.higginbot...@shapeblue.com

-Original Message-
From: sebgoa [mailto:run...@gmail.com]
Sent: 09 December 2013 11:54
To: dev@cloudstack.apache.org
Cc: Radhika Puthiyetath; msweet@gmail.com; Mike Tutkowski
Subject: [DISCUSS][PROPOSAL] Move docs to .rst format and readthedocs

Hi,

There has been lots of discussion about docs over the last 3/4 months, in 
summary the issues are:

-Difficult to maintain and keep website up to date (issues with lang and issues 
with pdf formatting lately) -Difficult to contribute to easily, docbook is fine 
but tedious to work on.
-Errors in the docs don't get properly fixed -Mix of OS information -Lack of 
content for certain features -Docs release cycle. Docs have bugs that will 
never get fixed in that specific release (because we see it as code release)

To remedy some of those issues and work on a new release process specific to 
docs we moved the docs to its own repo:

https://git-wip-us.apache.org/repos/asf?p=cloudstack-docs.git

*I propose that we move away from docbook and use a more readable format: 
restructuredtext*

I have worked on a prototype that uses restructured text:
http://docutils.sourceforge.net/rst.html

This format makes it extremely easy to write docs. Existing docbook content 
could be converted to .rst using a tool like pandoc:
http://johnmacfarlane.net/pandoc/

*In addition to changing the format I propose that we use readthedocs.org*

This will help with the release and build of the docs. readthedocs grabs the 
docs from a git repo, builds html, pdf and epub.
It can also maintain several releases. We can apply a specific -theme- to our 
docs.

See a prototype here:

http://cloudstack.readthedocs.org/en/latest/

*I propose that we move to this as early as 4.3 documentation*

Assuming this proposal passes, we would need to:

-re-architect the repo
-create the proper cnames to be in accordance with trademark guidelines -we can 
decide what content to keep or not and convert what we keep.
-decide how we organize the content
-start accepting pull requests (noting that pages can be edited directly from 
github) -make a first release of this new doc site at the same time than 4.3 
release.


Thoughts, flames ?


-Sebastien
This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England & Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue is a registered trademark.


Re: [DISCUSS][PROPOSAL] Move docs to .rst format and readthedocs

2013-12-10 Thread nicolas.lamirault
+1 for .rst !

Le 09/12/2013 12:54, sebgoa a écrit :
> Hi,
> 
> There has been lots of discussion about docs over the last 3/4 months, in 
> summary the issues are:
> 
> -Difficult to maintain and keep website up to date (issues with lang and 
> issues with pdf formatting lately)
> -Difficult to contribute to easily, docbook is fine but tedious to work on.
> -Errors in the docs don't get properly fixed
> -Mix of OS information
> -Lack of content for certain features
> -Docs release cycle. Docs have bugs that will never get fixed in that 
> specific release (because we see it as code release)
> 
> To remedy some of those issues and work on a new release process specific to 
> docs we moved the docs to its own repo:
> 
> https://git-wip-us.apache.org/repos/asf?p=cloudstack-docs.git
> 
> *I propose that we move away from docbook and use a more readable format: 
> restructuredtext*
> 
> I have worked on a prototype that uses restructured text:
> http://docutils.sourceforge.net/rst.html
> 
> This format makes it extremely easy to write docs. Existing docbook content 
> could be converted to .rst using a tool like pandoc:
> http://johnmacfarlane.net/pandoc/
> 
> *In addition to changing the format I propose that we use readthedocs.org*
> 
> This will help with the release and build of the docs. readthedocs grabs the 
> docs from a git repo, builds html, pdf and epub.
> It can also maintain several releases. We can apply a specific -theme- to our 
> docs. 
> 
> See a prototype here:
> 
> http://cloudstack.readthedocs.org/en/latest/
> 
> *I propose that we move to this as early as 4.3 documentation*
> 
> Assuming this proposal passes, we would need to:
> 
> -re-architect the repo
> -create the proper cnames to be in accordance with trademark guidelines
> -we can decide what content to keep or not and convert what we keep.
> -decide how we organize the content
> -start accepting pull requests (noting that pages can be edited directly from 
> github)
> -make a first release of this new doc site at the same time than 4.3 release.
> 
> 
> Thoughts, flames ?
> 
> 
> -Sebastien
> 


-- 
Nicolas Lamirault

_

Ce message et ses pieces jointes peuvent contenir des informations 
confidentielles ou privilegiees et ne doivent donc
pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce 
message par erreur, veuillez le signaler
a l'expediteur et le detruire ainsi que les pieces jointes. Les messages 
electroniques etant susceptibles d'alteration,
Orange decline toute responsabilite si ce message a ete altere, deforme ou 
falsifie. Merci.

This message and its attachments may contain confidential or privileged 
information that may be protected by law;
they should not be distributed, used or copied without authorisation.
If you have received this email in error, please notify the sender and delete 
this message and its attachments.
As emails may be altered, Orange is not liable for messages that have been 
modified, changed or falsified.
Thank you.



Re: Review Request 16154: Fixed CLOUDSTACK-5423

2013-12-10 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16154/#review30099
---


Commit 3144e01c13b4a488c557a74849eafe4161566784 in branch refs/heads/master 
from Santhosh Edukulla
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=3144e01 ]

CLOUDSTACK-5423: Fixed 5423


- ASF Subversion and Git Services


On Dec. 10, 2013, 11:37 a.m., Santhosh Edukulla wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16154/
> ---
> 
> (Updated Dec. 10, 2013, 11:37 a.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-5423
> https://issues.apache.org/jira/browse/CLOUDSTACK-5423
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> 1. As part of recent changes to marvin, mentioned files requires some 
> changes. 
> 2. Some cleaning is as well required for these two files. Did clean up.
> 3. Did cleanup in deployAndRun and added proper flow for ease of 
> understanding.
> 4. Removed unwanted logging and used MarvinInit for initialization of Marvin.
> 5. Removed few unwanted loops and redundant code.
> 6. Renamed  TestCaseExecuteEngine.py -> tcExecuteEngine.py inline with other 
> naming convention for modules in Marvin
> 7. Added few codes and doc strings.
> 
> 
> Diffs
> -
> 
>   tools/marvin/marvin/TestCaseExecuteEngine.py f5af1fe 
>   tools/marvin/marvin/configGenerator.py 3f98aca 
>   tools/marvin/marvin/deployAndRun.py 8a758a1 
>   tools/marvin/marvin/tcExecuteEngine.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/16154/diff/
> 
> 
> Testing
> ---
> 
> Tested DeployDC and Running Few test case runs with deployAndRun.
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>



Re: Review Request 16154: Fixed CLOUDSTACK-5423

2013-12-10 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16154/#review30100
---


Commit 4ee3fdbde9e721021894e9f4a869fb89f5d786e7 in branch refs/heads/4.3 from 
Santhosh Edukulla
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=4ee3fdb ]

CLOUDSTACK-5423: Fixed 5423


- ASF Subversion and Git Services


On Dec. 10, 2013, 11:37 a.m., Santhosh Edukulla wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16154/
> ---
> 
> (Updated Dec. 10, 2013, 11:37 a.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-5423
> https://issues.apache.org/jira/browse/CLOUDSTACK-5423
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> 1. As part of recent changes to marvin, mentioned files requires some 
> changes. 
> 2. Some cleaning is as well required for these two files. Did clean up.
> 3. Did cleanup in deployAndRun and added proper flow for ease of 
> understanding.
> 4. Removed unwanted logging and used MarvinInit for initialization of Marvin.
> 5. Removed few unwanted loops and redundant code.
> 6. Renamed  TestCaseExecuteEngine.py -> tcExecuteEngine.py inline with other 
> naming convention for modules in Marvin
> 7. Added few codes and doc strings.
> 
> 
> Diffs
> -
> 
>   tools/marvin/marvin/TestCaseExecuteEngine.py f5af1fe 
>   tools/marvin/marvin/configGenerator.py 3f98aca 
>   tools/marvin/marvin/deployAndRun.py 8a758a1 
>   tools/marvin/marvin/tcExecuteEngine.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/16154/diff/
> 
> 
> Testing
> ---
> 
> Tested DeployDC and Running Few test case runs with deployAndRun.
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>



Re: Review Request 15825: Added unit tests for Juniper Contrail Virtual Network (VN) and Virtual Machine (VM) Model classes.

2013-12-10 Thread Sachchidanand Vaidya

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15825/
---

(Updated Dec. 10, 2013, 5:12 p.m.)


Review request for cloudstack.


Changes
---

Updated diff based on the review comments.


Repository: cloudstack-git


Description
---

The code change adds UnitTest cases for Juniper Contrail Virtual Network(VN) 
and Virtual Machine(VM) Model classes.
Only VN & VM creation test cases added. 


Diffs (updated)
-

  
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ModelDatabase.java
 7f66a3b 
  
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualMachineModel.java
 96cea95 
  
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/VirtualMachineModelTest.java
 PRE-CREATION 
  
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/VirtualNetworkModelTest.java
 0938541 

Diff: https://reviews.apache.org/r/15825/diff/


Testing
---

Juniper contrail Unit Tests ran successfully as part of package build.


Thanks,

Sachchidanand Vaidya



Board report due tomorrow.

2013-12-10 Thread Chip Childers
I'll fill out the board report later on today, but wanted to ask on
the list if there are any specific items / issues that you want to see
added to the report this quarter.  Hearing none, I'll submit the
report with the "standard stuff" in it tomorrow.

-cihp


RE: [DISCUSS][PROPOSAL] Move docs to .rst format and readthedocs

2013-12-10 Thread Animesh Chaturvedi


-Original Message-
From: Sebastien Goasguen [mailto:run...@gmail.com] 
Sent: Monday, December 09, 2013 11:31 PM
To: dev@cloudstack.apache.org
Cc: Radhika Puthiyetath; msweet@gmail.com; Mike Tutkowski
Subject: Re: [DISCUSS][PROPOSAL] Move docs to .rst format and readthedocs


On Dec 9, 2013, at 9:37 PM, Animesh Chaturvedi  
wrote:

> I am +1 to make documentation easier but we just passed code freeze for 4.3 
> and I feel we need to do it after 4.3.  
> 

docs are not in the 4.3 code branch. it's different releases...

Animesh> But they will be released together. 

> 
> Animesh
> 
> -Original Message-
> From: sebgoa [mailto:run...@gmail.com] 
> Sent: Monday, December 09, 2013 3:54 AM
> To: dev@cloudstack.apache.org
> Cc: Radhika Puthiyetath; msweet@gmail.com; Mike Tutkowski
> Subject: [DISCUSS][PROPOSAL] Move docs to .rst format and readthedocs
> 
> Hi,
> 
> There has been lots of discussion about docs over the last 3/4 months, in 
> summary the issues are:
> 
> -Difficult to maintain and keep website up to date (issues with lang and 
> issues with pdf formatting lately) -Difficult to contribute to easily, 
> docbook is fine but tedious to work on.
> -Errors in the docs don't get properly fixed -Mix of OS information -Lack of 
> content for certain features -Docs release cycle. Docs have bugs that will 
> never get fixed in that specific release (because we see it as code release)
> 
> To remedy some of those issues and work on a new release process specific to 
> docs we moved the docs to its own repo:
> 
> https://git-wip-us.apache.org/repos/asf?p=cloudstack-docs.git
> 
> *I propose that we move away from docbook and use a more readable format: 
> restructuredtext*
> 
> I have worked on a prototype that uses restructured text:
> http://docutils.sourceforge.net/rst.html
> 
> This format makes it extremely easy to write docs. Existing docbook content 
> could be converted to .rst using a tool like pandoc:
> http://johnmacfarlane.net/pandoc/
> 
> *In addition to changing the format I propose that we use readthedocs.org*
> 
> This will help with the release and build of the docs. readthedocs grabs the 
> docs from a git repo, builds html, pdf and epub.
> It can also maintain several releases. We can apply a specific -theme- to our 
> docs. 
> 
> See a prototype here:
> 
> http://cloudstack.readthedocs.org/en/latest/
> 
> *I propose that we move to this as early as 4.3 documentation*
> 
> Assuming this proposal passes, we would need to:
> 
> -re-architect the repo
> -create the proper cnames to be in accordance with trademark guidelines -we 
> can decide what content to keep or not and convert what we keep.
> -decide how we organize the content
> -start accepting pull requests (noting that pages can be edited directly from 
> github) -make a first release of this new doc site at the same time than 4.3 
> release.
> 
> 
> Thoughts, flames ?
> 
> 
> -Sebastien



Re: [DISCUSS][PROPOSAL] Move docs to .rst format and readthedocs

2013-12-10 Thread Francois Gaudreault
+1.  Anything to move away from "manual" docbook is good!!! Now we won't
have any reasons not to update the documentation if we find bugs in it :S

asciidoc would have been another possibility tho... but reST is fine :)

Francois


On Tue, Dec 10, 2013 at 12:23 PM, Animesh Chaturvedi <
animesh.chaturv...@citrix.com> wrote:

>
>
> -Original Message-
> From: Sebastien Goasguen [mailto:run...@gmail.com]
> Sent: Monday, December 09, 2013 11:31 PM
> To: dev@cloudstack.apache.org
> Cc: Radhika Puthiyetath; msweet@gmail.com; Mike Tutkowski
> Subject: Re: [DISCUSS][PROPOSAL] Move docs to .rst format and readthedocs
>
>
> On Dec 9, 2013, at 9:37 PM, Animesh Chaturvedi <
> animesh.chaturv...@citrix.com> wrote:
>
> > I am +1 to make documentation easier but we just passed code freeze for
> 4.3 and I feel we need to do it after 4.3.
> >
>
> docs are not in the 4.3 code branch. it's different releases...
>
> Animesh> But they will be released together.
>
> >
> > Animesh
> >
> > -Original Message-
> > From: sebgoa [mailto:run...@gmail.com]
> > Sent: Monday, December 09, 2013 3:54 AM
> > To: dev@cloudstack.apache.org
> > Cc: Radhika Puthiyetath; msweet@gmail.com; Mike Tutkowski
> > Subject: [DISCUSS][PROPOSAL] Move docs to .rst format and readthedocs
> >
> > Hi,
> >
> > There has been lots of discussion about docs over the last 3/4 months,
> in summary the issues are:
> >
> > -Difficult to maintain and keep website up to date (issues with lang and
> issues with pdf formatting lately) -Difficult to contribute to easily,
> docbook is fine but tedious to work on.
> > -Errors in the docs don't get properly fixed -Mix of OS information
> -Lack of content for certain features -Docs release cycle. Docs have bugs
> that will never get fixed in that specific release (because we see it as
> code release)
> >
> > To remedy some of those issues and work on a new release process
> specific to docs we moved the docs to its own repo:
> >
> > https://git-wip-us.apache.org/repos/asf?p=cloudstack-docs.git
> >
> > *I propose that we move away from docbook and use a more readable
> format: restructuredtext*
> >
> > I have worked on a prototype that uses restructured text:
> > http://docutils.sourceforge.net/rst.html
> >
> > This format makes it extremely easy to write docs. Existing docbook
> content could be converted to .rst using a tool like pandoc:
> > http://johnmacfarlane.net/pandoc/
> >
> > *In addition to changing the format I propose that we use
> readthedocs.org*
> >
> > This will help with the release and build of the docs. readthedocs grabs
> the docs from a git repo, builds html, pdf and epub.
> > It can also maintain several releases. We can apply a specific -theme-
> to our docs.
> >
> > See a prototype here:
> >
> > http://cloudstack.readthedocs.org/en/latest/
> >
> > *I propose that we move to this as early as 4.3 documentation*
> >
> > Assuming this proposal passes, we would need to:
> >
> > -re-architect the repo
> > -create the proper cnames to be in accordance with trademark guidelines
> -we can decide what content to keep or not and convert what we keep.
> > -decide how we organize the content
> > -start accepting pull requests (noting that pages can be edited directly
> from github) -make a first release of this new doc site at the same time
> than 4.3 release.
> >
> >
> > Thoughts, flames ?
> >
> >
> > -Sebastien
>
>


Re: [DISCUSS][PROPOSAL] Move docs to .rst format and readthedocs

2013-12-10 Thread Marty Sweet
+1, also a clearer Wiki to show how to contribute towards docs would be
good, including what repo to fetch - I assume this would be made easier
using Github Pull requests?

On the Wiki:
GIT Usage - with Examples
Conventional Markup (Linking to documentation can be daunting to some
users, causing them not to contribute - as with the case with Publican)

Marty


On Tue, Dec 10, 2013 at 5:36 PM, Francois Gaudreault <
fgaudrea...@cloudops.com> wrote:

> +1.  Anything to move away from "manual" docbook is good!!! Now we won't
> have any reasons not to update the documentation if we find bugs in it :S
>
> asciidoc would have been another possibility tho... but reST is fine :)
>
> Francois
>
>
> On Tue, Dec 10, 2013 at 12:23 PM, Animesh Chaturvedi <
> animesh.chaturv...@citrix.com> wrote:
>
> >
> >
> > -Original Message-
> > From: Sebastien Goasguen [mailto:run...@gmail.com]
> > Sent: Monday, December 09, 2013 11:31 PM
> > To: dev@cloudstack.apache.org
> > Cc: Radhika Puthiyetath; msweet@gmail.com; Mike Tutkowski
> > Subject: Re: [DISCUSS][PROPOSAL] Move docs to .rst format and readthedocs
> >
> >
> > On Dec 9, 2013, at 9:37 PM, Animesh Chaturvedi <
> > animesh.chaturv...@citrix.com> wrote:
> >
> > > I am +1 to make documentation easier but we just passed code freeze for
> > 4.3 and I feel we need to do it after 4.3.
> > >
> >
> > docs are not in the 4.3 code branch. it's different releases...
> >
> > Animesh> But they will be released together.
> >
> > >
> > > Animesh
> > >
> > > -Original Message-
> > > From: sebgoa [mailto:run...@gmail.com]
> > > Sent: Monday, December 09, 2013 3:54 AM
> > > To: dev@cloudstack.apache.org
> > > Cc: Radhika Puthiyetath; msweet@gmail.com; Mike Tutkowski
> > > Subject: [DISCUSS][PROPOSAL] Move docs to .rst format and readthedocs
> > >
> > > Hi,
> > >
> > > There has been lots of discussion about docs over the last 3/4 months,
> > in summary the issues are:
> > >
> > > -Difficult to maintain and keep website up to date (issues with lang
> and
> > issues with pdf formatting lately) -Difficult to contribute to easily,
> > docbook is fine but tedious to work on.
> > > -Errors in the docs don't get properly fixed -Mix of OS information
> > -Lack of content for certain features -Docs release cycle. Docs have bugs
> > that will never get fixed in that specific release (because we see it as
> > code release)
> > >
> > > To remedy some of those issues and work on a new release process
> > specific to docs we moved the docs to its own repo:
> > >
> > > https://git-wip-us.apache.org/repos/asf?p=cloudstack-docs.git
> > >
> > > *I propose that we move away from docbook and use a more readable
> > format: restructuredtext*
> > >
> > > I have worked on a prototype that uses restructured text:
> > > http://docutils.sourceforge.net/rst.html
> > >
> > > This format makes it extremely easy to write docs. Existing docbook
> > content could be converted to .rst using a tool like pandoc:
> > > http://johnmacfarlane.net/pandoc/
> > >
> > > *In addition to changing the format I propose that we use
> > readthedocs.org*
> > >
> > > This will help with the release and build of the docs. readthedocs
> grabs
> > the docs from a git repo, builds html, pdf and epub.
> > > It can also maintain several releases. We can apply a specific -theme-
> > to our docs.
> > >
> > > See a prototype here:
> > >
> > > http://cloudstack.readthedocs.org/en/latest/
> > >
> > > *I propose that we move to this as early as 4.3 documentation*
> > >
> > > Assuming this proposal passes, we would need to:
> > >
> > > -re-architect the repo
> > > -create the proper cnames to be in accordance with trademark guidelines
> > -we can decide what content to keep or not and convert what we keep.
> > > -decide how we organize the content
> > > -start accepting pull requests (noting that pages can be edited
> directly
> > from github) -make a first release of this new doc site at the same time
> > than 4.3 release.
> > >
> > >
> > > Thoughts, flames ?
> > >
> > >
> > > -Sebastien
> >
> >
>


Upgrade System VM Template

2013-12-10 Thread Ian Service
I'm having no end of NAT issues with the System VM template I installed
with 4.1 and I noticed there's a newer one available.  Is there a
documented upgrade procedure somewhere or is it as simple as install the
new one and update a mysql table to point to the new template?

Thanks,

- Ian


Re: SRX/ASA and ACS VPC

2013-12-10 Thread Chiradeep Vittal
Not currently.

From: Simon Murphy mailto:simon.mur...@vifx.co.nz>>
Reply-To: "dev@cloudstack.apache.org" 
mailto:dev@cloudstack.apache.org>>
Date: Monday, December 9, 2013 3:03 PM
To: "us...@cloudstack.apache.org" 
mailto:us...@cloudstack.apache.org>>, 
"dev@cloudstack.apache.org" 
mailto:dev@cloudstack.apache.org>>
Subject: SRX/ASA and ACS VPC

Is it possible to offload firewall, SourceNAT and inter-VLAN routing functions 
to hardware devices for VPC networks?


Simon Murphy
Solutions Architect

ViFX | Cloud Infrastructure
Level 7, 57 Fort Street, Auckland, New Zealand 1010
PO Box 106700, Auckland, New Zealand 1143
M +64 21 285 4519 | S simon_a_murphy
www.vifx.co.nz follow us on 
twitter
Auckland | Wellington | Christchurch

[cid:image003.jpg@01CDDF95.815BF160]

experience. expertise. execution.

This email and any files transmitted with it are confidential, without 
prejudice and may contain information that is subject to legal privilege. It is 
intended solely for the use of the individual/s to whom it is addressed in 
accordance with the provisions of the Privacy Act (1993). The content contained 
in this email does not, necessarily, reflect the official policy position of 
ViFX nor does ViFX have any responsibility for any alterations to the contents 
of this email that may occur following transmission. If you are not the 
addressee it may be unlawful for you to read, copy, distribute, disclose or 
otherwise use the information contained within this email. If you are not the 
intended recipient, please notify the sender prior to deleting this email 
message from your system. Please note ViFX reserves the right to monitor, from 
time to time, the communications sent to and from its email network.


Re: Entity UUID and Type missing on ActionEvent event notifications

2013-12-10 Thread David Grizzanti
Murali,

I spoke with Alex regarding this issue and it appears there may have been some 
mix up in what the original intent of the bug was and what actually got fixed.  
To me, the idea behind this was to address the bug that the entity UUID was not 
getting added to ActionEvents for all resource types.  When I looked at this 
fix today and spoke with Alex, I think what was fixed was only for 
accounts/users/domains.

Not sure where the break down happened, but was wondering how you thought we 
should address this?  Open a new Jira to track the changes given the history of 
the existing one or re-open 
https://issues.apache.org/jira/browse/CLOUDSTACK-3190?

Thanks

-- 
David Grizzanti
Software Engineer
Sungard Availability Services

e: david.grizza...@sungard.com
w: 215.446.1431
c: 570.575.0315

On December 6, 2013 at 4:26:40 PM, Alex Ough (alex.o...@sungard.com) wrote:

I modified the fix to make a little simpler, so can you review it please?  

I'd like to finalize this as soon as possible to move on with CLOUDSTACK-4992.  

Thanks  
Alex Ough  

On Thu, Dec 5, 2013 at 1:32 PM, Alex Ough  wrote:  
> All,  
>  
> I submitted the review request, so please review it and let me know if there  
> is anything missing/incorrect.  
>  
> Thanks  
> Alex Ough  
>  
>  
> On Wed, Dec 4, 2013 at 11:29 PM, Murali Reddy   
> wrote:  
>>  
>> On 05/12/13 12:01 AM, "Alex Ough"  wrote:  
>>  
>> >All,  
>> >  
>> >I made a comment on its jira,  
>> >CLOUDSTACK-3190,  
>> >so can anyone confirm what I found?  
>> >I guess it is related with some refactoring related with 'CallContext'  
>> >class.  
>>  
>> Alex,  
>>  
>> Yes, it regressed during shift from UserContext to CallContext. Please go  
>> ahead with changes  
>>  
>> >  
>> >If correct, I'd like make changes because it is a blocker of what I'm  
>> >working on for  
>> >CLOUDSTACK-4992  
>> >.  
>> >  
>> >Thanks  
>> >Alex Ough  
>> >  
>> >  
>> >On Wed, Nov 20, 2013 at 1:37 PM, Nitin Mehta   
>> >wrote:  
>> >  
>> >> David - CallContext gets created during the entry point of the API.  
>> >> I haven't had the chance to completely investigate but I am hoping that  
>> >> you can push the UUID then or on completion of the API (in case where  
>> >>you  
>> >> are creating the actual resource).  
>> >> See if that works else there is no other way out.  
>> >>  
>> >> Another feedback on Rabbit MQ would be to push the list of all the  
>> >> first  
>> >> class objects (UUIDs) that are affected in the event description if  
>> >> possible. Say user invokes attachVolume to a vm. It would be good to  
>> >> always push vm uuid.  
>> >> Just putting in the volume uuid necessitates another call to CS and  
>> >> also  
>> >> that this was attach volume operation.  
>> >>  
>> >> Thanks,  
>> >> -Nitin  
>> >>  
>> >> On 20/11/13 8:23 AM, "David Grizzanti"   
>> >> wrote:  
>> >>  
>> >> >Thanks for the feedback and info on the existing bug filed for this.  
>> >> >  
>> >> >Nitin - I was originally thinking along the lines of what Murali has  
>> >> >recently commented (i.e. adding Entity Details in the UserContext in  
>> >>all  
>> >> >the places where an Action Event is generated). The particular case I  
>> >> >was using this for when I found the issue was for creating a network,  
>> >> >which is not an async job. The AsyncJobManager I believe it  
>> >>generating a  
>> >> >different type of event that what I was originally looking at.  
>> >> >  
>> >> >Let me know your thoughts.  
>> >> >  
>> >> >Thanks  
>> >> >  
>> >> >--  
>> >> >David Grizzanti  
>> >> >Software Engineer  
>> >> >Sungard Availability Services  
>> >> >  
>> >> >e: david.grizza...@sungard.com  
>> >> >w: 215.446.1431  
>> >> >c: 570.575.0315  
>> >> >  
>> >> >On November 20, 2013 at 2:45:50 AM, Murali Reddy  
>> >> >(murali.re...@citrix.com) wrote:  
>> >> >  
>> >> >  
>> >> >  
>> >> >On 20/11/13 2:15 AM, "David Grizzanti"   
>> >> >wrote:  
>> >> >  
>> >> >>Hi All,  
>> >> >>  
>> >> >>I noticed that the event messages going to rabbitmq of type  
>> >> >>"ActionEvent"  
>> >> >>are missing any reference to the entity Id/UUID. Was this omission  
>> >> >>intentional? Poking through the code, I was able to find that adding  
>> >>the  
>> >> >>  
>> >> >>information on to the event is fairly straightforward (albeit a bit  
>> >> >>tedious). Does anyone have any objections to updating these event  
>> >>types  
>> >> >>with this information? I can file the appropriate Jira, but wanted to  
>> >> >>check in with the list first to get opinions.  
>> >> >  
>> >> >David,  
>> >> >  
>> >> >Omission is not intentional. Please see [1] for earlier discussion.  
>> >>There  
>> >> >  
>> >> >is a bug opened as well[2].  
>> >> >  
>> >> >If you see ActionEventUtils, there is code that gets 'entity type' and  
>> >> >'entity uuid' from the CallContext and fills the details on the  

Re: [VOTE] 2rd round of voting for ASF 4.2.1 third RC

2013-12-10 Thread Daan Hoogland
I am going to tentatively -1 this one. There has changed something
since last rc that makes this one not start a ssvm in my sanity check
env after creating a zone. I have not pinned down the culprit commit
yet so I will keep looking till I can be sure as to what is wrong. I
have been going back and forth between the two versions and commits in
the middle and the problem is reproducible it seems.

The new rc throws an insufficient capacity exception and then null
pointers as it tries to start the console proxy. In the same env with
the same config and zone spec, the old rc works.

will let you know as I find out more,
Daan

On Tue, Dec 10, 2013 at 2:21 PM, Abhinandan Prateek
 wrote:
> The vote is open till 13 Dec 2013.
>
> On 10/12/13 6:28 pm, "Abhinandan Prateek" 
> wrote:
>
>>Hi,
>>
>>   This release candidate addresses the following additional issues
>>reported by community:
>>
>>1. CLOUDSTACK-5145 : ListNetworkACL API should list ACLs owned by the user
>>only
>>2. CLOUDSTACK-5214 : 4.2.1 upgrade is broken
>>3. The CHANGES file has been fixed to mark some important fixes as such,
>>instead of new features which they are not.
>>
>>The details of this RC are as:
>>
>>https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs
>>/
>>heads/4.2
>>commit: 43350d64ce66e366f08a9fa13ad09bca462b66da
>>
>>List of changes are available in Release Notes, a summary can be accessed
>>in CHANGES file:
>>https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=blob_plain;f=CH
>>A
>>NGES;hb=4.2
>>
>>Source release revision 3865 (checksums and signatures are available at
>>the same location):
>>https://dist.apache.org/repos/dist/dev/cloudstack/4.2.1/
>>  **note that for release notes separate email will go out subsequently.
>>
>>PGP release keys (signed using RSA Key ID = 42443AA1):
>>https://dist.apache.org/repos/dist/release/cloudstack/KEYS
>>
>>Vote will be open for 72 hours (until 12/05 End of day PST).
>>
>>For sanity in tallying the vote, can PMC members please be sure to
>>indicate "(binding)" with their vote?
>>
>>[ ] +1  approve
>>[ ] +0  no opinion
>>[ ] -1  disapprove (and reason why)
>>
>>
>>
>


Re: Review Request 16126: CLOUDSTACK-5404: Fix timezone bug in network usages

2013-12-10 Thread Olivier Lemasle

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16126/
---

(Updated Dec. 10, 2013, 10:14 p.m.)


Review request for cloudstack, Kishan Kavala and Wei Zhou.


Changes
---

New patch for master


Bugs: CLOUDSTACK-5404
https://issues.apache.org/jira/browse/CLOUDSTACK-5404


Repository: cloudstack-git


Description (updated)
---

Fix CLOUDSTACK-5404, which was causing a timezone issue: network usages 
(network bytes sent/received) are in local time, whereas other usages 
(instances, volumes, network offerings, etc.) are in GMT. More details on Jira 
(CLOUDSTACK-5404).

The patch applies for branchs 4.2 and 4.3.
I've attached an other patch for master.


Diffs
-

  engine/schema/src/com/cloud/usage/dao/UsageDaoImpl.java 8b79257 

Diff: https://reviews.apache.org/r/16126/diff/


Testing
---

I packaged the patch version in RPMs (branch 4.2), installed it, and the bug is 
fixed. No regression found.


File Attachments (updated)


patch-for-master
  
https://reviews.apache.org/media/uploaded/files/2013/12/10/e44c83a5-a78f-41e2-9abe-5560e29b5a80__CLOUDSTACK-5404-master.patch


Thanks,

Olivier Lemasle



Re: Documentation Question

2013-12-10 Thread Mike Tutkowski
Hi,

I know we are having a discussion about changing the way we do docs in 4.3,
but - for the time being - I was making a few changes locally from this
repo:

https://git-wip-us.apache.org/repos/asf/cloudstack-docs.git

I notice there are only the 4.2 and master branches.

I assume master is 4.3 in this repo?

Thanks!


On Thu, Dec 5, 2013 at 10:02 PM, Mike Tutkowski <
mike.tutkow...@solidfire.com> wrote:

> Thanks!
>
>
> On Thu, Dec 5, 2013 at 9:39 PM, Radhika Puthiyetath <
> radhika.puthiyet...@citrix.com> wrote:
>
>> Yes. It has been moved to
>> http://git-wip-us.apache.org/repos/asf/cloudstack-docs/repo
>>
>>
>>
>> -Original Message-
>> From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
>> Sent: Friday, December 06, 2013 12:20 AM
>> To: dev@cloudstack.apache.org
>> Subject: Documentation Question
>>
>> Hi,
>>
>> It's been a while since I've needed to update documentation for
>> CloudStack's Admin and Installation Guides.
>>
>> I know at some point there was talk of breaking documentation out into
>> another repo.
>>
>> Can someone refresh my memory as to whether that new repo was created or
>> if we decided to keep documentation in the same place it was located for
>> 4.2?
>>
>> Thanks!
>>
>> --
>> *Mike Tutkowski*
>> *Senior CloudStack Developer, SolidFire Inc.*
>> e: mike.tutkow...@solidfire.com
>> o: 303.746.7302
>> Advancing the way the world uses the
>> cloud
>> *(tm)*
>>
>
>
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the 
> cloud
> *™*
>



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloud
*™*


4.3 build failing due test failure in API Rate Limit

2013-12-10 Thread Rayees Namathponnan
Hi All,

4.3 build failing,  due to test failure in "API Rate Limit";  someone please 
look this ?





[INFO]

[INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ 
cloud-plugin-api-limit-account-based ---

[INFO] Compiling 4 source files to 
/root/jenkins/build/workspace/ASF_Repo-Marvin-Build/plugins/api/rate-limit/target/test-classes

[INFO]

[INFO] --- maven-surefire-plugin:2.12:test (default-test) @ 
cloud-plugin-api-limit-account-based ---

[INFO] Surefire report directory: 
/root/jenkins/build/workspace/ASF_Repo-Marvin-Build/plugins/api/rate-limit/target/surefire-reports



---

 T E S T S

---

Running org.apache.cloudstack.ratelimit.ApiRateLimitTest

log4j:WARN No appenders could be found for logger 
(net.sf.ehcache.config.ConfigurationFactory).

log4j:WARN Please initialize the log4j system properly.

log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more 
info.

Tests run: 7, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 3.439 sec <<< 
FAILURE!



Results :



Failed tests:   
verifySearchCounter(org.apache.cloudstack.ratelimit.ApiRateLimitTest): 
apiIssued is incorrect expected:<5> but was:<0>



Tests run: 7, Failures: 1, Errors: 0, Skipped: 0



[INFO] 




Regards,
Rayees


Re: 4.3 build failing due test failure in API Rate Limit

2013-12-10 Thread Min Chen
That test I put in about one year ago, since then nothing has been
changed. Strange why is it suddenly broken. I will try myself to see.

Thanks
-min

On 12/10/13 2:21 PM, "Rayees Namathponnan"
 wrote:

>Hi All,
>
>4.3 build failing,  due to test failure in "API Rate Limit";  someone
>please look this ?
>
>
>
>
>
>[INFO]
>
>[INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile)
>@ cloud-plugin-api-limit-account-based ---
>
>[INFO] Compiling 4 source files to
>/root/jenkins/build/workspace/ASF_Repo-Marvin-Build/plugins/api/rate-limit
>/target/test-classes
>
>[INFO]
>
>[INFO] --- maven-surefire-plugin:2.12:test (default-test) @
>cloud-plugin-api-limit-account-based ---
>
>[INFO] Surefire report directory:
>/root/jenkins/build/workspace/ASF_Repo-Marvin-Build/plugins/api/rate-limit
>/target/surefire-reports
>
>
>
>---
>
> T E S T S
>
>---
>
>Running org.apache.cloudstack.ratelimit.ApiRateLimitTest
>
>log4j:WARN No appenders could be found for logger
>(net.sf.ehcache.config.ConfigurationFactory).
>
>log4j:WARN Please initialize the log4j system properly.
>
>log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for
>more info.
>
>Tests run: 7, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 3.439 sec
><<< FAILURE!
>
>
>
>Results :
>
>
>
>Failed tests:   
>verifySearchCounter(org.apache.cloudstack.ratelimit.ApiRateLimitTest):
>apiIssued is incorrect expected:<5> but was:<0>
>
>
>
>Tests run: 7, Failures: 1, Errors: 0, Skipped: 0
>
>
>
>[INFO] 
>
>
>
>
>
>Regards,
>Rayees



Re: 4.3 build failing due test failure in API Rate Limit

2013-12-10 Thread Min Chen
Rayees, I just built latest 4.3 on my laptop using "mvn clean install
-Psystemvm", it works fine.

Thanks
-min

On 12/10/13 2:31 PM, "Min Chen"  wrote:

>That test I put in about one year ago, since then nothing has been
>changed. Strange why is it suddenly broken. I will try myself to see.
>
>Thanks
>-min
>
>On 12/10/13 2:21 PM, "Rayees Namathponnan"
> wrote:
>
>>Hi All,
>>
>>4.3 build failing,  due to test failure in "API Rate Limit";  someone
>>please look this ?
>>
>>
>>
>>
>>
>>[INFO]
>>
>>[INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile)
>>@ cloud-plugin-api-limit-account-based ---
>>
>>[INFO] Compiling 4 source files to
>>/root/jenkins/build/workspace/ASF_Repo-Marvin-Build/plugins/api/rate-limi
>>t
>>/target/test-classes
>>
>>[INFO]
>>
>>[INFO] --- maven-surefire-plugin:2.12:test (default-test) @
>>cloud-plugin-api-limit-account-based ---
>>
>>[INFO] Surefire report directory:
>>/root/jenkins/build/workspace/ASF_Repo-Marvin-Build/plugins/api/rate-limi
>>t
>>/target/surefire-reports
>>
>>
>>
>>---
>>
>> T E S T S
>>
>>---
>>
>>Running org.apache.cloudstack.ratelimit.ApiRateLimitTest
>>
>>log4j:WARN No appenders could be found for logger
>>(net.sf.ehcache.config.ConfigurationFactory).
>>
>>log4j:WARN Please initialize the log4j system properly.
>>
>>log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for
>>more info.
>>
>>Tests run: 7, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 3.439 sec
>><<< FAILURE!
>>
>>
>>
>>Results :
>>
>>
>>
>>Failed tests:   
>>verifySearchCounter(org.apache.cloudstack.ratelimit.ApiRateLimitTest):
>>apiIssued is incorrect expected:<5> but was:<0>
>>
>>
>>
>>Tests run: 7, Failures: 1, Errors: 0, Skipped: 0
>>
>>
>>
>>[INFO] 
>>
>>
>>
>>
>>
>>Regards,
>>Rayees
>



RE: 4.3 build failing due test failure in API Rate Limit

2013-12-10 Thread Rayees Namathponnan
Re-created the build;   build completed successfully.

Not sure, what happened last time;  Thanks Min.

Regards,
Rayees 

-Original Message-
From: Min Chen [mailto:min.c...@citrix.com] 
Sent: Tuesday, December 10, 2013 2:37 PM
To: dev@cloudstack.apache.org
Subject: Re: 4.3 build failing due test failure in API Rate Limit 

Rayees, I just built latest 4.3 on my laptop using "mvn clean install 
-Psystemvm", it works fine.

Thanks
-min

On 12/10/13 2:31 PM, "Min Chen"  wrote:

>That test I put in about one year ago, since then nothing has been 
>changed. Strange why is it suddenly broken. I will try myself to see.
>
>Thanks
>-min
>
>On 12/10/13 2:21 PM, "Rayees Namathponnan"
> wrote:
>
>>Hi All,
>>
>>4.3 build failing,  due to test failure in "API Rate Limit";  someone 
>>please look this ?
>>
>>
>>
>>
>>
>>[INFO]
>>
>>[INFO] --- maven-compiler-plugin:2.5.1:testCompile 
>>(default-testCompile) @ cloud-plugin-api-limit-account-based ---
>>
>>[INFO] Compiling 4 source files to
>>/root/jenkins/build/workspace/ASF_Repo-Marvin-Build/plugins/api/rate-l
>>imi
>>t
>>/target/test-classes
>>
>>[INFO]
>>
>>[INFO] --- maven-surefire-plugin:2.12:test (default-test) @ 
>>cloud-plugin-api-limit-account-based ---
>>
>>[INFO] Surefire report directory:
>>/root/jenkins/build/workspace/ASF_Repo-Marvin-Build/plugins/api/rate-l
>>imi
>>t
>>/target/surefire-reports
>>
>>
>>
>>---
>>
>> T E S T S
>>
>>---
>>
>>Running org.apache.cloudstack.ratelimit.ApiRateLimitTest
>>
>>log4j:WARN No appenders could be found for logger 
>>(net.sf.ehcache.config.ConfigurationFactory).
>>
>>log4j:WARN Please initialize the log4j system properly.
>>
>>log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig 
>>for more info.
>>
>>Tests run: 7, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 3.439 
>>sec <<< FAILURE!
>>
>>
>>
>>Results :
>>
>>
>>
>>Failed tests:   
>>verifySearchCounter(org.apache.cloudstack.ratelimit.ApiRateLimitTest):
>>apiIssued is incorrect expected:<5> but was:<0>
>>
>>
>>
>>Tests run: 7, Failures: 1, Errors: 0, Skipped: 0
>>
>>
>>
>>[INFO]
>>--
>>--
>>
>>
>>
>>
>>Regards,
>>Rayees
>



Re: Blocker bug: can't create the volumes on Xen 6.2.0 on the latest 4.3

2013-12-10 Thread Alena Prokharchyk
Anthony, just wanted to confirm - this file should never get submitted to
the remote asf repo, right? In this case I will add it to the .gitignore
as well.

-Alena.

On 12/9/13, 6:36 PM, "Anthony Xu"  wrote:

>Always put vhd-util in your cloudstack source tree,
>scripts/vm/hypervisor/xenserver/
>
>
>Anthony
>
>-Original Message-
>From: Alena Prokharchyk
>Sent: Monday, December 09, 2013 4:49 PM
>To: dev@cloudstack.apache.org; Anthony Xu
>Subject: Re: Blocker bug: can't create the volumes on Xen 6.2.0 on the
>latest 4.3
>
>That helped, thank you Min.
>
>It would be nice to get a notification email next time from the person
>making this kind of changes to save everybody else’s time on debugging.
>
>-Alena.
>
>
>
>On 12/9/13, 4:02 PM, "Min Chen"  wrote:
>
>>Is this happening in your ssvm startup? If so, go to your xen host,
>>/opt/cloud/bin folder, check if you have vhd-util there. Not sure why,
>>it seems that we have changed the directory from previous
>>/opt/xensources to /opt/cloud. I ran into a similar problem in starting
>>up ssvm.
>>
>>Thanks
>>-min
>>
>>On 12/9/13 3:58 PM, "Alena Prokharchyk" 
>>wrote:
>>
>>>There is some regression bug on the latest 4.3 ­ volumes creation
>>>fails on xen 6.2.0. Steps made:
>>>
>>>1) Deployed CS code and redeployed the DB
>>>2) Added xen host to the CS
>>>3) VDI creation fails with generic error message
>>>
>>>
>>>2013-12-09 15:56:44,629 WARN  [c.c.h.x.r.XenServerStorageProcessor]
>>>(DirectAgent-2:ctx-2d667640) can not create vdi in sr
>>>734481f8-fee3-59d9-20e8-dbe3b8124a78
>>>2013-12-09 15:56:44,629 WARN  [c.c.h.x.r.XenServerStorageProcessor]
>>>(DirectAgent-2:ctx-2d667640) Catch Exception
>>>com.cloud.utils.exception.CloudRuntimeException for template +  due to
>>>com.cloud.utils.exception.CloudRuntimeException: can not create vdi in
>>>sr
>>>734481f8-fee3-59d9-20e8-dbe3b8124a78
>>>com.cloud.utils.exception.CloudRuntimeException: can not create vdi in
>>>sr
>>>734481f8-fee3-59d9-20e8-dbe3b8124a78
>>>
>>>Anthony, I wonder if it can be related to your latest changes. Can you
>>>please take a look as its a blocker.
>>>
>>>-Alena.
>>
>



RE: Blocker bug: can't create the volumes on Xen 6.2.0 on the latest 4.3

2013-12-10 Thread Anthony Xu
Correct,

Anthony

-Original Message-
From: Alena Prokharchyk 
Sent: Tuesday, December 10, 2013 4:39 PM
To: Anthony Xu; dev@cloudstack.apache.org
Subject: Re: Blocker bug: can't create the volumes on Xen 6.2.0 on the latest 
4.3

Anthony, just wanted to confirm - this file should never get submitted to the 
remote asf repo, right? In this case I will add it to the .gitignore as well.

-Alena.

On 12/9/13, 6:36 PM, "Anthony Xu"  wrote:

>Always put vhd-util in your cloudstack source tree, 
>scripts/vm/hypervisor/xenserver/
>
>
>Anthony
>
>-Original Message-
>From: Alena Prokharchyk
>Sent: Monday, December 09, 2013 4:49 PM
>To: dev@cloudstack.apache.org; Anthony Xu
>Subject: Re: Blocker bug: can't create the volumes on Xen 6.2.0 on the 
>latest 4.3
>
>That helped, thank you Min.
>
>It would be nice to get a notification email next time from the person 
>making this kind of changes to save everybody else's time on debugging.
>
>-Alena.
>
>
>
>On 12/9/13, 4:02 PM, "Min Chen"  wrote:
>
>>Is this happening in your ssvm startup? If so, go to your xen host, 
>>/opt/cloud/bin folder, check if you have vhd-util there. Not sure why, 
>>it seems that we have changed the directory from previous 
>>/opt/xensources to /opt/cloud. I ran into a similar problem in 
>>starting up ssvm.
>>
>>Thanks
>>-min
>>
>>On 12/9/13 3:58 PM, "Alena Prokharchyk" 
>>wrote:
>>
>>>There is some regression bug on the latest 4.3  volumes creation 
>>>fails on xen 6.2.0. Steps made:
>>>
>>>1) Deployed CS code and redeployed the DB
>>>2) Added xen host to the CS
>>>3) VDI creation fails with generic error message
>>>
>>>
>>>2013-12-09 15:56:44,629 WARN  [c.c.h.x.r.XenServerStorageProcessor]
>>>(DirectAgent-2:ctx-2d667640) can not create vdi in sr
>>>734481f8-fee3-59d9-20e8-dbe3b8124a78
>>>2013-12-09 15:56:44,629 WARN  [c.c.h.x.r.XenServerStorageProcessor]
>>>(DirectAgent-2:ctx-2d667640) Catch Exception 
>>>com.cloud.utils.exception.CloudRuntimeException for template +  due 
>>>to
>>>com.cloud.utils.exception.CloudRuntimeException: can not create vdi 
>>>in sr
>>>734481f8-fee3-59d9-20e8-dbe3b8124a78
>>>com.cloud.utils.exception.CloudRuntimeException: can not create vdi 
>>>in sr
>>>734481f8-fee3-59d9-20e8-dbe3b8124a78
>>>
>>>Anthony, I wonder if it can be related to your latest changes. Can 
>>>you please take a look as its a blocker.
>>>
>>>-Alena.
>>
>



RE: [VOTE] 2rd round of voting for ASF 4.2.1 third RC

2013-12-10 Thread Anthony Xu
My best guess is you don't have vhd-util in your management server.

Check if vhd-util exists in /opt/cloud/bin in your XS host, if not,  you need 
to do following,
1. make sure vhd-util is downloaded in your management server
2. clear XS host tag, execute following command in each XS
  Xe host-param-clear host-uuid= param-name=tags
3. restart management server



Anthony

-Original Message-
From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] 
Sent: Tuesday, December 10, 2013 2:09 PM
To: dev
Subject: Re: [VOTE] 2rd round of voting for ASF 4.2.1 third RC

I am going to tentatively -1 this one. There has changed something since last 
rc that makes this one not start a ssvm in my sanity check env after creating a 
zone. I have not pinned down the culprit commit yet so I will keep looking till 
I can be sure as to what is wrong. I have been going back and forth between the 
two versions and commits in the middle and the problem is reproducible it seems.

The new rc throws an insufficient capacity exception and then null pointers as 
it tries to start the console proxy. In the same env with the same config and 
zone spec, the old rc works.

will let you know as I find out more,
Daan

On Tue, Dec 10, 2013 at 2:21 PM, Abhinandan Prateek 
 wrote:
> The vote is open till 13 Dec 2013.
>
> On 10/12/13 6:28 pm, "Abhinandan Prateek" 
> 
> wrote:
>
>>Hi,
>>
>>   This release candidate addresses the following additional issues 
>>reported by community:
>>
>>1. CLOUDSTACK-5145 : ListNetworkACL API should list ACLs owned by the 
>>user only 2. CLOUDSTACK-5214 : 4.2.1 upgrade is broken 3. The CHANGES 
>>file has been fixed to mark some important fixes as such, instead of 
>>new features which they are not.
>>
>>The details of this RC are as:
>>
>>https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=
>>refs
>>/
>>heads/4.2
>>commit: 43350d64ce66e366f08a9fa13ad09bca462b66da
>>
>>List of changes are available in Release Notes, a summary can be 
>>accessed in CHANGES file:
>>https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=blob_plain;
>>f=CH
>>A
>>NGES;hb=4.2
>>
>>Source release revision 3865 (checksums and signatures are available 
>>at the same location):
>>https://dist.apache.org/repos/dist/dev/cloudstack/4.2.1/
>>  **note that for release notes separate email will go out subsequently.
>>
>>PGP release keys (signed using RSA Key ID = 42443AA1):
>>https://dist.apache.org/repos/dist/release/cloudstack/KEYS
>>
>>Vote will be open for 72 hours (until 12/05 End of day PST).
>>
>>For sanity in tallying the vote, can PMC members please be sure to 
>>indicate "(binding)" with their vote?
>>
>>[ ] +1  approve
>>[ ] +0  no opinion
>>[ ] -1  disapprove (and reason why)
>>
>>
>>
>


RE: Documentation Question

2013-12-10 Thread Radhika Puthiyetath
Yes, I am checking into master.

-Original Message-
From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com] 
Sent: Wednesday, December 11, 2013 3:48 AM
To: dev@cloudstack.apache.org
Subject: Re: Documentation Question

Hi,

I know we are having a discussion about changing the way we do docs in 4.3, but 
- for the time being - I was making a few changes locally from this
repo:

https://git-wip-us.apache.org/repos/asf/cloudstack-docs.git

I notice there are only the 4.2 and master branches.

I assume master is 4.3 in this repo?

Thanks!


On Thu, Dec 5, 2013 at 10:02 PM, Mike Tutkowski < mike.tutkow...@solidfire.com> 
wrote:

> Thanks!
>
>
> On Thu, Dec 5, 2013 at 9:39 PM, Radhika Puthiyetath < 
> radhika.puthiyet...@citrix.com> wrote:
>
>> Yes. It has been moved to
>> http://git-wip-us.apache.org/repos/asf/cloudstack-docs/repo
>>
>>
>>
>> -Original Message-
>> From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
>> Sent: Friday, December 06, 2013 12:20 AM
>> To: dev@cloudstack.apache.org
>> Subject: Documentation Question
>>
>> Hi,
>>
>> It's been a while since I've needed to update documentation for 
>> CloudStack's Admin and Installation Guides.
>>
>> I know at some point there was talk of breaking documentation out 
>> into another repo.
>>
>> Can someone refresh my memory as to whether that new repo was created 
>> or if we decided to keep documentation in the same place it was 
>> located for 4.2?
>>
>> Thanks!
>>
>> --
>> *Mike Tutkowski*
>> *Senior CloudStack Developer, SolidFire Inc.*
>> e: mike.tutkow...@solidfire.com
>> o: 303.746.7302
>> Advancing the way the world uses the
>> cloud
>> *(tm)*
>>
>
>
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the 
> cloud
> *(tm)*
>



--
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloud
*(tm)*


[Update]test matrix job failures

2013-12-10 Thread Srikanteswararao Talluri
Test matrix job in j.b.a.c was failing because of recent changes that are 
required to marvin config file. I fixed the config now. Since all the 
deployment scripts are moved to tools/marvin/marvin/misc/build/ folder from 
github, I will point the job to pick up the deployment scripts from the same.

Thanks,
~Talluri




Re: [VOTE] 2rd round of voting for ASF 4.2.1 third RC

2013-12-10 Thread David Nalley
On Tue, Dec 10, 2013 at 9:18 PM, Anthony Xu  wrote:
> My best guess is you don't have vhd-util in your management server.
>
> Check if vhd-util exists in /opt/cloud/bin in your XS host, if not,  you need 
> to do following,
> 1. make sure vhd-util is downloaded in your management server
> 2. clear XS host tag, execute following command in each XS
>   Xe host-param-clear host-uuid= param-name=tags
> 3. restart management server
>

We expect a sysadmin to touch every single hypervisor manually and run
this command?
Is this documented in the upgrade directions? Is it right in the
install instructions?
Why, for a bug fix release would we do something like change the
expected location of vhd-util on a XS host?

--David


Re: Documentation Question

2013-12-10 Thread Mike Tutkowski
Thanks

I was wondering if you understand what might be the problem here when I try
to build the docs:

mtutkowski-LT:cloudstack-docs mtutkowski$ publican build
--config=publican-all.cfg --formats=pdf --langs=en-US
Unable to retrieve URL: [file:/etc/xml/catalog] at
/opt/local/lib/perl5/site_perl/5.12.4/XML/Catalog.pm line 170.


On Tue, Dec 10, 2013 at 8:20 PM, Radhika Puthiyetath <
radhika.puthiyet...@citrix.com> wrote:

> Yes, I am checking into master.
>
> -Original Message-
> From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
> Sent: Wednesday, December 11, 2013 3:48 AM
> To: dev@cloudstack.apache.org
> Subject: Re: Documentation Question
>
> Hi,
>
> I know we are having a discussion about changing the way we do docs in
> 4.3, but - for the time being - I was making a few changes locally from this
> repo:
>
> https://git-wip-us.apache.org/repos/asf/cloudstack-docs.git
>
> I notice there are only the 4.2 and master branches.
>
> I assume master is 4.3 in this repo?
>
> Thanks!
>
>
> On Thu, Dec 5, 2013 at 10:02 PM, Mike Tutkowski <
> mike.tutkow...@solidfire.com> wrote:
>
> > Thanks!
> >
> >
> > On Thu, Dec 5, 2013 at 9:39 PM, Radhika Puthiyetath <
> > radhika.puthiyet...@citrix.com> wrote:
> >
> >> Yes. It has been moved to
> >> http://git-wip-us.apache.org/repos/asf/cloudstack-docs/repo
> >>
> >>
> >>
> >> -Original Message-
> >> From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
> >> Sent: Friday, December 06, 2013 12:20 AM
> >> To: dev@cloudstack.apache.org
> >> Subject: Documentation Question
> >>
> >> Hi,
> >>
> >> It's been a while since I've needed to update documentation for
> >> CloudStack's Admin and Installation Guides.
> >>
> >> I know at some point there was talk of breaking documentation out
> >> into another repo.
> >>
> >> Can someone refresh my memory as to whether that new repo was created
> >> or if we decided to keep documentation in the same place it was
> >> located for 4.2?
> >>
> >> Thanks!
> >>
> >> --
> >> *Mike Tutkowski*
> >> *Senior CloudStack Developer, SolidFire Inc.*
> >> e: mike.tutkow...@solidfire.com
> >> o: 303.746.7302
> >> Advancing the way the world uses the
> >> cloud
> >> *(tm)*
> >>
> >
> >
> >
> > --
> > *Mike Tutkowski*
> > *Senior CloudStack Developer, SolidFire Inc.*
> > e: mike.tutkow...@solidfire.com
> > o: 303.746.7302
> > Advancing the way the world uses the
> > cloud
> > *(tm)*
> >
>
>
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the
> cloud
> *(tm)*
>



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloud
*™*


RE: Documentation Question

2013-12-10 Thread Radhika Puthiyetath
Try the following:

publican build --config=publican-adminguide.cfg --formats=test --langs=en-US
publican build --config=publican-installation.cfg --formats=test 
--langs=en-US


Let me pull your changes and try from my end.


-Original Message-
From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com] 
Sent: Wednesday, December 11, 2013 10:24 AM
To: dev@cloudstack.apache.org
Subject: Re: Documentation Question

Thanks

I was wondering if you understand what might be the problem here when I try to 
build the docs:

mtutkowski-LT:cloudstack-docs mtutkowski$ publican build 
--config=publican-all.cfg --formats=pdf --langs=en-US Unable to retrieve URL: 
[file:/etc/xml/catalog] at /opt/local/lib/perl5/site_perl/5.12.4/XML/Catalog.pm 
line 170.


On Tue, Dec 10, 2013 at 8:20 PM, Radhika Puthiyetath < 
radhika.puthiyet...@citrix.com> wrote:

> Yes, I am checking into master.
>
> -Original Message-
> From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
> Sent: Wednesday, December 11, 2013 3:48 AM
> To: dev@cloudstack.apache.org
> Subject: Re: Documentation Question
>
> Hi,
>
> I know we are having a discussion about changing the way we do docs in 
> 4.3, but - for the time being - I was making a few changes locally 
> from this
> repo:
>
> https://git-wip-us.apache.org/repos/asf/cloudstack-docs.git
>
> I notice there are only the 4.2 and master branches.
>
> I assume master is 4.3 in this repo?
>
> Thanks!
>
>
> On Thu, Dec 5, 2013 at 10:02 PM, Mike Tutkowski < 
> mike.tutkow...@solidfire.com> wrote:
>
> > Thanks!
> >
> >
> > On Thu, Dec 5, 2013 at 9:39 PM, Radhika Puthiyetath < 
> > radhika.puthiyet...@citrix.com> wrote:
> >
> >> Yes. It has been moved to
> >> http://git-wip-us.apache.org/repos/asf/cloudstack-docs/repo
> >>
> >>
> >>
> >> -Original Message-
> >> From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
> >> Sent: Friday, December 06, 2013 12:20 AM
> >> To: dev@cloudstack.apache.org
> >> Subject: Documentation Question
> >>
> >> Hi,
> >>
> >> It's been a while since I've needed to update documentation for 
> >> CloudStack's Admin and Installation Guides.
> >>
> >> I know at some point there was talk of breaking documentation out 
> >> into another repo.
> >>
> >> Can someone refresh my memory as to whether that new repo was 
> >> created or if we decided to keep documentation in the same place it 
> >> was located for 4.2?
> >>
> >> Thanks!
> >>
> >> --
> >> *Mike Tutkowski*
> >> *Senior CloudStack Developer, SolidFire Inc.*
> >> e: mike.tutkow...@solidfire.com
> >> o: 303.746.7302
> >> Advancing the way the world uses the 
> >> cloud
> >> *(tm)*
> >>
> >
> >
> >
> > --
> > *Mike Tutkowski*
> > *Senior CloudStack Developer, SolidFire Inc.*
> > e: mike.tutkow...@solidfire.com
> > o: 303.746.7302
> > Advancing the way the world uses the 
> > cloud
> > *(tm)*
> >
>
>
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the
> cloud
> *(tm)*
>



--
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloud
*(tm)*


Re: Documentation Question

2013-12-10 Thread Mike Tutkowski
Unfortunately got the same error message:

mtutkowski-LT:cloudstack-docs mtutkowski$ publican build
--config=publican-adminguide.cfg --formats=test --langs=en-US
Unable to retrieve URL: [file:/etc/xml/catalog] at
/opt/local/lib/perl5/site_perl/5.12.4/XML/Catalog.pm line 170.


On Tue, Dec 10, 2013 at 10:00 PM, Radhika Puthiyetath <
radhika.puthiyet...@citrix.com> wrote:

> Try the following:
>
> publican build --config=publican-adminguide.cfg --formats=test
> --langs=en-US
> publican build --config=publican-installation.cfg --formats=test
> --langs=en-US
>
>
> Let me pull your changes and try from my end.
>
>
> -Original Message-
> From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
> Sent: Wednesday, December 11, 2013 10:24 AM
> To: dev@cloudstack.apache.org
> Subject: Re: Documentation Question
>
> Thanks
>
> I was wondering if you understand what might be the problem here when I
> try to build the docs:
>
> mtutkowski-LT:cloudstack-docs mtutkowski$ publican build
> --config=publican-all.cfg --formats=pdf --langs=en-US Unable to retrieve
> URL: [file:/etc/xml/catalog] at
> /opt/local/lib/perl5/site_perl/5.12.4/XML/Catalog.pm line 170.
>
>
> On Tue, Dec 10, 2013 at 8:20 PM, Radhika Puthiyetath <
> radhika.puthiyet...@citrix.com> wrote:
>
> > Yes, I am checking into master.
> >
> > -Original Message-
> > From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
> > Sent: Wednesday, December 11, 2013 3:48 AM
> > To: dev@cloudstack.apache.org
> > Subject: Re: Documentation Question
> >
> > Hi,
> >
> > I know we are having a discussion about changing the way we do docs in
> > 4.3, but - for the time being - I was making a few changes locally
> > from this
> > repo:
> >
> > https://git-wip-us.apache.org/repos/asf/cloudstack-docs.git
> >
> > I notice there are only the 4.2 and master branches.
> >
> > I assume master is 4.3 in this repo?
> >
> > Thanks!
> >
> >
> > On Thu, Dec 5, 2013 at 10:02 PM, Mike Tutkowski <
> > mike.tutkow...@solidfire.com> wrote:
> >
> > > Thanks!
> > >
> > >
> > > On Thu, Dec 5, 2013 at 9:39 PM, Radhika Puthiyetath <
> > > radhika.puthiyet...@citrix.com> wrote:
> > >
> > >> Yes. It has been moved to
> > >> http://git-wip-us.apache.org/repos/asf/cloudstack-docs/repo
> > >>
> > >>
> > >>
> > >> -Original Message-
> > >> From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
> > >> Sent: Friday, December 06, 2013 12:20 AM
> > >> To: dev@cloudstack.apache.org
> > >> Subject: Documentation Question
> > >>
> > >> Hi,
> > >>
> > >> It's been a while since I've needed to update documentation for
> > >> CloudStack's Admin and Installation Guides.
> > >>
> > >> I know at some point there was talk of breaking documentation out
> > >> into another repo.
> > >>
> > >> Can someone refresh my memory as to whether that new repo was
> > >> created or if we decided to keep documentation in the same place it
> > >> was located for 4.2?
> > >>
> > >> Thanks!
> > >>
> > >> --
> > >> *Mike Tutkowski*
> > >> *Senior CloudStack Developer, SolidFire Inc.*
> > >> e: mike.tutkow...@solidfire.com
> > >> o: 303.746.7302
> > >> Advancing the way the world uses the
> > >> cloud
> > >> *(tm)*
> > >>
> > >
> > >
> > >
> > > --
> > > *Mike Tutkowski*
> > > *Senior CloudStack Developer, SolidFire Inc.*
> > > e: mike.tutkow...@solidfire.com
> > > o: 303.746.7302
> > > Advancing the way the world uses the
> > > cloud
> > > *(tm)*
> > >
> >
> >
> >
> > --
> > *Mike Tutkowski*
> > *Senior CloudStack Developer, SolidFire Inc.*
> > e: mike.tutkow...@solidfire.com
> > o: 303.746.7302
> > Advancing the way the world uses the
> > cloud
> > *(tm)*
> >
>
>
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the
> cloud
> *(tm)*
>



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloud
*™*


Re: Documentation Question

2013-12-10 Thread Mike Tutkowski
This is just building the current docs without my changes (and my changes
are quite minor at this point).


On Tue, Dec 10, 2013 at 10:05 PM, Mike Tutkowski <
mike.tutkow...@solidfire.com> wrote:

> Unfortunately got the same error message:
>
> mtutkowski-LT:cloudstack-docs mtutkowski$ publican build
> --config=publican-adminguide.cfg --formats=test --langs=en-US
> Unable to retrieve URL: [file:/etc/xml/catalog] at
> /opt/local/lib/perl5/site_perl/5.12.4/XML/Catalog.pm line 170.
>
>
> On Tue, Dec 10, 2013 at 10:00 PM, Radhika Puthiyetath <
> radhika.puthiyet...@citrix.com> wrote:
>
>> Try the following:
>>
>> publican build --config=publican-adminguide.cfg --formats=test
>> --langs=en-US
>> publican build --config=publican-installation.cfg --formats=test
>> --langs=en-US
>>
>>
>> Let me pull your changes and try from my end.
>>
>>
>> -Original Message-
>> From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
>> Sent: Wednesday, December 11, 2013 10:24 AM
>> To: dev@cloudstack.apache.org
>> Subject: Re: Documentation Question
>>
>> Thanks
>>
>> I was wondering if you understand what might be the problem here when I
>> try to build the docs:
>>
>> mtutkowski-LT:cloudstack-docs mtutkowski$ publican build
>> --config=publican-all.cfg --formats=pdf --langs=en-US Unable to retrieve
>> URL: [file:/etc/xml/catalog] at
>> /opt/local/lib/perl5/site_perl/5.12.4/XML/Catalog.pm line 170.
>>
>>
>> On Tue, Dec 10, 2013 at 8:20 PM, Radhika Puthiyetath <
>> radhika.puthiyet...@citrix.com> wrote:
>>
>> > Yes, I am checking into master.
>> >
>> > -Original Message-
>> > From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
>> > Sent: Wednesday, December 11, 2013 3:48 AM
>> > To: dev@cloudstack.apache.org
>> > Subject: Re: Documentation Question
>> >
>> > Hi,
>> >
>> > I know we are having a discussion about changing the way we do docs in
>> > 4.3, but - for the time being - I was making a few changes locally
>> > from this
>> > repo:
>> >
>> > https://git-wip-us.apache.org/repos/asf/cloudstack-docs.git
>> >
>> > I notice there are only the 4.2 and master branches.
>> >
>> > I assume master is 4.3 in this repo?
>> >
>> > Thanks!
>> >
>> >
>> > On Thu, Dec 5, 2013 at 10:02 PM, Mike Tutkowski <
>> > mike.tutkow...@solidfire.com> wrote:
>> >
>> > > Thanks!
>> > >
>> > >
>> > > On Thu, Dec 5, 2013 at 9:39 PM, Radhika Puthiyetath <
>> > > radhika.puthiyet...@citrix.com> wrote:
>> > >
>> > >> Yes. It has been moved to
>> > >> http://git-wip-us.apache.org/repos/asf/cloudstack-docs/repo
>> > >>
>> > >>
>> > >>
>> > >> -Original Message-
>> > >> From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
>> > >> Sent: Friday, December 06, 2013 12:20 AM
>> > >> To: dev@cloudstack.apache.org
>> > >> Subject: Documentation Question
>> > >>
>> > >> Hi,
>> > >>
>> > >> It's been a while since I've needed to update documentation for
>> > >> CloudStack's Admin and Installation Guides.
>> > >>
>> > >> I know at some point there was talk of breaking documentation out
>> > >> into another repo.
>> > >>
>> > >> Can someone refresh my memory as to whether that new repo was
>> > >> created or if we decided to keep documentation in the same place it
>> > >> was located for 4.2?
>> > >>
>> > >> Thanks!
>> > >>
>> > >> --
>> > >> *Mike Tutkowski*
>> > >> *Senior CloudStack Developer, SolidFire Inc.*
>> > >> e: mike.tutkow...@solidfire.com
>> > >> o: 303.746.7302
>> > >> Advancing the way the world uses the
>> > >> cloud
>> > >> *(tm)*
>> > >>
>> > >
>> > >
>> > >
>> > > --
>> > > *Mike Tutkowski*
>> > > *Senior CloudStack Developer, SolidFire Inc.*
>> > > e: mike.tutkow...@solidfire.com
>> > > o: 303.746.7302
>> > > Advancing the way the world uses the
>> > > cloud
>> > > *(tm)*
>> > >
>> >
>> >
>> >
>> > --
>> > *Mike Tutkowski*
>> > *Senior CloudStack Developer, SolidFire Inc.*
>> > e: mike.tutkow...@solidfire.com
>> > o: 303.746.7302
>> > Advancing the way the world uses the
>> > cloud
>> > *(tm)*
>> >
>>
>>
>>
>> --
>> *Mike Tutkowski*
>> *Senior CloudStack Developer, SolidFire Inc.*
>> e: mike.tutkow...@solidfire.com
>> o: 303.746.7302
>> Advancing the way the world uses the
>> cloud
>> *(tm)*
>>
>
>
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the 
> cloud
> *™*
>



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloud
*™*


Re: Review Request 15875: https://issues.apache.org/jira/browse/CLOUDSTACK-5160

2013-12-10 Thread bharat kumar


> On Dec. 4, 2013, 2:06 p.m., daan Hoogland wrote:
> > Bharat, neither version 4 nor version 3 of your patch apply to master. Also 
> > I noted the ticket number in the commit comment changed from 5160 to 5161. 
> > Can you explain.

Hi Dann,

This change is already shipped to master, closing this review request. Also you 
are right that the ticket number changed.I have linked the bugs in jira. so 
that one can see both the issues for tracking purposes.

thanks,
Bharat.


- bharat


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15875/#review29732
---


On Dec. 3, 2013, 10:53 a.m., bharat kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15875/
> ---
> 
> (Updated Dec. 3, 2013, 10:53 a.m.)
> 
> 
> Review request for cloudstack, Jayapal Reddy and Koushik Das.
> 
> 
> Bugs: CLOUDSTACK-5160
> https://issues.apache.org/jira/browse/CLOUDSTACK-5160
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> use a map to specify the custom parameters in the deployvm api Instead of one 
> parameter for each.
> 
> https://issues.apache.org/jira/browse/CLOUDSTACK-5160
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/vm/UserVmService.java 6fc8b54 
>   api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java 3643f91 
>   
> engine/api/src/org/apache/cloudstack/engine/orchestration/service/VolumeOrchestrationService.java
>  ad957d5 
>   
> engine/api/src/org/apache/cloudstack/engine/service/api/OrchestrationService.java
>  8c58227 
>   engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java 
> 4e25493 
>   
> engine/orchestration/src/org/apache/cloudstack/engine/orchestration/CloudOrchestrator.java
>  5dd15ce 
>   
> engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java
>  71e8b7d 
>   server/src/com/cloud/vm/UserVmManagerImpl.java a16f51c 
> 
> Diff: https://reviews.apache.org/r/15875/diff/
> 
> 
> Testing
> ---
> 
> Tested on master.
> 
> 
> Thanks,
> 
> bharat kumar
> 
>



Re: Review Request 16122: CLOUDSTACK-4498 cherry picked from 4.2

2013-12-10 Thread bharat kumar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16122/
---

(Updated Dec. 11, 2013, 5:38 a.m.)


Review request for cloudstack and Jayapal Reddy.


Changes
---

rebased the patch with 4.3


Bugs: CLOUDSTACK-4498
https://issues.apache.org/jira/browse/CLOUDSTACK-4498


Repository: cloudstack-git


Description
---

 CLOUDSTACK-4498 we should not reserve memory and cpu for vmware VMs if the 
vmware.reserve.cpu and vmware.reserve.mem are set to false.


Diffs (updated)
-

  plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java 
eb3cb6b 
  
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
 d306b74 
  
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 69f1b74 

Diff: https://reviews.apache.org/r/16122/diff/


Testing
---

tested on master.


Thanks,

bharat kumar



RE: Documentation Question

2013-12-10 Thread Radhika Puthiyetath
I get a clean build. Some perl file (since it it searching for catalog.pm file) 
is missing . Not related to Publican.

-Original Message-
From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com] 
Sent: Wednesday, December 11, 2013 10:36 AM
To: dev@cloudstack.apache.org
Subject: Re: Documentation Question

This is just building the current docs without my changes (and my changes are 
quite minor at this point).


On Tue, Dec 10, 2013 at 10:05 PM, Mike Tutkowski < 
mike.tutkow...@solidfire.com> wrote:

> Unfortunately got the same error message:
>
> mtutkowski-LT:cloudstack-docs mtutkowski$ publican build 
> --config=publican-adminguide.cfg --formats=test --langs=en-US Unable 
> to retrieve URL: [file:/etc/xml/catalog] at 
> /opt/local/lib/perl5/site_perl/5.12.4/XML/Catalog.pm line 170.
>
>
> On Tue, Dec 10, 2013 at 10:00 PM, Radhika Puthiyetath < 
> radhika.puthiyet...@citrix.com> wrote:
>
>> Try the following:
>>
>> publican build --config=publican-adminguide.cfg --formats=test 
>> --langs=en-US
>> publican build --config=publican-installation.cfg 
>> --formats=test --langs=en-US
>>
>>
>> Let me pull your changes and try from my end.
>>
>>
>> -Original Message-
>> From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
>> Sent: Wednesday, December 11, 2013 10:24 AM
>> To: dev@cloudstack.apache.org
>> Subject: Re: Documentation Question
>>
>> Thanks
>>
>> I was wondering if you understand what might be the problem here when 
>> I try to build the docs:
>>
>> mtutkowski-LT:cloudstack-docs mtutkowski$ publican build 
>> --config=publican-all.cfg --formats=pdf --langs=en-US Unable to 
>> retrieve
>> URL: [file:/etc/xml/catalog] at
>> /opt/local/lib/perl5/site_perl/5.12.4/XML/Catalog.pm line 170.
>>
>>
>> On Tue, Dec 10, 2013 at 8:20 PM, Radhika Puthiyetath < 
>> radhika.puthiyet...@citrix.com> wrote:
>>
>> > Yes, I am checking into master.
>> >
>> > -Original Message-
>> > From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
>> > Sent: Wednesday, December 11, 2013 3:48 AM
>> > To: dev@cloudstack.apache.org
>> > Subject: Re: Documentation Question
>> >
>> > Hi,
>> >
>> > I know we are having a discussion about changing the way we do docs 
>> > in 4.3, but - for the time being - I was making a few changes 
>> > locally from this
>> > repo:
>> >
>> > https://git-wip-us.apache.org/repos/asf/cloudstack-docs.git
>> >
>> > I notice there are only the 4.2 and master branches.
>> >
>> > I assume master is 4.3 in this repo?
>> >
>> > Thanks!
>> >
>> >
>> > On Thu, Dec 5, 2013 at 10:02 PM, Mike Tutkowski < 
>> > mike.tutkow...@solidfire.com> wrote:
>> >
>> > > Thanks!
>> > >
>> > >
>> > > On Thu, Dec 5, 2013 at 9:39 PM, Radhika Puthiyetath < 
>> > > radhika.puthiyet...@citrix.com> wrote:
>> > >
>> > >> Yes. It has been moved to
>> > >> http://git-wip-us.apache.org/repos/asf/cloudstack-docs/repo
>> > >>
>> > >>
>> > >>
>> > >> -Original Message-
>> > >> From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
>> > >> Sent: Friday, December 06, 2013 12:20 AM
>> > >> To: dev@cloudstack.apache.org
>> > >> Subject: Documentation Question
>> > >>
>> > >> Hi,
>> > >>
>> > >> It's been a while since I've needed to update documentation for 
>> > >> CloudStack's Admin and Installation Guides.
>> > >>
>> > >> I know at some point there was talk of breaking documentation 
>> > >> out into another repo.
>> > >>
>> > >> Can someone refresh my memory as to whether that new repo was 
>> > >> created or if we decided to keep documentation in the same place 
>> > >> it was located for 4.2?
>> > >>
>> > >> Thanks!
>> > >>
>> > >> --
>> > >> *Mike Tutkowski*
>> > >> *Senior CloudStack Developer, SolidFire Inc.*
>> > >> e: mike.tutkow...@solidfire.com
>> > >> o: 303.746.7302
>> > >> Advancing the way the world uses the 
>> > >> cloud
>> > >> *(tm)*
>> > >>
>> > >
>> > >
>> > >
>> > > --
>> > > *Mike Tutkowski*
>> > > *Senior CloudStack Developer, SolidFire Inc.*
>> > > e: mike.tutkow...@solidfire.com
>> > > o: 303.746.7302
>> > > Advancing the way the world uses the 
>> > > cloud
>> > > *(tm)*
>> > >
>> >
>> >
>> >
>> > --
>> > *Mike Tutkowski*
>> > *Senior CloudStack Developer, SolidFire Inc.*
>> > e: mike.tutkow...@solidfire.com
>> > o: 303.746.7302
>> > Advancing the way the world uses the 
>> > cloud
>> > *(tm)*
>> >
>>
>>
>>
>> --
>> *Mike Tutkowski*
>> *Senior CloudStack Developer, SolidFire Inc.*
>> e: mike.tutkow...@solidfire.com
>> o: 303.746.7302
>> Advancing the way the world uses the
>> cloud
>> *(tm)*
>>
>
>
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the 
> cloud
> *(tm)*
>



--
*Mike Tutkowski*
*Senior 

Build failed in Jenkins: cloudstack-4.3-maven-build #119

2013-12-10 Thread jenkins
See 

Changes:

[jayapal] CLOUDSTACK-5244 Fixed issue with applying acl items of acl to private 
gateway

--
[...truncated 929 lines...]
[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Server 4.3.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ cloud-server ---
[INFO] Deleting 

 (includes = [**/*], excludes = [])
[INFO] Deleting 
 
(includes = [target, dist], excludes = [])
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ cloud-server 
---
[INFO] 
[INFO] --- maven-antrun-plugin:1.7:run (generate-resource) @ cloud-server ---
[INFO] Executing tasks

main:
 [copy] Copying 3 files to 

 [copy] Copying 1 file to 

[INFO] Executed tasks
[INFO] 
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ 
cloud-server ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 30 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ cloud-server 
---
[INFO] Compiling 349 source files to 

[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-server ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 29 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ 
cloud-server ---
[INFO] Compiling 75 source files to 

[INFO] 
[INFO] --- maven-surefire-plugin:2.12:test (default-test) @ cloud-server ---
[INFO] Surefire report directory: 


---
 T E S T S
---
Running 
org.apache.cloudstack.region.gslb.GlobalLoadBalancingRulesServiceImplTest
log4j:WARN No appenders could be found for logger 
(org.apache.cloudstack.region.gslb.GlobalLoadBalancingRulesServiceImplTest).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more 
info.
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.193 sec
Running org.apache.cloudstack.region.RegionManagerTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.036 sec
Running org.apache.cloudstack.service.ServiceOfferingVOTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.06 sec
Running org.apache.cloudstack.affinity.AffinityApiUnitTest
Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.591 sec
Running org.apache.cloudstack.privategw.AclOnPrivateGwTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.399 sec
Running org.apache.cloudstack.network.lb.CertServiceTest
Tests run: 15, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.584 sec
Running org.apache.cloudstack.network.lb.ApplicationLoadBalancerTest
Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.933 sec
Running org.apache.cloudstack.networkoffering.CreateNetworkOfferingTest
Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 8.994 sec
Running com.cloud.keystore.KeystoreTest
org.apache.cloudstack.api.response.UserVmResponse/null/{"id":"3","securitygroup":[],"nic":[],"tags":[],"affinitygroup":[]}
org.apache.cloudstack.api.response.AlertResponse/null/{"id":"100","description":"Hello"}
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.265 sec
Running com.cloud.server.ConfigurationServerImplTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.014 sec
Running com.cloud.event.EventControlsUnitTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.054 sec
Running com.cloud.resourcelimit.ResourceLimitManagerImplTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.001 sec
Running com.cloud.api.ApiDispatcherTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.021 sec
Running com.cloud.alert.AlertControlsUnitTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.015 sec
Running com.cloud.ha.KVMFencerTest
T

Re: Review Request 16122: CLOUDSTACK-4498 cherry picked from 4.2

2013-12-10 Thread bharat kumar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16122/
---

(Updated Dec. 11, 2013, 5:45 a.m.)


Review request for cloudstack and Jayapal Reddy.


Changes
---

rebased with master.


Bugs: CLOUDSTACK-4498
https://issues.apache.org/jira/browse/CLOUDSTACK-4498


Repository: cloudstack-git


Description
---

 CLOUDSTACK-4498 we should not reserve memory and cpu for vmware VMs if the 
vmware.reserve.cpu and vmware.reserve.mem are set to false.


Diffs (updated)
-

  plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java 
081c651 
  
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
 066a395 
  
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 e34d5e1 

Diff: https://reviews.apache.org/r/16122/diff/


Testing
---

tested on master.


Thanks,

bharat kumar



Jenkins build became unstable: build-master » Apache CloudStack Server #188

2013-12-10 Thread jenkins
See 




Jenkins build became unstable: build-master #188

2013-12-10 Thread jenkins
See 



Re: Review Request 16154: Fixed CLOUDSTACK-5423

2013-12-10 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16154/#review30178
---


Commit c2a41b565a781eca9a2dace1459925bd150b7b7b in branch refs/heads/4.2 from 
Santhosh Edukulla
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=c2a41b5 ]

CLOUDSTACK-5423: Fixed 5423

Conflicts:
tools/marvin/marvin/deployAndRun.py


- ASF Subversion and Git Services


On Dec. 10, 2013, 11:37 a.m., Santhosh Edukulla wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16154/
> ---
> 
> (Updated Dec. 10, 2013, 11:37 a.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-5423
> https://issues.apache.org/jira/browse/CLOUDSTACK-5423
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> 1. As part of recent changes to marvin, mentioned files requires some 
> changes. 
> 2. Some cleaning is as well required for these two files. Did clean up.
> 3. Did cleanup in deployAndRun and added proper flow for ease of 
> understanding.
> 4. Removed unwanted logging and used MarvinInit for initialization of Marvin.
> 5. Removed few unwanted loops and redundant code.
> 6. Renamed  TestCaseExecuteEngine.py -> tcExecuteEngine.py inline with other 
> naming convention for modules in Marvin
> 7. Added few codes and doc strings.
> 
> 
> Diffs
> -
> 
>   tools/marvin/marvin/TestCaseExecuteEngine.py f5af1fe 
>   tools/marvin/marvin/configGenerator.py 3f98aca 
>   tools/marvin/marvin/deployAndRun.py 8a758a1 
>   tools/marvin/marvin/tcExecuteEngine.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/16154/diff/
> 
> 
> Testing
> ---
> 
> Tested DeployDC and Running Few test case runs with deployAndRun.
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>



Re: Review Request 16085: Fixed an Issue reported by xen server team

2013-12-10 Thread Girish Shilamkar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16085/#review30179
---

Ship it!


Merged to 4.2-forward branch only.

- Girish Shilamkar


On Dec. 6, 2013, 4:53 p.m., Santhosh Edukulla wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16085/
> ---
> 
> (Updated Dec. 6, 2013, 4:53 p.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Added a temp time sleep fix for a start command. Applies only to 4.2-forward 
> branch.
> 
> 
> Diffs
> -
> 
>   test/integration/smoke/test_snapshots.py 06777e4 
>   test/integration/smoke/test_volumes.py b60b70e 
> 
> Diff: https://reviews.apache.org/r/16085/diff/
> 
> 
> Testing
> ---
> 
> No
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>



Jenkins build is still unstable: build-master #189

2013-12-10 Thread jenkins
See 



Jenkins build is still unstable: build-master » Apache CloudStack Server #189

2013-12-10 Thread jenkins
See 




Build failed in Jenkins: cloudstack-4.3-maven-build #120

2013-12-10 Thread jenkins
See 

Changes:

[aprateek] CLOUDSTACK-4916: Fixing the issue with DB HA when there are more 
than 2 db nodes (Issue was mysql DriverManager was returning salve db nodes on 
random basis which was causing issue)

--
[...truncated 929 lines...]
[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Server 4.3.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ cloud-server ---
[INFO] Deleting 

 (includes = [**/*], excludes = [])
[INFO] Deleting 
 
(includes = [target, dist], excludes = [])
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ cloud-server 
---
[INFO] 
[INFO] --- maven-antrun-plugin:1.7:run (generate-resource) @ cloud-server ---
[INFO] Executing tasks

main:
 [copy] Copying 3 files to 

 [copy] Copying 1 file to 

[INFO] Executed tasks
[INFO] 
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ 
cloud-server ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 30 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ cloud-server 
---
[INFO] Compiling 349 source files to 

[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-server ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 29 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ 
cloud-server ---
[INFO] Compiling 75 source files to 

[INFO] 
[INFO] --- maven-surefire-plugin:2.12:test (default-test) @ cloud-server ---
[INFO] Surefire report directory: 


---
 T E S T S
---
Running 
org.apache.cloudstack.region.gslb.GlobalLoadBalancingRulesServiceImplTest
log4j:WARN No appenders could be found for logger 
(org.apache.cloudstack.region.gslb.GlobalLoadBalancingRulesServiceImplTest).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more 
info.
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.1 sec
Running org.apache.cloudstack.region.RegionManagerTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.034 sec
Running org.apache.cloudstack.service.ServiceOfferingVOTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.073 sec
Running org.apache.cloudstack.affinity.AffinityApiUnitTest
Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.794 sec
Running org.apache.cloudstack.privategw.AclOnPrivateGwTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.155 sec
Running org.apache.cloudstack.network.lb.CertServiceTest
Tests run: 15, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.937 sec
Running org.apache.cloudstack.network.lb.ApplicationLoadBalancerTest
Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.657 sec
Running org.apache.cloudstack.networkoffering.CreateNetworkOfferingTest
Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 8.84 sec
Running com.cloud.keystore.KeystoreTest
org.apache.cloudstack.api.response.UserVmResponse/null/{"id":"3","securitygroup":[],"nic":[],"tags":[],"affinitygroup":[]}
org.apache.cloudstack.api.response.AlertResponse/null/{"id":"100","description":"Hello"}
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.266 sec
Running com.cloud.server.ConfigurationServerImplTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.051 sec
Running com.cloud.event.EventControlsUnitTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.156 sec
Running com.cloud.resourcelimit.ResourceLimitManagerImplTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec
Running com.cloud.api.ApiDispatcherTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.06 sec
Running com.cloud.alert.AlertControlsUnitTest
Tests run: 

Jenkins build is still unstable: build-master » Apache CloudStack Server #190

2013-12-10 Thread jenkins
See 




Jenkins build is still unstable: build-master #190

2013-12-10 Thread jenkins
See 



Re: Review Request 16122: CLOUDSTACK-4498 cherry picked from 4.2

2013-12-10 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16122/#review30180
---


Commit 903af43be45c5b0e215c3c7ca9ce3ac56692d213 in branch refs/heads/4.3 from 
Bharat Kumar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=903af43 ]

CLOUDSTACK-4498 Do not reserve memory and cpu for vmware VMs, if
the vmware.reserve.cpu and vmware.reserve.mem are set to false while not over 
committing.

Signed-off-by: Jayapal 


- ASF Subversion and Git Services


On Dec. 11, 2013, 5:45 a.m., bharat kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16122/
> ---
> 
> (Updated Dec. 11, 2013, 5:45 a.m.)
> 
> 
> Review request for cloudstack and Jayapal Reddy.
> 
> 
> Bugs: CLOUDSTACK-4498
> https://issues.apache.org/jira/browse/CLOUDSTACK-4498
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
>  CLOUDSTACK-4498 we should not reserve memory and cpu for vmware VMs if the 
> vmware.reserve.cpu and vmware.reserve.mem are set to false.
> 
> 
> Diffs
> -
> 
>   plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java 
> 081c651 
>   
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
>  066a395 
>   
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
>  e34d5e1 
> 
> Diff: https://reviews.apache.org/r/16122/diff/
> 
> 
> Testing
> ---
> 
> tested on master.
> 
> 
> Thanks,
> 
> bharat kumar
> 
>



Re: Review Request 16086: Added a temp sleep fix for vm start command

2013-12-10 Thread Girish Shilamkar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16086/#review30181
---

Ship it!


Committed to 4.2, 4.3 and master.

- Girish Shilamkar


On Dec. 6, 2013, 6:28 p.m., Santhosh Edukulla wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16086/
> ---
> 
> (Updated Dec. 6, 2013, 6:28 p.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Added a temporary time sleep fix post a restart command. Applies to 
> 4.2,master,4.3
> 
> Note: Has to clean other things as well and will do more cleaner way of 
> handling things.
> 
> 
> Diffs
> -
> 
>   test/integration/smoke/test_volumes.py 816ae03 
> 
> Diff: https://reviews.apache.org/r/16086/diff/
> 
> 
> Testing
> ---
> 
> No.
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>



Jenkins build is still unstable: build-master » Apache CloudStack Server #191

2013-12-10 Thread jenkins
See 




Jenkins build is back to normal : cloudstack-4.3-maven-build #121

2013-12-10 Thread jenkins
See 



Jenkins build is still unstable: build-master #191

2013-12-10 Thread jenkins
See