Review Request 13189: CLOUDSTACK-4001: Unable to deploy Windows server 2012 64 bit VM on xenserver 6.2.

2013-08-01 Thread Sanjay Tripathi

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13189/
---

Review request for cloudstack, Abhinandan Prateek and Devdeep Singh.


Bugs: CLOUDSTACK-4001


Repository: cloudstack-git


Description
---

CLOUDSTACK-4001: Unable to deploy Windows server 2012 64 bit VM on xenserver 6.2


Diffs
-

  
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixHelper.java 
0d93d83 

Diff: https://reviews.apache.org/r/13189/diff/


Testing
---

Verified the fix by deploying the Windows server 2012(64 bit) VM on XenServer 
6.2 successfully on local cloudstack setup.


Thanks,

Sanjay Tripathi



[ACS42][Request] CLOUDSTACK-4001

2013-08-01 Thread Sanjay Tripathi
Hi,

Request to review and commit this patch to 4.2 branch.

Review request:
https://reviews.apache.org/r/13189/

Ticket:
https://issues.apache.org/jira/browse/CLOUDSTACK-4001
(Unable to deploy Windows server 2012 64bit VM on XenServer 6.2)

--Sanjay


Re: [DISCUSS] Should we be releasing -beta releases?

2013-08-01 Thread Daan Hoogland
On Thu, Aug 1, 2013 at 12:46 AM, Musayev, Ilya  wrote:
> The reason why CloudSand was created, was to bring in urgently needed 
> features into stable version, such that on the next major upgrade to ACS, all 
> features work as expected and nothing should break.
This is the same that we have done. Except that we have put work into
CLOUDSTACK-1532 that was urgently needed internally at Schuberg
Philis. It is implemented in 4.1.1-SBP a private release. I have
ported it to master several times but testing and paralel development
on other network features have prevented it from being merged in
master.

> What features are we talking about?

I gues our focus is hastening our own development and not backporting.

regards,
Daan


Re: Review Request 12264: CLOUDSTACK-3351: Fix add cluster API to set right hypervisor type

2013-08-01 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12264/#review24425
---


Commit b4fe0252230e74d36f62679cd2a751f278edacc1 in branch refs/heads/4.2 from 
Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=b4fe025 ]

CLOUDSTACK-3351: Fix add cluster API to set right hypervisor type

Signed-off-by: Abhinandan Prateek 


- ASF Subversion and Git Services


On July 4, 2013, 8:40 a.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12264/
> ---
> 
> (Updated July 4, 2013, 8:40 a.m.)
> 
> 
> Review request for cloudstack and Abhinandan Prateek.
> 
> 
> Bugs: CLOUDSTACK-3351
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-3351: Fix add cluster API to set right hypervisor type
> In AddCluster API we validate Hypervisor type parameter even if it is case 
> insensitive. We should not put this case insensitive value in the DB which 
> may lead to mismatch with hypervisor type with other tables in DB leading to 
> failure of various DB queries.
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/resource/ResourceManagerImpl.java c6e8d7d 
> 
> Diff: https://reviews.apache.org/r/12264/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>



Re: Network Problem

2013-08-01 Thread Ahmad Emneina
Next thing to do would be to sniff the traffic... Where's it failing to 
traverse?

Ahmad

On Jul 31, 2013, at 6:40 AM, Thomas Schneider  
wrote:

> I disabled it.
> 
> Le 30/07/2013 17:58, Ahmad Emneina a écrit :
>> guest os firewall?
>> 
>> 
>> On Tue, Jul 30, 2013 at 8:14 AM, Thomas Schneider <
>> thomas.schnei...@euskill.com> wrote:
>> 
>>> Hi,
>>> 
>>> I created a Security Group that allow all traffic by default in both way.
>>> I can ssh to a VM, but when I install LAMP I can't reach the web server.
>>> Do you have an idea of the problem ?
>>> 
>>> Regards
>>> 
>>> 
>>> Le 30/07/2013 03:11, Jijun a écrit :
 Hi ,
 Basic Network will setup the security group, and it will deny all the
 inbound traffic and allow outbound traffic.
 
 you should manually add some ingress rules.
 
 offical document:
>>> http://cloudstack.apache.org/docs/en-US/Apache_CloudStack/4.0.2/html/Installation_Guide/security-groups.html
 
 
 On 07/30/2013 01:34 AM, Thomas Schneider wrote:
> Hello,
> 
> I have setup cloudstack and it work fine, I can launch VM etc...
> But the problem is I can only SSH to the VM from the host on which she
> is running.
> When I am in the vm I can ping exernal network and download package to
> setup lamp for example.
> 
> I'm in basic network mode
> My config is:
> 
> mgmt srv: 10.10.10.20
> host1: 10.10.10.30
> host2: 10.10.10.31
> nfs for storage 10.10.10.100
> 
> pod pool 10.10.10.110 - 150
> guest pool 10.10.10.200 -250
> 
> and my network config on the host in /etc/init.d/networking/interface
> is:
> ---
> auto p49p1
> iface p49p1 inet manual
> 
> auto cloudbr0
> iface cloudbr0 inet static
> bridge_ports p49p1
> address 10.10.10.31
> netmask 255.255.255.0
> network 10.10.10.0
> broadcast 10.10.10.255
> gateway 10.10.10.254
> # dns-* options are implemented by the resolvconf package, if
> installed
> dns-nameservers 10.1.1.2
> ---
> 
> I also with to use OpenVSwitch but I didn't found a lot of documentation
> for configuring in basic nework mode on ubuntu.
> 
> Tkanks for your Help.
> 
> Best Regards,
>>> 
>>> --
>>> *Thomas Schneider*
> 
> 
> -- 
> *Thomas Schneider*
> Directeur des Opérations
> Euskill SARL
> Web: www.euskill.com
> Mobile: +33 (0)6 19 26 47 76
> Mail: thomas.schnei...@euskill.com
> 5 rue de Phalsbourg
> F-67000 Strasbourg


Re: Review Request 13109: CLOUDSTACK-3594: Fixes related to affinity groups

2013-08-01 Thread Prasanna Santhanam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13109/#review24426
---



test/integration/component/test_affinity_groups.py


use utils.randomgen()



tools/marvin/marvin/integration/lib/base.py


For every API in base, just use the prefix verb before the Cloud resource 
as the name of the method. 

So createXxx, updateXxx, deleteXxx transforms into Xxx.create(), 
Xxx.update, Xxx.delete()

IOW, rename update_affinity_group to just update()




- Prasanna Santhanam


On July 31, 2013, 12:13 p.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13109/
> ---
> 
> (Updated July 31, 2013, 12:13 p.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fixed test case issues mentioned in issue 
> https://issues.apache.org/jira/browse/CLOUDSTACK-3594
> 
> Radom-ized affinity group name to avoid cascading test case failures stating 
> "unable to create affinity group due to affinity group with the same name 
> exists".
> 
> Included following 2 test suites which were not run in last build because 
> there was no decorator for the test cases.
> 1. TestListAffinityGroups
> 2. TestUpdateVMAffinityGroups
> 
> One test case in TestUpdateVMAffinityGroups is skipped, it's failing right 
> now. Will be fixed shortly.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_affinity_groups.py 3ecab6f 
>   tools/marvin/marvin/integration/lib/base.py b552aba 
> 
> Diff: https://reviews.apache.org/r/13109/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>



Re: Review Request 12185: Remove dependency on backport-util.concurrent, and just use built in classes

2013-08-01 Thread daan Hoogland

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12185/#review24427
---


I think you need to rework this. Jenkins can't apply your patch and build it.

- daan Hoogland


On June 29, 2013, 2:34 a.m., Dave Brosius wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12185/
> ---
> 
> (Updated June 29, 2013, 2:34 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> code relies on classes in backport-util-concurrent, when these classes are 
> now available in the jdk supported by cloudstack.
> 
> Just switch the imports to the built in classes.
> 
> 
> Diffs
> -
> 
>   api/test/org/apache/cloudstack/api/command/test/AddClusterCmdTest.java 
> 90759fe 
>   api/test/org/apache/cloudstack/api/command/test/AddHostCmdTest.java 531f511 
>   engine/schema/src/com/cloud/keystore/KeystoreDaoImpl.java 0ea97c7 
>   
> engine/storage/src/org/apache/cloudstack/storage/datastore/DataStoreManagerImpl.java
>  b92f92f 
>   
> engine/storage/src/org/apache/cloudstack/storage/image/db/TemplateDataStoreDaoImpl.java
>  362f7a6 
>   
> plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BareMetalResourceBase.java
>  d46048e 
>   
> plugins/network-elements/nicira-nvp/test/com/cloud/network/guru/NiciraNvpGuestNetworkGuruTest.java
>  0e4f8fd 
>   server/src/com/cloud/agent/manager/AgentManagerImpl.java b24a238 
>   server/src/com/cloud/configuration/ConfigurationManagerImpl.java 2089f82 
>   server/src/com/cloud/consoleproxy/ConsoleProxyBalanceAllocator.java 45f0faa 
>   server/src/com/cloud/network/security/SecurityGroupManagerImpl.java 1c189c4 
>   server/src/com/cloud/resourcelimit/ResourceLimitManagerImpl.java b5c060d 
>   server/src/com/cloud/server/ManagementServerImpl.java 40bc437 
>   tools/whisker/descriptor-for-packaging.xml 66099ae 
>   utils/src/com/cloud/utils/db/GenericDaoBase.java f0fc700 
>   utils/src/com/cloud/utils/storage/encoding/Decoder.java fe74a04 
>   utils/src/com/cloud/utils/xmlobject/XmlObject.java 67bb8ed 
>   vmware-base/src/com/cloud/hypervisor/vmware/mo/ClusterMO.java d112c34 
>   vmware-base/src/com/cloud/hypervisor/vmware/mo/DatacenterMO.java cabb60a 
>   vmware-base/src/com/cloud/hypervisor/vmware/mo/HostMO.java e7fd922 
>   vmware-base/src/com/cloud/hypervisor/vmware/mo/PerfManagerMO.java bb4fb56 
>   vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java 
> cf5ffde 
> 
> Diff: https://reviews.apache.org/r/12185/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dave Brosius
> 
>



Re: Review Request 13189: CLOUDSTACK-4001: Unable to deploy Windows server 2012 64 bit VM on xenserver 6.2.

2013-08-01 Thread Jenkins Cloudstack.org

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13189/#review24428
---


Review 13189 failed the build test : FAILURE
The url of build cloudstack-master-with-patch #99 is : 
http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/99/

- Jenkins Cloudstack.org


On Aug. 1, 2013, 7:54 a.m., Sanjay Tripathi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13189/
> ---
> 
> (Updated Aug. 1, 2013, 7:54 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Devdeep Singh.
> 
> 
> Bugs: CLOUDSTACK-4001
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-4001: Unable to deploy Windows server 2012 64 bit VM on xenserver 
> 6.2
> 
> 
> Diffs
> -
> 
>   
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixHelper.java
>  0d93d83 
> 
> Diff: https://reviews.apache.org/r/13189/diff/
> 
> 
> Testing
> ---
> 
> Verified the fix by deploying the Windows server 2012(64 bit) VM on XenServer 
> 6.2 successfully on local cloudstack setup.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>



Re: Review Request 13109: CLOUDSTACK-3594: Fixes related to affinity groups

2013-08-01 Thread Gaurav Aradhye


> On Aug. 1, 2013, 8:26 a.m., Prasanna Santhanam wrote:
> > tools/marvin/marvin/integration/lib/base.py, line 574
> > 
> >
> > For every API in base, just use the prefix verb before the Cloud 
> > resource as the name of the method. 
> > 
> > So createXxx, updateXxx, deleteXxx transforms into Xxx.create(), 
> > Xxx.update, Xxx.delete()
> > 
> > IOW, rename update_affinity_group to just update()
> > 
> >

Hi,

update_affinity_group function is present in VirtualMachine class, not in 
Affnitygroup. Hence full name.
As discussed, will keep this as it is.
Will upload new diff for utis.randomgen() function use.


- Gaurav


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13109/#review24426
---


On July 31, 2013, 12:13 p.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13109/
> ---
> 
> (Updated July 31, 2013, 12:13 p.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fixed test case issues mentioned in issue 
> https://issues.apache.org/jira/browse/CLOUDSTACK-3594
> 
> Radom-ized affinity group name to avoid cascading test case failures stating 
> "unable to create affinity group due to affinity group with the same name 
> exists".
> 
> Included following 2 test suites which were not run in last build because 
> there was no decorator for the test cases.
> 1. TestListAffinityGroups
> 2. TestUpdateVMAffinityGroups
> 
> One test case in TestUpdateVMAffinityGroups is skipped, it's failing right 
> now. Will be fixed shortly.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_affinity_groups.py 3ecab6f 
>   tools/marvin/marvin/integration/lib/base.py b552aba 
> 
> Diff: https://reviews.apache.org/r/13109/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>



Re: Review Request 12192: set the field 'state' rather than the unread parameter 'state', if the parameter is null

2013-08-01 Thread Sanjay Tripathi


> On July 2, 2013, 7:11 a.m., daan Hoogland wrote:
> > Your change seems fine.
> > 
> > Did you regression test it? Or did you solve a problem with it?
> 
> Dave Brosius wrote:
> Just noticed during code inspection

Dave, can you also open a ticket for this and mention your review request in 
the comment section of the ticket; it will help the community to track the 
issue.


- Sanjay


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12192/#review22650
---


On June 29, 2013, 9:08 p.m., Dave Brosius wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12192/
> ---
> 
> (Updated June 29, 2013, 9:08 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> code checks the parameter 'state' and if null, set it to Allocated, even 
> though that parameter is never accessed. Meant to set the field 'state'.
> 
> 
> Diffs
> -
> 
>   engine/schema/src/com/cloud/network/dao/NetworkVO.java 6580ea0 
> 
> Diff: https://reviews.apache.org/r/12192/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dave Brosius
> 
>



[Doc] Portable IP is Ready

2013-08-01 Thread Radhika Puthiyetath
Hi,

Portable IP documentation is ready for review. The doc is attached at 
https://issues.apache.org/jira/browse/CLOUDSTACK-3236

Please see section 15.22. Portable IPs (169), and provide your feedback.

Regards
-Radhika




[Doc] Deleting and Archiving Events and Alerts for Review

2013-08-01 Thread Radhika Puthiyetath
Hi,

Deleting and Archiving Events and documentation is ready for review. The doc is 
attached at https://issues.apache.org/jira/browse/CLOUDSTACK-1567.


Please see section 22.1.6. Deleting and Archiving Events and Alerts (223), and 
provide your feedback.

Regards
-Radhika




Re: [ACS42] Release Status Update: After Code Freeze Next Steps

2013-08-01 Thread Go Chiba
Thanks Animesh, I'll be checking open tasks too.


On Thu, Aug 1, 2013 at 2:49 AM, Animesh Chaturvedi <
animesh.chaturv...@citrix.com> wrote:

>
>
> > -Original Message-
> > From: Chip Childers [mailto:chip.child...@sungard.com]
> > Sent: Wednesday, July 31, 2013 8:44 AM
> > To: dev@cloudstack.apache.org
> > Subject: Re: [ACS42] Release Status Update: After Code Freeze Next Steps
> >
> > On Thu, Aug 01, 2013 at 12:41:16AM +0900, Go Chiba wrote:
> > > Does it already fixed all 4.2 docs?
> > > If yes, I'd like to update it to transifex to go ahead doc
> > globalization...
> >
> > I'm not sure.
> >
> > Animesh? Docs team?
> [Animesh>] I am  following up with doc team I see a bunch of doc sub tasks
> still open.
> >
> > >
> > >
> > > On Wed, Jul 31, 2013 at 11:20 PM, Chip Childers
> > > wrote:
> > >
> > > > On Wed, Jul 31, 2013 at 10:33:51AM +0530, Prasanna Santhanam wrote:
> > > > > On Tue, Jul 30, 2013 at 10:03:08PM +, Animesh Chaturvedi
> > wrote:
> > > > > >
> > > > > >
> > > > > > > -Original Message-
> > > > > > > From: Alex Huang [mailto:alex.hu...@citrix.com]
> > > > > > > Sent: Tuesday, July 30, 2013 2:06 PM
> > > > > > > To: dev@cloudstack.apache.org
> > > > > > > Subject: RE: [ACS42] Release Status Update: After Code Freeze
> > > > > > > Next
> > > > Steps
> > > > > > >
> > > > > > > > The best type of commit for keeping things clean is a
> > cherry-pick.
> > > > > > > > Merging into the release branch is messy to track as the RM.
> > > > > > > >
> > > > > > >
> > > > > > > That should be a rule for release branches after code freeze.
> > > > > > >
> > > > > > > --Alex
> > > > > > [Animesh>] Thanks for clarifying, we will follow that for 4.2
> > > > >
> > > > > Also can we do a git cherry-pick -x? It lists the original commit
> > > > > from which the cherry was picked. Without it git branch --contains
> > > > > on a commit id returns the wrong branch the commit was brought in
> > from.
> > > >
> > > > Ah...  smart idea!
> > > >
> > >
> > >
> > >
> > > --
> > > 千葉 豪  Go Chiba
> > > E-mail:go.ch...@gmail.com
>



-- 
千葉 豪  Go Chiba
E-mail:go.ch...@gmail.com


[Doc] GSLB is Ready

2013-08-01 Thread Radhika Puthiyetath
Hi,

GSLB documentation is ready for review. The doc is attached at 
https://issues.apache.org/jira/browse/CLOUDSTACK-893

Please see section 15.11. Global Server Load Balancing Support, and provide 
your feedback.

Regards
-Radhika




RE: [DISCUSS] maven dependencies...

2013-08-01 Thread Donal Lafferty
FYI, org.apache.commons.io.FileUtils was missing due to an incorrect dependency 
spec.

For details, see 
http://dlafferty.blogspot.co.uk/2013/08/diagnosing-maven-dependency-problems.html
 

The problem has since been resolved.

DL


> -Original Message-
> From: Donal Lafferty [mailto:donal.laffe...@citrix.com]
> Sent: 30 July 2013 5:19 PM
> To: 
> Subject: RE: [DISCUSS] maven dependencies...
> 
> BTW, how is the dependency on org.apache.commons.io.FileUtils
> expressed?  Has this code changed recently?
> 
> Using this morning's master, the management server can't find the FileUtils
> class.  I.e.
> 
> INFO  [ConfigurationServerImpl] (Timer-2:null) Generated SSL keystore.
> Exception in thread "Timer-2" java.lang.NoClassDefFoundError:
> org/apache/commons/io/FileUtils
> at
> com.cloud.server.ConfigurationServerImpl.getBase64Keystore(Configuration
> ServerImpl.java:453)
> at
> com.cloud.server.ConfigurationServerImpl.updateSSLKeystore(Configuratio
> nServerImpl.java:520)
> at
> com.cloud.server.ConfigurationServerImpl.persistDefaultValues(Configurati
> onServerImpl.java:289)
> at
> com.cloud.server.ConfigurationServerImpl_EnhancerByCloudStack_4741108
> b.CGLIB$persistDefaultValues$14()
> at
> com.cloud.server.ConfigurationServerImpl_EnhancerByCloudStack_4741108
> b_FastClassByCloudStack_d48cf40f.invoke()
> at net.sf.cglib.proxy.MethodProxy.invokeSuper(MethodProxy.java:228)
> at
> com.cloud.utils.component.ComponentInstantiationPostProcessor$Intercep
> torDispatcher.intercept(ComponentInstantiationPostProcessor.java:125)
> at
> com.cloud.server.ConfigurationServerImpl_EnhancerByCloudStack_4741108
> b.persistDefaultValues()
> at
> com.cloud.server.ConfigurationServerImpl.configure(ConfigurationServerIm
> pl.java:157)
> at
> com.cloud.utils.component.ComponentContext.initComponentsLifeCycle(Co
> mponentContext.java:111)
> at
> com.cloud.servlet.CloudStartupServlet$1.run(CloudStartupServlet.java:50)
> at java.util.TimerThread.mainLoop(Timer.java:555)
> at java.util.TimerThread.run(Timer.java:505)
> Caused by: java.lang.ClassNotFoundException:
> org.apache.commons.io.FileUtils
> at
> org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy.loadClass(SelfFirs
> tStrategy.java:50)
> at
> org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.jav
> a:244)
> at
> org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.jav
> a:230)
> at
> org.mortbay.jetty.webapp.WebAppClassLoader.loadClass(WebAppClassLoa
> der.java:401)
> at
> org.mortbay.jetty.webapp.WebAppClassLoader.loadClass(WebAppClassLoa
> der.java:363)
> ... 13 more
> 
> > -Original Message-
> > From: Chip Childers [mailto:chip.child...@sungard.com]
> > Sent: 30 July 2013 4:12 PM
> > To: 
> > Subject: Re: [DISCUSS] maven dependencies...
> >
> > On Tue, Jul 30, 2013 at 10:22 AM, Alex Huang 
> > wrote:
> >
> > > Chip and Donal,
> > >
> > > I should have replied to this earlier.  I changed from a logging
> > > category of [cloud.vm.VirtualMachineManagerImpl] to
> > > [c.c.v.VirtualMachineManagerImpl].  It's shorter and really no one
> > > looks at the package any more with editors that can open any file
> > > from any package but every so often you need it and having the
> > > package abbreviation comes in handy.  To do that I changed from
> > > %{c3} to %{c1.} but it required the use of EnhancedPatternLayout.
> > >
> > > What I failed to notice (because the startup log rolls by so fast)
> > > is that some of the appenders are not using EnhancedPatternLayout.
> > >
> > > I've already put in a fix after Donal's email to put the ones that
> > > are using PatternLayout to go back to the old %{c3}.  They're
> > > specific to syslog and snmp so I didn't want to screw up anything in
> > > those implementations.
> > >
> > > I will revert Chip's commit that changed all the rest of them to
> > > %{c1} unless we rather not have the package abbreviations.
> > >
> > >
> > Good clarification.  Revert away.
> >
> >
> > > --Alex
> > >
> > > > -Original Message-
> > > > From: Chip Childers [mailto:chip.child...@sungard.com]
> > > > Sent: Tuesday, July 30, 2013 6:05 AM
> > > > To: dev@cloudstack.apache.org
> > > > Subject: Re: [DISCUSS] maven dependencies...
> > > >
> > > > On Mon, Jul 29, 2013 at 08:40:44PM +, Donal Lafferty wrote:
> > > > > Could you also have a look at ./client/tomcatconf/log4j-cloud.xml.in?
> > > > >
> > > > > It looks like it was updated in the refactor.
> > > > >
> > > > > AFAIK, in '', {1.} should be {1}.
> > > > >
> > > > > See "Conversion Character" chart under
> > > >
> > > http://logging.apache.org/log4j/1.2/apidocs/org/apache/log4j/Pattern
> > > La
> > > you
> > > > t.html
> > > > >
> > > > > There's a lot of paper work for me to make the update :(
> > > > >
> > > > > DL
> > > >
> > > > Done!
> > > >
> > > > commit 4c729e7
> > >
> > >


Re: Ruby dev wanted

2013-08-01 Thread Isaac Chiang
Hi Sebastien,
   I've read the ruby client project by Chips. It's pretty looks like
I'm doing now for _https://github.com/isaacchiang/cloud_ruby. Please have a
look. I believe there are
some code segments that would be helpful to the rOCCI driver. I need more
advice to
the rOCCI project, thanks.

Regard

Isaac


On Fri, Jul 26, 2013 at 11:16 PM, Sebastien Goasguen wrote:

>
> On Jul 25, 2013, at 8:04 PM, Isaac Chiang  wrote:
>
> > Hi Sebastien,
> > I'm interested in the rOCCi project. I'd like to join.
> > However, I know nothing about the OCCI and will spend some time on it in
> > next few days. Please kindly let me know more information about the
> > project(status, repo location, e.t.c., thanks :)
> >
> >
>
> Hi Isaac,
>
> Great, that's terrific of you to volunteer, should be fun.
>
> The first thing I think would be to check out Chip'c ruby client:
> https://github.com/chipchilders/cloudstack_ruby_client
>
> Test it and finish it up  (I am sure Chip can chime in).
>
> Then, you would need to look at:
> https://github.com/gwdg/rOCCI
>
> Figure out how to write a driver, there is an example for opennebula and
> ec2 I believe.
> And then go for it :)
>
> Cheers,
>
> -Sebastien
>
> > Regards
> >
> > Isaac
> >
> >
> > Hi folks,
> >
> > I committed to do an interoperability workshop in Madrid, Spain in
> > september:
> >
> http://www.cloudplugfest.org/cloud-interoperability-week/detailed-program
> >
> > All "four sisters" of cloud are represented.
> >
> > The main goal is to show that we can talk to CloudStack with OCCI and
> even
> > CIMI standards.
> >
> > The problem is that currently we cannot :)
> >
> > So I am looking for some help from Ruby developers who would be willing
> to
> > work on:
> >
> > https://github.com/gwdg/rOCCI
> >
> > and also on delta cloud (even though the project may have stalled):
> >
> > http://deltacloud.apache.org
> >
> > A good start might be Chip's ruby client:
> > https://github.com/chipchilders/cloudstack_ruby_client
> >
> > Help, any takers  ?
> >
> >
> >
> > -Sebastien
>
>


[Doc] Dedicated Resources: Public IPs and VLANs per Account is Ready

2013-08-01 Thread Radhika Puthiyetath
Hi,

Dedicated Resources: Public IPs and VLANs per Account is Ready documentation is 
ready for review. The doc is attached at 
https://issues.apache.org/jira/browse/CLOUDSTACK-817

Please see section 15.8. Reserving Public IP Addresses and VLANs Per Account 
(132), and provide your feedback.

Regards
-Radhika




[Doc] Adding and Removing Networks on a VM is Ready

2013-08-01 Thread Radhika Puthiyetath
Hi,

Adding and Removing Networks on a VM documentation is ready for review. The doc 
is attached at https://issues.apache.org/jira/browse/CLOUDSTACK-2986

Please see section 15.6.2. Reconfiguring Networks in VMs (128), and provide 
your feedback.

Regards
-Radhika




Review Request 13190: CLOUDSTACK-4010: Change required in the UI to pass startdate/enddate parameter rather than olderthan parameter in the archive/delete alerts/events API.

2013-08-01 Thread Sanjay Tripathi

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13190/
---

Review request for cloudstack, Brian Federle and Jessica Wang.


Bugs: CLOUDSTACK-4010


Repository: cloudstack-git


Description
---

 CLOUDSTACK-4010: Change required in the UI to pass startdate/enddate
 parameter rather than olderthan parameter in the archive/delete alerts/events 
API.


Diffs
-

  ui/scripts/events.js 873998e 

Diff: https://reviews.apache.org/r/13190/diff/


Testing
---

Veirified the fix and functionality locally on cloudstack setup.


Thanks,

Sanjay Tripathi



[Doc] Adding Multiple IP Ranges is Ready

2013-08-01 Thread Radhika Puthiyetath
Hi,

Adding Multiple IP Ranges documentation is ready for review. The doc is 
attached at https://issues.apache.org/jira/browse/CLOUDSTACK-847

Please see 15.13. Adding Multiple IP Ranges (139), and provide your feedback.

Regards
-Radhika




Re: Review Request 11626: Automation: Memory limits tests from Resource Limits Tests

2013-08-01 Thread Sanjay Tripathi

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11626/#review24360
---



test/integration/component/memory_limits/test_domain_limits.py


"domain" object is same as parent "domain" object, should use a different 
name.



test/integration/component/memory_limits/test_domain_limits.py


Use the listResourceLimit API to get the limit set for account. If you 
fetch the limit from the configuration, you will not get the limit set by using 
updateResourceLimit API.



test/integration/component/memory_limits/test_domain_limits.py


use listAccounts to get the resource count, also use assert to verify the 
count with the expected count.



test/integration/component/memory_limits/test_domain_limits.py


again, use listAccounts and assert



test/integration/component/memory_limits/test_domain_limits.py


use listAccounts and assert.



test/integration/component/memory_limits/test_domain_limits.py


Migration of a VM to another host will not affect/update any count because 
VM still belongs to the same account; instead of doing migration test, you 
should test assignVM to other account in which VM get assigned to other account 
and affects/updates the count for both the accounts.



test/integration/component/memory_limits/test_domain_limits.py


Use listAccounts to get the count.



test/integration/component/memory_limits/test_domain_limits.py


again, use listResourceLimits to get the limit set for this account.



test/integration/component/memory_limits/test_domain_limits.py


"Update" should be "List"



test/integration/component/memory_limits/test_domain_limits.py


I doubt if this test runs successfully because you are reaching the limit 
after the deployment of 1st VM itself.



test/integration/component/memory_limits/test_domain_limits.py


use listAccounts and assert to verify count.


- Sanjay Tripathi


On July 27, 2013, 1:21 p.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11626/
> ---
> 
> (Updated July 27, 2013, 1:21 p.m.)
> 
> 
> Review request for cloudstack, sailaja mada, Sanjay Tripathi, and Prasanna 
> Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Adding resource limit tests related to Memory. Changes suggested in CPU 
> resource limit tests which are applicable here are incorporated too.
> 
> Updated test plan is available here: 
> https://cwiki.apache.org/confluence/download/attachments/30757590/LimitResourcesTestPlanUpdate5.xlsx?version=1&modificationDate=1366952352000
> 
> 
> Diffs
> -
> 
>   test/integration/component/memory_limits/test_domain_limits.py PRE-CREATION 
>   test/integration/component/memory_limits/test_maximum_limits.py 
> PRE-CREATION 
>   test/integration/component/memory_limits/test_memory_limits.py PRE-CREATION 
>   test/integration/component/memory_limits/test_project_limits.py 
> PRE-CREATION 
>   tools/marvin/marvin/integration/lib/base.py 8d9a25d 
>   tools/marvin/marvin/integration/lib/common.py 4f5acef 
> 
> Diff: https://reviews.apache.org/r/11626/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>



[Doc] IP Address Reservation is Ready for Review

2013-08-01 Thread Radhika Puthiyetath
Hi,

Adding Multiple IP Ranges documentation is ready for review. The doc is 
attached at https://issues.apache.org/jira/browse/CLOUDSTACK-850.

Please see 15.7. IP Reservation in Isolated Guest Networks, and provide your 
feedback.

Regards
-Radhika




Re: Review Request 11626: Automation: Memory limits tests from Resource Limits Tests

2013-08-01 Thread Sanjay Tripathi


> On Aug. 1, 2013, 11:27 a.m., Sanjay Tripathi wrote:
> > test/integration/component/memory_limits/test_domain_limits.py, line 429
> > 
> >
> > use listAccounts and assert to verify count.

Also, can you close the issues opened in this request once you resolve them.


- Sanjay


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11626/#review24360
---


On July 27, 2013, 1:21 p.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11626/
> ---
> 
> (Updated July 27, 2013, 1:21 p.m.)
> 
> 
> Review request for cloudstack, sailaja mada, Sanjay Tripathi, and Prasanna 
> Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Adding resource limit tests related to Memory. Changes suggested in CPU 
> resource limit tests which are applicable here are incorporated too.
> 
> Updated test plan is available here: 
> https://cwiki.apache.org/confluence/download/attachments/30757590/LimitResourcesTestPlanUpdate5.xlsx?version=1&modificationDate=1366952352000
> 
> 
> Diffs
> -
> 
>   test/integration/component/memory_limits/test_domain_limits.py PRE-CREATION 
>   test/integration/component/memory_limits/test_maximum_limits.py 
> PRE-CREATION 
>   test/integration/component/memory_limits/test_memory_limits.py PRE-CREATION 
>   test/integration/component/memory_limits/test_project_limits.py 
> PRE-CREATION 
>   tools/marvin/marvin/integration/lib/base.py 8d9a25d 
>   tools/marvin/marvin/integration/lib/common.py 4f5acef 
> 
> Diff: https://reviews.apache.org/r/11626/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>



Re: Review Request 13112: upgrade to ASF 4.2 "cloud" Database Schema Inconsistencies on the Upgraded Setup - Table "volumes"

2013-08-01 Thread Abhinandan Prateek

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13112/#review24433
---


failed to apply on 4.2 and master

Applying: 3.0.6 to ASF 4.2 Upgrade: "cloud" Database Schema Inconsistencies on 
the Upgraded Setup - Table "volumes"
error: patch failed: setup/db/db/schema-410to420.sql:2207
error: setup/db/db/schema-410to420.sql: patch does not apply
Patch failed at 0001 3.0.6 to ASF 4.2 Upgrade: "cloud" Database Schema 
Inconsistencies on the Upgraded Setup - Table "volumes"
The copy of the patch that failed is found in:
   /Users/agneya2001/citrix/asf/.git/rebase-apply/patch


- Abhinandan Prateek


On July 31, 2013, 7:17 p.m., bharat kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13112/
> ---
> 
> (Updated July 31, 2013, 7:17 p.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
> 
> 
> Bugs: Cloudstack-3836
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> upgrade to ASF 4.2  "cloud" Database Schema Inconsistencies on the Upgraded 
> Setup - Table "volumes"
> https://issues.apache.org/jira/browse/CLOUDSTACK-3836
> 
> This extra column is because of the fix 
> Parent id of template incorrectly recorded as last ISO attached to VM.
> 
> when a template is created form the snapshot the sourcetemplateid is recorded 
> as the iso attached to the VM at thee time of creation. 
> 
> we fix this by adding a iso_id column to the volume table. when a template is 
> created from the snapshot we fetch the iso_id form the parent volume and set 
> it as the sourcetemplated id of the newly created template.
> 
> 
> Diffs
> -
> 
>   engine/schema/src/com/cloud/storage/VolumeVO.java 1445e99 
>   engine/schema/src/com/cloud/upgrade/dao/DbUpgradeUtils.java c37be3e 
>   engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java 13074cf 
>   server/src/com/cloud/storage/VolumeManager.java 2e44a3c 
>   server/src/com/cloud/storage/VolumeManagerImpl.java d8cbf11 
>   server/src/com/cloud/template/TemplateManagerImpl.java 8ccc567 
>   server/src/com/cloud/vm/VirtualMachineManagerImpl.java eedf4d2 
>   setup/db/db/schema-307to410.sql be6c17d 
>   setup/db/db/schema-410to420.sql 9cdf837 
> 
> Diff: https://reviews.apache.org/r/13112/diff/
> 
> 
> Testing
> ---
> 
> Tested on 4.2.
> 
> 
> Thanks,
> 
> bharat kumar
> 
>



Re: Review Request 11861: double slash fix for windows based nfs servers [CLOUDSTACK-2968]

2013-08-01 Thread daan Hoogland

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11861/
---

(Updated Aug. 1, 2013, 11:39 a.m.)


Review request for cloudstack and John Burwell.


Changes
---

John, can you check if I need to rework or abandon this submission? thanks


Bugs: CLOUDSTACK-2968


Repository: cloudstack-git


Description
---

double slash breaks windows based nfs servers [CLOUDSTACK-2968]


Diffs
-

  api/src/com/cloud/storage/template/TemplateInfo.java 6559d73 
  core/src/com/cloud/agent/api/storage/CreateEntityDownloadURLCommand.java 
98a957f 
  core/src/com/cloud/agent/api/storage/DownloadAnswer.java bb7b8a9 
  core/src/com/cloud/storage/template/TemplateLocation.java 58d023a 
  engine/schema/src/com/cloud/storage/VMTemplateHostVO.java b8dfc41 
  
engine/storage/src/org/apache/cloudstack/storage/motion/AncientDataMotionStrategy.java
 a6880c3 
  server/src/com/cloud/storage/download/DownloadListener.java 1d48803 
  server/src/com/cloud/storage/download/DownloadMonitorImpl.java f72a563 
  server/src/com/cloud/template/HypervisorTemplateAdapter.java 322f32e 
  server/src/com/cloud/template/TemplateManagerImpl.java 517d4ba 
  utils/src/com/cloud/utils/FileUtil.java 74f4088 
  utils/test/com/cloud/utils/FileUtilTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/11861/diff/


Testing
---

database analysis


Thanks,

daan Hoogland



RE: [ACS42][Request] CLOUDSTACK-4001

2013-08-01 Thread Koushik Das
I see this in the review request

Review 13189 failed the build test : FAILURE
The url of build cloudstack-master-with-patch #99 is : 
http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/99/

Can you address this?

-Koushik

> -Original Message-
> From: Sanjay Tripathi [mailto:sanjay.tripa...@citrix.com]
> Sent: Thursday, August 01, 2013 1:43 PM
> To: dev@cloudstack.apache.org
> Cc: Animesh Chaturvedi
> Subject: [ACS42][Request] CLOUDSTACK-4001
> 
> Hi,
> 
> Request to review and commit this patch to 4.2 branch.
> 
> Review request:
> https://reviews.apache.org/r/13189/
> 
> Ticket:
> https://issues.apache.org/jira/browse/CLOUDSTACK-4001
> (Unable to deploy Windows server 2012 64bit VM on XenServer 6.2)
> 
> --Sanjay


upgrade path 4.1.1 -> 4.2/master

2013-08-01 Thread Daan Hoogland
H,

I am testing an upgrade of my code for sdn based vpc private gateways
(not in the mainstream code). It runs on a custom 4.1.1 based on the
4.1 branch. I have tested it against a 4.0 database and it upgrades
fine.

Now I try to have a master version to which I applied my code to run
against the same environment. I added
_upgradeMap.put("4.1.1", new DbUpgrade[] {new Upgrade410to420()});
to the class com.cloud.upgrade.DatabaseUpgradeChecker.
I have the systemvm.iso ready on the hypervisors, but not on my
(windows) development machine. When I start my version in eclipse I
get

INFO  [c.c.u.DatabaseUpgradeChecker] (Timer-2:null) Database upgrade
must be performed from 4.1.1 to 4.2.0-SNAPSHOT
WARN  [c.c.u.d.Upgrade410to420] (Timer-2:null) 4.2.0 Hyperv SystemVm
template not found. Hyperv hypervisor is not used, so not failing
upgrade
WARN  [c.c.u.d.Upgrade410to420] (Timer-2:null) 4.2.0 KVM SystemVm
template not found. KVM hypervisor is not used, so not failing upgrade
ERROR [c.c.u.DatabaseUpgradeChecker] (Timer-2:null) Unable to upgrade
the database
com.cloud.utils.exception.CloudRuntimeException: 4.2.0 XenServer
SystemVm template not found. Cannot upgrade system Vms
at 
com.cloud.upgrade.dao.Upgrade410to420.updateSystemVmTemplates(Upgrade410to420.java:259)
...
ERROR [c.c.u.c.ComponentContext] (Timer-2:null) System integrity check
failed. Refuse to startup
com.cloud.utils.exception.CloudRuntimeException: Unable to upgrade the database
at 
com.cloud.upgrade.DatabaseUpgradeChecker.upgrade(DatabaseUpgradeChecker.java:296)
...
Caused by: com.cloud.utils.exception.CloudRuntimeException: 4.2.0
XenServer SystemVm template not found. Cannot upgrade system Vms
at 
com.cloud.upgrade.dao.Upgrade410to420.updateSystemVmTemplates(Upgrade410to420.java:259)
...
... 5 more
2013-07-31 21:50:50.802:INFO::Shutdown hook executing

I found that vm_template should contain a line for this;

//Get 4.2.0 system Vm template Id for
corresponding hypervisor
pstmt = conn.prepareStatement("select id from
`cloud`.`vm_template` where name = ? and removed is null order by id
desc limit 1");
pstmt.setString(1, hypervisorAndTemplateName.getValue());
rs = pstmt.executeQuery();

Should I add a row by hand?
Is there a readme/howto-upgrade, I should read (or create using my findings)?
Why is this not automatic this time?

sorry if I missed the mail thread explaining all of this,
Daan Hoogland


Re: Review Request 13190: CLOUDSTACK-4010: Change required in the UI to pass startdate/enddate parameter rather than olderthan parameter in the archive/delete alerts/events API.

2013-08-01 Thread Jenkins Cloudstack.org

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13190/#review24434
---


Review 13190 failed the build test : FAILURE
The url of build cloudstack-master-with-patch #100 is : 
http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/100/

- Jenkins Cloudstack.org


On Aug. 1, 2013, 11:05 a.m., Sanjay Tripathi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13190/
> ---
> 
> (Updated Aug. 1, 2013, 11:05 a.m.)
> 
> 
> Review request for cloudstack, Brian Federle and Jessica Wang.
> 
> 
> Bugs: CLOUDSTACK-4010
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
>  CLOUDSTACK-4010: Change required in the UI to pass startdate/enddate
>  parameter rather than olderthan parameter in the archive/delete 
> alerts/events API.
> 
> 
> Diffs
> -
> 
>   ui/scripts/events.js 873998e 
> 
> Diff: https://reviews.apache.org/r/13190/diff/
> 
> 
> Testing
> ---
> 
> Veirified the fix and functionality locally on cloudstack setup.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>



Re: Review Request 13072: Print agent host name in logging of agent commands

2013-08-01 Thread Koushik Das

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13072/#review24435
---


The changes look fine but I don't see much value with this as the name can be 
easily identified from the db. I feel the logs are used primarily for debugging 
issues. And one key aspect that is missing currently is the correlation of 
logs. Currently when a API call is made to MS, it traverses through various 
layers in the MS and finally hitting the resource layer and then returns back 
with response. Logs gets generated from each layer but it is not very intuitive 
to relate them to API call. If there is a unique id (some kind of uuid) that 
gets appended to the logs for a specific API call then correlation becomes very 
easy.

I feel adding these kind of correlation would be much more useful.

- Koushik Das


On July 30, 2013, 5:37 p.m., Marcus Sorensen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13072/
> ---
> 
> (Updated July 30, 2013, 5:37 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Bugs: CLOUDSTACK-3872
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Print agent name when logging Commands sent to VM hosts. See bug description. 
>  I'm not super familiar with this code, so I'd like someone to look over it 
> and verify it's the right thing.
> 
> 
> Diffs
> -
> 
>   core/src/com/cloud/agent/transport/Request.java b0fa4cc 
>   server/src/com/cloud/agent/manager/AgentManagerImpl.java b157838 
> 
> Diff: https://reviews.apache.org/r/13072/diff/
> 
> 
> Testing
> ---
> 
> Tested on KVM zone, need help testing others.
> 
> 
> Thanks,
> 
> Marcus Sorensen
> 
>



Re: How to create Port Forwarding rule for VM through UI?

2013-08-01 Thread Daan Hoogland
network ->  -> IP Adresses ->  ->
configuration -> Port Forwarding

On Mon, Jul 22, 2013 at 12:09 PM, Gaurav Aradhye
 wrote:
> Hi all,
>
> Can anybody tell me how to create port forwarding rule for a specific vm
> through Cloudstack UI?
> You can just mention the navigational steps.
>
> Regards,
> Gaurav


Re: Review Request 11861: double slash fix for windows based nfs servers [CLOUDSTACK-2968]

2013-08-01 Thread Jenkins Cloudstack.org

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11861/#review24436
---


Review 11861 failed the build test : FAILURE
The url of build cloudstack-master-with-patch #101 is : 
http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/101/

- Jenkins Cloudstack.org


On Aug. 1, 2013, 11:39 a.m., daan Hoogland wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11861/
> ---
> 
> (Updated Aug. 1, 2013, 11:39 a.m.)
> 
> 
> Review request for cloudstack and John Burwell.
> 
> 
> Bugs: CLOUDSTACK-2968
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> double slash breaks windows based nfs servers [CLOUDSTACK-2968]
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/storage/template/TemplateInfo.java 6559d73 
>   core/src/com/cloud/agent/api/storage/CreateEntityDownloadURLCommand.java 
> 98a957f 
>   core/src/com/cloud/agent/api/storage/DownloadAnswer.java bb7b8a9 
>   core/src/com/cloud/storage/template/TemplateLocation.java 58d023a 
>   engine/schema/src/com/cloud/storage/VMTemplateHostVO.java b8dfc41 
>   
> engine/storage/src/org/apache/cloudstack/storage/motion/AncientDataMotionStrategy.java
>  a6880c3 
>   server/src/com/cloud/storage/download/DownloadListener.java 1d48803 
>   server/src/com/cloud/storage/download/DownloadMonitorImpl.java f72a563 
>   server/src/com/cloud/template/HypervisorTemplateAdapter.java 322f32e 
>   server/src/com/cloud/template/TemplateManagerImpl.java 517d4ba 
>   utils/src/com/cloud/utils/FileUtil.java 74f4088 
>   utils/test/com/cloud/utils/FileUtilTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/11861/diff/
> 
> 
> Testing
> ---
> 
> database analysis
> 
> 
> Thanks,
> 
> daan Hoogland
> 
>



Re: Review Request 13109: CLOUDSTACK-3594: Fixes related to affinity groups

2013-08-01 Thread Gaurav Aradhye


> On Aug. 1, 2013, 8:26 a.m., Prasanna Santhanam wrote:
> > test/integration/component/test_affinity_groups.py, line 1444
> > 
> >
> > use utils.randomgen()

Currently the function random_gen is in utils only. It's not defined separately 
in test case.
 


- Gaurav


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13109/#review24426
---


On July 31, 2013, 12:13 p.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13109/
> ---
> 
> (Updated July 31, 2013, 12:13 p.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fixed test case issues mentioned in issue 
> https://issues.apache.org/jira/browse/CLOUDSTACK-3594
> 
> Radom-ized affinity group name to avoid cascading test case failures stating 
> "unable to create affinity group due to affinity group with the same name 
> exists".
> 
> Included following 2 test suites which were not run in last build because 
> there was no decorator for the test cases.
> 1. TestListAffinityGroups
> 2. TestUpdateVMAffinityGroups
> 
> One test case in TestUpdateVMAffinityGroups is skipped, it's failing right 
> now. Will be fixed shortly.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_affinity_groups.py 3ecab6f 
>   tools/marvin/marvin/integration/lib/base.py b552aba 
> 
> Diff: https://reviews.apache.org/r/13109/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>



RE: [ACS42][Request] CLOUDSTACK-4001

2013-08-01 Thread Sanjay Tripathi
I am able to build the code successfully (tested on both 4.2 and master) 
without any issues; and I don't think if there is any issue caused because of 
this patch.
There might be some issue with Jenkins bot settings as I am seeing the failure 
message in other requests also.

--Sanjay

> -Original Message-
> From: Koushik Das [mailto:koushik@citrix.com]
> Sent: Thursday, August 01, 2013 5:16 PM
> To: dev@cloudstack.apache.org
> Cc: Animesh Chaturvedi
> Subject: RE: [ACS42][Request] CLOUDSTACK-4001
> 
> I see this in the review request
> 
> Review 13189 failed the build test : FAILURE The url of build cloudstack-
> master-with-patch #99 is : http://jenkins.cloudstack.org/job/cloudstack-
> master-with-patch/99/
> 
> Can you address this?
> 
> -Koushik
> 
> > -Original Message-
> > From: Sanjay Tripathi [mailto:sanjay.tripa...@citrix.com]
> > Sent: Thursday, August 01, 2013 1:43 PM
> > To: dev@cloudstack.apache.org
> > Cc: Animesh Chaturvedi
> > Subject: [ACS42][Request] CLOUDSTACK-4001
> >
> > Hi,
> >
> > Request to review and commit this patch to 4.2 branch.
> >
> > Review request:
> > https://reviews.apache.org/r/13189/
> >
> > Ticket:
> > https://issues.apache.org/jira/browse/CLOUDSTACK-4001
> > (Unable to deploy Windows server 2012 64bit VM on XenServer 6.2)
> >
> > --Sanjay


unanwerred questions on dev

2013-08-01 Thread Daan Hoogland
H,

I made a summary of unanswered questions again. Only three on dev last
week. I will start this on users as well and keep this going the next
few weeks, if usefulness is considered to be high and work load for
this remains low.

http://markmail.org/message/demfcxuhtlflxc76 Unable to create image on
Cloudcentral by Prabakaran R
http://markmail.org/message/tlvrtkrvp7paqhqb zone create wizard issue
with create storagepool by Srikanteswararao Talluri
http://markmail.org/message/4xtly76mrp4weyrq VNC console access over
SSH by Ian Duffy

on question: should I send those messages to this list? alternatively
they could go to marketing or dev to dev and users to users. That last
one is not good marketing i think :P.

regards,
Daan


Re: upgrade path 4.1.1 -> 4.2/master

2013-08-01 Thread Harikrishna Patnala
Hi Daan,
Before upgrading to 4.2 we need to register the new system templates for each 
hypervisor with specific names so that during upgrade these new templates are 
set to the system vms.
It is mandatory to upgrade the system vm template if we want upgrade to 4.2.

Here seems like you have a Xen cluster. So you need to register xen system 
template with name systemvm-xenserver-4.2.
So for the existing clusters you need to register system vm template per 
hypervisor.
System template names are for each hypervisor are
1) systemvm-xenserver-4.2 
2) systemvm-kvm-4.2 
3) systemvm-vmware-4.2 
4) systemvm-hyperv-4.2 
5) systemvm-lxc-4.2 

Thank you
Harikrishna

On 01-Aug-2013, at 5:29 PM, Daan Hoogland  wrote:

> H,
> 
> I am testing an upgrade of my code for sdn based vpc private gateways
> (not in the mainstream code). It runs on a custom 4.1.1 based on the
> 4.1 branch. I have tested it against a 4.0 database and it upgrades
> fine.
> 
> Now I try to have a master version to which I applied my code to run
> against the same environment. I added
>_upgradeMap.put("4.1.1", new DbUpgrade[] {new Upgrade410to420()});
> to the class com.cloud.upgrade.DatabaseUpgradeChecker.
> I have the systemvm.iso ready on the hypervisors, but not on my
> (windows) development machine. When I start my version in eclipse I
> get
> 
> INFO  [c.c.u.DatabaseUpgradeChecker] (Timer-2:null) Database upgrade
> must be performed from 4.1.1 to 4.2.0-SNAPSHOT
> WARN  [c.c.u.d.Upgrade410to420] (Timer-2:null) 4.2.0 Hyperv SystemVm
> template not found. Hyperv hypervisor is not used, so not failing
> upgrade
> WARN  [c.c.u.d.Upgrade410to420] (Timer-2:null) 4.2.0 KVM SystemVm
> template not found. KVM hypervisor is not used, so not failing upgrade
> ERROR [c.c.u.DatabaseUpgradeChecker] (Timer-2:null) Unable to upgrade
> the database
> com.cloud.utils.exception.CloudRuntimeException: 4.2.0 XenServer
> SystemVm template not found. Cannot upgrade system Vms
> at 
> com.cloud.upgrade.dao.Upgrade410to420.updateSystemVmTemplates(Upgrade410to420.java:259)
> ...
> ERROR [c.c.u.c.ComponentContext] (Timer-2:null) System integrity check
> failed. Refuse to startup
> com.cloud.utils.exception.CloudRuntimeException: Unable to upgrade the 
> database
> at 
> com.cloud.upgrade.DatabaseUpgradeChecker.upgrade(DatabaseUpgradeChecker.java:296)
> ...
> Caused by: com.cloud.utils.exception.CloudRuntimeException: 4.2.0
> XenServer SystemVm template not found. Cannot upgrade system Vms
> at 
> com.cloud.upgrade.dao.Upgrade410to420.updateSystemVmTemplates(Upgrade410to420.java:259)
> ...
> ... 5 more
> 2013-07-31 21:50:50.802:INFO::Shutdown hook executing
> 
> I found that vm_template should contain a line for this;
> 
>//Get 4.2.0 system Vm template Id for
> corresponding hypervisor
>pstmt = conn.prepareStatement("select id from
> `cloud`.`vm_template` where name = ? and removed is null order by id
> desc limit 1");
>pstmt.setString(1, hypervisorAndTemplateName.getValue());
>rs = pstmt.executeQuery();
> 
> Should I add a row by hand?
> Is there a readme/howto-upgrade, I should read (or create using my findings)?
> Why is this not automatic this time?
> 
> sorry if I missed the mail thread explaining all of this,
> Daan Hoogland



we like dev better then users :(

2013-08-01 Thread Daan Hoogland
I think the following list speaks for itself

http://markmail.org/message/ap42zplnpenniqtd can't create VM after
upgrade from 3.0.2 to 4,1. Error Code: 533 Error text: Unable to
create a deploymentfor VM by William Jiang
http://markmail.org/message/wxe6oktgtxtvg6uk Setting up networking on
single machine by Philip Andrews
http://markmail.org/message/lrenopzjshkzfxbe MuleSoft by Len Bellemore
http://markmail.org/message/vicznsksl5k33uby VPC Issue with CS
4.1/KVM/Openvswitch by Dinu Arateanu
http://markmail.org/message/nqw3abaplbzgutwz AMI Import questions by
Carlos Reategui
http://markmail.org/message/ny7wi4hpufe6j7wb windows vm lost static ip
config after xe-tools upgrade from 6.0.2 to 6.1 by William Jiang
http://markmail.org/message/camfk7jrekuzy2ge Cloud capacity by Jerry Jiang
http://markmail.org/message/apnzuex65qcijegl vms hang in expunged
state by Valery Ciareszka
http://markmail.org/message/apkldlvxvq2u2yvm few orphan disk on
primary storage (CS v3) by Pierre Benard
http://markmail.org/message/to5zyb3k6z6hd3sg ESXI support by Chitra Manjunath
http://markmail.org/message/23ga4bseph6ruh4x ClassCastException for
Virtual Routers in Zones using Adv Networking by Boyer, Marc

regards,
Daan


Re: upgrade path 4.1.1 -> 4.2/master

2013-08-01 Thread Daan Hoogland
Harikrishna,

I suppose I have to register those templates before upgrading; i.e. in
the 4.1.1 version management server.
Is this procedure described somewhere?
Do I bake the templates myself first or should I use publicly offered templates?

thanks,
Daan

On Thu, Aug 1, 2013 at 3:16 PM, Harikrishna Patnala
 wrote:
> Hi Daan,
> Before upgrading to 4.2 we need to register the new system templates for each 
> hypervisor with specific names so that during upgrade these new templates are 
> set to the system vms.
> It is mandatory to upgrade the system vm template if we want upgrade to 4.2.
>
> Here seems like you have a Xen cluster. So you need to register xen system 
> template with name systemvm-xenserver-4.2.
> So for the existing clusters you need to register system vm template per 
> hypervisor.
> System template names are for each hypervisor are
> 1) systemvm-xenserver-4.2
> 2) systemvm-kvm-4.2
> 3) systemvm-vmware-4.2
> 4) systemvm-hyperv-4.2
> 5) systemvm-lxc-4.2
>
> Thank you
> Harikrishna
>
> On 01-Aug-2013, at 5:29 PM, Daan Hoogland  wrote:
>
>> H,
>>
>> I am testing an upgrade of my code for sdn based vpc private gateways
>> (not in the mainstream code). It runs on a custom 4.1.1 based on the
>> 4.1 branch. I have tested it against a 4.0 database and it upgrades
>> fine.
>>
>> Now I try to have a master version to which I applied my code to run
>> against the same environment. I added
>>_upgradeMap.put("4.1.1", new DbUpgrade[] {new Upgrade410to420()});
>> to the class com.cloud.upgrade.DatabaseUpgradeChecker.
>> I have the systemvm.iso ready on the hypervisors, but not on my
>> (windows) development machine. When I start my version in eclipse I
>> get
>>
>> INFO  [c.c.u.DatabaseUpgradeChecker] (Timer-2:null) Database upgrade
>> must be performed from 4.1.1 to 4.2.0-SNAPSHOT
>> WARN  [c.c.u.d.Upgrade410to420] (Timer-2:null) 4.2.0 Hyperv SystemVm
>> template not found. Hyperv hypervisor is not used, so not failing
>> upgrade
>> WARN  [c.c.u.d.Upgrade410to420] (Timer-2:null) 4.2.0 KVM SystemVm
>> template not found. KVM hypervisor is not used, so not failing upgrade
>> ERROR [c.c.u.DatabaseUpgradeChecker] (Timer-2:null) Unable to upgrade
>> the database
>> com.cloud.utils.exception.CloudRuntimeException: 4.2.0 XenServer
>> SystemVm template not found. Cannot upgrade system Vms
>> at 
>> com.cloud.upgrade.dao.Upgrade410to420.updateSystemVmTemplates(Upgrade410to420.java:259)
>> ...
>> ERROR [c.c.u.c.ComponentContext] (Timer-2:null) System integrity check
>> failed. Refuse to startup
>> com.cloud.utils.exception.CloudRuntimeException: Unable to upgrade the 
>> database
>> at 
>> com.cloud.upgrade.DatabaseUpgradeChecker.upgrade(DatabaseUpgradeChecker.java:296)
>> ...
>> Caused by: com.cloud.utils.exception.CloudRuntimeException: 4.2.0
>> XenServer SystemVm template not found. Cannot upgrade system Vms
>> at 
>> com.cloud.upgrade.dao.Upgrade410to420.updateSystemVmTemplates(Upgrade410to420.java:259)
>> ...
>> ... 5 more
>> 2013-07-31 21:50:50.802:INFO::Shutdown hook executing
>>
>> I found that vm_template should contain a line for this;
>>
>>//Get 4.2.0 system Vm template Id for
>> corresponding hypervisor
>>pstmt = conn.prepareStatement("select id from
>> `cloud`.`vm_template` where name = ? and removed is null order by id
>> desc limit 1");
>>pstmt.setString(1, hypervisorAndTemplateName.getValue());
>>rs = pstmt.executeQuery();
>>
>> Should I add a row by hand?
>> Is there a readme/howto-upgrade, I should read (or create using my findings)?
>> Why is this not automatic this time?
>>
>> sorry if I missed the mail thread explaining all of this,
>> Daan Hoogland
>


Re: we like dev better then users :(

2013-08-01 Thread Wido den Hollander

On 08/01/2013 03:31 PM, Daan Hoogland wrote:

I think the following list speaks for itself



Although it's really good that you point this out I took the following 
decision for myself: I contribute to the project by resolving bugs and 
writing new features.


In my case my colleague (Lennert) is subscribed to the users list and he 
watches that and sometimes asks me to look to something.


For me it's not doable to keep track of both the users and dev list and 
work on $dayjob


It's about shifting priorities and for me the dev list (which is hard 
enough) is my main priority.


Wido


http://markmail.org/message/ap42zplnpenniqtd can't create VM after
upgrade from 3.0.2 to 4,1. Error Code: 533 Error text: Unable to
create a deploymentfor VM by William Jiang
http://markmail.org/message/wxe6oktgtxtvg6uk Setting up networking on
single machine by Philip Andrews
http://markmail.org/message/lrenopzjshkzfxbe MuleSoft by Len Bellemore
http://markmail.org/message/vicznsksl5k33uby VPC Issue with CS
4.1/KVM/Openvswitch by Dinu Arateanu
http://markmail.org/message/nqw3abaplbzgutwz AMI Import questions by
Carlos Reategui
http://markmail.org/message/ny7wi4hpufe6j7wb windows vm lost static ip
config after xe-tools upgrade from 6.0.2 to 6.1 by William Jiang
http://markmail.org/message/camfk7jrekuzy2ge Cloud capacity by Jerry Jiang
http://markmail.org/message/apnzuex65qcijegl vms hang in expunged
state by Valery Ciareszka
http://markmail.org/message/apkldlvxvq2u2yvm few orphan disk on
primary storage (CS v3) by Pierre Benard
http://markmail.org/message/to5zyb3k6z6hd3sg ESXI support by Chitra Manjunath
http://markmail.org/message/23ga4bseph6ruh4x ClassCastException for
Virtual Routers in Zones using Adv Networking by Boyer, Marc

regards,
Daan





Re: Ruby dev wanted

2013-08-01 Thread Chip Childers
Happy to accept pull requests for cloudstack_ruby_client and to them
push the gem.

FWIW, you can always get the latest gem via: gem install
cloudstack_ruby_client


On Thu, Aug 01, 2013 at 06:03:35PM +0800, Isaac Chiang wrote:
> Hi Sebastien,
>I've read the ruby client project by Chips. It's pretty looks like
> I'm doing now for _https://github.com/isaacchiang/cloud_ruby. Please have a
> look. I believe there are
> some code segments that would be helpful to the rOCCI driver. I need more
> advice to
> the rOCCI project, thanks.
> 
> Regard
> 
> Isaac
> 
> 
> On Fri, Jul 26, 2013 at 11:16 PM, Sebastien Goasguen wrote:
> 
> >
> > On Jul 25, 2013, at 8:04 PM, Isaac Chiang  wrote:
> >
> > > Hi Sebastien,
> > > I'm interested in the rOCCi project. I'd like to join.
> > > However, I know nothing about the OCCI and will spend some time on it in
> > > next few days. Please kindly let me know more information about the
> > > project(status, repo location, e.t.c., thanks :)
> > >
> > >
> >
> > Hi Isaac,
> >
> > Great, that's terrific of you to volunteer, should be fun.
> >
> > The first thing I think would be to check out Chip'c ruby client:
> > https://github.com/chipchilders/cloudstack_ruby_client
> >
> > Test it and finish it up  (I am sure Chip can chime in).
> >
> > Then, you would need to look at:
> > https://github.com/gwdg/rOCCI
> >
> > Figure out how to write a driver, there is an example for opennebula and
> > ec2 I believe.
> > And then go for it :)
> >
> > Cheers,
> >
> > -Sebastien
> >
> > > Regards
> > >
> > > Isaac
> > >
> > >
> > > Hi folks,
> > >
> > > I committed to do an interoperability workshop in Madrid, Spain in
> > > september:
> > >
> > http://www.cloudplugfest.org/cloud-interoperability-week/detailed-program
> > >
> > > All "four sisters" of cloud are represented.
> > >
> > > The main goal is to show that we can talk to CloudStack with OCCI and
> > even
> > > CIMI standards.
> > >
> > > The problem is that currently we cannot :)
> > >
> > > So I am looking for some help from Ruby developers who would be willing
> > to
> > > work on:
> > >
> > > https://github.com/gwdg/rOCCI
> > >
> > > and also on delta cloud (even though the project may have stalled):
> > >
> > > http://deltacloud.apache.org
> > >
> > > A good start might be Chip's ruby client:
> > > https://github.com/chipchilders/cloudstack_ruby_client
> > >
> > > Help, any takers  ?
> > >
> > >
> > >
> > > -Sebastien
> >
> >


Re: Review Request 13072: Print agent host name in logging of agent commands

2013-08-01 Thread Prasanna Santhanam


> On Aug. 1, 2013, 12:06 p.m., Koushik Das wrote:
> > The changes look fine but I don't see much value with this as the name can 
> > be easily identified from the db. I feel the logs are used primarily for 
> > debugging issues. And one key aspect that is missing currently is the 
> > correlation of logs. Currently when a API call is made to MS, it traverses 
> > through various layers in the MS and finally hitting the resource layer and 
> > then returns back with response. Logs gets generated from each layer but it 
> > is not very intuitive to relate them to API call. If there is a unique id 
> > (some kind of uuid) that gets appended to the logs for a specific API call 
> > then correlation becomes very easy.
> > 
> > I feel adding these kind of correlation would be much more useful.

I disagree on this slightly. Snooping into the db for debugging should be 
gradually deprecated as a practice. Have you ever needed to look into the xen 
datastore for finding something? The point is admins map their hostnames to DNS 
addresses in datacenters and having via: 15 (representation of cloudstack) in 
the debug log is less intuitive compared to having command via kvm-host-0102. 
If I see command X failed on the kvm-host-0102 all I'll do as an admin of the 
cloud would be to inspect kvm-host-0102 over ssh. If you have 14 there I'll go 
to w3schools.com and start learning SQL :)


- Prasanna


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13072/#review24435
---


On July 30, 2013, 5:37 p.m., Marcus Sorensen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13072/
> ---
> 
> (Updated July 30, 2013, 5:37 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Bugs: CLOUDSTACK-3872
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Print agent name when logging Commands sent to VM hosts. See bug description. 
>  I'm not super familiar with this code, so I'd like someone to look over it 
> and verify it's the right thing.
> 
> 
> Diffs
> -
> 
>   core/src/com/cloud/agent/transport/Request.java b0fa4cc 
>   server/src/com/cloud/agent/manager/AgentManagerImpl.java b157838 
> 
> Diff: https://reviews.apache.org/r/13072/diff/
> 
> 
> Testing
> ---
> 
> Tested on KVM zone, need help testing others.
> 
> 
> Thanks,
> 
> Marcus Sorensen
> 
>



Re: we like dev better then users :(

2013-08-01 Thread Daan Hoogland
Wido, I am not urging you or anybody to keep better track of this. It
is a marketing issue. That is the only point I am trying to make. I am
notorious at not reading user lists ever, myself.

DaanOps

On Thu, Aug 1, 2013 at 3:36 PM, Wido den Hollander  wrote:
> On 08/01/2013 03:31 PM, Daan Hoogland wrote:
>>
>> I think the following list speaks for itself
>>
>
> Although it's really good that you point this out I took the following
> decision for myself: I contribute to the project by resolving bugs and
> writing new features.
>
> In my case my colleague (Lennert) is subscribed to the users list and he
> watches that and sometimes asks me to look to something.
>
> For me it's not doable to keep track of both the users and dev list and work
> on $dayjob
>
> It's about shifting priorities and for me the dev list (which is hard
> enough) is my main priority.
>
> Wido
>
>
>> http://markmail.org/message/ap42zplnpenniqtd can't create VM after
>> upgrade from 3.0.2 to 4,1. Error Code: 533 Error text: Unable to
>> create a deploymentfor VM by William Jiang
>> http://markmail.org/message/wxe6oktgtxtvg6uk Setting up networking on
>> single machine by Philip Andrews
>> http://markmail.org/message/lrenopzjshkzfxbe MuleSoft by Len Bellemore
>> http://markmail.org/message/vicznsksl5k33uby VPC Issue with CS
>> 4.1/KVM/Openvswitch by Dinu Arateanu
>> http://markmail.org/message/nqw3abaplbzgutwz AMI Import questions by
>> Carlos Reategui
>> http://markmail.org/message/ny7wi4hpufe6j7wb windows vm lost static ip
>> config after xe-tools upgrade from 6.0.2 to 6.1 by William Jiang
>> http://markmail.org/message/camfk7jrekuzy2ge Cloud capacity by Jerry Jiang
>> http://markmail.org/message/apnzuex65qcijegl vms hang in expunged
>> state by Valery Ciareszka
>> http://markmail.org/message/apkldlvxvq2u2yvm few orphan disk on
>> primary storage (CS v3) by Pierre Benard
>> http://markmail.org/message/to5zyb3k6z6hd3sg ESXI support by Chitra
>> Manjunath
>> http://markmail.org/message/23ga4bseph6ruh4x ClassCastException for
>> Virtual Routers in Zones using Adv Networking by Boyer, Marc
>>
>> regards,
>> Daan
>>
>


Re: Review Request 13072: Print agent host name in logging of agent commands

2013-08-01 Thread Marcus Sorensen
I agree, that would be useful.

The issue im resolving here is that 1) not everyone who has access to look
at the logs and troubleshoot also has access to (or knows the schema of)
the database. There might be an issue with a KVM host, but the admin will
waste time manually hunting down which host the command went to because he
has no idea what "via:1237" means and 2) even with db access, its a major
pain to go hunt down the unencrypted db password(because its a long string
that's hard to memorize), log into the database, run a query, just to know
where to continue your debugging.

A little background: Most of the people who surf these logs aren't devs.
For us they are usually devs, but not cloudstack devs. Maybe UI guys or
some other consumer. It has happened several times where someone comes into
my office, points out an agent command, and says "any idea where that
went?". I pretty much have the numbers memorized by now, depending on the
zone, so I tell them which agent the command went to. Then they ask me
where I found that, and when I explain that this little "via: 85" means to
go log into the db and make an SQL query for vm_instance 85, I almost
always get some "gee that's useful, how was I ever supposed to know that"
response.

So I do agree that the correlations you mention would also be good, I
disagree with the idea that there is not much value in doing this.
On Aug 1, 2013 6:06 AM, "Koushik Das"  wrote:

>This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13072/
>
> The changes look fine but I don't see much value with this as the name can be 
> easily identified from the db. I feel the logs are used primarily for 
> debugging issues. And one key aspect that is missing currently is the 
> correlation of logs. Currently when a API call is made to MS, it traverses 
> through various layers in the MS and finally hitting the resource layer and 
> then returns back with response. Logs gets generated from each layer but it 
> is not very intuitive to relate them to API call. If there is a unique id 
> (some kind of uuid) that gets appended to the logs for a specific API call 
> then correlation becomes very easy.
>
> I feel adding these kind of correlation would be much more useful.
>
>
> - Koushik Das
>
> On July 30th, 2013, 5:37 p.m. UTC, Marcus Sorensen wrote:
>   Review request for cloudstack.
> By Marcus Sorensen.
>
> *Updated July 30, 2013, 5:37 p.m.*
>  *Bugs: * CLOUDSTACK-3872
>  *Repository: * cloudstack-git
> Description
>
> Print agent name when logging Commands sent to VM hosts. See bug description. 
>  I'm not super familiar with this code, so I'd like someone to look over it 
> and verify it's the right thing.
>
>   Testing
>
> Tested on KVM zone, need help testing others.
>
>   Diffs
>
>- core/src/com/cloud/agent/transport/Request.java (b0fa4cc)
>- server/src/com/cloud/agent/manager/AgentManagerImpl.java (b157838)
>
> View Diff 
>


Re: Open up ports beyond 80/443/8080 for downloading templates

2013-08-01 Thread Prasanna Santhanam
My mistake. Didn't read the bug report clearly. So mgmt server would
need to know ahead of time to allow ports considered safe by the admin
so it can program that during SecStorageSetupCommand. 

On Wed, Jul 31, 2013 at 04:41:16PM +, Min Chen wrote:
> Hi Prasanna,
> 
>   I think what Tom and I mentioned is the url provided in registering a
> template, which is totally different from the endpoint.url for the object
> store. I still could not understand your suggestion.
> 
>   Thanks
>   -min
> 
> On 7/31/13 2:47 AM, "Prasanna Santhanam"  wrote:
> 
> >What can be done is to include into validateUrl the port provided in
> >the endpoint.url from addImageStore API . That will satisfy both
> >objectstore and NFS based storage. The unorthodox port that comes from
> >object store will anyway be closed on the SSVM so it will return a
> >connection-refused.
> >
> >Would that solve the problem albeit in a hacky way?
> >
> >In the future we could dissociate the dependency of the ports for
> >download from the validity of the url generated itself.
> >
> >On Wed, Jul 31, 2013 at 02:58:43PM +0900, Thomas O'Dowd wrote:
> >> I guess what I still don't understand is why restrict urls to certain
> >> ports? If the ports are not open it will cause an error. If the ports
> >> are open it will work (assuming the protocol is implemented on that
> >> port). For example, for register template if I choose a closed port then
> >> give me a connection error and ask me to try again. Even a currently
> >> valid port such as 8080 may be closed so it's the same thing really.
> >> Anyway, if I read Prasanna's mail correctly, it seems like there used to
> >> be a reason but its probably no harm to open things up?
> >> 
> >> Tom.
> >> 
> >> On Tue, 2013-07-30 at 16:41 +, Min Chen wrote:
> >> > Prasanna,
> >> >  Based on your comment, what will happen if we remove that check and
> >>still
> >> > NFS as secondary storage? In that case, register template is still
> >>done
> >> > through
> >> > SSVM. Any side effect? I had the same question as Tom when I was doing
> >> > object store refactoring, but hesitated to remove it because of not
> >> > knowing the history of it.
> >> > 
> >> >  Thanks
> >> >  -min
> >> > 
> >> > On 7/29/13 11:45 PM, "Prasanna Santhanam"  wrote:
> >> > 
> >> > >On Tue, Jul 30, 2013 at 03:37:39PM +0900, Thomas O'Dowd wrote:
> >> > >> Thanks Ian. I had a look at this file. It's an easy fix to remove
> >>the
> >> > >> check from here but it's a general utility function so will also
> >>affect
> >> > >> other uris... If there is no reason to limit any uri to those
> >>ports then
> >> > >> I'd like to remove this check and open them up.
> >> > >> 
> >> > >> Interested to hear opinions,
> >> > >
> >> > >This is probably because earlier one would interact only with the
> >>SSVM
> >> > >to download any images off of secondary storage. With 4.2 that
> >>ability
> >> > >is transferred to the image store like say s3/cloudian and one can
> >>get
> >> > >direct http access to the image on the object store. The code in
> >> > >validateUrl assumes that the url check goes always to the SSVM on
> >> > >which only 80/443/8080 are open by default.
> >> > >
> >> > >-- 
> >> > >Prasanna.,
> >> > >
> >> > >
> >> > >Powered by BigRock.com
> >> > >
> >> > 
> >> 
> >> -- 
> >> Cloudian KK - http://www.cloudian.com/get-started.html
> >> Fancy 100TB of full featured S3 Storage?
> >> Checkout the Cloudian?? Community Edition!
> >
> >-- 
> >Prasanna.,
> >
> >
> >Powered by BigRock.com
> >

-- 
Prasanna.,


Powered by BigRock.com



Re: [ACS42] Release Status Update: After Code Freeze Next Steps

2013-08-01 Thread Wido den Hollander

On 07/30/2013 09:25 PM, Animesh Chaturvedi wrote:


Folks code freeze was on 7/29 and starting today we are moving ACS 42 into 
limited updates in preparation for RC on 8/19. Code changes are now limited to 
fixes to blocker and critical bugs only. I need to follow up on doc and 
translations.




Shouldn't master now be bumped to 4.3?

Wido


There is a tremendous effort going on since last couple of weeks to fix issues 
found during the QA cycle. In last week alone 175 new issues were created and 
250 were resolved. The current unresolved issue count stands at 300+ with 60 
blocker and critical.

Given the high number of blocker and critical and that QA is still filing many 
defects I will follow what Chip did for 4.1 [1]. Up until when we cut the first 
RC on (2013-08-19) committers should continue to check in fixes to 4.2 branch 
for blocker and critical issues. Please do any fixes as cleanly as possible 
(i.e., squash related commits and make sure to avoid messy merge commits as 
much as possible).


For Contributors if you have a fix that needs to go into 4.2, please email the 
list with the subject tag [ACS42] and note the review that contains the patch.  
I'll pick whichever I can, but will also rely on others with commit rights to 
make it efficient.

I will review all commits going into that branch, and will revert anything 
that's outside the scope of that I outlined above (unless there is a discussion 
and consensus on this list to include something else).

There are large number of issues that are resolved but not verified yet. Given 
that the number is huge  with over 300 blocker and critical we need to 
prioritize and verify the ones that were returned by developers as ( Invalid, 
Incomplete, CanNotReproduce, Later, NotAProblem) first.  I have created a 
filter [2] to facilitate identifying these issues. This is no way means not to 
verify other issues but it is to close on the ones that have the most 
likelihood of being reopened during verification.

[1] http://markmail.org/message/qkkxycablpsmogsx
[2] https://issues.apache.org/jira/issues/#?filter=12324570


Thanks
Animesh





Re: [ACS42] Release Status Update: After Code Freeze Next Steps

2013-08-01 Thread Chip Childers
On Thu, Aug 01, 2013 at 04:13:14PM +0200, Wido den Hollander wrote:
> On 07/30/2013 09:25 PM, Animesh Chaturvedi wrote:
> >
> >Folks code freeze was on 7/29 and starting today we are moving ACS 42 into 
> >limited updates in preparation for RC on 8/19. Code changes are now limited 
> >to fixes to blocker and critical bugs only. I need to follow up on doc and 
> >translations.
> >
> >
> 
> Shouldn't master now be bumped to 4.3?
> 
> Wido

Done:

# tools/build/setnextversion.sh -v 4.3.0-SNAPSHOT -b master


And edited deb/changelog

> 
> >There is a tremendous effort going on since last couple of weeks to fix 
> >issues found during the QA cycle. In last week alone 175 new issues were 
> >created and 250 were resolved. The current unresolved issue count stands at 
> >300+ with 60 blocker and critical.
> >
> >Given the high number of blocker and critical and that QA is still filing 
> >many defects I will follow what Chip did for 4.1 [1]. Up until when we cut 
> >the first RC on (2013-08-19) committers should continue to check in fixes to 
> >4.2 branch for blocker and critical issues. Please do any fixes as cleanly 
> >as possible (i.e., squash related commits and make sure to avoid messy merge 
> >commits as much as possible).
> >
> >
> >For Contributors if you have a fix that needs to go into 4.2, please email 
> >the list with the subject tag [ACS42] and note the review that contains the 
> >patch.  I'll pick whichever I can, but will also rely on others with commit 
> >rights to make it efficient.
> >
> >I will review all commits going into that branch, and will revert anything 
> >that's outside the scope of that I outlined above (unless there is a 
> >discussion and consensus on this list to include something else).
> >
> >There are large number of issues that are resolved but not verified yet. 
> >Given that the number is huge  with over 300 blocker and critical we need to 
> >prioritize and verify the ones that were returned by developers as ( 
> >Invalid, Incomplete, CanNotReproduce, Later, NotAProblem) first.  I have 
> >created a filter [2] to facilitate identifying these issues. This is no way 
> >means not to verify other issues but it is to close on the ones that have 
> >the most likelihood of being reopened during verification.
> >
> >[1] http://markmail.org/message/qkkxycablpsmogsx
> >[2] https://issues.apache.org/jira/issues/#?filter=12324570
> >
> >
> >Thanks
> >Animesh
> >
> 
> 


Re: upgrade path 4.1.1 -> 4.2/master

2013-08-01 Thread Harikrishna Patnala
My comments inline.

Thanks
Harikrishna
On 01-Aug-2013, at 7:05 PM, Daan Hoogland 
 wrote:

> Harikrishna,
> 
> I suppose I have to register those templates before upgrading; i.e. in
> the 4.1.1 version management server.
Yes. in 4.1.1 these templates are registered as USER templates. During upgrade 
to 4.2 these are converted to SYSTEM templates

> Is this procedure described somewhere?
Usually upgrade instructions are given in the release notes. 
For 4.1 upgrade you can look at Chapter 4 
http://cloudstack.apache.org/docs/en-US/Apache_CloudStack/4.1.0/html/Release_Notes/upgrade-instructions.html#upgrade-from-4.0-to-4.1

> Do I bake the templates myself first or should I use publicly offered 
> templates?
No need to prepare templates. I guess there is some discussion happening for 
place to download system templates.
You can download these templates from jenkins URL 
http://jenkins.cloudstack.org/view/master/job/build-systemvm-master/

> 
> thanks,
> Daan
> 
> On Thu, Aug 1, 2013 at 3:16 PM, Harikrishna Patnala
>  wrote:
>> Hi Daan,
>> Before upgrading to 4.2 we need to register the new system templates for 
>> each hypervisor with specific names so that during upgrade these new 
>> templates are set to the system vms.
>> It is mandatory to upgrade the system vm template if we want upgrade to 4.2.
>> 
>> Here seems like you have a Xen cluster. So you need to register xen system 
>> template with name systemvm-xenserver-4.2.
>> So for the existing clusters you need to register system vm template per 
>> hypervisor.
>> System template names are for each hypervisor are
>> 1) systemvm-xenserver-4.2
>> 2) systemvm-kvm-4.2
>> 3) systemvm-vmware-4.2
>> 4) systemvm-hyperv-4.2
>> 5) systemvm-lxc-4.2
>> 
>> Thank you
>> Harikrishna
>> 
>> On 01-Aug-2013, at 5:29 PM, Daan Hoogland  wrote:
>> 
>>> H,
>>> 
>>> I am testing an upgrade of my code for sdn based vpc private gateways
>>> (not in the mainstream code). It runs on a custom 4.1.1 based on the
>>> 4.1 branch. I have tested it against a 4.0 database and it upgrades
>>> fine.
>>> 
>>> Now I try to have a master version to which I applied my code to run
>>> against the same environment. I added
>>>   _upgradeMap.put("4.1.1", new DbUpgrade[] {new Upgrade410to420()});
>>> to the class com.cloud.upgrade.DatabaseUpgradeChecker.
>>> I have the systemvm.iso ready on the hypervisors, but not on my
>>> (windows) development machine. When I start my version in eclipse I
>>> get
>>> 
>>> INFO  [c.c.u.DatabaseUpgradeChecker] (Timer-2:null) Database upgrade
>>> must be performed from 4.1.1 to 4.2.0-SNAPSHOT
>>> WARN  [c.c.u.d.Upgrade410to420] (Timer-2:null) 4.2.0 Hyperv SystemVm
>>> template not found. Hyperv hypervisor is not used, so not failing
>>> upgrade
>>> WARN  [c.c.u.d.Upgrade410to420] (Timer-2:null) 4.2.0 KVM SystemVm
>>> template not found. KVM hypervisor is not used, so not failing upgrade
>>> ERROR [c.c.u.DatabaseUpgradeChecker] (Timer-2:null) Unable to upgrade
>>> the database
>>> com.cloud.utils.exception.CloudRuntimeException: 4.2.0 XenServer
>>> SystemVm template not found. Cannot upgrade system Vms
>>> at 
>>> com.cloud.upgrade.dao.Upgrade410to420.updateSystemVmTemplates(Upgrade410to420.java:259)
>>> ...
>>> ERROR [c.c.u.c.ComponentContext] (Timer-2:null) System integrity check
>>> failed. Refuse to startup
>>> com.cloud.utils.exception.CloudRuntimeException: Unable to upgrade the 
>>> database
>>> at 
>>> com.cloud.upgrade.DatabaseUpgradeChecker.upgrade(DatabaseUpgradeChecker.java:296)
>>> ...
>>> Caused by: com.cloud.utils.exception.CloudRuntimeException: 4.2.0
>>> XenServer SystemVm template not found. Cannot upgrade system Vms
>>> at 
>>> com.cloud.upgrade.dao.Upgrade410to420.updateSystemVmTemplates(Upgrade410to420.java:259)
>>> ...
>>> ... 5 more
>>> 2013-07-31 21:50:50.802:INFO::Shutdown hook executing
>>> 
>>> I found that vm_template should contain a line for this;
>>> 
>>>   //Get 4.2.0 system Vm template Id for
>>> corresponding hypervisor
>>>   pstmt = conn.prepareStatement("select id from
>>> `cloud`.`vm_template` where name = ? and removed is null order by id
>>> desc limit 1");
>>>   pstmt.setString(1, hypervisorAndTemplateName.getValue());
>>>   rs = pstmt.executeQuery();
>>> 
>>> Should I add a row by hand?
>>> Is there a readme/howto-upgrade, I should read (or create using my 
>>> findings)?
>>> Why is this not automatic this time?
>>> 
>>> sorry if I missed the mail thread explaining all of this,
>>> Daan Hoogland
>> 



Re: [4.1] getVMPassword > how to decrypt

2013-08-01 Thread Harikrishna Patnala
Yes the password is encrypted with public key of ssh key pair assigned to the 
guest VM during deployment.
We can decrypt it using the private key of that key pair.

-Harikrishna

On 01-Aug-2013, at 3:13 AM, Chiradeep Vittal 
mailto:chiradeep.vit...@citrix.com>> wrote:

Isn't this encrypted with the ssh keys of the user? (createSshKeyPair)

From: Antonio Petrocelli 
mailto:a.petroce...@netsons.com>>
Reply-To: mailto:dev@cloudstack.apache.org>>
Date: Tuesday, July 30, 2013 2:46 AM
To: mailto:dev@cloudstack.apache.org>>
Subject: [4.1] getVMPassword > how to decrypt

Hello,

http://cloudstack.apache.org/docs/api/apidocs-4.1/domain_admin/getVMPassword.html

after retrieved the password i'm unable to decrypt the encryptedpassword.

Suggestions?

Thanks.

Regards.
--



Supernova s.r.l.
Via G. Misiticoni, 3
65126 - Pescara
ITALY

www.netsons.com
Antonio Petrocelli
Software Engineer


t. (+39) 085 45 100 52
e. a.petroce...@netsons.com





Netsons® è un marchio registrato dalla Supernova s.r.l.

Le informazioni trasmesse sono riservate alla persona o alla società indicata 
come destinatario, e possono includere contenuti considerati confidenziali. 
Ogni elaborazione, comunicazione, trasmissione o altro utilizzo, anche azioni 
conseguenti alla conoscenza di queste informazioni da parte di chiunque non sia 
espressamente indicato come destinatario è proibita. Nel caso abbiate ricevuto 
per errore questa comunicazione, siete pregati di darne avviso a info [at] 
netsons.com ed eliminare ogni stampa ed ogni traccia 
informatica. Il ricevente dovrà inoltre accertarsi che gli eventuali allegati 
non contengano virus prima di aprirli. Qualunque opinione o affermazione 
presentata in questo messaggio è da ritenersi propria dell'autore e non 
rappresenta necessariamente la posizione della Società.

The information transmitted is intended only for the person or entity to which 
it is addressed and may contain confidential material. Any review, 
retransmission, dissemination or other use of, or taking of any action in 
reliance upon this information by persons or entities other than the intended 
recipient is prohibited. If you received this in error, please contact: info 
[at] netsons.com and delete the material from any computer. 
If this email contains attachments you should ensure they are checked for 
viruses before opening them. Any views or opinions presented are solely those 
of the author and do not necessarily represent those of the company.



Review Request 13192: create private network test

2013-08-01 Thread daan Hoogland

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13192/
---

Review request for cloudstack, Koushik Das and Sheng Yang.


Bugs: CLOUDSTACK-1532


Repository: cloudstack-git


Description
---

This is a unit test I have been carrying in my work on CLOUDSTACK-1532. It 
occurred to me it can be submitted separately.


Diffs
-

  server/test/com/cloud/network/CreatePrivateNetworkTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/13192/diff/


Testing
---


Thanks,

daan Hoogland



Re: Review Request 12958: Automation test failure: can't attach volume to a stopped created VM. Fix the null pointer

2013-08-01 Thread Rajesh Battala

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12958/#review24442
---

Ship it!


Ship It!

- Rajesh Battala


On July 31, 2013, 10:10 p.m., Fang Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12958/
> ---
> 
> (Updated July 31, 2013, 10:10 p.m.)
> 
> 
> Review request for cloudstack, edison su and Prasanna Santhanam.
> 
> 
> Bugs: CLOUDSTACK-3759
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> When the new VM is created and put in stopped state, the volume and pool is 
> not allocated. Hence the NPE. 
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/storage/VolumeManagerImpl.java d7d62b0 
> 
> Diff: https://reviews.apache.org/r/12958/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Fang Wang
> 
>



Re: upgrade path 4.1.1 -> 4.2/master

2013-08-01 Thread Daan Hoogland
I have allready run master against this dev env, and added the
mentioned entry in the upgrade map. Now I cannot access the database
using 4.1.1 anymore because of
ERROR [agent.manager.AgentManagerImpl] (AgentTaskPool-1:) Monitor
StoragePoolMonitor says there is an error in the connect process for 3
due to DB Exception on:
com.mysql.jdbc.JDBC4PreparedStatement@4171352e: SELECT
storage_pool.id, storage_pool.name, storage_pool.uuid,
storage_pool.pool_type, storage_pool.created, storage_pool.removed,
storage_pool.update_time, storage_pool.data_center_id,
storage_pool.pod_id, storage_pool.available_bytes,
storage_pool.capacity_bytes, storage_pool.status, storage_pool.scope,
storage_pool.storage_provider_id, storage_pool.host_address,
storage_pool.path, storage_pool.port, storage_pool.user_info,
storage_pool.cluster_id FROM storage_pool WHERE
storage_pool.data_center_id = 1  AND  ( storage_pool.pod_id IS NULL
OR storage_pool.pod_id = 1  )  AND  ( storage_pool.cluster_id IS NULL
OR storage_pool.cluster_id = 1  )  AND storage_pool.removed IS NULL
com.cloud.utils.exception.CloudRuntimeException: DB Exception on:
com.mysql.jdbc.JDBC4PreparedStatement@4171352e: SELECT
storage_pool.id, storage_pool.name, storage_pool.uuid,
storage_pool.pool_type, storage_pool.created, storage_pool.removed,
storage_pool.update_time, storage_pool.data_center_id,
storage_pool.pod_id, storage_pool.available_bytes,
storage_pool.capacity_bytes, storage_pool.status, storage_pool.scope,
storage_pool.storage_provider_id, storage_pool.host_address,
storage_pool.path, storage_pool.port, storage_pool.user_info,
storage_pool.cluster_id FROM storage_pool WHERE
storage_pool.data_center_id = 1  AND  ( storage_pool.pod_id IS NULL
OR storage_pool.pod_id = 1  )  AND  ( storage_pool.cluster_id IS NULL
OR storage_pool.cluster_id = 1  )  AND storage_pool.removed IS NULL
at 
com.cloud.utils.db.GenericDaoBase.searchIncludingRemoved(GenericDaoBase.java:415)
at 
com.cloud.utils.component.ComponentInstantiationPostProcessor$InterceptorDispatcher.intercept(ComponentInstantiationPostProcessor.java:125)
at 
com.cloud.utils.db.GenericDaoBase.searchIncludingRemoved(GenericDaoBase.java:350)
...
Caused by: com.mysql.jdbc.exceptions.jdbc4.MySQLSyntaxErrorException:
Unknown column 'storage_pool.available_bytes' in 'field list'
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)

any change I can salvage this installation to run with master? I.E.
add the templates outside cloudstack somehow? (and promise I will
never do it again)


On Thu, Aug 1, 2013 at 4:43 PM, Harikrishna Patnala
 wrote:
> My comments inline.
>
> Thanks
> Harikrishna
> On 01-Aug-2013, at 7:05 PM, Daan Hoogland 
>  wrote:
>
>> Harikrishna,
>>
>> I suppose I have to register those templates before upgrading; i.e. in
>> the 4.1.1 version management server.
> Yes. in 4.1.1 these templates are registered as USER templates. During 
> upgrade to 4.2 these are converted to SYSTEM templates
>
>> Is this procedure described somewhere?
> Usually upgrade instructions are given in the release notes.
> For 4.1 upgrade you can look at Chapter 4 
> http://cloudstack.apache.org/docs/en-US/Apache_CloudStack/4.1.0/html/Release_Notes/upgrade-instructions.html#upgrade-from-4.0-to-4.1
>
>> Do I bake the templates myself first or should I use publicly offered 
>> templates?
> No need to prepare templates. I guess there is some discussion happening for 
> place to download system templates.
> You can download these templates from jenkins URL 
> http://jenkins.cloudstack.org/view/master/job/build-systemvm-master/
>
>>
>> thanks,
>> Daan
>>
>> On Thu, Aug 1, 2013 at 3:16 PM, Harikrishna Patnala
>>  wrote:
>>> Hi Daan,
>>> Before upgrading to 4.2 we need to register the new system templates for 
>>> each hypervisor with specific names so that during upgrade these new 
>>> templates are set to the system vms.
>>> It is mandatory to upgrade the system vm template if we want upgrade to 4.2.
>>>
>>> Here seems like you have a Xen cluster. So you need to register xen system 
>>> template with name systemvm-xenserver-4.2.
>>> So for the existing clusters you need to register system vm template per 
>>> hypervisor.
>>> System template names are for each hypervisor are
>>> 1) systemvm-xenserver-4.2
>>> 2) systemvm-kvm-4.2
>>> 3) systemvm-vmware-4.2
>>> 4) systemvm-hyperv-4.2
>>> 5) systemvm-lxc-4.2
>>>
>>> Thank you
>>> Harikrishna
>>>
>>> On 01-Aug-2013, at 5:29 PM, Daan Hoogland  wrote:
>>>
 H,

 I am testing an upgrade of my code for sdn based vpc private gateways
 (not in the mainstream code). It runs on a custom 4.1.1 based on the
 4.1 branch. I have tested it against a 4.0 database and it upgrades
 fine.

 Now I try to have a master version to which I applied my code to run
 against the same environment. I added
   _upgradeMap.put("4.1.1", new DbUpgrade[] {new Upgrade410to420()});
 to the class com.cloud.upgrade.DatabaseUpgradeChecker.
 I have the systemvm.i

Re: Review Request 13192: create private network test

2013-08-01 Thread Jenkins Cloudstack.org

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13192/#review24443
---


Review 13192 failed the build test : FAILURE
The url of build cloudstack-master-with-patch #102 is : 
http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/102/

- Jenkins Cloudstack.org


On Aug. 1, 2013, 2:52 p.m., daan Hoogland wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13192/
> ---
> 
> (Updated Aug. 1, 2013, 2:52 p.m.)
> 
> 
> Review request for cloudstack, Koushik Das and Sheng Yang.
> 
> 
> Bugs: CLOUDSTACK-1532
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> This is a unit test I have been carrying in my work on CLOUDSTACK-1532. It 
> occurred to me it can be submitted separately.
> 
> 
> Diffs
> -
> 
>   server/test/com/cloud/network/CreatePrivateNetworkTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/13192/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> daan Hoogland
> 
>



Re: Review Request 13189: CLOUDSTACK-4001: Unable to deploy Windows server 2012 64 bit VM on xenserver 6.2.

2013-08-01 Thread Abhinandan Prateek

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13189/#review2
---

Ship it!


Ship It!

- Abhinandan Prateek


On Aug. 1, 2013, 7:54 a.m., Sanjay Tripathi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13189/
> ---
> 
> (Updated Aug. 1, 2013, 7:54 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Devdeep Singh.
> 
> 
> Bugs: CLOUDSTACK-4001
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-4001: Unable to deploy Windows server 2012 64 bit VM on xenserver 
> 6.2
> 
> 
> Diffs
> -
> 
>   
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixHelper.java
>  0d93d83 
> 
> Diff: https://reviews.apache.org/r/13189/diff/
> 
> 
> Testing
> ---
> 
> Verified the fix by deploying the Windows server 2012(64 bit) VM on XenServer 
> 6.2 successfully on local cloudstack setup.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>



Re: Review Request 13189: CLOUDSTACK-4001: Unable to deploy Windows server 2012 64 bit VM on xenserver 6.2.

2013-08-01 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13189/#review24445
---


Commit ec9a797b4c80b6f2c9c02d19a23305933cad4977 in branch refs/heads/master 
from Sanjay Tripathi
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=ec9a797 ]

CLOUDSTACK-4001: Unable to deploy Windows server 2012 64 bit VM on xenserver 6.2

Signed-off-by: Abhinandan Prateek 


- ASF Subversion and Git Services


On Aug. 1, 2013, 7:54 a.m., Sanjay Tripathi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13189/
> ---
> 
> (Updated Aug. 1, 2013, 7:54 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Devdeep Singh.
> 
> 
> Bugs: CLOUDSTACK-4001
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-4001: Unable to deploy Windows server 2012 64 bit VM on xenserver 
> 6.2
> 
> 
> Diffs
> -
> 
>   
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixHelper.java
>  0d93d83 
> 
> Diff: https://reviews.apache.org/r/13189/diff/
> 
> 
> Testing
> ---
> 
> Verified the fix by deploying the Windows server 2012(64 bit) VM on XenServer 
> 6.2 successfully on local cloudstack setup.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>



Re: Review Request 13189: CLOUDSTACK-4001: Unable to deploy Windows server 2012 64 bit VM on xenserver 6.2.

2013-08-01 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13189/#review24446
---


Commit 47803c21fb66acf786a3c6df99596c41f621b4fe in branch refs/heads/4.2 from 
Sanjay Tripathi
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=47803c2 ]

CLOUDSTACK-4001: Unable to deploy Windows server 2012 64 bit VM on xenserver 6.2

Signed-off-by: Abhinandan Prateek 


- ASF Subversion and Git Services


On Aug. 1, 2013, 7:54 a.m., Sanjay Tripathi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13189/
> ---
> 
> (Updated Aug. 1, 2013, 7:54 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Devdeep Singh.
> 
> 
> Bugs: CLOUDSTACK-4001
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-4001: Unable to deploy Windows server 2012 64 bit VM on xenserver 
> 6.2
> 
> 
> Diffs
> -
> 
>   
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixHelper.java
>  0d93d83 
> 
> Diff: https://reviews.apache.org/r/13189/diff/
> 
> 
> Testing
> ---
> 
> Verified the fix by deploying the Windows server 2012(64 bit) VM on XenServer 
> 6.2 successfully on local cloudstack setup.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>



Re: [Publican] What version to use?

2013-08-01 Thread Chip Childers
Ilya,

Were you able to sort this out?  I'm holding off on the announcement of
the release until we get the docs online.


On Wed, Jul 31, 2013 at 10:48:34PM +, Musayev, Ilya wrote:
> David,
> 
> El6 is using 2.1.0, let me try out 2.8.2
> 
> Thanks
> ilya
> 
> 
> > -Original Message-
> > From: David Nalley [mailto:da...@gnsa.us]
> > Sent: Wednesday, July 31, 2013 5:42 PM
> > To: dev@cloudstack.apache.org
> > Subject: Re: [Publican] What version to use?
> > 
> > On Wed, Jul 31, 2013 at 4:43 PM, Musayev, Ilya 
> > wrote:
> > 
> > > What version of publican do we use?
> > >
> > > I recently rendered all docs for ACS 4.1.1 release and notices minor
> > > background inconsistencies along with many warning.
> > >
> > > Eventually, it all builds and very much similar to what we have
> > > online, but perhaps some is different in my version that causes this
> > > issue. I'm using latest publican from epel for centos6.
> > >
> > > Thanks
> > > ilya
> > >
> > 
> > I am using 2.8.2 - no idea what version is in el6.
> > 
> > --David
> 
> 


Re: Review Request 13112: upgrade to ASF 4.2 "cloud" Database Schema Inconsistencies on the Upgraded Setup - Table "volumes"

2013-08-01 Thread bharat kumar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13112/
---

(Updated Aug. 1, 2013, 4:34 p.m.)


Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.


Changes
---

rebased with 4.2


Bugs: Cloudstack-3836


Repository: cloudstack-git


Description
---

upgrade to ASF 4.2  "cloud" Database Schema Inconsistencies on the Upgraded 
Setup - Table "volumes"
https://issues.apache.org/jira/browse/CLOUDSTACK-3836

This extra column is because of the fix 
Parent id of template incorrectly recorded as last ISO attached to VM.

when a template is created form the snapshot the sourcetemplateid is recorded 
as the iso attached to the VM at thee time of creation. 

we fix this by adding a iso_id column to the volume table. when a template is 
created from the snapshot we fetch the iso_id form the parent volume and set it 
as the sourcetemplated id of the newly created template.


Diffs (updated)
-

  engine/schema/src/com/cloud/storage/VolumeVO.java 1445e99 
  server/src/com/cloud/storage/VolumeManager.java 2e44a3c 
  server/src/com/cloud/storage/VolumeManagerImpl.java d8cbf11 
  server/src/com/cloud/template/TemplateManagerImpl.java 8ccc567 
  server/src/com/cloud/vm/VirtualMachineManagerImpl.java eedf4d2 
  setup/db/db/schema-410to420.sql 3f25c3b 

Diff: https://reviews.apache.org/r/13112/diff/


Testing
---

Tested on 4.2.


Thanks,

bharat kumar



Re: Review Request 13112: upgrade to ASF 4.2 "cloud" Database Schema Inconsistencies on the Upgraded Setup - Table "volumes"

2013-08-01 Thread bharat kumar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13112/
---

(Updated Aug. 1, 2013, 4:51 p.m.)


Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.


Changes
---

rebased with master.


Bugs: Cloudstack-3836


Repository: cloudstack-git


Description
---

upgrade to ASF 4.2  "cloud" Database Schema Inconsistencies on the Upgraded 
Setup - Table "volumes"
https://issues.apache.org/jira/browse/CLOUDSTACK-3836

This extra column is because of the fix 
Parent id of template incorrectly recorded as last ISO attached to VM.

when a template is created form the snapshot the sourcetemplateid is recorded 
as the iso attached to the VM at thee time of creation. 

we fix this by adding a iso_id column to the volume table. when a template is 
created from the snapshot we fetch the iso_id form the parent volume and set it 
as the sourcetemplated id of the newly created template.


Diffs (updated)
-

  engine/schema/src/com/cloud/storage/VolumeVO.java 1445e99 
  server/src/com/cloud/storage/VolumeManager.java 13ddbab 
  server/src/com/cloud/storage/VolumeManagerImpl.java 3cce8b6 
  server/src/com/cloud/template/TemplateManagerImpl.java d26ebe2 
  server/src/com/cloud/vm/VirtualMachineManagerImpl.java 5b7aa5b 
  setup/db/db/schema-307to410.sql be6c17d 
  setup/db/db/schema-410to420.sql 99a0208 

Diff: https://reviews.apache.org/r/13112/diff/


Testing
---

Tested on 4.2.


Thanks,

bharat kumar



RE: [DISCUSS] Should we be releasing -beta releases?

2013-08-01 Thread Musayev, Ilya
Daan and Hugo,

This is just my opinion, you should consider merging this feature into master 
when time allows - this way you don't have to maintain a private branch of ACS 
in the future. Just my two cents :)

Regards
ilya

> -Original Message-
> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
> Sent: Thursday, August 01, 2013 4:13 AM
> To: dev
> Subject: Re: [DISCUSS] Should we be releasing -beta releases?
> 
> On Thu, Aug 1, 2013 at 12:46 AM, Musayev, Ilya 
> wrote:
> > The reason why CloudSand was created, was to bring in urgently needed
> features into stable version, such that on the next major upgrade to ACS, all
> features work as expected and nothing should break.
> This is the same that we have done. Except that we have put work into
> CLOUDSTACK-1532 that was urgently needed internally at Schuberg Philis. It
> is implemented in 4.1.1-SBP a private release. I have ported it to master
> several times but testing and paralel development on other network
> features have prevented it from being merged in master.
> 
> > What features are we talking about?
> 
> I gues our focus is hastening our own development and not backporting.
> 
> regards,
> Daan




RE: [DISCUSS] Should we be releasing -beta releases?

2013-08-01 Thread Alex Huang
+1

If it's due to company specific issues (licensing or company secret).  Maybe we 
can propose a plugin interface for it and see if you can keep just that code 
private.

Just look at how much master have changed from 4.2.  If we can we should try 
not to fork on the core code in cloudstack.  Maintaining will be tough.

--Alex

> -Original Message-
> From: Musayev, Ilya [mailto:imusa...@webmd.net]
> Sent: Thursday, August 1, 2013 9:51 AM
> To: dev@cloudstack.apache.org
> Subject: RE: [DISCUSS] Should we be releasing -beta releases?
> 
> Daan and Hugo,
> 
> This is just my opinion, you should consider merging this feature into master
> when time allows - this way you don't have to maintain a private branch of
> ACS in the future. Just my two cents :)
> 
> Regards
> ilya
> 
> > -Original Message-
> > From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
> > Sent: Thursday, August 01, 2013 4:13 AM
> > To: dev
> > Subject: Re: [DISCUSS] Should we be releasing -beta releases?
> >
> > On Thu, Aug 1, 2013 at 12:46 AM, Musayev, Ilya 
> > wrote:
> > > The reason why CloudSand was created, was to bring in urgently
> > > needed
> > features into stable version, such that on the next major upgrade to
> > ACS, all features work as expected and nothing should break.
> > This is the same that we have done. Except that we have put work into
> > CLOUDSTACK-1532 that was urgently needed internally at Schuberg
> > Philis. It is implemented in 4.1.1-SBP a private release. I have
> > ported it to master several times but testing and paralel development
> > on other network features have prevented it from being merged in master.
> >
> > > What features are we talking about?
> >
> > I gues our focus is hastening our own development and not backporting.
> >
> > regards,
> > Daan
> 



Re: Review Request 13112: upgrade to ASF 4.2 "cloud" Database Schema Inconsistencies on the Upgraded Setup - Table "volumes"

2013-08-01 Thread bharat kumar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13112/
---

(Updated Aug. 1, 2013, 5:08 p.m.)


Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.


Changes
---

Missed a change while rebasing with 4.2


Bugs: Cloudstack-3836


Repository: cloudstack-git


Description
---

upgrade to ASF 4.2  "cloud" Database Schema Inconsistencies on the Upgraded 
Setup - Table "volumes"
https://issues.apache.org/jira/browse/CLOUDSTACK-3836

This extra column is because of the fix 
Parent id of template incorrectly recorded as last ISO attached to VM.

when a template is created form the snapshot the sourcetemplateid is recorded 
as the iso attached to the VM at thee time of creation. 

we fix this by adding a iso_id column to the volume table. when a template is 
created from the snapshot we fetch the iso_id form the parent volume and set it 
as the sourcetemplated id of the newly created template.


Diffs (updated)
-

  engine/schema/src/com/cloud/storage/VolumeVO.java 1445e99 
  server/src/com/cloud/storage/VolumeManager.java 2e44a3c 
  server/src/com/cloud/storage/VolumeManagerImpl.java d8cbf11 
  server/src/com/cloud/template/TemplateManagerImpl.java 8ccc567 
  server/src/com/cloud/vm/VirtualMachineManagerImpl.java eedf4d2 
  setup/db/db/schema-307to410.sql be6c17d 
  setup/db/db/schema-410to420.sql 3f25c3b 

Diff: https://reviews.apache.org/r/13112/diff/


Testing
---

Tested on 4.2.


Thanks,

bharat kumar



[Discuss] Making CloudMonkey simpler to use for admin tasks

2013-08-01 Thread Donal Lafferty
I needed a different configuration than DevCloud provided, so I turned to 
CloudMonkey to automate setup of my test environment.

This led to a blog on automating with CloudMonkey at 
http://dlafferty.blogspot.co.uk/2013/07/using-cloudmonkey-to-automate.html

What I forgot to mention is that automation would be a lot simpler if we were 
to do the following:

1.   Update Apache CloudStack logging to provide API calls in a tidy format 
that can be fed directly.  E.g. POST parameters are not logged,  GET parameters 
are URL encoded.

2.   Update CloudMonkey to allow username / password authentication

3.   Update CloudMonkey to not be picky about the case of command 
parameters when 'api' command used.

4.   Update CloudMonkey to allow filter option to be used with 'api' 
command.






RE: we like dev better then users :(

2013-08-01 Thread Alex Huang
Daan,

This is a great service you're providing to the community!  I will go to my 
management and see if we can lend some support in terms of following up on your 
list.  Do you want to tag it so if I do get some resources, we have an easy way 
to filter in your report?

--Alex

> -Original Message-
> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
> Sent: Thursday, August 1, 2013 6:41 AM
> To: dev
> Subject: Re: we like dev better then users :(
> 
> Wido, I am not urging you or anybody to keep better track of this. It is a
> marketing issue. That is the only point I am trying to make. I am notorious at
> not reading user lists ever, myself.
> 
> DaanOps
> 
> On Thu, Aug 1, 2013 at 3:36 PM, Wido den Hollander 
> wrote:
> > On 08/01/2013 03:31 PM, Daan Hoogland wrote:
> >>
> >> I think the following list speaks for itself
> >>
> >
> > Although it's really good that you point this out I took the following
> > decision for myself: I contribute to the project by resolving bugs and
> > writing new features.
> >
> > In my case my colleague (Lennert) is subscribed to the users list and
> > he watches that and sometimes asks me to look to something.
> >
> > For me it's not doable to keep track of both the users and dev list
> > and work on $dayjob
> >
> > It's about shifting priorities and for me the dev list (which is hard
> > enough) is my main priority.
> >
> > Wido
> >
> >
> >> http://markmail.org/message/ap42zplnpenniqtd can't create VM after
> >> upgrade from 3.0.2 to 4,1. Error Code: 533 Error text: Unable to
> >> create a deploymentfor VM by William Jiang
> >> http://markmail.org/message/wxe6oktgtxtvg6uk Setting up networking
> on
> >> single machine by Philip Andrews
> >> http://markmail.org/message/lrenopzjshkzfxbe MuleSoft by Len
> >> Bellemore http://markmail.org/message/vicznsksl5k33uby VPC Issue with
> >> CS 4.1/KVM/Openvswitch by Dinu Arateanu
> >> http://markmail.org/message/nqw3abaplbzgutwz AMI Import questions
> by
> >> Carlos Reategui http://markmail.org/message/ny7wi4hpufe6j7wb
> windows
> >> vm lost static ip config after xe-tools upgrade from 6.0.2 to 6.1 by
> >> William Jiang http://markmail.org/message/camfk7jrekuzy2ge Cloud
> >> capacity by Jerry Jiang http://markmail.org/message/apnzuex65qcijegl
> >> vms hang in expunged state by Valery Ciareszka
> >> http://markmail.org/message/apkldlvxvq2u2yvm few orphan disk on
> >> primary storage (CS v3) by Pierre Benard
> >> http://markmail.org/message/to5zyb3k6z6hd3sg ESXI support by Chitra
> >> Manjunath http://markmail.org/message/23ga4bseph6ruh4x
> >> ClassCastException for Virtual Routers in Zones using Adv Networking
> >> by Boyer, Marc
> >>
> >> regards,
> >> Daan
> >>
> >


Re: we like dev better then users :(

2013-08-01 Thread Kelcey Jamison Damage
You can always send them over to IRC where I am. Usually it's easier to handle 
support in real-time.

- Original Message -
From: "Alex Huang" 
To: dev@cloudstack.apache.org
Sent: Thursday, August 1, 2013 10:15:08 AM
Subject: RE: we like dev better then users :(

Daan,

This is a great service you're providing to the community!  I will go to my 
management and see if we can lend some support in terms of following up on your 
list.  Do you want to tag it so if I do get some resources, we have an easy way 
to filter in your report?

--Alex

> -Original Message-
> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
> Sent: Thursday, August 1, 2013 6:41 AM
> To: dev
> Subject: Re: we like dev better then users :(
> 
> Wido, I am not urging you or anybody to keep better track of this. It is a
> marketing issue. That is the only point I am trying to make. I am notorious at
> not reading user lists ever, myself.
> 
> DaanOps
> 
> On Thu, Aug 1, 2013 at 3:36 PM, Wido den Hollander 
> wrote:
> > On 08/01/2013 03:31 PM, Daan Hoogland wrote:
> >>
> >> I think the following list speaks for itself
> >>
> >
> > Although it's really good that you point this out I took the following
> > decision for myself: I contribute to the project by resolving bugs and
> > writing new features.
> >
> > In my case my colleague (Lennert) is subscribed to the users list and
> > he watches that and sometimes asks me to look to something.
> >
> > For me it's not doable to keep track of both the users and dev list
> > and work on $dayjob
> >
> > It's about shifting priorities and for me the dev list (which is hard
> > enough) is my main priority.
> >
> > Wido
> >
> >
> >> http://markmail.org/message/ap42zplnpenniqtd can't create VM after
> >> upgrade from 3.0.2 to 4,1. Error Code: 533 Error text: Unable to
> >> create a deploymentfor VM by William Jiang
> >> http://markmail.org/message/wxe6oktgtxtvg6uk Setting up networking
> on
> >> single machine by Philip Andrews
> >> http://markmail.org/message/lrenopzjshkzfxbe MuleSoft by Len
> >> Bellemore http://markmail.org/message/vicznsksl5k33uby VPC Issue with
> >> CS 4.1/KVM/Openvswitch by Dinu Arateanu
> >> http://markmail.org/message/nqw3abaplbzgutwz AMI Import questions
> by
> >> Carlos Reategui http://markmail.org/message/ny7wi4hpufe6j7wb
> windows
> >> vm lost static ip config after xe-tools upgrade from 6.0.2 to 6.1 by
> >> William Jiang http://markmail.org/message/camfk7jrekuzy2ge Cloud
> >> capacity by Jerry Jiang http://markmail.org/message/apnzuex65qcijegl
> >> vms hang in expunged state by Valery Ciareszka
> >> http://markmail.org/message/apkldlvxvq2u2yvm few orphan disk on
> >> primary storage (CS v3) by Pierre Benard
> >> http://markmail.org/message/to5zyb3k6z6hd3sg ESXI support by Chitra
> >> Manjunath http://markmail.org/message/23ga4bseph6ruh4x
> >> ClassCastException for Virtual Routers in Zones using Adv Networking
> >> by Boyer, Marc
> >>
> >> regards,
> >> Daan
> >>
> >


Re: FW: CS 4.1.0 - this will help a number of people who struggle with Advanced Networking

2013-08-01 Thread Marcus Sorensen
I'm short on time, but here's the KVM advanced networking config we
use for testing. If someone wants to write a doc based around it that
would be nice.

Start out KVM host with two networks, eth0, eth1. eth0 is intended for
public traffic, eth0 will be guest vlans and management vlan. then
create a bridge interface for each:

[root@devcloud-kvm ~]# brctl show
bridge name bridge id STP enabled interfaces
cloud0 8000. no
br0 8000.5254004eff4f no eth0
br1 8000.52540052b15e no eth1

br0  Link encap:Ethernet  HWaddr 52:54:00:4E:FF:4F
  inet addr:172.17.10.10  Bcast:172.17.10.255  Mask:255.255.255.0
  inet6 addr: fe80::5054:ff:fe4e:ff4f/64 Scope:Link
  UP BROADCAST RUNNING MULTICAST  MTU:1500  Metric:1
  RX packets:127 errors:0 dropped:0 overruns:0 frame:0
  TX packets:30 errors:0 dropped:0 overruns:0 carrier:0
  collisions:0 txqueuelen:0
  RX bytes:5846 (5.7 KiB)  TX bytes:4345 (4.2 KiB)

br1  Link encap:Ethernet  HWaddr 52:54:00:52:B1:5E
  inet addr:192.168.100.10  Bcast:192.168.100.255  Mask:255.255.255.0
  inet6 addr: fe80::5054:ff:fe52:b15e/64 Scope:Link
  UP BROADCAST RUNNING MULTICAST  MTU:1500  Metric:1
  RX packets:343 errors:0 dropped:0 overruns:0 frame:0
  TX packets:153 errors:0 dropped:0 overruns:0 carrier:0
  collisions:0 txqueuelen:0
  RX bytes:24227 (23.6 KiB)  TX bytes:29108 (28.4 KiB)

eth0  Link encap:Ethernet  HWaddr 52:54:00:4E:FF:4F
  inet6 addr: fe80::5054:ff:fe4e:ff4f/64 Scope:Link
  UP BROADCAST RUNNING MULTICAST  MTU:1500  Metric:1
  RX packets:157 errors:0 dropped:0 overruns:0 frame:0
  TX packets:38 errors:0 dropped:0 overruns:0 carrier:0
  collisions:0 txqueuelen:1000
  RX bytes:12276 (11.9 KiB)  TX bytes:4897 (4.7 KiB)

eth1  Link encap:Ethernet  HWaddr 52:54:00:52:B1:5E
  inet6 addr: fe80::5054:ff:fe52:b15e/64 Scope:Link
  UP BROADCAST RUNNING MULTICAST  MTU:1500  Metric:1
  RX packets:377 errors:0 dropped:0 overruns:0 frame:0
  TX packets:163 errors:0 dropped:0 overruns:0 carrier:0
  collisions:0 txqueuelen:1000
  RX bytes:34044 (33.2 KiB)  TX bytes:29748 (29.0 KiB)

loLink encap:Local Loopback
  inet addr:127.0.0.1  Mask:255.0.0.0
  inet6 addr: ::1/128 Scope:Host
  UP LOOPBACK RUNNING  MTU:16436  Metric:1
  RX packets:863 errors:0 dropped:0 overruns:0 frame:0
  TX packets:863 errors:0 dropped:0 overruns:0 carrier:0
  collisions:0 txqueuelen:0
  RX bytes:120247 (117.4 KiB)  TX bytes:120247 (117.4 KiB)

Ok, now kvm host is ready. Just define the kvm traffic label for
Management traffic to be 'br0', for guest to be 'br0', and for public
to be 'br1'. Cloudstack will create any necessary bridges or vlans.
You can leave the vlan option empty if you don't want it to create a
vlan (say for management). I can perhaps go into more detail later.

On Wed, Jul 31, 2013 at 12:33 PM, Marcus Sorensen  wrote:
> Yes, that's correct. I think we need to update the documentation. The
> user simply needs to create a bridge where 'public' traffic will work,
> and then set that bridge name as the traffic label for public traffic.
> Then it will create the vlan device and the bridge necessary for
> public based on the physical ethernet device of that bridge.
>
> Note, in this example, it is only looking for cloudVirBr for
> compatibility, if there are existing cloudVirBr bridges then the agent
> will continue to create cloudVirBr bridges, otherwise, it will create
> breth bridges, which allow the same vlan number on different physical
> interfaces.
>
> We can easily create some concrete examples for this... such as the
> one represented in devcloud-kvm by
> tools/devcloud-kvm/devcloud-kvm-advanced.cfg
>
> On Wed, Jul 31, 2013 at 12:06 PM, Edison Su  wrote:
>> The KVM installation guide at 
>> http://cloudstack.apache.org/docs/en-US/Apache_CloudStack/4.1.0/html/Installation_Guide/hypervisor-kvm-install-flow.html
>>  , is unnecessary complicated and inaccurate.
>> For example, we don't need to configure vlan on kvm host by users 
>> themselves, cloudstack-agent will create vlans automatically.
>> All users need to do is to create bridges(if the default bridge created by 
>> cloudstack-agent is not enough), then add these bridge names from cloudstack 
>> mgt server UI during the zone creation.
>>
>> -Original Message-
>> From: Noel Kendall [mailto:noeldkend...@hotmail.com]
>> Sent: Wednesday, July 31, 2013 9:49 AM
>> To: us...@cloudstack.apache.org
>> Subject: CS 4.1.0 - this will help a number of people who struggle with 
>> Advanced Networking
>>
>> The documentation for installation in a KVM environment is utterly 
>> misleading.
>> The documentation reads as though one can set up the bridge for the public 
>> network with any name one chooses, the default being cloudbr0.
>> You cannot use just any old name. 

Re: Review Request 12905: Multiple VLAN range API need to accept a list rather than "add" or "remove" per command

2013-08-01 Thread Alena Prokharchyk

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12905/#review24452
---

Ship it!


Ship It!

- Alena Prokharchyk


On July 31, 2013, 3:07 p.m., bharat kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12905/
> ---
> 
> (Updated July 31, 2013, 3:07 p.m.)
> 
> 
> Review request for cloudstack, Alena Prokharchyk and Sheng Yang.
> 
> 
> Bugs: Cloudstack-3753
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> https://issues.apache.org/jira/browse/CLOUDSTACK-3753
> Multiple VLAN range API need to accept a list rather than "add" or "remove" 
> per command
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/network/NetworkService.java 59ccdbf 
>   
> api/src/org/apache/cloudstack/api/command/admin/network/UpdatePhysicalNetworkCmd.java
>  333564e 
>   engine/schema/src/com/cloud/dc/dao/DataCenterVnetDao.java e2e6b79 
>   engine/schema/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java ced2982 
>   engine/schema/src/com/cloud/network/dao/PhysicalNetworkVO.java f68eee1 
>   server/src/com/cloud/network/NetworkServiceImpl.java f1f71ca 
>   server/test/com/cloud/network/MockNetworkManagerImpl.java 4577d0a 
>   server/test/com/cloud/network/UpdatePhysicalNetworkTest.java e3fc36a 
>   server/test/com/cloud/vpc/MockNetworkManagerImpl.java fd61bc6 
> 
> Diff: https://reviews.apache.org/r/12905/diff/
> 
> 
> Testing
> ---
> 
> Tested on master.
> removed the removevlan parameter.
> vlan parameter can be used for both addition and removal of valns.
> instead of passing only a vlan range. user has to pass all the vlan ranges 
> that he wants to keep.
> the vlan ranges missing in the input and present in the db (not allocated) 
> will be removed.
> 
> 
> Thanks,
> 
> bharat kumar
> 
>



Re: Review Request 13112: upgrade to ASF 4.2 "cloud" Database Schema Inconsistencies on the Upgraded Setup - Table "volumes"

2013-08-01 Thread bharat kumar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13112/
---

(Updated Aug. 1, 2013, 6:01 p.m.)


Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.


Changes
---

rebased with master


Bugs: Cloudstack-3836


Repository: cloudstack-git


Description
---

upgrade to ASF 4.2  "cloud" Database Schema Inconsistencies on the Upgraded 
Setup - Table "volumes"
https://issues.apache.org/jira/browse/CLOUDSTACK-3836

This extra column is because of the fix 
Parent id of template incorrectly recorded as last ISO attached to VM.

when a template is created form the snapshot the sourcetemplateid is recorded 
as the iso attached to the VM at thee time of creation. 

we fix this by adding a iso_id column to the volume table. when a template is 
created from the snapshot we fetch the iso_id form the parent volume and set it 
as the sourcetemplated id of the newly created template.


Diffs (updated)
-

  engine/schema/src/com/cloud/storage/VolumeVO.java 1445e99 
  server/src/com/cloud/storage/VolumeManager.java 13ddbab 
  server/src/com/cloud/storage/VolumeManagerImpl.java 3cce8b6 
  server/src/com/cloud/template/TemplateManagerImpl.java d26ebe2 
  server/src/com/cloud/vm/VirtualMachineManagerImpl.java 5b7aa5b 
  setup/db/db/schema-307to410.sql be6c17d 
  setup/db/db/schema-410to420.sql 99a0208 

Diff: https://reviews.apache.org/r/13112/diff/


Testing
---

Tested on 4.2.


Thanks,

bharat kumar



Re: upgrade path 4.1.1 -> 4.2/master

2013-08-01 Thread Harikrishna Patnala
Have you taken the DB dump before trying to upgrade.
Then you can build CS in 4.1.1 and apply the dump.

-Harikrishna

On 01-Aug-2013, at 8:42 PM, Daan Hoogland  wrote:

> I have allready run master against this dev env, and added the
> mentioned entry in the upgrade map. Now I cannot access the database
> using 4.1.1 anymore because of
> ERROR [agent.manager.AgentManagerImpl] (AgentTaskPool-1:) Monitor
> StoragePoolMonitor says there is an error in the connect process for 3
> due to DB Exception on:
> com.mysql.jdbc.JDBC4PreparedStatement@4171352e: SELECT
> storage_pool.id, storage_pool.name, storage_pool.uuid,
> storage_pool.pool_type, storage_pool.created, storage_pool.removed,
> storage_pool.update_time, storage_pool.data_center_id,
> storage_pool.pod_id, storage_pool.available_bytes,
> storage_pool.capacity_bytes, storage_pool.status, storage_pool.scope,
> storage_pool.storage_provider_id, storage_pool.host_address,
> storage_pool.path, storage_pool.port, storage_pool.user_info,
> storage_pool.cluster_id FROM storage_pool WHERE
> storage_pool.data_center_id = 1  AND  ( storage_pool.pod_id IS NULL
> OR storage_pool.pod_id = 1  )  AND  ( storage_pool.cluster_id IS NULL
> OR storage_pool.cluster_id = 1  )  AND storage_pool.removed IS NULL
> com.cloud.utils.exception.CloudRuntimeException: DB Exception on:
> com.mysql.jdbc.JDBC4PreparedStatement@4171352e: SELECT
> storage_pool.id, storage_pool.name, storage_pool.uuid,
> storage_pool.pool_type, storage_pool.created, storage_pool.removed,
> storage_pool.update_time, storage_pool.data_center_id,
> storage_pool.pod_id, storage_pool.available_bytes,
> storage_pool.capacity_bytes, storage_pool.status, storage_pool.scope,
> storage_pool.storage_provider_id, storage_pool.host_address,
> storage_pool.path, storage_pool.port, storage_pool.user_info,
> storage_pool.cluster_id FROM storage_pool WHERE
> storage_pool.data_center_id = 1  AND  ( storage_pool.pod_id IS NULL
> OR storage_pool.pod_id = 1  )  AND  ( storage_pool.cluster_id IS NULL
> OR storage_pool.cluster_id = 1  )  AND storage_pool.removed IS NULL
> at 
> com.cloud.utils.db.GenericDaoBase.searchIncludingRemoved(GenericDaoBase.java:415)
> at 
> com.cloud.utils.component.ComponentInstantiationPostProcessor$InterceptorDispatcher.intercept(ComponentInstantiationPostProcessor.java:125)
> at 
> com.cloud.utils.db.GenericDaoBase.searchIncludingRemoved(GenericDaoBase.java:350)
> ...
> Caused by: com.mysql.jdbc.exceptions.jdbc4.MySQLSyntaxErrorException:
> Unknown column 'storage_pool.available_bytes' in 'field list'
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
> 
> any change I can salvage this installation to run with master? I.E.
> add the templates outside cloudstack somehow? (and promise I will
> never do it again)
> 
> 
> On Thu, Aug 1, 2013 at 4:43 PM, Harikrishna Patnala
>  wrote:
>> My comments inline.
>> 
>> Thanks
>> Harikrishna
>> On 01-Aug-2013, at 7:05 PM, Daan Hoogland 
>> wrote:
>> 
>>> Harikrishna,
>>> 
>>> I suppose I have to register those templates before upgrading; i.e. in
>>> the 4.1.1 version management server.
>> Yes. in 4.1.1 these templates are registered as USER templates. During 
>> upgrade to 4.2 these are converted to SYSTEM templates
>> 
>>> Is this procedure described somewhere?
>> Usually upgrade instructions are given in the release notes.
>> For 4.1 upgrade you can look at Chapter 4 
>> http://cloudstack.apache.org/docs/en-US/Apache_CloudStack/4.1.0/html/Release_Notes/upgrade-instructions.html#upgrade-from-4.0-to-4.1
>> 
>>> Do I bake the templates myself first or should I use publicly offered 
>>> templates?
>> No need to prepare templates. I guess there is some discussion happening for 
>> place to download system templates.
>> You can download these templates from jenkins URL 
>> http://jenkins.cloudstack.org/view/master/job/build-systemvm-master/
>> 
>>> 
>>> thanks,
>>> Daan
>>> 
>>> On Thu, Aug 1, 2013 at 3:16 PM, Harikrishna Patnala
>>>  wrote:
 Hi Daan,
 Before upgrading to 4.2 we need to register the new system templates for 
 each hypervisor with specific names so that during upgrade these new 
 templates are set to the system vms.
 It is mandatory to upgrade the system vm template if we want upgrade to 
 4.2.
 
 Here seems like you have a Xen cluster. So you need to register xen system 
 template with name systemvm-xenserver-4.2.
 So for the existing clusters you need to register system vm template per 
 hypervisor.
 System template names are for each hypervisor are
 1) systemvm-xenserver-4.2
 2) systemvm-kvm-4.2
 3) systemvm-vmware-4.2
 4) systemvm-hyperv-4.2
 5) systemvm-lxc-4.2
 
 Thank you
 Harikrishna
 
 On 01-Aug-2013, at 5:29 PM, Daan Hoogland  wrote:
 
> H,
> 
> I am testing an upgrade of my code for sdn based vpc private gateways
> (not in the mainstream code). It runs on a custom 4.1.1 based on the
> 4.1 branch. I have t

Do we allow ENUM database types?

2013-08-01 Thread Wido den Hollander

Hi,

I'm working on a disk cache setting for per disk offering which allows 
users to set it to:

- none (current behaviour and default)
- writeback
- writethrough

I've done some work in the disk-cache branch [0] where I created a new 
column called "cache_mode" in the disk_offering table.


It's currently a varchar(32), but only 3 strings are allowed in the 
column, as listed above.


We don't use enums anywhere in the database, so I was wondering if there 
is a good reason for that?


Otherwise I think using a enum here would be a good use-case.

Wido




[0]: 
https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/disk-cache


RE: [Discuss] Making CloudMonkey simpler to use for admin tasks

2013-08-01 Thread Musayev, Ilya
Donal,

Thanks for the details and putting this together - this is definitely helpful 
and I'm bookmarking this.

Please post it on wiki as tutorial.

Regards
ilya

> -Original Message-
> From: Donal Lafferty [mailto:donal.laffe...@citrix.com]
> Sent: Thursday, August 01, 2013 1:13 PM
> To: dev@cloudstack.apache.org
> Subject: [Discuss] Making CloudMonkey simpler to use for admin tasks
> 
> I needed a different configuration than DevCloud provided, so I turned to
> CloudMonkey to automate setup of my test environment.
> 
> This led to a blog on automating with CloudMonkey at
> http://dlafferty.blogspot.co.uk/2013/07/using-cloudmonkey-to-
> automate.html
> 
> What I forgot to mention is that automation would be a lot simpler if we
> were to do the following:
> 
> 1.   Update Apache CloudStack logging to provide API calls in a tidy 
> format
> that can be fed directly.  E.g. POST parameters are not logged,  GET
> parameters are URL encoded.
> 
> 2.   Update CloudMonkey to allow username / password authentication
> 
> 3.   Update CloudMonkey to not be picky about the case of command
> parameters when 'api' command used.
> 
> 4.   Update CloudMonkey to allow filter option to be used with 'api'
> command.
> 
> 
> 




RE: Do we allow ENUM database types?

2013-08-01 Thread Alex Huang
Wido,

We actually have plenty of places that uses enums.  I think you're specifically 
talking about saving the ordinal values of an enum into the database.  You can 
do that easily by putting this annotation on the field.

@Enumerated(value=EnumType.ORDINAL)

The DB layer will take care of saving the ordinal value and retrieving and 
matching that value back to the enum.

With that said, I do want to point out that saving ordinal values have 
operational issues.  The biggest is people forget what they are and have to 
keep referring back to documents/code to figure out what it means.   The gain 
from saving a ordinal value vs the string value in indexing is fairly minimal 
due to the range of values being fairly limited in most enum definitions.  
Therefore, my preference is to save the String value instead.

To do that you can use this annotation.
@Enumerated(value=EnumType.STRING)

There's an example of it in HostVO.java with the Type enum.

--Alex


> -Original Message-
> From: Wido den Hollander [mailto:w...@widodh.nl]
> Sent: Thursday, August 1, 2013 11:12 AM
> To: dev@cloudstack.apache.org
> Subject: Do we allow ENUM database types?
> 
> Hi,
> 
> I'm working on a disk cache setting for per disk offering which allows users 
> to
> set it to:
> - none (current behaviour and default)
> - writeback
> - writethrough
> 
> I've done some work in the disk-cache branch [0] where I created a new
> column called "cache_mode" in the disk_offering table.
> 
> It's currently a varchar(32), but only 3 strings are allowed in the column, as
> listed above.
> 
> We don't use enums anywhere in the database, so I was wondering if there
> is a good reason for that?
> 
> Otherwise I think using a enum here would be a good use-case.
> 
> Wido
> 
> 
> 
> 
> [0]:
> https://git-wip-
> us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/disk-
> cache


Re: [DISCUSS] Should we be releasing -beta releases?

2013-08-01 Thread Daan Hoogland
:} it is due to master moving faster then me being all over the code.
I have ported it once again to master and am busy testing again. but
we need it and have just moved to 4.1.1. I agree with you Alex. So we
will not release our fork just the patch via the earliest main
release. (I could publish a 4.1.1 patch however)

On Thu, Aug 1, 2013 at 7:00 PM, Alex Huang  wrote:
> +1
>
> If it's due to company specific issues (licensing or company secret).  Maybe 
> we can propose a plugin interface for it and see if you can keep just that 
> code private.
>
> Just look at how much master have changed from 4.2.  If we can we should try 
> not to fork on the core code in cloudstack.  Maintaining will be tough.
>
> --Alex
>
>> -Original Message-
>> From: Musayev, Ilya [mailto:imusa...@webmd.net]
>> Sent: Thursday, August 1, 2013 9:51 AM
>> To: dev@cloudstack.apache.org
>> Subject: RE: [DISCUSS] Should we be releasing -beta releases?
>>
>> Daan and Hugo,
>>
>> This is just my opinion, you should consider merging this feature into master
>> when time allows - this way you don't have to maintain a private branch of
>> ACS in the future. Just my two cents :)
>>
>> Regards
>> ilya
>>
>> > -Original Message-
>> > From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
>> > Sent: Thursday, August 01, 2013 4:13 AM
>> > To: dev
>> > Subject: Re: [DISCUSS] Should we be releasing -beta releases?
>> >
>> > On Thu, Aug 1, 2013 at 12:46 AM, Musayev, Ilya 
>> > wrote:
>> > > The reason why CloudSand was created, was to bring in urgently
>> > > needed
>> > features into stable version, such that on the next major upgrade to
>> > ACS, all features work as expected and nothing should break.
>> > This is the same that we have done. Except that we have put work into
>> > CLOUDSTACK-1532 that was urgently needed internally at Schuberg
>> > Philis. It is implemented in 4.1.1-SBP a private release. I have
>> > ported it to master several times but testing and paralel development
>> > on other network features have prevented it from being merged in master.
>> >
>> > > What features are we talking about?
>> >
>> > I gues our focus is hastening our own development and not backporting.
>> >
>> > regards,
>> > Daan
>>
>


Re: we like dev better then users :(

2013-08-01 Thread Daan Hoogland
Alex, what do you mean by tag? Most of what I did is my personal
judgement, hardly any automation involved.

I hope we can give some folow up to this. I think the dev report is
useful. The users report is less useful however. I am lagging a week
behind. In most cases people would have answered if they had the
time/knowledge earlier.

What worries me most is the tone I see in messages on the users list.
I report only on messages that are not answered at all. Some others I
happened to stumble upon are polemic rants. Of course these are not
the 'average' users that will go to a dev list first, before tone down
their mails.

I do not know if we are equipped to handle this properly. One thing I
can do is find an earlier moment next week to make my report.

regards,
Daan


On Thu, Aug 1, 2013 at 7:24 PM, Kelcey Jamison Damage  wrote:
> You can always send them over to IRC where I am. Usually it's easier to 
> handle support in real-time.
>
> - Original Message -
> From: "Alex Huang" 
> To: dev@cloudstack.apache.org
> Sent: Thursday, August 1, 2013 10:15:08 AM
> Subject: RE: we like dev better then users :(
>
> Daan,
>
> This is a great service you're providing to the community!  I will go to my 
> management and see if we can lend some support in terms of following up on 
> your list.  Do you want to tag it so if I do get some resources, we have an 
> easy way to filter in your report?
>
> --Alex
>
>> -Original Message-
>> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
>> Sent: Thursday, August 1, 2013 6:41 AM
>> To: dev
>> Subject: Re: we like dev better then users :(
>>
>> Wido, I am not urging you or anybody to keep better track of this. It is a
>> marketing issue. That is the only point I am trying to make. I am notorious 
>> at
>> not reading user lists ever, myself.
>>
>> DaanOps
>>
>> On Thu, Aug 1, 2013 at 3:36 PM, Wido den Hollander 
>> wrote:
>> > On 08/01/2013 03:31 PM, Daan Hoogland wrote:
>> >>
>> >> I think the following list speaks for itself
>> >>
>> >
>> > Although it's really good that you point this out I took the following
>> > decision for myself: I contribute to the project by resolving bugs and
>> > writing new features.
>> >
>> > In my case my colleague (Lennert) is subscribed to the users list and
>> > he watches that and sometimes asks me to look to something.
>> >
>> > For me it's not doable to keep track of both the users and dev list
>> > and work on $dayjob
>> >
>> > It's about shifting priorities and for me the dev list (which is hard
>> > enough) is my main priority.
>> >
>> > Wido
>> >
>> >
>> >> http://markmail.org/message/ap42zplnpenniqtd can't create VM after
>> >> upgrade from 3.0.2 to 4,1. Error Code: 533 Error text: Unable to
>> >> create a deploymentfor VM by William Jiang
>> >> http://markmail.org/message/wxe6oktgtxtvg6uk Setting up networking
>> on
>> >> single machine by Philip Andrews
>> >> http://markmail.org/message/lrenopzjshkzfxbe MuleSoft by Len
>> >> Bellemore http://markmail.org/message/vicznsksl5k33uby VPC Issue with
>> >> CS 4.1/KVM/Openvswitch by Dinu Arateanu
>> >> http://markmail.org/message/nqw3abaplbzgutwz AMI Import questions
>> by
>> >> Carlos Reategui http://markmail.org/message/ny7wi4hpufe6j7wb
>> windows
>> >> vm lost static ip config after xe-tools upgrade from 6.0.2 to 6.1 by
>> >> William Jiang http://markmail.org/message/camfk7jrekuzy2ge Cloud
>> >> capacity by Jerry Jiang http://markmail.org/message/apnzuex65qcijegl
>> >> vms hang in expunged state by Valery Ciareszka
>> >> http://markmail.org/message/apkldlvxvq2u2yvm few orphan disk on
>> >> primary storage (CS v3) by Pierre Benard
>> >> http://markmail.org/message/to5zyb3k6z6hd3sg ESXI support by Chitra
>> >> Manjunath http://markmail.org/message/23ga4bseph6ruh4x
>> >> ClassCastException for Virtual Routers in Zones using Adv Networking
>> >> by Boyer, Marc
>> >>
>> >> regards,
>> >> Daan
>> >>
>> >


Re: upgrade path 4.1.1 -> 4.2/master

2013-08-01 Thread Daan Hoogland
I did a 4.0 -> 4.1.1 -> master
I can/will go back to 4.0 and report my findings tomorrow

On Thu, Aug 1, 2013 at 8:02 PM, Harikrishna Patnala
 wrote:
> Have you taken the DB dump before trying to upgrade.
> Then you can build CS in 4.1.1 and apply the dump.
>
> -Harikrishna
>
> On 01-Aug-2013, at 8:42 PM, Daan Hoogland  wrote:
>
>> I have allready run master against this dev env, and added the
>> mentioned entry in the upgrade map. Now I cannot access the database
>> using 4.1.1 anymore because of
>> ERROR [agent.manager.AgentManagerImpl] (AgentTaskPool-1:) Monitor
>> StoragePoolMonitor says there is an error in the connect process for 3
>> due to DB Exception on:
>> com.mysql.jdbc.JDBC4PreparedStatement@4171352e: SELECT
>> storage_pool.id, storage_pool.name, storage_pool.uuid,
>> storage_pool.pool_type, storage_pool.created, storage_pool.removed,
>> storage_pool.update_time, storage_pool.data_center_id,
>> storage_pool.pod_id, storage_pool.available_bytes,
>> storage_pool.capacity_bytes, storage_pool.status, storage_pool.scope,
>> storage_pool.storage_provider_id, storage_pool.host_address,
>> storage_pool.path, storage_pool.port, storage_pool.user_info,
>> storage_pool.cluster_id FROM storage_pool WHERE
>> storage_pool.data_center_id = 1  AND  ( storage_pool.pod_id IS NULL
>> OR storage_pool.pod_id = 1  )  AND  ( storage_pool.cluster_id IS NULL
>> OR storage_pool.cluster_id = 1  )  AND storage_pool.removed IS NULL
>> com.cloud.utils.exception.CloudRuntimeException: DB Exception on:
>> com.mysql.jdbc.JDBC4PreparedStatement@4171352e: SELECT
>> storage_pool.id, storage_pool.name, storage_pool.uuid,
>> storage_pool.pool_type, storage_pool.created, storage_pool.removed,
>> storage_pool.update_time, storage_pool.data_center_id,
>> storage_pool.pod_id, storage_pool.available_bytes,
>> storage_pool.capacity_bytes, storage_pool.status, storage_pool.scope,
>> storage_pool.storage_provider_id, storage_pool.host_address,
>> storage_pool.path, storage_pool.port, storage_pool.user_info,
>> storage_pool.cluster_id FROM storage_pool WHERE
>> storage_pool.data_center_id = 1  AND  ( storage_pool.pod_id IS NULL
>> OR storage_pool.pod_id = 1  )  AND  ( storage_pool.cluster_id IS NULL
>> OR storage_pool.cluster_id = 1  )  AND storage_pool.removed IS NULL
>> at 
>> com.cloud.utils.db.GenericDaoBase.searchIncludingRemoved(GenericDaoBase.java:415)
>> at 
>> com.cloud.utils.component.ComponentInstantiationPostProcessor$InterceptorDispatcher.intercept(ComponentInstantiationPostProcessor.java:125)
>> at 
>> com.cloud.utils.db.GenericDaoBase.searchIncludingRemoved(GenericDaoBase.java:350)
>> ...
>> Caused by: com.mysql.jdbc.exceptions.jdbc4.MySQLSyntaxErrorException:
>> Unknown column 'storage_pool.available_bytes' in 'field list'
>> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
>>
>> any change I can salvage this installation to run with master? I.E.
>> add the templates outside cloudstack somehow? (and promise I will
>> never do it again)
>>
>>
>> On Thu, Aug 1, 2013 at 4:43 PM, Harikrishna Patnala
>>  wrote:
>>> My comments inline.
>>>
>>> Thanks
>>> Harikrishna
>>> On 01-Aug-2013, at 7:05 PM, Daan Hoogland 
>>> wrote:
>>>
 Harikrishna,

 I suppose I have to register those templates before upgrading; i.e. in
 the 4.1.1 version management server.
>>> Yes. in 4.1.1 these templates are registered as USER templates. During 
>>> upgrade to 4.2 these are converted to SYSTEM templates
>>>
 Is this procedure described somewhere?
>>> Usually upgrade instructions are given in the release notes.
>>> For 4.1 upgrade you can look at Chapter 4 
>>> http://cloudstack.apache.org/docs/en-US/Apache_CloudStack/4.1.0/html/Release_Notes/upgrade-instructions.html#upgrade-from-4.0-to-4.1
>>>
 Do I bake the templates myself first or should I use publicly offered 
 templates?
>>> No need to prepare templates. I guess there is some discussion happening 
>>> for place to download system templates.
>>> You can download these templates from jenkins URL 
>>> http://jenkins.cloudstack.org/view/master/job/build-systemvm-master/
>>>

 thanks,
 Daan

 On Thu, Aug 1, 2013 at 3:16 PM, Harikrishna Patnala
  wrote:
> Hi Daan,
> Before upgrading to 4.2 we need to register the new system templates for 
> each hypervisor with specific names so that during upgrade these new 
> templates are set to the system vms.
> It is mandatory to upgrade the system vm template if we want upgrade to 
> 4.2.
>
> Here seems like you have a Xen cluster. So you need to register xen 
> system template with name systemvm-xenserver-4.2.
> So for the existing clusters you need to register system vm template per 
> hypervisor.
> System template names are for each hypervisor are
> 1) systemvm-xenserver-4.2
> 2) systemvm-kvm-4.2
> 3) systemvm-vmware-4.2
> 4) systemvm-hyperv-4.2
> 5) systemvm-lxc-4.2
>
> Thank you
> Harikrishna
>
>

Re: Do we allow ENUM database types?

2013-08-01 Thread Daan Hoogland
I agree with the string as db value. reordering or inserting a value,
which might make for a more logical order, will break backwards
compatibility using ordinals.

Daan

On Thu, Aug 1, 2013 at 10:43 PM, Alex Huang  wrote:
> Wido,
>
> We actually have plenty of places that uses enums.  I think you're 
> specifically talking about saving the ordinal values of an enum into the 
> database.  You can do that easily by putting this annotation on the field.
>
> @Enumerated(value=EnumType.ORDINAL)
>
> The DB layer will take care of saving the ordinal value and retrieving and 
> matching that value back to the enum.
>
> With that said, I do want to point out that saving ordinal values have 
> operational issues.  The biggest is people forget what they are and have to 
> keep referring back to documents/code to figure out what it means.   The gain 
> from saving a ordinal value vs the string value in indexing is fairly minimal 
> due to the range of values being fairly limited in most enum definitions.  
> Therefore, my preference is to save the String value instead.
>
> To do that you can use this annotation.
> @Enumerated(value=EnumType.STRING)
>
> There's an example of it in HostVO.java with the Type enum.
>
> --Alex
>
>
>> -Original Message-
>> From: Wido den Hollander [mailto:w...@widodh.nl]
>> Sent: Thursday, August 1, 2013 11:12 AM
>> To: dev@cloudstack.apache.org
>> Subject: Do we allow ENUM database types?
>>
>> Hi,
>>
>> I'm working on a disk cache setting for per disk offering which allows users 
>> to
>> set it to:
>> - none (current behaviour and default)
>> - writeback
>> - writethrough
>>
>> I've done some work in the disk-cache branch [0] where I created a new
>> column called "cache_mode" in the disk_offering table.
>>
>> It's currently a varchar(32), but only 3 strings are allowed in the column, 
>> as
>> listed above.
>>
>> We don't use enums anywhere in the database, so I was wondering if there
>> is a good reason for that?
>>
>> Otherwise I think using a enum here would be a good use-case.
>>
>> Wido
>>
>>
>>
>>
>> [0]:
>> https://git-wip-
>> us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/disk-
>> cache


Re: Review Request 13192: create private network test

2013-08-01 Thread Daan Hoogland
someone broke the jenkins patch submission builds with a checkin. I
think no patch passes jenkins anymore because of the usage server not
building anymore. The patch build in my env in two different branches
(master and my work branch). The

 Apache CloudStack Server4.6 sec << my changes
Apache CloudStack Test1.4 sec
 Apache CloudStack Usage Server1.6 sec  << broken!
 Apache CloudStack Utils1 min 21 sec

this seems to be the case since

Commit 03046b4b50725f3d7299eaebfa6f7704b5168058 by wido
upgrade: Add SQL file for 4.2 -> 4.3 upgrade
setup/db/db/schema-420to430.sql

three commits where put on top of it :(
regards,

On Thu, Aug 1, 2013 at 5:18 PM, Jenkins Cloudstack.org  wrote:
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13192/
>
> Review 13192 failed the build test : FAILURE
> The url of build cloudstack-master-with-patch #102 is :
> http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/102/
>
>
> - Jenkins Cloudstack.org
>
>
> On August 1st, 2013, 2:52 p.m. UTC, daan Hoogland wrote:
>
> Review request for cloudstack, Koushik Das and Sheng Yang.
> By daan Hoogland.
>
> Updated Aug. 1, 2013, 2:52 p.m.
>
> Bugs: CLOUDSTACK-1532
> Repository: cloudstack-git
>
> Description
>
> This is a unit test I have been carrying in my work on CLOUDSTACK-1532. It
> occurred to me it can be submitted separately.
>
> Diffs
>
> server/test/com/cloud/network/CreatePrivateNetworkTest.java (PRE-CREATION)
>
> View Diff


Re: FW: CS 4.1.0 - this will help a number of people who struggle with Advanced Networking

2013-08-01 Thread Marcus Sorensen
Here's a simple (not recommended) one-nic setup:

http://marcus.mlsorensen.com/cloudstack-extras/cs-4.1-kvm-networking-one-nic.rtf

And a simple two-nic setup:

http://marcus.mlsorensen.com/cloudstack-extras/cs-4.1-kvm-networking-two-nic.rtf

Hasty docs put together on the road...


On Thu, Aug 1, 2013 at 11:28 AM, Marcus Sorensen  wrote:
> I'm short on time, but here's the KVM advanced networking config we
> use for testing. If someone wants to write a doc based around it that
> would be nice.
>
> Start out KVM host with two networks, eth0, eth1. eth0 is intended for
> public traffic, eth0 will be guest vlans and management vlan. then
> create a bridge interface for each:
>
> [root@devcloud-kvm ~]# brctl show
> bridge name bridge id STP enabled interfaces
> cloud0 8000. no
> br0 8000.5254004eff4f no eth0
> br1 8000.52540052b15e no eth1
>
> br0  Link encap:Ethernet  HWaddr 52:54:00:4E:FF:4F
>   inet addr:172.17.10.10  Bcast:172.17.10.255  Mask:255.255.255.0
>   inet6 addr: fe80::5054:ff:fe4e:ff4f/64 Scope:Link
>   UP BROADCAST RUNNING MULTICAST  MTU:1500  Metric:1
>   RX packets:127 errors:0 dropped:0 overruns:0 frame:0
>   TX packets:30 errors:0 dropped:0 overruns:0 carrier:0
>   collisions:0 txqueuelen:0
>   RX bytes:5846 (5.7 KiB)  TX bytes:4345 (4.2 KiB)
>
> br1  Link encap:Ethernet  HWaddr 52:54:00:52:B1:5E
>   inet addr:192.168.100.10  Bcast:192.168.100.255  Mask:255.255.255.0
>   inet6 addr: fe80::5054:ff:fe52:b15e/64 Scope:Link
>   UP BROADCAST RUNNING MULTICAST  MTU:1500  Metric:1
>   RX packets:343 errors:0 dropped:0 overruns:0 frame:0
>   TX packets:153 errors:0 dropped:0 overruns:0 carrier:0
>   collisions:0 txqueuelen:0
>   RX bytes:24227 (23.6 KiB)  TX bytes:29108 (28.4 KiB)
>
> eth0  Link encap:Ethernet  HWaddr 52:54:00:4E:FF:4F
>   inet6 addr: fe80::5054:ff:fe4e:ff4f/64 Scope:Link
>   UP BROADCAST RUNNING MULTICAST  MTU:1500  Metric:1
>   RX packets:157 errors:0 dropped:0 overruns:0 frame:0
>   TX packets:38 errors:0 dropped:0 overruns:0 carrier:0
>   collisions:0 txqueuelen:1000
>   RX bytes:12276 (11.9 KiB)  TX bytes:4897 (4.7 KiB)
>
> eth1  Link encap:Ethernet  HWaddr 52:54:00:52:B1:5E
>   inet6 addr: fe80::5054:ff:fe52:b15e/64 Scope:Link
>   UP BROADCAST RUNNING MULTICAST  MTU:1500  Metric:1
>   RX packets:377 errors:0 dropped:0 overruns:0 frame:0
>   TX packets:163 errors:0 dropped:0 overruns:0 carrier:0
>   collisions:0 txqueuelen:1000
>   RX bytes:34044 (33.2 KiB)  TX bytes:29748 (29.0 KiB)
>
> loLink encap:Local Loopback
>   inet addr:127.0.0.1  Mask:255.0.0.0
>   inet6 addr: ::1/128 Scope:Host
>   UP LOOPBACK RUNNING  MTU:16436  Metric:1
>   RX packets:863 errors:0 dropped:0 overruns:0 frame:0
>   TX packets:863 errors:0 dropped:0 overruns:0 carrier:0
>   collisions:0 txqueuelen:0
>   RX bytes:120247 (117.4 KiB)  TX bytes:120247 (117.4 KiB)
>
> Ok, now kvm host is ready. Just define the kvm traffic label for
> Management traffic to be 'br0', for guest to be 'br0', and for public
> to be 'br1'. Cloudstack will create any necessary bridges or vlans.
> You can leave the vlan option empty if you don't want it to create a
> vlan (say for management). I can perhaps go into more detail later.
>
> On Wed, Jul 31, 2013 at 12:33 PM, Marcus Sorensen  wrote:
>> Yes, that's correct. I think we need to update the documentation. The
>> user simply needs to create a bridge where 'public' traffic will work,
>> and then set that bridge name as the traffic label for public traffic.
>> Then it will create the vlan device and the bridge necessary for
>> public based on the physical ethernet device of that bridge.
>>
>> Note, in this example, it is only looking for cloudVirBr for
>> compatibility, if there are existing cloudVirBr bridges then the agent
>> will continue to create cloudVirBr bridges, otherwise, it will create
>> breth bridges, which allow the same vlan number on different physical
>> interfaces.
>>
>> We can easily create some concrete examples for this... such as the
>> one represented in devcloud-kvm by
>> tools/devcloud-kvm/devcloud-kvm-advanced.cfg
>>
>> On Wed, Jul 31, 2013 at 12:06 PM, Edison Su  wrote:
>>> The KVM installation guide at 
>>> http://cloudstack.apache.org/docs/en-US/Apache_CloudStack/4.1.0/html/Installation_Guide/hypervisor-kvm-install-flow.html
>>>  , is unnecessary complicated and inaccurate.
>>> For example, we don't need to configure vlan on kvm host by users 
>>> themselves, cloudstack-agent will create vlans automatically.
>>> All users need to do is to create bridges(if the default bridge created by 
>>> cloudstack-agent is not enough), then add these bridge names from 
>>> cloudstack mgt server UI during the zone creation.
>>>
>>> -Original Message-
>>> From: Noel K

How to enforce data disk selection

2013-08-01 Thread Musayev, Ilya
How would one enforce data disk selection?

I don't want to leave data disk blank in UI.


Review Request 13198: Fixing cleanup issues with test_vpn_users.py; test case need to teardown all resources incase any failure in setup

2013-08-01 Thread Rayees Namathponnan

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13198/
---

Review request for cloudstack, Prasanna Santhanam and Sheng Yang.


Repository: cloudstack-git


Description
---

Fixing cleanup issues with test_vpn_users.py; test case need to teardown all 
resources incase any failure in setup


Diffs
-

  test/integration/component/test_vpn_users.py fe020d0 

Diff: https://reviews.apache.org/r/13198/diff/


Testing
---

Tested 


Thanks,

Rayees Namathponnan



RE: we like dev better then users :(

2013-08-01 Thread Alex Huang
Hi Daan,

Sorry I meant to subject tag your email so people who's interested in helping 
can easily get to them.

--Alex

> -Original Message-
> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
> Sent: Thursday, August 1, 2013 2:11 PM
> To: dev
> Subject: Re: we like dev better then users :(
> 
> Alex, what do you mean by tag? Most of what I did is my personal judgement,
> hardly any automation involved.
> 
> I hope we can give some folow up to this. I think the dev report is useful. 
> The
> users report is less useful however. I am lagging a week behind. In most
> cases people would have answered if they had the time/knowledge earlier.
> 
> What worries me most is the tone I see in messages on the users list.
> I report only on messages that are not answered at all. Some others I
> happened to stumble upon are polemic rants. Of course these are not the
> 'average' users that will go to a dev list first, before tone down their 
> mails.
> 
> I do not know if we are equipped to handle this properly. One thing I can do
> is find an earlier moment next week to make my report.
> 
> regards,
> Daan
> 
> 
> On Thu, Aug 1, 2013 at 7:24 PM, Kelcey Jamison Damage 
> wrote:
> > You can always send them over to IRC where I am. Usually it's easier to
> handle support in real-time.
> >
> > - Original Message -
> > From: "Alex Huang" 
> > To: dev@cloudstack.apache.org
> > Sent: Thursday, August 1, 2013 10:15:08 AM
> > Subject: RE: we like dev better then users :(
> >
> > Daan,
> >
> > This is a great service you're providing to the community!  I will go to my
> management and see if we can lend some support in terms of following up
> on your list.  Do you want to tag it so if I do get some resources, we have an
> easy way to filter in your report?
> >
> > --Alex
> >
> >> -Original Message-
> >> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
> >> Sent: Thursday, August 1, 2013 6:41 AM
> >> To: dev
> >> Subject: Re: we like dev better then users :(
> >>
> >> Wido, I am not urging you or anybody to keep better track of this. It
> >> is a marketing issue. That is the only point I am trying to make. I
> >> am notorious at not reading user lists ever, myself.
> >>
> >> DaanOps
> >>
> >> On Thu, Aug 1, 2013 at 3:36 PM, Wido den Hollander 
> >> wrote:
> >> > On 08/01/2013 03:31 PM, Daan Hoogland wrote:
> >> >>
> >> >> I think the following list speaks for itself
> >> >>
> >> >
> >> > Although it's really good that you point this out I took the
> >> > following decision for myself: I contribute to the project by
> >> > resolving bugs and writing new features.
> >> >
> >> > In my case my colleague (Lennert) is subscribed to the users list
> >> > and he watches that and sometimes asks me to look to something.
> >> >
> >> > For me it's not doable to keep track of both the users and dev list
> >> > and work on $dayjob
> >> >
> >> > It's about shifting priorities and for me the dev list (which is
> >> > hard
> >> > enough) is my main priority.
> >> >
> >> > Wido
> >> >
> >> >
> >> >> http://markmail.org/message/ap42zplnpenniqtd can't create VM after
> >> >> upgrade from 3.0.2 to 4,1. Error Code: 533 Error text: Unable to
> >> >> create a deploymentfor VM by William Jiang
> >> >> http://markmail.org/message/wxe6oktgtxtvg6uk Setting up
> networking
> >> on
> >> >> single machine by Philip Andrews
> >> >> http://markmail.org/message/lrenopzjshkzfxbe MuleSoft by Len
> >> >> Bellemore http://markmail.org/message/vicznsksl5k33uby VPC Issue
> >> >> with CS 4.1/KVM/Openvswitch by Dinu Arateanu
> >> >> http://markmail.org/message/nqw3abaplbzgutwz AMI Import
> questions
> >> by
> >> >> Carlos Reategui http://markmail.org/message/ny7wi4hpufe6j7wb
> >> windows
> >> >> vm lost static ip config after xe-tools upgrade from 6.0.2 to 6.1
> >> >> by William Jiang http://markmail.org/message/camfk7jrekuzy2ge
> >> >> Cloud capacity by Jerry Jiang
> >> >> http://markmail.org/message/apnzuex65qcijegl
> >> >> vms hang in expunged state by Valery Ciareszka
> >> >> http://markmail.org/message/apkldlvxvq2u2yvm few orphan disk on
> >> >> primary storage (CS v3) by Pierre Benard
> >> >> http://markmail.org/message/to5zyb3k6z6hd3sg ESXI support by
> >> >> Chitra Manjunath http://markmail.org/message/23ga4bseph6ruh4x
> >> >> ClassCastException for Virtual Routers in Zones using Adv
> >> >> Networking by Boyer, Marc
> >> >>
> >> >> regards,
> >> >> Daan
> >> >>
> >> >


Re: Review Request 13198: Fixing cleanup issues with test_vpn_users.py; test case need to teardown all resources incase any failure in setup

2013-08-01 Thread Jenkins Cloudstack.org

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13198/#review24488
---


Review 13198 failed the build test : FAILURE
The url of build cloudstack-master-with-patch #103 is : 
http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/103/

- Jenkins Cloudstack.org


On Aug. 1, 2013, 10:49 p.m., Rayees Namathponnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13198/
> ---
> 
> (Updated Aug. 1, 2013, 10:49 p.m.)
> 
> 
> Review request for cloudstack, Prasanna Santhanam and Sheng Yang.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fixing cleanup issues with test_vpn_users.py; test case need to teardown all 
> resources incase any failure in setup
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_vpn_users.py fe020d0 
> 
> Diff: https://reviews.apache.org/r/13198/diff/
> 
> 
> Testing
> ---
> 
> Tested 
> 
> 
> Thanks,
> 
> Rayees Namathponnan
> 
>



Re: Review Request 13198: Fixing cleanup issues with test_vpn_users.py; test case need to teardown all resources incase any failure in setup

2013-08-01 Thread Rayees Namathponnan

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13198/
---

(Updated Aug. 1, 2013, 11:21 p.m.)


Review request for cloudstack, Prasanna Santhanam and Sheng Yang.


Repository: cloudstack-git


Description
---

Fixing cleanup issues with test_vpn_users.py; test case need to teardown all 
resources incase any failure in setup


Diffs
-

  test/integration/component/test_vpn_users.py fe020d0 

Diff: https://reviews.apache.org/r/13198/diff/


Testing
---

Tested 


File Attachments (updated)


Updated cleanup part
  
https://reviews.apache.org/media/uploaded/files/2013/08/01/0001-Updated-according-to-review-command-in-13198.patch


Thanks,

Rayees Namathponnan



Re: Review Request 13198: Fixing cleanup issues with test_vpn_users.py; test case need to teardown all resources incase any failure in setup

2013-08-01 Thread Rayees Namathponnan

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13198/
---

(Updated Aug. 1, 2013, 11:31 p.m.)


Review request for cloudstack, Prasanna Santhanam and Sheng Yang.


Repository: cloudstack-git


Description
---

Fixing cleanup issues with test_vpn_users.py; test case need to teardown all 
resources incase any failure in setup


Diffs (updated)
-

  test/integration/component/test_vpn_users.py fe020d0 

Diff: https://reviews.apache.org/r/13198/diff/


Testing
---

Tested 


File Attachments


Updated cleanup part
  
https://reviews.apache.org/media/uploaded/files/2013/08/01/0001-Updated-according-to-review-command-in-13198.patch


Thanks,

Rayees Namathponnan



RE: How to fix libvirt storage pool refresh issue?

2013-08-01 Thread Edison Su
Hi Wei, regarding to the bug CLOUDSTACK-2729, I removed storage.refresh during 
getStoragePool in LibvirtStorageAdaptor, but the issue still happened in BVT.
I am thinking add file lock on primary storage, seems you already have the 
patch, could you share the patch with us?

> -Original Message-
> From: Wei ZHOU [mailto:ustcweiz...@gmail.com]
> Sent: Tuesday, July 16, 2013 3:35 AM
> To: dev@cloudstack.apache.org
> Subject: Re: How to fix libvirt storage pool refresh issue?
> 
> I agree with Wido.
> 
> Moreover, the file lock will cause performane degrade of VM deployment.
> 
> -Wei
> 
> 
> 2013/7/16 Wido den Hollander 
> 
> > On 07/16/2013 12:27 AM, Marcus Sorensen wrote:
> >
> >> I'm ok with a symptom fix on our end, if the root cause is in
> >> Libvirt we can't do much about that. This is the sort of patch that
> >> tends to get pulled into the regular update cycle of the
> >> distributions, so unless there's more to it and it's not a good fix I
> >> imagine we will see it come through without having to wait for the
> >> next point releases. We still have to support existing users who
> >> might not be running the latest, though, so the symptom fix is
> >> probably ok as a temporary measure.
> >>
> >
> > I'm ok with not calling storagePoolRefresh every time we want a
> > capacity update, since that's also kind of I/O intensive for larger storage
> arrays.
> >
> > However, we should make sure we have a GOOD comment in the code
> about
> > this "fix", since that's the reason I initially removed the old code
> > which invoked "df".
> >
> > I'll see if I can get this libvirt patch into Ubuntu when it hits
> > libvirt upstream, since this bug is really annoying.
> >
> > Wido
> >
> >
> >
> >> On Mon, Jul 15, 2013 at 3:42 PM, Edison Su  wrote:
> >>
> >>> There is a serious issue on KVM(https://issues.apache.org/**
> >>> jira/browse/CLOUDSTACK-
> 2729):
> >>> a libvirt storage pool can disappear on KVM host, it's easy to be
> >>> reproduced in our internal QA environment.
> >>> Wei found the root cause, is on the libvirt:
> >>> "
> >>> This is a libvirt issue. I created a ticket for it.
> >>> https://bugzilla.redhat.com/**show_bug.cgi?id=977706 >>> a.redhat.com/show_bug.cgi?id=977706>
> >>> The patch is very simple.
> >>> https://www.redhat.com/**archives/libvir-list/2013-**July/msg00635.h
> >>> tml >>> tml>
> >>> "
> >>> But it's also introduced by CloudStack, as cloudstack will call
> >>> libvirt storage pool refresh method each time when access the
> >>> storage pool. The code is added by commit:
> >>> 2ffc9907f7b0d371737e39b7649f7a**f23026f5cf,
> >>> about less than one year ago.
> >>>
> >>> As Wei suggested, we can call storage pool refresh only if needed,
> >>> it will mitigate the issue(It's behavior I did on cloudstack
> >>> pre-4.0), but it's only treat the symptom, not the cause.
> >>> Or add a cluster wide lock, only one guy can access storage pool at
> >>> one time, we can add a file lock on NFS primary storage.
> >>> Any idea/feedback on how to fix this KVM issue?
> >>>
> >>>
> >>>
> >>>
> >


Re: Review Request 13198: Fixing cleanup issues with test_vpn_users.py; test case need to teardown all resources incase any failure in setup

2013-08-01 Thread Rayees Namathponnan

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13198/
---

(Updated Aug. 2, 2013, 12:28 a.m.)


Review request for cloudstack, Prasanna Santhanam and Sheng Yang.


Changes
---

Updated Patch raise and added from marvin.cloudstackException import 
cloudstackAPIException


Repository: cloudstack-git


Description
---

Fixing cleanup issues with test_vpn_users.py; test case need to teardown all 
resources incase any failure in setup


Diffs (updated)
-

  test/integration/component/test_vpn_users.py fe020d0 

Diff: https://reviews.apache.org/r/13198/diff/


Testing
---

Tested 


File Attachments


Updated cleanup part
  
https://reviews.apache.org/media/uploaded/files/2013/08/01/0001-Updated-according-to-review-command-in-13198.patch


Thanks,

Rayees Namathponnan



Re: Review Request 13198: Fixing cleanup issues with test_vpn_users.py; test case need to teardown all resources incase any failure in setup

2013-08-01 Thread Sheng Yang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13198/#review24492
---

Ship it!


Ship It!

- Sheng Yang


On Aug. 2, 2013, 12:28 a.m., Rayees Namathponnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13198/
> ---
> 
> (Updated Aug. 2, 2013, 12:28 a.m.)
> 
> 
> Review request for cloudstack, Prasanna Santhanam and Sheng Yang.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fixing cleanup issues with test_vpn_users.py; test case need to teardown all 
> resources incase any failure in setup
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_vpn_users.py fe020d0 
> 
> Diff: https://reviews.apache.org/r/13198/diff/
> 
> 
> Testing
> ---
> 
> Tested 
> 
> 
> File Attachments
> 
> 
> Updated cleanup part
>   
> https://reviews.apache.org/media/uploaded/files/2013/08/01/0001-Updated-according-to-review-command-in-13198.patch
> 
> 
> Thanks,
> 
> Rayees Namathponnan
> 
>



Re: Review Request 12958: Automation test failure: can't attach volume to a stopped created VM. Fix the null pointer

2013-08-01 Thread edison su

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12958/#review24494
---

Ship it!


Ship It!

- edison su


On July 31, 2013, 10:10 p.m., Fang Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12958/
> ---
> 
> (Updated July 31, 2013, 10:10 p.m.)
> 
> 
> Review request for cloudstack, edison su and Prasanna Santhanam.
> 
> 
> Bugs: CLOUDSTACK-3759
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> When the new VM is created and put in stopped state, the volume and pool is 
> not allocated. Hence the NPE. 
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/storage/VolumeManagerImpl.java d7d62b0 
> 
> Diff: https://reviews.apache.org/r/12958/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Fang Wang
> 
>



Re: Review Request 13008: Fix usage of vm.instancename.flag when generating VM names on ESX hypervisor

2013-08-01 Thread Venkata Siva Vijayendra Bhamidipati

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13008/
---

(Updated Aug. 2, 2013, 12:49 a.m.)


Review request for cloudstack, Alex Huang, Chip Childers, Kelven Yang, Sateesh 
Chodapuneedi, and William Chan.


Changes
---

Uploading patch rebased against latest 4.2. This patch also corrects the 
vm.instancename.flag description in Config.java and the 410-420 schema upgrade 
sql script.


Bugs: CLOUDSTACK-3886


Repository: cloudstack-git


Description
---

The vminstancename flag has been incorrectly used to simply append the 
displayname to the internal VM name that shows up on vCenter in vmware 
deployments. It was intended to show the actual name supplied as hostname, on 
the hypervisor. This helps admins and deployers to quickly identify VMs and 
resolve issues related to those VMs. Its usage is very limited as it stands 
now. This fix corrects it to ensure that the name of the VM on the hypervisor 
matches the hostname if it is supplied, and if the vm.instancename.flag is set 
to true.


Diffs (updated)
-

  
engine/orchestration/src/org/apache/cloudstack/platform/orchestration/CloudOrchestrator.java
 96fb1d9 
  plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java 
292f7e9 
  
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
 8d6bdb8 
  
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
 10b6de9 
  
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 1216e17 
  
plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java
 112a0cb 
  server/src/com/cloud/configuration/Config.java 0d72694 
  server/src/com/cloud/ha/HighAvailabilityManagerImpl.java 25c5a04 
  server/src/com/cloud/hypervisor/HypervisorGuruBase.java e042eb8 
  server/src/com/cloud/vm/UserVmManagerImpl.java 4a222c4 
  server/src/com/cloud/vm/VirtualMachineManagerImpl.java 6d35539 
  setup/db/db/schema-410to420.sql 3f25c3b 
  vmware-base/src/com/cloud/hypervisor/vmware/mo/ClusterMO.java 04ef0f8 
  vmware-base/src/com/cloud/hypervisor/vmware/mo/CustomFieldConstants.java 
11bc157 
  vmware-base/src/com/cloud/hypervisor/vmware/mo/HostMO.java 2735fb0 
  vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java 
dd0f889 
  vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java e2dd789 
  vmware-base/src/com/cloud/hypervisor/vmware/mo/VmwareHypervisorHost.java 
ac14328 

Diff: https://reviews.apache.org/r/13008/diff/


Testing
---

Post this change, all major VM operations, namely 
creation/destruction/expunging/start/stop/reboot of the VM have been tested and 
observed to work correctly. Part of this patch also puts in a fix for VMSync 
operations where the CS mgmt server doesn't detect that a guest VM is down, if 
the guest VM has been shut down/powered off in vCenter. Other operations such 
as VM snapshot, volume snapshots of disks belonging to the VM, volume migration 
across primaries, volume attach/detach have also been tested and they are 
working as expected. This is a functional change, and completely transparent to 
any of cloudstack's existing functionalities and all the test cases that cover 
the above code paths and APIs - all existing tests should and do pass - no new 
tests are necessary.


Thanks,

Venkata Siva Vijayendra Bhamidipati



Re: Review Request 13198: Fixing cleanup issues with test_vpn_users.py; test case need to teardown all resources incase any failure in setup

2013-08-01 Thread Sheng Yang


> On Aug. 2, 2013, 12:29 a.m., Sheng Yang wrote:
> > Ship It!

Committed to 4.2 and MASTER.


- Sheng


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13198/#review24492
---


On Aug. 2, 2013, 12:28 a.m., Rayees Namathponnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13198/
> ---
> 
> (Updated Aug. 2, 2013, 12:28 a.m.)
> 
> 
> Review request for cloudstack, Prasanna Santhanam and Sheng Yang.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fixing cleanup issues with test_vpn_users.py; test case need to teardown all 
> resources incase any failure in setup
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_vpn_users.py fe020d0 
> 
> Diff: https://reviews.apache.org/r/13198/diff/
> 
> 
> Testing
> ---
> 
> Tested 
> 
> 
> File Attachments
> 
> 
> Updated cleanup part
>   
> https://reviews.apache.org/media/uploaded/files/2013/08/01/0001-Updated-according-to-review-command-in-13198.patch
> 
> 
> Thanks,
> 
> Rayees Namathponnan
> 
>



[Responsiveness report] 2013w30 (was: we like dev better then users :( )

2013-08-01 Thread Daan Hoogland
sure, this one allright?

On Fri, Aug 2, 2013 at 12:54 AM, Alex Huang  wrote:
> Hi Daan,
>
> Sorry I meant to subject tag your email so people who's interested in helping 
> can easily get to them.
>
> --Alex
>
>> -Original Message-
>> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
>> Sent: Thursday, August 1, 2013 2:11 PM
>> To: dev
>> Subject: Re: we like dev better then users :(
>>
>> Alex, what do you mean by tag? Most of what I did is my personal judgement,
>> hardly any automation involved.
>>
>> I hope we can give some folow up to this. I think the dev report is useful. 
>> The
>> users report is less useful however. I am lagging a week behind. In most
>> cases people would have answered if they had the time/knowledge earlier.
>>
>> What worries me most is the tone I see in messages on the users list.
>> I report only on messages that are not answered at all. Some others I
>> happened to stumble upon are polemic rants. Of course these are not the
>> 'average' users that will go to a dev list first, before tone down their 
>> mails.
>>
>> I do not know if we are equipped to handle this properly. One thing I can do
>> is find an earlier moment next week to make my report.
>>
>> regards,
>> Daan
>>
>>
>> On Thu, Aug 1, 2013 at 7:24 PM, Kelcey Jamison Damage 
>> wrote:
>> > You can always send them over to IRC where I am. Usually it's easier to
>> handle support in real-time.
>> >
>> > - Original Message -
>> > From: "Alex Huang" 
>> > To: dev@cloudstack.apache.org
>> > Sent: Thursday, August 1, 2013 10:15:08 AM
>> > Subject: RE: we like dev better then users :(
>> >
>> > Daan,
>> >
>> > This is a great service you're providing to the community!  I will go to my
>> management and see if we can lend some support in terms of following up
>> on your list.  Do you want to tag it so if I do get some resources, we have 
>> an
>> easy way to filter in your report?
>> >
>> > --Alex
>> >
>> >> -Original Message-
>> >> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
>> >> Sent: Thursday, August 1, 2013 6:41 AM
>> >> To: dev
>> >> Subject: Re: we like dev better then users :(
>> >>
>> >> Wido, I am not urging you or anybody to keep better track of this. It
>> >> is a marketing issue. That is the only point I am trying to make. I
>> >> am notorious at not reading user lists ever, myself.
>> >>
>> >> DaanOps
>> >>
>> >> On Thu, Aug 1, 2013 at 3:36 PM, Wido den Hollander 
>> >> wrote:
>> >> > On 08/01/2013 03:31 PM, Daan Hoogland wrote:
>> >> >>
>> >> >> I think the following list speaks for itself
>> >> >>
>> >> >
>> >> > Although it's really good that you point this out I took the
>> >> > following decision for myself: I contribute to the project by
>> >> > resolving bugs and writing new features.
>> >> >
>> >> > In my case my colleague (Lennert) is subscribed to the users list
>> >> > and he watches that and sometimes asks me to look to something.
>> >> >
>> >> > For me it's not doable to keep track of both the users and dev list
>> >> > and work on $dayjob
>> >> >
>> >> > It's about shifting priorities and for me the dev list (which is
>> >> > hard
>> >> > enough) is my main priority.
>> >> >
>> >> > Wido
>> >> >
>> >> >
>> >> >> http://markmail.org/message/ap42zplnpenniqtd can't create VM after
>> >> >> upgrade from 3.0.2 to 4,1. Error Code: 533 Error text: Unable to
>> >> >> create a deploymentfor VM by William Jiang
>> >> >> http://markmail.org/message/wxe6oktgtxtvg6uk Setting up
>> networking
>> >> on
>> >> >> single machine by Philip Andrews
>> >> >> http://markmail.org/message/lrenopzjshkzfxbe MuleSoft by Len
>> >> >> Bellemore http://markmail.org/message/vicznsksl5k33uby VPC Issue
>> >> >> with CS 4.1/KVM/Openvswitch by Dinu Arateanu
>> >> >> http://markmail.org/message/nqw3abaplbzgutwz AMI Import
>> questions
>> >> by
>> >> >> Carlos Reategui http://markmail.org/message/ny7wi4hpufe6j7wb
>> >> windows
>> >> >> vm lost static ip config after xe-tools upgrade from 6.0.2 to 6.1
>> >> >> by William Jiang http://markmail.org/message/camfk7jrekuzy2ge
>> >> >> Cloud capacity by Jerry Jiang
>> >> >> http://markmail.org/message/apnzuex65qcijegl
>> >> >> vms hang in expunged state by Valery Ciareszka
>> >> >> http://markmail.org/message/apkldlvxvq2u2yvm few orphan disk on
>> >> >> primary storage (CS v3) by Pierre Benard
>> >> >> http://markmail.org/message/to5zyb3k6z6hd3sg ESXI support by
>> >> >> Chitra Manjunath http://markmail.org/message/23ga4bseph6ruh4x
>> >> >> ClassCastException for Virtual Routers in Zones using Adv
>> >> >> Networking by Boyer, Marc
>> >> >>
>> >> >> regards,
>> >> >> Daan
>> >> >>
>> >> >


RE: How to fix libvirt storage pool refresh issue?

2013-08-01 Thread Alex Huang
So I have very limited knowledge on KVM.  But, from my understanding from 
Edison, we should consider what has to be done to fix this problem once it 
occurs.

- Shutdown all VMs on all hosts that are affected.
- umount the nfs mount point
- Reestablish the storage pool.
- Restart the VMs.

Given how severe these actions are to the end user, I would vote for the file 
lock to ensure it never happens, even if it's slower.

--Alex

> -Original Message-
> From: Wei ZHOU [mailto:ustcweiz...@gmail.com]
> Sent: Tuesday, July 16, 2013 3:35 AM
> To: dev@cloudstack.apache.org
> Subject: Re: How to fix libvirt storage pool refresh issue?
> 
> I agree with Wido.
> 
> Moreover, the file lock will cause performane degrade of VM deployment.
> 
> -Wei
> 
> 
> 2013/7/16 Wido den Hollander 
> 
> > On 07/16/2013 12:27 AM, Marcus Sorensen wrote:
> >
> >> I'm ok with a symptom fix on our end, if the root cause is in
> >> Libvirt we can't do much about that. This is the sort of patch that
> >> tends to get pulled into the regular update cycle of the
> >> distributions, so unless there's more to it and it's not a good fix I
> >> imagine we will see it come through without having to wait for the
> >> next point releases. We still have to support existing users who
> >> might not be running the latest, though, so the symptom fix is
> >> probably ok as a temporary measure.
> >>
> >
> > I'm ok with not calling storagePoolRefresh every time we want a
> > capacity update, since that's also kind of I/O intensive for larger storage
> arrays.
> >
> > However, we should make sure we have a GOOD comment in the code
> about
> > this "fix", since that's the reason I initially removed the old code
> > which invoked "df".
> >
> > I'll see if I can get this libvirt patch into Ubuntu when it hits
> > libvirt upstream, since this bug is really annoying.
> >
> > Wido
> >
> >
> >
> >> On Mon, Jul 15, 2013 at 3:42 PM, Edison Su  wrote:
> >>
> >>> There is a serious issue on KVM(https://issues.apache.org/**
> >>> jira/browse/CLOUDSTACK-
> 2729):
> >>> a libvirt storage pool can disappear on KVM host, it's easy to be
> >>> reproduced in our internal QA environment.
> >>> Wei found the root cause, is on the libvirt:
> >>> "
> >>> This is a libvirt issue. I created a ticket for it.
> >>> https://bugzilla.redhat.com/**show_bug.cgi?id=977706 >>> a.redhat.com/show_bug.cgi?id=977706>
> >>> The patch is very simple.
> >>> https://www.redhat.com/**archives/libvir-list/2013-**July/msg00635.h
> >>> tml >>> tml>
> >>> "
> >>> But it's also introduced by CloudStack, as cloudstack will call
> >>> libvirt storage pool refresh method each time when access the
> >>> storage pool. The code is added by commit:
> >>> 2ffc9907f7b0d371737e39b7649f7a**f23026f5cf,
> >>> about less than one year ago.
> >>>
> >>> As Wei suggested, we can call storage pool refresh only if needed,
> >>> it will mitigate the issue(It's behavior I did on cloudstack
> >>> pre-4.0), but it's only treat the symptom, not the cause.
> >>> Or add a cluster wide lock, only one guy can access storage pool at
> >>> one time, we can add a file lock on NFS primary storage.
> >>> Any idea/feedback on how to fix this KVM issue?
> >>>
> >>>
> >>>
> >>>
> >


RE: Review Request 13072: Print agent host name in logging of agent commands

2013-08-01 Thread Koushik Das
I see your point Marcus.
I felt that accessing the database would be simpler but you are right that 
everyone may not have access to it. Actually the CS logs do mention the host 
names as well but in a different place and based on that you can match the id 
to a name. For e.g. if you look for agent status logs that mentions both id and 
name.

2013-07-29 10:09:47,124 DEBUG [c.c.h.Status] (AgentTaskPool-3:null) 
Transition:[Resource state = Enabled, Agent event = Ping, Host id = 1, name = 
xenserver-kd1]
2013-07-29 10:09:47,136 DEBUG [c.c.h.Status] (AgentTaskPool-3:null) Agent 
status update: [id = 1; name = xenserver-kd1; old status = Up; event = Ping; 
new status = Up; old update count = 78; new update count = 79]

2013-07-29 10:09:47,736 DEBUG [c.c.a.t.Request] (DirectAgent-24:null) Seq 
1-1386348573: Sending  { Cmd , MgmtId: 2546680725505, via: 1, Ver: v1, Flags: 
100011, 
[{"com.cloud.agent.api.StopCommand":{"isProxy":false,"executeInSequence":false,"vmName":"i-2-45-VM","wait":0}}]
 }
2013-07-29 10:09:47,736 DEBUG [c.c.a.t.Request] (DirectAgent-24:null) Seq 
1-1386348573: Executing:  { Cmd , MgmtId: 2546680725505, via: 1, Ver: v1, 
Flags: 100011, 
[{"com.cloud.agent.api.StopCommand":{"isProxy":false,"executeInSequence":false,"vmName":"i-2-45-VM","wait":0}}]
 }


The changes you have made would definitely improve the readability.

-Koushik

From: Marcus Sorensen [mailto:shadow...@gmail.com]
Sent: Thursday, August 01, 2013 7:26 PM
To: Koushik Das
Cc: cloudstack
Subject: Re: Review Request 13072: Print agent host name in logging of agent 
commands


I agree, that would be useful.

The issue im resolving here is that 1) not everyone who has access to look at 
the logs and troubleshoot also has access to (or knows the schema of) the 
database. There might be an issue with a KVM host, but the admin will waste 
time manually hunting down which host the command went to because he has no 
idea what "via:1237" means and 2) even with db access, its a major pain to go 
hunt down the unencrypted db password(because its a long string that's hard to 
memorize), log into the database, run a query, just to know where to continue 
your debugging.

A little background: Most of the people who surf these logs aren't devs. For us 
they are usually devs, but not cloudstack devs. Maybe UI guys or some other 
consumer. It has happened several times where someone comes into my office, 
points out an agent command, and says "any idea where that went?". I pretty 
much have the numbers memorized by now, depending on the zone, so I tell them 
which agent the command went to. Then they ask me where I found that, and when 
I explain that this little "via: 85" means to go log into the db and make an 
SQL query for vm_instance 85, I almost always get some "gee that's useful, how 
was I ever supposed to know that" response.

So I do agree that the correlations you mention would also be good, I disagree 
with the idea that there is not much value in doing this.
On Aug 1, 2013 6:06 AM, "Koushik Das" 
mailto:koushik@citrix.com>> wrote:
This is an automatically generated e-mail. To reply, visit: 
https://reviews.apache.org/r/13072/




The changes look fine but I don't see much value with this as the name can be 
easily identified from the db. I feel the logs are used primarily for debugging 
issues. And one key aspect that is missing currently is the correlation of 
logs. Currently when a API call is made to MS, it traverses through various 
layers in the MS and finally hitting the resource layer and then returns back 
with response. Logs gets generated from each layer but it is not very intuitive 
to relate them to API call. If there is a unique id (some kind of uuid) that 
gets appended to the logs for a specific API call then correlation becomes very 
easy.



I feel adding these kind of correlation would be much more useful.


- Koushik Das


On July 30th, 2013, 5:37 p.m. UTC, Marcus Sorensen wrote:
Review request for cloudstack.
By Marcus Sorensen.

Updated July 30, 2013, 5:37 p.m.
Bugs: CLOUDSTACK-3872
Repository: cloudstack-git
Description

Print agent name when logging Commands sent to VM hosts. See bug description.  
I'm not super familiar with this code, so I'd like someone to look over it and 
verify it's the right thing.


Testing

Tested on KVM zone, need help testing others.


Diffs

  *   core/src/com/cloud/agent/transport/Request.java (b0fa4cc)
  *   server/src/com/cloud/agent/manager/AgentManagerImpl.java (b157838)

View Diff




[Doc] Non Contiguous VLAN Ranges for Review

2013-08-01 Thread Radhika Puthiyetath
Hi,

Non Contiguous VLAN Ranges documentation is ready for review. The doc is 
attached at https://issues.apache.org/jira/browse/CLOUDSTACK-804.

Please see section 11.9.2. Non Contiguous VLAN Ranges (88), and provide your 
feedback.

Regards
-Radhika




RE: [ACS42] Release Status Update: After Code Freeze Next Steps

2013-08-01 Thread Animesh Chaturvedi
Besides doc being allowed during this limited update period, I think tests 
should also be an exception. Any comments?

> -Original Message-
> From: Animesh Chaturvedi [mailto:animesh.chaturv...@citrix.com]
> Sent: Tuesday, July 30, 2013 12:25 PM
> To: dev@cloudstack.apache.org
> Subject: [ACS42] Release Status Update: After Code Freeze Next Steps
> 
> 
> Folks code freeze was on 7/29 and starting today we are moving ACS 42 into
> limited updates in preparation for RC on 8/19. Code changes are now
> limited to fixes to blocker and critical bugs only. I need to follow up on
> doc and translations.
> 
> 
> There is a tremendous effort going on since last couple of weeks to fix
> issues found during the QA cycle. In last week alone 175 new issues were
> created and 250 were resolved. The current unresolved issue count stands
> at 300+ with 60 blocker and critical.
> 
> 
> Given the high number of blocker and critical and that QA is still filing
> many defects I will follow what Chip did for 4.1 [1]. Up until when we cut
> the first RC on (2013-08-19) committers should continue to check in fixes
> to 4.2 branch for blocker and critical issues. Please do any fixes as
> cleanly as possible (i.e., squash related commits and make sure to avoid
> messy merge commits as much as possible).
> 
> 
> For Contributors if you have a fix that needs to go into 4.2, please email
> the list with the subject tag [ACS42] and note the review that contains
> the patch.  I'll pick whichever I can, but will also rely on others with
> commit rights to make it efficient.
> 
> 
> I will review all commits going into that branch, and will revert anything
> that's outside the scope of that I outlined above (unless there is a
> discussion and consensus on this list to include something else).
> 
> There are large number of issues that are resolved but not verified yet.
> Given that the number is huge  with over 300 blocker and critical we need
> to prioritize and verify the ones that were returned by developers as (
> Invalid, Incomplete, CanNotReproduce, Later, NotAProblem) first.  I have
> created a filter [2] to facilitate identifying these issues. This is no
> way means not to verify other issues but it is to close on the ones that
> have the most likelihood of being reopened during verification.
> 
> [1] http://markmail.org/message/qkkxycablpsmogsx
> [2] https://issues.apache.org/jira/issues/#?filter=12324570
> 
> 
> Thanks
> Animesh


RE: [ACS42] Release Status Update: After Code Freeze Next Steps

2013-08-01 Thread Animesh Chaturvedi


> -Original Message-
> From: Animesh Chaturvedi [mailto:animesh.chaturv...@citrix.com]
> Sent: Thursday, August 01, 2013 10:25 PM
> To: dev@cloudstack.apache.org
> Subject: RE: [ACS42] Release Status Update: After Code Freeze Next Steps
> 
> Besides doc being allowed during this limited update period, I think
> tests should also be an exception. Any comments?
[Animesh>] Thanks Prasanna for pointing out

> 
> > -Original Message-
> > From: Animesh Chaturvedi [mailto:animesh.chaturv...@citrix.com]
> > Sent: Tuesday, July 30, 2013 12:25 PM
> > To: dev@cloudstack.apache.org
> > Subject: [ACS42] Release Status Update: After Code Freeze Next Steps
> >
> >
> > Folks code freeze was on 7/29 and starting today we are moving ACS 42
> > into limited updates in preparation for RC on 8/19. Code changes are
> > now limited to fixes to blocker and critical bugs only. I need to
> > follow up on doc and translations.
> >
> >
> > There is a tremendous effort going on since last couple of weeks to
> > fix issues found during the QA cycle. In last week alone 175 new
> > issues were created and 250 were resolved. The current unresolved
> > issue count stands at 300+ with 60 blocker and critical.
> >
> >
> > Given the high number of blocker and critical and that QA is still
> > filing many defects I will follow what Chip did for 4.1 [1]. Up until
> > when we cut the first RC on (2013-08-19) committers should continue to
> > check in fixes to 4.2 branch for blocker and critical issues. Please
> > do any fixes as cleanly as possible (i.e., squash related commits and
> > make sure to avoid messy merge commits as much as possible).
> >
> >
> > For Contributors if you have a fix that needs to go into 4.2, please
> > email the list with the subject tag [ACS42] and note the review that
> > contains the patch.  I'll pick whichever I can, but will also rely on
> > others with commit rights to make it efficient.
> >
> >
> > I will review all commits going into that branch, and will revert
> > anything that's outside the scope of that I outlined above (unless
> > there is a discussion and consensus on this list to include something
> else).
> >
> > There are large number of issues that are resolved but not verified
> yet.
> > Given that the number is huge  with over 300 blocker and critical we
> > need to prioritize and verify the ones that were returned by
> > developers as ( Invalid, Incomplete, CanNotReproduce, Later,
> > NotAProblem) first.  I have created a filter [2] to facilitate
> > identifying these issues. This is no way means not to verify other
> > issues but it is to close on the ones that have the most likelihood of
> being reopened during verification.
> >
> > [1] http://markmail.org/message/qkkxycablpsmogsx
> > [2] https://issues.apache.org/jira/issues/#?filter=12324570
> >
> >
> > Thanks
> > Animesh


Re: How to enforce data disk selection

2013-08-01 Thread Mike Tutkowski
Could you provide a little more info about where in the GUI you'd like to
enforce the selection of a data disk? When kicking off a VM instance
perhaps?


On Thu, Aug 1, 2013 at 4:03 PM, Musayev, Ilya  wrote:

> How would one enforce data disk selection?
>
> I don't want to leave data disk blank in UI.
>



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloud
*™*


RE: [ACS42] Release Status Update: After Code Freeze Next Steps

2013-08-01 Thread Radhika Puthiyetath
Hi,

I shall give you the complete picture on my doc tasks by EOD today. 

You will get a quick update on my doc progress at  
https://issues.apache.org/jira/issues/?filter=-1&jql=project%20%3D%20CLOUDSTACK%20AND%20fixVersion%20%3D%20%224.2.0%22%20AND%20assignee%20in%20(currentUser())%20ORDER%20BY%20updatedDate%20DESC

You can start localizing the following:

GSLB (CLOUDSTACK-653)
Document Dedicated Resources: Public IP Addresses and VLANs per Tenant 
(CLOUDSTACK-704)
Document limiting resources to domain/accounts (Dedicated Resources) 
(CLOUDSTACK-713)
Document user provided hostname to be specified in vCenter instead of 
CloudStack generated name (CLOUDSTACK-778)
Documentation for nTier Apps 2.0 : Internal LB (CLOUDSTACK-770)
Document Multiple IP Address per NIC (CLOUDSTACK-24)
Document new default password encoding mechanism, SHA256Salt (CLOUDSTACK-1734)
Document isolation in advanced zones using PVLAN (CLOUDSTACK-1456)
Document ability to delete events and alerts (CLOUDSTACK-874)
Document the ability to use multiple IP ranges (CLOUDSTACK-702)
Document ability to use only a portion of the network (CLOUDSTACK-705)
Documentation for the add/remove networks (CLOUDSTACK-645)
Doc- Support Multiple Subnets per VLAN (CLOUDSTACK-788)
Document the ability to use multiple IP ranges (CLOUDSTACK-702)


Regards
-Radhika

-Original Message-
From: Go Chiba [mailto:go.ch...@gmail.com] 
Sent: Thursday, August 01, 2013 2:54 PM
To: dev@cloudstack.apache.org
Subject: Re: [ACS42] Release Status Update: After Code Freeze Next Steps

Thanks Animesh, I'll be checking open tasks too.


On Thu, Aug 1, 2013 at 2:49 AM, Animesh Chaturvedi < 
animesh.chaturv...@citrix.com> wrote:

>
>
> > -Original Message-
> > From: Chip Childers [mailto:chip.child...@sungard.com]
> > Sent: Wednesday, July 31, 2013 8:44 AM
> > To: dev@cloudstack.apache.org
> > Subject: Re: [ACS42] Release Status Update: After Code Freeze Next 
> > Steps
> >
> > On Thu, Aug 01, 2013 at 12:41:16AM +0900, Go Chiba wrote:
> > > Does it already fixed all 4.2 docs?
> > > If yes, I'd like to update it to transifex to go ahead doc
> > globalization...
> >
> > I'm not sure.
> >
> > Animesh? Docs team?
> [Animesh>] I am  following up with doc team I see a bunch of doc sub 
> tasks still open.
> >
> > >
> > >
> > > On Wed, Jul 31, 2013 at 11:20 PM, Chip Childers
> > > wrote:
> > >
> > > > On Wed, Jul 31, 2013 at 10:33:51AM +0530, Prasanna Santhanam wrote:
> > > > > On Tue, Jul 30, 2013 at 10:03:08PM +, Animesh Chaturvedi
> > wrote:
> > > > > >
> > > > > >
> > > > > > > -Original Message-
> > > > > > > From: Alex Huang [mailto:alex.hu...@citrix.com]
> > > > > > > Sent: Tuesday, July 30, 2013 2:06 PM
> > > > > > > To: dev@cloudstack.apache.org
> > > > > > > Subject: RE: [ACS42] Release Status Update: After Code 
> > > > > > > Freeze Next
> > > > Steps
> > > > > > >
> > > > > > > > The best type of commit for keeping things clean is a
> > cherry-pick.
> > > > > > > > Merging into the release branch is messy to track as the RM.
> > > > > > > >
> > > > > > >
> > > > > > > That should be a rule for release branches after code freeze.
> > > > > > >
> > > > > > > --Alex
> > > > > > [Animesh>] Thanks for clarifying, we will follow that for 
> > > > > > 4.2
> > > > >
> > > > > Also can we do a git cherry-pick -x? It lists the original 
> > > > > commit from which the cherry was picked. Without it git branch 
> > > > > --contains on a commit id returns the wrong branch the commit 
> > > > > was brought in
> > from.
> > > >
> > > > Ah...  smart idea!
> > > >
> > >
> > >
> > >
> > > --
> > > 千葉 豪  Go Chiba
> > > E-mail:go.ch...@gmail.com
>



--
千葉 豪  Go Chiba
E-mail:go.ch...@gmail.com


Re: How to create Port Forwarding rule for VM through UI?

2013-08-01 Thread Jayapal Reddy Uradi
Hi Gaurav,

Port forwarding to work you need to create firewall rule also.

Thanks,
Jayapal

On 01-Aug-2013, at 5:38 PM, Daan Hoogland  wrote:

> network ->  -> IP Adresses ->  ->
> configuration -> Port Forwarding
> 
> On Mon, Jul 22, 2013 at 12:09 PM, Gaurav Aradhye
>  wrote:
>> Hi all,
>> 
>> Can anybody tell me how to create port forwarding rule for a specific vm
>> through Cloudstack UI?
>> You can just mention the navigational steps.
>> 
>> Regards,
>> Gaurav



Re: How to fix libvirt storage pool refresh issue?

2013-08-01 Thread Wei ZHOU
Alex,

Exactly.

We can also use Enable Maintenance -> umount nfs point -> restart
cloudstack-agent -> Cancel Maintenance to solve this issue.

-Wei


2013/8/2 Alex Huang 

> So I have very limited knowledge on KVM.  But, from my understanding from
> Edison, we should consider what has to be done to fix this problem once it
> occurs.
>
> - Shutdown all VMs on all hosts that are affected.
> - umount the nfs mount point
> - Reestablish the storage pool.
> - Restart the VMs.
>
> Given how severe these actions are to the end user, I would vote for the
> file lock to ensure it never happens, even if it's slower.
>
> --Alex
>
> > -Original Message-
> > From: Wei ZHOU [mailto:ustcweiz...@gmail.com]
> > Sent: Tuesday, July 16, 2013 3:35 AM
> > To: dev@cloudstack.apache.org
> > Subject: Re: How to fix libvirt storage pool refresh issue?
> >
> > I agree with Wido.
> >
> > Moreover, the file lock will cause performane degrade of VM deployment.
> >
> > -Wei
> >
> >
> > 2013/7/16 Wido den Hollander 
> >
> > > On 07/16/2013 12:27 AM, Marcus Sorensen wrote:
> > >
> > >> I'm ok with a symptom fix on our end, if the root cause is in
> > >> Libvirt we can't do much about that. This is the sort of patch that
> > >> tends to get pulled into the regular update cycle of the
> > >> distributions, so unless there's more to it and it's not a good fix I
> > >> imagine we will see it come through without having to wait for the
> > >> next point releases. We still have to support existing users who
> > >> might not be running the latest, though, so the symptom fix is
> > >> probably ok as a temporary measure.
> > >>
> > >
> > > I'm ok with not calling storagePoolRefresh every time we want a
> > > capacity update, since that's also kind of I/O intensive for larger
> storage
> > arrays.
> > >
> > > However, we should make sure we have a GOOD comment in the code
> > about
> > > this "fix", since that's the reason I initially removed the old code
> > > which invoked "df".
> > >
> > > I'll see if I can get this libvirt patch into Ubuntu when it hits
> > > libvirt upstream, since this bug is really annoying.
> > >
> > > Wido
> > >
> > >
> > >
> > >> On Mon, Jul 15, 2013 at 3:42 PM, Edison Su 
> wrote:
> > >>
> > >>> There is a serious issue on KVM(https://issues.apache.org/**
> > >>> jira/browse/CLOUDSTACK-
> > 2729):
> > >>> a libvirt storage pool can disappear on KVM host, it's easy to be
> > >>> reproduced in our internal QA environment.
> > >>> Wei found the root cause, is on the libvirt:
> > >>> "
> > >>> This is a libvirt issue. I created a ticket for it.
> > >>> https://bugzilla.redhat.com/**show_bug.cgi?id=977706 > >>> a.redhat.com/show_bug.cgi?id=977706>
> > >>> The patch is very simple.
> > >>> https://www.redhat.com/**archives/libvir-list/2013-**July/msg00635.h
> > >>> tml > >>> tml>
> > >>> "
> > >>> But it's also introduced by CloudStack, as cloudstack will call
> > >>> libvirt storage pool refresh method each time when access the
> > >>> storage pool. The code is added by commit:
> > >>> 2ffc9907f7b0d371737e39b7649f7a**f23026f5cf,
> > >>> about less than one year ago.
> > >>>
> > >>> As Wei suggested, we can call storage pool refresh only if needed,
> > >>> it will mitigate the issue(It's behavior I did on cloudstack
> > >>> pre-4.0), but it's only treat the symptom, not the cause.
> > >>> Or add a cluster wide lock, only one guy can access storage pool at
> > >>> one time, we can add a file lock on NFS primary storage.
> > >>> Any idea/feedback on how to fix this KVM issue?
> > >>>
> > >>>
> > >>>
> > >>>
> > >
>


RE: [Doc] Dedicated Resources: Public IPs and VLANs per Account is Ready

2013-08-01 Thread Likitha Shetty
I just have 2 comments,



1. Since this feature allows the admin to assign (and release) the IP addresses 
and VLANs only to an account, not both domain and account we need to modify the 
introduction accordingly.



2. And could you also add the following to section 15.8,



If an account has consumed all the VLANs and IPs dedicated to it, the account 
can acquire the 2 resources from the system. Cloudstack provides the ROOT admin 
with 2 configuration parameter to modify this default behavior - 
use.system.public.ips and use.system.guest.vlans.

The 2 global configs allow the ROOT admin to disallow an account from acquiring 
public IPs and guest VLANs from the system if the account has dedicated 
resources and these dedicated resources have all been consumed.

Both these configurations are configurable at the account level too. 
(https://issues.apache.org/jira/browse/CLOUDSTACK-3011)



Everything else looks good.



Thanks,

Likitha

From: Radhika Puthiyetath
Sent: Thursday, August 01, 2013 3:51 PM
To: us...@cloudstack.apache.org; dev@cloudstack.apache.org; Abhinav Roy; 
Likitha Shetty
Subject: [Doc] Dedicated Resources: Public IPs and VLANs per Account is Ready

Hi,

Dedicated Resources: Public IPs and VLANs per Account is Ready documentation is 
ready for review. The doc is attached at 
https://issues.apache.org/jira/browse/CLOUDSTACK-817

Please see section 15.8. Reserving Public IP Addresses and VLANs Per Account 
(132), and provide your feedback.

Regards
-Radhika




Re: Review Request 13072: Print agent host name in logging of agent commands

2013-08-01 Thread Chiradeep Vittal
This of course introduces an extra DB call during EVERY agent
communication. 
If there was a cache, not a big deal, but as it so happens, there isn't
one.

On 8/1/13 10:10 PM, "Koushik Das"  wrote:

>I see your point Marcus.
>I felt that accessing the database would be simpler but you are right
>that everyone may not have access to it. Actually the CS logs do mention
>the host names as well but in a different place and based on that you can
>match the id to a name. For e.g. if you look for agent status logs that
>mentions both id and name.
>
>2013-07-29 10:09:47,124 DEBUG [c.c.h.Status] (AgentTaskPool-3:null)
>Transition:[Resource state = Enabled, Agent event = Ping, Host id = 1,
>name = xenserver-kd1]
>2013-07-29 10:09:47,136 DEBUG [c.c.h.Status] (AgentTaskPool-3:null) Agent
>status update: [id = 1; name = xenserver-kd1; old status = Up; event =
>Ping; new status = Up; old update count = 78; new update count = 79]
>
>2013-07-29 10:09:47,736 DEBUG [c.c.a.t.Request] (DirectAgent-24:null) Seq
>1-1386348573: Sending  { Cmd , MgmtId: 2546680725505, via: 1, Ver: v1,
>Flags: 100011, 
>[{"com.cloud.agent.api.StopCommand":{"isProxy":false,"executeInSequence":f
>alse,"vmName":"i-2-45-VM","wait":0}}] }
>2013-07-29 10:09:47,736 DEBUG [c.c.a.t.Request] (DirectAgent-24:null) Seq
>1-1386348573: Executing:  { Cmd , MgmtId: 2546680725505, via: 1, Ver: v1,
>Flags: 100011, 
>[{"com.cloud.agent.api.StopCommand":{"isProxy":false,"executeInSequence":f
>alse,"vmName":"i-2-45-VM","wait":0}}] }
>
>
>The changes you have made would definitely improve the readability.
>
>-Koushik
>
>From: Marcus Sorensen [mailto:shadow...@gmail.com]
>Sent: Thursday, August 01, 2013 7:26 PM
>To: Koushik Das
>Cc: cloudstack
>Subject: Re: Review Request 13072: Print agent host name in logging of
>agent commands
>
>
>I agree, that would be useful.
>
>The issue im resolving here is that 1) not everyone who has access to
>look at the logs and troubleshoot also has access to (or knows the schema
>of) the database. There might be an issue with a KVM host, but the admin
>will waste time manually hunting down which host the command went to
>because he has no idea what "via:1237" means and 2) even with db access,
>its a major pain to go hunt down the unencrypted db password(because its
>a long string that's hard to memorize), log into the database, run a
>query, just to know where to continue your debugging.
>
>A little background: Most of the people who surf these logs aren't devs.
>For us they are usually devs, but not cloudstack devs. Maybe UI guys or
>some other consumer. It has happened several times where someone comes
>into my office, points out an agent command, and says "any idea where
>that went?". I pretty much have the numbers memorized by now, depending
>on the zone, so I tell them which agent the command went to. Then they
>ask me where I found that, and when I explain that this little "via: 85"
>means to go log into the db and make an SQL query for vm_instance 85, I
>almost always get some "gee that's useful, how was I ever supposed to
>know that" response.
>
>So I do agree that the correlations you mention would also be good, I
>disagree with the idea that there is not much value in doing this.
>On Aug 1, 2013 6:06 AM, "Koushik Das"
>mailto:koushik@citrix.com>> wrote:
>This is an automatically generated e-mail. To reply, visit:
>https://reviews.apache.org/r/13072/
>
>
>
>
>The changes look fine but I don't see much value with this as the name
>can be easily identified from the db. I feel the logs are used primarily
>for debugging issues. And one key aspect that is missing currently is the
>correlation of logs. Currently when a API call is made to MS, it
>traverses through various layers in the MS and finally hitting the
>resource layer and then returns back with response. Logs gets generated
>from each layer but it is not very intuitive to relate them to API call.
>If there is a unique id (some kind of uuid) that gets appended to the
>logs for a specific API call then correlation becomes very easy.
>
>
>
>I feel adding these kind of correlation would be much more useful.
>
>
>- Koushik Das
>
>
>On July 30th, 2013, 5:37 p.m. UTC, Marcus Sorensen wrote:
>Review request for cloudstack.
>By Marcus Sorensen.
>
>Updated July 30, 2013, 5:37 p.m.
>Bugs: CLOUDSTACK-3872
>Repository: cloudstack-git
>Description
>
>Print agent name when logging Commands sent to VM hosts. See bug
>description.  I'm not super familiar with this code, so I'd like someone
>to look over it and verify it's the right thing.
>
>
>Testing
>
>Tested on KVM zone, need help testing others.
>
>
>Diffs
>
>  *   core/src/com/cloud/agent/transport/Request.java (b0fa4cc)
>  *   server/src/com/cloud/agent/manager/AgentManagerImpl.java (b157838)
>
>View Diff
>
>



  1   2   >